Re: [PATCH wayland 4/4] tests: add code, public-code and private-code tests

[Emil Velikov]

Hi Pekka,

Thanks for having a look!

On 22 February 2018 at 10:26, Pekka Paalanen  wrote:

>> +# The existing "code" must produce result identical to "public-code"
>> +generate_and_compare "code" "small.xml" "small-public-code.c"
>> +generate_and_compare "public-code" "small.xml" "small-public-code.c"
>> +generate_and_compare "private-code" "small.xml" "small-private-code.c"
>>  exit $RETCODE
>
> Hi Emil,
>
> is there a reason why you introduced small-public-code.c as a new
> expected output file? It is by definition identical to small-code.c.
> Even the generate_and_compare line is identical.
>

I opted to have all three combinations split out and distinct from the
existing tests.
One would do something like the following. I don't have strong
preference, as long as we have some tests.

# The existing "code" must produce result identical to "public-code"
generate_and_compare "code" "small.xml" "small-code.c"
generate_and_compare "public-code" "small.xml" "small-code.c"
generate_and_compare "private-code" "small.xml" "small-private-code.c"

Updated patch coming in a second - feel free to pick the more
favourable solution.

Thanks
Emil
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland 4/4] tests: add code, public-code and private-code tests

[Pekka Paalanen]

On Fri, 16 Feb 2018 16:22:33 +
Emil Velikov  wrote:

> From: Emil Velikov 
> 
> First one is deprecated in favour of the second option.
> 
> The latter is newly introduced and annotates the generated symbols
> accordingly.
> 
> Signed-off-by: Emil Velikov 
> ---
>  Makefile.am |  4 ++-
>  tests/data/small-private-code.c | 71 
> +
>  tests/data/small-public-code.c  | 61 +++
>  tests/scanner-test.sh   |  4 +++
>  4 files changed, 139 insertions(+), 1 deletion(-)
>  create mode 100644 tests/data/small-private-code.c
>  create mode 100644 tests/data/small-public-code.c
> 
> diff --git a/Makefile.am b/Makefile.am
> index 4ffce0d..1a0b1ec 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -299,7 +299,9 @@ EXTRA_DIST += tests/scanner-test.sh   
> \
>   tests/data/small-server.h   \
>   tests/data/small-code-core.c\
>   tests/data/small-client-core.h  \
> - tests/data/small-server-core.h
> + tests/data/small-server-core.h  \
> + tests/data/small-public-code.c  \
> + tests/data/small-private-code.c
>  
>  tests/scanner-test.sh: $(top_builddir)/wayland-scanner
>  

> diff --git a/tests/scanner-test.sh b/tests/scanner-test.sh
> index 7854b86..4d2b42d 100755
> --- a/tests/scanner-test.sh
> +++ b/tests/scanner-test.sh
> @@ -48,4 +48,8 @@ generate_and_compare "-c code" "small.xml" 
> "small-code-core.c"
>  generate_and_compare "-c client-header" "small.xml" "small-client-core.h"
>  generate_and_compare "-c server-header" "small.xml" "small-server-core.h"
>  
> +# The existing "code" must produce result identical to "public-code"
> +generate_and_compare "code" "small.xml" "small-public-code.c"
> +generate_and_compare "public-code" "small.xml" "small-public-code.c"
> +generate_and_compare "private-code" "small.xml" "small-private-code.c"
>  exit $RETCODE

Hi Emil,

is there a reason why you introduced small-public-code.c as a new
expected output file? It is by definition identical to small-code.c.
Even the generate_and_compare line is identical.

Other than that, looks good to me. Nice work!


Thanks,
pq


pgpu0Gy9LIPB0.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel