[webkit-changes] [295702] trunk/Source/WebKit/UIProcess/API/Cocoa/ _WKWebAuthenticationPanel.mm

2022-06-21 Thread j_pascoe
Title: [295702] trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm Revision 295702 Author j_pas...@apple.com Date 2022-06-21 16:51:24 -0700 (Tue, 21 Jun 2022) Log Message [WebAuthn] Fix crash when making assertions https://bugs.webkit.org/show_bug.cgi?id=241814 rdar://95

[webkit-changes] [295695] trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

2022-06-21 Thread j_pascoe
Title: [295695] trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Revision 295695 Author j_pas...@apple.com Date 2022-06-21 15:34:05 -0700 (Tue, 21 Jun 2022) Log Message Only support downloading previews in captive portal mode https://bugs.webkit.org/show_bug.cgi?id=241741 Reviewed by Bren

[webkit-changes] [295694] trunk

2022-06-21 Thread j_pascoe
Title: [295694] trunk Revision 295694 Author j_pas...@apple.com Date 2022-06-21 15:11:33 -0700 (Tue, 21 Jun 2022) Log Message NotificationEventEnabled should be enabled macOS Ventura+ https://bugs.webkit.org/show_bug.cgi?id=241605 rdar://94441142 Reviewed by Alex Christensen. * Source/W

[webkit-changes] [295691] trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

2022-06-21 Thread j_pascoe
Title: [295691] trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp Revision 295691 Author j_pas...@apple.com Date 2022-06-21 14:50:42 -0700 (Tue, 21 Jun 2022) Log Message Disable system preview in captive portal mode https://bugs.webkit.org/show_bug.cgi?id=241739 rdar://90563679 Reviewed

[webkit-changes] [295690] trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp

2022-06-21 Thread j_pascoe
Title: [295690] trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp Revision 295690 Author j_pas...@apple.com Date 2022-06-21 14:35:26 -0700 (Tue, 21 Jun 2022) Log Message Use PageIdentifier, not WebPageProxy's identifier for WKPageGetIdentifier https://bugs.webkit.org/show_bug.cgi?id=241701 r

[webkit-changes] [295641] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/ LocalAuthenticator.mm

2022-06-17 Thread j_pascoe
Title: [295641] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm Revision 295641 Author j_pas...@apple.com Date 2022-06-17 11:57:08 -0700 (Fri, 17 Jun 2022) Log Message [WebAuthn] Upgrading a legacy platform credential to a passkey does not delete the legacy cre

[webkit-changes] [295617] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/ LocalAuthenticator.mm

2022-06-16 Thread j_pascoe
Title: [295617] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm Revision 295617 Author j_pas...@apple.com Date 2022-06-16 16:52:58 -0700 (Thu, 16 Jun 2022) Log Message [WebAuthn] Stop using decidePolicyForLocalAuthenticator https://bugs.webkit.org/show_bug.cgi?

[webkit-changes] [295616] trunk/Source

2022-06-16 Thread j_pascoe
Title: [295616] trunk/Source Revision 295616 Author j_pas...@apple.com Date 2022-06-16 16:37:37 -0700 (Thu, 16 Jun 2022) Log Message [WebAuthn] Rename cable transport to hybrid https://bugs.webkit.org/show_bug.cgi?id=241691 rdar://problem/95312126 Reviewed by Brent Fulgham. This transpo

[webkit-changes] [295506] trunk/Source

2022-06-13 Thread j_pascoe
Title: [295506] trunk/Source Revision 295506 Author j_pas...@apple.com Date 2022-06-13 17:21:10 -0700 (Mon, 13 Jun 2022) Log Message [WebAuthn] CTAP2_ERR_USER_ACTION_TIMEOUT isn't handled properly https://bugs.webkit.org/show_bug.cgi?id=241565 rdar://95040155 Reviewed by Brent Fulgham.

[webkit-changes] [295407] trunk/Source

2022-06-08 Thread j_pascoe
Title: [295407] trunk/Source Revision 295407 Author j_pas...@apple.com Date 2022-06-08 17:55:13 -0700 (Wed, 08 Jun 2022) Log Message [WebAuthn] Support credProps extension and refactor extension handling https://bugs.webkit.org/show_bug.cgi?id=241199 rdar://90281799 Reviewed by Brent Ful

[webkit-changes] [295070] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/ WebAuthenticatorCoordinatorProxy.mm

2022-05-31 Thread j_pascoe
Title: [295070] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Revision 295070 Author j_pas...@apple.com Date 2022-05-31 15:24:11 -0700 (Tue, 31 May 2022) Log Message [WebAuthn][ios] weakThis not checked before clearing ASCProxy https://bugs.webk

[webkit-changes] [294975] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ TestSOAuthorization.mm

2022-05-27 Thread j_pascoe
Title: [294975] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm Revision 294975 Author j_pas...@apple.com Date 2022-05-27 18:46:33 -0700 (Fri, 27 May 2022) Log Message [ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout https:/

[webkit-changes] [294950] trunk/Source

2022-05-27 Thread j_pascoe
Title: [294950] trunk/Source Revision 294950 Author j_pas...@apple.com Date 2022-05-27 13:14:24 -0700 (Fri, 27 May 2022) Log Message [WebAuthn] Forward declare ASC SPI for internal needs. https://bugs.webkit.org/show_bug.cgi?id=240928 rdar://problem/93930713 Reviewed by Brent Fulgham. T

[webkit-changes] [294812] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ _WKWebAuthenticationPanel.mm

2022-05-25 Thread j_pascoe
Title: [294812] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Revision 294812 Author j_pas...@apple.com Date 2022-05-25 11:33:57 -0700 (Wed, 25 May 2022) Log Message REGRESSION (r294434): [ iOS ] TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredenti

[webkit-changes] [294434] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ _WKWebAuthenticationPanel.mm

2022-05-18 Thread j_pascoe
Title: [294434] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Revision 294434 Author j_pas...@apple.com Date 2022-05-18 14:28:09 -0700 (Wed, 18 May 2022) Log Message REGRESSION (442fcb1ea6f?): TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential

[webkit-changes] [294332] trunk

2022-05-17 Thread j_pascoe
Title: [294332] trunk Revision 294332 Author j_pas...@apple.com Date 2022-05-17 12:09:56 -0700 (Tue, 17 May 2022) Log Message [WebAuthn] Add SPI to update platform credential's displayName https://bugs.webkit.org/show_bug.cgi?id=240471 Reviewed by Brent Fulgham. * Tools/TestWebKitAPI/T

[webkit-changes] [294331] trunk

2022-05-17 Thread j_pascoe
Title: [294331] trunk Revision 294331 Author j_pas...@apple.com Date 2022-05-17 12:02:27 -0700 (Tue, 17 May 2022) Log Message [WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator https://bugs.webkit.org/show_bug.cgi?id=240459 Reviewed by Brent Fulgham.

[webkit-changes] [294242] trunk/Tools

2022-05-16 Thread j_pascoe
Title: [294242] trunk/Tools Revision 294242 Author j_pas...@apple.com Date 2022-05-16 10:48:17 -0700 (Mon, 16 May 2022) Log Message (REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout) https://bugs.webkit.org/show_bug.cg

[webkit-changes] [294241] trunk/Source/WebKit

2022-05-16 Thread j_pascoe
Title: [294241] trunk/Source/WebKit Revision 294241 Author j_pas...@apple.com Date 2022-05-16 10:43:08 -0700 (Mon, 16 May 2022) Log Message REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing https://bugs.webkit.org/show_bug.cgi?id=240406

[webkit-changes] [294135] trunk/Source/WebCore

2022-05-12 Thread j_pascoe
Title: [294135] trunk/Source/WebCore Revision 294135 Author j_pas...@apple.com Date 2022-05-12 18:02:49 -0700 (Thu, 12 May 2022) Log Message [WebAuthn] Remove document focus requirement for conditional mediation requests https://bugs.webkit.org/show_bug.cgi?id=240361 rdar://problem/932010

[webkit-changes] [294122] trunk/Source

2022-05-12 Thread j_pascoe
Title: [294122] trunk/Source Revision 294122 Author j_pas...@apple.com Date 2022-05-12 14:51:58 -0700 (Thu, 12 May 2022) Log Message [WebAuthn] Include backup state in authenticatorData https://bugs.webkit.org/show_bug.cgi?id=240353 rdar://problem/93191958 Reviewed by Brent Fulgham. Sou

[webkit-changes] [293907] trunk/Source/WebKit

2022-05-06 Thread j_pascoe
Title: [293907] trunk/Source/WebKit Revision 293907 Author j_pas...@apple.com Date 2022-05-06 10:59:21 -0700 (Fri, 06 May 2022) Log Message [WebAuthn] Get rid of ASCAgentProxy instance after success/error/cancel https://bugs.webkit.org/show_bug.cgi?id=240143 rdar://problem/92825715 Revie

[webkit-changes] [293786] trunk/Source/WebKit

2022-05-04 Thread j_pascoe
Title: [293786] trunk/Source/WebKit Revision 293786 Author j_pas...@apple.com Date 2022-05-04 13:28:40 -0700 (Wed, 04 May 2022) Log Message [WebAuthn] Remove user gesture requirement for mediation=conditional assertions https://bugs.webkit.org/show_bug.cgi?id=240038 rdar://92137603 Revie

[webkit-changes] [293433] trunk/Source/WebKit

2022-04-26 Thread j_pascoe
Title: [293433] trunk/Source/WebKit Revision 293433 Author j_pas...@apple.com Date 2022-04-26 11:16:52 -0700 (Tue, 26 Apr 2022) Log Message [WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable https://bugs.webkit.org/show_bug.cgi?id=239746 rdar://91981865

[webkit-changes] [293432] trunk/Source/WebCore

2022-04-26 Thread j_pascoe
Title: [293432] trunk/Source/WebCore Revision 293432 Author j_pas...@apple.com Date 2022-04-26 11:09:57 -0700 (Tue, 26 Apr 2022) Log Message [WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup" https://bugs.webkit.org/show_bug.cgi?id=235894 rdar://88104045 Reviewed by B

[webkit-changes] [292913] trunk

2022-04-15 Thread j_pascoe
Title: [292913] trunk Revision 292913 Author j_pas...@apple.com Date 2022-04-15 10:38:42 -0700 (Fri, 15 Apr 2022) Log Message Source/WebCore: [WebAuthn] Implement getTransports() and getAuthenticatorData() on AuthenticatorAttestationResponse https://bugs.webkit.org/show_bug.cgi?id=238966

[webkit-changes] [292710] trunk/Source/WebKit

2022-04-11 Thread j_pascoe
Title: [292710] trunk/Source/WebKit Revision 292710 Author j_pas...@apple.com Date 2022-04-11 09:18:54 -0700 (Mon, 11 Apr 2022) Log Message [WebAuthn] Ensure requestPin callback on main thread https://bugs.webkit.org/show_bug.cgi?id=238962 rdar://problem/91446051 Reviewed by Brent Fulgha

[webkit-changes] [292593] trunk/Source/WebKit

2022-04-07 Thread j_pascoe
Title: [292593] trunk/Source/WebKit Revision 292593 Author j_pas...@apple.com Date 2022-04-07 22:40:06 -0700 (Thu, 07 Apr 2022) Log Message [WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators https://bugs.webkit.org/show_bug.cgi?id=238814 rdar:

[webkit-changes] [292508] trunk

2022-04-06 Thread j_pascoe
Title: [292508] trunk Revision 292508 Author j_pas...@apple.com Date 2022-04-06 14:57:52 -0700 (Wed, 06 Apr 2022) Log Message Fix expected, actual links for variant-based imported wpt tests https://bugs.webkit.org/show_bug.cgi?id=238832 rdar://problem/91313891 Reviewed by Brent Fulgham.

[webkit-changes] [292495] trunk/LayoutTests

2022-04-06 Thread j_pascoe
Title: [292495] trunk/LayoutTests Revision 292495 Author j_pas...@apple.com Date 2022-04-06 12:44:10 -0700 (Wed, 06 Apr 2022) Log Message pbkdf2.https.any.worker.html fails on WPE, GTK2 ports https://bugs.webkit.org/show_bug.cgi?id=238885 Unreviewed test gardening. * platform/gtk/TestE

[webkit-changes] [291988] trunk/Source/WebKit

2022-03-28 Thread j_pascoe
Title: [291988] trunk/Source/WebKit Revision 291988 Author j_pas...@apple.com Date 2022-03-28 13:58:18 -0700 (Mon, 28 Mar 2022) Log Message Adopt ASCPublicKeyCredentialCreationOptions's residentKeyPreference https://bugs.webkit.org/show_bug.cgi?id=238387 rdar://problem/90845393 Reviewed

[webkit-changes] [291882] trunk

2022-03-25 Thread j_pascoe
Title: [291882] trunk Revision 291882 Author j_pas...@apple.com Date 2022-03-25 13:16:29 -0700 (Fri, 25 Mar 2022) Log Message [WebAuthn] Maintain last modification time separate from last used time for platform credentials https://bugs.webkit.org/show_bug.cgi?id=238293 rdar://90655676 Re

[webkit-changes] [291761] trunk/Source/WebKit

2022-03-23 Thread j_pascoe
Title: [291761] trunk/Source/WebKit Revision 291761 Author j_pas...@apple.com Date 2022-03-23 12:24:00 -0700 (Wed, 23 Mar 2022) Log Message [WebAuthn] Specify correct ASCPublicKeyCredentialKind in configureAssertionOptions https://bugs.webkit.org/show_bug.cgi?id=238272 rdar://problem/9071

[webkit-changes] [291625] trunk

2022-03-22 Thread j_pascoe
Title: [291625] trunk Revision 291625 Author j_pas...@apple.com Date 2022-03-22 10:12:15 -0700 (Tue, 22 Mar 2022) Log Message [WebAuthn] Pass along timeout to ASA and ignore timeout for conditional mediation requests https://bugs.webkit.org/show_bug.cgi?id=238147 rdar://90509464 Reviewed

[webkit-changes] [291624] trunk/Source

2022-03-22 Thread j_pascoe
Title: [291624] trunk/Source Revision 291624 Author j_pas...@apple.com Date 2022-03-22 09:14:25 -0700 (Tue, 22 Mar 2022) Log Message [WebAuthn] Support getAssertion for virtual HID authenticators https://bugs.webkit.org/show_bug.cgi?id=238154 rdar://problem/90593150 Reviewed by Brent Ful

[webkit-changes] [291491] trunk

2022-03-18 Thread j_pascoe
Title: [291491] trunk Revision 291491 Author j_pas...@apple.com Date 2022-03-18 12:11:11 -0700 (Fri, 18 Mar 2022) Log Message Trigger PDF download in captive portal mode instead of using PDF viewer https://bugs.webkit.org/show_bug.cgi?id=237245 rdar://problem/89525531 Reviewed by Chris D

[webkit-changes] [291423] trunk/Source

2022-03-17 Thread j_pascoe
Title: [291423] trunk/Source Revision 291423 Author j_pas...@apple.com Date 2022-03-17 11:28:13 -0700 (Thu, 17 Mar 2022) Log Message [WebAuthn] Support makeCredential for virtual HID authenticators https://bugs.webkit.org/show_bug.cgi?id=237984 rdar://problem/90393676 Reviewed by Brent F

[webkit-changes] [291321] trunk/Source/WebKit

2022-03-15 Thread j_pascoe
Title: [291321] trunk/Source/WebKit Revision 291321 Author j_pas...@apple.com Date 2022-03-15 16:23:54 -0700 (Tue, 15 Mar 2022) Log Message [WebAuthn] Mock UI interactions whenever virtual authenticators are in use. https://bugs.webkit.org/show_bug.cgi?id=237856 rdar://problem/90274854 R

[webkit-changes] [291196] trunk/Source/WebKit

2022-03-11 Thread j_pascoe
Title: [291196] trunk/Source/WebKit Revision 291196 Author j_pas...@apple.com Date 2022-03-11 15:30:11 -0800 (Fri, 11 Mar 2022) Log Message [WebAuthn] Unreviewed build fix after r291177 https://bugs.webkit.org/show_bug.cgi?id=237797 rdar://problem/90183881 Remove unused move that is brea

[webkit-changes] [291177] trunk/Source/WebKit

2022-03-11 Thread j_pascoe
Title: [291177] trunk/Source/WebKit Revision 291177 Author j_pas...@apple.com Date 2022-03-11 10:25:39 -0800 (Fri, 11 Mar 2022) Log Message [WebAuthn] Cancel running operations in ASA on navigation https://bugs.webkit.org/show_bug.cgi?id=237452 rdar://problem/89781990 Reviewed by Brent F

[webkit-changes] [291176] trunk

2022-03-11 Thread j_pascoe
Title: [291176] trunk Revision 291176 Author j_pas...@apple.com Date 2022-03-11 09:49:14 -0800 (Fri, 11 Mar 2022) Log Message [WebAuthn] Support authenticatorSelection.residentKey ResidentKeyRequirement https://bugs.webkit.org/show_bug.cgi?id=237567 rdar://89788378 Reviewed by Brent Fulg

[webkit-changes] [291018] trunk

2022-03-08 Thread j_pascoe
Title: [291018] trunk Revision 291018 Author j_pas...@apple.com Date 2022-03-08 15:51:45 -0800 (Tue, 08 Mar 2022) Log Message [WebAuthn] Using WebAuthn within cross-origin iframe elements https://bugs.webkit.org/show_bug.cgi?id=40 rdar://problem/74830748 Reviewed by Brent Fulgham. S

[webkit-changes] [290991] trunk/LayoutTests

2022-03-08 Thread j_pascoe
Title: [290991] trunk/LayoutTests Revision 290991 Author j_pas...@apple.com Date 2022-03-08 08:17:13 -0800 (Tue, 08 Mar 2022) Log Message [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures https://bugs.webkit.org/show_bug.cgi?

[webkit-changes] [290893] trunk/Source/WebKit

2022-03-07 Thread j_pascoe
Title: [290893] trunk/Source/WebKit Revision 290893 Author j_pas...@apple.com Date 2022-03-07 09:37:04 -0800 (Mon, 07 Mar 2022) Log Message [WebAuthn] Provide global frame identifier to ASCAgent SPI https://bugs.webkit.org/show_bug.cgi?id=237454 rdar://problem/89782147 Reviewed by Brent

[webkit-changes] [290840] trunk/Source/WebKit

2022-03-04 Thread j_pascoe
Title: [290840] trunk/Source/WebKit Revision 290840 Author j_pas...@apple.com Date 2022-03-04 12:33:12 -0800 (Fri, 04 Mar 2022) Log Message [WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern https://bugs.webkit.org/show_bug.cgi?id=225646 rdar://78147681

[webkit-changes] [290751] trunk/LayoutTests

2022-03-02 Thread j_pascoe
Title: [290751] trunk/LayoutTests Revision 290751 Author j_pas...@apple.com Date 2022-03-02 13:04:20 -0800 (Wed, 02 Mar 2022) Log Message [WebAuthn] Remove obsolete failed attestation tests https://bugs.webkit.org/show_bug.cgi?id=237346 rdar://problem/89647260 Reviewed by Brent Fulgham.

[webkit-changes] [290744] trunk/Source/WebKit

2022-03-02 Thread j_pascoe
Title: [290744] trunk/Source/WebKit Revision 290744 Author j_pas...@apple.com Date 2022-03-02 11:47:21 -0800 (Wed, 02 Mar 2022) Log Message [WebAuthn] Ensure presenter gets dismissed on iOS https://bugs.webkit.org/show_bug.cgi?id=237336 rdar://81609371 Reviewed by Brent Fulgham. Always

[webkit-changes] [290652] trunk/Tools

2022-03-01 Thread j_pascoe
Title: [290652] trunk/Tools Revision 290652 Author j_pas...@apple.com Date 2022-03-01 09:40:35 -0800 (Tue, 01 Mar 2022) Log Message REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.* tests are constantly failing/crashing. https://bugs.webkit.org/show_bug.cgi?id=

[webkit-changes] [290539] trunk

2022-02-25 Thread j_pascoe
Title: [290539] trunk Revision 290539 Author j_pas...@apple.com Date 2022-02-25 17:47:04 -0800 (Fri, 25 Feb 2022) Log Message [WebAuthn] Fallback to attestation=none whenever attestation fails https://bugs.webkit.org/show_bug.cgi?id=237223 rdar://88767812 Reviewed by Brent Fulgham. Sour

[webkit-changes] [290515] trunk

2022-02-25 Thread j_pascoe
Title: [290515] trunk Revision 290515 Author j_pas...@apple.com Date 2022-02-25 10:44:20 -0800 (Fri, 25 Feb 2022) Log Message [WebAuthn] Use default pubKeyCredParams if empty in makeCredential https://bugs.webkit.org/show_bug.cgi?id=237109 rdar://problem/89376484 Reviewed by Brent Fulgha

[webkit-changes] [290441] trunk/Tools

2022-02-24 Thread j_pascoe
Title: [290441] trunk/Tools Revision 290441 Author j_pas...@apple.com Date 2022-02-24 10:02:18 -0800 (Thu, 24 Feb 2022) Log Message Add myself (John Pascoe) to watchlist for authentication and WebCrypto https://bugs.webkit.org/show_bug.cgi?id=237121 rdar://problem/89385797 Reviewed by Al

[webkit-changes] [290392] trunk

2022-02-23 Thread j_pascoe
Title: [290392] trunk Revision 290392 Author j_pas...@apple.com Date 2022-02-23 14:33:42 -0800 (Wed, 23 Feb 2022) Log Message [WebAuthn] Improve error message for missing pubKeyCredParams https://bugs.webkit.org/show_bug.cgi?id=235421 rdar://87884875 Reviewed by Brent Fulgham. Source/We

[webkit-changes] [290384] trunk/Source

2022-02-23 Thread j_pascoe
Title: [290384] trunk/Source Revision 290384 Author j_pas...@apple.com Date 2022-02-23 11:02:54 -0800 (Wed, 23 Feb 2022) Log Message Prevent use of PDFKit when using PDF.js https://bugs.webkit.org/show_bug.cgi?id=237052 rdar://89251696 Reviewed by Tim Horton. Source/WebCore: Add WEBCOR

[webkit-changes] [290381] trunk

2022-02-23 Thread j_pascoe
Title: [290381] trunk Revision 290381 Author j_pas...@apple.com Date 2022-02-23 10:19:54 -0800 (Wed, 23 Feb 2022) Log Message [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse https://bugs.webkit.org/show_bug.cgi?id=237043 rdar://89317740 Reviewed by Bren

[webkit-changes] [290317] trunk/Source/WebKit

2022-02-22 Thread j_pascoe
Title: [290317] trunk/Source/WebKit Revision 290317 Author j_pas...@apple.com Date 2022-02-22 10:21:24 -0800 (Tue, 22 Feb 2022) Log Message [WebAuthn] Fix lifetime issue on iOS https://bugs.webkit.org/show_bug.cgi?id=237018 rdar://89206950 Reviewed by Brent Fulgham. Lifetime issues intr

[webkit-changes] [290184] trunk/Source

2022-02-18 Thread j_pascoe
Title: [290184] trunk/Source Revision 290184 Author j_pas...@apple.com Date 2022-02-18 16:28:13 -0800 (Fri, 18 Feb 2022) Log Message [WebAuthn] Support for conditional mediation https://bugs.webkit.org/show_bug.cgi?id=236820 rdar://84821947 Reviewed by Brent Fulgham and Chris Dumez. Thi

[webkit-changes] [290154] trunk

2022-02-18 Thread j_pascoe
Title: [290154] trunk Revision 290154 Author j_pas...@apple.com Date 2022-02-18 12:37:00 -0800 (Fri, 18 Feb 2022) Log Message [WebAuthn] Add credentialID to _WKWebAuthenticationAssertionResponse and userHandle in getAllLocalAuthenticatorCredentials https://bugs.webkit.org/show_bug.cgi?id=

[webkit-changes] [290089] trunk/Source/WebCore

2022-02-17 Thread j_pascoe
Title: [290089] trunk/Source/WebCore Revision 290089 Author j_pas...@apple.com Date 2022-02-17 16:27:59 -0800 (Thu, 17 Feb 2022) Log Message PDF.js viewer should work for all kinds of URLs https://bugs.webkit.org/show_bug.cgi?id=236525 rdar://problem/88832961 Reviewed by Tim Nguyen. Thi

[webkit-changes] [289817] trunk/Source/WebKit

2022-02-15 Thread j_pascoe
Title: [289817] trunk/Source/WebKit Revision 289817 Author j_pas...@apple.com Date 2022-02-15 09:03:54 -0800 (Tue, 15 Feb 2022) Log Message Modify getAllLocalAuthenticatorCredentials according to internal requirements https://bugs.webkit.org/show_bug.cgi?id=236364 rdar://88585418 Reviewe

[webkit-changes] [289760] trunk

2022-02-14 Thread j_pascoe
Title: [289760] trunk Revision 289760 Author j_pas...@apple.com Date 2022-02-14 13:10:50 -0800 (Mon, 14 Feb 2022) Log Message [WebAuthn] Access group not set in add query for importLocalAuthenticatorCredential https://bugs.webkit.org/show_bug.cgi?id=236469 rdar://problem/88783447 Reviewe

[webkit-changes] [289739] trunk/Source

2022-02-14 Thread j_pascoe
Title: [289739] trunk/Source Revision 289739 Author j_pas...@apple.com Date 2022-02-14 09:58:13 -0800 (Mon, 14 Feb 2022) Log Message [WebAuthn] Modify _WKWebAuthenticationAssertionResponse according to internal needs https://bugs.webkit.org/show_bug.cgi?id=236369 rdar://88585811 Reviewed

[webkit-changes] [289482] trunk

2022-02-09 Thread j_pascoe
Title: [289482] trunk Revision 289482 Author j_pas...@apple.com Date 2022-02-09 10:17:43 -0800 (Wed, 09 Feb 2022) Log Message [WebAuthn] Specify LocalAuthenticatorAccessGroup when importing credentials https://bugs.webkit.org/show_bug.cgi?id=236311 rdar://88394179 Reviewed by Brent Fulgh

[webkit-changes] [289436] trunk/Source/WebKit

2022-02-08 Thread j_pascoe
Title: [289436] trunk/Source/WebKit Revision 289436 Author j_pas...@apple.com Date 2022-02-08 14:43:55 -0800 (Tue, 08 Feb 2022) Log Message [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS https://bugs.webkit.org/show_bug.cgi?id=236151 rdar://87908259 Reviewed by Bren

[webkit-changes] [289096] trunk/Source/WebCore

2022-02-03 Thread j_pascoe
Title: [289096] trunk/Source/WebCore Revision 289096 Author j_pas...@apple.com Date 2022-02-03 18:09:58 -0800 (Thu, 03 Feb 2022) Log Message [WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup" https://bugs.webkit.org/show_bug.cgi?id=235894 rdar://88104045 Reviewed by D

[webkit-changes] [289059] trunk

2022-02-03 Thread j_pascoe
Title: [289059] trunk Revision 289059 Author j_pas...@apple.com Date 2022-02-03 10:01:45 -0800 (Thu, 03 Feb 2022) Log Message [WebAuthn] Allow use of hardware-fixed credentials while using alternate store https://bugs.webkit.org/show_bug.cgi?id=235923 rdar://88102108 Reviewed by Brent Fu

[webkit-changes] [288816] trunk

2022-01-31 Thread j_pascoe
Title: [288816] trunk Revision 288816 Author j_pas...@apple.com Date 2022-01-31 08:55:49 -0800 (Mon, 31 Jan 2022) Log Message [WebAuthn] Provide SPI to export/import local credentials https://bugs.webkit.org/show_bug.cgi?id=234112 rdar://84822000 Reviewed by Brent Fulgham. Source/WebCor

[webkit-changes] [288652] trunk/Source/WebKit

2022-01-26 Thread j_pascoe
Title: [288652] trunk/Source/WebKit Revision 288652 Author j_pas...@apple.com Date 2022-01-26 16:03:15 -0800 (Wed, 26 Jan 2022) Log Message [WebAuthn] We should pass extensions to ASC if possible https://bugs.webkit.org/show_bug.cgi?id=235533 rdar://87169406 Reviewed by Brent Fulgham. T

[webkit-changes] [288622] trunk

2022-01-26 Thread j_pascoe
Title: [288622] trunk Revision 288622 Author j_pas...@apple.com Date 2022-01-26 08:59:14 -0800 (Wed, 26 Jan 2022) Log Message [WebAuthn] Add authenticator attachment used during authentication to credential payload https://bugs.webkit.org/show_bug.cgi?id=235621 rdar://86538235 Reviewed b

[webkit-changes] [288333] trunk/Source/WebKit

2022-01-20 Thread j_pascoe
Title: [288333] trunk/Source/WebKit Revision 288333 Author j_pas...@apple.com Date 2022-01-20 16:34:40 -0800 (Thu, 20 Jan 2022) Log Message [WebAuthn] Support all valid FIDO NFC tag types https://bugs.webkit.org/show_bug.cgi?id=234616 rdar://85871173 Reviewed by Darin Adler. This patch

[webkit-changes] [288010] trunk

2022-01-14 Thread j_pascoe
Title: [288010] trunk Revision 288010 Author j_pas...@apple.com Date 2022-01-14 00:02:17 -0800 (Fri, 14 Jan 2022) Log Message Expose way to encode CTAP commands with only the hash of ClientDataJSON https://bugs.webkit.org/show_bug.cgi?id=235191 Reviewed by Brent Fulgham. Source/WebKit:

[webkit-changes] [287957] trunk

2022-01-12 Thread j_pascoe
Title: [287957] trunk Revision 287957 Author j_pas...@apple.com Date 2022-01-12 15:45:51 -0800 (Wed, 12 Jan 2022) Log Message [WebAuthn] Fix freebie call without user gesture not being given https://bugs.webkit.org/show_bug.cgi?id=235078 rdar://87327557 Reviewed by Brent Fulgham. Source

[webkit-changes] [287360] trunk

2021-12-22 Thread j_pascoe
Title: [287360] trunk Revision 287360 Author j_pas...@apple.com Date 2021-12-22 09:59:28 -0800 (Wed, 22 Dec 2021) Log Message [WebAuthn] Set Web Authentication experimental feature flag as default true https://bugs.webkit.org/show_bug.cgi?id=234533 Reviewed by Brent Fulgham. Source/WTF

[webkit-changes] [287315] trunk

2021-12-21 Thread j_pascoe
Title: [287315] trunk Revision 287315 Author j_pas...@apple.com Date 2021-12-21 08:09:07 -0800 (Tue, 21 Dec 2021) Log Message [WebAuthn] Authenticator is not falling back to clientPIN after internal verification fails and is blocked. https://bugs.webkit.org/show_bug.cgi?id=232501 Review

[webkit-changes] [287278] trunk/Tools

2021-12-20 Thread j_pascoe
Title: [287278] trunk/Tools Revision 287278 Author j_pas...@apple.com Date 2021-12-20 14:11:53 -0800 (Mon, 20 Dec 2021) Log Message [WebAuthn] Add option to change requestWebAuthenticationNoGesture delegate for api tests. https://bugs.webkit.org/show_bug.cgi?id=23 rdar://86644642 Rev

[webkit-changes] [287277] trunk/Tools

2021-12-20 Thread j_pascoe
Title: [287277] trunk/Tools Revision 287277 Author j_pas...@apple.com Date 2021-12-20 14:09:35 -0800 (Mon, 20 Dec 2021) Log Message [WebAuthn] Only run WebAuthn test process on platform it is used https://bugs.webkit.org/show_bug.cgi?id=234445 rdar://86646638 Reviewed by Brent Fulgham.

[webkit-changes] [287116] trunk

2021-12-15 Thread j_pascoe
Title: [287116] trunk Revision 287116 Author j_pas...@apple.com Date 2021-12-15 16:52:57 -0800 (Wed, 15 Dec 2021) Log Message [WebAuthn] Allow same-site, cross-origin iframe get() https://bugs.webkit.org/show_bug.cgi?id=234309 rdar://problem/86486313 Reviewed by Brent Fulgham. Source/We

[webkit-changes] [287002] trunk

2021-12-13 Thread j_pascoe
Title: [287002] trunk Revision 287002 Author j_pas...@apple.com Date 2021-12-13 18:42:38 -0800 (Mon, 13 Dec 2021) Log Message Unreviewed, reverting r286993. https://bugs.webkit.org/show_bug.cgi?id=234283 Reverted changeset: "[WebAuthn] Allow same-site, cross-origin iframe get()" https:/

[webkit-changes] [286993] trunk

2021-12-13 Thread j_pascoe
Title: [286993] trunk Revision 286993 Author j_pas...@apple.com Date 2021-12-13 15:58:25 -0800 (Mon, 13 Dec 2021) Log Message [WebAuthn] Allow same-site, cross-origin iframe get() https://bugs.webkit.org/show_bug.cgi?id=234180 rdar://85161142 Reviewed by Brent Fulgham. Source/WebCore:

[webkit-changes] [286785] trunk

2021-12-09 Thread j_pascoe
Title: [286785] trunk Revision 286785 Author j_pas...@apple.com Date 2021-12-09 09:53:22 -0800 (Thu, 09 Dec 2021) Log Message [WebAuthn] Remove user gesture requirement for using platform authenticator on the web https://bugs.webkit.org/show_bug.cgi?id=230893 Reviewed by Brent Fulgham.

[webkit-changes] [286746] trunk

2021-12-08 Thread j_pascoe
Title: [286746] trunk Revision 286746 Author j_pas...@apple.com Date 2021-12-08 15:49:16 -0800 (Wed, 08 Dec 2021) Log Message [WebAuthn] Consider support for the displayName for FIDO authenticator https://bugs.webkit.org/show_bug.cgi?id=233389 rdar://84938707 Reviewed by Brent Fulgham.

[webkit-changes] [286370] trunk/Source/WTF

2021-12-01 Thread j_pascoe
Title: [286370] trunk/Source/WTF Revision 286370 Author j_pas...@apple.com Date 2021-12-01 11:01:35 -0800 (Wed, 01 Dec 2021) Log Message Fix NEAR_FIELD macro to support iOS devices again https://bugs.webkit.org/show_bug.cgi?id=233671 rdar://85318070 In a previous change, https://bugs.web

[webkit-changes] [286078] trunk

2021-11-19 Thread j_pascoe
Title: [286078] trunk Revision 286078 Author j_pas...@apple.com Date 2021-11-19 14:19:52 -0800 (Fri, 19 Nov 2021) Log Message [WebAuthn] Add headers for [_WKWebAuthenticationPanel makeCredentialWithClientDataHash] and [_WKWebAuthenticationPanel getAssertionWithClientDataHash] https://bugs

[webkit-changes] [285965] trunk/Source/WebKit

2021-11-17 Thread j_pascoe
Title: [285965] trunk/Source/WebKit Revision 285965 Author j_pas...@apple.com Date 2021-11-17 16:10:02 -0800 (Wed, 17 Nov 2021) Log Message [WebAuthn] Add SPI for makeCredential / getAssertion using clientDataHash https://bugs.webkit.org/show_bug.cgi?id=233216 Reviewed by Brent Fulgham.

[webkit-changes] [285864] trunk/Source/WebKit

2021-11-16 Thread j_pascoe
Title: [285864] trunk/Source/WebKit Revision 285864 Author j_pas...@apple.com Date 2021-11-16 08:47:40 -0800 (Tue, 16 Nov 2021) Log Message [WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle identifier to use required [ASCAgent performAuthorizationRequestsForContext] https:

[webkit-changes] [285617] trunk

2021-11-10 Thread j_pascoe
Title: [285617] trunk Revision 285617 Author j_pas...@apple.com Date 2021-11-10 18:52:01 -0800 (Wed, 10 Nov 2021) Log Message [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation https://bugs.webkit.org/show_bug.cgi?id=232965 Reviewed b

[webkit-changes] [285537] trunk/Source/WebKit

2021-11-09 Thread j_pascoe
Title: [285537] trunk/Source/WebKit Revision 285537 Author j_pas...@apple.com Date 2021-11-09 15:02:32 -0800 (Tue, 09 Nov 2021) Log Message [WebAuthn] User handle is not saved on create via ASC https://bugs.webkit.org/show_bug.cgi?id=232900 rdar://85216105 Reviewed by Brent Fulgham. Thi

[webkit-changes] [285535] trunk

2021-11-09 Thread j_pascoe
Title: [285535] trunk Revision 285535 Author j_pas...@apple.com Date 2021-11-09 14:25:51 -0800 (Tue, 09 Nov 2021) Log Message Add j_pascoe to contributors.json https://bugs.webkit.org/show_bug.cgi?id=232904 Unreviewed. * metadata/contributors.json: Modified Paths trunk/ChangeLog

[webkit-changes] [285475] trunk

2021-11-08 Thread j_pascoe
Title: [285475] trunk Revision 285475 Author j_pas...@apple.com Date 2021-11-08 17:37:58 -0800 (Mon, 08 Nov 2021) Log Message [WebAuthn] challenge does not get passed to -[_WKWebAuthenticationPanel getAssertionWithChallenge:origin:options:completionHandler:] https://bugs.webkit.org/show_b