[webkit-changes] [166222] tags/Safari-538.24.2/Source/WebKit2
Title: [166222] tags/Safari-538.24.2/Source/WebKit2
Revision 166222
Author bshaf...@apple.com
Date 2014-03-24 23:18:51 -0700 (Mon, 24 Mar 2014)
Log Message
Merged r165983.
Modified Paths
tags/Safari-538.24.2/Source/WebKit2/ChangeLog
tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h
tags/Safari-538.24.2/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Diff
Modified: tags/Safari-538.24.2/Source/WebKit2/ChangeLog (166221 => 166222)
--- tags/Safari-538.24.2/Source/WebKit2/ChangeLog 2014-03-25 05:30:00 UTC (rev 166221)
+++ tags/Safari-538.24.2/Source/WebKit2/ChangeLog 2014-03-25 06:18:51 UTC (rev 166222)
@@ -1,3 +1,21 @@
+2014-03-24 Babak Shafiei bshaf...@apple.com
+
+Merge r165983
+
+2014-03-20 Sam Weinig s...@webkit.org
+
+[Cocoa] Expose preference to enable telephone number detection
+https://bugs.webkit.org/show_bug.cgi?id=130524
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _telephoneNumberDetectionIsEnabled]):
+(-[WKPreferences _setTelephoneNumberDetectionIsEnabled:]):
+* UIProcess/API/Cocoa/WKPreferencesInternal.h:
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Added.
+* WebKit2.xcodeproj/project.pbxproj:
+
2014-03-24 Lucas Forschler lforsch...@apple.com
Merge r166203
Modified: tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (166221 => 166222)
--- tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-03-25 05:30:00 UTC (rev 166221)
+++ tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-03-25 06:18:51 UTC (rev 166222)
@@ -54,4 +54,18 @@
@end
+@implementation WKPreferences (WKPrivate)
+
+- (BOOL)_telephoneNumberDetectionIsEnabled
+{
+return _preferences-telephoneNumberParsingEnabled();
+}
+
+- (void)_setTelephoneNumberDetectionIsEnabled:(BOOL)telephoneNumberDetectionIsEnabled
+{
+_preferences-setTelephoneNumberParsingEnabled(telephoneNumberDetectionIsEnabled);
+}
+
+@end
+
#endif // WK_API_ENABLED
Modified: tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h (166221 => 166222)
--- tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h 2014-03-25 05:30:00 UTC (rev 166221)
+++ tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h 2014-03-25 06:18:51 UTC (rev 166222)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import WKPreferences.h
+#import WKPreferencesPrivate.h
#if WK_API_ENABLED
Copied: tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (from rev 165983, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h) (0 => 166222)
--- tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (rev 0)
+++ tags/Safari-538.24.2/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-03-25 06:18:51 UTC (rev 166222)
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import WebKit2/WKPreferences.h
+
+#if WK_API_ENABLED
+
+@interface WKPreferences (WKPrivate)
+
+@property (nonatomic, setter=_setTelephoneNumberDetectionIsEnabled:) BOOL _telephoneNumberDetectionIsEnabled;
+
+@end
+
+#endif
Modified: tags/Safari-538.24.2/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (166221 => 166222)
---
[webkit-changes] [166223] tags/Safari-538.24.2/Source/WebKit2
Title: [166223] tags/Safari-538.24.2/Source/WebKit2 Revision 166223 Author bshaf...@apple.com Date 2014-03-24 23:24:13 -0700 (Mon, 24 Mar 2014) Log Message Merged r166103. Modified Paths tags/Safari-538.24.2/Source/WebKit2/ChangeLog tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkProcess.xcconfig tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkService.Development.xcconfig tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkService.xcconfig tags/Safari-538.24.2/Source/WebKit2/Configurations/WebContent-iOS.entitlements tags/Safari-538.24.2/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm tags/Safari-538.24.2/Source/WebKit2/Platform/IPC/Connection.h tags/Safari-538.24.2/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp tags/Safari-538.24.2/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj tags/Safari-538.24.2/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm Added Paths tags/Safari-538.24.2/Source/WebKit2/Configurations/Network-iOS.entitlements Diff Modified: tags/Safari-538.24.2/Source/WebKit2/ChangeLog (166222 => 166223) --- tags/Safari-538.24.2/Source/WebKit2/ChangeLog 2014-03-25 06:18:51 UTC (rev 166222) +++ tags/Safari-538.24.2/Source/WebKit2/ChangeLog 2014-03-25 06:24:13 UTC (rev 166223) @@ -1,5 +1,34 @@ 2014-03-24 Babak Shafiei bshaf...@apple.com +Merge r166103 + +2014-03-21 Sam Weinig s...@webkit.org + +[WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2 +https://bugs.webkit.org/show_bug.cgi?id=130528 + +Reviewed by Tim Horton. + +* Platform/IPC/Connection.h: +* Platform/IPC/mac/ConnectionMac.cpp: +(IPC::Connection::getAuditToken): +Expose the audit data if available. + +* NetworkProcess/mac/RemoteNetworkingContext.mm: +(WebKit::RemoteNetworkingContext::sourceApplicationAuditData): +* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: +(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData): +Pass the audit data corresponding to the UIProcess. + +* Configurations/Network-iOS.entitlements: Copied from Configurations/WebContent-iOS.entitlements. +* Configurations/NetworkProcess.xcconfig: +* Configurations/NetworkService.Development.xcconfig: +* Configurations/NetworkService.xcconfig: +* Configurations/WebContent-iOS.entitlements: +Add entitlement allowing the audit data to be used. + +2014-03-24 Babak Shafiei bshaf...@apple.com + Merge r165983 2014-03-20 Sam Weinig s...@webkit.org Copied: tags/Safari-538.24.2/Source/WebKit2/Configurations/Network-iOS.entitlements (from rev 166103, trunk/Source/WebKit2/Configurations/Network-iOS.entitlements) (0 => 166223) --- tags/Safari-538.24.2/Source/WebKit2/Configurations/Network-iOS.entitlements (rev 0) +++ tags/Safari-538.24.2/Source/WebKit2/Configurations/Network-iOS.entitlements 2014-03-25 06:24:13 UTC (rev 166223) @@ -0,0 +1,8 @@ +?xml version=1.0 encoding=UTF-8? +!DOCTYPE plist PUBLIC -//Apple//DTD PLIST 1.0//EN http://www.apple.com/DTDs/PropertyList-1.0.dtd +plist version=1.0 +dict + keycom.apple.private.network.socket-delegate/key + true/ +/dict +/plist Modified: tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkProcess.xcconfig (166222 => 166223) --- tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkProcess.xcconfig 2014-03-25 06:18:51 UTC (rev 166222) +++ tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkProcess.xcconfig 2014-03-25 06:24:13 UTC (rev 166223) @@ -29,3 +29,6 @@ EXCLUDED_SHIM_FILE_NAME = $(EXCLUDED_SHIM_FILE_NAME_$(PLATFORM_NAME)); EXCLUDED_SHIM_FILE_NAME_iphoneos = SecItemShim.dylib; EXCLUDED_SHIM_FILE_NAME_iphonesimulator = $(EXCLUDED_SHIM_FILE_NAME_iphoneos); + +CODE_SIGN_ENTITLEMENTS[sdk=iphoneos*] = Configurations/Network-iOS.entitlements +CODE_SIGN_ENTITLEMENTS[sdk=iphonesimulator*] = Configurations/Network-iOS.entitlements Modified: tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkService.Development.xcconfig (166222 => 166223) --- tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkService.Development.xcconfig 2014-03-25 06:18:51 UTC (rev 166222) +++ tags/Safari-538.24.2/Source/WebKit2/Configurations/NetworkService.Development.xcconfig 2014-03-25 06:24:13 UTC (rev 166223) @@ -29,3 +29,6 @@ INFOPLIST_FILE = $(INFOPLIST_FILE_$(PLATFORM_NAME)); INFOPLIST_FILE_macosx = NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist; INFOPLIST_FILE_iphoneos = NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist; + +CODE_SIGN_ENTITLEMENTS[sdk=iphoneos*] = Configurations/Network-iOS.entitlements +CODE_SIGN_ENTITLEMENTS[sdk=iphonesimulator*] = Configurations/Network-iOS.entitlements Modified:
[webkit-changes] [166224] trunk/Source/WebKit2
Title: [166224] trunk/Source/WebKit2
Revision 166224
Author cfleiz...@apple.com
Date 2014-03-24 23:34:30 -0700 (Mon, 24 Mar 2014)
Log Message
AX: hit-testing doesn't always work correctly with WK2
https://bugs.webkit.org/show_bug.cgi?id=130706
Reviewed by Simon Fraser.
Accessibility code was trying to do screenToRootView itself, and in
some cases with embedded WK2 views that did not work.
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166223 => 166224)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 06:24:13 UTC (rev 166223)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 06:34:30 UTC (rev 166224)
@@ -1,3 +1,16 @@
+2014-03-24 Chris Fleizach cfleiz...@apple.com
+
+AX: hit-testing doesn't always work correctly with WK2
+https://bugs.webkit.org/show_bug.cgi?id=130706
+
+Reviewed by Simon Fraser.
+
+Accessibility code was trying to do screenToRootView itself, and in
+some cases with embedded WK2 views that did not work.
+
+* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
+
2014-03-24 Benjamin Poulain bpoul...@apple.com
[WK2] SpinLock are not initialized by default, ViewUpdateDispatcher is missing an initializer
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm (166223 => 166224)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2014-03-25 06:24:13 UTC (rev 166223)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2014-03-25 06:34:30 UTC (rev 166224)
@@ -193,27 +193,14 @@
#pragma clang diagnostic ignored -Wdeprecated-declarations
- (id)accessibilityHitTest:(NSPoint)point
{
-// Hit-test point comes in as bottom-screen coordinates. Needs to be normalized to the frame of the web page.
-NSPoint remotePosition = [[self accessibilityAttributeValue:NSAccessibilityPositionAttribute] pointValue];
-NSSize remoteSize = [[self accessibilityAttributeValue:NSAccessibilitySizeAttribute] sizeValue];
+if (!m_page)
+return nil;
-// Get the y position of the WKView (we have to screen-flip and go from bottom left to top left).
-CGFloat screenHeight = [(NSScreen *)[[NSScreen screens] objectAtIndex:0] frame].size.height;
-remotePosition.y = (screenHeight - remotePosition.y) - remoteSize.height;
-
-point.y = screenHeight - point.y;
-
-// Re-center point into the web page's frame.
-point.y -= remotePosition.y;
-point.x -= remotePosition.x;
-
-WebCore::FrameView* frameView = m_page ? m_page-mainFrameView() : 0;
-if (frameView) {
-point.y += frameView-scrollPosition().y();
-point.x += frameView-scrollPosition().x();
-}
-
-return [[self accessibilityRootObjectWrapper] accessibilityHitTest:point];
+IntPoint convertedPoint = m_page-screenToRootView(IntPoint(point));
+if (WebCore::FrameView* frameView = m_page-mainFrameView())
+convertedPoint.moveBy(frameView-scrollPosition());
+
+return [[self accessibilityRootObjectWrapper] accessibilityHitTest:convertedPoint];
}
#pragma clang diagnostic pop
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166225] tags/Safari-537.75.13/
Title: [166225] tags/Safari-537.75.13/ Revision 166225 Author bshaf...@apple.com Date 2014-03-25 00:10:31 -0700 (Tue, 25 Mar 2014) Log Message New tag. Added Paths tags/Safari-537.75.13/ Diff Property changes: tags/Safari-537.75.13 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166226] branches/safari-537.75-branch/Source
Title: [166226] branches/safari-537.75-branch/Source Revision 166226 Author bshaf...@apple.com Date 2014-03-25 00:13:20 -0700 (Tue, 25 Mar 2014) Log Message Versioning. Modified Paths branches/safari-537.75-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537.75-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537.75-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537.75-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537.75-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537.75-branch/Source/_javascript_Core/Configurations/Version.xcconfig (166225 => 166226) --- branches/safari-537.75-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-03-25 07:10:31 UTC (rev 166225) +++ branches/safari-537.75-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-03-25 07:13:20 UTC (rev 166226) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 75; -TINY_VERSION = 13; +TINY_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.75-branch/Source/WebCore/Configurations/Version.xcconfig (166225 => 166226) --- branches/safari-537.75-branch/Source/WebCore/Configurations/Version.xcconfig 2014-03-25 07:10:31 UTC (rev 166225) +++ branches/safari-537.75-branch/Source/WebCore/Configurations/Version.xcconfig 2014-03-25 07:13:20 UTC (rev 166226) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 75; -TINY_VERSION = 13; +TINY_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.75-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (166225 => 166226) --- branches/safari-537.75-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-03-25 07:10:31 UTC (rev 166225) +++ branches/safari-537.75-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-03-25 07:13:20 UTC (rev 166226) @@ -1,6 +1,6 @@ MAJOR_VERSION = 537; MINOR_VERSION = 75; -TINY_VERSION = 13; +TINY_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-537.75-branch/Source/WebKit/mac/Configurations/Version.xcconfig (166225 => 166226) --- branches/safari-537.75-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-03-25 07:10:31 UTC (rev 166225) +++ branches/safari-537.75-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-03-25 07:13:20 UTC (rev 166226) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 75; -TINY_VERSION = 13; +TINY_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.75-branch/Source/WebKit2/Configurations/Version.xcconfig (166225 => 166226) --- branches/safari-537.75-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-03-25 07:10:31 UTC (rev 166225) +++ branches/safari-537.75-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-03-25 07:13:20 UTC (rev 166226) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 75; -TINY_VERSION = 13; +TINY_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166227] trunk
Title: [166227] trunk
Revision 166227
Author calva...@igalia.com
Date 2014-03-25 02:10:32 -0700 (Tue, 25 Mar 2014)
Log Message
[GTK] Volume slider shows below the panel with videos in certain cases
https://bugs.webkit.org/show_bug.cgi?id=130608
Reviewed by Jer Noble.
Source/WebCore:
We need to delay the moment we check if the volume slider shows up
or down. If the video was not visible, the offsets were 0 and it
was forced to be shown below the panel.
Test: media/video-initially-hidden-volume-slider-up.html
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Moved volumebox pseudo from
the subclass. The test checks for it and it would fail in Mac.
* Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.createControls): Moved volumebox pseudo
to the superclass.
(ControllerGtk.prototype.handleMuteButtonMouseOver): Check if
volume slider should show up or down.
(ControllerGtk.prototype.updateReadyState): Removed check for
volume slider direction.
LayoutTests:
* media/video-initially-hidden-volume-slider-up-expected.txt: Added.
* media/video-initially-hidden-volume-slider-up.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js
Added Paths
trunk/LayoutTests/media/video-initially-hidden-volume-slider-up-expected.txt
trunk/LayoutTests/media/video-initially-hidden-volume-slider-up.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166226 => 166227)
--- trunk/LayoutTests/ChangeLog 2014-03-25 07:13:20 UTC (rev 166226)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 09:10:32 UTC (rev 166227)
@@ -1,3 +1,13 @@
+2014-03-25 Xabier Rodriguez Calvar calva...@igalia.com
+
+[GTK] Volume slider shows below the panel with videos in certain cases
+https://bugs.webkit.org/show_bug.cgi?id=130608
+
+Reviewed by Jer Noble.
+
+* media/video-initially-hidden-volume-slider-up-expected.txt: Added.
+* media/video-initially-hidden-volume-slider-up.html: Added.
+
2014-03-24 Brent Fulgham bfulg...@apple.com
[Win] Enable WebVTT Regions on Windows.
Added: trunk/LayoutTests/media/video-initially-hidden-volume-slider-up-expected.txt (0 => 166227)
--- trunk/LayoutTests/media/video-initially-hidden-volume-slider-up-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-initially-hidden-volume-slider-up-expected.txt 2014-03-25 09:10:32 UTC (rev 166227)
@@ -0,0 +1,4 @@
+
+EXPECTED (volumeSliderCoordinates[0] = muteButtonCoordinates[0] volumeSliderCoordinates[1] = muteButtonCoordinates[1] == 'true') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/video-initially-hidden-volume-slider-up.html (0 => 166227)
--- trunk/LayoutTests/media/video-initially-hidden-volume-slider-up.html (rev 0)
+++ trunk/LayoutTests/media/video-initially-hidden-volume-slider-up.html 2014-03-25 09:10:32 UTC (rev 166227)
@@ -0,0 +1,67 @@
+!DOCTYPE html
+html
+titleTest that volume slider is rendered up. /title
+
+head
+
+script src=""
+script src=""
+script src=""
+
+script
+var video;
+
+var muteButtonCoordinates;
+var volumeSliderCoordinates;
+
+function test()
+{
+video.style.display = block;
+
+// Test that the volume slider is rendered correctly if video is brought to foreground
+
+if (window.eventSender) {
+// Move mouse on top of the mute button
+
+try {
+muteButtonCoordinates = mediaControlsButtonCoordinates(video, mute-button);
+} catch (exception) {
+consoleWrite(ERROR: unable to get controls coordinates.);
+
+failTest();
+return;
+}
+
+eventSender.mouseMoveTo(muteButtonCoordinates[0], muteButtonCoordinates[1]);
+}
+
+// Ensure layout is done after mouse move
+document.body.offsetTop;
+try {
+volumeSliderCoordinates = mediaControlsButtonCoordinates(video, volume-slider-container);
+} catch (exception) {
+consoleWrite(ERROR: unable to get controls coordinates.);
+
+failTest();
+return;
+}
+
+// The volume slider should not be positioned below the panel
+testExpected(volumeSliderCoordinates[0] = muteButtonCoordinates[0] volumeSliderCoordinates[1] = muteButtonCoordinates[1], true);
+
+endTest();
+}
+
+function initialize()
+{
+internals.suspendAnimations();
+video = document.getElementsByTagName(video)[0];
+video.src = "" content/test);
+}
+/script
+/head
+
+body _onload_=initialize();
+ video controls _oncanplay_=test();
[webkit-changes] [166228] trunk/Source/WebKit2
Title: [166228] trunk/Source/WebKit2
Revision 166228
Author m.pak...@samsung.com
Date 2014-03-25 02:53:26 -0700 (Tue, 25 Mar 2014)
Log Message
[EFL][WK2] Add an API to set process model
https://bugs.webkit.org/show_bug.cgi?id=130133
Reviewed by Gyuyoung Kim.
Implement an API to set and get process model in ewk_context.
By default process model enum value is set to EWK_PROCESS_MODEL_SHARED_SECONDARY
which keeps current behaviour. Setting EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
will make each web view use separate web process, also enables network process.
* UIProcess/API/efl/ewk_context.cpp:
(toWKProcessModel):
(EwkContext::setProcessModel):
(toEwkProcessModel):
(EwkContext::processModel):
(ewk_context_process_model_set):
(ewk_context_process_model_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_private.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166227 => 166228)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 09:10:32 UTC (rev 166227)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 09:53:26 UTC (rev 166228)
@@ -1,3 +1,27 @@
+2014-03-24 Michał Pakuła vel Rutka m.pak...@samsung.com
+
+[EFL][WK2] Add an API to set process model
+https://bugs.webkit.org/show_bug.cgi?id=130133
+
+Reviewed by Gyuyoung Kim.
+
+Implement an API to set and get process model in ewk_context.
+By default process model enum value is set to EWK_PROCESS_MODEL_SHARED_SECONDARY
+which keeps current behaviour. Setting EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
+will make each web view use separate web process, also enables network process.
+
+* UIProcess/API/efl/ewk_context.cpp:
+(toWKProcessModel):
+(EwkContext::setProcessModel):
+(toEwkProcessModel):
+(EwkContext::processModel):
+(ewk_context_process_model_set):
+(ewk_context_process_model_get):
+* UIProcess/API/efl/ewk_context.h:
+* UIProcess/API/efl/ewk_context_private.h:
+* UIProcess/API/efl/tests/test_ewk2_context.cpp:
+(TEST_F):
+
2014-03-24 Chris Fleizach cfleiz...@apple.com
AX: hit-testing doesn't always work correctly with WK2
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp (166227 => 166228)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp 2014-03-25 09:10:32 UTC (rev 166227)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp 2014-03-25 09:53:26 UTC (rev 166228)
@@ -237,6 +237,48 @@
return static_castEwk_Cache_Model(WKContextGetCacheModel(m_context.get()));
}
+inline WKProcessModel toWKProcessModel(Ewk_Process_Model processModel)
+{
+switch (processModel) {
+case EWK_PROCESS_MODEL_SHARED_SECONDARY:
+return kWKProcessModelSharedSecondaryProcess;
+case EWK_PROCESS_MODEL_MULTIPLE_SECONDARY:
+return kWKProcessModelMultipleSecondaryProcesses;
+}
+ASSERT_NOT_REACHED();
+
+return kWKProcessModelSharedSecondaryProcess;
+}
+
+void EwkContext::setProcessModel(Ewk_Process_Model processModel)
+{
+WKProcessModel newWKProcessModel = toWKProcessModel(processModel);
+
+if (WKContextGetProcessModel(m_context.get()) == newWKProcessModel)
+return;
+
+WKContextSetUsesNetworkProcess(m_context.get(), newWKProcessModel == kWKProcessModelMultipleSecondaryProcesses);
+WKContextSetProcessModel(m_context.get(), newWKProcessModel);
+}
+
+inline Ewk_Process_Model toEwkProcessModel(WKProcessModel processModel)
+{
+switch (processModel) {
+case kWKProcessModelSharedSecondaryProcess:
+return EWK_PROCESS_MODEL_SHARED_SECONDARY;
+case kWKProcessModelMultipleSecondaryProcesses:
+return EWK_PROCESS_MODEL_MULTIPLE_SECONDARY;
+}
+ASSERT_NOT_REACHED();
+
+return EWK_PROCESS_MODEL_SHARED_SECONDARY;
+}
+
+Ewk_Process_Model EwkContext::processModel() const
+{
+return toEwkProcessModel(WKContextGetProcessModel(m_context.get()));
+}
+
#if ENABLE(NETSCAPE_PLUGIN_API)
void EwkContext::setAdditionalPluginPath(const String path)
{
@@ -469,3 +511,30 @@
impl-setMessageFromInjectedBundleCallback(callback, userData);
}
+
+Eina_Bool ewk_context_process_model_set(Ewk_Context* ewkContext, Ewk_Process_Model processModel)
+{
+#if ENABLE(NETWORK_PROCESS)
+EWK_OBJ_GET_IMPL_OR_RETURN(EwkContext, ewkContext, impl, false);
+
+impl-setProcessModel(processModel);
+
+return true;
+#else
+UNUSED_PARAM(ewkContext);
+UNUSED_PARAM(processModel);
+return false;
+#endif
+}
+
+Ewk_Process_Model ewk_context_process_model_get(const Ewk_Context* ewkContext)
+{
+#if ENABLE(NETWORK_PROCESS)
+EWK_OBJ_GET_IMPL_OR_RETURN(const EwkContext,
[webkit-changes] [166229] trunk/Tools
Title: [166229] trunk/Tools
Revision 166229
Author commit-qu...@webkit.org
Date 2014-03-25 05:13:03 -0700 (Tue, 25 Mar 2014)
Log Message
[webkitpy] Improve _parse_bug_description to recognize more descriptions
https://bugs.webkit.org/show_bug.cgi?id=130137
Patch by Eva Balazsfalvi evab.u-sze...@partner.samsung.com on 2014-03-25
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._parse_bug_description):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_commit_info_for_revision):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (166228 => 166229)
--- trunk/Tools/ChangeLog 2014-03-25 09:53:26 UTC (rev 166228)
+++ trunk/Tools/ChangeLog 2014-03-25 12:13:03 UTC (rev 166229)
@@ -1,3 +1,17 @@
+2014-03-25 Eva Balazsfalvi evab.u-sze...@partner.samsung.com
+
+[webkitpy] Improve _parse_bug_description to recognize more descriptions
+https://bugs.webkit.org/show_bug.cgi?id=130137
+
+Reviewed by Csaba Osztrogonác.
+
+* Scripts/webkitpy/common/checkout/changelog.py:
+(ChangeLogEntry._parse_bug_description):
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+(test_parse_log_entries_from_changelog):
+* Scripts/webkitpy/common/checkout/checkout_unittest.py:
+(CheckoutTest.test_commit_info_for_revision):
+
2014-03-24 Andy Estes aes...@apple.com
Fix the iOS build of TestWebKitAPI.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (166228 => 166229)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-25 09:53:26 UTC (rev 166228)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-25 12:13:03 UTC (rev 166229)
@@ -188,15 +188,16 @@
@classmethod
def _parse_bug_description(cls, text):
-# If line 4 is a bug url, line 3 is the bug description.
-# It's too hard to guess in other cases, so we return None.
+# Line 3 is the bug description in most cases.
lines = text.splitlines()
-if len(lines) 4:
+if len(lines) 3:
return None
-for bug_url in (config_urls.bug_url_short, config_urls.bug_url_long):
-if re.match(^\s* + bug_url + $, lines[3]):
-return lines[2].strip()
-return None
+found_reviewed = re.search(ChangeLogEntry.reviewed_by_regexp, lines[2], re.IGNORECASE)
+found_reviewed_byless = re.search(ChangeLogEntry.reviewed_byless_regexp, lines[2], re.IGNORECASE)
+found_url = parse_bug_id_from_changelog(lines[2])
+if found_reviewed or found_reviewed_byless or found_url:
+return None
+return lines[2].strip()
def _parse_entry(self):
match = re.match(self.date_line_regexp, self._contents, re.MULTILINE)
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (166228 => 166229)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-25 09:53:26 UTC (rev 166228)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-25 12:13:03 UTC (rev 166229)
@@ -241,15 +241,18 @@
self.assertEqual(parsed_entries[0].date(), 2009-08-17)
self.assertEqual(parsed_entries[0].reviewer_text(), David Levin)
self.assertEqual(parsed_entries[0].is_touched_files_text_clean(), False)
+self.assertIsNone(parsed_entries[0].bug_description())
self.assertEqual(parsed_entries[1].date_line(), 2009-08-16 David Kilzer ddkil...@apple.com)
self.assertEqual(parsed_entries[1].date(), 2009-08-16)
self.assertEqual(parsed_entries[1].author_email(), ddkil...@apple.com)
+self.assertEqual(parsed_entries[1].bug_description(), Backed out r47343 which was mistakenly committed)
self.assertEqual(parsed_entries[1].touched_files_text(), * Scripts/bugzilla-tool:\n* Scripts/modules/scm.py:\n)
self.assertEqual(parsed_entries[1].is_touched_files_text_clean(), True)
self.assertEqual(parsed_entries[2].reviewer_text(), Mark Rowe)
self.assertEqual(parsed_entries[2].touched_files(), [DumpRenderTree/mac/DumpRenderTreeWindow.mm])
self.assertEqual(parsed_entries[2].touched_functions(), {DumpRenderTree/mac/DumpRenderTreeWindow.mm: [-[DumpRenderTreeWindow close]]})
self.assertEqual(parsed_entries[2].is_touched_files_text_clean(), False)
+self.assertIsNone(parsed_entries[2].bug_description())
self.assertEqual(parsed_entries[3].author_name(), Benjamin Poulain)
self.assertEqual(parsed_entries[3].touched_files(), [platform/cf/KURLCFNet.cpp,
[webkit-changes] [166230] trunk
Title: [166230] trunk
Revision 166230
Author m.pak...@samsung.com
Date 2014-03-25 05:13:15 -0700 (Tue, 25 Mar 2014)
Log Message
[EFL][WK2] Add NETWORK_PROCESS build option
https://bugs.webkit.org/show_bug.cgi?id=130131
Reviewed by Gyuyoung Kim.
.:
Add option to build EFL port with NETWORK_PROCESS set on. By default NETWORK_PROCESS is
set off.
* Source/cmake/OptionsEfl.cmake:
Source/WebKit2:
* PlatformEfl.cmake: Add file needed to build with NETWORK_PROCESS enabled.
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/cmake/OptionsEfl.cmake
Diff
Modified: trunk/ChangeLog (166229 => 166230)
--- trunk/ChangeLog 2014-03-25 12:13:03 UTC (rev 166229)
+++ trunk/ChangeLog 2014-03-25 12:13:15 UTC (rev 166230)
@@ -1,3 +1,15 @@
+2014-03-25 Michał Pakuła vel Rutka m.pak...@samsung.com
+
+[EFL][WK2] Add NETWORK_PROCESS build option
+https://bugs.webkit.org/show_bug.cgi?id=130131
+
+Reviewed by Gyuyoung Kim.
+
+Add option to build EFL port with NETWORK_PROCESS set on. By default NETWORK_PROCESS is
+set off.
+
+* Source/cmake/OptionsEfl.cmake:
+
2014-03-24 Brian Burg bb...@apple.com
Web Replay: capture and replay keyboard events
Modified: trunk/Source/WebKit2/ChangeLog (166229 => 166230)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 12:13:03 UTC (rev 166229)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 12:13:15 UTC (rev 166230)
@@ -1,3 +1,12 @@
+2014-03-25 Michał Pakuła vel Rutka m.pak...@samsung.com
+
+[EFL][WK2] Add NETWORK_PROCESS build option
+https://bugs.webkit.org/show_bug.cgi?id=130131
+
+Reviewed by Gyuyoung Kim.
+
+* PlatformEfl.cmake: Add file needed to build with NETWORK_PROCESS enabled.
+
2014-03-24 Michał Pakuła vel Rutka m.pak...@samsung.com
[EFL][WK2] Add an API to set process model
Modified: trunk/Source/WebKit2/PlatformEfl.cmake (166229 => 166230)
--- trunk/Source/WebKit2/PlatformEfl.cmake 2014-03-25 12:13:03 UTC (rev 166229)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2014-03-25 12:13:15 UTC (rev 166230)
@@ -236,6 +236,7 @@
${WEBKIT2_DIR}/UIProcess/API/cpp/efl
${WEBKIT2_DIR}/UIProcess/API/efl
${WEBKIT2_DIR}/UIProcess/CoordinatedGraphics
+${WEBKIT2_DIR}/UIProcess/Network/CustomProtocols/soup
${WEBKIT2_DIR}/UIProcess/efl
${WEBKIT2_DIR}/UIProcess/soup
${WEBKIT2_DIR}/WebProcess/efl
@@ -295,6 +296,10 @@
efl/MainEfl.cpp
)
+list(APPEND NetworkProcess_SOURCES
+unix/NetworkMainUnix.cpp
+)
+
list(APPEND WebProcess_LIBRARIES
${CAIRO_LIBRARIES}
${ECORE_IMF_EVAS_LIBRARIES}
Modified: trunk/Source/cmake/OptionsEfl.cmake (166229 => 166230)
--- trunk/Source/cmake/OptionsEfl.cmake 2014-03-25 12:13:03 UTC (rev 166229)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-03-25 12:13:15 UTC (rev 166230)
@@ -80,6 +80,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_INFO ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_PROCESS ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOSNIFF ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PAGE_VISIBILITY_API ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY ON)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166232] trunk
Title: [166232] trunk Revision 166232 Author rga...@webkit.org Date 2014-03-25 06:08:29 -0700 (Tue, 25 Mar 2014) Log Message [EFL] Add ARM64 build support https://bugs.webkit.org/show_bug.cgi?id=130506 Rubber stamped by Gyuyoung Kim. .: * CMakeLists.txt: Set WTF_CPU_ARM64 when aarch64 is defined. Source/ThirdParty: * leveldb/port/atomic_pointer.h: Set ARCH_CPU_ARM_FAMILY when __aarch64__ is defined. Source/WTF: * wtf/Platform.h: Set WTF_CPU_ARM64 when __aarch64__ is defined. Tools: * Scripts/webkitdirs.pm: (isARM): Detect aarch64 as ARM. Modified Paths trunk/CMakeLists.txt trunk/ChangeLog trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/CMakeLists.txt (166231 => 166232) --- trunk/CMakeLists.txt 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/CMakeLists.txt 2014-03-25 13:08:29 UTC (rev 166232) @@ -77,6 +77,8 @@ endif () if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^arm) set(WTF_CPU_ARM 1) +elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^aarch64) +set(WTF_CPU_ARM64 1) elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^mips) set(WTF_CPU_MIPS 1) elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES sh4) Modified: trunk/ChangeLog (166231 => 166232) --- trunk/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* CMakeLists.txt: Set WTF_CPU_ARM64 when aarch64 is defined. + 2014-03-25 Michał Pakuła vel Rutka m.pak...@samsung.com [EFL][WK2] Add NETWORK_PROCESS build option Modified: trunk/Source/ThirdParty/ChangeLog (166231 => 166232) --- trunk/Source/ThirdParty/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/ThirdParty/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* leveldb/port/atomic_pointer.h: Set ARCH_CPU_ARM_FAMILY when __aarch64__ is defined. + 2014-03-14 Landry Breuil lan...@openbsd.org Fix leveldb build on OpenBSD/NetBSD by using the FreeBSD codepaths. Modified: trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h (166231 => 166232) --- trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h 2014-03-25 13:08:29 UTC (rev 166232) @@ -34,7 +34,7 @@ #define ARCH_CPU_X86_FAMILY 1 #elif defined(_M_IX86) || defined(__i386__) || defined(__i386) #define ARCH_CPU_X86_FAMILY 1 -#elif defined(__ARMEL__) +#elif defined(__ARMEL__) || defined(__aarch64__) #define ARCH_CPU_ARM_FAMILY 1 #elif defined(__ppc__) || defined(__powerpc__) || defined(__powerpc64__) #define ARCH_CPU_PPC_FAMILY 1 Modified: trunk/Source/WTF/ChangeLog (166231 => 166232) --- trunk/Source/WTF/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/WTF/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* wtf/Platform.h: Set WTF_CPU_ARM64 when __aarch64__ is defined. + 2014-03-24 Andy Estes aes...@apple.com Fix the iOS build. Modified: trunk/Source/WTF/wtf/Platform.h (166231 => 166232) --- trunk/Source/WTF/wtf/Platform.h 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/WTF/wtf/Platform.h 2014-03-25 13:08:29 UTC (rev 166232) @@ -152,7 +152,7 @@ #endif /* CPU(ARM64) - Apple */ -#if defined(__arm64__) defined(__APPLE__) +#if (defined(__arm64__) defined(__APPLE__)) || defined(__aarch64__) #define WTF_CPU_ARM64 1 #endif Modified: trunk/Tools/ChangeLog (166231 => 166232) --- trunk/Tools/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Tools/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,13 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* Scripts/webkitdirs.pm: +(isARM): Detect aarch64 as ARM. + 2014-03-25 Eva Balazsfalvi evab.u-sze...@partner.samsung.com [webkitpy] Improve _parse_bug_description to recognize more descriptions Modified: trunk/Tools/Scripts/webkitdirs.pm (166231 => 166232) --- trunk/Tools/Scripts/webkitdirs.pm 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Tools/Scripts/webkitdirs.pm 2014-03-25 13:08:29 UTC (rev 166232) @@ -1107,7 +1107,7 @@ sub isARM()
[webkit-changes] [166233] trunk/Source/WebCore
Title: [166233] trunk/Source/WebCore
Revision 166233
Author rga...@webkit.org
Date 2014-03-25 06:14:42 -0700 (Tue, 25 Mar 2014)
Log Message
[ARM64] GNU assembler fails in TransformationMatrix::multiply
https://bugs.webkit.org/show_bug.cgi?id=130454
Reviewed by Zoltan Herczeg.
Change the NEON intstructions to the proper style.
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166232 => 166233)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 13:14:42 UTC (rev 166233)
@@ -1,3 +1,15 @@
+2014-03-25 Gabor Rapcsanyi rga...@webkit.org
+
+[ARM64] GNU assembler fails in TransformationMatrix::multiply
+https://bugs.webkit.org/show_bug.cgi?id=130454
+
+Reviewed by Zoltan Herczeg.
+
+Change the NEON intstructions to the proper style.
+
+* platform/graphics/transforms/TransformationMatrix.cpp:
+(WebCore::TransformationMatrix::multiply):
+
2014-03-20 Sergio Villar Senin svil...@igalia.com
[CSS Grid Layout] Vertical rectangles not considered as valid grid areas
Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (166232 => 166233)
--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2014-03-25 13:08:29 UTC (rev 166232)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2014-03-25 13:14:42 UTC (rev 166233)
@@ -1040,61 +1040,61 @@
const double* rightMatrix = (mat.m_matrix[0][0]);
asm volatile (
// First, load the leftMatrix completely in memory. The leftMatrix is in v16-v23.
-mov x4, %[leftMatrix]\n\t
-ld1.2d {v16, v17, v18, v19}, [%[leftMatrix]], #64\n\t
-ld1.2d {v20, v21, v22, v23}, [%[leftMatrix]]\n\t
+mov x4, %[leftMatrix]\n\t
+ld1 {v16.2d, v17.2d, v18.2d, v19.2d}, [%[leftMatrix]], #64\n\t
+ld1 {v20.2d, v21.2d, v22.2d, v23.2d}, [%[leftMatrix]]\n\t
// First row.
-ld4r.2d {v24, v25, v26, v27}, [%[rightMatrix]], #32\n\t
-fmul.2d v28, v24, v16\n\t
-fmul.2d v29, v24, v17\n\t
-fmla.2d v28, v25, v18\n\t
-fmla.2d v29, v25, v19\n\t
-fmla.2d v28, v26, v20\n\t
-fmla.2d v29, v26, v21\n\t
-fmla.2d v28, v27, v22\n\t
-fmla.2d v29, v27, v23\n\t
+ld4r {v24.2d, v25.2d, v26.2d, v27.2d}, [%[rightMatrix]], #32\n\t
+fmul v28.2d, v24.2d, v16.2d\n\t
+fmul v29.2d, v24.2d, v17.2d\n\t
+fmla v28.2d, v25.2d, v18.2d\n\t
+fmla v29.2d, v25.2d, v19.2d\n\t
+fmla v28.2d, v26.2d, v20.2d\n\t
+fmla v29.2d, v26.2d, v21.2d\n\t
+fmla v28.2d, v27.2d, v22.2d\n\t
+fmla v29.2d, v27.2d, v23.2d\n\t
-ld4r.2d {v0, v1, v2, v3}, [%[rightMatrix]], #32\n\t
-st1.2d {v28, v29}, [x4], #32\n\t
+ld4r {v0.2d, v1.2d, v2.2d, v3.2d}, [%[rightMatrix]], #32\n\t
+st1 {v28.2d, v29.2d}, [x4], #32\n\t
// Second row.
-fmul.2d v30, v0, v16\n\t
-fmul.2d v31, v0, v17\n\t
-fmla.2d v30, v1, v18\n\t
-fmla.2d v31, v1, v19\n\t
-fmla.2d v30, v2, v20\n\t
-fmla.2d v31, v2, v21\n\t
-fmla.2d v30, v3, v22\n\t
-fmla.2d v31, v3, v23\n\t
+fmul v30.2d, v0.2d, v16.2d\n\t
+fmul v31.2d, v0.2d, v17.2d\n\t
+fmla v30.2d, v1.2d, v18.2d\n\t
+fmla v31.2d, v1.2d, v19.2d\n\t
+fmla v30.2d, v2.2d, v20.2d\n\t
+fmla v31.2d, v2.2d, v21.2d\n\t
+fmla v30.2d, v3.2d, v22.2d\n\t
+fmla v31.2d, v3.2d, v23.2d\n\t
-ld4r.2d {v24, v25, v26, v27}, [%[rightMatrix]], #32\n\t
-st1.2d {v30, v31}, [x4], #32\n\t
+ld4r {v24.2d, v25.2d, v26.2d, v27.2d}, [%[rightMatrix]], #32\n\t
+st1 {v30.2d, v31.2d}, [x4], #32\n\t
// Third row.
-fmul.2d v28, v24, v16\n\t
-fmul.2d v29, v24, v17\n\t
-fmla.2d v28, v25, v18\n\t
-fmla.2d v29, v25, v19\n\t
-fmla.2d v28, v26, v20\n\t
-fmla.2d v29, v26, v21\n\t
-fmla.2d v28, v27, v22\n\t
-fmla.2d v29, v27, v23\n\t
+fmul v28.2d, v24.2d, v16.2d\n\t
+fmul v29.2d, v24.2d, v17.2d\n\t
+fmla v28.2d, v25.2d, v18.2d\n\t
+fmla v29.2d, v25.2d, v19.2d\n\t
+fmla v28.2d, v26.2d, v20.2d\n\t
+fmla v29.2d, v26.2d, v21.2d\n\t
+fmla v28.2d, v27.2d, v22.2d\n\t
+fmla v29.2d, v27.2d, v23.2d\n\t
-ld4r.2d {v0, v1, v2, v3}, [%[rightMatrix]], #32\n\t
-st1.2d {v28, v29}, [x4], #32\n\t
+ld4r {v0.2d, v1.2d, v2.2d, v3.2d}, [%[rightMatrix]], #32\n\t
+st1 {v28.2d, v29.2d}, [x4], #32\n\t
// Fourth row.
-
[webkit-changes] [166234] trunk/Source/WTF
Title: [166234] trunk/Source/WTF Revision 166234 Author rga...@webkit.org Date 2014-03-25 07:13:07 -0700 (Tue, 25 Mar 2014) Log Message [ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap https://bugs.webkit.org/show_bug.cgi?id=130500 Reviewed by Filip Pizlo. Set the first operand to the exact register in the inline assembly with GCC. * wtf/Atomics.h: (WTF::weakCompareAndSwap): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Atomics.h Diff Modified: trunk/Source/WTF/ChangeLog (166233 => 166234) --- trunk/Source/WTF/ChangeLog 2014-03-25 13:14:42 UTC (rev 166233) +++ trunk/Source/WTF/ChangeLog 2014-03-25 14:13:07 UTC (rev 166234) @@ -1,5 +1,17 @@ 2014-03-25 Gabor Rapcsanyi rga...@webkit.org +[ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap +https://bugs.webkit.org/show_bug.cgi?id=130500 + +Reviewed by Filip Pizlo. + +Set the first operand to the exact register in the inline assembly with GCC. + +* wtf/Atomics.h: +(WTF::weakCompareAndSwap): + +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + [EFL] Add ARM64 build support https://bugs.webkit.org/show_bug.cgi?id=130506 Modified: trunk/Source/WTF/wtf/Atomics.h (166233 => 166234) --- trunk/Source/WTF/wtf/Atomics.h 2014-03-25 13:14:42 UTC (rev 166233) +++ trunk/Source/WTF/wtf/Atomics.h 2014-03-25 14:13:07 UTC (rev 166234) @@ -112,6 +112,20 @@ : r(expected), r(newValue) : memory); result = !result; +#elif CPU(ARM64) COMPILER(GCC) +unsigned tmp; +unsigned result; +asm volatile( +mov %w1, #1\n\t +ldxr %w2, [%0]\n\t +cmp %w3, %w2\n\t +b.ne 0f\n\t +stxr %w1, %w4, [%0]\n\t +0: +: +r(location), =r(result), =r(tmp) +: r(expected), r(newValue) +: memory); +result = !result; #elif CPU(ARM64) unsigned tmp; unsigned result; @@ -152,6 +166,20 @@ : memory ); return result; +#elif CPU(ARM64) COMPILER(GCC) +bool result; +void* tmp; +asm volatile( +mov %w1, #1\n\t +ldxr %x2, [%0]\n\t +cmp %x3, %x2\n\t +b.ne 0f\n\t +stxr %w1, %x4, [%0]\n\t +0: +: +r(location), =r(result), =r(tmp) +: r(expected), r(newValue) +: memory); +return !result; #elif CPU(ARM64) bool result; void* tmp; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166236] trunk
Title: [166236] trunk
Revision 166236
Author ddkil...@apple.com
Date 2014-03-25 09:42:15 -0700 (Tue, 25 Mar 2014)
Log Message
Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
http://webkit.org/b/130713
rdar://problem/15661876
Reviewed by Darin Adler.
Merged from Blink (patch by Ian Beer):
http://crbug.com/303657
https://src.chromium.org/viewvc/blink?view=revrevision=158938
Source/WebCore:
Test: fast/forms/form-submission-crash-successful-submit-button.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
LayoutTests:
* fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
* fast/forms/form-submission-crash-successful-submit-button.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt
trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166235 => 166236)
--- trunk/LayoutTests/ChangeLog 2014-03-25 15:53:39 UTC (rev 166235)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 16:42:15 UTC (rev 166236)
@@ -1,3 +1,18 @@
+2014-03-25 David Kilzer ddkil...@apple.com
+
+Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
+http://webkit.org/b/130713
+rdar://problem/15661876
+
+Reviewed by Darin Adler.
+
+Merged from Blink (patch by Ian Beer):
+http://crbug.com/303657
+https://src.chromium.org/viewvc/blink?view=revrevision=158938
+
+* fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
+* fast/forms/form-submission-crash-successful-submit-button.html: Added.
+
2014-03-20 Sergio Villar Senin svil...@igalia.com
[CSS Grid Layout] Vertical rectangles not considered as valid grid areas
Added: trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt (0 => 166236)
--- trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt 2014-03-25 16:42:15 UTC (rev 166236)
@@ -0,0 +1,5 @@
+PASS if not crashed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html (0 => 166236)
--- trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html (rev 0)
+++ trunk/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html 2014-03-25 16:42:15 UTC (rev 166236)
@@ -0,0 +1,37 @@
+!DOCTYPE html
+body
+script src=""
+script
+jsTestIsAsync = true;
+var form1;
+var submit1;
+
+function start() {
+form1 = document.createElement('form');
+submit1 = document.createElement('input');
+submit2 = document.createElement('input');
+submit1.type = 'submit';
+submit2.type = 'image';
+form1.addEventListener('submit', handleSubmit, false);
+form1.action = '';
+form1.appendChild(submit1);
+form1.appendChild(submit2);
+submit1.click();
+testPassed('if not crashed.');
+finishJSTest();
+}
+
+function handleSubmit() {
+form1.removeChild(submit1);
+}
+
+function removeImage() {
+form1.removeChild(submit2);
+submit2 = null;
+gc();
+}
+
+window._onload_ = start;
+/script
+script src=""
+/body
Modified: trunk/Source/WebCore/ChangeLog (166235 => 166236)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 15:53:39 UTC (rev 166235)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 16:42:15 UTC (rev 166236)
@@ -1,3 +1,20 @@
+2014-03-25 David Kilzer ddkil...@apple.com
+
+Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
+http://webkit.org/b/130713
+rdar://problem/15661876
+
+Reviewed by Darin Adler.
+
+Merged from Blink (patch by Ian Beer):
+http://crbug.com/303657
+https://src.chromium.org/viewvc/blink?view=revrevision=158938
+
+Test: fast/forms/form-submission-crash-successful-submit-button.html
+
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::submit):
+
2014-03-25 Gabor Rapcsanyi rga...@webkit.org
[ARM64] GNU assembler fails in TransformationMatrix::multiply
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (166235 => 166236)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-03-25 15:53:39 UTC (rev 166235)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-03-25 16:42:15 UTC (rev 166236)
@@ -333,7 +333,7 @@
m_isSubmittingOrPreparingForSubmission = true;
m_wasUserSubmitted = processingUserGesture;
-HTMLFormControlElement* firstSuccessfulSubmitButton = 0;
+RefPtrHTMLFormControlElement firstSuccessfulSubmitButton;
bool needButtonActivation =
[webkit-changes] [166237] trunk/LayoutTests
Title: [166237] trunk/LayoutTests Revision 166237 Author a...@apple.com Date 2014-03-25 09:44:33 -0700 (Tue, 25 Mar 2014) Log Message media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html frequently fails on EWS https://bugs.webkit.org/show_bug.cgi?id=130720 * platform/mac/TestExpectations: Marked as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (166236 => 166237) --- trunk/LayoutTests/ChangeLog 2014-03-25 16:42:15 UTC (rev 166236) +++ trunk/LayoutTests/ChangeLog 2014-03-25 16:44:33 UTC (rev 166237) @@ -1,3 +1,10 @@ +2014-03-25 Alexey Proskuryakov a...@apple.com + +media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html frequently fails on EWS +https://bugs.webkit.org/show_bug.cgi?id=130720 + +* platform/mac/TestExpectations: Marked as flaky. + 2014-03-25 David Kilzer ddkil...@apple.com Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit Modified: trunk/LayoutTests/platform/mac/TestExpectations (166236 => 166237) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-03-25 16:42:15 UTC (rev 166236) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-03-25 16:44:33 UTC (rev 166237) @@ -1340,3 +1340,6 @@ webkit.org/b/130490 media/video-remote-control-playpause.html [ Pass Failure ] webkit.org/b/130693 mathml/presentation/tokenElements-background-color.html [ ImageOnlyFailure ] + +# Frequently times out on EWS, which is then misreported as crash. +webkit.org/b/130720 [ MountainLion Release ] media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html [ Pass Failure Crash Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166238] trunk
Title: [166238] trunk
Revision 166238
Author bfulg...@apple.com
Date 2014-03-25 09:51:40 -0700 (Tue, 25 Mar 2014)
Log Message
Prevent 'removetrack' events from firing when all inband text tracks are removed.
https://bugs.webkit.org/show_bug.cgi?id=130704
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-remove-track.html
Based on the Blink change (patch by acolw...@chromium.org):
https://codereview.chromium.org/177243018/
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad): Reorder steps to match W3C specification.
(WebCore::HTMLMediaElement::noneSupported): Forget tracks as required by specification.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Forget tracks as required by specification.
(WebCore::HTMLMediaElement::removeTextTrack): Only request the 'removetracks' event if
requested by caller.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Renamed to 'forgetResourceSpecificTracks'
(WebCore::HTMLMediaElement::noneSupported): Specify that we want the 'removetracks' event
fired for this use case.
(WebCore::HTMLMediaElement::prepareForLoad): Switch to new 'forgetResourceSpecificTracks' name.
* html/HTMLMediaElement.h:
* html/track/TextTrackList.cpp:
(TextTrackList::remove): Only fire the 'removetrack' event if the caller requests it.
* html/track/TextTrackList.h: Add default argument to fire the 'removetrack' event
when removing a track.
* html/track/TrackListBase.cpp:
(TrackListBase::remove): Only fire the 'removetrack' event if the caller requests it.
* html/track/TrackListBase.h: Add default argument to fire the 'removetrack' event.
LayoutTests:
Based on the Blink change (patch by acolw...@chromium.org):
https://codereview.chromium.org/177243018/
* media/track/track-remove-track-expected.txt: Added.
* media/track/track-remove-track.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/track/TextTrackList.cpp
trunk/Source/WebCore/html/track/TextTrackList.h
trunk/Source/WebCore/html/track/TrackListBase.cpp
trunk/Source/WebCore/html/track/TrackListBase.h
Added Paths
trunk/LayoutTests/media/track/track-remove-track-expected.txt
trunk/LayoutTests/media/track/track-remove-track.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166237 => 166238)
--- trunk/LayoutTests/ChangeLog 2014-03-25 16:44:33 UTC (rev 166237)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 16:51:40 UTC (rev 166238)
@@ -1,3 +1,16 @@
+2014-03-24 Brent Fulgham bfulg...@apple.com
+
+Prevent 'removetrack' events from firing when all inband text tracks are removed.
+https://bugs.webkit.org/show_bug.cgi?id=130704
+
+Reviewed by Eric Carlson.
+
+Based on the Blink change (patch by acolw...@chromium.org):
+https://codereview.chromium.org/177243018/
+
+* media/track/track-remove-track-expected.txt: Added.
+* media/track/track-remove-track.html: Added.
+
2014-03-25 Alexey Proskuryakov a...@apple.com
media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html frequently fails on EWS
Added: trunk/LayoutTests/media/track/track-remove-track-expected.txt (0 => 166238)
--- trunk/LayoutTests/media/track/track-remove-track-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-remove-track-expected.txt 2014-03-25 16:51:40 UTC (rev 166238)
@@ -0,0 +1,4 @@
+
+PASS Tests that the 'removetrack' event is fired when an out-of-band TextTrack is removed.
+PASS Tests that the 'removetrack' event is NOT fired for inband TextTrack on a failed load.
+
Added: trunk/LayoutTests/media/track/track-remove-track.html (0 => 166238)
--- trunk/LayoutTests/media/track/track-remove-track.html (rev 0)
+++ trunk/LayoutTests/media/track/track-remove-track.html 2014-03-25 16:51:40 UTC (rev 166238)
@@ -0,0 +1,107 @@
+!DOCTYPE html
+html
+head
+meta http-equiv=Content-Type content=text/html; charset=utf-8 /
+
+script src=""
+script src=""
+script src=""
+script src=""
+/head
+body
+script
+async_test(function(test)
+{
+var video = document.createElement(video);
+var track;
+
+function trackRemoved()
+{
+assert_equals(event.target, video.textTracks);
+assert_equals(event instanceof window.TrackEvent, true);
+assert_equals(event.track, track);
+test.done();
+}
+
+var trackElement = document.createElement('track');
+video.appendChild(trackElement);
+
+trackElement.src = '';
+trackElement.track.mode = 'hidden';
+
+assert_equals(video.textTracks.length, 1);
+
+track = video.textTracks[0];
+
[webkit-changes] [166240] trunk
Title: [166240] trunk
Revision 166240
Author oli...@apple.com
Date 2014-03-25 11:00:30 -0700 (Tue, 25 Mar 2014)
Log Message
ASSERTION FAILED in Parser: dst != localReg
https://bugs.webkit.org/show_bug.cgi?id=130710
Reviewed by Filip Pizlo.
Source/_javascript_Core:
Just make sure we don't try to write to a captured constant,
following the change to track captured variables separately.
* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
LayoutTests:
New testcases.
* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/parser-syntax-check-expected.txt
trunk/LayoutTests/js/script-tests/parser-syntax-check.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (166239 => 166240)
--- trunk/LayoutTests/ChangeLog 2014-03-25 17:45:52 UTC (rev 166239)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 18:00:30 UTC (rev 166240)
@@ -1,3 +1,15 @@
+2014-03-24 Oliver Hunt oli...@apple.com
+
+ASSERTION FAILED in Parser: dst != localReg
+https://bugs.webkit.org/show_bug.cgi?id=130710
+
+Reviewed by Filip Pizlo.
+
+New testcases.
+
+* js/parser-syntax-check-expected.txt:
+* js/script-tests/parser-syntax-check.js:
+
2014-03-24 Brent Fulgham bfulg...@apple.com
Prevent 'removetrack' events from firing when all inband text tracks are removed.
Modified: trunk/LayoutTests/js/parser-syntax-check-expected.txt (166239 => 166240)
--- trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 17:45:52 UTC (rev 166239)
+++ trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 18:00:30 UTC (rev 166240)
@@ -350,6 +350,30 @@
PASS Invalid: function f() { var a = b ? c, b }
PASS Invalid: const a = b : c
PASS Invalid: function f() { const a = b : c }
+PASS Valid: const a = 7; eval(''); a++
+PASS Valid: function f() { const a = 7; eval(''); a++ }
+PASS Valid: const a = 7; eval(''); a--
+PASS Valid: function f() { const a = 7; eval(''); a-- }
+PASS Valid: const a = 7; with({}) a++
+PASS Valid: function f() { const a = 7; with({}) a++ }
+PASS Valid: const a = 7; with({}) a--
+PASS Valid: function f() { const a = 7; with({}) a-- }
+PASS Valid: const a = 7; eval(''); a+=1
+PASS Valid: function f() { const a = 7; eval(''); a+=1 }
+PASS Valid: const a = 7; eval(''); a-=1
+PASS Valid: function f() { const a = 7; eval(''); a-=1 }
+PASS Valid: const a = 7; with({}) a+=1
+PASS Valid: function f() { const a = 7; with({}) a+=1 }
+PASS Valid: const a = 7; with({}) a-=1
+PASS Valid: function f() { const a = 7; with({}) a-=1 }
+PASS Valid: const a = 7; eval(''); a=1
+PASS Valid: function f() { const a = 7; eval(''); a=1 }
+PASS Valid: const a = 7; eval(''); a=1
+PASS Valid: function f() { const a = 7; eval(''); a=1 }
+PASS Valid: const a = 7; with({}) a=1
+PASS Valid: function f() { const a = 7; with({}) a=1 }
+PASS Valid: const a = 7; with({}) a=1
+PASS Valid: function f() { const a = 7; with({}) a=1 }
for statement
PASS Valid: for ( ; ; ) { break }
PASS Valid: function f() { for ( ; ; ) { break } }
Modified: trunk/LayoutTests/js/script-tests/parser-syntax-check.js (166239 => 166240)
--- trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 17:45:52 UTC (rev 166239)
+++ trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 18:00:30 UTC (rev 166240)
@@ -241,7 +241,20 @@
valid (var a = a in b in c instanceof d);
invalid(var a = b ? c, b);
invalid(const a = b : c);
+valid(const a = 7; eval(''); a++);
+valid(const a = 7; eval(''); a--);
+valid(const a = 7; with({}) a++);
+valid(const a = 7; with({}) a--);
+valid(const a = 7; eval(''); a+=1);
+valid(const a = 7; eval(''); a-=1);
+valid(const a = 7; with({}) a+=1);
+valid(const a = 7; with({}) a-=1);
+valid(const a = 7; eval(''); a=1);
+valid(const a = 7; eval(''); a=1);
+valid(const a = 7; with({}) a=1);
+valid(const a = 7; with({}) a=1);
+
debug (for statement);
valid (for ( ; ; ) { break });
Modified: trunk/Source/_javascript_Core/ChangeLog (166239 => 166240)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-25 17:45:52 UTC (rev 166239)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-25 18:00:30 UTC (rev 166240)
@@ -1,3 +1,17 @@
+2014-03-24 Oliver Hunt oli...@apple.com
+
+ASSERTION FAILED in Parser: dst != localReg
+https://bugs.webkit.org/show_bug.cgi?id=130710
+
+Reviewed by Filip Pizlo.
+
+Just make sure we don't try to write to a captured constant,
+following the change to track captured variables separately.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::PostfixNode::emitResolve):
+(JSC::PrefixNode::emitResolve):
+
2014-03-25 Martin Robinson mrobin...@igalia.com
[GTK] Remove the autotools build
[webkit-changes] [166241] trunk
Title: [166241] trunk
Revision 166241
Author ander...@apple.com
Date 2014-03-25 12:17:54 -0700 (Tue, 25 Mar 2014)
Log Message
Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=130732
Reviewed by Tim Horton.
Source/WebKit2:
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView validateUserInterfaceItem:]):
(-[WKWebView goBack:]):
(-[WKWebView goForward:]):
(-[WKWebView stopLoading:]):
Tools:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166240 => 166241)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 18:00:30 UTC (rev 166240)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 19:17:54 UTC (rev 166241)
@@ -1,3 +1,19 @@
+2014-03-25 Anders Carlsson ander...@apple.com
+
+Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=130732
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView goBack]):
+(-[WKWebView goForward]):
+(-[WKWebView validateUserInterfaceItem:]):
+(-[WKWebView goBack:]):
+(-[WKWebView goForward:]):
+(-[WKWebView stopLoading:]):
+
2014-03-25 Martin Robinson mrobin...@igalia.com
[GTK] Remove the autotools build
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (166240 => 166241)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-25 18:00:30 UTC (rev 166240)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-25 19:17:54 UTC (rev 166241)
@@ -89,8 +89,6 @@
*/
- (WKNavigation *)goToBackForwardListItem:(WKBackForwardListItem *)item;
-- (IBAction)stopLoading:(id)sender;
-
@property (nonatomic, readonly) NSString *title;
/*! @abstract The active URL. @link WKWebView @/link is KVO-compliant for this property.
@@ -117,8 +115,8 @@
@property (readonly) BOOL canGoBack;
@property (readonly) BOOL canGoForward;
-- (void)goBack;
-- (void)goForward;
+- (WKNavigation *)goBack;
+- (WKNavigation *)goForward;
@property (nonatomic) BOOL allowsBackForwardNavigationGestures;
@@ -133,4 +131,13 @@
@end
+@interface WKWebView (WKIBActions) NSUserInterfaceValidations
+
+- (IBAction)goBack:(id)sender;
+- (IBAction)goForward:(id)sender;
+
+- (IBAction)stopLoading:(id)sender;
+
+@end
+
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166240 => 166241)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-25 18:00:30 UTC (rev 166240)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-25 19:17:54 UTC (rev 166241)
@@ -256,11 +256,6 @@
return nil;
}
-- (IBAction)stopLoading:(id)sender
-{
-_page-stopLoading();
-}
-
- (NSString *)title
{
return _page-pageLoadState().title();
@@ -298,16 +293,20 @@
return !!_page-backForwardList().forwardItem();
}
-// FIXME: This should return a WKNavigation object.
-- (void)goBack
+- (WKNavigation *)goBack
{
_page-goBack();
+
+// FIXME: Return a navigation object.
+return nil;
}
-// FIXME: This should return a WKNavigation object.
-- (void)goForward
+- (WKNavigation *)goForward
{
_page-goForward();
+
+// FIXME: Return a navigation object.
+return nil;
}
#pragma mark iOS-specific methods
@@ -1177,4 +1176,41 @@
@end
+@implementation WKWebView (WKIBActions)
+
+- (BOOL)validateUserInterfaceItem:(id NSValidatedUserInterfaceItem)item
+{
+SEL action = ""
+
+if (action == @selector(goBack:))
+return !!_page-backForwardList().backItem();
+
+if (action == @selector(goForward:))
+return !!_page-backForwardList().forwardItem();
+
+if (action == @selector(stopLoading:)) {
+// FIXME: Return no if we're stopped.
+return YES;
+}
+
+return NO;
+}
+
+- (IBAction)goBack:(id)sender
+{
+[self goBack];
+}
+
+- (IBAction)goForward:(id)sender
+{
+[self goForward];
+}
+
+- (IBAction)stopLoading:(id)sender
+{
+_page-stopLoading();
+}
+
+@end
+
#endif // WK_API_ENABLED
Modified: trunk/Tools/ChangeLog (166240 => 166241)
--- trunk/Tools/ChangeLog 2014-03-25 18:00:30 UTC (rev 166240)
+++ trunk/Tools/ChangeLog 2014-03-25 19:17:54 UTC (rev 166241)
@@ -1,3 +1,13 @@
+2014-03-25 Anders Carlsson ander...@apple.com
+
+Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=130732
+
+Reviewed by Tim
[webkit-changes] [166242] trunk/Tools
Title: [166242] trunk/Tools
Revision 166242
Author aes...@apple.com
Date 2014-03-25 12:48:15 -0700 (Tue, 25 Mar 2014)
Log Message
Add some debug logging to an API test that's failing on Mountain Lion.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _downloadDidFinish:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm
Diff
Modified: trunk/Tools/ChangeLog (166241 => 166242)
--- trunk/Tools/ChangeLog 2014-03-25 19:17:54 UTC (rev 166241)
+++ trunk/Tools/ChangeLog 2014-03-25 19:48:15 UTC (rev 166242)
@@ -1,3 +1,11 @@
+2014-03-25 Andy Estes aes...@apple.com
+
+Add some debug logging to an API test that's failing on Mountain Lion.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+(-[DownloadDelegate _download:didReceiveResponse:]):
+(-[DownloadDelegate _downloadDidFinish:]):
+
2014-03-25 Anders Carlsson ander...@apple.com
Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (166241 => 166242)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 19:17:54 UTC (rev 166241)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 19:48:15 UTC (rev 166242)
@@ -78,6 +78,8 @@
- (void)_download:(_WKDownload *)download didReceiveResponse:(NSURLResponse *)response
{
+NSLog(@[response sourceURL]: %@\n, [response URL]);
+NSLog(@[self sourceURL]: %@\n, [self sourceURL]);
EXPECT_EQ(_download, download);
EXPECT_TRUE(_expectedContentLength == 0);
EXPECT_TRUE(_receivedContentLength == 0);
@@ -106,6 +108,8 @@
- (void)_downloadDidFinish:(_WKDownload *)download
{
+NSLog(@_expectedContentLength: %lld\n, _expectedContentLength);
+NSLog(@_receivedContentLength: %llu\n, _receivedContentLength);
EXPECT_EQ(_download, download);
EXPECT_TRUE(_expectedContentLength == NSURLResponseUnknownLength || static_castuint64_t(_expectedContentLength) == _receivedContentLength);
EXPECT_TRUE([[NSFileManager defaultManager] contentsEqualAtPath:_destinationPath andPath:[_sourceURL path]]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166243] trunk
Title: [166243] trunk
Revision 166243
Author oli...@apple.com
Date 2014-03-25 13:06:07 -0700 (Tue, 25 Mar 2014)
Log Message
AST incorrectly conflates readable and writable locations
https://bugs.webkit.org/show_bug.cgi?id=130734
Reviewed by Filip Pizlo.
Source/_javascript_Core:
We need to distinguish between locations that are valid for reading
and writing, vs those that may only be written.
* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
* parser/Nodes.h:
(JSC::ExpressionNode::isAssignmentLocation):
LayoutTests:
More tests
* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/parser-syntax-check-expected.txt
trunk/LayoutTests/js/script-tests/parser-syntax-check.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/Nodes.h
Diff
Modified: trunk/LayoutTests/ChangeLog (166242 => 166243)
--- trunk/LayoutTests/ChangeLog 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 20:06:07 UTC (rev 166243)
@@ -1,3 +1,15 @@
+2014-03-25 Oliver Hunt oli...@apple.com
+
+AST incorrectly conflates readable and writable locations
+https://bugs.webkit.org/show_bug.cgi?id=130734
+
+Reviewed by Filip Pizlo.
+
+More tests
+
+* js/parser-syntax-check-expected.txt:
+* js/script-tests/parser-syntax-check.js:
+
2014-03-24 Oliver Hunt oli...@apple.com
ASSERTION FAILED in Parser: dst != localReg
Modified: trunk/LayoutTests/js/parser-syntax-check-expected.txt (166242 => 166243)
--- trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 20:06:07 UTC (rev 166243)
@@ -738,6 +738,22 @@
PASS Valid: function f() { var [x]=1 }
PASS Valid: ({[x]: 1})
PASS Valid: function f() { ({[x]: 1}) }
+PASS Valid: delete ({a}=1)
+PASS Valid: function f() { delete ({a}=1) }
+PASS Valid: delete ({a:a}=1)
+PASS Valid: function f() { delete ({a:a}=1) }
+PASS Valid: ({a}=1)()
+PASS Valid: function f() { ({a}=1)() }
+PASS Valid: ({a:a}=1)()
+PASS Valid: function f() { ({a:a}=1)() }
+PASS Valid: ({a}=1)=1
+PASS Valid: function f() { ({a}=1)=1 }
+PASS Valid: ({a:a}=1)=1
+PASS Valid: function f() { ({a:a}=1)=1 }
+PASS Valid: ({a}=1=1)
+PASS Valid: function f() { ({a}=1=1) }
+PASS Valid: ({a:a}=1=1)
+PASS Valid: function f() { ({a:a}=1=1) }
PASS Invalid: ({get [x](){}})
PASS Invalid: function f() { ({get [x](){}}) }
PASS Invalid: ({set [x](){}})
Modified: trunk/LayoutTests/js/script-tests/parser-syntax-check.js (166242 => 166243)
--- trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 20:06:07 UTC (rev 166243)
@@ -453,6 +453,14 @@
valid([x]=1)
valid(var [x]=1)
valid(({[x]: 1}))
+valid(delete ({a}=1))
+valid(delete ({a:a}=1))
+valid(({a}=1)())
+valid(({a:a}=1)())
+valid(({a}=1)=1)
+valid(({a:a}=1)=1)
+valid(({a}=1=1))
+valid(({a:a}=1=1))
invalid(({get [x](){}}))
invalid(({set [x](){}}))
invalid(({[...x]: 1}))
Modified: trunk/Source/_javascript_Core/ChangeLog (166242 => 166243)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-25 20:06:07 UTC (rev 166243)
@@ -1,3 +1,19 @@
+2014-03-25 Oliver Hunt oli...@apple.com
+
+AST incorrectly conflates readable and writable locations
+https://bugs.webkit.org/show_bug.cgi?id=130734
+
+Reviewed by Filip Pizlo.
+
+We need to distinguish between locations that are valid for reading
+and writing, vs those that may only be written.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::ForInNode::emitBytecode):
+(JSC::ForOfNode::emitBytecode):
+* parser/Nodes.h:
+(JSC::ExpressionNode::isAssignmentLocation):
+
2014-03-24 Oliver Hunt oli...@apple.com
ASSERTION FAILED in Parser: dst != localReg
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (166242 => 166243)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2014-03-25 20:06:07 UTC (rev 166243)
@@ -1805,7 +1805,7 @@
{
LabelScopePtr scope = generator.newLabelScope(LabelScope::Loop);
-if (!m_lexpr-isLocation()) {
+if (!m_lexpr-isAssignmentLocation()) {
emitThrowReferenceError(generator, Left side of for-in statement is not a reference.);
return;
}
@@ -1901,7 +1901,7 @@
// -- ForOfNode
void ForOfNode::emitBytecode(BytecodeGenerator generator, RegisterID* dst)
{
-if
[webkit-changes] [166244] trunk/Source/WebKit2
Title: [166244] trunk/Source/WebKit2 Revision 166244 Author ander...@apple.com Date 2014-03-25 13:10:02 -0700 (Tue, 25 Mar 2014) Log Message Begin stubbing out a WKWindowFeatures class https://bugs.webkit.org/show_bug.cgi?id=130733 Reviewed by Dan Bernstein. * UIProcess/API/Cocoa/WKWindowFeatures.h: Added. * UIProcess/API/Cocoa/WKWindowFeatures.mm: Added. (-[WKWindowFeatures _initWithWindowFeatures:WebCore::]): (-[WKWindowFeatures x]): (-[WKWindowFeatures y]): (-[WKWindowFeatures width]): (-[WKWindowFeatures height]): * UIProcess/API/Cocoa/WKWindowFeaturesInternal.h: Added. * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesInternal.h Diff Modified: trunk/Source/WebKit2/ChangeLog (166243 => 166244) --- trunk/Source/WebKit2/ChangeLog 2014-03-25 20:06:07 UTC (rev 166243) +++ trunk/Source/WebKit2/ChangeLog 2014-03-25 20:10:02 UTC (rev 166244) @@ -1,5 +1,22 @@ 2014-03-25 Anders Carlsson ander...@apple.com +Begin stubbing out a WKWindowFeatures class +https://bugs.webkit.org/show_bug.cgi?id=130733 + +Reviewed by Dan Bernstein. + +* UIProcess/API/Cocoa/WKWindowFeatures.h: Added. +* UIProcess/API/Cocoa/WKWindowFeatures.mm: Added. +(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]): +(-[WKWindowFeatures x]): +(-[WKWindowFeatures y]): +(-[WKWindowFeatures width]): +(-[WKWindowFeatures height]): +* UIProcess/API/Cocoa/WKWindowFeaturesInternal.h: Added. +* WebKit2.xcodeproj/project.pbxproj: + +2014-03-25 Anders Carlsson ander...@apple.com + Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView https://bugs.webkit.org/show_bug.cgi?id=130732 Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h (0 => 166244) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h (rev 0) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 20:10:02 UTC (rev 166244) @@ -0,0 +1,41 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +#import Foundation/Foundation.h +#import WebKit2/WKFoundation.h + +#if WK_API_ENABLED + +WK_API_CLASS +@interface WKWindowFeatures : NSObject + +@property (nonatomic, readonly) NSNumber *x; +@property (nonatomic, readonly) NSNumber *y; +@property (nonatomic, readonly) NSNumber *width; +@property (nonatomic, readonly) NSNumber *height; + +@end + +#endif Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm (0 => 166244) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm (rev 0) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 20:10:02 UTC (rev 166244) @@ -0,0 +1,80 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC.
[webkit-changes] [166246] trunk
Title: [166246] trunk
Revision 166246
Author k...@webkit.org
Date 2014-03-25 13:24:14 -0700 (Tue, 25 Mar 2014)
Log Message
Implement ImageData constructors and WebWorkers exposure
https://bugs.webkit.org/show_bug.cgi?id=130668
Reviewed by Dean Jackson.
Source/WebCore:
Add new constructors for ImageData.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
Test: fast/canvas/canvas-imageData.html
* html/ImageData.cpp:
(WebCore::ImageData::create):
* html/ImageData.h:
* html/ImageData.idl:
LayoutTests:
Tests for ImageData constructors. Remove a false tests for constructors
from Philip's test suite.
* fast/canvas/canvas-imageData-expected.txt: Added.
* fast/canvas/canvas-imageData.html: Added.
* fast/canvas/script-tests/canvas-imageData.js: Added.
(testTransparentBlack):
* LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html: Removed.
* LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt: Removed.
* LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
* LayoutTests/js/dom/global-constructors-attributes-shared-worker-expected.txt
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/LayoutTests/js/dom/global-constructors-attributes-shared-worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ImageData.cpp
trunk/Source/WebCore/html/ImageData.h
trunk/Source/WebCore/html/ImageData.idl
Added Paths
trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt
trunk/LayoutTests/fast/canvas/canvas-imageData.html
trunk/LayoutTests/fast/canvas/script-tests/canvas-imageData.js
Removed Paths
trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt
trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166245 => 166246)
--- trunk/LayoutTests/ChangeLog 2014-03-25 20:15:14 UTC (rev 166245)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 20:24:14 UTC (rev 166246)
@@ -1,3 +1,22 @@
+2014-03-25 Dirk Schulze k...@webkit.org
+
+Implement ImageData constructors and WebWorkers exposure
+https://bugs.webkit.org/show_bug.cgi?id=130668
+
+Reviewed by Dean Jackson.
+
+Tests for ImageData constructors. Remove a false tests for constructors
+from Philip's test suite.
+
+* fast/canvas/canvas-imageData-expected.txt: Added.
+* fast/canvas/canvas-imageData.html: Added.
+* fast/canvas/script-tests/canvas-imageData.js: Added.
+(testTransparentBlack):
+* LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html: Removed.
+* LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt: Removed.
+* LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
+* LayoutTests/js/dom/global-constructors-attributes-shared-worker-expected.txt
+
2014-03-25 Myles C. Maxfield mmaxfi...@apple.com
InlineIterator position (unsigned int) variable can wrap around
Deleted: trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt (166245 => 166246)
--- trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt 2014-03-25 20:15:14 UTC (rev 166245)
+++ trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt 2014-03-25 20:24:14 UTC (rev 166246)
@@ -1 +0,0 @@
-Passed
Deleted: trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html (166245 => 166246)
--- trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html 2014-03-25 20:15:14 UTC (rev 166245)
+++ trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html 2014-03-25 20:24:14 UTC (rev 166246)
@@ -1,21 +0,0 @@
-!DOCTYPE html
-titleCanvas test: 2d.imageData.object.ctor/title
-script src=""
-link rel=stylesheet href=""
-body
-p id=passtextPass/p
-p id=failtextFail/p
-p class=outputThese images should be identical:/p
-canvas id=c class=output width=100 height=50p class=fallbackFAIL (fallback content)/p/canvas
-
-ul id=d/ul
-script
-_addTest(function(canvas, ctx) {
-
-_assertDifferent(window.ImageData, undefined, window.ImageData, undefined);
-try { var _thrown = false; new window.ImageData(1,1); } catch (e) { _thrown = true; } finally { _assert(_thrown, should throw exception: new window.ImageData(1,1)); }
-
-
-});
-/script
-
Added: trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt (0 => 166246)
--- trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt 2014-03-25 20:24:14 UTC (rev 166246)
@@ -0,0 +1,46 @@
+Test constructors of ImageData.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Test invalid ImageData constructor arguments.
+PASS new ImageData() threw exception TypeError: Not enough arguments.
+PASS new ImageData(1)
[webkit-changes] [166245] trunk
Title: [166245] trunk Revision 166245 Author mmaxfi...@apple.com Date 2014-03-25 13:15:14 -0700 (Tue, 25 Mar 2014) Log Message InlineIterator position (unsigned int) variable can wrap around https://bugs.webkit.org/show_bug.cgi?id=130540 Patch by Myles C. Maxfield mmaxfi...@apple.com on 2014-03-25 Reviewed by Simon Fraser. Source/WebCore: We trigger an ASSERT that occurs when we are ignoring spaces (to collapse them into a single whitespace mark) but then encounter a line break. Because we don't ignore the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context we want to ignore that first space as well (so as not to push the text away from the right edge). We do this by decrementing the InlineIterator pointing to this first space, so all the spaces get ignored. However, if that space is the first character in a Text node, the decrement will try to go past the beginning of the node, and trigger an ASSERT. This design is not great. At some point we should rework it to more elegantly handle collapsing whitespace in both RTL and LTR writing modes. This patch adds an ASSERT earlier in this codepath to catch potential problems earlier. It also pulls our sentinel value out into a separate boolean to make it more clear what is going on. Test: fast/text/whitespace-only-text-in-rtl.html * rendering/InlineIterator.h: (WebCore::InlineIterator::moveTo): Use the set***() calls (WebCore::InlineIterator::setOffset): ASSERT early that our math hasn't wrapped * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlockFlow::appendRunsForObject): Use new boolean value * rendering/line/BreakingContextInlineHeaders.h: (WebCore::BreakingContext::handleText): Guard against wraps (WebCore::checkMidpoints): Use new boolean value * rendering/line/TrailingObjects.cpp: (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Use new boolean value LayoutTests: This test triggers an ASSERT that occurs when we are ignoring spaces (to collapse them into a single whitespace mark) but then encounter a line break. Because we don't ignore the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context we want to ignore that first space as well (so as not to push the text away from the right edge). We do this by decrementing the InlineIterator pointing to this first space, so all the spaces get ignored. However, if that space is the first character in a Text node, the decrement will try to go past the beginning of the node, and trigger an ASSERT. This design is not great. At some point we should rework it to more elegantly handle collapsing whitespace in both RTL and LTR writing modes. * fast/text/whitespace-only-text-in-rtl-expected.txt: Added. * fast/text/whitespace-only-text-in-rtl.html: Added. Conflicts: LayoutTests/ChangeLog Source/WebCore/ChangeLog Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineIterator.h trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp trunk/Source/WebCore/rendering/line/BreakingContextInlineHeaders.h trunk/Source/WebCore/rendering/line/TrailingObjects.cpp Added Paths trunk/LayoutTests/fast/text/whitespace-only-text-in-rtl-expected.txt trunk/LayoutTests/fast/text/whitespace-only-text-in-rtl.html Diff Modified: trunk/LayoutTests/ChangeLog (166244 => 166245) --- trunk/LayoutTests/ChangeLog 2014-03-25 20:10:02 UTC (rev 166244) +++ trunk/LayoutTests/ChangeLog 2014-03-25 20:15:14 UTC (rev 166245) @@ -1,3 +1,24 @@ +2014-03-25 Myles C. Maxfield mmaxfi...@apple.com + +InlineIterator position (unsigned int) variable can wrap around +https://bugs.webkit.org/show_bug.cgi?id=130540 + +Reviewed by Simon Fraser. + +This test triggers an ASSERT that occurs when we are ignoring spaces (to collapse them +into a single whitespace mark) but then encounter a line break. Because we don't ignore +the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context +we want to ignore that first space as well (so as not to push the text away from the right +edge). We do this by decrementing the InlineIterator pointing to this first space, so all +the spaces get ignored. However, if that space is the first character in a Text node, the +decrement will try to go past the beginning of the node, and trigger an ASSERT. + +This design is not great. At some point we should rework it to more elegantly handle +collapsing whitespace in both RTL and LTR writing modes. + +* fast/text/whitespace-only-text-in-rtl-expected.txt: Added. +* fast/text/whitespace-only-text-in-rtl.html: Added. + 2014-03-25 Oliver Hunt oli...@apple.com AST incorrectly conflates readable and writable locations Added: trunk/LayoutTests/fast/text/whitespace-only-text-in-rtl-expected.txt (0 => 166245) ---
[webkit-changes] [166247] trunk/Source/WebCore
Title: [166247] trunk/Source/WebCore Revision 166247 Author jer.no...@apple.com Date 2014-03-25 13:25:52 -0700 (Tue, 25 Mar 2014) Log Message [iOS] Playing video does not disable display sleep. https://bugs.webkit.org/show_bug.cgi?id=130729 Reviewed by Eric Carlson. DisplaySleepDisabler was broken by r161589, which replaced the iOS implementation with an empty one. Make a platform independent version with a Cocoa-platform subclass. Update the APIs to non-deprecated ones. * platform/DisplaySleepDisabler.cpp: Added. (WebCore::DisplaySleepDisabler::create): * platform/DisplaySleepDisabler.h: Added. (WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): (WebCore::DisplaySleepDisabler::DisplaySleepDisabler): * platform/cocoa/DisplaySleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp. (WebCore::DisplaySleepDisabler::create): (WebCore::DisplaySleepDisablerCocoa::DisplaySleepDisablerCocoa): (WebCore::DisplaySleepDisablerCocoa::~DisplaySleepDisablerCocoa): * platform/cocoa/DisplaySleepDisablerCocoa.h: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.h. Update m_sleepDisabler to be a std::unique_ptr, and unprotect the definition of methods which use it. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateSleepDisabling): (WebCore::HTMLMediaElement::shouldDisableSleep): * html/HTMLMediaElement.h: Add the new and renamed files to the project: * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h Added Paths trunk/Source/WebCore/platform/DisplaySleepDisabler.cpp trunk/Source/WebCore/platform/DisplaySleepDisabler.h trunk/Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.cpp trunk/Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.h Removed Paths trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.cpp trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (166246 => 166247) --- trunk/Source/WebCore/CMakeLists.txt 2014-03-25 20:24:14 UTC (rev 166246) +++ trunk/Source/WebCore/CMakeLists.txt 2014-03-25 20:25:52 UTC (rev 166247) @@ -1788,6 +1788,7 @@ platform/DatabaseStrategy.cpp platform/DateComponents.cpp platform/Decimal.cpp +platform/DisplaySleepDisabler.cpp platform/DragData.cpp platform/DragImage.cpp platform/FileChooser.cpp Modified: trunk/Source/WebCore/ChangeLog (166246 => 166247) --- trunk/Source/WebCore/ChangeLog 2014-03-25 20:24:14 UTC (rev 166246) +++ trunk/Source/WebCore/ChangeLog 2014-03-25 20:25:52 UTC (rev 166247) @@ -1,3 +1,36 @@ +2014-03-25 Jer Noble jer.no...@apple.com + +[iOS] Playing video does not disable display sleep. +https://bugs.webkit.org/show_bug.cgi?id=130729 + +Reviewed by Eric Carlson. + +DisplaySleepDisabler was broken by r161589, which replaced the iOS implementation with +an empty one. Make a platform independent version with a Cocoa-platform subclass. Update +the APIs to non-deprecated ones. + +* platform/DisplaySleepDisabler.cpp: Added. +(WebCore::DisplaySleepDisabler::create): +* platform/DisplaySleepDisabler.h: Added. +(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): +(WebCore::DisplaySleepDisabler::DisplaySleepDisabler): +* platform/cocoa/DisplaySleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp. +(WebCore::DisplaySleepDisabler::create): +(WebCore::DisplaySleepDisablerCocoa::DisplaySleepDisablerCocoa): +(WebCore::DisplaySleepDisablerCocoa::~DisplaySleepDisablerCocoa): +* platform/cocoa/DisplaySleepDisablerCocoa.h: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.h. + +Update m_sleepDisabler to be a std::unique_ptr, and unprotect the definition of methods which use it. +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::updateSleepDisabling): +(WebCore::HTMLMediaElement::shouldDisableSleep): +* html/HTMLMediaElement.h: + +Add the new and renamed files to the project: +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.xcodeproj/project.pbxproj: + 2014-03-25 Dirk Schulze k...@webkit.org Implement ImageData constructors and WebWorkers exposure Modified: trunk/Source/WebCore/GNUmakefile.list.am (166246 => 166247) --- trunk/Source/WebCore/GNUmakefile.list.am 2014-03-25 20:24:14 UTC (rev 166246) +++ trunk/Source/WebCore/GNUmakefile.list.am 2014-03-25 20:25:52 UTC (rev 166247) @@ -5326,6 +5326,8 @@ Source/WebCore/platform/CrossThreadCopier.h \ Source/WebCore/platform/DatabaseStrategy.cpp \
[webkit-changes] [166248] trunk
Title: [166248] trunk
Revision 166248
Author msab...@apple.com
Date 2014-03-25 13:40:34 -0700 (Tue, 25 Mar 2014)
Log Message
Unreviewed, rolling out r166126.
Rollout r166126 in prepartion to roll out prerequisite r166070
Reverted changeset:
toThis() on a JSWorkerGlobalScope should return a JSProxy and
not undefined
https://bugs.webkit.org/show_bug.cgi?id=130554
http://trac.webkit.org/changeset/166126
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/API/JSContextRef.cpp
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp
trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl
trunk/Source/WebCore/workers/SharedWorkerGlobalScope.idl
trunk/Source/WebCore/workers/WorkerGlobalScope.idl
Removed Paths
trunk/LayoutTests/fast/workers/resources/worker-strict.js
trunk/LayoutTests/fast/workers/worker-strict-expected.txt
trunk/LayoutTests/fast/workers/worker-strict.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166247 => 166248)
--- trunk/LayoutTests/ChangeLog 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 20:40:34 UTC (rev 166248)
@@ -1,3 +1,16 @@
+2014-03-25 Michael Saboff msab...@apple.com
+
+Unreviewed, rolling out r166126.
+
+Rollout r166126 in prepartion to roll out prerequisite r166070
+
+Reverted changeset:
+
+toThis() on a JSWorkerGlobalScope should return a JSProxy and
+not undefined
+https://bugs.webkit.org/show_bug.cgi?id=130554
+http://trac.webkit.org/changeset/166126
+
2014-03-25 Dirk Schulze k...@webkit.org
Implement ImageData constructors and WebWorkers exposure
Deleted: trunk/LayoutTests/fast/workers/resources/worker-strict.js (166247 => 166248)
--- trunk/LayoutTests/fast/workers/resources/worker-strict.js 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/LayoutTests/fast/workers/resources/worker-strict.js 2014-03-25 20:40:34 UTC (rev 166248)
@@ -1,11 +0,0 @@
-use strict;
-
-postMessage(SUCCESS: postMessage() called directly);
-
-(function () {
-this.done = function() { return SUCCESS: called function via attribute on WorkerGlobalScope; };
-
-this.postMessage(this.done());
-
-this.postMessage(DONE);
-}).call(this);
Deleted: trunk/LayoutTests/fast/workers/worker-strict-expected.txt (166247 => 166248)
--- trunk/LayoutTests/fast/workers/worker-strict-expected.txt 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/LayoutTests/fast/workers/worker-strict-expected.txt 2014-03-25 20:40:34 UTC (rev 166248)
@@ -1,6 +0,0 @@
-Test calling functions in strict mode script from WorkerContext. Should print SUCCESS lines, followed by DONE.
-
-SUCCESS: postMessage() called directly
-SUCCESS: called function via attribute on WorkerGlobalScope
-DONE
-
Deleted: trunk/LayoutTests/fast/workers/worker-strict.html (166247 => 166248)
--- trunk/LayoutTests/fast/workers/worker-strict.html 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/LayoutTests/fast/workers/worker-strict.html 2014-03-25 20:40:34 UTC (rev 166248)
@@ -1,25 +0,0 @@
-body
-pTest calling functions in strict mode script from WorkerContext. Should print SUCCESS lines, followed by DONE./p
-div id=result/div
-script
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function log(message)
-{
-document.getElementById(result).innerHTML += message + br;
-}
-
-var worker = new Worker(resources/worker-strict.js);
-worker._onmessage_ = function(event) {
-log(event.data);
-if (event.data == DONE) {
-if (window.testRunner)
-testRunner.notifyDone();
-}
-};
-/script
-/body
Modified: trunk/Source/_javascript_Core/API/JSContextRef.cpp (166247 => 166248)
--- trunk/Source/_javascript_Core/API/JSContextRef.cpp 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/Source/_javascript_Core/API/JSContextRef.cpp 2014-03-25 20:40:34 UTC (rev 166248)
@@ -129,6 +129,7 @@
if (!globalObjectClass) {
JSGlobalObject* globalObject = JSGlobalObject::create(*vm, JSGlobalObject::createStructure(*vm, jsNull()));
+globalObject-setGlobalThis(*vm, JSProxy::create(*vm, JSProxy::createStructure(*vm, globalObject, globalObject-prototype()), globalObject));
return JSGlobalContextRetain(toGlobalRef(globalObject-globalExec()));
}
Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (166247 => 166248)
--- trunk/Source/_javascript_Core/API/tests/testapi.c 2014-03-25 20:25:52 UTC (rev 166247)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c 2014-03-25 20:40:34 UTC (rev 166248)
@@ -891,8 +891,10 @@
// Ensure that an execution context is passed in
ASSERT(context);
+
[webkit-changes] [166249] trunk/Source/WebCore
Title: [166249] trunk/Source/WebCore
Revision 166249
Author msab...@apple.com
Date 2014-03-25 13:43:27 -0700 (Tue, 25 Mar 2014)
Log Message
Unreviewed, rolling out r166070.
Rollout r166070 due to 2% performance loss in page load times
Reverted changeset:
Change CodeGeneratorJS.pm special cases for DOMWindow to be
general purpose
https://bugs.webkit.org/show_bug.cgi?id=130553
http://trac.webkit.org/changeset/166070
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (166248 => 166249)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 20:40:34 UTC (rev 166248)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 20:43:27 UTC (rev 166249)
@@ -1,5 +1,18 @@
2014-03-25 Michael Saboff msab...@apple.com
+Unreviewed, rolling out r166070.
+
+Rollout r166070 due to 2% performance loss in page load times
+
+Reverted changeset:
+
+Change CodeGeneratorJS.pm special cases for DOMWindow to be
+general purpose
+https://bugs.webkit.org/show_bug.cgi?id=130553
+http://trac.webkit.org/changeset/166070
+
+2014-03-25 Michael Saboff msab...@apple.com
+
Unreviewed, rolling out r166126.
Rollout r166126 in prepartion to roll out prerequisite r166070
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (166248 => 166249)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-03-25 20:40:34 UTC (rev 166248)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-03-25 20:43:27 UTC (rev 166249)
@@ -2127,8 +2127,12 @@
push(@implContent, {\n);
if (!$attribute-isStatic || $attribute-signature-type =~ /Constructor$/) {
-if ($interface-extendedAttributes-{CustomProxyToJSObject}) {
-push(@implContent, ${className}* castedThis = to${className}(JSValue::decode(thisValue));\n);
+if ($interfaceName eq DOMWindow) {
+push(@implContent, ${className}* castedThis = jsDynamicCast$className*(JSValue::decode(thisValue));\n);
+push(@implContent, if (UNLIKELY(!castedThis)) {\n);
+push(@implContent, if (JSDOMWindowShell* shell = jsDynamicCastJSDOMWindowShell*(JSValue::decode(thisValue)))\n);
+push(@implContent, castedThis = shell-window();\n);
+push(@implContent, }\n);
push(@implContent, UNUSED_PARAM(slotBase);\n);
} else {
push(@implContent, ${className}* castedThis = jsDynamicCast$className*(JSValue::decode(thisValue));\n);
@@ -2346,8 +2350,12 @@
push(@implContent, {\n);
push(@implContent, UNUSED_PARAM(baseValue);\n);
push(@implContent, UNUSED_PARAM(thisValue);\n);
-if ($interface-extendedAttributes-{CustomProxyToJSObject}) {
-push(@implContent, ${className}* domObject = to${className}(JSValue::decode(thisValue));\n);
+if ($interfaceName eq DOMWindow) {
+push(@implContent, ${className}* domObject = jsDynamicCast$className*(JSValue::decode(thisValue));\n);
+push(@implContent, if (!domObject) {\n);
+push(@implContent, if (JSDOMWindowShell* shell = jsDynamicCastJSDOMWindowShell*(JSValue::decode(thisValue)))\n);
+push(@implContent, domObject = shell-window();\n);
+push(@implContent, }\n);
} else {
push(@implContent, ${className}* domObject = jsDynamicCast${className}*(JSValue::decode(thisValue));\n) if ConstructorShouldBeOnInstance($interface);
push(@implContent, ${className}Prototype* domObject = jsDynamicCast${className}Prototype*(baseValue);\n) if !ConstructorShouldBeOnInstance($interface);
@@ -2371,10 +2379,12 @@
push(@implContent, void ${constructorFunctionName}(ExecState* exec, JSObject*, EncodedJSValue thisValue, EncodedJSValue encodedValue)\n);
push(@implContent, {\n);
push(@implContent, JSValue value = JSValue::decode(encodedValue););
-if ($interface-extendedAttributes-{CustomProxyToJSObject}) {
-push(@implContent, ${className}* castedThis = to${className}(JSValue::decode(thisValue));\n);
-} else {
-push(@implContent, ${className}* castedThis = jsDynamicCast${className}*(JSValue::decode(thisValue));\n);
+push(@implContent, ${className}* castedThis = jsDynamicCast${className}*(JSValue::decode(thisValue));\n);
+if ($interfaceName eq DOMWindow) {
+push(@implContent, if (UNLIKELY(!castedThis)) {\n);
+push(@implContent, if
[webkit-changes] [166250] trunk/Source/WebCore
Title: [166250] trunk/Source/WebCore
Revision 166250
Author bfulg...@apple.com
Date 2014-03-25 14:00:19 -0700 (Tue, 25 Mar 2014)
Log Message
[iOS] Pass additional options to AVFoundation during playback.
https://bugs.webkit.org/show_bug.cgi?id=130624
Reviewed by Eric Carlson.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::doesHaveAttribute): Return attribute value if the user
passes a pointer to fill in.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::doesHaveAttribute):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::doesHaveAttribute):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Pass additional
option if supplied by user.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166249 => 166250)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 20:43:27 UTC (rev 166249)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:00:19 UTC (rev 166250)
@@ -1,3 +1,22 @@
+2014-03-25 Brent Fulgham bfulg...@apple.com
+
+[iOS] Pass additional options to AVFoundation during playback.
+https://bugs.webkit.org/show_bug.cgi?id=130624
+
+Reviewed by Eric Carlson.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::doesHaveAttribute): Return attribute value if the user
+passes a pointer to fill in.
+* html/HTMLMediaElement.h:
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::doesHaveAttribute):
+* platform/graphics/MediaPlayer.h:
+(WebCore::MediaPlayerClient::doesHaveAttribute):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Pass additional
+option if supplied by user.
+
2014-03-25 Michael Saboff msab...@apple.com
Unreviewed, rolling out r166070.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166249 => 166250)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 20:43:27 UTC (rev 166249)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 21:00:19 UTC (rev 166250)
@@ -6042,16 +6042,21 @@
}
}
-bool HTMLMediaElement::doesHaveAttribute(const AtomicString attribute) const
+bool HTMLMediaElement::doesHaveAttribute(const AtomicString attribute, AtomicString* value) const
{
QualifiedName attributeName(nullAtom, attribute, nullAtom);
-if (!fastHasAttribute(attributeName))
+
+AtomicString elementValue = fastGetAttribute(attributeName);
+if (elementValue.isNull())
return false;
if (Settings* settings = document().settings()) {
-if (attributeName == HTMLNames::x_itunes_inherit_uri_query_componentAttr)
-return settings-enableInheritURIQueryComponent();
+if (attributeName == HTMLNames::x_itunes_inherit_uri_query_componentAttr !settings-enableInheritURIQueryComponent())
+return false;
}
+
+if (value)
+*value = elementValue;
return true;
}
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (166249 => 166250)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-25 20:43:27 UTC (rev 166249)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-25 21:00:19 UTC (rev 166250)
@@ -129,7 +129,7 @@
virtual bool supportsSave() const;
virtual bool supportsScanning() const override;
-virtual bool doesHaveAttribute(const AtomicString) const override;
+virtual bool doesHaveAttribute(const AtomicString, AtomicString* value = nullptr) const override;
PlatformMedia platformMedia() const;
PlatformLayer* platformLayer() const;
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (166249 => 166250)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2014-03-25 20:43:27 UTC (rev 166249)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2014-03-25 21:00:19 UTC (rev 166250)
@@ -1412,12 +1412,12 @@
registerMediaEngine(addMediaEngine);
}
-bool MediaPlayer::doesHaveAttribute(const AtomicString attribute) const
+bool MediaPlayer::doesHaveAttribute(const AtomicString attribute, AtomicString* value) const
{
if (!m_mediaPlayerClient)
return false;
-return m_mediaPlayerClient-doesHaveAttribute(attribute);
+return m_mediaPlayerClient-doesHaveAttribute(attribute, value);
}
}
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (166249 => 166250)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2014-03-25 20:43:27 UTC (rev 166249)
+++
[webkit-changes] [166251] trunk/Source/WebKit2
Title: [166251] trunk/Source/WebKit2 Revision 166251 Author ander...@apple.com Date 2014-03-25 14:03:46 -0700 (Tue, 25 Mar 2014) Log Message Fix iOS build. * UIProcess/API/Cocoa/WKWebView.h: * UIProcess/API/Cocoa/WKWebView.mm: Make WKIBActions OS X only for now. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (166250 => 166251) --- trunk/Source/WebKit2/ChangeLog 2014-03-25 21:00:19 UTC (rev 166250) +++ trunk/Source/WebKit2/ChangeLog 2014-03-25 21:03:46 UTC (rev 166251) @@ -1,5 +1,13 @@ 2014-03-25 Anders Carlsson ander...@apple.com +Fix iOS build. + +* UIProcess/API/Cocoa/WKWebView.h: +* UIProcess/API/Cocoa/WKWebView.mm: +Make WKIBActions OS X only for now. + +2014-03-25 Anders Carlsson ander...@apple.com + Begin stubbing out a WKWindowFeatures class https://bugs.webkit.org/show_bug.cgi?id=130733 Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (166250 => 166251) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-25 21:00:19 UTC (rev 166250) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-25 21:03:46 UTC (rev 166251) @@ -131,6 +131,8 @@ @end +#if !TARGET_OS_IPHONE + @interface WKWebView (WKIBActions) NSUserInterfaceValidations - (IBAction)goBack:(id)sender; @@ -141,3 +143,5 @@ @end #endif + +#endif Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166250 => 166251) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-25 21:00:19 UTC (rev 166250) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-25 21:03:46 UTC (rev 166251) @@ -1176,6 +1176,8 @@ @end +#if !TARGET_OS_IPHONE + @implementation WKWebView (WKIBActions) - (BOOL)validateUserInterfaceItem:(id NSValidatedUserInterfaceItem)item @@ -1213,4 +1215,6 @@ @end +#endif + #endif // WK_API_ENABLED ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166252] trunk/Source/WebCore
Title: [166252] trunk/Source/WebCore
Revision 166252
Author jer.no...@apple.com
Date 2014-03-25 14:07:32 -0700 (Tue, 25 Mar 2014)
Log Message
Unreviewed build fix after r166247. Un-platform-protect the declaration of HTMLMediaElement::shouldDisableSleep()
and make WebVideoFullscreenController's _displaySleepDisabler a std::unique_ptr.
* html/HTMLMediaElement.h:
* platform/mac/WebVideoFullscreenController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166251 => 166252)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 21:03:46 UTC (rev 166251)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:07:32 UTC (rev 166252)
@@ -1,3 +1,11 @@
+2014-03-25 Jer Noble jer.no...@apple.com
+
+Unreviewed build fix after r166247. Un-platform-protect the declaration of HTMLMediaElement::shouldDisableSleep()
+and make WebVideoFullscreenController's _displaySleepDisabler a std::unique_ptr.
+
+* html/HTMLMediaElement.h:
+* platform/mac/WebVideoFullscreenController.h:
+
2014-03-25 Brent Fulgham bfulg...@apple.com
[iOS] Pass additional options to AVFoundation during playback.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (166251 => 166252)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-25 21:03:46 UTC (rev 166251)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-25 21:07:32 UTC (rev 166252)
@@ -686,9 +686,7 @@
bool isAutoplaying() const { return m_autoplaying; }
void updateSleepDisabling();
-#if PLATFORM(COCOA)
bool shouldDisableSleep() const;
-#endif
#if ENABLE(MEDIA_CONTROLS_SCRIPT)
virtual void didAddUserAgentShadowRoot(ShadowRoot*) override;
Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.h (166251 => 166252)
--- trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.h 2014-03-25 21:03:46 UTC (rev 166251)
+++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.h 2014-03-25 21:07:32 UTC (rev 166252)
@@ -53,7 +53,7 @@
BOOL _isEndingFullscreen;
BOOL _forceDisableAnimation;
-OwnPtrWebCore::DisplaySleepDisabler _displaySleepDisabler;
+std::unique_ptrWebCore::DisplaySleepDisabler _displaySleepDisabler;
}
- (id WebVideoFullscreenControllerDelegate)delegate;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166253] trunk/Source/WebKit2
Title: [166253] trunk/Source/WebKit2
Revision 166253
Author ander...@apple.com
Date 2014-03-25 14:18:20 -0700 (Tue, 25 Mar 2014)
Log Message
Add more properties to WKWindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=130738
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKWindowFeatures.h:
* UIProcess/API/Cocoa/WKWindowFeatures.mm:
(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
(-[WKWindowFeatures menuBarVisibility]):
(-[WKWindowFeatures statusBarVisibility]):
(-[WKWindowFeatures toolbarsVisibility]):
(-[WKWindowFeatures allowsResizing]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166252 => 166253)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 21:18:20 UTC (rev 166253)
@@ -1,5 +1,20 @@
2014-03-25 Anders Carlsson ander...@apple.com
+Add more properties to WKWindowFeatures
+https://bugs.webkit.org/show_bug.cgi?id=130738
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWindowFeatures.h:
+* UIProcess/API/Cocoa/WKWindowFeatures.mm:
+(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
+(-[WKWindowFeatures menuBarVisibility]):
+(-[WKWindowFeatures statusBarVisibility]):
+(-[WKWindowFeatures toolbarsVisibility]):
+(-[WKWindowFeatures allowsResizing]):
+
+2014-03-25 Anders Carlsson ander...@apple.com
+
Fix iOS build.
* UIProcess/API/Cocoa/WKWebView.h:
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h (166252 => 166253)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 21:18:20 UTC (rev 166253)
@@ -31,6 +31,12 @@
WK_API_CLASS
@interface WKWindowFeatures : NSObject
+@property (nonatomic, readonly) NSNumber *menuBarVisibility;
+@property (nonatomic, readonly) NSNumber *statusBarVisibility;
+@property (nonatomic, readonly) NSNumber *toolbarVisibility;
+
+@property (nonatomic, readonly) NSNumber *allowsResizing;
+
@property (nonatomic, readonly) NSNumber *x;
@property (nonatomic, readonly) NSNumber *y;
@property (nonatomic, readonly) NSNumber *width;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm (166252 => 166253)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 21:18:20 UTC (rev 166253)
@@ -32,6 +32,12 @@
#import wtf/RetainPtr.h
@implementation WKWindowFeatures {
+RetainPtrNSNumber _menuBarVisibility;
+RetainPtrNSNumber _statusBarVisibility;
+RetainPtrNSNumber _toolbarsVisibility;
+
+RetainPtrNSNumber _allowsResizing;
+
RetainPtrNSNumber _x;
RetainPtrNSNumber _y;
RetainPtrNSNumber _width;
@@ -43,6 +49,12 @@
if (!(self = [super init]))
return nil;
+// FIXME: These should be set to nil if the features didn't exist in the string.
+_menuBarVisibility = @(windowFeatures.menuBarVisible);
+_statusBarVisibility = @(windowFeatures.statusBarVisible);
+_toolbarVisibility = @(windowFeatures.toolBarVisible);
+_allowsResizing = @(windowFeatures.resizable);
+
if (windowFeatures.xSet)
_x = @(windowFeatures.x);
if (windowFeatures.ySet)
@@ -55,6 +67,26 @@
return self;
}
+- (NSNumber *)menuBarVisibility
+{
+return _menuBarVisibility.get();
+}
+
+- (NSNumber *)statusBarVisibility
+{
+return _statusBarVisibility.get();
+}
+
+- (NSNumber *)toolbarsVisibility
+{
+return _toolbarsVisibility.get();
+}
+
+- (NSNumber *)allowsResizing
+{
+return _allowsResizing.get();
+}
+
- (NSNumber *)x
{
return _x.get();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166254] trunk/Source/WebCore
Title: [166254] trunk/Source/WebCore
Revision 166254
Author jer.no...@apple.com
Date 2014-03-25 14:26:17 -0700 (Tue, 25 Mar 2014)
Log Message
Further unreviewed build fix after r166247. Add DisplaySleepDisabler to the windows project file and
move the definition of DisplaySleepDisabler's constructor and destructor into the cpp file.
* WebCore.vcxproj/WebCore.vcxproj:
* platform/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
* platform/DisplaySleepDisabler.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/DisplaySleepDisabler.cpp
trunk/Source/WebCore/platform/DisplaySleepDisabler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166253 => 166254)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 21:18:20 UTC (rev 166253)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:26:17 UTC (rev 166254)
@@ -1,5 +1,16 @@
2014-03-25 Jer Noble jer.no...@apple.com
+Further unreviewed build fix after r166247. Add DisplaySleepDisabler to the windows project file and
+move the definition of DisplaySleepDisabler's constructor and destructor into the cpp file.
+
+* WebCore.vcxproj/WebCore.vcxproj:
+* platform/DisplaySleepDisabler.cpp:
+(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
+(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
+* platform/DisplaySleepDisabler.h:
+
+2014-03-25 Jer Noble jer.no...@apple.com
+
Unreviewed build fix after r166247. Un-platform-protect the declaration of HTMLMediaElement::shouldDisableSleep()
and make WebVideoFullscreenController's _displaySleepDisabler a std::unique_ptr.
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (166253 => 166254)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-03-25 21:18:20 UTC (rev 166253)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-03-25 21:26:17 UTC (rev 166254)
@@ -7190,6 +7190,7 @@
ClCompile Include=..\platform\DatabaseStrategy.cpp /
ClCompile Include=..\platform\DateComponents.cpp /
ClCompile Include=..\platform\Decimal.cpp /
+ClCompile Include=..\platform\DisplaySleepDisabler.cpp /
ClCompile Include=..\platform\DragData.cpp /
ClCompile Include=..\platform\DragImage.cpp /
ClCompile Include=..\platform\FileChooser.cpp /
@@ -19089,6 +19090,7 @@
ClInclude Include=..\platform\DatabaseStrategy.h /
ClInclude Include=..\platform\DateComponents.h /
ClInclude Include=..\platform\Decimal.h /
+ClInclude Include=..\platform\DisplaySleepDisabler.h /
ClInclude Include=..\platform\DragData.h /
ClInclude Include=..\platform\DragImage.h /
ClInclude Include=..\platform\EventLoop.h /
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166253 => 166254)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 21:18:20 UTC (rev 166253)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 21:26:17 UTC (rev 166254)
@@ -38,6 +38,7 @@
#include ContentSecurityPolicy.h
#include ContentType.h
#include DiagnosticLoggingKeys.h
+#include DisplaySleepDisabler.h
#include DocumentLoader.h
#include ElementIterator.h
#include EventNames.h
@@ -112,10 +113,6 @@
#include WebKitPlaybackTargetAvailabilityEvent.h
#endif
-#if PLATFORM(COCOA)
-#include DisplaySleepDisabler.h
-#endif
-
#if ENABLE(MEDIA_SOURCE)
#include DOMWindow.h
#include MediaSource.h
Modified: trunk/Source/WebCore/platform/DisplaySleepDisabler.cpp (166253 => 166254)
--- trunk/Source/WebCore/platform/DisplaySleepDisabler.cpp 2014-03-25 21:18:20 UTC (rev 166253)
+++ trunk/Source/WebCore/platform/DisplaySleepDisabler.cpp 2014-03-25 21:26:17 UTC (rev 166254)
@@ -35,4 +35,12 @@
}
#endif // !PLATFORM(COCOA)
+DisplaySleepDisabler::DisplaySleepDisabler(const char*)
+{
}
+
+DisplaySleepDisabler::~DisplaySleepDisabler()
+{
+}
+
+}
Modified: trunk/Source/WebCore/platform/DisplaySleepDisabler.h (166253 => 166254)
--- trunk/Source/WebCore/platform/DisplaySleepDisabler.h 2014-03-25 21:18:20 UTC (rev 166253)
+++ trunk/Source/WebCore/platform/DisplaySleepDisabler.h 2014-03-25 21:26:17 UTC (rev 166254)
@@ -31,10 +31,10 @@
class DisplaySleepDisabler {
public:
static std::unique_ptrDisplaySleepDisabler create(const char*);
-virtual ~DisplaySleepDisabler() { }
+virtual ~DisplaySleepDisabler();
protected:
-DisplaySleepDisabler(const char*) { }
+DisplaySleepDisabler(const char*);
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166255] trunk/Source/WebCore
Title: [166255] trunk/Source/WebCore
Revision 166255
Author jer.no...@apple.com
Date 2014-03-25 14:33:45 -0700 (Tue, 25 Mar 2014)
Log Message
Even further unreviewed build fix after r166247. Unprotect the implementation of HTMLMediaElement::shouldDisableSleep().
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166254 => 166255)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 21:26:17 UTC (rev 166254)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:33:45 UTC (rev 166255)
@@ -1,5 +1,12 @@
2014-03-25 Jer Noble jer.no...@apple.com
+Even further unreviewed build fix after r166247. Unprotect the implementation of HTMLMediaElement::shouldDisableSleep().
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::parseAttribute):
+
+2014-03-25 Jer Noble jer.no...@apple.com
+
Further unreviewed build fix after r166247. Add DisplaySleepDisabler to the windows project file and
move the definition of DisplaySleepDisabler's constructor and destructor into the cpp file.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166254 => 166255)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 21:26:17 UTC (rev 166254)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-25 21:33:45 UTC (rev 166255)
@@ -5642,7 +5642,6 @@
m_sleepDisabler = DisplaySleepDisabler::create(com.apple.WebCore: HTMLMediaElement playback);
}
-#if PLATFORM(COCOA)
bool HTMLMediaElement::shouldDisableSleep() const
{
#if !PLATFORM(COCOA)
@@ -5656,7 +5655,6 @@
return m_player !m_player-paused() hasVideo() hasAudio() !loop();
}
-#endif
String HTMLMediaElement::mediaPlayerReferrer() const
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166257] trunk/Source
Title: [166257] trunk/Source
Revision 166257
Author joep...@webkit.org
Date 2014-03-25 14:52:20 -0700 (Tue, 25 Mar 2014)
Log Message
[iOS] Inspector View Indication Support
https://bugs.webkit.org/show_bug.cgi?id=130709
Reviewed by Simon Fraser.
Source/WebCore:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::showInspectorIndication):
(WebCore::InspectorClient::hideInspectorIndication):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setIndicating):
Rename indicate/hideIndication to show/hide names.
Source/WebKit/ios:
* WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorClient::showInspectorIndication):
(WebInspectorClient::hideInspectorIndication):
Renamed methods.
Source/WebKit/mac:
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didSetSearchingForNode): Deleted.
(WebInspectorClient::releaseFrontend): Deleted.
* WebView/WebView.mm:
(-[WebView setShowingInspectorIndication:]):
* WebView/WebViewPrivate.h:
Renamed methods.
Source/WebKit2:
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKInspectorIndicationView initWithFrame:]):
(-[WKContentView isShowingInspectorIndication]):
(-[WKContentView setShowingInspectorIndication:]):
(-[WKContentView _didCommitLayerTree:WebKit::]):
When indicating include a simple tinted UIView over the content.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showInspectorIndication]):
(-[WKWebView _hideInspectorIndication]):
Have the content view show or hide an indication.
* UIProcess/PageClient.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showInspectorIndication):
(WebKit::PageClientImpl::hideInspectorIndication):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::showInspectorIndication):
(WebKit::WebPageProxy::hideInspectorIndication):
Pass WebProcess indication message up to the WKWebView.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::indicate):
(WebKit::WebInspectorClient::hideIndication):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::indicate):
(WebKit::WebPage::hideIndication):
Pass WebCore / remote inspector indication message up to UIProcess.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewPrivate.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentView.h
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166256 => 166257)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 21:34:42 UTC (rev 166256)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:52:20 UTC (rev 166257)
@@ -1,3 +1,17 @@
+2014-03-25 Joseph Pecoraro pecor...@apple.com
+
+[iOS] Inspector View Indication Support
+https://bugs.webkit.org/show_bug.cgi?id=130709
+
+Reviewed by Simon Fraser.
+
+* inspector/InspectorClient.h:
+(WebCore::InspectorClient::showInspectorIndication):
+(WebCore::InspectorClient::hideInspectorIndication):
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::setIndicating):
+Rename indicate/hideIndication to show/hide names.
+
2014-03-25 Brent Fulgham bfulg...@apple.com
Unreviewed build fix. Typo on checkin.
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (166256 => 166257)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2014-03-25 21:34:42 UTC (rev 166256)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2014-03-25 21:52:20 UTC (rev 166257)
@@ -56,8 +56,8 @@
virtual void highlight() = 0;
virtual void hideHighlight() = 0;
-virtual void indicate() { }
-
[webkit-changes] [166258] trunk/Source/WebKit2
Title: [166258] trunk/Source/WebKit2 Revision 166258 Author jp...@apple.com Date 2014-03-25 14:53:14 -0700 (Tue, 25 Mar 2014) Log Message [WK2] Schemes registered as cache partitioned are not properly registered in new web processes https://bugs.webkit.org/show_bug.cgi?id=130739 Reviewed by Anders Carlsson. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166257 => 166258) --- trunk/Source/WebKit2/ChangeLog 2014-03-25 21:52:20 UTC (rev 166257) +++ trunk/Source/WebKit2/ChangeLog 2014-03-25 21:53:14 UTC (rev 166258) @@ -1,3 +1,13 @@ +2014-03-25 Jeffrey Pfau jp...@apple.com + +[WK2] Schemes registered as cache partitioned are not properly registered in new web processes +https://bugs.webkit.org/show_bug.cgi?id=130739 + +Reviewed by Anders Carlsson. + +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::initializeWebProcess): + 2014-03-25 Joseph Pecoraro pecor...@apple.com [iOS] Inspector View Indication Support Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (166257 => 166258) --- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-03-25 21:52:20 UTC (rev 166257) +++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-03-25 21:53:14 UTC (rev 166258) @@ -333,7 +333,7 @@ #if ENABLE(CACHE_PARTITIONING) for (auto scheme : parameters.urlSchemesRegisteredAsCachePartitioned) -registerURLSchemeAsCORSEnabled(scheme); +registerURLSchemeAsCachePartitioned(scheme); #endif setDefaultRequestTimeoutInterval(parameters.defaultRequestTimeoutInterval); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166259] trunk
Title: [166259] trunk
Revision 166259
Author stav...@adobe.com
Date 2014-03-25 15:01:25 -0700 (Tue, 25 Mar 2014)
Log Message
[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
https://bugs.webkit.org/show_bug.cgi?id=130574
Reviewed by David Hyatt.
Source/WebCore:
When computing the clip rect for painting the box decorations, the scrolled content offset
must be computed by going up the containing block tree, up to the region.
Tests: fast/regions/scrollable-region-scrollable-absolute-content-background.html
fast/regions/scrollable-region-scrollable-content-background.html
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
LayoutTests:
Added tests for properly painting background of children of scrollable elements flowed into regions.
* fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html: Added.
* fast/regions/scrollable-region-scrollable-absolute-content-background.html: Added.
* fast/regions/scrollable-region-scrollable-content-background-expected.html: Added.
* fast/regions/scrollable-region-scrollable-content-background.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
Added Paths
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-content-background-expected.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-content-background.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166258 => 166259)
--- trunk/LayoutTests/ChangeLog 2014-03-25 21:53:14 UTC (rev 166258)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 22:01:25 UTC (rev 166259)
@@ -1,3 +1,17 @@
+2014-03-25 Radu Stavila stav...@adobe.com
+
+[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
+https://bugs.webkit.org/show_bug.cgi?id=130574
+
+Reviewed by David Hyatt.
+
+Added tests for properly painting background of children of scrollable elements flowed into regions.
+
+* fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html: Added.
+* fast/regions/scrollable-region-scrollable-absolute-content-background.html: Added.
+* fast/regions/scrollable-region-scrollable-content-background-expected.html: Added.
+* fast/regions/scrollable-region-scrollable-content-background.html: Added.
+
2014-03-25 Michael Saboff msab...@apple.com
Unreviewed, rolling out r166126.
Added: trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html (0 => 166259)
--- trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html 2014-03-25 22:01:25 UTC (rev 166259)
@@ -0,0 +1,63 @@
+!DOCTYPE html
+html style=font: 16px/1.25 monospace;
+head
+script type=text/_javascript_
+_onload_ = function()
+{
+document.getElementById(container).scrollTop = 40;
+}
+/script
+
+style
+#container {
+border: thick solid green;
+height: 150px;
+overflow: scroll;
+margin: 15px;
+padding: 5px;
+}
+
+#region {
+width: 400px;
+height: 200px;
+border: 2px solid blue;
+margin: 10px;
+padding: 35px;
+}
+
+.blueBackground {
+background: lightblue;
+}
+
+.greenBackground {
+background: lightgreen;
+position: absolute;
+left: 205px;
+top: 227px;
+width: 250px;
+}
+
+#bottomDiv {
+position: relative;
+top: 50px;
+width: 100px;
+height: 100px;
+background: green;
+}
+/style
+/head
+
+body
+a style=font-size: 14px href="" Regions] The background of children of scrollablebr/elements flowed into regions is not properly scrolled/a
+pThis test passes if the backgrounds of the paragraphs inside the span style=color:greenbgreen box/b/span is properly painted when scrolling the box./p
+
+div id=region
+div id=container
+p class=greenBackgroundThis text is absolutely positioned and should have a lightgreen background./p
+
+
[webkit-changes] [166260] trunk/Tools
Title: [166260] trunk/Tools
Revision 166260
Author aes...@apple.com
Date 2014-03-25 15:20:02 -0700 (Tue, 25 Mar 2014)
Log Message
Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:didReceiveData:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm
Diff
Modified: trunk/Tools/ChangeLog (166259 => 166260)
--- trunk/Tools/ChangeLog 2014-03-25 22:01:25 UTC (rev 166259)
+++ trunk/Tools/ChangeLog 2014-03-25 22:20:02 UTC (rev 166260)
@@ -1,5 +1,13 @@
2014-03-25 Andy Estes aes...@apple.com
+Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+(-[DownloadDelegate _download:didReceiveResponse:]):
+(-[DownloadDelegate _download:didReceiveData:]):
+
+2014-03-25 Andy Estes aes...@apple.com
+
Add some debug logging to an API test that's failing on Mountain Lion.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (166259 => 166260)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 22:01:25 UTC (rev 166259)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 22:20:02 UTC (rev 166260)
@@ -78,17 +78,16 @@
- (void)_download:(_WKDownload *)download didReceiveResponse:(NSURLResponse *)response
{
-NSLog(@[response sourceURL]: %@\n, [response URL]);
-NSLog(@[self sourceURL]: %@\n, [self sourceURL]);
EXPECT_EQ(_download, download);
EXPECT_TRUE(_expectedContentLength == 0);
EXPECT_TRUE(_receivedContentLength == 0);
-EXPECT_TRUE([[response URL] isEqual:[self sourceURL]]);
+EXPECT_TRUE([[[response URL] path] isEqualToString:[[self sourceURL] path]]);
_expectedContentLength = [response expectedContentLength];
}
- (void)_download:(_WKDownload *)download didReceiveData:(uint64_t)length
{
+NSLog(@didReceiveData: %llu\n, length);
EXPECT_EQ(_download, download);
_receivedContentLength += length;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166261] trunk
Title: [166261] trunk
Revision 166261
Author jer.no...@apple.com
Date 2014-03-25 15:26:34 -0700 (Tue, 25 Mar 2014)
Log Message
[Mac] Pause the media element during system sleep.
https://bugs.webkit.org/show_bug.cgi?id=130718
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-system-sleep.html
Relying on the platform media system to pause and restart playback during
system sleep can cause problems on some platforms, especially where hardware
decoders are concerned. Rather than implicitly pausing the media during
system sleep, explicitly pause the media before sleeping and resume (if
appropriate) upon waking.
Add a new class to be used for system sleep notifications:
* platform/SystemSleepListener.cpp: Added.
(WebCore::SystemSleepListener::create):
(WebCore::SystemSleepListener::SystemSleepListener):
* platform/SystemSleepListener.h: Added.
(WebCore::SystemSleepListener::Client::~Client):
(WebCore::SystemSleepListener::~SystemSleepListener):
(WebCore::SystemSleepListener::client):
Add a Mac-specific implementation:
* platform/mac/SystemSleepListenerMac.h: Added.
* platform/mac/SystemSleepListenerMac.mm: Added.
(WebCore::SystemSleepListener::create):
(WebCore::SystemSleepListenerMac::SystemSleepListenerMac):
(WebCore::SystemSleepListenerMac::~SystemSleepListenerMac):
Listen for system sleep notifications in MediaSessionManager:
* platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::systemWillSleep):
(WebCore::MediaSessionManager::systemDidWake):
* platform/audio/MediaSessionManager.h:
Drive-by fix; notify the MediaSession that playback will begin
due to autoplay, but do not begin autoplaying if the session
is already interrupted:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
Add new files to project:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* CMakeLists.txt:
* GNUmakefile.list.am:
LayoutTests:
* media/video-system-sleep-expected.txt: Added.
* media/video-system-sleep.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/audio/MediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/MediaSessionManager.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/media/video-system-sleep-expected.txt
trunk/LayoutTests/media/video-system-sleep.html
trunk/Source/WebCore/platform/SystemSleepListener.cpp
trunk/Source/WebCore/platform/SystemSleepListener.h
trunk/Source/WebCore/platform/mac/SystemSleepListenerMac.h
trunk/Source/WebCore/platform/mac/SystemSleepListenerMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (166260 => 166261)
--- trunk/LayoutTests/ChangeLog 2014-03-25 22:20:02 UTC (rev 166260)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 22:26:34 UTC (rev 166261)
@@ -1,3 +1,13 @@
+2014-03-25 Jer Noble jer.no...@apple.com
+
+[Mac] Pause the media element during system sleep.
+https://bugs.webkit.org/show_bug.cgi?id=130718
+
+Reviewed by Eric Carlson.
+
+* media/video-system-sleep-expected.txt: Added.
+* media/video-system-sleep.html: Added.
+
2014-03-25 Radu Stavila stav...@adobe.com
[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
Added: trunk/LayoutTests/media/video-system-sleep-expected.txt (0 => 166261)
--- trunk/LayoutTests/media/video-system-sleep-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-system-sleep-expected.txt 2014-03-25 22:26:34 UTC (rev 166261)
@@ -0,0 +1,10 @@
+
+Test that video elements pause during system sleep.
+
+EVENT(playing)
+RUN(internals.simulateSystemSleep())
+EVENT(pause)
+RUN(internals.simulateSystemWake())
+EVENT(playing)
+END OF TEST
+
Added: trunk/LayoutTests/media/video-system-sleep.html (0 => 166261)
--- trunk/LayoutTests/media/video-system-sleep.html (rev 0)
+++ trunk/LayoutTests/media/video-system-sleep.html 2014-03-25 22:26:34 UTC (rev 166261)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script
+function start()
+{
+if (!window.internals)
+consoleWrite('To run this test manually, cause the machine to sleep then wake up.');
+
+findMediaElement();
+waitForEventOnce('playing', playing);
+video.src = "" content/test);
+}
+
+function playing()
+{
+waitForEventOnce('pause', paused);
+
[webkit-changes] [166262] trunk/Source/WebKit2
Title: [166262] trunk/Source/WebKit2 Revision 166262 Author ander...@apple.com Date 2014-03-25 15:34:47 -0700 (Tue, 25 Mar 2014) Log Message Add a WebFrame::fromCoreFrame static member function and use it where possible https://bugs.webkit.org/show_bug.cgi?id=130744 Reviewed by Tim Horton. * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation): * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::documentFrame): (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame): (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame): * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: (WebKit::InjectedBundleDOMWindowExtension::frame): * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: (WebKit::InjectedBundleHitTestResult::frame): (WebKit::InjectedBundleHitTestResult::targetFrame): * WebProcess/Plugins/PluginView.cpp: (WebKit::webPage): (WebKit::PluginView::performFrameLoadURLRequest): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::focusedElementChanged): (WebKit::WebChromeClient::focusedFrameChanged): (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): (WebKit::WebChromeClient::runJavaScriptAlert): (WebKit::WebChromeClient::runJavaScriptConfirm): (WebKit::WebChromeClient::runJavaScriptPrompt): (WebKit::WebChromeClient::print): (WebKit::WebChromeClient::exceededDatabaseQuota): (WebKit::WebChromeClient::runOpenPanel): * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::textFieldDidBeginEditing): (WebKit::WebEditorClient::textFieldDidEndEditing): (WebKit::WebEditorClient::textDidChangeInTextField): (WebKit::WebEditorClient::textDidChangeInTextArea): (WebKit::WebEditorClient::doTextFieldCommandFromEvent): (WebKit::WebEditorClient::textWillBeDeletedInTextField): * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent): (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::fromCoreFrame): (WebKit::WebFrame::contentsAsString): (WebKit::WebFrame::parentFrame): (WebKit::WebFrame::childFrames): (WebKit::WebFrame::frameForContext): (WebKit::WebFrame::webArchiveData): * WebProcess/WebPage/WebFrame.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h Diff Modified: trunk/Source/WebKit2/ChangeLog (166261 => 166262) --- trunk/Source/WebKit2/ChangeLog 2014-03-25 22:26:34 UTC (rev 166261) +++ trunk/Source/WebKit2/ChangeLog 2014-03-25 22:34:47 UTC (rev 166262) @@ -1,3 +1,56 @@ +2014-03-25 Anders Carlsson ander...@apple.com + +Add a WebFrame::fromCoreFrame static member function and use it where possible +https://bugs.webkit.org/show_bug.cgi?id=130744 + +Reviewed by Tim Horton. + +* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: +(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation): +* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: +(WebKit::InjectedBundleNodeHandle::documentFrame): +(WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame): +(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame): +* WebProcess/InjectedBundle/InjectedBundle.cpp: +(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): +* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: +(WebKit::InjectedBundleDOMWindowExtension::frame): +* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: +(WebKit::InjectedBundleHitTestResult::frame): +(WebKit::InjectedBundleHitTestResult::targetFrame): +* WebProcess/Plugins/PluginView.cpp: +(WebKit::webPage): +(WebKit::PluginView::performFrameLoadURLRequest): +* WebProcess/WebCoreSupport/WebChromeClient.cpp: +(WebKit::WebChromeClient::focusedElementChanged): +
[webkit-changes] [166256] trunk/Source/WebCore
Title: [166256] trunk/Source/WebCore
Revision 166256
Author bfulg...@apple.com
Date 2014-03-25 14:34:42 -0700 (Tue, 25 Mar 2014)
Log Message
Unreviewed build fix. Typo on checkin.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Left an unmatched open bracket.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166255 => 166256)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 21:33:45 UTC (rev 166255)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 21:34:42 UTC (rev 166256)
@@ -1,3 +1,10 @@
+2014-03-25 Brent Fulgham bfulg...@apple.com
+
+Unreviewed build fix. Typo on checkin.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Left an unmatched open bracket.
+
2014-03-25 Jer Noble jer.no...@apple.com
Even further unreviewed build fix after r166247. Unprotect the implementation of HTMLMediaElement::shouldDisableSleep().
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (166255 => 166256)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-25 21:33:45 UTC (rev 166255)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-25 21:34:42 UTC (rev 166256)
@@ -711,7 +711,7 @@
#if PLATFORM(IOS)
AtomicString value;
-if (player()-doesHaveAttribute(data-youtube-id, value)) {
+if (player()-doesHaveAttribute(data-youtube-id, value))
[m_avPlayerItem.get() setDataYouTubeID: value];
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166264] trunk
Title: [166264] trunk
Revision 166264
Author bb...@apple.com
Date 2014-03-25 15:56:58 -0700 (Tue, 25 Mar 2014)
Log Message
Source/WebCore: Web Replay: resource unique identifiers should be unique-per-frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130632
Reviewed by Timothy Hatcher.
For replay purposes, we want to deterministically assign resource load identifiers
to resource loaders, provided that the resource loaders are created in the same
order.
To do this, we convert unique identifiers from being globally-unique to being
frame-unique. When a new frame is being loaded, unique identifiers for
subresources of that frame begin counting from 1.
No new tests. Identifier invariants are exercised by existing assertions and tests.
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::createUniqueIdentifier):
* loader/ProgressTracker.h:
Tools: Web Replay: resource unique identifiers should be unique-per-frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130623
Reviewed by Timothy Hatcher.
The resource loader callback dumping routines assumed that resource identifiers
were globally unique. Its map of resource identifiers to URLs must also track the
frame associated with the resource.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
stable as long as the frame is valid.
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ProgressTracker.cpp
trunk/Source/WebCore/loader/ProgressTracker.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166263 => 166264)
--- trunk/Source/WebCore/ChangeLog 2014-03-25 22:38:52 UTC (rev 166263)
+++ trunk/Source/WebCore/ChangeLog 2014-03-25 22:56:58 UTC (rev 166264)
@@ -1,3 +1,26 @@
+2014-03-25 Brian Burg bb...@apple.com
+
+Web Replay: resource unique identifiers should be unique-per-frame, not globally
+https://bugs.webkit.org/show_bug.cgi?id=130632
+
+Reviewed by Timothy Hatcher.
+
+For replay purposes, we want to deterministically assign resource load identifiers
+to resource loaders, provided that the resource loaders are created in the same
+order.
+
+To do this, we convert unique identifiers from being globally-unique to being
+frame-unique. When a new frame is being loaded, unique identifiers for
+subresources of that frame begin counting from 1.
+
+No new tests. Identifier invariants are exercised by existing assertions and tests.
+
+* loader/ProgressTracker.cpp:
+(WebCore::ProgressTracker::ProgressTracker):
+(WebCore::ProgressTracker::reset):
+(WebCore::ProgressTracker::createUniqueIdentifier):
+* loader/ProgressTracker.h:
+
2014-03-25 Jer Noble jer.no...@apple.com
[Mac] Pause the media element during system sleep.
Modified: trunk/Source/WebCore/loader/ProgressTracker.cpp (166263 => 166264)
--- trunk/Source/WebCore/loader/ProgressTracker.cpp 2014-03-25 22:38:52 UTC (rev 166263)
+++ trunk/Source/WebCore/loader/ProgressTracker.cpp 2014-03-25 22:56:58 UTC (rev 166264)
@@ -73,8 +73,6 @@
long long estimatedLength;
};
-unsigned long ProgressTracker::s_uniqueIdentifier = 0;
-
ProgressTracker::ProgressTracker(ProgressTrackerClient client)
: m_client(client)
, m_totalPageAndResourceBytesToLoad(0)
@@ -84,6 +82,7 @@
, m_progressNotificationTimeInterval(std::chrono::milliseconds(100))
, m_finalProgressChangedSent(false)
, m_progressValue(0)
+, m_nextUniqueIdentifier(1)
, m_numProgressTrackedFrames(0)
, m_progressHeartbeatTimer(this, ProgressTracker::progressHeartbeatTimerFired)
, m_heartbeatsWithNoProgress(0)
@@ -114,6 +113,7 @@
m_finalProgressChangedSent = false;
m_numProgressTrackedFrames = 0;
m_originatingProgressFrame = 0;
+// Don't reset m_nextUniqueIdentifier. More loads could start after reset() is called.
m_heartbeatsWithNoProgress = 0;
m_totalBytesReceivedBeforePreviousHeartbeat = 0;
@@ -294,7 +294,7 @@
unsigned long ProgressTracker::createUniqueIdentifier()
{
-return ++s_uniqueIdentifier;
+return m_nextUniqueIdentifier++;
}
bool ProgressTracker::isMainLoadProgressing() const
Modified: trunk/Source/WebCore/loader/ProgressTracker.h (166263 => 166264)
--- trunk/Source/WebCore/loader/ProgressTracker.h 2014-03-25 22:38:52 UTC (rev 166263)
+++
[webkit-changes] [166265] trunk/Source/WebKit2
Title: [166265] trunk/Source/WebKit2
Revision 166265
Author ander...@apple.com
Date 2014-03-25 16:20:14 -0700 (Tue, 25 Mar 2014)
Log Message
Pass the source frame to the CreateNewPage message
https://bugs.webkit.org/show_bug.cgi?id=130752
Reviewed by Tim Horton.
* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166264 => 166265)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 22:56:58 UTC (rev 166264)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 23:20:14 UTC (rev 166265)
@@ -1,5 +1,23 @@
2014-03-25 Anders Carlsson ander...@apple.com
+Pass the source frame to the CreateNewPage message
+https://bugs.webkit.org/show_bug.cgi?id=130752
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::createNewPage):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::createNewPage):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::createWindow):
+
+2014-03-25 Anders Carlsson ander...@apple.com
+
Add a WebFrame::fromCoreFrame static member function and use it where possible
https://bugs.webkit.org/show_bug.cgi?id=130744
Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (166264 => 166265)
--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-03-25 22:56:58 UTC (rev 166264)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-03-25 23:20:14 UTC (rev 166265)
@@ -62,7 +62,7 @@
public:
virtual ~UIClient() { }
-virtual PassRefPtrWebKit::WebPageProxy createNewPage(WebKit::WebPageProxy*, const WebCore::ResourceRequest, const WebCore::WindowFeatures, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button) { return nullptr; }
+virtual PassRefPtrWebKit::WebPageProxy createNewPage(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceRequest, const WebCore::WindowFeatures, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button) { return nullptr; }
virtual void showPage(WebKit::WebPageProxy*) { }
virtual void close(WebKit::WebPageProxy*) { }
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (166264 => 166265)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-03-25 22:56:58 UTC (rev 166264)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-03-25 23:20:14 UTC (rev 166265)
@@ -1085,7 +1085,7 @@
}
private:
-virtual PassRefPtrWebPageProxy createNewPage(WebPageProxy* page, const ResourceRequest resourceRequest, const WindowFeatures windowFeatures, WebEvent::Modifiers modifiers, WebMouseEvent::Button button) override
+virtual PassRefPtrWebPageProxy createNewPage(WebPageProxy* page, WebFrameProxy*, const ResourceRequest resourceRequest, const WindowFeatures windowFeatures, WebEvent::Modifiers modifiers, WebMouseEvent::Button button) override
{
if (!m_client.base.version !m_client.createNewPage_deprecatedForUseWithV0)
return 0;
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (166264 => 166265)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-03-25 22:56:58 UTC (rev 166264)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-03-25 23:20:14 UTC (rev 166265)
@@ -2658,9 +2658,12 @@
// UIClient
-void WebPageProxy::createNewPage(const ResourceRequest request, const WindowFeatures windowFeatures, uint32_t opaqueModifiers, int32_t opaqueMouseButton, uint64_t newPageID, WebPageCreationParameters newPageParameters)
+void WebPageProxy::createNewPage(uint64_t frameID, const ResourceRequest request, const WindowFeatures windowFeatures, uint32_t opaqueModifiers, int32_t opaqueMouseButton, uint64_t newPageID, WebPageCreationParameters newPageParameters)
{
-RefPtrWebPageProxy newPage = m_uiClient-createNewPage(this, request, windowFeatures, static_castWebEvent::Modifiers(opaqueModifiers), static_castWebMouseEvent::Button(opaqueMouseButton));
+WebFrameProxy* frame = m_process-webFrame(frameID);
+MESSAGE_CHECK(frame);
+
+RefPtrWebPageProxy newPage = m_uiClient-createNewPage(this, frame, request, windowFeatures,
[webkit-changes] [166266] trunk/Source/JavaScriptCore
Title: [166266] trunk/Source/_javascript_Core Revision 166266 Author fpi...@apple.com Date 2014-03-25 16:28:48 -0700 (Tue, 25 Mar 2014) Log Message Fix 32-bit getter call alignment. Reviewed by Mark Hahnenberg. * jit/Repatch.cpp: (JSC::generateGetByIdStub): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/Repatch.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (166265 => 166266) --- trunk/Source/_javascript_Core/ChangeLog 2014-03-25 23:20:14 UTC (rev 166265) +++ trunk/Source/_javascript_Core/ChangeLog 2014-03-25 23:28:48 UTC (rev 166266) @@ -1,5 +1,14 @@ 2014-03-25 Filip Pizlo fpi...@apple.com +Fix 32-bit getter call alignment. + +Reviewed by Mark Hahnenberg. + +* jit/Repatch.cpp: +(JSC::generateGetByIdStub): + +2014-03-25 Filip Pizlo fpi...@apple.com + Repatch should plant calls to getters directly rather than through a C helper https://bugs.webkit.org/show_bug.cgi?id=129589 Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (166265 => 166266) --- trunk/Source/_javascript_Core/jit/Repatch.cpp 2014-03-25 23:20:14 UTC (rev 166265) +++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2014-03-25 23:28:48 UTC (rev 166266) @@ -340,8 +340,8 @@ // - Any byte between FP (exclusive) and SP (inclusive) could be live in the calling // code. // -// Therefore, we temporary grow the stack for the purpose of the call and then -// degrow it after. +// Therefore, we temporarily grow the stack for the purpose of the call and then +// shrink it after. callLinkInfo = std::make_uniqueCallLinkInfo(); callLinkInfo-callType = CallLinkInfo::Call; @@ -363,15 +363,14 @@ unsigned numberOfRegsForCall = JSStack::CallFrameHeaderSize + numberOfParameters; -unsigned alignedNumberOfNeededRegs = -WTF::roundUpToMultipleOf(stackAlignmentRegisters(), numberOfRegsForCall); +unsigned numberOfBytesForCall = +numberOfRegsForCall * sizeof(Register) - sizeof(CallerFrameAndPC); -unsigned alignedNumberOfNeededBytes = -alignedNumberOfNeededRegs * sizeof(Register); +unsigned alignedNumberOfBytesForCall = +WTF::roundUpToMultipleOf(stackAlignmentBytes(), numberOfBytesForCall); stubJit.subPtr( -MacroAssembler::TrustedImm32( -alignedNumberOfNeededBytes - sizeof(CallerFrameAndPC)), +MacroAssembler::TrustedImm32(alignedNumberOfBytesForCall), MacroAssembler::stackPointerRegister); MacroAssembler::Address calleeFrame = MacroAssembler::Address( @@ -404,8 +403,7 @@ fastPathCall = stubJit.nearCall(); stubJit.addPtr( -MacroAssembler::TrustedImm32( -alignedNumberOfNeededBytes - sizeof(CallerFrameAndPC)), +MacroAssembler::TrustedImm32(alignedNumberOfBytesForCall), MacroAssembler::stackPointerRegister); done.append(stubJit.jump()); @@ -419,8 +417,7 @@ slowPathCall = stubJit.nearCall(); stubJit.addPtr( -MacroAssembler::TrustedImm32( -alignedNumberOfNeededBytes - sizeof(CallerFrameAndPC)), +MacroAssembler::TrustedImm32(alignedNumberOfBytesForCall), MacroAssembler::stackPointerRegister); done.append(stubJit.jump()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166267] trunk/Source/WebKit2
Title: [166267] trunk/Source/WebKit2 Revision 166267 Author ander...@apple.com Date 2014-03-25 16:37:01 -0700 (Tue, 25 Mar 2014) Log Message Change toolbarVisibility back to toolbarsVisibility https://bugs.webkit.org/show_bug.cgi?id=130749 Reviewed by Tim Horton. * UIProcess/API/Cocoa/WKWindowFeatures.h: * UIProcess/API/Cocoa/WKWindowFeatures.mm: (-[WKWindowFeatures _initWithWindowFeatures:WebCore::]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (166266 => 166267) --- trunk/Source/WebKit2/ChangeLog 2014-03-25 23:28:48 UTC (rev 166266) +++ trunk/Source/WebKit2/ChangeLog 2014-03-25 23:37:01 UTC (rev 166267) @@ -1,5 +1,16 @@ 2014-03-25 Anders Carlsson ander...@apple.com +Change toolbarVisibility back to toolbarsVisibility +https://bugs.webkit.org/show_bug.cgi?id=130749 + +Reviewed by Tim Horton. + +* UIProcess/API/Cocoa/WKWindowFeatures.h: +* UIProcess/API/Cocoa/WKWindowFeatures.mm: +(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]): + +2014-03-25 Anders Carlsson ander...@apple.com + Pass the source frame to the CreateNewPage message https://bugs.webkit.org/show_bug.cgi?id=130752 Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h (166266 => 166267) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 23:28:48 UTC (rev 166266) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 23:37:01 UTC (rev 166267) @@ -33,7 +33,7 @@ @property (nonatomic, readonly) NSNumber *menuBarVisibility; @property (nonatomic, readonly) NSNumber *statusBarVisibility; -@property (nonatomic, readonly) NSNumber *toolbarVisibility; +@property (nonatomic, readonly) NSNumber *toolbarsVisibility; @property (nonatomic, readonly) NSNumber *allowsResizing; Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm (166266 => 166267) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 23:28:48 UTC (rev 166266) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 23:37:01 UTC (rev 166267) @@ -52,7 +52,7 @@ // FIXME: These should be set to nil if the features didn't exist in the string. _menuBarVisibility = @(windowFeatures.menuBarVisible); _statusBarVisibility = @(windowFeatures.statusBarVisible); -_toolbarVisibility = @(windowFeatures.toolBarVisible); +_toolbarsVisibility = @(windowFeatures.toolBarVisible || windowFeatures.locationBarVisible); _allowsResizing = @(windowFeatures.resizable); if (windowFeatures.xSet) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166268] trunk/Source/WebCore
Title: [166268] trunk/Source/WebCore Revision 166268 Author jer.no...@apple.com Date 2014-03-25 16:43:13 -0700 (Tue, 25 Mar 2014) Log Message [iOS] Enable caption support in full screen. https://bugs.webkit.org/show_bug.cgi?id=130603 Reviewed by Eric Carlson. Add TextTrackRepresentation support to MediaPlayerPrivateAVFoundationObjC. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Add the m_textTrackRepresenationLayer if present. (WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation): True, if a m_videoFullscreenLayer is present. (WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation): Remove the old, and add the new m_textTrackRepresenationLayer. Make the text track container a stacking context for painting purposes. * Modules/mediacontrols/mediaControlsiOS.css: (video::-webkit-media-text-track-container): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166267 => 166268) --- trunk/Source/WebCore/ChangeLog 2014-03-25 23:37:01 UTC (rev 166267) +++ trunk/Source/WebCore/ChangeLog 2014-03-25 23:43:13 UTC (rev 166268) @@ -1,3 +1,23 @@ +2014-03-21 Jer Noble jer.no...@apple.com + +[iOS] Enable caption support in full screen. +https://bugs.webkit.org/show_bug.cgi?id=130603 + +Reviewed by Eric Carlson. + +Add TextTrackRepresentation support to MediaPlayerPrivateAVFoundationObjC. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Add the m_textTrackRepresenationLayer if present. +(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): Ditto. +(WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation): True, if a m_videoFullscreenLayer is present. +(WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation): Remove the old, and add the new m_textTrackRepresenationLayer. + +Make the text track container a stacking context for painting purposes. +* Modules/mediacontrols/mediaControlsiOS.css: +(video::-webkit-media-text-track-container): + 2014-03-25 Brian Burg bb...@apple.com Web Replay: resource unique identifiers should be unique-per-frame, not globally Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (166267 => 166268) --- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-03-25 23:37:01 UTC (rev 166267) +++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-03-25 23:43:13 UTC (rev 166268) @@ -295,6 +295,7 @@ width: 100%; overflow: hidden; padding-bottom: 5px; +z-index: 0; text-align: center; color: rgba(255, 255, 255, 1); Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (166267 => 166268) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2014-03-25 23:37:01 UTC (rev 166267) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2014-03-25 23:43:13 UTC (rev 166268) @@ -190,7 +190,12 @@ virtual void updateVideoLayerGravity() override; virtual bool hasSingleSecurityOrigin() const; - + +#if ENABLE(VIDEO_TRACK) +virtual bool requiresTextTrackRepresentation() const override; +virtual void setTextTrackRepresentation(TextTrackRepresentation*) override; +#endif + void createImageGenerator(); void destroyImageGenerator(); RetainPtrCGImageRef createImageForTimeInRect(float, const IntRect); @@ -254,6 +259,7 @@ RetainPtrPlatformLayer m_videoFullscreenLayer; FloatRect m_videoFullscreenFrame; MediaPlayer::VideoGravity m_videoFullscreenGravity; +RetainPtrPlatformLayer m_textTrackRepresentationLayer; #endif RetainPtrWebCoreAVFMovieObserver m_objcObserver; RetainPtrid m_timeObserver; Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (166267 => 166268) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-25 23:37:01 UTC (rev 166267) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-25 23:43:13 UTC (rev 166268) @@ -48,6 +48,7
[webkit-changes] [166269] trunk/Source/WebKit2
Title: [166269] trunk/Source/WebKit2
Revision 166269
Author ander...@apple.com
Date 2014-03-25 17:00:17 -0700 (Tue, 25 Mar 2014)
Log Message
Move stopLoading: back for now.
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166268 => 166269)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 23:43:13 UTC (rev 166268)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-26 00:00:17 UTC (rev 166269)
@@ -1,5 +1,13 @@
2014-03-25 Anders Carlsson ander...@apple.com
+Move stopLoading: back for now.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView stopLoading:]):
+
+2014-03-25 Anders Carlsson ander...@apple.com
+
Change toolbarVisibility back to toolbarsVisibility
https://bugs.webkit.org/show_bug.cgi?id=130749
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (166268 => 166269)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-25 23:43:13 UTC (rev 166268)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h 2014-03-26 00:00:17 UTC (rev 166269)
@@ -118,6 +118,8 @@
- (WKNavigation *)goBack;
- (WKNavigation *)goForward;
+- (IBAction)stopLoading:(id)sender;
+
@property (nonatomic) BOOL allowsBackForwardNavigationGestures;
#if TARGET_OS_IPHONE
@@ -138,8 +140,6 @@
- (IBAction)goBack:(id)sender;
- (IBAction)goForward:(id)sender;
-- (IBAction)stopLoading:(id)sender;
-
@end
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166268 => 166269)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-25 23:43:13 UTC (rev 166268)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-26 00:00:17 UTC (rev 166269)
@@ -308,6 +308,11 @@
return nil;
}
+- (IBAction)stopLoading:(id)sender
+{
+_page-stopLoading();
+}
+
#pragma mark iOS-specific methods
#if PLATFORM(IOS)
@@ -1217,11 +1222,6 @@
[self goForward];
}
-- (IBAction)stopLoading:(id)sender
-{
-_page-stopLoading();
-}
-
@end
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166270] trunk/Source/WebKit2
Title: [166270] trunk/Source/WebKit2
Revision 166270
Author ander...@apple.com
Date 2014-03-25 17:01:09 -0700 (Tue, 25 Mar 2014)
Log Message
Add a UI delegate callback for handling window.open
https://bugs.webkit.org/show_bug.cgi?id=130757
Reviewed by Sam Weinig.
* UIProcess/API/Cocoa/WKUIDelegate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/Cocoa/UIClient.h:
* UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::createNewPage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166269 => 166270)
--- trunk/Source/WebKit2/ChangeLog 2014-03-26 00:00:17 UTC (rev 166269)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-26 00:01:09 UTC (rev 166270)
@@ -1,5 +1,20 @@
2014-03-25 Anders Carlsson ander...@apple.com
+Add a UI delegate callback for handling window.open
+https://bugs.webkit.org/show_bug.cgi?id=130757
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/Cocoa/WKUIDelegate.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+* UIProcess/API/Cocoa/WKWebViewInternal.h:
+* UIProcess/Cocoa/UIClient.h:
+* UIProcess/Cocoa/UIClient.mm:
+(WebKit::UIClient::setDelegate):
+(WebKit::UIClient::createNewPage):
+
+2014-03-25 Anders Carlsson ander...@apple.com
+
Move stopLoading: back for now.
* UIProcess/API/Cocoa/WKWebView.h:
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h (166269 => 166270)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h 2014-03-26 00:00:17 UTC (rev 166269)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h 2014-03-26 00:01:09 UTC (rev 166270)
@@ -29,11 +29,17 @@
#if WK_API_ENABLED
@class WKFrameInfo;
+@class WKWebViewConfiguration;
+@class WKWindowFeatures;
@protocol WKUIDelegate NSObject
@optional
+// FIXME: Maybe we should pass a WKNavigationAction instead of request and frame.
+// The C SPI has the key modifiers and mouse button as well.
+- (WKWebView *)webView:(WKWebView *)webView createWebViewWithConfiguration:(WKWebViewConfiguration *)configuration request:(NSURLRequest *)request windowFeatures:(WKWindowFeatures *)windowFeatures initiatedByFrame:(WKFrameInfo *)frame;
+
- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)())completionHandler;
- (void)webView:(WKWebView *)webView runJavaScriptConfirmPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(BOOL result))completionHandler;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166269 => 166270)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-26 00:00:17 UTC (rev 166269)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-03-26 00:01:09 UTC (rev 166270)
@@ -77,7 +77,6 @@
#endif
@implementation WKWebView {
-RetainPtrWKWebViewConfiguration _configuration;
std::unique_ptrWebKit::NavigationState _navigationState;
RetainPtrWKRemoteObjectRegistry _remoteObjectRegistry;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h (166269 => 166270)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h 2014-03-26 00:00:17 UTC (rev 166269)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h 2014-03-26 00:01:09 UTC (rev 166270)
@@ -28,6 +28,7 @@
#if WK_API_ENABLED
#import wtf/RefPtr.h
+#import wtf/RetainPtr.h
#if PLATFORM(IOS)
#import WKContentView.h
@@ -50,6 +51,8 @@
@interface WKWebView () WK_WEB_VIEW_PROTOCOLS {
@package
+RetainPtrWKWebViewConfiguration _configuration;
+
RefPtrWebKit::WebPageProxy _page;
}
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h (166269 => 166270)
--- trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h 2014-03-26 00:00:17 UTC (rev 166269)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h 2014-03-26 00:01:09 UTC (rev 166270)
@@ -52,6 +52,7 @@
private:
// API::UIClient
+virtual PassRefPtrWebKit::WebPageProxy createNewPage(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceRequest, const WebCore::WindowFeatures, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button) override;
virtual void runJavaScriptAlert(WebKit::WebPageProxy*, const WTF::String, WebKit::WebFrameProxy*, std::functionvoid () completionHandler) override;
virtual void runJavaScriptConfirm(WebKit::WebPageProxy*, const WTF::String, WebKit::WebFrameProxy*, std::functionvoid (bool) completionHandler) override;
virtual void runJavaScriptPrompt(WebKit::WebPageProxy*, const WTF::String,
[webkit-changes] [166271] trunk/Source/WebKit2
Title: [166271] trunk/Source/WebKit2
Revision 166271
Author psola...@apple.com
Date 2014-03-25 17:31:55 -0700 (Tue, 25 Mar 2014)
Log Message
Remove PLATFORM(IOS) from NetworkProcessMac.mm
https://bugs.webkit.org/show_bug.cgi?id=130751
Reviewed by Alexey Proskuryakov.
Code in NetworkProcessMac.mm is guarded by PLATFORM(MAC) and so is not compiled on iOS.
Having PLATFORM(IOS) code in this file is unnecessary and confusing.
* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::overrideSystemProxies):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166270 => 166271)
--- trunk/Source/WebKit2/ChangeLog 2014-03-26 00:01:09 UTC (rev 166270)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-26 00:31:55 UTC (rev 166271)
@@ -1,3 +1,18 @@
+2014-03-25 Pratik Solanki psola...@apple.com
+
+Remove PLATFORM(IOS) from NetworkProcessMac.mm
+https://bugs.webkit.org/show_bug.cgi?id=130751
+
+Reviewed by Alexey Proskuryakov.
+
+Code in NetworkProcessMac.mm is guarded by PLATFORM(MAC) and so is not compiled on iOS.
+Having PLATFORM(IOS) code in this file is unnecessary and confusing.
+
+* NetworkProcess/mac/NetworkProcessMac.mm:
+(WebKit::NetworkProcess::initializeProcessName):
+(WebKit::overrideSystemProxies):
+(WebKit::NetworkProcess::platformInitializeNetworkProcess):
+
2014-03-25 Anders Carlsson ander...@apple.com
Add a UI delegate callback for handling window.open
Modified: trunk/Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm (166270 => 166271)
--- trunk/Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm 2014-03-26 00:01:09 UTC (rev 166270)
+++ trunk/Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm 2014-03-26 00:31:55 UTC (rev 166271)
@@ -51,7 +51,7 @@
extern C CFURLCacheRef CFURLCacheCopySharedURLCache();
extern C void _CFURLCachePurgeMemoryCache(CFURLCacheRef);
-#if !PLATFORM(IOS) __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
+#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
extern C void _CFURLCacheSetMinSizeForVMCachedResource(CFURLCacheRef, CFIndex);
#endif
@@ -71,15 +71,10 @@
void NetworkProcess::initializeProcessName(const ChildProcessInitializationParameters parameters)
{
-#if PLATFORM(IOS)
-UNUSED_PARAM(parameters);
-#else
NSString *applicationName = [NSString stringWithFormat:WEB_UI_STRING(%@ Networking, visible name of the network process. The argument is the application name.), (NSString *)parameters.uiProcessName];
WKSetVisibleApplicationName((CFStringRef)applicationName);
-#endif
}
-#if !PLATFORM(IOS)
static void overrideSystemProxies(const String httpProxy, const String httpsProxy)
{
NSMutableDictionary *proxySettings = [NSMutableDictionary dictionary];
@@ -112,7 +107,6 @@
if ([proxySettings count] 0)
WKCFNetworkSetOverrideSystemProxySettings((CFDictionaryRef)proxySettings);
}
-#endif
void NetworkProcess::platformLowMemoryHandler(bool)
{
@@ -135,12 +129,10 @@
SecItemShim::shared().initialize(this);
#endif
-#if !PLATFORM(IOS)
if (!parameters.httpProxy.isNull() || !parameters.httpsProxy.isNull())
overrideSystemProxies(parameters.httpProxy, parameters.httpsProxy);
-#endif
-#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
+#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
RetainPtrCFURLCacheRef cache = adoptCF(CFURLCacheCopySharedURLCache());
if (!cache)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166272] trunk/Source/WebCore
Title: [166272] trunk/Source/WebCore
Revision 166272
Author psola...@apple.com
Date 2014-03-25 17:39:55 -0700 (Tue, 25 Mar 2014)
Log Message
Attempt to fix iOS build after r166261.
* WebCore.xcodeproj/project.pbxproj: Make SystemSleepListener.h a private header.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (166271 => 166272)
--- trunk/Source/WebCore/ChangeLog 2014-03-26 00:31:55 UTC (rev 166271)
+++ trunk/Source/WebCore/ChangeLog 2014-03-26 00:39:55 UTC (rev 166272)
@@ -1,3 +1,9 @@
+2014-03-25 Pratik Solanki psola...@apple.com
+
+Attempt to fix iOS build after r166261.
+
+* WebCore.xcodeproj/project.pbxproj: Make SystemSleepListener.h a private header.
+
2014-03-21 Jer Noble jer.no...@apple.com
[iOS] Enable caption support in full screen.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (166271 => 166272)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-03-26 00:31:55 UTC (rev 166271)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-03-26 00:39:55 UTC (rev 166272)
@@ -5560,7 +5560,7 @@
CD9DE18117AAD6A400EA386D /* DOMURLMediaSource.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD9DE17E17AAD64E00EA386D /* DOMURLMediaSource.cpp */; };
CD9DE18217AAD6A400EA386D /* DOMURLMediaSource.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9DE17F17AAD64E00EA386D /* DOMURLMediaSource.h */; };
CDA07FBD18E0A16A004699FA /* SystemSleepListener.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDA07FBB18E0A16A004699FA /* SystemSleepListener.cpp */; };
- CDA07FBE18E0A16A004699FA /* SystemSleepListener.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA07FBC18E0A16A004699FA /* SystemSleepListener.h */; };
+ CDA07FBE18E0A16A004699FA /* SystemSleepListener.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA07FBC18E0A16A004699FA /* SystemSleepListener.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDA07FC118E0A22B004699FA /* SystemSleepListenerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDA07FBF18E0A22B004699FA /* SystemSleepListenerMac.mm */; };
CDA07FC218E0A22B004699FA /* SystemSleepListenerMac.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA07FC018E0A22B004699FA /* SystemSleepListenerMac.h */; };
CDA79824170A258300D45C55 /* AudioSession.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDA79823170A258300D45C55 /* AudioSession.cpp */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166274] trunk/Source/WebCore
Title: [166274] trunk/Source/WebCore Revision 166274 Author eric.carl...@apple.com Date 2014-03-25 17:57:25 -0700 (Tue, 25 Mar 2014) Log Message [Mac] Always retry a failed MediaDocument as a PluginDocument https://bugs.webkit.org/show_bug.cgi?id=130742 Reviewed by Jer Noble. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaLoadingFailedFatally): If the element is in a media document, tell it that loading failed so it can retry as a plug-in. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166273 => 166274) --- trunk/Source/WebCore/ChangeLog 2014-03-26 00:49:05 UTC (rev 166273) +++ trunk/Source/WebCore/ChangeLog 2014-03-26 00:57:25 UTC (rev 166274) @@ -1,3 +1,14 @@ +2014-03-25 Eric Carlson eric.carl...@apple.com + +[Mac] Always retry a failed MediaDocument as a PluginDocument +https://bugs.webkit.org/show_bug.cgi?id=130742 + +Reviewed by Jer Noble. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::mediaLoadingFailedFatally): If the element is in a media document, +tell it that loading failed so it can retry as a plug-in. + 2014-03-25 Ryosuke Niwa rn...@webkit.org Replace HTMLConverter::_stringForNode by propertyValueForNode Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166273 => 166274) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-26 00:49:05 UTC (rev 166273) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-26 00:57:25 UTC (rev 166274) @@ -1876,6 +1876,11 @@ // 6 - Abort the overall resource selection algorithm. m_currentSourceNode = 0; + +#if PLATFORM(COCOA) +if (document().isMediaDocument()) +toMediaDocument(document()).mediaElementSawUnsupportedTracks(); +#endif } void HTMLMediaElement::cancelPendingEventsAndCallbacks() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166275] trunk/Tools
Title: [166275] trunk/Tools
Revision 166275
Author aes...@apple.com
Date 2014-03-25 18:47:26 -0700 (Tue, 25 Mar 2014)
Log Message
Fix a failing API test on Mountain Lion and remove temporary debug logging.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveData:]):
(-[DownloadDelegate _downloadDidFinish:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm
Diff
Modified: trunk/Tools/ChangeLog (166274 => 166275)
--- trunk/Tools/ChangeLog 2014-03-26 00:57:25 UTC (rev 166274)
+++ trunk/Tools/ChangeLog 2014-03-26 01:47:26 UTC (rev 166275)
@@ -1,3 +1,11 @@
+2014-03-25 Andy Estes aes...@apple.com
+
+Fix a failing API test on Mountain Lion and remove temporary debug logging.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+(-[DownloadDelegate _download:didReceiveData:]):
+(-[DownloadDelegate _downloadDidFinish:]):
+
2014-03-25 Brian Burg bb...@apple.com
Web Replay: resource unique identifiers should be unique-per-frame, not globally
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (166274 => 166275)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-26 00:57:25 UTC (rev 166274)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-26 01:47:26 UTC (rev 166275)
@@ -87,7 +87,6 @@
- (void)_download:(_WKDownload *)download didReceiveData:(uint64_t)length
{
-NSLog(@didReceiveData: %llu\n, length);
EXPECT_EQ(_download, download);
_receivedContentLength += length;
}
@@ -107,8 +106,10 @@
- (void)_downloadDidFinish:(_WKDownload *)download
{
-NSLog(@_expectedContentLength: %lld\n, _expectedContentLength);
-NSLog(@_receivedContentLength: %llu\n, _receivedContentLength);
+#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1080
+// Work around rdar://problem/7611450 NSURLDownload calls didReceiveDataOfLength: delegate method too many times
+_receivedContentLength /= 2;
+#endif
EXPECT_EQ(_download, download);
EXPECT_TRUE(_expectedContentLength == NSURLResponseUnknownLength || static_castuint64_t(_expectedContentLength) == _receivedContentLength);
EXPECT_TRUE([[NSFileManager defaultManager] contentsEqualAtPath:_destinationPath andPath:[_sourceURL path]]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166276] trunk/Source/JavaScriptCore
Title: [166276] trunk/Source/_javascript_Core
Revision 166276
Author fpi...@apple.com
Date 2014-03-25 19:14:40 -0700 (Tue, 25 Mar 2014)
Log Message
DFG::ByteCodeParser::SetMode should distinguish between setting immediately without a flush and setting immediately with a flush
https://bugs.webkit.org/show_bug.cgi?id=130760
Reviewed by Mark Hahnenberg.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
* tests/stress/assign-argument-in-inlined-call.js: Added.
(f1):
(getF2Arguments):
(f2):
(f3):
* tests/stress/assign-captured-argument-in-inlined-call.js: Added.
(f1):
(f2):
(f3):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/assign-argument-in-inlined-call.js
trunk/Source/_javascript_Core/tests/stress/assign-captured-argument-in-inlined-call.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166275 => 166276)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-26 01:47:26 UTC (rev 166275)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-26 02:14:40 UTC (rev 166276)
@@ -1,5 +1,27 @@
2014-03-25 Filip Pizlo fpi...@apple.com
+DFG::ByteCodeParser::SetMode should distinguish between setting immediately without a flush and setting immediately with a flush
+https://bugs.webkit.org/show_bug.cgi?id=130760
+
+Reviewed by Mark Hahnenberg.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::setLocal):
+(JSC::DFG::ByteCodeParser::setArgument):
+(JSC::DFG::ByteCodeParser::handleInlining):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* tests/stress/assign-argument-in-inlined-call.js: Added.
+(f1):
+(getF2Arguments):
+(f2):
+(f3):
+* tests/stress/assign-captured-argument-in-inlined-call.js: Added.
+(f1):
+(f2):
+(f3):
+
+2014-03-25 Filip Pizlo fpi...@apple.com
+
Fix 32-bit getter call alignment.
Reviewed by Mark Hahnenberg.
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (166275 => 166276)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-03-26 01:47:26 UTC (rev 166275)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-03-26 02:14:40 UTC (rev 166276)
@@ -249,7 +249,25 @@
return getDirect(m_inlineStackTop-remapOperand(operand));
}
-enum SetMode { NormalSet, ImmediateSet };
+enum SetMode {
+// A normal set which follows a two-phase commit that spans code origins. During
+// the current code origin it issues a MovHint, and at the start of the next
+// code origin there will be a SetLocal. If the local needs flushing, the second
+// SetLocal will be preceded with a Flush.
+NormalSet,
+
+// A set where the SetLocal happens immediately and there is still a Flush. This
+// is relevant when assigning to a local in tricky situations for the delayed
+// SetLocal logic but where we know that we have not performed any side effects
+// within this code origin. This is a safe replacement for NormalSet anytime we
+// know that we have not yet performed side effects in this code origin.
+ImmediateSetWithFlush,
+
+// A set where the SetLocal happens immediately and we do not Flush it even if
+// this is a local that is marked as needing it. This is relevant when
+// initializing locals at the top of a function.
+ImmediateNakedSet
+};
Node* setDirect(VirtualRegister operand, Node* value, SetMode setMode = NormalSet)
{
addToGraph(MovHint, OpInfo(operand.offset()), value);
@@ -340,7 +358,7 @@
unsigned local = operand.toLocal();
bool isCaptured = m_codeBlock-isCaptured(operand, inlineCallFrame());
-if (setMode == NormalSet) {
+if (setMode != ImmediateNakedSet) {
ArgumentPosition* argumentPosition = findArgumentPositionForLocal(operand);
if (isCaptured || argumentPosition)
flushDirect(operand, argumentPosition);
@@ -399,7 +417,7 @@
// Always flush arguments, except for 'this'. If 'this' is created by us,
// then make sure that it's never unboxed.
if (argument) {
-if (setMode == NormalSet)
+if (setMode != ImmediateNakedSet)
flushDirect(operand);
} else if (m_codeBlock-specializationKind() == CodeForConstruct)
variableAccessData-mergeShouldNeverUnbox(true);
@@ -1399,9 +1417,9 @@
== callLinkStatus.isClosureCall());
if (callLinkStatus.isClosureCall()) {
VariableAccessData* calleeVariable =
-set(VirtualRegister(JSStack::Callee), callTargetNode,
[webkit-changes] [166277] trunk
Title: [166277] trunk
Revision 166277
Author commit-qu...@webkit.org
Date 2014-03-25 19:30:27 -0700 (Tue, 25 Mar 2014)
Log Message
When the mouse is upped after dragged out of shadowDOM, it should lose :active.
https://bugs.webkit.org/show_bug.cgi?id=130660
Patch by Sanghyup Lee sh53@samsung.com on 2014-03-25
Reviewed by Darin Adler.
Source/WebCore:
This caused a regression after r165037.
When we have to clear :active style of shadow DOM, we should clear host's style.
This patch replaces parentElement() by parentOrShadowHostElement().
* dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
LayoutTests:
* fast/css/hover-active-drag-expected.txt: Added a test for textarea.
* fast/css/hover-active-drag.html: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/hover-active-drag-expected.txt
trunk/LayoutTests/fast/css/hover-active-drag.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (166276 => 166277)
--- trunk/LayoutTests/ChangeLog 2014-03-26 02:14:40 UTC (rev 166276)
+++ trunk/LayoutTests/ChangeLog 2014-03-26 02:30:27 UTC (rev 166277)
@@ -1,3 +1,13 @@
+2014-03-25 Sanghyup Lee sh53@samsung.com
+
+When the mouse is upped after dragged out of shadowDOM, it should lose :active.
+https://bugs.webkit.org/show_bug.cgi?id=130660
+
+Reviewed by Darin Adler.
+
+* fast/css/hover-active-drag-expected.txt: Added a test for textarea.
+* fast/css/hover-active-drag.html: Updated.
+
2014-03-25 Filip Pizlo fpi...@apple.com
Repatch should plant calls to getters directly rather than through a C helper
Modified: trunk/LayoutTests/fast/css/hover-active-drag-expected.txt (166276 => 166277)
--- trunk/LayoutTests/fast/css/hover-active-drag-expected.txt 2014-03-26 02:14:40 UTC (rev 166276)
+++ trunk/LayoutTests/fast/css/hover-active-drag-expected.txt 2014-03-26 02:30:27 UTC (rev 166277)
@@ -1,3 +1,4 @@
+
Dragging out of an element should cause it to lose :hover
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
@@ -12,6 +13,10 @@
PASS background is rgb(0, 0, 0)
PASS background is rgb(0, 0, 0)
PASS background is rgb(0, 0, 0)
+PASS background is rgb(255, 0, 0)
+PASS background is rgb(255, 255, 0)
+PASS background is rgb(0, 255, 0)
+PASS background is rgb(0, 0, 0)
Modified: trunk/LayoutTests/fast/css/hover-active-drag.html (166276 => 166277)
--- trunk/LayoutTests/fast/css/hover-active-drag.html 2014-03-26 02:14:40 UTC (rev 166276)
+++ trunk/LayoutTests/fast/css/hover-active-drag.html 2014-03-26 02:30:27 UTC (rev 166277)
@@ -1,10 +1,10 @@
!DOCTYPE html
style
- div { background: rgb(0, 0, 0); }
- div:hover { background: rgb(255, 0, 0); }
- div:hover:active { background: rgb(255, 255, 0); }
- div:active { background: rgb(0, 255, 0); }
- div {
+ div, textarea { background: rgb(0, 0, 0); }
+ div:hover, textarea:hover { background: rgb(255, 0, 0); }
+ div:hover:active, textarea:hover:active { background: rgb(255, 255, 0); }
+ div:active, textarea:active { background: rgb(0, 255, 0); }
+ div, textarea {
width: 100px;
height: 100px;
border: 2px solid rgb(0, 0, 255);
@@ -14,6 +14,7 @@
body
div id=box/div
div id=box2/div
+ textarea id=textarea/textarea
pre id=description/div
pre id=console/pre
/body
@@ -59,5 +60,18 @@
eventSender.mouseUp()
shouldHaveBackground(box, 'rgb(0, 0, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
+
+// Move into the textarea.
+eventSender.mouseMoveTo(50, 250)
+shouldHaveBackground(textarea, 'rgb(255, 0, 0)')
+
+eventSender.mouseDown()
+shouldHaveBackground(textarea, 'rgb(255, 255, 0)')
+
+eventSender.mouseMoveTo(400, 250)
+shouldHaveBackground(textarea, 'rgb(0, 255, 0)')
+
+eventSender.mouseUp()
+shouldHaveBackground(textarea, 'rgb(0, 0, 0)')
}
/script
Modified: trunk/Source/WebCore/ChangeLog (166276 => 166277)
--- trunk/Source/WebCore/ChangeLog 2014-03-26 02:14:40 UTC (rev 166276)
+++ trunk/Source/WebCore/ChangeLog 2014-03-26 02:30:27 UTC (rev 166277)
@@ -1,3 +1,17 @@
+2014-03-25 Sanghyup Lee sh53@samsung.com
+
+When the mouse is upped after dragged out of shadowDOM, it should lose :active.
+https://bugs.webkit.org/show_bug.cgi?id=130660
+
+Reviewed by Darin Adler.
+
+This caused a regression after r165037.
+When we have to clear :active style of shadow DOM, we should clear host's style.
+This patch replaces parentElement() by parentOrShadowHostElement().
+
+* dom/Document.cpp:
+(WebCore::Document::updateHoverActiveState):
+
2014-03-25 Eric Carlson eric.carl...@apple.com
[Mac] Always retry a failed MediaDocument as a PluginDocument
Modified: trunk/Source/WebCore/dom/Document.cpp (166276 => 166277)
--- trunk/Source/WebCore/dom/Document.cpp 2014-03-26 02:14:40 UTC (rev 166276)
+++
[webkit-changes] [166279] trunk
Title: [166279] trunk Revision 166279 Author commit-qu...@webkit.org Date 2014-03-25 20:03:39 -0700 (Tue, 25 Mar 2014) Log Message Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode https://bugs.webkit.org/show_bug.cgi?id=130712 Patch by James Craig jcr...@apple.com on 2014-03-25 Reviewed by Timothy Hatcher. Source/WebCore: Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode. * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): * inspector/protocol/DOM.json: Source/WebInspectorUI: Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Models/DOMNode.js: * UserInterface/Views/DOMNodeDetailsSidebarPanel.js: LayoutTests: Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode. * inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: * inspector-protocol/dom/getAccessibilityPropertiesForNode.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp trunk/Source/WebCore/inspector/protocol/DOM.json trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js Diff Modified: trunk/LayoutTests/ChangeLog (166278 => 166279) --- trunk/LayoutTests/ChangeLog 2014-03-26 02:37:51 UTC (rev 166278) +++ trunk/LayoutTests/ChangeLog 2014-03-26 03:03:39 UTC (rev 166279) @@ -1,3 +1,15 @@ +2014-03-25 James Craig jcr...@apple.com + +Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode +https://bugs.webkit.org/show_bug.cgi?id=130712 + +Reviewed by Timothy Hatcher. + +Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode. + +* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: +* inspector-protocol/dom/getAccessibilityPropertiesForNode.html: + 2014-03-25 Sanghyup Lee sh53@samsung.com When the mouse is upped after dragged out of shadowDOM, it should lose :active. Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (166278 => 166279) --- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-03-26 02:37:51 UTC (rev 166278) +++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-03-26 03:03:39 UTC (rev 166279) @@ -7,13 +7,15 @@ label: role: treeitem childNodeIds.length: 1 +parentNodeId: exists -li role=treeitem aria-expanded=falsecollapsed/li +li role=treeitem aria-expanded=false id=activedescendantcollapsed/li exists: true label: role: treeitem childNodeIds.length: 1 expanded: false +parentNodeId: exists li role=treeitem aria-expanded=trueexpanded/li exists: true @@ -21,26 +23,31 @@ role: treeitem childNodeIds.length: 1 expanded: true +parentNodeId: exists -ul role=tree id=flowedTo1 +ul role=tree id=flowedTo1 aria-activedescendant=activedescendant li role=treeitem aria-expanded=trueexpanded/li -li role=treeitem aria-expanded=falsecollapsed/li +li role=treeitem aria-expanded=false id=activedescendantcollapsed/li li role=treeitem aria-expanded=undefinedexpanded/li /ul exists: true label: role: tree +activeDescendantNodeId: exists childNodeIds.length: 3 +parentNodeId: exists div role=tab aria-selected=falsenot selected/div exists: true label: role: tab +parentNodeId: exists div role=tab aria-selected=trueselected/div exists: true label: role: tab +parentNodeId: exists selected: true div role=tablist aria-flowto=flowedTo1 invalidIdRef flowedTo2 @@ -52,16 +59,19 @@ role: tablist childNodeIds.length: 2 flowedNodeIds.length: 2 +parentNodeId: exists div role=option aria-selected=falsenot selected/div exists: true label: role: option +parentNodeId: exists div role=option aria-selected=trueselected/div exists: true label: role: option +parentNodeId: exists selected: true div role=listbox id=ownedlistbox @@ -72,6 +82,7 @@ label: role: listbox childNodeIds.length: 2 +parentNodeId: exists required: false input role=combobox aria-owns=ownedlistbox invalidIdRef
[webkit-changes] [166281] trunk/Source/JavaScriptCore
Title: [166281] trunk/Source/_javascript_Core
Revision 166281
Author fpi...@apple.com
Date 2014-03-25 21:08:52 -0700 (Tue, 25 Mar 2014)
Log Message
Arguments simplification phase should be fine with marking the arguments local itself as an arguments alias
https://bugs.webkit.org/show_bug.cgi?id=130764
rdar://problem/16304788
Reviewed by Sam Weinig.
Being an arguments alias just means that your OSR exit recovery should attempt arguments
creation. This is true of arguments locals. We had special cases that tried to make it not
true of arguments locals. The only consequence of those special cases was to cause crashes
in case of arguments that are also captured variables (i.e. we have SlowArguments). This
change just removes those special cases.
This change means that the FTL will now see SetLocals with a FlushedArguments format.
Previously you wouldn't see them because previously only non-captured variable would be
arguments aliases, and non-captured variables get completely SSAified - i.e. no SetLocals
left. Adding handling for FlushedArguments is a benign and simple change since its
behavior is identical to FlushedJSValue for that code's purposes.
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
* tests/stress/captured-arguments-variable.js: Added.
(foo):
(noInline):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGArgumentsSimplificationPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/captured-arguments-variable.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166280 => 166281)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-26 03:35:30 UTC (rev 166280)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-26 04:08:52 UTC (rev 166281)
@@ -1,3 +1,31 @@
+2014-03-25 Filip Pizlo fpi...@apple.com
+
+Arguments simplification phase should be fine with marking the arguments local itself as an arguments alias
+https://bugs.webkit.org/show_bug.cgi?id=130764
+rdar://problem/16304788
+
+Reviewed by Sam Weinig.
+
+Being an arguments alias just means that your OSR exit recovery should attempt arguments
+creation. This is true of arguments locals. We had special cases that tried to make it not
+true of arguments locals. The only consequence of those special cases was to cause crashes
+in case of arguments that are also captured variables (i.e. we have SlowArguments). This
+change just removes those special cases.
+
+This change means that the FTL will now see SetLocals with a FlushedArguments format.
+Previously you wouldn't see them because previously only non-captured variable would be
+arguments aliases, and non-captured variables get completely SSAified - i.e. no SetLocals
+left. Adding handling for FlushedArguments is a benign and simple change since its
+behavior is identical to FlushedJSValue for that code's purposes.
+
+* dfg/DFGArgumentsSimplificationPhase.cpp:
+(JSC::DFG::ArgumentsSimplificationPhase::run):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
+* tests/stress/captured-arguments-variable.js: Added.
+(foo):
+(noInline):
+
2014-03-25 Mark Hahnenberg mhahnenb...@apple.com
Add HeapInlines
Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsSimplificationPhase.cpp (166280 => 166281)
--- trunk/Source/_javascript_Core/dfg/DFGArgumentsSimplificationPhase.cpp 2014-03-26 03:35:30 UTC (rev 166280)
+++ trunk/Source/_javascript_Core/dfg/DFGArgumentsSimplificationPhase.cpp 2014-03-26 04:08:52 UTC (rev 166281)
@@ -397,10 +397,6 @@
VariableAccessData* variableAccessData = node-variableAccessData();
-if (m_graph.argumentsRegisterFor(node-origin.semantic) == variableAccessData-local()
-|| unmodifiedArgumentsRegister(m_graph.argumentsRegisterFor(node-origin.semantic)) == variableAccessData-local())
-break;
-
if (variableAccessData-mergeIsArgumentsAlias(true)) {
changed = true;
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (166280 => 166281)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-26 03:35:30 UTC (rev 166280)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-26 04:08:52 UTC (rev 166281)
@@ -806,7 +806,8 @@
{
VariableAccessData* variable = m_node-variableAccessData();
switch (variable-flushFormat()) {
-case FlushedJSValue: {
+case FlushedJSValue:
+case FlushedArguments: {
LValue value
[webkit-changes] [166282] trunk
Title: [166282] trunk
Revision 166282
Author jer.no...@apple.com
Date 2014-03-25 21:16:53 -0700 (Tue, 25 Mar 2014)
Log Message
[MSE] Duplicate 'seeked' events.
https://bugs.webkit.org/show_bug.cgi?id=130754
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-duplicate-seeked.html
During certain seek operations, HTMLMediaElement::finishSeek() can be called re-entrantly due to
the ready state changing as a result of MediaSource::monitorSourceBuffers(). Move this call to the
end of finishSeek() after m_seeking has been cleared.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
LayoutTests:
* media/media-source/media-source-duplicate-seeked-expected.txt: Added.
* media/media-source/media-source-duplicate-seeked.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/media-source/media-source-duplicate-seeked-expected.txt
trunk/LayoutTests/media/media-source/media-source-duplicate-seeked.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166281 => 166282)
--- trunk/LayoutTests/ChangeLog 2014-03-26 04:08:52 UTC (rev 166281)
+++ trunk/LayoutTests/ChangeLog 2014-03-26 04:16:53 UTC (rev 166282)
@@ -1,3 +1,13 @@
+2014-03-25 Jer Noble jer.no...@apple.com
+
+[MSE] Duplicate 'seeked' events.
+https://bugs.webkit.org/show_bug.cgi?id=130754
+
+Reviewed by Eric Carlson.
+
+* media/media-source/media-source-duplicate-seeked-expected.txt: Added.
+* media/media-source/media-source-duplicate-seeked.html: Added.
+
2014-03-25 James Craig jcr...@apple.com
Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode
Added: trunk/LayoutTests/media/media-source/media-source-duplicate-seeked-expected.txt (0 => 166282)
--- trunk/LayoutTests/media/media-source/media-source-duplicate-seeked-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-duplicate-seeked-expected.txt 2014-03-26 04:16:53 UTC (rev 166282)
@@ -0,0 +1,16 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer(video/mock; codecs=mock))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(samples))
+EVENT(updateend)
+RUN(source.duration = 1)
+RUN(source.endOfStream())
+RUN(video.currentTime = 1)
+EVENT(seeked)
+RUN(video.play())
+EVENT(ended)
+END OF TEST
+
Added: trunk/LayoutTests/media/media-source/media-source-duplicate-seeked.html (0 => 166282)
--- trunk/LayoutTests/media/media-source/media-source-duplicate-seeked.html (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-duplicate-seeked.html 2014-03-26 04:16:53 UTC (rev 166282)
@@ -0,0 +1,62 @@
+!DOCTYPE html
+html
+head
+titlemock-media-source/title
+script src=""
+script src=""
+script
+var source;
+var sourceBuffer;
+var initSegment;
+var samples;
+
+if (window.internals)
+internals.initializeMockMediaSource();
+
+function runTest() {
+findMediaElement();
+
+source = new MediaSource();
+testExpected('source.readyState', 'closed');
+
+waitForEventOn(source, 'sourceopen', sourceOpen);
+var videoSource = document.createElement('source');
+videoSource.type = 'video/mock; codecs=mock';
+videoSource.src = ""
+video.appendChild(videoSource);
+}
+
+function sourceOpen() {
+run('sourceBuffer = source.addSourceBuffer(video/mock; codecs=mock)');
+waitForEventOn(sourceBuffer, 'updateend', loadSamples, false, true);
+initSegment = makeAInit(8, [makeATrack(1, 'mock', TRACK_KIND.VIDEO)]);
+run('sourceBuffer.appendBuffer(initSegment)');
+}
+
+function loadSamples() {
+samples = concatenateSamples([
+makeASample(0, 1, 1, 1, SAMPLE_FLAG.SYNC),
+]);
+waitForEventOn(sourceBuffer, 'updateend', seek, false, true);
+run('sourceBuffer.appendBuffer(samples)');
+}
+
+function seek() {
+run('source.duration = 1');
+run('source.endOfStream()');
+waitForEventOnce('seeked', seeked);
+run('video.currentTime = 1');
+}
+
+function seeked() {
+waitForEventAndFail('seeked');
+waitForEventAndEnd('ended');
+run('video.play()');
+}
+
+/script
+/head
+body _onload_=runTest()
+video/video
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (166281 => 166282)
--- trunk/Source/WebCore/ChangeLog 2014-03-26 04:08:52 UTC (rev 166281)
+++ trunk/Source/WebCore/ChangeLog 2014-03-26 04:16:53 UTC (rev 166282)
@@ -1,3 +1,19 @@
+2014-03-25 Jer Noble jer.no...@apple.com
+
+[MSE] Duplicate 'seeked' events.
+https://bugs.webkit.org/show_bug.cgi?id=130754
+
+Reviewed by Eric Carlson.
+
+
[webkit-changes] [166283] trunk/Source/WebCore
Title: [166283] trunk/Source/WebCore Revision 166283 Author wei...@apple.com Date 2014-03-25 21:22:52 -0700 (Tue, 25 Mar 2014) Log Message Speculative iOS build fix. * editing/cocoa/HTMLConverter.mm: (HTMLConverter::_addAttachmentForElement): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166282 => 166283) --- trunk/Source/WebCore/ChangeLog 2014-03-26 04:16:53 UTC (rev 166282) +++ trunk/Source/WebCore/ChangeLog 2014-03-26 04:22:52 UTC (rev 166283) @@ -1,3 +1,10 @@ +2014-03-25 Sam Weinig s...@webkit.org + +Speculative iOS build fix. + +* editing/cocoa/HTMLConverter.mm: +(HTMLConverter::_addAttachmentForElement): + 2014-03-25 Jer Noble jer.no...@apple.com [MSE] Duplicate 'seeked' events. Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166282 => 166283) --- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-03-26 04:16:53 UTC (rev 166282) +++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-03-26 04:22:52 UTC (rev 166283) @@ -1505,7 +1505,7 @@ #if PLATFORM(IOS) float verticalAlign = 0.0; if (element) -_caches-floatPropertyValueForNode(core(element), CSSPropertyVerticalAlign, verticalAlign) +_caches-floatPropertyValueForNode(*core(element), CSSPropertyVerticalAlign, verticalAlign) attachment.get().bounds = CGRectMake(0, (verticalAlign / 100) * element.clientHeight, element.clientWidth, element.clientHeight); #endif RetainPtrNSString string = adoptNS([[NSString alloc] initWithFormat:(needsParagraph ? @%C\n : @%C), static_castunichar(NSAttachmentCharacter)]); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166284] trunk/Source/WebCore
Title: [166284] trunk/Source/WebCore Revision 166284 Author psola...@apple.com Date 2014-03-25 22:37:00 -0700 (Tue, 25 Mar 2014) Log Message iOS build fix. Add missing semicolon. * editing/cocoa/HTMLConverter.mm: (HTMLConverter::_addAttachmentForElement): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166283 => 166284) --- trunk/Source/WebCore/ChangeLog 2014-03-26 04:22:52 UTC (rev 166283) +++ trunk/Source/WebCore/ChangeLog 2014-03-26 05:37:00 UTC (rev 166284) @@ -1,3 +1,10 @@ +2014-03-25 Pratik Solanki psola...@apple.com + +iOS build fix. Add missing semicolon. + +* editing/cocoa/HTMLConverter.mm: +(HTMLConverter::_addAttachmentForElement): + 2014-03-25 Sam Weinig s...@webkit.org Speculative iOS build fix. Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166283 => 166284) --- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-03-26 04:22:52 UTC (rev 166283) +++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-03-26 05:37:00 UTC (rev 166284) @@ -1505,7 +1505,7 @@ #if PLATFORM(IOS) float verticalAlign = 0.0; if (element) -_caches-floatPropertyValueForNode(*core(element), CSSPropertyVerticalAlign, verticalAlign) +_caches-floatPropertyValueForNode(*core(element), CSSPropertyVerticalAlign, verticalAlign); attachment.get().bounds = CGRectMake(0, (verticalAlign / 100) * element.clientHeight, element.clientWidth, element.clientHeight); #endif RetainPtrNSString string = adoptNS([[NSString alloc] initWithFormat:(needsParagraph ? @%C\n : @%C), static_castunichar(NSAttachmentCharacter)]); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
