[webkit-changes] [189843] trunk/Source/WebCore

2015-09-15 Thread rniwa
Title: [189843] trunk/Source/WebCore








Revision 189843
Author rn...@webkit.org
Date 2015-09-15 20:46:46 -0700 (Tue, 15 Sep 2015)


Log Message
GTK+ build fix attempt after r189841.

* PlatformGTK.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (189842 => 189843)

--- trunk/Source/WebCore/ChangeLog	2015-09-16 03:36:55 UTC (rev 189842)
+++ trunk/Source/WebCore/ChangeLog	2015-09-16 03:46:46 UTC (rev 189843)
@@ -1,3 +1,9 @@
+2015-09-15  Ryosuke Niwa  
+
+GTK+ build fix attempt after r189841.
+
+* PlatformGTK.cmake:
+
 2015-09-15  Chris Dumez  
 
 Document.createElement(localName) does not handle correctly missing or null parameter


Modified: trunk/Source/WebCore/PlatformGTK.cmake (189842 => 189843)

--- trunk/Source/WebCore/PlatformGTK.cmake	2015-09-16 03:36:55 UTC (rev 189842)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2015-09-16 03:46:46 UTC (rev 189843)
@@ -593,7 +593,6 @@
 dom/NodeList.idl
 dom/ProcessingInstruction.idl
 dom/Range.idl
-dom/ShadowRoot.idl
 dom/Text.idl
 dom/TreeWalker.idl
 dom/UIEvent.idl






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189846] trunk/Source/JavaScriptCore

2015-09-15 Thread commit-queue
Title: [189846] trunk/Source/_javascript_Core








Revision 189846
Author commit-qu...@webkit.org
Date 2015-09-15 22:49:11 -0700 (Tue, 15 Sep 2015)


Log Message
Implement imported global variables in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149206

Patch by Sukolsak Sakshuwong  on 2015-09-15
Reviewed by Filip Pizlo.

Values can now be imported to a WebAssembly module through properties of
the imports object that is passed to loadWebAssembly(). In order to
avoid any side effect when accessing the imports object, we check that
the properties are data properties. We also check that each value is a
primitive and is not a Symbol. According to the ECMA262 6.0 spec,
calling ToNumber() on a primitive that is not a Symbol should not cause
any side effect.[1]

[1]: http://www.ecma-international.org/ecma-262/6.0/#sec-tonumber

* tests/stress/wasm-globals.js:
* tests/stress/wasm/globals.wasm:
* wasm/WASMModuleParser.cpp:
(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseGlobalSection):
* wasm/WASMModuleParser.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tests/stress/wasm/globals.wasm
trunk/Source/_javascript_Core/tests/stress/wasm-globals.js
trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp
trunk/Source/_javascript_Core/wasm/WASMModuleParser.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189845 => 189846)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-16 04:22:21 UTC (rev 189845)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-16 05:49:11 UTC (rev 189846)
@@ -1,5 +1,29 @@
 2015-09-15  Sukolsak Sakshuwong  
 
+Implement imported global variables in WebAssembly
+https://bugs.webkit.org/show_bug.cgi?id=149206
+
+Reviewed by Filip Pizlo.
+
+Values can now be imported to a WebAssembly module through properties of
+the imports object that is passed to loadWebAssembly(). In order to
+avoid any side effect when accessing the imports object, we check that
+the properties are data properties. We also check that each value is a
+primitive and is not a Symbol. According to the ECMA262 6.0 spec,
+calling ToNumber() on a primitive that is not a Symbol should not cause
+any side effect.[1]
+
+[1]: http://www.ecma-international.org/ecma-262/6.0/#sec-tonumber
+
+* tests/stress/wasm-globals.js:
+* tests/stress/wasm/globals.wasm:
+* wasm/WASMModuleParser.cpp:
+(JSC::WASMModuleParser::parseModule):
+(JSC::WASMModuleParser::parseGlobalSection):
+* wasm/WASMModuleParser.h:
+
+2015-09-15  Sukolsak Sakshuwong  
+
 Fix asm.js errors in WebAssembly tests
 https://bugs.webkit.org/show_bug.cgi?id=149203
 


Modified: trunk/Source/_javascript_Core/tests/stress/wasm/globals.wasm (189845 => 189846)

--- trunk/Source/_javascript_Core/tests/stress/wasm/globals.wasm	2015-09-16 04:22:21 UTC (rev 189845)
+++ trunk/Source/_javascript_Core/tests/stress/wasm/globals.wasm	2015-09-16 05:49:11 UTC (rev 189846)
@@ -1 +1 @@
-wasm\xD2\x80\x80\x80\x80\xA0\xC0\x80\xA1\xA0\x80\xA2\xA0getXgetYgetZsetXsetYsetZ
\ No newline at end of file
+wasmmabc	\x80\x80\x80\x80\x80\x80\x80\xA0\xC0\x80\xA1\xA0\x80\xA2\xA0	getAgetBgetCgetXgetYgetZsetXsetYsetZ
\ No newline at end of file


Modified: trunk/Source/_javascript_Core/tests/stress/wasm-globals.js (189845 => 189846)

--- trunk/Source/_javascript_Core/tests/stress/wasm-globals.js	2015-09-16 04:22:21 UTC (rev 189845)
+++ trunk/Source/_javascript_Core/tests/stress/wasm-globals.js	2015-09-16 05:49:11 UTC (rev 189846)
@@ -8,14 +8,29 @@
 /*
 wasm/globals.wasm is generated by pack-asmjs  from the following script:
 
-function asmModule(global, env, buffer) {
+function asmModule(global, imports, buffer) {
 "use asm";
 
 var fround = global.Math.fround;
+var a = imports.a | 0;
+var b = fround(imports.b);
+var c = +imports.c;
 var x = 0;
 var y = fround(0);
 var z = 0.0;
 
+function getA() {
+return a | 0;
+}
+
+function getB() {
+return b;
+}
+
+function getC() {
+return c;
+}
+
 function getX() {
 return x | 0;
 }
@@ -44,6 +59,9 @@
 }
 
 return {
+getA: getA,
+getB: getB,
+getC: getC,
 getX: getX,
 getY: getY,
 getZ: getZ,
@@ -54,8 +72,17 @@
 }
 */
 
-var module = loadWebAssembly("wasm/globals.wasm");
+var imports = {
+a: 42,
+b: 4.2,
+c: 4.2,
+};
+var module = loadWebAssembly("wasm/globals.wasm", imports);
 
+shouldBe(module.getA(), 42);
+shouldBe(module.getB(), 4.19809265137);
+shouldBe(module.getC(), 4.2);
+
 shouldBe(module.getX(), 0);
 shouldBe(module.getY(), 0);
 shouldBe(module.getZ(), 0);


Modified: 

[webkit-changes] [189828] trunk/Source/WebInspectorUI

2015-09-15 Thread bburg
Title: [189828] trunk/Source/WebInspectorUI








Revision 189828
Author bb...@apple.com
Date 2015-09-15 16:44:30 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: command-click in NewTabContentView should open new tab without switching to it
https://bugs.webkit.org/show_bug.cgi?id=149173

Reviewed by Joseph Pecoraro.

To allow a user to quickly restore tabs, it should be possible to command-click
all the tabs that are desired without going back through the [+] tab button.

* UserInterface/Base/Main.js:
(WebInspector.createNewTabWithType): Renamed.

Use an options object and split creating the tab from deleting the
replaced tab and showing the new tab. Add better error checking.

(WebInspector.createNewTab): Deleted.
* UserInterface/Views/NewTabContentView.js:
(WebInspector.NewTabContentView):
(WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.

If the meta key is pressed, don't switch to the new tab or remove this view
unless there are no more tabs that can be created beyond the current one.

(WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
(WebInspector.NewTabContentView.prototype._createNewTab): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (189827 => 189828)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 22:10:54 UTC (rev 189827)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 23:44:30 UTC (rev 189828)
@@ -1,3 +1,30 @@
+2015-09-15  Brian Burg  
+
+Web Inspector: command-click in NewTabContentView should open new tab without switching to it
+https://bugs.webkit.org/show_bug.cgi?id=149173
+
+Reviewed by Joseph Pecoraro.
+
+To allow a user to quickly restore tabs, it should be possible to command-click
+all the tabs that are desired without going back through the [+] tab button.
+
+* UserInterface/Base/Main.js:
+(WebInspector.createNewTabWithType): Renamed.
+
+Use an options object and split creating the tab from deleting the
+replaced tab and showing the new tab. Add better error checking.
+
+(WebInspector.createNewTab): Deleted.
+* UserInterface/Views/NewTabContentView.js:
+(WebInspector.NewTabContentView):
+(WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.
+
+If the meta key is pressed, don't switch to the new tab or remove this view
+unless there are no more tabs that can be created beyond the current one.
+
+(WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
+(WebInspector.NewTabContentView.prototype._createNewTab): Deleted.
+
 2015-09-15  Joseph Pecoraro  
 
 Web Inspector: Watch Expressions uncaught exceptions on page reload


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (189827 => 189828)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-09-15 22:10:54 UTC (rev 189827)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-09-15 23:44:30 UTC (rev 189828)
@@ -507,20 +507,24 @@
 return true;
 };
 
-WebInspector.createNewTab = function(tabType, newTabContentViewToReplace)
+WebInspector.createNewTabWithType = function(tabType, options = {})
 {
 console.assert(this.isNewTabWithTypeAllowed(tabType));
 
-var tabContentView = this._tabContentViewForType(tabType);
+let {referencedView, shouldReplaceTab, shouldShowNewTab} = options;
+console.assert(!referencedView || referencedView instanceof WebInspector.TabContentView, referencedView);
+console.assert(!shouldReplaceTab || referencedView, "Must provide a reference view to replace a tab.");
 
-if (newTabContentViewToReplace) {
-var insertionIndex = this.tabBar.tabBarItems.indexOf(newTabContentViewToReplace.tabBarItem);
-this.tabBrowser.closeTabForContentView(newTabContentViewToReplace, true);
-this.tabBrowser.showTabForContentView(tabContentView, true, insertionIndex);
-return;
-}
+let tabContentView = this._tabContentViewForType(tabType);
+const suppressAnimations = true;
+let insertionIndex = referencedView ? this.tabBar.tabBarItems.indexOf(referencedView.tabBarItem) : undefined;
+this.tabBrowser.addTabForContentView(tabContentView, suppressAnimations, insertionIndex);
 
-this.tabBrowser.showTabForContentView(tabContentView);
+if (shouldReplaceTab)
+this.tabBrowser.closeTabForContentView(referencedView, suppressAnimations);
+
+if (shouldShowNewTab)
+this.tabBrowser.showTabForContentView(tabContentView);
 };
 
 WebInspector.activateExtraDomains = function(domains)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js (189827 => 189828)

--- 

[webkit-changes] [189844] trunk/Source/JavaScriptCore

2015-09-15 Thread commit-queue
Title: [189844] trunk/Source/_javascript_Core








Revision 189844
Author commit-qu...@webkit.org
Date 2015-09-15 20:52:20 -0700 (Tue, 15 Sep 2015)


Log Message
Fix asm.js errors in WebAssembly tests
https://bugs.webkit.org/show_bug.cgi?id=149203

Patch by Sukolsak Sakshuwong  on 2015-09-15
Reviewed by Geoffrey Garen.

Our WebAssembly implementation uses asm.js for testing. Using Firefox to
parse asm.js reveals many errors that are not caught by pack-asmjs. For
example,
- asm.js does not allow the use of the multiplication operator (*) to
  multiply two integers, because the result can be so large that some
  lower bits of precision are lost. Math.imul is used instead.
- an int variable must be coerced to either signed (via x|0) or unsigned
  (via x>>>0) before it's returned.

* tests/stress/wasm-arithmetic-int32.js:
* tests/stress/wasm-calls.js:
* tests/stress/wasm-control-flow.js:
* tests/stress/wasm-globals.js:
* tests/stress/wasm-locals.js:
* tests/stress/wasm-relational.js:
* tests/stress/wasm/control-flow.wasm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tests/stress/wasm/control-flow.wasm
trunk/Source/_javascript_Core/tests/stress/wasm-arithmetic-int32.js
trunk/Source/_javascript_Core/tests/stress/wasm-calls.js
trunk/Source/_javascript_Core/tests/stress/wasm-control-flow.js
trunk/Source/_javascript_Core/tests/stress/wasm-globals.js
trunk/Source/_javascript_Core/tests/stress/wasm-locals.js
trunk/Source/_javascript_Core/tests/stress/wasm-relational.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189843 => 189844)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-16 03:46:46 UTC (rev 189843)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-16 03:52:20 UTC (rev 189844)
@@ -1,3 +1,27 @@
+2015-09-15  Sukolsak Sakshuwong  
+
+Fix asm.js errors in WebAssembly tests
+https://bugs.webkit.org/show_bug.cgi?id=149203
+
+Reviewed by Geoffrey Garen.
+
+Our WebAssembly implementation uses asm.js for testing. Using Firefox to
+parse asm.js reveals many errors that are not caught by pack-asmjs. For
+example,
+- asm.js does not allow the use of the multiplication operator (*) to
+  multiply two integers, because the result can be so large that some
+  lower bits of precision are lost. Math.imul is used instead.
+- an int variable must be coerced to either signed (via x|0) or unsigned
+  (via x>>>0) before it's returned.
+
+* tests/stress/wasm-arithmetic-int32.js:
+* tests/stress/wasm-calls.js:
+* tests/stress/wasm-control-flow.js:
+* tests/stress/wasm-globals.js:
+* tests/stress/wasm-locals.js:
+* tests/stress/wasm-relational.js:
+* tests/stress/wasm/control-flow.wasm:
+
 2015-09-15  Ryosuke Niwa  
 
 Add ShadowRoot interface and Element.prototype.attachShadow


Modified: trunk/Source/_javascript_Core/tests/stress/wasm/control-flow.wasm (189843 => 189844)

--- trunk/Source/_javascript_Core/tests/stress/wasm/control-flow.wasm	2015-09-16 03:46:46 UTC (rev 189843)
+++ trunk/Source/_javascript_Core/tests/stress/wasm/control-flow.wasm	2015-09-16 03:52:20 UTC (rev 189844)
@@ -1,3 +1,3 @@
-wasm6\x81\x80\xA5<\xC0\xA0\xA1\xA0\x81<\xC0\xA0\xA1\xA0\x81\x80\xA5<\xC0\xA0\xA1\xA2\x81<\xC0\xA0\xA1\xA2\x82\x80\xA1.\xC0\xA0.\xC1\xA0\xA1\xA2.\xC1\xA0\xA3\xA4\x824\xC1\xA5\x80\xC0\xA1\x81\xC1\xA1\xC0\x82\xA1.\xC1\xA2\x80\xC0\xA1\x81\xC1\xA1\xC0\x824\xC1\xA5.\xC1\xA2\x81\xA3\x80\xC0\xA1\x81\xC1\xA1\xC0\x834\xC1\xA5\x82\xA04¢\x80\xC0\xA1\x82¡\x81\xC1\xA1\xC0\x82\x80\xC0\xA1\x81\xC1\xA14\xC1\xA0\xC0\x82.\xC1\xA2\x80\xC0\xA1\x81\xC1\xA1\xA1\xC0\x82.\xC1\xA2\x81\xA3\x80\xC0\xA1\x81\xC1\xA14\xC1\xA5\xC0\x81\x80\xA1\x80\xA2\xA0\xC0\x81.\xC0\xA1\x80\xA1\x80\xA2\xA0\xC0\x81\x80\xA1\x80\xA2\x80\xA3\xA0\x80\xA4\xA0\xC0\x81\x80\xA1\x80\xA2\x80\xA3\xA0\x80\xA4\xA0\xC0\x834\xC1\xA5\x82\xA04¢\x80\xC0\xA1.\xC0\xA8\x82¡\x81\xC1\xA1\xC0\x81\xC0\x81\xA1\x81\xA2\
 x81\xA3\xC1\x81\xC0\x81\xC1\xE8\x81\xC1d\x81\xC1\xAA\x81\xC1\xA1\xC1ifTrueifFalseifElseTrueifElseFalseifInIfwhileLoopwhileBreakwhileContinuewhileInWhiledoLoop	doBreak
+wasmT\x81\x80\xA5<\xC0\xA0\xA1\xA0\x81<\xC0\xA0\xA1\xA0\x81\x80\xA5<\xC0\xA0\xA1\xA2\xA0\x81<\xC0\xA0\xA1\xA2\xA0\x82\x80\xA1.\xC0\xA0.\xC1\xA0\xA1\xA2.\xC1\xA0\xA3\xA4\xA0\x824\xC1\xA5\x80\xC0\xA1\x81\xC1\xA1\xC0\x82\xA1.\xC1\xA2\x80\xC0\xA1\x81\xC1\xA1\xC0\x824\xC1\xA5.\xC1\xA2\x81\xA3\x80\xC0\xA1\x81\xC1\xA1\xC0\x834\xC1\xA5\x82\xA04¢\x80\xC0\xA1\x82¡\x81\xC1\xA1\xC0\x82\x80\xC0\xA1\x81\xC1\xA14\xC1\xA0\xC0\x82.\xC1\xA2\x80\xC0\xA1\x81

[webkit-changes] [189845] trunk/Source/WebInspectorUI

2015-09-15 Thread commit-queue
Title: [189845] trunk/Source/WebInspectorUI








Revision 189845
Author commit-qu...@webkit.org
Date 2015-09-15 21:22:21 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
https://bugs.webkit.org/show_bug.cgi?id=148351

Patch by Devin Rousso  on 2015-09-15
Reviewed by Brian Burg.

Visual number editors now save any new values in the special placeholder element
to display it whenever the "Unchanged" option is selected by the user.

* UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set value):
(WebInspector.VisualStyleNumberInputBox.prototype.set units):
(WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
(WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (189844 => 189845)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-09-16 03:52:20 UTC (rev 189844)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-09-16 04:22:21 UTC (rev 189845)
@@ -1,3 +1,21 @@
+2015-09-15  Devin Rousso  
+
+Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
+https://bugs.webkit.org/show_bug.cgi?id=148351
+
+Reviewed by Brian Burg.
+
+Visual number editors now save any new values in the special placeholder element
+to display it whenever the "Unchanged" option is selected by the user.
+
+* UserInterface/Views/VisualStyleNumberInputBox.js:
+(WebInspector.VisualStyleNumberInputBox.prototype.set value):
+(WebInspector.VisualStyleNumberInputBox.prototype.set units):
+(WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
+(WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
+(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
+(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
+
 2015-09-15  Brian Burg  
 
 Web Inspector: command-click in NewTabContentView should open new tab without switching to it


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js (189844 => 189845)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js	2015-09-16 03:52:20 UTC (rev 189844)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js	2015-09-16 04:22:21 UTC (rev 189845)
@@ -111,12 +111,16 @@
 if (value && value === this.value)
 return;
 
-if (this._updatedValues.propertyMissing && isNaN(value)) {
-this._unchangedOptionElement.selected = true;
-this._numberInputIsEditable = false;
-this.contentElement.classList.remove("number-input-editable");
-this.specialPropertyPlaceholderElement.hidden = false;
-return;
+if (this._updatedValues.propertyMissing) {
+if (value || this._updatedValues.placeholder)
+this.specialPropertyPlaceholderElement.textContent = (value || this._updatedValues.placeholder) + (this._updatedValues.units || "");
+
+if (isNaN(value)) {
+this._unchangedOptionElement.selected = true;
+this._setNumberInputIsEditable();
+this.specialPropertyPlaceholderElement.hidden = false;
+return;
+}
 }
 
 this.specialPropertyPlaceholderElement.hidden = true;
@@ -128,16 +132,14 @@
 }
 
 if (!isNaN(value)) {
-this._numberInputIsEditable = true;
-this.contentElement.classList.add("number-input-editable");
+this._setNumberInputIsEditable(true);
 this._valueNumberInputElement.value = Math.round(value * 100) / 100;
 this._markUnitsContainerIfInputHasValue();
 return;
 }
 
 if (this.valueIsSupportedKeyword(value)) {
-this._numberInputIsEditable = false;
-this.contentElement.classList.remove("number-input-editable");
+this._setNumberInputIsEditable();
 this._keywordSelectElement.value = value;
 return;
 }
@@ -169,8 +171,7 @@
 if (this._valueIsSupportedAdvancedUnit(unit))
 this._addAdvancedUnits();
 
-this._numberInputIsEditable = true;
-this.contentElement.classList.add("number-input-editable");
+this._setNumberInputIsEditable(true);
 this._keywordSelectElement.value = unit;
 

[webkit-changes] [189835] trunk/Websites/webkit.org

2015-09-15 Thread wenson_hsieh
Title: [189835] trunk/Websites/webkit.org








Revision 189835
Author wenson_hs...@apple.com
Date 2015-09-15 18:14:29 -0700 (Tue, 15 Sep 2015)


Log Message
Add anchor tags for scroll snapping examples.

* demos/scroll-snap/index.html: Added anchor tags.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/demos/scroll-snap/index.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (189834 => 189835)

--- trunk/Websites/webkit.org/ChangeLog	2015-09-16 01:03:35 UTC (rev 189834)
+++ trunk/Websites/webkit.org/ChangeLog	2015-09-16 01:14:29 UTC (rev 189835)
@@ -1,3 +1,9 @@
+2015-09-15  Wenson Hsieh  
+
+Add anchor tags for scroll snapping examples.
+
+* demos/scroll-snap/index.html: Added anchor tags.
+
 2015-09-14  Wenson Hsieh  
 
 Add scroll snap blog post resources.


Modified: trunk/Websites/webkit.org/demos/scroll-snap/index.html (189834 => 189835)

--- trunk/Websites/webkit.org/demos/scroll-snap/index.html	2015-09-16 01:03:35 UTC (rev 189834)
+++ trunk/Websites/webkit.org/demos/scroll-snap/index.html	2015-09-16 01:14:29 UTC (rev 189835)
@@ -216,6 +216,7 @@
 The scroll-snap-* Properties.
 The following examples are overflow-scrolling divs. In the second, third and fourth examples, the blue cross represents the location of each containers scroll snap destination.
 
+
 This first container does not have any scroll snapping behavior.
 
 
@@ -249,6 +250,7 @@
 
 
 
+
 This second container shows what basic scroll snapping can do for us.
 
 
@@ -285,6 +287,7 @@
 -webkit-scroll-snap-type: mandatory;-webkit-scroll-snap-points-x: repeat(100%);
 
 
+
 This next container snaps to elements of different sizes when scrolling.
 
 
@@ -344,6 +347,7 @@
 -webkit-scroll-snap-coordinate: 0% 0%;
 
 
+
 Here, we snap elements of different sizes to the center of the container.
 
 
@@ -403,6 +407,7 @@
 -webkit-scroll-snap-coordinate: 50% 50%;
 
 
+
 This container shows centered scroll snapping in a 2D grid.
 
 @@ -416,6 +421,7 @@
 -webkit-scroll-snap-coordinate: 50% 50%;
 
 
+
 This example takes the 2D scroll snapping grid above and rotates it by 30 degrees.
 
 





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189838] trunk/LayoutTests

2015-09-15 Thread commit-queue
Title: [189838] trunk/LayoutTests








Revision 189838
Author commit-qu...@webkit.org
Date 2015-09-15 18:54:47 -0700 (Tue, 15 Sep 2015)


Log Message
[WebGL] Only require that the stencil value and write masks have as many bits set as the stencil buffer is deep
https://bugs.webkit.org/show_bug.cgi?id=149174

Patch by Jinyoung Hur  on 2015-09-15
Reviewed by Dean Jackson.

Copied the stencil mask related tests from the webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html.

It seems that there is a difference in the way that glGetIntegerV returns an unsigned int type value among
OpenGL implementatios. Some return the whole bits of value(e.g., 0x -> 0x), whereas some(e.g., ANGLE)
return a max-int-clamped value(e.g., 0x -> 0x7fff).

It would be good to make this test independent on the OpenGL implementations.

* fast/canvas/webgl/gl-get-calls-expected.txt:
* fast/canvas/webgl/gl-get-calls.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt
trunk/LayoutTests/fast/canvas/webgl/gl-get-calls.html




Diff

Modified: trunk/LayoutTests/ChangeLog (189837 => 189838)

--- trunk/LayoutTests/ChangeLog	2015-09-16 01:34:05 UTC (rev 189837)
+++ trunk/LayoutTests/ChangeLog	2015-09-16 01:54:47 UTC (rev 189838)
@@ -1,3 +1,21 @@
+2015-09-15  Jinyoung Hur  
+
+[WebGL] Only require that the stencil value and write masks have as many bits set as the stencil buffer is deep
+https://bugs.webkit.org/show_bug.cgi?id=149174
+
+Reviewed by Dean Jackson.
+
+Copied the stencil mask related tests from the webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html.
+
+It seems that there is a difference in the way that glGetIntegerV returns an unsigned int type value among 
+OpenGL implementatios. Some return the whole bits of value(e.g., 0x -> 0x), whereas some(e.g., ANGLE) 
+return a max-int-clamped value(e.g., 0x -> 0x7fff).
+
+It would be good to make this test independent on the OpenGL implementations.
+
+* fast/canvas/webgl/gl-get-calls-expected.txt:
+* fast/canvas/webgl/gl-get-calls.html:
+
 2015-09-15  Gyuyoung Kim  
 
 [EFL] Unreviewed gardening 16th Sep.


Modified: trunk/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt (189837 => 189838)

--- trunk/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt	2015-09-16 01:34:05 UTC (rev 189837)
+++ trunk/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt	2015-09-16 01:54:47 UTC (rev 189838)
@@ -54,8 +54,8 @@
 PASS context.getParameter(context.STENCIL_BACK_PASS_DEPTH_FAIL) is context.KEEP
 PASS context.getParameter(context.STENCIL_BACK_PASS_DEPTH_PASS) is context.KEEP
 PASS context.getParameter(context.STENCIL_BACK_REF) is 0
-PASS context.getParameter(context.STENCIL_BACK_VALUE_MASK) is 0x
-PASS context.getParameter(context.STENCIL_BACK_WRITEMASK) is 0x
+PASS context.getParameter(context.STENCIL_BACK_VALUE_MASK) & minimumRequiredStencilMask is minimumRequiredStencilMask
+PASS context.getParameter(context.STENCIL_BACK_WRITEMASK) & minimumRequiredStencilMask is minimumRequiredStencilMask
 PASS context.getParameter(context.STENCIL_BITS) >= 0 is true
 PASS context.getParameter(context.STENCIL_CLEAR_VALUE) is 0
 PASS context.getParameter(context.STENCIL_FAIL) is context.KEEP
@@ -64,8 +64,8 @@
 PASS context.getParameter(context.STENCIL_PASS_DEPTH_PASS) is context.KEEP
 PASS context.getParameter(context.STENCIL_REF) is 0
 PASS context.getParameter(context.STENCIL_TEST) is false
-PASS context.getParameter(context.STENCIL_VALUE_MASK) is 0x
-PASS context.getParameter(context.STENCIL_WRITEMASK) is 0x
+PASS context.getParameter(context.STENCIL_VALUE_MASK) & minimumRequiredStencilMask is minimumRequiredStencilMask
+PASS context.getParameter(context.STENCIL_WRITEMASK) & minimumRequiredStencilMask is minimumRequiredStencilMask
 PASS context.getParameter(context.TEXTURE_BINDING_2D) is null
 PASS context.getParameter(context.TEXTURE_BINDING_CUBE_MAP) is null
 PASS context.getParameter(context.UNPACK_ALIGNMENT) is 4


Modified: trunk/LayoutTests/fast/canvas/webgl/gl-get-calls.html (189837 => 189838)

--- trunk/LayoutTests/fast/canvas/webgl/gl-get-calls.html	2015-09-16 01:34:05 UTC (rev 189837)
+++ trunk/LayoutTests/fast/canvas/webgl/gl-get-calls.html	2015-09-16 01:54:47 UTC (rev 189838)
@@ -17,6 +17,7 @@
 debug("");
 debug("Canvas.getContext");
 
+var minimumRequiredStencilMask = 0;
 var context = create3DContext(document.getElementById("canvas"));
 if (!context)
 testFailed("context does not exist");
@@ -81,9 +82,12 @@
 shouldBe('context.getParameter(context.STENCIL_BACK_PASS_DEPTH_PASS)', 'context.KEEP');
 shouldBe('context.getParameter(context.STENCIL_BACK_REF)', '0');
 
-

[webkit-changes] [189841] trunk

2015-09-15 Thread rniwa
Title: [189841] trunk








Revision 189841
Author rn...@webkit.org
Date 2015-09-15 19:40:53 -0700 (Tue, 15 Sep 2015)


Log Message
Add ShadowRoot interface and Element.prototype.attachShadow
https://bugs.webkit.org/show_bug.cgi?id=149187

Reviewed by Antti Koivisto.

.:

* Source/cmake/OptionsGTK.cmake:

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add back ShadowRoot IDL interface and Element.prototype.attachShadow in accordance with
http://w3c.github.io/webcomponents/spec/shadow/ at db27e6e36eab512d86edcdabb33ed27b5751acd7 excluding getSelection(),
elementFromPoint(), elementsFromPoint(), caretPositionFromPoint(), and styleSheets attribute on ShadowRoot interface.

The feature is enabled by default on Mac and iOS ports for testing and disabled by default elsewhere.

Also added HTMLElement::canHaveUserAgentShadowRoot which returns false by default and overridden elsewhere to return true
to distinguish elements for which attachShadow is supposed to throw NotSupported.
See https://w3c.github.io/webcomponents/spec/shadow/#widl-Element-attachShadow-ShadowRoot-ShadowRootInit-shadowRootInitDict

Tests: fast/shadow-dom/Element-interface-attachShadow.html
   fast/shadow-dom/Element-interface-shadowRoot-attribute.html
   fast/shadow-dom/ShadowRoot-interface.html

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
* dom/Element.cpp:
(WebCore::Element::bindingsOffsetParent):
(WebCore::Element::offsetParent):
(WebCore::Element::addShadowRoot):
(WebCore::Element::createShadowRoot):
(WebCore::Element::attachShadow): Added.
(WebCore::Element::bindingShadowRoot): Added. Returns null unless the attached shadow root is in the "open" mode.
* dom/Element.h:
* dom/Element.idl: Added attachShadow and shadowRoot. We only expose these to JS for now since Dictionary argument isn't
supported by other binding code.
* dom/ShadowRoot.cpp: Removed an unused enum.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::Type): Replaced old-style enum "ShadowRootType" by an enum class named "Type". Also added two new
values Open and Closed for author shadow roots.
(WebCore::ShadowRoot::type):
* dom/ShadowRoot.idl: Added.
* html/HTMLButtonElement.h:
* html/HTMLDetailsElement.h:
(HTMLButtonElement::canHaveUserAgentShadowRoot): Ditto.
* html/HTMLElement.h:
(WebCore::HTMLElement::canHaveUserAgentShadowRoot): Added. Returns false by default.
* html/HTMLInputElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLMarqueeElement.h:
* html/HTMLMediaElement.h:
* html/HTMLMeterElement.h:
* html/HTMLPlugInElement.h:
* html/HTMLProgressElement.h:
* html/HTMLSelectElement.h:
* html/HTMLSummaryElement.h:
* html/HTMLTextAreaElement.h:
* html/shadow/InsertionPoint.h:
(ShadowRootWithInsertionPoints::ShadowRootWithInsertionPoints):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionPseudoStyle):
* rendering/RenderLayer.cpp:
(WebCore::rendererForScrollbar):
* svg/SVGElement.cpp:
(WebCore::SVGElement::correspondingUseElement):
* testing/Internals.cpp:
(WebCore::Internals::shadowRootType):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Add new tests for Shadow DOM with failing expectations on all platforms but Mac.

* TestExpectations:
* fast/shadow-dom: Added.
* fast/shadow-dom/Element-interface-attachShadow-expected.txt: Added.
* fast/shadow-dom/Element-interface-attachShadow.html: Added.
* fast/shadow-dom/Element-interface-shadowRoot-attribute-expected.txt: Added.
* fast/shadow-dom/Element-interface-shadowRoot-attribute.html: Added.
* fast/shadow-dom/ShadowRoot-interface-expected.txt: Added.
* fast/shadow-dom/ShadowRoot-interface.html: Added.
* js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/js/dom/constructor-length-expected.txt:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac/js/dom/constructor-length-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/DerivedSources.cpp

[webkit-changes] [189842] trunk

2015-09-15 Thread cdumez
Title: [189842] trunk








Revision 189842
Author cdu...@apple.com
Date 2015-09-15 20:36:55 -0700 (Tue, 15 Sep 2015)


Log Message
Document.createElement(localName) does not handle correctly missing or null parameter
https://bugs.webkit.org/show_bug.cgi?id=149184


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Document-createElement-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Document.createElement(localName) does not handle correct missing or
null parameter:
- https://dom.spec.whatwg.org/#interface-document

As per the specification, the parameter is a non-nullable DOMString and
is mandatory. Therefore, as per Web IDL, we should have the following
behavior:
1. If the parameter is missing, we should throw an exception
2. If the parameter is null, we should convert it to the "null" string
   and create a  element.

Chrome and Firefox behave according to the specification. However,
WebKit was doing:
1. Create a  element
2. Throw an InvalidCharacterError

This patch aligns WebKit's behavior with the specification and other
major browsers.

No new tests, already covered by existing tests.

* dom/Document.idl:

LayoutTests:

Update / rebaseline existing tests now that our behavior has changed.

* fast/dom/Document/createElementNS-namespace-err-expected.txt:
* fast/dom/Document/script-tests/createElementNS-namespace-err.js:
* fast/dom/dom-method-document-change.html:
* fast/dom/element-removed-while-inserting-parent-crash.html:
* fast/inspector-support/uncaught-dom3-exception-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt
trunk/LayoutTests/fast/dom/Document/script-tests/createElementNS-namespace-err.js
trunk/LayoutTests/fast/dom/dom-method-document-change.html
trunk/LayoutTests/fast/dom/element-removed-while-inserting-parent-crash.html
trunk/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html
trunk/LayoutTests/fast/inspector-support/uncaught-dom3-exception.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/svg/dom/vkern-element-crash.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (189841 => 189842)

--- trunk/LayoutTests/ChangeLog	2015-09-16 02:40:53 UTC (rev 189841)
+++ trunk/LayoutTests/ChangeLog	2015-09-16 03:36:55 UTC (rev 189842)
@@ -1,3 +1,19 @@
+2015-09-15  Chris Dumez  
+
+Document.createElement(localName) does not handle correctly missing or null parameter
+https://bugs.webkit.org/show_bug.cgi?id=149184
+
+
+Reviewed by Ryosuke Niwa.
+
+Update / rebaseline existing tests now that our behavior has changed.
+
+* fast/dom/Document/createElementNS-namespace-err-expected.txt:
+* fast/dom/Document/script-tests/createElementNS-namespace-err.js:
+* fast/dom/dom-method-document-change.html:
+* fast/dom/element-removed-while-inserting-parent-crash.html:
+* fast/inspector-support/uncaught-dom3-exception-expected.txt:
+
 2015-09-15  Ryosuke Niwa  
 
 Add ShadowRoot interface and Element.prototype.attachShadow


Modified: trunk/LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt (189841 => 189842)

--- trunk/LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt	2015-09-16 02:40:53 UTC (rev 189841)
+++ trunk/LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt	2015-09-16 03:36:55 UTC (rev 189842)
@@ -47,7 +47,7 @@
 PASS createElementNS("http://www.w3.org/XML/1998/namespace", "xml:test")
 PASS createElementNS("http://www.w3.org/XML/1998/namespace", "x:test")
 PASS createElement()
-PASS createElement(null); threw INVALID_CHARACTER_ERR
+PASS createElement(null)
 PASS createElement(""); threw INVALID_CHARACTER_ERR
 PASS createElement(""); threw INVALID_CHARACTER_ERR
 PASS createElement("0div"); threw INVALID_CHARACTER_ERR
@@ -76,7 +76,7 @@
 PASS createElement("SOAP-ENV:Body")
 XHTML createElement tests:
 PASS createElement()
-PASS createElement(null); threw INVALID_CHARACTER_ERR
+PASS createElement(null)
 PASS createElement(""); threw INVALID_CHARACTER_ERR
 PASS createElement(""); threw INVALID_CHARACTER_ERR
 PASS createElement("0div"); threw INVALID_CHARACTER_ERR
@@ -105,7 +105,7 @@
 PASS createElement("SOAP-ENV:Body")
 XML createElement tests:
 PASS createElement()
-PASS createElement(null); threw INVALID_CHARACTER_ERR
+PASS createElement(null)
 PASS createElement(""); threw INVALID_CHARACTER_ERR
 

[webkit-changes] [189829] trunk/Source/WebCore

2015-09-15 Thread mmaxfield
Title: [189829] trunk/Source/WebCore








Revision 189829
Author mmaxfi...@apple.com
Date 2015-09-15 17:05:58 -0700 (Tue, 15 Sep 2015)


Log Message
GraphicsContext::drawBidiText()'s BidiResolver should not have isolated runs
https://bugs.webkit.org/show_bug.cgi?id=149193

Reviewed by Anders Carlsson.

There are two users of BidiResolver, one which needs isolated runs (in RenderBlockLineLayout) and
one which doesn't (in GraphicsContext::drawBidiText()). Because of [1], the isolated runs vector
is migrating to a new type outside of platform/. Therefore, only the first user of BidiResolver
should have this member variable.

This is achieved by creating two subclasses of BidiResolver, and using the Curiously Repeating
Template pattern to downcast into specializations.

[1] https://bugs.webkit.org/show_bug.cgi?id=149153

No new tests because there is no behavior change.

* platform/text/BidiResolver.h:
(WebCore::BidiResolverBase::BidiResolverBase):
(WebCore::BidiResolverBase::increment):
(WebCore::BidiResolverBase::appendRun):
(WebCore::BidiResolverBase::incrementInternal):
(WebCore::IsolateRun>::~BidiResolverWithIsolate):
(WebCore::Subclass>::appendRunInternal):
(WebCore::Subclass>::embed):
(WebCore::Subclass>::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::Subclass>::lowerExplicitEmbeddingLevel):
(WebCore::Subclass>::raiseExplicitEmbeddingLevel):
(WebCore::Subclass>::commitExplicitEmbedding):
(WebCore::Subclass>::updateStatusLastFromCurrentDirection):
(WebCore::Subclass>::reorderRunsFromLevels):
(WebCore::Subclass>::createBidiRunsForLine):
(WebCore::Subclass>::setMidpointForIsolatedRun):
(WebCore::Subclass>::midpointForIsolatedRun):
(WebCore::BidiResolver::BidiResolver): Deleted.
(WebCore::BidiResolver::increment): Deleted.
(WebCore::BidiResolver::isolatedRuns): Deleted.
(WebCore::Run>::~BidiResolver): Deleted.
(WebCore::Run>::appendRun): Deleted.
(WebCore::Run>::embed): Deleted.
(WebCore::Run>::checkDirectionInLowerRaiseEmbeddingLevel): Deleted.
(WebCore::Run>::lowerExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::raiseExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::commitExplicitEmbedding): Deleted.
(WebCore::Run>::updateStatusLastFromCurrentDirection): Deleted.
(WebCore::Run>::reorderRunsFromLevels): Deleted.
(WebCore::Run>::createBidiRunsForLine): Deleted.
(WebCore::Run>::setMidpointForIsolatedRun): Deleted.
(WebCore::Run>::midpointForIsolatedRun): Deleted.
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::incrementInternal):
(WebCore::InlineBidiResolver::appendRunInternal):
(WebCore::InlineBidiResolver::increment): Deleted.
(WebCore::InlineBidiResolver::appendRun): Deleted.
* rendering/line/TrailingObjects.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/BidiResolver.h
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/line/TrailingObjects.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189828 => 189829)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 23:44:30 UTC (rev 189828)
+++ trunk/Source/WebCore/ChangeLog	2015-09-16 00:05:58 UTC (rev 189829)
@@ -1,3 +1,61 @@
+2015-09-15  Myles C. Maxfield  
+
+GraphicsContext::drawBidiText()'s BidiResolver should not have isolated runs
+https://bugs.webkit.org/show_bug.cgi?id=149193
+
+Reviewed by Anders Carlsson.
+
+There are two users of BidiResolver, one which needs isolated runs (in RenderBlockLineLayout) and
+one which doesn't (in GraphicsContext::drawBidiText()). Because of [1], the isolated runs vector
+is migrating to a new type outside of platform/. Therefore, only the first user of BidiResolver
+should have this member variable.
+
+This is achieved by creating two subclasses of BidiResolver, and using the Curiously Repeating
+Template pattern to downcast into specializations.
+
+[1] https://bugs.webkit.org/show_bug.cgi?id=149153
+
+No new tests because there is no behavior change.
+
+* platform/text/BidiResolver.h:
+(WebCore::BidiResolverBase::BidiResolverBase):
+(WebCore::BidiResolverBase::increment):
+(WebCore::BidiResolverBase::appendRun):
+(WebCore::BidiResolverBase::incrementInternal):
+(WebCore::IsolateRun>::~BidiResolverWithIsolate):
+(WebCore::Subclass>::appendRunInternal):
+(WebCore::Subclass>::embed):
+(WebCore::Subclass>::checkDirectionInLowerRaiseEmbeddingLevel):
+(WebCore::Subclass>::lowerExplicitEmbeddingLevel):
+(WebCore::Subclass>::raiseExplicitEmbeddingLevel):
+(WebCore::Subclass>::commitExplicitEmbedding):
+(WebCore::Subclass>::updateStatusLastFromCurrentDirection):
+(WebCore::Subclass>::reorderRunsFromLevels):
+(WebCore::Subclass>::createBidiRunsForLine):
+(WebCore::Subclass>::setMidpointForIsolatedRun):
+(WebCore::Subclass>::midpointForIsolatedRun):
+(WebCore::BidiResolver::BidiResolver): 

[webkit-changes] [189837] trunk/LayoutTests

2015-09-15 Thread gyuyoung . kim
Title: [189837] trunk/LayoutTests








Revision 189837
Author gyuyoung@webkit.org
Date 2015-09-15 18:34:05 -0700 (Tue, 15 Sep 2015)


Log Message
[EFL] Unreviewed gardening 16th Sep.

Mark fast/css, fast/form tests to failure. Besides some tests of imported/w3c/web-platform-tests/html
are marked to pass on EFL port.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189836 => 189837)

--- trunk/LayoutTests/ChangeLog	2015-09-16 01:31:50 UTC (rev 189836)
+++ trunk/LayoutTests/ChangeLog	2015-09-16 01:34:05 UTC (rev 189837)
@@ -1,3 +1,12 @@
+2015-09-15  Gyuyoung Kim  
+
+[EFL] Unreviewed gardening 16th Sep.
+
+Mark fast/css, fast/form tests to failure. Besides some tests of imported/w3c/web-platform-tests/html
+are marked to pass on EFL port.
+
+* platform/efl/TestExpectations:
+
 2015-09-15  Benjamin Poulain  
 
 Style invalidation affecting siblings does not work with inline-style changes


Modified: trunk/LayoutTests/platform/efl/TestExpectations (189836 => 189837)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-09-16 01:31:50 UTC (rev 189836)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-09-16 01:34:05 UTC (rev 189837)
@@ -1275,6 +1275,16 @@
 imported/w3c/css/css-multicol-1/multicol-width-ems-001.xht [ Pass ]
 imported/w3c/css/css-multicol-1/multicol-width-small-001.xht [ Pass ]
 imported/w3c/css/css-multicol-1/multicol-zero-height-001.xht [ Pass ]
+imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs.html [ Pass ]
+imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs.html [ Pass ]
+imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html [ Pass ]
+imported/w3c/web-platform-tests/html/dom/elements/global-attributes/style-01.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-01.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol.html [ Pass ]
+imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ Pass ]
 css3/conditional/w3c/at-supports-010.html [ Pass ]
 css3/conditional/w3c/at-supports-014.html [ Pass ]
 fast/borders/border-painting-dashed.html [ Pass ]
@@ -2590,4 +2600,13 @@
 webkit.org/b/148470 fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Timeout ]
 webkit.org/b/148470 fast/replaced/no-focus-ring-iframe.html [ Timeout ]
 webkit.org/b/148470 fullscreen/video-cursor-auto-hide.html [ Timeout ]
-webkit.org/b/148470 http/tests/navigation/no-referrer-subframe.html [ Timeout ]
\ No newline at end of file
+webkit.org/b/148470 http/tests/navigation/no-referrer-subframe.html [ Timeout ]
+
+webkit.org/b/149201 fast/css/text-overflow-ellipsis-text-align-center.html [ Failure ]
+webkit.org/b/149201 fast/css/text-overflow-ellipsis-text-align-left.html [ Failure ]
+webkit.org/b/149201 fast/css/text-overflow-ellipsis-text-align-right.html [ Failure ]
+
+webkit.org/b/149202 fast/forms/indeterminate-progress-inline-height.html [ Failure ]
+webkit.org/b/149202 fast/forms/input-appearance-spinbutton-up.html [ Failure ]
+webkit.org/b/149202 fast/forms/input-appearance-spinbutton.html [ Failure ]
+webkit.org/b/149202 fast/forms/listbox-scrollbar-hit-test.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189832] trunk

2015-09-15 Thread mmaxfield
Title: [189832] trunk








Revision 189832
Author mmaxfi...@apple.com
Date 2015-09-15 17:30:38 -0700 (Tue, 15 Sep 2015)


Log Message
Nested isolates can cause an infinite loop when laying out bidi runs
https://bugs.webkit.org/show_bug.cgi?id=149153

Reviewed by David Hyatt.

Source/WebCore:

When traversing bidi runs, we might encounter a run which is supposed to be isolated. In this
situation, we will append a placeholder run in the run list, and remember a pointer to these
isolated runs inside BidiResolver. Then, once we're done traversing the bidi runs, we return
to the isolated runs and handle them separately (and replace the placeholder with the result).

However, due to the fact that our BidiRuns start at leaf nodes, we have to keep track of which
local root of the render tree we were inspecting (to ensure that we visit the same node
multiple times if there are nested isolate spans). We were not correctly keeping track of this
local root, which was leading us to consider the same root multiple times, thereby leading to
an infinite loop.

The solution is simply to keep root information alongside the isolated run information inside
BidiResolver. However, BidiResolver is inside platform/, which means that this new type should
be a template argument, just like how BidiRun itself is a template argument.

This new type, BidiIsolatedRun, holds all the information that our isolate-revisiting logic
needs inside constructBidiRunsForSegment(). It also holds a reference to the placeholder run
which we will replace.

Test: fast/text/international/unicode-bidi-isolate-nested-crash.html

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText): BidiIsolatedRun template argument is unused, so pass
in Void.
* platform/text/BidiResolver.h: Add template argument.
(WebCore::BidiResolver::isolatedRuns):
(WebCore::IsolatedRun>::~BidiResolver):
(WebCore::IsolatedRun>::appendRun):
(WebCore::IsolatedRun>::embed):
(WebCore::IsolatedRun>::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::IsolatedRun>::lowerExplicitEmbeddingLevel):
(WebCore::IsolatedRun>::raiseExplicitEmbeddingLevel):
(WebCore::IsolatedRun>::commitExplicitEmbedding):
(WebCore::IsolatedRun>::updateStatusLastFromCurrentDirection):
(WebCore::IsolatedRun>::reorderRunsFromLevels):
(WebCore::IsolatedRun>::createBidiRunsForLine):
(WebCore::IsolatedRun>::setMidpointForIsolatedRun): Use references instead of pointers.
(WebCore::IsolatedRun>::midpointForIsolatedRun): Ditto.
(WebCore::Run>::~BidiResolver): Deleted.
(WebCore::Run>::appendRun): Deleted.
(WebCore::Run>::embed): Deleted.
(WebCore::Run>::checkDirectionInLowerRaiseEmbeddingLevel): Deleted.
(WebCore::Run>::lowerExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::raiseExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::commitExplicitEmbedding): Deleted.
(WebCore::Run>::updateStatusLastFromCurrentDirection): Deleted.
(WebCore::Run>::reorderRunsFromLevels): Deleted.
(WebCore::Run>::createBidiRunsForLine): Deleted.
(WebCore::Run>::setMidpointForIsolatedRun): Deleted.
(WebCore::Run>::midpointForIsolatedRun): Deleted.
* rendering/InlineIterator.h:
(WebCore::BidiIsolatedRun::BidiIsolatedRun): New type.
(WebCore::addPlaceholderRunForIsolatedInline): Create new type, and include local root
information.
(WebCore::IsolateTracker::addFakeRunIfNecessary): Include local root information.
(WebCore::InlineBidiResolver::appendRun): Ditto.
* rendering/RenderBlockLineLayout.cpp: Update for new BidiIsolatedRun type.
(WebCore::setUpResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):
* rendering/line/TrailingObjects.h:

LayoutTests:

* fast/text/international/unicode-bidi-isolate-nested-crash-expected.html: Added.
* fast/text/international/unicode-bidi-isolate-nested-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/BidiResolver.h
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/line/TrailingObjects.h


Added Paths

trunk/LayoutTests/fast/text/international/unicode-bidi-isolate-nested-crash-expected.html
trunk/LayoutTests/fast/text/international/unicode-bidi-isolate-nested-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (189831 => 189832)

--- trunk/LayoutTests/ChangeLog	2015-09-16 00:19:29 UTC (rev 189831)
+++ trunk/LayoutTests/ChangeLog	2015-09-16 00:30:38 UTC (rev 189832)
@@ -1,3 +1,13 @@
+2015-09-15  Myles C. Maxfield  
+
+Nested isolates can cause an infinite loop when laying out bidi runs
+https://bugs.webkit.org/show_bug.cgi?id=149153
+
+Reviewed by David Hyatt.
+
+* fast/text/international/unicode-bidi-isolate-nested-crash-expected.html: Added.
+* fast/text/international/unicode-bidi-isolate-nested-crash.html: Added.
+
 2015-09-15  Chris Dumez  
 
 Element.getAttributeNS() should return null if the attribute does not 

[webkit-changes] [189833] trunk

2015-09-15 Thread bfulgham
Title: [189833] trunk








Revision 189833
Author bfulg...@apple.com
Date 2015-09-15 18:00:32 -0700 (Tue, 15 Sep 2015)


Log Message
[Win] Provide a means for viewing the layer tree
https://bugs.webkit.org/show_bug.cgi?id=149165

Reviewed by Simon Fraser.

Source/WebCore:

Revise the old fprintf logic to generate a string
containing the layer tree so that it can be output
to the debugger (or elsewhere).

* platform/graphics/ca/PlatformCALayer.h: Rename 'printTree'
to 'printLayerTree', and make it available in release builds.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::printLayerTree): Added. Calls into
the PlatformCALayer implementation.
* platform/graphics/ca/win/CACFLayerTreeHost.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(printIndent): Revise to use two-space indent and use StringBuilder.
(printTransform): Ditto.
(printColor): Added helper function.
(printLayer): Revised to output information on the layer contents.
(PlatformCALayerWin::printLayerTree): Renamed from 'printTree'.
(PlatformCALayerWin::printTree): Deleted.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::drawRepaintCounters): Drive-by fix. Match the
cocoa repaint counter logic by not painting counters for the layers that
contain the tile grid.
* platform/graphics/ca/win/PlatformCALayerWin.h:
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::drawRepaintCounters):

Source/WebKit/win:

Add a new WebView method "printLayerTree" so that clients
can get a string dump of the current layer tree. Add this
to a new COM interface version so no existing clients break
compatibility.

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::QueryInterface): Recognize the new interface version.
(WebView::printLayerTree): Added. This just calls the WebCore
implementation.
* WebView.h:

Tools:

Update MiniBrowser with a new Debug menu option that will
dump the current layer tree to the debug console.

* MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
* MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
* MiniBrowser/win/Common.cpp:
(WndProc): Add handler for 'Print Layer Tree' menu option.
* MiniBrowser/win/MiniBrowser.cpp:
(MiniBrowser::printLayerTree): Added Handler.
* MiniBrowser/win/MiniBrowser.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit/win/WebView.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc
trunk/Tools/MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h
trunk/Tools/MiniBrowser/win/Common.cpp
trunk/Tools/MiniBrowser/win/MiniBrowser.cpp
trunk/Tools/MiniBrowser/win/MiniBrowser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189832 => 189833)

--- trunk/Source/WebCore/ChangeLog	2015-09-16 00:30:38 UTC (rev 189832)
+++ trunk/Source/WebCore/ChangeLog	2015-09-16 01:00:32 UTC (rev 189833)
@@ -1,3 +1,35 @@
+2015-09-15  Brent Fulgham  
+
+[Win] Provide a means for viewing the layer tree
+https://bugs.webkit.org/show_bug.cgi?id=149165
+
+Reviewed by Simon Fraser.
+
+Revise the old fprintf logic to generate a string
+containing the layer tree so that it can be output
+to the debugger (or elsewhere).
+
+* platform/graphics/ca/PlatformCALayer.h: Rename 'printTree'
+to 'printLayerTree', and make it available in release builds.
+* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
+(WebCore::CACFLayerTreeHost::printLayerTree): Added. Calls into
+the PlatformCALayer implementation.
+* platform/graphics/ca/win/CACFLayerTreeHost.h:
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(printIndent): Revise to use two-space indent and use StringBuilder.
+(printTransform): Ditto.
+(printColor): Added helper function.
+(printLayer): Revised to output information on the layer contents.
+(PlatformCALayerWin::printLayerTree): Renamed from 'printTree'.
+(PlatformCALayerWin::printTree): Deleted.
+* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
+(PlatformCALayerWinInternal::drawRepaintCounters): Drive-by fix. Match the
+cocoa repaint counter logic by not painting counters for the layers that
+contain the tile grid.
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+* 

[webkit-changes] [189836] trunk

2015-09-15 Thread benjamin
Title: [189836] trunk








Revision 189836
Author benja...@webkit.org
Date 2015-09-15 18:31:50 -0700 (Tue, 15 Sep 2015)


Log Message
Style invalidation affecting siblings does not work with inline-style changes
https://bugs.webkit.org/show_bug.cgi?id=149189

Patch by Benjamin Poulain  on 2015-09-15
Reviewed by Antti Koivisto.

Source/WebCore:

Style::resolveTree() made the assumption that inline style changes only affect
descendants and should not participate in "StyleRecalcAffectsNextSiblingElementStyle".
That was wrong. If the inline style change through CSSOM, it can cause the creation
of a style attribute, which is observable through "StyleRecalcAffectsNextSiblingElementStyle".

This patch removes the incorrect assumption. Style invalidation is always propagated now.

Tests: fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html
   fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html
   fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::InlineCSSStyleDeclaration::didMutate): Deleted.
* dom/StyledElement.cpp:
(WebCore::StyledElement::inlineStyleChanged):
* dom/StyledElement.h:
(WebCore::StyledElement::invalidateStyleAttribute):
Clean up inline-style invalidation a tiny bit.

* style/StyleResolveTree.cpp:
(WebCore::Style::resolveTree):
Fix the bug.

LayoutTests:

* fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt: Added.
* fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html: Added.
* fast/css/style-attribute-invalidation-propagates-to-direct-siblings-expected.txt: Added.
* fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html: Added.
* fast/css/style-attribute-invalidation-propagates-to-indirect-siblings-expected.txt: Added.
* fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/dom/StyledElement.h
trunk/Source/WebCore/style/StyleResolveTree.cpp


Added Paths

trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt
trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html
trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-direct-siblings-expected.txt
trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html
trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-indirect-siblings-expected.txt
trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html




Diff

Modified: trunk/LayoutTests/ChangeLog (189835 => 189836)

--- trunk/LayoutTests/ChangeLog	2015-09-16 01:14:29 UTC (rev 189835)
+++ trunk/LayoutTests/ChangeLog	2015-09-16 01:31:50 UTC (rev 189836)
@@ -1,3 +1,17 @@
+2015-09-15  Benjamin Poulain  
+
+Style invalidation affecting siblings does not work with inline-style changes
+https://bugs.webkit.org/show_bug.cgi?id=149189
+
+Reviewed by Antti Koivisto.
+
+* fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt: Added.
+* fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html: Added.
+* fast/css/style-attribute-invalidation-propagates-to-direct-siblings-expected.txt: Added.
+* fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html: Added.
+* fast/css/style-attribute-invalidation-propagates-to-indirect-siblings-expected.txt: Added.
+* fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html: Added.
+
 2015-09-15  Myles C. Maxfield  
 
 Nested isolates can cause an infinite loop when laying out bidi runs


Added: trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt (0 => 189836)

--- trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt	2015-09-16 01:31:50 UTC (rev 189836)
@@ -0,0 +1,19 @@
+Test that style invalidation through inline-style propagates correctly to siblings when a combinator requires it.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getComputedStyle(document.querySelectorAll("target")[0]).color is "rgb(0, 0, 0)"
+PASS getComputedStyle(document.querySelectorAll("target")[1]).color is "rgb(0, 0, 0)"
+PASS getComputedStyle(document.querySelectorAll("target")[0]).color is "rgb(255, 192, 203)"
+PASS getComputedStyle(document.querySelectorAll("target")[1]).color is "rgb(255, 192, 203)"
+PASS 

[webkit-changes] [189831] trunk/Source

2015-09-15 Thread beidson
Title: [189831] trunk/Source








Revision 189831
Author beid...@apple.com
Date 2015-09-15 17:19:29 -0700 (Tue, 15 Sep 2015)


Log Message
Add empty IDBFactory implementation for Modern IDB.
https://bugs.webkit.org/show_bug.cgi?id=149191

Reviewed by Jer Noble.

Source/WebCore:

No new tests (No behavior change).

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):

* Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::IDBFactory::create):
(WebCore::IDBClient::IDBFactory::IDBFactory):
(WebCore::IDBClient::IDBFactory::getDatabaseNames):
(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::deleteDatabase):
(WebCore::IDBClient::IDBFactory::cmp):
* Modules/indexeddb/client/IDBFactoryImpl.h:

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* loader/EmptyClients.cpp:
* page/DatabaseProvider.h:

Source/WebKit:

* Storage/WebDatabaseProvider.h:

Source/WebKit2:

* WebProcess/Databases/WebDatabaseProvider.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/page/DatabaseProvider.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Storage/WebDatabaseProvider.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Databases/WebDatabaseProvider.h


Added Paths

trunk/Source/WebCore/Modules/indexeddb/client/
trunk/Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (189830 => 189831)

--- trunk/Source/WebCore/CMakeLists.txt	2015-09-16 00:16:58 UTC (rev 189830)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-09-16 00:19:29 UTC (rev 189831)
@@ -10,6 +10,7 @@
 "${WEBCORE_DIR}/Modules/gamepad/deprecated"
 "${WEBCORE_DIR}/Modules/geolocation"
 "${WEBCORE_DIR}/Modules/indexeddb"
+"${WEBCORE_DIR}/Modules/indexeddb/client"
 "${WEBCORE_DIR}/Modules/indexeddb/legacy"
 "${WEBCORE_DIR}/Modules/indieui"
 "${WEBCORE_DIR}/Modules/mediacontrols/"
@@ -864,6 +865,8 @@
 Modules/indexeddb/IDBVersionChangeEvent.cpp
 Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp
 
+Modules/indexeddb/client/IDBFactoryImpl.cpp
+
 Modules/indexeddb/legacy/IDBCursorBackend.cpp
 Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp
 Modules/indexeddb/legacy/IDBDatabaseBackend.cpp


Modified: trunk/Source/WebCore/ChangeLog (189830 => 189831)

--- trunk/Source/WebCore/ChangeLog	2015-09-16 00:16:58 UTC (rev 189830)
+++ trunk/Source/WebCore/ChangeLog	2015-09-16 00:19:29 UTC (rev 189831)
@@ -1,3 +1,30 @@
+2015-09-15  Brady Eidson  
+
+Add empty IDBFactory implementation for Modern IDB.
+https://bugs.webkit.org/show_bug.cgi?id=149191
+
+Reviewed by Jer Noble.
+
+No new tests (No behavior change).
+
+* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
+(WebCore::DOMWindowIndexedDatabase::indexedDB):
+
+* Modules/indexeddb/client/IDBFactoryImpl.cpp: 
+(WebCore::IDBClient::IDBFactory::create):
+(WebCore::IDBClient::IDBFactory::IDBFactory):
+(WebCore::IDBClient::IDBFactory::getDatabaseNames):
+(WebCore::IDBClient::IDBFactory::open):
+(WebCore::IDBClient::IDBFactory::deleteDatabase):
+(WebCore::IDBClient::IDBFactory::cmp):
+* Modules/indexeddb/client/IDBFactoryImpl.h: 
+
+* CMakeLists.txt:
+* WebCore.xcodeproj/project.pbxproj:
+
+* loader/EmptyClients.cpp:
+* page/DatabaseProvider.h:
+
 2015-09-15  Antti Koivisto  
 
 Split FontDescription into lower and higher level types


Modified: trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp (189830 => 189831)

--- trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp	2015-09-16 00:16:58 UTC (rev 189830)
+++ trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp	2015-09-16 00:19:29 UTC (rev 189831)
@@ -31,6 +31,7 @@
 #include "DOMWindow.h"
 #include "DatabaseProvider.h"
 #include "Document.h"
+#include "IDBFactoryImpl.h"
 #include "LegacyFactory.h"
 #include "Page.h"
 #include "SecurityOrigin.h"
@@ -111,8 +112,12 @@
 if (!m_window->isCurrentlyDisplayedInFrame())
 return nullptr;
 
-if (!m_idbFactory)
-m_idbFactory = LegacyFactory::create(page->databaseProvider().idbFactoryBackend());
+if (!m_idbFactory) {
+if (page->databaseProvider().supportsModernIDB())
+m_idbFactory = IDBClient::IDBFactory::create();
+else
+m_idbFactory = LegacyFactory::create(page->databaseProvider().idbFactoryBackend());
+}
 
 return m_idbFactory.get();
 }


Copied: trunk/Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp 

[webkit-changes] [189834] trunk/Source

2015-09-15 Thread commit-queue
Title: [189834] trunk/Source








Revision 189834
Author commit-qu...@webkit.org
Date 2015-09-15 18:03:35 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: Paused Debugger prevents page reload
https://bugs.webkit.org/show_bug.cgi?id=148174

Patch by Joseph Pecoraro  on 2015-09-15
Reviewed by Brian Burg.

Source/_javascript_Core:

* debugger/Debugger.h:
(JSC::Debugger::suppressAllPauses):
(JSC::Debugger::setSuppressAllPauses):
* debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
(JSC::Debugger::pauseIfNeeded):
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::setSuppressAllPauses):
Provide a way to suppress pauses.

Source/WebCore:

When navigating the page while paused, suppress any pausing until the page
has completed navigation. If not paused and navigating, you can still pause
in pagehide and unload handlers or other late page events.

Could not write a reliable test for this at the moment.
InspectorTest.reloadPage has multiple issues with the output,
so I'll investigate making reload tests more reliable later.

* inspector/InspectorController.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::resume): Deleted.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
We now use existing InspectorInstrumentation functions instead of a method
on InspectorController during load. In dropping the method InspectorController
can drop a member variable no longer used.

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willStartProvisionalLoad):
Add a new instrumentation hook.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willStartProvisionalLoadImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
When starting or completing main frame navigations, let the PageDebuggerAgent do some work.

* inspector/PageDebuggerAgent.h:
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::mainFrameStartedLoading):
(WebCore::PageDebuggerAgent::mainFrameStoppedLoading):
(WebCore::PageDebuggerAgent::mainFrameNavigated):
Suppress pausing if navigating while paused. Otherwise behave as normal.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/debugger/Debugger.cpp
trunk/Source/_javascript_Core/debugger/Debugger.h
trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp
trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.h
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189833 => 189834)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-16 01:00:32 UTC (rev 189833)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-16 01:03:35 UTC (rev 189834)
@@ -1,3 +1,21 @@
+2015-09-15  Joseph Pecoraro  
+
+Web Inspector: Paused Debugger prevents page reload
+https://bugs.webkit.org/show_bug.cgi?id=148174
+
+Reviewed by Brian Burg.
+
+* debugger/Debugger.h:
+(JSC::Debugger::suppressAllPauses):
+(JSC::Debugger::setSuppressAllPauses):
+* debugger/Debugger.cpp:
+(JSC::Debugger::Debugger):
+(JSC::Debugger::pauseIfNeeded):
+* inspector/agents/InspectorDebuggerAgent.h:
+* inspector/agents/InspectorDebuggerAgent.cpp:
+(Inspector::InspectorDebuggerAgent::setSuppressAllPauses):
+Provide a way to suppress pauses.
+
 2015-09-15  Sukolsak Sakshuwong  
 
 Implement calls to _javascript_ functions in WebAssembly


Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (189833 => 189834)

--- trunk/Source/_javascript_Core/debugger/Debugger.cpp	2015-09-16 01:00:32 UTC (rev 189833)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp	2015-09-16 01:03:35 UTC (rev 189834)
@@ -118,6 +118,7 @@
 , m_breakpointsActivated(true)
 , m_hasHandlerForExceptionCallback(false)
 , m_isInWorkerThread(isInWorkerThread)
+, m_suppressAllPauses(false)
 , m_steppingMode(SteppingModeDisabled)
 , m_reasonForPause(NotPaused)
 , m_pauseOnCallFrame(0)
@@ -585,6 +586,9 @@
 if (m_isPaused)
 return;
 
+if (m_suppressAllPauses)
+return;
+
 JSGlobalObject* vmEntryGlobalObject = callFrame->vmEntryGlobalObject();
 if (!needPauseHandling(vmEntryGlobalObject))
 return;


Modified: trunk/Source/_javascript_Core/debugger/Debugger.h (189833 => 189834)

--- trunk/Source/_javascript_Core/debugger/Debugger.h	2015-09-16 01:00:32 UTC (rev 189833)
+++ trunk/Source/_javascript_Core/debugger/Debugger.h	2015-09-16 01:03:35 UTC 

[webkit-changes] [189839] trunk/Tools

2015-09-15 Thread commit-queue
Title: [189839] trunk/Tools








Revision 189839
Author commit-qu...@webkit.org
Date 2015-09-15 19:04:31 -0700 (Tue, 15 Sep 2015)


Log Message
Appscale queue status json output lacks bots
https://bugs.webkit.org/show_bug.cgi?id=149194


Patch by Aakash Jain  on 2015-09-15
Reviewed by Alexey Proskuryakov.

* QueueStatusServer/handlers/queuestatusjson.py:
(QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
* QueueStatusServer/index.yaml: Index according to appscale requirements.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py
trunk/Tools/QueueStatusServer/index.yaml




Diff

Modified: trunk/Tools/ChangeLog (189838 => 189839)

--- trunk/Tools/ChangeLog	2015-09-16 01:54:47 UTC (rev 189838)
+++ trunk/Tools/ChangeLog	2015-09-16 02:04:31 UTC (rev 189839)
@@ -1,3 +1,15 @@
+2015-09-15  Aakash Jain  
+
+Appscale queue status json output lacks bots
+https://bugs.webkit.org/show_bug.cgi?id=149194
+
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/handlers/queuestatusjson.py:
+(QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
+* QueueStatusServer/index.yaml: Index according to appscale requirements.
+
 2015-09-15  Brent Fulgham  
 
 [Win] Provide a means for viewing the layer tree


Modified: trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py (189838 => 189839)

--- trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py	2015-09-16 01:54:47 UTC (rev 189838)
+++ trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py	2015-09-16 02:04:31 UTC (rev 189839)
@@ -78,7 +78,7 @@
 
 def _bots(self, queue):
 # First, collect all bots that ever served this queue.
-bot_id_statuses = QueueStatus.all(projection=['bot_id'], distinct=True).filter('queue_name =', queue.name()).fetch(500)
+bot_id_statuses = QueueStatus.all(projection=['bot_id'], distinct=True).filter('queue_name =', queue.name()).order('-date').fetch(500)
 bot_ids = list(entry.bot_id for entry in bot_id_statuses)
 result = []
 for bot_id in bot_ids:


Modified: trunk/Tools/QueueStatusServer/index.yaml (189838 => 189839)

--- trunk/Tools/QueueStatusServer/index.yaml	2015-09-16 01:54:47 UTC (rev 189838)
+++ trunk/Tools/QueueStatusServer/index.yaml	2015-09-16 02:04:31 UTC (rev 189839)
@@ -49,10 +49,10 @@
 
 - kind: QueueStatus
   properties:
-  - name: bot_id
   - name: queue_name
   - name: date
 direction: desc
+  - name: bot_id
 
 - kind: QueueStatus
   properties:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189840] trunk/Source/WebCore

2015-09-15 Thread bfulgham
Title: [189840] trunk/Source/WebCore








Revision 189840
Author bfulg...@apple.com
Date 2015-09-15 19:10:46 -0700 (Tue, 15 Sep 2015)


Log Message
[Win] Unreviewed release fix after r189832

* platform/graphics/ca/win/PlatformCALayerWin.h: The implementation
should exist in Release builds as well.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189839 => 189840)

--- trunk/Source/WebCore/ChangeLog	2015-09-16 02:04:31 UTC (rev 189839)
+++ trunk/Source/WebCore/ChangeLog	2015-09-16 02:10:46 UTC (rev 189840)
@@ -1,3 +1,10 @@
+2015-09-15  Brent Fulgham  
+
+[Win] Unreviewed release fix after r189832
+
+* platform/graphics/ca/win/PlatformCALayerWin.h: The implementation
+should exist in Release builds as well.
+
 2015-09-15  Benjamin Poulain  
 
 Style invalidation affecting siblings does not work with inline-style changes


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (189839 => 189840)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2015-09-16 02:04:31 UTC (rev 189839)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2015-09-16 02:10:46 UTC (rev 189840)
@@ -150,9 +150,7 @@
 virtual void setNeedsCommit() override;
 virtual void drawTextAtPoint(CGContextRef, CGFloat x, CGFloat y, const char* text, size_t length) const override;
 
-#ifndef NDEBUG
 virtual String layerTreeAsString() const override;
-#endif
 
 virtual PassRefPtr clone(PlatformCALayerClient* owner) const override;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189826] trunk/Source/WebCore

2015-09-15 Thread clopez
Title: [189826] trunk/Source/WebCore








Revision 189826
Author clo...@igalia.com
Date 2015-09-15 14:50:18 -0700 (Tue, 15 Sep 2015)


Log Message
[GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only.
https://bugs.webkit.org/show_bug.cgi?id=149172

Reviewed by Martin Robinson.

No new tests, no behavior change.

* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::cairoDevice):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (189825 => 189826)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 21:39:02 UTC (rev 189825)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 21:50:18 UTC (rev 189826)
@@ -1,3 +1,15 @@
+2015-09-15  Carlos Alberto Lopez Perez  
+
+[GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only.
+https://bugs.webkit.org/show_bug.cgi?id=149172
+
+Reviewed by Martin Robinson.
+
+No new tests, no behavior change.
+
+* platform/graphics/glx/GLContextGLX.cpp:
+(WebCore::GLContextGLX::cairoDevice):
+
 2015-09-15  Chris Dumez  
 
 Element.getAttributeNS() should return null if the attribute does not exist


Modified: trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp (189825 => 189826)

--- trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp	2015-09-15 21:39:02 UTC (rev 189825)
+++ trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp	2015-09-15 21:50:18 UTC (rev 189826)
@@ -226,7 +226,7 @@
 if (m_cairoDevice)
 return m_cairoDevice;
 
-#if ENABLE(ACCELERATED_2D_CANVAS)
+#if ENABLE(ACCELERATED_2D_CANVAS) && CAIRO_HAS_GLX_FUNCTIONS
 m_cairoDevice = cairo_glx_device_create(downcast(PlatformDisplay::sharedDisplay()).native(), m_context.get());
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189827] trunk

2015-09-15 Thread cdumez
Title: [189827] trunk








Revision 189827
Author cdu...@apple.com
Date 2015-09-15 15:10:54 -0700 (Tue, 15 Sep 2015)


Log Message
new Event() without parameter should throw
https://bugs.webkit.org/show_bug.cgi?id=149146


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that a new check is passing.

* web-platform-tests/dom/events/Event-constructors-expected.txt:

Source/WebCore:

new Event() without parameter should throw because the type parameter
is mandatory as per the specification:
https://dom.spec.whatwg.org/#interface-event

Both Firefox and Chrome throw in this case. However, WebKit was
creating an event whose type is the string "undefined". This patch
aligns our behavior with the specification and other major browsers.

No new tests, already covered by existing test.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):

Modified Paths

trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp




Diff

Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (189826 => 189827)

--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt	2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt	2015-09-15 22:10:54 UTC (rev 189827)
@@ -9,10 +9,6 @@
 PASS (new inner.MediaController()).constructor.isInner is true
 PASS (new inner.Option()).isInner is true
 PASS (new inner.Option()).constructor.isInner is true
-PASS (new inner.OverflowEvent()).isInner is true
-PASS (new inner.OverflowEvent()).constructor.isInner is true
-PASS (new inner.ProgressEvent()).isInner is true
-PASS (new inner.ProgressEvent()).constructor.isInner is true
 PASS (new inner.URL('about:blank')).isInner is true
 PASS (new inner.URL('about:blank')).constructor.isInner is true
 PASS (new inner.XMLHttpRequest()).isInner is true


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189826 => 189827)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-15 22:10:54 UTC (rev 189827)
@@ -1,5 +1,17 @@
 2015-09-15  Chris Dumez  
 
+new Event() without parameter should throw
+https://bugs.webkit.org/show_bug.cgi?id=149146
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline W3C test now that a new check is passing.
+
+* web-platform-tests/dom/events/Event-constructors-expected.txt:
+
+2015-09-15  Chris Dumez  
+
 Element.getAttributeNS() should return null if the attribute does not exist
 https://bugs.webkit.org/show_bug.cgi?id=149180
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt (189826 => 189827)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt	2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt	2015-09-15 22:10:54 UTC (rev 189827)
@@ -1,7 +1,5 @@
 
-FAIL Event constructors assert_throws: function "function () {
-new Event()
-  }" did not throw
+PASS Event constructors 
 PASS Event constructors 1 
 FAIL Event constructors 2 assert_equals: expected (boolean) false but got (undefined) undefined
 FAIL Event constructors 3 assert_equals: expected (boolean) false but got (undefined) undefined


Modified: trunk/Source/WebCore/ChangeLog (189826 => 189827)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 22:10:54 UTC (rev 189827)
@@ -1,3 +1,26 @@
+2015-09-15  Chris Dumez  
+
+new Event() without parameter should throw
+https://bugs.webkit.org/show_bug.cgi?id=149146
+
+
+Reviewed by Ryosuke Niwa.
+
+new Event() without parameter should throw because the type parameter
+is mandatory as per the specification:
+https://dom.spec.whatwg.org/#interface-event
+
+Both Firefox and Chrome throw in this case. However, WebKit was
+creating an event whose type is the string "undefined". This patch
+aligns our behavior with the specification and other major browsers.
+
+No new tests, already covered by existing test.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition):
+* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+

[webkit-changes] [189778] trunk/LayoutTests

2015-09-15 Thread ap
Title: [189778] trunk/LayoutTests








Revision 189778
Author a...@apple.com
Date 2015-09-14 23:46:48 -0700 (Mon, 14 Sep 2015)


Log Message
Layout Test http/tests/media/media-document-referer.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=145257

Reviewed by Chris Dumez.

* http/tests/media/media-document-referer.html: Increase the timeout, one second is not much.

* platform/gtk/TestExpectations: Fingers crossed, this will help Gtk as well.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-document-referer.html
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189777 => 189778)

--- trunk/LayoutTests/ChangeLog	2015-09-15 06:25:23 UTC (rev 189777)
+++ trunk/LayoutTests/ChangeLog	2015-09-15 06:46:48 UTC (rev 189778)
@@ -1,3 +1,14 @@
+2015-09-14  Alexey Proskuryakov  
+
+Layout Test http/tests/media/media-document-referer.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=145257
+
+Reviewed by Chris Dumez.
+
+* http/tests/media/media-document-referer.html: Increase the timeout, one second is not much.
+
+* platform/gtk/TestExpectations: Fingers crossed, this will help Gtk as well.
+
 2015-09-14  Gyuyoung Kim  
 
 Unreviewed, EFL gardening on 15th Sep.


Modified: trunk/LayoutTests/http/tests/media/media-document-referer.html (189777 => 189778)

--- trunk/LayoutTests/http/tests/media/media-document-referer.html	2015-09-15 06:25:23 UTC (rev 189777)
+++ trunk/LayoutTests/http/tests/media/media-document-referer.html	2015-09-15 06:46:48 UTC (rev 189778)
@@ -21,7 +21,7 @@
 return;
 }
 
-if (++counter >= 10) {
+if (++counter >= 100) {
 failTest("TIMEOUT: video failed to load without an error.");
 return;
 }


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (189777 => 189778)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-15 06:25:23 UTC (rev 189777)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-15 06:46:48 UTC (rev 189778)
@@ -1157,7 +1157,6 @@
 webkit.org/b/145170 fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html [ Failure Pass ]
 
 webkit.org/b/145256 media/video-controller-child-rate.html [ Failure Pass ]
-webkit.org/b/145257 http/tests/media/media-document-referer.html [ Failure Pass ]
 webkit.org/b/145258 media/video-controller-child-rate.html [ Failure Pass ]
 
 webkit.org/b/145261 fast/workers/stress-js-execution.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189782] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189782] releases/WebKitGTK/webkit-2.10








Revision 189782
Author carlo...@webkit.org
Date 2015-09-15 00:17:25 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189502 - document.importNode(node, deep): deep's default value should be false
https://bugs.webkit.org/show_bug.cgi?id=148959


Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* web-platform-tests/dom/nodes/Document-importNode-expected.txt:
Rebaseline now that an additional check is passing.

Source/WebCore:

Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:
- https://dom.spec.whatwg.org/#interface-document
- https://dom.spec.whatwg.org/#dom-document-importnode

Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.

No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html

* dom/Document.h:
(WebCore::Document::importNode):

LayoutTests:

* fast/dom/document-importNode-arguments.html:
Explicitly pass deep parameter as the test wants a deep clone.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html
releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.h




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189781 => 189782)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,14 @@
+2015-09-08  Chris Dumez  
+
+document.importNode(node, deep): deep's default value should be false
+https://bugs.webkit.org/show_bug.cgi?id=148959
+
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/dom/document-importNode-arguments.html:
+Explicitly pass deep parameter as the test wants a deep clone.
+
 2015-09-07  Daniel Bates  
 
 ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html (189781 => 189782)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html	2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html	2015-09-15 07:17:25 UTC (rev 189782)
@@ -14,7 +14,7 @@
 var d = document.createElement("div");
 d.innerHTML = "hello world";
 
-imported = document.importNode(d);
+imported = document.importNode(d, true);
 shouldBe('imported.childNodes.length','2');
 shouldBeTrue("imported.textContent == 'hello world'");
 


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog (189781 => 189782)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,14 @@
+2015-09-08  Chris Dumez  
+
+document.importNode(node, deep): deep's default value should be false
+https://bugs.webkit.org/show_bug.cgi?id=148959
+
+
+Reviewed by Alexey Proskuryakov.
+
+* web-platform-tests/dom/nodes/Document-importNode-expected.txt:
+Rebaseline now that an additional check is passing.
+
 2015-04-13  Alexey Proskuryakov  
 
 imported/w3c/canvas/2d.text.measure.width.empty.html is flaky


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189781 => 189782)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,25 @@
+2015-09-08  Chris Dumez  
+
+document.importNode(node, deep): deep's default value should be false
+https://bugs.webkit.org/show_bug.cgi?id=148959
+
+
+Reviewed by Alexey Proskuryakov.
+
+Switch deep parameter's default value for document.importNode() to
+false, as per the latest DOM specification:
+- https://dom.spec.whatwg.org/#interface-document
+- https://dom.spec.whatwg.org/#dom-document-importnode
+
+Firefox and Chrome follow the specification. However, WebKit was using
+"true" for deep's default value.
+
+No new tests, already covered by:
+imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html
+
+* dom/Document.h:
+(WebCore::Document::importNode):
+
 2015-09-07  Daniel Bates  
 
 ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form


Modified: 

[webkit-changes] [189783] releases/WebKitGTK/webkit-2.10/Source/WebCore

2015-09-15 Thread carlosgc
Title: [189783] releases/WebKitGTK/webkit-2.10/Source/WebCore








Revision 189783
Author carlo...@webkit.org
Date 2015-09-15 00:20:22 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189526 - Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=143245

Reviewed by Darin Adler.

sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
library when needed, so applications should never need to call it directly. The problem is,
it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
make sure that the library is fully initialized before the first call to sqlite3_open. It's
a good idea to do this regardless, because the documentation says it could be required in
a future release of SQLite. (Though the use of std::call_once should not be needed, and is
only used to attempt to work around the crashes.)

This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
developers are not really confident in the thread-safety of this function, and have advised
that we carry the workaround. Seems like a good idea.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/sql/SQLiteDatabase.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189782 => 189783)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:17:25 UTC (rev 189782)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:20:22 UTC (rev 189783)
@@ -1,3 +1,27 @@
+2015-09-08  Michael Catanzaro  
+
+Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
+https://bugs.webkit.org/show_bug.cgi?id=143245
+
+Reviewed by Darin Adler.
+
+sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
+library when needed, so applications should never need to call it directly. The problem is,
+it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
+cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
+threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
+make sure that the library is fully initialized before the first call to sqlite3_open. It's
+a good idea to do this regardless, because the documentation says it could be required in
+a future release of SQLite. (Though the use of std::call_once should not be needed, and is
+only used to attempt to work around the crashes.)
+
+This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
+developers are not really confident in the thread-safety of this function, and have advised
+that we carry the workaround. Seems like a good idea.
+
+* platform/sql/SQLiteDatabase.cpp:
+(WebCore::SQLiteDatabase::SQLiteDatabase):
+
 2015-09-08  Chris Dumez  
 
 document.importNode(node, deep): deep's default value should be false


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/sql/SQLiteDatabase.cpp (189782 => 189783)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2015-09-15 07:17:25 UTC (rev 189782)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2015-09-15 07:20:22 UTC (rev 189783)
@@ -31,6 +31,8 @@
 #include "Logging.h"
 #include "SQLiteFileSystem.h"
 #include "SQLiteStatement.h"
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -57,6 +59,22 @@
 , m_openErrorMessage()
 , m_lastChangesCount(0)
 {
+static std::once_flag flag;
+std::call_once(flag, [] {
+// It should be safe to call this outside of std::call_once, since it is documented to be
+// completely threadsafe. But in the past it was not safe, and the SQLite developers still
+// aren't confident that it really is, and we still support ancient versions of SQLite. So
+// std::call_once is used to stay on the safe side. See bug #143245.
+int ret = sqlite3_initialize();
+if (ret != SQLITE_OK) {
+#if SQLITE_VERSION_NUMBER >= 3007015
+WTFLogAlways("Failed to initialize SQLite: %s", sqlite3_errstr(ret));
+#else
+WTFLogAlways("Failed to initialize SQLite");
+#endif
+CRASH();
+}
+});
 }
 
 SQLiteDatabase::~SQLiteDatabase()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [189794] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

2015-09-15 Thread carlosgc
Title: [189794] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po








Revision 189794
Author carlo...@webkit.org
Date 2015-09-15 01:10:14 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189661 - [GTK] [l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

* tr.po: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog


Added Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/tr.po




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189793 => 189794)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:07:01 UTC (rev 189793)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:10:14 UTC (rev 189794)
@@ -1,3 +1,12 @@
+2015-09-12  Michael Catanzaro  
+
+[GTK] [l10n] Updated Turkish translation of WebKitGTK+
+https://bugs.webkit.org/show_bug.cgi?id=148362
+
+Unreviewed.
+
+* tr.po: Added.
+
 2015-07-22  Josef Andersson  
 
 [l10n] Updated Swedish translation


Added: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/tr.po (0 => 189794)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/tr.po	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/tr.po	2015-09-15 08:10:14 UTC (rev 189794)
@@ -0,0 +1,1611 @@
+# Turkish translation for webkit.
+# Copyright (C) 2014 webkit's COPYRIGHT HOLDER
+# This file is distributed under the same license as the webkit package.
+#
+# Elif Aydurmuş , 2014.
+# Sabri Ünal , 2014.
+# Furkan Usta , 2015.
+# Gökhan Gurbetoğlu , 2014, 2015.
+# Muhammet Kara , 2014, 2015.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: webkit HEAD\n"
+"Report-Msgid-Bugs-To: https://bugs.webkit.org\n"
+"POT-Creation-Date: 2015-08-23 00:17+\n"
+"PO-Revision-Date: 2015-08-23 03:32+0300\n"
+"Last-Translator: Muhammet Kara \n"
+"Language-Team: Türkçe \n"
+"Language: tr\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=1; plural=0;\n"
+"X-Generator: Gtranslator 2.91.7\n"
+
+#: ../ErrorsGtk.cpp:33
+msgid "Load request cancelled"
+msgstr "Yükleme isteği iptal edildi"
+
+#: ../ErrorsGtk.cpp:39
+msgid "Not allowed to use restricted network port"
+msgstr "Sınırlı ağ bağlantı noktası kullanmaya izin verilmiyor"
+
+#: ../ErrorsGtk.cpp:45
+msgid "URL cannot be shown"
+msgstr "URL gösterilemiyor"
+
+#: ../ErrorsGtk.cpp:51
+msgid "Frame load was interrupted"
+msgstr "Çerçeve yükleme kesintiye uğradı"
+
+#: ../ErrorsGtk.cpp:57
+msgid "Content with the specified MIME type cannot be shown"
+msgstr "Belirtilen MIME türündeki içerik gösterilemiyor"
+
+#: ../ErrorsGtk.cpp:63
+msgid "File does not exist"
+msgstr "Dosya mevcut değil"
+
+#: ../ErrorsGtk.cpp:69
+msgid "Plugin will handle load"
+msgstr "Yükleme işini eklenti halledecek"
+
+#: ../ErrorsGtk.cpp:81
+msgid "User cancelled the download"
+msgstr "Kullanıcı indirmeyi iptal etti"
+
+#: ../ErrorsGtk.cpp:97
+msgid "Printer not found"
+msgstr "Yazıcı bulunamadı"
+
+#: ../ErrorsGtk.cpp:102
+msgid "Invalid page range"
+msgstr "Geçersiz sayfa aralığı"
+
+#: ../LocalizedStringsGtk.cpp:55 ../LocalizedStringsGtk.cpp:60
+msgid "Submit"
+msgstr "Gönder"
+
+#: ../LocalizedStringsGtk.cpp:65
+msgid "Reset"
+msgstr "Sıfırla"
+
+#: ../LocalizedStringsGtk.cpp:70
+msgid "Details"
+msgstr "Ayrıntılar"
+
+#: ../LocalizedStringsGtk.cpp:75
+msgid "This is a searchable index. Enter search keywords: "
+msgstr "Bu aranabilir bir dizindir. Arama için anahtar sözcükleri girin:"
+
+#: ../LocalizedStringsGtk.cpp:80
+msgid "Choose File"
+msgstr "Dosya Seç"
+
+#: ../LocalizedStringsGtk.cpp:85
+msgid "Choose Files"
+msgstr "Dosyaları Seç"
+
+#: ../LocalizedStringsGtk.cpp:90 ../LocalizedStringsGtk.cpp:95
+msgid "(None)"
+msgstr "(Yok)"
+
+#: ../LocalizedStringsGtk.cpp:100
+msgid "Open Link in New _Window"
+msgstr "Bağlantıyı Yeni _Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:105
+msgid "_Download Linked File"
+msgstr "Bağlı Dosyayı _İndir"
+
+#: ../LocalizedStringsGtk.cpp:110
+msgid "Copy Link Loc_ation"
+msgstr "B_ağlantı Konumunu Kopyala"
+
+#: ../LocalizedStringsGtk.cpp:115
+msgid "Open _Image in New Window"
+msgstr "Resm_i Yeni Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:120
+msgid "Sa_ve Image As"
+msgstr "Resmi Farkl_ı Kaydet"
+
+#: ../LocalizedStringsGtk.cpp:125
+msgid "Cop_y Image"
+msgstr "Resmi Kop_yala"
+
+#: ../LocalizedStringsGtk.cpp:130
+msgid "Copy Image _Address"
+msgstr "Resim _Adresini Kopyala"
+
+#: ../LocalizedStringsGtk.cpp:135
+msgid "Open _Video in New Window"
+msgstr "_Videoyu Yeni Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:140

[webkit-changes] [189795] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ ChangeLog

2015-09-15 Thread carlosgc
Title: [189795] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog








Revision 189795
Author carlo...@webkit.org
Date 2015-09-15 01:10:56 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189662 - [GTK] [l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

Patch by Muhammet Kara  on 2015-09-12

* tr.po: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189794 => 189795)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:10:14 UTC (rev 189794)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:10:56 UTC (rev 189795)
@@ -1,4 +1,4 @@
-2015-09-12  Michael Catanzaro  
+2015-09-12  Muhammet Kara  
 
 [GTK] [l10n] Updated Turkish translation of WebKitGTK+
 https://bugs.webkit.org/show_bug.cgi?id=148362






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189786] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189786] releases/WebKitGTK/webkit-2.10








Revision 189786
Author carlo...@webkit.org
Date 2015-09-15 00:33:13 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189546 - fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages
https://bugs.webkit.org/show_bug.cgi?id=148951

Reviewed by Anders Carlsson.

Source/WebKit2:

* Platform/IPC/Connection.cpp:
(IPC::Connection::waitForMessage): Don't modify m_waitingForMessage without holding
a lock. This is not part of this fix, but seems necessary for correctness.
(IPC::Connection::processIncomingMessage): Don't interrupt a wait that has already succeeded.

LayoutTests:

* platform/mac-wk2/TestExpectations: Unmark the test (it still fails per platform/mac
expectations, which is unrelated).

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/Platform/IPC/Connection.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189785 => 189786)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:28:57 UTC (rev 189785)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:33:13 UTC (rev 189786)
@@ -1,3 +1,13 @@
+2015-09-09  Alexey Proskuryakov  
+
+fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages
+https://bugs.webkit.org/show_bug.cgi?id=148951
+
+Reviewed by Anders Carlsson.
+
+* platform/mac-wk2/TestExpectations: Unmark the test (it still fails per platform/mac
+expectations, which is unrelated).
+
 2015-09-09  David Hyatt  
 
 REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present


Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (189785 => 189786)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 07:28:57 UTC (rev 189785)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 07:33:13 UTC (rev 189786)
@@ -1,3 +1,15 @@
+2015-09-09  Alexey Proskuryakov  
+
+fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages
+https://bugs.webkit.org/show_bug.cgi?id=148951
+
+Reviewed by Anders Carlsson.
+
+* Platform/IPC/Connection.cpp:
+(IPC::Connection::waitForMessage): Don't modify m_waitingForMessage without holding
+a lock. This is not part of this fix, but seems necessary for correctness.
+(IPC::Connection::processIncomingMessage): Don't interrupt a wait that has already succeeded.
+
 2015-09-05  Michael Catanzaro  
 
 Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData


Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/Platform/IPC/Connection.cpp (189785 => 189786)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/Platform/IPC/Connection.cpp	2015-09-15 07:28:57 UTC (rev 189785)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/Platform/IPC/Connection.cpp	2015-09-15 07:33:13 UTC (rev 189786)
@@ -436,12 +436,12 @@
 // Now we wait.
 bool didTimeout = !m_waitForMessageCondition.waitUntil(lock, absoluteTimeout);
 // We timed out, lost our connection, or a sync message came in with InterruptWaitingIfSyncMessageArrives, so stop waiting.
-if (didTimeout || m_waitingForMessage->messageWaitingInterrupted)
+if (didTimeout || m_waitingForMessage->messageWaitingInterrupted) {
+m_waitingForMessage = nullptr;
 break;
+}
 }
 
-m_waitingForMessage = nullptr;
-
 return nullptr;
 }
 
@@ -689,16 +689,18 @@
 {
 std::lock_guard lock(m_waitForMessageMutex);
 
-if (m_waitingForMessage && m_waitingForMessage->messageReceiverName == message->messageReceiverName() && m_waitingForMessage->messageName == message->messageName() && m_waitingForMessage->destinationID == message->destinationID()) {
-m_waitingForMessage->decoder = WTF::move(message);
-ASSERT(m_waitingForMessage->decoder);
-m_waitForMessageCondition.notifyOne();
-return;
-}
+if (m_waitingForMessage && !m_waitingForMessage->decoder) {
+if (m_waitingForMessage->messageReceiverName == message->messageReceiverName() && m_waitingForMessage->messageName == message->messageName() && m_waitingForMessage->destinationID == message->destinationID()) {
+m_waitingForMessage->decoder = WTF::move(message);
+ASSERT(m_waitingForMessage->decoder);
+m_waitForMessageCondition.notifyOne();
+return;
+}
 
-if (m_waitingForMessage && (m_waitingForMessage->waitForMessageFlags & InterruptWaitingIfSyncMessageArrives) && message->isSyncMessage()) {
-m_waitingForMessage->messageWaitingInterrupted = true;
-

[webkit-changes] [189788] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189788] releases/WebKitGTK/webkit-2.10








Revision 189788
Author carlo...@webkit.org
Date 2015-09-15 00:41:31 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189560 - CSS general sibling selectors does not work without CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=148987
rdar://problem/22559860

Patch by Benjamin Poulain  on 2015-09-09
Reviewed by Andreas Kling.

Source/WebCore:

When traversing with the indirect adjacent combinator, SelectorChecker
was not setting the style invalidation flag on the right element.

Tests: fast/css/indirect-adjacent-style-invalidation-1.html
   fast/css/indirect-adjacent-style-invalidation-2.html
   fast/css/indirect-adjacent-style-invalidation-3.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):

LayoutTests:

There are multiple variations of the same tests to test
cases where we JIT and cases without JIT.

* fast/css/indirect-adjacent-style-invalidation-1-expected.txt: Added.
* fast/css/indirect-adjacent-style-invalidation-1.html: Added.
* fast/css/indirect-adjacent-style-invalidation-2-expected.txt: Added.
* fast/css/indirect-adjacent-style-invalidation-2.html: Added.
* fast/css/indirect-adjacent-style-invalidation-3-expected.txt: Added.
* fast/css/indirect-adjacent-style-invalidation-3.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/css/SelectorChecker.cpp


Added Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-1-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-1.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-2-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-2.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-3-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-3.html




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189787 => 189788)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:38:08 UTC (rev 189787)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:41:31 UTC (rev 189788)
@@ -1,3 +1,21 @@
+2015-09-09  Benjamin Poulain  
+
+CSS general sibling selectors does not work without CSS JIT
+https://bugs.webkit.org/show_bug.cgi?id=148987
+rdar://problem/22559860
+
+Reviewed by Andreas Kling.
+
+There are multiple variations of the same tests to test
+cases where we JIT and cases without JIT. 
+
+* fast/css/indirect-adjacent-style-invalidation-1-expected.txt: Added.
+* fast/css/indirect-adjacent-style-invalidation-1.html: Added.
+* fast/css/indirect-adjacent-style-invalidation-2-expected.txt: Added.
+* fast/css/indirect-adjacent-style-invalidation-2.html: Added.
+* fast/css/indirect-adjacent-style-invalidation-3-expected.txt: Added.
+* fast/css/indirect-adjacent-style-invalidation-3.html: Added.
+
 2015-09-09  Alexey Proskuryakov  
 
 fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages


Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-1-expected.txt (0 => 189788)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-1-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/indirect-adjacent-style-invalidation-1-expected.txt	2015-09-15 07:41:31 UTC (rev 189788)
@@ -0,0 +1,35 @@
+Test the style invalidation of elements affected by an indirect adjacent.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll(".activator")[0]) is false
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll(".activator")[1]) is false
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll("target")[0]) is false
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll("target")[1]) is false
+PASS getComputedStyle(document.querySelectorAll("target")[0]).color is "rgb(0, 0, 0)"
+PASS getComputedStyle(document.querySelectorAll("target")[1]).color is "rgb(0, 0, 0)"
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll(".activator")[0]) is true
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll(".activator")[1]) is true
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll("target")[0]) is false
+PASS window.internals.nodeNeedsStyleRecalc(document.querySelectorAll("target")[1]) is false
+PASS 

[webkit-changes] [189792] releases/WebKitGTK/webkit-2.10/Source/WebKit2

2015-09-15 Thread carlosgc
Title: [189792] releases/WebKitGTK/webkit-2.10/Source/WebKit2








Revision 189792
Author carlo...@webkit.org
Date 2015-09-15 00:59:43 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189587 - sendProcessWillSuspendImminently uses a wrong message flag
https://bugs.webkit.org/show_bug.cgi?id=148995

Reviewed by Alexey Proskuryakov.

Remove use of flag IPC::InterruptWaitingIfSyncMessageArrives as it does not make
sense when sending a sync message.

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendProcessWillSuspendImminently):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebProcessProxy.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (189791 => 189792)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 07:56:02 UTC (rev 189791)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 07:59:43 UTC (rev 189792)
@@ -1,3 +1,18 @@
+2015-09-10  Daniel Bates  
+
+sendProcessWillSuspendImminently uses a wrong message flag
+https://bugs.webkit.org/show_bug.cgi?id=148995
+
+Reviewed by Alexey Proskuryakov.
+
+Remove use of flag IPC::InterruptWaitingIfSyncMessageArrives as it does not make
+sense when sending a sync message.
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::sendProcessWillSuspendImminently):
+
 2015-09-09  Alexey Proskuryakov  
 
 fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages


Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp (189791 => 189792)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp	2015-09-15 07:56:02 UTC (rev 189791)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp	2015-09-15 07:59:43 UTC (rev 189792)
@@ -335,8 +335,7 @@
 return;
 
 bool handled = false;
-sendSync(Messages::NetworkProcess::ProcessWillSuspendImminently(), Messages::NetworkProcess::ProcessWillSuspendImminently::Reply(handled),
-0, std::chrono::seconds(1), IPC::InterruptWaitingIfSyncMessageArrives);
+sendSync(Messages::NetworkProcess::ProcessWillSuspendImminently(), Messages::NetworkProcess::ProcessWillSuspendImminently::Reply(handled), 0, std::chrono::seconds(1));
 }
 
 void NetworkProcessProxy::sendPrepareToSuspend()


Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebProcessProxy.cpp (189791 => 189792)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2015-09-15 07:56:02 UTC (rev 189791)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2015-09-15 07:59:43 UTC (rev 189792)
@@ -893,8 +893,7 @@
 return;
 
 bool handled = false;
-sendSync(Messages::WebProcess::ProcessWillSuspendImminently(), Messages::WebProcess::ProcessWillSuspendImminently::Reply(handled),
-0, std::chrono::seconds(1), IPC::InterruptWaitingIfSyncMessageArrives);
+sendSync(Messages::WebProcess::ProcessWillSuspendImminently(), Messages::WebProcess::ProcessWillSuspendImminently::Reply(handled), 0, std::chrono::seconds(1));
 }
 
 void WebProcessProxy::sendPrepareToSuspend()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189791] releases/WebKitGTK/webkit-2.10/Source/WebCore

2015-09-15 Thread carlosgc
Title: [189791] releases/WebKitGTK/webkit-2.10/Source/WebCore








Revision 189791
Author carlo...@webkit.org
Date 2015-09-15 00:56:02 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189581 - [WebGL][GLES] bad shaders should not be linked not only for GL but also for GL ES
https://bugs.webkit.org/show_bug.cgi?id=148794

Patch by Jinyoung Hur  on 2015-09-10
Reviewed by Dean Jackson.

Checking bad shaders, precision matching and varyings packing are all valid for GL ES too.

Test: webgl/1.0.2/conformance/programs/program-test.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::linkProgram):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189790 => 189791)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:54:47 UTC (rev 189790)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:56:02 UTC (rev 189791)
@@ -1,5 +1,19 @@
 2015-09-10  Jinyoung Hur  
 
+[WebGL][GLES] bad shaders should not be linked not only for GL but also for GL ES
+https://bugs.webkit.org/show_bug.cgi?id=148794
+
+Reviewed by Dean Jackson.
+
+Checking bad shaders, precision matching and varyings packing are all valid for GL ES too.
+
+Test: webgl/1.0.2/conformance/programs/program-test.html
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::linkProgram):
+
+2015-09-10  Jinyoung Hur  
+
 Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition
 https://bugs.webkit.org/show_bug.cgi?id=148957
 


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (189790 => 189791)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2015-09-15 07:54:47 UTC (rev 189790)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2015-09-15 07:56:02 UTC (rev 189791)
@@ -2744,13 +2744,11 @@
 UNUSED_PARAM(ec);
 if (isContextLostOrPending() || !validateWebGLObject("linkProgram", program))
 return;
-if (!isGLES2Compliant()) {
-WebGLShader* vertexShader = program->getAttachedShader(GraphicsContext3D::VERTEX_SHADER);
-WebGLShader* fragmentShader = program->getAttachedShader(GraphicsContext3D::FRAGMENT_SHADER);
-if (!vertexShader || !vertexShader->isValid() || !fragmentShader || !fragmentShader->isValid() || !m_context->precisionsMatch(objectOrZero(vertexShader), objectOrZero(fragmentShader)) || !m_context->checkVaryingsPacking(objectOrZero(vertexShader), objectOrZero(fragmentShader))) {
-program->setLinkStatus(false);
-return;
-}
+WebGLShader* vertexShader = program->getAttachedShader(GraphicsContext3D::VERTEX_SHADER);
+WebGLShader* fragmentShader = program->getAttachedShader(GraphicsContext3D::FRAGMENT_SHADER);
+if (!vertexShader || !vertexShader->isValid() || !fragmentShader || !fragmentShader->isValid() || !m_context->precisionsMatch(objectOrZero(vertexShader), objectOrZero(fragmentShader)) || !m_context->checkVaryingsPacking(objectOrZero(vertexShader), objectOrZero(fragmentShader))) {
+program->setLinkStatus(false);
+return;
 }
 
 m_context->linkProgram(objectOrZero(program));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189781] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189781] releases/WebKitGTK/webkit-2.10








Revision 189781
Author carlo...@webkit.org
Date 2015-09-14 23:59:24 -0700 (Mon, 14 Sep 2015)


Log Message
Merge r189469 - ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
association after subtree insertion
https://bugs.webkit.org/show_bug.cgi?id=148919


Patch by Daniel Bates  on 2015-09-07
Reviewed by Andy Estes.

Source/WebCore:

Currently we update the form association of a form control upon insertion into
the document. Instead we should update the form association of a form control
after its containing subtree is inserted into the document to avoid an assertion
failure when the containing subtree has an element whose id is identical to both
the id of some other element in the document and the name of the form referenced
by the inserted form control.

Tests: fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html
   fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html
   fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html
   fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto): Moved resetFormOwner() from here
to {HTMLFormControlElement, HTMLObjectElement}::finishedInsertingSubtree().
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree
so that HTMLFormControlElement::finishedInsertingSubtree() is called.
(WebCore::HTMLFormControlElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLInputElement::finishedInsertingSubtree() is called and move logic to update radio button
group from here...
(WebCore::HTMLInputElement::finishedInsertingSubtree): to here.
* html/HTMLInputElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLObjectElement::finishedInsertingSubtree() is called.
(WebCore::HTMLObjectElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().
* html/HTMLObjectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto): Modified to return the result of
HTMLFormControlElementWithState::insertedInto(), which may schedule a callback after subtree
insertion.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto): Ditto.

LayoutTests:

Add tests to ensure that updating the form association of a form control in a subtree
does not cause an assertion failure.

* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/FormAssociatedElement.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLFormControlElement.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLFormControlElement.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLInputElement.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLInputElement.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLObjectElement.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLObjectElement.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLTextFormControlElement.cpp


Added Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4-expected.txt

[webkit-changes] [189793] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189793] releases/WebKitGTK/webkit-2.10








Revision 189793
Author carlo...@webkit.org
Date 2015-09-15 01:07:01 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189594 - [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
https://bugs.webkit.org/show_bug.cgi?id=149042

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/block/inside-inlines/

* rendering/InlineFlowBox.cpp:
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::anonymousInlineBlock):
Add a new accessor to get the anonymousInlineBlock() for lines that wrap them.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childrenPreventSelfCollapsing):
(WebCore::RenderBlock::isSelfCollapsingBlock):
isSelfCollapsingBlock() now calls a virtual method that checks lines/children called childrenPreventSelfCollapsing.
This lets us farm out the lines check to the derived RenderBlockFlow class.

* rendering/RenderBlock.h:
(WebCore::RenderBlock::childrenPreventSelfCollapsing):
Added new virtual method for checking children.

* rendering/RenderBlockFlow.cpp:
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing):
Overridden to ensure that blocks can still be self-collapsing if they only contain anonymous inline-block lines that
are also self-collapsing.

LayoutTests:

* fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Added.
* fast/block/inside-inlines/new-model/self-collapsing-test.html: Added.
* fast/block/inside-inlines/self-collapsing-test-expected.html: Added.
* fast/block/inside-inlines/self-collapsing-test.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/InlineFlowBox.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/InlineFlowBox.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlockFlow.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlockFlow.h


Added Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test-expected.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/self-collapsing-test-expected.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/self-collapsing-test.html




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189792 => 189793)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:59:43 UTC (rev 189792)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 08:07:01 UTC (rev 189793)
@@ -1,3 +1,15 @@
+2015-09-10  David Hyatt  
+
+[New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
+https://bugs.webkit.org/show_bug.cgi?id=149042
+
+Reviewed by Dean Jackson.
+
+* fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Added.
+* fast/block/inside-inlines/new-model/self-collapsing-test.html: Added.
+* fast/block/inside-inlines/self-collapsing-test-expected.html: Added.
+* fast/block/inside-inlines/self-collapsing-test.html: Added.
+
 2015-09-10  ChangSeok Oh  
 
 [GTK] Volume bar is broken


Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test-expected.html (0 => 189793)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test-expected.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test-expected.html	2015-09-15 08:07:01 UTC (rev 189793)
@@ -0,0 +1,13 @@
+
+
+
+.margin { margin:20px 0 }
+p { margin:0 }
+span { clear:left; float:left; width:20px; height:20px; background-color:green }
+
+
+The two green floats should be stacked right on top of one another.
+
+
+
+
\ No newline at end of file


Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test.html (0 => 189793)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/inside-inlines/new-model/self-collapsing-test.html	2015-09-15 08:07:01 UTC (rev 189793)
@@ -0,0 +1,20 @@
+
+
+
+.margin { margin:20px 0 }
+p { margin:0 }
+span { float:left; width:20px; height:20px; background-color:green }
+
+
+if (window.internals)
+window.internals.settings.setNewBlockInsideInlineModelEnabled(true)
+
+
+The two green floats should be stacked 

[webkit-changes] [189777] trunk/LayoutTests

2015-09-15 Thread gyuyoung . kim
Title: [189777] trunk/LayoutTests








Revision 189777
Author gyuyoung@webkit.org
Date 2015-09-14 23:25:23 -0700 (Mon, 14 Sep 2015)


Log Message
Unreviewed, EFL gardening on 15th Sep.

Mark tests of css1/box_properties to flaky and tests of editing, fast are set to timeout.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189776 => 189777)

--- trunk/LayoutTests/ChangeLog	2015-09-15 06:00:54 UTC (rev 189776)
+++ trunk/LayoutTests/ChangeLog	2015-09-15 06:25:23 UTC (rev 189777)
@@ -1,3 +1,11 @@
+2015-09-14  Gyuyoung Kim  
+
+Unreviewed, EFL gardening on 15th Sep.
+
+Mark tests of css1/box_properties to flaky and tests of editing, fast are set to timeout.
+
+* platform/efl/TestExpectations:
+
 2015-09-14  Alexey Proskuryakov  
 
 fast/events/frame-scroll-fake-mouse-move.html is flaky


Modified: trunk/LayoutTests/platform/efl/TestExpectations (189776 => 189777)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-09-15 06:00:54 UTC (rev 189776)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-09-15 06:25:23 UTC (rev 189777)
@@ -1036,6 +1036,38 @@
 webkit.org/b/146495 js/dom/create-lots-of-workers.html [ Crash Timeout Pass Failure ]
 webkit.org/b/146495 svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg [ Timeout Pass ]
 
+# box properties tests have been flaky since r188693.
+webkit.org/b/148470 css1/box_properties/border.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_bottom.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_bottom_width.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_left.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_left_width.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_right_inline.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_right_width.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_style.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_top.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_top_width.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/border_width.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/clear.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/clear_float.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/float_elements_in_series.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/float_margin.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/float_on_text_elements.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/height.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin_bottom.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin_inline.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin_left.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin_right.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/margin_top.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding_bottom.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding_inline.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding_left.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding_right.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/padding_top.html [ Failure ImageOnlyFailure Pass ]
+webkit.org/b/148470 css1/box_properties/width.html [ Failure ImageOnlyFailure Pass ]
+
 #
 # PASSING TESTS WITH INCORRECT EXPECTATIONS
 #
@@ -2540,3 +2572,22 @@
 fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
 
 webkit.org/b/149128 fast/text/control-characters [ ImageOnlyFailure ]
+
+# Below tests have been timeout since r188693.
+webkit.org/b/148470 editing/spelling/design-mode-spellcheck-off.html [ Timeout ]
+webkit.org/b/148470 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Timeout ]

[webkit-changes] [189785] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189785] releases/WebKitGTK/webkit-2.10








Revision 189785
Author carlo...@webkit.org
Date 2015-09-15 00:28:57 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189540 - REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
https://bugs.webkit.org/show_bug.cgi?id=147452
rdar://problem/21943074

Reviewed by Myles Maxfield.

Source/WebCore:

Added new test in fast/inline-block

Treat zero width replaced elements the same as replaced elements with width. Instead of
clearing floats based off having no committed width, we instead track both committed
width and committed replaced objects. We do this with two new booleans in LineWidth
so that we know when we have uncomitted and committed replaced objects.

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* rendering/line/LineWidth.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):
* rendering/line/LineWidth.h:
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::logicalLeftOffset):
(WebCore::LineWidth::hasCommitted):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::addUncommittedReplacedWidth):

LayoutTests:

* fast/inline-block/baseline-with-zero-width-replaced-child-expected.html: Added.
* fast/inline-block/baseline-with-zero-width-replaced-child.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/line/BreakingContext.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/line/LineWidth.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/line/LineWidth.h


Added Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child-expected.html
releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child.html




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189784 => 189785)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:25:44 UTC (rev 189784)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:28:57 UTC (rev 189785)
@@ -1,3 +1,14 @@
+2015-09-09  David Hyatt  
+
+REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
+https://bugs.webkit.org/show_bug.cgi?id=147452
+rdar://problem/21943074
+
+Reviewed by Myles Maxfield.
+
+* fast/inline-block/baseline-with-zero-width-replaced-child-expected.html: Added.
+* fast/inline-block/baseline-with-zero-width-replaced-child.html: Added.
+
 2015-09-08  Chris Dumez  
 
 document.importNode(node, deep): deep's default value should be false


Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child-expected.html (0 => 189785)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child-expected.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child-expected.html	2015-09-15 07:28:57 UTC (rev 189785)
@@ -0,0 +1,9 @@
+
+
+
+
+
+The green block should align nicely with the text.
+
+
+


Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child.html (0 => 189785)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/inline-block/baseline-with-zero-width-replaced-child.html	2015-09-15 07:28:57 UTC (rev 189785)
@@ -0,0 +1,9 @@
+
+
+
+
+
+The green block should align nicely with the text.
+
+
+


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189784 => 189785)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:25:44 UTC (rev 189784)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:28:57 UTC (rev 189785)
@@ -1,3 +1,35 @@
+2015-09-08  David Hyatt  
+
+REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
+https://bugs.webkit.org/show_bug.cgi?id=147452
+rdar://problem/21943074
+
+Reviewed by Myles Maxfield.
+
+Added new test in fast/inline-block
+
+Treat zero width replaced elements the same as replaced elements with width. Instead of
+clearing floats based off having no committed width, we instead track both committed
+width and committed replaced objects. We do this with two new booleans in LineWidth
+so that we know when we have 

[webkit-changes] [189790] releases/WebKitGTK/webkit-2.10/Source/WebCore

2015-09-15 Thread carlosgc
Title: [189790] releases/WebKitGTK/webkit-2.10/Source/WebCore








Revision 189790
Author carlo...@webkit.org
Date 2015-09-15 00:54:47 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189580 - Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition
https://bugs.webkit.org/show_bug.cgi?id=148957

Patch by Jinyoung Hur  on 2015-09-10
Reviewed by Dean Jackson.

There is no guarantee that only one thread calls GraphicsContext3D::compileShader() at a time so it would be
better to use a thread local storage variable rather than use a static variable.

No new tests. No behavioural changes.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::getCurrentNameHashMapForShader):
(WebCore::setCurrentNameHashMapForShader):
(WebCore::nameHashForShader):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189789 => 189790)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:52:30 UTC (rev 189789)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:54:47 UTC (rev 189790)
@@ -1,3 +1,22 @@
+2015-09-10  Jinyoung Hur  
+
+Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition
+https://bugs.webkit.org/show_bug.cgi?id=148957
+
+Reviewed by Dean Jackson.
+
+There is no guarantee that only one thread calls GraphicsContext3D::compileShader() at a time so it would be 
+better to use a thread local storage variable rather than use a static variable.
+
+No new tests. No behavioural changes.
+
+* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+(WebCore::getCurrentNameHashMapForShader):
+(WebCore::setCurrentNameHashMapForShader):
+(WebCore::nameHashForShader):
+(WebCore::GraphicsContext3D::compileShader):
+(WebCore::GraphicsContext3D::mappedSymbolName):
+
 2015-09-10  ChangSeok Oh  
 
 [GTK] Volume bar is broken


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp (189789 => 189790)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2015-09-15 07:52:30 UTC (rev 189789)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2015-09-15 07:54:47 UTC (rev 189790)
@@ -79,8 +79,22 @@
 
 namespace WebCore {
 
-static ShaderNameHash* currentNameHashMapForShader = nullptr;
+static ThreadSpecific& getCurrentNameHashMapForShader()
+{
+static std::once_flag onceFlag;
+static ThreadSpecific* sharedNameHash;
+std::call_once(onceFlag, [] {
+sharedNameHash = new ThreadSpecific;
+});
 
+return *sharedNameHash;
+}
+
+static void setCurrentNameHashMapForShader(ShaderNameHash* shaderNameHash)
+{
+*getCurrentNameHashMapForShader() = shaderNameHash;
+}
+
 // Hash function used by the ANGLE translator/compiler to do
 // symbol name mangling. Since this is a static method, before
 // calling compileShader we set currentNameHashMapForShader
@@ -94,11 +108,10 @@
 CString nameAsCString = CString(name);
 
 // Look up name in our local map.
-if (currentNameHashMapForShader) {
-ShaderNameHash::iterator result = currentNameHashMapForShader->find(nameAsCString);
-if (result != currentNameHashMapForShader->end())
-return result->value;
-}
+ShaderNameHash*& currentNameHashMapForShader = *getCurrentNameHashMapForShader();
+ShaderNameHash::iterator findResult = currentNameHashMapForShader->find(nameAsCString);
+if (findResult != currentNameHashMapForShader->end())
+return findResult->value;
 
 unsigned hashValue = nameAsCString.hash();
 
@@ -569,14 +582,14 @@
 
 if (!nameHashMapForShaders)
 nameHashMapForShaders = std::make_unique();
-currentNameHashMapForShader = nameHashMapForShaders.get();
+setCurrentNameHashMapForShader(nameHashMapForShaders.get());
 m_compiler.setResources(ANGLEResources);
 
 String translatedShaderSource = m_extensions->getTranslatedShaderSourceANGLE(shader);
 
 ANGLEResources.HashFunction = previousHashFunction;
 m_compiler.setResources(ANGLEResources);
-currentNameHashMapForShader = nullptr;
+setCurrentNameHashMapForShader(nullptr);
 
 if (!translatedShaderSource.length())
 return;
@@ -878,11 +891,11 @@
 // and aren't even required to be used in any shader program.
 if (!nameHashMapForShaders)
 nameHashMapForShaders = 

[webkit-changes] [189776] trunk/Source/WebCore

2015-09-15 Thread gyuyoung . kim
Title: [189776] trunk/Source/WebCore








Revision 189776
Author gyuyoung@webkit.org
Date 2015-09-14 23:00:54 -0700 (Mon, 14 Sep 2015)


Log Message
Remove all uses of PassRefPtr in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=149114

Reviewed by Darin Adler.

* dom/DecodedDataDocumentParser.h:
* dom/DocumentParser.h:
* dom/RawDataDocumentParser.h:
* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::append):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::append):
* html/parser/HTMLDocumentParser.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::append):
* html/parser/TextDocumentParser.h:
* xml/NativeXPathNSResolver.cpp:
(WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
* xml/NativeXPathNSResolver.h:
(WebCore::NativeXPathNSResolver::create):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
* xml/XMLHttpRequestProgressEventThrottle.h:
* xml/XMLSerializer.h:
* xml/XPathEvaluator.cpp:
(WebCore::XPathEvaluator::createExpression):
(WebCore::XPathEvaluator::createNSResolver):
(WebCore::XPathEvaluator::evaluate):
* xml/XPathEvaluator.h:
* xml/XPathNodeSet.h: Fix style errors.
(WebCore::XPath::NodeSet::NodeSet):
(WebCore::XPath::NodeSet::append):
* xml/XPathPath.cpp:
(WebCore::XPath::Filter::evaluate):
(WebCore::XPath::LocationPath::evaluate):
* xml/XPathValue.h: ditto.
(WebCore::XPath::Value::Value):
(WebCore::XPath::Value::Data::create):
(WebCore::XPath::Value::Data::Data):
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::setXSLStyleSheet):
(WebCore::XSLTProcessor::importStylesheet):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
* xml/parser/XMLDocumentParser.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DecodedDataDocumentParser.h
trunk/Source/WebCore/dom/DocumentParser.h
trunk/Source/WebCore/dom/RawDataDocumentParser.h
trunk/Source/WebCore/html/FTPDirectoryDocument.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h
trunk/Source/WebCore/html/parser/TextDocumentParser.cpp
trunk/Source/WebCore/html/parser/TextDocumentParser.h
trunk/Source/WebCore/xml/NativeXPathNSResolver.cpp
trunk/Source/WebCore/xml/NativeXPathNSResolver.h
trunk/Source/WebCore/xml/XMLErrors.cpp
trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp
trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h
trunk/Source/WebCore/xml/XMLSerializer.h
trunk/Source/WebCore/xml/XPathEvaluator.cpp
trunk/Source/WebCore/xml/XPathEvaluator.h
trunk/Source/WebCore/xml/XPathNodeSet.h
trunk/Source/WebCore/xml/XPathPath.cpp
trunk/Source/WebCore/xml/XPathValue.h
trunk/Source/WebCore/xml/XSLTProcessor.cpp
trunk/Source/WebCore/xml/XSLTProcessor.h
trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189775 => 189776)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 04:05:10 UTC (rev 189775)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 06:00:54 UTC (rev 189776)
@@ -1,3 +1,58 @@
+2015-09-14  Gyuyoung Kim  
+
+Remove all uses of PassRefPtr in WebCore/xml
+https://bugs.webkit.org/show_bug.cgi?id=149114
+
+Reviewed by Darin Adler.
+
+* dom/DecodedDataDocumentParser.h:
+* dom/DocumentParser.h:
+* dom/RawDataDocumentParser.h:
+* html/FTPDirectoryDocument.cpp:
+(WebCore::FTPDirectoryDocumentParser::append):
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::append):
+* html/parser/HTMLDocumentParser.h:
+* html/parser/TextDocumentParser.cpp:
+(WebCore::TextDocumentParser::append):
+* html/parser/TextDocumentParser.h:
+* xml/NativeXPathNSResolver.cpp:
+(WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
+* xml/NativeXPathNSResolver.h:
+(WebCore::NativeXPathNSResolver::create):
+* xml/XMLErrors.cpp:
+(WebCore::createXHTMLParserErrorHeader):
+* xml/XMLHttpRequestProgressEventThrottle.cpp:
+(WebCore::XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent):
+(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
+(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
+* xml/XMLHttpRequestProgressEventThrottle.h:
+* xml/XMLSerializer.h:
+* xml/XPathEvaluator.cpp:
+(WebCore::XPathEvaluator::createExpression):
+(WebCore::XPathEvaluator::createNSResolver):
+

[webkit-changes] [189779] releases/WebKitGTK/webkit-2.10/Source/WebKit2

2015-09-15 Thread carlosgc
Title: [189779] releases/WebKitGTK/webkit-2.10/Source/WebKit2








Revision 189779
Author carlo...@webkit.org
Date 2015-09-14 23:48:02 -0700 (Mon, 14 Sep 2015)


Log Message
Merge r189442 - Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
https://bugs.webkit.org/show_bug.cgi?id=148769

Fix suggested by Zan Dobersek.

Reviewed by Darin Adler.

* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (189778 => 189779)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 06:46:48 UTC (rev 189778)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-09-15 06:48:02 UTC (rev 189779)
@@ -1,3 +1,15 @@
+2015-09-05  Michael Catanzaro  
+
+Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
+https://bugs.webkit.org/show_bug.cgi?id=148769
+
+Fix suggested by Zan Dobersek.
+
+Reviewed by Darin Adler.
+
+* UIProcess/WebContextInjectedBundleClient.cpp:
+(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
+
 2015-08-31  Antti Koivisto  
 
 Network Cache: Stale content after back navigation


Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp (189778 => 189779)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp	2015-09-15 06:46:48 UTC (rev 189778)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp	2015-09-15 06:48:02 UTC (rev 189779)
@@ -57,7 +57,7 @@
 if (!m_client.getInjectedBundleInitializationUserData)
 return 0;
 
-return toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo));
+return adoptRef(toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo)));
 }
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189784] releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

2015-09-15 Thread carlosgc
Title: [189784] releases/WebKitGTK/webkit-2.10/Source/_javascript_Core








Revision 189784
Author carlo...@webkit.org
Date 2015-09-15 00:25:44 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189531 - [JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
https://bugs.webkit.org/show_bug.cgi?id=148414

Patch by Benjamin Poulain  on 2015-09-08
Reviewed by Mark Lam.

LivenessAnalysisPhase still causes a huge number of cache miss.
This patch reduces the amount of accesses needed by the HashTables.

* dfg/DFGBasicBlock.h:
* dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGBasicBlock.h
releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGLivenessAnalysisPhase.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog (189783 => 189784)

--- releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog	2015-09-15 07:20:22 UTC (rev 189783)
+++ releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/ChangeLog	2015-09-15 07:25:44 UTC (rev 189784)
@@ -1,3 +1,18 @@
+2015-09-08  Benjamin Poulain  
+
+[JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
+https://bugs.webkit.org/show_bug.cgi?id=148414
+
+Reviewed by Mark Lam.
+
+LivenessAnalysisPhase still causes a huge number of cache miss.
+This patch reduces the amount of accesses needed by the HashTables.
+
+* dfg/DFGBasicBlock.h:
+* dfg/DFGLivenessAnalysisPhase.cpp:
+(JSC::DFG::LivenessAnalysisPhase::run):
+(JSC::DFG::LivenessAnalysisPhase::process):
+
 2015-08-31  Chris Dumez  
 
 NodeFilter.SHOW_ALL has wrong value on 32-bit


Modified: releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGBasicBlock.h (189783 => 189784)

--- releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGBasicBlock.h	2015-09-15 07:20:22 UTC (rev 189783)
+++ releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGBasicBlock.h	2015-09-15 07:25:44 UTC (rev 189784)
@@ -242,8 +242,9 @@
 AvailabilityMap availabilityAtHead;
 AvailabilityMap availabilityAtTail;
 
+bool liveAtTailIsDirty { false };
+HashSet liveAtTail;
 HashSet liveAtHead;
-HashSet liveAtTail;
 HashMap valuesAtHead;
 HashMap valuesAtTail;
 


Modified: releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGLivenessAnalysisPhase.cpp (189783 => 189784)

--- releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGLivenessAnalysisPhase.cpp	2015-09-15 07:20:22 UTC (rev 189783)
+++ releases/WebKitGTK/webkit-2.10/Source/_javascript_Core/dfg/DFGLivenessAnalysisPhase.cpp	2015-09-15 07:25:44 UTC (rev 189784)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2015 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -57,6 +57,7 @@
 BasicBlock* block = m_graph.block(blockIndex);
 if (!block)
 continue;
+block->ssa->liveAtTailIsDirty = true;
 block->ssa->liveAtHead.clear();
 block->ssa->liveAtTail.clear();
 }
@@ -85,8 +86,11 @@
 if (!block)
 return;
 
+if (!block->ssa->liveAtTailIsDirty)
+return;
+block->ssa->liveAtTailIsDirty = false;
+
 m_live = block->ssa->liveAtTail;
-
 for (unsigned nodeIndex = block->size(); nodeIndex--;) {
 Node* node = block->at(nodeIndex);
 
@@ -128,12 +132,16 @@
 }
 }
 
-if (m_live == block->ssa->liveAtHead)
-return;
-
-m_changed = true;
-for (unsigned i = block->predecessors.size(); i--;)
-block->predecessors[i]->ssa->liveAtTail.add(m_live.begin(), m_live.end());
+for (Node* node : m_live) {
+if (!block->ssa->liveAtHead.contains(node)) {
+m_changed = true;
+for (unsigned i = block->predecessors.size(); i--;) {
+BasicBlock* predecessor = block->predecessors[i];
+if (predecessor->ssa->liveAtTail.add(node).isNewEntry)
+predecessor->ssa->liveAtTailIsDirty = true;
+}
+}
+}
 block->ssa->liveAtHead = WTF::move(m_live);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189787] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189787] releases/WebKitGTK/webkit-2.10








Revision 189787
Author carlo...@webkit.org
Date 2015-09-15 00:38:08 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189555 - Setting document.title when there is no title and no head element should no nothing
https://bugs.webkit.org/show_bug.cgi?id=149005


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline tests now that more checks are passing.

* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Setting document.title when there is no title element and no head
element should no nothing:
- https://html.spec.whatwg.org/multipage/dom.html#document.title

Firefox and Chrome comply with the specification. However, WebKit
was returning the updated title when querying document.title after
setting it.

No new tests, covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::setTitle):

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog (189786 => 189787)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 07:33:13 UTC (rev 189786)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 07:38:08 UTC (rev 189787)
@@ -1,3 +1,16 @@
+2015-09-09  Chris Dumez  
+
+Setting document.title when there is no title and no head element should no nothing
+https://bugs.webkit.org/show_bug.cgi?id=149005
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline tests now that more checks are passing.
+
+* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
+* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:
+
 2015-09-08  Chris Dumez  
 
 document.importNode(node, deep): deep's default value should be false


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189786 => 189787)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:33:13 UTC (rev 189786)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:38:08 UTC (rev 189787)
@@ -1,3 +1,24 @@
+2015-09-09  Chris Dumez  
+
+Setting document.title when there is no title and no head element should no nothing
+https://bugs.webkit.org/show_bug.cgi?id=149005
+
+
+Reviewed by Ryosuke Niwa.
+
+Setting document.title when there is no title element and no head
+element should no nothing:
+- https://html.spec.whatwg.org/multipage/dom.html#document.title
+
+Firefox and Chrome comply with the specification. However, WebKit
+was returning the updated title when querying document.title after
+setting it.
+
+No new tests, covered by existing tests.
+
+* dom/Document.cpp:
+(WebCore::Document::setTitle):
+
 2015-09-08  David Hyatt  
 
 REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp (189786 => 189787)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp	2015-09-15 07:33:13 UTC (rev 189786)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp	2015-09-15 07:38:08 UTC (rev 189787)
@@ -1533,10 +1533,11 @@
 if (!isHTMLDocument() && !isXHTMLDocument())
 m_titleElement = nullptr;
 else if (!m_titleElement) {
-if (HTMLElement* headElement = head()) {
-m_titleElement = createElement(titleTag, false);
-headElement->appendChild(m_titleElement, ASSERT_NO_EXCEPTION);
-}
+auto* headElement = head();
+if (!headElement)
+return;
+m_titleElement = createElement(titleTag, false);
+headElement->appendChild(m_titleElement, ASSERT_NO_EXCEPTION);
 }
 
 // The DOM API has no method of specifying direction, so assume LTR.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189789] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189789] releases/WebKitGTK/webkit-2.10








Revision 189789
Author carlo...@webkit.org
Date 2015-09-15 00:52:30 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189566 - [GTK] Volume bar is broken
https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html
   media/volume-bar-empty-when-muted.html

* platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

* platform/gtk/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/ThemeTypes.h




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189788 => 189789)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:41:31 UTC (rev 189788)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 07:52:30 UTC (rev 189789)
@@ -1,3 +1,14 @@
+2015-09-10  ChangSeok Oh  
+
+[GTK] Volume bar is broken
+https://bugs.webkit.org/show_bug.cgi?id=145639
+
+Reviewed by Philippe Normand.
+
+Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
+
+* platform/gtk/TestExpectations:
+
 2015-09-09  Benjamin Poulain  
 
 CSS general sibling selectors does not work without CSS JIT


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/platform/gtk/TestExpectations (189788 => 189789)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/platform/gtk/TestExpectations	2015-09-15 07:41:31 UTC (rev 189788)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/platform/gtk/TestExpectations	2015-09-15 07:52:30 UTC (rev 189789)
@@ -1350,7 +1350,6 @@
 webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
 
 webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
-webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
 webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
 
 webkit.org/b/143477 fast/writing-mode/broken-ideograph-small-caps.html [ Timeout Pass ]
@@ -2199,8 +2198,6 @@
 
 webkit.org/b/132235 fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html [ ImageOnlyFailure ]
 
-webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
-
 webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]
 
 webkit.org/b/132914 http/tests/security/drag-drop-local-file.html [ Failure ]


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189788 => 189789)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:41:31 UTC (rev 189788)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2015-09-15 07:52:30 UTC (rev 189789)
@@ -1,3 +1,18 @@
+2015-09-10  ChangSeok Oh  
+
+[GTK] Volume bar is broken
+https://bugs.webkit.org/show_bug.cgi?id=145639
+
+Reviewed by Philippe Normand.
+
+The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
+after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
+
+Tests: media/click-volume-bar-not-pausing.html
+   media/volume-bar-empty-when-muted.html
+
+* platform/ThemeTypes.h:
+
 2015-09-09  Benjamin Poulain  
 
 CSS general sibling selectors does not work without CSS JIT


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/ThemeTypes.h (189788 => 189789)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/ThemeTypes.h	2015-09-15 07:41:31 UTC (rev 189788)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/ThemeTypes.h	2015-09-15 07:52:30 UTC (rev 189789)
@@ -38,8 +38,8 @@
 MediaFullScreenVolumeSliderThumbPart, MediaMuteButtonPart, MediaOverlayPlayButtonPart,
 MediaPlayButtonPart, MediaReturnToRealtimeButtonPart, MediaRewindButtonPart, MediaSeekBackButtonPart,
 MediaSeekForwardButtonPart, MediaSliderPart, MediaSliderThumbPart, MediaTimeRemainingPart,
-MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderContainerPart, MediaVolumeSliderMuteButtonPart,
-MediaVolumeSliderPart, MediaVolumeSliderThumbPart,
+MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderPart, MediaVolumeSliderContainerPart,
+MediaVolumeSliderMuteButtonPart, MediaVolumeSliderThumbPart,
 MenulistPart, MenulistButtonPart, MenulistTextPart, 

[webkit-changes] [189813] trunk/Source/WebCore

2015-09-15 Thread beidson
Title: [189813] trunk/Source/WebCore








Revision 189813
Author beid...@apple.com
Date 2015-09-15 11:09:29 -0700 (Tue, 15 Sep 2015)


Log Message
Make the IDBAny::Type enum into an enum class.
https://bugs.webkit.org/show_bug.cgi?id=149169.

Reviewed by Oliver Hunt.

No new tests (Cleanup, no behavior change).

* Modules/indexeddb/IDBAny.h:
* Modules/indexeddb/legacy/LegacyAny.cpp:
(WebCore::LegacyAny::createInvalid):
(WebCore::LegacyAny::createNull):
(WebCore::LegacyAny::LegacyAny):
(WebCore::LegacyAny::domStringList):
(WebCore::LegacyAny::idbCursor):
(WebCore::LegacyAny::idbCursorWithValue):
(WebCore::LegacyAny::idbDatabase):
(WebCore::LegacyAny::idbFactory):
(WebCore::LegacyAny::idbIndex):
(WebCore::LegacyAny::idbObjectStore):
(WebCore::LegacyAny::idbTransaction):
(WebCore::LegacyAny::scriptValue):
(WebCore::LegacyAny::string):
(WebCore::LegacyAny::integer):
(WebCore::LegacyAny::legacyCursor):
(WebCore::LegacyAny::legacyCursorWithValue):
(WebCore::LegacyAny::legacyDatabase):
(WebCore::LegacyAny::legacyFactory):
(WebCore::LegacyAny::legacyIndex):
(WebCore::LegacyAny::legacyObjectStore):
(WebCore::LegacyAny::legacyTransaction):
* Modules/indexeddb/legacy/LegacyCursor.cpp:
(WebCore::LegacyCursor::LegacyCursor):
(WebCore::LegacyCursor::effectiveObjectStore):
* Modules/indexeddb/legacy/LegacyObjectStore.cpp:
* Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp:
(WebCore::LegacyOpenDBRequest::dispatchEvent):
* Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::getResultCursor):
(WebCore::effectiveObjectStore):
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
* inspector/InspectorIndexedDBAgent.cpp:
* page/DatabaseProvider.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBAny.h
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyAny.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp
trunk/Source/WebCore/bindings/js/JSIDBAnyCustom.cpp
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
trunk/Source/WebCore/page/DatabaseProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189812 => 189813)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 17:48:58 UTC (rev 189812)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 18:09:29 UTC (rev 189813)
@@ -1,5 +1,51 @@
 2015-09-15  Brady Eidson  
 
+Make the IDBAny::Type enum into an enum class.
+https://bugs.webkit.org/show_bug.cgi?id=149169.
+
+Reviewed by Oliver Hunt.
+
+No new tests (Cleanup, no behavior change).
+
+* Modules/indexeddb/IDBAny.h:
+* Modules/indexeddb/legacy/LegacyAny.cpp:
+(WebCore::LegacyAny::createInvalid):
+(WebCore::LegacyAny::createNull):
+(WebCore::LegacyAny::LegacyAny):
+(WebCore::LegacyAny::domStringList):
+(WebCore::LegacyAny::idbCursor):
+(WebCore::LegacyAny::idbCursorWithValue):
+(WebCore::LegacyAny::idbDatabase):
+(WebCore::LegacyAny::idbFactory):
+(WebCore::LegacyAny::idbIndex):
+(WebCore::LegacyAny::idbObjectStore):
+(WebCore::LegacyAny::idbTransaction):
+(WebCore::LegacyAny::scriptValue):
+(WebCore::LegacyAny::string):
+(WebCore::LegacyAny::integer):
+(WebCore::LegacyAny::legacyCursor):
+(WebCore::LegacyAny::legacyCursorWithValue):
+(WebCore::LegacyAny::legacyDatabase):
+(WebCore::LegacyAny::legacyFactory):
+(WebCore::LegacyAny::legacyIndex):
+(WebCore::LegacyAny::legacyObjectStore):
+(WebCore::LegacyAny::legacyTransaction):
+* Modules/indexeddb/legacy/LegacyCursor.cpp:
+(WebCore::LegacyCursor::LegacyCursor):
+(WebCore::LegacyCursor::effectiveObjectStore):
+* Modules/indexeddb/legacy/LegacyObjectStore.cpp:
+* Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp:
+(WebCore::LegacyOpenDBRequest::dispatchEvent):
+* Modules/indexeddb/legacy/LegacyRequest.cpp:
+(WebCore::LegacyRequest::getResultCursor):
+(WebCore::effectiveObjectStore):
+* bindings/js/JSIDBAnyCustom.cpp:
+(WebCore::toJS):
+* inspector/InspectorIndexedDBAgent.cpp:
+* page/DatabaseProvider.h:
+
+2015-09-15  Brady Eidson  
+
 Move most IDB object encoding/decoding from WebKit2 to WebCore.
 https://bugs.webkit.org/show_bug.cgi?id=149152
 


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBAny.h (189812 => 189813)

--- trunk/Source/WebCore/Modules/indexeddb/IDBAny.h	2015-09-15 17:48:58 UTC (rev 189812)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBAny.h	2015-09-15 18:09:29 UTC (rev 189813)
@@ -52,21 +52,21 @@
 public:
 virtual ~IDBAny() { }
 
-enum Type {
-UndefinedType = 0,
-NullType,
-

[webkit-changes] [189814] trunk/Source/WebInspectorUI

2015-09-15 Thread bburg
Title: [189814] trunk/Source/WebInspectorUI








Revision 189814
Author bb...@apple.com
Date 2015-09-15 11:18:03 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: new tab content view should disallow split console
https://bugs.webkit.org/show_bug.cgi?id=149164

Reviewed by Joseph Pecoraro.

* UserInterface/Views/NewTabContentView.js:
(WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (189813 => 189814)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:09:29 UTC (rev 189813)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:18:03 UTC (rev 189814)
@@ -1,3 +1,13 @@
+2015-09-15  Brian Burg  
+
+Web Inspector: new tab content view should disallow split console
+https://bugs.webkit.org/show_bug.cgi?id=149164
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/NewTabContentView.js:
+(WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):
+
 2015-09-14  Brian Burg  
 
 Web Inspector: tab bar stutters when moving mouse after closing tab


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js (189813 => 189814)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js	2015-09-15 18:09:29 UTC (rev 189813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js	2015-09-15 18:18:03 UTC (rev 189814)
@@ -85,6 +85,13 @@
 WebInspector.tabBrowser.tabBar.removeEventListener(null, null, this);
 }
 
+get supportsSplitContentBrowser()
+{
+// Showing the split console is problematic because some new tabs will cause it to
+// disappear and not reappear, but others won't. Just prevent it from ever showing.
+return false;
+}
+
 // Private
 
 _createNewTab(tabType, event)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189816] trunk/Source/WebInspectorUI

2015-09-15 Thread commit-queue
Title: [189816] trunk/Source/WebInspectorUI








Revision 189816
Author commit-qu...@webkit.org
Date 2015-09-15 11:36:04 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: Watch Expressions uncaught exceptions on page reload
https://bugs.webkit.org/show_bug.cgi?id=149150

Patch by Joseph Pecoraro  on 2015-09-15
Reviewed by Brian Burg.

Instead of waiting 50ms to Resume, when the page navigates
Resume immediately. This ensures nobody is using a stale
activeCallFrame after the navigation.

Also clean up the manager a bit by removing some deletes.

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.restoreBreakpointsSoon):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
(WebInspector.DebuggerManager.prototype.debuggerDidResume):
(WebInspector.DebuggerManager.prototype._mainResourceDidChange):
(WebInspector.DebuggerManager.prototype._didResumeInternal):
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
(WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (189815 => 189816)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:26:27 UTC (rev 189815)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:36:04 UTC (rev 189816)
@@ -1,5 +1,28 @@
 2015-09-15  Joseph Pecoraro  
 
+Web Inspector: Watch Expressions uncaught exceptions on page reload
+https://bugs.webkit.org/show_bug.cgi?id=149150
+
+Reviewed by Brian Burg.
+
+Instead of waiting 50ms to Resume, when the page navigates
+Resume immediately. This ensures nobody is using a stale
+activeCallFrame after the navigation.
+
+Also clean up the manager a bit by removing some deletes.
+
+* UserInterface/Controllers/DebuggerManager.js:
+(WebInspector.DebuggerManager.restoreBreakpointsSoon):
+(WebInspector.DebuggerManager.prototype.reset):
+(WebInspector.DebuggerManager.prototype.debuggerDidPause):
+(WebInspector.DebuggerManager.prototype.debuggerDidResume):
+(WebInspector.DebuggerManager.prototype._mainResourceDidChange):
+(WebInspector.DebuggerManager.prototype._didResumeInternal):
+(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
+(WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.
+
+2015-09-15  Joseph Pecoraro  
+
 Web Inspector: Closing the final inspector tab should be allowed
 https://bugs.webkit.org/show_bug.cgi?id=149130
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (189815 => 189816)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2015-09-15 18:26:27 UTC (rev 189815)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2015-09-15 18:36:04 UTC (rev 189816)
@@ -38,6 +38,8 @@
 WebInspector.Breakpoint.addEventListener(WebInspector.Breakpoint.Event.AutoContinueDidChange, this._breakpointEditablePropertyDidChange, this);
 WebInspector.Breakpoint.addEventListener(WebInspector.Breakpoint.Event.ActionsDidChange, this._breakpointEditablePropertyDidChange, this);
 
+WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
+
 window.addEventListener("pagehide", this._inspectorClosing.bind(this));
 
 this._allExceptionsBreakpointEnabledSetting = new WebInspector.Setting("break-on-all-exceptions", false);
@@ -76,7 +78,7 @@
 this._restoringBreakpoints = true;
 for (var cookie of this._breakpointsSetting.value)
 this.addBreakpoint(new WebInspector.Breakpoint(cookie));
-delete this._restoringBreakpoints;
+this._restoringBreakpoints = false;
 }
 
 // Ensure that all managers learn about restored breakpoints,
@@ -443,7 +445,7 @@
 breakpoint.sourceCodeLocation.sourceCode = null;
 }
 
-delete this._ignoreBreakpointDisplayLocationDidChangeEvent;
+this._ignoreBreakpointDisplayLocationDidChangeEvent = false;
 
 this.dispatchEventToListeners(WebInspector.DebuggerManager.Event.ScriptsCleared);
 
@@ -457,7 +459,7 @@
 
 if (this._delayedResumeTimeout) {
 clearTimeout(this._delayedResumeTimeout);
-delete this._delayedResumeTimeout;
+this._delayedResumeTimeout = undefined;
 }
 
 var wasStillPaused = this._paused;
@@ -497,22 +499,9 @@
 {
 // Called from WebInspector.DebuggerObserver.
 
-function delayedWork()
-{
-delete this._delayedResumeTimeout;
-
-this._paused = 

[webkit-changes] [189817] trunk

2015-09-15 Thread hyatt
Title: [189817] trunk








Revision 189817
Author hy...@apple.com
Date 2015-09-15 11:38:18 -0700 (Tue, 15 Sep 2015)


Log Message
[New Block-Inside-Inline Model] Implement margin collapsing across contiguous anonymous inline blocks.
https://bugs.webkit.org/show_bug.cgi?id=149132

Reviewed by Zalan Bujtas.

Source/WebCore:

Added new tests inside fast/block/inside-inlines/

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::anonymousInlineBlock):
Change this accessor to be more robust and be willing to both recur (in case we ever do decide intermediate line boxes should exist)
and to type check. This is not currently needed, but I'm just being paranoid and future proof.

(WebCore::InlineFlowBox::addToLine):
Again, for thoroughness, I am making sure to propagate the hasAnonymousInlineBlock() bit through to parents. This is only needed
if we build intermediate line boxes for lines with anonymous inline blocks.

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Anonymous inline blocks receive a layout via layoutBlockChild, in order to make sure that margin collapsing runs. This means
that unlike other line objects, the position of the child has been determined already. Therefore we simply set the position
of the line box that wraps the anonymous inline block to the already-computed position for that block.

Also patch the code that sets lineTop and lineBottom using the root box's dimensions. We don't really care about the root line
box on anonymous inline block lines and just want to set lineTop and lineBottom to fit the anonymous inline block.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo):
Refactor collapseMargins to call a helper function that can pass in a previous "sibling", and that can handle the child
being null. We do this to perform a margin collapse when anonymous inline blocks run up against regular lines (which is like
collapsing with a sibling block "child").

* rendering/RenderBlockFlow.h:
Tweak the MarginInfo constructor to take a const RenderBlockFlow. Tweak some line layout methods to pass in the LineLayoutState
so that MarginInfo is available during line layout.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createLineBoxes):
When we create a new line box, if it is not an anonymous inline block line and our previous line was, simulate a margin
collapse in order to possibly push the line box down or up. Re-use the pagination adjustment code to rewind line layout
and perform it again if pushed below a float.

(WebCore::constructBidiRunsForSegment):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::RenderBlockFlow::updateRegionForLine):
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart):
Patch line layout to run margin collapsing when anonymous inline blocks are encountered. This involves making sure
margin info and float bottom positions are passed through so that layoutBlockChild can be properly called on
anonymous inline blocks that we encounter.

In addition line layout when it syncs dirty lines has to run margin collapsing on earlier lines in order to make
sure margin info is properly set up at the first dirty line position.

Note that there will be more improvements/changes in this area (dirty line syncing), as the current model is inefficient
when many anonymous inline blocks are scattered throughout a large-scale line box tree.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::ascentAndDescentForBox):
Make sure to rely on the block layout code for the placement of the boxes themselves. Set up the line box code to not have
an effect on ascent/descent.

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::handleReplaced):
When we encounter an anonymous inline block, lay it out when it is seen. We have to delay the layout, since we have
to be able to perform it mid-line-layout when the containing block's logical height is at the correct value and all previous
lines are placed. Margin info also has to be current.

* rendering/line/LineBreaker.cpp:
* rendering/line/LineBreaker.h:
Patched to pass LineLayoutState through so that the stuff we need to perform block layout is available (margin info and float vars).

* rendering/line/LineLayoutState.h:
Add the block layout margin and float bottom information to the line layout state so that we have it available when performing
layouts and margin collapses on anonymous inline block children.

LayoutTests:

* fast/block/inside-inlines/new-model/margin-collapse: Added.
* fast/block/inside-inlines/new-model/margin-collapse/001-expected.html: Added.
* 

[webkit-changes] [189815] trunk/Source/WebInspectorUI

2015-09-15 Thread commit-queue
Title: [189815] trunk/Source/WebInspectorUI








Revision 189815
Author commit-qu...@webkit.org
Date 2015-09-15 11:26:27 -0700 (Tue, 15 Sep 2015)


Log Message
Web Inspector: Closing the final inspector tab should be allowed
https://bugs.webkit.org/show_bug.cgi?id=149130

Patch by Joseph Pecoraro  on 2015-09-15
Reviewed by Brian Burg.

Previously we did not allow closing the last inspector tab. Now, we
will allow closing all inspector tabs, and when the last is closed,
present an unclosable New Tab tab, which would then be used to create
a new tab.

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
If we have no tabs to restore, show the New Tab tab.

(WebInspector._openDefaultTab):
When the last tab is closed, the tab bar requests we open a default tab.
Open the New Tab tab.

(WebInspector.TabBar.prototype._handleClick):
Disallow closing the single default tab.

(WebInspector._newTabItemClicked):
(WebInspector.showNewTabTab):
Share logic for showing the New Tab tab.

* UserInterface/Views/NewTabContentView.js:
(WebInspector.NewTabContentView):
Mark the new tab's tab bar item as the "default" tab bar item. It gets
special behavior when it is the single normal tab (cannot be closed).

* UserInterface/Views/TabBar.css:
(body:not(.window-inactive) .tab-bar > .item:hover > .close):
(body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
(.tab-bar.single-tab > .item.default-tab > .close):
(body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
(.tab-bar > .item.hide-close-button > .close): Deleted.
Update styles to only disable the close button on the
"default-tab" when it is the "single-tab" open. Otherwise
always allow closing tabs.

* UserInterface/Views/TabBar.js:
(WebInspector.TabBar.prototype.removeTabBarItem):
(WebInspector.TabBar.prototype.hasNormalTab):
(WebInspector.TabBar.prototype._openDefaultTab):
When removing the last normal tab, send an event to open
the default tab.

* UserInterface/Views/TabBarItem.js:
(WebInspector.TabBarItem.prototype.get default):
(WebInspector.TabBarItem.prototype.get isDefaultTab):
(WebInspector.TabBarItem.prototype.set isDefaultTab):
(WebInspector.TabBarItem.prototype.get hideCloseButton): Deleted.
(WebInspector.TabBarItem.prototype.set hideCloseButton): Deleted.
Switch to marking a tab bar item as the default tab. This tab
will be allowed when it is the single remaining tab. Currently
the default tab is always the "New Tab" tab.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js
trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (189814 => 189815)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:18:03 UTC (rev 189814)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-09-15 18:26:27 UTC (rev 189815)
@@ -1,3 +1,62 @@
+2015-09-15  Joseph Pecoraro  
+
+Web Inspector: Closing the final inspector tab should be allowed
+https://bugs.webkit.org/show_bug.cgi?id=149130
+
+Reviewed by Brian Burg.
+
+Previously we did not allow closing the last inspector tab. Now, we
+will allow closing all inspector tabs, and when the last is closed,
+present an unclosable New Tab tab, which would then be used to create
+a new tab.
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+If we have no tabs to restore, show the New Tab tab.
+
+(WebInspector._openDefaultTab):
+When the last tab is closed, the tab bar requests we open a default tab.
+Open the New Tab tab.
+
+(WebInspector.TabBar.prototype._handleClick):
+Disallow closing the single default tab.
+
+(WebInspector._newTabItemClicked):
+(WebInspector.showNewTabTab):
+Share logic for showing the New Tab tab.
+
+* UserInterface/Views/NewTabContentView.js:
+(WebInspector.NewTabContentView):
+Mark the new tab's tab bar item as the "default" tab bar item. It gets
+special behavior when it is the single normal tab (cannot be closed).
+
+* UserInterface/Views/TabBar.css:
+(body:not(.window-inactive) .tab-bar > .item:hover > .close):
+(body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
+(.tab-bar.single-tab > .item.default-tab > .close):
+(body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
+(.tab-bar > .item.hide-close-button > .close): Deleted.
+Update styles to only disable the close button on the
+"default-tab" when it is the "single-tab" open. Otherwise
+

[webkit-changes] [189818] trunk/Source/JavaScriptCore

2015-09-15 Thread msaboff
Title: [189818] trunk/Source/_javascript_Core








Revision 189818
Author msab...@apple.com
Date 2015-09-15 12:00:13 -0700 (Tue, 15 Sep 2015)


Log Message
REGRESSION(r189774): CLoop doesn't build after r189774
https://bugs.webkit.org/show_bug.cgi?id=149171

Unreviewed build fix for the C Loop.

Added needed C Loop label opcodes.

* bytecode/BytecodeList.json:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeList.json




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189817 => 189818)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-15 18:38:18 UTC (rev 189817)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:00:13 UTC (rev 189818)
@@ -1,3 +1,14 @@
+2015-09-15  Michael Saboff  
+
+REGRESSION(r189774): CLoop doesn't build after r189774
+https://bugs.webkit.org/show_bug.cgi?id=149171
+
+Unreviewed build fix for the C Loop.
+
+Added needed C Loop label opcodes.
+
+* bytecode/BytecodeList.json:
+
 2015-09-15  Andy VanWagoner  
 
 [INTL] Implement supportedLocalesOf on Intl Constructors


Modified: trunk/Source/_javascript_Core/bytecode/BytecodeList.json (189817 => 189818)

--- trunk/Source/_javascript_Core/bytecode/BytecodeList.json	2015-09-15 18:38:18 UTC (rev 189817)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeList.json	2015-09-15 19:00:13 UTC (rev 189818)
@@ -147,7 +147,9 @@
 { "name" : "llint_cloop_did_return_from_js_6" },
 { "name" : "llint_cloop_did_return_from_js_7" },
 { "name" : "llint_cloop_did_return_from_js_8" },
-{ "name" : "llint_cloop_did_return_from_js_9" }
+{ "name" : "llint_cloop_did_return_from_js_9" },
+{ "name" : "llint_cloop_did_return_from_js_10" },
+{ "name" : "llint_cloop_did_return_from_js_11" }
 ]
 },
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189796] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

2015-09-15 Thread carlosgc
Title: [189796] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po








Revision 189796
Author carlo...@webkit.org
Date 2015-09-15 01:11:38 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189663 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148475

Unreviewed.

Patch by Piotr Drąg  on 2015-09-12

* pl.po:

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/pl.po




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189795 => 189796)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:10:56 UTC (rev 189795)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:11:38 UTC (rev 189796)
@@ -1,3 +1,12 @@
+2015-09-12  Piotr Drąg  
+
+[l10n] Updated Polish translation of WebKitGTK+
+https://bugs.webkit.org/show_bug.cgi?id=148475
+
+Unreviewed.
+
+* pl.po:
+
 2015-09-12  Muhammet Kara  
 
 [GTK] [l10n] Updated Turkish translation of WebKitGTK+


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/pl.po (189795 => 189796)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/pl.po	2015-09-15 08:10:56 UTC (rev 189795)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/pl.po	2015-09-15 08:11:38 UTC (rev 189796)
@@ -9,9 +9,9 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: webkitgtk\n"
-"Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2015-01-20 12:06+\n"
-"PO-Revision-Date: 2015-03-04 22:32+0100\n"
+"Report-Msgid-Bugs-To: https://bugs.webkit.org\n"
+"POT-Creation-Date: 2015-08-26 14:45+\n"
+"PO-Revision-Date: 2015-08-26 17:00+0200\n"
 "Last-Translator: Piotr Drąg \n"
 "Language-Team: Polish \n"
 "Language: pl\n"
@@ -258,43 +258,43 @@
 
 #: ../LocalizedStringsGtk.cpp:366
 msgid "LRM _Left-to-right mark"
-msgstr "LRM znacznik od l_ewej do prawej"
+msgstr "LRM — znacznik od l_ewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:371
 msgid "RLM _Right-to-left mark"
-msgstr "RLM znacznik od p_rawej do lewej"
+msgstr "RLM — znacznik od p_rawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:376
 msgid "LRE Left-to-right _embedding"
-msgstr "LRE _osadzanie od lewej do prawej"
+msgstr "LRE — _osadzanie od lewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:381
 msgid "RLE Right-to-left e_mbedding"
-msgstr "RLE o_sadzanie od prawej do lewej"
+msgstr "RLE — o_sadzanie od prawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:386
 msgid "LRO Left-to-right _override"
-msgstr "LRO _zastąpienie od lewej do prawej"
+msgstr "LRO — _zastąpienie od lewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:391
 msgid "RLO Right-to-left o_verride"
-msgstr "RLO z_astąpienie od prawej do lewej"
+msgstr "RLO — z_astąpienie od prawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:396
 msgid "PDF _Pop directional formatting"
-msgstr "PDF formatowanie kierunkowe _Pop"
+msgstr "PDF — formatowanie kierunkowe _Pop"
 
 #: ../LocalizedStringsGtk.cpp:401
 msgid "ZWS _Zero width space"
-msgstr "ZWS spacja o _zerowej szerokości"
+msgstr "ZWS — spacja o _zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:406
 msgid "ZWJ Zero width _joiner"
-msgstr "ZWJ łą_cznik o zerowej szerokości"
+msgstr "ZWJ — łą_cznik o zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:411
 msgid "ZWNJ Zero width _non-joiner"
-msgstr "ZWNJ _bezłącznik o zerowej szerokości"
+msgstr "ZWNJ — _bezłącznik o zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:416
 msgid "No recent searches"
@@ -365,257 +365,252 @@
 msgstr "Niepowodzenie wtyczki"
 
 #. FIXME: If this file gets localized, this should really be localized as one string with a wildcard for the number.
-#: ../LocalizedStringsGtk.cpp:536
+#: ../LocalizedStringsGtk.cpp:530
 msgid " files"
 msgstr " plików"
 
-#: ../LocalizedStringsGtk.cpp:541
+#: ../LocalizedStringsGtk.cpp:535
 msgid "Unknown"
 msgstr "Nieznane"
 
-#: ../LocalizedStringsGtk.cpp:546
+#: ../LocalizedStringsGtk.cpp:540
 #, c-format
 msgctxt "Title string for images"
 msgid "%s  (%dx%d pixels)"
-msgstr "%s  (%dx%d pikseli)"
+msgstr "%s  (%d×%d pikseli)"
 
-#: ../LocalizedStringsGtk.cpp:557
+#: ../LocalizedStringsGtk.cpp:551
 msgid "Loading..."
-msgstr "Wczytywanie..."
+msgstr "Wczytywanie…"
 
-#: ../LocalizedStringsGtk.cpp:562
+#: ../LocalizedStringsGtk.cpp:556
 msgid "Live Broadcast"
 msgstr "Nadawanie na żywo"
 
-#: ../LocalizedStringsGtk.cpp:568
+#: ../LocalizedStringsGtk.cpp:562
 msgid "audio playback"
 msgstr "odtwarzanie dźwięku"
 
-#: ../LocalizedStringsGtk.cpp:570
+#: ../LocalizedStringsGtk.cpp:564
 msgid "video playback"
 msgstr "odtwarzanie wideo"
 
-#: ../LocalizedStringsGtk.cpp:572
+#: ../LocalizedStringsGtk.cpp:566
 msgid "mute"
 msgstr "wyciszenie"
 
-#: ../LocalizedStringsGtk.cpp:574
+#: 

[webkit-changes] [189798] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

2015-09-15 Thread carlosgc
Title: [189798] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po








Revision 189798
Author carlo...@webkit.org
Date 2015-09-15 01:13:02 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189665 - Webkit Tamil translations updated
https://bugs.webkit.org/show_bug.cgi?id=139478

Unreviewed.

Patch by Shantha kumar  on 2015-09-12

* ta.po:

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ta.po




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189797 => 189798)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:12:22 UTC (rev 189797)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:13:02 UTC (rev 189798)
@@ -1,3 +1,12 @@
+2015-09-12  Shantha kumar  
+
+Webkit Tamil translations updated
+https://bugs.webkit.org/show_bug.cgi?id=139478
+
+Unreviewed.
+
+* ta.po:
+
 2015-09-12  Zahari Yurukov  
 
 [l10n] Updated Bulgarian translation


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ta.po (189797 => 189798)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ta.po	2015-09-15 08:12:22 UTC (rev 189797)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ta.po	2015-09-15 08:13:02 UTC (rev 189798)
@@ -6,8 +6,8 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2014-09-10 10:57+\n"
-"PO-Revision-Date: 2014-09-15 15:44+0630\n"
+"POT-Creation-Date: 2014-10-25 10:53+\n"
+"PO-Revision-Date: 2014-12-10 18:57+0530\n"
 "Last-Translator: Shantha kumar \n"
 "Language-Team: Tamil \n"
 "Language: ta\n"
@@ -599,49 +599,60 @@
 msgid "No label"
 msgstr "லேபிள் இல்லை"
 
-#: ../LocalizedStringsGtk.cpp:817
+#: ../LocalizedStringsGtk.cpp:816
+#| msgctxt "Menu item label for a closed captions track that has no other name"
+#| msgid "No label"
+msgctxt "Menu item label for an audio track that has no other name"
+msgid "No label"
+msgstr "லேபிள் இல்லை"
+
+#: ../LocalizedStringsGtk.cpp:822
 msgctxt "Snapshotted Plug-In"
 msgid "Title of the label to show on a snapshotted plug-in"
 msgstr ""
 "ஸ்னாப்ஷாட் செய்யப்பட்ட செருகுநிரலில் காண்பிக்கப்பட வேண்டிய லேபிளின் தலைப்பு"
 
-#: ../LocalizedStringsGtk.cpp:822
+#: ../LocalizedStringsGtk.cpp:827
 msgctxt "Click to restart"
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr ""
 "ஸ்னாப்ஷாட் செய்யப்பட்ட செருகுநிரலில் காண்பிக்கப்பட வேண்டிய லேபிளின் "
 "துணைத்தலைப்பு"
 
-#: ../WebKitAuthenticationWidget.cpp:155
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
 #, c-format
+msgid ""
+"Cannot determine destination URI for download with suggested filename %s"
+msgstr ""
+"பரிந்துரைக்கப்பட்ட கோப்புப் பெயரான %s ஐக் கொண்டுள்ள பதிவறக்குத்துக்கான இலக்கு "
+"URI ஐத் "
+"தீர்மானிக்க முடியவில்லை"
+
+#. Prompt on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:114
+#, c-format
 msgid "The site %s:%i requests a username and password"
 msgstr "தளம் %s:%i பயனர் பெயரையும் கடவுச்சொலையும் கோருகிறது"
 
-#: ../WebKitAuthenticationWidget.cpp:159
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
+msgid "Server message:"
+msgstr "சேவையக செய்தி:"
+
+#. Check button on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:129
 msgid "_Remember password"
 msgstr "கடவுச்சொல்லை நினைவில் கொள் (_R)"
 
-#: ../WebKitAuthenticationWidget.cpp:167
-msgid "Server message:"
-msgstr "சேவையக செய்தி:"
-
-#: ../WebKitAuthenticationWidget.cpp:168 ../WebKitAuthenticationWidget.cpp:177
+#. Entry on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:133
 msgid "Username:"
 msgstr "பயனர்பெயர்:"
 
-#: ../WebKitAuthenticationWidget.cpp:169 ../WebKitAuthenticationWidget.cpp:178
+#. Entry on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:144
 msgid "Password:"
 msgstr "கடவுச்சொல்:"
 
-#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
-#, c-format
-msgid ""
-"Cannot determine destination URI for download with suggested filename %s"
-msgstr ""
-"பரிந்துரைக்கப்பட்ட கோப்புப் பெயரான %s ஐக் கொண்டுள்ள பதிவறக்குத்துக்கான இலக்கு "
-"URI ஐத் "
-"தீர்மானிக்க முடியவில்லை"
-
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitDownload.cpp:164
 msgid "Destination"
 msgstr "இலக்கு"
@@ -672,7 +683,6 @@
 msgstr "மேலெழுத அனுமதிக்கவும்"
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitDownload.cpp:215
-#| msgid "Whether the window can be resized."
 msgid "Whether the destination may be overwritten"
 msgstr "இலக்கு மேலெழுதப்படலாமா"
 
@@ -807,12 +817,10 @@
 msgstr "மீடியா URI"
 
 

[webkit-changes] [189799] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

2015-09-15 Thread carlosgc
Title: [189799] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po








Revision 189799
Author carlo...@webkit.org
Date 2015-09-15 01:13:41 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189666 - Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=123080

Unreviewed.

Patch by Matej Urbančič  on 2015-09-12

* sl.po:

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/sl.po




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189798 => 189799)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:13:02 UTC (rev 189798)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:13:41 UTC (rev 189799)
@@ -1,3 +1,12 @@
+2015-09-12  Matej Urbančič  
+
+Updated Slovenian translation
+https://bugs.webkit.org/show_bug.cgi?id=123080
+
+Unreviewed.
+
+* sl.po:
+
 2015-09-12  Shantha kumar  
 
 Webkit Tamil translations updated


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/sl.po (189798 => 189799)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/sl.po	2015-09-15 08:13:02 UTC (rev 189798)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/sl.po	2015-09-15 08:13:41 UTC (rev 189799)
@@ -9,8 +9,8 @@
 msgstr ""
 "Project-Id-Version: webkit HEAD\n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2013-03-19 18:04+\n"
-"PO-Revision-Date: 2013-03-24 13:29+0100\n"
+"POT-Creation-Date: 2013-09-16 15:07+\n"
+"PO-Revision-Date: 2013-10-20 08:09+0100\n"
 "Last-Translator: Matej Urbančič \n"
 "Language-Team: Slovenian GNOME Translation Team \n"
 "Language: sl_SI\n"
@@ -62,27 +62,6 @@
 msgid "Invalid page range"
 msgstr "Neveljaven obseg strani"
 
-#: ../GtkAuthenticationDialog.cpp:171
-#, c-format
-msgid "The site %s:%i requests a username and password"
-msgstr "Spletišče %s:%i zahteva uporabniško ime in geslo"
-
-#: ../GtkAuthenticationDialog.cpp:175
-msgid "_Remember password"
-msgstr "Za_pomni si geslo"
-
-#: ../GtkAuthenticationDialog.cpp:201
-msgid "Server message:"
-msgstr "Sporočilo strežnika:"
-
-#: ../GtkAuthenticationDialog.cpp:202 ../GtkAuthenticationDialog.cpp:210
-msgid "Username:"
-msgstr "Uporabniško ime:"
-
-#: ../GtkAuthenticationDialog.cpp:203 ../GtkAuthenticationDialog.cpp:211
-msgid "Password:"
-msgstr "Geslo:"
-
 #: ../LocalizedStringsGtk.cpp:56 ../LocalizedStringsGtk.cpp:61
 msgid "Submit"
 msgstr "Pošlji"
@@ -148,465 +127,522 @@
 msgstr "Odpri _zvok v novem oknu"
 
 #: ../LocalizedStringsGtk.cpp:146
+#| msgid "_Download Linked File"
+msgid "Download _Video"
+msgstr "Prejmi _sliko"
+
+#: ../LocalizedStringsGtk.cpp:151
+#| msgid "_Download Linked File"
+msgid "Download _Audio"
+msgstr "Prejmi _zvok"
+
+#: ../LocalizedStringsGtk.cpp:156
 msgid "Cop_y Video Link Location"
 msgstr "Kopiraj mesto slikovne _povezave"
 
-#: ../LocalizedStringsGtk.cpp:151
+#: ../LocalizedStringsGtk.cpp:161
 msgid "Cop_y Audio Link Location"
 msgstr "Kopiraj mesto zvočne _povezave"
 
-#: ../LocalizedStringsGtk.cpp:156
+#: ../LocalizedStringsGtk.cpp:166
 msgid "_Toggle Media Controls"
 msgstr "_Preklopi predstavne tipke"
 
-#: ../LocalizedStringsGtk.cpp:161
+#: ../LocalizedStringsGtk.cpp:171
+#| msgid "_Toggle Media Controls"
+msgid "_Show Media Controls"
+msgstr "_Pokaži predstavne tipke"
+
+#: ../LocalizedStringsGtk.cpp:176
+#| msgid "_Toggle Media Controls"
+msgid "_Hide Media Controls"
+msgstr "_Skrij predstavne tipke"
+
+#: ../LocalizedStringsGtk.cpp:181
 msgid "Toggle Media _Loop Playback"
 msgstr "Preklopi predvajanje v _zanki"
 
-#: ../LocalizedStringsGtk.cpp:166
+#: ../LocalizedStringsGtk.cpp:186
 msgid "Switch Video to _Fullscreen"
 msgstr "Preklopi sliko na _cel zaslon"
 
-#: ../LocalizedStringsGtk.cpp:171
+#: ../LocalizedStringsGtk.cpp:191
 msgid "_Play"
 msgstr "_Predvajaj"
 
-#: ../LocalizedStringsGtk.cpp:176
+#: ../LocalizedStringsGtk.cpp:196
 msgid "_Pause"
 msgstr "_Premor"
 
-#: ../LocalizedStringsGtk.cpp:181
+#: ../LocalizedStringsGtk.cpp:201
 msgid "_Mute"
 msgstr "_Nemo"
 
-#: ../LocalizedStringsGtk.cpp:186
+#: ../LocalizedStringsGtk.cpp:206
 msgid "Open _Frame in New Window"
 msgstr "Odpri okvir v _novem oknu"
 
-#: ../LocalizedStringsGtk.cpp:209
+#: ../LocalizedStringsGtk.cpp:229
 msgid "_Insert Unicode Control Character"
 msgstr "_Vstavi nadzorni znak Unicode"
 
-#: ../LocalizedStringsGtk.cpp:214
+#: ../LocalizedStringsGtk.cpp:234
 msgid "Input _Methods"
 msgstr "_Načini vnosa"
 
-#: ../LocalizedStringsGtk.cpp:237
+#: ../LocalizedStringsGtk.cpp:257
 msgid "_Reload"
 msgstr "_Ponovno naloži"
 
-#: ../LocalizedStringsGtk.cpp:254
+#: ../LocalizedStringsGtk.cpp:274
 msgid "No Guesses Found"
 msgstr "Ni najdenih ugibanj"
 
-#: 

[webkit-changes] [189802] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189802] releases/WebKitGTK/webkit-2.10








Revision 189802
Author carlo...@webkit.org
Date 2015-09-15 01:37:17 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189677 - Node.baseURI should not return null for detached nodes
https://bugs.webkit.org/show_bug.cgi?id=149104


Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/dom/nodes/Node-baseURI-expected.txt:

Source/WebCore:

Node.baseURI should not return null for detached nodes. It should return
the node document's base URL. The node document is set when the node is
created so it is valid even if the node is detached [1]:
https://dom.spec.whatwg.org/#dom-node-baseuri

WebKit was traversing the ancestors to find the base URL, which only
works if the node is attached. Also, WebKit was taking into account
the xml:base attribute when computing the baseURI.

Both Chrome and Firefox already dropped support for xml:base:
https://code.google.com/p/chromium/issues/detail?id=341854
https://bugzilla.mozilla.org/show_bug.cgi?id=903372

Firefox complies with the specification. Chrome's baseURI still only
works for attached Nodes as their implementation still traverses the
DOM tree, despite dropping support for xml:base.

This patch drops support xml:base when computing Node.baseURI, as
Firefox, Chrome and the latest DOM specification do. It also makes
Node.baseURI work for detached Nodes by returning the base URL of the
node Document. This means we no longer have to traverse the Node's
ancestors in the DOM tree. This is consistent with the behavior of
Firefox and the latest DOM specification.

This patch does not drop the SVGElement.xmlbase attribute yet. However,
we should probably consider making this change as well given that:
- The SVG2 specification dropped it
- Chrome dropped it.
- It no longers impacts Node.baseURI

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=20976

No new tests, already covered by existing test.

* dom/Document.cpp:
(WebCore::Document::setContent): Deleted.
* dom/Document.h:
(WebCore::Document::inputCursor): Deleted.
* dom/DocumentType.cpp:
(WebCore::DocumentType::nodeName): Deleted.
* dom/DocumentType.h:
* dom/Element.cpp:
(WebCore::Element::imageSourceURL): Deleted.
(WebCore::Element::rendererIsNeeded): Deleted.
(WebCore::Element::createElementRenderer): Deleted.
(WebCore::Element::insertedInto): Deleted.
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::baseURI):
* dom/Node.h:
* svg/SVGElement.idl:

LayoutTests:

* dom/xhtml/level3/core/nodegetbaseuri03-expected.txt:
Rebaseline outdated DOM3 test.

* svg/custom/image-base-uri-expected.txt: Removed.
* svg/custom/image-base-uri.svg: Removed.
Drop outdated SVG test. SVG2 no longer support xml:base.

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03.js
releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/DocumentType.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/DocumentType.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Element.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Element.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Node.cpp
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Node.h
releases/WebKitGTK/webkit-2.10/Source/WebCore/svg/SVGElement.idl


Removed Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/svg/custom/image-base-uri-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/svg/custom/image-base-uri.svg




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189801 => 189802)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 08:15:09 UTC (rev 189801)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 08:37:17 UTC (rev 189802)
@@ -1,3 +1,18 @@
+2015-09-13  Chris Dumez  
+
+Node.baseURI should not return null for detached nodes
+https://bugs.webkit.org/show_bug.cgi?id=149104
+
+
+Reviewed by Sam Weinig.
+
+* dom/xhtml/level3/core/nodegetbaseuri03-expected.txt:
+Rebaseline outdated DOM3 test.
+
+* svg/custom/image-base-uri-expected.txt: Removed.
+* svg/custom/image-base-uri.svg: Removed.
+Drop outdated SVG test. SVG2 no longer support xml:base.
+
 2015-09-10  David Hyatt  
 
 [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt (189801 => 189802)

--- 

[webkit-changes] [189804] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189804] releases/WebKitGTK/webkit-2.10








Revision 189804
Author carlo...@webkit.org
Date 2015-09-15 01:57:56 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189680 - Document.title does not behave according to specification
https://bugs.webkit.org/show_bug.cgi?id=149098

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Update Document.title to behave according to the latest DOM specification:
https://html.spec.whatwg.org/multipage/dom.html#document.title

In particular, the following Web-Exposed changes were made:
1. The title Element should be the first title element in the document
   (in tree order) [1]. Previously, WebKit would use the first title
   Element *added* to the Document. Document.title returns the text
   content of the title Element so this change is web-exposed.
2. If the title Element is replaced after the title has been set by the
   JS (via the document.title setter), we should update the value
   returned by the document.title getter. Previously, WebKit would set
   a flag if the title was explicitly set by JS via document.title
   setter and later title element changes would not override the title
   set by the JS. This behavior isn't specified and does not match the
   behavior of other browsers.

The new behavior is also consistent with the behavior of Firefox and
Chrome.

Some refactoring was made for the sake of clarity now that our
implementation has changed. See details below.

[1] https://html.spec.whatwg.org/multipage/dom.html#the-title-element-2

No new tests, already covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::updateTitleFromTitleElement):
New convenience method that calls updateTitle() with the text of the
document's current title Element. If there is no title Element, it
clears the title.

(WebCore::Document::updateTitleElement):
Method which updates the Document's title Element whenever a title
Element is added or removed from the Document. Once the title Element
is updated, it takes care of calling updateTitleFromTitleElement() to
update the Document's title.

(WebCore::Document::titleElementAdded):
(WebCore::Document::titleElementRemoved):
(WebCore::Document::titleElementTextChanged):
New Document public API called by HTMLTitleElement / SVGTitleElement
whenever a title Element is added / removed from the Document or
whenever the title element's text has changed. These methods will
take care of calling updateTitleElement() / updateTitleFromTitleElement()
as necessary.
Previously, we would only have 2 methods:
- setTitleElement() which would be called whenever a title Element was
  added to the document or when its text had changed. The name was
  confusing because it would not necessarily set the document's title
  Element and it would be used both for title element update and a
  simple title update. This method has been split into 2:
  titleElementAdded() and titleElementTextChanged().
- removeTitle() which would be called whenever a title Element was
  removed. The naming was confusing because it would not necessarily
  remove the Document's title Element. This is now called
  titleElementRemoved().

* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::HTMLTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::HTMLTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement() / removeTitle() as we don't really want
to remove or add a title Element. We merely want to notify
the document that the title element text has changed in
case it is the current title Element of the Document.

(WebCore::HTMLTitleElement::computedTextWithDirection):
Rename textWithDirection() to computedTextWithDirection() to
make it clear it is not a simple getter and make it private
as it is only used to set the m_title member which caches the
computed text.

* html/HTMLTitleElement.h:
Add new textWithDirection() getter which returns m_title. This
is needed so that Document can query the title of the Element.
Previously, HTMLTitleElement would pass directly m_title to
the Document when calling Document::setTitleElement().

* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::SVGTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::SVGTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement().

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog

[webkit-changes] [189803] releases/WebKitGTK/webkit-2.10

2015-09-15 Thread carlosgc
Title: [189803] releases/WebKitGTK/webkit-2.10








Revision 189803
Author carlo...@webkit.org
Date 2015-09-15 01:39:09 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189679 - document.lastModified should use the user's local time zone
https://bugs.webkit.org/show_bug.cgi?id=149092
LayoutTests/imported/w3c:



Reviewed by Ryosuke Niwa.

Rebaseline a couple of W3C tests now that more checks are passing.

* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01-expected.txt:
* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt:

Source/WebCore:



Reviewed by Ryosuke Niwa.

document.lastModified should use the user's local time zone:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-lastmodified

Chrome and Firefox comply with the specification but WebKit was using
UTC. This patch aligns WebKit's behavior with the specification and
other browsers.

No new tests, already covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::lastModified):
(WebCore::Document::setCookieURL): Deleted.

LayoutTests:

Reviewed by Ryosuke Niwa.

Update test so that it converts document.lastModified to UTF before
printing it. This is so that we can consistent layout tests results, no
matter the system's timezone.

* http/tests/misc/last-modified-parsing-expected.txt:
* http/tests/resources/last-modified.php:

Modified Paths

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt
releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/resources/last-modified.php
releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189802 => 189803)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 08:37:17 UTC (rev 189802)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog	2015-09-15 08:39:09 UTC (rev 189803)
@@ -1,5 +1,19 @@
 2015-09-13  Chris Dumez  
 
+document.lastModified should use the user's local time zone
+https://bugs.webkit.org/show_bug.cgi?id=149092
+
+Reviewed by Ryosuke Niwa.
+
+Update test so that it converts document.lastModified to UTF before
+printing it. This is so that we can consistent layout tests results, no
+matter the system's timezone.
+
+* http/tests/misc/last-modified-parsing-expected.txt:
+* http/tests/resources/last-modified.php:
+
+2015-09-13  Chris Dumez  
+
 Node.baseURI should not return null for detached nodes
 https://bugs.webkit.org/show_bug.cgi?id=149104
 


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt (189802 => 189803)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt	2015-09-15 08:37:17 UTC (rev 189802)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt	2015-09-15 08:39:09 UTC (rev 189803)
@@ -3,34 +3,34 @@
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/1997 01:03:33
+Fri, 21 Nov 1997 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-02/21/2008 01:03:33
+Thu, 21 Feb 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-02/03/2008 01:03:33
+Sun, 03 Feb 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-03/03/2008 01:03:33
+Mon, 03 Mar 2008 01:03:33 GMT


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/resources/last-modified.php (189802 => 189803)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/resources/last-modified.php	2015-09-15 08:37:17 UTC (rev 189802)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/http/tests/resources/last-modified.php	2015-09-15 08:39:09 UTC (rev 189803)
@@ -3,5 +3,5 @@
 header("Last-Modified: $date");
 ?>
 
-document.write(document.lastModified);
+document.write((new Date(document.lastModified)).toUTCString());
 


Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog (189802 => 189803)

--- releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 08:37:17 UTC (rev 189802)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog	2015-09-15 08:39:09 UTC (rev 189803)
@@ -1,5 +1,18 @@
 2015-09-13  Chris Dumez  
 
+document.lastModified should use the user's local time zone
+https://bugs.webkit.org/show_bug.cgi?id=149092
+
+
+Reviewed by Ryosuke Niwa.

[webkit-changes] [189801] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

2015-09-15 Thread carlosgc
Title: [189801] releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po








Revision 189801
Author carlo...@webkit.org
Date 2015-09-15 01:15:09 -0700 (Tue, 15 Sep 2015)


Log Message
Merge r189673 - Webkit Gujarati Translations
https://bugs.webkit.org/show_bug.cgi?id=139530

Unreviewed.

Patch by Ankit Patel  on 2015-09-13

* gu.po:

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/gu.po




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog (189800 => 189801)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:14:23 UTC (rev 189800)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 08:15:09 UTC (rev 189801)
@@ -1,3 +1,12 @@
+2015-09-13  Ankit Patel  
+
+Webkit Gujarati Translations
+https://bugs.webkit.org/show_bug.cgi?id=139530
+
+Unreviewed.
+
+* gu.po:
+
 2015-09-12  Francisco Serrador  
 
 Updated Spanish translation


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/gu.po (189800 => 189801)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/gu.po	2015-09-15 08:14:23 UTC (rev 189800)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/gu.po	2015-09-15 08:15:09 UTC (rev 189801)
@@ -8,8 +8,8 @@
 msgstr ""
 "Project-Id-Version: webkit.gu\n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2014-08-28 22:55+\n"
-"PO-Revision-Date: 2014-09-04 15:13+0530\n"
+"POT-Creation-Date: 2014-10-25 10:53+\n"
+"PO-Revision-Date: 2014-12-11 10:49+0530\n"
 "Last-Translator: \n"
 "Language-Team: American English \n"
 "Language: \n"
@@ -125,12 +125,10 @@
 msgstr "નવી વિન્ડોમાં ઓડિયો ખોલો (_A)"
 
 #: ../LocalizedStringsGtk.cpp:145
-#| msgid "_Download Linked File"
 msgid "Download _Video"
 msgstr "વિડિઓને ડાઉનલોડ કરો (_V)"
 
 #: ../LocalizedStringsGtk.cpp:150
-#| msgid "_Download Linked File"
 msgid "Download _Audio"
 msgstr "ઓડિયોને ડાઉનલોડ કરો (_A)"
 
@@ -147,12 +145,10 @@
 msgstr "ટૉગલ મીડિયા નિયંત્રણ (_T)"
 
 #: ../LocalizedStringsGtk.cpp:170
-#| msgid "_Toggle Media Controls"
 msgid "_Show Media Controls"
 msgstr "મીડિયા નિયંત્રણને બતાવો (_S)"
 
 #: ../LocalizedStringsGtk.cpp:175
-#| msgid "_Toggle Media Controls"
 msgid "_Hide Media Controls"
 msgstr "મીડિયા નિયંત્રણને છુપાડો (_H)"
 
@@ -321,7 +317,6 @@
 msgstr "પદ"
 
 #: ../LocalizedStringsGtk.cpp:446
-#| msgid "definition"
 msgid "description"
 msgstr "વર્ણન"
 
@@ -389,12 +384,10 @@
 msgstr "જીવંત પ્રસારણ"
 
 #: ../LocalizedStringsGtk.cpp:568
-#| msgid "pause playback"
 msgid "audio playback"
 msgstr "ઓડિયો વગાડો"
 
 #: ../LocalizedStringsGtk.cpp:570
-#| msgid "begin playback"
 msgid "video playback"
 msgstr "વિડિયો વગાડો"
 
@@ -583,7 +576,6 @@
 msgstr "અસ્વીકારી TLS પ્રમાણપત્ર"
 
 #: ../LocalizedStringsGtk.cpp:791
-#| msgid "stop displaying closed captions"
 msgctxt "Closed Captions"
 msgid "Menu section heading for closed captions"
 msgstr "મેનુ વિભાગ બંધ કૅપ્શન માટે મથાળું"
@@ -594,8 +586,7 @@
 msgstr "ઉપશીર્ષકો"
 
 #: ../LocalizedStringsGtk.cpp:801
-msgctxt ""
-"Menu item label for the track that represents disabling closed captions"
+msgctxt "Menu item label for the track that represents disabling closed captions"
 msgid "Off"
 msgstr "બંધ"
 
@@ -609,73 +600,87 @@
 msgid "No label"
 msgstr "લેબલ નથી"
 
-#: ../LocalizedStringsGtk.cpp:817
+#: ../LocalizedStringsGtk.cpp:816
+#| msgctxt "Menu item label for a closed captions track that has no other name"
+#| msgid "No label"
+msgctxt "Menu item label for an audio track that has no other name"
+msgid "No label"
+msgstr "લેબલ નથી"
+
+#: ../LocalizedStringsGtk.cpp:822
 msgctxt "Snapshotted Plug-In"
 msgid "Title of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગ-ઇન પર બતાવવા માટે લેબલનું શીર્ષક"
 
-#: ../LocalizedStringsGtk.cpp:822
+#: ../LocalizedStringsGtk.cpp:827
 msgctxt "Click to restart"
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગઇન પર બતાવવા માટે લેબલનું ઉપશીર્ષક"
 
-#: ../WebKitAuthenticationWidget.cpp:155
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
 #, c-format
+msgid "Cannot determine destination URI for download with suggested filename %s"
+msgstr "સૂચિત ફાઇલનામ %s સાથે ડાઉનલોડ માટે લક્ષ્ય URI ને નક્કી કરી શકાતુ નથી"
+
+#. Prompt on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:114
+#, c-format
 msgid "The site %s:%i requests a username and password"
 msgstr "સાઇટ %s:%i એ વપરાશકર્તાનામ અને પાસવર્ડની માંગણી કરે છે"
 
-#: ../WebKitAuthenticationWidget.cpp:159
-msgid "_Remember password"
-msgstr "પાસવર્ડ યાદ રાખો (_R)"
-
-#: ../WebKitAuthenticationWidget.cpp:167
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
 

[webkit-changes] [189808] trunk/LayoutTests

2015-09-15 Thread achristensen
Title: [189808] trunk/LayoutTests








Revision 189808
Author achristen...@apple.com
Date 2015-09-15 08:33:09 -0700 (Tue, 15 Sep 2015)


Log Message
Unreviewed gardening.

* platform/win/TestExpectations:
Fix Windows tests after r189769.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189807 => 189808)

--- trunk/LayoutTests/ChangeLog	2015-09-15 15:01:09 UTC (rev 189807)
+++ trunk/LayoutTests/ChangeLog	2015-09-15 15:33:09 UTC (rev 189808)
@@ -1,3 +1,10 @@
+2015-09-15  Alex Christensen  
+
+Unreviewed gardening.
+
+* platform/win/TestExpectations:
+Fix Windows tests after r189769.
+
 2015-09-14  Alexey Proskuryakov  
 
 Layout Test http/tests/media/media-document-referer.html is flaky


Modified: trunk/LayoutTests/platform/win/TestExpectations (189807 => 189808)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-09-15 15:01:09 UTC (rev 189807)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-09-15 15:33:09 UTC (rev 189808)
@@ -3177,6 +3177,7 @@
 
 # Changing system language is not supported.
 fast/text/international/system-language [ Skip ]
+webkit.org/b/149128 fast/text/control-characters [ ImageOnlyFailure ]
 
 fast/ruby/ruby-expansion-cjk.html [ ImageOnlyFailure ]
 fast/ruby/ruby-expansion-cjk-2.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189810] trunk/Source

2015-09-15 Thread beidson
Title: [189810] trunk/Source








Revision 189810
Author beid...@apple.com
Date 2015-09-15 09:36:19 -0700 (Tue, 15 Sep 2015)


Log Message
Move most IDB object encoding/decoding from WebKit2 to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=149152

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Cleanup, no behavior change).

* Modules/indexeddb/IDBDatabaseMetadata.h:
(WebCore::IDBDatabaseMetadata::encode):
(WebCore::IDBDatabaseMetadata::decode):
* Modules/indexeddb/IDBIndexMetadata.h:
(WebCore::IDBIndexMetadata::encode):
(WebCore::IDBIndexMetadata::decode):
* Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
* Modules/indexeddb/IDBKeyPath.h:
(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):
* Modules/indexeddb/IDBKeyRangeData.h:
(WebCore::IDBKeyRangeData::encode):
(WebCore::IDBKeyRangeData::decode):
* Modules/indexeddb/IDBObjectStoreMetadata.h:
(WebCore::IDBObjectStoreMetadata::encode):
(WebCore::IDBObjectStoreMetadata::decode):

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h
trunk/Source/WebCore/Modules/indexeddb/IDBIndexMetadata.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRangeData.h
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreMetadata.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189809 => 189810)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 15:51:02 UTC (rev 189809)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 16:36:19 UTC (rev 189810)
@@ -1,3 +1,31 @@
+2015-09-15  Brady Eidson  
+
+Move most IDB object encoding/decoding from WebKit2 to WebCore.
+https://bugs.webkit.org/show_bug.cgi?id=149152
+
+Reviewed by Alex Christensen.
+
+No new tests (Cleanup, no behavior change).
+
+* Modules/indexeddb/IDBDatabaseMetadata.h:
+(WebCore::IDBDatabaseMetadata::encode):
+(WebCore::IDBDatabaseMetadata::decode):
+* Modules/indexeddb/IDBIndexMetadata.h:
+(WebCore::IDBIndexMetadata::encode):
+(WebCore::IDBIndexMetadata::decode):
+* Modules/indexeddb/IDBKeyData.h:
+(WebCore::IDBKeyData::encode):
+(WebCore::IDBKeyData::decode):
+* Modules/indexeddb/IDBKeyPath.h:
+(WebCore::IDBKeyPath::encode):
+(WebCore::IDBKeyPath::decode):
+* Modules/indexeddb/IDBKeyRangeData.h:
+(WebCore::IDBKeyRangeData::encode):
+(WebCore::IDBKeyRangeData::decode):
+* Modules/indexeddb/IDBObjectStoreMetadata.h:
+(WebCore::IDBObjectStoreMetadata::encode):
+(WebCore::IDBObjectStoreMetadata::decode):
+
 2015-09-14  Brady Eidson  
 
 Make the enum IDBKey::Type into a utility enum class.


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h (189809 => 189810)

--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h	2015-09-15 15:51:02 UTC (rev 189809)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h	2015-09-15 16:36:19 UTC (rev 189810)
@@ -68,6 +68,9 @@
 {
 }
 
+template void encode(Encoder&) const;
+template static bool decode(Decoder&, IDBDatabaseMetadata&);
+
 String name;
 int64_t id;
 uint64_t version;
@@ -79,6 +82,33 @@
 WEBCORE_EXPORT IDBDatabaseMetadata isolatedCopy() const;
 };
 
+template
+void IDBDatabaseMetadata::encode(Encoder& encoder) const
+{
+encoder << name << id << version << maxObjectStoreId << objectStores;
+}
+
+template
+bool IDBDatabaseMetadata::decode(Decoder& decoder, IDBDatabaseMetadata& metadata)
+{
+if (!decoder.decode(metadata.name))
+return false;
+
+if (!decoder.decode(metadata.id))
+return false;
+
+if (!decoder.decode(metadata.version))
+return false;
+
+if (!decoder.decode(metadata.maxObjectStoreId))
+return false;
+
+if (!decoder.decode(metadata.objectStores))
+return false;
+
+return true;
+}
+
 } // namespace WebCore
 
 #endif // ENABLE(INDEXED_DATABASE)


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndexMetadata.h (189809 => 189810)

--- trunk/Source/WebCore/Modules/indexeddb/IDBIndexMetadata.h	2015-09-15 

[webkit-changes] [189807] trunk

2015-09-15 Thread ossy
Title: [189807] trunk








Revision 189807
Author o...@webkit.org
Date 2015-09-15 08:01:09 -0700 (Tue, 15 Sep 2015)


Log Message
[cmake] Enable debug fission only if it is supported
https://bugs.webkit.org/show_bug.cgi?id=149161

Reviewed by Martin Robinson.

* Source/cmake/OptionsCommon.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake




Diff

Modified: trunk/ChangeLog (189806 => 189807)

--- trunk/ChangeLog	2015-09-15 14:48:41 UTC (rev 189806)
+++ trunk/ChangeLog	2015-09-15 15:01:09 UTC (rev 189807)
@@ -1,3 +1,12 @@
+2015-09-15  Csaba Osztrogonác  
+
+[cmake] Enable debug fission only if it is supported
+https://bugs.webkit.org/show_bug.cgi?id=149161
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/OptionsCommon.cmake:
+
 2015-09-14  Alex Christensen  
 
 Progress towards CMake on Mac.


Modified: trunk/Source/cmake/OptionsCommon.cmake (189806 => 189807)

--- trunk/Source/cmake/OptionsCommon.cmake	2015-09-15 14:48:41 UTC (rev 189806)
+++ trunk/Source/cmake/OptionsCommon.cmake	2015-09-15 15:01:09 UTC (rev 189807)
@@ -85,7 +85,11 @@
 
 set(ENABLE_DEBUG_FISSION_DEFAULT OFF)
 if (USE_LD_GOLD AND CMAKE_BUILD_TYPE STREQUAL "Debug")
-set(ENABLE_DEBUG_FISSION_DEFAULT ON)
+include(TestCXXAcceptsFlag)
+CHECK_CXX_ACCEPTS_FLAG(-gsplit-dwarf CXX_ACCEPTS_GSPLIT_DWARF)
+if (CXX_ACCEPTS_GSPLIT_DWARF)
+set(ENABLE_DEBUG_FISSION_DEFAULT ON)
+endif ()
 endif ()
 
 option(DEBUG_FISSION "Use Debug Fission support" ${ENABLE_DEBUG_FISSION_DEFAULT})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189805] trunk/Source/JavaScriptCore/jit/JITOperations.cpp

2015-09-15 Thread ssakshuwong
Title: [189805] trunk/Source/_javascript_Core/jit/JITOperations.cpp








Revision 189805
Author ssakshuw...@apple.com
Date 2015-09-15 04:06:10 -0700 (Tue, 15 Sep 2015)


Log Message
Build fix after r189774

* jit/JITOperations.cpp

Modified Paths

trunk/Source/_javascript_Core/jit/JITOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (189804 => 189805)

--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2015-09-15 08:57:56 UTC (rev 189804)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2015-09-15 11:06:10 UTC (rev 189805)
@@ -856,7 +856,9 @@
 #if ENABLE(WEBASSEMBLY)
 if (!isCall(kind)) {
 exec->vm().throwException(exec, createNotAConstructorError(exec, function));
-return reinterpret_cast(vm->getCTIStub(throwExceptionFromCallSlowPathGenerator).code().executableAddress());
+return encodeResult(
+vm->getCTIStub(throwExceptionFromCallSlowPathGenerator).code().executableAddress(),
+reinterpret_cast(KeepTheFrame));
 }
 
 WebAssemblyExecutable* webAssemblyExecutable = static_cast(executable);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189812] trunk/Source/WebCore/platform/gtk/po

2015-09-15 Thread mcatanzaro
Title: [189812] trunk/Source/WebCore/platform/gtk/po








Revision 189812
Author mcatanz...@igalia.com
Date 2015-09-15 10:48:58 -0700 (Tue, 15 Sep 2015)


Log Message
[GTK] Remove outdated README under po directory
https://bugs.webkit.org/show_bug.cgi?id=149166

Reviewed by Martin Robinson.

* README: Removed.

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog


Removed Paths

trunk/Source/WebCore/platform/gtk/po/README




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189811 => 189812)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 17:43:27 UTC (rev 189811)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 17:48:58 UTC (rev 189812)
@@ -1,3 +1,12 @@
+2015-09-15  Michael Catanzaro  
+
+[GTK] Remove outdated README under po directory
+https://bugs.webkit.org/show_bug.cgi?id=149166
+
+Reviewed by Martin Robinson.
+
+* README: Removed.
+
 2015-09-13  Ankit Patel  
 
 Webkit Gujarati Translations


Deleted: trunk/Source/WebCore/platform/gtk/po/README (189811 => 189812)

--- trunk/Source/WebCore/platform/gtk/po/README	2015-09-15 17:43:27 UTC (rev 189811)
+++ trunk/Source/WebCore/platform/gtk/po/README	2015-09-15 17:48:58 UTC (rev 189812)
@@ -1,11 +0,0 @@
-===
-WebKitGTK+ Localization
-===
-
-WebKitGTK+'s build system is very unorthodox. This means that you will
-not get to run the usual make commands in the po directory.
-
-To refresh the .pot file, go to the root of the build directory, and
-run `make webkit.pot-update'. To update the .po files using the new
-.pot file run `make update-po'. This will also build the .mo files.
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189809] trunk/Source

2015-09-15 Thread beidson
Title: [189809] trunk/Source








Revision 189809
Author beid...@apple.com
Date 2015-09-15 08:51:02 -0700 (Tue, 15 Sep 2015)


Log Message
Make the enum IDBKey::Type into a utility enum class.
https://bugs.webkit.org/show_bug.cgi?id=149149

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Cleanup, no behavior change).

* Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::isValid):
(WebCore::IDBKey::compare):
* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createMultiEntryArray):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::type):
(WebCore::IDBKey::array):
(WebCore::IDBKey::string):
(WebCore::IDBKey::date):
(WebCore::IDBKey::number):
(WebCore::IDBKey::compareTypes):
(WebCore::IDBKey::IDBKey):
* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::setArrayValue):
(WebCore::IDBKeyData::setStringValue):
(WebCore::IDBKeyData::setDateValue):
(WebCore::IDBKeyData::setNumberValue):
* Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):
* Modules/indexeddb/IndexedDB.h:
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyToJSValue):
(WebCore::createIDBKeyFromValue):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::generateIndexKeysForValue):
* inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit2:

* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKey.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h
trunk/Source/WebCore/Modules/indexeddb/IndexedDB.h
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (189808 => 189809)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 15:33:09 UTC (rev 189808)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 15:51:02 UTC (rev 189809)
@@ -1,3 +1,51 @@
+2015-09-14  Brady Eidson  
+
+Make the enum IDBKey::Type into a utility enum class.
+https://bugs.webkit.org/show_bug.cgi?id=149149
+
+Reviewed by Alex Christensen.
+
+No new tests (Cleanup, no behavior change).
+
+* Modules/indexeddb/IDBKey.cpp:
+(WebCore::IDBKey::isValid):
+(WebCore::IDBKey::compare):
+* Modules/indexeddb/IDBKey.h:
+(WebCore::IDBKey::createNumber):
+(WebCore::IDBKey::createDate):
+(WebCore::IDBKey::createMultiEntryArray):
+(WebCore::IDBKey::createArray):
+(WebCore::IDBKey::type):
+(WebCore::IDBKey::array):
+(WebCore::IDBKey::string):
+(WebCore::IDBKey::date):
+(WebCore::IDBKey::number):
+(WebCore::IDBKey::compareTypes):
+(WebCore::IDBKey::IDBKey):
+* Modules/indexeddb/IDBKeyData.cpp:
+(WebCore::IDBKeyData::IDBKeyData):
+(WebCore::IDBKeyData::maybeCreateIDBKey):
+(WebCore::IDBKeyData::isolatedCopy):
+(WebCore::IDBKeyData::encode):
+(WebCore::IDBKeyData::decode):
+(WebCore::IDBKeyData::compare):
+(WebCore::IDBKeyData::loggingString):
+(WebCore::IDBKeyData::setArrayValue):
+(WebCore::IDBKeyData::setStringValue):
+(WebCore::IDBKeyData::setDateValue):
+(WebCore::IDBKeyData::setNumberValue):
+* Modules/indexeddb/IDBKeyData.h:
+(WebCore::IDBKeyData::IDBKeyData):
+(WebCore::IDBKeyData::minimum):
+(WebCore::IDBKeyData::maximum):
+* Modules/indexeddb/IndexedDB.h:
+* bindings/js/IDBBindingUtilities.cpp:
+(WebCore::idbKeyToJSValue):
+(WebCore::createIDBKeyFromValue):
+(WebCore::createIDBKeyFromScriptValueAndKeyPath):
+(WebCore::generateIndexKeysForValue):
+* inspector/InspectorIndexedDBAgent.cpp:
+
 2015-09-15  Javier Fernandez  
 
 [CSS Grid Layout] Using {row, column}-axis terms in alignment related logic


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp (189808 => 189809)

--- trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp	2015-09-15 15:33:09 UTC (rev 189808)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp	2015-09-15 15:51:02 UTC (rev 189809)
@@ -38,10 +38,10 @@
 
 bool IDBKey::isValid() const
 {
-if 

[webkit-changes] [189819] trunk/Source/JavaScriptCore

2015-09-15 Thread commit-queue
Title: [189819] trunk/Source/_javascript_Core








Revision 189819
Author commit-qu...@webkit.org
Date 2015-09-15 12:26:45 -0700 (Tue, 15 Sep 2015)


Log Message
functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary
https://bugs.webkit.org/show_bug.cgi?id=148169

Patch by Saam barati  on 2015-09-15
Reviewed by Geoffrey Garen.

We used to do this before we had proper lexical scoping
in the bytecode generator. There is absolutely no reason
why need to allocate a top-level "var" activation when a
function/program uses a "catch" block.

* parser/ASTBuilder.h:
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::incConstants):
(JSC::ASTBuilder::usesThis):
(JSC::ASTBuilder::usesArguments):
(JSC::ASTBuilder::usesWith):
(JSC::ASTBuilder::usesEval):
(JSC::ASTBuilder::usesCatch): Deleted.
* parser/Nodes.h:
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivation):
(JSC::ScopeNode::hasCapturedVariables):
(JSC::ScopeNode::captures):
(JSC::ScopeNode::needsActivationForMoreThanVariables): Deleted.
* parser/ParserModes.h:
* runtime/Executable.h:
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::ecmaMode):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/ParserModes.h
trunk/Source/_javascript_Core/runtime/Executable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189818 => 189819)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:00:13 UTC (rev 189818)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:26:45 UTC (rev 189819)
@@ -1,3 +1,39 @@
+2015-09-15  Saam barati  
+
+functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary
+https://bugs.webkit.org/show_bug.cgi?id=148169
+
+Reviewed by Geoffrey Garen.
+
+We used to do this before we had proper lexical scoping
+in the bytecode generator. There is absolutely no reason
+why need to allocate a top-level "var" activation when a
+function/program uses a "catch" block.
+
+* parser/ASTBuilder.h:
+(JSC::ASTBuilder::createTryStatement):
+(JSC::ASTBuilder::incConstants):
+(JSC::ASTBuilder::usesThis):
+(JSC::ASTBuilder::usesArguments):
+(JSC::ASTBuilder::usesWith):
+(JSC::ASTBuilder::usesEval):
+(JSC::ASTBuilder::usesCatch): Deleted.
+* parser/Nodes.h:
+(JSC::ScopeNode::isStrictMode):
+(JSC::ScopeNode::setUsesArguments):
+(JSC::ScopeNode::usesThis):
+(JSC::ScopeNode::needsActivation):
+(JSC::ScopeNode::hasCapturedVariables):
+(JSC::ScopeNode::captures):
+(JSC::ScopeNode::needsActivationForMoreThanVariables): Deleted.
+* parser/ParserModes.h:
+* runtime/Executable.h:
+(JSC::ScriptExecutable::usesEval):
+(JSC::ScriptExecutable::usesArguments):
+(JSC::ScriptExecutable::needsActivation):
+(JSC::ScriptExecutable::isStrictMode):
+(JSC::ScriptExecutable::ecmaMode):
+
 2015-09-15  Michael Saboff  
 
 REGRESSION(r189774): CLoop doesn't build after r189774


Modified: trunk/Source/_javascript_Core/parser/ASTBuilder.h (189818 => 189819)

--- trunk/Source/_javascript_Core/parser/ASTBuilder.h	2015-09-15 19:00:13 UTC (rev 189818)
+++ trunk/Source/_javascript_Core/parser/ASTBuilder.h	2015-09-15 19:26:45 UTC (rev 189819)
@@ -571,8 +571,6 @@
 StatementNode* createTryStatement(const JSTokenLocation& location, StatementNode* tryBlock, const Identifier* ident, StatementNode* catchBlock, StatementNode* finallyBlock, int startLine, int endLine, VariableEnvironment& catchEnvironment)
 {
 TryNode* result = new (m_parserArena) TryNode(location, tryBlock, *ident, catchBlock, catchEnvironment, finallyBlock);
-if (catchBlock)
-usesCatch();
 result->setLoc(startLine, endLine, location.startOffset, location.lineStartOffset);
 return result;
 }
@@ -878,7 +876,6 @@
 
 void incConstants() { m_scope.m_numConstants++; }
 void usesThis() { m_scope.m_features |= ThisFeature; }
-void usesCatch() { m_scope.m_features |= CatchFeature; }
 void usesArguments() { m_scope.m_features |= ArgumentsFeature; }
 void usesWith() { m_scope.m_features |= WithFeature; }
 void usesEval() 


Modified: trunk/Source/_javascript_Core/parser/Nodes.h (189818 => 189819)

--- trunk/Source/_javascript_Core/parser/Nodes.h	2015-09-15 19:00:13 UTC (rev 189818)
+++ trunk/Source/_javascript_Core/parser/Nodes.h	2015-09-15 19:26:45 UTC (rev 189819)
@@ -1554,8 +1554,7 @@
 bool isStrictMode() 

[webkit-changes] [189821] trunk/Source/WebCore

2015-09-15 Thread bfulgham
Title: [189821] trunk/Source/WebCore








Revision 189821
Author bfulg...@apple.com
Date 2015-09-15 12:56:34 -0700 (Tue, 15 Sep 2015)


Log Message
[Win] Tiled drawing is rendering more times than it should
https://bugs.webkit.org/show_bug.cgi?id=149144


Reviewed by Simon Fraser.

Provide a more faithful implemenation of the Objective C tiled drawing logic.
(1) Create a new WebTiledBackingLayerWin class that represents a the
container of tiles. This matches the Objective C design.
(2) Move implementation of several methods (e.g., isOpaque) to the internal
class implementation so that the Tile Drawing logic can perform special
handling in these cases.
(3) Remove the duplicated Tiled Drawing logic from PlatformCALayerWinInternal,
since it was just duplicating code in TileController and TileGrid.
(4) Clean up the display callback code to avoid performing incorrect flipping
of the coordinate system.

* PlatformAppleWin.cmake: Add new WebTiledBackingLayerWin file.
* WebCore.vcxproj/WebCore.vcxproj: Add the new WebTiledBackingLayerWin files.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* platform/graphics/ca/PlatformCALayer.cpp:
(PlatformCALayer::flipContext): Added convenience method.
(PlatformCALayer::drawRepaintIndicator): Ditto.
* platform/graphics/ca/TileGrid.cpp:
(TileGrid::platformCALayerPaintContents): Flip the context before drawing the repaint
indicator on Windows.
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::PlatformCALayerWin): Create a WebTiledBackingLayerWin
object if using tiled drawing.
(PlatformCALayerWin::~PlatformCALayerWin):
(PlatformCALayerWin::isOpaque): Move implementation to internal class.
(PlatformCALayerWin::setOpaque): Ditto.
(PlatformCALayerWin::setBorderWidth): Ditto.
(PlatformCALayerWin::setBorderColor): Ditto.
(PlatformCALayerWin::contentsScale): Ditto.
(PlatformCALayerWin::setContentsScale): Ditto.
(PlatformCALayerWin::cornerRadius): Ditto.
(PlatformCALayerWin::tiledBacking): Ditto.
(PlatformCALayerWin::drawTextAtPoint): New helper method to draw repaint counter
text. Needed to work around bug in CG.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::PlatformCALayerWinInternal): Remove tiling-logic
related member variables.
(PlatformCALayerWinInternal::~PlatformCALayerWinInternal):
(shouldInvertBeforeDrawingContent): Added convenience method.
(shouldInvertBeforeDrawingRepaintCounters): Ditto.
(PlatformCALayerWinInternal::displayCallback):
(PlatformCALayerWinInternal::drawRepaintCounters): Helper method to
share code between the two layer classes.
(PlatformCALayerWinInternal::internalSetNeedsDisplay): use nullptr.
(PlatformCALayerWinInternal::setNeedsDisplay): Ditto.
(PlatformCALayerWinInternal::setNeedsDisplayInRect): Move tiled code
to WebTiledBackingLayerWin and simplify the remaing code.
(PlatformCALayerWinInternal::setSublayers): Remove tile code.
(PlatformCALayerWinInternal::getSublayers): Ditto.
(PlatformCALayerWinInternal::removeAllSublayers): Ditto.
(PlatformCALayerWinInternal::insertSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerCount): Ditto.
(PlatformCALayerWinInternal::indexOfSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerAtIndex): Ditto.
(PlatformCALayerWinInternal::setBounds): Ditto.
(PlatformCALayerWinInternal::setFrame): Ditto.
(PlatformCALayerWinInternal::isOpaque): Ditto.
(PlatformCALayerWinInternal::setOpaque): Ditto.
(PlatformCALayerWinInternal::contentsScale): Ditto.
(PlatformCALayerWinInternal::setContentsScale): Ditto.
(PlatformCALayerWinInternal::setBorderWidth): Ditto.
(PlatformCALayerWinInternal::setBorderColor): Ditto.
(layerTypeIsTiled): Deleted.
(PlatformCALayerWinInternal::constrainedSize): Deleted.
(PlatformCALayerWinInternal::tileDisplayCallback): Deleted.
(PlatformCALayerWinInternal::addTile): Deleted.
(PlatformCALayerWinInternal::removeTile): Deleted.
(PlatformCALayerWinInternal::tileAtIndex): Deleted.
(PlatformCALayerWinInternal::tileCount): Deleted.
(PlatformCALayerWinInternal::updateTiles): Deleted.
(PlatformCALayerWinInternal::drawTile): Deleted.
(PlatformCALayerWinInternal::createTileController): Deleted.
(PlatformCALayerWinInternal::tiledBacking): Deleted.
* platform/graphics/ca/win/PlatformCALayerWinInternal.h:
(WebCore::PlatformCALayerWinInternal::owner):
* platform/graphics/ca/win/WebTiledBackingLayerWin.cpp: Added.
(WebTiledBackingLayerWin::WebTiledBackingLayerWin):
(WebTiledBackingLayerWin::~WebTiledBackingLayerWin):
(DisplayOnMainThreadContext::DisplayOnMainThreadContext):
(redispatchOnMainQueue):
(WebTiledBackingLayerWin::displayCallback):
(WebTiledBackingLayerWin::setNeedsDisplay):
(WebTiledBackingLayerWin::setNeedsDisplayInRect):
(WebTiledBackingLayerWin::setBounds):
(WebTiledBackingLayerWin::isOpaque):
(WebTiledBackingLayerWin::setOpaque):
(WebTiledBackingLayerWin::contentsScale):
(WebTiledBackingLayerWin::setContentsScale):
(WebTiledBackingLayerWin::setBorderWidth):
(WebTiledBackingLayerWin::setBorderColor):

[webkit-changes] [189820] trunk/Source/JavaScriptCore

2015-09-15 Thread ossy
Title: [189820] trunk/Source/_javascript_Core








Revision 189820
Author o...@webkit.org
Date 2015-09-15 12:47:34 -0700 (Tue, 15 Sep 2015)


Log Message
Fix the !ENABLE(DFG_JIT) build after r188696
https://bugs.webkit.org/show_bug.cgi?id=149158

Reviewed by Yusuke Suzuki.

* bytecode/GetByIdStatus.cpp:
* bytecode/GetByIdStatus.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp
trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189819 => 189820)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:26:45 UTC (rev 189819)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:47:34 UTC (rev 189820)
@@ -1,3 +1,13 @@
+2015-09-15  Csaba Osztrogonác  
+
+Fix the !ENABLE(DFG_JIT) build after r188696
+https://bugs.webkit.org/show_bug.cgi?id=149158
+
+Reviewed by Yusuke Suzuki.
+
+* bytecode/GetByIdStatus.cpp:
+* bytecode/GetByIdStatus.h:
+
 2015-09-15  Saam barati  
 
 functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary


Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp (189819 => 189820)

--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp	2015-09-15 19:26:45 UTC (rev 189819)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp	2015-09-15 19:47:34 UTC (rev 189820)
@@ -119,7 +119,7 @@
 return result;
 }
 
-#if ENABLE(JIT)
+#if ENABLE(DFG_JIT)
 GetByIdStatus GetByIdStatus::computeForStubInfo(const ConcurrentJITLocker& locker, CodeBlock* profiledBlock, StructureStubInfo* stubInfo, CodeOrigin codeOrigin, UniquedStringImpl* uid)
 {
 GetByIdStatus result = GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback(
@@ -130,7 +130,7 @@
 return GetByIdStatus(result.makesCalls() ? GetByIdStatus::MakesCalls : GetByIdStatus::TakesSlowPath, true);
 return result;
 }
-#endif // ENABLE(JIT)
+#endif // ENABLE(DFG_JIT)
 
 #if ENABLE(JIT)
 GetByIdStatus GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback(


Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h (189819 => 189820)

--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h	2015-09-15 19:26:45 UTC (rev 189819)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h	2015-09-15 19:47:34 UTC (rev 189820)
@@ -72,7 +72,7 @@
 
 static GetByIdStatus computeFor(CodeBlock* baselineBlock, CodeBlock* dfgBlock, StubInfoMap& baselineMap, StubInfoMap& dfgMap, CodeOrigin, UniquedStringImpl* uid);
 
-#if ENABLE(JIT)
+#if ENABLE(DFG_JIT)
 static GetByIdStatus computeForStubInfo(const ConcurrentJITLocker&, CodeBlock* baselineBlock, StructureStubInfo*, CodeOrigin, UniquedStringImpl* uid);
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [189822] trunk/Source/JavaScriptCore

2015-09-15 Thread commit-queue
Title: [189822] trunk/Source/_javascript_Core








Revision 189822
Author commit-qu...@webkit.org
Date 2015-09-15 13:00:23 -0700 (Tue, 15 Sep 2015)


Log Message
Implement calls to _javascript_ functions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149093

Patch by Sukolsak Sakshuwong  on 2015-09-15
Reviewed by Filip Pizlo.

This patch implements calls to _javascript_ functions in WebAssembly.
WebAssembly functions can only call _javascript_ functions that are
imported to their module via an object that is passed into
loadWebAssembly(). References to _javascript_ functions are resolved at
the module's load time, just like asm.js.

* jsc.cpp:
(GlobalObject::finishCreation):
(functionLoadWebAssembly):
* tests/stress/wasm-calls.js:
* tests/stress/wasm/calls.wasm:
* wasm/JSWASMModule.cpp:
(JSC::JSWASMModule::visitChildren):
* wasm/JSWASMModule.h:
(JSC::JSWASMModule::importedFunctions):
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::buildCallImport):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseCallImport):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::buildCallInternal):
(JSC::WASMFunctionSyntaxChecker::buildCallImport):
(JSC::WASMFunctionSyntaxChecker::updateTempStackHeightForCall):
* wasm/WASMModuleParser.cpp:
(JSC::WASMModuleParser::WASMModuleParser):
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseFunctionImportSection):
(JSC::WASMModuleParser::getImportedValue):
(JSC::parseWebAssembly):
* wasm/WASMModuleParser.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/tests/stress/wasm/calls.wasm
trunk/Source/_javascript_Core/tests/stress/wasm-calls.js
trunk/Source/_javascript_Core/wasm/JSWASMModule.cpp
trunk/Source/_javascript_Core/wasm/JSWASMModule.h
trunk/Source/_javascript_Core/wasm/WASMFunctionCompiler.h
trunk/Source/_javascript_Core/wasm/WASMFunctionParser.cpp
trunk/Source/_javascript_Core/wasm/WASMFunctionParser.h
trunk/Source/_javascript_Core/wasm/WASMFunctionSyntaxChecker.h
trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp
trunk/Source/_javascript_Core/wasm/WASMModuleParser.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189821 => 189822)

--- trunk/Source/_javascript_Core/ChangeLog	2015-09-15 19:56:34 UTC (rev 189821)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-15 20:00:23 UTC (rev 189822)
@@ -1,3 +1,45 @@
+2015-09-15  Sukolsak Sakshuwong  
+
+Implement calls to _javascript_ functions in WebAssembly
+https://bugs.webkit.org/show_bug.cgi?id=149093
+
+Reviewed by Filip Pizlo.
+
+This patch implements calls to _javascript_ functions in WebAssembly.
+WebAssembly functions can only call _javascript_ functions that are
+imported to their module via an object that is passed into
+loadWebAssembly(). References to _javascript_ functions are resolved at
+the module's load time, just like asm.js.
+
+* jsc.cpp:
+(GlobalObject::finishCreation):
+(functionLoadWebAssembly):
+* tests/stress/wasm-calls.js:
+* tests/stress/wasm/calls.wasm:
+* wasm/JSWASMModule.cpp:
+(JSC::JSWASMModule::visitChildren):
+* wasm/JSWASMModule.h:
+(JSC::JSWASMModule::importedFunctions):
+* wasm/WASMFunctionCompiler.h:
+(JSC::WASMFunctionCompiler::buildCallImport):
+* wasm/WASMFunctionParser.cpp:
+(JSC::WASMFunctionParser::parseExpressionI32):
+(JSC::WASMFunctionParser::parseExpressionF64):
+(JSC::WASMFunctionParser::parseCallImport):
+* wasm/WASMFunctionParser.h:
+* wasm/WASMFunctionSyntaxChecker.h:
+(JSC::WASMFunctionSyntaxChecker::buildCallInternal):
+(JSC::WASMFunctionSyntaxChecker::buildCallImport):
+(JSC::WASMFunctionSyntaxChecker::updateTempStackHeightForCall):
+* wasm/WASMModuleParser.cpp:
+(JSC::WASMModuleParser::WASMModuleParser):
+(JSC::WASMModuleParser::parse):
+(JSC::WASMModuleParser::parseModule):
+(JSC::WASMModuleParser::parseFunctionImportSection):
+(JSC::WASMModuleParser::getImportedValue):
+(JSC::parseWebAssembly):
+* wasm/WASMModuleParser.h:
+
 2015-09-15  Csaba Osztrogonác  
 
 Fix the !ENABLE(DFG_JIT) build after r188696


Modified: trunk/Source/_javascript_Core/jsc.cpp (189821 => 189822)

--- trunk/Source/_javascript_Core/jsc.cpp	2015-09-15 19:56:34 UTC (rev 189821)
+++ trunk/Source/_javascript_Core/jsc.cpp	2015-09-15 20:00:23 UTC (rev 189822)
@@ -679,7 +679,7 @@
 addFunction(vm, "drainMicrotasks", functionDrainMicrotasks, 0);
 
 #if ENABLE(WEBASSEMBLY)
-addFunction(vm, "loadWebAssembly", functionLoadWebAssembly, 1);
+   

[webkit-changes] [189824] trunk/Source/WebCore

2015-09-15 Thread rniwa
Title: [189824] trunk/Source/WebCore








Revision 189824
Author rn...@webkit.org
Date 2015-09-15 14:31:31 -0700 (Tue, 15 Sep 2015)


Log Message
ContentDistribution should be only used for details elements
https://bugs.webkit.org/show_bug.cgi?id=149148

Reviewed by Antti Koivisto.

Extracted ShadowRootWithInsertionPoints out of ShadowRoot for HTMLDetailsElement and HTMLSummaryElement.

We don't add a separate .h and .cpp files since this is a temporary measure until we replace it with
a slot-based shadow DOM implementation.

No new tests. There should be no observable behavioral change.

* dom/Element.cpp:
(WebCore::Element::addShadowRoot): Removed the call to didShadowBoundaryChange since this function is only
called in ensureUserAgentShadowRoot. Also moved the call to didAddUserAgentShadowRoot for
HTMLDetailsElement's shadow root which uses this function instead of ensureUserAgentShadowRoot.
(WebCore::Element::removeShadowRoot): Removed the call to invalidateDistribution since it's only called by
~Element.
(WebCore::Element::createShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot): Moved the call didAddUserAgentShadowRoot into addShadowRoot
since HTMLDetailsElement uses a subclass of ShadowRoot.
(WebCore::Element::childrenChanged):
(WebCore::Element::removeAllEventListeners):

* dom/Element.h:
(Element::addShadowRoot): Made this function a protected member as it's now used by HTMLDetailsElement.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::childrenChanged): Deleted.

* dom/ShadowRoot.h:
(WebCore::ShadowRoot::distributor): Made this a virtual function and return nullptr by default.
(WebCore::ShadowRoot::isOrphan):

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::create): Uses ShadowRootWithInsertionPoints instead of ShadowRoot.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::runPostTypeUpdateTasks): Removed the call to invalidateDistribution since it's
only relevant for HTMLDetailsElement's shadow DOM.

* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create): Uses ShadowRootWithInsertionPoints instead of ShadowRoot.

* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::ensureDistribution):
(WebCore::ContentDistributor::invalidateDistribution):

* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::childrenChanged):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
(WebCore::findInsertionPointOf):
(WebCore::ShadowRootWithInsertionPoints::childrenChanged): Moved from ShadowRoot.

* html/shadow/InsertionPoint.h:
(WebCore::ShadowRootWithInsertionPoints::create): Added.
(WebCore::ShadowRootWithInsertionPoints::ShadowRootWithInsertionPoints): Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
trunk/Source/WebCore/html/shadow/ContentDistributor.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189823 => 189824)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 20:42:22 UTC (rev 189823)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 21:31:31 UTC (rev 189824)
@@ -1,3 +1,65 @@
+2015-09-15  Ryosuke Niwa  
+
+ContentDistribution should be only used for details elements
+https://bugs.webkit.org/show_bug.cgi?id=149148
+
+Reviewed by Antti Koivisto.
+
+Extracted ShadowRootWithInsertionPoints out of ShadowRoot for HTMLDetailsElement and HTMLSummaryElement.
+
+We don't add a separate .h and .cpp files since this is a temporary measure until we replace it with
+a slot-based shadow DOM implementation.
+
+No new tests. There should be no observable behavioral change.
+
+* dom/Element.cpp:
+(WebCore::Element::addShadowRoot): Removed the call to didShadowBoundaryChange since this function is only
+called in ensureUserAgentShadowRoot. Also moved the call to didAddUserAgentShadowRoot for
+HTMLDetailsElement's shadow root which uses this function instead of ensureUserAgentShadowRoot.
+(WebCore::Element::removeShadowRoot): Removed the call to invalidateDistribution since it's only called by
+~Element.
+(WebCore::Element::createShadowRoot):
+(WebCore::Element::ensureUserAgentShadowRoot): Moved the call didAddUserAgentShadowRoot into addShadowRoot
+since HTMLDetailsElement uses a subclass of ShadowRoot.
+(WebCore::Element::childrenChanged):
+(WebCore::Element::removeAllEventListeners):
+
+* dom/Element.h:
+(Element::addShadowRoot): Made this function a protected member as it's now used by HTMLDetailsElement.
+
+* 

[webkit-changes] [189825] trunk

2015-09-15 Thread cdumez
Title: [189825] trunk








Revision 189825
Author cdu...@apple.com
Date 2015-09-15 14:39:02 -0700 (Tue, 15 Sep 2015)


Log Message
Element.getAttributeNS() should return null if the attribute does not exist
https://bugs.webkit.org/show_bug.cgi?id=149180


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM tests now that more checks are passing.

* web-platform-tests/dom/nodes/attributes-expected.txt:
* web-platform-tests/dom/nodes/case-expected.txt:

Source/WebCore:

Element.getAttributeNS() should return null if the attribute does not
exist, similarly to what Element.getAttribute() does:
- https://dom.spec.whatwg.org/#element (both return a nullable DOMString).
- https://dom.spec.whatwg.org/#dom-element-getattributens (step 2)

Firefox and Chrome match the specification. However, WebKit was returning
an empty string for getAttributeNS() and null for getAttribute(). This
patch aligns WebKit's behavior with the specification and other browsers.

No new tests, already covered by existing tests.

* dom/Element.idl:

LayoutTests:

Rebaseline / update existing tests now that our behavior has changed.

* fast/dom/Element/attribute-uppercase-expected.txt:
* fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt:
* fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html:
* fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-expected.txt:
* fast/dom/Element/setAttributeNode-overriding-lowercase-values-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Element/attribute-uppercase-expected.txt
trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt
trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html
trunk/LayoutTests/fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-expected.txt
trunk/LayoutTests/fast/dom/Element/setAttributeNode-overriding-lowercase-values-2-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/case-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (189824 => 189825)

--- trunk/LayoutTests/ChangeLog	2015-09-15 21:31:31 UTC (rev 189824)
+++ trunk/LayoutTests/ChangeLog	2015-09-15 21:39:02 UTC (rev 189825)
@@ -1,5 +1,21 @@
 2015-09-15  Chris Dumez  
 
+Element.getAttributeNS() should return null if the attribute does not exist
+https://bugs.webkit.org/show_bug.cgi?id=149180
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline / update existing tests now that our behavior has changed.
+
+* fast/dom/Element/attribute-uppercase-expected.txt:
+* fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt:
+* fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html:
+* fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-expected.txt:
+* fast/dom/Element/setAttributeNode-overriding-lowercase-values-2-expected.txt:
+
+2015-09-15  Chris Dumez  
+
 Unreviewed, rebaseline several W3C HTML tests on iOS after r189762.
 
 * platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:


Modified: trunk/LayoutTests/fast/dom/Element/attribute-uppercase-expected.txt (189824 => 189825)

--- trunk/LayoutTests/fast/dom/Element/attribute-uppercase-expected.txt	2015-09-15 21:31:31 UTC (rev 189824)
+++ trunk/LayoutTests/fast/dom/Element/attribute-uppercase-expected.txt	2015-09-15 21:39:02 UTC (rev 189825)
@@ -23,7 +23,7 @@
 
 The following should be empty, false, or null.
 
-getAttributeNS(ATTR_NAME) = 
+getAttributeNS(ATTR_NAME) = null
 hasAttributeNS(ATTR_NAME) = false
 getAttributeNodeNS(ATTR_NAME) = null
 attributes.getNamedItemNS(ATTR_NAME) = null


Modified: trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt (189824 => 189825)

--- trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt	2015-09-15 21:31:31 UTC (rev 189824)
+++ trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt	2015-09-15 21:39:02 UTC (rev 189825)
@@ -4,7 +4,7 @@
 
 
 PASS document.documentElement.hasAttributeNS("", "aa") is false
-PASS document.documentElement.getAttributeNS("", "aa") is ""
+PASS document.documentElement.getAttributeNS("", "aa") is null
 PASS document.documentElement.hasAttributeNS("", "AA") is true
 PASS document.documentElement.getAttributeNS("", "AA") is "UPPERCASE"
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html (189824 => 189825)

--- trunk/LayoutTests/fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html	2015-09-15 21:31:31 UTC (rev 189824)
+++ 

[webkit-changes] [189823] trunk/LayoutTests

2015-09-15 Thread cdumez
Title: [189823] trunk/LayoutTests








Revision 189823
Author cdu...@apple.com
Date 2015-09-15 13:42:22 -0700 (Tue, 15 Sep 2015)


Log Message
Unreviewed, rebaseline several W3C HTML tests on iOS after r189762.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
* platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (189822 => 189823)

--- trunk/LayoutTests/ChangeLog	2015-09-15 20:00:23 UTC (rev 189822)
+++ trunk/LayoutTests/ChangeLog	2015-09-15 20:42:22 UTC (rev 189823)
@@ -1,3 +1,10 @@
+2015-09-15  Chris Dumez  
+
+Unreviewed, rebaseline several W3C HTML tests on iOS after r189762.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
+
 2015-09-14  David Hyatt  
 
 2015-09-14  David Hyatt  


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (189822 => 189823)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-09-15 20:00:23 UTC (rev 189822)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-09-15 20:42:22 UTC (rev 189823)
@@ -553,6 +553,7 @@
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'validationMessage' on a non-HTMLFieldSetElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'form' on a non-HTMLLegendElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'align' on a non-HTMLLegendElement object.
+CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'open' on a non-HTMLDetailsElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'compact' on a non-HTMLMenuElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'src' on a non-HTMLScriptElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'type' on a non-HTMLScriptElement object.
@@ -5089,12 +5090,16 @@
 PASS ValidityState interface: document.createElement("input").validity must inherit property "badInput" with the proper type (8) 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "customError" with the proper type (9) 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "valid" with the proper type (10) 
-FAIL HTMLDetailsElement interface: existence and properties of interface object assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface object length assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: existence and properties of interface prototype object assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: attribute open assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement must be primary interface of document.createElement("details") assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
+FAIL HTMLDetailsElement interface: existence and properties of interface object assert_equals: prototype of self's property "HTMLDetailsElement" is not Function.prototype expected (function) function "function () {
+[native code]
+}" but got (object) object "[object Object]"
+PASS HTMLDetailsElement interface object length 
+PASS HTMLDetailsElement interface: existence and properties of interface prototype object 
+FAIL HTMLDetailsElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLDetailsElement.prototype.constructor is not writable expected true got false
+FAIL HTMLDetailsElement interface: attribute open assert_throws: getting property on prototype object must throw TypeError function "function () {
+[native code]
+}" did not throw
+PASS 

[webkit-changes] [189806] trunk/Source/WebCore

2015-09-15 Thread jfernandez
Title: [189806] trunk/Source/WebCore








Revision 189806
Author jfernan...@igalia.com
Date 2015-09-15 07:48:41 -0700 (Tue, 15 Sep 2015)


Log Message
[CSS Grid Layout] Using {row, column}-axis terms in alignment related logic
https://bugs.webkit.org/show_bug.cgi?id=148942

Reviewed by Sergio Villar Senin.

This patch changes the names of several functions and variables
defined to implement the alignment logic. We want to use from now
on the terms row-axis and column-axis when referring to the
alignment direction the logic is applied to.

No new tests, no new functionality.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
* rendering/RenderGrid.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189805 => 189806)

--- trunk/Source/WebCore/ChangeLog	2015-09-15 11:06:10 UTC (rev 189805)
+++ trunk/Source/WebCore/ChangeLog	2015-09-15 14:48:41 UTC (rev 189806)
@@ -1,3 +1,23 @@
+2015-09-15  Javier Fernandez  
+
+[CSS Grid Layout] Using {row, column}-axis terms in alignment related logic
+https://bugs.webkit.org/show_bug.cgi?id=148942
+
+Reviewed by Sergio Villar Senin.
+
+This patch changes the names of several functions and variables
+defined to implement the alignment logic. We want to use from now
+on the terms row-axis and column-axis when referring to the
+alignment direction the logic is applied to.
+
+No new tests, no new functionality.
+
+* rendering/RenderGrid.cpp:
+(WebCore::RenderGrid::columnAxisOffsetForChild):
+(WebCore::RenderGrid::rowAxisOffsetForChild):
+(WebCore::RenderGrid::findChildLogicalPosition):
+* rendering/RenderGrid.h:
+
 2015-09-14  Gyuyoung Kim  
 
 Remove all uses of PassRefPtr in WebCore/xml


Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (189805 => 189806)

--- trunk/Source/WebCore/rendering/RenderGrid.cpp	2015-09-15 11:06:10 UTC (rev 189805)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp	2015-09-15 14:48:41 UTC (rev 189806)
@@ -1526,7 +1526,7 @@
 return GridAxisStart;
 }
 
-LayoutUnit RenderGrid::rowPositionForChild(const RenderBox& child) const
+LayoutUnit RenderGrid::columnAxisOffsetForChild(const RenderBox& child) const
 {
 const GridCoordinate& coordinate = cachedGridCoordinate(child);
 LayoutUnit startOfRow = m_rowPositions[coordinate.rows.resolvedInitialPosition.toInt()];
@@ -1550,7 +1550,7 @@
 }
 
 
-LayoutUnit RenderGrid::columnPositionForChild(const RenderBox& child) const
+LayoutUnit RenderGrid::rowAxisOffsetForChild(const RenderBox& child) const
 {
 const GridCoordinate& coordinate = cachedGridCoordinate(child);
 LayoutUnit startOfColumn = m_columnPositions[coordinate.columns.resolvedInitialPosition.toInt()];
@@ -1575,14 +1575,17 @@
 
 LayoutPoint RenderGrid::findChildLogicalPosition(const RenderBox& child) const
 {
-LayoutUnit columnPosition = columnPositionForChild(child);
+LayoutUnit rowAxisOffset = rowAxisOffsetForChild(child);
 // We stored m_columnPositions's data ignoring the direction, hence we might need now
 // to translate positions from RTL to LTR, as it's more convenient for painting.
-if (!style().isLeftToRightDirection())
-columnPosition = (m_columnPositions[m_columnPositions.size() - 1] + borderAndPaddingLogicalLeft()) - columnPosition  - child.logicalWidth();
+if (!style().isLeftToRightDirection()) {
+LayoutUnit alignmentOffset =  m_columnPositions[0] - borderAndPaddingStart();
+LayoutUnit rightGridEdgePosition = m_columnPositions[m_columnPositions.size() - 1] + alignmentOffset + borderAndPaddingLogicalLeft();
+rowAxisOffset = rightGridEdgePosition - (rowAxisOffset + child.logicalWidth());
+}
 
 // The grid items should be inside the grid container's border box, that's why they need to be shifted.
-return LayoutPoint(columnPosition, rowPositionForChild(child));
+return LayoutPoint(rowAxisOffset, columnAxisOffsetForChild(child));
 }
 
 void RenderGrid::paintChildren(PaintInfo& paintInfo, const LayoutPoint& paintOffset, PaintInfo& forChild, bool usePrintRect)


Modified: trunk/Source/WebCore/rendering/RenderGrid.h (189805 => 189806)

--- trunk/Source/WebCore/rendering/RenderGrid.h	2015-09-15 11:06:10 UTC (rev 189805)
+++ trunk/Source/WebCore/rendering/RenderGrid.h	2015-09-15 14:48:41 UTC (rev 189806)
@@ -120,8 +120,8 @@
 LayoutUnit maxContentForChild(RenderBox&, GridTrackSizingDirection, Vector& columnTracks);
 GridAxisPosition columnAxisPositionForChild(const RenderBox&) const;
 GridAxisPosition rowAxisPositionForChild(const RenderBox&) const;
-LayoutUnit rowPositionForChild(const RenderBox&) const;
-LayoutUnit