[webkit-changes] [190660] trunk

2015-10-06 Thread mcatanzaro 
Title: [190660] trunk








Revision 190660
Author mcatanz...@igalia.com
Date 2015-10-06 21:08:25 -0700 (Tue, 06 Oct 2015)


Log Message
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588

Reviewed by Darin Adler.

Source/WebCore:

* PlatformGTK.cmake:
* bindings/scripts/gobject-generate-headers.pl:

Source/WebKit2:

* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAutocleanups.h: Added.
* UIProcess/API/gtk/webkit2.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/bindings/scripts/gobject-generate-headers.pl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAutocleanups.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190659 => 190660)

--- trunk/Source/WebCore/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/ChangeLog	2015-10-07 04:08:25 UTC (rev 190660)
@@ -1,3 +1,13 @@
+2015-10-06  Michael Catanzaro  
+
+[GTK] Add autocleanups
+https://bugs.webkit.org/show_bug.cgi?id=149588
+
+Reviewed by Darin Adler.
+
+* PlatformGTK.cmake:
+* bindings/scripts/gobject-generate-headers.pl:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/Source/WebCore/PlatformGTK.cmake (190659 => 190660)

--- trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 04:08:25 UTC (rev 190660)
@@ -559,6 +559,8 @@
 bindings/gobject/WebKitDOMObject.cpp
 bindings/gobject/WebKitDOMPrivate.cpp
 bindings/gobject/WebKitDOMXPathNSResolver.cpp
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
@@ -774,6 +776,7 @@
 
 set(GObjectDOMBindingsStable_CLASS_LIST ${GObjectDOMBindings_STATIC_CLASS_LIST})
 set(GObjectDOMBindingsStable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h
@@ -785,6 +788,7 @@
 )
 
 set(GObjectDOMBindingsUnstable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustomUnstable.h
 )
@@ -826,6 +830,18 @@
 COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl gdom > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
 )
 
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+)
+
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsUnstable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+)
+
 # Some of the static headers are included by generated public headers with include .
 # We need those headers in the derived sources to be in webkitdom directory.
 set(GObjectDOMBindings_STATIC_HEADER_NAMES ${GObjectDOMBindings_STATIC_CLAS

[webkit-changes] [190659] trunk/LayoutTests

2015-10-06 Thread jhoneycutt 
Title: [190659] trunk/LayoutTests








Revision 190659
Author jhoneyc...@apple.com
Date 2015-10-06 20:35:26 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed iOS test gardening after r190629.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190658 => 190659)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
@@ -1,3 +1,10 @@
+2015-10-06  Jon Honeycutt  
+
+Unreviewed iOS test gardening after r190629.
+
+* platform/ios-simulator/TestExpectations:
+* platform/ios-simulator-wk1/TestExpectations:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (190658 => 190659)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 03:35:26 UTC (rev 190659)
@@ -2798,45 +2798,60 @@
 streams/reference-implementation/readable-stream-cancel.html [ Failure Pass ]
 compositing/visible-rect/coverage-scrolling.html [ Failure Pass ]
 
-# Imported Blink tests. (Oct 1, 2015)
-imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure ]
+# Imported Blink tests.
+imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
+imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
+imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
 imported/blink/compositing/overflow/body-switch-composited-scrolling.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure ]
-imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure ]
+imported/blink/compositing/reorder-z-with-style.html [ Timeout ]
+imported/blink/compositing/squashing/invalidate-on-grouped-mapping-reorder.html [ Pass Timeout ]
+imported/blink/css3/calc/transition-asan-crash.html [ Pass Timeout ]
+imported/blink/editing/execCommand/4128080-2.html [ Failure Pass ]
+imported/blink/fast/canvas/bug382588.html [ Pass Timeout ]
+imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/css/border-current-color.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure ]
-imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure ]
+imported/blink/fast/css/crash-corner-present.html [ Skip ]
+imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/events/popup-forwarded-gesture.html [ Skip ]
+imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/images/image-hover-display-alt.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/dynamic/remove-spanner-in-content.html [ ImageOnlyFailure ]
+imported/blink/fast/images/image-hover-display-alt.html [ Pass Timeout ]
+imported/blink/fast/inline/reparent-inline-box.html [ Pass Timeout ]
+imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/dynamic/remove-spanner-in-content.html [ ImageOnlyFailure Pass ]
 imported

[webkit-changes] [190658] trunk

2015-10-06 Thread zalan 
Title: [190658] trunk








Revision 190658
Author za...@apple.com
Date 2015-10-06 19:51:29 -0700 (Tue, 06 Oct 2015)


Log Message
Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920

Reviewed by Simon Fraser.

When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.

When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.

Source/WebCore:

Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html

* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):

LayoutTests:

* css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
* fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
* fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
* fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt
trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp


Added Paths

trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt
trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190657 => 190658)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 02:51:29 UTC (rev 190658)
@@ -1,3 +1,26 @@
+2015-10-06  Zalan Bujtas  
+
+Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
+https://bugs.webkit.org/show_bug.cgi?id=149535
+rdar://problem/22874920
+
+Reviewed by Simon Fraser.
+
+When due to some style change, a renderer's self-painting layer is getting destroyed 
+and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
+
+When a renderer has a self-painting layer, the parent stops tracking the child's 
+visual overflow rect. All overflow painting is delegated to the self-painting layer.
+However when this layer gets destroyed, no-one issues repaint to clean up
+the overflow bits.
+This patch ensures that we issue a repaint when the self-painting layer is destroyed
+and the triggering style change requires full repaint.
+
+* css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
+* fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
+* fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
+* fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.
+
 2015-10-06  Jon Honeycutt  
 
 More unreviewed Windows test gardening after r190629.


Modified: trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt (190657 => 190658)

--- trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt	2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt	2015-10-07 02:51:29 UTC (rev 190658)
@@ -19,6 +19,7 @@
   (rect 48 172 60 60)
   (rect 28 290 60 60)
   (rect 48 290 60 60)
+  (rect 28 290 60 60)
   (rect 48 290 60 60)
   (rect 48 408 60 60)
   (rect 48 408 60 60)
@@ -26,6 +27,7 @@
   (rect 48 526 60 60)
   (rect 48 644 60 60)
   (rect 68 644 60 60)
+  (rect 48 644 60 60)
   (rect 68 644 60 60)
   (rect 28 290 60 60)
   (rect 48 644 60 60)


Modified: trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt (190657 => 190658)

--- trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt	2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt	2015-10-07 02:51:29 UTC (rev 190658)
@@ -2,6 +2,7 @@
   (rect 8 5000 100 100)
   (rect 108 5100 100 100)
   (rect 8 8 784 2000)
+  (rect 8 5000 100 100)
   (rect 108 5100 100 100)
   (rect 100 100 100 100)
   (rect 16 5008 100 100)


Added: trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt (0 => 190658)

--- trunk/LayoutTests/fast/repa

[webkit-changes] [190657] trunk/LayoutTests

2015-10-06 Thread jhoneycutt 
Title: [190657] trunk/LayoutTests








Revision 190657
Author jhoneyc...@apple.com
Date 2015-10-06 19:11:09 -0700 (Tue, 06 Oct 2015)


Log Message
More unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190656 => 190657)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:07:19 UTC (rev 190656)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 02:11:09 UTC (rev 190657)
@@ -1,5 +1,11 @@
 2015-10-06  Jon Honeycutt  
 
+More unreviewed Windows test gardening after r190629.
+
+* platform/win/TestExpectations:
+
+2015-10-06  Jon Honeycutt  
+
 Unreviewed Windows test gardening after r190629.
 
 * platform/win/TestExpectations:


Modified: trunk/LayoutTests/platform/win/TestExpectations (190656 => 190657)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:07:19 UTC (rev 190656)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:11:09 UTC (rev 190657)
@@ -3282,3 +3282,6 @@
 imported/blink/svg/custom/focus-ring-2.svg [ ImageOnlyFailure ]
 imported/blink/svg/custom/focus-ring-text.svg [ ImageOnlyFailure ]
 imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html [ ImageOnlyFailure ]
+imported/blink/fast/block/float/float-mark-descendants-for-layout-crash.html [ Failure ]
+imported/blink/http/tests/security/script-crossorigin-loads-correctly-credentials.html [ Failure ]
+imported/blink/printing/print-document-without-documentElement-crash.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190656] trunk/LayoutTests

2015-10-06 Thread jhoneycutt 
Title: [190656] trunk/LayoutTests








Revision 190656
Author jhoneyc...@apple.com
Date 2015-10-06 19:07:19 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190655 => 190656)

--- trunk/LayoutTests/ChangeLog	2015-10-07 01:24:54 UTC (rev 190655)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 02:07:19 UTC (rev 190656)
@@ -1,5 +1,11 @@
 2015-10-06  Jon Honeycutt  
 
+Unreviewed Windows test gardening after r190629.
+
+* platform/win/TestExpectations:
+
+2015-10-06  Jon Honeycutt  
+
 Unreviewed Mac test gardening after r190629.
 
 * platform/mac-wk1/TestExpectations:


Modified: trunk/LayoutTests/platform/win/TestExpectations (190655 => 190656)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 01:24:54 UTC (rev 190655)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:07:19 UTC (rev 190656)
@@ -3246,3 +3246,39 @@
 webkit.org/b/148886 http/tests/navigation/ping-attribute/anchor-same-origin.html [ Pass Failure ]
 webkit.org/b/148887 http/tests/navigation/success200-reload.html [ Pass Failure ]
 webkit.org/b/14 http/tests/navigation/slowmetaredirect-basic.html [ Pass Failure ]
+
+# Imported Blink tests.
+imported/blink/compositing/iframes/ancestor-clipping-layer.html [ Skip ]
+imported/blink/compositing/perspective-origin-overflow-hidden.html [ Skip ]
+imported/blink/editing/execCommand/indent-button-crash.html [ Skip ]
+imported/blink/http/tests/plugins/get-url-notify-on-removal.html [ Skip ]
+imported/blink/plugins/empty-per-context-data.html [ Skip ]
+imported/blink/animations/animation-iteration-event-short-iterations.html [ Failure Pass ]
+imported/blink/fast/dom/ruby-numeric-overflow.html [ Failure Pass ]
+imported/blink/fast/masking/mask-serializing.html [ Failure Pass ]
+imported/blink/compositing/ancestor-painted-layer-should-appear.html [ ImageOnlyFailure ]
+imported/blink/compositing/child-transform-layer-with-foreground-layer.html [ ImageOnlyFailure ]
+imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure ]
+imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ ImageOnlyFailure ]
+imported/blink/compositing/will-change/stacking-context-creation.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-background-size.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-multiply.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-with-opacity-change-js.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-with-squashing-layer.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-blend-overlapping-elements.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-isolation-foreign-no-isolation.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-isolation-nested-svg-no-isolation.html [ ImageOnlyFailure ]
+imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html [ ImageOnlyFailure ]
+imported/blink/css3/filters/effect-reference-on-transparent-element.html [ ImageOnlyFailure ]
+imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure ]
+imported/blink/fast/css/tab-size-complex-path.html [ ImageOnlyFailure ]
+imported/blink/fast/css/text-decoration-propagate.html [ ImageOnlyFailure ]
+imported/blink/fast/text/emoji-font-fallback-win.html [ ImageOnlyFailure ]
+imported/blink/fast/text/international/text-shaping-arabic.html [ ImageOnlyFailure ]
+imported/blink/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001.html [ ImageOnlyFailure ]
+imported/blink/svg/as-image/default-font-size.html [ ImageOnlyFailure ]
+imported/blink/svg/as-image/default-sans-serif-font.html [ ImageOnlyFailure ]
+imported/blink/svg/custom/focus-ring-2.svg [ ImageOnlyFailure ]
+imported/blink/svg/custom/focus-ring-text.svg [ ImageOnlyFailure ]
+imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190655] trunk/Source/WebCore

2015-10-06 Thread jer . noble 
Title: [190655] trunk/Source/WebCore








Revision 190655
Author jer.no...@apple.com
Date 2015-10-06 18:24:54 -0700 (Tue, 06 Oct 2015)


Log Message
[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
https://bugs.webkit.org/show_bug.cgi?id=149845

Reviewed by Darin Adler.

When converting from time-as-double to MediaTime, a regression was introduced
when checking whether m_seekTo was set to a valid value or not. The clause
`time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (190654 => 190655)

--- trunk/Source/WebCore/ChangeLog	2015-10-07 01:12:54 UTC (rev 190654)
+++ trunk/Source/WebCore/ChangeLog	2015-10-07 01:24:54 UTC (rev 190655)
@@ -1,3 +1,17 @@
+2015-10-06  Jer Noble  
+
+[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
+https://bugs.webkit.org/show_bug.cgi?id=149845
+
+Reviewed by Darin Adler.
+
+When converting from time-as-double to MediaTime, a regression was introduced
+when checking whether m_seekTo was set to a valid value or not. The clause
+`time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.
+
+* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+(WebCore::MediaPlayerPrivateQTKit::timeChanged):
+
 2015-10-06  Brady Eidson  
 
 Rename IDBRequestIdentifier to IDBResourceIdentifier.


Modified: trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm (190654 => 190655)

--- trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2015-10-07 01:12:54 UTC (rev 190654)
+++ trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2015-10-07 01:24:54 UTC (rev 190655)
@@ -1113,7 +1113,7 @@
 // It may not be possible to seek to a specific time in a streamed movie. When seeking in a 
 // stream QuickTime sets the movie time to closest time possible and posts a timechanged 
 // notification. Update m_seekTo so we can detect when the seek completes.
-if (!m_seekTo.isValid())
+if (m_seekTo.isValid())
 m_seekTo = currentMediaTime();
 
 m_timeToRestore = MediaTime::invalidTime();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190654] trunk/LayoutTests

2015-10-06 Thread jhoneycutt 
Title: [190654] trunk/LayoutTests








Revision 190654
Author jhoneyc...@apple.com
Date 2015-10-06 18:12:54 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190653 => 190654)

--- trunk/LayoutTests/ChangeLog	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 01:12:54 UTC (rev 190654)
@@ -1,3 +1,10 @@
+2015-10-06  Jon Honeycutt  
+
+Unreviewed Mac test gardening after r190629.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2015-10-06  Nan Wang  
 
 AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (190653 => 190654)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-07 01:12:54 UTC (rev 190654)
@@ -145,3 +145,7 @@
 
 # Testing the system language declaratively only makes sense in WK2, because it's implemented in WebKitTestRunner by launching a new WebContent process.
 fast/text/international/system-language [ Pass Failure ImageOnlyFailure ]
+
+# Imported Blink tests
+imported/blink/svg/hittest/rect-miterlimit.html [ Pass Timeout ]
+imported/blink/fast/text-autosizing/print-autosizing.html  [ Pass Timeout ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (190653 => 190654)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-07 01:12:54 UTC (rev 190654)
@@ -530,3 +530,9 @@
 
 # WebKit1-only failure.
 webkit.org/b/103857 fast/events/mouse-cursor-change.html [ Pass ]
+
+# Imported Blink tests
+imported/blink/fast/multicol/basic-rtl.html [ Pass ImageOnlyFailure ]
+imported/blink/fast/multicol/dynamic/add-spanner-inside-overflow-hidden.html [ Pass ImageOnlyFailure ]
+imported/blink/fast/multicol/vertical-lr/float-big-line.html  [ Pass ImageOnlyFailure ]
+imported/blink/http/tests/plugins/get-url-notify-on-removal.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190653] trunk/Source/WebCore

2015-10-06 Thread beidson 
Title: [190653] trunk/Source/WebCore








Revision 190653
Author beid...@apple.com
Date 2015-10-06 17:06:59 -0700 (Tue, 06 Oct 2015)


Log Message
Rename IDBRequestIdentifier to IDBResourceIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=149861

Reviewed by Alex Christensen.

No new tests (No change in behavior).

Turns out having an object representing a (connection ID + unique ID pair) is useful for more than just IDBRequests.

* CMakeLists.txt:
* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::IDBRequest):
* Modules/indexeddb/client/IDBRequestImpl.h:
(WebCore::IDBClient::IDBRequest::resourceIdentifier):
(WebCore::IDBClient::IDBRequest::requestIdentifier): Deleted.
* Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::requestIdentifier):
* Modules/indexeddb/shared/IDBResourceIdentifier.cpp: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.cpp.
(WebCore::nextResourceNumber):
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue):
* Modules/indexeddb/shared/IDBResourceIdentifier.h: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h.
(WebCore::IDBResourceIdentifier::isEmpty):
(WebCore::IDBResourceIdentifier::hash):
(WebCore::IDBResourceIdentifier::operator==):
(WebCore::IDBResourceIdentifier::connectionIdentifier):
(WebCore::IDBResourceIdentifierHash::hash):
(WebCore::IDBResourceIdentifierHash::equal):
(WebCore::IDBResourceIdentifierHashTraits::emptyValue):
(WebCore::IDBResourceIdentifierHashTraits::isEmptyValue):
(WebCore::IDBResourceIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBResourceIdentifierHashTraits::isDeletedValue):
* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
* Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::requestIdentifier):
* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.h
trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h


Removed Paths

trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (190652 => 190653)

--- trunk/Source/WebCore/CMakeLists.txt	2015-10-07 00:05:37 UTC (rev 190652)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-10-07 00:06:59 UTC (rev 190653)
@@ -906,7 +906,7 @@
 Modules/indexeddb/shared/IDBDatabaseInfo.cpp
 Modules/indexeddb/shared/IDBError.cpp
 Modules/indexeddb/shared/IDBRequestData.cpp
-Modules/indexeddb/shared/IDBRequestIdentifier.cpp
+Modules/indexeddb/shared/IDBResourceIdentifier.cpp
 Modules/indexeddb/shared/IDBResultData.cpp
 Modules/indexeddb/shared/InProcessIDBServer.cpp
 


Modified: trunk/Source/WebCore/ChangeLog (190652 => 190653)

--- trunk/Source/WebCore/ChangeLog	2015-10-07 00:05:37 UTC (rev 190652)
+++ trunk/Source/WebCore/ChangeLog	2015-10-07 00:06:59 UTC (rev 190653)
@@ -1,3 +1,49 @@
+2015-10-06  Brady Eidson  
+
+Rename IDBRequestIdentifier to IDBResourceIdentifier.
+https://bugs.webkit.org/show_bug.cgi?id=149861
+
+Reviewed by Alex Christensen.
+
+No new tests (No change in behavior).
+
+Turns out having an object representing a (connection ID + unique ID pair) is useful for more than just IDBRequests.
+
+* CMakeLists.txt:
+* Modules/indexeddb/client/IDBConnectionToServer.cpp:
+(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
+(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
+* Modules/indexeddb/client/IDBConnectionToServer.h:
+* Modules/indexeddb/client/IDBRequestImpl.cpp:
+(WebCore::IDBClient::IDBRequest::IDBRequest):
+* Modules/indexeddb/client/IDBRequestImpl.h:
+(WebCore::IDBClient::IDBRequest::resourceIdentifier):
+(WebCore::IDBClient::IDBRequest::requestIdentifier): Deleted.
+* Modules/indexeddb/shared/IDBR

[webkit-changes] [190652] trunk/Tools

2015-10-06 Thread bburg 
Title: [190652] trunk/Tools








Revision 190652
Author bb...@apple.com
Date 2015-10-06 17:05:37 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed, try to fix the iOS 8 build after r190368.

On older versions, IOHIDEventCreateForceEvent is not available.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm




Diff

Modified: trunk/Tools/ChangeLog (190651 => 190652)

--- trunk/Tools/ChangeLog	2015-10-06 23:22:39 UTC (rev 190651)
+++ trunk/Tools/ChangeLog	2015-10-07 00:05:37 UTC (rev 190652)
@@ -1,3 +1,12 @@
+2015-10-06  Brian Burg  
+
+Unreviewed, try to fix the iOS 8 build after r190368.
+
+On older versions, IOHIDEventCreateForceEvent is not available.
+
+* WebKitTestRunner/ios/HIDEventGenerator.mm:
+(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
+
 2015-10-06  Keith Miller  
 
 Add gmalloc option to run-_javascript_core-tests.


Modified: trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm (190651 => 190652)

--- trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2015-10-06 23:22:39 UTC (rev 190651)
+++ trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2015-10-07 00:05:37 UTC (rev 190652)
@@ -205,6 +205,7 @@
 IOHIDEventAppendEvent(eventRef.get(), subEvent.get(), 0);
 }
 
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 9
 if (_activePointCount) {
 IOHIDFloat progress = _activePoints[0].pathPressure;
 RetainPtr forceEvent = adoptCF(IOHIDEventCreateForceEvent(kCFAllocatorDefault,
@@ -216,6 +217,7 @@
 kIOHIDEventOptionNone));
 IOHIDEventAppendEvent(eventRef.get(), forceEvent.get(), 0);
 }
+#endif
 
 return eventRef.leakRef();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190651] trunk/Source/WebInspectorUI

2015-10-06 Thread nvasilyev 
Title: [190651] trunk/Source/WebInspectorUI








Revision 190651
Author nvasil...@apple.com
Date 2015-10-06 16:22:39 -0700 (Tue, 06 Oct 2015)


Log Message
Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
https://bugs.webkit.org/show_bug.cgi?id=149405

lineNumber should be a number type but it was a string.

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.openURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
Keep lineNumber undefined when it isn't present in the string.
WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
when it wasn't found in the parsed string.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (190650 => 190651)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-06 22:40:45 UTC (rev 190650)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-06 23:22:39 UTC (rev 190651)
@@ -1,3 +1,20 @@
+2015-10-06  Nikita Vasilyev  
+
+Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
+https://bugs.webkit.org/show_bug.cgi?id=149405
+
+lineNumber should be a number type but it was a string.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.openURL):
+(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
+Keep lineNumber undefined when it isn't present in the string.
+WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
+WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
+when it wasn't found in the parsed string.
+
 2015-10-06  Devin Rousso  
 
 Web Inspector: Fix spacing of FindBanner prev/next buttons


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (190650 => 190651)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-06 22:40:45 UTC (rev 190650)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-06 23:22:39 UTC (rev 190651)
@@ -666,6 +666,8 @@
 if (!url)
 return;
 
+console.assert(typeof lineNumber === "undefined" || typeof lineNumber === "number", "lineNumber should be a number.");
+
 // If alwaysOpenExternally is not defined, base it off the command/meta key for the current event.
 if (alwaysOpenExternally === undefined || alwaysOpenExternally === null)
 alwaysOpenExternally = window.event ? window.event.metaKey : false;
@@ -2034,7 +2036,11 @@
 if (lineColumnMatch)
 realURL = realURL.substring(0, realURL.length - lineColumnMatch[0].length);
 
-var linkNode = linkifier(title, realURL, lineColumnMatch ? lineColumnMatch[1] : undefined);
+var lineNumber;
+if (lineColumnMatch)
+lineNumber = parseInt(lineColumnMatch[1]) - 1;
+
+var linkNode = linkifier(title, realURL, lineNumber);
 container.appendChild(linkNode);
 string = string.substring(linkIndex + linkString.length, string.length);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190650] trunk/Tools

2015-10-06 Thread keith_miller 
Title: [190650] trunk/Tools








Revision 190650
Author keith_mil...@apple.com
Date 2015-10-06 15:40:45 -0700 (Tue, 06 Oct 2015)


Log Message
Add gmalloc option to run-_javascript_core-tests.
https://bugs.webkit.org/show_bug.cgi?id=149858

Reviewed by Geoffrey Garen.

run-_javascript_core-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.

* Scripts/run-_javascript_core-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (190649 => 190650)

--- trunk/Tools/ChangeLog	2015-10-06 22:29:27 UTC (rev 190649)
+++ trunk/Tools/ChangeLog	2015-10-06 22:40:45 UTC (rev 190650)
@@ -1,3 +1,15 @@
+2015-10-06  Keith Miller  
+
+Add gmalloc option to run-_javascript_core-tests.
+https://bugs.webkit.org/show_bug.cgi?id=149858
+
+Reviewed by Geoffrey Garen.
+
+run-_javascript_core-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
+If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
+
+* Scripts/run-_javascript_core-tests:
+
 2015-10-06  Myles C. Maxfield  
 
 Post-review cleanup after r190572.


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (190649 => 190650)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2015-10-06 22:29:27 UTC (rev 190649)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2015-10-06 22:40:45 UTC (rev 190650)
@@ -59,6 +59,8 @@
 my $runJITStressTests = 1;
 my $runQuickMode = 0;
 my $envVars = "";
+my $gmallocPath = undef;
+my $gmallocDefaultPath = "/usr/lib/libgmalloc.dylib";
 
 my $enableFTL = isAppleMacWebKit();
 my $createTarball = 0;
@@ -97,6 +99,7 @@
   --env-varsPass a list of environment variables to set before running tests.
 Each environment variable should be separated by a space.
 e.g. \"foo=bar x=y\" (no quotes).
+  --gmalloc:Run tests with Guard Malloc enabled (if no path is given: $gmallocDefaultPath is used)
 
 EOF
 
@@ -117,7 +120,8 @@
 'make-runner' => \$makeRunner,
 'filter=s' => \$filter,
 'help' => \$showHelp,
-'env-vars=s' => \$envVars
+'env-vars=s' => \$envVars,
+'gmalloc:s' => \$gmallocPath
 );
 
 # Assume any arguments left over from GetOptions are assumed to be build arguments
@@ -148,6 +152,13 @@
 }
 }
 
+if (defined($gmallocPath)) {
+if ($gmallocPath eq "") {
+$envVars .= " DYLD_INSERT_LIBRARIES=" . $gmallocDefaultPath;
+} else {
+$envVars .= " DYLD_INSERT_LIBRARIES=" . $gmallocPath;
+}
+}
 
 my $productDir = jscProductDir();
 $ENV{DYLD_FRAMEWORK_PATH} = $productDir;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190649] trunk/Source/JavaScriptCore

2015-10-06 Thread mark . lam 
Title: [190649] trunk/Source/_javascript_Core








Revision 190649
Author mark@apple.com
Date 2015-10-06 15:29:27 -0700 (Tue, 06 Oct 2015)


Log Message
Factoring out op_sub baseline code generation into JITSubGenerator.
https://bugs.webkit.org/show_bug.cgi?id=149600

Reviewed by Geoffrey Garen.

We're going to factor out baseline code generation into snippet generators so
that we can later use them in the DFG and FTL to emit code for to perform the
JS operations where the operand types are predicted to be polymorphic.
We are starting in this patch with the implementation of op_sub.

What was done in this patch:
1. Created JITSubGenerator based on the baseline implementation of op_sub as
   expressed in compileBinaryArithOp() and compileBinaryArithOpSlowCase().
   I did not attempt to do write a more optimal version of op_sub.  I'll
   leave that to a later patch.

2. Convert the 32-bit op_sub baseline implementation to use the same
   JITSubGenerator which was based on the 64-bit implementation.  The
   pre-existing 32-bit baseline op_sub had handling for more optimization cases.
   However, a benchmark run shows that simply going with the 64-bit version
   (foregoing those extra optimizations) did not change the performance.

   Also, previously, the 32-bit version was able to move double results directly
   into the result location on the stack directly.  By using JITSubGenerator,
   we now always move that result into a pair of GPRs before storing it into
   the stack location.

3. Add some needed emitters to AssemblyHelpers that play nice with JSValueRegs.

* _javascript_Core.xcodeproj/project.pbxproj:
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::boxDouble):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::boxBooleanPayload):
* jit/JIT.h:
(JSC::JIT::linkDummySlowCase):
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_sub): Deleted.
(JSC::JIT::emitSub32Constant): Deleted.
(JSC::JIT::emitSlow_op_sub): Deleted.
* jit/JITInlines.h:
(JSC::JIT::linkSlowCaseIfNotJSCell):
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
(JSC::JIT::addSlowCase):
(JSC::JIT::emitLoad):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):
* jit/JITSubGenerator.h: Added.
(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::generateFastPath):
(JSC::JITSubGenerator::slowPathJumpList):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp
trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp
trunk/Source/_javascript_Core/jit/JITInlines.h


Added Paths

trunk/Source/_javascript_Core/jit/JITSubGenerator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190648 => 190649)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-06 21:46:08 UTC (rev 190648)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-06 22:29:27 UTC (rev 190649)
@@ -1,3 +1,64 @@
+2015-10-06  Mark Lam  
+
+Factoring out op_sub baseline code generation into JITSubGenerator.
+https://bugs.webkit.org/show_bug.cgi?id=149600
+
+Reviewed by Geoffrey Garen.
+
+We're going to factor out baseline code generation into snippet generators so
+that we can later use them in the DFG and FTL to emit code for to perform the
+JS operations where the operand types are predicted to be polymorphic.
+We are starting in this patch with the implementation of op_sub.
+
+What was done in this patch:
+1. Created JITSubGenerator based on the baseline implementation of op_sub as
+   expressed in compileBinaryArithOp() and compileBinaryArithOpSlowCase().
+   I did not attempt to do write a more optimal version of op_sub.  I'll
+   leave that to a later patch.
+
+2. Convert the 32-bit op_sub baseline implementation to use the same
+   JITSubGenerator which was based on the 64-bit implementation.  The
+   pre-existing 32-bit baseline op_sub had handling for more optimization cases.
+   However, a benchmark run shows that simply going with the 64-bit version
+   (foregoing those extra optimizations) did not change the performance.
+
+   Also, previously, the 32-bit version was able to move double results directly
+   into the result location on the stack directly.  By using JITSubGenerator,
+   we now always move that result into a pair of GPRs before storing it into
+   the stack location.
+
+3. Add some needed emitters to AssemblyHelpers that play nice with JSValueRegs.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+

[webkit-changes] [190648] trunk

2015-10-06 Thread n_wang 
Title: [190648] trunk








Revision 190648
Author n_w...@apple.com
Date 2015-10-06 14:46:08 -0700 (Tue, 06 Oct 2015)


Log Message
AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
https://bugs.webkit.org/show_bug.cgi?id=132177

Reviewed by Chris Fleizach.

Source/WebCore:

Added role-specific defaults and changed general default to undefined.
Also added more elements to support aria-orientation on Mac.

Test: accessibility/mac/aria-orientation.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::isDescendantOfObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isColorWell):
(WebCore::AccessibilityObject::isSplitter):
(WebCore::AccessibilityObject::isToolbar):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::orientation):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::scrollBar):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

* accessibility/mac/aria-orientation-expected.txt: Added.
* accessibility/mac/aria-orientation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollbar.cpp
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm


Added Paths

trunk/LayoutTests/accessibility/mac/aria-orientation-expected.txt
trunk/LayoutTests/accessibility/mac/aria-orientation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190647 => 190648)

--- trunk/LayoutTests/ChangeLog	2015-10-06 21:41:56 UTC (rev 190647)
+++ trunk/LayoutTests/ChangeLog	2015-10-06 21:46:08 UTC (rev 190648)
@@ -1,3 +1,13 @@
+2015-10-06  Nan Wang  
+
+AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
+https://bugs.webkit.org/show_bug.cgi?id=132177
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/aria-orientation-expected.txt: Added.
+* accessibility/mac/aria-orientation.html: Added.
+
 2015-10-06  Simon Fraser  
 
 Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing


Added: trunk/LayoutTests/accessibility/mac/aria-orientation-expected.txt (0 => 190648)

--- trunk/LayoutTests/accessibility/mac/aria-orientation-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-orientation-expected.txt	2015-10-06 21:46:08 UTC (rev 190648)
@@ -0,0 +1,33 @@
+Implicit defaults
+ 
+Option
+Menu item 1
+menubar
+item one
+tree item
+
+Authored orientation
+radio 1
+cell
+cell2
+X
+This test makes sure that aria-orientation works correctly and the implicit defaults are defined on different roles.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS slider.orientation is 'AXOrientation: AXHorizontalOrientation'
+PASS combobox.orientation is 'AXOrientation: AXVerticalOrientation'
+PASS listbox.orientation is 'AXOrientation: AXVerticalOrientation'
+PASS menu.orientation is 'AXOrientation: AXVerticalOrientation'
+PASS menubar.orientation is 'AXOrientation: AXHorizontalOrientation'
+PASS tablist.orientation is 'AXOrientation: AXHorizontalOrientation'
+PASS toolbar.orientation is 'AXOrientation: AXHorizontalOrientation'
+PASS tree.orientation is 'AXOrientation: AXVerticalOrientation'
+PASS radiogroup.orientation is 'AXOrientation: AXVerticalOrientation'
+PASS treegrid.orientation is 'AXOrientation: AXHorizontalOrientation'
+PASS slider2.orientation is 'AXOrientation: AXUnknownOrientation'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/mac/aria-orientation.html (0 => 190648)

--- trunk/LayoutTests/accessibility/mac/aria-orientation.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-orientation.html	2015-10-06 21:46:08 UTC (rev 190648)
@@ -0,0 +1,85 @@
+
+
+
+
+
+
+
Implicit defaults

+
+
+

+
Option

+

+