[webkit-changes] [191387] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [191387] trunk/Source/WebInspectorUI








Revision 191387
Author nvasil...@apple.com
Date 2015-10-21 06:36:55 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Typo in a property name: style.inerhited
https://bugs.webkit.org/show_bug.cgi?id=150391

Reviewed by Csaba Osztrogonác.

* UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191386 => 191387)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-21 12:52:17 UTC (rev 191386)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-21 13:36:55 UTC (rev 191387)
@@ -1,3 +1,13 @@
+2015-10-21  Nikita Vasilyev  
+
+Web Inspector: Typo in a property name: style.inerhited
+https://bugs.webkit.org/show_bug.cgi?id=150391
+
+Reviewed by Csaba Osztrogonác.
+
+* UserInterface/Views/RulesStyleDetailsPanel.js:
+(WebInspector.RulesStyleDetailsPanel.prototype.refresh):
+
 2015-10-20  Nikita Vasilyev  
 
 Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js (191386 => 191387)

--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js	2015-10-21 12:52:17 UTC (rev 191386)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js	2015-10-21 13:36:55 UTC (rev 191387)
@@ -272,7 +272,7 @@
 var orderedStyles = uniqueOrderedStyles(this.nodeStyles.orderedStyles);
 for (var style of orderedStyles) {
 var isUserAgentStyle = style.ownerRule && style.ownerRule.type === WebInspector.CSSStyleSheet.Type.UserAgent;
-insertAllMatchingPseudoStyles.call(this, isUserAgentStyle || style.inerhited);
+insertAllMatchingPseudoStyles.call(this, isUserAgentStyle || style.inherited);
 
 insertMediaOrInheritanceLabel.call(this, style);
 appendStyleSection.call(this, style);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191435] trunk/Source/WebCore

[bburg]

Title: [191435] trunk/Source/WebCore








Revision 191435
Author bb...@apple.com
Date 2015-10-21 21:51:56 -0700 (Wed, 21 Oct 2015)


Log Message
Unreviewed, CMake build fix after r191433.

* CMakeLists.txt: add WritableStreamInternals.js to WebCore_BUILTINS_SOURCES.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (191434 => 191435)

--- trunk/Source/WebCore/CMakeLists.txt	2015-10-22 04:45:53 UTC (rev 191434)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-10-22 04:51:56 UTC (rev 191435)
@@ -3593,6 +3593,7 @@
 ${WEBCORE_DIR}/Modules/streams/ReadableStreamReader.js
 ${WEBCORE_DIR}/Modules/streams/StreamInternals.js
 ${WEBCORE_DIR}/Modules/streams/WritableStream.js
+${WEBCORE_DIR}/Modules/streams/WritableStreamInternals.js
 )
 
 set(BUILTINS_GENERATOR_SCRIPTS


Modified: trunk/Source/WebCore/ChangeLog (191434 => 191435)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 04:45:53 UTC (rev 191434)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 04:51:56 UTC (rev 191435)
@@ -1,5 +1,11 @@
 2015-10-21  Brian Burg  
 
+Unreviewed, CMake build fix after r191433.
+
+* CMakeLists.txt: add WritableStreamInternals.js to WebCore_BUILTINS_SOURCES.
+
+2015-10-21  Brian Burg  
+
 Restructure generate-js-bindings script to be modular and testable
 https://bugs.webkit.org/show_bug.cgi?id=149929
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191436] trunk/Source/WebKit2

[gyuyoung . kim]

Title: [191436] trunk/Source/WebKit2








Revision 191436
Author gyuyoung@webkit.org
Date 2015-10-21 22:13:32 -0700 (Wed, 21 Oct 2015)


Log Message
   Unreviewed EFL build fix. Remove customizeMenu implementation.

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191435 => 191436)

--- trunk/Source/WebKit2/ChangeLog	2015-10-22 04:51:56 UTC (rev 191435)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-22 05:13:32 UTC (rev 191436)
@@ -1,3 +1,10 @@
+2015-10-21  Gyuyoung Kim  
+
+   Unreviewed EFL build fix. Remove customizeMenu implementation.
+
+* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
+(WebKit::WebContextMenuClient::customizeMenu): Deleted.
+
 2015-10-21  Alex Christensen  
 
 Speculative EFL build fix.


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp (191435 => 191436)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp	2015-10-22 04:51:56 UTC (rev 191435)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp	2015-10-22 05:13:32 UTC (rev 191436)
@@ -49,12 +49,7 @@
 delete this;
 }
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-std::unique_ptr WebContextMenuClient::customizeMenu(std::unique_ptr)
-{
-return nullptr;
-}
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 PlatformMenuDescription WebContextMenuClient::getCustomMenuFromDefaultItems(ContextMenu* menu)
 {
 // WebKit2 ignores this client callback and does context menu customization when it is told to show the menu.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191434] trunk/Source/WebKit2

[achristensen]

Title: [191434] trunk/Source/WebKit2








Revision 191434
Author achristen...@apple.com
Date 2015-10-21 21:45:53 -0700 (Wed, 21 Oct 2015)


Log Message
Speculative EFL build fix.

* WebProcess/WebCoreSupport/WebContextMenuClient.h:
Remove another customizeMenu call.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191433 => 191434)

--- trunk/Source/WebKit2/ChangeLog	2015-10-22 04:39:01 UTC (rev 191433)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-22 04:45:53 UTC (rev 191434)
@@ -1,3 +1,10 @@
+2015-10-21  Alex Christensen  
+
+Speculative EFL build fix.
+
+* WebProcess/WebCoreSupport/WebContextMenuClient.h:
+Remove another customizeMenu call.
+
 2015-10-21  Gyuyoung Kim  
 
 [EFL][GTK][WK2] Fix build break since r191402, r191401


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h (191433 => 191434)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h	2015-10-22 04:39:01 UTC (rev 191433)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h	2015-10-22 04:45:53 UTC (rev 191434)
@@ -44,9 +44,7 @@
 private:
 virtual void contextMenuDestroyed() override;
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-virtual std::unique_ptr customizeMenu(std::unique_ptr) override;
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 virtual WebCore::PlatformMenuDescription getCustomMenuFromDefaultItems(WebCore::ContextMenu*) override;
 #endif
 virtual void contextMenuItemSelected(WebCore::ContextMenuItem*, const WebCore::ContextMenu*) override;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191438] trunk/Source/WebCore

[achristensen]

Title: [191438] trunk/Source/WebCore








Revision 191438
Author achristen...@apple.com
Date 2015-10-21 22:50:24 -0700 (Wed, 21 Oct 2015)


Log Message
Fix CMake clean build after r191423.

* CMakeLists.txt:
HTMLBaseFontElement.idl no longer generates any _javascript_ bindings.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (191437 => 191438)

--- trunk/Source/WebCore/CMakeLists.txt	2015-10-22 05:26:28 UTC (rev 191437)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-10-22 05:50:24 UTC (rev 191438)
@@ -460,7 +460,6 @@
 html/HTMLAudioElement.idl
 html/HTMLBRElement.idl
 html/HTMLBaseElement.idl
-html/HTMLBaseFontElement.idl
 html/HTMLBodyElement.idl
 html/HTMLButtonElement.idl
 html/HTMLCanvasElement.idl


Modified: trunk/Source/WebCore/ChangeLog (191437 => 191438)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 05:26:28 UTC (rev 191437)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 05:50:24 UTC (rev 191438)
@@ -1,3 +1,10 @@
+2015-10-21  Alex Christensen  
+
+Fix CMake clean build after r191423.
+
+* CMakeLists.txt:
+HTMLBaseFontElement.idl no longer generates any _javascript_ bindings.
+
 2015-10-21  Brian Burg  
 
 Unreviewed, CMake build fix after r191433.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191388] trunk

[cdumez]

Title: [191388] trunk








Revision 191388
Author cdu...@apple.com
Date 2015-10-21 10:00:18 -0700 (Wed, 21 Oct 2015)


Log Message
HTMLIFrameElement.sandbox should be a DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=150377

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLIFrameElement.sandbox should be a DOMSettableTokenList as per the
HTML specification:
- https://html.spec.whatwg.org/multipage/embedded-content.html#htmliframeelement

Chrome and Firefox match the specification but Safari/WebKit was uding
a DOMString.

Test: fast/frames/sandbox-attribute.html

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
(WebCore::HTMLIFrameElement::parseAttribute):
* html/HTMLIFrameElement.h:
* html/HTMLIFrameElement.idl:

LayoutTests:

* fast/frames/sandbox-attribute-expected.txt: Added.
* fast/frames/sandbox-attribute.html: Added.
Add layout test to check that HTMLIframeElement.sandbox is now a
DOMSettableTokenList.

* fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:
* fast/frames/sandboxed-iframe-navigation-allowed.html:
Update test that was using shouldBe() with HTMLIframeElement.sandbox.
shouldBe() does an === check but which now fails before
HTMLIframeElement.sandbox is now a DOMSettableTokenList that can be
stringified, rather than a String.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-allowed-expected.txt
trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-allowed.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLIFrameElement.cpp
trunk/Source/WebCore/html/HTMLIFrameElement.h
trunk/Source/WebCore/html/HTMLIFrameElement.idl


Added Paths

trunk/LayoutTests/fast/frames/sandbox-attribute-expected.txt
trunk/LayoutTests/fast/frames/sandbox-attribute.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191387 => 191388)

--- trunk/LayoutTests/ChangeLog	2015-10-21 13:36:55 UTC (rev 191387)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 17:00:18 UTC (rev 191388)
@@ -1,3 +1,22 @@
+2015-10-21  Chris Dumez  
+
+HTMLIFrameElement.sandbox should be a DOMSettableTokenList
+https://bugs.webkit.org/show_bug.cgi?id=150377
+
+Reviewed by Ryosuke Niwa.
+
+* fast/frames/sandbox-attribute-expected.txt: Added.
+* fast/frames/sandbox-attribute.html: Added.
+Add layout test to check that HTMLIframeElement.sandbox is now a
+DOMSettableTokenList.
+
+* fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:
+* fast/frames/sandboxed-iframe-navigation-allowed.html:
+Update test that was using shouldBe() with HTMLIframeElement.sandbox.
+shouldBe() does an === check but which now fails before
+HTMLIframeElement.sandbox is now a DOMSettableTokenList that can be
+stringified, rather than a String.
+
 2015-10-20  Sergio Villar Senin  
 
 [css-grid] Fix freeSpace computation with non-zero baseSize flex tracks


Added: trunk/LayoutTests/fast/frames/sandbox-attribute-expected.txt (0 => 191388)

--- trunk/LayoutTests/fast/frames/sandbox-attribute-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/frames/sandbox-attribute-expected.txt	2015-10-21 17:00:18 UTC (rev 191388)
@@ -0,0 +1,25 @@
+Checks that HTMLIframeElement.sandbox is a DOMSettableTokenList.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS iframe.sandbox.__proto__ is DOMSettableTokenList.prototype
+
+iframe.sandbox = 'allow-popups   allow-scripts  allow-scripts  allow-same-origin'
+PASS iframe.sandbox.length is 3
+PASS iframe.sandbox[0] is "allow-popups"
+PASS iframe.sandbox[1] is "allow-scripts"
+PASS iframe.sandbox[2] is "allow-same-origin"
+PASS String(iframe.sandbox) is "allow-popups allow-scripts allow-same-origin"
+PASS iframe.getAttribute('sandbox') is "allow-popups allow-scripts allow-same-origin"
+
+iframe.setAttribute('sandbox', 'allow-popups allow-scripts')
+PASS iframe.sandbox.length is 2
+PASS iframe.sandbox[0] is "allow-popups"
+PASS iframe.sandbox[1] is "allow-scripts"
+PASS String(iframe.sandbox) is "allow-popups allow-scripts"
+PASS iframe.getAttribute('sandbox') is "allow-popups allow-scripts"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/frames/sandbox-attribute.html (0 => 191388)

--- trunk/LayoutTests/fast/frames/sandbox-attribute.html	(rev 0)
+++ trunk/LayoutTests/fast/frames/sandbox-attribute.html	2015-10-21 17:00:18 UTC (rev 191388)
@@ -0,0 +1,30 @@
+
+
+
+
+description("Checks that HTMLIframeElement.sandbox is a DOMSettableTokenList.");
+
+var iframe = document.createElement("iframe");
+shouldBe("iframe.sandbox.__proto__", "DOMSettableTokenList.prototype");
+
+debug("");
+evalAndLog("iframe.sandbox = 'allow-popups   allow-scripts  allow-scripts  allow-same-origin'");
+shouldBe("iframe.sandbox.length", "3");
+shouldBeEqualToString("iframe.sandbox[0]", 

[webkit-changes] [191389] trunk/Source/JavaScriptCore

[commit-queue]

Title: [191389] trunk/Source/_javascript_Core








Revision 191389
Author commit-qu...@webkit.org
Date 2015-10-21 10:08:17 -0700 (Wed, 21 Oct 2015)


Log Message
llint: align stack pointer on mips too

[MIPS] LLInt: align stack pointer on MIPS too
https://bugs.webkit.org/show_bug.cgi?id=150380

Patch by Guillaume Emont  on 2015-10-21
Reviewed by Michael Saboff.

* llint/LowLevelInterpreter32_64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191388 => 191389)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 17:00:18 UTC (rev 191388)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 17:08:17 UTC (rev 191389)
@@ -1,3 +1,14 @@
+2015-10-21  Guillaume Emont  
+
+llint: align stack pointer on mips too
+
+[MIPS] LLInt: align stack pointer on MIPS too
+https://bugs.webkit.org/show_bug.cgi?id=150380
+
+Reviewed by Michael Saboff.
+
+* llint/LowLevelInterpreter32_64.asm:
+
 2015-10-20  Mark Lam  
 
 YarrPatternConstructor::containsCapturingTerms() should not assume that its terms.size() is greater than 0.


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (191388 => 191389)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2015-10-21 17:00:18 UTC (rev 191388)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2015-10-21 17:08:17 UTC (rev 191389)
@@ -129,7 +129,7 @@
 storep t4, VMEntryRecord::m_prevTopVMEntryFrame[sp]
 
 # Align stack pointer
-if X86_WIN
+if X86_WIN or MIPS
 addp CallFrameAlignSlots * SlotSize, sp, t3
 andp ~StackAlignmentMask, t3
 subp t3, CallFrameAlignSlots * SlotSize, sp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191390] trunk/Source/WebKit2

[cdumez]

Title: [191390] trunk/Source/WebKit2








Revision 191390
Author cdu...@apple.com
Date 2015-10-21 10:12:35 -0700 (Wed, 21 Oct 2015)


Log Message
Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
https://bugs.webkit.org/show_bug.cgi?id=150369

Reviewed by Antti Koivisto.

Add assertions to NetworkCache::Entry constructor to make sure a key's
type is "resource" now that the NetworkCache storage supports other
types of entries.

* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191389 => 191390)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 17:08:17 UTC (rev 191389)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 17:12:35 UTC (rev 191390)
@@ -1,3 +1,17 @@
+2015-10-21  Chris Dumez  
+
+Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
+https://bugs.webkit.org/show_bug.cgi?id=150369
+
+Reviewed by Antti Koivisto.
+
+Add assertions to NetworkCache::Entry constructor to make sure a key's
+type is "resource" now that the NetworkCache storage supports other
+types of entries.
+
+* NetworkProcess/cache/NetworkCacheEntry.cpp:
+(WebKit::NetworkCache::Entry::Entry):
+
 2015-10-21  Carlos Garcia Campos  
 
 NetworkProcess: DNS prefetch happens in the Web Process


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp (191389 => 191390)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp	2015-10-21 17:08:17 UTC (rev 191389)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp	2015-10-21 17:12:35 UTC (rev 191390)
@@ -46,6 +46,7 @@
 , m_varyingRequestHeaders(varyingRequestHeaders)
 , m_buffer(WTF::move(buffer))
 {
+ASSERT(m_key.type() == "resource");
 }
 
 Entry::Entry(const Storage::Record& storageEntry)
@@ -53,6 +54,7 @@
 , m_timeStamp(storageEntry.timeStamp)
 , m_sourceStorageRecord(storageEntry)
 {
+ASSERT(m_key.type() == "resource");
 }
 
 Storage::Record Entry::encodeAsStorageRecord() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191396] trunk/Source

[bshafiei]

Title: [191396] trunk/Source








Revision 191396
Author bshaf...@apple.com
Date 2015-10-21 11:53:17 -0700 (Wed, 21 Oct 2015)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (191395 => 191396)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-21 18:45:48 UTC (rev 191395)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-21 18:53:17 UTC (rev 191396)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (191395 => 191396)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2015-10-21 18:45:48 UTC (rev 191395)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2015-10-21 18:53:17 UTC (rev 191396)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (191395 => 191396)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-21 18:45:48 UTC (rev 191395)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-21 18:53:17 UTC (rev 191396)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (191395 => 191396)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-21 18:45:48 UTC (rev 191395)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-21 18:53:17 UTC (rev 191396)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (191395 => 191396)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2015-10-21 18:45:48 UTC (rev 191395)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2015-10-21 18:53:17 UTC (rev 191396)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191392] trunk

[commit-queue]

Title: [191392] trunk








Revision 191392
Author commit-qu...@webkit.org
Date 2015-10-21 11:29:39 -0700 (Wed, 21 Oct 2015)


Log Message
Support for the SVG `onend` attribute
https://bugs.webkit.org/show_bug.cgi?id=150393

Patch by Antoine Quint  on 2015-10-21
Reviewed by Dean Jackson.

Source/WebCore:

Add support for the SVG `onend` attribute to SVG timing and animation elements, which allow the definition
of a JS event listener declaratively for the SVG `endEvent` event.

Tests: svg/animations/end-event-attribute-expected.svg
   svg/animations/end-event-attribute.svg
   svg/animations/end-event-syncbase-expected.svg
   svg/animations/end-event-syncbase.svg

* dom/EventNames.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseAttribute):
* svg/svgattrs.in:

LayoutTests:

Create a new test for the `onend` attribute and rename the previously-named "end-event-declarative.svg" test to
"end-event-syncbase.svg" since the term "declarative" was a little loose.

* svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
* svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
* svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
* svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventNames.h
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
trunk/Source/WebCore/svg/svgattrs.in


Added Paths

trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg
trunk/LayoutTests/svg/animations/end-event-attribute.svg
trunk/LayoutTests/svg/animations/end-event-syncbase-expected.svg
trunk/LayoutTests/svg/animations/end-event-syncbase.svg


Removed Paths

trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg
trunk/LayoutTests/svg/animations/end-event-declarative.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (191391 => 191392)

--- trunk/LayoutTests/ChangeLog	2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 18:29:39 UTC (rev 191392)
@@ -1,3 +1,18 @@
+2015-10-21  Antoine Quint  
+
+Support for the SVG `onend` attribute
+https://bugs.webkit.org/show_bug.cgi?id=150393
+
+Reviewed by Dean Jackson.
+
+Create a new test for the `onend` attribute and rename the previously-named "end-event-declarative.svg" test to
+"end-event-syncbase.svg" since the term "declarative" was a little loose.
+
+* svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
+* svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
+* svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
+* svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.
+
 2015-10-21  Nan Wang  
 
 AX: Expose table size and cell indexes on iOS


Copied: trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg) (0 => 191392)

--- trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg	2015-10-21 18:29:39 UTC (rev 191392)
@@ -0,0 +1,5 @@
+
+
+
+
+
\ No newline at end of file


Copied: trunk/LayoutTests/svg/animations/end-event-attribute.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative.svg) (0 => 191392)

--- trunk/LayoutTests/svg/animations/end-event-attribute.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-attribute.svg	2015-10-21 18:29:39 UTC (rev 191392)
@@ -0,0 +1,21 @@
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function handleEndEvent(event) {
+document.getElementById("rect").setAttribute("fill", "green");
+testRunner.notifyDone();
+}
+
+function loaded() {
+document.documentElement.setCurrentTime(2);
+}
+
+
+
\ No newline at end of file


Deleted: trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg (191391 => 191392)

--- trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg	2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg	2015-10-21 18:29:39 UTC (rev 191392)
@@ -1,5 +0,0 @@
-
-
-
-
-
\ No newline at end of file


Deleted: trunk/LayoutTests/svg/animations/end-event-declarative.svg (191391 => 191392)

--- 

[webkit-changes] [191393] trunk/Source/JavaScriptCore

[ggaren]

Title: [191393] trunk/Source/_javascript_Core








Revision 191393
Author gga...@apple.com
Date 2015-10-21 11:42:06 -0700 (Wed, 21 Oct 2015)


Log Message
Date creation should share a little code
https://bugs.webkit.org/show_bug.cgi?id=150399

Reviewed by Filip Pizlo.

I want to fix a bug in this code, but I don't want to fix it in two
different places. (See https://bugs.webkit.org/show_bug.cgi?id=150386.)

* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::milliseconds): Factored out a shared helper function. If you look
closely, you'll see that one copy of this code previously checked isfinite
while the other checked isnan. isnan returning nan was obviously a no-op,
so I removed it. isfinite, it turns out, is also a no-op -- but less
obviously so, so I kept it for now.

(JSC::constructDate):
(JSC::dateUTC): Use the helper function.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DateConstructor.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191392 => 191393)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:29:39 UTC (rev 191392)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:42:06 UTC (rev 191393)
@@ -1,3 +1,24 @@
+2015-10-21  Geoffrey Garen  
+
+Date creation should share a little code
+https://bugs.webkit.org/show_bug.cgi?id=150399
+
+Reviewed by Filip Pizlo.
+
+I want to fix a bug in this code, but I don't want to fix it in two
+different places. (See https://bugs.webkit.org/show_bug.cgi?id=150386.)
+
+* runtime/DateConstructor.cpp:
+(JSC::DateConstructor::getOwnPropertySlot):
+(JSC::milliseconds): Factored out a shared helper function. If you look
+closely, you'll see that one copy of this code previously checked isfinite
+while the other checked isnan. isnan returning nan was obviously a no-op,
+so I removed it. isfinite, it turns out, is also a no-op -- but less
+obviously so, so I kept it for now.
+
+(JSC::constructDate):
+(JSC::dateUTC): Use the helper function.
+
 2015-10-21  Guillaume Emont  
 
 llint: align stack pointer on mips too


Modified: trunk/Source/_javascript_Core/runtime/DateConstructor.cpp (191392 => 191393)

--- trunk/Source/_javascript_Core/runtime/DateConstructor.cpp	2015-10-21 18:29:39 UTC (rev 191392)
+++ trunk/Source/_javascript_Core/runtime/DateConstructor.cpp	2015-10-21 18:42:06 UTC (rev 191393)
@@ -112,6 +112,42 @@
 return getStaticFunctionSlot(exec, dateConstructorTable, jsCast(object), propertyName, slot);
 }
 
+static double millisecondsFromComponents(ExecState* exec, const ArgList& args, WTF::TimeType timeType)
+{
+double doubleArguments[] = {
+args.at(0).toNumber(exec), 
+args.at(1).toNumber(exec), 
+args.at(2).toNumber(exec), 
+args.at(3).toNumber(exec), 
+args.at(4).toNumber(exec), 
+args.at(5).toNumber(exec), 
+args.at(6).toNumber(exec)
+};
+
+int numArgs = args.size();
+
+if ((!std::isfinite(doubleArguments[0]) || (doubleArguments[0] > INT_MAX) || (doubleArguments[0] < INT_MIN))
+|| (!std::isfinite(doubleArguments[1]) || (doubleArguments[1] > INT_MAX) || (doubleArguments[1] < INT_MIN))
+|| (numArgs >= 3 && (!std::isfinite(doubleArguments[2]) || (doubleArguments[2] > INT_MAX) || (doubleArguments[2] < INT_MIN)))
+|| (numArgs >= 4 && (!std::isfinite(doubleArguments[3]) || (doubleArguments[3] > INT_MAX) || (doubleArguments[3] < INT_MIN)))
+|| (numArgs >= 5 && (!std::isfinite(doubleArguments[4]) || (doubleArguments[4] > INT_MAX) || (doubleArguments[4] < INT_MIN)))
+|| (numArgs >= 6 && (!std::isfinite(doubleArguments[5]) || (doubleArguments[5] > INT_MAX) || (doubleArguments[5] < INT_MIN)))
+|| (numArgs >= 7 && (!std::isfinite(doubleArguments[6]) || (doubleArguments[6] > INT_MAX) || (doubleArguments[6] < INT_MIN
+return PNaN;
+
+GregorianDateTime t;
+int year = JSC::toInt32(doubleArguments[0]);
+t.setYear((year >= 0 && year <= 99) ? (year + 1900) : year);
+t.setMonth(JSC::toInt32(doubleArguments[1]));
+t.setMonthDay((numArgs >= 3) ? JSC::toInt32(doubleArguments[2]) : 1);
+t.setHour(JSC::toInt32(doubleArguments[3]));
+t.setMinute(JSC::toInt32(doubleArguments[4]));
+t.setSecond(JSC::toInt32(doubleArguments[5]));
+t.setIsDST(-1);
+double ms = (numArgs >= 7) ? doubleArguments[6] : 0;
+return gregorianDateTimeToMS(exec->vm(), t, ms, timeType);
+}
+
 // ECMA 15.9.3
 JSObject* constructDate(ExecState* exec, JSGlobalObject* globalObject, const ArgList& args)
 {
@@ -132,38 +168,8 @@
 else
 value = primitive.toNumber(exec);
 }
-} else {
-double doubleArguments[7] = {
-args.at(0).toNumber(exec), 
-args.at(1).toNumber(exec), 
-

[webkit-changes] [191395] trunk

[fpizlo]

Title: [191395] trunk








Revision 191395
Author fpi...@apple.com
Date 2015-10-21 11:45:48 -0700 (Wed, 21 Oct 2015)


Log Message
Failures in PutStackSinkingPhase should be less severe
https://bugs.webkit.org/show_bug.cgi?id=150400

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

Make the PutStackSinkingPhase abort instead of asserting. To test that it's OK to not have
PutStackSinkingPhase run, this adds a test mode where we run without PutStackSinkingPhase.

* dfg/DFGPlan.cpp: Make it possible to not run PutStackSinkingPhase for tests.
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGPutStackSinkingPhase.cpp: PutStackSinkingPhase should abort instead of asserting, except when validation is enabled.
* runtime/Options.h: Add an option for disabling PutStackSinkingPhase.

Tools:

Add a test mode for no PutStackSinkingPhase.

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191394 => 191395)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:44:44 UTC (rev 191394)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:45:48 UTC (rev 191395)
@@ -1,3 +1,18 @@
+2015-10-21  Filip Pizlo  
+
+Failures in PutStackSinkingPhase should be less severe
+https://bugs.webkit.org/show_bug.cgi?id=150400
+
+Reviewed by Geoffrey Garen.
+
+Make the PutStackSinkingPhase abort instead of asserting. To test that it's OK to not have
+PutStackSinkingPhase run, this adds a test mode where we run without PutStackSinkingPhase.
+
+* dfg/DFGPlan.cpp: Make it possible to not run PutStackSinkingPhase for tests.
+(JSC::DFG::Plan::compileInThreadImpl):
+* dfg/DFGPutStackSinkingPhase.cpp: PutStackSinkingPhase should abort instead of asserting, except when validation is enabled.
+* runtime/Options.h: Add an option for disabling PutStackSinkingPhase.
+
 2015-10-21  Saam barati  
 
 The FTL should place the CallSiteIndex on the call frame for JS calls when it fills in the patchpoint


Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (191394 => 191395)

--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2015-10-21 18:44:44 UTC (rev 191394)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2015-10-21 18:45:48 UTC (rev 191395)
@@ -394,7 +394,8 @@
 
 // Ideally, these would be run to fixpoint with the object allocation sinking phase.
 performArgumentsElimination(dfg);
-performPutStackSinking(dfg);
+if (Options::usePutStackSinking())
+performPutStackSinking(dfg);
 
 performConstantHoisting(dfg);
 performGlobalCSE(dfg);


Modified: trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp (191394 => 191395)

--- trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp	2015-10-21 18:44:44 UTC (rev 191394)
+++ trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp	2015-10-21 18:45:48 UTC (rev 191395)
@@ -233,10 +233,39 @@
 dataLog("Deferred at ", node, ":", deferred, "\n");
 
 if (node->op() == GetStack) {
-DFG_ASSERT(
-m_graph, node,
-deferred.operand(node->stackAccessData()->local) != ConflictingFlush);
+// Handle the case that the input doesn't match our requirements. This is
+// really a bug, but it's a benign one if we simply don't run this phase.
+// It usually arises because of patterns like:
+//
+// if (thing)
+// PutStack()
+// ...
+// if (thing)
+// GetStack()
+//
+// Or:
+//
+// if (never happens)
+// GetStack()
+//
+// Because this phase runs early in SSA, it should be sensible to enforce
+// that no such code pattern has arisen yet. So, when validation is
+// enabled, we assert that we aren't seeing this. But with validation
+// disabled we silently let this fly and we just abort this phase.
+// FIXME: Get rid of all remaining cases of conflicting GetStacks.
+// https://bugs.webkit.org/show_bug.cgi?id=150398
+
+bool isConflicting =
+deferred.operand(node->stackAccessData()->local) == 

[webkit-changes] [191394] trunk/Source/JavaScriptCore

[sbarati]

Title: [191394] trunk/Source/_javascript_Core








Revision 191394
Author sbar...@apple.com
Date 2015-10-21 11:44:44 -0700 (Wed, 21 Oct 2015)


Log Message
The FTL should place the CallSiteIndex on the call frame for JS calls when it fills in the patchpoint
https://bugs.webkit.org/show_bug.cgi?id=150104

Reviewed by Filip Pizlo.

We lower JS Calls to patchpoints in LLVM. LLVM may decide to duplicate
these patchpoints (or remove them). We eagerly store the CallSiteIndex on the 
call frame when lowering DFG to LLVM. But, because the patchpoint we lower to may
be duplicated, we really don't know the unique CallSiteIndex until we've
actually seen the resulting patchpoints after LLVM has completed its transformations.
To solve this, we now store the unique CallSiteIndex on the call frame header 
when generating code to fill into the patchpoint.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLJSCall.cpp:
(JSC::FTL::JSCall::JSCall):
(JSC::FTL::JSCall::emit):
* ftl/FTLJSCall.h:
(JSC::FTL::JSCall::stackmapID):
* ftl/FTLJSCallBase.cpp:
(JSC::FTL::JSCallBase::JSCallBase):
(JSC::FTL::JSCallBase::emit):
(JSC::FTL::JSCallBase::link):
* ftl/FTLJSCallBase.h:
* ftl/FTLJSCallVarargs.cpp:
(JSC::FTL::JSCallVarargs::JSCallVarargs):
(JSC::FTL::JSCallVarargs::numSpillSlotsNeeded):
(JSC::FTL::JSCallVarargs::emit):
* ftl/FTLJSCallVarargs.h:
(JSC::FTL::JSCallVarargs::node):
(JSC::FTL::JSCallVarargs::stackmapID):
* ftl/FTLJSTailCall.cpp:
(JSC::FTL::JSTailCall::JSTailCall):
(JSC::FTL::m_instructionOffset):
(JSC::FTL::JSTailCall::emit):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
(JSC::FTL::DFG::LowerDFGToLLVM::codeOriginDescriptionOfCallSite):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLJSCall.cpp
trunk/Source/_javascript_Core/ftl/FTLJSCall.h
trunk/Source/_javascript_Core/ftl/FTLJSCallBase.cpp
trunk/Source/_javascript_Core/ftl/FTLJSCallBase.h
trunk/Source/_javascript_Core/ftl/FTLJSCallVarargs.cpp
trunk/Source/_javascript_Core/ftl/FTLJSCallVarargs.h
trunk/Source/_javascript_Core/ftl/FTLJSTailCall.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191393 => 191394)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:42:06 UTC (rev 191393)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:44:44 UTC (rev 191394)
@@ -1,3 +1,48 @@
+2015-10-21  Saam barati  
+
+The FTL should place the CallSiteIndex on the call frame for JS calls when it fills in the patchpoint
+https://bugs.webkit.org/show_bug.cgi?id=150104
+
+Reviewed by Filip Pizlo.
+
+We lower JS Calls to patchpoints in LLVM. LLVM may decide to duplicate
+these patchpoints (or remove them). We eagerly store the CallSiteIndex on the 
+call frame when lowering DFG to LLVM. But, because the patchpoint we lower to may
+be duplicated, we really don't know the unique CallSiteIndex until we've
+actually seen the resulting patchpoints after LLVM has completed its transformations.
+To solve this, we now store the unique CallSiteIndex on the call frame header 
+when generating code to fill into the patchpoint.
+
+* ftl/FTLCompile.cpp:
+(JSC::FTL::mmAllocateDataSection):
+* ftl/FTLJSCall.cpp:
+(JSC::FTL::JSCall::JSCall):
+(JSC::FTL::JSCall::emit):
+* ftl/FTLJSCall.h:
+(JSC::FTL::JSCall::stackmapID):
+* ftl/FTLJSCallBase.cpp:
+(JSC::FTL::JSCallBase::JSCallBase):
+(JSC::FTL::JSCallBase::emit):
+(JSC::FTL::JSCallBase::link):
+* ftl/FTLJSCallBase.h:
+* ftl/FTLJSCallVarargs.cpp:
+(JSC::FTL::JSCallVarargs::JSCallVarargs):
+(JSC::FTL::JSCallVarargs::numSpillSlotsNeeded):
+(JSC::FTL::JSCallVarargs::emit):
+* ftl/FTLJSCallVarargs.h:
+(JSC::FTL::JSCallVarargs::node):
+(JSC::FTL::JSCallVarargs::stackmapID):
+* ftl/FTLJSTailCall.cpp:
+(JSC::FTL::JSTailCall::JSTailCall):
+(JSC::FTL::m_instructionOffset):
+(JSC::FTL::JSTailCall::emit):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
+(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
+(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
+(JSC::FTL::DFG::LowerDFGToLLVM::codeOriginDescriptionOfCallSite):
+(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
+
 2015-10-21  Geoffrey Garen  
 
 Date creation should share a little code


Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (191393 => 191394)

--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2015-10-21 

[webkit-changes] [191397] trunk/Source/JavaScriptCore

[commit-queue]

Title: [191397] trunk/Source/_javascript_Core








Revision 191397
Author commit-qu...@webkit.org
Date 2015-10-21 12:56:50 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Array previews with Symbol objects have too few preview values
https://bugs.webkit.org/show_bug.cgi?id=150404

Patch by Joseph Pecoraro  on 2015-10-21
Reviewed by Timothy Hatcher.

* inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
We should be continuing inside this loop not returning.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191396 => 191397)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 18:53:17 UTC (rev 191396)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 19:56:50 UTC (rev 191397)
@@ -1,3 +1,14 @@
+2015-10-21  Joseph Pecoraro  
+
+Web Inspector: Array previews with Symbol objects have too few preview values
+https://bugs.webkit.org/show_bug.cgi?id=150404
+
+Reviewed by Timothy Hatcher.
+
+* inspector/InjectedScriptSource.js:
+(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
+We should be continuing inside this loop not returning.
+
 2015-10-21  Filip Pizlo  
 
 Failures in PutStackSinkingPhase should be less severe


Modified: trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js (191396 => 191397)

--- trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2015-10-21 18:53:17 UTC (rev 191396)
+++ trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2015-10-21 19:56:50 UTC (rev 191397)
@@ -1185,7 +1185,7 @@
 preview.lossless = false;
 }
 this._appendPropertyPreview(preview, internal, {name, type, value: symbolString}, propertiesThreshold);
-return;
+continue;
 }
 
 // Object.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191400] trunk

[beidson]

Title: [191400] trunk








Revision 191400
Author beid...@apple.com
Date 2015-10-21 13:22:31 -0700 (Wed, 21 Oct 2015)


Log Message
Modern IDB: Add basic transaction aborting.
https://bugs.webkit.org/show_bug.cgi?id=150148

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/double-abort.html
   storage/indexeddb/modern/versionchange-abort-then-reopen.html

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IndexedDB.h:

* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::abortTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didAbortTransaction):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::abortTransaction):
(WebCore::IDBClient::IDBDatabase::didCommitOrAbortTransaction):
* Modules/indexeddb/client/IDBDatabaseImpl.h:

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::isFinishedOrFinishing):
(WebCore::IDBClient::IDBTransaction::activationTimerFired):
(WebCore::IDBClient::IDBTransaction::didAbort):
* Modules/indexeddb/client/IDBTransactionImpl.h:

* Modules/indexeddb/server/IDBBackingStore.h:

* Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didAbortTransaction):
* Modules/indexeddb/server/IDBConnectionToClient.h:
* Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::abortTransaction):
* Modules/indexeddb/server/IDBServer.h:

* Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::create):
(WebCore::IDBServer::MemoryBackingStoreTransaction::MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::~MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
(WebCore::IDBServer::MemoryBackingStoreTransaction::commit):
* Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
(WebCore::IDBServer::MemoryBackingStoreTransaction::isVersionChange):

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::setDatabaseInfo):
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::abortTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::commitTransaction):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::beginTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
* Modules/indexeddb/server/UniqueIDBDatabase.h:

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::originalDatabaseInfo):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abort):
* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

* Modules/indexeddb/shared/IDBError.cpp:
(WebCore::idbErrorName):
(WebCore::idbErrorDescription):
* Modules/indexeddb/shared/IDBError.h:

* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::abortTransaction):
* Modules/indexeddb/shared/InProcessIDBServer.h:

LayoutTests:

* storage/indexeddb/modern/double-abort-expected.txt: Added.
* storage/indexeddb/modern/double-abort.html: Added.
* storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt: Added.
* storage/indexeddb/modern/versionchange-abort-then-reopen.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IndexedDB.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h

[webkit-changes] [191399] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191399] trunk/Source/WebInspectorUI








Revision 191399
Author commit-qu...@webkit.org
Date 2015-10-21 13:07:33 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Use some CSS Variables in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=150405

Patch by Joseph Pecoraro  on 2015-10-21
Reviewed by Timothy Hatcher.

* UserInterface/Main.html:
Include the new variables stylesheet.

* UserInterface/Views/Variables.css: Added.
(:root):
Introduce new global variables.

* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .cm-link):
* UserInterface/Views/ConsoleMessageView.css:
(.console-message-preview-divider):
(.console-message-enclosed):
(.console-message .console-message-extra-parameters-container > li::before):
(.console-saved-variable):
* UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.selected > span::after):
* UserInterface/Views/FormattedValue.css:
(:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
(.formatted-number):
(.formatted-boolean):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):
* UserInterface/Views/ObjectPreviewView.css:
(.object-preview > .size):
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, ._javascript_-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, ._javascript_-number)):
(.syntax-highlighted :matches(.css-string, ._javascript_-string, .html-attribute-value)):
(.syntax-highlighted ._javascript_-regexp):
* UserInterface/Views/TypeTokenView.css:
(.type-token-symbol):
Make use of variables.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css
trunk/Source/WebInspectorUI/UserInterface/Views/TypeTokenView.css


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191398 => 191399)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-21 20:04:12 UTC (rev 191398)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-21 20:07:33 UTC (rev 191399)
@@ -1,3 +1,46 @@
+2015-10-21  Joseph Pecoraro  
+
+Web Inspector: Use some CSS Variables in Web Inspector
+https://bugs.webkit.org/show_bug.cgi?id=150405
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Main.html:
+Include the new variables stylesheet.
+
+* UserInterface/Views/Variables.css: Added.
+(:root):
+Introduce new global variables.
+
+* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
+(.css-style-text-editor > .CodeMirror .cm-link):
+* UserInterface/Views/ConsoleMessageView.css:
+(.console-message-preview-divider):
+(.console-message-enclosed):
+(.console-message .console-message-extra-parameters-container > li::before):
+(.console-saved-variable):
+* UserInterface/Views/DOMTreeOutline.css:
+(.dom-tree-outline li.selected > span::after):
+* UserInterface/Views/FormattedValue.css:
+(:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
+(.formatted-number):
+(.formatted-boolean):
+(.formatted-string):
+(.formatted-regexp):
+(.formatted-symbol):
+* UserInterface/Views/ObjectPreviewView.css:
+(.object-preview > .size):
+* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+(.object-tree-array-index .index-name):
+* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
+(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, ._javascript_-keyword, .html-tag)):
+(.syntax-highlighted :matches(.css-number, ._javascript_-number)):
+(.syntax-highlighted :matches(.css-string, ._javascript_-string, .html-attribute-value)):
+(.syntax-highlighted ._javascript_-regexp):
+* UserInterface/Views/TypeTokenView.css:
+(.type-token-symbol):
+Make use of variables.
+
 2015-10-21  Nikita Vasilyev  
 
 Web Inspector: Typo in a property name: style.inerhited


Modified: trunk/Source/WebInspectorUI/UserInterface/Main.html 

[webkit-changes] [191398] trunk

[cdumez]

Title: [191398] trunk








Revision 191398
Author cdu...@apple.com
Date 2015-10-21 13:04:12 -0700 (Wed, 21 Oct 2015)


Log Message
bgsound should use HTMLUnknownElement interface
https://bugs.webkit.org/show_bug.cgi?id=148857


Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline a couple of W3C HTML tests now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

The blink, bgsound, isindex, multicol, nextid, and spacer elements must
use the HTMLUnknownElement interface, as per the HTML specification:
https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis

WebKit was using HTMLUnknownElement for all of them except bgsound.
This patch fixes the issue and aligns our behavior with Chrome and
Firefox.

No new tests, already covered by existing tests.

* html/HTMLTagNames.in:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTagNames.in




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (191397 => 191398)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-10-21 20:04:12 UTC (rev 191398)
@@ -1,3 +1,16 @@
+2015-10-21  Chris Dumez  
+
+bgsound should use HTMLUnknownElement interface
+https://bugs.webkit.org/show_bug.cgi?id=148857
+
+
+Reviewed by Sam Weinig.
+
+Rebaseline a couple of W3C HTML tests now that more checks are passing.
+
+* web-platform-tests/html/dom/interfaces-expected.txt:
+* web-platform-tests/html/semantics/interfaces-expected.txt:
+
 2015-10-21  Youenn Fablet  
 
 W3C test importer should not import reference files as regular tests


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (191397 => 191398)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-10-21 20:04:12 UTC (rev 191398)
@@ -148,10 +148,6 @@
 CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
 CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
 CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
 CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'version' on a non-HTMLHtmlElement object.
 CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'text' on a non-HTMLTitleElement object.
 CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'href' on a non-HTMLBaseElement object.
@@ -2230,8 +2226,8 @@
 PASS Stringification of document.createElement("blink") 
 PASS HTMLUnknownElement must be primary interface of document.createElement("quasit") 
 PASS Stringification of document.createElement("quasit") 
-FAIL HTMLUnknownElement must be primary interface of document.createElement("bgsound") assert_equals: document.createElement("bgsound")'s prototype is not HTMLUnknownElement.prototype expected Node object of unknown type but got Node object of unknown type
-FAIL Stringification of document.createElement("bgsound") assert_equals: class string of document.createElement("bgsound") expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
+PASS HTMLUnknownElement must be primary interface of document.createElement("bgsound") 
+PASS Stringification of document.createElement("bgsound") 
 PASS HTMLUnknownElement must be primary interface of document.createElement("isindex") 
 PASS Stringification of document.createElement("isindex") 
 PASS HTMLUnknownElement must be primary interface of document.createElement("multicol") 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt (191397 => 191398)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt	2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt	2015-10-21 20:04:12 UTC (rev 191398)
@@ -17,8 +17,8 @@
 FAIL Interfaces for BASEFONT assert_equals: Element 

[webkit-changes] [191401] trunk/Source/WebKit2

[andersca]

Title: [191401] trunk/Source/WebKit2








Revision 191401
Author ander...@apple.com
Date 2015-10-21 14:04:43 -0700 (Wed, 21 Oct 2015)


Log Message
Stop using a popup menu button cell(!) for context menus
https://bugs.webkit.org/show_bug.cgi?id=150413

Reviewed by Tim Horton.

Just use a regular NSMenu. Also, have the service menu code path store the service menu
in the same member variable.

* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::clearServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):
(WebKit::WebContextMenuProxyMac::cancelTracking):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191400 => 191401)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 20:22:31 UTC (rev 191400)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 21:04:43 UTC (rev 191401)
@@ -1,3 +1,23 @@
+2015-10-21  Anders Carlsson  
+
+Stop using a popup menu button cell(!) for context menus
+https://bugs.webkit.org/show_bug.cgi?id=150413
+
+Reviewed by Tim Horton.
+
+Just use a regular NSMenu. Also, have the service menu code path store the service menu
+in the same member variable.
+
+* UIProcess/mac/WebContextMenuProxyMac.h:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::setupServicesMenu):
+(WebKit::WebContextMenuProxyMac::clearServicesMenu):
+(WebKit::WebContextMenuProxyMac::populate):
+(WebKit::WebContextMenuProxyMac::showContextMenu):
+(WebKit::WebContextMenuProxyMac::hideContextMenu):
+(WebKit::WebContextMenuProxyMac::cancelTracking):
+(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac): Deleted.
+
 2015-10-21  Chris Dumez  
 
 Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h (191400 => 191401)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 20:22:31 UTC (rev 191400)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 21:04:43 UTC (rev 191401)
@@ -74,10 +74,8 @@
 WebCore::ContextMenuItem shareMenuItem();
 #endif
 
-RetainPtr m_popup;
-#if ENABLE(SERVICE_CONTROLS)
-RetainPtr m_servicesMenu;
-#endif
+RetainPtr m_menu;
+
 WKView* m_webView;
 WebPageProxy& m_page;
 };


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191400 => 191401)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 20:22:31 UTC (rev 191400)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 21:04:43 UTC (rev 191401)
@@ -160,7 +160,6 @@
 
 WebContextMenuProxyMac::~WebContextMenuProxyMac()
 {
-[m_popup setControlView:nil];
 }
 
 void WebContextMenuProxyMac::contextMenuItemSelected(const WebContextMenuItemData& item)
@@ -284,10 +283,10 @@
 [[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setFiltersEditingServices:!includeEditorServices];
 [[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setHandlesEditingReplacement:includeEditorServices];
 
-m_servicesMenu = adoptNS([[picker menu] copy]);
+m_menu = adoptNS([[picker menu] copy]);
 
 if (!hasControlledImage)
-[m_servicesMenu setShowsStateColumn:YES];
+[m_menu setShowsStateColumn:YES];
 
 // Explicitly add a menu item for each telephone number that is in the selection.
 const Vector& selectedTelephoneNumbers = context.selectedTelephoneNumbers();
@@ -300,28 +299,28 @@
 }
 
 if (!telephoneNumberMenuItems.isEmpty()) {
-if (m_servicesMenu)
-[m_servicesMenu insertItem:[NSMenuItem separatorItem] atIndex:0];
+if (m_menu)
+[m_menu insertItem:[NSMenuItem separatorItem] atIndex:0];
 else
-m_servicesMenu = adoptNS([[NSMenu alloc] init]);
+m_menu = adoptNS([[NSMenu alloc] init]);
 int itemPosition = 0;
 NSMenuItem *groupEntry = [[NSMenuItem alloc] initWithTitle:menuItemTitleForTelephoneNumberGroup() action:nil keyEquivalent:@""];
 [groupEntry setEnabled:NO];
-[m_servicesMenu insertItem:groupEntry atIndex:itemPosition++];
+[m_menu insertItem:groupEntry atIndex:itemPosition++];
 for (auto& menuItem : telephoneNumberMenuItems)
-[m_servicesMenu insertItem:menuItem.get() atIndex:itemPosition++];
+[m_menu insertItem:menuItem.get() atIndex:itemPosition++];
 }
 
 // If there is no 

[webkit-changes] [191402] trunk/Source/WebKit2

[andersca]

Title: [191402] trunk/Source/WebKit2








Revision 191402
Author ander...@apple.com
Date 2015-10-21 14:26:41 -0700 (Wed, 21 Oct 2015)


Log Message
WebContextMenuProxy doesn't have to be ref-counted
https://bugs.webkit.org/show_bug.cgi?id=150415

Reviewed by Tim Horton.

Change WebContextMenuProxy to not inherit from RefCounted. Instead of using RefPtr, use std::unique_ptr.
Get rid of cancelTracking and hideContextMenu and dismiss the menu whenever the menu proxy is destroyed.
Also, rename showContextMenu to show.

* UIProcess/PageClient.h:
* UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::cancelTracking): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
* UIProcess/mac/WebContextMenuProxyMac.h:
(WebKit::WebContextMenuProxyMac::create): Deleted.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::hideContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::cancelTracking): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebContextMenuProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191401 => 191402)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 21:04:43 UTC (rev 191401)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 21:26:41 UTC (rev 191402)
@@ -1,5 +1,38 @@
 2015-10-21  Anders Carlsson  
 
+WebContextMenuProxy doesn't have to be ref-counted
+https://bugs.webkit.org/show_bug.cgi?id=150415
+
+Reviewed by Tim Horton.
+
+Change WebContextMenuProxy to not inherit from RefCounted. Instead of using RefPtr, use std::unique_ptr.
+Get rid of cancelTracking and hideContextMenu and dismiss the menu whenever the menu proxy is destroyed.
+Also, rename showContextMenu to show.
+
+* UIProcess/PageClient.h:
+* UIProcess/WebContextMenuProxy.h:
+(WebKit::WebContextMenuProxy::cancelTracking): Deleted.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::close):
+(WebKit::WebPageProxy::internalShowContextMenu):
+* UIProcess/WebPageProxy.h:
+* UIProcess/ios/PageClientImplIOS.h:
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::createContextMenuProxy):
+* UIProcess/mac/PageClientImpl.h:
+* UIProcess/mac/PageClientImpl.mm:
+(WebKit::PageClientImpl::createContextMenuProxy):
+* UIProcess/mac/WebContextMenuProxyMac.h:
+(WebKit::WebContextMenuProxyMac::create): Deleted.
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
+(WebKit::WebContextMenuProxyMac::show):
+(WebKit::WebContextMenuProxyMac::showContextMenu): Deleted.
+(WebKit::WebContextMenuProxyMac::hideContextMenu): Deleted.
+(WebKit::WebContextMenuProxyMac::cancelTracking): Deleted.
+
+2015-10-21  Anders Carlsson  
+
 Stop using a popup menu button cell(!) for context menus
 https://bugs.webkit.org/show_bug.cgi?id=150413
 


Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (191401 => 191402)

--- trunk/Source/WebKit2/UIProcess/PageClient.h	2015-10-21 21:04:43 UTC (rev 191401)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h	2015-10-21 21:26:41 UTC (rev 191402)
@@ -224,7 +224,7 @@
 
 virtual RefPtr createPopupMenuProxy(WebPageProxy&) = 0;
 #if ENABLE(CONTEXT_MENUS)
-virtual RefPtr createContextMenuProxy(WebPageProxy&, const ContextMenuContextData&, const UserData&) = 0;
+virtual std::unique_ptr createContextMenuProxy(WebPageProxy&, const ContextMenuContextData&, const UserData&) = 0;
 #endif
 
 #if ENABLE(INPUT_TYPE_COLOR)


Modified: trunk/Source/WebKit2/UIProcess/WebContextMenuProxy.h (191401 => 191402)

--- trunk/Source/WebKit2/UIProcess/WebContextMenuProxy.h	2015-10-21 21:04:43 UTC (rev 191401)
+++ trunk/Source/WebKit2/UIProcess/WebContextMenuProxy.h	2015-10-21 21:26:41 UTC (rev 191402)
@@ -36,13 +36,11 @@
 
 class WebContextMenuItem;
 
-class WebContextMenuProxy : public 

[webkit-changes] [191403] trunk

[dino]

Title: [191403] trunk








Revision 191403
Author d...@apple.com
Date 2015-10-21 14:45:26 -0700 (Wed, 21 Oct 2015)


Log Message
Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
https://bugs.webkit.org/show_bug.cgi?id=150212


Reviewed by Brent Fulgham.

Source/WebCore:

Handle the case where a filter element doesn't have a renderer. Inspired by the Blink
commit:
https://chromium.googlesource.com/chromium/src.git/+/fb79f7fc46552d45127acd2959a23662ad8f271e

Test: svg/filters/display-none-filter-primitive.html

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):

LayoutTests:

* svg/filters/display-none-filter-primitive-expected.txt: Added.
* svg/filters/display-none-filter-primitive.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp


Added Paths

trunk/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt
trunk/LayoutTests/svg/filters/display-none-filter-primitive.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191402 => 191403)

--- trunk/LayoutTests/ChangeLog	2015-10-21 21:26:41 UTC (rev 191402)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 21:45:26 UTC (rev 191403)
@@ -1,3 +1,14 @@
+2015-10-21  Dean Jackson  
+
+Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
+https://bugs.webkit.org/show_bug.cgi?id=150212
+
+
+Reviewed by Brent Fulgham.
+
+* svg/filters/display-none-filter-primitive-expected.txt: Added.
+* svg/filters/display-none-filter-primitive.html: Added.
+
 2015-10-21  Brady Eidson  
 
 Modern IDB: Add basic transaction aborting.


Added: trunk/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt (0 => 191403)

--- trunk/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt	2015-10-21 21:45:26 UTC (rev 191403)
@@ -0,0 +1 @@
+PASS if no crash
Property changes on: trunk/LayoutTests/svg/filters/display-none-filter-primitive-expected.txt
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Added: trunk/LayoutTests/svg/filters/display-none-filter-primitive.html (0 => 191403)

--- trunk/LayoutTests/svg/filters/display-none-filter-primitive.html	(rev 0)
+++ trunk/LayoutTests/svg/filters/display-none-filter-primitive.html	2015-10-21 21:45:26 UTC (rev 191403)
@@ -0,0 +1,15 @@
+
+
+  
+
+  
+
+
+  
+  
+
+PASS if no crash
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+
\ No newline at end of file
Property changes on: trunk/LayoutTests/svg/filters/display-none-filter-primitive.html
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (191402 => 191403)

--- trunk/Source/WebCore/ChangeLog	2015-10-21 21:26:41 UTC (rev 191402)
+++ trunk/Source/WebCore/ChangeLog	2015-10-21 21:45:26 UTC (rev 191403)
@@ -1,3 +1,22 @@
+2015-10-21  Dean Jackson  
+
+Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
+https://bugs.webkit.org/show_bug.cgi?id=150212
+
+
+Reviewed by Brent Fulgham.
+
+Handle the case where a filter element doesn't have a renderer. Inspired by the Blink
+commit:
+https://chromium.googlesource.com/chromium/src.git/+/fb79f7fc46552d45127acd2959a23662ad8f271e
+
+Test: svg/filters/display-none-filter-primitive.html
+
+* rendering/svg/RenderSVGResourceFilter.cpp:
+(WebCore::RenderSVGResourceFilter::buildPrimitives):
+* svg/graphics/filters/SVGFilterBuilder.cpp:
+(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
+
 2015-10-21  Brady Eidson  
 
 Modern IDB: Add basic transaction aborting.


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp (191402 => 191403)

--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp	2015-10-21 21:26:41 UTC (rev 191402)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp	2015-10-21 21:45:26 UTC (rev 191403)
@@ -90,7 +90,8 @@
 builder->appendEffectToEffectReferences(effect.copyRef(), element.renderer());
 element.setStandardAttributes(effect.get());
 effect->setEffectBoundaries(SVGLengthContext::resolveRectangle(, filterElement().primitiveUnits(), targetBoundingBox));
-

[webkit-changes] [191405] tags/Safari-602.1.8/

[bshafiei]

Title: [191405] tags/Safari-602.1.8/








Revision 191405
Author bshaf...@apple.com
Date 2015-10-21 15:08:43 -0700 (Wed, 21 Oct 2015)


Log Message
New tag.

Added Paths

tags/Safari-602.1.8/




Diff

Property changes: tags/Safari-602.1.8



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191412] trunk/Source/WebKit2

[andersca]

Title: [191412] trunk/Source/WebKit2








Revision 191412
Author ander...@apple.com
Date 2015-10-21 16:14:31 -0700 (Wed, 21 Oct 2015)


Log Message
Move services menu handling out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=150420

Reviewed by Tim Horton.

* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showServicesMenu):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::populate): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191411 => 191412)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 23:10:45 UTC (rev 191411)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 23:14:31 UTC (rev 191412)
@@ -1,3 +1,17 @@
+2015-10-21  Anders Carlsson  
+
+Move services menu handling out into a separate function
+https://bugs.webkit.org/show_bug.cgi?id=150420
+
+Reviewed by Tim Horton.
+
+* UIProcess/mac/WebContextMenuProxyMac.h:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::showServicesMenu):
+(WebKit::WebContextMenuProxyMac::show):
+(WebKit::WebContextMenuProxyMac::showContextMenu):
+(WebKit::WebContextMenuProxyMac::populate): Deleted.
+
 2015-10-21  Wenson Hsieh  
 
 Single tapping clickable elements in unscalable pages should show a tap highlight


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h (191411 => 191412)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 23:10:45 UTC (rev 191411)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 23:14:31 UTC (rev 191412)
@@ -59,9 +59,10 @@
 private:
 virtual void show() override;
 
-void populate(const Vector&);
+void showContextMenu();
 
 #if ENABLE(SERVICE_CONTROLS)
+void showServicesMenu();
 void setupServicesMenu();
 WebCore::ContextMenuItem shareMenuItem();
 #endif


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191411 => 191412)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 23:10:45 UTC (rev 191411)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 23:14:31 UTC (rev 191412)
@@ -318,6 +318,14 @@
 ServicesController::singleton().refreshExistingServices();
 }
 
+void WebContextMenuProxyMac::showServicesMenu()
+{
+setupServicesMenu();
+
+[[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setMenuProxy:this];
+[m_menu popUpMenuPositioningItem:nil atLocation:m_context.menuLocation() inView:m_webView];
+}
+
 void WebContextMenuProxyMac::clearServicesMenu()
 {
 [[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setPicker:nullptr];
@@ -360,30 +368,22 @@
 }
 #endif
 
-void WebContextMenuProxyMac::populate(const Vector& items)
+void WebContextMenuProxyMac::show()
 {
+Ref protect(m_page);
+
 #if ENABLE(SERVICE_CONTROLS)
 if (m_context.isServicesMenu()) {
-setupServicesMenu();
+showServicesMenu();
 return;
 }
 #endif
 
-m_menu = [[NSMenu alloc] initWithTitle:@""];
-[m_menu setAutoenablesItems:NO];
-
-populateNSMenu(m_menu.get(), nsMenuItemVector(items));
+showContextMenu();
 }
 
-void WebContextMenuProxyMac::show()
+void WebContextMenuProxyMac::showContextMenu()
 {
-// Unless this is an image control, give the PageContextMenuClient one last swipe at changing the menu.
-bool askClientToChangeMenu = true;
-#if ENABLE(SERVICE_CONTROLS)
-if (m_context.isServicesMenu() || m_context.controlledImage())
-askClientToChangeMenu = false;
-#endif
-
 Vector proposedAPIItems;
 for (auto& item : m_context.menuItems()) {
 if (item.action() != ContextMenuItemTagShareMenu) {
@@ -401,30 +401,20 @@
 Vector clientItems;
 bool useProposedItems = true;
 
-if (askClientToChangeMenu && m_page.contextMenuClient().getContextMenuFromProposedMenu(m_page, proposedAPIItems, clientItems, m_context.webHitTestResultData(), m_page.process().transformHandlesToObjects(m_userData.object()).get()))
+if (m_page.contextMenuClient().getContextMenuFromProposedMenu(m_page, proposedAPIItems, clientItems, m_context.webHitTestResultData(), m_page.process().transformHandlesToObjects(m_userData.object()).get()))
 useProposedItems = false;
 
 const Vector& items = useProposedItems ? proposedAPIItems : clientItems;
 
-#if ENABLE(SERVICE_CONTROLS)
-if (items.isEmpty() && !m_context.isServicesMenu())
-return;
-#else
 if (items.isEmpty())
 return;
-#endif
 
-populate(items);
+m_menu = [[NSMenu alloc] initWithTitle:@""];
+ 

[webkit-changes] [191404] trunk/Source/JavaScriptCore

[sbarati]

Title: [191404] trunk/Source/_javascript_Core








Revision 191404
Author sbar...@apple.com
Date 2015-10-21 14:49:08 -0700 (Wed, 21 Oct 2015)


Log Message
C calls in PolymorphicAccess shouldn't assume that the top of the stack looks like a JSC JIT frame and enable *ByIdFlush in FTL
https://bugs.webkit.org/show_bug.cgi?id=125711

Reviewed by Filip Pizlo.

This patch ensures that anytime we need to make a C call inside
PolymorphicAccess, we ensure there is enough space on the stack to do so.

This patch also enables GetByIdFlush/PutByIdFlush inside the FTL.
Because PolymorphicAccess now spills the necessary registers
before making a JS/C call, any registers that LLVM report as
being in use for the patchpoint will be spilled before making
a call by PolymorphicAccess.

* bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetById):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitTypeOf):
(JSC::AssemblyHelpers::makeSpaceOnStackForCCall):
(JSC::AssemblyHelpers::reclaimSpaceOnStackForCCall):
* jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForJSCall):
(JSC::RegisterSet::registersToNotSaveForCCall):
(JSC::RegisterSet::allGPRs):
(JSC::RegisterSet::registersToNotSaveForCall): Deleted.
* jit/RegisterSet.h:
(JSC::RegisterSet::set):
* jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
These methods now take an extra parameter indicating if they
should create space for a C call at the top of the stack if
there are any reused registers to spill.

(JSC::ScratchRegisterAllocator::usedRegistersForCall):
* jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::usedRegisters):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/RegisterSet.cpp
trunk/Source/_javascript_Core/jit/RegisterSet.h
trunk/Source/_javascript_Core/jit/ScratchRegisterAllocator.cpp
trunk/Source/_javascript_Core/jit/ScratchRegisterAllocator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191403 => 191404)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-21 21:45:26 UTC (rev 191403)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-21 21:49:08 UTC (rev 191404)
@@ -1,3 +1,56 @@
+2015-10-21  Saam barati  
+
+C calls in PolymorphicAccess shouldn't assume that the top of the stack looks like a JSC JIT frame and enable *ByIdFlush in FTL
+https://bugs.webkit.org/show_bug.cgi?id=125711
+
+Reviewed by Filip Pizlo.
+
+This patch ensures that anytime we need to make a C call inside
+PolymorphicAccess, we ensure there is enough space on the stack to do so.
+
+This patch also enables GetByIdFlush/PutByIdFlush inside the FTL.
+Because PolymorphicAccess now spills the necessary registers
+before making a JS/C call, any registers that LLVM report as
+being in use for the patchpoint will be spilled before making
+a call by PolymorphicAccess.
+
+* bytecode/PolymorphicAccess.cpp:
+(JSC::AccessGenerationState::restoreScratch):
+(JSC::AccessGenerationState::succeed):
+(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
+(JSC::AccessCase::generate):
+(JSC::PolymorphicAccess::regenerate):
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
+(JSC::FTL::DFG::LowerDFGToLLVM::compileGetById):
+(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::emitTypeOf):
+(JSC::AssemblyHelpers::makeSpaceOnStackForCCall):
+(JSC::AssemblyHelpers::reclaimSpaceOnStackForCCall):
+* jit/RegisterSet.cpp:
+(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
+(JSC::RegisterSet::registersToNotSaveForJSCall):
+(JSC::RegisterSet::registersToNotSaveForCCall):
+(JSC::RegisterSet::allGPRs):
+(JSC::RegisterSet::registersToNotSaveForCall): Deleted.
+* jit/RegisterSet.h:
+

[webkit-changes] [191409] trunk/Source/WebKit2

[wenson_hsieh]

Title: [191409] trunk/Source/WebKit2








Revision 191409
Author wenson_hs...@apple.com
Date 2015-10-21 15:30:59 -0700 (Wed, 21 Oct 2015)


Log Message
Single tapping clickable elements in unscalable pages should show a tap highlight
https://bugs.webkit.org/show_bug.cgi?id=150382

Reviewed by Simon Fraser.

When the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is
committed before the geometries come in. To fix this, we introduce a flag that allows the single tap to be
committed before the tap highlight arrives. This allows the tap highlight to be immediately animated when receiving
the tap highlight geometries only in the case where double tapping is disabled when recognizing the single tap.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _singleTapCommited:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191408 => 191409)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 22:30:01 UTC (rev 191408)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 22:30:59 UTC (rev 191409)
@@ -1,3 +1,23 @@
+2015-10-21  Wenson Hsieh  
+
+Single tapping clickable elements in unscalable pages should show a tap highlight
+https://bugs.webkit.org/show_bug.cgi?id=150382
+
+Reviewed by Simon Fraser.
+
+When the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is
+committed before the geometries come in. To fix this, we introduce a flag that allows the single tap to be
+committed before the tap highlight arrives. This allows the tap highlight to be immediately animated when receiving
+the tap highlight geometries only in the case where double tapping is disabled when recognizing the single tap.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView setupInteraction]):
+(-[WKContentView cleanupInteraction]):
+(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
+(-[WKContentView _singleTapRecognized:]):
+(-[WKContentView _singleTapCommited:]):
+
 2015-10-21  Anders Carlsson  
 
 Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (191408 => 191409)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-10-21 22:30:01 UTC (rev 191408)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-10-21 22:30:59 UTC (rev 191409)
@@ -158,6 +158,7 @@
 BOOL _usingGestureForSelection;
 BOOL _inspectorNodeSearchEnabled;
 BOOL _didAccessoryTabInitiateFocus;
+BOOL _isExpectingFastSingleTapCommit;
 }
 
 @end


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (191408 => 191409)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-10-21 22:30:01 UTC (rev 191408)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-10-21 22:30:59 UTC (rev 191409)
@@ -453,6 +453,7 @@
 _actionSheetAssistant = adoptNS([[WKActionSheetAssistant alloc] initWithView:self]);
 [_actionSheetAssistant setDelegate:self];
 _smartMagnificationController = std::make_unique(self);
+_isExpectingFastSingleTapCommit = NO;
 }
 
 - (void)cleanupInteraction
@@ -462,6 +463,7 @@
 _actionSheetAssistant = nil;
 _smartMagnificationController = nil;
 _didAccessoryTabInitiateFocus = NO;
+_isExpectingFastSingleTapCommit = NO;
 [_formInputSession invalidate];
 _formInputSession = nil;
 [_highlightView removeFromSuperview];
@@ -849,6 +851,11 @@
 }
 
 [self _showTapHighlight];
+if (_isExpectingFastSingleTapCommit) {
+[self _finishInteraction];
+if (!_potentialTapInProgress)
+_isExpectingFastSingleTapCommit = NO;
+}
 }
 
 - (CGFloat)_fastClickZoomThreshold
@@ -1244,6 +1251,7 @@
 _page->potentialTapAtPosition(gestureRecognizer.location, ++_latestTapID);
 _potentialTapInProgress = YES;
 _isTapHighlightIDValid = YES;
+_isExpectingFastSingleTapCommit = !_doubleTapGestureRecognizer.get().enabled;
 }
 
 static void cancelPotentialTapIfNecessary(WKContentView* contentView)
@@ -1297,7 +1305,8 @@
 
 _page->commitPotentialTap();
 
-[self _finishInteraction];
+if (!_isExpectingFastSingleTapCommit)
+[self _finishInteraction];
 }
 
 - 

[webkit-changes] [191407] trunk/Source/WebKit2

[andersca]

Title: [191407] trunk/Source/WebKit2








Revision 191407
Author ander...@apple.com
Date 2015-10-21 15:17:03 -0700 (Wed, 21 Oct 2015)


Log Message
WebContextMenuProxyMac::setupServicesMenu doesn't need to take a context parameter
https://bugs.webkit.org/show_bug.cgi?id=150418

Reviewed by Tim Horton.

* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191406 => 191407)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 22:14:38 UTC (rev 191406)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 22:17:03 UTC (rev 191407)
@@ -1,5 +1,17 @@
 2015-10-21  Anders Carlsson  
 
+WebContextMenuProxyMac::setupServicesMenu doesn't need to take a context parameter
+https://bugs.webkit.org/show_bug.cgi?id=150418
+
+Reviewed by Tim Horton.
+
+* UIProcess/mac/WebContextMenuProxyMac.h:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::setupServicesMenu):
+(WebKit::WebContextMenuProxyMac::populate):
+
+2015-10-21  Anders Carlsson  
+
 WebContextMenuProxy doesn't have to be ref-counted
 https://bugs.webkit.org/show_bug.cgi?id=150415
 


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h (191406 => 191407)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 22:14:38 UTC (rev 191406)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.h	2015-10-21 22:17:03 UTC (rev 191407)
@@ -62,7 +62,7 @@
 void populate(const Vector&);
 
 #if ENABLE(SERVICE_CONTROLS)
-void setupServicesMenu(const ContextMenuContextData&);
+void setupServicesMenu();
 WebCore::ContextMenuItem shareMenuItem();
 #endif
 


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191406 => 191407)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 22:14:38 UTC (rev 191406)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-21 22:17:03 UTC (rev 191407)
@@ -248,13 +248,13 @@
 }
 
 #if ENABLE(SERVICE_CONTROLS)
-void WebContextMenuProxyMac::setupServicesMenu(const ContextMenuContextData& context)
+void WebContextMenuProxyMac::setupServicesMenu()
 {
-bool includeEditorServices = context.controlledDataIsEditable();
-bool hasControlledImage = context.controlledImage();
+bool includeEditorServices = m_context.controlledDataIsEditable();
+bool hasControlledImage = m_context.controlledImage();
 NSArray *items = nil;
 if (hasControlledImage) {
-RefPtr image = context.controlledImage();
+RefPtr image = m_context.controlledImage();
 if (!image)
 return;
 
@@ -267,9 +267,9 @@
 #else
 items = @[ ];
 #endif
-} else if (!context.controlledSelectionData().isEmpty()) {
-RetainPtr selectionData = adoptNS([[NSData alloc] initWithBytes:(void*)context.controlledSelectionData().data() length:context.controlledSelectionData().size()]);
-RetainPtr selection = adoptNS([[NSAttributedString alloc] initWithRTFD:selectionData.get() documentAttributes:nil]);
+} else if (!m_context.controlledSelectionData().isEmpty()) {
+auto selectionData = adoptNS([[NSData alloc] initWithBytes:static_cast(m_context.controlledSelectionData().data()) length:m_context.controlledSelectionData().size()]);
+auto selection = adoptNS([[NSAttributedString alloc] initWithRTFD:selectionData.get() documentAttributes:nil]);
 
 items = @[ selection.get() ];
 } else {
@@ -290,9 +290,9 @@
 [m_menu setShowsStateColumn:YES];
 
 // Explicitly add a menu item for each telephone number that is in the selection.
-const Vector& selectedTelephoneNumbers = context.selectedTelephoneNumbers();
 Vector telephoneNumberMenuItems;
-for (auto& telephoneNumber : selectedTelephoneNumbers) {
+
+for (auto& telephoneNumber : m_context.selectedTelephoneNumbers()) {
 if (NSMenuItem *item = menuItemForTelephoneNumber(telephoneNumber)) {
 [item setIndentationLevel:1];
 telephoneNumberMenuItems.append(item);
@@ -364,7 +364,7 @@
 {
 #if ENABLE(SERVICE_CONTROLS)
 if (m_context.isServicesMenu()) {
-setupServicesMenu(m_context);
+setupServicesMenu();
 return;
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191408] trunk/Source/WebKit2

[andersca]

Title: [191408] trunk/Source/WebKit2








Revision 191408
Author ander...@apple.com
Date 2015-10-21 15:30:01 -0700 (Wed, 21 Oct 2015)


Log Message
Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
https://bugs.webkit.org/show_bug.cgi?id=150417

Reviewed by Tim Horton.

The useBinaryEncoding parameter is always false, so just get rid of it.

* UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsMHTMLData):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_page_contents_get):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_save):
(webkit_web_view_save_to_file):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getContentsAsMHTMLData):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsMHTMLData):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191407 => 191408)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 22:17:03 UTC (rev 191407)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 22:30:01 UTC (rev 191408)
@@ -1,5 +1,30 @@
 2015-10-21  Anders Carlsson  
 
+Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
+https://bugs.webkit.org/show_bug.cgi?id=150417
+
+Reviewed by Tim Horton.
+
+The useBinaryEncoding parameter is always false, so just get rid of it.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageGetContentsAsMHTMLData):
+* UIProcess/API/C/WKPage.h:
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_page_contents_get):
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_save):
+(webkit_web_view_save_to_file):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::getContentsAsMHTMLData):
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::getContentsAsMHTMLData):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
+2015-10-21  Anders Carlsson  
+
 WebContextMenuProxyMac::setupServicesMenu doesn't need to take a context parameter
 https://bugs.webkit.org/show_bug.cgi?id=150418
 


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (191407 => 191408)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2015-10-21 22:17:03 UTC (rev 191407)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2015-10-21 22:30:01 UTC (rev 191408)
@@ -2185,13 +2185,12 @@
 toImpl(pageRef)->getSelectionAsWebArchiveData(toGenericCallbackFunction(context, callback));
 }
 
-void WKPageGetContentsAsMHTMLData(WKPageRef pageRef, bool useBinaryEncoding, void* context, WKPageGetContentsAsMHTMLDataFunction callback)
+void WKPageGetContentsAsMHTMLData(WKPageRef pageRef, void* context, WKPageGetContentsAsMHTMLDataFunction callback)
 {
 #if ENABLE(MHTML)
-toImpl(pageRef)->getContentsAsMHTMLData(toGenericCallbackFunction(context, callback), useBinaryEncoding);
+toImpl(pageRef)->getContentsAsMHTMLData(toGenericCallbackFunction(context, callback));
 #else
 UNUSED_PARAM(pageRef);
-UNUSED_PARAM(useBinaryEncoding);
 UNUSED_PARAM(context);
 UNUSED_PARAM(callback);
 #endif


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.h (191407 => 191408)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2015-10-21 22:17:03 UTC (rev 191407)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2015-10-21 22:30:01 UTC (rev 191408)
@@ -244,7 +244,7 @@
 WK_EXPORT void WKPageGetContentsAsString(WKPageRef page, void* context, WKPageGetContentsAsStringFunction function);
 
 typedef void (*WKPageGetContentsAsMHTMLDataFunction)(WKDataRef, WKErrorRef, void*);
-WK_EXPORT void WKPageGetContentsAsMHTMLData(WKPageRef page, bool useBinaryEncoding, void* context, WKPageGetContentsAsMHTMLDataFunction function);
+WK_EXPORT void WKPageGetContentsAsMHTMLData(WKPageRef page, void* context, WKPageGetContentsAsMHTMLDataFunction function);
 
 typedef void (*WKPageGetSelectionAsWebArchiveDataFunction)(WKDataRef, WKErrorRef, void*);
 WK_EXPORT void WKPageGetSelectionAsWebArchiveData(WKPageRef page, void* context, WKPageGetSelectionAsWebArchiveDataFunction function);


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (191407 => 191408)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2015-10-21 22:17:03 UTC (rev 191407)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2015-10-21 22:30:01 UTC (rev 

[webkit-changes] [191410] trunk/Tools

[commit-queue]

Title: [191410] trunk/Tools








Revision 191410
Author commit-qu...@webkit.org
Date 2015-10-21 16:05:53 -0700 (Wed, 21 Oct 2015)


Log Message
run-webkit-tests does not copy all crash logs for layout test failures on Mac
https://bugs.webkit.org/show_bug.cgi?id=150407


Patch by Aakash Jain  on 2015-10-21
Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/mac.py:
(MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
the log directory.
(MacPort.look_for_new_crash_logs): Uses above method to get crash logs
from log directory and merge them with the list of already crashed tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/mac.py




Diff

Modified: trunk/Tools/ChangeLog (191409 => 191410)

--- trunk/Tools/ChangeLog	2015-10-21 22:30:59 UTC (rev 191409)
+++ trunk/Tools/ChangeLog	2015-10-21 23:05:53 UTC (rev 191410)
@@ -1,3 +1,18 @@
+2015-10-21  Aakash Jain  
+
+run-webkit-tests does not copy all crash logs for layout test failures on Mac
+https://bugs.webkit.org/show_bug.cgi?id=150407
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/mac.py:
+(MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
+(MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
+the log directory.
+(MacPort.look_for_new_crash_logs): Uses above method to get crash logs
+from log directory and merge them with the list of already crashed tests.
+
 2015-10-21  Filip Pizlo  
 
 Failures in PutStackSinkingPhase should be less severe


Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (191409 => 191410)

--- trunk/Tools/Scripts/webkitpy/port/mac.py	2015-10-21 22:30:59 UTC (rev 191409)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py	2015-10-21 23:05:53 UTC (rev 191410)
@@ -220,6 +220,22 @@
 return (stderr, None)
 return (stderr, crash_log)
 
+def _merge_crash_logs(self, logs, new_logs, crashed_processes):
+for test, crash_log in new_logs.iteritems():
+try:
+process_name = test.split("-")[0]
+pid = int(test.split("-")[1])
+except IndexError:
+continue
+if not any(entry[1] == process_name and entry[2] == pid for entry in crashed_processes):
+# if this is a new crash, then append the logs
+logs[test] = crash_log
+return logs
+
+def _look_for_all_crash_logs_in_log_dir(self, newer_than):
+crash_log = CrashLogs(self.host)
+return crash_log.find_all_logs(include_errors=True, newer_than=newer_than)
+
 def look_for_new_crash_logs(self, crashed_processes, start_time):
 """Since crash logs can take a long time to be written out if the system is
under stress do a second pass at the end of the test run.
@@ -236,7 +252,8 @@
 if not crash_log:
 continue
 crash_logs[test_name] = crash_log
-return crash_logs
+all_crash_log = self._look_for_all_crash_logs_in_log_dir(start_time)
+return self._merge_crash_logs(crash_logs, all_crash_log, crashed_processes)
 
 def look_for_new_samples(self, unresponsive_processes, start_time):
 sample_files = {}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191411] tags/Safari-602.1.8

[bshafiei]

Title: [191411] tags/Safari-602.1.8








Revision 191411
Author bshaf...@apple.com
Date 2015-10-21 16:10:45 -0700 (Wed, 21 Oct 2015)


Log Message
Roll out r191360. rdar://problem/23205990

Modified Paths

tags/Safari-602.1.8/LayoutTests/ChangeLog
tags/Safari-602.1.8/LayoutTests/js/caller-property-expected.txt
tags/Safari-602.1.8/Source/_javascript_Core/ChangeLog
tags/Safari-602.1.8/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
tags/Safari-602.1.8/Source/_javascript_Core/jit/AssemblyHelpers.h
tags/Safari-602.1.8/Source/_javascript_Core/runtime/Options.h
tags/Safari-602.1.8/Source/_javascript_Core/tests/es6.yaml
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/dfg-tail-calls.js
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/tail-call-recognize.js
tags/Safari-602.1.8/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js


Removed Paths

tags/Safari-602.1.8/LayoutTests/js/regress-150336-expected.txt
tags/Safari-602.1.8/LayoutTests/js/regress-150336.html
tags/Safari-602.1.8/LayoutTests/js/script-tests/regress-150336.js




Diff

Modified: tags/Safari-602.1.8/LayoutTests/ChangeLog (191410 => 191411)

--- tags/Safari-602.1.8/LayoutTests/ChangeLog	2015-10-21 23:05:53 UTC (rev 191410)
+++ tags/Safari-602.1.8/LayoutTests/ChangeLog	2015-10-21 23:10:45 UTC (rev 191411)
@@ -1,3 +1,7 @@
+2015-10-21  Babak Shafiei  
+
+Roll out r191360.
+
 2015-10-20  Ryan Haddad  
 
 Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite


Modified: tags/Safari-602.1.8/LayoutTests/js/caller-property-expected.txt (191410 => 191411)

--- tags/Safari-602.1.8/LayoutTests/js/caller-property-expected.txt	2015-10-21 23:05:53 UTC (rev 191410)
+++ tags/Safari-602.1.8/LayoutTests/js/caller-property-expected.txt	2015-10-21 23:10:45 UTC (rev 191411)
@@ -10,13 +10,13 @@
 PASS nonStrictCaller(strictCallee) threw exception TypeError: Type error.
 PASS strictCaller(nonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
 PASS strictCaller(strictCallee) threw exception TypeError: Type error.
-PASS strictTailCaller(nonStrictCallee) is null
+FAIL strictTailCaller(nonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
 PASS strictTailCaller(strictCallee) threw exception TypeError: Type error.
 PASS nonStrictCaller(boundNonStrictCallee) is nonStrictCaller
 PASS nonStrictCaller(boundStrictCallee) threw exception TypeError: Type error.
 PASS strictCaller(boundNonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
 PASS strictCaller(boundStrictCallee) threw exception TypeError: Type error.
-PASS strictTailCaller(boundNonStrictCallee) is null
+FAIL strictTailCaller(boundNonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
 PASS strictTailCaller(boundStrictCallee) threw exception TypeError: Type error.
 PASS nonStrictGetter(nonStrictAccessor) is nonStrictGetter
 PASS nonStrictSetter(nonStrictAccessor) is true


Deleted: tags/Safari-602.1.8/LayoutTests/js/regress-150336-expected.txt (191410 => 191411)

--- tags/Safari-602.1.8/LayoutTests/js/regress-150336-expected.txt	2015-10-21 23:05:53 UTC (rev 191410)
+++ tags/Safari-602.1.8/LayoutTests/js/regress-150336-expected.txt	2015-10-21 23:10:45 UTC (rev 191411)
@@ -1,10 +0,0 @@
-Regression test for https://webkit.org/b/150336.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Properly handled OSR exit from a bound function with an inlined tail callee.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: tags/Safari-602.1.8/LayoutTests/js/regress-150336.html (191410 => 191411)

--- tags/Safari-602.1.8/LayoutTests/js/regress-150336.html	2015-10-21 23:05:53 UTC (rev 191410)
+++ tags/Safari-602.1.8/LayoutTests/js/regress-150336.html	2015-10-21 23:10:45 UTC (rev 191411)
@@ -1,10 +0,0 @@
-
-
-

[webkit-changes] [191424] trunk/Source

[fpizlo]

Title: [191424] trunk/Source








Revision 191424
Author fpi...@apple.com
Date 2015-10-21 18:46:06 -0700 (Wed, 21 Oct 2015)


Log Message
Factor out the graph node worklists from DFG into WTF
https://bugs.webkit.org/show_bug.cgi?id=150411

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

Rewrite the DFGBlockWorklist.h file as a bunch of typedefs and aliases for things in
wtf/GraphNodeWorklist.h. Most users won't notice, except that some small things got
renamed. For example PreOrder becomes VisitOrder::Pre and item.block becomes item.node.

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGBlockWorklist.cpp: Removed.
* dfg/DFGBlockWorklist.h:
(JSC::DFG::BlockWorklist::notEmpty): Deleted.
(JSC::DFG::BlockWith::BlockWith): Deleted.
(JSC::DFG::BlockWith::operator bool): Deleted.
(JSC::DFG::ExtendedBlockWorklist::ExtendedBlockWorklist): Deleted.
(JSC::DFG::ExtendedBlockWorklist::forcePush): Deleted.
(JSC::DFG::ExtendedBlockWorklist::push): Deleted.
(JSC::DFG::ExtendedBlockWorklist::notEmpty): Deleted.
(JSC::DFG::ExtendedBlockWorklist::pop): Deleted.
(JSC::DFG::BlockWithOrder::BlockWithOrder): Deleted.
(JSC::DFG::BlockWithOrder::operator bool): Deleted.
(JSC::DFG::PostOrderBlockWorklist::push): Deleted.
(JSC::DFG::PostOrderBlockWorklist::notEmpty): Deleted.
* dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::compute):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::blocksInPostOrder):
* dfg/DFGPrePostNumbering.cpp:
(JSC::DFG::PrePostNumbering::compute):

Source/WTF:

The new GraphNodeWorklist.h file is basically just the functionality from the old
DFGBlockWorklist.h, but templatized to work for any graph node type and any kind of graph
node set.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/GraphNodeWorklist.h: Added.
(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::notEmpty):
(WTF::GraphNodeWorklist::pop):
(WTF::GraphNodeWith::GraphNodeWith):
(WTF::GraphNodeWith::operator bool):
(WTF::ExtendedGraphNodeWorklist::ExtendedGraphNodeWorklist):
(WTF::ExtendedGraphNodeWorklist::forcePush):
(WTF::ExtendedGraphNodeWorklist::push):
(WTF::ExtendedGraphNodeWorklist::notEmpty):
(WTF::ExtendedGraphNodeWorklist::pop):
(WTF::GraphNodeWithOrder::GraphNodeWithOrder):
(WTF::GraphNodeWithOrder::operator bool):
(WTF::PostOrderGraphNodeWorklist::PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::~PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::pushPre):
(WTF::PostOrderGraphNodeWorklist::pushPost):
(WTF::PostOrderGraphNodeWorklist::push):
(WTF::PostOrderGraphNodeWorklist::notEmpty):
(WTF::PostOrderGraphNodeWorklist::pop):
* wtf/HashTable.h:
(WTF::HashTableAddResult::HashTableAddResult):
(WTF::HashTableAddResult::operator bool):

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGBlockWorklist.h
trunk/Source/_javascript_Core/dfg/DFGDominators.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGPrePostNumbering.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/HashTable.h


Added Paths

trunk/Source/WTF/wtf/GraphNodeWorklist.h


Removed Paths

trunk/Source/_javascript_Core/dfg/DFGBlockWorklist.cpp




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (191423 => 191424)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2015-10-22 00:58:24 UTC (rev 191423)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2015-10-22 01:46:06 UTC (rev 191424)
@@ -150,7 +150,6 @@
 dfg/DFGBasicBlock.cpp
 dfg/DFGBlockInsertionSet.cpp
 dfg/DFGBlockSet.cpp
-dfg/DFGBlockWorklist.cpp
 dfg/DFGByteCodeParser.cpp
 dfg/DFGCFAPhase.cpp
 dfg/DFGCFGSimplificationPhase.cpp


Modified: trunk/Source/_javascript_Core/ChangeLog (191423 => 191424)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-22 00:58:24 UTC (rev 191423)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-22 01:46:06 UTC (rev 191424)
@@ -1,3 +1,37 @@
+2015-10-21  Filip Pizlo  
+
+Factor out the graph node worklists from DFG into WTF
+https://bugs.webkit.org/show_bug.cgi?id=150411
+
+Reviewed by Geoffrey Garen.
+
+Rewrite the DFGBlockWorklist.h file as a bunch of typedefs and aliases for things in
+wtf/GraphNodeWorklist.h. Most users won't notice, except that some small things got
+renamed. For example PreOrder becomes VisitOrder::Pre and item.block becomes item.node.
+
+* CMakeLists.txt:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* dfg/DFGBlockWorklist.cpp: Removed.
+* dfg/DFGBlockWorklist.h:
+(JSC::DFG::BlockWorklist::notEmpty): Deleted.
+(JSC::DFG::BlockWith::BlockWith): Deleted.
+(JSC::DFG::BlockWith::operator bool): Deleted.
+(JSC::DFG::ExtendedBlockWorklist::ExtendedBlockWorklist): 

[webkit-changes] [191425] trunk/Source/JavaScriptCore

[benjamin]

Title: [191425] trunk/Source/_javascript_Core








Revision 191425
Author benja...@webkit.org
Date 2015-10-21 18:57:26 -0700 (Wed, 21 Oct 2015)


Log Message
[JSC] Remove two useless temporaries from the PutByOffset codegen
https://bugs.webkit.org/show_bug.cgi?id=150421

Patch by Benjamin Poulain  on 2015-10-21
Reviewed by Geoffrey Garen.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
Looks like they were added by accident in r160796.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191424 => 191425)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-22 01:46:06 UTC (rev 191424)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-22 01:57:26 UTC (rev 191425)
@@ -1,3 +1,14 @@
+2015-10-21  Benjamin Poulain  
+
+[JSC] Remove two useless temporaries from the PutByOffset codegen
+https://bugs.webkit.org/show_bug.cgi?id=150421
+
+Reviewed by Geoffrey Garen.
+
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile): Deleted.
+Looks like they were added by accident in r160796.
+
 2015-10-21  Filip Pizlo  
 
 Factor out the graph node worklists from DFG into WTF


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (191424 => 191425)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2015-10-22 01:46:06 UTC (rev 191424)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2015-10-22 01:57:26 UTC (rev 191425)
@@ -4102,8 +4102,6 @@
 case PutByOffset: {
 StorageOperand storage(this, node->child1());
 JSValueOperand value(this, node->child3());
-GPRTemporary scratch1(this);
-GPRTemporary scratch2(this);
 
 GPRReg storageGPR = storage.gpr();
 GPRReg valueGPR = value.gpr();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191426] trunk/Source/JavaScriptCore

[benjamin]

Title: [191426] trunk/Source/_javascript_Core








Revision 191426
Author benja...@webkit.org
Date 2015-10-21 18:58:24 -0700 (Wed, 21 Oct 2015)


Log Message
[JSC] Remove FTL Native Inlining, it is dead code
https://bugs.webkit.org/show_bug.cgi?id=150429

Patch by Benjamin Poulain  on 2015-10-21
Reviewed by Filip Pizlo.

The code is not used and it is in the way of other changes.

* ftl/FTLAbbreviations.h:
(JSC::FTL::getFirstInstruction): Deleted.
(JSC::FTL::getNextInstruction): Deleted.
(JSC::FTL::getFirstBasicBlock): Deleted.
(JSC::FTL::getNextBasicBlock): Deleted.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::isInlinableSize): Deleted.
* runtime/Options.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191425 => 191426)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-22 01:57:26 UTC (rev 191425)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-22 01:58:24 UTC (rev 191426)
@@ -1,5 +1,23 @@
 2015-10-21  Benjamin Poulain  
 
+[JSC] Remove FTL Native Inlining, it is dead code
+https://bugs.webkit.org/show_bug.cgi?id=150429
+
+Reviewed by Filip Pizlo.
+
+The code is not used and it is in the way of other changes.
+
+* ftl/FTLAbbreviations.h:
+(JSC::FTL::getFirstInstruction): Deleted.
+(JSC::FTL::getNextInstruction): Deleted.
+(JSC::FTL::getFirstBasicBlock): Deleted.
+(JSC::FTL::getNextBasicBlock): Deleted.
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::isInlinableSize): Deleted.
+* runtime/Options.h:
+
+2015-10-21  Benjamin Poulain  
+
 [JSC] Remove two useless temporaries from the PutByOffset codegen
 https://bugs.webkit.org/show_bug.cgi?id=150421
 


Modified: trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h (191425 => 191426)

--- trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h	2015-10-22 01:57:26 UTC (rev 191425)
+++ trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h	2015-10-22 01:58:24 UTC (rev 191426)
@@ -149,10 +149,6 @@
 
 static inline void setMetadata(LValue instruction, unsigned kind, LValue metadata) { llvm->SetMetadata(instruction, kind, metadata); }
 
-static inline LValue getFirstInstruction(LBasicBlock block) { return llvm->GetFirstInstruction(block); }
-static inline LValue getNextInstruction(LValue instruction) { return llvm->GetNextInstruction(instruction); }
-
-
 static inline LValue addFunction(LModule module, const char* name, LType type) { return llvm->AddFunction(module, name, type); }
 static inline LValue getNamedFunction(LModule module, const char* name) { return llvm->GetNamedFunction(module, name); }
 static inline LValue getFirstFunction(LModule module) { return llvm->GetFirstFunction(module); }
@@ -214,9 +210,6 @@
 static inline LValue constNull(LType type) { return llvm->ConstNull(type); }
 static inline LValue constBitCast(LValue value, LType type) { return llvm->ConstBitCast(value, type); }
 
-static inline LBasicBlock getFirstBasicBlock(LValue function) { return llvm->GetFirstBasicBlock(function); }
-static inline LBasicBlock getNextBasicBlock(LBasicBlock block) { return llvm->GetNextBasicBlock(block); }
-
 static inline LBasicBlock appendBasicBlock(LContext context, LValue function, const char* name = "") { return llvm->AppendBasicBlockInContext(context, function, name); }
 static inline LBasicBlock insertBasicBlock(LContext context, LBasicBlock beforeBasicBlock, const char* name = "") { return llvm->InsertBasicBlockInContext(context, beforeBasicBlock, name); }
 


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (191425 => 191426)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-10-22 01:57:26 UTC (rev 191425)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-10-22 01:58:24 UTC (rev 191426)
@@ -5647,19 +5647,6 @@
 m_out.appendTo(continuation, lastNext);
 }
 
-bool isInlinableSize(LValue function)
-{
-size_t instructionCount = 0;
-size_t maxSize = Options::maximumLLVMInstructionCountForNativeInlining();
-for (LBasicBlock basicBlock = getFirstBasicBlock(function); basicBlock; basicBlock = getNextBasicBlock(basicBlock)) {
-for (LValue instruction = getFirstInstruction(basicBlock); instruction; instruction = getNextInstruction(instruction)) {
-if (++instructionCount >= maxSize)
-return false;
-}
-}
-return true;
-}
-
 LValue didOverflowStack()
 {
 // This does a very simple leaf function analysis. The invariant of FTL call


Modified: trunk/Source/_javascript_Core/runtime/Options.h (191425 => 191426)

--- 

[webkit-changes] [191427] trunk/Source/WebCore

[gyuyoung . kim]

Title: [191427] trunk/Source/WebCore








Revision 191427
Author gyuyoung@webkit.org
Date 2015-10-21 19:02:04 -0700 (Wed, 21 Oct 2015)


Log Message
Remove unnecessary default quota setting in DatabaseContext::databaseExceededQuota
https://bugs.webkit.org/show_bug.cgi?id=150356

Reviewed by Darin Adler.

All ports have supported DatabaseContext::databaseExceededQuota(). Thus we don't need to
keep a test code to extend database quota anymore.

* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191426 => 191427)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 01:58:24 UTC (rev 191426)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 02:02:04 UTC (rev 191427)
@@ -1,3 +1,16 @@
+2015-10-21  Gyuyoung Kim  
+
+Remove unnecessary default quota setting in DatabaseContext::databaseExceededQuota
+https://bugs.webkit.org/show_bug.cgi?id=150356
+
+Reviewed by Darin Adler.
+
+All ports have supported DatabaseContext::databaseExceededQuota(). Thus we don't need to
+keep a test code to extend database quota anymore.
+
+* Modules/webdatabase/DatabaseContext.cpp:
+(WebCore::DatabaseContext::databaseExceededQuota): Deleted.
+
 2015-10-21  Chris Dumez  
 
 Un-expose obsolete HTMLBaseFontElement


Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp (191426 => 191427)

--- trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp	2015-10-22 01:58:24 UTC (rev 191426)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp	2015-10-22 02:02:04 UTC (rev 191427)
@@ -216,9 +216,6 @@
 return;
 }
 ASSERT(m_scriptExecutionContext->isWorkerGlobalScope());
-// FIXME: This needs a real implementation; this is a temporary solution for testing.
-const unsigned long long defaultQuota = 5 * 1024 * 1024;
-DatabaseManager::singleton().setQuota(m_scriptExecutionContext->securityOrigin(), defaultQuota);
 }
 
 SecurityOrigin* DatabaseContext::securityOrigin() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191428] trunk/Source/WebCore

[achristensen]

Title: [191428] trunk/Source/WebCore








Revision 191428
Author achristen...@apple.com
Date 2015-10-21 19:18:42 -0700 (Wed, 21 Oct 2015)


Log Message
Build fix after r191422.

* page/ContextMenuClient.h:
(WebCore::ContextMenuClient::~ContextMenuClient):
Completely remove customizeMenu.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ContextMenuClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191427 => 191428)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 02:02:04 UTC (rev 191427)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 02:18:42 UTC (rev 191428)
@@ -1,3 +1,11 @@
+2015-10-21  Alex Christensen  
+
+Build fix after r191422.
+
+* page/ContextMenuClient.h:
+(WebCore::ContextMenuClient::~ContextMenuClient):
+Completely remove customizeMenu.
+
 2015-10-21  Gyuyoung Kim  
 
 Remove unnecessary default quota setting in DatabaseContext::databaseExceededQuota


Modified: trunk/Source/WebCore/page/ContextMenuClient.h (191427 => 191428)

--- trunk/Source/WebCore/page/ContextMenuClient.h	2015-10-22 02:02:04 UTC (rev 191427)
+++ trunk/Source/WebCore/page/ContextMenuClient.h	2015-10-22 02:18:42 UTC (rev 191428)
@@ -43,9 +43,7 @@
 virtual ~ContextMenuClient() {  }
 virtual void contextMenuDestroyed() = 0;
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-virtual std::unique_ptr customizeMenu(std::unique_ptr) = 0;
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 virtual PlatformMenuDescription getCustomMenuFromDefaultItems(ContextMenu*) = 0;
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191391] trunk

[n_wang]

Title: [191391] trunk








Revision 191391
Author n_w...@apple.com
Date 2015-10-21 10:46:40 -0700 (Wed, 21 Oct 2015)


Log Message
AX: Expose table size and cell indexes on iOS
https://bugs.webkit.org/show_bug.cgi?id=150366

Source/WebCore:

Add support to expose table row/column count and cell indexes on iOS.

Reviewed by Chris Fleizach.

Test: accessibility/aria-table-attributes.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowCount]):
(-[WebAccessibilityObjectWrapper accessibilityColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):

Tools:

Reviewed by Chris Fleizach.

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::numberAttributeValue):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):

LayoutTests:

Reviewed by Chris Fleizach.

* accessibility/aria-table-attributes-expected.txt: Added.
* accessibility/aria-table-attributes.html: Added.
* accessibility/mac/aria-table-attributes-expected.txt: Removed.
* accessibility/mac/aria-table-attributes.html: Removed.
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm


Added Paths

trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt
trunk/LayoutTests/accessibility/aria-table-attributes.html


Removed Paths

trunk/LayoutTests/accessibility/mac/aria-table-attributes-expected.txt
trunk/LayoutTests/accessibility/mac/aria-table-attributes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191390 => 191391)

--- trunk/LayoutTests/ChangeLog	2015-10-21 17:12:35 UTC (rev 191390)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 17:46:40 UTC (rev 191391)
@@ -1,3 +1,18 @@
+2015-10-21  Nan Wang  
+
+AX: Expose table size and cell indexes on iOS
+https://bugs.webkit.org/show_bug.cgi?id=150366
+
+Reviewed by Chris Fleizach.
+
+* accessibility/aria-table-attributes-expected.txt: Added.
+* accessibility/aria-table-attributes.html: Added.
+* accessibility/mac/aria-table-attributes-expected.txt: Removed.
+* accessibility/mac/aria-table-attributes.html: Removed.
+* platform/gtk/TestExpectations:
+* platform/ios-simulator/TestExpectations:
+* platform/win/TestExpectations:
+
 2015-10-21  Chris Dumez  
 
 HTMLIFrameElement.sandbox should be a DOMSettableTokenList


Copied: trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt (from rev 191390, trunk/LayoutTests/accessibility/mac/aria-table-attributes-expected.txt) (0 => 191391)

--- trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt	2015-10-21 17:46:40 UTC (rev 191391)
@@ -0,0 +1,31 @@
+This tests that attributes related to aria table/grid are working correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS grid.numberAttributeValue('AXARIAColumnCount') is 16
+PASS grid.numberAttributeValue('AXARIARowCount') is 30
+PASS grid.rowCount is 4
+PASS grid.columnCount is 4
+PASS cell1.numberAttributeValue('AXARIAColumnIndex') is 2
+PASS cell1.numberAttributeValue('AXARIARowIndex') is 7
+PASS cell2.numberAttributeValue('AXARIAColumnIndex') is 4
+PASS cell2.numberAttributeValue('AXARIARowIndex') is 8
+PASS cell4.numberAttributeValue('AXARIAColumnIndex') is 3
+PASS cell2.rowIndexRange() is '{1, 2}'
+PASS cell5.columnIndexRange() is '{2, 3}'
+PASS cell3.rowIndexRange() is '{1, 2}'
+PASS cell6.rowIndexRange() is '{0, 2}'
+PASS cell7.rowIndexRange() is '{0, 2}'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+First Name Last Name Company Address
+Fred Jackson Acme, Inc. 123 Broad St.
+Sara James
+Footer 1 Footer 2 Footer 3
+Name 

[webkit-changes] [191429] trunk/Source

[gyuyoung . kim]

Title: [191429] trunk/Source








Revision 191429
Author gyuyoung@webkit.org
Date 2015-10-21 19:27:15 -0700 (Wed, 21 Oct 2015)


Log Message
[EFL][GTK][WK2] Fix build break since r191402, r191401
https://bugs.webkit.org/show_bug.cgi?id=150432

Unreviewed EFL and GTK build fix.

Source/WebCore:

* loader/EmptyClients.h:

Source/WebKit2:

* CMakeLists.txt:
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createContextMenuProxy):
* UIProcess/CoordinatedGraphics/WebView.h:
* UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::show):
* UIProcess/efl/WebContextMenuProxyEfl.h:
(WebKit::WebContextMenuProxyEfl::create): Deleted.
* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::createContextMenuProxy):
* UIProcess/efl/WebViewEfl.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu):
* WebProcess/WebCoreSupport/WebContextMenuClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h
trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.cpp
trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.h
trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp
trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191428 => 191429)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 02:18:42 UTC (rev 191428)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 02:27:15 UTC (rev 191429)
@@ -1,3 +1,12 @@
+2015-10-21  Gyuyoung Kim  
+
+[EFL][GTK][WK2] Fix build break since r191402, r191401
+https://bugs.webkit.org/show_bug.cgi?id=150432
+
+Unreviewed EFL and GTK build fix.
+
+* loader/EmptyClients.h:
+
 2015-10-21  Alex Christensen  
 
 Build fix after r191422.


Modified: trunk/Source/WebCore/loader/EmptyClients.h (191428 => 191429)

--- trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 02:18:42 UTC (rev 191428)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 02:27:15 UTC (rev 191429)
@@ -549,7 +549,9 @@
 virtual ~EmptyContextMenuClient() {  }
 virtual void contextMenuDestroyed() override { }
 
-#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
+#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
+virtual std::unique_ptr customizeMenu(std::unique_ptr) override { return nullptr; }
+#else
 virtual PlatformMenuDescription getCustomMenuFromDefaultItems(ContextMenu*) override { return nullptr; }
 #endif
 virtual void contextMenuItemSelected(ContextMenuItem*, const ContextMenu*) override { }


Modified: trunk/Source/WebKit2/CMakeLists.txt (191428 => 191429)

--- trunk/Source/WebKit2/CMakeLists.txt	2015-10-22 02:18:42 UTC (rev 191428)
+++ trunk/Source/WebKit2/CMakeLists.txt	2015-10-22 02:27:15 UTC (rev 191429)
@@ -359,7 +359,6 @@
 UIProcess/WebDatabaseManagerProxy.cpp
 UIProcess/WebDatabaseManagerProxyClient.cpp
 UIProcess/WebEditCommandProxy.cpp
-UIProcess/WebFindClient.cpp
 UIProcess/WebFormClient.cpp
 UIProcess/WebFormSubmissionListenerProxy.cpp
 UIProcess/WebFrameListenerProxy.cpp


Modified: trunk/Source/WebKit2/ChangeLog (191428 => 191429)

--- trunk/Source/WebKit2/ChangeLog	2015-10-22 02:18:42 UTC (rev 191428)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-22 02:27:15 UTC (rev 191429)
@@ -1,3 +1,25 @@
+2015-10-21  Gyuyoung Kim  
+
+[EFL][GTK][WK2] Fix build break since r191402, r191401
+https://bugs.webkit.org/show_bug.cgi?id=150432
+
+Unreviewed EFL and GTK build fix.
+
+* CMakeLists.txt:
+* UIProcess/CoordinatedGraphics/WebView.cpp:
+(WebKit::WebView::createContextMenuProxy):
+* UIProcess/CoordinatedGraphics/WebView.h:
+* UIProcess/efl/WebContextMenuProxyEfl.cpp:
+(WebKit::WebContextMenuProxyEfl::show):
+* UIProcess/efl/WebContextMenuProxyEfl.h:
+(WebKit::WebContextMenuProxyEfl::create): Deleted.
+* UIProcess/efl/WebViewEfl.cpp:
+(WebKit::WebViewEfl::createContextMenuProxy):
+* UIProcess/efl/WebViewEfl.h:
+* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
+(WebKit::WebContextMenuClient::customizeMenu):
+* WebProcess/WebCoreSupport/WebContextMenuClient.h:
+
 2015-10-21  Anders Carlsson  
 
 Get rid of WebContextMenuClient::customizeMenu, it's no longer used


Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp (191428 => 191429)

--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp	2015-10-22 02:18:42 UTC (rev 191428)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp	

[webkit-changes] [191437] trunk/Tools

[bburg]

Title: [191437] trunk/Tools








Revision 191437
Author bb...@apple.com
Date 2015-10-21 22:26:28 -0700 (Wed, 21 Oct 2015)


Log Message
Unreviewed, update watchlist for JS builtins.

Add a category for JS builtins code generator, similar to other generators.

Add a nag message to rebaseline builtins generator tests when touching
code generator files in Source/_javascript_Core/Scripts/builtins/.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (191436 => 191437)

--- trunk/Tools/ChangeLog	2015-10-22 05:13:32 UTC (rev 191436)
+++ trunk/Tools/ChangeLog	2015-10-22 05:26:28 UTC (rev 191437)
@@ -1,5 +1,16 @@
 2015-10-21  Brian Burg  
 
+Unreviewed, update watchlist for JS builtins.
+
+Add a category for JS builtins code generator, similar to other generators.
+
+Add a nag message to rebaseline builtins generator tests when touching
+code generator files in Source/_javascript_Core/Scripts/builtins/.
+
+* Scripts/webkitpy/common/config/watchlist:
+
+2015-10-21  Brian Burg  
+
 Restructure generate-js-bindings script to be modular and testable
 https://bugs.webkit.org/show_bug.cgi?id=149929
 


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (191436 => 191437)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-10-22 05:13:32 UTC (rev 191436)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-10-22 05:26:28 UTC (rev 191437)
@@ -216,6 +216,10 @@
 "filename": r"Source/WebCore/Modules/websockets"
 r"|Source/WebCore/platform/network/(|.+/)SocketStream.*",
 },
+"JSBuiltinsGenerator": {
+"filename": r"Source/_javascript_Core/Scripts/builtins"
+r"|Source/_javascript_Core/Scripts/generate-js-builtins\.py",
+},
 "MediaStream": {
 "filename": r"Source/WebCore/Modules/mediastream"
 r"|Source/WebCore/platform/mediastream"
@@ -386,6 +390,7 @@
 "WebInspectorGenerator": [ "bb...@apple.com", "joep...@webkit.org" ],
 "WebInspectorUIImages": [ "ago...@igalia.com" ],
 "WebReplayGenerator": [ "bb...@apple.com" ],
+"JSBuiltinsGenerator": [ "bb...@apple.com" ],
 "WebKitGTKTranslations": [ "g...@gnome.org", "mrobin...@webkit.org", "be...@igalia.com", "cgar...@igalia.com", "mcatanz...@igalia.com" ],
 "WebSocket": [ "yu...@chromium.org", "toyoshim+watchl...@chromium.org" ],
 "XSS": [ "dba...@webkit.org" ],
@@ -404,5 +409,6 @@
"See http://trac.webkit.org/wiki/UpdatingANGLE", ],
 "WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
 "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ],
+"JSBuiltinsGenerator": [ "This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)" ],
 },
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191420] trunk/Source/WebCore

[andersca]

Title: [191420] trunk/Source/WebCore








Revision 191420
Author ander...@apple.com
Date 2015-10-21 17:46:20 -0700 (Wed, 21 Oct 2015)


Log Message
Remove dead MHTML code
https://bugs.webkit.org/show_bug.cgi?id=150426

Reviewed by Tim Horton.

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
(WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding): Deleted.
* loader/archive/mhtml/MHTMLArchive.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp
trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191419 => 191420)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 00:31:23 UTC (rev 191419)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 00:46:20 UTC (rev 191420)
@@ -1,3 +1,15 @@
+2015-10-21  Anders Carlsson  
+
+Remove dead MHTML code
+https://bugs.webkit.org/show_bug.cgi?id=150426
+
+Reviewed by Tim Horton.
+
+* loader/archive/mhtml/MHTMLArchive.cpp:
+(WebCore::MHTMLArchive::generateMHTMLData):
+(WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding): Deleted.
+* loader/archive/mhtml/MHTMLArchive.h:
+
 2015-10-21  Dean Jackson  
 
 Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html


Modified: trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp (191419 => 191420)

--- trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp	2015-10-22 00:31:23 UTC (rev 191419)
+++ trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp	2015-10-22 00:46:20 UTC (rev 191420)
@@ -59,7 +59,6 @@
 
 const char* const quotedPrintable = "quoted-printable";
 const char* const base64 = "base64";
-const char* const binary = "binary";
 
 static String generateRandomBoundary()
 {
@@ -133,16 +132,6 @@
 
 PassRefPtr MHTMLArchive::generateMHTMLData(Page* page)
 {
-return generateMHTMLData(page, false);
-}
-
-PassRefPtr MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(Page* page)
-{
-return generateMHTMLData(page, true);
-}
-
-PassRefPtr MHTMLArchive::generateMHTMLData(Page* page, bool useBinaryEncoding)
-{
 Vector resources;
 PageSerializer pageSerializer();
 pageSerializer.serialize(page);
@@ -183,9 +172,7 @@
 stringBuilder.append(resource.mimeType);
 
 const char* contentEncoding = nullptr;
-if (useBinaryEncoding)
-contentEncoding = binary;
-else if (MIMETypeRegistry::isSupportedJavaScriptMIMEType(resource.mimeType) || MIMETypeRegistry::isSupportedNonImageMIMEType(resource.mimeType))
+if (MIMETypeRegistry::isSupportedJavaScriptMIMEType(resource.mimeType) || MIMETypeRegistry::isSupportedNonImageMIMEType(resource.mimeType))
 contentEncoding = quotedPrintable;
 else
 contentEncoding = base64;
@@ -199,36 +186,27 @@
 asciiString = stringBuilder.toString().utf8();
 mhtmlData->append(asciiString.data(), asciiString.length());
 
-if (!strcmp(contentEncoding, binary)) {
-const char* data;
-size_t position = 0;
-while (size_t length = resource.data->getSomeData(data, position)) {
-mhtmlData->append(data, length);
-position += length;
-}
+// FIXME: ideally we would encode the content as a stream without having to fetch it all.
+const char* data = ""
+size_t dataLength = resource.data->size();
+Vector encodedData;
+if (!strcmp(contentEncoding, quotedPrintable)) {
+quotedPrintableEncode(data, dataLength, encodedData);
+mhtmlData->append(encodedData.data(), encodedData.size());
+mhtmlData->append("\r\n", 2);
 } else {
-// FIXME: ideally we would encode the content as a stream without having to fetch it all.
-const char* data = ""
-size_t dataLength = resource.data->size();
-Vector encodedData;
-if (!strcmp(contentEncoding, quotedPrintable)) {
-quotedPrintableEncode(data, dataLength, encodedData);
-mhtmlData->append(encodedData.data(), encodedData.size());
+ASSERT(!strcmp(contentEncoding, base64));
+// We are not specifying insertLFs = true below as it would cut the lines with LFs and MHTML requires CRLFs.
+base64Encode(data, dataLength, encodedData);
+const size_t maximumLineLength = 76;
+size_t index = 0;
+size_t encodedDataLength = encodedData.size();
+do {
+size_t lineLength = std::min(encodedDataLength - index, maximumLineLength);
+mhtmlData->append(encodedData.data() + index, lineLength);
 mhtmlData->append("\r\n", 2);
-} else {
-ASSERT(!strcmp(contentEncoding, base64));
-// We are not 

[webkit-changes] [191422] trunk/Source

[andersca]

Title: [191422] trunk/Source








Revision 191422
Author ander...@apple.com
Date 2015-10-21 17:50:27 -0700 (Wed, 21 Oct 2015)


Log Message
Get rid of WebContextMenuClient::customizeMenu, it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=150427

Reviewed by Tim Horton.
Source/WebCore:

* loader/EmptyClients.cpp:
(WebCore::EmptyContextMenuClient::customizeMenu): Deleted.
* loader/EmptyClients.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):

Source/WebKit/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu): Deleted.
* WebCoreSupport/WebContextMenuClient.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu): Deleted.
* WebProcess/WebCoreSupport/WebContextMenuClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191421 => 191422)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 00:50:25 UTC (rev 191421)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 00:50:27 UTC (rev 191422)
@@ -1,5 +1,17 @@
 2015-10-21  Anders Carlsson  
 
+Get rid of WebContextMenuClient::customizeMenu, it's no longer used
+https://bugs.webkit.org/show_bug.cgi?id=150427
+
+Reviewed by Tim Horton.
+* loader/EmptyClients.cpp:
+(WebCore::EmptyContextMenuClient::customizeMenu): Deleted.
+* loader/EmptyClients.h:
+* page/ContextMenuController.cpp:
+(WebCore::ContextMenuController::showContextMenu):
+
+2015-10-21  Anders Carlsson  
+
 Remove dead MHTML code
 https://bugs.webkit.org/show_bug.cgi?id=150426
 


Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (191421 => 191422)

--- trunk/Source/WebCore/loader/EmptyClients.cpp	2015-10-22 00:50:25 UTC (rev 191421)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp	2015-10-22 00:50:27 UTC (rev 191422)
@@ -232,13 +232,4 @@
 {
 }
 
-#if ENABLE(CONTEXT_MENUS)
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-std::unique_ptr EmptyContextMenuClient::customizeMenu(std::unique_ptr)
-{
-return nullptr;
 }
-#endif
-#endif
-
-}


Modified: trunk/Source/WebCore/loader/EmptyClients.h (191421 => 191422)

--- trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 00:50:25 UTC (rev 191421)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 00:50:27 UTC (rev 191422)
@@ -549,9 +549,7 @@
 virtual ~EmptyContextMenuClient() {  }
 virtual void contextMenuDestroyed() override { }
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-virtual std::unique_ptr customizeMenu(std::unique_ptr) override;
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 virtual PlatformMenuDescription getCustomMenuFromDefaultItems(ContextMenu*) override { return nullptr; }
 #endif
 virtual void contextMenuItemSelected(ContextMenuItem*, const ContextMenu*) override { }


Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (191421 => 191422)

--- trunk/Source/WebCore/page/ContextMenuController.cpp	2015-10-22 00:50:25 UTC (rev 191421)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp	2015-10-22 00:50:27 UTC (rev 191422)
@@ -181,9 +181,7 @@
 if (m_page.inspectorController().enabled())
 addInspectElementItem();
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-m_contextMenu = m_client.customizeMenu(WTF::move(m_contextMenu));
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 PlatformMenuDescription customMenu = m_client.getCustomMenuFromDefaultItems(m_contextMenu.get());
 m_contextMenu->setPlatformDescription(customMenu);
 #endif


Modified: trunk/Source/WebKit/win/ChangeLog (191421 => 191422)

--- trunk/Source/WebKit/win/ChangeLog	2015-10-22 00:50:25 UTC (rev 191421)
+++ trunk/Source/WebKit/win/ChangeLog	2015-10-22 00:50:27 UTC (rev 191422)
@@ -1,5 +1,16 @@
 2015-10-21  Anders Carlsson  
 
+Get rid of WebContextMenuClient::customizeMenu, it's no longer used
+https://bugs.webkit.org/show_bug.cgi?id=150427
+
+Reviewed by Tim Horton.
+
+* WebCoreSupport/WebContextMenuClient.cpp:
+(WebContextMenuClient::customizeMenu): Deleted.
+* WebCoreSupport/WebContextMenuClient.h:
+
+2015-10-21  Anders Carlsson  
+
 Simplify context menu handling on Windows
 https://bugs.webkit.org/show_bug.cgi?id=150423
 


Modified: trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp (191421 => 191422)

--- 

[webkit-changes] [191421] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191421] trunk/Source/WebInspectorUI








Revision 191421
Author commit-qu...@webkit.org
Date 2015-10-21 17:50:25 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: srcset attributes should have hyperlinks to the resources
https://bugs.webkit.org/show_bug.cgi?id=150409

Patch by Joseph Pecoraro  on 2015-10-21
Reviewed by Timothy Hatcher.

The "srcset" attribute parsing is a simplification of:
https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset

The "srcset" attribute value is expected to be in comma
separated groups. Within each group we always expect a link,
and an optional descriptor. We want to linkify the link.

* UserInterface/Views/CodeMirrorAdditions.js:
(tokenizeSrcSetString):
(extendedXMLToken):
When parsing srcset attribute, parse links as link tokens
so that they are linkified in resource content views.

* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
When creating the DOMTree DOM for srcset attributes,
create link elements for the link values of attribute value.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191420 => 191421)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:46:20 UTC (rev 191420)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:50:25 UTC (rev 191421)
@@ -1,3 +1,28 @@
+2015-10-21  Joseph Pecoraro  
+
+Web Inspector: srcset attributes should have hyperlinks to the resources
+https://bugs.webkit.org/show_bug.cgi?id=150409
+
+Reviewed by Timothy Hatcher.
+
+The "srcset" attribute parsing is a simplification of:
+https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
+
+The "srcset" attribute value is expected to be in comma
+separated groups. Within each group we always expect a link,
+and an optional descriptor. We want to linkify the link.
+
+* UserInterface/Views/CodeMirrorAdditions.js:
+(tokenizeSrcSetString):
+(extendedXMLToken):
+When parsing srcset attribute, parse links as link tokens
+so that they are linkified in resource content views.
+
+* UserInterface/Views/DOMTreeElement.js:
+(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
+When creating the DOMTree DOM for srcset attributes,
+create link elements for the link values of attribute value.
+
 2015-10-21  Devin Rousso  
 
 Web Inspector: Autocompletion previews in the CSS sidebar do not apply


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js (191420 => 191421)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js	2015-10-22 00:46:20 UTC (rev 191420)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js	2015-10-22 00:50:25 UTC (rev 191421)
@@ -65,10 +65,50 @@
 delete state._linkTokenize;
 delete state._linkQuoteCharacter;
 delete state._linkBaseStyle;
+delete state._srcSetTokenizeState;
 
 return style;
 }
 
+function tokenizeSrcSetString(stream, state)
+{
+console.assert(state._linkQuoteCharacter !== undefined);
+
+if (state._srcSetTokenizeState === "link") {
+// Eat the string until a space, comma, or ending quote.
+// If this is unquoted, then eat until whitespace or common parse errors.
+if (state._linkQuoteCharacter)
+stream.eatWhile(new RegExp("[^\\s," + state._linkQuoteCharacter + "]"));
+else
+stream.eatWhile(/[^\s,\u00a0=<>\"\']/);
+} else {
+// Eat the string until a comma, or ending quote.
+// If this is unquoted, then eat until whitespace or common parse errors.
+stream.eatSpace();
+if (state._linkQuoteCharacter)
+stream.eatWhile(new RegExp("[^," + state._linkQuoteCharacter + "]"));
+else
+stream.eatWhile(/[^\s\u00a0=<>\"\',]/);
+stream.eatWhile(/[\s,]/);
+}
+
+// If the stream isn't at the end of line and we found the end quote
+// change _linkTokenize to parse the end of the link next. Otherwise
+// _linkTokenize will stay as-is to parse more of the srcset.
+if (!stream.eol() && (!state._linkQuoteCharacter || stream.peek() === state._linkQuoteCharacter))
+state._linkTokenize = tokenizeEndOfLinkString;
+
+// Link portion.
+if (state._srcSetTokenizeState === "link") {
+state._srcSetTokenizeState = "descriptor";
+return "link";
+}
+
+// Descriptor portion.
+state._srcSetTokenizeState = "link";
+return 

[webkit-changes] [191423] trunk

[cdumez]

Title: [191423] trunk








Revision 191423
Author cdu...@apple.com
Date 2015-10-21 17:58:24 -0700 (Wed, 21 Oct 2015)


Log Message
Un-expose obsolete HTMLBaseFontElement
https://bugs.webkit.org/show_bug.cgi?id=150397

Reviewed by Anders Carlsson.

LayoutTests/imported/w3c:

Rebaseline a couple of W3C HTML tests now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

Un-expose obsolete HTMLBaseFontElement:
- https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features

This means that we no longer expose HTMLBaseFontElement on the global
Window object. Firefox and Chrome do not expose it either.

Also, document.createElement("basefont") now returns an HTMLUnknownElement
as per the specification. Firefox and Chrome return a generic HTMLElement
instead but I don't think this is a big compatibility risk.

No new tests, already covered by existing tests.

* html/HTMLBaseFontElement.cpp:
(WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
* html/HTMLBaseFontElement.h:
* html/HTMLBaseFontElement.idl:
* html/HTMLTagNames.in:

LayoutTests:

Update existing layout tests to stop expecting HTMLBaseFontElement to
be exposed.

* dom/html/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
* dom/html/level2/html/HTMLBaseFontElement01.html: Removed.
* dom/html/level2/html/HTMLBaseFontElement01.js: Removed.
* dom/html/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
* dom/html/level2/html/HTMLBaseFontElement02.html: Removed.
* dom/html/level2/html/HTMLBaseFontElement02.js: Removed.
* dom/html/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
* dom/html/level2/html/HTMLBaseFontElement03.html: Removed.
* dom/html/level2/html/HTMLBaseFontElement03.js: Removed.
* dom/html/level2/html/basefont01-expected.txt: Removed.
* dom/html/level2/html/basefont01.html: Removed.
* dom/html/level2/html/basefont01.js: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement01.js: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement01.xhtml: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement02.js: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement02.xhtml: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement03.js: Removed.
* dom/xhtml/level2/html/HTMLBaseFontElement03.xhtml: Removed.
* dom/xhtml/level2/html/basefont01-expected.txt: Removed.
* dom/xhtml/level2/html/basefont01.js: Removed.
* dom/xhtml/level2/html/basefont01.xhtml: Removed.
Drop Legacy W3C DOM level 2 basefont tests.

* fast/dom/Window/element-constructors-on-window-expected.txt:
* fast/dom/Window/element-constructors-on-window.html:
* fast/dom/Window/get-set-properties-expected.txt:
* fast/dom/Window/get-set-properties.html:
* fast/dom/Window/resources/window-properties.js:
* fast/dom/Window/window-lookup-precedence-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/element-attribute-js-null.html:
* fast/dom/html-attribute-types-expected.txt:
* fast/dom/html-attribute-types.html:
* fast/dom/wrapper-classes-expected.txt:
* fast/dom/wrapper-classes.html:
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/element-constructors-on-window-expected.txt
trunk/LayoutTests/fast/dom/Window/element-constructors-on-window.html
trunk/LayoutTests/fast/dom/Window/get-set-properties-expected.txt
trunk/LayoutTests/fast/dom/Window/get-set-properties.html
trunk/LayoutTests/fast/dom/Window/resources/window-properties.js
trunk/LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors.html
trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt
trunk/LayoutTests/fast/dom/element-attribute-js-null.html
trunk/LayoutTests/fast/dom/html-attribute-types-expected.txt
trunk/LayoutTests/fast/dom/html-attribute-types.html
trunk/LayoutTests/fast/dom/wrapper-classes-expected.txt
trunk/LayoutTests/fast/dom/wrapper-classes.html

[webkit-changes] [191413] trunk/Source/WebKit/win

[andersca]

Title: [191413] trunk/Source/WebKit/win








Revision 191413
Author ander...@apple.com
Date 2015-10-21 16:54:32 -0700 (Wed, 21 Oct 2015)


Log Message
Simplify context menu handling on Windows
https://bugs.webkit.org/show_bug.cgi?id=150423

Reviewed by Tim Horton.

Instead of converting a ContextMenu to a HMENU, then back to a ContextMenu, and then back to a HMENU again
just convert it once right before showing it and let the UIDelegate return a new menu at at time where we don't
have to convert it back.

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu):
* WebView.cpp:
(WebView::createContextMenu):
(WebView::handleContextMenuEvent):
* WebView.h:

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit/win/WebView.h




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (191412 => 191413)

--- trunk/Source/WebKit/win/ChangeLog	2015-10-21 23:14:31 UTC (rev 191412)
+++ trunk/Source/WebKit/win/ChangeLog	2015-10-21 23:54:32 UTC (rev 191413)
@@ -1,3 +1,21 @@
+2015-10-21  Anders Carlsson  
+
+Simplify context menu handling on Windows
+https://bugs.webkit.org/show_bug.cgi?id=150423
+
+Reviewed by Tim Horton.
+
+Instead of converting a ContextMenu to a HMENU, then back to a ContextMenu, and then back to a HMENU again
+just convert it once right before showing it and let the UIDelegate return a new menu at at time where we don't
+have to convert it back.
+
+* WebCoreSupport/WebContextMenuClient.cpp:
+(WebContextMenuClient::customizeMenu):
+* WebView.cpp:
+(WebView::createContextMenu):
+(WebView::handleContextMenuEvent):
+* WebView.h:
+
 2015-10-21  Carlos Garcia Campos  
 
 NetworkProcess: DNS prefetch happens in the Web Process


Modified: trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp (191412 => 191413)

--- trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp	2015-10-21 23:14:31 UTC (rev 191412)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp	2015-10-21 23:54:32 UTC (rev 191413)
@@ -52,29 +52,9 @@
 delete this;
 }
 
-std::unique_ptr WebContextMenuClient::customizeMenu(std::unique_ptr popMenu)
+std::unique_ptr WebContextMenuClient::customizeMenu(std::unique_ptr menu)
 {
-std::unique_ptr menu = WTF::move(popMenu);
-
-COMPtr uiDelegate;
-if (FAILED(m_webView->uiDelegate()))
-return menu;
-
-ASSERT(uiDelegate);
-
-HMENU nativeMenu = menu->platformContextMenu();
-COMPtr propertyBag;
-propertyBag.adoptRef(WebElementPropertyBag::createInstance(m_webView->page()->contextMenuController().hitTestResult()));
-// FIXME: We need to decide whether to do the default before calling this delegate method
-if (FAILED(uiDelegate->contextMenuItemsForElement(m_webView, propertyBag.get(), nativeMenu, ))) {
-::DestroyMenu(nativeMenu);
-return menu;
-}
-
-std::unique_ptr customizedMenu = std::unique_ptr(new ContextMenu(nativeMenu));
-::DestroyMenu(nativeMenu);
-
-return customizedMenu;
+return WTF::move(menu);
 }
 
 void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu)


Modified: trunk/Source/WebKit/win/WebView.cpp (191412 => 191413)

--- trunk/Source/WebKit/win/WebView.cpp	2015-10-21 23:14:31 UTC (rev 191412)
+++ trunk/Source/WebKit/win/WebView.cpp	2015-10-21 23:54:32 UTC (rev 191413)
@@ -1393,6 +1393,36 @@
 return m_page;
 }
 
+HMENU WebView::createContextMenu()
+{
+auto& contextMenuController = m_page->contextMenuController();
+
+ContextMenu* coreMenu = contextMenuController.contextMenu();
+if (!coreMenu)
+return nullptr;
+
+HMENU contextMenu = coreMenu->platformContextMenu();
+
+COMPtr uiDelegate;
+if (SUCCEEDED(this->uiDelegate())) {
+ASSERT(uiDelegate);
+
+COMPtr propertyBag;
+propertyBag.adoptRef(WebElementPropertyBag::createInstance(contextMenuController.hitTestResult()));
+
+HMENU newMenu = nullptr;
+if (SUCCEEDED(uiDelegate->contextMenuItemsForElement(this, propertyBag.get(), contextMenu, ))) {
+// Make sure to delete the old menu if the delegate returned a new menu.
+if (newMenu != contextMenu) {
+::DestroyMenu(contextMenu);
+contextMenu = newMenu;
+}
+}
+}
+
+return contextMenu;
+}
+
 bool WebView::handleContextMenuEvent(WPARAM wParam, LPARAM lParam)
 {
 // Translate the screen coordinates into window coordinates
@@ -1456,19 +1486,23 @@
 if (!::ClientToScreen(m_viewWindow, ))
 return false;
 
+HMENU contextMenu = createContextMenu();
+
 BOOL hasCustomMenus = false;
 if (m_uiDelegate)
 m_uiDelegate->hasCustomMenuImplementation();
 
 if (hasCustomMenus)
-  

[webkit-changes] [191414] trunk/Source/WebKit2

[enrica]

Title: [191414] trunk/Source/WebKit2








Revision 191414
Author enr...@apple.com
Date 2015-10-21 17:02:01 -0700 (Wed, 21 Oct 2015)


Log Message
WebProcess crashes when accessibility bundle is not found.
https://bugs.webkit.org/show_bug.cgi?id=150414

Reviewed by Dan Bernstein.

The uninitialized pointer to NSError causes the print function to crash.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerWithAccessibility):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191413 => 191414)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 23:54:32 UTC (rev 191413)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-22 00:02:01 UTC (rev 191414)
@@ -1,3 +1,15 @@
+2015-10-21  Enrica Casucci  
+
+WebProcess crashes when accessibility bundle is not found.
+https://bugs.webkit.org/show_bug.cgi?id=150414
+
+Reviewed by Dan Bernstein.
+
+The uninitialized pointer to NSError causes the print function to crash.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::registerWithAccessibility):
+
 2015-10-21  Anders Carlsson  
 
 Move services menu handling out into a separate function


Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm (191413 => 191414)

--- trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2015-10-21 23:54:32 UTC (rev 191413)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2015-10-22 00:02:01 UTC (rev 191414)
@@ -203,7 +203,7 @@
 #endif
 #if PLATFORM(IOS)
 NSString *accessibilityBundlePath = [(NSString *)GSSystemRootDirectory() stringByAppendingString:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"];
-NSError *error;
+NSError *error = nil;
 if (![[NSBundle bundleWithPath:accessibilityBundlePath] loadAndReturnError:])
 LOG_ERROR("Failed to load accessibility bundle at %@: %@", accessibilityBundlePath, error);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191415] trunk/Source/WebKit2

[timothy_horton]

Title: [191415] trunk/Source/WebKit2








Revision 191415
Author timothy_hor...@apple.com
Date 2015-10-21 17:07:27 -0700 (Wed, 21 Oct 2015)


Log Message
API-ify the FindMatches client
https://bugs.webkit.org/show_bug.cgi?id=150422

Reviewed by Anders Carlsson.

* UIProcess/API/APIFindMatchesClient.h: Renamed from Source/WebKit2/UIProcess/WebFindClient.h.
(API::FindMatchesClient::~FindMatchesClient):
(API::FindMatchesClient::didFindStringMatches):
(API::FindMatchesClient::didGetImageForMatchResult):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFindMatchesClient):
* UIProcess/WebFindClient.cpp: Removed.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setFindMatchesClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didGetImageForFindMatch):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::initializeFindMatchesClient): Deleted.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::findMatchesClient):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/API/APIFindMatchesClient.h


Removed Paths

trunk/Source/WebKit2/UIProcess/WebFindClient.cpp
trunk/Source/WebKit2/UIProcess/WebFindClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191414 => 191415)

--- trunk/Source/WebKit2/ChangeLog	2015-10-22 00:02:01 UTC (rev 191414)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-22 00:07:27 UTC (rev 191415)
@@ -1,3 +1,28 @@
+2015-10-21  Tim Horton  
+
+API-ify the FindMatches client
+https://bugs.webkit.org/show_bug.cgi?id=150422
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/APIFindMatchesClient.h: Renamed from Source/WebKit2/UIProcess/WebFindClient.h.
+(API::FindMatchesClient::~FindMatchesClient):
+(API::FindMatchesClient::didFindStringMatches):
+(API::FindMatchesClient::didGetImageForMatchResult):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageFindMatchesClient):
+* UIProcess/WebFindClient.cpp: Removed.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+(WebKit::WebPageProxy::setFindMatchesClient):
+(WebKit::WebPageProxy::close):
+(WebKit::WebPageProxy::didGetImageForFindMatch):
+(WebKit::WebPageProxy::didFindStringMatches):
+(WebKit::WebPageProxy::initializeFindMatchesClient): Deleted.
+* UIProcess/WebPageProxy.h:
+(WebKit::WebPageProxy::findMatchesClient):
+* WebKit2.xcodeproj/project.pbxproj:
+
 2015-10-21  Enrica Casucci  
 
 WebProcess crashes when accessibility bundle is not found.


Added: trunk/Source/WebKit2/UIProcess/API/APIFindMatchesClient.h (0 => 191415)

--- trunk/Source/WebKit2/UIProcess/API/APIFindMatchesClient.h	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/APIFindMatchesClient.h	2015-10-22 00:07:27 UTC (rev 191415)
@@ -0,0 +1,50 @@
+/*
+ * Copyright (C) 2015 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef APIFindMatchesClient_h
+#define APIFindMatchesClient_h
+
+#include 
+#include 
+#include 
+
+namespace WebKit {
+class WebImage;
+class WebPageProxy;
+}
+
+namespace API {
+
+class FindMatchesClient {
+public:
+virtual ~FindMatchesClient() { }
+
+virtual void didFindStringMatches(WebKit::WebPageProxy*, const WTF::String&, const WTF::Vector&, int32_t) { }
+virtual void 

[webkit-changes] [191417] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191417] trunk/Source/WebInspectorUI








Revision 191417
Author commit-qu...@webkit.org
Date 2015-10-21 17:26:29 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=150424

Patch by Devin Rousso  on 2015-10-21
Reviewed by Timothy Hatcher.

Adds "!!" in front of force parameters in classList.toggle calls that
could possibly be undefined (thereby breaking the UI).

* UserInterface/Views/ScopeBarItem.js:
(WebInspector.ScopeBarItem):
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
* UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191416 => 191417)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:13:29 UTC (rev 191416)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:26:29 UTC (rev 191417)
@@ -1,5 +1,22 @@
 2015-10-21  Devin Rousso  
 
+Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
+https://bugs.webkit.org/show_bug.cgi?id=150424
+
+Reviewed by Timothy Hatcher.
+
+Adds "!!" in front of force parameters in classList.toggle calls that
+could possibly be undefined (thereby breaking the UI).
+
+* UserInterface/Views/ScopeBarItem.js:
+(WebInspector.ScopeBarItem):
+* UserInterface/Views/VisualStyleDetailsPanel.js:
+(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
+* UserInterface/Views/VisualStylePropertyEditor.js:
+(WebInspector.VisualStylePropertyEditor):
+
+2015-10-21  Devin Rousso  
+
 Web Inspector: Option-Up doesn't increment certain attribute values
 https://bugs.webkit.org/show_bug.cgi?id=149257
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js (191416 => 191417)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js	2015-10-22 00:13:29 UTC (rev 191416)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js	2015-10-22 00:26:29 UTC (rev 191417)
@@ -30,7 +30,7 @@
 super();
 
 this._element = document.createElement("li");
-this._element.classList.toggle("exclusive", exclusive);
+this._element.classList.toggle("exclusive", !!exclusive);
 this._element.classList.add(className);
 this._element.textContent = label;
 this._element.addEventListener("click", this._clicked.bind(this));


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (191416 => 191417)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2015-10-22 00:13:29 UTC (rev 191416)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2015-10-22 00:26:29 UTC (rev 191417)
@@ -155,7 +155,7 @@
 return;
 
 let disabled = this._currentStyle[WebInspector.VisualStyleDetailsPanel.StyleDisabledSymbol];
-this._element.classList.toggle("disabled", disabled);
+this._element.classList.toggle("disabled", !!disabled);
 if (disabled)
 return;
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js (191416 => 191417)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js	2015-10-22 00:13:29 UTC (rev 191416)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js	2015-10-22 00:26:29 UTC (rev 191417)
@@ -65,7 +65,7 @@
 
 this._element = document.createElement("div");
 this._element.classList.add("visual-style-property-container", className);
-this._element.classList.toggle("layout-reversed", layoutReversed);
+this._element.classList.toggle("layout-reversed", !!layoutReversed);
 
 if (label && label.length) {
 let titleContainer = document.createElement("div");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191419] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191419] trunk/Source/WebInspectorUI








Revision 191419
Author commit-qu...@webkit.org
Date 2015-10-21 17:31:23 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Autocompletion previews in the CSS sidebar do not apply
https://bugs.webkit.org/show_bug.cgi?id=147720

Patch by Devin Rousso  on 2015-10-21
Reviewed by Timothy Hatcher.

When autocompletion hints are added to styles or the console, the history
object used by CodeMirror was edited to remove the last entry. Instead of
using this method (which caused glitchy behaviour when undo-ing), call
CodeMirror.undo() and adjust accordingly. In addition, a marker was being
used as the completion hint instead of applying text, whereas these
changes use actual text, ensuring that completions are previewed in the page.

* UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController):
(WebInspector.CodeMirrorCompletionController.prototype.close):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191418 => 191419)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:29:51 UTC (rev 191418)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:31:23 UTC (rev 191419)
@@ -1,5 +1,30 @@
 2015-10-21  Devin Rousso  
 
+Web Inspector: Autocompletion previews in the CSS sidebar do not apply
+https://bugs.webkit.org/show_bug.cgi?id=147720
+
+Reviewed by Timothy Hatcher.
+
+When autocompletion hints are added to styles or the console, the history
+object used by CodeMirror was edited to remove the last entry. Instead of
+using this method (which caused glitchy behaviour when undo-ing), call
+CodeMirror.undo() and adjust accordingly. In addition, a marker was being
+used as the completion hint instead of applying text, whereas these
+changes use actual text, ensuring that completions are previewed in the page.
+
+* UserInterface/Controllers/CodeMirrorCompletionController.js:
+(WebInspector.CodeMirrorCompletionController):
+(WebInspector.CodeMirrorCompletionController.prototype.close):
+(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
+(WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
+(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
+(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
+(WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
+(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
+(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.
+
+2015-10-21  Devin Rousso  
+
 Web Inspector: Add forgotten WebInspector.UIString from r190521
 https://bugs.webkit.org/show_bug.cgi?id=150425
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js (191418 => 191419)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2015-10-22 00:29:51 UTC (rev 191418)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2015-10-22 00:31:23 UTC (rev 191419)
@@ -59,12 +59,14 @@
 "Cmd-Y": this._handleHideKey.bind(this)
 };
 
+this._handleBeforeChangeListener = this._handleBeforeChange.bind(this);
 this._handleChangeListener = this._handleChange.bind(this);
 this._handleCursorActivityListener = this._handleCursorActivity.bind(this);
 this._handleHideActionListener = this._handleHideAction.bind(this);
 
 this._codeMirror.addKeyMap(this._keyMap);
 
+this._codeMirror.on("beforeChange", this._handleBeforeChangeListener);
 this._codeMirror.on("change", this._handleChangeListener);
 this._codeMirror.on("cursorActivity", this._handleCursorActivityListener);
 this._codeMirror.on("blur", this._handleHideActionListener);
@@ -171,6 +173,7 @@
 {
 this._codeMirror.removeKeyMap(this._keyMap);
 

[webkit-changes] [191416] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191416] trunk/Source/WebInspectorUI








Revision 191416
Author commit-qu...@webkit.org
Date 2015-10-21 17:13:29 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Option-Up doesn't increment certain attribute values
https://bugs.webkit.org/show_bug.cgi?id=149257

Patch by Devin Rousso  on 2015-10-21
Reviewed by Brian Burg.

If the user tries to modify a numerical attribute in HTML and the cursor
was at the beginning of the attribute value, the range of the selection
was within a sibling element instead of the text node containin the value.
This patch fixes this issue and ensures that the correct text is selected.

* UserInterface/Views/EditingSupport.js:
(WebInspector.startEditing.handleEditingResult):
Replaced var with let.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191415 => 191416)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:07:27 UTC (rev 191415)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:13:29 UTC (rev 191416)
@@ -1,3 +1,19 @@
+2015-10-21  Devin Rousso  
+
+Web Inspector: Option-Up doesn't increment certain attribute values
+https://bugs.webkit.org/show_bug.cgi?id=149257
+
+Reviewed by Brian Burg.
+
+If the user tries to modify a numerical attribute in HTML and the cursor
+was at the beginning of the attribute value, the range of the selection
+was within a sibling element instead of the text node containin the value.
+This patch fixes this issue and ensures that the correct text is selected.
+
+* UserInterface/Views/EditingSupport.js:
+(WebInspector.startEditing.handleEditingResult):
+Replaced var with let.
+
 2015-10-21  Joseph Pecoraro  
 
 Web Inspector: Use some CSS Variables in Web Inspector


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js (191415 => 191416)

--- trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js	2015-10-22 00:07:27 UTC (rev 191415)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js	2015-10-22 00:13:29 UTC (rev 191416)
@@ -218,8 +218,8 @@
 if (event.keyIdentifier !== "U+0009")
 blurEventListener();
 } else if (result && result.startsWith("modify-")) {
-var direction = result.substring(7);
-var modifyValue = direction.startsWith("up") ? 1 : -1;
+let direction = result.substring(7);
+let modifyValue = direction.startsWith("up") ? 1 : -1;
 if (direction.endsWith("big"))
 modifyValue *= 10;
 
@@ -228,21 +228,21 @@
 else if (event.ctrlKey)
 modifyValue /= 10;
 
-var selection = element.ownerDocument.defaultView.getSelection();
+let selection = element.ownerDocument.defaultView.getSelection();
 if (!selection.rangeCount)
 return;
 
-var range = selection.getRangeAt(0);
+let range = selection.getRangeAt(0);
 if (!range.commonAncestorContainer.isSelfOrDescendant(element))
 return false;
 
-var wordRange = range.startContainer.rangeOfWord(range.startOffset, WebInspector.EditingSupport.StyleValueDelimiters, element);
-var word = wordRange.toString();
-var wordPrefix = "";
-var wordSuffix = "";
-var nonNumberInWord = /[^\d-\.]+/.exec(word);
+let wordRange = range.startContainer.rangeOfWord(range.startOffset, WebInspector.EditingSupport.StyleValueDelimiters, element);
+let word = wordRange.toString();
+let wordPrefix = "";
+let wordSuffix = "";
+let nonNumberInWord = /[^\d-\.]+/.exec(word);
 if (nonNumberInWord) {
-var nonNumberEndOffset = nonNumberInWord.index + nonNumberInWord[0].length;
+let nonNumberEndOffset = nonNumberInWord.index + nonNumberInWord[0].length;
 if (range.startOffset > wordRange.startOffset + nonNumberInWord.index && nonNumberEndOffset < word.length && range.startOffset !== wordRange.startOffset) {
 wordPrefix = word.substring(0, nonNumberEndOffset);
 word = word.substring(nonNumberEndOffset);
@@ -252,20 +252,37 @@
 }
 }
 
-var matches = WebInspector.EditingSupport.CSSNumberRegex.exec(word);
+let matches = WebInspector.EditingSupport.CSSNumberRegex.exec(word);
 if (!matches || matches.length !== 4)
 return;
 
-var replacement = matches[1] + (Math.round((parseFloat(matches[2]) + modifyValue) * 100) / 100) + matches[3];
+let replacement = matches[1] + (Math.round((parseFloat(matches[2]) + modifyValue) * 100) / 100) + 

[webkit-changes] [191418] trunk/Source/WebInspectorUI

[commit-queue]

Title: [191418] trunk/Source/WebInspectorUI








Revision 191418
Author commit-qu...@webkit.org
Date 2015-10-21 17:29:51 -0700 (Wed, 21 Oct 2015)


Log Message
Web Inspector: Add forgotten WebInspector.UIString from r190521
https://bugs.webkit.org/show_bug.cgi?id=150425

Patch by Devin Rousso  on 2015-10-21
Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191417 => 191418)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:26:29 UTC (rev 191417)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-22 00:29:51 UTC (rev 191418)
@@ -1,5 +1,16 @@
 2015-10-21  Devin Rousso  
 
+Web Inspector: Add forgotten WebInspector.UIString from r190521
+https://bugs.webkit.org/show_bug.cgi?id=150425
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+(UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)
+
+2015-10-21  Devin Rousso  
+
 Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
 https://bugs.webkit.org/show_bug.cgi?id=150424
 


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (191417 => 191418)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-10-22 00:26:29 UTC (rev 191417)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-10-22 00:29:51 UTC (rev 191418)
@@ -417,6 +417,7 @@
 localizedStrings["Opacity"] = "Opacity";
 localizedStrings["Option-click to show all units"] = "Option-click to show all units";
 localizedStrings["Option-click to show all values"] = "Option-click to show all values";
+localizedStrings["Option-click to show source"] = "Option-click to show source";
 localizedStrings["Options"] = "Options";
 localizedStrings["Order"] = "Order";
 localizedStrings["Original"] = "Original";


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (191417 => 191418)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js	2015-10-22 00:26:29 UTC (rev 191417)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js	2015-10-22 00:29:51 UTC (rev 191418)
@@ -967,7 +967,7 @@
 && !property.implicit && typeof this._delegate.cssStyleDeclarationTextEditorShowProperty === "function") {
 
 let arrowElement = WebInspector.createGoToArrowButton();
-arrowElement.title = "Option-click to show source";
+arrowElement.title = WebInspector.UIString("Option-click to show source");
 
 let delegate = this._delegate;
 arrowElement.addEventListener("click", function(event) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191430] trunk/LayoutTests

[commit-queue]

Title: [191430] trunk/LayoutTests








Revision 191430
Author commit-qu...@webkit.org
Date 2015-10-21 19:49:05 -0700 (Wed, 21 Oct 2015)


Log Message
Marking imported/blink/fast/overflow/hidden-html-auto-body.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=150419

Patch by Ryan Haddad  on 2015-10-21
Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191429 => 191430)

--- trunk/LayoutTests/ChangeLog	2015-10-22 02:27:15 UTC (rev 191429)
+++ trunk/LayoutTests/ChangeLog	2015-10-22 02:49:05 UTC (rev 191430)
@@ -1,3 +1,12 @@
+2015-10-21  Ryan Haddad  
+
+Marking imported/blink/fast/overflow/hidden-html-auto-body.html as flaky
+https://bugs.webkit.org/show_bug.cgi?id=150419
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac-wk2/TestExpectations:
+
 2015-10-21  Chris Dumez  
 
 Un-expose obsolete HTMLBaseFontElement


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (191429 => 191430)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-22 02:27:15 UTC (rev 191429)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-22 02:49:05 UTC (rev 191430)
@@ -557,3 +557,4 @@
 imported/blink/fast/transforms/transform-update-frame-overflow.html [ Pass ImageOnlyFailure ]
 imported/blink/fast/multicol/vertical-rl/float-big-line.html [ Pass ImageOnlyFailure ]
 imported/blink/fast/multicol/span/adjacent-spanners-with-margin.html [ Pass ImageOnlyFailure ]
+imported/blink/fast/overflow/hidden-html-auto-body.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191431] trunk/LayoutTests

[commit-queue]

Title: [191431] trunk/LayoutTests








Revision 191431
Author commit-qu...@webkit.org
Date 2015-10-21 19:55:16 -0700 (Wed, 21 Oct 2015)


Log Message
Adding http/tests/media/video-load-suspend.html to the list of flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=150408

Patch by Ryan Haddad  on 2015-10-21
Reviewed by Alexey Proskuryakov.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191430 => 191431)

--- trunk/LayoutTests/ChangeLog	2015-10-22 02:49:05 UTC (rev 191430)
+++ trunk/LayoutTests/ChangeLog	2015-10-22 02:55:16 UTC (rev 191431)
@@ -1,5 +1,14 @@
 2015-10-21  Ryan Haddad  
 
+Adding http/tests/media/video-load-suspend.html to the list of flaky media tests
+https://bugs.webkit.org/show_bug.cgi?id=150408
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac/TestExpectations:
+
+2015-10-21  Ryan Haddad  
+
 Marking imported/blink/fast/overflow/hidden-html-auto-body.html as flaky
 https://bugs.webkit.org/show_bug.cgi?id=150419
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (191430 => 191431)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-10-22 02:49:05 UTC (rev 191430)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-10-22 02:55:16 UTC (rev 191431)
@@ -972,7 +972,7 @@
 webkit.org/b/142152 media/track/track-in-band-cues-added-once.html [ Pass Failure ]
 webkit.org/b/147944 media/video-seek-to-current-time.html [ Pass Failure ]
 webkit.org/b/114177 media/event-queue-crash.html [ Pass Failure ]
-
+webkit.org/b/150408 http/tests/media/video-load-suspend.html [ Pass Timeout ]
 ## --- End flaky media tests
 
 # Skipped while Eric Carlson works on a fix.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191432] trunk/Source/WebCore

[achristensen]

Title: [191432] trunk/Source/WebCore








Revision 191432
Author achristen...@apple.com
Date 2015-10-21 20:17:06 -0700 (Wed, 21 Oct 2015)


Log Message
Recommit r191428.

I don't think it was supposed to be reverted in r191429, and it really does fix the build.

* loader/EmptyClients.h:
(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
Remove customizeMenu again.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191431 => 191432)

--- trunk/Source/WebCore/ChangeLog	2015-10-22 02:55:16 UTC (rev 191431)
+++ trunk/Source/WebCore/ChangeLog	2015-10-22 03:17:06 UTC (rev 191432)
@@ -1,3 +1,13 @@
+2015-10-21  Alex Christensen  
+
+Recommit r191428.
+
+I don't think it was supposed to be reverted in r191429, and it really does fix the build.
+
+* loader/EmptyClients.h:
+(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
+Remove customizeMenu again.
+
 2015-10-21  Gyuyoung Kim  
 
 [EFL][GTK][WK2] Fix build break since r191402, r191401


Modified: trunk/Source/WebCore/loader/EmptyClients.h (191431 => 191432)

--- trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 02:55:16 UTC (rev 191431)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2015-10-22 03:17:06 UTC (rev 191432)
@@ -549,9 +549,7 @@
 virtual ~EmptyContextMenuClient() {  }
 virtual void contextMenuDestroyed() override { }
 
-#if USE(CROSS_PLATFORM_CONTEXT_MENUS)
-virtual std::unique_ptr customizeMenu(std::unique_ptr) override { return nullptr; }
-#else
+#if !USE(CROSS_PLATFORM_CONTEXT_MENUS)
 virtual PlatformMenuDescription getCustomMenuFromDefaultItems(ContextMenu*) override { return nullptr; }
 #endif
 virtual void contextMenuItemSelected(ContextMenuItem*, const ContextMenu*) override { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191377] trunk/Source/WebKit2

[cdumez]

Title: [191377] trunk/Source/WebKit2








Revision 191377
Author cdu...@apple.com
Date 2015-10-20 23:41:13 -0700 (Tue, 20 Oct 2015)


Log Message
[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
https://bugs.webkit.org/show_bug.cgi?id=150221


Reviewed by Darin Adler and Antti Koivisto.

Generalize NetworkCacheStorage API so it can store different types of
metadata alongside the network resources. This is a pre-requirement to
making our NetworkCache smarter by storing information about the
resources.

To keep the code simple, the entry type is now part of the entry key and
we store records of a specific type in a 'type' subfolder. The cache
structure looks like so:
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)

Existing cache entries now that the 'resource' type as these are network
resources.

* NetworkProcess/cache/NetworkCache.cpp:
* NetworkProcess/cache/NetworkCacheKey.cpp:
* NetworkProcess/cache/NetworkCacheKey.h:
* NetworkProcess/cache/NetworkCacheStatistics.cpp:
* NetworkProcess/cache/NetworkCacheStorage.cpp:
* NetworkProcess/cache/NetworkCacheStorage.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.h
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStatistics.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191376 => 191377)

--- trunk/Source/WebKit2/ChangeLog	2015-10-21 06:20:58 UTC (rev 191376)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 06:41:13 UTC (rev 191377)
@@ -1,3 +1,32 @@
+2015-10-20  Chris Dumez  
+
+[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
+https://bugs.webkit.org/show_bug.cgi?id=150221
+
+
+Reviewed by Darin Adler and Antti Koivisto.
+
+Generalize NetworkCacheStorage API so it can store different types of
+metadata alongside the network resources. This is a pre-requirement to
+making our NetworkCache smarter by storing information about the
+resources.
+
+To keep the code simple, the entry type is now part of the entry key and
+we store records of a specific type in a 'type' subfolder. The cache
+structure looks like so:
+- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
+- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)
+
+Existing cache entries now that the 'resource' type as these are network
+resources.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+* NetworkProcess/cache/NetworkCacheKey.cpp:
+* NetworkProcess/cache/NetworkCacheKey.h:
+* NetworkProcess/cache/NetworkCacheStatistics.cpp:
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+* NetworkProcess/cache/NetworkCacheStorage.h:
+
 2015-10-20  Hunseop Jeong  
 
 [EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194.


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (191376 => 191377)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-21 06:20:58 UTC (rev 191376)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-21 06:41:13 UTC (rev 191377)
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -50,6 +51,13 @@
 namespace WebKit {
 namespace NetworkCache {
 
+static const AtomicString& resourceType()
+{
+ASSERT(WTF::isMainThread());
+static NeverDestroyed resource("resource", AtomicString::ConstructFromLiteral);
+return resource;
+}
+
 Cache& singleton()
 {
 static NeverDestroyed instance;
@@ -113,7 +121,7 @@
 // FIXME: This implements minimal Range header disk cache support. We don't parse
 // ranges so only the same exact range request will be served from the cache.
 String range = request.httpHeaderField(WebCore::HTTPHeaderName::Range);
-return { partition, range, request.url().string() };
+return { partition, resourceType(), range, request.url().string() };
 }
 
 static String headerValueForVary(const WebCore::ResourceRequest& request, const String& headerName)
@@ -472,7 +480,7 @@
 {
 ASSERT(isEnabled());
 
-m_storage->traverse(0, [traverseHandler](const Storage::Record* record, const Storage::RecordInfo&) {
+m_storage->traverse(resourceType(), 0, [traverseHandler](const Storage::Record* record, const Storage::RecordInfo&) {
 if (!record) {
 traverseHandler(nullptr);
 return;
@@ -509,7 +517,7 @@
 Totals totals;
 auto flags = Storage::TraverseFlag::ComputeWorth | Storage::TraverseFlag::ShareCount;
 size_t capacity = 

[webkit-changes] [191378] trunk

[fred . wang]

Title: [191378] trunk








Revision 191378
Author fred.w...@free.fr
Date 2015-10-21 00:05:21 -0700 (Wed, 21 Oct 2015)


Log Message
[FreeType] Add support for the USE_TYPO_METRICS flag
https://bugs.webkit.org/show_bug.cgi?id=150340

Reviewed by Martin Robinson.

Source/WebCore:

Test: fonts/use-typo-metrics-1.html

Make the FreeType backend use the typo metrics when the OS/2 USE_TYPO_METRICS flag is set.
Similar work should be done for other backends, see bug 131839.

* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that's the case.

LayoutTests:

Add a test to verify that the line height of a font is calculated from the typo metrics when the OS/2 USE_TYPO_METRICS flag is set. Currently, the test only passes with the FreeType backend.

* fonts/lineheight5000-typolineheight2300.woff: Added.
* fonts/use-typo-metrics-1-expected.html: Added.
* fonts/use-typo-metrics-1.html: Added.
* platform/mac/TestExpectations: Mark as failing.
* platform/win/TestExpectations: Mark as failing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp


Added Paths

trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff
trunk/LayoutTests/fonts/use-typo-metrics-1-expected.html
trunk/LayoutTests/fonts/use-typo-metrics-1.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191377 => 191378)

--- trunk/LayoutTests/ChangeLog	2015-10-21 06:41:13 UTC (rev 191377)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 07:05:21 UTC (rev 191378)
@@ -1,3 +1,18 @@
+2015-10-21  Frederic Wang  
+
+[FreeType] Add support for the USE_TYPO_METRICS flag
+https://bugs.webkit.org/show_bug.cgi?id=150340
+
+Reviewed by Martin Robinson.
+
+Add a test to verify that the line height of a font is calculated from the typo metrics when the OS/2 USE_TYPO_METRICS flag is set. Currently, the test only passes with the FreeType backend.
+
+* fonts/lineheight5000-typolineheight2300.woff: Added.
+* fonts/use-typo-metrics-1-expected.html: Added.
+* fonts/use-typo-metrics-1.html: Added.
+* platform/mac/TestExpectations: Mark as failing.
+* platform/win/TestExpectations: Mark as failing.
+
 2015-10-20  Ryan Haddad  
 
 Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html as flaky on Yosemite


Added: trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff (0 => 191378)

--- trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff	(rev 0)
+++ trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff	2015-10-21 07:05:21 UTC (rev 191378)
@@ -0,0 +1,17 @@
+wOFFOTTOT
+
CFF \xF4\xDF
(\x89\xC9 6FFTM
\xD4v\xC5\x86OS/2
\xF0D`!\xD5'cmap4E
J\x93\xA9head|06\x8Dh\xB7hhea\xAC$+\xAD+\xAFhmtx\xC8
+
+\xD0maxp\xD4Pname\xDC
]\xE4\xE7}\xAB\xE0post< \xFF\x863x\x9Ccd`aa`ddTO\xCB\xCF+\xD1\xCD\xC9\xCCK\xCDH\xCDL\xCF(1500\xD0-\xA9,\xC8G002102\xE8\xFD\xE0g\xF8!\xCD\xF8C\x86\xE9\x87,\xF3	\x96\xC6\xEE\xDF1\xBFj~na\x95ax\xC8/\xC3\xC0  \xC3\xF0LP\x86\x81O\x86QJ\x88\x81\xA4G\x8D\xC1\x87\xA1\xC89\xBF\xA0\xB2d\x96\x82F\xB2\xA6\x82\x91\x81\xA1\xA9\x82obI\x86\xAF\x8F\x82cqq~rfbIf~q.!ҽ@\xC0\xC8`\xC0\xC0\xCCȨ\xA4\xAC׽\xF7\x87\xEB^ƽ{n\xD9˼W\xEC\x97ď\x95\xFF$\xD8\xF6\xFE)\xFD\xE1\xFAs\xCBWv>\xBE\xDF1,\xBFj~\xD5\xFC\xABa\xE7\xFBU#\xD2-Z>\xFF\xE7\x96n\xB6n.\x8Elc[x\x9Cc```d\x82Kvo\xB8\xC1\xB4\xB3\xD0^+?\x8E\xD1x\x9Cc`a~\xC18\x81\x81\x95\x81\x81\xA9\x8BiC\x84f|\xC0`\xC8\xC8e`\xE5d\x80
Ft\xD0\xC0\xA0\xC0\xE0Ϭ\xF0߂U\x84\xF3\xE7\x84fd:\xFD
+-x\x9Cc```f\x80`Fp
\xF2\xC1|+ \xCD\xA4\x98\xFC\xFF\xFF\xF2\xC1\xF4\xFF\x87\xFF7C\xD5
#\x82\x83\x92GL\xA4)x
	9x\x9Cc`d``⠖7\xF1\xFC6_\xB8\x99_E.9\xEDE\xD0\xFF-\x98_0+\xB9L Q3\xA2
+\x89x\x9Cc`d`\xE0<\xC2y\x84\x81\x81\xF9\x98dd@LX\xE2u\xE8\xE8Px\x9CŒ?N\xC30ş\xD3?\xB0\xB2\x99\x81\xAAJ\xE5\xA4\xCAҭT\xEAP%k\xF7\xAAJ\x93HU\%^r
F\x8E\x828\x823p+^C\x87J\x8D\x95\xF8g\xE7\xBD\xEF\xB3?\xC05^!\xD0=\x88\x8C\xF0\xEE\xD8ýxt\xDC\xC3R|:\xEEc\xE4e\x8E\xB8\xF5\xDE1\xEA\xDDP)\xFAW\xAD\xAD\xABe\xC1\xE8\x95cO\xF8r\xDCóH\xF7{w\x8E\x90ދ\xE3!\xE7?\xB0\x84\xC6+\xA3Ȑ\xC3@b\x8C&\xECC(\x88H	\xB6\xFC\x93\xB3\x8F9Z\xA0f\xD3Tv\xBE \x97\xC0R\x9B\xAA\xC8r#ǻ\x89U\xC9dk\xF2$\x96\x8B\xBAֻbk
+M\xD9ު+|\xE8,\x912n\xFA\x9B=bζ\xF9\xE4\x86+\xD3\xFF\xAAB̬
+{]\xFFP\x94i\x9E\xB6\x99#\xA5\x94o\x9A\xA3\xFE\x9B
+g\x8A\xBA3\xA4:!\xCB\xCAm\xAD\xED+\xFAS[\xC4)\xDDs\xBE\xE7\xDCz1\xE0\xC8\xE7\xB7u\xFDV,\xCAJWY*é\x92syZ\x91(f~\xA0\xFC\xF6\xE4.tL\x9A+ޭ\xEEFIkl
\xBB-c\x93V5o\x91T*\x982\x88\xBC\xCC:\xBF
{\xBFfx\x9Cc`f\x83\xFF\xCDF@\x8A\x91
+(U
\xB9
\ No newline at end of file


Added: 

[webkit-changes] [191386] trunk/Source/WebCore

[commit-queue]

Title: [191386] trunk/Source/WebCore








Revision 191386
Author commit-qu...@webkit.org
Date 2015-10-21 05:52:17 -0700 (Wed, 21 Oct 2015)


Log Message
ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight
https://bugs.webkit.org/show_bug.cgi?id=150171

Patch by Carlos Garcia Campos  on 2015-10-21
Reviewed by Myles C. Maxfield.

It happens with several tests like fast/ruby/text-emphasis.html in
the GTK Debug bot. The tests seem to pass in Release and the rendering
looks correct as well removing the assert. The thing is that
for some reason we can get an empty GlyphData from
FontCascade::getEmphasisMarkGlyphData() when it ends up falling
back to system (FontCascadeFonts::glyphDataForSystemFallback).

* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::getEmphasisMarkGlyphData): Return
Optional instead of returning a boolean and an out
parameter. If we get an invalid GlyphData, Nullopt is
returned. Also use a SurrogatePairAwareTextIterator to handle
surrogate pairs.
(WebCore::FontCascade::emphasisMarkAscent):
(WebCore::FontCascade::emphasisMarkDescent):
(WebCore::FontCascade::emphasisMarkHeight):
(WebCore::FontCascade::drawEmphasisMarks):
* platform/graphics/FontCascade.h:
* platform/graphics/GlyphPage.h:
(WebCore::GlyphData::isValid): Return whether the GlyphData is valid.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/Source/WebCore/platform/graphics/FontCascade.h
trunk/Source/WebCore/platform/graphics/GlyphPage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191385 => 191386)

--- trunk/Source/WebCore/ChangeLog	2015-10-21 11:47:16 UTC (rev 191385)
+++ trunk/Source/WebCore/ChangeLog	2015-10-21 12:52:17 UTC (rev 191386)
@@ -1,3 +1,31 @@
+2015-10-21  Carlos Garcia Campos  
+
+ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight
+https://bugs.webkit.org/show_bug.cgi?id=150171
+
+Reviewed by Myles C. Maxfield.
+
+It happens with several tests like fast/ruby/text-emphasis.html in
+the GTK Debug bot. The tests seem to pass in Release and the rendering
+looks correct as well removing the assert. The thing is that
+for some reason we can get an empty GlyphData from
+FontCascade::getEmphasisMarkGlyphData() when it ends up falling
+back to system (FontCascadeFonts::glyphDataForSystemFallback).
+
+* platform/graphics/FontCascade.cpp:
+(WebCore::FontCascade::getEmphasisMarkGlyphData): Return
+Optional instead of returning a boolean and an out
+parameter. If we get an invalid GlyphData, Nullopt is
+returned. Also use a SurrogatePairAwareTextIterator to handle
+surrogate pairs.
+(WebCore::FontCascade::emphasisMarkAscent):
+(WebCore::FontCascade::emphasisMarkDescent):
+(WebCore::FontCascade::emphasisMarkHeight):
+(WebCore::FontCascade::drawEmphasisMarks):
+* platform/graphics/FontCascade.h:
+* platform/graphics/GlyphPage.h:
+(WebCore::GlyphData::isValid): Return whether the GlyphData is valid.
+
 2015-10-20  Sergio Villar Senin  
 
 [css-grid] Fix availableLogicalSpace computation with non-zero baseSize flex tracks


Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (191385 => 191386)

--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-10-21 11:47:16 UTC (rev 191385)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-10-21 12:52:17 UTC (rev 191386)
@@ -29,6 +29,7 @@
 #include "FontCache.h"
 #include "GlyphBuffer.h"
 #include "LayoutRect.h"
+#include "SurrogatePairAwareTextIterator.h"
 #include "TextRun.h"
 #include "WidthIterator.h"
 #include 
@@ -1197,38 +1198,31 @@
 
 // FIXME: This function may not work if the emphasis mark uses a complex script, but none of the
 // standard emphasis marks do so.
-bool FontCascade::getEmphasisMarkGlyphData(const AtomicString& mark, GlyphData& glyphData) const
+Optional FontCascade::getEmphasisMarkGlyphData(const AtomicString& mark) const
 {
 if (mark.isEmpty())
-return false;
+return Nullopt;
 
-UChar32 character = mark[0];
+UChar32 character;
+if (!mark.is8Bit()) {
+SurrogatePairAwareTextIterator iterator(mark.characters16(), 0, mark.length(), mark.length());
+unsigned clusterLength;
+if (!iterator.consume(character, clusterLength))
+return Nullopt;
+} else
+character = mark[0];
 
-if (U16_IS_SURROGATE(character)) {
-if (!U16_IS_SURROGATE_LEAD(character))
-return false;
-
-if (mark.length() < 2)
-return false;
-
-UChar low = mark[1];
-if (!U16_IS_TRAIL(low))
-return false;
-
-character = U16_GET_SUPPLEMENTARY(character, low);
-}
-
-glyphData = glyphDataForCharacter(character, false, EmphasisMarkVariant);
-return true;
+Optional 

[webkit-changes] [191385] trunk

[svillar]

Title: [191385] trunk








Revision 191385
Author svil...@igalia.com
Date 2015-10-21 04:47:16 -0700 (Wed, 21 Oct 2015)


Log Message
Source/WebCore:
[css-grid] Fix availableLogicalSpace computation with non-zero baseSize flex tracks
https://bugs.webkit.org/show_bug.cgi?id=150359

Reviewed by Zalan Bujtas.

The availableLogicalSpace computation was incorrect whenever
the flex tracks had a non-zero baseSize before the 1fr unit
size resolution. That happened because when assigning the new
baseSize to the flex track, we were unconditionally
subtracting the whole baseSize to the
availableLogicalSpace. That's correct if the track is a "pure"
flex track, i.e. 2fr, but if the track had a non-zero baseSize
(like minmax(10px, 1fr)) then both the new and the old base
sizes were incorrectly used to compute the
availableLogicalSpace.

We can test the amount of remaining freeSpace by using content
distribution to align and item place on a non-zero baseSize
flex track. The content distribution will be accurate if and
only if the availableLogicalSpace computation is correct.

Test: fast/css-grid-layout/flex-content-distribution.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):

LayoutTests:
[css-grid] Fix freeSpace computation with non-zero baseSize flex tracks
https://bugs.webkit.org/show_bug.cgi?id=150359

Reviewed by Zalan Bujtas.

* fast/css-grid-layout/flex-content-distribution-expected.txt: Added.
* fast/css-grid-layout/flex-content-distribution.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp


Added Paths

trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191384 => 191385)

--- trunk/LayoutTests/ChangeLog	2015-10-21 08:52:27 UTC (rev 191384)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 11:47:16 UTC (rev 191385)
@@ -1,3 +1,13 @@
+2015-10-20  Sergio Villar Senin  
+
+[css-grid] Fix freeSpace computation with non-zero baseSize flex tracks
+https://bugs.webkit.org/show_bug.cgi?id=150359
+
+Reviewed by Zalan Bujtas.
+
+* fast/css-grid-layout/flex-content-distribution-expected.txt: Added.
+* fast/css-grid-layout/flex-content-distribution.html: Added.
+
 2015-10-21  Youenn Fablet  
 
 Remove commented lines in TestExpectations


Added: trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt (0 => 191385)

--- trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt	2015-10-21 11:47:16 UTC (rev 191385)
@@ -0,0 +1,20 @@
+This test checks that freeSpace is properly computed after computing fr tracks so that we could use it for content distribution
+
+Grid with justify-content: start.
+
+PASS
+Grid with justify-content: center.
+
+PASS
+Grid with justify-content: end.
+
+PASS
+Grid with align-content: start.
+
+PASS
+Grid with align-content: center.
+
+PASS
+Grid with align-content: end.
+
+PASS
Property changes on: trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution.html (0 => 191385)

--- trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-content-distribution.html	2015-10-21 11:47:16 UTC (rev 191385)
@@ -0,0 +1,81 @@
+
+
+
+
+
+.freeSpaceForColumnsGrid {
+-webkit-grid-template: minmax(20px, 0.7fr) / 100%;
+width: 50px;
+height: 100px;
+}
+
+.freeSpaceForRowsGrid {
+-webkit-grid-template: 100% / minmax(20px, 0.7fr);
+width: 50px;
+height: 100px;
+}
+
+.container { position: relative; }
+
+.item {
+width: 100%;
+height: 50px;
+background-color: red;
+}
+
+.item2 {
+width: 50px;
+height: 100%;
+background-color: red;
+}
+
+
+

[webkit-changes] [191375] trunk/LayoutTests

[commit-queue]

Title: [191375] trunk/LayoutTests








Revision 191375
Author commit-qu...@webkit.org
Date 2015-10-20 23:08:20 -0700 (Tue, 20 Oct 2015)


Log Message
Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=150363

Patch by Ryan Haddad  on 2015-10-20
Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191374 => 191375)

--- trunk/LayoutTests/ChangeLog	2015-10-21 05:36:49 UTC (rev 191374)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 06:08:20 UTC (rev 191375)
@@ -1,3 +1,12 @@
+2015-10-20  Ryan Haddad  
+
+Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite
+https://bugs.webkit.org/show_bug.cgi?id=150363
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac-wk2/TestExpectations:
+
 2015-10-20  Aakash Jain  
 
 run-webkit-tests does not copy all crash logs for layout test failures on iOS


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (191374 => 191375)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-21 05:36:49 UTC (rev 191374)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-21 06:08:20 UTC (rev 191375)
@@ -274,6 +274,8 @@
 
 webkit.org/b/150241 webarchive/loading/object.html [ Pass Crash ] 
 
+webkit.org/b/150363 [ Yosemite ] http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html [ Pass Failure ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191376] trunk/LayoutTests

[commit-queue]

Title: [191376] trunk/LayoutTests








Revision 191376
Author commit-qu...@webkit.org
Date 2015-10-20 23:20:58 -0700 (Tue, 20 Oct 2015)


Log Message
Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html as flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=150378

Patch by Ryan Haddad  on 2015-10-20
Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191375 => 191376)

--- trunk/LayoutTests/ChangeLog	2015-10-21 06:08:20 UTC (rev 191375)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 06:20:58 UTC (rev 191376)
@@ -1,5 +1,14 @@
 2015-10-20  Ryan Haddad  
 
+Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html as flaky on Yosemite
+https://bugs.webkit.org/show_bug.cgi?id=150378
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac-wk2/TestExpectations:
+
+2015-10-20  Ryan Haddad  
+
 Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite
 https://bugs.webkit.org/show_bug.cgi?id=150363
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (191375 => 191376)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-21 06:08:20 UTC (rev 191375)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-21 06:20:58 UTC (rev 191376)
@@ -276,6 +276,8 @@
 
 webkit.org/b/150363 [ Yosemite ] http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html [ Pass Failure ]
 
+webkit.org/b/150378 [ Yosemite ] http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html [ Pass Failure ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191383] trunk

[calvaris]

Title: [191383] trunk








Revision 191383
Author calva...@igalia.com
Date 2015-10-21 01:34:41 -0700 (Wed, 21 Oct 2015)


Log Message
[Streams API] Construct a writable stream
https://bugs.webkit.org/show_bug.cgi?id=150360

Reviewed by Darin Adler.

Source/WebCore:

This patch initializes a writable stream according to the spec. To do it we need two internal functions, which
are syncWritableStreamStateWithQueue and errorWritableStream, which are also implemented as a quite direct
translation from the spec.

Current test set suffices, expectations are updated accordingly.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/WebCoreBuiltinNames.h:
* bindings/js/WebCoreJSBuiltinInternals.h:
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
* Modules/streams/WritableStream.js:
(initializeWritableStream): Function that acts as constructor of WritableStream.
* Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue):
(errorWritableStream): As per spec.

LayoutTests:

Expectations for the writable stream initialization.

* streams/reference-implementation/bad-strategies-expected.txt:
* streams/reference-implementation/bad-underlying-sinks-expected.txt:
* streams/reference-implementation/brand-checks-expected.txt:
* streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
* streams/reference-implementation/count-queuing-strategy-expected.txt:
* streams/reference-implementation/pipe-through-expected.txt:
* streams/reference-implementation/pipe-to-expected.txt:
* streams/reference-implementation/pipe-to-options-expected.txt:
* streams/reference-implementation/readable-stream-templated-expected.txt:
* streams/reference-implementation/writable-stream-abort-expected.txt:
* streams/reference-implementation/writable-stream-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt
trunk/LayoutTests/streams/reference-implementation/bad-underlying-sinks-expected.txt
trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt
trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt
trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-through-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-to-options-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt
trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt
trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/streams/WritableStream.js
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h


Added Paths

trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js




Diff

Modified: trunk/LayoutTests/ChangeLog (191382 => 191383)

--- trunk/LayoutTests/ChangeLog	2015-10-21 08:18:29 UTC (rev 191382)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 08:34:41 UTC (rev 191383)
@@ -1,3 +1,24 @@
+2015-10-21  Xabier Rodriguez Calvar  
+
+[Streams API] Construct a writable stream
+https://bugs.webkit.org/show_bug.cgi?id=150360
+
+Reviewed by Darin Adler.
+
+Expectations for the writable stream initialization.
+
+* streams/reference-implementation/bad-strategies-expected.txt:
+* streams/reference-implementation/bad-underlying-sinks-expected.txt:
+* streams/reference-implementation/brand-checks-expected.txt:
+* streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
+* streams/reference-implementation/count-queuing-strategy-expected.txt:
+* streams/reference-implementation/pipe-through-expected.txt:
+* streams/reference-implementation/pipe-to-expected.txt:
+* streams/reference-implementation/pipe-to-options-expected.txt:
+* streams/reference-implementation/readable-stream-templated-expected.txt:
+* streams/reference-implementation/writable-stream-abort-expected.txt:
+* streams/reference-implementation/writable-stream-expected.txt:
+
 2015-10-21  Frederic Wang  
 
 Unreviewed gardening. Test expectation for use-typo-metrics-1 on Mac and Windows should be "ImageOnlyFailure" not "Failure".


Modified: 

[webkit-changes] [191380] trunk

[youenn . fablet]

Title: [191380] trunk








Revision 191380
Author youenn.fab...@crf.canon.fr
Date 2015-10-21 00:53:37 -0700 (Wed, 21 Oct 2015)


Log Message
W3C test importer should not import reference files as regular tests
https://bugs.webkit.org/show_bug.cgi?id=150331

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* resources/ImportExpectations: Removed some Skip expectations as test importer no longer will handle these files as tests, but as reference files.

Tools:

Updated test_parser to return information that a file can be a referencefile or a manual test.
Updated test importer to skip those files.
Updated/Added test parser unit tests accordingly.

Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
to mark these files as Skip, since they are not direct tests.

* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.__init__):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
* Scripts/webkitpy/w3c/test_parser.py:
(TestParser.analyze_test):
* Scripts/webkitpy/w3c/test_parser_unittest.py:
(test_analyze_non_html_file):
(test_reference_test):

LayoutTests:

* TestExpectations: Adding Skip expectations for web-platform-test resource files (currently commented out as not all are yet imported).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/ImportExpectations
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_importer.py
trunk/Tools/Scripts/webkitpy/w3c/test_parser.py
trunk/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py




Diff

Modified: trunk/LayoutTests/ChangeLog (191379 => 191380)

--- trunk/LayoutTests/ChangeLog	2015-10-21 07:44:33 UTC (rev 191379)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 07:53:37 UTC (rev 191380)
@@ -1,5 +1,14 @@
 2015-10-21  Youenn Fablet  
 
+W3C test importer should not import reference files as regular tests
+https://bugs.webkit.org/show_bug.cgi?id=150331
+
+Reviewed by Darin Adler.
+
+* TestExpectations: Adding Skip expectations for web-platform-test resource files (currently commented out as not all are yet imported).
+
+2015-10-21  Youenn Fablet  
+
 Update web-platform-tests tests to the same revision as tools
 https://bugs.webkit.org/show_bug.cgi?id=149656
 


Modified: trunk/LayoutTests/TestExpectations (191379 => 191380)

--- trunk/LayoutTests/TestExpectations	2015-10-21 07:44:33 UTC (rev 191379)
+++ trunk/LayoutTests/TestExpectations	2015-10-21 07:53:37 UTC (rev 191380)
@@ -266,6 +266,68 @@
 imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1c.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe.html [ Skip ]
 
+# Resource files not in resources folder
+#imported/w3c/web-platform-tests/common/blank.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xhtml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xhtml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xhtml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xhtml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xml [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.html [ Skip ]
+#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xhtml [ Skip ]

[webkit-changes] [191381] trunk/Source

[carlosgc]

Title: [191381] trunk/Source








Revision 191381
Author carlo...@webkit.org
Date 2015-10-21 01:08:48 -0700 (Wed, 21 Oct 2015)


Log Message
NetworkProcess: DNS prefetch happens in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=147824

Reviewed by Chris Dumez.

Source/WebCore:

Use FrameLoaderClient to do the DNS prefetch.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit/mac:

Implement FrameLoaderClient::prefetchDNS().

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

Implement FrameLoaderClient::prefetchDNS().

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::prefetchDNS):
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

DNS prefetch requests started in the WebProcess should be sent to
the network process when it's enabled.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::prefetchDNS): Use NetworkProcess::prefetchDNS().
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in: Add
PrefetchDNS message.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prefetchDNS): Do the actual DNS prefetch.
* NetworkProcess/NetworkProcess.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage): Use WebProcess::prefetchDNS().
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::prefetchDNS): Use WebProcess::prefetchDNS().
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary): Use
FrameLoaderClient to do the DNS prefetch.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Initialize the DNS prefetched
hosts cleanup hysteresis activity. Clear the cache of DNS
prefetched when hysteresis activity stopped.
(WebKit::WebProcess::prefetchDNS): Send the request to the network
process if it's enabled, otherwise do the actual DNS prefetch.
* WebProcess/WebProcess.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191380 => 191381)

--- trunk/Source/WebCore/ChangeLog	2015-10-21 07:53:37 UTC (rev 191380)
+++ trunk/Source/WebCore/ChangeLog	2015-10-21 08:08:48 UTC (rev 191381)
@@ -1,3 +1,21 @@
+2015-10-21  Carlos Garcia Campos  
+
+NetworkProcess: DNS prefetch happens in the Web Process
+https://bugs.webkit.org/show_bug.cgi?id=147824
+
+Reviewed by Chris Dumez.
+
+Use FrameLoaderClient to do the DNS prefetch.
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::parseAttribute):
+* loader/EmptyClients.h:
+* loader/FrameLoaderClient.h:
+* loader/LinkLoader.cpp:
+(WebCore::LinkLoader::loadLink):
+* page/Chrome.cpp:
+(WebCore::Chrome::mouseDidMoveOverElement):
+
 2015-10-21  Frederic Wang  
 
 [FreeType] Add support for the USE_TYPO_METRICS flag


Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (191380 => 191381)

--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2015-10-21 07:53:37 UTC (rev 191380)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2015-10-21 08:08:48 UTC (rev 191381)
@@ -25,7 +25,6 @@
 #include "HTMLAnchorElement.h"
 
 #include "AttributeDOMTokenList.h"
-#include "DNS.h"
 #include "ElementIterator.h"
 #include "EventHandler.h"
 #include "EventNames.h"
@@ -252,9 +251,9 @@
   

[webkit-changes] [191382] trunk/LayoutTests

[fred . wang]

Title: [191382] trunk/LayoutTests








Revision 191382
Author fred.w...@free.fr
Date 2015-10-21 01:18:29 -0700 (Wed, 21 Oct 2015)


Log Message
Unreviewed gardening. Test expectation for use-typo-metrics-1 on Mac and Windows should be "ImageOnlyFailure" not "Failure".

* platform/mac/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191381 => 191382)

--- trunk/LayoutTests/ChangeLog	2015-10-21 08:08:48 UTC (rev 191381)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 08:18:29 UTC (rev 191382)
@@ -1,3 +1,10 @@
+2015-10-21  Frederic Wang  
+
+Unreviewed gardening. Test expectation for use-typo-metrics-1 on Mac and Windows should be "ImageOnlyFailure" not "Failure".
+
+* platform/mac/TestExpectations:
+* platform/win/TestExpectations:
+
 2015-10-21  Youenn Fablet  
 
 W3C test importer should not import reference files as regular tests


Modified: trunk/LayoutTests/platform/mac/TestExpectations (191381 => 191382)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-10-21 08:08:48 UTC (rev 191381)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-10-21 08:18:29 UTC (rev 191382)
@@ -1350,4 +1350,4 @@
 imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]
 
 # USE_TYPO_METRICS is not implemented on mac.
-webkit.org/b/131839 fonts/use-typo-metrics-1.html [ Failure ]
+webkit.org/b/131839 fonts/use-typo-metrics-1.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/win/TestExpectations (191381 => 191382)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-21 08:08:48 UTC (rev 191381)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-21 08:18:29 UTC (rev 191382)
@@ -3266,4 +3266,4 @@
 fast/forms/hidpi-textfield-background-bleeding.html [ Skip ]
 
 # USE_TYPO_METRICS is not implemented on the Windows platform
-webkit.org/b/131839 fonts/use-typo-metrics-1.html [ Failure ]
+webkit.org/b/131839 fonts/use-typo-metrics-1.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191384] trunk/LayoutTests

[youenn . fablet]

Title: [191384] trunk/LayoutTests








Revision 191384
Author youenn.fab...@crf.canon.fr
Date 2015-10-21 01:52:27 -0700 (Wed, 21 Oct 2015)


Log Message
Remove commented lines in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=150387

Unreviewed.


* TestExpectations: remove commented lines introduced in bug 150331 bug.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191383 => 191384)

--- trunk/LayoutTests/ChangeLog	2015-10-21 08:34:41 UTC (rev 191383)
+++ trunk/LayoutTests/ChangeLog	2015-10-21 08:52:27 UTC (rev 191384)
@@ -1,3 +1,12 @@
+2015-10-21  Youenn Fablet  
+
+Remove commented lines in TestExpectations
+https://bugs.webkit.org/show_bug.cgi?id=150387
+
+Unreviewed.
+
+* TestExpectations: remove commented lines introduced in bug 150331 bug.
+
 2015-10-21  Xabier Rodriguez Calvar  
 
 [Streams API] Construct a writable stream


Modified: trunk/LayoutTests/TestExpectations (191383 => 191384)

--- trunk/LayoutTests/TestExpectations	2015-10-21 08:34:41 UTC (rev 191383)
+++ trunk/LayoutTests/TestExpectations	2015-10-21 08:52:27 UTC (rev 191384)
@@ -266,68 +266,6 @@
 imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1c.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe.html [ Skip ]
 
-# Resource files not in resources folder
-#imported/w3c/web-platform-tests/common/blank.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xhtml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xml [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/Node-parentNode-iframe.html [ Skip ]
-#imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html [ Skip ]