[webkit-changes] [214865] trunk

[wenson_hsieh]

Title: [214865] trunk








Revision 214865
Author wenson_hs...@apple.com
Date 2017-04-03 21:31:48 -0700 (Mon, 03 Apr 2017)


Log Message
Data interaction should register type identifiers in order of priority
https://bugs.webkit.org/show_bug.cgi?id=170428


Reviewed by Tim Horton.

Source/WebCore:

Currently, due to the shared logic for writing to a UIPasteboard (in the case of copy/paste) and the shared
UIItemProvider-based pasteboard wrapper (in the case of data interaction), we don't enforce any particular
ordering in which type identifiers are registered in the generated item provider. This is because
-[UIPasteboard setItems:] only takes an unordered mapping of type identifiers to objects.

To fix this, we introduce a separate way to set pasteboard data that first writes a list of object
representations in order of priority (which is dependent on the content being interacted with) and then register
individual type-data mappings at the end.

Augmented existing API tests in DataInteractionTests to check for the existence and priority of type identifiers
in the UIItemProviders created upon starting data interaction. Also adds a new unit test:
DataInteractionTests.TextAreaToInput.

* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/EditorCocoa.mm:
(WebCore::archivedDataForAttributedString):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeSelection):
* platform/Pasteboard.h:
* platform/PasteboardWriterData.h:
* platform/PlatformPasteboard.h:
* platform/ios/AbstractPasteboard.h:
* platform/ios/AbstractPasteboard.mm: Copied from Source/WebCore/platform/ios/AbstractPasteboard.h.

Introduce WebPasteboardItemData, a wrapper around a list of objects representating the pasteboard data in order
of priority, and a dictionary containing additional NSData blobs that contain data useful for private clients.

(+[WebPasteboardItemData itemWithRepresentingObjects:additionalData:]):
(-[WebPasteboardItemData initWithRepresentingObjects:additionalData:]):
(-[WebPasteboardItemData representingObjects]):
(-[WebPasteboardItemData additionalData]):
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::richTextRepresentationsForPasteboardWebContent):
(WebCore::PlatformPasteboard::writeObjectRepresentations):
(WebCore::PlatformPasteboard::write):

Tweaked to check whether the pasteboard responds to -setItemsFromObjectRepresentations:. If so, uses the
PlatformPasteboard::writeObjectRepresentations codepath to write data to the pasteboard, respecting type
priority.

* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard pasteboardTypes]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard setItemsFromObjectRepresentations:]):

Replaces -setItems: with -setItemsFromObjectRepresentations:, which respects the priority of each object
representation of the data in the pasteboard.

(-[WebItemProviderPasteboard setItems:]): Deleted.

Source/WebKit2:

Serialize PasteboardWebContent.dataInAttributedStringFormat when sending over IPC. Refer to WebCore ChangeLog
for more details.

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* UIProcess/API/Cocoa/WKWebView.mm:

Tools:

Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
test for data interaction from a textarea to an input.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkTypeIdentifierPrecedesOtherTypeIdentifier):
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/DataInteractionSimulator.h:
* TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator _advanceProgress]):
(-[DataInteractionSimulator sourceItemProviders]):
(-[DataInteractionSimulator _webView:showCustomSheetForElement:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/PasteboardWriterData.h
trunk/Source/WebCore/platform/PlatformPasteboard.h
trunk/Source/WebCore/platform/ios/AbstractPasteboard.h
trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h
trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm


Added Paths

trunk/Source/WebCore/platform/ios/AbstractPasteboard.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (214864 => 214865)

--- trunk/Source/WebCore/ChangeLog	2017-04-04 03:30:30 UTC (rev 214864)
+++ trunk/Source/WebCore/ChangeLog	2017-04-04 04:31:48 UTC (rev 214865)
@@ -1,3 +1,61 @@

[webkit-changes] [214864] trunk/Source/WebInspectorUI

[bburg]

Title: [214864] trunk/Source/WebInspectorUI








Revision 214864
Author bb...@apple.com
Date 2017-04-03 20:30:30 -0700 (Mon, 03 Apr 2017)


Log Message
Web Inspector: RTL: results in Search navigation sidebar have misplaced highlights
https://bugs.webkit.org/show_bug.cgi?id=170292

Reviewed by Timothy Hatcher.

* UserInterface/Models/SourceCodeSearchMatchObject.js:
(WebInspector.SourceCodeSearchMatchObject.prototype.get className):
* UserInterface/Views/SearchIcons.css:
(.source-code-match .icon):
(.source-code-match-icon .icon): Deleted.
Remove -icon suffix from the class name since the class is attached to a result
and is not specific to the icon displayed within the result .

* UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
Flip the leading and trailing context in RTL so that the highlight is not overflowed
to the left when too much context is included on the right side. Less context must be
used in RTL because we must not overflow to the right, as it may hide the result. And,
we don't know the exact starting character either as it may be overflowed to the right
as the user resizes the expanded sidebar larger or smaller. So show less context to
be conservative about never overflowing the highlighted result string.

* UserInterface/Views/SearchSidebarPanel.css:
(.sidebar > .panel.navigation.search .item.source-code-match .title):
When in RTL, show source code matches as LTR with text-align to right.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js
trunk/Source/WebInspectorUI/UserInterface/Views/SearchIcons.css
trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (214863 => 214864)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 03:28:03 UTC (rev 214863)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 03:30:30 UTC (rev 214864)
@@ -1,3 +1,31 @@
+2017-04-03  Brian Burg  
+
+Web Inspector: RTL: results in Search navigation sidebar have misplaced highlights
+https://bugs.webkit.org/show_bug.cgi?id=170292
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Models/SourceCodeSearchMatchObject.js:
+(WebInspector.SourceCodeSearchMatchObject.prototype.get className):
+* UserInterface/Views/SearchIcons.css:
+(.source-code-match .icon):
+(.source-code-match-icon .icon): Deleted.
+Remove -icon suffix from the class name since the class is attached to a result
+and is not specific to the icon displayed within the result .
+
+* UserInterface/Views/SearchResultTreeElement.js:
+(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
+Flip the leading and trailing context in RTL so that the highlight is not overflowed
+to the left when too much context is included on the right side. Less context must be
+used in RTL because we must not overflow to the right, as it may hide the result. And,
+we don't know the exact starting character either as it may be overflowed to the right
+as the user resizes the expanded sidebar larger or smaller. So show less context to
+be conservative about never overflowing the highlighted result string.
+
+* UserInterface/Views/SearchSidebarPanel.css:
+(.sidebar > .panel.navigation.search .item.source-code-match .title):
+When in RTL, show source code matches as LTR with text-align to right.
+
 2017-04-03  Devin Rousso  
 
 Web Inspector: clicking on the body of a CSS rule after editing the selector causes the section to disappear


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js (214863 => 214864)

--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js	2017-04-04 03:28:03 UTC (rev 214863)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js	2017-04-04 03:30:30 UTC (rev 214864)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -46,7 +46,7 @@
 
 get className()
 {
-return WebInspector.SourceCodeSearchMatchObject.SourceCodeMatchIconStyleClassName;
+return "source-code-match";
 }
 
 saveIdentityToCookie(cookie)
@@ -59,8 +59,6 @@
 }
 };
 
-WebInspector.SourceCodeSearchMatchObject.SourceCodeMatchIconStyleClassName = "source-code-match-icon";
-
 WebInspector.SourceCodeSearchMatchObject.TypeIdentifier = "source-code-search-match-object";
 WebInspector.SourceCodeSearchMatchObject.URLCookieKey = 

[webkit-changes] [214862] trunk/Source/WebInspectorUI

[bburg]

Title: [214862] trunk/Source/WebInspectorUI








Revision 214862
Author bb...@apple.com
Date 2017-04-03 20:20:28 -0700 (Mon, 03 Apr 2017)


Log Message
Web Inspector: RTL: hierarchical path component labels should guess directionality based on content
https://bugs.webkit.org/show_bug.cgi?id=170298

Reviewed by Timothy Hatcher.

* UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent):
Use dir="auto" since this will properly set 'unicode-bidi:isolate' for form elements too.
This is applied to the title label and to the  for the path component.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (214861 => 214862)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 03:19:09 UTC (rev 214861)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 03:20:28 UTC (rev 214862)
@@ -1,3 +1,15 @@
+2017-04-03  Brian Burg  
+
+Web Inspector: RTL: hierarchical path component labels should guess directionality based on content
+https://bugs.webkit.org/show_bug.cgi?id=170298
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/HierarchicalPathComponent.js:
+(WebInspector.HierarchicalPathComponent):
+Use dir="auto" since this will properly set 'unicode-bidi:isolate' for form elements too.
+This is applied to the title label and to the  for the path component.
+
 2017-04-03  Matt Baker  
 
 Web Inspector: Show additional pause reason details for DOM "subtree modified" breakpoint


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js (214861 => 214862)

--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js	2017-04-04 03:19:09 UTC (rev 214861)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js	2017-04-04 03:20:28 UTC (rev 214862)
@@ -51,6 +51,7 @@
 
 this._titleElement = document.createElement("div");
 this._titleElement.className = "title";
+this._titleElement.setAttribute("dir", "auto");
 this._element.appendChild(this._titleElement);
 
 this._titleContentElement = document.createElement("div");
@@ -62,6 +63,7 @@
 this._element.appendChild(this._separatorElement);
 
 this._selectElement = document.createElement("select");
+this._selectElement.setAttribute("dir", "auto");
 this._selectElement.addEventListener("mouseover", this._selectElementMouseOver.bind(this));
 this._selectElement.addEventListener("mouseout", this._selectElementMouseOut.bind(this));
 this._selectElement.addEventListener("mousedown", this._selectElementMouseDown.bind(this));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214861] trunk/Source/WebInspectorUI

[mattbaker]

Title: [214861] trunk/Source/WebInspectorUI








Revision 214861
Author mattba...@apple.com
Date 2017-04-03 20:19:09 -0700 (Mon, 03 Apr 2017)


Log Message
Web Inspector: Show additional pause reason details for DOM "subtree modified" breakpoint
https://bugs.webkit.org/show_bug.cgi?id=169479

Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
New Pause Reason UI strings.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
Include a link for the target node when breaking for subtree modifications.
This is either the parent of a node being inserted, or a node that is
being removed.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (214860 => 214861)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 01:22:41 UTC (rev 214860)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-04-04 03:19:09 UTC (rev 214861)
@@ -1,3 +1,19 @@
+2017-04-03  Matt Baker  
+
+Web Inspector: Show additional pause reason details for DOM "subtree modified" breakpoint
+https://bugs.webkit.org/show_bug.cgi?id=169479
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+New Pause Reason UI strings.
+
+* UserInterface/Views/DebuggerSidebarPanel.js:
+(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
+Include a link for the target node when breaking for subtree modifications.
+This is either the parent of a node being inserted, or a node that is
+being removed.
+
 2017-04-03  Devin Rousso  
 
 Web Inspector: showing the Find banner doesn't immediately focus it


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (214860 => 214861)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-04-04 01:22:41 UTC (rev 214860)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-04-04 03:19:09 UTC (rev 214861)
@@ -153,6 +153,7 @@
 localizedStrings["Charge ‘%s’ to Callers"] = "Charge ‘%s’ to Callers";
 localizedStrings["Checked"] = "Checked";
 localizedStrings["Child Layers"] = "Child Layers";
+localizedStrings["Child added to "] = "Child added to ";
 localizedStrings["Children"] = "Children";
 localizedStrings["Classes"] = "Classes";
 localizedStrings["Clear"] = "Clear";
@@ -659,6 +660,7 @@
 localizedStrings["Remove probe"] = "Remove probe";
 localizedStrings["Remove selected item"] = "Remove selected item";
 localizedStrings["Remove this breakpoint action"] = "Remove this breakpoint action";
+localizedStrings["Removed descendant "] = "Removed descendant ";
 localizedStrings["Rendering Frames"] = "Rendering Frames";
 localizedStrings["Repeat"] = "Repeat";
 localizedStrings["Repeating Linear Gradient"] = "Repeating Linear Gradient";
@@ -856,7 +858,6 @@
 localizedStrings["Transform"] = "Transform";
 localizedStrings["Transition"] = "Transition";
 localizedStrings["Triggered Breakpoint"] = "Triggered Breakpoint";
-localizedStrings["Triggered DOM Breakpoint"] = "Triggered DOM Breakpoint";
 localizedStrings["Triggered XHR Breakpoint"] = "Triggered XHR Breakpoint";
 localizedStrings["True"] = "True";
 localizedStrings["Type"] = "Type";


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (214860 => 214861)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-04-04 01:22:41 UTC (rev 214860)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-04-04 03:19:09 UTC (rev 214861)
@@ -974,14 +974,43 @@
 if (!domBreakpoint)
 return;
 
-this._pauseReasonTreeOutline = this.createContentTreeOutline(true, true);
+const suppressFiltering = true;
+this._pauseReasonTreeOutline = this.createContentTreeOutline(suppressFiltering);
 
-let domBreakpointTreeElement = new WebInspector.DOMBreakpointTreeElement(domBreakpoint, WebInspector.DebuggerSidebarPanel.PausedBreakpointIconStyleClassName, WebInspector.UIString("Triggered DOM Breakpoint"));
-let domBreakpointDetailsSection = new WebInspector.DetailsSectionRow;
+let type = WebInspector.DOMBreakpointTreeElement.displayNameForType(domBreakpoint.type);
+let domBreakpointTreeElement = new WebInspector.DOMBreakpointTreeElement(domBreakpoint, WebInspector.DebuggerSidebarPanel.PausedBreakpointIconStyleClassName, type);
+let domBreakpointRow = new WebInspector.DetailsSectionRow;
 this._pauseReasonTreeOutline.appendChild(domBreakpointTreeElement);
-

[webkit-changes] [214860] trunk/LayoutTests

[ap]

Title: [214860] trunk/LayoutTests








Revision 214860
Author a...@apple.com
Date 2017-04-03 18:22:41 -0700 (Mon, 03 Apr 2017)


Log Message
Re-adding flaky timeout expectation for http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html

This test still times out, most of the time.

* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214859 => 214860)

--- trunk/LayoutTests/ChangeLog	2017-04-04 00:57:32 UTC (rev 214859)
+++ trunk/LayoutTests/ChangeLog	2017-04-04 01:22:41 UTC (rev 214860)
@@ -1,3 +1,11 @@
+2017-04-03  Alexey Proskuryakov  
+
+Re-adding flaky timeout expectation for http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html
+
+This test still times out, most of the time.
+
+* platform/wk2/TestExpectations:
+
 2017-04-03  Javier Fernandez  
 
 [css-align] Adapt place-content alignment shorthand to the new baseline syntax


Modified: trunk/LayoutTests/platform/wk2/TestExpectations (214859 => 214860)

--- trunk/LayoutTests/platform/wk2/TestExpectations	2017-04-04 00:57:32 UTC (rev 214859)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2017-04-04 01:22:41 UTC (rev 214860)
@@ -699,7 +699,7 @@
 imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.html [ Failure ]
 
 # Resource Load Statistics are only supported in WebKit2.
-http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html [ Pass ]
+http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html [ Pass Timeout ]
 http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214859] trunk/Tools

[clopez]

Title: [214859] trunk/Tools








Revision 214859
Author clo...@igalia.com
Date 2017-04-03 17:57:32 -0700 (Mon, 03 Apr 2017)


Log Message
[GTK][JHBuild] Update mesa repository url for tarballs
https://bugs.webkit.org/show_bug.cgi?id=170431

Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (214858 => 214859)

--- trunk/Tools/ChangeLog	2017-04-04 00:42:54 UTC (rev 214858)
+++ trunk/Tools/ChangeLog	2017-04-04 00:57:32 UTC (rev 214859)
@@ -1,3 +1,12 @@
+2017-04-03  Carlos Alberto Lopez Perez  
+
+[GTK][JHBuild] Update mesa repository url for tarballs
+https://bugs.webkit.org/show_bug.cgi?id=170431
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules:
+
 2017-04-03  Joseph Pecoraro  
 
 TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf


Modified: trunk/Tools/gtk/jhbuild.modules (214858 => 214859)

--- trunk/Tools/gtk/jhbuild.modules	2017-04-04 00:42:54 UTC (rev 214858)
+++ trunk/Tools/gtk/jhbuild.modules	2017-04-04 00:57:32 UTC (rev 214859)
@@ -72,8 +72,8 @@
   href=""
 href=""
-  +href=""
   @@ -503,9 +503,10 @@
 autogenargs="--disable-dri3 --enable-dri --enable-glx --enable-egl --with-egl-platforms=x11,wayland --with-dri-drivers=swrast --with-gallium-drivers=swrast">
 
-+ hash="sha256:8340e64cdc91999840404c211496f3de38e7b4cb38db34e2f72f1642c5134760">
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214858] trunk/Tools

[commit-queue]

Title: [214858] trunk/Tools








Revision 214858
Author commit-qu...@webkit.org
Date 2017-04-03 17:42:54 -0700 (Mon, 03 Apr 2017)


Log Message
TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
https://bugs.webkit.org/show_bug.cgi?id=170430

Patch by Joseph Pecoraro  on 2017-04-03
Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
Eliminate one of the copies of Ahem.ttf.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Once eliminated, there is now only one Ahem.ttf that is copied
to the Resources bundle. Drive-by sort the project file.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Removed Paths

trunk/Tools/TestWebKitAPI/Tests/mac/Ahem.ttf




Diff

Modified: trunk/Tools/ChangeLog (214857 => 214858)

--- trunk/Tools/ChangeLog	2017-04-04 00:42:02 UTC (rev 214857)
+++ trunk/Tools/ChangeLog	2017-04-04 00:42:54 UTC (rev 214858)
@@ -1,3 +1,17 @@
+2017-04-03  Joseph Pecoraro  
+
+TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
+https://bugs.webkit.org/show_bug.cgi?id=170430
+
+Reviewed by Alexey Proskuryakov.
+
+* TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
+Eliminate one of the copies of Ahem.ttf.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+Once eliminated, there is now only one Ahem.ttf that is copied
+to the Resources bundle. Drive-by sort the project file.
+
 2017-04-03  Simon Fraser  
 
 Allow MiniBrowser windows to receive local file drags again


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (214857 => 214858)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-04-04 00:42:02 UTC (rev 214857)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-04-04 00:42:54 UTC (rev 214858)
@@ -508,7 +508,6 @@
 		AD7C434D1DD2A54E0026888B /* Expected.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AD7C434C1DD2A5470026888B /* Expected.cpp */; };
 		B55AD1D5179F3B3000AC1494 /* PreventImageLoadWithAutoResizing_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B55AD1D3179F3ABF00AC1494 /* PreventImageLoadWithAutoResizing_Bundle.cpp */; };
 		B55F11B71517D03300915916 /* attributedStringCustomFont.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = B55F11B01517A2C400915916 /* attributedStringCustomFont.html */; };
-		B55F11BE15191A0600915916 /* Ahem.ttf in Copy Resources */ = {isa = PBXBuildFile; fileRef = B55F11B9151916E600915916 /* Ahem.ttf */; };
 		BC22D31914DC68B900FFB1DD /* UserMessage_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC22D31714DC68B800FFB1DD /* UserMessage_Bundle.cpp */; };
 		BC246D9C132F1FF000B56D7C /* CanHandleRequest_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC246D97132F1FE100B56D7C /* CanHandleRequest_Bundle.cpp */; };
 		BC2D006412AA04CE00E732A3 /* file-with-anchor.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = BC2D004A12A9FEB300E732A3 /* file-with-anchor.html */; };
@@ -659,88 +658,55 @@
 			dstPath = TestWebKitAPI.resources;
 			dstSubfolderSpec = 7;
 			files = (
-A12DDC001E8373E700CF6CAE /* rendered-image-excluding-overflow.html in Copy Resources */,
-F4538EF71E8473E600B5C953 /* large-red-square.png in Copy Resources */,
-C99BDF891E80980400C7170E /* autoplay-zero-volume-check.html in Copy Resources */,
-A14AAB651E78DC5400C1ADC2 /* encrypted.pdf in Copy Resources */,
-A1409AD91E7254D4004949D9 /* password-protected.pages in Copy Resources */,
-5120C83E1E67678F0025B250 /* WebsiteDataStoreCustomPaths.html in Copy Resources */,
-F4856CA31E649EA8009D7EE7 /* attachment-element.html in Copy Resources */,
-8361F1781E610B4E00759B25 /* link-with-download-attribute-with-slashes.html in Copy Resources */,
-F4FA91831E61857B007B8C1D /* double-click-does-not-select-trailing-space.html in Copy Resources */,
-C25CCA0D1E5141840026CB8A /* AllAhem.svg in Copy Resources */,
-C25CCA0B1E5140C10026CB8A /* LineBreaking.html in Copy Resources */,
-C9C60E651E53A9DC006DA181 /* autoplay-check-frame.html in Copy Resources */,
-C9C60E661E53A9DC006DA181 /* autoplay-check-in-iframe.html in Copy Resources */,
-F47728991E4AE3C1007ABF6A /* full-page-contenteditable.html in Copy Resources */,
-C99B675F1E39736F00FC6C80 /* no-autoplay-with-controls.html in Copy Resources */,
-C99B675D1E39722000FC6C80 /* js-play-with-controls.html in Copy Resources */,
-C99B675C1E39721A00FC6C80 /* autoplay-with-controls.html in Copy Resources */,
-CD321B041E3A85FA00EB21C8 /* video-with-muted-audio-and-webaudio.html in Copy Resources */,
-C95984F71E36BCEF002C0D45 /* test-without-audio-track.mp4 in Copy Resources */,
-C95984F41E36BC6B002C0D45 /* autoplay-check.html in Copy Resources */,
-C95984F51E36BC6B002C0D45 /* autoplay-no-audio-check.html in Copy Resources */,
-

[webkit-changes] [214857] trunk

[mark . lam]

Title: [214857] trunk








Revision 214857
Author mark@apple.com
Date 2017-04-03 17:42:02 -0700 (Mon, 03 Apr 2017)


Log Message
Fix incorrect capacity delta calculation reported in SparseArrayValueMap::add().
https://bugs.webkit.org/show_bug.cgi?id=170412


Reviewed by Filip Pizlo.

JSTests:

* stress/regress-170412.js: Added.

Source/_javascript_Core:

Here's an example of code that will trigger underflow in the "deprecatedExtraMemory"
reported by SparseArrayValueMap::add() that is added to Heap::m_deprecatedExtraMemorySize:

arr = new Array;
Object.defineProperty(arr, 18, ({writable: true, configurable: true}));
for (var i = 0; i < 3; ++i) {
Array.prototype.push.apply(arr, ["", () => {}, {}]);
Array.prototype.sort.apply(arr, [() => {}, []]);
}

However, Heap::m_deprecatedExtraMemorySize is only 1 of 3 values that are added
up to form the result of Heap::extraMemorySize().  Heap::m_extraMemorySize and
Heap::m_arrayBuffers.size() are the other 2.

While Heap::m_arrayBuffers.size() is bounded by actual allocated memory, both
Heap::m_deprecatedExtraMemorySize and Heap::m_extraMemorySize are added to
without any bounds checks, and they are only reset to 0 at the start of a full
GC.  As a result, if we have a long sequence of eden GCs with a lot of additions
to Heap::m_extraMemorySize and/or Heap::m_deprecatedExtraMemorySize, then these
values could theoretically overflow.  Coupling this with the underflow from
SparseArrayValueMap::add(), the result for Heap::extraMemorySize() can easily
overflow.  Note: Heap::extraMemorySize() is used to compute the value
currentHeapSize.

If multiple conditions line up just right, the above overflows can result in this
debug assertion failure during an eden GC:

ASSERT(currentHeapSize >= m_sizeAfterLastCollect);

Otherwise, the effects of the overflows will only result in the computed
currentHeapSize not being representative of actual memory usage, and therefore,
a full GC may be triggered earlier or later than is ideal.

This patch ensures that SparseArrayValueMap::add() cannot underflow
Heap::m_deprecatedExtraMemorySize.  It also adds overflows checks in the
calculations of Heap::m_deprecatedExtraMemorySize, Heap::m_extraMemorySize, and
Heap::extraMemorySize() so that their values are saturated appropriately to
ensure that GC collections are triggered based on representative memory usage.

* heap/Heap.cpp:
(JSC::Heap::deprecatedReportExtraMemorySlowCase):
(JSC::Heap::extraMemorySize):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::reportExtraMemoryVisited):
* runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::add):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/runtime/SparseArrayValueMap.cpp


Added Paths

trunk/JSTests/stress/regress-170412.js




Diff

Modified: trunk/JSTests/ChangeLog (214856 => 214857)

--- trunk/JSTests/ChangeLog	2017-04-04 00:41:19 UTC (rev 214856)
+++ trunk/JSTests/ChangeLog	2017-04-04 00:42:02 UTC (rev 214857)
@@ -1,3 +1,13 @@
+2017-04-03  Mark Lam  
+
+Fix incorrect capacity delta calculation reported in SparseArrayValueMap::add().
+https://bugs.webkit.org/show_bug.cgi?id=170412
+
+
+Reviewed by Filip Pizlo.
+
+* stress/regress-170412.js: Added.
+
 2017-04-03  Keith Miller  
 
 WebAssembly: Update spec tests


Added: trunk/JSTests/stress/regress-170412.js (0 => 214857)

--- trunk/JSTests/stress/regress-170412.js	(rev 0)
+++ trunk/JSTests/stress/regress-170412.js	2017-04-04 00:42:02 UTC (rev 214857)
@@ -0,0 +1,8 @@
+// This test passes if it does not crash.
+
+arr = new Array;
+Object.defineProperty(arr, 18, ({writable: true, configurable: true}));
+for (var i = 0; i < 3; ++i) {
+Array.prototype.push.apply(arr, ["", () => { }, {}]);
+Array.prototype.sort.apply(arr, [edenGC, []]);
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (214856 => 214857)

--- trunk/Source/_javascript_Core/ChangeLog	2017-04-04 00:41:19 UTC (rev 214856)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-04-04 00:42:02 UTC (rev 214857)
@@ -1,3 +1,58 @@
+2017-04-03  Mark Lam  
+
+Fix incorrect capacity delta calculation reported in SparseArrayValueMap::add().
+https://bugs.webkit.org/show_bug.cgi?id=170412
+
+
+Reviewed by Filip Pizlo.
+
+Here's an example of code that will trigger underflow in the "deprecatedExtraMemory"
+reported by SparseArrayValueMap::add() that is added to Heap::m_deprecatedExtraMemorySize:
+
+arr = new Array;
+Object.defineProperty(arr, 18, ({writable: true, configurable: true}));
+for (var i = 0; i < 3; ++i) {
+Array.prototype.push.apply(arr, ["", () => {}, {}]);
+Array.prototype.sort.apply(arr, [() => {}, []]);
+

[webkit-changes] [214855] trunk/Tools

[simon . fraser]

Title: [214855] trunk/Tools








Revision 214855
Author simon.fra...@apple.com
Date 2017-04-03 17:10:33 -0700 (Mon, 03 Apr 2017)


Log Message
Allow MiniBrowser windows to receive local file drags again
https://bugs.webkit.org/show_bug.cgi?id=170422

Reviewed by Wenson Hsieh.

Adopt the new UIDelegate SPI to allow drops.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m




Diff

Modified: trunk/Tools/ChangeLog (214854 => 214855)

--- trunk/Tools/ChangeLog	2017-04-03 23:40:10 UTC (rev 214854)
+++ trunk/Tools/ChangeLog	2017-04-04 00:10:33 UTC (rev 214855)
@@ -1,3 +1,15 @@
+2017-04-03  Simon Fraser  
+
+Allow MiniBrowser windows to receive local file drags again
+https://bugs.webkit.org/show_bug.cgi?id=170422
+
+Reviewed by Wenson Hsieh.
+
+Adopt the new UIDelegate SPI to allow drops.
+
+* MiniBrowser/mac/WK2BrowserWindowController.m:
+(-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
+
 2017-04-03  Carlos Alberto Lopez Perez  
 
 [GTK][JHBuild] Fetch libvpx from a release tarball instead of git


Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (214854 => 214855)

--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m	2017-04-03 23:40:10 UTC (rev 214854)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m	2017-04-04 00:10:33 UTC (rev 214855)
@@ -34,6 +34,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -514,6 +515,11 @@
 }];
 }
 
+- (WKDragDestinationAction)_webView:(WKWebView *)webView dragDestinationActionMaskForDraggingInfo:(id)draggingInfo
+{
+return WKDragDestinationActionAny;
+}
+
 - (void)updateTextFieldFromURL:(NSURL *)URL
 {
 if (!URL)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214854] trunk/Tools

[clopez]

Title: [214854] trunk/Tools








Revision 214854
Author clo...@igalia.com
Date 2017-04-03 16:40:10 -0700 (Mon, 03 Apr 2017)


Log Message
[GTK][JHBuild] Fetch libvpx from a release tarball instead of git
https://bugs.webkit.org/show_bug.cgi?id=170426

Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (214853 => 214854)

--- trunk/Tools/ChangeLog	2017-04-03 23:11:25 UTC (rev 214853)
+++ trunk/Tools/ChangeLog	2017-04-03 23:40:10 UTC (rev 214854)
@@ -1,3 +1,12 @@
+2017-04-03  Carlos Alberto Lopez Perez  
+
+[GTK][JHBuild] Fetch libvpx from a release tarball instead of git
+https://bugs.webkit.org/show_bug.cgi?id=170426
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules:
+
 2017-04-03  Nan Wang  
 
 AX: Expose link children when doing search predication on iOS


Modified: trunk/Tools/gtk/jhbuild.modules (214853 => 214854)

--- trunk/Tools/gtk/jhbuild.modules	2017-04-03 23:11:25 UTC (rev 214853)
+++ trunk/Tools/gtk/jhbuild.modules	2017-04-03 23:40:10 UTC (rev 214854)
@@ -80,6 +80,8 @@
   href=""
  href=""
+   
   
 
@@ -526,8 +528,10 @@
 
autogen-template="%(srcdir)s/configure --prefix=%(prefix)s --enable-pic --as=yasm --disable-unit-tests --size-limit=16384x16384 --enable-postproc --enable-multi-res-encoding --enable-temporal-denoising --enable-vp9-temporal-denoising --enable-vp9-postproc --enable-shared">
-
-
+
   
 







___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214853] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [214853] trunk/Source/WebInspectorUI








Revision 214853
Author nvasil...@apple.com
Date 2017-04-03 16:11:25 -0700 (Mon, 03 Apr 2017)


Log Message
Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
https://bugs.webkit.org/show_bug.cgi?id=169649


Reviewed by Brian Burg.

* UserInterface/Models/WebSocketResource.js:
(WebInspector.WebSocketResource.prototype.addFrame):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (214852 => 214853)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-04-03 23:08:42 UTC (rev 214852)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-04-03 23:11:25 UTC (rev 214853)
@@ -1,3 +1,14 @@
+2017-04-03  Nikita Vasilyev  
+
+Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
+https://bugs.webkit.org/show_bug.cgi?id=169649
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Models/WebSocketResource.js:
+(WebInspector.WebSocketResource.prototype.addFrame):
+
 2017-04-03  Devin Rousso  
 
 Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js (214852 => 214853)

--- trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js	2017-04-03 23:08:42 UTC (rev 214852)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js	2017-04-03 23:11:25 UTC (rev 214853)
@@ -61,7 +61,15 @@
 
 addFrame(data, isOutgoing, opcode, timestamp, elapsedTime)
 {
-let frame = {data, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
+let frameData;
+
+// Binary data is never shown in the UI, don't clog memory with it.
+if (opcode === WebInspector.WebSocketResource.OpCodes.BinaryFrame)
+frameData = null;
+else
+frameData = data;
+
+let frame = {data: frameData, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
 this._frames.push(frame);
 
 this.increaseSize(data.length, elapsedTime);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214852] trunk

[jfernandez]

Title: [214852] trunk








Revision 214852
Author jfernan...@igalia.com
Date 2017-04-03 16:08:42 -0700 (Mon, 03 Apr 2017)


Log Message
[css-align] Adapt place-content alignment shorthand to the new baseline syntax
https://bugs.webkit.org/show_bug.cgi?id=170340

Reviewed by David Hyatt.

Source/WebCore:

Now that the align-content and justify-content CSS properties are
adapted to the new baseline-position CSS values syntax we can adapt the
shorthand that controls such properties to the new syntax as well.

No new tests, just adding some additional cases to the tests we already have.

* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::placeContentPropertyValue):
* css/StyleProperties.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::isContentDistributionKeyword):
(WebCore::isContentPositionKeyword):
(WebCore::isOverflowKeyword):
(WebCore::getBaselineKeyword):
(WebCore::consumeContentDistributionOverflowPosition):
(WebCore::consumeSimplifiedContentPosition):

LayoutTests:

Added additional test cases to evaluate the new baseline-alignment syntax.

* css3/parse-place-content-expected.txt:
* css3/parse-place-content.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/parse-place-content-expected.txt
trunk/LayoutTests/css3/parse-place-content.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (214851 => 214852)

--- trunk/LayoutTests/ChangeLog	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/ChangeLog	2017-04-03 23:08:42 UTC (rev 214852)
@@ -1,3 +1,15 @@
+2017-04-03  Javier Fernandez  
+
+[css-align] Adapt place-content alignment shorthand to the new baseline syntax
+https://bugs.webkit.org/show_bug.cgi?id=170340
+
+Reviewed by David Hyatt.
+
+Added additional test cases to evaluate the new baseline-alignment syntax.
+
+* css3/parse-place-content-expected.txt:
+* css3/parse-place-content.html:
+
 2017-04-03  Nan Wang  
 
 AX: Expose link children when doing search predication on iOS


Modified: trunk/LayoutTests/css3/parse-place-content-expected.txt (214851 => 214852)

--- trunk/LayoutTests/css3/parse-place-content-expected.txt	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/css3/parse-place-content-expected.txt	2017-04-03 23:08:42 UTC (rev 214852)
@@ -3,6 +3,8 @@
 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'normal' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'baseline' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'first baseline' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'last baseline' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'start' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'flex-start' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'end' value through CSS. 
@@ -18,7 +20,7 @@
 PASS Test setting 'start safe' as incorrect value through CSS. 
 PASS Test setting 'baseline safe' as incorrect value through CSS. 
 PASS Test setting 'start end left' as incorrect value through CSS. 
-FAIL Test setting values through JS. assert_equals: placeContent specified value is not what it should. expected "center" but got "center center"
+PASS Test setting values through JS. 
 PASS Test setting incorrect values through JS. 
 PASS Test the 'initial' value of the place-content shorthand and its longhand properties' Computed value 
 PASS Test the 'inherit' value of the place-content shorthand and its longhand properties' Computed value 


Modified: trunk/LayoutTests/css3/parse-place-content.html (214851 => 214852)

--- trunk/LayoutTests/css3/parse-place-content.html	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/css3/parse-place-content.html	2017-04-03 23:08:42 UTC (rev 214852)
@@ -8,6 +8,12 @@
 #placeContentBaseline {
 place-content: baseline;
 }
+#placeContentFirstBaseline {
+place-content: first baseline;
+}
+#placeContentLastBaseline {
+place-content: last baseline;
+}
 #placeContentStart {
 place-content: start;
 }
@@ -63,6 +69,8 @@
 
 
 
+
+
 
 
 
@@ -82,20 +90,30 @@
 

[webkit-changes] [214851] trunk

[n_wang]

Title: [214851] trunk








Revision 214851
Author n_w...@apple.com
Date 2017-04-03 16:06:25 -0700 (Mon, 03 Apr 2017)


Log Message
AX: Expose link children when doing search predication on iOS
https://bugs.webkit.org/show_bug.cgi?id=170424


Source/WebCore:

The children of links are accessible elements on iOS instead of the link itself,
so we should expose the children when doing predicated searches as well.

Reviewed by Chris Fleizach.

Test: accessibility/ios-simulator/ios-search-predicate-link-children.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):

Tools:

Reviewed by Chris Fleizach.

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests:

Reviewed by Chris Fleizach.

* accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt: Added.
* accessibility/ios-simulator/ios-search-predicate-link-children.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm


Added Paths

trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children.html




Diff

Modified: trunk/LayoutTests/ChangeLog (214850 => 214851)

--- trunk/LayoutTests/ChangeLog	2017-04-03 23:04:40 UTC (rev 214850)
+++ trunk/LayoutTests/ChangeLog	2017-04-03 23:06:25 UTC (rev 214851)
@@ -1,3 +1,14 @@
+2017-04-03  Nan Wang  
+
+AX: Expose link children when doing search predication on iOS
+https://bugs.webkit.org/show_bug.cgi?id=170424
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt: Added.
+* accessibility/ios-simulator/ios-search-predicate-link-children.html: Added.
+
 2017-04-03  Dave Hyatt  
 
 Japanese fonts in vertical text should support synthesized italics


Added: trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt (0 => 214851)

--- trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt	2017-04-03 23:06:25 UTC (rev 214851)
@@ -0,0 +1,22 @@
+start text
+
+heading text
+
+sub text
+start text 2
+
+link2 text link3
+This tests the ability to search for exposed link children.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS resultElement.description is 'AXLabel: heading text'
+PASS resultElement.description is 'AXLabel: sub text'
+PASS resultElement.description is 'AXLabel: heading text'
+PASS resultElement.description is 'AXLabel: link2 text'
+PASS resultElement.description is 'AXLabel: link3'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children.html (0 => 214851)

--- trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children.html	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/ios-search-predicate-link-children.html	2017-04-03 23:06:25 UTC (rev 214851)
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
start text
+
+
heading text
+
sub text
+
+
+
start text 2
+
+link2
+ text
+
+

+

+
+