[webkit-changes] [219676] trunk/Source

[zandobersek]

Title: [219676] trunk/Source








Revision 219676
Author zandober...@gmail.com
Date 2017-07-19 22:57:35 -0700 (Wed, 19 Jul 2017)


Log Message
[CMake] Clean up Web Crypto build targets
https://bugs.webkit.org/show_bug.cgi?id=174253

Reviewed by Alex Christensen.

Gather the common WebCrypto source files in CMakeLists.txt, including them
in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
build guards to exclude the code from compilation if the feature is disabled.

PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
Web Crypto build targets.

PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
though as they by default leverage a libgcrypt-based CrpytoDigest implementation
in the PAL library.

The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
the build and also sets up libgcrypt include directiories and libraries.

No new tests -- no change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* platform/GCrypt.cmake: Added.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebCore/PlatformWPE.cmake
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake


Added Paths

trunk/Source/WebCore/platform/GCrypt.cmake




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (219675 => 219676)

--- trunk/Source/WebCore/CMakeLists.txt	2017-07-20 05:46:30 UTC (rev 219675)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-07-20 05:57:35 UTC (rev 219676)
@@ -1293,6 +1293,41 @@
 contentextensions/NFAToDFA.cpp
 contentextensions/URLFilterParser.cpp
 
+crypto/CryptoAlgorithm.cpp
+crypto/CryptoAlgorithmRegistry.cpp
+crypto/CryptoKey.cpp
+crypto/SubtleCrypto.cpp
+crypto/WebKitSubtleCrypto.cpp
+
+crypto/algorithms/CryptoAlgorithmAES_CBC.cpp
+crypto/algorithms/CryptoAlgorithmAES_CFB.cpp
+crypto/algorithms/CryptoAlgorithmAES_CTR.cpp
+crypto/algorithms/CryptoAlgorithmAES_GCM.cpp
+crypto/algorithms/CryptoAlgorithmAES_KW.cpp
+crypto/algorithms/CryptoAlgorithmECDH.cpp
+crypto/algorithms/CryptoAlgorithmECDSA.cpp
+crypto/algorithms/CryptoAlgorithmHKDF.cpp
+crypto/algorithms/CryptoAlgorithmHMAC.cpp
+crypto/algorithms/CryptoAlgorithmPBKDF2.cpp
+crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp
+crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp
+crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp
+crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp
+crypto/algorithms/CryptoAlgorithmSHA1.cpp
+crypto/algorithms/CryptoAlgorithmSHA224.cpp
+crypto/algorithms/CryptoAlgorithmSHA256.cpp
+crypto/algorithms/CryptoAlgorithmSHA384.cpp
+crypto/algorithms/CryptoAlgorithmSHA512.cpp
+
+crypto/keys/CryptoKeyAES.cpp
+crypto/keys/CryptoKeyDataOctetSequence.cpp
+crypto/keys/CryptoKeyDataRSAComponents.cpp
+crypto/keys/CryptoKeyEC.cpp
+crypto/keys/CryptoKeyHMAC.cpp
+crypto/keys/CryptoKeyRSA.cpp
+crypto/keys/CryptoKeyRaw.cpp
+crypto/keys/CryptoKeySerializationRaw.cpp
+
 css/BasicShapeFunctions.cpp
 css/CSSAspectRatioValue.cpp
 css/CSSBasicShapes.cpp


Modified: trunk/Source/WebCore/ChangeLog (219675 => 219676)

--- trunk/Source/WebCore/ChangeLog	2017-07-20 05:46:30 UTC (rev 219675)
+++ trunk/Source/WebCore/ChangeLog	2017-07-20 05:57:35 UTC (rev 219676)
@@ -1,3 +1,34 @@
+2017-07-19  Zan Dobersek  
+
+[CMake] Clean up Web Crypto build targets
+https://bugs.webkit.org/show_bug.cgi?id=174253
+
+Reviewed by Alex Christensen.
+
+Gather the common WebCrypto source files in CMakeLists.txt, including them
+in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
+build guards to exclude the code from compilation if the feature is disabled.
+
+PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
+duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
+Web Crypto build targets.
+
+PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
+USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
+though as they by default leverage a libgcrypt-based CrpytoDigest implementation
+in the PAL library.
+
+The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
+the build and also sets up libgcrypt include directiories and libraries.
+
+No new tests -- no change in behavior.
+
+* CMakeLists.txt:
+* PlatformGTK.cmake:
+* PlatformMac.cmake:
+* PlatformWPE.cmake:
+* platform/GCrypt.cmake: Added.
+
 2017-07-19  

[webkit-changes] [219675] trunk/Source/WebCore

[commit-queue]

Title: [219675] trunk/Source/WebCore








Revision 219675
Author commit-qu...@webkit.org
Date 2017-07-19 22:46:30 -0700 (Wed, 19 Jul 2017)


Log Message
[WebIDL] Remove custom bindings for CommandLineAPIHost
https://bugs.webkit.org/show_bug.cgi?id=174642

Patch by Sam Weinig  on 2017-07-19
Reviewed by Joseph Pecoraro.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.
Remove JSCommandLineAPIHostCustom.cpp.

* bindings/js/JSDOMConvertObject.h:
(WebCore::JSConverter::convert):
Add missing JSConverter specialization for IDLObject.

* inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::inspect):
(WebCore::listenerEntriesFromListenerInfo):
(WebCore::CommandLineAPIHost::inspectedObject):
(WebCore::CommandLineAPIHost::databaseId):
(WebCore::CommandLineAPIHost::storageId):
(WebCore::CommandLineAPIHost::inspectImpl): Deleted.
(WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
(WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
(WebCore::CommandLineAPIHost::storageIdImpl): Deleted.
* inspector/CommandLineAPIHost.h:
* inspector/CommandLineAPIHost.idl:
Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSDOMConvertObject.h
trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp
trunk/Source/WebCore/inspector/CommandLineAPIHost.h
trunk/Source/WebCore/inspector/CommandLineAPIHost.idl


Removed Paths

trunk/Source/WebCore/bindings/js/JSCommandLineAPIHostCustom.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (219674 => 219675)

--- trunk/Source/WebCore/CMakeLists.txt	2017-07-20 05:43:11 UTC (rev 219674)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-07-20 05:46:30 UTC (rev 219675)
@@ -1155,7 +1155,6 @@
 bindings/js/JSFontFaceSetCustom.cpp
 bindings/js/JSCallbackData.cpp
 bindings/js/JSCanvasRenderingContext2DCustom.cpp
-bindings/js/JSCommandLineAPIHostCustom.cpp
 bindings/js/JSCryptoAlgorithmBuilder.cpp
 bindings/js/JSCryptoAlgorithmDictionary.cpp
 bindings/js/JSCryptoKeyCustom.cpp


Modified: trunk/Source/WebCore/ChangeLog (219674 => 219675)

--- trunk/Source/WebCore/ChangeLog	2017-07-20 05:43:11 UTC (rev 219674)
+++ trunk/Source/WebCore/ChangeLog	2017-07-20 05:46:30 UTC (rev 219675)
@@ -1,3 +1,34 @@
+2017-07-19  Sam Weinig  
+
+[WebIDL] Remove custom bindings for CommandLineAPIHost
+https://bugs.webkit.org/show_bug.cgi?id=174642
+
+Reviewed by Joseph Pecoraro.
+
+* CMakeLists.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSBindingsAllInOne.cpp:
+* bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.
+Remove JSCommandLineAPIHostCustom.cpp.
+
+* bindings/js/JSDOMConvertObject.h:
+(WebCore::JSConverter::convert):
+Add missing JSConverter specialization for IDLObject.
+
+* inspector/CommandLineAPIHost.cpp:
+(WebCore::CommandLineAPIHost::inspect):
+(WebCore::listenerEntriesFromListenerInfo):
+(WebCore::CommandLineAPIHost::inspectedObject):
+(WebCore::CommandLineAPIHost::databaseId):
+(WebCore::CommandLineAPIHost::storageId):
+(WebCore::CommandLineAPIHost::inspectImpl): Deleted.
+(WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
+(WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
+(WebCore::CommandLineAPIHost::storageIdImpl): Deleted.
+* inspector/CommandLineAPIHost.h:
+* inspector/CommandLineAPIHost.idl:
+Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.
+
 2017-07-19  Zan Dobersek  
 
 Unreviewed CoordGraphics build fix.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (219674 => 219675)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-07-20 05:43:11 UTC (rev 219674)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-07-20 05:46:30 UTC (rev 219675)
@@ -4408,7 +4408,6 @@
 		A584FE301864CB8400843B10 /* WebInjectedScriptManager.h in Headers */ = {isa = PBXBuildFile; fileRef = A584FE2E1864CB8400843B10 /* WebInjectedScriptManager.h */; };
 		A584FE341864D5AF00843B10 /* CommandLineAPIHost.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A584FE311864D5AF00843B10 /* CommandLineAPIHost.cpp */; };
 		A584FE351864D5AF00843B10 /* CommandLineAPIHost.h in Headers */ = {isa = PBXBuildFile; fileRef = A584FE321864D5AF00843B10 /* CommandLineAPIHost.h */; };
-		A584FE381864DAC100843B10 /* JSCommandLineAPIHostCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A584FE371864DAC100843B10 /* JSCommandLineAPIHostCustom.cpp */; };
 		

[webkit-changes] [219674] trunk/Source/WebCore

[zandobersek]

Title: [219674] trunk/Source/WebCore








Revision 219674
Author zandober...@gmail.com
Date 2017-07-19 22:43:11 -0700 (Wed, 19 Jul 2017)


Log Message
Unreviewed CoordGraphics build fix.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
the ScrollingStateNode's LayerRepresentation.
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (219673 => 219674)

--- trunk/Source/WebCore/ChangeLog	2017-07-20 05:23:48 UTC (rev 219673)
+++ trunk/Source/WebCore/ChangeLog	2017-07-20 05:43:11 UTC (rev 219674)
@@ -1,3 +1,14 @@
+2017-07-19  Zan Dobersek  
+
+Unreviewed CoordGraphics build fix.
+
+* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
+(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
+This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
+Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
+the ScrollingStateNode's LayerRepresentation.
+(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.
+
 2017-07-19  Chris Dumez  
 
 Drop SQLException type


Modified: trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp (219673 => 219674)

--- trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp	2017-07-20 05:23:48 UTC (rev 219673)
+++ trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp	2017-07-20 05:43:11 UTC (rev 219674)
@@ -24,11 +24,11 @@
  */
 
 #include "config.h"
+#include "ScrollingCoordinatorCoordinatedGraphics.h"
 
 #if USE(COORDINATED_GRAPHICS)
 
-#include "ScrollingCoordinatorCoordinatedGraphics.h"
-
+#include "AsyncScrollingCoordinator.h"
 #include "CoordinatedGraphicsLayer.h"
 #include "FrameView.h"
 #include "HostWindow.h"
@@ -81,7 +81,7 @@
 node->setLayer(graphicsLayer);
 }
 
-void AsyncScrollingCoordinator::updateNodeViewportConstraints(ScrollingNodeID nodeID, const ViewportConstraints& constraints)
+void ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints(ScrollingNodeID nodeID, const ViewportConstraints& constraints)
 {
 ScrollingStateNode* node = m_scrollingStateTree->stateNodeForID(nodeID);
 if (!node)
@@ -89,7 +89,9 @@
 
 switch (constraints.constraintType()) {
 case ViewportConstraints::FixedPositionConstraint: {
-downcast(*graphicsLayer).setFixedToViewport(true);
+auto& layer = node->layer();
+if (layer.representsGraphicsLayer())
+downcast(static_cast(layer))->setFixedToViewport(true);
 break;
 }
 case ViewportConstraints::StickyPositionConstraint:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219673] trunk/Source

[cdumez]

Title: [219673] trunk/Source








Revision 219673
Author cdu...@apple.com
Date 2017-07-19 22:23:48 -0700 (Wed, 19 Jul 2017)


Log Message
Drop SQLException type
https://bugs.webkit.org/show_bug.cgi?id=174665

Reviewed by Sam Weinig.

Source/WebCore:

Drop SQLException type. We never throw such exception. Also, Firefox
and Chrome no longer expose this type.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Modules/webdatabase/SQLException.cpp: Removed.
* Modules/webdatabase/SQLException.h: Removed.
* Modules/webdatabase/SQLException.idl: Removed.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::createDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* dom/DOMExceptions.in:

Source/WebInspectorUI:

Use SQLError instead of SQLException, this is what the script should really
use here since it is checking the code of an SQLError.

* .eslintrc:
* UserInterface/Models/DatabaseObject.js:
(WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
(WebInspector.DatabaseObject.prototype.executeSQL):
(WebInspector.DatabaseObject):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp
trunk/Source/WebCore/bindings/js/JSExceptionBase.cpp
trunk/Source/WebCore/dom/DOMExceptions.in
trunk/Source/WebInspectorUI/.eslintrc
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js


Removed Paths

trunk/Source/WebCore/Modules/webdatabase/SQLException.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLException.h
trunk/Source/WebCore/Modules/webdatabase/SQLException.idl




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (219672 => 219673)

--- trunk/Source/WebCore/CMakeLists.txt	2017-07-20 03:49:58 UTC (rev 219672)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-07-20 05:23:48 UTC (rev 219673)
@@ -330,7 +330,6 @@
 Modules/webdatabase/Database.idl
 Modules/webdatabase/DatabaseCallback.idl
 Modules/webdatabase/SQLError.idl
-Modules/webdatabase/SQLException.idl
 Modules/webdatabase/SQLResultSet.idl
 Modules/webdatabase/SQLResultSetRowList.idl
 Modules/webdatabase/SQLStatementCallback.idl
@@ -1069,7 +1068,6 @@
 Modules/webdatabase/DatabaseThread.cpp
 Modules/webdatabase/DatabaseTracker.cpp
 Modules/webdatabase/OriginLock.cpp
-Modules/webdatabase/SQLException.cpp
 Modules/webdatabase/SQLResultSet.cpp
 Modules/webdatabase/SQLResultSetRowList.cpp
 Modules/webdatabase/SQLStatement.cpp


Modified: trunk/Source/WebCore/ChangeLog (219672 => 219673)

--- trunk/Source/WebCore/ChangeLog	2017-07-20 03:49:58 UTC (rev 219672)
+++ trunk/Source/WebCore/ChangeLog	2017-07-20 05:23:48 UTC (rev 219673)
@@ -1,3 +1,26 @@
+2017-07-19  Chris Dumez  
+
+Drop SQLException type
+https://bugs.webkit.org/show_bug.cgi?id=174665
+
+Reviewed by Sam Weinig.
+
+Drop SQLException type. We never throw such exception. Also, Firefox
+and Chrome no longer expose this type.
+
+* CMakeLists.txt:
+* DerivedSources.cpp:
+* DerivedSources.make:
+* Modules/webdatabase/SQLException.cpp: Removed.
+* Modules/webdatabase/SQLException.h: Removed.
+* Modules/webdatabase/SQLException.idl: Removed.
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSDOMExceptionHandling.cpp:
+(WebCore::createDOMException):
+* bindings/js/JSExceptionBase.cpp:
+(WebCore::toExceptionBase):
+* dom/DOMExceptions.in:
+
 2017-07-19  Wenson Hsieh  
 
 Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.


Modified: trunk/Source/WebCore/DerivedSources.cpp (219672 => 219673)

--- trunk/Source/WebCore/DerivedSources.cpp	2017-07-20 03:49:58 UTC (rev 219672)
+++ trunk/Source/WebCore/DerivedSources.cpp	2017-07-20 05:23:48 UTC (rev 219673)
@@ -406,7 +406,6 @@
 #include "JSSpeechSynthesisUtterance.cpp"
 #include "JSSpeechSynthesisVoice.cpp"
 #include "JSSQLError.cpp"
-#include "JSSQLException.cpp"
 #include "JSSQLResultSet.cpp"
 #include "JSSQLResultSetRowList.cpp"
 #include "JSSQLStatementCallback.cpp"


Modified: trunk/Source/WebCore/DerivedSources.make (219672 => 219673)

--- trunk/Source/WebCore/DerivedSources.make	2017-07-20 03:49:58 UTC (rev 219672)
+++ trunk/Source/WebCore/DerivedSources.make	2017-07-20 05:23:48 UTC (rev 219673)
@@ -267,7 +267,6 @@
 $(WebCore)/Modules/webdatabase/Database.idl \
 $(WebCore)/Modules/webdatabase/DatabaseCallback.idl \
 $(WebCore)/Modules/webdatabase/SQLError.idl \
-$(WebCore)/Modules/webdatabase/SQLException.idl \
 $(WebCore)/Modules/webdatabase/SQLResultSet.idl \
 

[webkit-changes] [219672] releases/Apple

[mitz]

Title: [219672] releases/Apple








Revision 219672
Author m...@apple.com
Date 2017-07-19 20:49:58 -0700 (Wed, 19 Jul 2017)


Log Message
Added a tag for iOS 10.3.3.

Added Paths

releases/Apple/iOS 10.3.3/
releases/Apple/iOS 10.3.3/ANGLE/
releases/Apple/iOS 10.3.3/_javascript_Core/
releases/Apple/iOS 10.3.3/WTF/
releases/Apple/iOS 10.3.3/WebCore/
releases/Apple/iOS 10.3.3/WebKit/
releases/Apple/iOS 10.3.3/WebKit2/
releases/Apple/iOS 10.3.3/bmalloc/




Diff
Index: releases/Apple/iOS 10.3.3/ANGLE
===
--- tags/Safari-603.3.8/Source/ThirdParty/ANGLE	2017-07-20 03:49:56 UTC (rev 219671)
+++ releases/Apple/iOS 10.3.3/ANGLE	2017-07-20 03:49:58 UTC (rev 219672)

Property changes: releases/Apple/iOS 10.3.3/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/iOS 10.3.3/_javascript_Core
===
--- tags/Safari-603.3.8/Source/_javascript_Core	2017-07-20 03:49:56 UTC (rev 219671)
+++ releases/Apple/iOS 10.3.3/_javascript_Core	2017-07-20 03:49:58 UTC (rev 219672)

Property changes: releases/Apple/iOS 10.3.3/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/iOS 10.3.3/WTF
===
--- tags/Safari-603.3.8/Source/WTF	2017-07-20 03:49:56 UTC (rev 219671)
+++ releases/Apple/iOS 10.3.3/WTF	2017-07-20 03:49:58 UTC (rev 219672)

Property changes: releases/Apple/iOS 10.3.3/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/iOS 10.3.3/WebKit2
===
--- tags/Safari-603.3.8/Source/WebKit2	2017-07-20 03:49:56 UTC (rev 219671)
+++ releases/Apple/iOS 10.3.3/WebKit2	2017-07-20 03:49:58 UTC (rev 219672)

Property changes: releases/Apple/iOS 10.3.3/WebKit2



Added: svn:mergeinfo
+/trunk/Source/WebKit2:53455
\ No newline at end of property
Index: releases/Apple/iOS 10.3.3/bmalloc
===
--- tags/Safari-603.3.8/Source/bmalloc	2017-07-20 03:49:56 UTC (rev 219671)
+++ releases/Apple/iOS 10.3.3/bmalloc	2017-07-20 03:49:58 UTC (rev 219672)

Property changes: releases/Apple/iOS 10.3.3/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219671] releases/Apple

[mitz]

Title: [219671] releases/Apple








Revision 219671
Author m...@apple.com
Date 2017-07-19 20:49:56 -0700 (Wed, 19 Jul 2017)


Log Message
Added a tag for Safari 10.1.2.

Added Paths

releases/Apple/Safari 10.1.2/
releases/Apple/Safari 10.1.2/ANGLE/
releases/Apple/Safari 10.1.2/_javascript_Core/
releases/Apple/Safari 10.1.2/WTF/
releases/Apple/Safari 10.1.2/WebCore/
releases/Apple/Safari 10.1.2/WebInspectorUI/
releases/Apple/Safari 10.1.2/WebKit/
releases/Apple/Safari 10.1.2/WebKit2/
releases/Apple/Safari 10.1.2/bmalloc/




Diff
Index: releases/Apple/Safari 10.1.2/ANGLE
===
--- tags/Safari-603.3.8/Source/ThirdParty/ANGLE	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/ANGLE	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari 10.1.2/_javascript_Core
===
--- tags/Safari-603.3.8/Source/_javascript_Core	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/_javascript_Core	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari 10.1.2/WTF
===
--- tags/Safari-603.3.8/Source/WTF	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/WTF	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari 10.1.2/WebInspectorUI
===
--- tags/Safari-603.3.8/Source/WebInspectorUI	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/WebInspectorUI	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari 10.1.2/WebKit2
===
--- tags/Safari-603.3.8/Source/WebKit2	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/WebKit2	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/WebKit2



Added: svn:mergeinfo
+/trunk/Source/WebKit2:53455
\ No newline at end of property
Index: releases/Apple/Safari 10.1.2/bmalloc
===
--- tags/Safari-603.3.8/Source/bmalloc	2017-07-20 02:14:29 UTC (rev 219670)
+++ releases/Apple/Safari 10.1.2/bmalloc	2017-07-20 03:49:56 UTC (rev 219671)

Property changes: releases/Apple/Safari 10.1.2/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219670] trunk/Source/WebCore

[wenson_hsieh]

Title: [219670] trunk/Source/WebCore








Revision 219670
Author wenson_hs...@apple.com
Date 2017-07-19 19:14:29 -0700 (Wed, 19 Jul 2017)


Log Message
Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.

The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).

* editing/Editor.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (219669 => 219670)

--- trunk/Source/WebCore/ChangeLog	2017-07-20 00:17:40 UTC (rev 219669)
+++ trunk/Source/WebCore/ChangeLog	2017-07-20 02:14:29 UTC (rev 219670)
@@ -1,3 +1,12 @@
+2017-07-19  Wenson Hsieh  
+
+Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.
+
+The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
+to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).
+
+* editing/Editor.h:
+
 2017-07-19  Simon Fraser  
 
 getBoundingClientRects not updated for programmatic scrolls


Modified: trunk/Source/WebCore/editing/Editor.h (219669 => 219670)

--- trunk/Source/WebCore/editing/Editor.h	2017-07-20 00:17:40 UTC (rev 219669)
+++ trunk/Source/WebCore/editing/Editor.h	2017-07-20 02:14:29 UTC (rev 219670)
@@ -109,7 +109,7 @@
 // Scroll to reveal the selection.
 TemporarySelectionOptionRevealSelection = 1 << 0,
 
-// Don't propagate selection changes to the UI process.
+// Don't propagate selection changes to the client layer.
 TemporarySelectionOptionIgnoreSelectionChanges = 1 << 1,
 
 // Force the render tree to update selection state. Only respected on iOS.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219669] trunk/Tools

[jbedard]

Title: [219669] trunk/Tools








Revision 219669
Author jbed...@apple.com
Date 2017-07-19 17:17:40 -0700 (Wed, 19 Jul 2017)


Log Message
lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559


Reviewed by Daniel Bates.

Follow up fix addressing style and a few minor bugs.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.__init__): Use lambda x: x instead of str
(TestExpectationsModel.__init__): Make lambda x: x the default argument.
(TestExpectationsModel._already_seen_better_match): Use a temporary variable to
reduce the calls of _shorten_filename, fix minor bug in appending the current
expectation's line number instead of the previous ones, clarify treatment of None
in file-to-line-number mapping.
(TestExpectations._report_warnings): Collapse call.
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.lint_test_expectations):
* Scripts/webkitpy/style/filereader.py: Re-write comment.
(TextFileReader.process_file): Add comment explaining treatment of None in
file-to-line-number mapping.
(TextFileReader.delete_file): Collapse call.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
trunk/Tools/Scripts/webkitpy/style/filereader.py




Diff

Modified: trunk/Tools/ChangeLog (219668 => 219669)

--- trunk/Tools/ChangeLog	2017-07-20 00:15:08 UTC (rev 219668)
+++ trunk/Tools/ChangeLog	2017-07-20 00:17:40 UTC (rev 219669)
@@ -1,3 +1,28 @@
+2017-07-19  Jonathan Bedard  
+
+lint-test-expectations should be run during style checking
+https://bugs.webkit.org/show_bug.cgi?id=173559
+
+
+Reviewed by Daniel Bates.
+
+Follow up fix addressing style and a few minor bugs.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py:
+(TestExpectationParser.__init__): Use lambda x: x instead of str
+(TestExpectationsModel.__init__): Make lambda x: x the default argument.
+(TestExpectationsModel._already_seen_better_match): Use a temporary variable to
+reduce the calls of _shorten_filename, fix minor bug in appending the current
+expectation's line number instead of the previous ones, clarify treatment of None
+in file-to-line-number mapping.
+(TestExpectations._report_warnings): Collapse call.
+* Scripts/webkitpy/style/checkers/test_expectations.py:
+(TestExpectationsChecker.lint_test_expectations):
+* Scripts/webkitpy/style/filereader.py: Re-write comment.
+(TextFileReader.process_file): Add comment explaining treatment of None in
+file-to-line-number mapping.
+(TextFileReader.delete_file): Collapse call.
+
 2017-07-19  Chris Dumez  
 
 Unreviewed attempt to fix API test failure after r219663.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (219668 => 219669)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2017-07-20 00:15:08 UTC (rev 219668)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2017-07-20 00:17:40 UTC (rev 219669)
@@ -92,7 +92,7 @@
 
 MISSING_BUG_WARNING = 'Test lacks BUG modifier.'
 
-def __init__(self, port, full_test_list, allow_rebaseline_modifier, shorten_filename=str):
+def __init__(self, port, full_test_list, allow_rebaseline_modifier, shorten_filename=lambda x: x):
 self._port = port
 self._test_configuration_converter = TestConfigurationConverter(set(port.all_test_configurations()), port.configuration_specifier_macros())
 if full_test_list is None:
@@ -512,7 +512,7 @@
 class TestExpectationsModel(object):
 """Represents relational store of all expectations and provides CRUD semantics to manage it."""
 
-def __init__(self, shorten_filename=None):
+def __init__(self, shorten_filename=lambda x: x):
 # Maps a test to its list of expectations.
 self._test_to_expectations = {}
 
@@ -527,7 +527,7 @@
 self._timeline_to_tests = self._dict_of_sets(TestExpectations.TIMELINES)
 self._result_type_to_tests = self._dict_of_sets(TestExpectations.RESULT_TYPES)
 
-self._shorten_filename = shorten_filename or (lambda x: x)
+self._shorten_filename = shorten_filename
 
 def _dict_of_sets(self, strings_to_constants):
 """Takes a dict of strings->constants and returns a dict mapping
@@ -714,39 +714,40 @@
 #
 # To use the "more modifiers wins" policy, change the errors for overrides
 # to be warnings and return False".
+shortened_expectation_filename = self._shorten_filename(expectation_line.filename)
+shortened_previous_expectation_filename = self._shorten_filename(prev_expectation_line.filename)
 
 if prev_expectation_line.matching_configurations == 

[webkit-changes] [219668] trunk

[simon . fraser]

Title: [219668] trunk








Revision 219668
Author simon.fra...@apple.com
Date 2017-07-19 17:15:08 -0700 (Wed, 19 Jul 2017)


Log Message
getBoundingClientRects not updated for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=174538
rdar://problem/33049012

Reviewed by Tim Horton.
Source/WebCore:

Baidu.com has two event handlers on its , and both query the input location with getBoundingClientRect()
and the current pageYOffset (via jQuery), then try to scroll the input to the top of the screen. The bug is that
programmatic scrolls did not immediately update the layout viewport rect, so the second call to
getBoundingClientRect() would return stale coordinates, triggering an extra scroll.

To fix this, undo the fix for r219320 which tried to keep getBoundingClientRect() current during unstable scroll
updates by adding a shadow layout viewport rect. Instead, almost always update the layout viewport rect on
FrameView, even during unstable visible rect updates, but not if content insets are being changed interactively,
since changing viewport heights cause problems with bottom-fixed elements. Also, we need to compute a new layout
viewport rect in FrameView::updateLayoutViewport() for programmatic scrolls.

However, always updating the layout viewport triggered issues with the scrolling tree. The scrolling state tree
fossilizes layer positions relative to a specific viewport rect, and that relationship has to be maintained.
There are code paths that recompute fixed/sticky viewport constraints when the layout viewport has changed but
we haven't done layout or recomputed layer positions (e.g. updating viewport-constrained layers via
updateScrollCoordinatedLayersAfterFlush()) and in these cases using a new layout viewport for those computations
results in an inconsistent scrolling tree.

Fix this by not updating scrolling constraints every time we have to re-register scrolling nodes.
updateScrollCoordinatedLayersAfterFlush() only needs to update the layer on the scrolling node (to handle
tiled/non-tiled switches), so make updateScrollCoordinatedLayer() a little more fine-grained, and only update
constraints when we've just computed layer geometry. This allows for different scrolling nodes to have
constraints computed at different times, with different layout viewports, which happens.

Two additional fixes were required to make bottom-fixed bars behave correctly.

First, FrameView::computeLayoutViewportOrigin() had a bug where rounding of half-pixel values would cause it to
fall into the if (visualViewport.height() > layoutViewport.height()) clause, but then fail to clamp for
rubber-banding.

Second, the FrameView::unscaledMaximumScrollPosition() was wrong after zooming on iOS, since it uses visibleSize()
which is affected by page scale on iOS only (and the function wants scale-independent values). Fix with a hack that
should be cleaned up via webkit.org/b/174648.

Tested by existing tests.

* page/FrameView.cpp:
(WebCore::FrameView::computeUpdatedLayoutViewportRect):
(WebCore::FrameView::computeLayoutViewportOrigin):
(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::unscaledMaximumScrollPosition):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::setUnstableLayoutViewportRect): Deleted.
* page/FrameView.h:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
(WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions):
(WebCore::AsyncScrollingCoordinator::updateNodeLayer):
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode): Deleted.
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::operator<<):
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::reconcileScrollingState):
(WebCore::ScrollingCoordinator::updateNodeLayer):
(WebCore::ScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode): Deleted.
* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::updateConstraints):
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitTreeState):
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* rendering/RenderLayerCompositor.cpp:

[webkit-changes] [219667] trunk/Tools

[cdumez]

Title: [219667] trunk/Tools








Revision 219667
Author cdu...@apple.com
Date 2017-07-19 16:59:22 -0700 (Wed, 19 Jul 2017)


Log Message
Unreviewed attempt to fix API test failure after r219663.

The test was hard-coding an exception string and the string has changed slightly
in r219663.

* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm




Diff

Modified: trunk/Tools/ChangeLog (219666 => 219667)

--- trunk/Tools/ChangeLog	2017-07-19 23:57:38 UTC (rev 219666)
+++ trunk/Tools/ChangeLog	2017-07-19 23:59:22 UTC (rev 219667)
@@ -1,3 +1,13 @@
+2017-07-19  Chris Dumez  
+
+Unreviewed attempt to fix API test failure after r219663.
+
+The test was hard-coding an exception string and the string has changed slightly
+in r219663.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
+(TEST):
+
 2017-07-19  Megan Gardner  
 
 Don't write file URLs to iOS Pasteboard


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm (219666 => 219667)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm	2017-07-19 23:57:38 UTC (rev 219666)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm	2017-07-19 23:59:22 UTC (rev 219667)
@@ -115,7 +115,7 @@
 // We expect 4 messages, 1 each for WebSQL, IndexedDB, cookies, and localStorage.
 EXPECT_STREQ([getNextMessage().body UTF8String], "localstorage written");
 EXPECT_STREQ([getNextMessage().body UTF8String], "cookie written");
-EXPECT_STREQ([getNextMessage().body UTF8String], "Exception: QuotaExceededError (DOM Exception 22): The quota has been exceeded.");
+EXPECT_STREQ([getNextMessage().body UTF8String], "Exception: QuotaExceededError: The quota has been exceeded.");
 EXPECT_STREQ([getNextMessage().body UTF8String], "Success opening indexed database");
 
 [[[webView configuration] processPool] _syncNetworkProcessCookies];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219666] trunk

[megan_gardner]

Title: [219666] trunk








Revision 219666
Author megan_gard...@apple.com
Date 2017-07-19 16:57:38 -0700 (Wed, 19 Jul 2017)


Log Message
Don't write file URLs to iOS Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=174647


Reviewed by Wenson Hsieh.

Source/WebCore:

Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard):
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):

Tools:

Updating tests to reflect the lack of file URLs for images.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkTypeIdentifierAndIsNotOtherTypeIdentifier):
(checkEstimatedSize):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ios/EditorIOS.mm
trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (219665 => 219666)

--- trunk/Source/WebCore/ChangeLog	2017-07-19 23:38:06 UTC (rev 219665)
+++ trunk/Source/WebCore/ChangeLog	2017-07-19 23:57:38 UTC (rev 219666)
@@ -1,3 +1,18 @@
+2017-07-19  Megan Gardner  
+
+Don't write file URLs to iOS Pasteboard
+https://bugs.webkit.org/show_bug.cgi?id=174647
+
+
+Reviewed by Wenson Hsieh.
+
+Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.
+
+* editing/ios/EditorIOS.mm:
+(WebCore::Editor::writeImageToPasteboard):
+* platform/ios/PlatformPasteboardIOS.mm:
+(WebCore::PlatformPasteboard::write):
+
 2017-07-19  Myles C. Maxfield  
 
 Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap


Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (219665 => 219666)

--- trunk/Source/WebCore/editing/ios/EditorIOS.mm	2017-07-19 23:38:06 UTC (rev 219665)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm	2017-07-19 23:57:38 UTC (rev 219666)
@@ -207,8 +207,12 @@
 ASSERT(cachedImage);
 
 auto imageSourceURL = imageElement.document().completeURL(stripLeadingAndTrailingHTMLSpaces(imageElement.imageSourceURL()));
-pasteboardImage.url.url = "" ? imageSourceURL : url;
-pasteboardImage.url.title = title;
+
+auto pasteboardImageURL = url.isEmpty() ? imageSourceURL : url;
+if (!pasteboardImageURL.isLocalFile()) {
+pasteboardImage.url.url = ""
+pasteboardImage.url.title = title;
+}
 pasteboardImage.suggestedName = imageSourceURL.lastPathComponent();
 pasteboardImage.imageSize = image->size();
 pasteboardImage.resourceMIMEType = pasteboard.resourceMIMEType(cachedImage->response().mimeType());


Modified: trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm (219665 => 219666)

--- trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm	2017-07-19 23:38:06 UTC (rev 219665)
+++ trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm	2017-07-19 23:57:38 UTC (rev 219666)
@@ -325,7 +325,8 @@
 RetainPtr representations = adoptNS([[NSMutableDictionary alloc] init]);
 if (!pasteboardImage.resourceMIMEType.isNull()) {
 [representations setObject:pasteboardImage.resourceData->createNSData().get() forKey:pasteboardImage.resourceMIMEType];
-[representations setObject:(NSURL *)pasteboardImage.url.url forKey:(NSString *)kUTTypeURL];
+if (!pasteboardImage.url.url.isNull())
+[representations setObject:(NSURL *)pasteboardImage.url.url forKey:(NSString *)kUTTypeURL];
 }
 
 // Explicitly cast m_pasteboard to UIPasteboard * to work around rdar://problem/33383354.


Modified: trunk/Tools/ChangeLog (219665 => 219666)

--- trunk/Tools/ChangeLog	2017-07-19 23:38:06 UTC (rev 219665)
+++ trunk/Tools/ChangeLog	2017-07-19 23:57:38 UTC (rev 219666)
@@ -1,3 +1,18 @@
+2017-07-19  Megan Gardner  
+
+Don't write file URLs to iOS Pasteboard
+https://bugs.webkit.org/show_bug.cgi?id=174647
+
+
+Reviewed by Wenson Hsieh.
+
+Updating tests to reflect the lack of file URLs for images.
+
+* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+(checkTypeIdentifierAndIsNotOtherTypeIdentifier):
+(checkEstimatedSize):
+(TestWebKitAPI::TEST):
+
 2017-07-19  Brady Eidson  
 
 iBooks sometimes crashes when closing a book.


Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (219665 => 219666)

--- trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm	2017-07-19 23:38:06 UTC (rev 219665)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm	2017-07-19 23:57:38 UTC (rev 219666)
@@ -114,6 +114,13 @@
 EXPECT_TRUE([registeredTypes indexOfObject:firstType] < [registeredTypes indexOfObject:secondType]);
 }
 
+static void 

[webkit-changes] [219665] trunk

[mmaxfield]

Title: [219665] trunk








Revision 219665
Author mmaxfi...@apple.com
Date 2017-07-19 16:38:06 -0700 (Wed, 19 Jul 2017)


Log Message
Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
https://bugs.webkit.org/show_bug.cgi?id=174406
Source/WebCore:

Reviewed by Simon Fraser.


Reviewed by NOBODY.

When the minimumFontSize API preference is set, we will increase the font size without increasing
the line height. If the content specifies line-height as an absolute value, there can be two
unfortunate results:

- Adjacent lines in a paragraph can overlap
- If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines
can be cut off and potentially indecipherable.

Instead, we should use the minimum font size preference as a signal that we should increase the
line-height as well as the font-size. Eventually, we will want to increase it by an amount
proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
a behavior change on many webpages which use small text, so such a change would be too risky right now.
Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
only signal to boost the corresponding line-height.

Tests: fast/text/line-height-minimumFontSize-text-zoom.html
   fast/text/line-height-minimumFontSize-visual.html
   fast/text/line-height-minimumFontSize-zoom.html
   fast/text/line-height-minimumFontSize.html
   fast/text/line-height-minimumFontSize-autosize.html

* css/StyleBuilderCustom.h:
(WebCore::computeBaseSpecifiedFontSize):
(WebCore::computeLineHeightMultiplierDueToFontSize):
(WebCore::StyleBuilderCustom::applyValueLineHeight):
(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyValueStroke):
(WebCore::StyleBuilderCustom::applyValueContent):
* rendering/TextAutoSizing.cpp:

LayoutTests:



Reviewed by Simon Fraser.

* fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
* fast/text/line-height-minimumFontSize-autosize.html: Added.
* fast/text/line-height-minimumFontSize-expected.txt: Added.
* fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
* fast/text/line-height-minimumFontSize-text-zoom.html: Added.
* fast/text/line-height-minimumFontSize-visual-expected.html: Added.
* fast/text/line-height-minimumFontSize-visual.html: Added.
* fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
* fast/text/line-height-minimumFontSize-zoom.html: Added.
* fast/text/line-height-minimumFontSize.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilderCustom.h
trunk/Source/WebCore/rendering/TextAutoSizing.cpp


Added Paths

trunk/LayoutTests/fast/text/line-height-minimumFontSize-autosize-expected.txt
trunk/LayoutTests/fast/text/line-height-minimumFontSize-autosize.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-expected.txt
trunk/LayoutTests/fast/text/line-height-minimumFontSize-text-zoom-expected.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-text-zoom.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-visual-expected.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-visual.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-zoom-expected.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize-zoom.html
trunk/LayoutTests/fast/text/line-height-minimumFontSize.html




Diff

Modified: trunk/LayoutTests/ChangeLog (219664 => 219665)

--- trunk/LayoutTests/ChangeLog	2017-07-19 20:42:21 UTC (rev 219664)
+++ trunk/LayoutTests/ChangeLog	2017-07-19 23:38:06 UTC (rev 219665)
@@ -1,3 +1,41 @@
+2017-07-19  Myles C. Maxfield  
+
+Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
+https://bugs.webkit.org/show_bug.cgi?id=174406
+
+
+Reviewed by Simon Fraser.
+
+* fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
+* fast/text/line-height-minimumFontSize-autosize.html: Added.
+* fast/text/line-height-minimumFontSize-expected.txt: Added.
+* fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
+* fast/text/line-height-minimumFontSize-text-zoom.html: Added.
+* fast/text/line-height-minimumFontSize-visual-expected.html: Added.
+* fast/text/line-height-minimumFontSize-visual.html: Added.
+* fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
+* fast/text/line-height-minimumFontSize-zoom.html: Added.
+* fast/text/line-height-minimumFontSize.html: Added.
+
+2017-07-18  Myles C. Maxfield  
+
+Setting the minimum font size preference doesn’t affect absolute line-height values, 

[webkit-changes] [219664] trunk

[beidson]

Title: [219664] trunk








Revision 219664
Author beid...@apple.com
Date 2017-07-19 13:42:21 -0700 (Wed, 19 Jul 2017)


Log Message
iBooks sometimes crashes when closing a book.
 and https://bugs.webkit.org/show_bug.cgi?id=174658

Reviewed by Oliver Hunt.

Source/WebKit:

- LegacyCustomProtocolManagerProxy should not reference a WebProcessPool directly.
- LegacyCustomProtocolManagerProxy should invalidate in its destructor.

* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:
(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose): Deleted.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):
* UIProcess/Network/NetworkProcessProxy.h:
(WebKit::NetworkProcessProxy::processPool):

Tools:

* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
(-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
(-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
(-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
(TestWebKitAPI::TEST):

Add a "spin the runloop X number of times" utility:
* TestWebKitAPI/Utilities.h:
* TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
(TestWebKitAPI::Util::spinRunLoop):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm
trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp
trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm
trunk/Tools/TestWebKitAPI/Utilities.h
trunk/Tools/TestWebKitAPI/cocoa/UtilitiesCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (219663 => 219664)

--- trunk/Source/WebKit/ChangeLog	2017-07-19 20:24:15 UTC (rev 219663)
+++ trunk/Source/WebKit/ChangeLog	2017-07-19 20:42:21 UTC (rev 219664)
@@ -1,3 +1,33 @@
+2017-07-19  Brady Eidson  
+
+iBooks sometimes crashes when closing a book.
+ and https://bugs.webkit.org/show_bug.cgi?id=174658
+
+Reviewed by Oliver Hunt.
+
+- LegacyCustomProtocolManagerProxy should not reference a WebProcessPool directly.
+- LegacyCustomProtocolManagerProxy should invalidate in its destructor.
+
+* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:
+(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
+(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
+(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
+(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
+(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
+(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
+(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
+(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
+(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
+(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
+(WebKit::LegacyCustomProtocolManagerProxy::processDidClose): Deleted.
+* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::NetworkProcessProxy):
+(WebKit::NetworkProcessProxy::didClose):
+* UIProcess/Network/NetworkProcessProxy.h:
+(WebKit::NetworkProcessProxy::processPool):
+
 2017-07-19  Yusuke Suzuki  
 
 [WTF] Implement WTF::ThreadGroup


Modified: trunk/Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm (219663 => 219664)

--- trunk/Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm	2017-07-19 20:24:15 UTC (rev 219663)
+++ trunk/Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm	2017-07-19 20:42:21 UTC (rev 219664)
@@ -148,8 +148,11 @@
 
 void LegacyCustomProtocolManagerClient::invalidate(LegacyCustomProtocolManagerProxy&)
 {
-for (auto& loader : m_loaderMap)
-

[webkit-changes] [219662] trunk

[commit-queue]

Title: [219662] trunk








Revision 219662
Author commit-qu...@webkit.org
Date 2017-07-19 13:13:15 -0700 (Wed, 19 Jul 2017)


Log Message
[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
https://bugs.webkit.org/show_bug.cgi?id=174650


Patch by Antoine Quint  on 2017-07-19
Reviewed by Dean Jackson.

Source/WebCore:

We would only pause when scrubbing on macOS because we only listened to "mousedown" events on the
scrubber's backing  element to identify that the user had started interacting with the
scrubber.

Implementing the same technique on iOS required a little more work than just listening to "touchstart"
events on the same element. On top of that, we needed to make sure that we would only respond to
"touchstart" events on the slider's thumb, and not on the track, since only on macOS should the user
be able to click anywhere on the track to scrub. So we turn off pointer-events for the  on iOS
only, and turn them back on specifically for the thumb.

There is also some finessing when dealing with touch events where we need to track the identifier of
the touch that started the user interaction. So we keep track of it in an ivar and wait until we get
a "touchend" event where the changedTouches list contains a touch with that same identifier to ensure
the same touch that initiates and ends the scrubbing interaction.

Finally, we fix another issue that was uncovered while turning back on the ScrubbingSupport tests
where we would not trash the cached _value ivar when we initiated scrubbing, which was important since
we would mistakenly use the pre-srubbing value during a scrub.

* Modules/modern-media-controls/controls/slider.css:
(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):
* Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.handleEvent):
(Slider.prototype._handleMousedownEvent):
(Slider.prototype._interactionEndTarget):
(Slider.prototype._handleTouchstartEvent):
(Slider.prototype._valueWillStartChanging):
(Slider.prototype._valueDidStopChanging):
(Slider.prototype._handleMouseupEvent):
(Slider.prototype._handleTouchendEvent):

LayoutTests:

Rebaseline and turn back on all the ScrubberSupport tests on macOS and iOS.

* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt:
* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html:
* media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt:
* media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt
trunk/LayoutTests/media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html
trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt
trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.css
trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js




Diff

Modified: trunk/LayoutTests/ChangeLog (219661 => 219662)

--- trunk/LayoutTests/ChangeLog	2017-07-19 19:18:40 UTC (rev 219661)
+++ trunk/LayoutTests/ChangeLog	2017-07-19 20:13:15 UTC (rev 219662)
@@ -1,3 +1,20 @@
+2017-07-19  Antoine Quint  
+
+[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
+https://bugs.webkit.org/show_bug.cgi?id=174650
+
+
+Reviewed by Dean Jackson.
+
+Rebaseline and turn back on all the ScrubberSupport tests on macOS and iOS.
+
+* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt:
+* media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html:
+* media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt:
+* media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
+* platform/ios-simulator/TestExpectations:
+* platform/mac/TestExpectations:
+
 2017-07-19  Nan Wang  
 
 AX: Web page reloaded when a node is labelling multiple childnodes


Modified: trunk/LayoutTests/media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt (219661 => 219662)

--- trunk/LayoutTests/media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt	2017-07-19 19:18:40 UTC (rev 219661)
+++ trunk/LayoutTests/media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt	2017-07-19 20:13:15 UTC (rev 219662)
@@ -3,7 +3,9 @@
 On success, you will see a series of "PASS" 

[webkit-changes] [219661] trunk

[n_wang]

Title: [219661] trunk








Revision 219661
Author n_w...@apple.com
Date 2017-07-19 12:18:40 -0700 (Wed, 19 Jul 2017)


Log Message
AX: Web page reloaded when a node is labelling multiple childnodes
https://bugs.webkit.org/show_bug.cgi?id=174655

Reviewed by Chris Fleizach.

Source/WebCore:

When we are asking for the aria-labelledby attribute of a node and its
sibling is also labelled by the same node, we get into an infinite loop
in textUnderElement since we only ignore one child. Added checks for
siblings to avoid such loop.

Test: accessibility/mac/aria-labelledby-multiple-child-crash.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

* accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt: Added.
* accessibility/mac/aria-labelledby-multiple-child-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp


Added Paths

trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt
trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (219660 => 219661)

--- trunk/LayoutTests/ChangeLog	2017-07-19 18:16:35 UTC (rev 219660)
+++ trunk/LayoutTests/ChangeLog	2017-07-19 19:18:40 UTC (rev 219661)
@@ -1,3 +1,13 @@
+2017-07-19  Nan Wang  
+
+AX: Web page reloaded when a node is labelling multiple childnodes
+https://bugs.webkit.org/show_bug.cgi?id=174655
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt: Added.
+* accessibility/mac/aria-labelledby-multiple-child-crash.html: Added.
+
 2017-07-19  Chris Dumez  
 
 Make cross-origin properties enumerable


Added: trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt (0 => 219661)

--- trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt	2017-07-19 19:18:40 UTC (rev 219661)
@@ -0,0 +1,14 @@
+Header
+Header2
+Description text
+
+This tests that when a node is labelling multiple child nodes it won't cause crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+AXDescription: Description text
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash.html (0 => 219661)

--- trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-labelledby-multiple-child-crash.html	2017-07-19 19:18:40 UTC (rev 219661)
@@ -0,0 +1,33 @@
+
+
+
+
+
+
+

+
Header
+
Header2
+
+
Description text
+
+
+

+

+
+