[webkit-changes] [223168] trunk/Source/WebCore

2017-10-10 Thread calvaris 
Title: [223168] trunk/Source/WebCore








Revision 223168
Author calva...@igalia.com
Date 2017-10-10 22:48:47 -0700 (Tue, 10 Oct 2017)


Log Message
[GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
https://bugs.webkit.org/show_bug.cgi?id=178079

Reviewed by Žan Doberšek.

When the downloadbuffer GStreamer element requests two seeks too
close to each other there's some rare race condition where our
source answers that it is not seekable and ends up with
downloadbuffer element to seek beyond the file size, which causes
the server to issue a 416 HTTP error code eventually, causing our
MediaPlayer to stop.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStop): We only unset he seekable attribute if we are
not seeking.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (223167 => 223168)

--- trunk/Source/WebCore/ChangeLog	2017-10-11 04:12:30 UTC (rev 223167)
+++ trunk/Source/WebCore/ChangeLog	2017-10-11 05:48:47 UTC (rev 223168)
@@ -1,3 +1,21 @@
+2017-10-10  Xabier Rodriguez Calvar  
+
+[GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
+https://bugs.webkit.org/show_bug.cgi?id=178079
+
+Reviewed by Žan Doberšek.
+
+When the downloadbuffer GStreamer element requests two seeks too
+close to each other there's some rare race condition where our
+source answers that it is not seekable and ends up with
+downloadbuffer element to seek beyond the file size, which causes
+the server to issue a 416 HTTP error code eventually, causing our
+MediaPlayer to stop.
+
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(webKitWebSrcStop): We only unset he seekable attribute if we are
+not seeking.
+
 2017-10-10  Ryosuke Niwa  
 
 Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (223167 => 223168)

--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2017-10-11 04:12:30 UTC (rev 223167)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2017-10-11 05:48:47 UTC (rev 223168)
@@ -58,7 +58,7 @@
 virtual ~CachedResourceStreamingClient();
 private:
 #if USE(SOUP)
-char* getOrCreateReadBuffer(PlatformMediaResource&, size_t requestedSize, size_t& actualSize);
+char* getOrCreateReadBuffer(PlatformMediaResource&, size_t requestedSize, size_t& actualSize) override;
 #endif
 // PlatformMediaResourceClient virtual methods.
 void responseReceived(PlatformMediaResource&, const ResourceResponse&) override;
@@ -373,12 +373,12 @@
 priv->paused = false;
 
 priv->offset = 0;
-priv->seekable = FALSE;
 
 if (!wasSeeking) {
 priv->size = 0;
 priv->requestedOffset = 0;
 priv->player = nullptr;
+priv->seekable = FALSE;
 }
 
 if (priv->appsrc) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [223167] trunk

2017-10-10 Thread rniwa 
Title: [223167] trunk








Revision 223167
Author rn...@webkit.org
Date 2017-10-10 21:12:30 -0700 (Tue, 10 Oct 2017)


Log Message
Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=178154

Reviewed by Wenson Hsieh.

Source/WebCore:

Extracted the logic to compute the default enabled-ness of custom pasteboard data as
Settings::defaultCustomPasteboardDataEnabled() to be called by WebKit1 and WebKit2 layers.

* page/Settings.cpp:
(WebCore::Settings::defaultCustomPasteboardDataEnabled): Extracted from customPasteboardDataEnabled.
(WebCore::Settings::customPasteboardDataEnabled): Deleted. Now inlined in the header file.
* page/Settings.h:
(WebCore::Settings::customPasteboardDataEnabled):
* platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::read): Fixed a bug that we were adding MIME type to the map before checking that
we could actually read the buffer. We shouldn't skip a type (NSTIFFPboardType and kUTTypeTIFF for now)
if an equivalent type had failed to read.

Source/WebKit:

Plumbed customPasteboardDataEnabled flag to be used in WebKitTestRunner.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCustomPasteboardDataEnabled):
(WKPreferencesGetCustomPasteboardDataEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

Enable custom pasteboard data by default.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences customPasteboardDataEnabled]): Added.
(-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

Fixed the bug that LocalPasteboard would fail to load the promise type if data is set after declaring types
by delaying the call to provideDataForType until when dataForType is called.

Without this fix, fast/events/dropzone-002.html would start failing after enabling custom pasteboard data.
With this fix, fast/events/dropzone-005.html also starts passing.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard dataForType:]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

* editing/pasteboard/dataTransfer-setData-getData-expected.txt: Rebaselined. One more test case is passing now.
* fast/events/dropzone-002.html: Fixed the test to accept an image since we no longer drop URLs when dropping
an image avoid leaking local file paths.
* platform/mac/TestExpectations: Enabled dropzone-005.html since it started passing after fixing LocalPasteboard.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/dataTransfer-setData-getData-expected.txt
trunk/LayoutTests/fast/events/dropzone-002.html
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (223166 => 223167)

--- trunk/LayoutTests/ChangeLog	2017-10-11 03:49:16 UTC (rev 223166)
+++ trunk/LayoutTests/ChangeLog	2017-10-11 04:12:30 UTC (rev 223167)
@@ -1,3 +1,15 @@
+2017-10-10  Ryosuke Niwa  
+
+Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=178154
+
+Reviewed by Wenson Hsieh.
+
+* editing/pasteboard/dataTransfer-setData-getData-expected.txt: Rebaselined. One more test case is passing now.
+* fast/events/dropzone-002.html: Fixed the test to accept an image since we no longer drop URLs when dropping
+an image avoid leaking local file paths.
+* platform/mac/TestExpectations: Enabled dropzone-005.html since it started passing after fixing LocalPasteboard.
+
 2017-10-10  Andy Estes  
 
 [Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay


Modified:

[webkit-changes] [223165] branches/safari-604-branch

2017-10-10 Thread jmarcell 
Title: [223165] branches/safari-604-branch








Revision 223165
Author jmarc...@apple.com
Date 2017-10-10 20:49:13 -0700 (Tue, 10 Oct 2017)


Log Message
Cherry-pick r223084. rdar://problem/34857469

Modified Paths

branches/safari-604-branch/Source/WebKit/ChangeLog
branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.messages.in
branches/safari-604-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
branches/safari-604-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/WebFrame.h
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/WebPage.h
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
branches/safari-604-branch/Tools/ChangeLog
branches/safari-604-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

branches/safari-604-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/_javascript_DuringNavigation.mm




Diff

Modified: branches/safari-604-branch/Source/WebKit/ChangeLog (223164 => 223165)

--- branches/safari-604-branch/Source/WebKit/ChangeLog	2017-10-11 03:16:39 UTC (rev 223164)
+++ branches/safari-604-branch/Source/WebKit/ChangeLog	2017-10-11 03:49:13 UTC (rev 223165)
@@ -1,5 +1,51 @@
 2017-10-10  Jason Marcell  
 
+Cherry-pick r223084. rdar://problem/34857469
+
+2017-10-09  Jason Marcell  
+
+Apply patch. rdar://problem/34857459
+
+Apply patch. rdar://problem/34857459
+
+2017-10-06  Alex Christensen  
+
+REGRESSION(r214201): WebProcess hangs during policy decisions
+https://bugs.webkit.org/show_bug.cgi?id=177411
+
+
+Original patch reviewed by Geoffrey Garen, this is a modification that doesn't change Mac.
+
+This is like r222431 which allows the WebProcess to not be hung.  This fixes the desired bug on iOS
+but without changing Mac, which depends on the ability to asynchronously call the completion handlers.
+
+This change applies to the safari-604-branch.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::receivedPolicyDecision):
+(WebKit::WebPageProxy::decidePolicyForNavigationAction):
+(WebKit::WebPageProxy::decidePolicyForResponseSync):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
+(WebKit::WebFrameLoaderClient::applyToDocumentLoader):
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::setUpPolicyListener):
+(WebKit::WebFrame::invalidatePolicyListener):
+(WebKit::WebFrame::didReceivePolicyDecision):
+* WebProcess/WebPage/WebFrame.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didReceivePolicyDecision):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
+2017-10-10  Jason Marcell  
+
 Cherry-pick r222478. rdar://problem/34771020
 
 2017-09-25  Youenn Fablet  


Modified: branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (223164 => 223165)

--- branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2017-10-11 03:16:39 UTC (rev 223164)
+++ branches/safari-604-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2017-10-11 03:49:13 UTC (rev 223165)
@@ -2260,12 +2260,20 @@
 DownloadID downloadID = { };
 if (action == PolicyDownload) {
 // Create a download proxy.
+#if PLATFORM(MAC)
 DownloadProxy* download = m_process->processPool().createDownloadProxy(m_decidePolicyForResponseRequest);
+#else
+const ResourceRequest& downloadRequest = m_decidePolicyForResponseRequest ? *m_decidePolicyForResponseRequest : ResourceRequest();
+DownloadProxy* download = m_process->processPool().createDownloadProxy(downloadRequest);
+#endif
 downloadID = download->downloadID();
 handleDownloadRequest(download);
+#if PLATFORM(MAC)

[webkit-changes] [223166] branches/safari-604-branch/LayoutTests

2017-10-10 Thread jmarcell 
Title: [223166] branches/safari-604-branch/LayoutTests








Revision 223166
Author jmarc...@apple.com
Date 2017-10-10 20:49:16 -0700 (Tue, 10 Oct 2017)


Log Message
Cherry-pick r222450. rdar://problem/34920294

Modified Paths

branches/safari-604-branch/LayoutTests/ChangeLog
branches/safari-604-branch/LayoutTests/platform/ios/TestExpectations




Diff

Modified: branches/safari-604-branch/LayoutTests/ChangeLog (223165 => 223166)

--- branches/safari-604-branch/LayoutTests/ChangeLog	2017-10-11 03:49:13 UTC (rev 223165)
+++ branches/safari-604-branch/LayoutTests/ChangeLog	2017-10-11 03:49:16 UTC (rev 223166)
@@ -1,5 +1,18 @@
 2017-10-10  Jason Marcell  
 
+Cherry-pick r222450. rdar://problem/34920294
+
+2017-09-25  Ryan Haddad  
+
+Mark imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html as flaky on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=177323
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
+2017-10-10  Jason Marcell  
+
 Cherry-pick r222478. rdar://problem/34771020
 
 2017-09-25  Youenn Fablet  


Modified: branches/safari-604-branch/LayoutTests/platform/ios/TestExpectations (223165 => 223166)

--- branches/safari-604-branch/LayoutTests/platform/ios/TestExpectations	2017-10-11 03:49:13 UTC (rev 223165)
+++ branches/safari-604-branch/LayoutTests/platform/ios/TestExpectations	2017-10-11 03:49:16 UTC (rev 223166)
@@ -3111,3 +3111,5 @@
 http/tests/multipart/load-last-non-html-frame.php [ Failure  ]
 
 webkit.org/b/177366 http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html [ Pass Timeout ]
+
+webkit.org/b/177323 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [223164] trunk/Source/WebInspectorUI

2017-10-10 Thread bburg 
Title: [223164] trunk/Source/WebInspectorUI








Revision 223164
Author bb...@apple.com
Date 2017-10-10 20:16:39 -0700 (Tue, 10 Oct 2017)


Log Message
Web Inspector: Quick Open: source mapped files are not shown as search results
https://bugs.webkit.org/show_bug.cgi?id=178151


Reviewed by Joseph Pecoraro.

* UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._addResource):
Also consider matching the query string against SourceMapResources
attached to a resource's source maps.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (223163 => 223164)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-10-11 02:57:12 UTC (rev 223163)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-10-11 03:16:39 UTC (rev 223164)
@@ -1,3 +1,16 @@
+2017-10-10  Brian Burg  
+
+Web Inspector: Quick Open: source mapped files are not shown as search results
+https://bugs.webkit.org/show_bug.cgi?id=178151
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/OpenResourceDialog.js:
+(WI.OpenResourceDialog.prototype._addResource):
+Also consider matching the query string against SourceMapResources
+attached to a resource's source maps.
+
 2017-10-10  Joseph Pecoraro  
 
 Web Inspector: Network Tab - Set column initial widths to try allow waterfall column to expand more by default


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js (223163 => 223164)

--- trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js	2017-10-11 02:57:12 UTC (rev 223163)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js	2017-10-11 03:16:39 UTC (rev 223164)
@@ -265,6 +265,12 @@
 if (!this.representedObjectIsValid(resource))
 return;
 
+// Recurse on source maps if any exist.
+for (let sourceMap of resource.sourceMaps) {
+for (let sourceMapResource of sourceMap.resources)
+this._addResource(sourceMapResource, suppressFilterUpdate);
+}
+
 this._queryController.addResource(resource);
 if (suppressFilterUpdate)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [223163] trunk

2017-10-10 Thread aestes 
Title: [223163] trunk








Revision 223163
Author aes...@apple.com
Date 2017-10-10 19:57:12 -0700 (Tue, 10 Oct 2017)


Log Message
[Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay
https://bugs.webkit.org/show_bug.cgi?id=178150

Reviewed by Tim Horton.

Source/WebCore:

Apple Pay requires a single currency code, but the Payment Request API allows the client to
specify a currency code for each PaymentCurrencyAmount.

Instead of having a required currencyCode property on ApplePayRequest and ignoring the
currency property on PaymentCurrencyAmount, validate that all PaymentCurrencyAmounts use the
same currency code and use that as ApplePaySessionPaymentRequest's currencyCode.

Added test cases to http/tests/ssl/applepay/PaymentRequest.https.html.

* Modules/applepay/ApplePayPaymentRequest.h:
* Modules/applepay/ApplePayPaymentRequest.idl:
* Modules/applepay/ApplePayRequestBase.cpp:
(WebCore::convertAndValidate):
* Modules/applepay/ApplePayRequestBase.h:
* Modules/applepay/ApplePayRequestBase.idl:
* Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidate):
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::validate):
(WebCore::convertAndValidate):
(WebCore::ApplePayPaymentHandler::show):
* Modules/applepay/paymentrequest/ApplePayRequest.idl:

LayoutTests:

* http/tests/paymentrequest/payment-request-abort-method.https.html:
* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
* http/tests/paymentrequest/payment-request-show-method.https.html:
* http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
* http/tests/ssl/applepay/PaymentRequest.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html
trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html
trunk/LayoutTests/http/tests/ssl/applepay/PaymentRequest.https-expected.txt
trunk/LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h
trunk/Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.h
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.idl
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayRequest.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (223162 => 223163)

--- trunk/LayoutTests/ChangeLog	2017-10-11 01:01:53 UTC (rev 223162)
+++ trunk/LayoutTests/ChangeLog	2017-10-11 02:57:12 UTC (rev 223163)
@@ -1,5 +1,18 @@
 2017-10-10  Andy Estes  
 
+[Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay
+https://bugs.webkit.org/show_bug.cgi?id=178150
+
+Reviewed by Tim Horton.
+
+* http/tests/paymentrequest/payment-request-abort-method.https.html:
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
+* http/tests/paymentrequest/payment-request-show-method.https.html:
+* http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
+* http/tests/ssl/applepay/PaymentRequest.https.html:
+
+2017-10-10  Andy Estes  
+
 [Payment Request] Implement PaymentRequest.canMakePayment()
 https://bugs.webkit.org/show_bug.cgi?id=178048
 


Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html (223162 => 223163)

--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html	2017-10-11 01:01:53 UTC (rev 223162)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html	2017-10-11 02:57:12 UTC (rev 223163)
@@ -22,7 +22,6 @@
 merchantCapabilities: ['supports3DS'],
 supportedNetworks: ['visa', 'masterCard'],
 countryCode: 'US',
-currencyCode: 'USD',
 },
 });
 const defaultMethods = Object.freeze([applePay]);


Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html (223162 => 223163)

--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2017-10-11 01:01:53 UTC (rev 223162)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2017-10-11 02:57:12 UTC (rev 223163)
@@ -16,7 +16,6 @@
 merchantCapabilities: ["supports3DS"],
 supportedNetworks: ["visa", "masterCard"],
 countryCode: "US",
-currencyCode: "USD",
 }
 });
 const defaultMethods = Object.freeze([applePay]);


Modified:

[webkit-changes] [223162] trunk

2017-10-10 Thread aperez 
Title: [223162] trunk








Revision 223162
Author ape...@igalia.com
Date 2017-10-10 18:01:53 -0700 (Tue, 10 Oct 2017)


Log Message
[WPE] Remove the possibility of installing the old WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=178125

Reviewed by Michael Catanzaro.

.:

* Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API
build option.

Source/WebKit:

* PlatformWPE.cmake: Remove support for installing the deprecated C API.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (223161 => 223162)

--- trunk/ChangeLog	2017-10-11 00:53:59 UTC (rev 223161)
+++ trunk/ChangeLog	2017-10-11 01:01:53 UTC (rev 223162)
@@ -1,3 +1,13 @@
+2017-10-10  Adrian Perez de Castro  
+
+[WPE] Remove the possibility of installing the old WebKit2 C API
+https://bugs.webkit.org/show_bug.cgi?id=178125
+
+Reviewed by Michael Catanzaro.
+
+* Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API
+build option.
+
 2017-10-10  Michael Catanzaro  
 
 [WPE] Expose ENABLE_XSLT option


Modified: trunk/Source/WebKit/ChangeLog (223161 => 223162)

--- trunk/Source/WebKit/ChangeLog	2017-10-11 00:53:59 UTC (rev 223161)
+++ trunk/Source/WebKit/ChangeLog	2017-10-11 01:01:53 UTC (rev 223162)
@@ -1,3 +1,12 @@
+2017-10-10  Adrian Perez de Castro  
+
+[WPE] Remove the possibility of installing the old WebKit2 C API
+https://bugs.webkit.org/show_bug.cgi?id=178125
+
+Reviewed by Michael Catanzaro.
+
+* PlatformWPE.cmake: Remove support for installing the deprecated C API.
+
 2017-10-10  Chris Dumez  
 
 [WK2] Add API to clear service worker registrations


Modified: trunk/Source/WebKit/PlatformWPE.cmake (223161 => 223162)

--- trunk/Source/WebKit/PlatformWPE.cmake	2017-10-11 00:53:59 UTC (rev 223161)
+++ trunk/Source/WebKit/PlatformWPE.cmake	2017-10-11 01:01:53 UTC (rev 223162)
@@ -516,123 +516,6 @@
 ADD_WEBKIT_PREFIX_HEADER(WPEInjectedBundle)
 target_link_libraries(WPEInjectedBundle WebKit)
 
-if (EXPORT_DEPRECATED_WEBKIT2_C_API)
-set(WPE_INSTALLED_WEBKIT_HEADERS
-${WEBKIT_DIR}/Shared/API/c/WKArray.h
-${WEBKIT_DIR}/Shared/API/c/WKBase.h
-${WEBKIT_DIR}/Shared/API/c/WKData.h
-${WEBKIT_DIR}/Shared/API/c/WKDeclarationSpecifiers.h
-${WEBKIT_DIR}/Shared/API/c/WKDiagnosticLoggingResultType.h
-${WEBKIT_DIR}/Shared/API/c/WKDictionary.h
-${WEBKIT_DIR}/Shared/API/c/WKErrorRef.h
-${WEBKIT_DIR}/Shared/API/c/WKEvent.h
-${WEBKIT_DIR}/Shared/API/c/WKFindOptions.h
-${WEBKIT_DIR}/Shared/API/c/WKGeometry.h
-${WEBKIT_DIR}/Shared/API/c/WKImage.h
-${WEBKIT_DIR}/Shared/API/c/WKMutableArray.h
-${WEBKIT_DIR}/Shared/API/c/WKMutableDictionary.h
-${WEBKIT_DIR}/Shared/API/c/WKNumber.h
-${WEBKIT_DIR}/Shared/API/c/WKPageLoadTypes.h
-${WEBKIT_DIR}/Shared/API/c/WKPageVisibilityTypes.h
-${WEBKIT_DIR}/Shared/API/c/WKSecurityOriginRef.h
-${WEBKIT_DIR}/Shared/API/c/WKSerializedScriptValue.h
-${WEBKIT_DIR}/Shared/API/c/WKString.h
-${WEBKIT_DIR}/Shared/API/c/WKType.h
-${WEBKIT_DIR}/Shared/API/c/WKURL.h
-${WEBKIT_DIR}/Shared/API/c/WKURLRequest.h
-${WEBKIT_DIR}/Shared/API/c/WKURLResponse.h
-${WEBKIT_DIR}/Shared/API/c/WKUserContentInjectedFrames.h
-${WEBKIT_DIR}/Shared/API/c/WKUserContentURLPattern.h
-${WEBKIT_DIR}/Shared/API/c/WKUserScriptInjectionTime.h
-
-${WEBKIT_DIR}/Shared/API/c/wpe/WKBaseWPE.h
-
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundle.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleFrame.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleInitialize.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleInspector.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundlePage.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h
-${WEBKIT_DIR}/WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h
-

[webkit-changes] [223161] trunk/Source/JavaScriptCore

2017-10-10 Thread sbarati 
Title: [223161] trunk/Source/_javascript_Core








Revision 223161
Author sbar...@apple.com
Date 2017-10-10 17:53:59 -0700 (Tue, 10 Oct 2017)


Log Message
Prototype structure transition should be a deferred transition
https://bugs.webkit.org/show_bug.cgi?id=177734

Reviewed by Keith Miller.

Absence ObjectPropertyConditions work by verifying both that the Structure
does not have a particular property and that its prototype has
remained constant. However, the prototype transition was firing
the transition watchpoint before setting the object's structure.
This meant that isValid for Absence would never return false because
the prototype changed. Clearly this is wrong. The reason this didn't
break OPCs in general is that we'd also check if we could still watch
the OPC. In this case, we can't still watch it because we're inspecting
a structure with an invalidated transition watchpoint. To fix
this weird quirk of the code, I'm making it so that doing a prototype
transition uses the DeferredStructureTransitionWatchpointFire machinery.

This patch also fixes some dead code that I left in regarding
poly proto in OPC.

* bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
* runtime/JSObject.cpp:
(JSC::JSObject::setPrototypeDirect):
* runtime/Structure.cpp:
(JSC::Structure::changePrototypeTransition):
* runtime/Structure.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/Structure.cpp
trunk/Source/_javascript_Core/runtime/Structure.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (223160 => 223161)

--- trunk/Source/_javascript_Core/ChangeLog	2017-10-11 00:37:49 UTC (rev 223160)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-11 00:53:59 UTC (rev 223161)
@@ -1,3 +1,33 @@
+2017-10-10  Saam Barati  
+
+Prototype structure transition should be a deferred transition
+https://bugs.webkit.org/show_bug.cgi?id=177734
+
+Reviewed by Keith Miller.
+
+Absence ObjectPropertyConditions work by verifying both that the Structure 
+does not have a particular property and that its prototype has
+remained constant. However, the prototype transition was firing
+the transition watchpoint before setting the object's structure.
+This meant that isValid for Absence would never return false because
+the prototype changed. Clearly this is wrong. The reason this didn't
+break OPCs in general is that we'd also check if we could still watch
+the OPC. In this case, we can't still watch it because we're inspecting
+a structure with an invalidated transition watchpoint. To fix
+this weird quirk of the code, I'm making it so that doing a prototype
+transition uses the DeferredStructureTransitionWatchpointFire machinery.
+
+This patch also fixes some dead code that I left in regarding
+poly proto in OPC.
+
+* bytecode/PropertyCondition.cpp:
+(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
+* runtime/JSObject.cpp:
+(JSC::JSObject::setPrototypeDirect):
+* runtime/Structure.cpp:
+(JSC::Structure::changePrototypeTransition):
+* runtime/Structure.h:
+
 2017-10-10  Robin Morisset  
 
 Avoid allocating useless landingBlocks in DFGByteCodeParser::handleInlining()


Modified: trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp (223160 => 223161)

--- trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp	2017-10-11 00:37:49 UTC (rev 223160)
+++ trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp	2017-10-11 00:53:59 UTC (rev 223161)
@@ -122,15 +122,7 @@
 return false;
 }
 
-JSObject* currentPrototype;
-if (structure->hasMonoProto())
-currentPrototype = structure->storedPrototypeObject();
-else {
-RELEASE_ASSERT(base);
-currentPrototype = jsDynamicCast(*structure->vm(), base->getPrototypeDirect());
-}
-
-if (currentPrototype != prototype()) {
+if (structure->storedPrototypeObject() != prototype()) {
 if (PropertyConditionInternal::verbose) {
 dataLog(
 "Invalid because the prototype is ", structure->storedPrototype(), " even though "


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (223160 => 223161)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-10-11 00:37:49 UTC (rev 223160)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-10-11 00:53:59 UTC (rev 223161)
@@ -1634,7 +1634,8 @@
 prototype.asCell()->didBecomePrototype();
 
 if (structure(vm)->hasMonoProto()) {
-Structure* newStructure =

[webkit-changes] [223160] trunk

2017-10-10 Thread aestes 
Title: [223160] trunk








Revision 223160
Author aes...@apple.com
Date 2017-10-10 17:37:49 -0700 (Tue, 10 Oct 2017)


Log Message
[Payment Request] Implement PaymentRequest.canMakePayment()
https://bugs.webkit.org/show_bug.cgi?id=178048

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Removed.

Source/WebCore:

Test: http/tests/paymentrequest/payment-request-canmakepayment-method.https.html

* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::convertData): Moved
ApplePayRequest-to-ApplePaySessionPaymentRequest conversion from here to show().
(WebCore::ApplePayPaymentHandler::show): Returned an exception if
ApplePaySessionPaymentRequest conversion fails.
(WebCore::shouldDiscloseApplePayCapability): Checked if we are in an ephimeral session or if
Settings::applePayCapabilityDisclosureAllowed() is false.
(WebCore::ApplePayPaymentHandler::canMakePayment): Called
PaymentCoordinator::canMakePayments() or PaymentCoordinator::canMakePaymentsWithActiveCard()
depending on shouldDiscloseApplePayCapability().
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
* Modules/applepay/paymentrequest/ApplePayRequest.h:
* Modules/applepay/paymentrequest/ApplePayRequest.idl: Defined merchantIdentifier.
* Modules/paymentrequest/PaymentHandler.h:
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::parse): Moved JSON-parsing to here from show().
(WebCore::PaymentRequest::show): Returned the exception from PaymentHandler::show().
(WebCore::PaymentRequest::canMakePayment): For each payment method, try to create a
PaymentHandler.
For the first valid PaymentHandler, call canMakePayment() and pass a lambda that resolves
the promise.
* Modules/paymentrequest/PaymentRequest.h:
* Modules/paymentrequest/PaymentRequest.idl: Added CallWith=Document annotations to show()
and canMakePayment().

LayoutTests:

* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt: Added.
* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Added.
* http/tests/ssl/applepay/PaymentRequest.https.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html
trunk/LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.h
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayRequest.h
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayRequest.idl
trunk/Source/WebCore/Modules/paymentrequest/PaymentHandler.h
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.h
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.idl


Added Paths

trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt
trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html


Removed Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (223159 => 223160)

--- trunk/LayoutTests/ChangeLog	2017-10-11 00:09:20 UTC (rev 223159)
+++ trunk/LayoutTests/ChangeLog	2017-10-11 00:37:49 UTC (rev 223160)
@@ -1,3 +1,16 @@
+2017-10-10  Andy Estes  
+
+[Payment Request] Implement PaymentRequest.canMakePayment()
+https://bugs.webkit.org/show_bug.cgi?id=178048
+
+Reviewed by Youenn Fablet.
+
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt: Added.
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Added.
+* http/tests/ssl/applepay/PaymentRequest.https.html:
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2017-10-10  Joanmarie Diggs  
 
 AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM


Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html (223159 => 223160)

--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html	2017-10-11 00:09:20 UTC (rev 223159)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-abort-method.https.html	2017-10-11 00:37:49 UTC (rev 223160)
@@ -18,6 +18,7 @@
 supportedMethods: "https://apple.com/apple-pay",

[webkit-changes] [223159] trunk/Source/JavaScriptCore

2017-10-10 Thread rmorisset 
Title: [223159] trunk/Source/_javascript_Core








Revision 223159
Author rmoris...@apple.com
Date 2017-10-10 17:09:20 -0700 (Tue, 10 Oct 2017)


Log Message
Avoid allocating useless landingBlocks in DFGByteCodeParser::handleInlining()
https://bugs.webkit.org/show_bug.cgi?id=177926

Reviewed by Saam Barati.

When doing polyvariant inlining, there used to be a landing block for each callee, each of which was then linked to a continuation block.
With this change, we allocate the continuation block first, and pass it to the inlining routine so that op_ret in the callee link directly to it.
The only subtlety is that when inlining an intrinsic we must do the jump by hand, and also remember to call processSetLocalQueue with nextOffset before it.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (223158 => 223159)

--- trunk/Source/_javascript_Core/ChangeLog	2017-10-11 00:01:28 UTC (rev 223158)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-11 00:09:20 UTC (rev 223159)
@@ -1,3 +1,21 @@
+2017-10-10  Robin Morisset  
+
+Avoid allocating useless landingBlocks in DFGByteCodeParser::handleInlining()
+https://bugs.webkit.org/show_bug.cgi?id=177926
+
+Reviewed by Saam Barati.
+
+When doing polyvariant inlining, there used to be a landing block for each callee, each of which was then linked to a continuation block.
+With this change, we allocate the continuation block first, and pass it to the inlining routine so that op_ret in the callee link directly to it.
+The only subtlety is that when inlining an intrinsic we must do the jump by hand, and also remember to call processSetLocalQueue with nextOffset before it.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::inlineCall):
+(JSC::DFG::ByteCodeParser::attemptToInlineCall):
+(JSC::DFG::ByteCodeParser::handleInlining):
+(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
+(JSC::DFG::ByteCodeParser::parse):
+
 2017-10-10  Guillaume Emont  
 
 Fix compilation when MASM_PROBE (and therefore DFG) are disabled


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (223158 => 223159)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2017-10-11 00:01:28 UTC (rev 223158)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2017-10-11 00:09:20 UTC (rev 223159)
@@ -228,9 +228,9 @@
 // Handle inlining. Return true if it succeeded, false if we need to plant a call.
 bool handleInlining(Node* callTargetNode, int resultOperand, const CallLinkStatus&, int registerOffset, VirtualRegister thisArgument, VirtualRegister argumentsArgument, unsigned argumentsOffset, int argumentCountIncludingThis, unsigned nextOffset, NodeType callOp, InlineCallFrame::Kind, SpeculatedType prediction);
 template
-bool attemptToInlineCall(Node* callTargetNode, int resultOperand, CallVariant, int registerOffset, int argumentCountIncludingThis, unsigned nextOffset, InlineCallFrame::Kind, SpeculatedType prediction, unsigned& inliningBalance, const ChecksFunctor& insertChecks);
+bool attemptToInlineCall(Node* callTargetNode, int resultOperand, CallVariant, int registerOffset, int argumentCountIncludingThis, unsigned nextOffset, InlineCallFrame::Kind, SpeculatedType prediction, unsigned& inliningBalance, BasicBlock* continuationBlock, const ChecksFunctor& insertChecks);
 template
-void inlineCall(Node* callTargetNode, int resultOperand, CallVariant, int registerOffset, int argumentCountIncludingThis, unsigned nextOffset, InlineCallFrame::Kind, const ChecksFunctor& insertChecks);
+void inlineCall(Node* callTargetNode, int resultOperand, CallVariant, int registerOffset, int argumentCountIncludingThis, unsigned nextOffset, InlineCallFrame::Kind, BasicBlock* continuationBlock, const ChecksFunctor& insertChecks);
 void cancelLinkingForBlock(InlineStackEntry*, BasicBlock*); // Only works when the given block is the last one to have been added for that inline stack entry.
 // Handle intrinsic functions. Return true if it succeeded, false if we need to plant a call.
 template
@@ -1157,7 +1157,8 @@
 VirtualRegister returnValueVR,
 VirtualRegister inlineCallFrameStart,
 int argumentCountIncludingThis,
-InlineCallFrame::Kind);
+InlineCallFrame::Kind,
+BasicBlock* continuationBlock);
 
 ~InlineStackEntry()
 {
@@ -1510,7 +1511,7 @@
 }
 
 template
-void ByteCodeParser::inlineCall(Node* callTargetNode, int

[webkit-changes] [223158] trunk/Source/WebKit

2017-10-10 Thread cdumez 
Title: [223158] trunk/Source/WebKit








Revision 223158
Author cdu...@apple.com
Date 2017-10-10 17:01:28 -0700 (Tue, 10 Oct 2017)


Log Message
[WK2] Add API to clear service worker registrations
https://bugs.webkit.org/show_bug.cgi?id=178085


Reviewed by Ryosuke Niwa.

Add API to clear service worker registrations. Although the request to
clear the registration is passed on to the StorageProcess, it is currently
a no-op on StorageProcess side until we actually persist service worker
registrations on disk.

* Shared/WebsiteData/WebsiteDataType.h:
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::fetchWebsiteData):
(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):
* UIProcess/API/C/WKWebsiteDataStoreRef.h:
* UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
* UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
(dataTypesToString):
* UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore allWebsiteDataTypes]):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebsiteData/WebsiteDataType.h
trunk/Source/WebKit/StorageProcess/StorageProcess.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (223157 => 223158)

--- trunk/Source/WebKit/ChangeLog	2017-10-10 23:46:05 UTC (rev 223157)
+++ trunk/Source/WebKit/ChangeLog	2017-10-11 00:01:28 UTC (rev 223158)
@@ -1,3 +1,36 @@
+2017-10-10  Chris Dumez  
+
+[WK2] Add API to clear service worker registrations
+https://bugs.webkit.org/show_bug.cgi?id=178085
+
+
+Reviewed by Ryosuke Niwa.
+
+Add API to clear service worker registrations. Although the request to
+clear the registration is passed on to the StorageProcess, it is currently
+a no-op on StorageProcess side until we actually persist service worker
+registrations on disk.
+
+* Shared/WebsiteData/WebsiteDataType.h:
+* StorageProcess/StorageProcess.cpp:
+(WebKit::StorageProcess::fetchWebsiteData):
+(WebKit::StorageProcess::deleteWebsiteData):
+(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
+* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):
+* UIProcess/API/C/WKWebsiteDataStoreRef.h:
+* UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
+* UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
+(dataTypesToString):
+* UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
+(WebKit::toWebsiteDataType):
+(WebKit::toWKWebsiteDataTypes):
+* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+(+[WKWebsiteDataStore allWebsiteDataTypes]):
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::fetchDataAndApply):
+(WebKit::WebsiteDataStore::removeData):
+
 2017-10-10  Commit Queue  
 
 Unreviewed, rolling out r223130.


Modified: trunk/Source/WebKit/Shared/WebsiteData/WebsiteDataType.h (223157 => 223158)

--- trunk/Source/WebKit/Shared/WebsiteData/WebsiteDataType.h	2017-10-10 23:46:05 UTC (rev 223157)
+++ trunk/Source/WebKit/Shared/WebsiteData/WebsiteDataType.h	2017-10-11 00:01:28 UTC (rev 223158)
@@ -45,6 +45,9 @@
 #endif
 ResourceLoadStatistics = 1 << 12,
 Credentials = 1 << 13,
+#if ENABLE(SERVICE_WORKER)
+ServiceWorkerRegistrations = 1 << 14,
+#endif
 };
 
 };


Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.cpp (223157 => 223158)

--- trunk/Source/WebKit/StorageProcess/StorageProcess.cpp	2017-10-10 23:46:05 UTC (rev 223157)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.cpp	2017-10-11 00:01:28 UTC (rev 223158)
@@ -183,18 +183,18 @@
 
 void StorageProcess::fetchWebsiteData(PAL::SessionID sessionID, OptionSet websiteDataTypes, uint64_t callbackID)
 {
-#if ENABLE(INDEXED_DATABASE)
 auto completionHandler = [this, callbackID](const WebsiteData& websiteData) {
 parentProcessConnection()->send(Messages::StorageProcessProxy::DidFetchWebsiteData(callbackID, websiteData), 0);
 };
 
+#if ENABLE(SERVICE_WORKER)
+if (websiteDataTypes.contains(WebsiteDataType::ServiceWorkerRegistrations))
+

[webkit-changes] [223157] branches/safari-604-branch

2017-10-10 Thread jmarcell 
Title: [223157] branches/safari-604-branch








Revision 223157
Author jmarc...@apple.com
Date 2017-10-10 16:46:05 -0700 (Tue, 10 Oct 2017)


Log Message
Cherry-pick r222478. rdar://problem/34771020

Modified Paths

branches/safari-604-branch/LayoutTests/ChangeLog
branches/safari-604-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.h
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.mm
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.h
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.h
branches/safari-604-branch/Source/WebCore/testing/Internals.cpp
branches/safari-604-branch/Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp
branches/safari-604-branch/Source/WebCore/testing/MockLibWebRTCPeerConnection.h
branches/safari-604-branch/Source/WebKit/ChangeLog
branches/safari-604-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
branches/safari-604-branch/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme


Added Paths

branches/safari-604-branch/LayoutTests/webrtc/video-interruption-expected.txt
branches/safari-604-branch/LayoutTests/webrtc/video-interruption.html
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/VideoToolBoxDecoderFactory.cpp
branches/safari-604-branch/Source/WebCore/platform/mediastream/libwebrtc/VideoToolBoxDecoderFactory.h




Diff

Modified: branches/safari-604-branch/LayoutTests/ChangeLog (223156 => 223157)

--- branches/safari-604-branch/LayoutTests/ChangeLog	2017-10-10 23:40:39 UTC (rev 223156)
+++ branches/safari-604-branch/LayoutTests/ChangeLog	2017-10-10 23:46:05 UTC (rev 223157)
@@ -1,3 +1,18 @@
+2017-10-10  Jason Marcell  
+
+Cherry-pick r222478. rdar://problem/34771020
+
+2017-09-25  Youenn Fablet  
+
+WebRTC video does not resume receiving when switching back to Safari 11 on iOS
+https://bugs.webkit.org/show_bug.cgi?id=175472
+
+
+Reviewed by Darin Adler.
+
+* webrtc/video-interruption-expected.txt: Added.
+* webrtc/video-interruption.html: Added.
+
 2017-10-09  Jason Marcell  
 
 Cherry-pick r222779. rdar://problem/34820881


Added: branches/safari-604-branch/LayoutTests/webrtc/video-interruption-expected.txt (0 => 223157)

--- branches/safari-604-branch/LayoutTests/webrtc/video-interruption-expected.txt	(rev 0)
+++ branches/safari-604-branch/LayoutTests/webrtc/video-interruption-expected.txt	2017-10-10 23:46:05 UTC (rev 223157)
@@ -0,0 +1,4 @@
+ 
+
+PASS Basic video exchange with media session interruption 
+


Added: branches/safari-604-branch/LayoutTests/webrtc/video-interruption.html (0 => 223157)

--- branches/safari-604-branch/LayoutTests/webrtc/video-interruption.html	(rev 0)
+++ branches/safari-604-branch/LayoutTests/webrtc/video-interruption.html	2017-10-10 23:46:05 UTC (rev 223157)
@@ -0,0 +1,85 @@
+
+
+
+
+Testing basic video exchange from offerer to receiver
+
+
+
+
+
+