[webkit-changes] [229525] trunk/Source/WebCore

[mcatanzaro]

Title: [229525] trunk/Source/WebCore








Revision 229525
Author mcatanz...@igalia.com
Date 2018-03-12 02:14:19 -0700 (Mon, 12 Mar 2018)


Log Message
[GTK] Crash in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland
https://bugs.webkit.org/show_bug.cgi?id=176490

Reviewed by Žan Doberšek.

Destroy the wl_display with wl_display_disconnect() (client process API), not
wl_display_destroy() (server process API). It has to be destroyed last, so explicitly
destroy the wl_registry and wl_compositor first.

* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229524 => 229525)

--- trunk/Source/WebCore/ChangeLog	2018-03-12 09:12:12 UTC (rev 229524)
+++ trunk/Source/WebCore/ChangeLog	2018-03-12 09:14:19 UTC (rev 229525)
@@ -1,3 +1,17 @@
+2018-03-12  Michael Catanzaro  
+
+[GTK] Crash in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland
+https://bugs.webkit.org/show_bug.cgi?id=176490
+
+Reviewed by Žan Doberšek.
+
+Destroy the wl_display with wl_display_disconnect() (client process API), not
+wl_display_destroy() (server process API). It has to be destroyed last, so explicitly
+destroy the wl_registry and wl_compositor first.
+
+* platform/graphics/wayland/PlatformDisplayWayland.cpp:
+(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
+
 2018-03-10  Megan Gardner  
 
 Media query for default appearance


Modified: trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp (229524 => 229525)

--- trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2018-03-12 09:12:12 UTC (rev 229524)
+++ trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2018-03-12 09:14:19 UTC (rev 229525)
@@ -67,8 +67,11 @@
 
 PlatformDisplayWayland::~PlatformDisplayWayland()
 {
-if (m_nativeDisplayOwned == NativeDisplayOwned::Yes)
-wl_display_destroy(m_display);
+if (m_nativeDisplayOwned == NativeDisplayOwned::Yes) {
+m_compositor = nullptr;
+m_registry = nullptr;
+wl_display_disconnect(m_display);
+}
 }
 
 void PlatformDisplayWayland::initialize(wl_display* display)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229524] releases/WebKitGTK/webkit-2.20

[carlosgc]

Title: [229524] releases/WebKitGTK/webkit-2.20








Revision 229524
Author carlo...@webkit.org
Date 2018-03-12 02:12:12 -0700 (Mon, 12 Mar 2018)


Log Message
Merge r229461 - [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form
https://bugs.webkit.org/show_bug.cgi?id=183510

Reviewed by Michael Catanzaro.

Source/WebKit:

In 2.22 WebKitDOMHTMLFormElement will be deprecated in GTK+ port and won't still exist in WPE. The new
_javascript_ GLib API will be used to replace most of the DOM API, but a few classes will remain with a minimal
API for things that can't be done with _javascript_. WebKitDOMElement will stay and will be added to WPE as well,
so if we change the signal parameter to WebKitDOMElement we will be able to keep using
WebKitWebPage::will-submit-form without any changes. WPE will gain this signal and the rest of the API that uses
DOM.

* WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkit_web_page_class_init):

Tools:

Update the test to use WebKitDOMElement instead and fix a memory leak.

* TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(handleFormSubmissionCallback):
(willSubmitFormCallback):

Modified Paths

releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
releases/WebKitGTK/webkit-2.20/Tools/ChangeLog
releases/WebKitGTK/webkit-2.20/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog (229523 => 229524)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 09:10:23 UTC (rev 229523)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 09:12:12 UTC (rev 229524)
@@ -1,3 +1,20 @@
+2018-03-09  Carlos Garcia Campos  
+
+[GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form
+https://bugs.webkit.org/show_bug.cgi?id=183510
+
+Reviewed by Michael Catanzaro.
+
+In 2.22 WebKitDOMHTMLFormElement will be deprecated in GTK+ port and won't still exist in WPE. The new
+_javascript_ GLib API will be used to replace most of the DOM API, but a few classes will remain with a minimal
+API for things that can't be done with _javascript_. WebKitDOMElement will stay and will be added to WPE as well,
+so if we change the signal parameter to WebKitDOMElement we will be able to keep using
+WebKitWebPage::will-submit-form without any changes. WPE will gain this signal and the rest of the API that uses
+DOM.
+
+* WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
+(webkit_web_page_class_init):
+
 2018-03-07  Carlos Garcia Campos  
 
 REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp (229523 => 229524)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp	2018-03-12 09:10:23 UTC (rev 229523)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp	2018-03-12 09:12:12 UTC (rev 229524)
@@ -417,7 +417,7 @@
 g_ptr_array_add(textFieldValues.get(), g_strdup(pair.second.utf8().data()));
 }
 
-g_signal_emit(m_webPage, signals[WILL_SUBMIT_FORM], 0, WebKit::kit(formElement), step, webkitSourceFrame, webkitTargetFrame, textFieldNames.get(), textFieldValues.get());
+g_signal_emit(m_webPage, signals[WILL_SUBMIT_FORM], 0, WEBKIT_DOM_ELEMENT(WebKit::kit(formElement)), step, webkitSourceFrame, webkitTargetFrame, textFieldNames.get(), textFieldValues.get());
 }
 
 WebKitWebPage* m_webPage;
@@ -591,7 +591,7 @@
 /**
  * WebKitWebPage::will-submit-form:
  * @web_page: the #WebKitWebPage on which the signal is emitted
- * @form: the #WebKitDOMHTMLFormElement to be submitted
+ * @form: the #WebKitDOMElement to be submitted, which will always correspond to an HTMLFormElement
  * @step: a #WebKitFormSubmissionEventType indicating the current
  * stage of form submission
  * @source_frame: the #WebKitFrame containing the form to be
@@ -640,7 +640,7 @@
 0, 0, nullptr,
 g_cclosure_marshal_generic,
 G_TYPE_NONE, 6,
-WEBKIT_DOM_TYPE_HTML_FORM_ELEMENT,
+WEBKIT_DOM_TYPE_ELEMENT,
 WEBKIT_TYPE_FORM_SUBMISSION_STEP,
 WEBKIT_TYPE_FRAME,
 WEBKIT_TYPE_FRAME,


Modified: releases/WebKitGTK/webkit-2.20/Tools/ChangeLog (229523 => 229524)

--- releases/WebKitGTK/webkit-2.20/Tools/ChangeLog	2018-03-12 09:10:23 UTC (rev 229523)
+++ releases/WebKitGTK/webkit-2.20/Tools/ChangeLog	2018-03-12 09:12:12 UTC (rev 229524)
@@ -1,3 +1,16 @@
+2018-03-09  Carlos Garcia Campos  
+
+[GTK] Do not 

[webkit-changes] [229528] releases/WebKitGTK/webkit-2.20

[carlosgc]

Title: [229528] releases/WebKitGTK/webkit-2.20








Revision 229528
Author carlo...@webkit.org
Date 2018-03-12 02:55:57 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.0 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.20.0.

Modified Paths

releases/WebKitGTK/webkit-2.20/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.20/ChangeLog (229527 => 229528)

--- releases/WebKitGTK/webkit-2.20/ChangeLog	2018-03-12 09:46:37 UTC (rev 229527)
+++ releases/WebKitGTK/webkit-2.20/ChangeLog	2018-03-12 09:55:57 UTC (rev 229528)
@@ -1,3 +1,9 @@
+2018-03-12  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.0 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2018-03-06  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.92 release.


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog (229527 => 229528)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 09:46:37 UTC (rev 229527)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 09:55:57 UTC (rev 229528)
@@ -1,3 +1,9 @@
+2018-03-12  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.0 release.
+
+* gtk/NEWS: Add release notes for 2.20.0.
+
 2018-03-09  Carlos Garcia Campos  
 
 [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS (229527 => 229528)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS	2018-03-12 09:46:37 UTC (rev 229527)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS	2018-03-12 09:55:57 UTC (rev 229528)
@@ -1,4 +1,15 @@
 ==
+WebKitGTK+  2.20.0
+==
+
+What's new in WebKitGTK+ 2.20.0?
+
+  - Remove resource load statistics API, it's not ready for stable yet.
+  - Make it possible to close the inspector when webkit_web_view_get_inspector() hasn't been called.
+  - Use WebKitDOMElement instead of WebKitDOMHTMLFormElement in paramater of signal WebKitWebPage::will-submit-form.
+  - Fix a crash when trying to disconnect the wayland connection.
+
+==
 WebKitGTK+ 2.19.92
 ==
 


Modified: releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake (229527 => 229528)

--- releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake	2018-03-12 09:46:37 UTC (rev 229527)
+++ releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake	2018-03-12 09:55:57 UTC (rev 229528)
@@ -1,11 +1,11 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 19 92)
+SET_PROJECT_VERSION(2 20 0)
 set(WEBKITGTK_API_VERSION 4.0)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 64 5 27)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 7 7)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 65 0 28)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 8 7)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229529] releases/WebKitGTK/webkit-2.20.0/

[carlosgc]

Title: [229529] releases/WebKitGTK/webkit-2.20.0/








Revision 229529
Author carlo...@webkit.org
Date 2018-03-12 02:56:27 -0700 (Mon, 12 Mar 2018)


Log Message
WebKitGTK+ 2.20.0

Added Paths

releases/WebKitGTK/webkit-2.20.0/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229526] releases/WebKitGTK/webkit-2.20/Source/WebCore

[carlosgc]

Title: [229526] releases/WebKitGTK/webkit-2.20/Source/WebCore








Revision 229526
Author carlo...@webkit.org
Date 2018-03-12 02:28:26 -0700 (Mon, 12 Mar 2018)


Log Message
Merge r229525 - [GTK] Crash in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland
https://bugs.webkit.org/show_bug.cgi?id=176490

Reviewed by Žan Doberšek.

Destroy the wl_display with wl_display_disconnect() (client process API), not
wl_display_destroy() (server process API). It has to be destroyed last, so explicitly
destroy the wl_registry and wl_compositor first.

* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):

Modified Paths

releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog (229525 => 229526)

--- releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-03-12 09:14:19 UTC (rev 229525)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-03-12 09:28:26 UTC (rev 229526)
@@ -1,3 +1,17 @@
+2018-03-12  Michael Catanzaro  
+
+[GTK] Crash in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland
+https://bugs.webkit.org/show_bug.cgi?id=176490
+
+Reviewed by Žan Doberšek.
+
+Destroy the wl_display with wl_display_disconnect() (client process API), not
+wl_display_destroy() (server process API). It has to be destroyed last, so explicitly
+destroy the wl_registry and wl_compositor first.
+
+* platform/graphics/wayland/PlatformDisplayWayland.cpp:
+(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
+
 2018-03-01  Carlos Garcia Campos  
 
 REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not correctly handled


Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp (229525 => 229526)

--- releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2018-03-12 09:14:19 UTC (rev 229525)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2018-03-12 09:28:26 UTC (rev 229526)
@@ -67,8 +67,11 @@
 
 PlatformDisplayWayland::~PlatformDisplayWayland()
 {
-if (m_nativeDisplayOwned == NativeDisplayOwned::Yes)
-wl_display_destroy(m_display);
+if (m_nativeDisplayOwned == NativeDisplayOwned::Yes) {
+m_compositor = nullptr;
+m_registry = nullptr;
+wl_display_disconnect(m_display);
+}
 }
 
 void PlatformDisplayWayland::initialize(wl_display* display)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229523] releases/WebKitGTK/webkit-2.20/Source/WebKit

[carlosgc]

Title: [229523] releases/WebKitGTK/webkit-2.20/Source/WebKit








Revision 229523
Author carlo...@webkit.org
Date 2018-03-12 02:10:23 -0700 (Mon, 12 Mar 2018)


Log Message
Merge r229396 - REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close
https://bugs.webkit.org/show_bug.cgi?id=181126

Reviewed by Carlos Alberto Lopez Perez.

Fix the condition to decide whether to detach the inspector view ourselves.

* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector view from its parent if we don't have a client
or the client didn't detach it.

Modified Paths

releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog (229522 => 229523)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 03:46:57 UTC (rev 229522)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-03-12 09:10:23 UTC (rev 229523)
@@ -1,3 +1,16 @@
+2018-03-07  Carlos Garcia Campos  
+
+REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close
+https://bugs.webkit.org/show_bug.cgi?id=181126
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Fix the condition to decide whether to detach the inspector view ourselves.
+
+* UIProcess/gtk/WebInspectorProxyGtk.cpp:
+(WebKit::WebInspectorProxy::platformDetach): Remove the inspector view from its parent if we don't have a client
+or the client didn't detach it.
+
 2018-03-06  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.92 release.


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp (229522 => 229523)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2018-03-12 03:46:57 UTC (rev 229522)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2018-03-12 09:10:23 UTC (rev 229523)
@@ -396,7 +396,7 @@
 return;
 
 GRefPtr inspectorView = m_inspectorView;
-if (m_client && !m_client->detach(*this)) {
+if (!m_client || !m_client->detach(*this)) {
 // Detach is called when m_isAttached is true, but it could called before
 // the inspector is opened if the inspector is shown/closed quickly. So,
 // we might not have a parent yet.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229527] trunk

[carlosgc]

Title: [229527] trunk








Revision 229527
Author carlo...@webkit.org
Date 2018-03-12 02:46:37 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed. Fix library version of _javascript_CoreGTK.

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (229526 => 229527)

--- trunk/ChangeLog	2018-03-12 09:28:26 UTC (rev 229526)
+++ trunk/ChangeLog	2018-03-12 09:46:37 UTC (rev 229527)
@@ -1,3 +1,9 @@
+2018-03-12  Carlos Garcia Campos  
+
+Unreviewed. Fix library version of _javascript_CoreGTK.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2018-03-09  Carlos Garcia Campos  
 
 Unreviewed. Bump WebKitGTK+ version to 2.21.0.


Modified: trunk/Source/cmake/OptionsGTK.cmake (229526 => 229527)

--- trunk/Source/cmake/OptionsGTK.cmake	2018-03-12 09:28:26 UTC (rev 229526)
+++ trunk/Source/cmake/OptionsGTK.cmake	2018-03-12 09:46:37 UTC (rev 229527)
@@ -5,7 +5,7 @@
 set(WEBKITGTK_API_VERSION 4.0)
 
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 66 0 29)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 27 0 9)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 26 0 8)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229534] trunk/LayoutTests

[pvollan]

Title: [229534] trunk/LayoutTests








Revision 229534
Author pvol...@apple.com
Date 2018-03-12 08:42:29 -0700 (Mon, 12 Mar 2018)


Log Message
Mark webanimations/css-animations.html and webanimations/css-transitions.html as failures on Windows.
https://bugs.webkit.org/show_bug.cgi?id=183569

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (229533 => 229534)

--- trunk/LayoutTests/ChangeLog	2018-03-12 14:13:03 UTC (rev 229533)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 15:42:29 UTC (rev 229534)
@@ -1,3 +1,12 @@
+2018-03-12  Per Arne Vollan  
+
+Mark webanimations/css-animations.html and webanimations/css-transitions.html as failures on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=183569
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-03-12  Frederic Wang  
 
 Do not rely on Latin Modern Math to test fraction/radical bars


Modified: trunk/LayoutTests/platform/win/TestExpectations (229533 => 229534)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-03-12 14:13:03 UTC (rev 229533)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-03-12 15:42:29 UTC (rev 229534)
@@ -3931,3 +3931,6 @@
 webkit.org/b/183393 fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-async-delegates.html [ Skip ]
 webkit.org/b/183393 fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html [ Skip ]
 webkit.org/b/183393 fast/loader/window-open-to-invalid-url-disallowed.html [ Skip ]
+
+webkit.org/b/183569 webanimations/css-animations.html [ Failure ]
+webkit.org/b/183569 webanimations/css-transitions.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229539] trunk/LayoutTests

[cdumez]

Title: [229539] trunk/LayoutTests








Revision 229539
Author cdu...@apple.com
Date 2018-03-12 10:50:53 -0700 (Mon, 12 Mar 2018)


Log Message
http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates
https://bugs.webkit.org/show_bug.cgi?id=183460

Reviewed by Alex Christensen.

The test has 3 frames which all initially load "about:blank". Then using document.write(), it inserts
HTML in each frame.
Frame 1: body has an onload event handler, which calls JS is click an anchor link to navigate the frame.
Frame 2: body has an onload event handler to do some logging
Frame 3: body has an onload event handler and finishes the test (calls testRunner.notifyDone())

The issue is that with asynchronous policy delegates, the first frame may not have navigated yet by the
time the third frame is loaded. Indeed, the onload event of the first frame merely clicks am anchor link
which will trigger a navigation policy check and then later navigate.

To make the test more robust, we now count the number of loads and call testRunner.notifyDone() when
we've reached the expected number of loads.

* http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt: Added.
* http/tests/security/frame-loading-via-document-write-async-delegates.html: Copied from LayoutTests/http/tests/security/frame-loading-via-document-write.html.
* http/tests/security/frame-loading-via-document-write.html:
* http/tests/security/resources/frame-loading-via-document-write.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/security/frame-loading-via-document-write-expected.txt
trunk/LayoutTests/http/tests/security/frame-loading-via-document-write.html
trunk/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js


Added Paths

trunk/LayoutTests/http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt
trunk/LayoutTests/http/tests/security/frame-loading-via-document-write-async-delegates.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229538 => 229539)

--- trunk/LayoutTests/ChangeLog	2018-03-12 16:47:59 UTC (rev 229538)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 17:50:53 UTC (rev 229539)
@@ -1,3 +1,28 @@
+2018-03-12  Chris Dumez  
+
+http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates
+https://bugs.webkit.org/show_bug.cgi?id=183460
+
+Reviewed by Alex Christensen.
+
+The test has 3 frames which all initially load "about:blank". Then using document.write(), it inserts
+HTML in each frame.
+Frame 1: body has an onload event handler, which calls JS is click an anchor link to navigate the frame.
+Frame 2: body has an onload event handler to do some logging
+Frame 3: body has an onload event handler and finishes the test (calls testRunner.notifyDone())
+
+The issue is that with asynchronous policy delegates, the first frame may not have navigated yet by the
+time the third frame is loaded. Indeed, the onload event of the first frame merely clicks am anchor link
+which will trigger a navigation policy check and then later navigate.
+
+To make the test more robust, we now count the number of loads and call testRunner.notifyDone() when
+we've reached the expected number of loads.
+
+* http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt: Added.
+* http/tests/security/frame-loading-via-document-write-async-delegates.html: Copied from LayoutTests/http/tests/security/frame-loading-via-document-write.html.
+* http/tests/security/frame-loading-via-document-write.html:
+* http/tests/security/resources/frame-loading-via-document-write.js:
+
 2018-03-12  Per Arne Vollan  
 
 Mark webanimations/css-animations.html and webanimations/css-transitions.html as failures on Windows.


Modified: trunk/LayoutTests/TestExpectations (229538 => 229539)

--- trunk/LayoutTests/TestExpectations	2018-03-12 16:47:59 UTC (rev 229538)
+++ trunk/LayoutTests/TestExpectations	2018-03-12 17:50:53 UTC (rev 229539)
@@ -188,6 +188,10 @@
 imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html [ DumpJSConsoleLogInStdErr ]
 
+# Line number in the console logging may change so we silence it to avoid flakiness.
+http/tests/security/frame-loading-via-document-write.html [ DumpJSConsoleLogInStdErr ]
+http/tests/security/frame-loading-via-document-write-async-delegates.html [ DumpJSConsoleLogInStdErr ]
+
 webkit.org/b/181901 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ]
 

[webkit-changes] [229540] trunk

[commit-queue]

Title: [229540] trunk








Revision 229540
Author commit-qu...@webkit.org
Date 2018-03-12 10:53:39 -0700 (Mon, 12 Mar 2018)


Log Message
Add a query and fragment exception to history API's unique origin restriction.
https://bugs.webkit.org/show_bug.cgi?id=183028

Patch by Danyao Wang  on 2018-03-12
Reviewed by Brent Fulgham.

Tests: http/tests/navigation/pushstate-at-unique-origin-denied.php
   Tools/TestWebKitAPI/Tests/WebCore/URL.cpp

* page/History.cpp:
(WebCore::History::stateObjectAdded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/History.cpp
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/URL.h
trunk/Tools/TestWebKitAPI/Tests/WebCore/URL.cpp


Added Paths

trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied-expected.txt
trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php




Diff

Added: trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied-expected.txt (0 => 229540)

--- trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied-expected.txt	2018-03-12 17:53:39 UTC (rev 229540)
@@ -0,0 +1,6 @@
+
+PASS pushState to a new path in unique origin should fail with SecurityError 
+PASS pushState #hash in unique origin should not fail with SecurityError 
+PASS pushState ?query in unique origin should not fail with SecurityError 
+PASS pushState ?query#hash in unique origin should not fail with SecurityError 
+


Added: trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php (0 => 229540)

--- trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php	(rev 0)
+++ trunk/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.php	2018-03-12 17:53:39 UTC (rev 229540)
@@ -0,0 +1,40 @@
+
+
+var originURL = document.URL;
+test(function () {
+assert_throws('SecurityError', function () {
+history.pushState(null, null, originURL + "/path");
+});
+}, 'pushState to a new path in unique origin should fail with SecurityError');
+
+test(function () {
+try {
+history.pushState(null, null, originURL + "#hash");
+done();
+} catch (e) {
+assert_unreached("pushState #hash should not fail.");
+}
+}, 'pushState #hash in unique origin should not fail with SecurityError');
+
+test(function () {
+try {
+history.pushState(null, null, originURL + "?query");
+done();
+} catch (e) {
+assert_unreached("pushState ?query should not fail.");
+}
+}, 'pushState ?query in unique origin should not fail with SecurityError');
+
+test(function () {
+try {
+history.pushState(null, null, originURL + "?query#hash");
+done();
+} catch (e) {
+assert_unreached("pushState ?query#hash should not fail.");
+}
+}, 'pushState ?query#hash in unique origin should not fail with SecurityError');
+


Modified: trunk/Source/WebCore/ChangeLog (229539 => 229540)

--- trunk/Source/WebCore/ChangeLog	2018-03-12 17:50:53 UTC (rev 229539)
+++ trunk/Source/WebCore/ChangeLog	2018-03-12 17:53:39 UTC (rev 229540)
@@ -1,3 +1,16 @@
+2018-03-12  Danyao Wang  
+
+Add a query and fragment exception to history API's unique origin restriction.
+https://bugs.webkit.org/show_bug.cgi?id=183028
+
+Reviewed by Brent Fulgham.
+
+Tests: http/tests/navigation/pushstate-at-unique-origin-denied.php
+   Tools/TestWebKitAPI/Tests/WebCore/URL.cpp
+
+* page/History.cpp:
+(WebCore::History::stateObjectAdded):
+
 2018-03-12  Antti Koivisto  
 
 Don't invalidate descendants for nth pseudo classes unless needed


Modified: trunk/Source/WebCore/page/History.cpp (229539 => 229540)

--- trunk/Source/WebCore/page/History.cpp	2018-03-12 17:50:53 UTC (rev 229539)
+++ trunk/Source/WebCore/page/History.cpp	2018-03-12 17:53:39 UTC (rev 229540)
@@ -192,7 +192,13 @@
 };
 if (!protocolHostAndPortAreEqual(fullURL, documentURL) || fullURL.user() != documentURL.user() || fullURL.pass() != documentURL.pass())
 return createBlockedURLSecurityErrorWithMessageSuffix("Protocols, domains, ports, usernames, and passwords must match.");
-if (!m_frame->document()->securityOrigin().canRequest(fullURL) && (fullURL.path() != documentURL.path() || fullURL.query() != documentURL.query()))
+
+const auto& documentSecurityOrigin = m_frame->document()->securityOrigin();
+// We allow sandboxed documents, 'data:'/'file:' URLs, etc. to use 'pushState'/'replaceState' to modify the URL query and fragments.
+// See https://bugs.webkit.org/show_bug.cgi?id=183028 for the compatibility concerns.
+bool allowSandboxException = (documentSecurityOrigin.isLocal() || documentSecurityOrigin.isUnique()) && 

[webkit-changes] [229541] trunk/Tools

[commit-queue]

Title: [229541] trunk/Tools








Revision 229541
Author commit-qu...@webkit.org
Date 2018-03-12 11:05:36 -0700 (Mon, 12 Mar 2018)


Log Message
[webkitpy] Remove openssl command dependency.
https://bugs.webkit.org/show_bug.cgi?id=183494

Patch by Basuke Suzuki  on 2018-03-12
Reviewed by Ryosuke Niwa.

Added Python implementation of PEM file perser and switched to use that
from external `openssl` command.

* Scripts/webkitpy/common/system/pemfile.py: Added.
(load):
(BadFormatError):
(Pem):
(Pem.__init__):
(Pem.get):
(Pem.get_all):
(Pem.certificate):
(Pem.private_key):
(Pem.csr):
(Pem.certificate_request):
(Pem.certificate_signing_request):
(_parse_pem_format):
(_parse_pem_format.find_begin):
(_parse_pem_format.find_end):
(_parse_pem_format.sections):
* Scripts/webkitpy/common/system/pemfile_unittest.py: Added.
(PemFileTest):
(PemFileTest.test_parse):
(PemFileTest.test_parse_bad_format):
* Scripts/webkitpy/port/base.py:
(Port.start_websocket_server):
(Port._extract_certificate_from_pem): Deleted.
(Port._extract_private_key_from_pem): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/system/pemfile.py
trunk/Tools/Scripts/webkitpy/common/system/pemfile_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (229540 => 229541)

--- trunk/Tools/ChangeLog	2018-03-12 17:53:39 UTC (rev 229540)
+++ trunk/Tools/ChangeLog	2018-03-12 18:05:36 UTC (rev 229541)
@@ -1,3 +1,38 @@
+2018-03-12  Basuke Suzuki  
+
+[webkitpy] Remove openssl command dependency.
+https://bugs.webkit.org/show_bug.cgi?id=183494
+
+Reviewed by Ryosuke Niwa.
+
+Added Python implementation of PEM file perser and switched to use that
+from external `openssl` command.
+
+* Scripts/webkitpy/common/system/pemfile.py: Added.
+(load):
+(BadFormatError):
+(Pem):
+(Pem.__init__):
+(Pem.get):
+(Pem.get_all):
+(Pem.certificate):
+(Pem.private_key):
+(Pem.csr):
+(Pem.certificate_request):
+(Pem.certificate_signing_request):
+(_parse_pem_format):
+(_parse_pem_format.find_begin):
+(_parse_pem_format.find_end):
+(_parse_pem_format.sections):
+* Scripts/webkitpy/common/system/pemfile_unittest.py: Added.
+(PemFileTest):
+(PemFileTest.test_parse):
+(PemFileTest.test_parse_bad_format):
+* Scripts/webkitpy/port/base.py:
+(Port.start_websocket_server):
+(Port._extract_certificate_from_pem): Deleted.
+(Port._extract_private_key_from_pem): Deleted.
+
 2018-03-12  Javier Fernandez  
 
 Remove GridLayout runtime flag


Added: trunk/Tools/Scripts/webkitpy/common/system/pemfile.py (0 => 229541)

--- trunk/Tools/Scripts/webkitpy/common/system/pemfile.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/system/pemfile.py	2018-03-12 18:05:36 UTC (rev 229541)
@@ -0,0 +1,139 @@
+# Copyright (C) 2018 Sony Interactive Entertainment Inc.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+import re
+
+
+def load(filesystem, path):
+"""Load PEM file and return PEM object"""
+return Pem(filesystem.read_text_file(path))
+
+
+class BadFormatError(Exception):
+"""Bad format error"""
+pass
+
+
+class Pem(object):
+"""
+Container for certificate related information.
+Each section in PEM file can be accessible by get().
+e.g.
+pem = pemfile.load(filesystem, "/path/to/sample.pem")
+assert pem.certificate.startswith("-BEGIN CERTIFICATE-")
+"""
+
+def __init__(self, content):
+self._contents = 

[webkit-changes] [229531] trunk

[jfernandez]

Title: [229531] trunk








Revision 229531
Author jfernan...@igalia.com
Date 2018-03-12 06:48:01 -0700 (Mon, 12 Mar 2018)


Log Message
Remove GridLayout runtime flag
https://bugs.webkit.org/show_bug.cgi?id=183484

Reviewed by Myles C. Maxfield.

Source/WebCore:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

No new tests, because there are no changes in functionality.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertContentAlignmentData):
* css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/parser/CSSParserMode.h:
(WebCore::CSSParserContextHash::hash):
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
* dom/Document.cpp:
* dom/Document.h:
* page/RuntimeEnabledFeatures.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialDefaultAlignment):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

* Shared/WebPreferences.yaml:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):

LayoutTests:

Since the GridLayout runtime flag is removed and the feature
enabled by default, we don't need the tests verifying the
codepaths run when the feature is disabled.

* css3/flexbox/flexbox-lines-must-be-stretched-by-default.html:
* css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt: Removed.
* css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html: Removed.
* fast/css-grid-layout/grid-disable-expected.txt: Removed.
* fast/css-grid-layout/grid-disable.html: Removed.
* fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt: Removed.
* fast/css/ensure-flexbox-compatibility-with-initial-values.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt
trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/css/parser/CSSParser.cpp
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/css/parser/CSSParserMode.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm


Removed Paths

trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt
trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt

[webkit-changes] [229532] trunk

[zandobersek]

Title: [229532] trunk








Revision 229532
Author zandober...@gmail.com
Date 2018-03-12 06:50:36 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed. Unbreak the WPE layout testing that's been broken since
r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
for the WPE port as well.

* Source/cmake/OptionsWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (229531 => 229532)

--- trunk/ChangeLog	2018-03-12 13:48:01 UTC (rev 229531)
+++ trunk/ChangeLog	2018-03-12 13:50:36 UTC (rev 229532)
@@ -1,3 +1,13 @@
+2018-03-12  Zan Dobersek  
+
+Unreviewed. Unbreak the WPE layout testing that's been broken since
+r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
+HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
+undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
+for the WPE port as well.
+
+* Source/cmake/OptionsWPE.cmake:
+
 2018-03-12  Carlos Garcia Campos  
 
 Unreviewed. Fix library version of _javascript_CoreGTK.


Modified: trunk/Source/cmake/OptionsWPE.cmake (229531 => 229532)

--- trunk/Source/cmake/OptionsWPE.cmake	2018-03-12 13:48:01 UTC (rev 229531)
+++ trunk/Source/cmake/OptionsWPE.cmake	2018-03-12 13:50:36 UTC (rev 229532)
@@ -24,6 +24,7 @@
 # Private options shared with other WebKit ports. Add options here only if
 # we need a value different from the default defined in WebKitFeatures.cmake.
 # Changing these options is completely unsupported.
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229542] trunk

[wenson_hsieh]

Title: [229542] trunk








Revision 229542
Author wenson_hs...@apple.com
Date 2018-03-12 12:25:19 -0700 (Mon, 12 Mar 2018)


Log Message
REGRESSION(r211643): Dismissing WKActionSheet should not also dismiss its presenting view controller
https://bugs.webkit.org/show_bug.cgi?id=183549


Reviewed by Andy Estes.

Source/WebKit:

Fixes the bug by dismissing the presented view controller (i.e. the action sheet or the view controller being
presented during rotation) rather than the presenting view controller.

Test: ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController

* UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet doneWithSheet:]):

Tools:

Add TestWebKitAPI support for testing WKWebViews embedded within presented view controllers, and use this to
check that dismissing an action sheet does not additionally cause the view controller being used to present the
web view to also dismiss.

* TestWebKitAPI/ClassMethodSwizzler.h: Added.
* TestWebKitAPI/ClassMethodSwizzler.mm: Added.
(TestWebKitAPI::ClassMethodSwizzler::ClassMethodSwizzler):
(TestWebKitAPI::ClassMethodSwizzler::~ClassMethodSwizzler):

Add ClassMethodSwizzler, an RAII which swizzles an Objective-C class method over its lifetime.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

Add a new API test that loads a view controller which embeds a WKWebView, and verifies that presenting and then
dismissing an action sheet from that web view does not cause the view controller to also dismiss.

(TestWebKitAPI::setOverrideViewControllerForFullscreenPresentation):
(TestWebKitAPI::overrideViewControllerForFullscreenPresentation):

Mock +[UIViewController _viewControllerForFullScreenPresentationFromView:] to return the web view. This works
around the fact that TestWebKitAPI is not a UI application, so certain pieces of UIKit API and SPI need to be
stubbed or mocked to simulate being a UI application. We can remove these workarounds once
https://webkit.org/b/175204 is addressed, and TestWebKitAPI becomes a UI application that can actually maintain
a root view controller and key window.

(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView initWithFrame:configuration:addToWindow:]):

Add a new initializer for TestWKWebView that doesn't force the view to be hosted within a UIWindow. This is used
by TestWKWebViewController to create a TestWKWebView in -loadView.

* TestWebKitAPI/ios/TestWKWebViewController.h: Added.
* TestWebKitAPI/ios/TestWKWebViewController.mm: Added.
(-[TestWKWebViewControllerWindow _beginKeyWindowDeferral]):
(-[TestWKWebViewControllerWindow _endKeyWindowDeferral]):

Stub out these methods to prevent UIKit from hitting assertions when making this UIWindow the key window. This
can also be removed once TestWebKitAPI is a UI application.

(-[TestWKWebViewController initWithFrame:configuration:]):
(-[TestWKWebViewController loadView]):
(-[TestWKWebViewController webView]):
(-[TestWKWebViewController dismissViewControllerAnimated:completion:]):
(-[TestWKWebViewController dismissalHandler]):
(-[TestWKWebViewController setDismissalHandler:]):

Add a UIViewController helper subclass whose -view is a WKWebView. The new API test presents this view
controller. Tests may also provide a dismissalHandler, which is invoked when the view controller is being
dismissed. The new API test uses this hook to verify that the view controller containing the web view isn't also
dismissed after the action sheet goes away.

* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKActionSheet.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h


Added Paths

trunk/Tools/TestWebKitAPI/ClassMethodSwizzler.h
trunk/Tools/TestWebKitAPI/ClassMethodSwizzler.mm
trunk/Tools/TestWebKitAPI/ios/TestWKWebViewController.h
trunk/Tools/TestWebKitAPI/ios/TestWKWebViewController.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (229541 => 229542)

--- trunk/Source/WebKit/ChangeLog	2018-03-12 18:05:36 UTC (rev 229541)
+++ trunk/Source/WebKit/ChangeLog	2018-03-12 19:25:19 UTC (rev 229542)
@@ -1,3 +1,19 @@
+2018-03-12  Wenson Hsieh  
+
+REGRESSION(r211643): Dismissing WKActionSheet should not also dismiss its presenting view controller
+https://bugs.webkit.org/show_bug.cgi?id=183549
+
+
+Reviewed by Andy Estes.
+
+Fixes the bug by dismissing the presented view controller (i.e. the action sheet or the view controller being
+presented during rotation) rather than the presenting view controller.
+
+Test: ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
+

[webkit-changes] [229543] trunk/Source/WebInspectorUI

[jond]

Title: [229543] trunk/Source/WebInspectorUI








Revision 229543
Author j...@apple.com
Date 2018-03-12 12:35:00 -0700 (Mon, 12 Mar 2018)


Log Message
Web Inspector: Remove redundant tooltips
https://bugs.webkit.org/show_bug.cgi?id=183099

Reviewed by Matt Baker.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WI.contentLoaded):
Instantiate ConsoleDrawer so the keyboard shortcuts for FindBanner are available.

* UserInterface/Views/BreakpointTreeElement.js:
(WI.BreakpointTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

* UserInterface/Views/ButtonNavigationItem.js:
(WI.ButtonNavigationItem):
Only show tooltips when the button style is an image.

* UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer):
(WI.ConsoleDrawer.prototype.toggleButtonShortcutTooltip):
Added helper to set the toggle button keyboard shortcut tooltip.

* UserInterface/Views/DOMBreakpointTreeElement.js:
(WI.DOMBreakpointTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

* UserInterface/Views/DOMNodeTreeElement.js:
(WI.DOMNodeTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

* UserInterface/Views/FindBanner.js:
(WI.FindBanner):
* UserInterface/Views/HierarchicalPathComponent.js:
(WI.HierarchicalPathComponent):
(WI.HierarchicalPathComponent.prototype.get tooltip):
(WI.HierarchicalPathComponent.prototype.set tooltip):
(WI.HierarchicalPathComponent.prototype.get hideTooltip):
(WI.HierarchicalPathComponent.prototype.set hideTooltip):
(WI.HierarchicalPathComponent.prototype._updateElementTitleAndText):
Add tooltip management features to manage tooltips separately of the displayName,
and provide a behavior to hide tooltips while retaining the tooltip data.

* UserInterface/Views/HierarchicalPathNavigationItem.js:
(WI.HierarchicalPathNavigationItem.prototype.updateLayout):
Hide tooltips when fully visible, show tooltips for collapsed items.

* UserInterface/Views/PinnedTabBarItem.js:
(WI.PinnedTabBarItem.prototype.titleDidChange):
Set tooltips for pinned tab bar items.

* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole):
Set the ConsoleDrawer toggle button tooltip after the keyboard shortcut is registered.

* UserInterface/Views/StorageTreeElement.js:
(WI.StorageTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

* UserInterface/Views/TabBarItem.js:
(WI.TabBarItem.prototype.get title):
(WI.TabBarItem.prototype.set title):
(WI.TabBarItem.prototype.titleDidChange):
(WI.TabBarItem):
Add title property management with an overridable titleDidChange handler for
setting tooltips when needed.

* UserInterface/Views/TimelineTreeElement.js:
(WI.TimelineTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

* UserInterface/Views/ToggleButtonNavigationItem.js:
(WI.ToggleButtonNavigationItem.prototype.set defaultToolTip):
Added a setter for manging the default tooltip of a toggle button.

* UserInterface/Views/XHRBreakpointTreeElement.js:
(WI.XHRBreakpointTreeElement):
Suppress tooltips by setting the tooltipHandledSeprately flag with no custom handler.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMBreakpointTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/PinnedTabBarItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
trunk/Source/WebInspectorUI/UserInterface/Views/StorageTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/ToggleButtonNavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/XHRBreakpointTreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (229542 => 229543)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-03-12 19:25:19 UTC (rev 229542)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-03-12 19:35:00 UTC (rev 229543)
@@ -1,3 +1,84 @@
+2018-03-12  Jon Davis  
+
+Web Inspector: Remove redundant tooltips
+https://bugs.webkit.org/show_bug.cgi?id=183099
+
+Reviewed by Matt Baker.
+
+* Localizations/en.lproj/localizedStrings.js:
+* 

[webkit-changes] [229536] trunk/Source/ThirdParty/libwebrtc

[youenn]

Title: [229536] trunk/Source/ThirdParty/libwebrtc








Revision 229536
Author you...@apple.com
Date 2018-03-12 09:14:03 -0700 (Mon, 12 Mar 2018)


Log Message
Remove empty cpp files in Source/ThirdParty/libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=183529

Reviewed by Eric Carlson.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog


Removed Paths

trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/boringssl_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/ssl_privkey_cc.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/fir_filter.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/config.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/ilbc/test/empty.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/isac/empty.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/NETEQTEST_DummyRTPpacket.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/NETEQTEST_RTPpacket.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/RTPchange.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/RTPencode.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/RTPjitter.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/neteq/test/RTPtimeshift.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/source/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/test/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_device/test/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/decimator_by_4.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/decimator_by_4_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/agc2/digital_gain_applier.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/congestion_controller.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/congestion_controller_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/desktop_capture/resolution_change_detector.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/test/predictive_packet_manipulator.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/tools/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/sequence_number_util_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/dtlstransportchannel.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/dtlstransportchannel_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/transportcontroller.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/transportcontroller_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/quic/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/quicdatachannel.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/quicdatachannel_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/quicdatatransport.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/quicdatatransport_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsession.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsession_unittest.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/audio_jni.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/filevideocapturer_jni.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/media_jni.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/native_handle_impl.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/null_audio_jni.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/android/src/jni/null_media_jni.cc

[webkit-changes] [229537] trunk/Source/WebCore

[antti]

Title: [229537] trunk/Source/WebCore








Revision 229537
Author an...@apple.com
Date 2018-03-12 09:15:46 -0700 (Mon, 12 Mar 2018)


Log Message
Don't invalidate descendants for nth pseudo classes unless needed
https://bugs.webkit.org/show_bug.cgi?id=183566

Reviewed by Zalan Bujtas.

We currently invalidate the whole subtrees that may match :nth-child and similar. In many common
cases we know that only the direct siblings may be affected.

* css/SelectorChecker.cpp:
(WebCore::localContextForParent):
(WebCore::SelectorChecker::matchRecursively const):

Track if the context matches the subject element if the selector or its siblings only.

(WebCore::SelectorChecker::checkOne const):

Use different bits of descendant and child invalidation cases.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::fragmentMatchesRightmostOrAdjacentElement):
(WebCore::SelectorCompiler::constructFragmentsInternal):

Track if the context matches the subject element if the selector or its siblings only.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild):

Use different bits of descendant and child invalidation cases.

* dom/Element.cpp:
(WebCore::invalidateForForwardPositionalRules):
(WebCore::invalidateForBackwardPositionalRules):

Invalidate more precisely based on the new bits.

(WebCore::checkForSiblingStyleChanges):
(WebCore::Element::setDescendantsAffectedByForwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByBackwardPositionalRules):
(WebCore::Element::hasFlagsSetDuringStylingOfChildren const):
(WebCore::Element::rareDataDescendantsAffectedByForwardPositionalRules const):
(WebCore::Element::rareDataDescendantsAffectedByBackwardPositionalRules const):

New bits.

* dom/Element.h:
(WebCore::Element::descendantsAffectedByForwardPositionalRules const):
(WebCore::Element::descendantsAffectedByBackwardPositionalRules const):
* dom/ElementRareData.h:
(WebCore::ElementRareData::descendantsAffectedByForwardPositionalRules const):
(WebCore::ElementRareData::setDescendantsAffectedByForwardPositionalRules):
(WebCore::ElementRareData::descendantsAffectedByBackwardPositionalRules const):
(WebCore::ElementRareData::setDescendantsAffectedByBackwardPositionalRules):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetStyleRelations):
* style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):
* style/StyleRelations.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/style/StyleRelations.cpp
trunk/Source/WebCore/style/StyleRelations.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (229536 => 229537)

--- trunk/Source/WebCore/ChangeLog	2018-03-12 16:14:03 UTC (rev 229536)
+++ trunk/Source/WebCore/ChangeLog	2018-03-12 16:15:46 UTC (rev 229537)
@@ -1,3 +1,65 @@
+2018-03-12  Antti Koivisto  
+
+Don't invalidate descendants for nth pseudo classes unless needed
+https://bugs.webkit.org/show_bug.cgi?id=183566
+
+Reviewed by Zalan Bujtas.
+
+We currently invalidate the whole subtrees that may match :nth-child and similar. In many common
+cases we know that only the direct siblings may be affected.
+
+* css/SelectorChecker.cpp:
+(WebCore::localContextForParent):
+(WebCore::SelectorChecker::matchRecursively const):
+
+Track if the context matches the subject element if the selector or its siblings only.
+
+(WebCore::SelectorChecker::checkOne const):
+
+Use different bits of descendant and child invalidation cases.
+
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::fragmentMatchesRightmostOrAdjacentElement):
+(WebCore::SelectorCompiler::constructFragmentsInternal):
+
+Track if the context matches the subject element if the selector or its siblings only.
+
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild):
+
+Use different bits of descendant and child invalidation cases.
+
+* dom/Element.cpp:
+(WebCore::invalidateForForwardPositionalRules):
+(WebCore::invalidateForBackwardPositionalRules):
+
+Invalidate more precisely based on the new bits.
+
+(WebCore::checkForSiblingStyleChanges):
+(WebCore::Element::setDescendantsAffectedByForwardPositionalRules):
+

[webkit-changes] [229545] trunk/Source/JavaScriptCore

[fpizlo]

Title: [229545] trunk/Source/_javascript_Core








Revision 229545
Author fpi...@apple.com
Date 2018-03-12 13:19:53 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, fix simple goof that was causing 32-bit DFG crashes.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229544 => 229545)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-12 19:44:17 UTC (rev 229544)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-12 20:19:53 UTC (rev 229545)
@@ -1,3 +1,10 @@
+2018-03-12  Filip Pizlo  
+
+Unreviewed, fix simple goof that was causing 32-bit DFG crashes.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):
+
 2018-03-11  Yusuke Suzuki  
 
 [DFG] AI should convert CreateThis to NewObject if the prototype object is proved


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (229544 => 229545)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-03-12 19:44:17 UTC (rev 229544)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-03-12 20:19:53 UTC (rev 229545)
@@ -7006,7 +7006,8 @@
 GPRTemporary length;
 
 if (isX86() && is32Bit() && !lengthIsKnown) {
-GPRFlushedCallResult result(this);
+GPRFlushedCallResult realResult(this);
+result.adopt(realResult);
 resultGPR = result.gpr();
 RELEASE_ASSERT(resultGPR == GPRInfo::regT0);
 flushRegisters();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229538] trunk/Source/ThirdParty/libwebrtc

[youenn]

Title: [229538] trunk/Source/ThirdParty/libwebrtc








Revision 229538
Author you...@apple.com
Date 2018-03-12 09:47:59 -0700 (Mon, 12 Mar 2018)


Log Message
Remove empty cpp files in Source/ThirdParty/libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=183529

Unreviewed.

* libwebrtc.xcodeproj/project.pbxproj: fix the build.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (229537 => 229538)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-03-12 16:15:46 UTC (rev 229537)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-03-12 16:47:59 UTC (rev 229538)
@@ -1,3 +1,12 @@
+2018-03-12  youenn fablet  
+
+Remove empty cpp files in Source/ThirdParty/libwebrtc
+https://bugs.webkit.org/show_bug.cgi?id=183529
+
+Unreviewed.
+
+* libwebrtc.xcodeproj/project.pbxproj: fix the build.
+
 2018-03-09  Youenn Fablet  
 
 Remove empty cpp files in Source/ThirdParty/libwebrtc


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (229537 => 229538)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2018-03-12 16:15:46 UTC (rev 229537)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2018-03-12 16:47:59 UTC (rev 229538)
@@ -2369,7 +2369,6 @@
 		5CDD8C0B1E43C34600621E92 /* audio_encoder_isac_t_impl.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD8BFD1E43C34600621E92 /* audio_encoder_isac_t_impl.h */; };
 		5CDD8C0C1E43C34600621E92 /* audio_encoder_isac_t.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD8BFE1E43C34600621E92 /* audio_encoder_isac_t.h */; };
 		5CDD8C0D1E43C34600621E92 /* bandwidth_info.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD8BFF1E43C34600621E92 /* bandwidth_info.h */; };
-		5CDD8C0E1E43C34600621E92 /* empty.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD8C001E43C34600621E92 /* empty.cc */; };
 		5CDD8C0F1E43C34600621E92 /* locked_bandwidth_info.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD8C071E43C34600621E92 /* locked_bandwidth_info.cc */; };
 		5CDD8C101E43C34600621E92 /* locked_bandwidth_info.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD8C081E43C34600621E92 /* locked_bandwidth_info.h */; };
 		5CDD8C141E43C3B400621E92 /* vp9_noop.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD8C131E43C3B400621E92 /* vp9_noop.cc */; };
@@ -5478,7 +5477,6 @@
 		5CDD8BFD1E43C34600621E92 /* audio_encoder_isac_t_impl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = audio_encoder_isac_t_impl.h; sourceTree = ""; };
 		5CDD8BFE1E43C34600621E92 /* audio_encoder_isac_t.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = audio_encoder_isac_t.h; sourceTree = ""; };
 		5CDD8BFF1E43C34600621E92 /* bandwidth_info.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = bandwidth_info.h; sourceTree = ""; };
-		5CDD8C001E43C34600621E92 /* empty.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = empty.cc; sourceTree = ""; };
 		5CDD8C071E43C34600621E92 /* locked_bandwidth_info.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = locked_bandwidth_info.cc; sourceTree = ""; };
 		5CDD8C081E43C34600621E92 /* locked_bandwidth_info.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = locked_bandwidth_info.h; sourceTree = ""; };
 		5CDD8C131E43C3B400621E92 /* vp9_noop.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = vp9_noop.cc; path = codecs/vp9/vp9_noop.cc; sourceTree = ""; };
@@ -9346,7 +9344,6 @@
 5CDD8BFE1E43C34600621E92 /* audio_encoder_isac_t.h */,
 5CDD8BFD1E43C34600621E92 /* audio_encoder_isac_t_impl.h */,
 5CDD8BFF1E43C34600621E92 /* bandwidth_info.h */,
-5CDD8C001E43C34600621E92 /* empty.cc */,
 5CDD8C071E43C34600621E92 /* locked_bandwidth_info.cc */,
 5CDD8C081E43C34600621E92 /* locked_bandwidth_info.h */,
 			);
@@ -12912,7 +12909,6 @@
 5CD285BC1E6A63430094FDC8 /* echo_path_variability.cc in Sources */,
 5CD285C01E6A63430094FDC8 /* echo_remover.cc in Sources */,
 5CD285BE1E6A63430094FDC8 /* echo_remover_metrics.cc in Sources */,
-5CDD8C0E1E43C34600621E92 /* empty.cc in Sources */,
 5CDD8B961E43C2B500621E92 /* encode.c in Sources */,
 413A239B1FE18E0800373E99 /* bufferqueue.cc in Sources */,
 5CDD87B71E43BC0500621E92 /* encode.c in Sources */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229571] trunk/Source/WTF

[utatane . tea]

Title: [229571] trunk/Source/WTF








Revision 229571
Author utatane@gmail.com
Date 2018-03-12 20:10:44 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, include time.h
https://bugs.webkit.org/show_bug.cgi?id=183312

Attempt to fix oss-fuzz build.

* wtf/CurrentTime.cpp:
* wtf/unix/CPUTimeUnix.cpp:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CurrentTime.cpp
trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (229570 => 229571)

--- trunk/Source/WTF/ChangeLog	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/ChangeLog	2018-03-13 03:10:44 UTC (rev 229571)
@@ -1,3 +1,13 @@
+2018-03-12  Yusuke Suzuki  
+
+Unreviewed, include time.h
+https://bugs.webkit.org/show_bug.cgi?id=183312
+
+Attempt to fix oss-fuzz build.
+
+* wtf/CurrentTime.cpp:
+* wtf/unix/CPUTimeUnix.cpp:
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Source/WTF/wtf/CurrentTime.cpp (229570 => 229571)

--- trunk/Source/WTF/wtf/CurrentTime.cpp	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/wtf/CurrentTime.cpp	2018-03-13 03:10:44 UTC (rev 229571)
@@ -34,6 +34,7 @@
 #include "config.h"
 #include "MonotonicTime.h"
 #include "WallTime.h"
+#include 
 
 #if OS(DARWIN)
 #include 
@@ -49,7 +50,6 @@
 #include 
 #include 
 #include 
-#include 
 #else
 #include 
 #endif


Modified: trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp (229570 => 229571)

--- trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp	2018-03-13 03:10:44 UTC (rev 229571)
@@ -28,6 +28,7 @@
 
 #include 
 #include 
+#include 
 
 namespace WTF {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229570] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [229570] trunk/Source/_javascript_Core








Revision 229570
Author utatane@gmail.com
Date 2018-03-12 20:04:25 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, fix obsolete ASSERT
https://bugs.webkit.org/show_bug.cgi?id=183310

Now NewObject can be conereted from CallObjectConstructor and CreateThis.

* dfg/DFGNode.h:
(JSC::DFG::Node::convertToNewObject):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229569 => 229570)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-13 02:05:56 UTC (rev 229569)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-13 03:04:25 UTC (rev 229570)
@@ -1,3 +1,13 @@
+2018-03-12  Yusuke Suzuki  
+
+Unreviewed, fix obsolete ASSERT
+https://bugs.webkit.org/show_bug.cgi?id=183310
+
+Now NewObject can be conereted from CallObjectConstructor and CreateThis.
+
+* dfg/DFGNode.h:
+(JSC::DFG::Node::convertToNewObject):
+
 2018-03-12  Tim Horton  
 
 Stop using SDK conditionals to control feature definitions


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (229569 => 229570)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-03-13 02:05:56 UTC (rev 229569)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-03-13 03:04:25 UTC (rev 229570)
@@ -726,7 +726,7 @@
 
 void convertToNewObject(RegisteredStructure structure)
 {
-ASSERT(m_op == CallObjectConstructor);
+ASSERT(m_op == CallObjectConstructor || m_op == CreateThis);
 setOpAndDefaultFlags(NewObject);
 children.reset();
 m_opInfo = structure;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229573] trunk/Source

[dino]

Title: [229573] trunk/Source








Revision 229573
Author d...@apple.com
Date 2018-03-12 21:11:06 -0700 (Mon, 12 Mar 2018)


Log Message
Add a WKWebViewContentProvider for system previews
https://bugs.webkit.org/show_bug.cgi?id=183582


Reviewed by Tim Horton.

Source/WebCore/PAL:

Add some QuickLook SPI.

* pal/spi/ios/QuickLookSPI.h:

Source/WebKit:

Implement WKSystemPreviewView, which conforms to WKWebViewContentProvider, in
order to view content as a "system preview". This effectively replaces the
SystemPreviewController, which will be removed soon.

Some of the required methods of WKWebViewContentProvider are not necessary on
this instance, so a follow-up patch will clean the protocol up a bit.

* UIProcess/Cocoa/NavigationState.mm: Don't trigger a SystemPreview when downloading.
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

* UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry init]): Register the WKSystemPreviewView for
MIME types retrieved from WebKitAdditions.

* UIProcess/ios/WKSystemPreviewView.h: Added.
* UIProcess/ios/WKSystemPreviewView.mm: Added.

(-[WKSystemPreviewView web_initWithFrame:webView:]):
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]): This is the
method that actually creates a QuickLook preview and provides the data.
(-[WKSystemPreviewView web_setMinimumSize:]):
(-[WKSystemPreviewView web_setOverlaidAccessoryViewsInset:]):
(-[WKSystemPreviewView web_computedContentInsetDidChange]):
(-[WKSystemPreviewView web_setFixedOverlayView:]):
(-[WKSystemPreviewView web_didSameDocumentNavigation:]):
(-[WKSystemPreviewView web_countStringMatches:options:maxCount:]):
(-[WKSystemPreviewView web_findString:options:maxCount:]):
(-[WKSystemPreviewView web_hideFindUI]):

(-[WKSystemPreviewView numberOfPreviewItemsInPreviewController:]): QuickLook delegates.
(-[WKSystemPreviewView previewController:previewItemAtIndex:]):
(-[WKSystemPreviewView provideDataForItem:]):
(-[WKSystemPreviewView previewControllerWillDismiss:]):

* WebKit.xcodeproj/project.pbxproj: Add new files.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.h
trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (229572 => 229573)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-03-13 04:11:06 UTC (rev 229573)
@@ -1,3 +1,15 @@
+2018-03-12  Dean Jackson  
+
+Add a WKWebViewContentProvider for system previews
+https://bugs.webkit.org/show_bug.cgi?id=183582
+
+
+Reviewed by Tim Horton.
+
+Add some QuickLook SPI.
+
+* pal/spi/ios/QuickLookSPI.h:
+
 2018-03-12  Don Olmstead  
 
 [CMake][Win] Forwarding headers of WTF and PAL are copied twice in Visual Studio builds


Modified: trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h (229572 => 229573)

--- trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h	2018-03-13 04:11:06 UTC (rev 229573)
@@ -34,6 +34,9 @@
 @interface QLPreviewConverter : NSObject
 @end
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnullability-completeness"
+
 @interface QLPreviewConverter ()
 - (NSURLRequest *)safeRequestForRequest:(NSURLRequest *)request;
 - (id)initWithConnection:(NSURLConnection *)connection delegate:(id)delegate response:(NSURLResponse *)response options:(NSDictionary *)options;
@@ -47,6 +50,17 @@
 @property (readonly, nonatomic) NSURLResponse *previewResponse;
 @end
 
+@class QLItem;
+
+@protocol QLPreviewItemDataProvider 
+- (NSData *)provideDataForItem:(QLItem *)item;
+@end
+
+@interface QLItem : NSObject
+- (instancetype)initWithDataProvider:(id _Nonnull)data contentType:(NSString *_Nonnull)contentType previewTitle:(NSString *_Nonnull)previewTitle;
+@end
+
+
 #if __IPHONE_OS_VERSION_MIN_REQUIRED >= 11
 #define kQLReturnPasswordProtected 1 << 2
 #else
@@ -70,3 +84,5 @@
 NSString *QLTypeCopyUTIForURLAndMimeType(NSURL *, NSString *mimeType);
 
 WTF_EXTERN_C_END
+
+#pragma clang diagnostic pop


Modified: trunk/Source/WebKit/ChangeLog (229572 => 229573)

--- trunk/Source/WebKit/ChangeLog	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebKit/ChangeLog	2018-03-13 04:11:06 UTC (rev 229573)
@@ -1,3 +1,47 @@
+2018-03-12  Dean Jackson  
+
+Add a WKWebViewContentProvider for system previews
+https://bugs.webkit.org/show_bug.cgi?id=183582
+
+
+Reviewed by Tim Horton.
+
+Implement 

[webkit-changes] [229555] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [229555] branches/safari-605-branch/Source/WebKit








Revision 229555
Author jmarc...@apple.com
Date 2018-03-12 14:59:34 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r229134. rdar://problem/38035474

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (229554 => 229555)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-03-12 21:59:32 UTC (rev 229554)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-03-12 21:59:34 UTC (rev 229555)
@@ -1,5 +1,28 @@
 2018-03-11  Jason Marcell  
 
+Cherry-pick r229134. rdar://problem/38035474
+
+2018-03-01  Antti Koivisto  
+
+Crash when updating cache entry after validation in apps that uses class A file protection
+https://bugs.webkit.org/show_bug.cgi?id=183242
+
+
+Reviewed by Chris Dumez.
+
+When validating a cache entry, we keep it alive until we get a network response. With 304 response
+we then update the headers of this existing entry. This accesses the body data of the entry which
+may be backed by a mapped file. If the app uses class A protection, user might have locked
+the device and the entry might have become inaccessible, leading to a crash.
+
+* NetworkProcess/cache/NetworkCacheEntry.cpp:
+(WebKit::NetworkCache::Entry::setNeedsValidation):
+
+In case of class A protection, pull the data to a memory buffer immediately before starting a revalidation request.
+This makes the window where the file could become inaccessible much shorter (since it no longer depends on network).
+
+2018-03-11  Jason Marcell  
+
 Cherry-pick r229028. rdar://problem/37992284
 
 2018-02-26  Youenn Fablet  


Modified: branches/safari-605-branch/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp (229554 => 229555)

--- branches/safari-605-branch/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp	2018-03-12 21:59:32 UTC (rev 229554)
+++ branches/safari-605-branch/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp	2018-03-12 21:59:34 UTC (rev 229555)
@@ -195,6 +195,13 @@
 
 void Entry::setNeedsValidation(bool value)
 {
+if (value) {
+// Validation keeps the entry alive waiting for the network response. Pull data from a mapped file into a buffer early
+// to protect against map disappearing due to device becoming locked.
+// FIXME: Cache files should be Class B/C, or we shoudn't use mapped files at all in these cases.
+if (!NetworkProcess::singleton().cache()->canUseSharedMemoryForBodyData())
+buffer();
+}
 m_response.setSource(value ? WebCore::ResourceResponse::Source::DiskCacheAfterValidation : WebCore::ResourceResponse::Source::DiskCache);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229553] branches/safari-605-branch

[jmarcell]

Title: [229553] branches/safari-605-branch








Revision 229553
Author jmarc...@apple.com
Date 2018-03-12 14:59:28 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r228279. rdar://problem/38154561

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/accessibility/canvas-fallback-content.html
branches/safari-605-branch/LayoutTests/accessibility/mac/aria-expanded-notifications.html
branches/safari-605-branch/LayoutTests/accessibility/mac/aria-listbox-selectedchildren-change.html
branches/safari-605-branch/LayoutTests/accessibility/mac/aria-menu-item-selected-notification.html
branches/safari-605-branch/LayoutTests/accessibility/mac/aria-modal-auto-focus.html
branches/safari-605-branch/LayoutTests/accessibility/mac/element-busy-changed.html
branches/safari-605-branch/LayoutTests/accessibility/mac/expanded-notification.html
branches/safari-605-branch/LayoutTests/accessibility/notification-listeners.html
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/accessibility/AXObjectCache.cpp
branches/safari-605-branch/Source/WebCore/accessibility/AXObjectCache.h
branches/safari-605-branch/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
branches/safari-605-branch/Source/WebCore/accessibility/AccessibleNode.cpp
branches/safari-605-branch/Source/WebCore/dom/Element.cpp




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (229552 => 229553)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-03-12 21:59:23 UTC (rev 229552)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-03-12 21:59:28 UTC (rev 229553)
@@ -1,3 +1,34 @@
+2018-03-11  Jason Marcell  
+
+Cherry-pick r228279. rdar://problem/38154561
+
+2018-02-08  Chris Fleizach  
+
+AX: Defer attribute computation until needed.
+https://bugs.webkit.org/show_bug.cgi?id=182386
+
+
+Reviewed by Zalan Bujtas.
+
+Update tests to reflect new world of delayed attribute handling for accessibility.
+
+* accessibility/canvas-fallback-content.html:
+ Make test async so attributes can be checked after deferred handling.
+* accessibility/mac/aria-expanded-notifications.html:
+ Access elements through AX tree so attribute changes generate notifications.
+* accessibility/mac/aria-listbox-selectedchildren-change.html:
+ Make test async so attributes can be checked after deferred handling.
+* accessibility/mac/aria-menu-item-selected-notification.html:
+ Access menu item through AX tree so attribute changes generate notifications.
+* accessibility/mac/aria-modal-auto-focus.html:
+ Access buttons after delay so attributes have time to be deferred.
+* accessibility/mac/element-busy-changed.html:
+ Process second attribute change after delay so we generate two notifications.
+* accessibility/mac/expanded-notification.html:
+ Set attributes after a delay so they generate individual notifications.
+* accessibility/notification-listeners.html:
+  Access elements through AX tree so attribute changes generate notifications.
+
 2018-02-26  Ryan Haddad  
 
 Work towards rdar://problem/36837397.


Modified: branches/safari-605-branch/LayoutTests/accessibility/canvas-fallback-content.html (229552 => 229553)

--- branches/safari-605-branch/LayoutTests/accessibility/canvas-fallback-content.html	2018-03-12 21:59:23 UTC (rev 229552)
+++ branches/safari-605-branch/LayoutTests/accessibility/canvas-fallback-content.html	2018-03-12 21:59:28 UTC (rev 229553)
@@ -40,6 +40,7 @@
 description("This test makes sure that focusable elements in canvas fallback content are accessible.");
 
 if (window.testRunner && window.accessibilityController) {
+window.jsTestIsAsync = true;
 window.testRunner.dumpAsText();
 
 function check(id, expectedRole) {
@@ -80,9 +81,15 @@
 
 // Check that the role is updated when the element changes.
 document.getElementById('focusable1').setAttribute('role', 'button');
-check("focusable1", "AXRole: AXButton");
+setTimeout(function() {
+check("focusable1", "AXRole: AXButton");
+}, 1);
+
 document.getElementById('focusable2').setAttribute('role', 'button');
-check("focusable2", "AXRole: AXButton");
+setTimeout(function() {
+check("focusable2", "AXRole: AXButton");
+finishJSTest();
+}, 1);
 }
 
 


Modified: branches/safari-605-branch/LayoutTests/accessibility/mac/aria-expanded-notifications.html (229552 => 229553)

--- branches/safari-605-branch/LayoutTests/accessibility/mac/aria-expanded-notifications.html	2018-03-12 21:59:23 UTC (rev 229552)
+++ 

[webkit-changes] [229552] branches/safari-605-branch/Source/JavaScriptCore/runtime/ Options.h

[jmarcell]

Title: [229552] branches/safari-605-branch/Source/_javascript_Core/runtime/Options.h








Revision 229552
Author jmarc...@apple.com
Date 2018-03-12 14:59:23 -0700 (Mon, 12 Mar 2018)


Log Message
Apply patch. rdar://problem/38035486

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/runtime/Options.h




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/runtime/Options.h (229551 => 229552)

--- branches/safari-605-branch/Source/_javascript_Core/runtime/Options.h	2018-03-12 21:50:29 UTC (rev 229551)
+++ branches/safari-605-branch/Source/_javascript_Core/runtime/Options.h	2018-03-12 21:59:23 UTC (rev 229552)
@@ -149,7 +149,7 @@
 \
 v(bool, useFunctionDotArguments, true, Normal, nullptr) \
 v(bool, useTailCalls, true, Normal, nullptr) \
-v(bool, optimizeRecursiveTailCalls, true, Normal, nullptr) \
+v(bool, optimizeRecursiveTailCalls, false, Normal, nullptr) \
 v(bool, alwaysUseShadowChicken, false, Normal, nullptr) \
 v(unsigned, shadowChickenLogSize, 1000, Normal, nullptr) \
 v(unsigned, shadowChickenMaxTailDeletedFramesSize, 128, Normal, nullptr) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229550] trunk/Source/ThirdParty/libwebrtc

[youenn]

Title: [229550] trunk/Source/ThirdParty/libwebrtc








Revision 229550
Author you...@apple.com
Date 2018-03-12 14:43:19 -0700 (Mon, 12 Mar 2018)


Log Message
Remove empty cpp files in Source/ThirdParty/libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=183529

Unreviewed.

Removing further empty files.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog


Removed Paths

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/BUILD.gn
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/DEPS
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/OWNERS
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/OWNERS
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.mm
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (229549 => 229550)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-03-12 21:19:14 UTC (rev 229549)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-03-12 21:43:19 UTC (rev 229550)
@@ -1,3 +1,19 @@
+2018-03-12  Youenn Fablet  
+
+Remove empty cpp files in Source/ThirdParty/libwebrtc
+https://bugs.webkit.org/show_bug.cgi?id=183529
+
+Unreviewed.
+Removing further empty files.
+
+* Source/webrtc/modules/audio_conference_mixer/BUILD.gn: Removed.
+* Source/webrtc/modules/audio_conference_mixer/DEPS: Removed.
+* Source/webrtc/modules/audio_conference_mixer/OWNERS: Removed.
+* Source/webrtc/modules/video_coding/codecs/OWNERS: Removed.
+* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.mm: Removed.
+* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm: Removed.
+* Source/webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm: Removed.
+
 2018-03-12  youenn fablet  
 
 Remove empty cpp files in Source/ThirdParty/libwebrtc


Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/BUILD.gn ( => )

Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/DEPS
===


Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_conference_mixer/OWNERS ( => )

Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/OWNERS
===


Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.mm ( => )

Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
===


Deleted: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm ( => )









___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229556] branches/safari-605-branch

[jmarcell]

Title: [229556] branches/safari-605-branch








Revision 229556
Author jmarc...@apple.com
Date 2018-03-12 14:59:39 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r229086. rdar://problem/37992301

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/platform/gtk/TestExpectations
branches/safari-605-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-605-branch/LayoutTests/platform/win/TestExpectations
branches/safari-605-branch/LayoutTests/platform/wpe/TestExpectations
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/loader/DocumentLoader.cpp


Added Paths

branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw-expected.txt
branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw.html
branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/main-resource-redirect-with-sw.manifest
branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/register-resources-service-worker.html
branches/safari-605-branch/LayoutTests/http/tests/appcache/service-worker-proxy.js




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (229555 => 229556)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-03-12 21:59:34 UTC (rev 229555)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-03-12 21:59:39 UTC (rev 229556)
@@ -1,5 +1,27 @@
 2018-03-11  Jason Marcell  
 
+Cherry-pick r229086. rdar://problem/37992301
+
+2018-02-27  Youenn Fablet  
+
+Do not trigger a service worker match in case of document redirection if it will be already served by AppCache
+https://bugs.webkit.org/show_bug.cgi?id=183185
+
+
+Reviewed by Chris Dumez.
+
+* http/tests/appcache/main-resource-redirect-with-sw-expected.txt: Added.
+* http/tests/appcache/main-resource-redirect-with-sw.html: Added.
+* http/tests/appcache/resources/main-resource-redirect-with-sw.manifest: Added.
+* http/tests/appcache/resources/register-resources-service-worker.html: Added.
+* http/tests/appcache/service-worker-proxy.js: Added.
+* platform/gtk/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wpe/TestExpectations:
+
+2018-03-11  Jason Marcell  
+
 Cherry-pick r228279. rdar://problem/38154561
 
 2018-02-08  Chris Fleizach  


Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw-expected.txt (0 => 229556)

--- branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw-expected.txt	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw-expected.txt	2018-03-12 21:59:39 UTC (rev 229556)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
+PASS


Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw.html (0 => 229556)

--- branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw.html	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/main-resource-redirect-with-sw.html	2018-03-12 21:59:39 UTC (rev 229556)
@@ -0,0 +1,52 @@
+
+
+Test that application cache and service worker do not mess with each other in case of redirections.
+Testing...
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+testRunner.setShouldDecideNavigationPolicyAfterDelay(true);
+}
+
+var serviceWorkerIframe;
+function prepareTest()
+{
+serviceWorkerIframe = document.createElement("iframe");
+serviceWorkerIframe.setAttribute("src", "/appcache/resources/register-resources-service-worker.html");
+document.body.appendChild(serviceWorkerIframe);
+serviceWorkerIframe._onload_ = async (e) => {
+try {
+await serviceWorkerIframe.contentWindow.registerServiceWorker();
+} catch (e) {
+console.log(e);
+}
+test();
+};
+}
+
+function test()
+{
+applicationCache._oncached_ = null;
+applicationCache._onnoupdate_ = null;
+var iframe = document.createElement("iframe");
+iframe.setAttribute("src", "/resources/redirect.php?url=""
+document.body.appendChild(iframe);
+iframe._onload_ = done;
+}
+
+function done()
+{
+applicationCache._onerror_ = null;
+// We wait some small time to ensure that the frame loading does not trigger two concurrent loads.
+setTimeout(() => {
+window.document.body.innerHTML = "PASS";
+if (window.testRunner)
+testRunner.notifyDone();
+}, 10);
+}
+

[webkit-changes] [229554] branches/safari-605-branch/Source

[jmarcell]

Title: [229554] branches/safari-605-branch/Source








Revision 229554
Author jmarc...@apple.com
Date 2018-03-12 14:59:32 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r229028. rdar://problem/37992284

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp
branches/safari-605-branch/Source/WebCore/dom/MessagePort.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (229553 => 229554)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-03-12 21:59:28 UTC (rev 229553)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-03-12 21:59:32 UTC (rev 229554)
@@ -1,5 +1,29 @@
 2018-03-11  Jason Marcell  
 
+Cherry-pick r229028. rdar://problem/37992284
+
+2018-02-26  Youenn Fablet  
+
+MessagePort is not always destroyed in the right thread
+https://bugs.webkit.org/show_bug.cgi?id=183053
+
+Reviewed by Chris Dumez.
+
+Make existingMessagePortForIdentifier take a lambda so that we hold the lock until there
+is no longer a need to keep the MessagePort around.
+This is very time sensitive and does not happen a lot when running WPT tests.
+
+Update existing call sites to pass a lambda.
+
+* dom/MessagePort.cpp:
+(WebCore::MessagePort::existingMessagePortForIdentifier):
+* dom/MessagePort.h:
+* dom/messageports/MessagePortChannelProviderImpl.cpp:
+(WebCore::MessagePortChannelProviderImpl::postMessageToRemote):
+(WebCore::MessagePortChannelProviderImpl::checkProcessLocalPortForActivity):
+
+2018-03-11  Jason Marcell  
+
 Cherry-pick r228279. rdar://problem/38154561
 
 2018-02-08  Chris Fleizach  


Modified: branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp (229553 => 229554)

--- branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp	2018-03-12 21:59:28 UTC (rev 229553)
+++ branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp	2018-03-12 21:59:32 UTC (rev 229554)
@@ -56,12 +56,8 @@
 
 void MessagePort::deref() const
 {
-// MessagePort::existingMessagePortForIdentifier() is unique in that it holds a raw pointer to a MessagePort
-// but might create a RefPtr from it.
-// If that happens on one thread at the same time that a MessagePort is being deref'ed and destroyed on a
-// different thread then Bad Things could happen.
-// This custom deref() function is designed to handle that contention by guaranteeing that nobody can be
-// creating a RefPtr inside existingMessagePortForIdentifier while the object is mid-deletion.
+// This custom deref() function ensures that as long as the lock to allMessagePortsLock is taken, no MessagePort will be destroyed.
+// This allows isExistingMessagePortLocallyReachable and notifyMessageAvailable to easily query the map and manipulate MessagePort instances.
 
 if (!--m_refCount) {
 Locker locker(allMessagePortsLock());
@@ -74,11 +70,19 @@
 }
 }
 
-RefPtr MessagePort::existingMessagePortForIdentifier(const MessagePortIdentifier& identifier)
+bool MessagePort::isExistingMessagePortLocallyReachable(const MessagePortIdentifier& identifier)
 {
 Locker locker(allMessagePortsLock());
+auto* port = allMessagePorts().get(identifier);
+return port && port->isLocallyReachable();
+}
 
-return allMessagePorts().get(identifier);
+void MessagePort::notifyMessageAvailable(const MessagePortIdentifier& identifier)
+{
+Locker locker(allMessagePortsLock());
+if (auto* port = allMessagePorts().get(identifier))
+port->messageAvailable();
+
 }
 
 Ref MessagePort::create(ScriptExecutionContext& scriptExecutionContext, const MessagePortIdentifier& local, const MessagePortIdentifier& remote)


Modified: branches/safari-605-branch/Source/WebCore/dom/MessagePort.h (229553 => 229554)

--- branches/safari-605-branch/Source/WebCore/dom/MessagePort.h	2018-03-12 21:59:28 UTC (rev 229553)
+++ branches/safari-605-branch/Source/WebCore/dom/MessagePort.h	2018-03-12 21:59:32 UTC (rev 229554)
@@ -57,8 +57,10 @@
 // Returns nullptr if the passed-in vector is empty.
 static ExceptionOr disentanglePorts(Vector&&);
 static Vector entanglePorts(ScriptExecutionContext&, TransferredMessagePortArray&&);
-WEBCORE_EXPORT static RefPtr existingMessagePortForIdentifier(const MessagePortIdentifier&);
 
+WEBCORE_EXPORT static bool isExistingMessagePortLocallyReachable(const MessagePortIdentifier&);
+WEBCORE_EXPORT 

[webkit-changes] [229565] trunk/Tools

[ross . kirsling]

Title: [229565] trunk/Tools








Revision 229565
Author ross.kirsl...@sony.com
Date 2018-03-12 18:29:46 -0700 (Mon, 12 Mar 2018)


Log Message
[DRT] TestOptions should not be ObjC.
https://bugs.webkit.org/show_bug.cgi?id=183487

Reviewed by Per Arne Vollan.

* DumpRenderTree/CMakeLists.txt:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/PlatformMac.cmake:
Move TestOptions to platform-agnostic sources.

* DumpRenderTree/TestOptions.h:
* DumpRenderTree/TestOptions.cpp: Renamed from Tools/DumpRenderTree/TestOptions.mm.
* DumpRenderTree/mac/DumpRenderTree.mm:
Remove NSURL dependency and align with WTR as much as possible.

* DumpRenderTree/win/DumpRenderTree.cpp:
Consume TestOptions (recognizing just the ones that have WebPreferences defined for now).

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/CMakeLists.txt
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/PlatformMac.cmake
trunk/Tools/DumpRenderTree/TestOptions.h
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp


Added Paths

trunk/Tools/DumpRenderTree/TestOptions.cpp


Removed Paths

trunk/Tools/DumpRenderTree/TestOptions.mm




Diff

Modified: trunk/Tools/ChangeLog (229564 => 229565)

--- trunk/Tools/ChangeLog	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/ChangeLog	2018-03-13 01:29:46 UTC (rev 229565)
@@ -1,3 +1,23 @@
+2018-03-12  Ross Kirsling  
+
+[DRT] TestOptions should not be ObjC.
+https://bugs.webkit.org/show_bug.cgi?id=183487
+
+Reviewed by Per Arne Vollan.
+
+* DumpRenderTree/CMakeLists.txt:
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+* DumpRenderTree/PlatformMac.cmake:
+Move TestOptions to platform-agnostic sources.
+
+* DumpRenderTree/TestOptions.h:
+* DumpRenderTree/TestOptions.cpp: Renamed from Tools/DumpRenderTree/TestOptions.mm.
+* DumpRenderTree/mac/DumpRenderTree.mm:
+Remove NSURL dependency and align with WTR as much as possible.
+
+* DumpRenderTree/win/DumpRenderTree.cpp:
+Consume TestOptions (recognizing just the ones that have WebPreferences defined for now).
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Tools/DumpRenderTree/CMakeLists.txt (229564 => 229565)

--- trunk/Tools/DumpRenderTree/CMakeLists.txt	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/DumpRenderTree/CMakeLists.txt	2018-03-13 01:29:46 UTC (rev 229565)
@@ -13,6 +13,7 @@
 GCController.cpp
 _javascript_Threading.cpp
 PixelDumpSupport.cpp
+TestOptions.cpp
 TestRunner.cpp
 WorkQueue.cpp
 ${WEBKIT_TESTRUNNER_UISCRIPTCONTEXT_DIR}/UIScriptContext.cpp


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (229564 => 229565)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2018-03-13 01:29:46 UTC (rev 229565)
@@ -101,7 +101,6 @@
 		5DB9AC9E0F722C3600684641 /* WebKitWeightWatcher700.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09770DAC3CB600C8B4E5 /* WebKitWeightWatcher700.ttf */; };
 		5DB9AC9F0F722C3600684641 /* WebKitWeightWatcher800.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09780DAC3CB600C8B4E5 /* WebKitWeightWatcher800.ttf */; };
 		5DB9ACA00F722C3600684641 /* WebKitWeightWatcher900.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09790DAC3CB600C8B4E5 /* WebKitWeightWatcher900.ttf */; };
-		7CBBC3231DDFCF9A00786B9D /* TestOptions.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7CBBC3211DDFCF9A00786B9D /* TestOptions.mm */; };
 		80045AEE147718E7008290A8 /* AccessibilityNotificationHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 80045AEC147718E7008290A8 /* AccessibilityNotificationHandler.mm */; };
 		8465E2C70FFA8DF2003B8342 /* PixelDumpSupport.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 8465E2C60FFA8DF2003B8342 /* PixelDumpSupport.cpp */; };
 		9830F31F15C81181005AB206 /* DumpRenderTreeCommon.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9830F31E15C81181005AB206 /* DumpRenderTreeCommon.cpp */; };
@@ -109,6 +108,7 @@
 		A1158D59189274360088C17B /* PixelDumpSupportIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = A1158D57189273EB0088C17B /* PixelDumpSupportIOS.mm */; };
 		A134E531188FC27000901D06 /* DumpRenderTreeMain.mm in Sources */ = {isa = PBXBuildFile; fileRef = A134E52F188FC27000901D06 /* DumpRenderTreeMain.mm */; };
 		A134E53618905EFF00901D06 /* AccessibilityCommonMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC0E26140E2DA4C6001B6BC3 /* AccessibilityCommonMac.mm */; };
+		A30A21F82051D8C40008FF42 /* TestOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30A21F72051D8960008FF42 /* TestOptions.cpp */; };
 	

[webkit-changes] [229566] trunk

[cdumez]

Title: [229566] trunk








Revision 229566
Author cdu...@apple.com
Date 2018-03-12 18:37:23 -0700 (Mon, 12 Mar 2018)


Log Message
Return boolean from DOMTokenList's replace() method
https://bugs.webkit.org/show_bug.cgi?id=183567

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline web platform test now that all checks are passing.

* web-platform-tests/dom/nodes/Element-classlist-expected.txt:

Source/WebCore:

Have DOMTokenList's replace() method return a boolean indicating if the
token was replaced, as per:
- https://dom.spec.whatwg.org/#dom-domtokenlist-replace

This is a recent addition to the DOM specification:
- https://github.com/whatwg/dom/pull/582

No new tests, rebaselined existing test.

* html/DOMTokenList.cpp:
(WebCore::replaceInOrderedSet):
(WebCore::DOMTokenList::replace):
* html/DOMTokenList.h:
* html/DOMTokenList.idl:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMTokenList.cpp
trunk/Source/WebCore/html/DOMTokenList.h
trunk/Source/WebCore/html/DOMTokenList.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (229565 => 229566)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-13 01:29:46 UTC (rev 229565)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-13 01:37:23 UTC (rev 229566)
@@ -1,3 +1,14 @@
+2018-03-12  Chris Dumez  
+
+Return boolean from DOMTokenList's replace() method
+https://bugs.webkit.org/show_bug.cgi?id=183567
+
+Reviewed by Youenn Fablet.
+
+Rebaseline web platform test now that all checks are passing.
+
+* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
+
 2018-03-12  Ryan Haddad  
 
 Unreviewed, rebaseline two cssom tests after r229544.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt (229565 => 229566)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt	2018-03-13 01:29:46 UTC (rev 229565)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt	2018-03-13 01:37:23 UTC (rev 229566)
@@ -258,31 +258,31 @@
 PASS classList.replace("b", "a\r") with attribute value null (HTML node) 
 PASS classList.replace("b", " a") with attribute value null (HTML node) 
 PASS classList.replace("b", "a ") with attribute value null (HTML node) 
-FAIL classList.replace("a", "a") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("A", "b") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("b", "A") with attribute value "a b" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "a b" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("d", "e") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "a") with attribute value "a a a  b" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "d") with attribute value "a a a  b" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value null (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value "" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value " " (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value " a  \f" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("b", "d") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "c b a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("a", "c") 

[webkit-changes] [229568] tags/Safari-606.1.9/Source/WebCore

[jmarcell]

Title: [229568] tags/Safari-606.1.9/Source/WebCore








Revision 229568
Author jmarc...@apple.com
Date 2018-03-12 18:54:14 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r229564. rdar://problem/38395317

Modified Paths

tags/Safari-606.1.9/Source/WebCore/ChangeLog
tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp
tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp
tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp




Diff

Modified: tags/Safari-606.1.9/Source/WebCore/ChangeLog (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/ChangeLog	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/ChangeLog	2018-03-13 01:54:14 UTC (rev 229568)
@@ -1,3 +1,23 @@
+2018-03-12  Jason Marcell  
+
+Cherry-pick r229564. rdar://problem/38395317
+
+2018-03-12  Brian Burg  
+
+Ignore some deprecation warnings encountered when compiling with newer versions of ICU
+https://bugs.webkit.org/show_bug.cgi?id=183584
+
+
+Reviewed by Daniel Bates.
+
+Ignore new deprecation warnings. Where a function has more than one
+deprecation warning, mark out the entire function so it remains readable.
+
+* editing/TextIterator.cpp:
+* platform/graphics/SurrogatePairAwareTextIterator.cpp:
+(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
+* platform/text/TextEncoding.cpp:
+
 2018-03-12  Javier Fernandez  
 
 Remove GridLayout runtime flag


Modified: tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -1999,6 +1999,12 @@
 return false;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 static void normalizeCharacters(const UChar* characters, unsigned length, Vector& buffer)
 {
 ASSERT(length);
@@ -2020,6 +2026,10 @@
 ASSERT(status == U_STRING_NOT_TERMINATED_WARNING);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 static bool isNonLatin1Separator(UChar32 character)
 {
 ASSERT_ARG(character, character >= 256);


Modified: tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -69,6 +69,12 @@
 return true;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 UChar32 SurrogatePairAwareTextIterator::normalizeVoicingMarks()
 {
 // According to http://www.unicode.org/Public/UNIDATA/UCD.html#Canonical_Combining_Class_Values
@@ -89,4 +95,8 @@
 return 0;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 }


Modified: tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -69,6 +69,12 @@
 return newTextCodec(*this)->decode(data, length, true, stopOnError, sawError);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_quickCheck and unorm_normalize functions are deprecated in some SDKs.
+
 Vector TextEncoding::encode(StringView text, UnencodableHandling handling) const
 {
 if (!m_name || text.isEmpty())
@@ -106,6 +112,10 @@
 return newTextCodec(*this)->encode(StringView { source, sourceLength }, handling);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 const char* TextEncoding::domName() const
 {
 if (noExtendedTextEncodingNameUsed())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229563] trunk

[yoav]

Title: [229563] trunk








Revision 229563
Author y...@yoav.ws
Date 2018-03-12 16:28:45 -0700 (Mon, 12 Mar 2018)


Log Message
Runtime flag for link prefetch and remove link subresource.
https://bugs.webkit.org/show_bug.cgi?id=183540

Reviewed by Chris Dumez.

.:

Remove the LINK_PREFETCH build time flag.

* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/_javascript_Core:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This patch removes the LINK_PREFETCH build time flag, removes
link subresource, adds an off-by-default runtime flag for link
prefetch and makes sure link prefetch only works when this flag is on.

Subresource is removed as it's not a part of any spec, nor supported by any
other browser. It was replaced by link preload.

No new tests as this is not adding any new functionality.

* Configurations/FeatureDefines.xcconfig: Remove the LINK_PREFETCH flag.
* html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute): Put prefetch support behind the runtime flag.
(WebCore::LinkRelAttribute::isSupported): Add prefetch.
* html/LinkRelAttribute.h: Remove the LINK_PREFETCH flag.
* loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient): Remove the LINK_PREFETCH flag.
(WebCore::LinkLoader::prefetchIfNeeded): Move the prefetch code to `prefetchIfNeeded()`. Remove subresource bits.
(WebCore::LinkLoader::loadLink): Call `prefetchIfNeeded()`.
* loader/LinkLoader.h:
* loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType): Remove the LINK_PREFETCH flag as well as subresource.
* loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResource::load): Remove the LINK_PREFETCH flag.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount const): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::requestLinkResource): Remove subresource.
(WebCore::contentTypeFromResourceType): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::checkInsecureContent const): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResourceLoader.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setLinkPrefetchEnabled): Set the prefetch flag.
(WebCore::RuntimeEnabledFeatures::linkPrefetchEnabled const): Get the prefetch flag.

Source/WebCore/PAL:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):

Source/WebKitLegacy/mac:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Remove the LINK_PREFETCH build time flag.

* wtf/FeatureDefines.h:

Tools:

Remove the LINK_PREFETCH build time flag.

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/html/LinkRelAttribute.cpp
trunk/Source/WebCore/html/LinkRelAttribute.h
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/loader/LinkLoader.h
trunk/Source/WebCore/loader/ResourceLoadInfo.cpp
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsWin.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Source/cmake/tools/vsprops/FeatureDefines.props
trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props
trunk/Tools/ChangeLog

[webkit-changes] [229560] trunk

[cdumez]

Title: [229560] trunk








Revision 229560
Author cdu...@apple.com
Date 2018-03-12 16:06:51 -0700 (Mon, 12 Mar 2018)


Log Message
Load may get committed before receiving policy for the resource response
https://bugs.webkit.org/show_bug.cgi?id=183579


Reviewed by Youenn Fablet.

Source/WebKit:

r228852 updated WebResourceLoader::didReceiveResponse to only send the
ContinueDidReceiveResponse IPC back to the Networkprocess *after* the
policy decision for the resource response has been made. This is necessary
now that policy decisions can be made asynchronously.

However, one of the 2 code paths in NetworkProcess side (code path when
the resource is already in the HTTP disk cache) failed to wait for the
ContinueDidReceiveResponse IPC before sending over the data to the WebProcess.
As a result, the WebProcess could commit the load before even receiving the
policy response from the client.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::continueProcessingCachedEntryAfterDidReceiveResponse):
* NetworkProcess/NetworkResourceLoader.h:
Make sure NetworkResourceLoader::didRetrieveCacheEntry() does not start sending the data
until the network process gets the ContinueDidReceiveResponse IPC back from the WebProcess.

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
* WebProcess/Network/WebResourceLoader.h:
Add assertion to make sure didReceiveData() never gets called before didReceiveResponse's
completion handler has been called. If this hits, then the load may get committed even
though the client did not reply to the policy for the resource response yet.

LayoutTests:

Add layout test coverage.

* http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt: Added.
* http/tests/cache/cachedEntry-waits-for-response-policy.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.h


Added Paths

trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt
trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229559 => 229560)

--- trunk/LayoutTests/ChangeLog	2018-03-12 23:01:26 UTC (rev 229559)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 23:06:51 UTC (rev 229560)
@@ -1,3 +1,16 @@
+2018-03-12  Chris Dumez  
+
+Load may get committed before receiving policy for the resource response
+https://bugs.webkit.org/show_bug.cgi?id=183579
+
+
+Reviewed by Youenn Fablet.
+
+Add layout test coverage.
+
+* http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt: Added.
+* http/tests/cache/cachedEntry-waits-for-response-policy.html: Added.
+
 2018-03-12  Ali Juma  
 
 http/tests/workers/service/service-worker-download.https.html times out with async policy delegates


Added: trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt (0 => 229560)

--- trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt	2018-03-12 23:06:51 UTC (rev 229560)
@@ -0,0 +1,3 @@
+This test passes if it does not crash.
+
+ 


Added: trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html (0 => 229560)

--- trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html	(rev 0)
+++ trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html	2018-03-12 23:06:51 UTC (rev 229560)
@@ -0,0 +1,34 @@
+
+
+
+This test passes if it does not crash.
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+if (testRunner.setShouldDecideNavigationPolicyAfterDelay)
+testRunner.setShouldDecideNavigationPolicyAfterDelay(true);
+if (testRunner.setShouldDecideResponsePolicyAfterDelay)
+testRunner.setShouldDecideResponsePolicyAfterDelay(true);
+}
+function createFrame(url) {
+return new Promise((resolve) => {
+let frame = document.createElement('iframe');
+frame.src = ""
+frame._onload_ = function() { resolve(frame); };
+document.body.appendChild(frame);
+});
+}
+
+createFrame("/cache/resources/cacheable-random-text.php").then(function(frame) {
+frame.remove();
+internals.clearMemoryCache();
+createFrame("/cache/resources/cacheable-random-text.php").then(function(frame) {
+if 

[webkit-changes] [229561] tags/Safari-606.1.9/Source

[jmarcell]

Title: [229561] tags/Safari-606.1.9/Source








Revision 229561
Author jmarc...@apple.com
Date 2018-03-12 16:15:25 -0700 (Mon, 12 Mar 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229564] trunk/Source/WebCore

[bburg]

Title: [229564] trunk/Source/WebCore








Revision 229564
Author bb...@apple.com
Date 2018-03-12 16:46:06 -0700 (Mon, 12 Mar 2018)


Log Message
Ignore some deprecation warnings encountered when compiling with newer versions of ICU
https://bugs.webkit.org/show_bug.cgi?id=183584


Reviewed by Daniel Bates.

Ignore new deprecation warnings. Where a function has more than one
deprecation warning, mark out the entire function so it remains readable.

* editing/TextIterator.cpp:
* platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
* platform/text/TextEncoding.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextIterator.cpp
trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp
trunk/Source/WebCore/platform/text/TextEncoding.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229563 => 229564)

--- trunk/Source/WebCore/ChangeLog	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/ChangeLog	2018-03-12 23:46:06 UTC (rev 229564)
@@ -1,3 +1,19 @@
+2018-03-12  Brian Burg  
+
+Ignore some deprecation warnings encountered when compiling with newer versions of ICU
+https://bugs.webkit.org/show_bug.cgi?id=183584
+
+
+Reviewed by Daniel Bates.
+
+Ignore new deprecation warnings. Where a function has more than one
+deprecation warning, mark out the entire function so it remains readable.
+
+* editing/TextIterator.cpp:
+* platform/graphics/SurrogatePairAwareTextIterator.cpp:
+(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
+* platform/text/TextEncoding.cpp:
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Source/WebCore/editing/TextIterator.cpp (229563 => 229564)

--- trunk/Source/WebCore/editing/TextIterator.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/editing/TextIterator.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -1999,6 +1999,12 @@
 return false;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 static void normalizeCharacters(const UChar* characters, unsigned length, Vector& buffer)
 {
 ASSERT(length);
@@ -2020,6 +2026,10 @@
 ASSERT(status == U_STRING_NOT_TERMINATED_WARNING);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 static bool isNonLatin1Separator(UChar32 character)
 {
 ASSERT_ARG(character, character >= 256);


Modified: trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp (229563 => 229564)

--- trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -69,6 +69,12 @@
 return true;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 UChar32 SurrogatePairAwareTextIterator::normalizeVoicingMarks()
 {
 // According to http://www.unicode.org/Public/UNIDATA/UCD.html#Canonical_Combining_Class_Values
@@ -89,4 +95,8 @@
 return 0;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 }


Modified: trunk/Source/WebCore/platform/text/TextEncoding.cpp (229563 => 229564)

--- trunk/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -69,6 +69,12 @@
 return newTextCodec(*this)->decode(data, length, true, stopOnError, sawError);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_quickCheck and unorm_normalize functions are deprecated in some SDKs.
+
 Vector TextEncoding::encode(StringView text, UnencodableHandling handling) const
 {
 if (!m_name || text.isEmpty())
@@ -106,6 +112,10 @@
 return newTextCodec(*this)->encode(StringView { source, sourceLength }, handling);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 const char* TextEncoding::domName() const
 {
 if (noExtendedTextEncodingNameUsed())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229562] trunk/Source

[jmarcell]

Title: [229562] trunk/Source








Revision 229562
Author jmarc...@apple.com
Date 2018-03-12 16:21:32 -0700 (Mon, 12 Mar 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229551] trunk/Source/JavaScriptCore

[mark . lam]

Title: [229551] trunk/Source/_javascript_Core








Revision 229551
Author mark@apple.com
Date 2018-03-12 14:50:29 -0700 (Mon, 12 Mar 2018)


Log Message
Add another PtrTag.
https://bugs.webkit.org/show_bug.cgi?id=183580


Reviewed by Keith Miller.

* runtime/PtrTag.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/PtrTag.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229550 => 229551)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-12 21:43:19 UTC (rev 229550)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-12 21:50:29 UTC (rev 229551)
@@ -1,5 +1,15 @@
 2018-03-12  Mark Lam  
 
+Add another PtrTag.
+https://bugs.webkit.org/show_bug.cgi?id=183580
+
+
+Reviewed by Keith Miller.
+
+* runtime/PtrTag.h:
+
+2018-03-12  Mark Lam  
+
 Make a NativeFunction into a class to support pointer profiling.
 https://bugs.webkit.org/show_bug.cgi?id=183573
 


Modified: trunk/Source/_javascript_Core/runtime/PtrTag.h (229550 => 229551)

--- trunk/Source/_javascript_Core/runtime/PtrTag.h	2018-03-12 21:43:19 UTC (rev 229550)
+++ trunk/Source/_javascript_Core/runtime/PtrTag.h	2018-03-12 21:50:29 UTC (rev 229551)
@@ -32,6 +32,7 @@
 enum PtrTag : uintptr_t {
 NoPtrTag = 0,
 NearCallPtrTag,
+NearJumpPtrTag,
 CFunctionPtrTag,
 
 BytecodePtrTag,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229559] trunk/LayoutTests/imported/w3c

[ryanhaddad]

Title: [229559] trunk/LayoutTests/imported/w3c








Revision 229559
Author ryanhad...@apple.com
Date 2018-03-12 16:01:26 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, rebaseline two cssom tests after r229544.

* web-platform-tests/cssom-view/interfaces-expected.txt:
* web-platform-tests/cssom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (229558 => 229559)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-12 22:58:54 UTC (rev 229558)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-12 23:01:26 UTC (rev 229559)
@@ -1,3 +1,10 @@
+2018-03-12  Ryan Haddad  
+
+Unreviewed, rebaseline two cssom tests after r229544.
+
+* web-platform-tests/cssom-view/interfaces-expected.txt:
+* web-platform-tests/cssom/interfaces-expected.txt:
+
 2018-03-12  Youenn Fablet  
 
 RTCPeerConnection's close method should update signalingState


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt (229558 => 229559)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt	2018-03-12 22:58:54 UTC (rev 229558)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt	2018-03-12 23:01:26 UTC (rev 229559)
@@ -1,20 +1,24 @@
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
 CSSOM IDL tests
 
 
 PASS Test driver 
 PASS HTMLElement interface: attribute style 
+PASS Unscopable handled correctly for style property on HTMLElement 
 PASS HTMLElement interface: style_element must inherit property "style" with the proper type 
 PASS HTMLElement interface: document.createElement('unknownelement') must inherit property "style" with the proper type 
 PASS HTMLLinkElement interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on HTMLLinkElement 
 PASS HTMLStyleElement interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on HTMLStyleElement 
 PASS Window interface: operation getComputedStyle(Element, CSSOMString) 
+PASS Unscopable handled correctly for getComputedStyle(Element, CSSOMString) on Window 
 PASS Window interface: window must inherit property "getComputedStyle(Element, CSSOMString)" with the proper type 
 PASS Window interface: calling getComputedStyle(Element, CSSOMString) on window with too few arguments must throw TypeError 
 PASS WorkerGlobalScope interface: existence and properties of interface object 
@@ -23,21 +27,32 @@
 PASS WorkerNavigator interface: existence and properties of interface object 
 PASS WorkerLocation interface: existence and properties of interface object 
 PASS Document interface: attribute styleSheets 
+PASS Unscopable handled correctly for styleSheets property on Document 
 PASS Document interface: document must inherit property "styleSheets" with the proper type 
 PASS Document interface: new Document() must inherit property "styleSheets" with the proper type 
 PASS ProcessingInstruction interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on ProcessingInstruction 
 PASS ProcessingInstruction interface: xmlss_pi must inherit property "sheet" with the proper type 
+PASS SVGElement interface: attribute style 
+PASS Unscopable handled correctly for style property on SVGElement 
+PASS SVGElement interface: svg_element must inherit property "style" with the proper type 
 PASS MediaList interface: existence and properties of interface object 
 PASS MediaList interface object length 
 PASS MediaList interface object name 
 FAIL MediaList interface: existence and properties of interface prototype object assert_equals: prototype of MediaList.prototype is not Array.prototype expected [] but got object "[object Object]"
 PASS MediaList interface: existence and properties of interface prototype object's "constructor" property 
+PASS MediaList interface: existence and properties of interface prototype object's @@unscopables property 
 PASS MediaList interface: attribute mediaText 
+PASS Unscopable 

[webkit-changes] [229569] trunk/Source

[wilander]

Title: [229569] trunk/Source








Revision 229569
Author wilan...@apple.com
Date 2018-03-12 19:05:56 -0700 (Mon, 12 Mar 2018)


Log Message
Resource Load Statistics: Immediately forward cookie access at user interaction when there's an opener document
https://bugs.webkit.org/show_bug.cgi?id=183577


Reviewed by Brent Fulgham.

Source/WebCore:

Tested manually on live websites.
No new automated tests because of a bug in WebKitTestRunner:
https://bugs.webkit.org/show_bug.cgi?id=183578
The event sender triggers gestures in the opener rather than
in the popup.

* dom/Document.cpp:
(WebCore::Document::removedLastRef):
Clears the new m_primaryDomainsGrantedPageSpecificStorageAccess.
(WebCore::Document::hasGrantedPageSpecificStorageAccess):
(WebCore::Document::setHasGrantedPageSpecificStorageAccess):
* dom/Document.h:
Added member m_primaryDomainsGrantedPageSpecificStorageAccess
where we store domains that have been granted access.
* loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setGrantStorageAccessUnderOpenerCallback):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
Now checks if there is a cross-origin opener and if so, immediately
grants cookie access to the popup's domain if it is partitioned or
blocked.
* loader/ResourceLoadObserver.h:
* platform/network/NetworkStorageSession.h:
Added member m_pagesGrantedStorageAccess.
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::cookieStoragePartition const):
(WebCore::NetworkStorageSession::hasStorageAccess const):
Renamed from hasStorageAccessForFrame since the frameID now is optional.
(WebCore::NetworkStorageSession::grantStorageAccess):
Renamed from grantStorageAccessForFrame since the frameID now is optional.
(WebCore::NetworkStorageSession::removeStorageAccessForAllFramesOnPage):
Now removes the pageID entry in m_pagesGrantedStorageAccess.
(WebCore::NetworkStorageSession::hasStorageAccessForFrame const): Deleted.
Renamed since the frameID now is optional.
(WebCore::NetworkStorageSession::grantStorageAccessForFrame): Deleted.
Renamed since the frameID now is optional.

Source/WebKit:

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::hasStorageAccessForFrame):
Now also checks for general page access.
(WebKit::NetworkProcess::grantStorageAccess):
Renamed from grantStorageAccessForFrame since the frameID now is optional.
(WebKit::NetworkProcess::grantStorageAccessForFrame): Deleted.
Renamed since the frameID now is optional.
* NetworkProcess/NetworkProcess.h:
Renaming since the frameID now is optional.
* NetworkProcess/NetworkProcess.messages.in:
Renaming since the frameID now is optional.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::logCookieInformation):
Consequence of function renaming.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantStorageAccess):
(WebKit::NetworkProcessProxy::grantStorageAccessForFrame): Deleted.
Renaming since the frameID now is optional.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
Renaming since the frameID now is optional.
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
Handler renaming since the frameID now is optional.
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessUnderOpener):
New function for that grants cookie access under a whole page.
* UIProcess/WebResourceLoadStatisticsStore.h:
Member renaming since the frameID now is optional.
* UIProcess/WebResourceLoadStatisticsStore.messages.in:
New message received straight from WebCore::ResourceLoadObserver.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::grantStorageAccessHandler):
Renamed and made frameID optional.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
Consequence of renaming and making frameID optional.
(WebKit::WebsiteDataStore::grantStorageAccessForFrameHandler): Deleted.
Renamed and made frameID optional.
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebProcess/WebProcess.cpp:
(WebProcess::WebProcess):
Now calls setGrantStorageAccessUnderOpenerCallback() on the shared
WebCore::ResourceLoadObserver.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/loader/ResourceLoadObserver.cpp
trunk/Source/WebCore/loader/ResourceLoadObserver.h
trunk/Source/WebCore/platform/network/NetworkStorageSession.h
trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

[webkit-changes] [229557] trunk/Source/JavaScriptCore

[mark . lam]

Title: [229557] trunk/Source/_javascript_Core








Revision 229557
Author mark@apple.com
Date 2018-03-12 15:24:37 -0700 (Mon, 12 Mar 2018)


Log Message
Gardening: speculative build fix for Windows.
https://bugs.webkit.org/show_bug.cgi?id=183573

Not reviewed.

* runtime/NativeFunction.h:
(JSC::TaggedNativeFunction::TaggedNativeFunction):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/NativeFunction.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229556 => 229557)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-12 21:59:39 UTC (rev 229556)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-12 22:24:37 UTC (rev 229557)
@@ -1,5 +1,15 @@
 2018-03-12  Mark Lam  
 
+Gardening: speculative build fix for Windows.
+https://bugs.webkit.org/show_bug.cgi?id=183573
+
+Not reviewed.
+
+* runtime/NativeFunction.h:
+(JSC::TaggedNativeFunction::TaggedNativeFunction):
+
+2018-03-12  Mark Lam  
+
 Add another PtrTag.
 https://bugs.webkit.org/show_bug.cgi?id=183580
 


Modified: trunk/Source/_javascript_Core/runtime/NativeFunction.h (229556 => 229557)

--- trunk/Source/_javascript_Core/runtime/NativeFunction.h	2018-03-12 21:59:39 UTC (rev 229556)
+++ trunk/Source/_javascript_Core/runtime/NativeFunction.h	2018-03-12 22:24:37 UTC (rev 229557)
@@ -68,6 +68,9 @@
 TaggedNativeFunction() = default;
 TaggedNativeFunction(std::nullptr_t) : m_ptr(nullptr) { }
 explicit TaggedNativeFunction(uintptr_t bits) : m_ptr(bitwise_cast(bits)) { }
+#if COMPILER(MSVC)
+explicit TaggedNativeFunction(intptr_t bits) : m_ptr(bitwise_cast(bits)) { }
+#endif
 
 TaggedNativeFunction(NativeFunction func)
 : m_ptr(tagCFunctionPtr(func.m_ptr, NativeCodePtrTag))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229558] trunk

[ajuma]

Title: [229558] trunk








Revision 229558
Author aj...@chromium.org
Date 2018-03-12 15:58:54 -0700 (Mon, 12 Mar 2018)


Log Message
http/tests/workers/service/service-worker-download.https.html times out with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183479

Reviewed by Youenn Fablet.

Source/WebKit:

Ensure that ServiceWorkerFetchClient::m_isCheckingResponse is set before code that depends on it
executes. This bit was set by code that's posted to the runloop using 'callOnMainThread' in
ServiceWorkerFetchClient::didReceiveResponse. But when didReceiveResponse is executing, tasks for
handling didReceiveData, didFail, or didFinish may already have been posted to the runloop, and in
that case would execute before m_isCheckingResponse gets set, and then incorrectly fail to
early-out. Fix this by directly setting m_isCheckingResponse in didReceiveResponse.

* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::start):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

LayoutTests:

Add layout test coverage.

* http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
* http/tests/workers/service/service-worker-download-async-delegates.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp


Added Paths

trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229557 => 229558)

--- trunk/LayoutTests/ChangeLog	2018-03-12 22:24:37 UTC (rev 229557)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 22:58:54 UTC (rev 229558)
@@ -1,3 +1,15 @@
+2018-03-12  Ali Juma  
+
+http/tests/workers/service/service-worker-download.https.html times out with async policy delegates
+https://bugs.webkit.org/show_bug.cgi?id=183479
+
+Reviewed by Youenn Fablet.
+
+Add layout test coverage.
+
+* http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
+* http/tests/workers/service/service-worker-download-async-delegates.https.html: Added.
+
 2018-03-12  Chris Dumez  
 
 http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates


Added: trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt (0 => 229558)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt	2018-03-12 22:58:54 UTC (rev 229558)
@@ -0,0 +1,4 @@
+Download started.
+Downloading URL with suggested filename "download-binary.php"
+Download completed.
+


Added: trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html (0 => 229558)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html	(rev 0)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html	2018-03-12 22:58:54 UTC (rev 229558)
@@ -0,0 +1,24 @@
+
+
+
+
+