date:20190628

[webkit-changes] [246949] trunk/Source/WebKit

2019-06-28 Thread bfulgham

Title: [246949] trunk/Source/WebKit








Revision 246949
Author bfulg...@apple.com
Date 2019-06-28 22:09:49 -0700 (Fri, 28 Jun 2019)


Log Message
Revise WebContent sandbox based on seed feedback
https://bugs.webkit.org/show_bug.cgi?id=199339


Reviewed by Alexey Proskuryakov.

Unblock syscall needed by CoreText.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (246948 => 246949)

--- trunk/Source/WebKit/ChangeLog	2019-06-29 03:48:18 UTC (rev 246948)
+++ trunk/Source/WebKit/ChangeLog	2019-06-29 05:09:49 UTC (rev 246949)
@@ -1,3 +1,16 @@
+2019-06-28  Brent Fulgham  
+
+Revise WebContent sandbox based on seed feedback
+https://bugs.webkit.org/show_bug.cgi?id=199339
+
+
+Reviewed by Alexey Proskuryakov.
+
+Unblock syscall needed by CoreText.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-06-28  Tim Horton  
 
 iOS WebKit2 find-in-page indicator doesn't move with 'overflow: scroll'


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (246948 => 246949)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-06-29 03:48:18 UTC (rev 246948)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-06-29 05:09:49 UTC (rev 246949)
@@ -614,6 +614,7 @@
 (syscall-number SYS_fgetattrlist) ;; 
 (syscall-number SYS_fsetxattr) ;; 
 (syscall-number SYS_abort_with_payload) ;; 
+(syscall-number SYS_kqueue) ;; 
 (syscall-number SYS_kqueue_workloop_ctl) ;; 
 (syscall-number SYS_psynch_rw_rdlock) ;; 
 )


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (246948 => 246949)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-06-29 03:48:18 UTC (rev 246948)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-06-29 05:09:49 UTC (rev 246949)
@@ -974,6 +974,7 @@
 (syscall-number SYS_workq_open)
 (syscall-number SYS_getgroups)
 (syscall-number SYS_fgetattrlist) ;; 
+(syscall-number SYS_kqueue) ;; 
 (syscall-number SYS_kqueue_workloop_ctl) ;; 
 (syscall-number SYS_open_dprotected_np)
 (syscall-number SYS_flistxattr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246948] trunk/Source

2019-06-28 Thread timothy_horton

Title: [246948] trunk/Source








Revision 246948
Author timothy_hor...@apple.com
Date 2019-06-28 20:48:18 -0700 (Fri, 28 Jun 2019)


Log Message
iOS WebKit2 find-in-page indicator doesn't move with 'overflow: scroll'
https://bugs.webkit.org/show_bug.cgi?id=175032


Reviewed by Wenson Hsieh.

Source/WebCore:

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectionBounds const):
(WebCore::FrameSelection::revealSelection):
* editing/FrameSelection.h:
Make selectionBounds' clipToVisibleContent param an enum class.

* page/TextIndicator.cpp:
(WebCore::initializeIndicator):
Save the un-clipped selection rect; otherwise we'll frequently save 0, 0
here when finding a match that is off-screen.

Source/WebKit:

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::drawRect):
(WebKit::FindController::didScrollAffectingFindIndicatorPosition):
Adopt the macOS code that notices that the find highlight doesn't match
its original position, but instead of hiding the highlight like we do on macOS,
update it. We do this asynchronously to avoid mutating the layer tree
in the middle of painting, which is not /truly/ unsafe, but definitely
non-ideal and causes fun flashes.

* WebProcess/WebPage/FindController.h:
* WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator):
Store m_findIndicatorRect when updating the indicator, just like we do on macOS.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebCore/page/TextIndicator.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp
trunk/Source/WebKit/WebProcess/WebPage/FindController.h
trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (246947 => 246948)

--- trunk/Source/WebCore/ChangeLog	2019-06-28 23:35:44 UTC (rev 246947)
+++ trunk/Source/WebCore/ChangeLog	2019-06-29 03:48:18 UTC (rev 246948)
@@ -1,3 +1,22 @@
+2019-06-28  Tim Horton  
+
+iOS WebKit2 find-in-page indicator doesn't move with 'overflow: scroll'
+https://bugs.webkit.org/show_bug.cgi?id=175032
+
+
+Reviewed by Wenson Hsieh.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::selectionBounds const):
+(WebCore::FrameSelection::revealSelection):
+* editing/FrameSelection.h:
+Make selectionBounds' clipToVisibleContent param an enum class.
+
+* page/TextIndicator.cpp:
+(WebCore::initializeIndicator):
+Save the un-clipped selection rect; otherwise we'll frequently save 0, 0
+here when finding a match that is off-screen.
+
 2019-06-28  Zalan Bujtas  
 
 [Text autosizing][iPadOS] bing.com is hard to read even with boosted text because of the line height


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (246947 => 246948)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2019-06-28 23:35:44 UTC (rev 246947)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2019-06-29 03:48:18 UTC (rev 246948)
@@ -2288,7 +2288,7 @@
 return m_frame->editor().client()->shouldDeleteRange(selection.toNormalizedRange().get());
 }
 
-FloatRect FrameSelection::selectionBounds(bool clipToVisibleContent) const
+FloatRect FrameSelection::selectionBounds(ClipToVisibleContent clipToVisibleContent) const
 {
 if (!m_frame->document())
 return LayoutRect();
@@ -2299,8 +2299,13 @@
 return LayoutRect();
 
 auto& selection = renderView->selection();
-auto selectionRect = clipToVisibleContent ? selection.boundsClippedToVisibleContent() : selection.bounds();
-return clipToVisibleContent ? intersection(selectionRect, renderView->frameView().visibleContentRect(ScrollableArea::LegacyIOSDocumentVisibleRect)) : selectionRect;
+
+if (clipToVisibleContent == ClipToVisibleContent::Yes) {
+auto selectionRect = selection.boundsClippedToVisibleContent();
+return intersection(selectionRect, renderView->frameView().visibleContentRect(ScrollableArea::LegacyIOSDocumentVisibleRect));
+}
+
+return selection.bounds();
 }
 
 void FrameSelection::getClippedVisibleTextRectangles(Vector& rectangles, TextRectangleHeight textRectHeight) const
@@ -2391,7 +2396,7 @@
 rect = absoluteCaretBounds();
 break;
 case VisibleSelection::RangeSelection:
-rect = revealExtentOption == RevealExtent ? VisiblePosition(m_selection.extent()).absoluteCaretBounds() : enclosingIntRect(selectionBounds(false));
+rect = revealExtentOption == RevealExtent ? VisiblePosition(m_selection.extent()).absoluteCaretBounds() : enclosingIntRect(selectionBounds(ClipToVisibleContent::No));
 break;
 }
 


Modified: trunk/Source/WebCore/editing/FrameSelection.h (246947 => 246948)

--- trunk/Source/WebCore/editing/FrameSelection.h	2019-06-28 23:35:44 UTC (rev 246947)
+++ trunk/Source/WebCore/editing/FrameSelection.h

[webkit-changes] [246947] trunk/Source/WebKit

2019-06-28 Thread ryanhaddad

Title: [246947] trunk/Source/WebKit








Revision 246947
Author ryanhad...@apple.com
Date 2019-06-28 16:35:44 -0700 (Fri, 28 Jun 2019)


Log Message
Unreviewed build fix attempt after r246928.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _closeAllMediaPresentations]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (246946 => 246947)

--- trunk/Source/WebKit/ChangeLog	2019-06-28 23:19:11 UTC (rev 246946)
+++ trunk/Source/WebKit/ChangeLog	2019-06-28 23:35:44 UTC (rev 246947)
@@ -1,3 +1,10 @@
+2019-06-28  Ryan Haddad  
+
+Unreviewed build fix attempt after r246928.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _closeAllMediaPresentations]):
+
 2019-06-28  Youenn Fablet  
 
 Protect NetworkProcess::m_swServers from bad session IDs


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (246946 => 246947)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2019-06-28 23:19:11 UTC (rev 246946)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2019-06-28 23:35:44 UTC (rev 246947)
@@ -4743,6 +4743,7 @@
 
 - (void)_closeAllMediaPresentations
 {
+#if ENABLE(FULLSCREEN_API)
 if (auto videoFullscreenManager = _page->videoFullscreenManager()) {
 videoFullscreenManager->forEachSession([] (auto& model, auto& interface) {
 model.requestFullscreenMode(WebCore::HTMLMediaElementEnums::VideoFullscreenModeNone);
@@ -4749,7 +4750,6 @@
 });
 }
 
-#if ENABLE(FULLSCREEN_API)
 if (auto fullScreenManager = _page->fullScreenManager(); fullScreenManager && fullScreenManager->isFullScreen())
 fullScreenManager->close();
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246946] trunk

2019-06-28 Thread justin_michaud

Title: [246946] trunk








Revision 246946
Author justin_mich...@apple.com
Date 2019-06-28 16:19:11 -0700 (Fri, 28 Jun 2019)


Log Message
Add b3 macro lowering for CheckMul on arm64
https://bugs.webkit.org/show_bug.cgi?id=199251

Reviewed by Robin Morisset.

JSTests:

* microbenchmarks/check-mul-constant.js: Added.
(doTest):
* microbenchmarks/check-mul-no-constant.js: Added.
(doTest):
* microbenchmarks/check-mul-power-of-two.js: Added.
(doTest):

Source/_javascript_Core:

- Lower CheckMul for 32-bit arguments on arm64 into a mul and then an overflow check.
- Add a new opcode to air on arm64 for smull (multiplySignExtend32).
- Fuse sign extend 32 + mul into smull (taking two 32-bit arguments and producing 64 bits).
- 1.25x speedup on power of two microbenchmark, 1.15x speedup on normal constant microbenchmark,
  and no change on the no-constant benchmark.
Also, skip some of the b3 tests that were failing before this patch so that the new tests can run
to completion.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::multiplySignExtend32):
* assembler/testmasm.cpp:
(JSC::testMul32SignExtend):
(JSC::run):
* b3/B3LowerMacros.cpp:
* b3/B3LowerToAir.cpp:
* b3/air/AirOpcode.opcodes:
* b3/testb3.cpp:
(JSC::B3::testMulArgs32SignExtend):
(JSC::B3::testMulImm32SignExtend):
(JSC::B3::testMemoryFence):
(JSC::B3::testStoreFence):
(JSC::B3::testLoadFence):
(JSC::B3::testPinRegisters):
(JSC::B3::run):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp


Added Paths

trunk/JSTests/microbenchmarks/check-mul-constant.js
trunk/JSTests/microbenchmarks/check-mul-no-constant.js
trunk/JSTests/microbenchmarks/check-mul-power-of-two.js




Diff

Modified: trunk/JSTests/ChangeLog (246945 => 246946)

--- trunk/JSTests/ChangeLog	2019-06-28 22:50:41 UTC (rev 246945)
+++ trunk/JSTests/ChangeLog	2019-06-28 23:19:11 UTC (rev 246946)
@@ -1,3 +1,17 @@
+2019-06-28  Justin Michaud  
+
+Add b3 macro lowering for CheckMul on arm64
+https://bugs.webkit.org/show_bug.cgi?id=199251
+
+Reviewed by Robin Morisset.
+
+* microbenchmarks/check-mul-constant.js: Added.
+(doTest):
+* microbenchmarks/check-mul-no-constant.js: Added.
+(doTest):
+* microbenchmarks/check-mul-power-of-two.js: Added.
+(doTest):
+
 2019-06-26  Keith Miller  
 
 speciesConstruct needs to throw if the result is a DataView


Added: trunk/JSTests/microbenchmarks/check-mul-constant.js (0 => 246946)

--- trunk/JSTests/microbenchmarks/check-mul-constant.js	(rev 0)
+++ trunk/JSTests/microbenchmarks/check-mul-constant.js	2019-06-28 23:19:11 UTC (rev 246946)
@@ -0,0 +1,13 @@
+function doTest(max) {
+let sum = 0
+for (let i=0; i

Added: trunk/JSTests/microbenchmarks/check-mul-no-constant.js (0 => 246946)

--- trunk/JSTests/microbenchmarks/check-mul-no-constant.js	(rev 0)
+++ trunk/JSTests/microbenchmarks/check-mul-no-constant.js	2019-06-28 23:19:11 UTC (rev 246946)
@@ -0,0 +1,13 @@
+function doTest(max) {
+let sum = 0
+for (let i=0; i

Added: trunk/JSTests/microbenchmarks/check-mul-power-of-two.js (0 => 246946)

--- trunk/JSTests/microbenchmarks/check-mul-power-of-two.js	(rev 0)
+++ trunk/JSTests/microbenchmarks/check-mul-power-of-two.js	2019-06-28 23:19:11 UTC (rev 246946)
@@ -0,0 +1,13 @@
+function doTest(max) {
+let sum = 0
+for (let i=0; i

Modified: trunk/Source/_javascript_Core/ChangeLog (246945 => 246946)

--- trunk/Source/_javascript_Core/ChangeLog	2019-06-28 22:50:41 UTC (rev 246945)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-06-28 23:19:11 UTC (rev 246946)
@@ -1,3 +1,35 @@
+2019-06-28  Justin Michaud  
+
+Add b3 macro lowering for CheckMul on arm64
+https://bugs.webkit.org/show_bug.cgi?id=199251
+
+Reviewed by Robin Morisset.
+
+- Lower CheckMul for 32-bit arguments on arm64 into a mul and then an overflow check.
+- Add a new opcode to air on arm64 for smull (multiplySignExtend32).
+- Fuse sign extend 32 + mul into smull (taking two 32-bit arguments and producing 64 bits). 
+- 1.25x speedup on power of two microbenchmark, 1.15x speedup on normal constant microbenchmark, 
+  and no change on the no-constant benchmark.
+Also, skip some of the b3 tests that were failing before this patch so that the new tests can run
+to completion.
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::multiplySignExtend32):
+* assembler/testmasm.cpp:
+(JSC::testMul32SignExtend):
+(JSC::run):
+* b3/B3LowerMacros.cpp:
+*

[webkit-changes] [246945] trunk/Source/ThirdParty/libwebrtc

2019-06-28 Thread dino

Title: [246945] trunk/Source/ThirdParty/libwebrtc








Revision 246945
Author d...@apple.com
Date 2019-06-28 15:50:41 -0700 (Fri, 28 Jun 2019)


Log Message
unable to build WebRTC for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=199337


Reviewed by Tim Horton.

Run the compiled yasm with DYLD_ROOT_PATH=/
in order to convince dyld that it can load
the simulator binary on macOS.

* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (246944 => 246945)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-06-28 22:48:13 UTC (rev 246944)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2019-06-28 22:50:41 UTC (rev 246945)
@@ -1,3 +1,17 @@
+2019-06-28  Dean Jackson  
+
+unable to build WebRTC for iOS Simulator
+https://bugs.webkit.org/show_bug.cgi?id=199337
+
+
+Reviewed by Tim Horton.
+
+Run the compiled yasm with DYLD_ROOT_PATH=/
+in order to convince dyld that it can load
+the simulator binary on macOS.
+
+* libwebrtc.xcodeproj/project.pbxproj:
+
 2019-06-27  Beth Dakin  
 
 Upstream use of MACCATALYST


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (246944 => 246945)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-06-28 22:48:13 UTC (rev 246944)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2019-06-28 22:50:41 UTC (rev 246945)
@@ -3375,11 +3375,13 @@
 			compilerSpec = com.apple.compilers.proxy.script;
 			filePatterns = asm;
 			fileType = sourcecode.asm.asm;
+			inputFiles = (
+			);
 			isEditable = 1;
 			outputFiles = (
 "${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o",
 			);
-			script = "${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
+			script = "# This DYLD_ROOT_PATH hack is there to allow the yasm binary to run on macOS if it was built for another platform (e.g. iphonesimulator) - rdar://52020841 and rdar://50479465\nDYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
 		};
 /* End PBXBuildRule section */
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246944] trunk/Tools

2019-06-28 Thread rmorisset

Title: [246944] trunk/Tools








Revision 246944
Author rmoris...@apple.com
Date 2019-06-28 15:48:13 -0700 (Fri, 28 Jun 2019)


Log Message
Adding myself as a reviewer in contributors.json.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (246943 => 246944)

--- trunk/Tools/ChangeLog	2019-06-28 22:27:58 UTC (rev 246943)
+++ trunk/Tools/ChangeLog	2019-06-28 22:48:13 UTC (rev 246944)
@@ -1,3 +1,11 @@
+2019-06-28  Robin Morisset  
+
+Adding myself as a reviewer to contributors.json.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2019-06-28  Jer Noble  
 
 Add new -[WKWebView _closeAllMediaPresentations] SPI


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (246943 => 246944)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2019-06-28 22:27:58 UTC (rev 246943)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2019-06-28 22:48:13 UTC (rev 246944)
@@ -4627,7 +4627,7 @@
   "nicks" : [
  "rmorisset"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Roger Fong" : {
   "emails" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246943] trunk

2019-06-28 Thread zalan

Title: [246943] trunk








Revision 246943
Author za...@apple.com
Date 2019-06-28 15:27:58 -0700 (Fri, 28 Jun 2019)


Log Message
[Text autosizing][iPadOS] bing.com is hard to read even with boosted text because of the line height
https://bugs.webkit.org/show_bug.cgi?id=199318


Reviewed by Wenson Hsieh.

Source/WebCore:

Initial implementation of line height boosting on iPadOs. It enlarges line height in certain cases to improve readability when the text content feels too dense.
It kicks in only for relatively small text (12px) where it slightly (1.25x) changes the line height to widen the gap between lines.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyleForTextAutosizing):

LayoutTests:

* fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt: Added.
* fast/text-autosizing/ios/idempotentmode/line-height-boosting.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp


Added Paths

trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt
trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting.html




Diff

Modified: trunk/LayoutTests/ChangeLog (246942 => 246943)

--- trunk/LayoutTests/ChangeLog	2019-06-28 22:24:23 UTC (rev 246942)
+++ trunk/LayoutTests/ChangeLog	2019-06-28 22:27:58 UTC (rev 246943)
@@ -1,3 +1,14 @@
+2019-06-28  Zalan Bujtas  
+
+[Text autosizing][iPadOS] bing.com is hard to read even with boosted text because of the line height
+https://bugs.webkit.org/show_bug.cgi?id=199318
+
+
+Reviewed by Wenson Hsieh.
+
+* fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt: Added.
+* fast/text-autosizing/ios/idempotentmode/line-height-boosting.html: Added.
+
 2019-06-27  Ryosuke Niwa  
 
 Fix the test added in r246868 on iOS debug simulator.


Added: trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt (0 => 246943)

--- trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt	2019-06-28 22:27:58 UTC (rev 246943)
@@ -0,0 +1,13 @@
+PASS result is >= 18
+PASS result is >= 13
+PASS result is >= 11
+PASS result is >= 12
+PASS result is >= 18
+PASS successfullyParsed is true
+
+TEST COMPLETE
+yes line-height boost
+yes line-height boost
+yes line-height boost
+no line-height boost
+no line-height boost


Added: trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting.html (0 => 246943)

--- trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting.html	(rev 0)
+++ trunk/LayoutTests/fast/text-autosizing/ios/idempotentmode/line-height-boosting.html	2019-06-28 22:27:58 UTC (rev 246943)
@@ -0,0 +1,38 @@
+
+
+
+
+
+if (window.internals) {
+window.internals.settings.setTextAutosizingEnabled(true);
+window.internals.settings.setTextAutosizingUsesIdempotentMode(true);
+}
+
+
+
+yes line-height boost
+yes line-height boost
+yes line-height boost
+no line-height boost
+no line-height boost
+