[webkit-changes] [284518] trunk

2021-10-19 Thread nham
Title: [284518] trunk








Revision 284518
Author n...@apple.com
Date 2021-10-19 22:16:30 -0700 (Tue, 19 Oct 2021)


Log Message
Add NetworkProcess stubs for push subscriptions
https://bugs.webkit.org/show_bug.cgi?id=231922

Reviewed by Youenn Fablet.

Source/WebCore:

Both PushManager and PushSubscription now send their subscription requests to NetworkProcess
via ServiceWorkerRegistration => ServiceWorkerContainer => SWClientConnection.

* Headers.cmake:
* Modules/push-api/PushManager.cpp:
(WebCore::PushManager::subscribe):
(WebCore::PushManager::getSubscription):
(WebCore::PushManager::permissionState):
* Modules/push-api/PushPermissionState.h:
* Modules/push-api/PushSubscription.cpp:
(WebCore::PushSubscription::PushSubscription):
(WebCore::PushSubscription::unsubscribe):
* Modules/push-api/PushSubscription.h:
* Modules/push-api/PushSubscriptionData.cpp:
(WebCore::PushSubscriptionData::isolatedCopy const):
* Modules/push-api/PushSubscriptionData.h:
(WebCore::PushSubscriptionData::encode const):
(WebCore::PushSubscriptionData::decode):
* Modules/push-api/PushSubscriptionOptions.cpp:
(WebCore::PushSubscriptionOptions::PushSubscriptionOptions):
(WebCore::PushSubscriptionOptions::userVisibleOnly const):
* Modules/push-api/PushSubscriptionOptions.h:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* testing/Internals.cpp:
(WebCore::Internals::createPushSubscription):
* testing/Internals.h:
* testing/Internals.idl:
* workers/service/SWClientConnection.h:
* workers/service/ServiceWorkerContainer.cpp:
(WebCore::createPushSubscriptionFromData):
(WebCore::ServiceWorkerContainer::subscribeToPushService):
(WebCore::ServiceWorkerContainer::unsubscribeFromPushService):
(WebCore::ServiceWorkerContainer::getPushSubscription):
(WebCore::ServiceWorkerContainer::getPushPermissionState):
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::subscribeToPushService):
(WebCore::ServiceWorkerRegistration::unsubscribeFromPushService):
(WebCore::ServiceWorkerRegistration::getPushSubscription):
(WebCore::ServiceWorkerRegistration::getPushPermissionState):
* workers/service/ServiceWorkerRegistration.h:
* workers/service/ServiceWorkerRegistration.idl:
* workers/service/WorkerSWClientConnection.cpp:
(WebCore::WorkerSWClientConnection::~WorkerSWClientConnection):
(WebCore::WorkerSWClientConnection::subscribeToPushService):
(WebCore::WorkerSWClientConnection::unsubscribeFromPushService):
(WebCore::WorkerSWClientConnection::getPushSubscription):
(WebCore::WorkerSWClientConnection::getPushPermissionState):
* workers/service/WorkerSWClientConnection.h:

Source/WebKit:

Added stubs in NetworkProcess for push subscription-related IPC. Currently the stubs return
that subscribing is unsupported and that there are no active push subscriptions.

* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::subscribeToPushService):
(WebKit::WebSWServerConnection::unsubscribeFromPushService):
(WebKit::WebSWServerConnection::getPushSubscription):
(WebKit::WebSWServerConnection::getPushPermissionState):
* NetworkProcess/ServiceWorker/WebSWServerConnection.h:
* NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::subscribeToPushService):
(WebKit::WebSWClientConnection::unsubscribeFromPushService):
(WebKit::WebSWClientConnection::getPushSubscription):
(WebKit::WebSWClientConnection::getPushPermissionState):
* WebProcess/Storage/WebSWClientConnection.h:

LayoutTests:

Modify PushSubscription tests to pass in a ServiceWorkerRegistration.

* http/wpt/push-api/emptyWorker.js: Renamed from LayoutTests/http/wpt/push-api/pushManager-worker.js.
* http/wpt/push-api/pushManager.any.js:
(else.promise_test.async test):
* http/wpt/push-api/pushSubscription.https.any-expected.txt:
* http/wpt/push-api/pushSubscription.https.any.js:
(promise_test.async test):
(promise_test):
(test): Deleted.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/push-api/pushManager.any.js
trunk/LayoutTests/http/wpt/push-api/pushSubscription.https.any-expected.txt
trunk/LayoutTests/http/wpt/push-api/pushSubscription.https.any.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Modules/push-api/PushManager.cpp
trunk/Source/WebCore/Modules/push-api/PushPermissionState.h
trunk/Source/WebCore/Modules/push-api/PushSubscription.cpp
trunk/Source/WebCore/Modules/push-api/PushSubscription.h
trunk/Source/WebCore/Modules/push-api/PushSubscriptionOptions.cpp
trunk/Source/WebCore/Modules/push-api/PushSubscriptionOptions.h
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/workers/service/SWClientConnection.h

[webkit-changes] [284517] trunk/Source/WebKit

2021-10-19 Thread commit-queue
Title: [284517] trunk/Source/WebKit








Revision 284517
Author commit-qu...@webkit.org
Date 2021-10-19 21:49:28 -0700 (Tue, 19 Oct 2021)


Log Message
Fix build break after r284406 if ENABLE_SERVICE_WORKER=OFF
https://bugs.webkit.org/show_bug.cgi?id=231968

Patch by Jigen Zhou  on 2021-10-19
Reviewed by Don Olmstead.

r284406 made m_isServiceWorkerPage of WebPageProxy not available if !ENABLE(SERVICE_WORKER),
but the change was incomplete and can cause build failure if ENABLE_SERVICE_WORKER=OFF.
This patch avoids accessing m_isServiceWorkerPage if !ENABLE(SERVICE_WORKER) in WebPageProxy
methods isServiceWorkerPage, loadDataWithNavigationShared, and resetStateAfterProcessExited.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (284516 => 284517)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 03:25:35 UTC (rev 284516)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 04:49:28 UTC (rev 284517)
@@ -1,3 +1,18 @@
+2021-10-19  Jigen Zhou  
+
+Fix build break after r284406 if ENABLE_SERVICE_WORKER=OFF
+https://bugs.webkit.org/show_bug.cgi?id=231968
+
+Reviewed by Don Olmstead.
+
+r284406 made m_isServiceWorkerPage of WebPageProxy not available if !ENABLE(SERVICE_WORKER), 
+but the change was incomplete and can cause build failure if ENABLE_SERVICE_WORKER=OFF. 
+This patch avoids accessing m_isServiceWorkerPage if !ENABLE(SERVICE_WORKER) in WebPageProxy 
+methods isServiceWorkerPage, loadDataWithNavigationShared, and resetStateAfterProcessExited.  
+
+* UIProcess/WebPageProxy.cpp:
+* UIProcess/WebPageProxy.h:
+
 2021-10-19  Don Olmstead  
 
 Non-unified build fixes, mid October 2021 edition


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (284516 => 284517)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-10-20 03:25:35 UTC (rev 284516)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-10-20 04:49:28 UTC (rev 284517)
@@ -1534,7 +1534,7 @@
 loadParameters.websitePolicies = WTFMove(websitePolicies);
 loadParameters.shouldOpenExternalURLsPolicy = shouldOpenExternalURLsPolicy;
 loadParameters.isNavigatingToAppBoundDomain = isNavigatingToAppBoundDomain;
-loadParameters.isServiceWorkerLoad = m_isServiceWorkerPage;
+loadParameters.isServiceWorkerLoad = isServiceWorkerPage();
 addPlatformLoadParameters(process, loadParameters);
 
 process->markProcessAsRecentlyUsed();
@@ -7996,7 +7996,9 @@
 
 m_hasRunningProcess = false;
 m_areActiveDOMObjectsAndAnimationsSuspended = false;
+#if ENABLE(SERVICE_WORKER)
 m_isServiceWorkerPage = false;
+#endif
 
 m_userScriptsNotified = false;
 m_hasActiveAnimatedScroll = false;


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (284516 => 284517)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.h	2021-10-20 03:25:35 UTC (rev 284516)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h	2021-10-20 04:49:28 UTC (rev 284517)
@@ -1938,7 +1938,11 @@
 bool acceptsFirstMouse(int eventNumber, const WebMouseEvent&);
 #endif
 
+#if ENABLE(SERVICE_WORKER)
 bool isServiceWorkerPage() const { return m_isServiceWorkerPage; }
+#else
+bool isServiceWorkerPage() const { return false; }
+#endif
 
 void dispatchWheelEventWithoutScrolling(const WebWheelEvent&, CompletionHandler&&);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284516] trunk/Source

2021-10-19 Thread don . olmstead
Title: [284516] trunk/Source








Revision 284516
Author don.olmst...@sony.com
Date 2021-10-19 20:25:35 -0700 (Tue, 19 Oct 2021)


Log Message
Non-unified build fixes, mid October 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=231915

Unreviewed non-unified build fixes.


Source/WebCore:

* animation/KeyframeEffectStack.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* dom/ActiveDOMObject.cpp:
* html/DOMFormData.cpp:
* html/HTMLDialogElement.cpp:
* html/HTMLOutputElement.cpp:
* html/ResetInputType.cpp:
* page/DragController.cpp:
* page/EventHandler.cpp:
* rendering/updating/RenderTreeBuilderFirstLetter.cpp:

Source/WebKit:

* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.cpp:
* WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffectStack.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/dom/ActiveDOMObject.cpp
trunk/Source/WebCore/html/DOMFormData.cpp
trunk/Source/WebCore/html/HTMLDialogElement.cpp
trunk/Source/WebCore/html/HTMLOutputElement.cpp
trunk/Source/WebCore/html/ResetInputType.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (284515 => 284516)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 03:25:35 UTC (rev 284516)
@@ -1,3 +1,21 @@
+2021-10-19  Don Olmstead  
+
+Non-unified build fixes, mid October 2021 edition
+https://bugs.webkit.org/show_bug.cgi?id=231915
+
+Unreviewed non-unified build fixes.
+
+* animation/KeyframeEffectStack.cpp:
+* bindings/js/JSDOMWindowBase.cpp:
+* dom/ActiveDOMObject.cpp:
+* html/DOMFormData.cpp:
+* html/HTMLDialogElement.cpp:
+* html/HTMLOutputElement.cpp:
+* html/ResetInputType.cpp:
+* page/DragController.cpp:
+* page/EventHandler.cpp:
+* rendering/updating/RenderTreeBuilderFirstLetter.cpp:
+
 2021-10-19  Jigen Zhou  
 
 r284315 can cause build break.


Modified: trunk/Source/WebCore/animation/KeyframeEffectStack.cpp (284515 => 284516)

--- trunk/Source/WebCore/animation/KeyframeEffectStack.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/animation/KeyframeEffectStack.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -31,6 +31,7 @@
 #include "KeyframeEffect.h"
 #include "WebAnimation.h"
 #include "WebAnimationUtilities.h"
+#include 
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp (284515 => 284516)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -30,6 +30,7 @@
 #include "DOMWindow.h"
 #include "Document.h"
 #include "Element.h"
+#include "Event.h"
 #include "EventLoop.h"
 #include "FetchResponse.h"
 #include "Frame.h"


Modified: trunk/Source/WebCore/dom/ActiveDOMObject.cpp (284515 => 284516)

--- trunk/Source/WebCore/dom/ActiveDOMObject.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/dom/ActiveDOMObject.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -28,6 +28,7 @@
 #include "ActiveDOMObject.h"
 
 #include "Document.h"
+#include "Event.h"
 #include "EventLoop.h"
 #include "ScriptExecutionContext.h"
 


Modified: trunk/Source/WebCore/html/DOMFormData.cpp (284515 => 284516)

--- trunk/Source/WebCore/html/DOMFormData.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/html/DOMFormData.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -31,6 +31,7 @@
 #include "config.h"
 #include "DOMFormData.h"
 
+#include "Document.h"
 #include "HTMLFormControlElement.h"
 #include "HTMLFormElement.h"
 


Modified: trunk/Source/WebCore/html/HTMLDialogElement.cpp (284515 => 284516)

--- trunk/Source/WebCore/html/HTMLDialogElement.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/html/HTMLDialogElement.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -25,11 +25,15 @@
 
 #include "config.h"
 #include "HTMLDialogElement.h"
+
+#include "DocumentInlines.h"
 #include "EventLoop.h"
 #include "EventNames.h"
 #include "FocusOptions.h"
-
+#include "GCReachableRef.h"
 #include "HTMLNames.h"
+#include "RenderElement.h"
+#include "TypedElementDescendantIterator.h"
 #include 
 
 namespace WebCore {


Modified: trunk/Source/WebCore/html/HTMLOutputElement.cpp (284515 => 284516)

--- trunk/Source/WebCore/html/HTMLOutputElement.cpp	2021-10-20 03:03:58 UTC (rev 284515)
+++ trunk/Source/WebCore/html/HTMLOutputElement.cpp	2021-10-20 03:25:35 UTC (rev 284516)
@@ -33,6 +33,7 @@
 #include 

[webkit-changes] [284515] trunk/Source/WebCore

2021-10-19 Thread commit-queue
Title: [284515] trunk/Source/WebCore








Revision 284515
Author commit-qu...@webkit.org
Date 2021-10-19 20:03:58 -0700 (Tue, 19 Oct 2021)


Log Message
r284315 can cause build break.
https://bugs.webkit.org/show_bug.cgi?id=231923

Patch by Jigen Zhou  on 2021-10-19
Reviewed by Michael Catanzaro.

Class 'WebCore::RenderBlockFlow' was forward declared in header file
InlineIteratorLogicalOrderTraversal.h, but template
leafBoxesInLogicalOrder that was added by r284315 has access to RenderBlockFLow's method
style() and can cause build break in our local webkit build.

The build can be fixed when the concreate declaration of class
RenderBlockFlow is included in InlineIteratorLogicalOrderTraversal.h.

* layout/integration/InlineIteratorLogicalOrderTraversal.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284514 => 284515)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 00:58:48 UTC (rev 284514)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 03:03:58 UTC (rev 284515)
@@ -1,3 +1,20 @@
+2021-10-19  Jigen Zhou  
+
+r284315 can cause build break.
+https://bugs.webkit.org/show_bug.cgi?id=231923
+
+Reviewed by Michael Catanzaro.
+
+Class 'WebCore::RenderBlockFlow' was forward declared in header file
+InlineIteratorLogicalOrderTraversal.h, but template
+leafBoxesInLogicalOrder that was added by r284315 has access to RenderBlockFLow's method
+style() and can cause build break in our local webkit build.
+
+The build can be fixed when the concreate declaration of class
+RenderBlockFlow is included in InlineIteratorLogicalOrderTraversal.h.
+
+* layout/integration/InlineIteratorLogicalOrderTraversal.h:
+
 2021-10-19  Ross Kirsling  
 
 [CMake] Align OptionsMac with Xcode build


Modified: trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h (284514 => 284515)

--- trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h	2021-10-20 00:58:48 UTC (rev 284514)
+++ trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h	2021-10-20 03:03:58 UTC (rev 284515)
@@ -27,6 +27,7 @@
 
 #include "InlineIteratorLine.h"
 #include "InlineIteratorTextBox.h"
+#include "RenderBlockFlow.h"
 
 namespace WebCore {
 namespace InlineIterator {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284514] tags/Safari-612.3.1/

2021-10-19 Thread alancoon
Title: [284514] tags/Safari-612.3.1/








Revision 284514
Author alanc...@apple.com
Date 2021-10-19 17:58:48 -0700 (Tue, 19 Oct 2021)


Log Message
Tag Safari-612.3.1.

Added Paths

tags/Safari-612.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284513] trunk/Source/JavaScriptCore

2021-10-19 Thread tzagallo
Title: [284513] trunk/Source/_javascript_Core








Revision 284513
Author tzaga...@apple.com
Date 2021-10-19 17:40:19 -0700 (Tue, 19 Oct 2021)


Log Message
Address post-landing feedback to wasm exceptions
https://bugs.webkit.org/show_bug.cgi?id=231973

Reviewed by Saam Barati.

Address comments left by Saam in https://bugs.webkit.org/show_bug.cgi?id=229681
after the patch landed. This includes deleting some unused code, and renaming a
couple variables and methods, but the biggest change is copying the callee saves
to VMEntry in the llint rethrow.

* interpreter/Interpreter.cpp:
(JSC::CatchInfo::CatchInfo):
(JSC::UnwindFunctor::operator() const):
* interpreter/Interpreter.h:
(JSC::CatchInfo::CatchInfo): Deleted.
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::convertCalleeToVM): Deleted.
* llint/WebAssembly.asm:
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::ControlData::ControlData):
(JSC::Wasm::B3IRGenerator::ControlData::tryDepth const):
(JSC::Wasm::B3IRGenerator::connectControlAtEntrypoint):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::addTry):
(JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions):
(JSC::Wasm::B3IRGenerator::emitCatchImpl):
(JSC::Wasm::B3IRGenerator::addDelegateToUnreachable):
(JSC::Wasm::B3IRGenerator::addThrow):
(JSC::Wasm::B3IRGenerator::addRethrow):
(JSC::Wasm::B3IRGenerator::addEndToUnreachable):
(JSC::Wasm::B3IRGenerator::connectControlEntry): Deleted.
* wasm/WasmCallee.h:
(JSC::Wasm::Callee::llintFunctionCodeBlock const):
(JSC::Wasm::Callee::functionCodeBlock const): Deleted.
* wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::unifyValuesWithBlock):
(JSC::Wasm::LLIntGenerator::addTry):
(JSC::Wasm::LLIntGenerator::addThrow):
(JSC::Wasm::LLIntGenerator::repatch): Deleted.
* wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
* wasm/WasmOperations.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/_javascript_Core/jit/JSInterfaceJIT.h
trunk/Source/_javascript_Core/llint/WebAssembly.asm
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmCallee.h
trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmOperations.cpp
trunk/Source/_javascript_Core/wasm/WasmOperations.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284512 => 284513)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-20 00:30:31 UTC (rev 284512)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-20 00:40:19 UTC (rev 284513)
@@ -1,3 +1,48 @@
+2021-10-19  Tadeu Zagallo  
+
+Address post-landing feedback to wasm exceptions
+https://bugs.webkit.org/show_bug.cgi?id=231973
+
+Reviewed by Saam Barati.
+
+Address comments left by Saam in https://bugs.webkit.org/show_bug.cgi?id=229681
+after the patch landed. This includes deleting some unused code, and renaming a
+couple variables and methods, but the biggest change is copying the callee saves
+to VMEntry in the llint rethrow.
+
+* interpreter/Interpreter.cpp:
+(JSC::CatchInfo::CatchInfo):
+(JSC::UnwindFunctor::operator() const):
+* interpreter/Interpreter.h:
+(JSC::CatchInfo::CatchInfo): Deleted.
+* jit/JSInterfaceJIT.h:
+(JSC::JSInterfaceJIT::convertCalleeToVM): Deleted.
+* llint/WebAssembly.asm:
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::ControlData::ControlData):
+(JSC::Wasm::B3IRGenerator::ControlData::tryDepth const):
+(JSC::Wasm::B3IRGenerator::connectControlAtEntrypoint):
+(JSC::Wasm::B3IRGenerator::addLoop):
+(JSC::Wasm::B3IRGenerator::addTry):
+(JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions):
+(JSC::Wasm::B3IRGenerator::emitCatchImpl):
+(JSC::Wasm::B3IRGenerator::addDelegateToUnreachable):
+(JSC::Wasm::B3IRGenerator::addThrow):
+(JSC::Wasm::B3IRGenerator::addRethrow):
+(JSC::Wasm::B3IRGenerator::addEndToUnreachable):
+(JSC::Wasm::B3IRGenerator::connectControlEntry): Deleted.
+* wasm/WasmCallee.h:
+(JSC::Wasm::Callee::llintFunctionCodeBlock const):
+(JSC::Wasm::Callee::functionCodeBlock const): Deleted.
+* wasm/WasmLLIntGenerator.cpp:
+(JSC::Wasm::LLIntGenerator::unifyValuesWithBlock):
+(JSC::Wasm::LLIntGenerator::addTry):
+(JSC::Wasm::LLIntGenerator::addThrow):
+(JSC::Wasm::LLIntGenerator::repatch): Deleted.
+* wasm/WasmOperations.cpp:
+(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
+* wasm/WasmOperations.h:
+
 2021-10-19  Alexey Proskuryakov  
 
 Eagerly resolve python3 path in Makefiles


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (284512 => 284513)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	

[webkit-changes] [284512] trunk

2021-10-19 Thread ross . kirsling
Title: [284512] trunk








Revision 284512
Author ross.kirsl...@sony.com
Date 2021-10-19 17:30:31 -0700 (Tue, 19 Oct 2021)


Log Message
[CMake] Align OptionsMac with Xcode build
https://bugs.webkit.org/show_bug.cgi?id=231982

Reviewed by Don Olmstead.

.:

* Source/cmake/OptionsMac.cmake:
Ensure that the listed options (1) are not redundant with the defaults in WebKitFeatures.cmake and
(2) match the options for the Xcode build as closely as possible.

* Source/cmake/WebKitFeatures.cmake:
Remove an outdated feature, ENABLE_APPLE_PAY_SESSION_V9,
and let ENABLE_MAC_GESTURE_EVENTS be handled by PlatformEnable, since it depends on USE_APPLE_INTERNAL_SDK.

Source/WebCore:

* PlatformMac.cmake:
Add support for new files.

* platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
Fix for r284295 -- ReplayKit is iOS and its headers shouldn't be included on Mac.

Source/WebKit:

* CMakeLists.txt:
Enable -fobjc-weak to support r284329.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/cmake/OptionsMac.cmake
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (284511 => 284512)

--- trunk/ChangeLog	2021-10-20 00:16:38 UTC (rev 284511)
+++ trunk/ChangeLog	2021-10-20 00:30:31 UTC (rev 284512)
@@ -1,3 +1,18 @@
+2021-10-19  Ross Kirsling  
+
+[CMake] Align OptionsMac with Xcode build
+https://bugs.webkit.org/show_bug.cgi?id=231982
+
+Reviewed by Don Olmstead.
+
+* Source/cmake/OptionsMac.cmake:
+Ensure that the listed options (1) are not redundant with the defaults in WebKitFeatures.cmake and
+(2) match the options for the Xcode build as closely as possible.
+
+* Source/cmake/WebKitFeatures.cmake:
+Remove an outdated feature, ENABLE_APPLE_PAY_SESSION_V9,
+and let ENABLE_MAC_GESTURE_EVENTS be handled by PlatformEnable, since it depends on USE_APPLE_INTERNAL_SDK.
+
 2021-10-19  Tyler Wilcock  
 
 Add AX team GitHub usernames to contributors.json


Modified: trunk/Source/WebCore/ChangeLog (284511 => 284512)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 00:16:38 UTC (rev 284511)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 00:30:31 UTC (rev 284512)
@@ -1,3 +1,16 @@
+2021-10-19  Ross Kirsling  
+
+[CMake] Align OptionsMac with Xcode build
+https://bugs.webkit.org/show_bug.cgi?id=231982
+
+Reviewed by Don Olmstead.
+
+* PlatformMac.cmake:
+Add support for new files.
+
+* platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
+Fix for r284295 -- ReplayKit is iOS and its headers shouldn't be included on Mac.
+
 2021-10-19  Ben Nham  
 
 Unreviewed build fix for non-unified build.


Modified: trunk/Source/WebCore/PlatformMac.cmake (284511 => 284512)

--- trunk/Source/WebCore/PlatformMac.cmake	2021-10-20 00:16:38 UTC (rev 284511)
+++ trunk/Source/WebCore/PlatformMac.cmake	2021-10-20 00:30:31 UTC (rev 284512)
@@ -665,6 +665,7 @@
 platform/graphics/cocoa/VP9UtilitiesCocoa.h
 platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h
 platform/graphics/cocoa/WebCoreCALayerExtras.h
+platform/graphics/cocoa/WebGLLayer.h
 platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h
 
 platform/graphics/cv/CVUtilities.h


Modified: trunk/Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp (284511 => 284512)

--- trunk/Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp	2021-10-20 00:16:38 UTC (rev 284511)
+++ trunk/Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp	2021-10-20 00:30:31 UTC (rev 284512)
@@ -29,6 +29,7 @@
 #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA)
 
 #include "CGDisplayStreamScreenCaptureSource.h"
+#include "CoreVideoSoftLink.h"
 #include "ImageTransferSessionVT.h"
 #include "Logging.h"
 #include "MediaSampleAVFObjC.h"
@@ -38,12 +39,12 @@
 #include "RealtimeMediaSourceSettings.h"
 #include "RealtimeVideoUtilities.h"
 #include "RemoteVideoSample.h"
-#include "ReplayKitCaptureSource.h"
 #include "Timer.h"
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -51,8 +52,9 @@
 #include 
 #include 
 
-#include "CoreVideoSoftLink.h"
-#include 
+#if PLATFORM(IOS)
+#include "ReplayKitCaptureSource.h"
+#endif
 
 namespace WebCore {
 


Modified: trunk/Source/WebKit/CMakeLists.txt (284511 => 284512)

--- trunk/Source/WebKit/CMakeLists.txt	2021-10-20 00:16:38 UTC (rev 284511)
+++ trunk/Source/WebKit/CMakeLists.txt	2021-10-20 00:30:31 UTC (rev 284512)
@@ -627,6 +627,10 @@
 endif ()
 endif ()
 
+if (APPLE)
+WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -fobjc-weak)
+endif ()
+
 if ("${PORT}" STREQUAL "Mac")
 WEBKIT_DEFINE_XPC_SERVICES()
 else ()


Modified: trunk/Source/WebKit/ChangeLog (284511 => 284512)

--- trunk/Source/WebKit/ChangeLog	

[webkit-changes] [284511] trunk/Source/WebCore

2021-10-19 Thread nham
Title: [284511] trunk/Source/WebCore








Revision 284511
Author n...@apple.com
Date 2021-10-19 17:16:38 -0700 (Tue, 19 Oct 2021)


Log Message
Unreviewed build fix for non-unified build.

* Modules/webaudio/RealtimeAnalyser.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284510 => 284511)

--- trunk/Source/WebCore/ChangeLog	2021-10-19 23:56:15 UTC (rev 284510)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 00:16:38 UTC (rev 284511)
@@ -1,3 +1,9 @@
+2021-10-19  Ben Nham  
+
+Unreviewed build fix for non-unified build.
+
+* Modules/webaudio/RealtimeAnalyser.h:
+
 2021-10-19  Alexey Proskuryakov  
 
 Eagerly resolve python3 path in Makefiles


Modified: trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h (284510 => 284511)

--- trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h	2021-10-19 23:56:15 UTC (rev 284510)
+++ trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h	2021-10-20 00:16:38 UTC (rev 284511)
@@ -25,6 +25,7 @@
 #pragma once
 
 #include "AudioArray.h"
+#include "AudioBus.h"
 #include <_javascript_Core/Forward.h>
 #include 
 #include 
@@ -32,7 +33,6 @@
 
 namespace WebCore {
 
-class AudioBus;
 class FFTFrame;
 
 class RealtimeAnalyser {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284509] branches/safari-613.1.6-branch/Source/WebCore/PAL

2021-10-19 Thread alancoon
Title: [284509] branches/safari-613.1.6-branch/Source/WebCore/PAL








Revision 284509
Author alanc...@apple.com
Date 2021-10-19 16:54:52 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r284494. rdar://problem/84439983

REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header



Reviewed by Wenson Hsieh.

* PAL.xcodeproj/project.pbxproj:
- Change TCCSPI.h from a private header to a project header.
  PAL uses a build phase script to install its headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.6-branch/Source/WebCore/PAL/ChangeLog
branches/safari-613.1.6-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj




Diff

Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/ChangeLog (284508 => 284509)

--- branches/safari-613.1.6-branch/Source/WebCore/PAL/ChangeLog	2021-10-19 23:34:31 UTC (rev 284508)
+++ branches/safari-613.1.6-branch/Source/WebCore/PAL/ChangeLog	2021-10-19 23:54:52 UTC (rev 284509)
@@ -1,3 +1,32 @@
+2021-10-19  Alan Coon  
+
+Cherry-pick r284494. rdar://problem/84439983
+
+REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header
+
+
+
+Reviewed by Wenson Hsieh.
+
+* PAL.xcodeproj/project.pbxproj:
+- Change TCCSPI.h from a private header to a project header.
+  PAL uses a build phase script to install its headers.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-19  David Kilzer  
+
+REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header
+
+
+
+Reviewed by Wenson Hsieh.
+
+* PAL.xcodeproj/project.pbxproj:
+- Change TCCSPI.h from a private header to a project header.
+  PAL uses a build phase script to install its headers.
+
 2021-10-18  Carlos Garcia Campos  
 
 [GLIB] Simplify SleepDisabler by checking if we are under sandbox


Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (284508 => 284509)

--- branches/safari-613.1.6-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2021-10-19 23:34:31 UTC (rev 284508)
+++ branches/safari-613.1.6-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2021-10-19 23:54:52 UTC (rev 284509)
@@ -140,7 +140,7 @@
 		4450FCA021F5F602004DFA56 /* QuickLookSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 4450FC9E21F5F602004DFA56 /* QuickLookSoftLink.h */; };
 		44E1A8AF21FA54E600C3048E /* LookupSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 44E1A8AD21FA54DA00C3048E /* LookupSoftLink.h */; };
 		44E1A8B021FA54EB00C3048E /* LookupSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 44E1A8AE21FA54DA00C3048E /* LookupSoftLink.mm */; };
-		4996C0F32717644C002C125D /* TCCSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 4996C0F22717642B002C125D /* TCCSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		4996C0F32717644C002C125D /* TCCSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 4996C0F22717642B002C125D /* TCCSPI.h */; };
 		517E03F924B7C0070054895A /* IOKitSPIMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 517E03F824B7C0060054895A /* IOKitSPIMac.h */; };
 		570AB8F120AE2E8D00B8BE87 /* SecKeyProxySPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F020AE2E8D00B8BE87 /* SecKeyProxySPI.h */; };
 		570AB8F920AF6E3D00B8BE87 /* NSXPCConnectionSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */; };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284508] branches/safari-613.1.6-branch/Source/WebKit

2021-10-19 Thread repstein
Title: [284508] branches/safari-613.1.6-branch/Source/WebKit








Revision 284508
Author repst...@apple.com
Date 2021-10-19 16:34:31 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r284489. rdar://problem/84439180

WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread
https://bugs.webkit.org/show_bug.cgi?id=231963


Patch by Garrett Davidson  on 2021-10-19
Reviewed by Brent Fulgham.

- The clearanceHandler is not guaranteed to happen on the main thread, but
weakThis.get() needs to happen there.

- `proxy` needs to stay alive for the whole transaction, otherwise it will tear
down the connection and cancel the request, so explicitly capture it everywhere.

- Start logging if we get an error from clearanceHandler.

Covered by existing tests.

* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.6-branch/Source/WebKit/ChangeLog
branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm




Diff

Modified: branches/safari-613.1.6-branch/Source/WebKit/ChangeLog (284507 => 284508)

--- branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-19 23:14:19 UTC (rev 284507)
+++ branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-19 23:34:31 UTC (rev 284508)
@@ -1,5 +1,52 @@
 2021-10-19  Alan Coon  
 
+Cherry-pick r284489. rdar://problem/84439180
+
+WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=231963
+
+
+Patch by Garrett Davidson  on 2021-10-19
+Reviewed by Brent Fulgham.
+
+- The clearanceHandler is not guaranteed to happen on the main thread, but
+weakThis.get() needs to happen there.
+
+- `proxy` needs to stay alive for the whole transaction, otherwise it will tear
+down the connection and cancel the request, so explicitly capture it everywhere.
+
+- Start logging if we get an error from clearanceHandler.
+
+Covered by existing tests.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-19  Garrett Davidson  
+
+WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=231963
+
+
+Reviewed by Brent Fulgham.
+
+- The clearanceHandler is not guaranteed to happen on the main thread, but
+weakThis.get() needs to happen there.
+
+- `proxy` needs to stay alive for the whole transaction, otherwise it will tear
+down the connection and cancel the request, so explicitly capture it everywhere.
+
+- Start logging if we get an error from clearanceHandler.
+
+Covered by existing tests.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
+
+2021-10-19  Alan Coon  
+
 Cherry-pick r284495. rdar://problem/84433820
 
 Unreviewed, reverting r284099.


Modified: branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (284507 => 284508)

--- branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-10-19 23:14:19 UTC (rev 284507)
+++ branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-10-19 23:34:31 UTC (rev 284508)
@@ -264,75 +264,74 @@
 auto proxy = adoptNS([allocASCAgentProxyInstance() init]);
 
 RetainPtr window = m_webPageProxy.platformWindow();
-[proxy performAuthorizationRequestsForContext:requestContext.get() withClearanceHandler:makeBlockPtr([weakThis = WeakPtr { *this }, handler = WTFMove(handler), window = WTFMove(window)](NSXPCListenerEndpoint *daemonEnpoint, NSError *error) mutable {
-auto protectedThis = weakThis.get();
-
-if (!protectedThis || !daemonEnpoint) {
-RunLoop::main().dispatch([handler = WTFMove(handler)]() mutable {
+[proxy performAuthorizationRequestsForContext:requestContext.get() withClearanceHandler:makeBlockPtr([weakThis = WeakPtr { *this }, handler = WTFMove(handler), window = WTFMove(window), proxy = WTFMove(proxy)](NSXPCListenerEndpoint *daemonEndpoint, NSError *error) mutable {
+callOnMainRunLoop([weakThis, handler = WTFMove(handler), window = WTFMove(window), proxy = WTFMove(proxy), daemonEndpoint = 

[webkit-changes] [284507] trunk/Source

2021-10-19 Thread ap
Title: [284507] trunk/Source








Revision 284507
Author a...@apple.com
Date 2021-10-19 16:14:19 -0700 (Tue, 19 Oct 2021)


Log Message
Eagerly resolve python3 path in Makefiles
https://bugs.webkit.org/show_bug.cgi?id=231979

Reviewed by Jonathan Bedard.

* DerivedSources.make:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources.make
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources.make




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284506 => 284507)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-19 23:14:19 UTC (rev 284507)
@@ -1,3 +1,12 @@
+2021-10-19  Alexey Proskuryakov  
+
+Eagerly resolve python3 path in Makefiles
+https://bugs.webkit.org/show_bug.cgi?id=231979
+
+Reviewed by Jonathan Bedard.
+
+* DerivedSources.make:
+
 2021-10-19  Saam Barati  
 
 canDoFastSpread should also check that the Structure is from the global object we're watching


Modified: trunk/Source/_javascript_Core/DerivedSources.make (284506 => 284507)

--- trunk/Source/_javascript_Core/DerivedSources.make	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/_javascript_Core/DerivedSources.make	2021-10-19 23:14:19 UTC (rev 284507)
@@ -24,11 +24,14 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-PYTHON = python3
-PERL = perl
-RUBY = ruby
-DELETE = rm -f
+# Workaround for rdar://84212106.
+find_tool = $(realpath $(shell xcrun --sdk $(SDK_NAME) -f $(1)))
 
+PYTHON := $(call find_tool,python3)
+PERL := perl
+RUBY := ruby
+DELETE := rm -f
+
 ifneq ($(SDKROOT),)
 SDK_FLAGS = -isysroot $(SDKROOT)
 endif


Modified: trunk/Source/WebCore/ChangeLog (284506 => 284507)

--- trunk/Source/WebCore/ChangeLog	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/WebCore/ChangeLog	2021-10-19 23:14:19 UTC (rev 284507)
@@ -1,3 +1,12 @@
+2021-10-19  Alexey Proskuryakov  
+
+Eagerly resolve python3 path in Makefiles
+https://bugs.webkit.org/show_bug.cgi?id=231979
+
+Reviewed by Jonathan Bedard.
+
+* DerivedSources.make:
+
 2021-10-19  Simon Fraser  
 
 Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing


Modified: trunk/Source/WebCore/DerivedSources.make (284506 => 284507)

--- trunk/Source/WebCore/DerivedSources.make	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/WebCore/DerivedSources.make	2021-10-19 23:14:19 UTC (rev 284507)
@@ -26,11 +26,14 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-PYTHON = python3
-PERL = perl
-RUBY = ruby
-DELETE = rm -f
+# Workaround for rdar://84212106.
+find_tool = $(realpath $(shell xcrun --sdk $(SDK_NAME) -f $(1)))
 
+PYTHON := $(call find_tool,python3)
+PERL := perl
+RUBY := ruby
+DELETE := rm -f
+
 ifneq ($(SDKROOT),)
 SDK_FLAGS = -isysroot $(SDKROOT)
 endif


Modified: trunk/Source/WebKit/ChangeLog (284506 => 284507)

--- trunk/Source/WebKit/ChangeLog	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/WebKit/ChangeLog	2021-10-19 23:14:19 UTC (rev 284507)
@@ -1,3 +1,12 @@
+2021-10-19  Alexey Proskuryakov  
+
+Eagerly resolve python3 path in Makefiles
+https://bugs.webkit.org/show_bug.cgi?id=231979
+
+Reviewed by Jonathan Bedard.
+
+* DerivedSources.make:
+
 2021-10-19  Commit Queue  
 
 Unreviewed, reverting r284099.


Modified: trunk/Source/WebKit/DerivedSources.make (284506 => 284507)

--- trunk/Source/WebKit/DerivedSources.make	2021-10-19 22:48:26 UTC (rev 284506)
+++ trunk/Source/WebKit/DerivedSources.make	2021-10-19 23:14:19 UTC (rev 284507)
@@ -108,10 +108,13 @@
 $(WEBKITADDITIONS_HEADER_SEARCH_PATHS) \
 #
 
-PYTHON = python3
-PERL = perl
-RUBY = ruby
+# Workaround for rdar://84212106.
+find_tool = $(realpath $(shell xcrun --sdk $(SDK_NAME) -f $(1)))
 
+PYTHON := $(call find_tool,python3)
+PERL := perl
+RUBY := ruby
+
 ifeq ($(OS),Windows_NT)
 DELETE = cmd //C del
 else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284506] trunk/Source/JavaScriptCore

2021-10-19 Thread sbarati
Title: [284506] trunk/Source/_javascript_Core








Revision 284506
Author sbar...@apple.com
Date 2021-10-19 15:48:26 -0700 (Tue, 19 Oct 2021)


Log Message
canDoFastSpread should also check that the Structure is from the global object we're watching
https://bugs.webkit.org/show_bug.cgi?id=231976


Reviewed by Keith Miller.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::canDoFastSpread):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284505 => 284506)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-19 22:37:56 UTC (rev 284505)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-19 22:48:26 UTC (rev 284506)
@@ -1,3 +1,14 @@
+2021-10-19  Saam Barati  
+
+canDoFastSpread should also check that the Structure is from the global object we're watching
+https://bugs.webkit.org/show_bug.cgi?id=231976
+
+
+Reviewed by Keith Miller.
+
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::canDoFastSpread):
+
 2021-10-19  Chris Dumez  
 
 [clang 13] Suppress sign comparison warnings


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (284505 => 284506)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2021-10-19 22:37:56 UTC (rev 284505)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2021-10-19 22:48:26 UTC (rev 284506)
@@ -1843,10 +1843,12 @@
 if (!value.m_structure.isFinite())
 return false;
 
-ArrayPrototype* arrayPrototype = globalObjectFor(node->child1()->origin.semantic)->arrayPrototype();
+JSGlobalObject* globalObject = globalObjectFor(node->child1()->origin.semantic);
+ArrayPrototype* arrayPrototype = globalObject->arrayPrototype();
 bool allGood = true;
 value.m_structure.forEach([&] (RegisteredStructure structure) {
 allGood &= structure->hasMonoProto()
+&& structure->globalObject() == globalObject
 && structure->storedPrototype() == arrayPrototype
 && !structure->isDictionary()
 && structure->getConcurrently(m_vm.propertyNames->iteratorSymbol.impl()) == invalidOffset






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284505] releases/WebKitGTK/webkit-2.34/Source/WebCore

2021-10-19 Thread aperez
Title: [284505] releases/WebKitGTK/webkit-2.34/Source/WebCore








Revision 284505
Author ape...@igalia.com
Date 2021-10-19 15:37:56 -0700 (Tue, 19 Oct 2021)


Log Message
Merge r284239 - [WPE][GTK] Update user agent browser versions
https://bugs.webkit.org/show_bug.cgi?id=231772

Patch by Michael Catanzaro  on 2021-10-15
Reviewed by Carlos Garcia Campos.

* platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/UserAgentQuirks.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/glib/UserAgentGLib.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (284504 => 284505)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2021-10-19 22:37:50 UTC (rev 284504)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2021-10-19 22:37:56 UTC (rev 284505)
@@ -1,3 +1,15 @@
+2021-10-15  Michael Catanzaro  
+
+[WPE][GTK] Update user agent browser versions
+https://bugs.webkit.org/show_bug.cgi?id=231772
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::UserAgentQuirks::stringForQuirk):
+* platform/glib/UserAgentGLib.cpp:
+(WebCore::buildUserAgentString):
+
 2021-10-13  Philippe Normand  
 
 [GStreamer] Crash in WebCore::MediaPlayerPrivateGStreamer::sourceSetup when loading reddit video


Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/UserAgentQuirks.cpp (284504 => 284505)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/UserAgentQuirks.cpp	2021-10-19 22:37:50 UTC (rev 284504)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/UserAgentQuirks.cpp	2021-10-19 22:37:56 UTC (rev 284505)
@@ -169,9 +169,9 @@
 switch (quirk) {
 case NeedsChromeBrowser:
 // Get versions from https://chromium.googlesource.com/chromium/src.git
-return "Chrome/90.0.4419.1"_s;
+return "Chrome/97.0.4669.2"_s;
 case NeedsFirefoxBrowser:
-return "; rv:87.0) Gecko/20100101 Firefox/87.0"_s;
+return "; rv:95.0) Gecko/20100101 Firefox/95.0"_s;
 case NeedsMacintoshPlatform:
 return "Macintosh; Intel Mac OS X 10_15"_s;
 case NeedsUnbrandedUserAgent:


Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/glib/UserAgentGLib.cpp (284504 => 284505)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/glib/UserAgentGLib.cpp	2021-10-19 22:37:50 UTC (rev 284504)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/glib/UserAgentGLib.cpp	2021-10-19 22:37:56 UTC (rev 284505)
@@ -104,7 +104,7 @@
 // Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
 // https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
 } else
-uaString.append("Version/14.0 ");
+uaString.append("Version/15.0 ");
 
 if (chassisType() == WTF::ChassisType::Mobile)
 uaString.append("Mobile ");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284504] releases/WebKitGTK/webkit-2.34/Source/WebCore

2021-10-19 Thread aperez
Title: [284504] releases/WebKitGTK/webkit-2.34/Source/WebCore








Revision 284504
Author ape...@igalia.com
Date 2021-10-19 15:37:50 -0700 (Tue, 19 Oct 2021)


Log Message
Merge r284091 - [GStreamer] Crash in WebCore::MediaPlayerPrivateGStreamer::sourceSetup when loading reddit video
https://bugs.webkit.org/show_bug.cgi?id=231519

Patch by Philippe Normand  on 2021-10-13
Reviewed by Xabier Rodriguez-Calvar.

Since this GStreamer commit:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/commit/52bca104e447309898ca8904b3914211ec7d4114

and starting from GStreamer 1.20, the playbin::source-setup signal is emitted before the
source element is added to the pipeline, so this gave us the opportunity to refactor our
code handling the downloadbuffer configuration, using the existing deep-element-added signal
handler.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamer::configureDownloadBuffer):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback): Deleted.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (284503 => 284504)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2021-10-19 22:37:43 UTC (rev 284503)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2021-10-19 22:37:50 UTC (rev 284504)
@@ -1,3 +1,26 @@
+2021-10-13  Philippe Normand  
+
+[GStreamer] Crash in WebCore::MediaPlayerPrivateGStreamer::sourceSetup when loading reddit video
+https://bugs.webkit.org/show_bug.cgi?id=231519
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Since this GStreamer commit:
+https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/commit/52bca104e447309898ca8904b3914211ec7d4114
+
+and starting from GStreamer 1.20, the playbin::source-setup signal is emitted before the
+source element is added to the pipeline, so this gave us the opportunity to refactor our
+code handling the downloadbuffer configuration, using the existing deep-element-added signal
+handler.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
+(WebCore::MediaPlayerPrivateGStreamer::sourceSetup):
+(WebCore::MediaPlayerPrivateGStreamer::configureDownloadBuffer):
+(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+(WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback): Deleted.
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+
 2021-09-15  Carlos Garcia Campos  
 
 Fix size calculation in ImageBufferCairoImageSurfaceBackend::create()


Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (284503 => 284504)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2021-10-19 22:37:43 UTC (rev 284503)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2021-10-19 22:37:50 UTC (rev 284504)
@@ -200,9 +200,6 @@
 if (m_fillTimer.isActive())
 m_fillTimer.stop();
 
-if (WEBKIT_IS_WEB_SRC(m_source.get()) && GST_OBJECT_PARENT(m_source.get()))
-g_signal_handlers_disconnect_by_func(GST_ELEMENT_PARENT(m_source.get()), reinterpret_cast(uriDecodeBinElementAddedCallback), this);
-
 auto* sink = audioSink();
 if (sink && !WEBKIT_IS_AUDIO_SINK(sink))
 g_signal_handlers_disconnect_by_func(G_OBJECT(sink), reinterpret_cast(setAudioStreamPropertiesCallback), this);
@@ -874,16 +871,10 @@
 {
 GST_DEBUG_OBJECT(pipeline(), "Source element set-up for %s", GST_ELEMENT_NAME(sourceElement));
 
-if (WEBKIT_IS_WEB_SRC(m_source.get()) && GST_OBJECT_PARENT(m_source.get()))
-g_signal_handlers_disconnect_by_func(GST_ELEMENT_PARENT(m_source.get()), reinterpret_cast(uriDecodeBinElementAddedCallback), this);
-
 m_source = sourceElement;
 
 if (WEBKIT_IS_WEB_SRC(m_source.get())) {
 webKitWebSrcSetMediaPlayer(WEBKIT_WEB_SRC_CAST(m_source.get()), m_player, m_referrer);
-g_signal_connect(GST_ELEMENT_PARENT(m_source.get()), "element-added", G_CALLBACK(uriDecodeBinElementAddedCallback), this);
-// This will set the multiqueue size to the default value.
-g_object_set(GST_ELEMENT_PARENT(m_source.get()), "buffer-size", 2 * MB, nullptr);
 #if 

[webkit-changes] [284503] releases/WebKitGTK/webkit-2.34/Source

2021-10-19 Thread aperez
Title: [284503] releases/WebKitGTK/webkit-2.34/Source








Revision 284503
Author ape...@igalia.com
Date 2021-10-19 15:37:43 -0700 (Tue, 19 Oct 2021)


Log Message
Merge r284132 - [GTK] Opening emoji chooser crashes UI process with GTK 3.24.30
https://bugs.webkit.org/show_bug.cgi?id=228664

Reviewed by Michael Catanzaro.

Instead of providing a copy of the emoji chooser widget, use GLib's
introspection features and a little sprinkle of knowledge about how
GTK works in order to obtain the type code of the GtkEmojiChooser
widget included with GTK. This ensures that a working widget is
always used, regardless of the current GTK version.

No new tests needed.

* UIProcess/API/gtk/WebKitEmojiChooser.cpp:
(webkitEmojiChooserNew):
(): Deleted.
(webkitEmojiChooserAddEmoji): Deleted.
(webkitEmojiChooserAddRecentItem): Deleted.
(emojiActivated): Deleted.
(emojiDataHasVariations): Deleted.
(webkitEmojiChooserShowVariations): Deleted.
(emojiLongPressed): Deleted.
(emojiPressed): Deleted.
(emojiPopupMenu): Deleted.
(verticalAdjustmentChanged): Deleted.
(webkitEmojiChooserSetupSectionBox): Deleted.
(scrollToSection): Deleted.
(webkitEmojiChooserSetupSectionButton): Deleted.
(webkitEmojiChooserSetupRecent): Deleted.
(webkitEmojiChooserEnsureEmptyResult): Deleted.
(webkitEmojiChooserSearchChanged): Deleted.
(webkitEmojiChooserSetupFilters): Deleted.
(webkitEmojiChooserSetupEmojiSections): Deleted.
(webkitEmojiChooserInitializeEmojiMaxWidth): Deleted.
(webkitEmojiChooserConstructed): Deleted.
(webkitEmojiChooserShow): Deleted.
(webkit_emoji_chooser_class_init): Deleted.
* UIProcess/API/gtk/WebKitEmojiChooser.h:

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/gtk/po/POTFILES.in
releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitEmojiChooser.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitEmojiChooser.h




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/gtk/po/POTFILES.in (284502 => 284503)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/gtk/po/POTFILES.in	2021-10-19 22:37:32 UTC (rev 284502)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/platform/gtk/po/POTFILES.in	2021-10-19 22:37:43 UTC (rev 284503)
@@ -33,7 +33,6 @@
 ../../../WebKit/UIProcess/API/glib/WebKitWindowProperties.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp
-../../../WebKit/UIProcess/API/gtk/WebKitEmojiChooser.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (284502 => 284503)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-19 22:37:32 UTC (rev 284502)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-19 22:37:43 UTC (rev 284503)
@@ -1,3 +1,44 @@
+2021-10-13  Adrian Perez de Castro  
+
+[GTK] Opening emoji chooser crashes UI process with GTK 3.24.30
+https://bugs.webkit.org/show_bug.cgi?id=228664
+
+Reviewed by Michael Catanzaro.
+
+Instead of providing a copy of the emoji chooser widget, use GLib's
+introspection features and a little sprinkle of knowledge about how
+GTK works in order to obtain the type code of the GtkEmojiChooser
+widget included with GTK. This ensures that a working widget is
+always used, regardless of the current GTK version.
+
+No new tests needed.
+
+* UIProcess/API/gtk/WebKitEmojiChooser.cpp:
+(webkitEmojiChooserNew):
+(): Deleted.
+(webkitEmojiChooserAddEmoji): Deleted.
+(webkitEmojiChooserAddRecentItem): Deleted.
+(emojiActivated): Deleted.
+(emojiDataHasVariations): Deleted.
+(webkitEmojiChooserShowVariations): Deleted.
+(emojiLongPressed): Deleted.
+(emojiPressed): Deleted.
+(emojiPopupMenu): Deleted.
+(verticalAdjustmentChanged): Deleted.
+(webkitEmojiChooserSetupSectionBox): Deleted.
+(scrollToSection): Deleted.
+(webkitEmojiChooserSetupSectionButton): Deleted.
+(webkitEmojiChooserSetupRecent): Deleted.
+(webkitEmojiChooserEnsureEmptyResult): Deleted.
+(webkitEmojiChooserSearchChanged): Deleted.
+(webkitEmojiChooserSetupFilters): Deleted.
+(webkitEmojiChooserSetupEmojiSections): Deleted.
+(webkitEmojiChooserInitializeEmojiMaxWidth): Deleted.
+(webkitEmojiChooserConstructed): Deleted.
+(webkitEmojiChooserShow): Deleted.
+(webkit_emoji_chooser_class_init): Deleted.
+* UIProcess/API/gtk/WebKitEmojiChooser.h:
+
 2021-10-19  Michael Catanzaro  
 
 Update seccomp filters with latest changes from flatpak


Modified: 

[webkit-changes] [284502] releases/WebKitGTK/webkit-2.34/Source/WebKit

2021-10-19 Thread aperez
Title: [284502] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 284502
Author ape...@igalia.com
Date 2021-10-19 15:37:32 -0700 (Tue, 19 Oct 2021)


Log Message
Merge r284451 - Update seccomp filters with latest changes from flatpak
https://bugs.webkit.org/show_bug.cgi?id=231479

Patch by Michael Catanzaro  on 2021-10-19
Reviewed by Adrian Perez de Castro.

Additionally, let's fix a minor inconsistency in our error-handling code: all but one of
our codepaths carefully free and close resources, but the process is about to crash so
there's not really any reason to do so. The code is slightly simpler if we don't bother.

The seemingly-extraneous include order changes are required to placate the style checker.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::seccompStrerror):
(WebKit::setupSeccomp):
* UIProcess/Launcher/glib/Syscalls.h: Added.

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp


Added Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/Syscalls.h




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (284501 => 284502)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-19 21:53:27 UTC (rev 284501)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-19 22:37:32 UTC (rev 284502)
@@ -1,3 +1,21 @@
+2021-10-19  Michael Catanzaro  
+
+Update seccomp filters with latest changes from flatpak
+https://bugs.webkit.org/show_bug.cgi?id=231479
+
+Reviewed by Adrian Perez de Castro.
+
+Additionally, let's fix a minor inconsistency in our error-handling code: all but one of
+our codepaths carefully free and close resources, but the process is about to crash so
+there's not really any reason to do so. The code is slightly simpler if we don't bother.
+
+The seemingly-extraneous include order changes are required to placate the style checker.
+
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+(WebKit::seccompStrerror):
+(WebKit::setupSeccomp):
+* UIProcess/Launcher/glib/Syscalls.h: Added.
+
 2021-10-19  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.0 release


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (284501 => 284502)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-10-19 21:53:27 UTC (rev 284501)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-10-19 22:37:32 UTC (rev 284502)
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -32,6 +33,12 @@
 #include 
 #include 
 
+#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
+#include 
+#endif
+
+#include "Syscalls.h"
+
 #if PLATFORM(GTK)
 #include "WaylandCompositor.h"
 #endif
@@ -42,14 +49,8 @@
 #define BASE_DIRECTORY "wpe"
 #endif
 
-#include 
+#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
 
-#ifndef MFD_ALLOW_SEALING
-
-#if HAVE(LINUX_MEMFD_H)
-
-#include 
-
 // These defines were added in glibc 2.27, the same release that added memfd_create.
 // But the kernel added all of this in Linux 3.17. So it's totally safe for us to
 // depend on, as long as we define it all ourselves. Remove this once we depend on
@@ -67,10 +68,8 @@
 {
 return syscall(__NR_memfd_create, name, flags);
 }
-#endif // #if HAVE(LINUX_MEMFD_H)
+#endif // #if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
 
-#endif // #ifndef MFD_ALLOW_SEALING
-
 namespace WebKit {
 using namespace WebCore;
 
@@ -600,6 +599,28 @@
 }
 }
 
+// Translate a libseccomp error code into an error message. libseccomp
+// mostly returns negative errno values such as -ENOMEM, but some
+// standard errno values are used for non-standard purposes where their
+// strerror() would be misleading.
+static const char* seccompStrerror(int negativeErrno)
+{
+RELEASE_ASSERT_WITH_MESSAGE(negativeErrno < 0, "Non-negative error value from libseccomp?");
+RELEASE_ASSERT_WITH_MESSAGE(negativeErrno > INT_MIN, "Out of range error value from libseccomp?");
+
+switch (negativeErrno) {
+case -EDOM:
+return "Architecture-specific failure";
+case -EFAULT:
+return "Internal libseccomp failure (unknown syscall?)";
+case -ECANCELED:
+return "System failure beyond the control of libseccomp";
+}
+
+// e.g. -ENOMEM: the result of strerror() is good enough
+return g_strerror(-negativeErrno);
+}
+
 static int setupSeccomp()
 {
 // NOTE: This is shared code (flatpak-run.c - LGPLv2.1+)
@@ -627,6 +648,10 @@
 //in common/flatpak-run.c
 //  https://git.gnome.org/browse/linux-user-chroot
 //in src/setup-seccomp.c
+//
+// Other useful resources:
+// 

[webkit-changes] [284501] trunk/Source/WTF

2021-10-19 Thread ysuzuki
Title: [284501] trunk/Source/WTF








Revision 284501
Author ysuz...@apple.com
Date 2021-10-19 14:53:27 -0700 (Tue, 19 Oct 2021)


Log Message
Remove old GCC workaround for Allocator
https://bugs.webkit.org/show_bug.cgi?id=231978

Reviewed by Darin Adler.

This is for old GCC. Since our GCC baseline is 8.3.0, this is no longer necessary.

* wtf/FastMalloc.h:
(WTF::FastAllocator::deallocate):
(WTF::FastAllocator::construct): Deleted.
(WTF::FastAllocator::destroy): Deleted.
(WTF::FastAllocator::max_size const): Deleted.
(WTF::FastAllocator::select_on_container_copy_construction const): Deleted.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.h




Diff

Modified: trunk/Source/WTF/ChangeLog (284500 => 284501)

--- trunk/Source/WTF/ChangeLog	2021-10-19 21:46:36 UTC (rev 284500)
+++ trunk/Source/WTF/ChangeLog	2021-10-19 21:53:27 UTC (rev 284501)
@@ -1,3 +1,19 @@
+2021-10-19  Yusuke Suzuki  
+
+Remove old GCC workaround for Allocator
+https://bugs.webkit.org/show_bug.cgi?id=231978
+
+Reviewed by Darin Adler.
+
+This is for old GCC. Since our GCC baseline is 8.3.0, this is no longer necessary.
+
+* wtf/FastMalloc.h:
+(WTF::FastAllocator::deallocate):
+(WTF::FastAllocator::construct): Deleted.
+(WTF::FastAllocator::destroy): Deleted.
+(WTF::FastAllocator::max_size const): Deleted.
+(WTF::FastAllocator::select_on_container_copy_construction const): Deleted.
+
 2021-10-18  Filip Pizlo  
 
 StringBuffer should really know that strings might be 8-bit


Modified: trunk/Source/WTF/wtf/FastMalloc.h (284500 => 284501)

--- trunk/Source/WTF/wtf/FastMalloc.h	2021-10-19 21:46:36 UTC (rev 284500)
+++ trunk/Source/WTF/wtf/FastMalloc.h	2021-10-19 21:53:27 UTC (rev 284501)
@@ -210,60 +210,6 @@
 {
 fastFree(pointer);
 }
-
-#if defined(__GLIBCXX__) && (!defined(_GLIBCXX_RELEASE) || _GLIBCXX_RELEASE < 6)
-// This allocator also supports pre-C++11 STL allocator interface. This is a workaround for GCC < 6, which std::list
-// does not support C++11 allocator. Note that _GLIBCXX_RELEASE is only defined after GCC 7 release. So currently
-// this workaround is enabled in GCC 6 too.
-// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55409
-
-using pointer = value_type*;
-using const_pointer = typename std::pointer_traits::template rebind;
-using void_pointer = typename std::pointer_traits::template rebind;
-using const_void_pointer = typename std::pointer_traits::template rebind;
-
-using reference = T&;
-using const_reference = const T&;
-
-using difference_type = typename std::pointer_traits::difference_type;
-using size_type = std::make_unsigned_t;
-
-template  struct rebind {
-using other = FastAllocator;
-};
-
-value_type* allocate(std::size_t count, const_void_pointer)
-{
-return allocate(count);
-}
-
-template 
-void construct(U* p, Args&& ...args)
-{
-new (const_cast(static_cast(p))) U(std::forward(args)...);
-}
-
-template 
-void destroy(U* p)
-{
-p->~U();
-}
-
-std::size_t max_size() const
-{
-return std::numeric_limits::max();
-}
-
-FastAllocator select_on_container_copy_construction() const
-{
-return *this;
-}
-
-using propagate_on_container_copy_assignment = std::false_type;
-using propagate_on_container_move_assignment = std::false_type;
-using propagate_on_container_swap = std::false_type;
-using is_always_equal = std::is_empty;
-#endif // defined(__GLIBCXX__) && (!defined(_GLIBCXX_RELEASE) || _GLIBCXX_RELEASE < 6)
 };
 
 template inline bool operator==(const FastAllocator&, const FastAllocator&) { return true; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284500] tags/Safari-613.1.5.2/

2021-10-19 Thread repstein
Title: [284500] tags/Safari-613.1.5.2/








Revision 284500
Author repst...@apple.com
Date 2021-10-19 14:46:36 -0700 (Tue, 19 Oct 2021)


Log Message
Tag Safari-613.1.5.2.

Added Paths

tags/Safari-613.1.5.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284499] branches/safari-613.1.6-branch

2021-10-19 Thread alancoon
Title: [284499] branches/safari-613.1.6-branch








Revision 284499
Author alanc...@apple.com
Date 2021-10-19 14:46:07 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r284490. rdar://problem/84434069

Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing
https://bugs.webkit.org/show_bug.cgi?id=231916

Reviewed by Antti Koivisto.
Source/WebCore:

In r284336 I made clip-path not apply to non-RenderBoxes, which disabled it on inlines,
breaking the system-preview/badge.html test.

The spec says it applies to all elements, so this behavior change was incorrect.

Revert back to using calculateLayerBounds() as the fallback rect to use for inlines, and add
tests for this. This rectangle is obviously incorrect (for example, it's affected by text
shadow), but leave it for now until https://github.com/w3c/csswg-drafts/issues/6383 is
resolved.

I also failed to see that computeClipPath() was already computing the reference box
internally, so clean up the code with some comments to make it more clear that the result of
calculateLayerBounds() is used only as the fallback for inlines, as well as for the buffer
bounds for the applyClippingToContext() code path.

Tests: css3/masking/clip-path-on-inline.html
   css3/masking/clip-path-on-split-inline.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeClipPath const):
(WebCore::RenderLayer::setupClipPath):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):

LayoutTests:

Tests for clip-path on a single-box inline, and a split inline.

* css3/masking/clip-path-on-inline-expected.html: Added.
* css3/masking/clip-path-on-inline.html: Added.
* css3/masking/clip-path-on-split-inline-expected.html: Added.
* css3/masking/clip-path-on-split-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.6-branch/LayoutTests/ChangeLog
branches/safari-613.1.6-branch/Source/WebCore/ChangeLog
branches/safari-613.1.6-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-613.1.6-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-613.1.6-branch/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

branches/safari-613.1.6-branch/LayoutTests/css3/masking/clip-path-on-inline-expected.html
branches/safari-613.1.6-branch/LayoutTests/css3/masking/clip-path-on-inline.html
branches/safari-613.1.6-branch/LayoutTests/css3/masking/clip-path-on-split-inline-expected.html
branches/safari-613.1.6-branch/LayoutTests/css3/masking/clip-path-on-split-inline.html




Diff

Modified: branches/safari-613.1.6-branch/LayoutTests/ChangeLog (284498 => 284499)

--- branches/safari-613.1.6-branch/LayoutTests/ChangeLog	2021-10-19 21:44:07 UTC (rev 284498)
+++ branches/safari-613.1.6-branch/LayoutTests/ChangeLog	2021-10-19 21:46:07 UTC (rev 284499)
@@ -1,5 +1,65 @@
 2021-10-19  Alan Coon  
 
+Cherry-pick r284490. rdar://problem/84434069
+
+Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing
+https://bugs.webkit.org/show_bug.cgi?id=231916
+
+Reviewed by Antti Koivisto.
+Source/WebCore:
+
+In r284336 I made clip-path not apply to non-RenderBoxes, which disabled it on inlines,
+breaking the system-preview/badge.html test.
+
+The spec says it applies to all elements, so this behavior change was incorrect.
+
+Revert back to using calculateLayerBounds() as the fallback rect to use for inlines, and add
+tests for this. This rectangle is obviously incorrect (for example, it's affected by text
+shadow), but leave it for now until https://github.com/w3c/csswg-drafts/issues/6383 is
+resolved.
+
+I also failed to see that computeClipPath() was already computing the reference box
+internally, so clean up the code with some comments to make it more clear that the result of
+calculateLayerBounds() is used only as the fallback for inlines, as well as for the buffer
+bounds for the applyClippingToContext() code path.
+
+Tests: css3/masking/clip-path-on-inline.html
+   css3/masking/clip-path-on-split-inline.html
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::computeClipPath const):
+(WebCore::RenderLayer::setupClipPath):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
+
+LayoutTests:
+
+Tests for clip-path on a single-box inline, and a split inline.
+
+* css3/masking/clip-path-on-inline-expected.html: Added.
+* css3/masking/clip-path-on-inline.html: Added.
+* css3/masking/clip-path-on-split-inline-expected.html: Added.
+* css3/masking/clip-path-on-split-inline.html: Added.
+
+git-svn-id: 

[webkit-changes] [284498] trunk/Tools

2021-10-19 Thread jbedard
Title: [284498] trunk/Tools








Revision 284498
Author jbed...@apple.com
Date 2021-10-19 14:44:07 -0700 (Tue, 19 Oct 2021)


Log Message
[webkitscmpy] Override http url with ssh url
https://bugs.webkit.org/show_bug.cgi?id=231965


Reviewed by Ryan Haddad.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): Exclude / from hostname.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Prompt user to switch to ssh checkout.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
Canonical link: https://commits.webkit.org/243250@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (284497 => 284498)

--- trunk/Tools/ChangeLog	2021-10-19 21:41:53 UTC (rev 284497)
+++ trunk/Tools/ChangeLog	2021-10-19 21:44:07 UTC (rev 284498)
@@ -1,3 +1,17 @@
+2021-10-19  Jonathan Bedard  
+
+[webkitscmpy] Override http url with ssh url
+https://bugs.webkit.org/show_bug.cgi?id=231965
+
+
+Reviewed by Ryan Haddad.
+
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git): Exclude / from hostname.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
+(Setup.git): Prompt user to switch to ssh checkout.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
+
 2021-10-19  Ryan Haddad  
 
 [EWS] Move EWS bots to iOS 15 / watchOS 8 / tvOS 15


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (284497 => 284498)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-10-19 21:41:53 UTC (rev 284497)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-10-19 21:44:07 UTC (rev 284498)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='2.2.14',
+version='2.2.15',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (284497 => 284498)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-10-19 21:41:53 UTC (rev 284497)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-10-19 21:44:07 UTC (rev 284498)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(2, 2, 14)
+version = Version(2, 2, 15)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (284497 => 284498)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py	2021-10-19 21:41:53 UTC (rev 284497)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py	2021-10-19 21:44:07 UTC (rev 284498)
@@ -275,7 +275,7 @@
 
 GIT_COMMIT = re.compile(r'commit (?P[0-9a-f]+)')
 SSH_REMOTE = re.compile('(ssh://)?git@(?P[^:/]+)[:/](?P.+).git')
-HTTP_REMOTE = re.compile('(?Phttps?)://(?P.+)/(?P.+).git')
+HTTP_REMOTE = re.compile(r'(?Phttps?)://(?P[^\/]+)/(?P.+).git')
 REMOTE_BRANCH = re.compile(r'remotes\/(?P[^\/]+)\/(?P.+)')
 
 @classmethod


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py (284497 => 284498)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py	2021-10-19 21:41:53 UTC (rev 284497)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py	2021-10-19 21:44:07 UTC (rev 284498)
@@ -131,7 +131,7 @@
 log.warning('Set better Objective-C diffing behavior!')
 
 if args.defaults or Terminal.choose(
-'Auto-color status, diff, and branch?'.format(email),
+'Auto-color status, diff, and branch?',
 default='Yes',
 ) == 'Yes':
 for command in ('status', 'diff', 'branch'):
@@ -187,6 +187,24 @@
 else:
 log.warning("Set git editor to '{}'".format(editor_name))
 
+# Pushing to http repositories is difficult, offer to change http checkouts to ssh
+http_remote = local.Git.HTTP_REMOTE.match(repository.url())
+if http_remote and not args.defaults and Terminal.choose(
+"http based remotes will prompt for your password when pushing,\nwould you like to convert to a ssh remote?",
+default='Yes',
+) == 'Yes':
+if run([
+local.Git.executable(), 'config', 'remote.origin.url',
+   

[webkit-changes] [284497] branches/safari-613.1.6-branch/Source/WebKit

2021-10-19 Thread alancoon
Title: [284497] branches/safari-613.1.6-branch/Source/WebKit








Revision 284497
Author alanc...@apple.com
Date 2021-10-19 14:41:53 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r284495. rdar://problem/84433820

Unreviewed, reverting r284099.
https://bugs.webkit.org/show_bug.cgi?id=231984

Introduced build failure

Reverted changeset:

"[iOS] Stop including 'util.sb' in the WebContent process'
sandbox"
https://bugs.webkit.org/show_bug.cgi?id=231570
https://commits.webkit.org/r284099

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.6-branch/Source/WebKit/ChangeLog
branches/safari-613.1.6-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in


Removed Paths

branches/safari-613.1.6-branch/Source/WebKit/Shared/Sandbox/util.sb




Diff

Modified: branches/safari-613.1.6-branch/Source/WebKit/ChangeLog (284496 => 284497)

--- branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-19 21:40:00 UTC (rev 284496)
+++ branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-19 21:41:53 UTC (rev 284497)
@@ -1,5 +1,37 @@
 2021-10-19  Alan Coon  
 
+Cherry-pick r284495. rdar://problem/84433820
+
+Unreviewed, reverting r284099.
+https://bugs.webkit.org/show_bug.cgi?id=231984
+
+Introduced build failure
+
+Reverted changeset:
+
+"[iOS] Stop including 'util.sb' in the WebContent process'
+sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=231570
+https://commits.webkit.org/r284099
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-19  Commit Queue  
+
+Unreviewed, reverting r284099.
+https://bugs.webkit.org/show_bug.cgi?id=231984
+
+Introduced build failure
+
+Reverted changeset:
+
+"[iOS] Stop including 'util.sb' in the WebContent process'
+sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=231570
+https://commits.webkit.org/r284099
+
+2021-10-19  Alan Coon  
+
 Cherry-pick r284483. rdar://problem/84428759
 
 LayoutTests/imported/w3c:


Modified: branches/safari-613.1.6-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (284496 => 284497)

--- branches/safari-613.1.6-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-10-19 21:40:00 UTC (rev 284496)
+++ branches/safari-613.1.6-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-10-19 21:41:53 UTC (rev 284497)
@@ -30,13 +30,13 @@
 ;; Silence spurious logging due to rdar://20117923 and rdar://72366475
 (deny system-privilege (privilege-id PRIV_GLOBAL_PROC_INFO) (with no-report))
 
-#include "Shared/Sandbox/util.sb"
-
 ;;;
 ;;; The following rules were originally contained in 'common.sb'. We are duplicating them here so we can
 ;;; remove unneeded sandbox extensions.
 ;;;
 
+(import "util.sb")
+
 (define-once (allow-read-and-issue-generic-extensions . filters)
 (allow file-read*
(apply require-any filters))


Deleted: branches/safari-613.1.6-branch/Source/WebKit/Shared/Sandbox/util.sb (284496 => 284497)

--- branches/safari-613.1.6-branch/Source/WebKit/Shared/Sandbox/util.sb	2021-10-19 21:40:00 UTC (rev 284496)
+++ branches/safari-613.1.6-branch/Source/WebKit/Shared/Sandbox/util.sb	2021-10-19 21:41:53 UTC (rev 284497)
@@ -1,94 +0,0 @@
-; Copyright (C) 2021 Apple Inc. All rights reserved.
-;
-; Redistribution and use in source and binary forms, with or without
-; modification, are permitted provided that the following conditions
-; are met:
-; 1. Redistributions of source code must retain the above copyright
-;notice, this list of conditions and the following disclaimer.
-; 2. Redistributions in binary form must reproduce the above copyright
-;notice, this list of conditions and the following disclaimer in the
-;documentation and/or other materials provided with the distribution.
-;
-; THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-; AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-; THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-; PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-; BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-; CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-; SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-; INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-; CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-; ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-; THE POSSIBILITY OF SUCH DAMAGE.
-
-(macro (define-once form)
-  (let* ((ps (cdr form))
- (signature (car 

[webkit-changes] [284496] branches/safari-613.1.5-branch/Source

2021-10-19 Thread repstein
Title: [284496] branches/safari-613.1.5-branch/Source








Revision 284496
Author repst...@apple.com
Date 2021-10-19 14:40:00 -0700 (Tue, 19 Oct 2021)


Log Message
Versioning.

WebKit-7613.1.5.2

Modified Paths

branches/safari-613.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.5-branch/Source/WebKit/Configurations/Version.xcconfig (284495 => 284496)

--- branches/safari-613.1.5-branch/Source/WebKit/Configurations/Version.xcconfig	2021-10-19 21:37:49 UTC (rev 284495)
+++ branches/safari-613.1.5-branch/Source/WebKit/Configurations/Version.xcconfig	2021-10-19 21:40:00 UTC (rev 284496)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [284495] trunk/Source/WebKit

2021-10-19 Thread commit-queue
Title: [284495] trunk/Source/WebKit








Revision 284495
Author commit-qu...@webkit.org
Date 2021-10-19 14:37:49 -0700 (Tue, 19 Oct 2021)


Log Message
Unreviewed, reverting r284099.
https://bugs.webkit.org/show_bug.cgi?id=231984

Introduced build failure

Reverted changeset:

"[iOS] Stop including 'util.sb' in the WebContent process'
sandbox"
https://bugs.webkit.org/show_bug.cgi?id=231570
https://commits.webkit.org/r284099

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in


Removed Paths

trunk/Source/WebKit/Shared/Sandbox/util.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (284494 => 284495)

--- trunk/Source/WebKit/ChangeLog	2021-10-19 21:10:39 UTC (rev 284494)
+++ trunk/Source/WebKit/ChangeLog	2021-10-19 21:37:49 UTC (rev 284495)
@@ -1,3 +1,17 @@
+2021-10-19  Commit Queue  
+
+Unreviewed, reverting r284099.
+https://bugs.webkit.org/show_bug.cgi?id=231984
+
+Introduced build failure
+
+Reverted changeset:
+
+"[iOS] Stop including 'util.sb' in the WebContent process'
+sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=231570
+https://commits.webkit.org/r284099
+
 2021-10-19  Garrett Davidson  
 
 WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (284494 => 284495)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-10-19 21:10:39 UTC (rev 284494)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-10-19 21:37:49 UTC (rev 284495)
@@ -30,13 +30,13 @@
 ;; Silence spurious logging due to rdar://20117923 and rdar://72366475
 (deny system-privilege (privilege-id PRIV_GLOBAL_PROC_INFO) (with no-report))
 
-#include "Shared/Sandbox/util.sb"
-
 ;;;
 ;;; The following rules were originally contained in 'common.sb'. We are duplicating them here so we can
 ;;; remove unneeded sandbox extensions.
 ;;;
 
+(import "util.sb")
+
 (define-once (allow-read-and-issue-generic-extensions . filters)
 (allow file-read*
(apply require-any filters))


Deleted: trunk/Source/WebKit/Shared/Sandbox/util.sb (284494 => 284495)

--- trunk/Source/WebKit/Shared/Sandbox/util.sb	2021-10-19 21:10:39 UTC (rev 284494)
+++ trunk/Source/WebKit/Shared/Sandbox/util.sb	2021-10-19 21:37:49 UTC (rev 284495)
@@ -1,94 +0,0 @@
-; Copyright (C) 2021 Apple Inc. All rights reserved.
-;
-; Redistribution and use in source and binary forms, with or without
-; modification, are permitted provided that the following conditions
-; are met:
-; 1. Redistributions of source code must retain the above copyright
-;notice, this list of conditions and the following disclaimer.
-; 2. Redistributions in binary form must reproduce the above copyright
-;notice, this list of conditions and the following disclaimer in the
-;documentation and/or other materials provided with the distribution.
-;
-; THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-; AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-; THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-; PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-; BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-; CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-; SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-; INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-; CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-; ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-; THE POSSIBILITY OF SUCH DAMAGE.
-
-(macro (define-once form)
-  (let* ((ps (cdr form))
- (signature (car ps))
- (body (cdr ps))
- (name (car signature)))
-(if (not (defined? name))
-`(define ,signature ,@body
-
-(define-once (home-literal . relative-subpaths)
-  (apply literal (map home-relative-path relative-subpaths)))
-
-(define-once (home-subpath . relative-subpaths)
-  (apply subpath (map home-relative-path relative-subpaths)))
-
-(define-once (home-prefix . relative-subpaths)
-  (apply prefix (map home-relative-path relative-subpaths)))
-
-(define-once (home-regex . relative-regexes)
-  (require-all
-(apply any-home-regex relative-regexes)
-(home-subpath "")))
-
-(define-once (home-relative-path relative-subpath)
-  (string-append "${HOME}" relative-subpath))
-
-(define-once (front-user-home-subpath . relative-subpaths)
-  (apply subpath (map front-user-home-relative-path relative-subpaths)))
-
-(define-once (front-user-home-relative-path relative-subpath)
-  (string-append "${FRONT_USER_HOME}" relative-subpath))
-
-(define-once (%elevated-precedence-finalize)
-(lambda () #f))
-
-(macro 

[webkit-changes] [284494] trunk/Source/WebCore/PAL

2021-10-19 Thread ddkilzer
Title: [284494] trunk/Source/WebCore/PAL








Revision 284494
Author ddkil...@apple.com
Date 2021-10-19 14:10:39 -0700 (Tue, 19 Oct 2021)


Log Message
REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header



Reviewed by Wenson Hsieh.

* PAL.xcodeproj/project.pbxproj:
- Change TCCSPI.h from a private header to a project header.
  PAL uses a build phase script to install its headers.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (284493 => 284494)

--- trunk/Source/WebCore/PAL/ChangeLog	2021-10-19 20:58:44 UTC (rev 284493)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-10-19 21:10:39 UTC (rev 284494)
@@ -1,3 +1,15 @@
+2021-10-19  David Kilzer  
+
+REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header
+
+
+
+Reviewed by Wenson Hsieh.
+
+* PAL.xcodeproj/project.pbxproj:
+- Change TCCSPI.h from a private header to a project header.
+  PAL uses a build phase script to install its headers.
+
 2021-10-18  David Kilzer  
 
 Bug 231882: WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t


Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (284493 => 284494)

--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2021-10-19 20:58:44 UTC (rev 284493)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2021-10-19 21:10:39 UTC (rev 284494)
@@ -140,7 +140,7 @@
 		4450FCA021F5F602004DFA56 /* QuickLookSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 4450FC9E21F5F602004DFA56 /* QuickLookSoftLink.h */; };
 		44E1A8AF21FA54E600C3048E /* LookupSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 44E1A8AD21FA54DA00C3048E /* LookupSoftLink.h */; };
 		44E1A8B021FA54EB00C3048E /* LookupSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 44E1A8AE21FA54DA00C3048E /* LookupSoftLink.mm */; };
-		4996C0F32717644C002C125D /* TCCSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 4996C0F22717642B002C125D /* TCCSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		4996C0F32717644C002C125D /* TCCSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 4996C0F22717642B002C125D /* TCCSPI.h */; };
 		517E03F924B7C0070054895A /* IOKitSPIMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 517E03F824B7C0060054895A /* IOKitSPIMac.h */; };
 		570AB8F120AE2E8D00B8BE87 /* SecKeyProxySPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F020AE2E8D00B8BE87 /* SecKeyProxySPI.h */; };
 		570AB8F920AF6E3D00B8BE87 /* NSXPCConnectionSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */; };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284493] trunk/LayoutTests

2021-10-19 Thread ayumi_kojima
Title: [284493] trunk/LayoutTests








Revision 284493
Author ayumi_koj...@apple.com
Date 2021-10-19 13:58:44 -0700 (Tue, 19 Oct 2021)


Log Message
Regression(r283935 - r283938): [ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=231918

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284492 => 284493)

--- trunk/LayoutTests/ChangeLog	2021-10-19 20:46:30 UTC (rev 284492)
+++ trunk/LayoutTests/ChangeLog	2021-10-19 20:58:44 UTC (rev 284493)
@@ -1,3 +1,12 @@
+2021-10-19  Ayumi Kojima  
+
+Regression(r283935 - r283938): [ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=231918
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-10-19  Simon Fraser  
 
 Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284492 => 284493)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-19 20:46:30 UTC (rev 284492)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-19 20:58:44 UTC (rev 284493)
@@ -767,7 +767,8 @@
 webkit.org/b/184456 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html [ Pass Failure ]
 
 webkit.org/b/231918 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times.html [ Pass Failure ]
-
+webkit.org/b/231918 imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus.html [ Pass Failure ]
+ 
 webkit.org/b/184569 [ Debug ] animations/missing-from-to.html [ Skip ]
 
 webkit.org/b/184458 media/remote-control-command-is-user-gesture.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284492] trunk/Tools

2021-10-19 Thread ryanhaddad
Title: [284492] trunk/Tools








Revision 284492
Author ryanhad...@apple.com
Date 2021-10-19 13:46:30 -0700 (Tue, 19 Oct 2021)


Log Message
[EWS] Move EWS bots to iOS 15 / watchOS 8 / tvOS 15
https://bugs.webkit.org/show_bug.cgi?id=231925

Reviewed by Jonathan Bedard.

* CISupport/ews-build/config.json:
* CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):

Modified Paths

trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/CISupport/ews-build/factories_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/config.json (284491 => 284492)

--- trunk/Tools/CISupport/ews-build/config.json	2021-10-19 20:36:29 UTC (rev 284491)
+++ trunk/Tools/CISupport/ews-build/config.json	2021-10-19 20:46:30 UTC (rev 284492)
@@ -42,12 +42,12 @@
 { "name": "ews118", "platform": "mac-catalina" },
 { "name": "ews119", "platform": "mac-catalina" },
 { "name": "ews120", "platform": "mac-catalina" },
-{ "name": "ews121", "platform": "ios-simulator-14" },
-{ "name": "ews122", "platform": "ios-simulator-14" },
-{ "name": "ews123", "platform": "ios-simulator-14" },
-{ "name": "ews124", "platform": "ios-simulator-14" },
-{ "name": "ews125", "platform": "ios-simulator-14" },
-{ "name": "ews126", "platform": "ios-simulator-14" },
+{ "name": "ews121", "platform": "ios-simulator-15" },
+{ "name": "ews122", "platform": "ios-simulator-15" },
+{ "name": "ews123", "platform": "ios-simulator-15" },
+{ "name": "ews124", "platform": "ios-simulator-15" },
+{ "name": "ews125", "platform": "ios-simulator-15" },
+{ "name": "ews126", "platform": "ios-simulator-15" },
 { "name": "ews127", "platform": "mac-catalina" },
 { "name": "ews128", "platform": "mac-catalina" },
 { "name": "ews150", "platform": "*" },
@@ -70,7 +70,7 @@
 { "name": "ews167", "platform": "*" },
 { "name": "ews168", "platform": "*" },
 { "name": "ews169", "platform": "mac-bigsur" },
-{ "name": "ews170", "platform": "tvos-simulator-14" },
+{ "name": "ews170", "platform": "tvos-simulator-15" },
 { "name": "ews171", "platform": "mac-bigsur" },
 { "name": "ews172", "platform": "mac-bigsur" },
 { "name": "ews173", "platform": "mac-bigsur" },
@@ -118,23 +118,23 @@
   "workernames": ["igalia5-gtk-wk2-ews", "igalia6-gtk-wk2-ews", "igalia7-gtk-wk2-ews", "igalia8-gtk-wk2-ews", "igalia9-gtk-wk2-ews"]
 },
 {
-  "name": "iOS-14-Build-EWS", "shortname": "ios", "icon": "buildOnly",
-  "factory": "iOSEmbeddedBuildFactory", "platform": "ios-14",
+  "name": "iOS-15-Build-EWS", "shortname": "ios", "icon": "buildOnly",
+  "factory": "iOSEmbeddedBuildFactory", "platform": "ios-15",
   "configuration": "release", "architectures": ["arm64"],
   "workernames": ["ews152", "ews154", "ews108", "ews109"]
 },
 {
-  "name": "iOS-14-Simulator-Build-EWS", "shortname": "ios-sim", "icon": "buildOnly",
-  "factory": "iOSBuildFactory", "platform": "ios-simulator-14",
+  "name": "iOS-15-Simulator-Build-EWS", "shortname": "ios-sim", "icon": "buildOnly",
+  "factory": "iOSBuildFactory", "platform": "ios-simulator-15",
   "configuration": "release", "architectures": ["x86_64"],
-  "triggers": ["api-tests-ios-sim-ews", "ios-14-sim-wk2-tests-ews"],
+  "triggers": ["api-tests-ios-sim-ews", "ios-15-sim-wk2-tests-ews"],
   "workernames": ["ews152", "ews154", "ews156", "ews157", "ews108", "ews109"]
 },
 {
-  "name": "iOS-14-Simulator-WK2-Tests-EWS", "shortname": "ios-wk2", "icon": "testOnly",
-  "factory": "iOSTestsFactory", "platform": "ios-simulator-14",
+  "name": "iOS-15-Simulator-WK2-Tests-EWS", "shortname": "ios-wk2", "icon": "testOnly",
+  "factory": "iOSTestsFactory", "platform": "ios-simulator-15",
   "configuration": "release", "architectures": ["x86_64"],
-  "triggered_by": ["ios-14-sim-build-ews"],
+  "triggered_by": ["ios-15-sim-build-ews"],
   "workernames": ["ews121", "ews122", "ews123", "ews124", "ews125", "ews126"]
 },
 {
@@ -194,26 +194,26 @@
   "workernames": ["ews112", "ews113", "ews115", "ews117"]
 },
 {
-  "name": "watchOS-7-Build-EWS", "shortname": "watch", "icon": "buildOnly",
-  "factory": "watchOSBuildFactory", "platform": "watchos-7",
+  "name": "watchOS-8-Build-EWS", "shortname": "watch", "icon": "buildOnly",
+  "factory": "watchOSBuildFactory", "platform": "watchos-8",
   "configuration": "release", "architectures": ["arm64_32", "armv7k"],
   "workernames": ["ews163", "ews164", "ews165"]
 },
 {
-  "name": "watchOS-7-Simulator-Build-EWS", "shortname": "watch-sim", "icon": "buildOnly",
-  "factory": "watchOSBuildFactory", "platform": "watchos-simulator-7",
+  "name": "watchOS-8-Simulator-Build-EWS", "shortname": "watch-sim", "icon": "buildOnly",
+  "factory": "watchOSBuildFactory", "platform": "watchos-simulator-8",
   "configuration": "release", 

[webkit-changes] [284491] trunk/Tools

2021-10-19 Thread jbedard
Title: [284491] trunk/Tools








Revision 284491
Author jbed...@apple.com
Date 2021-10-19 13:36:29 -0700 (Tue, 19 Oct 2021)


Log Message
[webkitscmpy] Generate commit message template (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=231023


Unreviewed follow-up fix.

* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: MarkupSafe is imported as markupsafe.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py




Diff

Modified: trunk/Tools/ChangeLog (284490 => 284491)

--- trunk/Tools/ChangeLog	2021-10-19 20:34:23 UTC (rev 284490)
+++ trunk/Tools/ChangeLog	2021-10-19 20:36:29 UTC (rev 284491)
@@ -1,3 +1,13 @@
+2021-10-19  Jonathan Bedard  
+
+[webkitscmpy] Generate commit message template (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=231023
+
+
+Unreviewed follow-up fix.
+
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: MarkupSafe is imported as markupsafe.
+
 2021-10-14  Jonathan Bedard  
 
 [webkitscmpy] Generate commit message template


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (284490 => 284491)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-10-19 20:34:23 UTC (rev 284490)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-10-19 20:36:29 UTC (rev 284491)
@@ -53,7 +53,7 @@
 AutoInstall.register(Package('monotonic', Version(1, 5)))
 AutoInstall.register(Package('whichcraft', Version(0, 6, 1)))
 AutoInstall.register(Package('xmltodict', Version(0, 11, 0)))
-AutoInstall.register(Package('MarkupSafe', Version(1, 1, 1)))
+AutoInstall.register(Package('markupsafe', Version(1, 1, 1), pypi_name='MarkupSafe'))
 
 if sys.version_info < (3, 0):
 AutoInstall.register(Package('inspect2', Version(0, 1, 2)))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284490] trunk

2021-10-19 Thread simon . fraser
Title: [284490] trunk








Revision 284490
Author simon.fra...@apple.com
Date 2021-10-19 13:34:23 -0700 (Tue, 19 Oct 2021)


Log Message
Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing
https://bugs.webkit.org/show_bug.cgi?id=231916

Reviewed by Antti Koivisto.
Source/WebCore:

In r284336 I made clip-path not apply to non-RenderBoxes, which disabled it on inlines,
breaking the system-preview/badge.html test.

The spec says it applies to all elements, so this behavior change was incorrect.

Revert back to using calculateLayerBounds() as the fallback rect to use for inlines, and add
tests for this. This rectangle is obviously incorrect (for example, it's affected by text
shadow), but leave it for now until https://github.com/w3c/csswg-drafts/issues/6383 is
resolved.

I also failed to see that computeClipPath() was already computing the reference box
internally, so clean up the code with some comments to make it more clear that the result of
calculateLayerBounds() is used only as the fallback for inlines, as well as for the buffer
bounds for the applyClippingToContext() code path.

Tests: css3/masking/clip-path-on-inline.html
   css3/masking/clip-path-on-split-inline.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeClipPath const):
(WebCore::RenderLayer::setupClipPath):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):

LayoutTests:

Tests for clip-path on a single-box inline, and a split inline.

* css3/masking/clip-path-on-inline-expected.html: Added.
* css3/masking/clip-path-on-inline.html: Added.
* css3/masking/clip-path-on-split-inline-expected.html: Added.
* css3/masking/clip-path-on-split-inline.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

trunk/LayoutTests/css3/masking/clip-path-on-inline-expected.html
trunk/LayoutTests/css3/masking/clip-path-on-inline.html
trunk/LayoutTests/css3/masking/clip-path-on-split-inline-expected.html
trunk/LayoutTests/css3/masking/clip-path-on-split-inline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (284489 => 284490)

--- trunk/LayoutTests/ChangeLog	2021-10-19 20:32:40 UTC (rev 284489)
+++ trunk/LayoutTests/ChangeLog	2021-10-19 20:34:23 UTC (rev 284490)
@@ -1,3 +1,17 @@
+2021-10-19  Simon Fraser  
+
+Regression(r284336): [ iOS 15 ] system-preview/badge.html is image failing
+https://bugs.webkit.org/show_bug.cgi?id=231916
+
+Reviewed by Antti Koivisto.
+
+Tests for clip-path on a single-box inline, and a split inline.
+
+* css3/masking/clip-path-on-inline-expected.html: Added.
+* css3/masking/clip-path-on-inline.html: Added.
+* css3/masking/clip-path-on-split-inline-expected.html: Added.
+* css3/masking/clip-path-on-split-inline.html: Added.
+
 2021-10-19  Chris Dumez  
 
 Resync web-platform-tests/reporting from upstream


Added: trunk/LayoutTests/css3/masking/clip-path-on-inline-expected.html (0 => 284490)

--- trunk/LayoutTests/css3/masking/clip-path-on-inline-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/masking/clip-path-on-inline-expected.html	2021-10-19 20:34:23 UTC (rev 284490)
@@ -0,0 +1,22 @@
+
+
+
+
+.container {
+font-family: ahem;
+font-size: 100px;
+overflow: hidden;
+height: calc(1em - 20px);
+}
+span {
+color: transparent;
+background-color: green;
+}
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/css3/masking/clip-path-on-inline.html (0 => 284490)

--- trunk/LayoutTests/css3/masking/clip-path-on-inline.html	(rev 0)
+++ trunk/LayoutTests/css3/masking/clip-path-on-inline.html	2021-10-19 20:34:23 UTC (rev 284490)
@@ -0,0 +1,23 @@
+
+
+
+
+.container {
+font-family: ahem;
+font-size: 100px;
+overflow: hidden;
+height: 1em;
+}
+span {
+color: transparent;
+background-color: green;
+clip-path: inset(0 0 20px 0);
+}
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/css3/masking/clip-path-on-split-inline-expected.html (0 => 284490)

--- trunk/LayoutTests/css3/masking/clip-path-on-split-inline-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/masking/clip-path-on-split-inline-expected.html	2021-10-19 20:34:23 UTC (rev 284490)
@@ -0,0 +1,24 @@
+
+
+
+
+.container {
+font-family: ahem;
+font-size: 100px;
+width: 400px;
+overflow: hidden;
+height: 160px;
+margin-top: 28px;
+}
+span {
+color: transparent;
+background-color: green;
+}
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/css3/masking/clip-path-on-split-inline.html (0 => 284490)


[webkit-changes] [284489] trunk/Source/WebKit

2021-10-19 Thread commit-queue
Title: [284489] trunk/Source/WebKit








Revision 284489
Author commit-qu...@webkit.org
Date 2021-10-19 13:32:40 -0700 (Tue, 19 Oct 2021)


Log Message
WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread
https://bugs.webkit.org/show_bug.cgi?id=231963


Patch by Garrett Davidson  on 2021-10-19
Reviewed by Brent Fulgham.

- The clearanceHandler is not guaranteed to happen on the main thread, but
weakThis.get() needs to happen there.

- `proxy` needs to stay alive for the whole transaction, otherwise it will tear
down the connection and cancel the request, so explicitly capture it everywhere.

- Start logging if we get an error from clearanceHandler.

Covered by existing tests.

* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (284488 => 284489)

--- trunk/Source/WebKit/ChangeLog	2021-10-19 20:15:32 UTC (rev 284488)
+++ trunk/Source/WebKit/ChangeLog	2021-10-19 20:32:40 UTC (rev 284489)
@@ -1,3 +1,24 @@
+2021-10-19  Garrett Davidson  
+
+WebAuthn Platform UI callbacks are not guaranteed to happen on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=231963
+
+
+Reviewed by Brent Fulgham.
+
+- The clearanceHandler is not guaranteed to happen on the main thread, but
+weakThis.get() needs to happen there.
+
+- `proxy` needs to stay alive for the whole transaction, otherwise it will tear
+down the connection and cancel the request, so explicitly capture it everywhere.
+
+- Start logging if we get an error from clearanceHandler.
+
+Covered by existing tests.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
+
 2021-10-19  Wenson Hsieh  
 
 REGRESSION (r284079): fast/canvas/gradient-with-clip.html and fast/canvas/gradient-text-with-shadow.html are flaky failures


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (284488 => 284489)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-10-19 20:15:32 UTC (rev 284488)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-10-19 20:32:40 UTC (rev 284489)
@@ -264,75 +264,74 @@
 auto proxy = adoptNS([allocASCAgentProxyInstance() init]);
 
 RetainPtr window = m_webPageProxy.platformWindow();
-[proxy performAuthorizationRequestsForContext:requestContext.get() withClearanceHandler:makeBlockPtr([weakThis = WeakPtr { *this }, handler = WTFMove(handler), window = WTFMove(window)](NSXPCListenerEndpoint *daemonEnpoint, NSError *error) mutable {
-auto protectedThis = weakThis.get();
-
-if (!protectedThis || !daemonEnpoint) {
-RunLoop::main().dispatch([handler = WTFMove(handler)]() mutable {
+[proxy performAuthorizationRequestsForContext:requestContext.get() withClearanceHandler:makeBlockPtr([weakThis = WeakPtr { *this }, handler = WTFMove(handler), window = WTFMove(window), proxy = WTFMove(proxy)](NSXPCListenerEndpoint *daemonEndpoint, NSError *error) mutable {
+callOnMainRunLoop([weakThis, handler = WTFMove(handler), window = WTFMove(window), proxy = WTFMove(proxy), daemonEndpoint = retainPtr(daemonEndpoint), error = retainPtr(error)] () mutable {
+if (!weakThis || !daemonEndpoint) {
+LOG_ERROR("Could not connect to authorization daemon: %@\n", error.get());
 handler({ }, (AuthenticatorAttachment)0, ExceptionData { NotAllowedError, "Operation failed." });
-});
-return;
-}
+return;
+}
 
-protectedThis->m_presenter = adoptNS([allocASCAuthorizationRemotePresenterInstance() init]);
-[protectedThis->m_presenter presentWithWindow:window.get() daemonEndpoint:daemonEnpoint completionHandler:makeBlockPtr([handler = WTFMove(handler)](id  credential, NSError *error) mutable {
-AuthenticatorResponseData response = { };
-AuthenticatorAttachment attachment;
-ExceptionData exceptionData = { };
+weakThis->m_presenter = adoptNS([allocASCAuthorizationRemotePresenterInstance() init]);
+[weakThis->m_presenter presentWithWindow:window.get() daemonEndpoint:daemonEndpoint.get() completionHandler:makeBlockPtr([handler = WTFMove(handler), proxy = WTFMove(proxy)](id  credential, NSError *error) mutable {
+AuthenticatorResponseData response = { };
+AuthenticatorAttachment attachment;
+ExceptionData exceptionData = { };
 
-if ([credential 

[webkit-changes] [284488] tags/Safari-612.2.9.1.22/

2021-10-19 Thread alancoon
Title: [284488] tags/Safari-612.2.9.1.22/








Revision 284488
Author alanc...@apple.com
Date 2021-10-19 13:15:32 -0700 (Tue, 19 Oct 2021)


Log Message
Tag Safari-612.2.9.1.22.

Added Paths

tags/Safari-612.2.9.1.22/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [284487] branches/safari-612.2.9.1-branch/Source/WebKit

2021-10-19 Thread alancoon
Title: [284487] branches/safari-612.2.9.1-branch/Source/WebKit








Revision 284487
Author alanc...@apple.com
Date 2021-10-19 13:11:38 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r283430. rdar://problem/84428809

Use DYLD_FRAMEWORK_PATH instead of DYLD_VERSIONED_FRAMEWORK_PATH on Safari Big Sur
https://bugs.webkit.org/show_bug.cgi?id=231058

Patch by Remy Demarest  on 2021-10-01
Reviewed by David Kilzer.

Modify the DYLD environment variable that is used when compiling with staged frameworks.
We want to use DYLD_VERSIONED_FRAMEWORK_PATH to define the search path of the frameworks
for DYLD because this makes launching Safari and its child processes faster. However,
on Apple Silicon Big Sur using that environment variable does not work and results in Safari
loading frameworks from the System folder rather than from the StagedFrameworks/Safari
folder, this is because dyld on M1 does not look up that variable properly. To make sure
we actually load the frameworks from the desired location, we need to use DYLD_FRAMEWORK_PATH
instead, this makes dyld perform more stat() calls than usual to link the frameworks hence
why we prefer the other variable, but this is the only way to workaround the issue in
Big Sur on M1. In Monterey and above, this bug will be fixed in dyld so we only need this
variable before macOS 11.

Override OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES based on SDK and architecture to use
DYLD_FRAMEWORK_PATH instead of DYLD_VERSIONED_FRAMEWORK_PATH when building for macOS 11 and arm64.

* Configurations/BaseTarget.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog
branches/safari-612.2.9.1-branch/Source/WebKit/Configurations/BaseTarget.xcconfig




Diff

Modified: branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog (284486 => 284487)

--- branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog	2021-10-19 20:08:13 UTC (rev 284486)
+++ branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog	2021-10-19 20:11:38 UTC (rev 284487)
@@ -1,3 +1,56 @@
+2021-10-19  Alan Coon  
+
+Cherry-pick r283430. rdar://problem/84428809
+
+Use DYLD_FRAMEWORK_PATH instead of DYLD_VERSIONED_FRAMEWORK_PATH on Safari Big Sur
+https://bugs.webkit.org/show_bug.cgi?id=231058
+
+Patch by Remy Demarest  on 2021-10-01
+Reviewed by David Kilzer.
+
+Modify the DYLD environment variable that is used when compiling with staged frameworks.
+We want to use DYLD_VERSIONED_FRAMEWORK_PATH to define the search path of the frameworks
+for DYLD because this makes launching Safari and its child processes faster. However,
+on Apple Silicon Big Sur using that environment variable does not work and results in Safari
+loading frameworks from the System folder rather than from the StagedFrameworks/Safari
+folder, this is because dyld on M1 does not look up that variable properly. To make sure
+we actually load the frameworks from the desired location, we need to use DYLD_FRAMEWORK_PATH
+instead, this makes dyld perform more stat() calls than usual to link the frameworks hence
+why we prefer the other variable, but this is the only way to workaround the issue in
+Big Sur on M1. In Monterey and above, this bug will be fixed in dyld so we only need this
+variable before macOS 11.
+
+Override OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES based on SDK and architecture to use
+DYLD_FRAMEWORK_PATH instead of DYLD_VERSIONED_FRAMEWORK_PATH when building for macOS 11 and arm64.
+
+* Configurations/BaseTarget.xcconfig:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-01  Remy Demarest  
+
+Use DYLD_FRAMEWORK_PATH instead of DYLD_VERSIONED_FRAMEWORK_PATH on Safari Big Sur
+https://bugs.webkit.org/show_bug.cgi?id=231058
+
+Reviewed by David Kilzer.
+
+Modify the DYLD environment variable that is used when compiling with staged frameworks.
+We want to use DYLD_VERSIONED_FRAMEWORK_PATH to define the search path of the frameworks
+for DYLD because this makes launching Safari and its child processes faster. However,
+on Apple Silicon Big Sur using that environment variable does not work and results in Safari
+loading frameworks from the System folder rather than from the StagedFrameworks/Safari
+folder, this is because dyld on M1 does not look up that variable properly. To make sure
+we actually load the frameworks from the desired location, we need to use DYLD_FRAMEWORK_PATH
+instead, this makes dyld perform more stat() calls than usual to link the frameworks hence
+why we prefer the other variable, but this is the only way to 

[webkit-changes] [284486] branches/safari-612.2.9.1-branch/Source

2021-10-19 Thread alancoon
Title: [284486] branches/safari-612.2.9.1-branch/Source








Revision 284486
Author alanc...@apple.com
Date 2021-10-19 13:08:13 -0700 (Tue, 19 Oct 2021)


Log Message
Versioning.

WebKit-7612.2.9.1.22

Modified Paths

branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (284485 => 284486)

--- branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-10-19 20:07:43 UTC (rev 284485)
+++ branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-10-19 20:08:13 UTC (rev 284486)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = 

[webkit-changes] [284485] trunk/Tools

2021-10-19 Thread jbedard
Title: [284485] trunk/Tools








Revision 284485
Author jbed...@apple.com
Date 2021-10-19 13:07:43 -0700 (Tue, 19 Oct 2021)


Log Message
[webkitscmpy] Generate commit message template
https://bugs.webkit.org/show_bug.cgi?id=231023


Reviewed by Dewei Zhu.

* Tools/Scripts/git-webkit: Use prepare-ChangeLog to generate commit messages.
* Tools/Scripts/hooks/prepare-commit-msg: Added.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version, add jinja.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git.__init__): Add unbound status mock.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
(main): Pass hooks to sub-programs.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): iterate through the directory of provided hooks and render with jinja2.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg: Added.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
(TestSetup.test_commit_message):
Canonical link: https://commits.webkit.org/243242@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/git-webkit
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py


Added Paths

trunk/Tools/Scripts/hooks/
trunk/Tools/Scripts/hooks/prepare-commit-msg
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg




Diff

Modified: trunk/Tools/ChangeLog (284484 => 284485)

--- trunk/Tools/ChangeLog	2021-10-19 20:05:16 UTC (rev 284484)
+++ trunk/Tools/ChangeLog	2021-10-19 20:07:43 UTC (rev 284485)
@@ -1,3 +1,25 @@
+2021-10-14  Jonathan Bedard  
+
+[webkitscmpy] Generate commit message template
+https://bugs.webkit.org/show_bug.cgi?id=231023
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/git-webkit: Use prepare-ChangeLog to generate commit messages.
+* Scripts/hooks/prepare-commit-msg: Added.
+* Scripts/libraries/webkitscmpy/setup.py: Bump version, add jinja.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
+(Git.__init__): Add unbound status mock.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
+(main): Pass hooks to sub-programs.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
+(Setup.git): iterate through the directory of provided hooks and render with jinja2.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg: Added.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
+(TestSetup.test_commit_message):
+
 2021-10-19  Jonathan Bedard  
 
 [webkitscmpy] Filter approvers by status


Modified: trunk/Tools/Scripts/git-webkit (284484 => 284485)

--- trunk/Tools/Scripts/git-webkit	2021-10-19 20:05:16 UTC (rev 284484)
+++ trunk/Tools/Scripts/git-webkit	2021-10-19 20:07:43 UTC (rev 284485)
@@ -71,5 +71,6 @@
 identifier_template=is_webkit_filter('Canonical link: https://commits.webkit.org/{}'),
 subversion=is_webkit_filter('https://svn.webkit.org/repository/webkit'),
 additional_setup=is_webkit_filter(additional_setup),
+hooks=os.path.join(os.path.abspath(os.path.join(os.path.dirname(__file__))), 'hooks'),
 ))
 


Added: trunk/Tools/Scripts/hooks/prepare-commit-msg (0 => 284485)

--- trunk/Tools/Scripts/hooks/prepare-commit-msg	(rev 0)
+++ trunk/Tools/Scripts/hooks/prepare-commit-msg	2021-10-19 20:07:43 UTC (rev 284485)
@@ -0,0 +1,76 @@
+#!/usr/bin/env {{ python }}
+
+import os
+import subprocess
+import sys
+
+LOCATION = '{{ location }}'
+SPACING = 8
+SCRIPTS = os.path.dirname(os.path.dirname(LOCATION))
+
+
+def message(source=None, sha=None):
+dirname = None
+commit_message = []
+
+try:
+for line in subprocess.check_output(
+[os.path.join(SCRIPTS, 'prepare-ChangeLog'), '--no-write', '--only-files', '--delimiters'],
+**(dict(encoding='utf-8') if sys.version_info > (3, 0) else dict())
+).splitlines():
+if line == '~':
+dirname = None
+continue
+if line.startswith(' ' * SPACING):
+if dirname:
+line = line.replace('* ', '* {}/'.format(dirname))
+commit_message.append(line[SPACING:])
+continue
+if line.endswith(':'):
+dirname = 

[webkit-changes] [284484] branches/safari-613.1.6-branch

2021-10-19 Thread repstein
Title: [284484] branches/safari-613.1.6-branch








Revision 284484
Author repst...@apple.com
Date 2021-10-19 13:05:16 -0700 (Tue, 19 Oct 2021)


Log Message
Cherry-pick r284483. rdar://problem/84428759

LayoutTests/imported/w3c:
Origin of opaque blob: URLs ends up as empty string
https://bugs.webkit.org/show_bug.cgi?id=231942

Patch by Alex Christensen  on 2021-10-19
Reviewed by Tim Horton.

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-origin-expected.txt:
* web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/resources/urltestdata.json:
* web-platform-tests/url/url-constructor.any-expected.txt:
* web-platform-tests/url/url-constructor.any.worker-expected.txt:
* web-platform-tests/url/url-origin.any-expected.txt:
* web-platform-tests/url/url-origin.any.worker-expected.txt:

Source/WebCore:
Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext()



Patch by David Kilzer  on 2021-10-19
Reviewed by Wenson Hsieh.

* platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:
(WebCore::FilterEffectRendererCoreImage::sharedCIContext):
- Use adoptCF() to fix the leak.

Source/WebKit:
REGRESSION (r284079): fast/canvas/gradient-with-clip.html and fast/canvas/gradient-text-with-shadow.html are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=231681
rdar://84202478

Patch by Wenson Hsieh  on 2021-10-19
Reviewed by Kimmo Kinnunen.

These tests occasionally fail when we time out while waiting for the pixel buffer to be populated underneath
`RemoteImageBufferProxy::getPixelBuffer`; this happens because the GPU process sometimes halts (and never
resumes) while processing stream messages, and consequently never ends up processing the GetPixelBuffer IPC
stream message that's necessary to populate the shared memory buffer for GetPixelBuffer.

This, in turn, happens when the IPC stream buffer is about to exhaust all available capacity (i.e. the write
cursor is nearing the end of the 2MB buffer), and as a result, we send messages that would normally be encoded
in the IPC stream as out-of-line IPC messages instead, which are received in the GPU process on the IPC thread
and appended to the receive queue corresponding to the destination ID in `Connection::processIncomingMessage()`.

If we happen to have sent `RemoteRenderingBackend::CreateImageBuffer(a)` right before exhausting capacity and
sending out-of-line messages targeting the RemoteDisplayListRecorder corresponding to the newly created image
buffer `a`, we'll end up with a race condition where the IPC thread may receive the out-of-line messages meant
for the new remote display list destination *before* the new remote display list has added itself as an IPC
receive queue by calling into `StreamServerConnection::startReceivingMessages()`.

In this particular scenario (where we "lose" the race), `Connection::processIncomingMessage` will skip past the
early return where it would normally find its corresponding receive queue via `m_receiveQueues.get(*message)`,
and instead falls through to `Connection::SyncMessageState::processIncomingMessage()`, which will attempt to
dispatch the incoming message to the Connection's client (GPUConnectionToWebProcess). Of course, the
GPUConnectionToWebProcess isn't aware of how to process this incoming message, so it simply gets dropped. By the
time the receive queue is added for the new RemoteDisplayListRecorder, we'll observe a ProcessOutOfStreamMessage
and end up waiting forever for this out-of-line message to be added to the receive queue, but this never ends up
happening because it has already been received and dropped by GPUConnectionToWebProcess.

To address the flaky tests in the short term, we work around this issue by making `CreateImageBuffer` a sync
message, so we guarantee that any subsequent messages sent to the image buffer's RemoteDisplayListRecorder will
not be dropped. In the (slightly) longer term, we should turn this back into an async stream message, and add a
mechanism to redirect all receiver-less RemoteDisplayListRecorder messages to a separate queue.

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::createImageBuffer):
* GPUProcess/graphics/RemoteRenderingBackend.h:
* GPUProcess/graphics/RemoteRenderingBackend.messages.in:

Make `CreateImageBuffer` a synchronous stream message for now.

* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):

LayoutTests:
Resync web-platform-tests/reporting from upstream
https://bugs.webkit.org/show_bug.cgi?id=231957

Reviewed by Alex Christensen.

Resync 

[webkit-changes] [284483] trunk

2021-10-19 Thread cdumez
Title: [284483] trunk








Revision 284483
Author cdu...@apple.com
Date 2021-10-19 13:00:44 -0700 (Tue, 19 Oct 2021)


Log Message
LayoutTests/imported/w3c:
Origin of opaque blob: URLs ends up as empty string
https://bugs.webkit.org/show_bug.cgi?id=231942

Patch by Alex Christensen  on 2021-10-19
Reviewed by Tim Horton.

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-origin-expected.txt:
* web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/resources/urltestdata.json:
* web-platform-tests/url/url-constructor.any-expected.txt:
* web-platform-tests/url/url-constructor.any.worker-expected.txt:
* web-platform-tests/url/url-origin.any-expected.txt:
* web-platform-tests/url/url-origin.any.worker-expected.txt:

Source/WebCore:
Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext()



Patch by David Kilzer  on 2021-10-19
Reviewed by Wenson Hsieh.

* platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:
(WebCore::FilterEffectRendererCoreImage::sharedCIContext):
- Use adoptCF() to fix the leak.

Source/WebKit:
REGRESSION (r284079): fast/canvas/gradient-with-clip.html and fast/canvas/gradient-text-with-shadow.html are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=231681
rdar://84202478

Patch by Wenson Hsieh  on 2021-10-19
Reviewed by Kimmo Kinnunen.

These tests occasionally fail when we time out while waiting for the pixel buffer to be populated underneath
`RemoteImageBufferProxy::getPixelBuffer`; this happens because the GPU process sometimes halts (and never
resumes) while processing stream messages, and consequently never ends up processing the GetPixelBuffer IPC
stream message that's necessary to populate the shared memory buffer for GetPixelBuffer.

This, in turn, happens when the IPC stream buffer is about to exhaust all available capacity (i.e. the write
cursor is nearing the end of the 2MB buffer), and as a result, we send messages that would normally be encoded
in the IPC stream as out-of-line IPC messages instead, which are received in the GPU process on the IPC thread
and appended to the receive queue corresponding to the destination ID in `Connection::processIncomingMessage()`.

If we happen to have sent `RemoteRenderingBackend::CreateImageBuffer(a)` right before exhausting capacity and
sending out-of-line messages targeting the RemoteDisplayListRecorder corresponding to the newly created image
buffer `a`, we'll end up with a race condition where the IPC thread may receive the out-of-line messages meant
for the new remote display list destination *before* the new remote display list has added itself as an IPC
receive queue by calling into `StreamServerConnection::startReceivingMessages()`.

In this particular scenario (where we "lose" the race), `Connection::processIncomingMessage` will skip past the
early return where it would normally find its corresponding receive queue via `m_receiveQueues.get(*message)`,
and instead falls through to `Connection::SyncMessageState::processIncomingMessage()`, which will attempt to
dispatch the incoming message to the Connection's client (GPUConnectionToWebProcess). Of course, the
GPUConnectionToWebProcess isn't aware of how to process this incoming message, so it simply gets dropped. By the
time the receive queue is added for the new RemoteDisplayListRecorder, we'll observe a ProcessOutOfStreamMessage
and end up waiting forever for this out-of-line message to be added to the receive queue, but this never ends up
happening because it has already been received and dropped by GPUConnectionToWebProcess.

To address the flaky tests in the short term, we work around this issue by making `CreateImageBuffer` a sync
message, so we guarantee that any subsequent messages sent to the image buffer's RemoteDisplayListRecorder will
not be dropped. In the (slightly) longer term, we should turn this back into an async stream message, and add a
mechanism to redirect all receiver-less RemoteDisplayListRecorder messages to a separate queue.

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::createImageBuffer):
* GPUProcess/graphics/RemoteRenderingBackend.h:
* GPUProcess/graphics/RemoteRenderingBackend.messages.in:

Make `CreateImageBuffer` a synchronous stream message for now.

* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):

LayoutTests:
Resync web-platform-tests/reporting from upstream
https://bugs.webkit.org/show_bug.cgi?id=231957

Reviewed by Alex Christensen.

Resync web-platform-tests/reporting from upstream 207e223d74fdc1f1.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations

[webkit-changes] [284482] branches/safari-612-branch

2021-10-19 Thread repstein
Title: [284482] branches/safari-612-branch








Revision 284482
Author repst...@apple.com
Date 2021-10-19 12:59:30 -0700 (Tue, 19 Oct 2021)


Log Message
Revert r283931. rdar://problem/83953710

Modified Paths

branches/safari-612-branch/LayoutTests/ChangeLog
branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt
branches/safari-612-branch/LayoutTests/platform/gtk/TestExpectations
branches/safari-612-branch/LayoutTests/platform/wpe/TestExpectations
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/workers/service/server/SWServer.cpp
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
branches/safari-612-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
branches/safari-612-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
branches/safari-612-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm


Added Paths

branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt
branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py
branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-expected.txt
branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.py


Removed Paths

branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction-expected.txt
branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction.py
branches/safari-612-branch/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt




Diff

Modified: branches/safari-612-branch/LayoutTests/ChangeLog (284481 => 284482)

--- branches/safari-612-branch/LayoutTests/ChangeLog	2021-10-19 19:56:12 UTC (rev 284481)
+++ branches/safari-612-branch/LayoutTests/ChangeLog	2021-10-19 19:59:30 UTC (rev 284482)
@@ -1,3 +1,7 @@
+2021-10-19  Russell Epstein  
+
+Revert r283931. rdar://problem/83953710
+
 2021-10-18  Russell Epstein  
 
 Cherry-pick r284230. rdar://problem/84351866


Copied: branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt (from rev 284431, branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction-expected.txt) (0 => 284482)

--- branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt	(rev 0)
+++ branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt	2021-10-19 19:59:30 UTC (rev 284482)
@@ -0,0 +1,12 @@
+Tests that the session is not switched upon top frame navigation to a prevalent resource without user interaction.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Should have and has the session cookie.
+PASS Should have and has the persistent cookie.
+PASS Origin has no isolated session.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py (from rev 284431, branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction.py) (0 => 284482)

--- branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py	(rev 0)
+++ branches/safari-612-branch/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py	2021-10-19 19:59:30 UTC (rev 284482)
@@ -0,0 +1,117 @@
+#!/usr/bin/env python3
+
+import sys
+
+sys.stdout.write(
+'Cache-Control: no-store\r\n'
+'Content-Type: text/html\r\n\r\n'
+)
+
+print('''
+
+
+
+
+
+