[webkit-changes] [292762] trunk
Title: [292762] trunk
Revision 292762
Author z...@falconsigh.net
Date 2022-04-11 22:59:08 -0700 (Mon, 11 Apr 2022)
Log Message
Unreviewed, removing one of my email addresses.
* metadata/contributors.json:
Modified Paths
trunk/ChangeLog
trunk/metadata/contributors.json
Diff
Modified: trunk/ChangeLog (292761 => 292762)
--- trunk/ChangeLog 2022-04-12 05:47:27 UTC (rev 292761)
+++ trunk/ChangeLog 2022-04-12 05:59:08 UTC (rev 292762)
@@ -1,3 +1,9 @@
+2022-04-11 Zan Dobersek
+
+Unreviewed, removing one of my email addresses.
+
+* metadata/contributors.json:
+
2022-04-09 Adrian Perez de Castro
[GTK][WPE] Missing inter-module documentation links
Modified: trunk/metadata/contributors.json (292761 => 292762)
--- trunk/metadata/contributors.json 2022-04-12 05:47:27 UTC (rev 292761)
+++ trunk/metadata/contributors.json 2022-04-12 05:59:08 UTC (rev 292762)
@@ -7160,8 +7160,7 @@
{
"emails" : [
"zdober...@igalia.com",
- "z...@falconsigh.net",
- "zandober...@gmail.com"
+ "z...@falconsigh.net"
],
"github" : "zdobersek",
"name" : "\u017dan Dober\u0161ek",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292761] trunk/Source/WebKit
Title: [292761] trunk/Source/WebKit
Revision 292761
Author dp...@igalia.com
Date 2022-04-11 22:47:27 -0700 (Mon, 11 Apr 2022)
Log Message
[GLIB] Unreviewed, build fix for Debian Stable after r292251
https://bugs.webkit.org/show_bug.cgi?id=239102
* UIProcess/gtk/WaylandCompositor.cpp:
(WebKit::WaylandCompositor::initializeEGL): Convert char* to String.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292760 => 292761)
--- trunk/Source/WebKit/ChangeLog 2022-04-12 04:57:41 UTC (rev 292760)
+++ trunk/Source/WebKit/ChangeLog 2022-04-12 05:47:27 UTC (rev 292761)
@@ -1,3 +1,11 @@
+2022-04-11 Diego Pino Garcia
+
+[GLIB] Unreviewed, build fix for Debian Stable after r292251
+https://bugs.webkit.org/show_bug.cgi?id=239102
+
+* UIProcess/gtk/WaylandCompositor.cpp:
+(WebKit::WaylandCompositor::initializeEGL): Convert char* to String.
+
2022-04-11 Wenson Hsieh
REGRESSION: Web content process crashes when triggering Live Text in recoveryOS
Modified: trunk/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp (292760 => 292761)
--- trunk/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp 2022-04-12 04:57:41 UTC (rev 292760)
+++ trunk/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp 2022-04-12 05:47:27 UTC (rev 292761)
@@ -432,7 +432,7 @@
#else
std::unique_ptr glExtensions = makeUnique(nullptr, GLContext::current()->version() >= 320);
#endif
-if (glExtensions->supports("GL_OES_EGL_image") || glExtensions->supports("GL_OES_EGL_image_external"))
+if (glExtensions->supports("GL_OES_EGL_image"_s) || glExtensions->supports("GL_OES_EGL_image_external"_s))
glImageTargetTexture2D = reinterpret_cast(eglGetProcAddress("glEGLImageTargetTexture2DOES"));
if (!glImageTargetTexture2D) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292760] trunk/Source/WebGPU
Title: [292760] trunk/Source/WebGPU
Revision 292760
Author mmaxfi...@apple.com
Date 2022-04-11 21:57:41 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Fix the tvOS build (again)
https://bugs.webkit.org/show_bug.cgi?id=239106
Unreviewed.
Turns out PLATFORM(APPLETV) and PLATFORM(TVOS) are different things.
* WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
(WebGPU::Texture::createView):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Texture.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292759 => 292760)
--- trunk/Source/WebGPU/ChangeLog 2022-04-12 03:43:50 UTC (rev 292759)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-12 04:57:41 UTC (rev 292760)
@@ -1,5 +1,19 @@
2022-04-11 Myles C. Maxfield
+[WebGPU] Fix the tvOS build (again)
+https://bugs.webkit.org/show_bug.cgi?id=239106
+
+
+Unreviewed.
+
+Turns out PLATFORM(APPLETV) and PLATFORM(TVOS) are different things.
+
+* WebGPU/Texture.mm:
+(WebGPU::Device::createTexture):
+(WebGPU::Texture::createView):
+
+2022-04-11 Myles C. Maxfield
+
[WebGPU] Use checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=239058
Modified: trunk/Source/WebGPU/WebGPU/Texture.mm (292759 => 292760)
--- trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 03:43:50 UTC (rev 292759)
+++ trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 04:57:41 UTC (rev 292760)
@@ -2009,7 +2009,7 @@
if (descriptor.size.depthOrArrayLayers > 1) {
textureDescriptor.arrayLength = descriptor.size.depthOrArrayLayers;
if (descriptor.sampleCount > 1) {
-#if PLATFORM(WATCHOS) || PLATFORM(TVOS)
+#if PLATFORM(WATCHOS) || PLATFORM(APPLETV)
return Texture::createInvalid(*this);
#else
textureDescriptor.textureType = MTLTextureType2DMultisampleArray;
@@ -2313,7 +2313,7 @@
break;
case WGPUTextureViewDimension_2DArray:
if (m_descriptor.sampleCount > 1) {
-#if PLATFORM(WATCHOS) || PLATFORM(TVOS)
+#if PLATFORM(WATCHOS) || PLATFORM(APPLETV)
return TextureView::createInvalid(m_device);
#else
textureType = MTLTextureType2DMultisampleArray;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292759] trunk
Title: [292759] trunk Revision 292759 Author an...@apple.com Date 2022-04-11 20:43:50 -0700 (Mon, 11 Apr 2022) Log Message [CSS Container Queries] Update container shorthand order https://bugs.webkit.org/show_bug.cgi?id=239065 Reviewed by Alan Bujtas. LayoutTests/imported/w3c: Update from WPT repo. * resources/resource-files.json: * web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt: * web-platform-tests/css/css-contain/container-queries/at-container-parsing.html: * web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-computed.html: * web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-name-parsing.html: * web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-parsing.html: * web-platform-tests/css/css-contain/container-queries/container-selection.html: * web-platform-tests/css/css-contain/container-queries/container-type-parsing.html: * web-platform-tests/css/css-contain/container-queries/crashtests/canvas-as-container-crash.html: * web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-000-crash.html: * web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-001-crash.html: * web-platform-tests/css/css-contain/container-queries/crashtests/chrome-quotes-crash.html: Added. * web-platform-tests/css/css-contain/container-queries/crashtests/force-sibling-style-crash.html: Added. * web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log: Source/WebCore: The format is now 'name / type' instead of 'type / name'. https://drafts.csswg.org/css-contain-3/#container-shorthand * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/StyleProperties.cpp: (WebCore::isNoneValue): (WebCore::isValueID): (WebCore::StyleProperties::getPropertyValue const): Also make "foo / none" serialize as "foo". * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContainerName): (WebCore::CSSPropertyParser::consumeContainerShorthand): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/resource-files.json trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-selection.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/canvas-as-container-crash.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-000-crash.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-001-crash.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-quotes-crash.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/force-sibling-style-crash.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292758 => 292759) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-12 03:34:04 UTC (rev 292758) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-12 03:43:50 UTC (rev 292759) @@ -1,3 +1,30 @@ +2022-04-11 Antti Koivisto + +
[webkit-changes] [292758] trunk/Source/ThirdParty/libwebrtc
Title: [292758] trunk/Source/ThirdParty/libwebrtc
Revision 292758
Author msab...@apple.com
Date 2022-04-11 20:34:04 -0700 (Mon, 11 Apr 2022)
Log Message
REGRESSION (r292411): libwebrtc header files aren't installed in system content path
https://bugs.webkit.org/show_bug.cgi?id=239100
Reviewed by Mark Lam.
Restored System Content Path processing for absl and webrtc header files.
* Configurations/libabsl.xcconfig:
* Configurations/libwebrtc.xcconfig:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (292757 => 292758)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2022-04-12 03:00:18 UTC (rev 292757)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2022-04-12 03:34:04 UTC (rev 292758)
@@ -1,3 +1,15 @@
+2022-04-11 Michael Saboff
+
+REGRESSION (r292411): libwebrtc header files aren't installed in system content path
+https://bugs.webkit.org/show_bug.cgi?id=239100
+
+Reviewed by Mark Lam.
+
+Restored System Content Path processing for absl and webrtc header files.
+
+* Configurations/libabsl.xcconfig:
+* Configurations/libwebrtc.xcconfig:
+
2022-04-08 Elliott Williams
[Xcode] Avoid targeting 32-bit iOS and Mac architectures
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig (292757 => 292758)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig 2022-04-12 03:00:18 UTC (rev 292757)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig 2022-04-12 03:34:04 UTC (rev 292758)
@@ -23,7 +23,10 @@
PRODUCT_NAME = absl;
+INSTALL_PATH_PREFIX = $(INSTALL_PATH_PREFIX_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH));
+INSTALL_PATH_PREFIX_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH);
+
APPLY_RULES_IN_COPY_HEADERS = $(WK_USE_NEW_BUILD_SYSTEM);
PUBLIC_HEADERS_FOLDER_PATH = $(PUBLIC_HEADERS_FOLDER_PATH_$(WK_WHICH_BUILD_SYSTEM));
-PUBLIC_HEADERS_FOLDER_PATH_not_legacy = /usr/local/include/absl;
+PUBLIC_HEADERS_FOLDER_PATH_not_legacy = $(INSTALL_PATH_PREFIX)/usr/local/include/absl;
PUBLIC_HEADERS_FOLDER_PATH_legacy = /usr/local/include/absl_flattened;
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (292757 => 292758)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2022-04-12 03:00:18 UTC (rev 292757)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2022-04-12 03:34:04 UTC (rev 292758)
@@ -70,7 +70,7 @@
APPLY_RULES_IN_COPY_HEADERS = $(WK_USE_NEW_BUILD_SYSTEM);
PUBLIC_HEADERS_FOLDER_PATH = $(PUBLIC_HEADERS_FOLDER_PATH_$(WK_WHICH_BUILD_SYSTEM));
-PUBLIC_HEADERS_FOLDER_PATH_not_legacy = ${PUBLIC_HEADERS_FOLDER_PREFIX}/webrtc;
+PUBLIC_HEADERS_FOLDER_PATH_not_legacy = ${INSTALL_PUBLIC_HEADER_PREFIX}/webrtc;
PUBLIC_HEADERS_FOLDER_PATH_legacy = ${PUBLIC_HEADERS_FOLDER_PREFIX}/webrtc_flattened;
USE_HEADERMAP = NO;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292757] trunk/Source
Title: [292757] trunk/Source
Revision 292757
Author mmaxfi...@apple.com
Date 2022-04-11 20:00:18 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Use checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=239058
Reviewed by Kimmo Kinnunen.
We have a bunch of places where overflow can occur.
Luckily, we can just detect overflow inside the validation functions, and not have
to do any inside the code that creates platform types (NSUInteger, etc.). This is
because if the validation code succeeds, then we are guaranteed that the cast to
NSUIntegers will succeed. This is because ranges in a resource are checked against
the size of the resource, and the size of the resource has been checked against
platform maximums, which are guaranteed to be smaller than the largest NSUInteger.
* WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* WebGPU/Buffer.mm:
(WebGPU::Buffer::validateGetMappedRange const):
(WebGPU::Buffer::getMappedRange):
(WebGPU::Buffer::validateMapAsync const):
(WebGPU::Buffer::mapAsync):
* WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::validateCopyBufferToBuffer):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::CommandEncoder::validateClearBuffer):
(WebGPU::CommandEncoder::clearBuffer):
* WebGPU/Queue.mm:
(WebGPU::Queue::validateWriteBuffer const):
(WebGPU::Queue::writeTexture):
* WebGPU/Texture.h:
* WebGPU/Texture.mm:
(WebGPU::Texture::resolveTextureViewDescriptorDefaults const):
(WebGPU::Texture::validateCreateView const):
(WebGPU::Texture::createView):
(WebGPU::Texture::validateTextureCopyRange):
(WebGPU::Texture::validateLinearTextureData):
Modified Paths
trunk/Source/WTF/wtf/CheckedArithmetic.h
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/BindGroup.mm
trunk/Source/WebGPU/WebGPU/Buffer.mm
trunk/Source/WebGPU/WebGPU/CommandEncoder.mm
trunk/Source/WebGPU/WebGPU/Queue.mm
trunk/Source/WebGPU/WebGPU/Texture.h
trunk/Source/WebGPU/WebGPU/Texture.mm
Diff
Modified: trunk/Source/WTF/wtf/CheckedArithmetic.h (292756 => 292757)
--- trunk/Source/WTF/wtf/CheckedArithmetic.h 2022-04-12 01:58:28 UTC (rev 292756)
+++ trunk/Source/WTF/wtf/CheckedArithmetic.h 2022-04-12 03:00:18 UTC (rev 292757)
@@ -1000,6 +1000,12 @@
return Checked(value) + checkedSum(args...);
}
+template
+Checked checkedDifference(U left, V right)
+{
+return Checked(left) - Checked(right);
+}
+
// Sometimes, you just want to check if some math would overflow - the code to do the math is
// already in place, and you want to guard it.
@@ -1010,7 +1016,7 @@
template bool differenceOverflows(U left, U right)
{
-return (Checked(left) - Checked(right)).hasOverflowed();
+return checkedDifference(left, right).hasOverflowed();
}
template
@@ -1056,6 +1062,8 @@
using WTF::CrashOnOverflow;
using WTF::RecordOverflow;
using WTF::checkedSum;
+using WTF::checkedDifference;
+using WTF::checkedProduct;
using WTF::differenceOverflows;
using WTF::isInBounds;
using WTF::productOverflows;
Modified: trunk/Source/WebGPU/ChangeLog (292756 => 292757)
--- trunk/Source/WebGPU/ChangeLog 2022-04-12 01:58:28 UTC (rev 292756)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-12 03:00:18 UTC (rev 292757)
@@ -1,5 +1,46 @@
2022-04-11 Myles C. Maxfield
+[WebGPU] Use checked arithmetic
+https://bugs.webkit.org/show_bug.cgi?id=239058
+
+Reviewed by Kimmo Kinnunen.
+
+We have a bunch of places where overflow can occur.
+
+Luckily, we can just detect overflow inside the validation functions, and not have
+to do any inside the code that creates platform types (NSUInteger, etc.). This is
+because if the validation code succeeds, then we are guaranteed that the cast to
+NSUIntegers will succeed. This is because ranges in a resource are checked against
+the size of the resource, and the size of the resource has been checked against
+platform maximums, which are guaranteed to be smaller than the largest NSUInteger.
+
+* WebGPU/BindGroup.mm:
+(WebGPU::Device::createBindGroup):
+* WebGPU/Buffer.mm:
+(WebGPU::Buffer::validateGetMappedRange const):
+(WebGPU::Buffer::getMappedRange):
+(WebGPU::Buffer::validateMapAsync const):
+(WebGPU::Buffer::mapAsync):
+* WebGPU/CommandEncoder.mm:
+(WebGPU::CommandEncoder::validateCopyBufferToBuffer):
+(WebGPU::CommandEncoder::copyBufferToTexture):
+(WebGPU::CommandEncoder::copyTextureToBuffer):
+(WebGPU::CommandEncoder::copyTextureToTexture):
+(WebGPU::CommandEncoder::validateClearBuffer):
+(WebGPU::CommandEncoder::clearBuffer):
+* WebGPU/Queue.mm:
+(WebGPU::Queue::validateWriteBuffer const):
+(WebGPU::Queue::writeTexture):
+* WebGPU/Texture.h:
+* WebGPU/Texture.mm:
+(WebGPU::Texture::resolveTextureViewDescriptorDefaults const):
+
[webkit-changes] [292756] trunk/Source/WebKit
Title: [292756] trunk/Source/WebKit
Revision 292756
Author wenson_hs...@apple.com
Date 2022-04-11 18:58:28 -0700 (Mon, 11 Apr 2022)
Log Message
REGRESSION: Web content process crashes when triggering Live Text in recoveryOS
https://bugs.webkit.org/show_bug.cgi?id=239096
rdar://91592943
Reviewed by Tim Horton.
Make encoding or decoding `RetainPtr` a no-op when the VisionKitCore framework is unavailable
on Cocoa platforms, rather than crashing (due to `PAL::getVKCImageAnalysisClass()` returning nil).
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder>::encode):
(IPC::ArgumentCoder>::decode):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292755 => 292756)
--- trunk/Source/WebKit/ChangeLog 2022-04-12 01:38:37 UTC (rev 292755)
+++ trunk/Source/WebKit/ChangeLog 2022-04-12 01:58:28 UTC (rev 292756)
@@ -1,3 +1,18 @@
+2022-04-11 Wenson Hsieh
+
+REGRESSION: Web content process crashes when triggering Live Text in recoveryOS
+https://bugs.webkit.org/show_bug.cgi?id=239096
+rdar://91592943
+
+Reviewed by Tim Horton.
+
+Make encoding or decoding `RetainPtr` a no-op when the VisionKitCore framework is unavailable
+on Cocoa platforms, rather than crashing (due to `PAL::getVKCImageAnalysisClass()` returning nil).
+
+* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
+(IPC::ArgumentCoder>::encode):
+(IPC::ArgumentCoder>::decode):
+
2022-04-11 Myles C. Maxfield
[WebGPU] Hook up device.queue to the IDL
Modified: trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm (292755 => 292756)
--- trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm 2022-04-12 01:38:37 UTC (rev 292755)
+++ trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm 2022-04-12 01:58:28 UTC (rev 292756)
@@ -736,11 +736,17 @@
void ArgumentCoder>::encode(Encoder& encoder, const RetainPtr& data)
{
+if (!PAL::isVisionKitCoreFrameworkAvailable())
+return;
+
encoder << data.get();
}
std::optional> ArgumentCoder>::decode(Decoder& decoder)
{
+if (!PAL::isVisionKitCoreFrameworkAvailable())
+return nil;
+
return IPC::decode(decoder, @[ PAL::getVKCImageAnalysisClass() ]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292755] trunk/Tools
Title: [292755] trunk/Tools Revision 292755 Author jbed...@apple.com Date 2022-04-11 18:38:37 -0700 (Mon, 11 Apr 2022) Log Message [Merge-Queue] Build before landing https://bugs.webkit.org/show_bug.cgi?id=239068 Reviewed by Ryan Haddad. * Tools/CISupport/ews-build/factories.py: (MergeQueueFactory.__init__): Build WebKit before landing. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Canonical link: https://commits.webkit.org/249539@main Modified Paths trunk/Tools/CISupport/ews-build/factories.py trunk/Tools/CISupport/ews-build/factories_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/ews-build/factories.py (292754 => 292755) --- trunk/Tools/CISupport/ews-build/factories.py 2022-04-12 01:34:15 UTC (rev 292754) +++ trunk/Tools/CISupport/ews-build/factories.py 2022-04-12 01:38:37 UTC (rev 292755) @@ -344,6 +344,10 @@ def __init__(self, platform, **kwargs): super(MergeQueueFactory, self).__init__(platform, **kwargs) +self.addStep(KillOldProcesses()) +self.addStep(CompileWebKit(skipUpload=True)) +self.addStep(KillOldProcesses()) + self.addStep(ValidateChange(verifyMergeQueue=True, verifyNoDraftForMergeQueue=True)) self.addStep(Canonicalize()) self.addStep(PushCommitToWebKitRepo()) Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (292754 => 292755) --- trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-12 01:34:15 UTC (rev 292754) +++ trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-12 01:38:37 UTC (rev 292755) @@ -645,6 +645,9 @@ 'add-reviewer-to-changelog', 'validate-commit-message', 'validate-changelog-and-reviewer', +'kill-old-processes', +'compile-webkit', +'kill-old-processes', 'validate-change', 'canonicalize-commit', 'push-commit-to-webkit-repo', Modified: trunk/Tools/ChangeLog (292754 => 292755) --- trunk/Tools/ChangeLog 2022-04-12 01:34:15 UTC (rev 292754) +++ trunk/Tools/ChangeLog 2022-04-12 01:38:37 UTC (rev 292755) @@ -1,3 +1,16 @@ +2022-04-11 Jonathan Bedard + +[Merge-Queue] Build before landing +https://bugs.webkit.org/show_bug.cgi?id=239068 + + +Reviewed by Ryan Haddad. + +* CISupport/ews-build/factories.py: +(MergeQueueFactory.__init__): Build WebKit before landing. +* CISupport/ews-build/factories_unittest.py: +(TestExpectedBuildSteps): + 2022-04-11 Chris Dumez REGRESSION:(r292696) lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292754] trunk
Title: [292754] trunk Revision 292754 Author pan...@apple.com Date 2022-04-11 18:34:15 -0700 (Mon, 11 Apr 2022) Log Message Web Inspector: preserve DOM.NodeId if a node is removed and re-added https://bugs.webkit.org/show_bug.cgi?id=189687 Reviewed by Devin Rousso. Source/WebCore: Instead of unbinding and rebinding nodes upon removal/reinsertion to the DOM tree, we should only perform the unbinding actions on a `Node` that is being destroyed. This resolves an issue where console messages with DOM nodes would behave unexpectedly because the node for a visible console message could have its children removed in `DOMManager.prototype._unbind`, even though the node would still have its children when it is removed from the DOM tree (unless it is being destroyed, which is handled by `DOMManager.prototype.willDestroyDOMNode`). While not a cause of an issue here, it is worth noting (due to confusion it caused me while investigating) that even after we stopped keeping `RefPtr` for nodes in r278785 the nodes themselves continued to be kept alive as part of the `RemoteObject` mechanism because the inspector injected script holds on to nodes until the `RemoteObject` is released. * inspector/agents/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::nodeLayoutContextTypeChanged): * inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::bind): (WebCore::InspectorDOMAgent::didCommitLoad): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::pseudoElementDestroyed): (WebCore::InspectorDOMAgent::unbind): Deleted. - We should no longer be unbinding and rebinding nodes on insertion/removal, since nodes should keep the same ID for their lifetime, and we will clean up the binding upon the Node's destruction. (WebCore::InspectorDOMAgent::willDestroyDOMNode): (WebCore::InspectorDOMAgent::destroyedNodesTimerFired): - A Node in middle of being destroyed will no longer have a parent. * inspector/agents/InspectorDOMAgent.h: Source/WebInspectorUI: Instead of unbinding and rebinding nodes upon removal/reinsertion to the DOM tree, we should only perform the unbinding actions on a `Node` that is being destroyed. * UserInterface/Controllers/DOMDebuggerManager.js: * UserInterface/Controllers/DOMManager.js: (WI.DOMManager.prototype._pseudoElementAdded): (WI.DOMManager.prototype.willDestroyDOMNode): (WI.DOMManager.prototype._unbind): - To match the backend, we should only unbind nodes when they are destroyed, not removed. * UserInterface/Models/DOMNode.js: (WI.DOMNode.prototype.newOrExistingFromPayload): - Reuse an existing orphaned DOMNode if it already exists. In the future, we want to stop sending entire node payloads to the frontend in those situations. (WI.DOMNode.prototype._insertChild): (WI.DOMNode.prototype._setChildrenPayload): LayoutTests: Update test to reflect that DOM breakpoints are now able to be reattached to their original node upon insertion following removal. * inspector/dom-debugger/dom-breakpoint-node-removed-ancestor.html: * inspector/dom-debugger/dom-breakpoint-node-removed-ancestor-expected.txt: * inspector/dom-debugger/dom-breakpoint-node-removed-direct-expected.txt: * inspector/dom-debugger/resources/dom-breakpoint-utilities.js: (TestPage.registerInitializer.InspectorTest.DOMBreakpoint.createBreakpoint): - Add an event handler to log the setting of the domNode for breakpoints. In order to prevent spurious output when removing breakpoints, instrument the removal of breakpoints to remove the testing event handler before the node is changed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/dom-debugger/dom-breakpoint-node-removed-ancestor-expected.txt trunk/LayoutTests/inspector/dom-debugger/dom-breakpoint-node-removed-ancestor.html trunk/LayoutTests/inspector/dom-debugger/dom-breakpoint-node-removed-direct-expected.txt trunk/LayoutTests/inspector/dom-debugger/resources/dom-breakpoint-utilities.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js Diff Modified: trunk/LayoutTests/ChangeLog (292753 => 292754) --- trunk/LayoutTests/ChangeLog 2022-04-12 01:32:43 UTC (rev 292753) +++ trunk/LayoutTests/ChangeLog 2022-04-12 01:34:15 UTC (rev 292754) @@ -1,3 +1,23 @@ +2022-04-11 Patrick Angle + +Web Inspector: preserve DOM.NodeId if a node is removed and re-added +https://bugs.webkit.org/show_bug.cgi?id=189687 + +Reviewed by Devin Rousso. + +Update test to reflect that DOM breakpoints are now able to be reattached to
[webkit-changes] [292753] trunk/Source
Title: [292753] trunk/Source
Revision 292753
Author don.olmst...@sony.com
Date 2022-04-11 18:32:43 -0700 (Mon, 11 Apr 2022)
Log Message
Fix PlayStation build after r292696
https://bugs.webkit.org/show_bug.cgi?id=239098
Unreviewed build fix.
Source/WebDriver:
* playstation/WebDriverServicePlayStation.cpp:
(WebDriver::WebDriverService::platformCapabilities):
Source/WTF:
* wtf/playstation/LanguagePlayStation.cpp:
(WTF::platformUserPreferredLanguages):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/playstation/LanguagePlayStation.cpp
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/playstation/WebDriverServicePlayStation.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (292752 => 292753)
--- trunk/Source/WTF/ChangeLog 2022-04-12 01:30:11 UTC (rev 292752)
+++ trunk/Source/WTF/ChangeLog 2022-04-12 01:32:43 UTC (rev 292753)
@@ -1,3 +1,13 @@
+2022-04-11 Don Olmstead
+
+Fix PlayStation build after r292696
+https://bugs.webkit.org/show_bug.cgi?id=239098
+
+Unreviewed build fix.
+
+* wtf/playstation/LanguagePlayStation.cpp:
+(WTF::platformUserPreferredLanguages):
+
2022-04-11 Yusuke Suzuki
[JSC] Reduce use of unnecessary cryptographicallyRandom numbers
Modified: trunk/Source/WTF/wtf/playstation/LanguagePlayStation.cpp (292752 => 292753)
--- trunk/Source/WTF/wtf/playstation/LanguagePlayStation.cpp 2022-04-12 01:30:11 UTC (rev 292752)
+++ trunk/Source/WTF/wtf/playstation/LanguagePlayStation.cpp 2022-04-12 01:32:43 UTC (rev 292753)
@@ -36,7 +36,7 @@
char buffer[16];
if (!getenv_np("SYSTEM_LANGUAGE", buffer, sizeof(buffer)))
-languages.append(buffer);
+languages.append(String::fromLatin1(buffer));
return languages;
}
Modified: trunk/Source/WebDriver/ChangeLog (292752 => 292753)
--- trunk/Source/WebDriver/ChangeLog 2022-04-12 01:30:11 UTC (rev 292752)
+++ trunk/Source/WebDriver/ChangeLog 2022-04-12 01:32:43 UTC (rev 292753)
@@ -1,3 +1,13 @@
+2022-04-11 Don Olmstead
+
+Fix PlayStation build after r292696
+https://bugs.webkit.org/show_bug.cgi?id=239098
+
+Unreviewed build fix.
+
+* playstation/WebDriverServicePlayStation.cpp:
+(WebDriver::WebDriverService::platformCapabilities):
+
2022-04-10 Chris Dumez
Finish porting code base to String::fromLatin1() and make String(const char*) private
Modified: trunk/Source/WebDriver/playstation/WebDriverServicePlayStation.cpp (292752 => 292753)
--- trunk/Source/WebDriver/playstation/WebDriverServicePlayStation.cpp 2022-04-12 01:30:11 UTC (rev 292752)
+++ trunk/Source/WebDriver/playstation/WebDriverServicePlayStation.cpp 2022-04-12 01:32:43 UTC (rev 292753)
@@ -45,7 +45,7 @@
Capabilities WebDriverService::platformCapabilities()
{
Capabilities capabilities;
-capabilities.platformName = String("playstation");
+capabilities.platformName = String::fromLatin1("playstation");
capabilities.setWindowRect = true;
return capabilities;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292752] trunk/Source/WebCore
Title: [292752] trunk/Source/WebCore
Revision 292752
Author za...@apple.com
Date 2022-04-11 18:30:11 -0700 (Mon, 11 Apr 2022)
Log Message
[IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent
https://bugs.webkit.org/show_bug.cgi?id=239059
Reviewed by Antti Koivisto.
Implement inkOverflowTop/inkOverflowBottom for inline iterator (LineBox) so that we can
keep InlineContent internal to LayoutIntegration::LineLayout.
* layout/integration/InlineIteratorLineBox.h:
(WebCore::InlineIterator::LineBox::inkOverflowTop const):
(WebCore::InlineIterator::LineBox::inkOverflowBottom const):
* layout/integration/InlineIteratorLineBoxLegacyPath.h:
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::inkOverflowTop const):
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::inkOverflowBottom const):
* layout/integration/InlineIteratorLineBoxModernPath.h:
(WebCore::InlineIterator::LineBoxIteratorModernPath::inkOverflowTop const):
(WebCore::InlineIterator::LineBoxIteratorModernPath::inkOverflowBottom const):
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hasVisualOverflow const):
* layout/integration/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::isPaginated const):
(WebCore::LayoutIntegration::LineLayout::inlineContent const): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutModernLines):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/InlineIteratorLineBox.h
trunk/Source/WebCore/layout/integration/InlineIteratorLineBoxLegacyPath.h
trunk/Source/WebCore/layout/integration/InlineIteratorLineBoxModernPath.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292751 => 292752)
--- trunk/Source/WebCore/ChangeLog 2022-04-12 01:16:08 UTC (rev 292751)
+++ trunk/Source/WebCore/ChangeLog 2022-04-12 01:30:11 UTC (rev 292752)
@@ -1,3 +1,30 @@
+2022-04-11 Alan Bujtas
+
+[IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent
+https://bugs.webkit.org/show_bug.cgi?id=239059
+
+Reviewed by Antti Koivisto.
+
+Implement inkOverflowTop/inkOverflowBottom for inline iterator (LineBox) so that we can
+keep InlineContent internal to LayoutIntegration::LineLayout.
+
+* layout/integration/InlineIteratorLineBox.h:
+(WebCore::InlineIterator::LineBox::inkOverflowTop const):
+(WebCore::InlineIterator::LineBox::inkOverflowBottom const):
+* layout/integration/InlineIteratorLineBoxLegacyPath.h:
+(WebCore::InlineIterator::LineBoxIteratorLegacyPath::inkOverflowTop const):
+(WebCore::InlineIterator::LineBoxIteratorLegacyPath::inkOverflowBottom const):
+* layout/integration/InlineIteratorLineBoxModernPath.h:
+(WebCore::InlineIterator::LineBoxIteratorModernPath::inkOverflowTop const):
+(WebCore::InlineIterator::LineBoxIteratorModernPath::inkOverflowBottom const):
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::hasVisualOverflow const):
+* layout/integration/LayoutIntegrationLineLayout.h:
+(WebCore::LayoutIntegration::LineLayout::isPaginated const):
+(WebCore::LayoutIntegration::LineLayout::inlineContent const): Deleted.
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::layoutModernLines):
+
2022-04-11 Myles C. Maxfield
[WebGPU] Hook up device.queue to the IDL
Modified: trunk/Source/WebCore/layout/integration/InlineIteratorLineBox.h (292751 => 292752)
--- trunk/Source/WebCore/layout/integration/InlineIteratorLineBox.h 2022-04-12 01:16:08 UTC (rev 292751)
+++ trunk/Source/WebCore/layout/integration/InlineIteratorLineBox.h 2022-04-12 01:30:11 UTC (rev 292752)
@@ -67,6 +67,9 @@
float contentLogicalTopAdjustedForPrecedingLineBox() const;
float contentLogicalBottomAdjustedForFollowingLineBox() const;
+float inkOverflowTop() const;
+float inkOverflowBottom() const;
+
const RenderBlockFlow& containingBlock() const;
RenderFragmentContainer* containingFragment() const;
@@ -180,6 +183,20 @@
});
}
+inline float LineBox::inkOverflowTop() const
+{
+return WTF::switchOn(m_pathVariant, [](const auto& path) {
+return path.inkOverflowTop();
+});
+}
+
+inline float LineBox::inkOverflowBottom() const
+{
+return WTF::switchOn(m_pathVariant, [](const auto& path) {
+return path.inkOverflowBottom();
+});
+}
+
inline float LineBox::contentLogicalLeft() const
{
return WTF::switchOn(m_pathVariant, [](const auto& path) {
Modified: trunk/Source/WebCore/layout/integration/InlineIteratorLineBoxLegacyPath.h (292751 => 292752)
---
[webkit-changes] [292751] trunk/LayoutTests
Title: [292751] trunk/LayoutTests Revision 292751 Author matteo_flo...@apple.com Date 2022-04-11 18:16:08 -0700 (Mon, 11 Apr 2022) Log Message [ Mac wk2 Debug ] accessibility/ancestor-computation.html is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=239099 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292750 => 292751) --- trunk/LayoutTests/ChangeLog 2022-04-12 01:15:48 UTC (rev 292750) +++ trunk/LayoutTests/ChangeLog 2022-04-12 01:16:08 UTC (rev 292751) @@ -1,3 +1,12 @@ +2022-04-11 Matteo Flores + +[ Mac wk2 Debug ] accessibility/ancestor-computation.html is a constant timeout +https://bugs.webkit.org/show_bug.cgi?id=239099 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2022-04-11 Alan Bujtas [ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292750 => 292751) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-12 01:15:48 UTC (rev 292750) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-12 01:16:08 UTC (rev 292751) @@ -1552,6 +1552,8 @@ webkit.org/b/229579 [ BigSur Debug ] http/tests/loading/preload-img-test.html [ Pass Failure ] +webkit.org/b/239099 [ Debug ] accessibility/ancestor-computation.html [ Pass Timeout ] + webkit.org/b/231088 [ Release ] http/tests/loading/preload-slow-loading.py [ Pass Failure ] webkit.org/b/228127 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/resource-popup.https.html [ Pass Crash Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292750] trunk/Tools
Title: [292750] trunk/Tools
Revision 292750
Author cdu...@apple.com
Date 2022-04-11 18:15:48 -0700 (Mon, 11 Apr 2022)
Log Message
REGRESSION:(r292696) lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=239087
Reviewed by Jonathan Bedard.
Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string
* lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/lldb/lldbWebKitTester/main.cpp
Diff
Modified: trunk/Tools/ChangeLog (292749 => 292750)
--- trunk/Tools/ChangeLog 2022-04-12 00:43:49 UTC (rev 292749)
+++ trunk/Tools/ChangeLog 2022-04-12 01:15:48 UTC (rev 292750)
@@ -1,3 +1,16 @@
+2022-04-11 Chris Dumez
+
+REGRESSION:(r292696) lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure
+https://bugs.webkit.org/show_bug.cgi?id=239087
+
+Reviewed by Jonathan Bedard.
+
+Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
+lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string
+
+* lldb/lldbWebKitTester/main.cpp:
+(testSummaryProviders):
+
2022-04-11 Alan Bujtas
[ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing
Modified: trunk/Tools/lldb/lldbWebKitTester/main.cpp (292749 => 292750)
--- trunk/Tools/lldb/lldbWebKitTester/main.cpp 2022-04-12 00:43:49 UTC (rev 292749)
+++ trunk/Tools/lldb/lldbWebKitTester/main.cpp 2022-04-12 01:15:48 UTC (rev 292750)
@@ -57,7 +57,7 @@
static void testSummaryProviders()
{
-String aNullString { };
+String aNullString { ""_s };
StringImpl* aNullStringImpl = aNullString.impl();
String anEmptyString { ""_s };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292749] trunk
Title: [292749] trunk Revision 292749 Author za...@apple.com Date 2022-04-11 17:43:49 -0700 (Mon, 11 Apr 2022) Log Message [ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing https://bugs.webkit.org/show_bug.cgi?id=232384 Reviewed by Wenson Hsieh. Tools: Rotation (initiated by UiController::simulateRotationLikeSafari) may confuse UIScreen and produce unexpected scale value. This patch ensures that we set the scale value back to the default (2) in between test runs. (Currently we only set this value in TestController::platformInitialize/dumpRenderTree.) * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentState): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): LayoutTests: * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm Diff Modified: trunk/LayoutTests/ChangeLog (292748 => 292749) --- trunk/LayoutTests/ChangeLog 2022-04-12 00:40:29 UTC (rev 292748) +++ trunk/LayoutTests/ChangeLog 2022-04-12 00:43:49 UTC (rev 292749) @@ -1,3 +1,13 @@ +2022-04-11 Alan Bujtas + +[ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing +https://bugs.webkit.org/show_bug.cgi?id=232384 + + +Reviewed by Wenson Hsieh. + +* platform/ios/TestExpectations: + 2022-04-11 Truitt Savell REGRESSION (249023-249029@main): [ Monterey ] http/wpt/cache-storage/cache-storage-networkprocess-crash.html is a flaky CRASH with ASSERTION FAILED: m_pageMap.isEmpty() Modified: trunk/LayoutTests/platform/ios/TestExpectations (292748 => 292749) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-04-12 00:40:29 UTC (rev 292748) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-04-12 00:43:49 UTC (rev 292749) @@ -3426,11 +3426,6 @@ model-element/model-element-camera.html [ Skip ] model-element/model-element-interactive-dragging.html [ Skip ] -# webkit.org/b/232384 these are flaky failures on iOS -fast/hidpi/image-srcset-simple-1x.html [ Pass Failure ] -fast/hidpi/image-srcset-simple-in-variable-1x.html [ Pass Failure ] -fast/hidpi/pdf-image-scaled.html [ Pass Failure ] - # webkit.org/b/201982 These are flaky failures on iOS fast/images/exif-orientation-svg-feimage.html [ Pass Failure ] fast/images/exif-orientation-background-image-repeat.html [ Pass Failure ] Modified: trunk/Tools/ChangeLog (292748 => 292749) --- trunk/Tools/ChangeLog 2022-04-12 00:40:29 UTC (rev 292748) +++ trunk/Tools/ChangeLog 2022-04-12 00:43:49 UTC (rev 292749) @@ -1,3 +1,20 @@ +2022-04-11 Alan Bujtas + +[ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing +https://bugs.webkit.org/show_bug.cgi?id=232384 + + +Reviewed by Wenson Hsieh. + +Rotation (initiated by UiController::simulateRotationLikeSafari) may confuse UIScreen and produce unexpected scale value. +This patch ensures that we set the scale value back to the default (2) in between test runs. +(Currently we only set this value in TestController::platformInitialize/dumpRenderTree.) + +* DumpRenderTree/mac/DumpRenderTree.mm: +(resetWebViewToConsistentState): +* WebKitTestRunner/ios/TestControllerIOS.mm: +(WTR::TestController::platformResetStateToConsistentValues): + 2022-04-11 Sam Sneddon webkitpy.w3c.test_exporter assumes all exceptions are HTTPError Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (292748 => 292749) --- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2022-04-12 00:40:29 UTC (rev 292748) +++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2022-04-12 00:43:49 UTC (rev 292749) @@ -1732,6 +1732,7 @@ #if PLATFORM(IOS_FAMILY) adjustWebDocumentForStandardViewport(gWebBrowserView.get(), gWebScrollView.get()); [webView _setAllowsMessaging:YES]; +[[UIScreen mainScreen] _setScale:2.0]; #endif [webView setEditable:NO]; [(EditingDelegate *)[webView editingDelegate] setAcceptsEditing:YES]; Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (292748 => 292749) --- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2022-04-12 00:40:29 UTC (rev 292748) +++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2022-04-12 00:43:49 UTC (rev 292749) @@ -158,6 +158,7 @@ [pasteboardConsistencyEnforcer() clearPasteboard]; [[UIApplication sharedApplication] _cancelAllTouches]; [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO]; +[[UIScreen mainScreen] _setScale:2.0]; // Ensures that only the UCB is on-screen when showing the keyboard, if the hardware keyboard is attached. TIPreferencesController *textInputPreferences = [getTIPreferencesControllerClass()
[webkit-changes] [292748] trunk/Source/WebGPU
Title: [292748] trunk/Source/WebGPU
Revision 292748
Author mmaxfi...@apple.com
Date 2022-04-11 17:40:29 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] WebGPU strings are UTF-8, not Latin-1
https://bugs.webkit.org/show_bug.cgi?id=239057
Reviewed by Kimmo Kinnunen.
Replace String::fromLatin1() with String::fromUTF8().
* WebGPU/APIConversions.h:
(WebGPU::fromAPI):
* WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
* WebGPU/ComputePipeline.mm:
(WebGPU::createConstantValues):
(WebGPU::Device::createComputePipeline):
* WebGPU/ShaderModule.mm:
(WebGPU::earlyCompileShaderModule):
(WebGPU::Device::createShaderModule):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/APIConversions.h
trunk/Source/WebGPU/WebGPU/Adapter.mm
trunk/Source/WebGPU/WebGPU/ComputePipeline.mm
trunk/Source/WebGPU/WebGPU/ShaderModule.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292747 => 292748)
--- trunk/Source/WebGPU/ChangeLog 2022-04-12 00:30:21 UTC (rev 292747)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-12 00:40:29 UTC (rev 292748)
@@ -1,5 +1,25 @@
2022-04-11 Myles C. Maxfield
+[WebGPU] WebGPU strings are UTF-8, not Latin-1
+https://bugs.webkit.org/show_bug.cgi?id=239057
+
+Reviewed by Kimmo Kinnunen.
+
+Replace String::fromLatin1() with String::fromUTF8().
+
+* WebGPU/APIConversions.h:
+(WebGPU::fromAPI):
+* WebGPU/Adapter.mm:
+(WebGPU::Adapter::requestDevice):
+* WebGPU/ComputePipeline.mm:
+(WebGPU::createConstantValues):
+(WebGPU::Device::createComputePipeline):
+* WebGPU/ShaderModule.mm:
+(WebGPU::earlyCompileShaderModule):
+(WebGPU::Device::createShaderModule):
+
+2022-04-11 Myles C. Maxfield
+
[WebGPU] Make sure asynchronous things are asynchronous
https://bugs.webkit.org/show_bug.cgi?id=239056
Modified: trunk/Source/WebGPU/WebGPU/APIConversions.h (292747 => 292748)
--- trunk/Source/WebGPU/WebGPU/APIConversions.h 2022-04-12 00:30:21 UTC (rev 292747)
+++ trunk/Source/WebGPU/WebGPU/APIConversions.h 2022-04-12 00:40:29 UTC (rev 292748)
@@ -171,7 +171,7 @@
inline String fromAPI(const char* string)
{
-return String::fromLatin1(string);
+return String::fromUTF8(string);
}
template
Modified: trunk/Source/WebGPU/WebGPU/Adapter.mm (292747 => 292748)
--- trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-04-12 00:30:21 UTC (rev 292747)
+++ trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-04-12 00:40:29 UTC (rev 292748)
@@ -134,7 +134,7 @@
return;
}
-auto label = String::fromLatin1(descriptor.label);
+auto label = fromAPI(descriptor.label);
instance().scheduleWork([strongThis = Ref { *this }, label = WTFMove(label), callback = WTFMove(callback)]() mutable {
callback(WGPURequestDeviceStatus_Success, Device::create(strongThis->m_device, WTFMove(label), strongThis), { });
});
Modified: trunk/Source/WebGPU/WebGPU/ComputePipeline.mm (292747 => 292748)
--- trunk/Source/WebGPU/WebGPU/ComputePipeline.mm 2022-04-12 00:30:21 UTC (rev 292747)
+++ trunk/Source/WebGPU/WebGPU/ComputePipeline.mm 2022-04-12 00:40:29 UTC (rev 292748)
@@ -71,7 +71,7 @@
auto constantValues = [MTLFunctionConstantValues new];
for (uint32_t i = 0; i < constantCount; ++i) {
const auto& entry = constants[i];
-auto nameIterator = entryPointInformation.specializationConstantIndices.find(String::fromLatin1(entry.key));
+auto nameIterator = entryPointInformation.specializationConstantIndices.find(fromAPI(entry.key));
if (nameIterator == entryPointInformation.specializationConstantIndices.end())
return nullptr;
auto specializationConstantIndex = nameIterator->value;
@@ -150,7 +150,7 @@
const PipelineLayout& pipelineLayout = WebGPU::fromAPI(descriptor.layout);
auto label = fromAPI(descriptor.label);
-auto libraryCreationResult = createLibrary(m_device, shaderModule, pipelineLayout, String::fromLatin1(descriptor.compute.entryPoint), label);
+auto libraryCreationResult = createLibrary(m_device, shaderModule, pipelineLayout, fromAPI(descriptor.compute.entryPoint), label);
if (!libraryCreationResult)
return ComputePipeline::createInvalid(*this);
Modified: trunk/Source/WebGPU/WebGPU/ShaderModule.mm (292747 => 292748)
--- trunk/Source/WebGPU/WebGPU/ShaderModule.mm 2022-04-12 00:30:21 UTC (rev 292747)
+++ trunk/Source/WebGPU/WebGPU/ShaderModule.mm 2022-04-12 00:40:29 UTC (rev 292748)
@@ -88,7 +88,7 @@
const auto& hint = suppliedHints.hints[i];
if (hint.nextInChain)
return nullptr;
-auto hintKey = String::fromLatin1(hint.key);
+auto hintKey = fromAPI(hint.key);
hints.add(hintKey, WebGPU::fromAPI(hint.hint.layout));
auto convertedPipelineLayout = ShaderModule::convertPipelineLayout(WebGPU::fromAPI(hint.hint.layout));
wgslHints.add(hintKey, WTFMove(convertedPipelineLayout));
@@
[webkit-changes] [292747] trunk/Source/WebGPU
Title: [292747] trunk/Source/WebGPU
Revision 292747
Author mmaxfi...@apple.com
Date 2022-04-11 17:30:21 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Make sure asynchronous things are asynchronous
https://bugs.webkit.org/show_bug.cgi?id=239056
Reviewed by Kimmo Kinnunen.
This isn't strictly necessary, because these asynchronous callbacks get hooked up
to promises in the browser which only call their callbacks at microtask boundaries.
However, for native code that uses WebGPU.framework, it's probably better to make
sure the asynchronous callbacks are actually asynchronous.
* WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
* WebGPU/Buffer.mm:
(WebGPU::Buffer::mapAsync):
* WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipelineAsync):
* WebGPU/Device.mm:
(WebGPU::Device::loseTheDevice):
(WebGPU::Device::popErrorScope):
* WebGPU/Instance.mm:
(WebGPU::Instance::requestAdapter):
* WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipelineAsync):
* WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::getCompilationInfo):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Adapter.mm
trunk/Source/WebGPU/WebGPU/Buffer.mm
trunk/Source/WebGPU/WebGPU/ComputePipeline.mm
trunk/Source/WebGPU/WebGPU/Device.mm
trunk/Source/WebGPU/WebGPU/Instance.mm
trunk/Source/WebGPU/WebGPU/RenderPipeline.mm
trunk/Source/WebGPU/WebGPU/ShaderModule.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292746 => 292747)
--- trunk/Source/WebGPU/ChangeLog 2022-04-12 00:23:05 UTC (rev 292746)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-12 00:30:21 UTC (rev 292747)
@@ -1,5 +1,33 @@
2022-04-11 Myles C. Maxfield
+[WebGPU] Make sure asynchronous things are asynchronous
+https://bugs.webkit.org/show_bug.cgi?id=239056
+
+Reviewed by Kimmo Kinnunen.
+
+This isn't strictly necessary, because these asynchronous callbacks get hooked up
+to promises in the browser which only call their callbacks at microtask boundaries.
+However, for native code that uses WebGPU.framework, it's probably better to make
+sure the asynchronous callbacks are actually asynchronous.
+
+* WebGPU/Adapter.mm:
+(WebGPU::Adapter::requestDevice):
+* WebGPU/Buffer.mm:
+(WebGPU::Buffer::mapAsync):
+* WebGPU/ComputePipeline.mm:
+(WebGPU::Device::createComputePipelineAsync):
+* WebGPU/Device.mm:
+(WebGPU::Device::loseTheDevice):
+(WebGPU::Device::popErrorScope):
+* WebGPU/Instance.mm:
+(WebGPU::Instance::requestAdapter):
+* WebGPU/RenderPipeline.mm:
+(WebGPU::Device::createRenderPipelineAsync):
+* WebGPU/ShaderModule.mm:
+(WebGPU::ShaderModule::getCompilationInfo):
+
+2022-04-11 Myles C. Maxfield
+
[WebGPU] Implement missing validity checks
https://bugs.webkit.org/show_bug.cgi?id=238722
Modified: trunk/Source/WebGPU/WebGPU/Adapter.mm (292746 => 292747)
--- trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-04-12 00:23:05 UTC (rev 292746)
+++ trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-04-12 00:30:21 UTC (rev 292747)
@@ -114,21 +114,30 @@
void Adapter::requestDevice(const WGPUDeviceDescriptor& descriptor, CompletionHandler&&, String&&)>&& callback)
{
if (descriptor.nextInChain) {
-callback(WGPURequestDeviceStatus_Error, Device::createInvalid(*this), "Unknown descriptor type"_s);
+instance().scheduleWork([strongThis = Ref { *this }, callback = WTFMove(callback)]() mutable {
+callback(WGPURequestDeviceStatus_Error, Device::createInvalid(strongThis), "Unknown descriptor type"_s);
+});
return;
}
if (descriptor.requiredFeaturesCount) {
-callback(WGPURequestDeviceStatus_Error, Device::createInvalid(*this), "Device does not support requested features"_s);
+instance().scheduleWork([strongThis = Ref { *this }, callback = WTFMove(callback)]() mutable {
+callback(WGPURequestDeviceStatus_Error, Device::createInvalid(strongThis), "Device does not support requested features"_s);
+});
return;
}
if (descriptor.requiredLimits && !deviceMeetsRequiredLimits(m_device, *descriptor.requiredLimits)) {
-callback(WGPURequestDeviceStatus_Error, Device::createInvalid(*this), "Device does not support requested limits"_s);
+instance().scheduleWork([strongThis = Ref { *this }, callback = WTFMove(callback)]() mutable {
+callback(WGPURequestDeviceStatus_Error, Device::createInvalid(strongThis), "Device does not support requested limits"_s);
+});
return;
}
-callback(WGPURequestDeviceStatus_Success, Device::create(m_device, String::fromLatin1(descriptor.label), *this), { });
+auto label = String::fromLatin1(descriptor.label);
+instance().scheduleWork([strongThis = Ref { *this }, label = WTFMove(label), callback = WTFMove(callback)]() mutable {
+callback(WGPURequestDeviceStatus_Success,
[webkit-changes] [292746] trunk/Source/WebInspectorUI
Title: [292746] trunk/Source/WebInspectorUI
Revision 292746
Author nvasil...@apple.com
Date 2022-04-11 17:23:05 -0700 (Mon, 11 Apr 2022)
Log Message
Web Inspector: REGRESSION(r290770): Styles: creating a new property scrolls the input to the top of the panel
https://bugs.webkit.org/show_bug.cgi?id=237747
Reviewed by Patrick Angle.
Remove unnecessary scrollIntoViewIfNeeded call. I added the scrollIntoViewIfNeeded call in 2017 (r222959) because,
at the time, focusing on an input field didn't scroll it into the viewport. It was possible to tab into an element
outside of the viewport and WebKit wouldn't scroll it make it visible. This is no longer the case.
* UserInterface/Views/SpreadsheetSelectorField.js:
(WI.SpreadsheetSelectorField.prototype.startEditing):
Call `focus()` to scroll to the edited element.
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype.startEditing):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (292745 => 292746)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-04-12 00:19:08 UTC (rev 292745)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-12 00:23:05 UTC (rev 292746)
@@ -1,3 +1,22 @@
+2022-04-11 Nikita Vasilyev
+
+Web Inspector: REGRESSION(r290770): Styles: creating a new property scrolls the input to the top of the panel
+https://bugs.webkit.org/show_bug.cgi?id=237747
+
+
+Reviewed by Patrick Angle.
+
+Remove unnecessary scrollIntoViewIfNeeded call. I added the scrollIntoViewIfNeeded call in 2017 (r222959) because,
+at the time, focusing on an input field didn't scroll it into the viewport. It was possible to tab into an element
+outside of the viewport and WebKit wouldn't scroll it make it visible. This is no longer the case.
+
+* UserInterface/Views/SpreadsheetSelectorField.js:
+(WI.SpreadsheetSelectorField.prototype.startEditing):
+Call `focus()` to scroll to the edited element.
+
+* UserInterface/Views/SpreadsheetTextField.js:
+(WI.SpreadsheetTextField.prototype.startEditing):
+
2022-04-08 Elliott Williams
[Xcode] Avoid targeting 32-bit iOS and Mac architectures
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js (292745 => 292746)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js 2022-04-12 00:19:08 UTC (rev 292745)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js 2022-04-12 00:23:05 UTC (rev 292746)
@@ -59,7 +59,7 @@
element.classList.add("editing");
element.contentEditable = "plaintext-only";
element.spellcheck = false;
-element.scrollIntoViewIfNeeded(false);
+element.focus();
// Disable syntax highlighting.
element.textContent = element.textContent;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js (292745 => 292746)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2022-04-12 00:19:08 UTC (rev 292745)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2022-04-12 00:23:05 UTC (rev 292746)
@@ -123,7 +123,6 @@
this._element.classList.add("editing");
this._element.contentEditable = "plaintext-only";
this._element.spellcheck = false;
-this._element.scrollIntoViewIfNeeded(false);
this._element.focus();
this._selectText();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292745] trunk/Source/WebCore/PAL
Title: [292745] trunk/Source/WebCore/PAL
Revision 292745
Author mmaxfi...@apple.com
Date 2022-04-11 17:19:08 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Unspecified texture size values should be set to 1, not 0
https://bugs.webkit.org/show_bug.cgi?id=239052
Reviewed by Kimmo Kinnunen.
If content says "Please create a texture of size [32, 32]" then we need to pad that
to [32, 32, 1] rather than [32, 32, 0].
Test: http/tests/webgpu/webgpu/api/validation/createTexture.html
* pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:
(PAL::WebGPU::ConvertToBackingContext::convertToBacking):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (292744 => 292745)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-04-12 00:14:49 UTC (rev 292744)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-04-12 00:19:08 UTC (rev 292745)
@@ -1,5 +1,20 @@
2022-04-11 Myles C. Maxfield
+[WebGPU] Unspecified texture size values should be set to 1, not 0
+https://bugs.webkit.org/show_bug.cgi?id=239052
+
+Reviewed by Kimmo Kinnunen.
+
+If content says "Please create a texture of size [32, 32]" then we need to pad that
+to [32, 32, 1] rather than [32, 32, 0].
+
+Test: http/tests/webgpu/webgpu/api/validation/createTexture.html
+
+* pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:
+(PAL::WebGPU::ConvertToBackingContext::convertToBacking):
+
+2022-04-11 Myles C. Maxfield
+
[WebGPU] Implement correct ownership for WGPUQueues
https://bugs.webkit.org/show_bug.cgi?id=239050
Modified: trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp (292744 => 292745)
--- trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp 2022-04-12 00:14:49 UTC (rev 292744)
+++ trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp 2022-04-12 00:19:08 UTC (rev 292745)
@@ -790,9 +790,9 @@
{
return WTF::switchOn(extent3D, [] (const Vector& vector) {
return WGPUExtent3D {
-vector.size() > 0 ? vector[0] : 0,
-vector.size() > 1 ? vector[1] : 0,
-vector.size() > 2 ? vector[2] : 0,
+vector.size() > 0 ? vector[0] : 1,
+vector.size() > 1 ? vector[1] : 1,
+vector.size() > 2 ? vector[2] : 1,
};
}, [] (const Extent3DDict& extent) {
return WGPUExtent3D {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292744] trunk/Source/WebGPU
Title: [292744] trunk/Source/WebGPU Revision 292744 Author mmaxfi...@apple.com Date 2022-04-11 17:14:49 -0700 (Mon, 11 Apr 2022) Log Message [WebGPU] Implement missing validity checks https://bugs.webkit.org/show_bug.cgi?id=238722 Reviewed by Kimmo Kinnunen. Now that WebGPU objects have a notion of validity, we can implement all the FIXMEs for validity checks. * WebGPU/Buffer.mm: (WebGPU::validateCreateBuffer): (WebGPU::Buffer::validateMapAsync const): * WebGPU/CommandEncoder.h: (WebGPU::CommandEncoder::makeInvalid): * WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::validateCopyBufferToBuffer): (WebGPU::validateImageCopyBuffer): (WebGPU::CommandEncoder::validateClearBuffer): (WebGPU::CommandEncoder::validateFinish const): (WebGPU::CommandEncoder::finish): (WebGPU::CommandEncoder::popDebugGroup): (WebGPU::validateCopyBufferToBuffer): Deleted. (WebGPU::validateClearBuffer): Deleted. * WebGPU/ComputePassEncoder.h: (WebGPU::ComputePassEncoder::makeInvalid): * WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::popDebugGroup): * WebGPU/ObjectBase.h: (WebGPU::ObjectBase::isValidToUseWith const): (WebGPU::ObjectBase::device const): * WebGPU/Queue.h: (WebGPU::Queue::device const): * WebGPU/Queue.mm: (WebGPU::Queue::validateSubmit const): (WebGPU::Queue::submit): (WebGPU::Queue::validateWriteBuffer const): * WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::makeInvalid): * WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::popDebugGroup): * WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::makeInvalid): * WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::popDebugGroup): * WebGPU/Sampler.mm: (WebGPU::validateCreateSampler): * WebGPU/Texture.mm: (WebGPU::Device::validateCreateTexture): (WebGPU::Device::createTexture): (WebGPU::Texture::validateCreateView const): (WebGPU::Texture::createView): (WebGPU::Texture::validateImageCopyTexture): Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU/Texture.mm Diff Modified: trunk/Source/WebGPU/ChangeLog (292743 => 292744) --- trunk/Source/WebGPU/ChangeLog 2022-04-12 00:10:17 UTC (rev 292743) +++ trunk/Source/WebGPU/ChangeLog 2022-04-12 00:14:49 UTC (rev 292744) @@ -52,6 +52,18 @@ (WebGPU::Texture::createView): (WebGPU::Texture::validateImageCopyTexture): +2022-04-11 Myles C. Maxfield + +[WebGPU] RGB9E5Ufloat textures should not be multisamplable +https://bugs.webkit.org/show_bug.cgi?id=239053 + +Reviewed by Kimmo Kinnunen. + +It's classified as a "packed format" rather than a "mixed component width format." + +* WebGPU/Texture.mm: +(WebGPU::supportsMultisampling): + 2022-04-08 Myles C. Maxfield [WebGPU] Fix the release build Modified: trunk/Source/WebGPU/WebGPU/Texture.mm (292743 => 292744) --- trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 00:10:17 UTC (rev 292743) +++ trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 00:14:49 UTC (rev 292744) @@ -868,7 +868,6 @@ case WGPUTextureFormat_BGRA8UnormSrgb: case WGPUTextureFormat_RGB10A2Unorm: case WGPUTextureFormat_RG11B10Ufloat: -case WGPUTextureFormat_RGB9E5Ufloat: case WGPUTextureFormat_RGBA16Uint: case WGPUTextureFormat_RGBA16Sint: case WGPUTextureFormat_RGBA16Float: @@ -889,6 +888,7 @@ case WGPUTextureFormat_RGBA32Float: case WGPUTextureFormat_RGBA32Uint: case WGPUTextureFormat_RGBA32Sint: +case WGPUTextureFormat_RGB9E5Ufloat: case WGPUTextureFormat_BC1RGBAUnorm: case WGPUTextureFormat_BC1RGBAUnormSrgb: case WGPUTextureFormat_BC2RGBAUnorm: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292743] trunk/Source/ThirdParty/ANGLE
Title: [292743] trunk/Source/ThirdParty/ANGLE
Revision 292743
Author kpidding...@apple.com
Date 2022-04-11 17:10:17 -0700 (Mon, 11 Apr 2022)
Log Message
This WebGL example crashes
https://bugs.webkit.org/show_bug.cgi?id=238953
Null-check subnodes while performing a deep copy for
loops, and branches. These nodes can be null in some cases
Reviewed by Dean Jackson.
* src/compiler/translator/IntermNode.cpp:
(sh::TIntermBranch::TIntermBranch):
(sh::TIntermLoop::TIntermLoop):
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.cpp
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (292742 => 292743)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-12 00:07:17 UTC (rev 292742)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-12 00:10:17 UTC (rev 292743)
@@ -1,3 +1,17 @@
+2022-04-11 Kyle Piddington
+
+This WebGL example crashes
+https://bugs.webkit.org/show_bug.cgi?id=238953
+
+Null-check subnodes while performing a deep copy for
+loops, and branches. These nodes can be null in some cases
+
+Reviewed by Dean Jackson.
+
+* src/compiler/translator/IntermNode.cpp:
+(sh::TIntermBranch::TIntermBranch):
+(sh::TIntermLoop::TIntermLoop):
+
2022-04-08 Elliott Williams
[Xcode] Avoid targeting 32-bit iOS and Mac architectures
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.cpp (292742 => 292743)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.cpp 2022-04-12 00:07:17 UTC (rev 292742)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.cpp 2022-04-12 00:10:17 UTC (rev 292743)
@@ -279,7 +279,7 @@
}
TIntermBranch::TIntermBranch(const TIntermBranch )
-: TIntermBranch(node.mFlowOp, node.mExpression->deepCopy())
+: TIntermBranch(node.mFlowOp, node.mExpression ? node.mExpression->deepCopy() : nullptr)
{}
size_t TIntermBranch::getChildCount() const
@@ -1601,10 +1601,10 @@
TIntermLoop::TIntermLoop(const TIntermLoop )
: TIntermLoop(node.mType,
- node.mInit->deepCopy(),
- node.mCond->deepCopy(),
- node.mExpr->deepCopy(),
- node.mBody->deepCopy())
+ node.mInit ? node.mInit->deepCopy() : nullptr,
+ node.mCond ? node.mCond->deepCopy() : nullptr,
+ node.mExpr ? node.mExpr->deepCopy() : nullptr,
+ node.mBody ? node.mBody->deepCopy() : nullptr)
{}
TIntermIfElse::TIntermIfElse(TIntermTyped *cond, TIntermBlock *trueB, TIntermBlock *falseB)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292742] trunk/Source/WebCore/PAL
Title: [292742] trunk/Source/WebCore/PAL Revision 292742 Author mmaxfi...@apple.com Date 2022-04-11 17:07:17 -0700 (Mon, 11 Apr 2022) Log Message [WebGPU] Implement correct ownership for WGPUQueues https://bugs.webkit.org/show_bug.cgi?id=239050 Reviewed by Kimmo Kinnunen. WGPUQueues and WGPUDevices have a somewhat interesting relationship: neither is reference-counted, and the WGPUDevice owns its WGPUQueue. This means that, if client code wants to extend the lifetime of a WGPUQueue, it has to do this by extending the lifetime of its owning WGPUDevice. Both objects are _javascript_ objects, so there has to be some mechanism for a queue to extend the lifetime of its owning device. And yet, a device owns a queue, so a queue can't have a queue have a Ref<> to its owning device, because that would be a circular depndency. Here's the old ownership graph: _javascript_ | | | | V | PAL::WebGPU::DeviceImpl | |\| | - | | \ V |-> PAL::WebGPU::QueueImpl | | | | V | WGPUDevice| \ | - | \ V > WGPUQueue You can see that there's a problem here: WGPUQueue has 2 owners, but it's not a reference-counted object. The solution is to add a new node into the ownership graph, like this: _javascript_ | | | | V | PAL::WebGPU::DeviceImpl | \ \| \ - | \\ V \ -> PAL::WebGPU::QueueImpl \ / \/ \ / VV PAL::WebGPU::DeviceHolder / / / / V WGPUDevice \ - \ > WGPUQueue This way, both WGPUDevice and WGPUQueue have a single owner, there are no cycles, and there is a path from PAL::WebGPU::QueueImpl to WGPUDevice. * PAL.xcodeproj/project.pbxproj: * pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.cpp: Added. (PAL::WebGPU::DeviceHolderImpl::DeviceHolderImpl): (PAL::WebGPU::DeviceHolderImpl::~DeviceHolderImpl): * pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUQueueImpl.h. * pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::DeviceImpl::DeviceImpl): (PAL::WebGPU::DeviceImpl::destroy): (PAL::WebGPU::DeviceImpl::createBuffer): (PAL::WebGPU::DeviceImpl::createTexture): (PAL::WebGPU::DeviceImpl::createSampler): (PAL::WebGPU::DeviceImpl::createBindGroupLayout): (PAL::WebGPU::DeviceImpl::createPipelineLayout): (PAL::WebGPU::DeviceImpl::createBindGroup): (PAL::WebGPU::DeviceImpl::createShaderModule): (PAL::WebGPU::DeviceImpl::createComputePipeline): (PAL::WebGPU::DeviceImpl::createRenderPipeline): (PAL::WebGPU::DeviceImpl::createComputePipelineAsync): (PAL::WebGPU::DeviceImpl::createRenderPipelineAsync): (PAL::WebGPU::DeviceImpl::createCommandEncoder): (PAL::WebGPU::DeviceImpl::createRenderBundleEncoder): (PAL::WebGPU::DeviceImpl::createQuerySet): (PAL::WebGPU::DeviceImpl::pushErrorScope): (PAL::WebGPU::DeviceImpl::popErrorScope): (PAL::WebGPU::DeviceImpl::setLabelInternal): (PAL::WebGPU::DeviceImpl::~DeviceImpl): Deleted. * pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h: * pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp: (PAL::WebGPU::QueueImpl::QueueImpl): (PAL::WebGPU::QueueImpl::submit): (PAL::WebGPU::QueueImpl::onSubmittedWorkDone): (PAL::WebGPU::QueueImpl::writeBuffer): (PAL::WebGPU::QueueImpl::writeTexture): (PAL::WebGPU::QueueImpl::setLabelInternal): (PAL::WebGPU::QueueImpl::~QueueImpl): Deleted. * pal/graphics/WebGPU/Impl/WebGPUQueueImpl.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
[webkit-changes] [292741] trunk/Source
Title: [292741] trunk/Source
Revision 292741
Author mmaxfi...@apple.com
Date 2022-04-11 17:04:35 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Hook up device.queue to the IDL
https://bugs.webkit.org/show_bug.cgi?id=239043
Reviewed by Kimmo Kinnunen.
Source/WebCore:
It seems when I imported the WebGPU IDLs, I somehow skipped GPUDevice.queue.
I was probably unsure about the ownership model. Now that the ownership model
is straightened out, this can be implemented.
This is needed to run any of the CTS tests.
* Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::queue const):
* Modules/WebGPU/GPUDevice.h:
(WebCore::GPUDevice::m_queue):
(WebCore::GPUDevice::m_backing): Deleted.
* Modules/WebGPU/GPUDevice.idl:
Source/WebCore/PAL:
* pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::DeviceImpl::DeviceImpl):
(PAL::WebGPU::DeviceImpl::queue):
* pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h:
* pal/graphics/WebGPU/WebGPUDevice.h:
Source/WebKit:
* GPUProcess/graphics/WebGPU/RemoteAdapter.cpp:
(WebKit::RemoteAdapter::requestDevice):
* GPUProcess/graphics/WebGPU/RemoteAdapter.h:
* GPUProcess/graphics/WebGPU/RemoteAdapter.messages.in:
* GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::RemoteDevice):
(WebKit::RemoteDevice::queue):
* GPUProcess/graphics/WebGPU/RemoteDevice.h:
* WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp:
(WebKit::WebGPU::RemoteAdapterProxy::requestDevice):
* WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::RemoteDeviceProxy):
(WebKit::WebGPU::RemoteDeviceProxy::queue):
* WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/WebGPU/GPUDevice.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUDevice.h
trunk/Source/WebCore/Modules/WebGPU/GPUDevice.idl
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUDevice.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.messages.in
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292740 => 292741)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 23:48:05 UTC (rev 292740)
+++ trunk/Source/WebCore/ChangeLog 2022-04-12 00:04:35 UTC (rev 292741)
@@ -1,3 +1,23 @@
+2022-04-11 Myles C. Maxfield
+
+[WebGPU] Hook up device.queue to the IDL
+https://bugs.webkit.org/show_bug.cgi?id=239043
+
+Reviewed by Kimmo Kinnunen.
+
+It seems when I imported the WebGPU IDLs, I somehow skipped GPUDevice.queue.
+I was probably unsure about the ownership model. Now that the ownership model
+is straightened out, this can be implemented.
+
+This is needed to run any of the CTS tests.
+
+* Modules/WebGPU/GPUDevice.cpp:
+(WebCore::GPUDevice::queue const):
+* Modules/WebGPU/GPUDevice.h:
+(WebCore::GPUDevice::m_queue):
+(WebCore::GPUDevice::m_backing): Deleted.
+* Modules/WebGPU/GPUDevice.idl:
+
2022-04-11 Philippe Normand
[GStreamer] Debugs logs from VideoSinkCommon are missing
Modified: trunk/Source/WebCore/Modules/WebGPU/GPUDevice.cpp (292740 => 292741)
--- trunk/Source/WebCore/Modules/WebGPU/GPUDevice.cpp 2022-04-11 23:48:05 UTC (rev 292740)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUDevice.cpp 2022-04-12 00:04:35 UTC (rev 292741)
@@ -86,6 +86,11 @@
return GPUSupportedLimits::create(m_backing->limits());
}
+GPUQueue& GPUDevice::queue() const
+{
+return m_queue;
+}
+
void GPUDevice::destroy()
{
m_backing->destroy();
Modified: trunk/Source/WebCore/Modules/WebGPU/GPUDevice.h (292740 => 292741)
--- trunk/Source/WebCore/Modules/WebGPU/GPUDevice.h 2022-04-11 23:48:05 UTC (rev 292740)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUDevice.h 2022-04-12 00:04:35 UTC (rev 292741)
@@ -33,6 +33,7 @@
#include "GPUError.h"
#include "GPUErrorFilter.h"
#include "GPURenderPipeline.h"
+#include "GPUQueue.h"
#include "JSDOMPromiseDeferred.h"
#include "ScriptExecutionContext.h"
#include
@@ -90,6 +91,8 @@
Ref features() const;
Ref limits() const;
+GPUQueue& queue() const;
+
void destroy();
Ref createBuffer(const GPUBufferDescriptor&);
@@ -131,6 +134,7 @@
GPUDevice(ScriptExecutionContext* scriptExecutionContext, Ref&& backing)
: ActiveDOMObject { scriptExecutionContext }
,
[webkit-changes] [292740] trunk/Source/WebCore
Title: [292740] trunk/Source/WebCore
Revision 292740
Author commit-qu...@webkit.org
Date 2022-04-11 16:48:05 -0700 (Mon, 11 Apr 2022)
Log Message
[GStreamer] Debugs logs from VideoSinkCommon are missing
https://bugs.webkit.org/show_bug.cgi?id=239049
Patch by Philippe Normand on 2022-04-11
Reviewed by Adrian Perez de Castro.
When this new module was added, the logging support was lost due to missing logging category.
* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292739 => 292740)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 23:45:18 UTC (rev 292739)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 23:48:05 UTC (rev 292740)
@@ -1,3 +1,15 @@
+2022-04-11 Philippe Normand
+
+[GStreamer] Debugs logs from VideoSinkCommon are missing
+https://bugs.webkit.org/show_bug.cgi?id=239049
+
+Reviewed by Adrian Perez de Castro.
+
+When this new module was added, the logging support was lost due to missing logging category.
+
+* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
+(webKitVideoSinkSetMediaPlayerPrivate):
+
2022-04-11 Nikolaos Mouchtaris
calc(): Propogate nan for min, max, clamp, and hypot
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp (292739 => 292740)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-04-11 23:45:18 UTC (rev 292739)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-04-11 23:48:05 UTC (rev 292740)
@@ -26,8 +26,16 @@
using namespace WebCore;
+GST_DEBUG_CATEGORY(webkit_gst_video_sink_common_debug);
+#define GST_CAT_DEFAULT webkit_gst_video_sink_common_debug
+
void webKitVideoSinkSetMediaPlayerPrivate(GstElement* appSink, MediaPlayerPrivateGStreamer* player)
{
+static std::once_flag onceFlag;
+std::call_once(onceFlag, [] {
+GST_DEBUG_CATEGORY_INIT(webkit_gst_video_sink_common_debug, "webkitvideosinkcommon", 0, "WebKit Video Sink Common utilities");
+});
+
g_signal_connect(appSink, "new-sample", G_CALLBACK(+[](GstElement* sink, MediaPlayerPrivateGStreamer* player) -> GstFlowReturn {
GRefPtr sample = adoptGRef(gst_app_sink_pull_sample(GST_APP_SINK(sink)));
GstBuffer* buffer = gst_sample_get_buffer(sample.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292739] trunk/LayoutTests
Title: [292739] trunk/LayoutTests Revision 292739 Author tsav...@apple.com Date 2022-04-11 16:45:18 -0700 (Mon, 11 Apr 2022) Log Message REGRESSION (249023-249029@main): [ Monterey ] http/wpt/cache-storage/cache-storage-networkprocess-crash.html is a flaky CRASH with ASSERTION FAILED: m_pageMap.isEmpty() https://bugs.webkit.org/show_bug.cgi?id=239095 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292738 => 292739) --- trunk/LayoutTests/ChangeLog 2022-04-11 23:45:00 UTC (rev 292738) +++ trunk/LayoutTests/ChangeLog 2022-04-11 23:45:18 UTC (rev 292739) @@ -1,3 +1,12 @@ +2022-04-11 Truitt Savell + +REGRESSION (249023-249029@main): [ Monterey ] http/wpt/cache-storage/cache-storage-networkprocess-crash.html is a flaky CRASH with ASSERTION FAILED: m_pageMap.isEmpty() +https://bugs.webkit.org/show_bug.cgi?id=239095 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2022-04-11 Matteo Flores [ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292738 => 292739) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-11 23:45:00 UTC (rev 292738) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-11 23:45:18 UTC (rev 292739) @@ -1651,3 +1651,5 @@ fast/text/install-font-style-recalc.html [ Pass ] webkit.org/b/238880 [ Monterey+ Release ] imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-012.html [ Pass ImageOnlyFailure ] + +webkit.org/b/239095 http/wpt/cache-storage/cache-storage-networkprocess-crash.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292738] trunk/Source/WebKit
Title: [292738] trunk/Source/WebKit
Revision 292738
Author commit-qu...@webkit.org
Date 2022-04-11 16:45:00 -0700 (Mon, 11 Apr 2022)
Log Message
Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=239089
Patch by Alex Christensen on 2022-04-11
Reviewed by Chris Dumez.
The latter dereferences the frame loader which can be null.
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292737 => 292738)
--- trunk/Source/WebKit/ChangeLog 2022-04-11 23:39:27 UTC (rev 292737)
+++ trunk/Source/WebKit/ChangeLog 2022-04-11 23:45:00 UTC (rev 292738)
@@ -1,3 +1,16 @@
+2022-04-11 Alex Christensen
+
+Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=239089
+
+
+Reviewed by Chris Dumez.
+
+The latter dereferences the frame loader which can be null.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
+
2022-04-11 Simon Fraser
Crash under ShareableBitmap::makeCGImageCopy()
Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (292737 => 292738)
--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp 2022-04-11 23:39:27 UTC (rev 292737)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp 2022-04-11 23:45:00 UTC (rev 292738)
@@ -326,8 +326,8 @@
&& resourceLoader.frameLoader()->notifier().isInitialRequestIdentifier(identifier)
? MainFrameMainResource::Yes : MainFrameMainResource::No;
if (!page->allowsLoadFromURL(request.url(), mainFrameMainResource)) {
-RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader }] {
-resourceLoader->didFail(resourceLoader->blockedError());
+RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader }, error = blockedError(request)] {
+resourceLoader->didFail(error);
});
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292737] trunk/Source/WebKit
Title: [292737] trunk/Source/WebKit
Revision 292737
Author simon.fra...@apple.com
Date 2022-04-11 16:39:27 -0700 (Mon, 11 Apr 2022)
Log Message
Crash under ShareableBitmap::makeCGImageCopy()
https://bugs.webkit.org/show_bug.cgi?id=239085
Reviewed by Wenson Hsieh.
ShareableBitmap::create() can return null, so check it before calling makeCGImageCopy()
on the result.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292736 => 292737)
--- trunk/Source/WebKit/ChangeLog 2022-04-11 23:31:43 UTC (rev 292736)
+++ trunk/Source/WebKit/ChangeLog 2022-04-11 23:39:27 UTC (rev 292737)
@@ -1,3 +1,17 @@
+2022-04-11 Simon Fraser
+
+Crash under ShareableBitmap::makeCGImageCopy()
+https://bugs.webkit.org/show_bug.cgi?id=239085
+
+
+Reviewed by Wenson Hsieh.
+
+ShareableBitmap::create() can return null, so check it before calling makeCGImageCopy()
+on the result.
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
+
2022-04-11 Aditya Keerthi
[iOS] Ignore find interaction deprecation warnings
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (292736 => 292737)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-04-11 23:31:43 UTC (rev 292736)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-04-11 23:39:27 UTC (rev 292737)
@@ -572,7 +572,8 @@
WTF::switchOn(*m_bufferHandle,
[&] (ShareableBitmap::Handle& handle) {
ASSERT(m_type == Type::Bitmap);
-contents = bridge_id_cast(ShareableBitmap::create(handle)->makeCGImageCopy());
+if (auto bitmap = ShareableBitmap::create(handle))
+contents = bridge_id_cast(bitmap->makeCGImageCopy());
},
[&] (MachSendRight& machSendRight) {
ASSERT(m_type == Type::IOSurface);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292736] branches/safari-614.1.10-branch/
Title: [292736] branches/safari-614.1.10-branch/ Revision 292736 Author repst...@apple.com Date 2022-04-11 16:31:43 -0700 (Mon, 11 Apr 2022) Log Message New branch. Added Paths branches/safari-614.1.10-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292735] trunk/Source/WebCore/PAL
Title: [292735] trunk/Source/WebCore/PAL Revision 292735 Author mmaxfi...@apple.com Date 2022-04-11 16:28:14 -0700 (Mon, 11 Apr 2022) Log Message Sort PAL.xcodeproj. https://bugs.webkit.org/show_bug.cgi?id=239050 Reviewed by Kimmo Kinnunen. * PAL.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (292734 => 292735) --- trunk/Source/WebCore/PAL/ChangeLog 2022-04-11 23:21:34 UTC (rev 292734) +++ trunk/Source/WebCore/PAL/ChangeLog 2022-04-11 23:28:14 UTC (rev 292735) @@ -1,3 +1,12 @@ +2022-04-11 Myles C. Maxfield + +Sort PAL.xcodeproj. +https://bugs.webkit.org/show_bug.cgi?id=239050 + +Reviewed by Kimmo Kinnunen. + +* PAL.xcodeproj/project.pbxproj: + 2022-04-10 Chris Dumez Unreviewed Windows build fix after r292696. Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (292734 => 292735) --- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2022-04-11 23:21:34 UTC (rev 292734) +++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2022-04-11 23:28:14 UTC (rev 292735) @@ -1627,61 +1627,205 @@ isa = PBXHeadersBuildPhase; buildActionMask = 2147483647; files = ( -DD20DD1227BC90D60093D175 /* MediaTimeAVFoundation.h in Headers */, -DD20DD1327BC90D60093D175 /* OutputContext.h in Headers */, -DD20DD1427BC90D60093D175 /* OutputDevice.h in Headers */, +DD20DDD527BC90D70093D175 /* AccessibilitySupportSoftLink.h in Headers */, +DD20DDD627BC90D70093D175 /* AccessibilitySupportSPI.h in Headers */, +DD20DD1A27BC90D60093D175 /* AppSSOSoftLink.h in Headers */, +DD20DDD727BC90D70093D175 /* AppSSOSPI.h in Headers */, DD20DD1527BC90D60093D175 /* AudioToolboxSoftLink.h in Headers */, +DD20DDD827BC90D70093D175 /* AudioToolboxSPI.h in Headers */, +DD20DDD927BC90D70093D175 /* AuthKitSPI.h in Headers */, +DD20DDDA27BC90D70093D175 /* AVAssetWriterSPI.h in Headers */, +DD20DD1B27BC90D60093D175 /* AVFoundationSoftLink.h in Headers */, +DD20DDDB27BC90D70093D175 /* AVFoundationSPI.h in Headers */, +DD20DDDC27BC90D70093D175 /* AVKitSPI.h in Headers */, +DD2027BC90D70093D175 /* AVStreamDataParserSPI.h in Headers */, +DD20DDDE27BC90D70093D175 /* AXSpeechManagerSPI.h in Headers */, +DD20DE0F27BC90D80093D175 /* CelestialSPI.h in Headers */, +DD20DDC927BC90D70093D175 /* CFLocaleSPI.h in Headers */, +DD20DDCA27BC90D70093D175 /* CFNetworkConnectionCacheSPI.h in Headers */, +DD20DDCB27BC90D70093D175 /* CFNetworkSPI.h in Headers */, +DD20DDCC27BC90D70093D175 /* CFNotificationCenterSPI.h in Headers */, +DD20DDDF27BC90D70093D175 /* CFNSURLConnectionSPI.h in Headers */, +DD20DDCD27BC90D70093D175 /* CFUtilitiesSPI.h in Headers */, +DD20DE4827BC90D80093D175 /* Clock.h in Headers */, +DD20DE4927BC90D80093D175 /* ClockGeneric.h in Headers */, +DD20DDE027BC90D70093D175 /* CommonCryptoSPI.h in Headers */, +DD20DE6527BC90F90093D175 /* config.h in Headers */, +DD20DDCE27BC90D70093D175 /* CoreAudioSPI.h in Headers */, +DD20DDD327BC90D70093D175 /* CoreGraphicsSPI.h in Headers */, DD20DD1627BC90D60093D175 /* CoreMediaSoftLink.h in Headers */, +DD20DDCF27BC90D70093D175 /* CoreMediaSPI.h in Headers */, +DD20DD1C27BC90D60093D175 /* CoreMLSoftLink.h in Headers */, +DD20DDE127BC90D70093D175 /* CoreMotionSPI.h in Headers */, +DD20DDE227BC90D70093D175 /* CoreServicesSPI.h in Headers */, DD20DD1727BC90D60093D175 /* CoreTextSoftLink.h in Headers */, -DD20DD1827BC90D60093D175 /* OTSVGTable.h in Headers */, -DD20DD1927BC90D60093D175 /* VideoToolboxSoftLink.h in Headers */, -DD20DD1A27BC90D60093D175 /* AppSSOSoftLink.h in Headers */, -DD20DD1B27BC90D60093D175 /* AVFoundationSoftLink.h in Headers */, -DD20DD1C27BC90D60093D175 /* CoreMLSoftLink.h in Headers */, +DD20DDD027BC90D70093D175 /* CoreTextSPI.h in Headers */, +DD20DE1027BC90D80093D175 /* CoreUISPI.h in Headers */, +DD20DE1C27BC90D80093D175 /* CoreUISPI.h in Headers */, +DD20DDD127BC90D70093D175 /* CoreVideoSPI.h in Headers */, +DD20DD2727BC90D60093D175 /* CryptoDigest.h in Headers */, DD20DD1D27BC90D60093D175 /* CryptoKitPrivateSoftLink.h in Headers */, +DD20DDE327BC90D70093D175 /* CryptoKitPrivateSPI.h in Headers */, DD20DD1E27BC90D60093D175 /* DataDetectorsCoreSoftLink.h in Headers */, +DD20DDE427BC90D70093D175 /* DataDetectorsCoreSPI.h in Headers */, +DD20DDC527BC90D70093D175 /* DataDetectorsSoftLink.h in Headers */, +DD20DE1D27BC90D80093D175 /* DataDetectorsSPI.h in Headers */, +DD20DE1127BC90D80093D175 /* DataDetectorsUISPI.h in Headers */, +DD20DE4D27BC90D80093D175 /* DecodeEscapeSequences.h in Headers */, +DD20DE4427BC90D80093D175 /* DefaultSearchProvider.h in Headers */, +DD20DE4E27BC90D80093D175 /* EncodingTables.h in Headers */, +
[webkit-changes] [292734] trunk/Source
Title: [292734] trunk/Source Revision 292734 Author repst...@apple.com Date 2022-04-11 16:21:34 -0700 (Mon, 11 Apr 2022) Log Message Versioning. WebKit-7614.1.11 Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebGPU/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebGPU/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebGPU/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebGPU/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -1,6 +1,6 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 10; +TINY_VERSION = 11; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (292733 => 292734) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2022-04-11 23:20:11 UTC (rev 292733) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2022-04-11 23:21:34 UTC (rev 292734) @@ -23,7
[webkit-changes] [292733] trunk/LayoutTests
Title: [292733] trunk/LayoutTests Revision 292733 Author matteo_flo...@apple.com Date 2022-04-11 16:20:11 -0700 (Mon, 11 Apr 2022) Log Message [ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=239091 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292732 => 292733) --- trunk/LayoutTests/ChangeLog 2022-04-11 23:05:22 UTC (rev 292732) +++ trunk/LayoutTests/ChangeLog 2022-04-11 23:20:11 UTC (rev 292733) @@ -1,5 +1,15 @@ 2022-04-11 Matteo Flores +[ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure +https://bugs.webkit.org/show_bug.cgi?id=239091 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + +2022-04-11 Matteo Flores + REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures https://bugs.webkit.org/show_bug.cgi?id=238908 Modified: trunk/LayoutTests/platform/mac/TestExpectations (292732 => 292733) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-11 23:05:22 UTC (rev 292732) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-11 23:20:11 UTC (rev 292733) @@ -2236,6 +2236,8 @@ webkit.org/b/230780 [ BigSur Debug ] fast/workers/use-machine-stack.html [ Pass Crash ] +webkit.org/b/239091 http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Pass Failure ] + webkit.org/b/230862 [ BigSur ] imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html [ Pass Failure ] webkit.org/b/230984 [ BigSur Debug arm64 ] streams/readableStream-then.html [ Pass Crash ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (292732 => 292733) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-11 23:05:22 UTC (rev 292732) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-11 23:20:11 UTC (rev 292733) @@ -1600,8 +1600,6 @@ webkit.org/b/232276 imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/spin-by-blocking-style-sheet.html [ Pass Failure ] -webkit.org/b/228561 http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Pass Timeout ] - webkit.org/b/228704 imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html [ Pass Failure ] webkit.org/b/229058 imported/w3c/web-platform-tests/FileAPI/url/url-in-tags.window.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292732] trunk
Title: [292732] trunk Revision 292732 Author nmouchta...@apple.com Date 2022-04-11 16:05:22 -0700 (Mon, 11 Apr 2022) Log Message calc(): Propogate nan for min, max, clamp, and hypot https://bugs.webkit.org/show_bug.cgi?id=238974 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt: * web-platform-tests/css/css-values/calc-infinity-nan-serialize-angle-expected.txt: * web-platform-tests/css/css-values/calc-infinity-nan-serialize-length-expected.txt: * web-platform-tests/css/css-values/calc-infinity-nan-serialize-time-expected.txt: Source/WebCore: If min, max, clamp, and hypot have a NaN value we need to propagate the NaN. This has to do with the "infectious" NaN behavior the spec mentions. This patch also removes some unnecessary code in CSSCalcPrimitiveValueNode::invert() and has clamp() properly serialize. May want to separate them and expand clamp() serialization testing so it would have caught this issue. * css/calc/CSSCalcOperationNode.cpp: (WebCore::CSSCalcOperationNode::combineChildren): (WebCore::CSSCalcOperationNode::simplifyNode): (WebCore::CSSCalcOperationNode::evaluateOperator): * css/calc/CSSCalcOperationNode.h: * css/calc/CSSCalcPrimitiveValueNode.cpp: (WebCore::CSSCalcPrimitiveValueNode::invert): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-serialize-angle-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-serialize-length-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-serialize-time-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/clamp-length-serialize.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h trunk/Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292731 => 292732) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-11 22:56:48 UTC (rev 292731) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-11 23:05:22 UTC (rev 292732) @@ -1,3 +1,15 @@ +2022-04-11 Nikolaos Mouchtaris + +calc(): Propogate nan for min, max, clamp, and hypot +https://bugs.webkit.org/show_bug.cgi?id=238974 + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt: +* web-platform-tests/css/css-values/calc-infinity-nan-serialize-angle-expected.txt: +* web-platform-tests/css/css-values/calc-infinity-nan-serialize-length-expected.txt: +* web-platform-tests/css/css-values/calc-infinity-nan-serialize-time-expected.txt: + 2022-04-11 Youenn Fablet Expose more ServiceWorker interfaces to workers Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt (292731 => 292732) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt 2022-04-11 22:56:48 UTC (rev 292731) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt 2022-04-11 23:05:22 UTC (rev 292732) @@ -13,11 +13,11 @@ PASS 'calc(1px * max(0/0, 0))' as a specified value should serialize as 'calc(NaN * 1px)'. PASS 'calc(1px * min(0/0, 0))' as a specified value should serialize as 'calc(NaN * 1px)'. PASS 'calc(1px * max(0/0, min(0,10)))' as a specified value should serialize as 'calc(NaN * 1px)'. -FAIL 'calc(1px * clamp(0/0, 0, 10))' as a specified value should serialize as 'calc(NaN * 1px)'. assert_equals: 'calc(1px * clamp(0/0, 0, 10))' and 'calc(NaN * 1px)' should serialize the same in specified values. expected "calc(NaN * 1px)" but got "calc(1px * clamp(NaN, 0, 10))" -FAIL 'calc(1px * max(0, min(10, 0/0)))' as a specified value should serialize as 'calc(NaN * 1px)'. assert_equals: 'calc(1px * max(0, min(10, 0/0)))' and 'calc(NaN * 1px)' should serialize the same in specified values. expected "calc(NaN * 1px)" but got "calc(10px)" -FAIL 'calc(1px * clamp(0, 10, 0/0))' as a specified value should serialize as 'calc(NaN * 1px)'. assert_equals: 'calc(1px * clamp(0, 10, 0/0))' and 'calc(NaN * 1px)' should serialize the same in specified values. expected "calc(NaN * 1px)" but got "calc(1px * clamp(0, 10, NaN))" -FAIL 'calc(1px * max(0, min(0/0, 10)))' as a specified value should serialize as 'calc(NaN * 1px)'. assert_equals: 'calc(1px * max(0, min(0/0, 10)))' and 'calc(NaN * 1px)' should serialize the same in specified values. expected "calc(NaN * 1px)" but got "calc(0px)" -FAIL 'calc(1px * clamp(0, 0/0, 10))' as a specified value should serialize as 'calc(NaN * 1px)'. assert_equals: 'calc(1px * clamp(0, 0/0, 10))' and 'calc(NaN * 1px)'
[webkit-changes] [292731] trunk/Tools
Title: [292731] trunk/Tools
Revision 292731
Author gsnedd...@apple.com
Date 2022-04-11 15:56:48 -0700 (Mon, 11 Apr 2022)
Log Message
webkitpy.w3c.test_exporter assumes all exceptions are HTTPError
https://bugs.webkit.org/show_bug.cgi?id=238737
Reviewed by Jonathan Bedard.
This currently isn't at all easy to test, as our existing mocks for much
of this don't make it easy to throw arbitrary exceptions from given
functions.
* Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter.create_wpt_pull_request):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py
Diff
Modified: trunk/Tools/ChangeLog (292730 => 292731)
--- trunk/Tools/ChangeLog 2022-04-11 22:48:26 UTC (rev 292730)
+++ trunk/Tools/ChangeLog 2022-04-11 22:56:48 UTC (rev 292731)
@@ -1,3 +1,17 @@
+2022-04-11 Sam Sneddon
+
+webkitpy.w3c.test_exporter assumes all exceptions are HTTPError
+https://bugs.webkit.org/show_bug.cgi?id=238737
+
+Reviewed by Jonathan Bedard.
+
+This currently isn't at all easy to test, as our existing mocks for much
+of this don't make it easy to throw arbitrary exceptions from given
+functions.
+
+* Scripts/webkitpy/w3c/test_exporter.py:
+(WebPlatformTestExporter.create_wpt_pull_request):
+
2022-04-11 Sihui Liu
Fix size computation in WebCore::StorageMap
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py (292730 => 292731)
--- trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-04-11 22:48:26 UTC (rev 292730)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-04-11 22:56:48 UTC (rev 292731)
@@ -348,12 +348,15 @@
pr_number = None
try:
pr_number = self._github.create_pr(remote_branch_name, title, body)
-except Exception as e:
+except HTTPError as e:
if e.code == 422:
_log.info('Unable to create a new pull request for branch "%s" because a pull request already exists. The branch has been updated and there is no further action needed.' % (remote_branch_name))
else:
_log.warning(e)
_log.info('Error creating a pull request on github. Please ensure that the provided github token has the "public_repo" scope.')
+except Exception as e:
+_log.warning(e)
+_log.info('Error creating a pull request on github. Please ensure that the provided github token has the "public_repo" scope.')
return pr_number
def delete_local_branch(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292730] trunk/Source/WebCore
Title: [292730] trunk/Source/WebCore Revision 292730 Author drou...@apple.com Date 2022-04-11 15:48:26 -0700 (Mon, 11 Apr 2022) Log Message [Modern Media Controls] remove unnecessary `LayoutTraits` methods https://bugs.webkit.org/show_bug.cgi?id=239018 Reviewed by Eric Carlson. * Modules/modern-media-controls/controls/layout-traits.js: (LayoutTraits.prototype.knobStyleForScrubber): Deleted. (LayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. * Modules/modern-media-controls/controls/ios-layout-traits.js: (IOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. (IOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. * Modules/modern-media-controls/controls/macos-layout-traits.js: (MacOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. (MacOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. * Modules/modern-media-controls/controls/watchos-layout-traits.js: (WatchOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. (WatchOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. * Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js: (MacOSFullscreenMediaControls): * Modules/modern-media-controls/controls/macos-inline-media-controls.js: (MacOSInlineMediaControls): * Modules/modern-media-controls/controls/play-pause-button.js: (PlayPauseButton): * Modules/modern-media-controls/controls/time-control.js: (TimeControl): Remove these functions as they are much more controllable by having the `MediaControls` subclass set the related property directly. Having them be on `LayoutTraits` also makes it more difficult to handle situations where the state of the `MediaControls` influences the value given to the property (e.g. whether to use the video or audio layout). * Modules/modern-media-controls/controls/buttons-container.js: (ButtonsContainer): Expose the default value of `leftMargin`, `rightMargin`, and `buttonMargin` so that if the `MediaControls` wants to reset one of the above overrides, it doesn't need a magic number. * Modules/modern-media-controls/controls/slider.js: (Slider.prototype.get knobStyle): Added. (Slider.prototype.set knobStyle): Added. Provide a way to change the `knobStyle` after construction in case the `MediaControls` state changes. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/modern-media-controls/controls/buttons-container.js trunk/Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js trunk/Source/WebCore/Modules/modern-media-controls/controls/play-pause-button.js trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js trunk/Source/WebCore/Modules/modern-media-controls/controls/time-control.js trunk/Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js Diff Modified: trunk/Source/WebCore/ChangeLog (292729 => 292730) --- trunk/Source/WebCore/ChangeLog 2022-04-11 22:14:09 UTC (rev 292729) +++ trunk/Source/WebCore/ChangeLog 2022-04-11 22:48:26 UTC (rev 292730) @@ -1,3 +1,47 @@ +2022-04-11 Devin Rousso + +[Modern Media Controls] remove unnecessary `LayoutTraits` methods +https://bugs.webkit.org/show_bug.cgi?id=239018 + + +Reviewed by Eric Carlson. + +* Modules/modern-media-controls/controls/layout-traits.js: +(LayoutTraits.prototype.knobStyleForScrubber): Deleted. +(LayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. +* Modules/modern-media-controls/controls/ios-layout-traits.js: +(IOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. +(IOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. +* Modules/modern-media-controls/controls/macos-layout-traits.js: +(MacOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. +(MacOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. +* Modules/modern-media-controls/controls/watchos-layout-traits.js: +(WatchOSLayoutTraits.prototype.knobStyleForScrubber): Deleted. +(WatchOSLayoutTraits.prototype.playPauseButtonScaleFactor): Deleted. +* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js: +(MacOSFullscreenMediaControls): +* Modules/modern-media-controls/controls/macos-inline-media-controls.js: +(MacOSInlineMediaControls): +* Modules/modern-media-controls/controls/play-pause-button.js: +(PlayPauseButton): +* Modules/modern-media-controls/controls/time-control.js: +(TimeControl): +Remove these functions as they are much more controllable by having the `MediaControls` +subclass set the
[webkit-changes] [292729] trunk/Source/WebCore
Title: [292729] trunk/Source/WebCore
Revision 292729
Author mattwood...@apple.com
Date 2022-04-11 15:14:09 -0700 (Mon, 11 Apr 2022)
Log Message
Use unaccelerated rendering for ImageBitmapRenderingContext's placeholder image.
https://bugs.webkit.org/show_bug.cgi?id=238846
Reviewed by Simon Fraser.
This is a blank immutable image used a placeholder until a real ImageBitmap is provided, so there's
no need to allocate to allocate an accelerated IOSurface.
* html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::isAccelerated const):
(WebCore::ImageBitmapRenderingContext::setOutputBitmap):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292728 => 292729)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 22:03:54 UTC (rev 292728)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 22:14:09 UTC (rev 292729)
@@ -1,3 +1,17 @@
+2022-04-11 Matt Woodrow
+
+Use unaccelerated rendering for ImageBitmapRenderingContext's placeholder image.
+https://bugs.webkit.org/show_bug.cgi?id=238846
+
+Reviewed by Simon Fraser.
+
+This is a blank immutable image used a placeholder until a real ImageBitmap is provided, so there's
+no need to allocate to allocate an accelerated IOSurface.
+
+* html/canvas/ImageBitmapRenderingContext.cpp:
+(WebCore::ImageBitmapRenderingContext::isAccelerated const):
+(WebCore::ImageBitmapRenderingContext::setOutputBitmap):
+
2022-04-11 Jer Noble
REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure
Modified: trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp (292728 => 292729)
--- trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp 2022-04-11 22:03:54 UTC (rev 292728)
+++ trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp 2022-04-11 22:14:09 UTC (rev 292729)
@@ -36,12 +36,6 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(ImageBitmapRenderingContext);
-#if USE(IOSURFACE_CANVAS_BACKING_STORE)
-static RenderingMode bufferRenderingMode = RenderingMode::Accelerated;
-#else
-static RenderingMode bufferRenderingMode = RenderingMode::Unaccelerated;
-#endif
-
std::unique_ptr ImageBitmapRenderingContext::create(CanvasBase& canvas, ImageBitmapRenderingContextSettings&& settings)
{
auto renderingContext = std::unique_ptr(new ImageBitmapRenderingContext(canvas, WTFMove(settings)));
@@ -70,7 +64,7 @@
bool ImageBitmapRenderingContext::isAccelerated() const
{
-return bufferRenderingMode == RenderingMode::Accelerated;
+return false;
}
void ImageBitmapRenderingContext::setOutputBitmap(RefPtr imageBitmap)
@@ -95,8 +89,7 @@
// only reason I can think of is toDataURL(), but that doesn't seem like
// a good enough argument to waste memory.
-// FIXME: This needs to use RenderingPurpose::Canvas to avoid accelerated buffers in the WebContent process (webkit.org/b/238846).
-auto buffer = ImageBuffer::create(FloatSize(canvas()->width(), canvas()->height()), RenderingPurpose::Unspecified, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, bufferOptionsForRendingMode(bufferRenderingMode));
+auto buffer = ImageBuffer::create(FloatSize(canvas()->width(), canvas()->height()), RenderingPurpose::Unspecified, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, bufferOptionsForRendingMode(RenderingMode::Unaccelerated));
canvas()->setImageBufferAndMarkDirty(WTFMove(buffer));
// 1.4. Set the output bitmap's origin-clean flag to true.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292728] trunk/Source/WebGPU
Title: [292728] trunk/Source/WebGPU Revision 292728 Author mmaxfi...@apple.com Date 2022-04-11 15:03:54 -0700 (Mon, 11 Apr 2022) Log Message [WebGPU] Implement missing validity checks https://bugs.webkit.org/show_bug.cgi?id=238722 Reviewed by Kimmo Kinnunen. Now that WebGPU objects have a notion of validity, we can implement all the FIXMEs for validity checks. * WebGPU/Buffer.mm: (WebGPU::validateCreateBuffer): (WebGPU::Buffer::validateMapAsync const): * WebGPU/CommandEncoder.h: (WebGPU::CommandEncoder::makeInvalid): * WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::validateCopyBufferToBuffer): (WebGPU::validateImageCopyBuffer): (WebGPU::CommandEncoder::validateClearBuffer): (WebGPU::CommandEncoder::validateFinish const): (WebGPU::CommandEncoder::finish): (WebGPU::CommandEncoder::popDebugGroup): (WebGPU::validateCopyBufferToBuffer): Deleted. (WebGPU::validateClearBuffer): Deleted. * WebGPU/ComputePassEncoder.h: (WebGPU::ComputePassEncoder::makeInvalid): * WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::popDebugGroup): * WebGPU/ObjectBase.h: (WebGPU::ObjectBase::isValidToUseWith const): (WebGPU::ObjectBase::device const): * WebGPU/Queue.h: (WebGPU::Queue::device const): * WebGPU/Queue.mm: (WebGPU::Queue::validateSubmit const): (WebGPU::Queue::submit): (WebGPU::Queue::validateWriteBuffer const): * WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::makeInvalid): * WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::popDebugGroup): * WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::makeInvalid): * WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::popDebugGroup): * WebGPU/Sampler.mm: (WebGPU::validateCreateSampler): * WebGPU/Texture.mm: (WebGPU::Device::validateCreateTexture): (WebGPU::Device::createTexture): (WebGPU::Texture::validateCreateView const): (WebGPU::Texture::createView): (WebGPU::Texture::validateImageCopyTexture): Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU/Buffer.mm trunk/Source/WebGPU/WebGPU/CommandEncoder.h trunk/Source/WebGPU/WebGPU/CommandEncoder.mm trunk/Source/WebGPU/WebGPU/ComputePassEncoder.h trunk/Source/WebGPU/WebGPU/ComputePassEncoder.mm trunk/Source/WebGPU/WebGPU/Queue.h trunk/Source/WebGPU/WebGPU/Queue.mm trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.h trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.mm trunk/Source/WebGPU/WebGPU/RenderPassEncoder.h trunk/Source/WebGPU/WebGPU/RenderPassEncoder.mm trunk/Source/WebGPU/WebGPU/Sampler.mm trunk/Source/WebGPU/WebGPU/Texture.mm Diff Modified: trunk/Source/WebGPU/ChangeLog (292727 => 292728) --- trunk/Source/WebGPU/ChangeLog 2022-04-11 21:59:00 UTC (rev 292727) +++ trunk/Source/WebGPU/ChangeLog 2022-04-11 22:03:54 UTC (rev 292728) @@ -1,3 +1,57 @@ +2022-04-11 Myles C. Maxfield + +[WebGPU] Implement missing validity checks +https://bugs.webkit.org/show_bug.cgi?id=238722 + +Reviewed by Kimmo Kinnunen. + +Now that WebGPU objects have a notion of validity, we can implement all the +FIXMEs for validity checks. + +* WebGPU/Buffer.mm: +(WebGPU::validateCreateBuffer): +(WebGPU::Buffer::validateMapAsync const): +* WebGPU/CommandEncoder.h: +(WebGPU::CommandEncoder::makeInvalid): +* WebGPU/CommandEncoder.mm: +(WebGPU::CommandEncoder::validateCopyBufferToBuffer): +(WebGPU::validateImageCopyBuffer): +(WebGPU::CommandEncoder::validateClearBuffer): +(WebGPU::CommandEncoder::validateFinish const): +(WebGPU::CommandEncoder::finish): +(WebGPU::CommandEncoder::popDebugGroup): +(WebGPU::validateCopyBufferToBuffer): Deleted. +(WebGPU::validateClearBuffer): Deleted. +* WebGPU/ComputePassEncoder.h: +(WebGPU::ComputePassEncoder::makeInvalid): +* WebGPU/ComputePassEncoder.mm: +(WebGPU::ComputePassEncoder::popDebugGroup): +* WebGPU/ObjectBase.h: +(WebGPU::ObjectBase::isValidToUseWith const): +(WebGPU::ObjectBase::device const): +* WebGPU/Queue.h: +(WebGPU::Queue::device const): +* WebGPU/Queue.mm: +(WebGPU::Queue::validateSubmit const): +(WebGPU::Queue::submit): +(WebGPU::Queue::validateWriteBuffer const): +* WebGPU/RenderBundleEncoder.h: +(WebGPU::RenderBundleEncoder::makeInvalid): +* WebGPU/RenderBundleEncoder.mm: +(WebGPU::RenderBundleEncoder::popDebugGroup): +* WebGPU/RenderPassEncoder.h: +(WebGPU::RenderPassEncoder::makeInvalid): +* WebGPU/RenderPassEncoder.mm: +(WebGPU::RenderPassEncoder::popDebugGroup): +* WebGPU/Sampler.mm: +(WebGPU::validateCreateSampler): +* WebGPU/Texture.mm: +(WebGPU::Device::validateCreateTexture): +(WebGPU::Device::createTexture): +(WebGPU::Texture::validateCreateView const): +(WebGPU::Texture::createView): +(WebGPU::Texture::validateImageCopyTexture): +
[webkit-changes] [292727] trunk/LayoutTests
Title: [292727] trunk/LayoutTests Revision 292727 Author matteo_flo...@apple.com Date 2022-04-11 14:59:00 -0700 (Mon, 11 Apr 2022) Log Message REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures https://bugs.webkit.org/show_bug.cgi?id=238908 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Fixed expectations due to wk2 expectation Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292726 => 292727) --- trunk/LayoutTests/ChangeLog 2022-04-11 21:45:28 UTC (rev 292726) +++ trunk/LayoutTests/ChangeLog 2022-04-11 21:59:00 UTC (rev 292727) @@ -1,3 +1,12 @@ +2022-04-11 Matteo Flores + +REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures +https://bugs.webkit.org/show_bug.cgi?id=238908 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: Fixed expectations due to wk2 expectation + 2022-04-11 Jer Noble REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292726 => 292727) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-11 21:45:28 UTC (rev 292726) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-11 21:59:00 UTC (rev 292727) @@ -76,6 +76,13 @@ imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html [ DumpJSConsoleLogInStdErr ] +# webkit.org/b/238908 Global expectations for these until baselines are resolved +http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html [ Pass Failure ] +http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html [ Pass Failure ] +http/tests/paymentrequest/payment-request-change-shipping-option.https.html [ Pass Failure ] +http/tests/paymentrequest/payment-response-retry-method.https.html [ Pass Failure ] +http/tests/paymentrequest/updateWith-shippingOptions.https.html [ Pass Failure ] + # This test is failing due to lack of user activation. imported/w3c/web-platform-tests/payment-request/payment-is-showing.https.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292726] trunk/Source/WebKit
Title: [292726] trunk/Source/WebKit
Revision 292726
Author akeer...@apple.com
Date 2022-04-11 14:45:28 -0700 (Mon, 11 Apr 2022)
Log Message
[iOS] Ignore find interaction deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=239084
Unreviewed, build fix.
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setFindInteractionEnabled:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292725 => 292726)
--- trunk/Source/WebKit/ChangeLog 2022-04-11 21:42:46 UTC (rev 292725)
+++ trunk/Source/WebKit/ChangeLog 2022-04-11 21:45:28 UTC (rev 292726)
@@ -1,3 +1,13 @@
+2022-04-11 Aditya Keerthi
+
+[iOS] Ignore find interaction deprecation warnings
+https://bugs.webkit.org/show_bug.cgi?id=239084
+
+Unreviewed, build fix.
+
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(-[WKWebView _setFindInteractionEnabled:]):
+
2022-04-11 Jer Noble
REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (292725 => 292726)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-04-11 21:42:46 UTC (rev 292725)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-04-11 21:45:28 UTC (rev 292726)
@@ -3563,7 +3563,9 @@
if (enabled) {
if (!_findInteraction) {
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
_findInteraction = adoptNS([[_UIFindInteraction alloc] init]);
+ALLOW_DEPRECATED_DECLARATIONS_END
[_findInteraction setSearchableObject:[self _searchableObject]];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292725] trunk
Title: [292725] trunk
Revision 292725
Author jer.no...@apple.com
Date 2022-04-11 14:42:46 -0700 (Mon, 11 Apr 2022)
Log Message
REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure
https://bugs.webkit.org/show_bug.cgi?id=238634
Reviewed by Eric Carlson.
Source/WebCore:
Depending on whether setVideoFullscreenGravity() or updateVideoLayerGravity() is called first,
the wrong video gravity will be set. Rather than have two places where video gravity is set,
just have setVideoFullscreenGravity() set an ivar, and then call updateVideoLayerGravity(),
which will set the correct gravity based on whether fullscreen is active or not.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
Source/WebKit:
Use an `std:: bool` rather than `bool` to cache values sent to WebContent, so that
when a new value is pushed in, it's sent to WebContent the first time regardless of the default
value.
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
LayoutTests:
* platform/ios-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
Diff
Modified: trunk/LayoutTests/ChangeLog (292724 => 292725)
--- trunk/LayoutTests/ChangeLog 2022-04-11 21:33:31 UTC (rev 292724)
+++ trunk/LayoutTests/ChangeLog 2022-04-11 21:42:46 UTC (rev 292725)
@@ -1,3 +1,13 @@
+2022-04-11 Jer Noble
+
+REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure
+https://bugs.webkit.org/show_bug.cgi?id=238634
+
+
+Reviewed by Eric Carlson.
+
+* platform/ios-wk2/TestExpectations:
+
2022-04-11 Matteo Flores
webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec.html crashes
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292724 => 292725)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-11 21:33:31 UTC (rev 292724)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-11 21:42:46 UTC (rev 292725)
@@ -2246,6 +2246,4 @@
webkit.org/b/237849 imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-003.html [ ImageOnlyFailure ]
-webkit.org/b/238634 media/video-object-fit.html [ ImageOnlyFailure ]
-
fast/text/install-font-style-recalc.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (292724 => 292725)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 21:33:31 UTC (rev 292724)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 21:42:46 UTC (rev 292725)
@@ -1,3 +1,22 @@
+2022-04-11 Jer Noble
+
+REGRESSION(r292051-r292022): [ iOS ] media/video-object-fit.html is a constant image failure
+https://bugs.webkit.org/show_bug.cgi?id=238634
+
+
+Reviewed by Eric Carlson.
+
+Depending on whether setVideoFullscreenGravity() or updateVideoLayerGravity() is called first,
+the wrong video gravity will be set. Rather than have two places where video gravity is set,
+just have setVideoFullscreenGravity() set an ivar, and then call updateVideoLayerGravity(),
+which will set the correct gravity based on whether fullscreen is active or not.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
+
2022-04-11 Youenn Fablet
Expose more ServiceWorker interfaces to workers
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (292724 => 292725)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2022-04-11 21:33:31 UTC (rev 292724)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2022-04-11 21:42:46 UTC (rev 292725)
@@ -233,8 +233,11 @@
bool hasContextRenderer() const final;
bool hasLayerRenderer() const final;
-void updateVideoLayerGravity() final;
+enum class ShouldAnimate : bool { No, Yes };
+void updateVideoLayerGravity() final { updateVideoLayerGravity(ShouldAnimate::No); }
+
[webkit-changes] [292724] branches/safari-613.2.6.1-branch/Source
Title: [292724] branches/safari-613.2.6.1-branch/Source Revision 292724 Author alanc...@apple.com Date 2022-04-11 14:33:31 -0700 (Mon, 11 Apr 2022) Log Message Versioning. WebKit-7613.2.6.1.1 Modified Paths branches/safari-613.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.6.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292723 => 292724) --- branches/safari-613.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 21:22:02 UTC (rev 292723) +++ branches/safari-613.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 21:33:31 UTC (rev 292724) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292723 => 292724) --- branches/safari-613.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 21:22:02 UTC (rev 292723) +++ branches/safari-613.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 21:33:31 UTC (rev 292724) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292723 => 292724) --- branches/safari-613.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 21:22:02 UTC (rev 292723) +++ branches/safari-613.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 21:33:31 UTC (rev 292724) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig (292723 => 292724) --- branches/safari-613.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 21:22:02 UTC (rev 292723) +++ branches/safari-613.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 21:33:31 UTC (rev 292724) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292723 => 292724) --- branches/safari-613.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 21:22:02 UTC (rev 292723) +++ branches/safari-613.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 21:33:31 UTC (rev 292724) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION =
[webkit-changes] [292723] trunk/LayoutTests
Title: [292723] trunk/LayoutTests Revision 292723 Author matteo_flo...@apple.com Date 2022-04-11 14:22:02 -0700 (Mon, 11 Apr 2022) Log Message webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec.html crashes https://bugs.webkit.org/show_bug.cgi?id=237840 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292722 => 292723) --- trunk/LayoutTests/ChangeLog 2022-04-11 21:16:16 UTC (rev 292722) +++ trunk/LayoutTests/ChangeLog 2022-04-11 21:22:02 UTC (rev 292723) @@ -1,3 +1,12 @@ +2022-04-11 Matteo Flores + +webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec.html crashes +https://bugs.webkit.org/show_bug.cgi?id=237840 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2022-04-11 Youenn Fablet Expose more ServiceWorker interfaces to workers Modified: trunk/LayoutTests/platform/mac/TestExpectations (292722 => 292723) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-11 21:16:16 UTC (rev 292722) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-11 21:22:02 UTC (rev 292723) @@ -2242,6 +2242,8 @@ webkit.org/b/231757 [ BigSur ] inspector/canvas/updateShader-webgl.html [ Pass Failure ] +webkit.org/b/237840 [ Monterey ] webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec.html [ Pass Crash ] + webkit.org/b/238917 [ Monterey ] fast/text/khmer-lao-font.html [ Failure ] webkit.org/b/231924 inspector/css/modify-css-property.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292722] trunk
Title: [292722] trunk Revision 292722 Author you...@apple.com Date 2022-04-11 14:16:16 -0700 (Mon, 11 Apr 2022) Log Message Expose more ServiceWorker interfaces to workers https://bugs.webkit.org/show_bug.cgi?id=238992 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/notifications/idlharness.https.any.worker-expected.txt: * web-platform-tests/push-api/idlharness.https.any.worker-expected.txt: * web-platform-tests/service-workers/idlharness.https.any.sharedworker-expected.txt: * web-platform-tests/service-workers/idlharness.https.any.worker-expected.txt: Source/WebCore: Expose ServiceWorker, ServiceWorkerContainer and ServiceWorkerRegistration interfaces. Update task posting to support workers and shared workers. Tests: http/wpt/service-workers/serviceworker-in-dedicatedworker.https.html http/wpt/service-workers/serviceworker-in-sharedworker.https.html * workers/Worker.cpp: * workers/Worker.h: * workers/service/SWClientConnection.cpp: * workers/service/ServiceWorker.idl: * workers/service/ServiceWorkerContainer.idl: * workers/service/ServiceWorkerRegistration.idl: * workers/service/context/SWContextManager.cpp: * workers/service/context/SWContextManager.h: * workers/shared/context/SharedWorkerContextManager.cpp: * workers/shared/context/SharedWorkerContextManager.h: LayoutTests: * http/wpt/service-workers/resources/serviceworker-in-sharedworker.js: Added. * http/wpt/service-workers/resources/serviceworker-in-worker.js: Added. * http/wpt/service-workers/serviceworker-in-dedicatedworker.https-expected.txt: Added. * http/wpt/service-workers/serviceworker-in-dedicatedworker.https.html: Added. * http/wpt/service-workers/serviceworker-in-sharedworker.https-expected.txt: Added. * http/wpt/service-workers/serviceworker-in-sharedworker.https.html: Added. * platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any.worker-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any.sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any.worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/Worker.h trunk/Source/WebCore/workers/service/SWClientConnection.cpp trunk/Source/WebCore/workers/service/ServiceWorker.idl trunk/Source/WebCore/workers/service/ServiceWorkerContainer.idl trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.idl trunk/Source/WebCore/workers/service/context/SWContextManager.cpp trunk/Source/WebCore/workers/service/context/SWContextManager.h trunk/Source/WebCore/workers/shared/context/SharedWorkerContextManager.cpp trunk/Source/WebCore/workers/shared/context/SharedWorkerContextManager.h Added Paths trunk/LayoutTests/http/wpt/service-workers/resources/serviceworker-in-sharedworker.js trunk/LayoutTests/http/wpt/service-workers/resources/serviceworker-in-worker.js trunk/LayoutTests/http/wpt/service-workers/serviceworker-in-dedicatedworker.https-expected.txt trunk/LayoutTests/http/wpt/service-workers/serviceworker-in-dedicatedworker.https.html trunk/LayoutTests/http/wpt/service-workers/serviceworker-in-sharedworker.https-expected.txt trunk/LayoutTests/http/wpt/service-workers/serviceworker-in-sharedworker.https.html trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any.worker-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (292721 => 292722) --- trunk/LayoutTests/ChangeLog 2022-04-11 20:59:13 UTC (rev 292721) +++ trunk/LayoutTests/ChangeLog 2022-04-11 21:16:16 UTC (rev 292722) @@ -1,3 +1,18 @@ +2022-04-11 Youenn Fablet + +Expose more ServiceWorker interfaces to workers +https://bugs.webkit.org/show_bug.cgi?id=238992 + +Reviewed by Chris Dumez. + +* http/wpt/service-workers/resources/serviceworker-in-sharedworker.js: Added. +* http/wpt/service-workers/resources/serviceworker-in-worker.js: Added. +* http/wpt/service-workers/serviceworker-in-dedicatedworker.https-expected.txt: Added. +* http/wpt/service-workers/serviceworker-in-dedicatedworker.https.html: Added. +* http/wpt/service-workers/serviceworker-in-sharedworker.https-expected.txt: Added. +* http/wpt/service-workers/serviceworker-in-sharedworker.https.html: Added. +* platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any.worker-expected.txt: + 2022-04-11 Matteo Flores REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures Added:
[webkit-changes] [292721] trunk
Title: [292721] trunk
Revision 292721
Author sihui_...@apple.com
Date 2022-04-11 13:59:13 -0700 (Mon, 11 Apr 2022)
Log Message
Fix size computation in WebCore::StorageMap
https://bugs.webkit.org/show_bug.cgi?id=239024
rdar://88249235
Reviewed by Chris Dumez.
Source/WebCore:
We use currentSize to track size for StorageMap. There are a few issues in current implementation that can make
currentSize incorrect and may lead to overflow:
1. When computing size of key, StorageMap uses parameter key instead of stored key. The problem is that
two Strings can be evaluated to equal while their sizeInBytes() value is different, when one String is 8-bit and
the other is 16-bit. That means removeItem() may decrease currentSize by wrong number (e.g setItem() with an
8-bit key, converting the key to 16-bit, removeItem() with the key). To fix this, StorageMap now always uses
stored key for computation.
2. When map.take(key) or map.get(key) returns null string, StorageMap takes it as the key does not exist and
will not correctly update currentSize, but user of WebCore::StorageMap may store null string as value. To fix
this, StorageMap now check if key exists with find() function.
3. StorageMap only uses CheckedUint32 in setItem(), but removeItem() and importItem() may cause overflow in
currentSize as mentioned above, and the error will not be caught until setItem() is called. To fix this,
StorageMap now uses CheckedUint32 in all places that update currentSize.
New test: WKWebView.LocalStorageNoSizeOverflow
* storage/StorageMap.cpp:
(WebCore::StorageMap::setItem):
(WebCore::StorageMap::removeItem):
(WebCore::StorageMap::importItems):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
(TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageMap.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (292720 => 292721)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 20:49:06 UTC (rev 292720)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 20:59:13 UTC (rev 292721)
@@ -1,3 +1,32 @@
+2022-04-11 Sihui Liu
+
+Fix size computation in WebCore::StorageMap
+https://bugs.webkit.org/show_bug.cgi?id=239024
+rdar://88249235
+
+Reviewed by Chris Dumez.
+
+We use currentSize to track size for StorageMap. There are a few issues in current implementation that can make
+currentSize incorrect and may lead to overflow:
+1. When computing size of key, StorageMap uses parameter key instead of stored key. The problem is that
+two Strings can be evaluated to equal while their sizeInBytes() value is different, when one String is 8-bit and
+the other is 16-bit. That means removeItem() may decrease currentSize by wrong number (e.g setItem() with an
+8-bit key, converting the key to 16-bit, removeItem() with the key). To fix this, StorageMap now always uses
+stored key for computation.
+2. When map.take(key) or map.get(key) returns null string, StorageMap takes it as the key does not exist and
+will not correctly update currentSize, but user of WebCore::StorageMap may store null string as value. To fix
+this, StorageMap now check if key exists with find() function.
+3. StorageMap only uses CheckedUint32 in setItem(), but removeItem() and importItem() may cause overflow in
+currentSize as mentioned above, and the error will not be caught until setItem() is called. To fix this,
+StorageMap now uses CheckedUint32 in all places that update currentSize.
+
+New test: WKWebView.LocalStorageNoSizeOverflow
+
+* storage/StorageMap.cpp:
+(WebCore::StorageMap::setItem):
+(WebCore::StorageMap::removeItem):
+(WebCore::StorageMap::importItems):
+
2022-04-11 Yusuke Suzuki
[JSC] Reduce use of unnecessary cryptographicallyRandom numbers
Modified: trunk/Source/WebCore/storage/StorageMap.cpp (292720 => 292721)
--- trunk/Source/WebCore/storage/StorageMap.cpp 2022-04-11 20:49:06 UTC (rev 292720)
+++ trunk/Source/WebCore/storage/StorageMap.cpp 2022-04-11 20:59:13 UTC (rev 292721)
@@ -88,30 +88,29 @@
void StorageMap::setItem(const String& key, const String& value, String& oldValue, bool& quotaException)
{
ASSERT(!value.isNull());
+
quotaException = false;
-
-// Implement copy-on-write semantics.
-if (m_impl->refCount() > 1)
-m_impl = m_impl->copy();
-
-oldValue = m_impl->map.get(key);
-
-// Quota tracking. This is done in a couple of steps to keep the overflow tracking simple.
CheckedUint32 newSize = m_impl->currentSize;
-newSize -= oldValue.sizeInBytes();
+auto iter = m_impl->map.find(key);
+if (iter != m_impl->map.end()) {
+oldValue = iter->value;
+newSize -= oldValue.sizeInBytes();
+} else {
+oldValue = nullString();
+newSize +=
[webkit-changes] [292720] trunk/LayoutTests
Title: [292720] trunk/LayoutTests Revision 292720 Author matteo_flo...@apple.com Date 2022-04-11 13:49:06 -0700 (Mon, 11 Apr 2022) Log Message REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures https://bugs.webkit.org/show_bug.cgi?id=238908 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292719 => 292720) --- trunk/LayoutTests/ChangeLog 2022-04-11 20:19:32 UTC (rev 292719) +++ trunk/LayoutTests/ChangeLog 2022-04-11 20:49:06 UTC (rev 292720) @@ -1,3 +1,12 @@ +2022-04-11 Matteo Flores + +REBASLINE: [ Monterey wk2 ] 4 http/tests/inspector/paymentrequest/* tests are constant text failures +https://bugs.webkit.org/show_bug.cgi?id=238908 + +Unreviewed test gardening. + +* TestExpectations: + 2022-04-11 Andres Gonzalez Rewrite accessibility/table-modification-crash.html to test that the AX tree reflects the changes made to the table rows. Modified: trunk/LayoutTests/TestExpectations (292719 => 292720) --- trunk/LayoutTests/TestExpectations 2022-04-11 20:19:32 UTC (rev 292719) +++ trunk/LayoutTests/TestExpectations 2022-04-11 20:49:06 UTC (rev 292720) @@ -2942,6 +2942,13 @@ webkit.org/b/169625 imported/w3c/web-platform-tests/cors/status.htm [ Pass Failure ] +# webkit.org/b/238908 Global expectations for these until baselines are resolved +http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html [ Pass Failure ] +http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html [ Pass Failure ] +http/tests/paymentrequest/payment-request-change-shipping-option.https.html [ Pass Failure ] +http/tests/paymentrequest/payment-response-retry-method.https.html [ Pass Failure ] +http/tests/paymentrequest/updateWith-shippingOptions.https.html [ Pass Failure ] + webkit.org/b/170130 fast/events/before-unload-adopt-subframe-to-outside.html [ Pass Timeout ] webkit.org/b/170355 [ Release ] fast/mediastream/MediaStream-page-muted.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292718] branches/safari-613.2.6.2-branch/
Title: [292718] branches/safari-613.2.6.2-branch/ Revision 292718 Author repst...@apple.com Date 2022-04-11 13:19:26 -0700 (Mon, 11 Apr 2022) Log Message New branch. Added Paths branches/safari-613.2.6.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292717] branches/safari-613.2.6.1-branch/
Title: [292717] branches/safari-613.2.6.1-branch/ Revision 292717 Author repst...@apple.com Date 2022-04-11 13:19:20 -0700 (Mon, 11 Apr 2022) Log Message New branch. Added Paths branches/safari-613.2.6.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292719] branches/safari-613.2.6.3-branch/
Title: [292719] branches/safari-613.2.6.3-branch/ Revision 292719 Author repst...@apple.com Date 2022-04-11 13:19:32 -0700 (Mon, 11 Apr 2022) Log Message New branch. Added Paths branches/safari-613.2.6.3-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292716] branches/safari-613.2.6.0-branch/
Title: [292716] branches/safari-613.2.6.0-branch/ Revision 292716 Author repst...@apple.com Date 2022-04-11 13:19:13 -0700 (Mon, 11 Apr 2022) Log Message New branch. Added Paths branches/safari-613.2.6.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292715] trunk/Source/WebKit
Title: [292715] trunk/Source/WebKit Revision 292715 Author wenson_hs...@apple.com Date 2022-04-11 13:18:49 -0700 (Mon, 11 Apr 2022) Log Message REGRESSION (r289785): [iOS] Unable to double-click to select a word in a received email https://bugs.webkit.org/show_bug.cgi?id=239055 rdar://90736710 Reviewed by Tim Horton. Following r289785, double-clicking text in Mail message viewer on iOS (or more generally, any web view in an app that does not have the "UIApplicationSupportsIndirectInputEvents" application plist key set to `YES`) produces a selection that is immediately removed. This is because after double clicking, the synthetic click gesture fires and immediately clears the selection. In Safari (an application that sets UIApplicationSupportsIndirectInputEvents), the non-pointer gesture recognizers (e.g. synthetic taps) don't fire because the type of the `UITouch` is `UITouchTypeIndirectPointer`, which allows us to return `NO` from `-gestureRecognizer:shouldReceiveTouch:` for anything that is not the mouse gesture recognizer's current mouse touch. For apps that lack this plist key, the touch type remains `UITouchTypeDirect` to avoid breaking compatibility, even for events that are generated via a pointing device (i.e. trackpad). This means that we no longer route these events solely to the mouse gesture recognizer. To fix this, use `-_isPointerTouch` instead of `-[UITouch type]` here. Unlike the latter, the former isn't affected by the "supports indirect input" plist key. * Platform/spi/ios/UIKitSPI.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView gestureRecognizer:shouldReceiveTouch:]): * UIProcess/ios/WKMouseGestureRecognizer.mm: (-[WKMouseGestureRecognizer _shouldReceiveTouch:forEvent:recognizerView:]): Also fix a similar bug here, where the check against `UITouchTypeIndirectPointer` instead of `-_isPointerEvent` causes apps without the UIApplicationSupportsIndirectInputEvents key to lose the ability to listen for mousedown and mouseup events when the user clicks via trackpad on iPad. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm Diff Modified: trunk/Source/WebKit/ChangeLog (292714 => 292715) --- trunk/Source/WebKit/ChangeLog 2022-04-11 20:10:44 UTC (rev 292714) +++ trunk/Source/WebKit/ChangeLog 2022-04-11 20:18:49 UTC (rev 292715) @@ -1,3 +1,36 @@ +2022-04-11 Wenson Hsieh + +REGRESSION (r289785): [iOS] Unable to double-click to select a word in a received email +https://bugs.webkit.org/show_bug.cgi?id=239055 +rdar://90736710 + +Reviewed by Tim Horton. + +Following r289785, double-clicking text in Mail message viewer on iOS (or more generally, any web view in an app +that does not have the "UIApplicationSupportsIndirectInputEvents" application plist key set to `YES`) produces a +selection that is immediately removed. This is because after double clicking, the synthetic click gesture fires +and immediately clears the selection. + +In Safari (an application that sets UIApplicationSupportsIndirectInputEvents), the non-pointer gesture +recognizers (e.g. synthetic taps) don't fire because the type of the `UITouch` is `UITouchTypeIndirectPointer`, +which allows us to return `NO` from `-gestureRecognizer:shouldReceiveTouch:` for anything that is not the mouse +gesture recognizer's current mouse touch. + +For apps that lack this plist key, the touch type remains `UITouchTypeDirect` to avoid breaking compatibility, +even for events that are generated via a pointing device (i.e. trackpad). This means that we no longer route +these events solely to the mouse gesture recognizer. To fix this, use `-_isPointerTouch` instead of +`-[UITouch type]` here. Unlike the latter, the former isn't affected by the "supports indirect input" plist key. + +* Platform/spi/ios/UIKitSPI.h: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView gestureRecognizer:shouldReceiveTouch:]): +* UIProcess/ios/WKMouseGestureRecognizer.mm: +(-[WKMouseGestureRecognizer _shouldReceiveTouch:forEvent:recognizerView:]): + +Also fix a similar bug here, where the check against `UITouchTypeIndirectPointer` instead of `-_isPointerEvent` +causes apps without the UIApplicationSupportsIndirectInputEvents key to lose the ability to listen for mousedown +and mouseup events when the user clicks via trackpad on iPad. + 2022-04-11 J Pascoe [WebAuthn] Ensure requestPin callback on main thread Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (292714 => 292715) --- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-04-11 20:10:44 UTC (rev 292714) +++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-04-11 20:18:49 UTC (rev
[webkit-changes] [292714] trunk/Source
Title: [292714] trunk/Source
Revision 292714
Author ysuz...@apple.com
Date 2022-04-11 13:10:44 -0700 (Mon, 11 Apr 2022)
Log Message
[JSC] Reduce use of unnecessary cryptographicallyRandom numbers
https://bugs.webkit.org/show_bug.cgi?id=239026
Reviewed by Saam Barati.
Source/_javascript_Core:
This patch removes cryptographically random calls in some of super hot critical path.
MarkedBlock's use is very hot and it appears on Speedometer2 artrace. But this is just
a random shuffling of freelist, and WeakRandom is enough for that. This patch replaces
them with WeakRandom. It offers 0.3% improvement in Speedometer2.
* assembler/AbstractMacroAssembler.cpp:
(JSC::AbstractMacroAssemblerBase::initializeRandom):
(WTF::printInternal):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssemblerBase::random):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::random): Deleted.
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::Code):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::weakRandom): Deleted.
* heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::specializedSweep):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
(JSC::VM::heapRandom):
Source/WebCore:
We use createVersion4UUIDStringWeak since there is no need to use cryptographically random numbers for KeyframeEffect names.
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
Source/WTF:
We add createVersion4UUIDStringWeak, which can generate UUID with WeakRandom numbers.
* wtf/UUID.cpp:
(WTF::convertRandomUInt128ToUUIDVersion4):
(WTF::generateCryptographicallyRandomUUIDVersion4):
(WTF::generateWeakRandomUUIDVersion4):
(WTF::UUID::UUID):
(WTF::createVersion4UUIDStringWeak):
* wtf/UUID.h:
* wtf/WeakRandom.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.cpp
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/b3/air/AirCode.cpp
trunk/Source/_javascript_Core/b3/air/AirCode.h
trunk/Source/_javascript_Core/heap/MarkedBlockInlines.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/UUID.cpp
trunk/Source/WTF/wtf/UUID.h
trunk/Source/WTF/wtf/WeakRandom.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292713 => 292714)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-11 20:04:18 UTC (rev 292713)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-11 20:10:44 UTC (rev 292714)
@@ -1,5 +1,35 @@
2022-04-11 Yusuke Suzuki
+[JSC] Reduce use of unnecessary cryptographicallyRandom numbers
+https://bugs.webkit.org/show_bug.cgi?id=239026
+
+Reviewed by Saam Barati.
+
+This patch removes cryptographically random calls in some of super hot critical path.
+MarkedBlock's use is very hot and it appears on Speedometer2 artrace. But this is just
+a random shuffling of freelist, and WeakRandom is enough for that. This patch replaces
+them with WeakRandom. It offers 0.3% improvement in Speedometer2.
+
+* assembler/AbstractMacroAssembler.cpp:
+(JSC::AbstractMacroAssemblerBase::initializeRandom):
+(WTF::printInternal):
+* assembler/AbstractMacroAssembler.h:
+(JSC::AbstractMacroAssemblerBase::random):
+(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
+(JSC::AbstractMacroAssembler::random): Deleted.
+* b3/air/AirCode.cpp:
+(JSC::B3::Air::Code::Code):
+* b3/air/AirCode.h:
+(JSC::B3::Air::Code::weakRandom): Deleted.
+* heap/MarkedBlockInlines.h:
+(JSC::MarkedBlock::Handle::specializedSweep):
+* runtime/VM.cpp:
+(JSC::VM::VM):
+* runtime/VM.h:
+(JSC::VM::heapRandom):
+
+2022-04-11 Yusuke Suzuki
+
Unreviewed, use std::forward instead of WTFMove since it becomes template typename Vector&&
https://bugs.webkit.org/show_bug.cgi?id=239025
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.cpp (292713 => 292714)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.cpp 2022-04-11 20:04:18 UTC (rev 292713)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.cpp 2022-04-11 20:10:44 UTC (rev 292714)
@@ -30,17 +30,31 @@
#include
+namespace JSC {
+
+void AbstractMacroAssemblerBase::initializeRandom()
+{
+// No strong cryptographic characteristics are necessary.
+static std::once_flag onceKey;
+static uint32_t globalCounter;
+std::call_once(onceKey, [&] {
+globalCounter = cryptographicallyRandomNumber();
+});
+ASSERT(!m_randomSource);
+m_randomSource.emplace(globalCounter++);
+}
+
+}
+
namespace WTF {
[webkit-changes] [292713] trunk/Source/JavaScriptCore
Title: [292713] trunk/Source/_javascript_Core Revision 292713 Author ysuz...@apple.com Date 2022-04-11 13:04:18 -0700 (Mon, 11 Apr 2022) Log Message Unreviewed, use std::forward instead of WTFMove since it becomes template typename Vector&& https://bugs.webkit.org/show_bug.cgi?id=239025 * bytecode/ObjectPropertyConditionSet.h: (JSC::ObjectPropertyConditionSet::create): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/ObjectPropertyConditionSet.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (292712 => 292713) --- trunk/Source/_javascript_Core/ChangeLog 2022-04-11 19:02:22 UTC (rev 292712) +++ trunk/Source/_javascript_Core/ChangeLog 2022-04-11 20:04:18 UTC (rev 292713) @@ -1,3 +1,11 @@ +2022-04-11 Yusuke Suzuki + +Unreviewed, use std::forward instead of WTFMove since it becomes template typename Vector&& +https://bugs.webkit.org/show_bug.cgi?id=239025 + +* bytecode/ObjectPropertyConditionSet.h: +(JSC::ObjectPropertyConditionSet::create): + 2022-04-10 Chris Dumez Unreviewed WatchOS build fix. Modified: trunk/Source/_javascript_Core/bytecode/ObjectPropertyConditionSet.h (292712 => 292713) --- trunk/Source/_javascript_Core/bytecode/ObjectPropertyConditionSet.h 2022-04-11 19:02:22 UTC (rev 292712) +++ trunk/Source/_javascript_Core/bytecode/ObjectPropertyConditionSet.h 2022-04-11 20:04:18 UTC (rev 292713) @@ -62,7 +62,7 @@ return ObjectPropertyConditionSet(); ObjectPropertyConditionSet result; -result.m_data = Conditions::createFromVector(WTFMove(vector)); +result.m_data = Conditions::createFromVector(std::forward(vector)); ASSERT(result.isValid()); return result; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292712] trunk
Title: [292712] trunk
Revision 292712
Author wenson_hs...@apple.com
Date 2022-04-11 12:02:22 -0700 (Mon, 11 Apr 2022)
Log Message
[Mail Compose] Preserve attachment identifiers when cloning attachment-backed images
https://bugs.webkit.org/show_bug.cgi?id=239040
rdar://91527065
Reviewed by Aditya Keerthi.
Source/WebCore:
Override HTMLImageElement's `cloneElementWithoutAttributesAndChildren` method so that it additionally clones the
attachment element underneath the original image element, if it exists. This ensures that an image element that
is copied from existing attachment-backed images using `cloneNode` will contain an `attachment` in its shadow
root that points to the same `_WKAttachment` in the embedding client.
Test: WKAttachmentTests.CloneImageWithAttachment
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::cloneElementWithoutAttributesAndChildren):
* html/HTMLImageElement.h:
Tools:
Add an API test to exercise the change.
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLImageElement.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (292711 => 292712)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 16:47:10 UTC (rev 292711)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 19:02:22 UTC (rev 292712)
@@ -1,3 +1,22 @@
+2022-04-11 Wenson Hsieh
+
+[Mail Compose] Preserve attachment identifiers when cloning attachment-backed images
+https://bugs.webkit.org/show_bug.cgi?id=239040
+rdar://91527065
+
+Reviewed by Aditya Keerthi.
+
+Override HTMLImageElement's `cloneElementWithoutAttributesAndChildren` method so that it additionally clones the
+attachment element underneath the original image element, if it exists. This ensures that an image element that
+is copied from existing attachment-backed images using `cloneNode` will contain an `attachment` in its shadow
+root that points to the same `_WKAttachment` in the embedding client.
+
+Test: WKAttachmentTests.CloneImageWithAttachment
+
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::cloneElementWithoutAttributesAndChildren):
+* html/HTMLImageElement.h:
+
2022-04-11 Nikolas Zimmermann
[LBSE] Activate SVG transform support through layers
Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (292711 => 292712)
--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2022-04-11 16:47:10 UTC (rev 292711)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2022-04-11 19:02:22 UTC (rev 292712)
@@ -948,4 +948,17 @@
invalidateStyle();
}
+Ref HTMLImageElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
+{
+auto clone = create(targetDocument);
+#if ENABLE(ATTACHMENT_ELEMENT)
+if (auto attachment = attachmentElement()) {
+auto attachmentClone = attachment->cloneElementWithoutChildren(targetDocument);
+RELEASE_ASSERT(is(attachmentClone));
+clone->setAttachmentElement(downcast(attachmentClone.get()));
+}
+#endif
+return clone;
}
+
+}
Modified: trunk/Source/WebCore/html/HTMLImageElement.h (292711 => 292712)
--- trunk/Source/WebCore/html/HTMLImageElement.h 2022-04-11 16:47:10 UTC (rev 292711)
+++ trunk/Source/WebCore/html/HTMLImageElement.h 2022-04-11 19:02:22 UTC (rev 292712)
@@ -165,6 +165,8 @@
void collectExtraStyleForPresentationalHints(MutableStyleProperties&) override;
void invalidateAttributeMapping();
+Ref cloneElementWithoutAttributesAndChildren(Document& targetDocument) final;
+
// ActiveDOMObject.
const char* activeDOMObjectName() const final;
bool virtualHasPendingActivity() const final;
Modified: trunk/Tools/ChangeLog (292711 => 292712)
--- trunk/Tools/ChangeLog 2022-04-11 16:47:10 UTC (rev 292711)
+++ trunk/Tools/ChangeLog 2022-04-11 19:02:22 UTC (rev 292712)
@@ -1,3 +1,16 @@
+2022-04-11 Wenson Hsieh
+
+[Mail Compose] Preserve attachment identifiers when cloning attachment-backed images
+https://bugs.webkit.org/show_bug.cgi?id=239040
+rdar://91527065
+
+Reviewed by Aditya Keerthi.
+
+Add an API test to exercise the change.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+(TestWebKitAPI::TEST):
+
2022-04-11 Andres Gonzalez
TestRunner’s calls to [WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:] need to be dispatch to the AX secondary thread.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (292711 => 292712)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2022-04-11 16:47:10 UTC (rev 292711)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2022-04-11 19:02:22 UTC (rev 292712)
@@ -1632,6 +1632,30 @@
[webkit-changes] [292711] branches/safari-614.1.9-branch/Source
Title: [292711] branches/safari-614.1.9-branch/Source Revision 292711 Author repst...@apple.com Date 2022-04-11 09:47:10 -0700 (Mon, 11 Apr 2022) Log Message Versioning. WebKit-7614.1.9.3 Modified Paths branches/safari-614.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.9-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/WebCore/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/WebGPU/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (292710 => 292711) --- branches/safari-614.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-11 16:18:54 UTC (rev 292710) +++ branches/safari-614.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-11 16:47:10 UTC (rev 292711) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 2; +MICRO_VERSION = 3;
[webkit-changes] [292710] trunk/Source/WebKit
Title: [292710] trunk/Source/WebKit
Revision 292710
Author j_pas...@apple.com
Date 2022-04-11 09:18:54 -0700 (Mon, 11 Apr 2022)
Log Message
[WebAuthn] Ensure requestPin callback on main thread
https://bugs.webkit.org/show_bug.cgi?id=238962
rdar://problem/91446051
Reviewed by Brent Fulgham.
This callback gets called by a non-main thread when making calls via
ASA. This patch uses ensureOnMainThread to ensure the completion handler
is called on the main thread. It also upgrades the callback asserts to
RELEASE_ASSERTs to avoid this issue in the future.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::getAssertion):
* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::requestPin const):
* UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::continueRequestPinAfterGetKeyAgreement):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292709 => 292710)
--- trunk/Source/WebKit/ChangeLog 2022-04-11 16:13:37 UTC (rev 292709)
+++ trunk/Source/WebKit/ChangeLog 2022-04-11 16:18:54 UTC (rev 292710)
@@ -1,3 +1,24 @@
+2022-04-11 J Pascoe
+
+[WebAuthn] Ensure requestPin callback on main thread
+https://bugs.webkit.org/show_bug.cgi?id=238962
+rdar://problem/91446051
+
+Reviewed by Brent Fulgham.
+
+This callback gets called by a non-main thread when making calls via
+ASA. This patch uses ensureOnMainThread to ensure the completion handler
+is called on the main thread. It also upgrades the callback asserts to
+RELEASE_ASSERTs to avoid this issue in the future.
+
+* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+(WebKit::LocalAuthenticator::getAssertion):
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
+(WebKit::WebAuthenticationPanelClient::requestPin const):
+* UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
+(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):
+(WebKit::CtapAuthenticator::continueRequestPinAfterGetKeyAgreement):
+
2022-04-10 Chris Dumez
Unreviewed Windows build fix after r292696.
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (292709 => 292710)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-04-11 16:13:37 UTC (rev 292709)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-04-11 16:18:54 UTC (rev 292710)
@@ -544,7 +544,7 @@
if (auto* observer = this->observer()) {
auto callback = [this, weakThis = WeakPtr { *this }] (AuthenticatorAssertionResponse* response) {
-ASSERT(RunLoop::isMain());
+RELEASE_ASSERT(RunLoop::isMain());
if (!weakThis)
return;
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm (292709 => 292710)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm 2022-04-11 16:13:37 UTC (rev 292709)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm 2022-04-11 16:18:54 UTC (rev 292710)
@@ -131,10 +131,12 @@
auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector(panel:requestPINWithRemainingRetries:completionHandler:));
[delegate panel:m_panel requestPINWithRemainingRetries:retries completionHandler:makeBlockPtr([completionHandler = WTFMove(completionHandler), checker = WTFMove(checker)](NSString *pin) mutable {
-if (checker->completionHandlerHasBeenCalled())
-return;
-checker->didCallCompletionHandler();
-completionHandler(pin);
+ensureOnMainThread([completionHandler = WTFMove(completionHandler), checker = WTFMove(checker), pin = retainPtr(pin)] () mutable {
+if (checker->completionHandlerHasBeenCalled())
+return;
+checker->didCallCompletionHandler();
+completionHandler(pin.get());
+});
}).get()];
}
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp (292709 => 292710)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp 2022-04-11 16:13:37 UTC (rev 292709)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp 2022-04-11 16:18:54 UTC (rev 292710)
@@ -210,7 +210,7 @@
if (!m_remainingAssertionResponses) {
if (auto* observer = this->observer()) {
[webkit-changes] [292709] tags/WebKit-7614.1.9.2/
Title: [292709] tags/WebKit-7614.1.9.2/ Revision 292709 Author repst...@apple.com Date 2022-04-11 09:13:37 -0700 (Mon, 11 Apr 2022) Log Message Tag WebKit-7614.1.9.2. Added Paths tags/WebKit-7614.1.9.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292708] trunk/LayoutTests
Title: [292708] trunk/LayoutTests Revision 292708 Author andresg...@apple.com Date 2022-04-11 08:32:20 -0700 (Mon, 11 Apr 2022) Log Message Rewrite accessibility/table-modification-crash.html to test that the AX tree reflects the changes made to the table rows. https://bugs.webkit.org/show_bug.cgi?id=239013 Reviewed by Darin Adler. Renamed and rewrote this test to actually test more than just that it doesn't crash. Now we check that the AX tree reflects the changes of adding and removing table rows. * accessibility/table-add-remove-row-expected.txt: Added. * accessibility/table-add-remove-row.html: Added. * accessibility/table-modification-crash-expected.txt: Removed. * accessibility/table-modification-crash.html: Removed. * platform/glib/accessibility/table-add-remove-row-expected.txt: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Added Paths trunk/LayoutTests/accessibility/table-add-remove-row-expected.txt trunk/LayoutTests/accessibility/table-add-remove-row.html trunk/LayoutTests/platform/glib/accessibility/table-add-remove-row-expected.txt Removed Paths trunk/LayoutTests/accessibility/table-modification-crash-expected.txt trunk/LayoutTests/accessibility/table-modification-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (292707 => 292708) --- trunk/LayoutTests/ChangeLog 2022-04-11 13:43:57 UTC (rev 292707) +++ trunk/LayoutTests/ChangeLog 2022-04-11 15:32:20 UTC (rev 292708) @@ -1,3 +1,22 @@ +2022-04-11 Andres Gonzalez + +Rewrite accessibility/table-modification-crash.html to test that the AX tree reflects the changes made to the table rows. +https://bugs.webkit.org/show_bug.cgi?id=239013 + + +Reviewed by Darin Adler. + +Renamed and rewrote this test to actually test more than just that it +doesn't crash. Now we check that the AX tree reflects the changes of +adding and removing table rows. + +* accessibility/table-add-remove-row-expected.txt: Added. +* accessibility/table-add-remove-row.html: Added. +* accessibility/table-modification-crash-expected.txt: Removed. +* accessibility/table-modification-crash.html: Removed. +* platform/glib/accessibility/table-add-remove-row-expected.txt: +* platform/win/TestExpectations: + 2022-04-10 Tyler Wilcock Fix accessibility/aria-invalid.html in isolated tree mode Added: trunk/LayoutTests/accessibility/table-add-remove-row-expected.txt (0 => 292708) --- trunk/LayoutTests/accessibility/table-add-remove-row-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/table-add-remove-row-expected.txt 2022-04-11 15:32:20 UTC (rev 292708) @@ -0,0 +1,12 @@ +Original number of rows: 1 +firstRow +Number of rows after appending 1 row: 2 +firstRow +secondRow +Number of rows after removing first row: 1 +secondRow + +PASS successfullyParsed is true + +TEST COMPLETE +d e f Added: trunk/LayoutTests/accessibility/table-add-remove-row.html (0 => 292708) --- trunk/LayoutTests/accessibility/table-add-remove-row.html (rev 0) +++ trunk/LayoutTests/accessibility/table-add-remove-row.html 2022-04-11 15:32:20 UTC (rev 292708) @@ -0,0 +1,61 @@ + + + + + ++
+ ++ a b c