[webkit-changes] [292856] trunk
Title: [292856] trunk
Revision 292856
Author commit-qu...@webkit.org
Date 2022-04-13 21:38:41 -0700 (Wed, 13 Apr 2022)
Log Message
Punycode encode U+15AF when not in context of other Canadian aboriginal code points
https://bugs.webkit.org/show_bug.cgi?id=239316
Patch by Alex Christensen on 2022-04-13
Reviewed by Darin Adler.
Source/WTF:
* wtf/URLHelpers.cpp:
(WTF::URLHelpers::isLookalikeCharacterOfScriptType):
(WTF::URLHelpers::isLookalikeCharacter):
Tools:
* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URLHelpers.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (292855 => 292856)
--- trunk/Source/WTF/ChangeLog 2022-04-14 03:56:58 UTC (rev 292855)
+++ trunk/Source/WTF/ChangeLog 2022-04-14 04:38:41 UTC (rev 292856)
@@ -1,3 +1,15 @@
+2022-04-13 Alex Christensen
+
+Punycode encode U+15AF when not in context of other Canadian aboriginal code points
+https://bugs.webkit.org/show_bug.cgi?id=239316
+
+
+Reviewed by Darin Adler.
+
+* wtf/URLHelpers.cpp:
+(WTF::URLHelpers::isLookalikeCharacterOfScriptType):
+(WTF::URLHelpers::isLookalikeCharacter):
+
2022-04-13 Chris Dumez
Drop unused AtomString(const LChar*) constructor
Modified: trunk/Source/WTF/wtf/URLHelpers.cpp (292855 => 292856)
--- trunk/Source/WTF/wtf/URLHelpers.cpp 2022-04-14 03:56:58 UTC (rev 292855)
+++ trunk/Source/WTF/wtf/URLHelpers.cpp 2022-04-14 04:38:41 UTC (rev 292856)
@@ -92,6 +92,16 @@
}
}
+template<> bool isLookalikeCharacterOfScriptType(UChar32 codePoint)
+{
+switch (codePoint) {
+case 0x15AF: /* CANADIAN SYLLABICS AIVILIK B */
+return true;
+default:
+return false;
+}
+}
+
template
bool isOfScriptType(UChar32 codePoint)
{
@@ -287,7 +297,8 @@
return false;
default:
return isLookalikeSequence(previousCodePoint, codePoint)
-|| isLookalikeSequence(previousCodePoint, codePoint);
+|| isLookalikeSequence(previousCodePoint, codePoint)
+|| isLookalikeSequence(previousCodePoint, codePoint);
}
}
Modified: trunk/Tools/ChangeLog (292855 => 292856)
--- trunk/Tools/ChangeLog 2022-04-14 03:56:58 UTC (rev 292855)
+++ trunk/Tools/ChangeLog 2022-04-14 04:38:41 UTC (rev 292856)
@@ -1,3 +1,14 @@
+2022-04-13 Alex Christensen
+
+Punycode encode U+15AF when not in context of other Canadian aboriginal code points
+https://bugs.webkit.org/show_bug.cgi?id=239316
+
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
+(TestWebKitAPI::TEST):
+
2022-04-13 Matteo Flores
[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturing is a flaky timeout
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm (292855 => 292856)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2022-04-14 03:56:58 UTC (rev 292855)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2022-04-14 04:38:41 UTC (rev 292856)
@@ -126,6 +126,8 @@
"xn--g-idc"_s, // 'g' U+0581
"xn--o-00e"_s, // U+0BE6 'o'
"xn--o-10e"_s, // 'o' U+0BE6
+"xn--a-53i"_s, // U+15AF 'a'
+"xn--a-63i"_s, // 'a' U+15AF
};
for (auto& host : punycodedSpoofHosts) {
auto url = "" host, "/").utf8();
@@ -152,6 +154,9 @@
// Tamil
EXPECT_STREQ("https://\u0BE6\u0BE7\u0BE8\u0BE9count/", userVisibleString(literalURL("https://\u0BE6\u0BE7\u0BE8\u0BE9count/")));
+
+// Canadian aboriginal
+EXPECT_STREQ("https://\u15AF\u1401abc/", userVisibleString(literalURL("https://\u15AF\u1401abc/")));
}
TEST(WTF_URLExtras, URLExtras_DivisionSign)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292855] trunk
Title: [292855] trunk
Revision 292855
Author za...@apple.com
Date 2022-04-13 20:56:58 -0700 (Wed, 13 Apr 2022)
Log Message
REGRESSION (r292043): [ Mac ] fast/block/positioning/fixed-container-with-relative-parent.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239101
Reviewed by Antti Koivisto.
Source/WebCore:
1. Out of flow boxes are laid out independently from each other as the last step of their containing block layout.
2. However their static positions are computed during regular in-flow layout (as if their positions were static).
In order to do #1, we maintain a ListHashSet for the out-of-flow boxes and insert them at #2 (and we also have
a corresponding HashMap).
Normally this is a very simple list of descendant positioned boxes and since out-of-flow boxes don't interact with each
other, their position in the list is not important.
e.g.
At in-flow layout (#2), we insert B and C to "ListHashSet of A" as we come across them in DOM order and compute their static positions.
Later in the layout flow when we get to the "let's layout the out-of-flow boxes" phase (#1) we simply walk
the ListHashSet and lay out B and C (but "C and B" order would also work just fine).
However the ICB (RenderView) is a special containing block as it can hold different types of out-of-flow boxes (absolute and fixed)
and those out-of-flow boxes may have layout dependencies.
e.g.
ICB's ListHasSet has both A and B, but in this case there's (static)layout dependency between these boxes.
In order to figure out the static position of B, we have to have A laid out first. In order to lay out A before B,
B has to be preceded by A in ICB's ListHasSet.
Now full layout always guarantees the correct order.
However in case of partial layout since we don't run a full #2, the ListHasSet may end up having an unexpected order.
e.g.
1. The initial (full) layout produces the following (correct) order for the ICB's ListHasSet -> AC.
2. A subsequent partial layout (e.g. triggered by A's position change) runs an in-flow layout on the which
(re-)appends A to the ListHasSet (CA <- incorrect order). Now at this point we assume that the in-flow layout picks up B
which eventually (re-)appends C to the ListHashSet (AC <- correct order). However since B does not need layout, we just
stop at which leaves us with an unexpected ListHashSet.
3. As part of the ICB's out-of-flow layout, we pick C as the first box to lay out followed by A. However since C's static
position depends on A's position, we end up using stale geometry when computing C's static position.
This patch fixes this issue by ensuring the absolute positioned boxes always come first in the ICB's ListHasSet (note
that their order is not really important -see above. What's important is that a potential (as-if-static) containing block always
comes before the fixed boxes).
Test: fast/block/fixed-inside-absolute-positioned.html
* rendering/RenderBlock.cpp:
(WebCore::PositionedDescendantsMap::addDescendant):
(WebCore::RenderBlock::insertPositionedObject):
LayoutTests:
* fast/block/fixed-inside-absolute-positioned-expected.html: Added.
* fast/block/fixed-inside-absolute-positioned.html: Added.
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/block/fixed-inside-absolute-positioned-expected.html
trunk/LayoutTests/fast/block/fixed-inside-absolute-positioned.html
Diff
Modified: trunk/LayoutTests/ChangeLog (292854 => 292855)
--- trunk/LayoutTests/ChangeLog 2022-04-14 03:55:10 UTC (rev 292854)
+++ trunk/LayoutTests/ChangeLog 2022-04-14 03:56:58 UTC (rev 292855)
@@ -1,3 +1,15 @@
+2022-04-13 Alan Bujtas
+
+REGRESSION (r292043): [ Mac ] fast/block/positioning/fixed-container-with-relative-parent.html is a flaky image failure
+https://bugs.webkit.org/show_bug.cgi?id=239101
+
+
+Reviewed by Antti Koivisto.
+
+* fast/block/fixed-inside-absolute-positioned-expected.html: Added.
+* fast/block/fixed-inside-absolute-positioned.html: Added.
+* platform/mac-wk1/TestExpectations:
+
2022-04-13 Truitt Savell
[ Monterey WK2 ] media/media-source/media-source-webm-vorbis-partial.html is a constant failure
Added: trunk/LayoutTests/fast/block/fixed-inside-absolute-positioned-expected.html (0 => 292855)
--- trunk/LayoutTests/fast/block/fixed-inside-absolute-positioned-expected.html (rev 0)
+++ trunk/LayoutTests/fast/block/fixed-inside-absolute-positioned-expected.html 2022-04-14 03:56:58 UTC (rev 292855)
@@ -0,0 +1,13 @@
+
+body {
+ margin: 0px;
+}
+div {
+ width: 100px;
+ height: 100px;
+ background-color: green;
+ margin-top: 8px;
+ margin-left: 100px;
+}
+
+
\ No
[webkit-changes] [292854] trunk/Source/WebCore
Title: [292854] trunk/Source/WebCore Revision 292854 Author cdu...@apple.com Date 2022-04-13 20:55:10 -0700 (Wed, 13 Apr 2022) Log Message Use [AtomString] where appropriate in IDL files for performance https://bugs.webkit.org/show_bug.cgi?id=239314 Reviewed by Alexey Shvayka. Use [AtomString] where appropriate in IDL files for performance. I added [AtomString] on the IDL side whenever our C++ implementation uses AtomString. Without this, the generated bindings code will generate a String, which will then get atomized once passed to our implementation. This means we're doing unnecessary String allocations in cases where the AtomString is already in the AtomStringTable. * dom/Attr.idl: * dom/Document+HTML.idl: * dom/Document.cpp: (WebCore::Document::createAttribute): * dom/Document.h: * dom/Document.idl: * dom/Element.cpp: (WebCore::Element::getAttribute const): * dom/Element.idl: * dom/ElementContentEditable.idl: * dom/Event.idl: * dom/FocusEvent.idl: * dom/FormDataEvent.idl: * dom/HashChangeEvent.idl: * dom/InputEvent.idl: * dom/KeyboardEvent.idl: * dom/MessageEvent.idl: * dom/MouseEvent.idl: * dom/MutationEvent.idl: * dom/NamedNodeMap.idl: * dom/Node.idl: * dom/OverflowEvent.idl: * dom/PageTransitionEvent.idl: * dom/PointerEvent.idl: * dom/ProgressEvent.idl: * dom/PromiseRejectionEvent.idl: * dom/SecurityPolicyViolationEvent.idl: * dom/TextEvent.idl: * dom/TouchEvent.idl: * dom/TransitionEvent.idl: * dom/UIEvent.idl: * dom/WheelEvent.idl: * html/HTMLButtonElement.idl: * html/HTMLDocument.idl: * html/HTMLElement.idl: * html/HTMLFormElement.idl: * html/HTMLImageElement.idl: * html/HTMLInputElement.idl: * html/HTMLLinkElement.idl: * html/HTMLMediaElement.idl: * html/HTMLScriptElement.idl: * html/HTMLTableCellElement.idl: * html/HTMLTrackElement.idl: * html/MediaEncryptedEvent.idl: * html/SubmitEvent.idl: * html/track/AudioTrack.idl: * html/track/AudioTrackList.idl: * html/track/TextTrack.idl: * html/track/TextTrackList.idl: * html/track/VTTRegion.idl: * html/track/VideoTrack.idl: * html/track/VideoTrackList.idl: * page/DOMWindow.idl: * page/UserMessageHandlersNamespace.idl: * storage/StorageEvent.idl: * svg/SVGAltGlyphElement.idl: * svg/SVGStyleElement.idl: * workers/service/ExtendableEvent.idl: * workers/service/ExtendableMessageEvent.idl: * workers/service/FetchEvent.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Attr.idl trunk/Source/WebCore/dom/Document+HTML.idl trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Document.idl trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.idl trunk/Source/WebCore/dom/ElementContentEditable.idl trunk/Source/WebCore/dom/Event.idl trunk/Source/WebCore/dom/FocusEvent.idl trunk/Source/WebCore/dom/FormDataEvent.idl trunk/Source/WebCore/dom/HashChangeEvent.idl trunk/Source/WebCore/dom/InputEvent.idl trunk/Source/WebCore/dom/KeyboardEvent.idl trunk/Source/WebCore/dom/MessageEvent.idl trunk/Source/WebCore/dom/MouseEvent.idl trunk/Source/WebCore/dom/MutationEvent.idl trunk/Source/WebCore/dom/NamedNodeMap.idl trunk/Source/WebCore/dom/Node.idl trunk/Source/WebCore/dom/OverflowEvent.idl trunk/Source/WebCore/dom/PageTransitionEvent.idl trunk/Source/WebCore/dom/PointerEvent.idl trunk/Source/WebCore/dom/ProgressEvent.idl trunk/Source/WebCore/dom/PromiseRejectionEvent.idl trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.idl trunk/Source/WebCore/dom/TextEvent.idl trunk/Source/WebCore/dom/TouchEvent.idl trunk/Source/WebCore/dom/TransitionEvent.idl trunk/Source/WebCore/dom/UIEvent.idl trunk/Source/WebCore/dom/WheelEvent.idl trunk/Source/WebCore/html/HTMLButtonElement.idl trunk/Source/WebCore/html/HTMLDocument.idl trunk/Source/WebCore/html/HTMLElement.idl trunk/Source/WebCore/html/HTMLFormElement.idl trunk/Source/WebCore/html/HTMLImageElement.idl trunk/Source/WebCore/html/HTMLInputElement.idl trunk/Source/WebCore/html/HTMLLinkElement.idl trunk/Source/WebCore/html/HTMLMediaElement.idl trunk/Source/WebCore/html/HTMLScriptElement.idl trunk/Source/WebCore/html/HTMLTableCellElement.idl trunk/Source/WebCore/html/HTMLTrackElement.idl trunk/Source/WebCore/html/MediaEncryptedEvent.idl trunk/Source/WebCore/html/SubmitEvent.idl trunk/Source/WebCore/html/track/AudioTrack.idl trunk/Source/WebCore/html/track/AudioTrackList.idl trunk/Source/WebCore/html/track/TextTrack.idl trunk/Source/WebCore/html/track/TextTrackList.idl trunk/Source/WebCore/html/track/VTTRegion.idl trunk/Source/WebCore/html/track/VideoTrack.idl trunk/Source/WebCore/html/track/VideoTrackList.idl trunk/Source/WebCore/page/DOMWindow.idl trunk/Source/WebCore/page/UserMessageHandlersNamespace.idl trunk/Source/WebCore/storage/StorageEvent.idl trunk/Source/WebCore/svg/SVGAltGlyphElement.idl trunk/Source/WebCore/svg/SVGStyleElement.idl trunk/Source/WebCore/workers/service/ExtendableEvent.idl trunk/Source/WebCore/workers/service/ExtendableMessageEvent.idl trunk/Source/WebCore/workers/service/FetchEvent.idl Diff Modified:
[webkit-changes] [292853] trunk/Tools
Title: [292853] trunk/Tools
Revision 292853
Author matteo_flo...@apple.com
Date 2022-04-13 19:34:36 -0700 (Wed, 13 Apr 2022)
Log Message
[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturing is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=239315 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
Diff
Modified: trunk/Tools/ChangeLog (292852 => 292853)
--- trunk/Tools/ChangeLog 2022-04-14 02:24:13 UTC (rev 292852)
+++ trunk/Tools/ChangeLog 2022-04-14 02:34:36 UTC (rev 292853)
@@ -1,5 +1,14 @@
2022-04-13 Matteo Flores
+[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturing is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=239315
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+
+2022-04-13 Matteo Flores
+
[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturingAndCalling is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239309
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (292852 => 292853)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2022-04-14 02:24:13 UTC (rev 292852)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2022-04-14 02:34:36 UTC (rev 292853)
@@ -560,7 +560,8 @@
#endif
#if ENABLE(GPU_PROCESS)
-TEST(WebKit2, CrashGPUProcessWhileCapturing)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239315
+TEST(WebKit2, DISABLED_CrashGPUProcessWhileCapturing)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto preferences = [configuration preferences];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292852] trunk/Tools
Title: [292852] trunk/Tools
Revision 292852
Author matteo_flo...@apple.com
Date 2022-04-13 19:24:13 -0700 (Wed, 13 Apr 2022)
Log Message
[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturingAndCalling is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=239309 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: Disabling test to help EWS
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
Diff
Modified: trunk/Tools/ChangeLog (292851 => 292852)
--- trunk/Tools/ChangeLog 2022-04-14 02:02:10 UTC (rev 292851)
+++ trunk/Tools/ChangeLog 2022-04-14 02:24:13 UTC (rev 292852)
@@ -1,5 +1,14 @@
2022-04-13 Matteo Flores
+[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturingAndCalling is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=239309
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: Disabling test to help EWS
+
+2022-04-13 Matteo Flores
+
[ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239311
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (292851 => 292852)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2022-04-14 02:02:10 UTC (rev 292851)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2022-04-14 02:24:13 UTC (rev 292852)
@@ -707,7 +707,8 @@
EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
}
-TEST(WebKit2, CrashGPUProcessWhileCapturingAndCalling)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239309
+TEST(WebKit2, DISABLED_CrashGPUProcessWhileCapturingAndCalling)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto preferences = [configuration preferences];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292851] trunk/Tools
Title: [292851] trunk/Tools
Revision 292851
Author matteo_flo...@apple.com
Date 2022-04-13 19:02:10 -0700 (Wed, 13 Apr 2022)
Log Message
[ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=239311 Unreviewed test gardening * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Disabling the test to help EWS (TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm
Diff
Modified: trunk/Tools/ChangeLog (292850 => 292851)
--- trunk/Tools/ChangeLog 2022-04-14 01:50:09 UTC (rev 292850)
+++ trunk/Tools/ChangeLog 2022-04-14 02:02:10 UTC (rev 292851)
@@ -1,5 +1,15 @@
2022-04-13 Matteo Flores
+[ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=239311
+
+Unreviewed test gardening
+
+* TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Disabling the test to help EWS
+(TestWebKitAPI::TEST):
+
+2022-04-13 Matteo Flores
+
REGRESSION(r292401-r292310): [ iOS ] TestWebKitAPI.GPUProcess.CanvasBasicCrashHandling is a constant failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=239303
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm (292850 => 292851)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm 2022-04-14 01:50:09 UTC (rev 292850)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm 2022-04-14 02:02:10 UTC (rev 292851)
@@ -2634,7 +2634,8 @@
EXPECT_FALSE(authorizationPerformed);
}
-TEST(SOAuthorizationSubFrame, InterceptionErrorWithReferrer)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239311
+TEST(SOAuthorizationSubFrame, DISABLED_InterceptionErrorWithReferrer)
{
resetState();
ClassMethodSwizzler swizzler1(PAL::getSOAuthorizationClass(), @selector(canPerformAuthorizationWithURL:responseCode:), reinterpret_cast(overrideCanPerformAuthorizationWithURL));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292850] trunk/Tools
Title: [292850] trunk/Tools
Revision 292850
Author matteo_flo...@apple.com
Date 2022-04-13 18:50:09 -0700 (Wed, 13 Apr 2022)
Log Message
REGRESSION(r292401-r292310): [ iOS ] TestWebKitAPI.GPUProcess.CanvasBasicCrashHandling is a constant failure on iOS https://bugs.webkit.org/show_bug.cgi?id=239303 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: Disabling the test to help EWS (TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm
Diff
Modified: trunk/Tools/ChangeLog (292849 => 292850)
--- trunk/Tools/ChangeLog 2022-04-14 01:30:02 UTC (rev 292849)
+++ trunk/Tools/ChangeLog 2022-04-14 01:50:09 UTC (rev 292850)
@@ -1,5 +1,15 @@
2022-04-13 Matteo Flores
+REGRESSION(r292401-r292310): [ iOS ] TestWebKitAPI.GPUProcess.CanvasBasicCrashHandling is a constant failure on iOS
+https://bugs.webkit.org/show_bug.cgi?id=239303
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: Disabling the test to help EWS
+(TEST):
+
+2022-04-13 Matteo Flores
+
[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=239310
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm (292849 => 292850)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2022-04-14 01:30:02 UTC (rev 292849)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2022-04-14 01:50:09 UTC (rev 292850)
@@ -451,7 +451,8 @@
" \n"
"";
-TEST(GPUProcess, CanvasBasicCrashHandling)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239303
+TEST(GPUProcess, DISABLED_CanvasBasicCrashHandling)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
WKPreferencesSetBoolValueForKeyForTesting((__bridge WKPreferencesRef)[configuration preferences], true, WKStringCreateWithUTF8CString("UseGPUProcessForCanvasRenderingEnabled"));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292849] trunk/Tools
Title: [292849] trunk/Tools
Revision 292849
Author matteo_flo...@apple.com
Date 2022-04-13 18:30:02 -0700 (Wed, 13 Apr 2022)
Log Message
[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=239310 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Disabling the test (TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm
Diff
Modified: trunk/Tools/ChangeLog (292848 => 292849)
--- trunk/Tools/ChangeLog 2022-04-14 01:18:57 UTC (rev 292848)
+++ trunk/Tools/ChangeLog 2022-04-14 01:30:02 UTC (rev 292849)
@@ -1,3 +1,13 @@
+2022-04-13 Matteo Flores
+
+[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout
+https://bugs.webkit.org/show_bug.cgi?id=239310
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Disabling the test
+(TEST):
+
2022-04-13 Jonathan Bedard
[git-webkit] Found branch name instead of hash
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm (292848 => 292849)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-04-14 01:18:57 UTC (rev 292848)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-04-14 01:30:02 UTC (rev 292849)
@@ -70,8 +70,8 @@
keepNetworkProcessActive();
}];
}
-
-TEST(IndexedDB, IndexedDBSuspendImminently)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239310
+TEST(IndexedDB, DISABLED_IndexedDBSuspendImminently)
{
readyToContinue = false;
[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292848] tags/WebKit-7613.2.6.0.1/
Title: [292848] tags/WebKit-7613.2.6.0.1/ Revision 292848 Author kocsen_ch...@apple.com Date 2022-04-13 18:18:57 -0700 (Wed, 13 Apr 2022) Log Message Tag WebKit-7613.2.6.0.1. Added Paths tags/WebKit-7613.2.6.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292847] tags/WebKit-7613.2.6.1.1/
Title: [292847] tags/WebKit-7613.2.6.1.1/ Revision 292847 Author kocsen_ch...@apple.com Date 2022-04-13 18:05:41 -0700 (Wed, 13 Apr 2022) Log Message Tag WebKit-7613.2.6.1.1. Added Paths tags/WebKit-7613.2.6.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292846] trunk/Source/WebKit
Title: [292846] trunk/Source/WebKit
Revision 292846
Author achristen...@apple.com
Date 2022-04-13 17:52:22 -0700 (Wed, 13 Apr 2022)
Log Message
Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is called
https://bugs.webkit.org/show_bug.cgi?id=237735
Reviewed by Geoff Garen.
This is recommitting http://trac.webkit.org/r291598 but leaving the definition of PrivateRelayed::Yes and ::No
based on whether metrics._privacyStance == nw_connection_privacy_stance_direct instead of nw_connection_privacy_stance_failed.
It has flip flopped several times in the various related commits, but it needs to be nw_connection_privacy_stance_direct.
I manually verified that this fixes without reintroducing .
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292845 => 292846)
--- trunk/Source/WebKit/ChangeLog 2022-04-14 00:15:54 UTC (rev 292845)
+++ trunk/Source/WebKit/ChangeLog 2022-04-14 00:52:22 UTC (rev 292846)
@@ -1,3 +1,21 @@
+2022-04-13 Alex Christensen
+
+Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is called
+https://bugs.webkit.org/show_bug.cgi?id=237735
+
+Reviewed by Geoff Garen.
+
+This is recommitting http://trac.webkit.org/r291598 but leaving the definition of PrivateRelayed::Yes and ::No
+based on whether metrics._privacyStance == nw_connection_privacy_stance_direct instead of nw_connection_privacy_stance_failed.
+It has flip flopped several times in the various related commits, but it needs to be nw_connection_privacy_stance_direct.
+I manually verified that this fixes without reintroducing .
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
2022-04-13 Elliott Williams
[Xcode] Fix public watchOS workspace build by updating scheme and build settings
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (292845 => 292846)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-14 00:15:54 UTC (rev 292845)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-14 00:52:22 UTC (rev 292846)
@@ -340,6 +340,14 @@
RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
+if (parameters.isMainFrameNavigation
+|| parameters.hadMainFrameMainResourcePrivateRelayed
+|| !parameters.topOrigin
+|| request.url().host() == parameters.topOrigin->host()) {
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+}
+
#if ENABLE(APP_PRIVACY_REPORT)
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (292845 => 292846)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-14 00:15:54 UTC (rev 292845)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-14 00:52:22 UTC (rev 292846)
@@ -936,7 +936,7 @@
NSURLSessionTaskTransactionMetrics *metrics = taskMetrics.transactionMetrics.lastObject;
#if HAVE(NETWORK_CONNECTION_PRIVACY_STANCE)
-auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_failed ? PrivateRelayed::No : PrivateRelayed::Yes;
+auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct ? PrivateRelayed::No : PrivateRelayed::Yes;
#else
auto privateRelayed = PrivateRelayed::No;
#endif
@@ -1713,6 +1713,17 @@
appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
#endif
+// FIXME: This function can make up to 3 copies of a request.
+// Reduce that to one if the protocol is null, the request isn't app initiated,
+// or the main frame main resource was private relayed, then set all properties
+// on the one copy.
+if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
+
[webkit-changes] [292845] trunk
Title: [292845] trunk Revision 292845 Author e...@apple.com Date 2022-04-13 17:15:54 -0700 (Wed, 13 Apr 2022) Log Message [Xcode] Fix public watchOS workspace build by updating scheme and build settings https://bugs.webkit.org/show_bug.cgi?id=239301 Reviewed by Alexey Proskuryakov. .: Add AD_HOC_CODE_SIGNING_ALLOWED=YES (similar to https://commits.webkit.org/249449@main) and DISABLE_SDK_METADATA_PARSING=YES in various places to work around open-source workspace build failures when building for watchOS. * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: - Remove libwebrtc from the "All Source" scheme. On watchOS, it doesn't build, and on other platforms, it is an implicit dependency, so removing it lets the build system determine whether or not it should build. - Remove MiniBrowser from the "All Source" scheme, as it's part of "All Tools". "All Tools" probably shouldn't be built for embedded platforms, as it contains some Mac-only tools, but we do not enforce this. Source/WebCore: * Configurations/Base.xcconfig: * Configurations/WebCore.xcconfig: * Configurations/WebCoreTestSupport.xcconfig: Source/WebGPU: * Configurations/Base.xcconfig: * Configurations/WebGPU.xcconfig: Source/WebInspectorUI: * Configurations/Base.xcconfig: Source/WebKit: * Configurations/WebKit.xcconfig: Source/WebKitLegacy/mac: * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/Base.xcconfig trunk/Source/WebCore/Configurations/WebCore.xcconfig trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/Configurations/Base.xcconfig trunk/Source/WebGPU/Configurations/WebGPU.xcconfig trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Configurations/Base.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/WebKit.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme Diff Modified: trunk/ChangeLog (292844 => 292845) --- trunk/ChangeLog 2022-04-13 23:43:01 UTC (rev 292844) +++ trunk/ChangeLog 2022-04-14 00:15:54 UTC (rev 292845) @@ -1,3 +1,25 @@ +2022-04-13 Elliott Williams + +[Xcode] Fix public watchOS workspace build by updating scheme and build settings +https://bugs.webkit.org/show_bug.cgi?id=239301 + +Reviewed by Alexey Proskuryakov. + +Add AD_HOC_CODE_SIGNING_ALLOWED=YES (similar to +https://commits.webkit.org/249449@main) and +DISABLE_SDK_METADATA_PARSING=YES in various places to work around +open-source workspace build failures when building for watchOS. + +* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: +- Remove libwebrtc from the "All Source" scheme. On watchOS, it doesn't +build, and on other platforms, it is an implicit dependency, so +removing it lets the build system determine whether or not it should +build. +- Remove MiniBrowser from the "All Source" scheme, as it's part of "All +Tools". "All Tools" probably shouldn't be built for embedded +platforms, as it contains some Mac-only tools, but we do not enforce +this. + 2022-04-12 Elliott Williams Reland "[XCBuild] Enable dependency validation by default" Modified: trunk/Source/WebCore/ChangeLog (292844 => 292845) --- trunk/Source/WebCore/ChangeLog 2022-04-13 23:43:01 UTC (rev 292844) +++ trunk/Source/WebCore/ChangeLog 2022-04-14 00:15:54 UTC (rev 292845) @@ -1,3 +1,14 @@ +2022-04-13 Elliott Williams + +[Xcode] Fix public watchOS workspace build by updating scheme and build settings +https://bugs.webkit.org/show_bug.cgi?id=239301 + +Reviewed by Alexey Proskuryakov. + +* Configurations/Base.xcconfig: +* Configurations/WebCore.xcconfig: +* Configurations/WebCoreTestSupport.xcconfig: + 2022-04-13 Michael Catanzaro Misc compiler warnings, April 2022 edition Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (292844 => 292845) --- trunk/Source/WebCore/Configurations/Base.xcconfig 2022-04-13 23:43:01 UTC (rev 292844) +++ trunk/Source/WebCore/Configurations/Base.xcconfig 2022-04-14 00:15:54 UTC (rev 292845) @@ -25,6 +25,7 @@ #include "SDKVariant.xcconfig" CODE_SIGN_IDENTITY = -; +AD_HOC_CODE_SIGNING_ALLOWED = YES; USE_INTERNAL_SDK = $(USE_INTERNAL_SDK_$(CONFIGURATION)); USE_INTERNAL_SDK_Production = YES; Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (292844 => 292845) --- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2022-04-13 23:43:01 UTC (rev 292844) +++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2022-04-14 00:15:54 UTC (rev 292845) @@ -78,6 +78,9 @@
[webkit-changes] [292844] trunk/Tools
Title: [292844] trunk/Tools
Revision 292844
Author jbed...@apple.com
Date 2022-04-13 16:43:01 -0700 (Wed, 13 Apr 2022)
Log Message
[git-webkit] Found branch name instead of hash
https://bugs.webkit.org/show_bug.cgi?id=239296
Reviewed by Michael Catanzaro.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate): Add --no-decorate to `git log` command.
(Git.commit): Ditto.
(Git.commits): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log): Ditto.
Canonical link: https://commits.webkit.org/249617@main
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (292843 => 292844)
--- trunk/Tools/ChangeLog 2022-04-13 23:24:40 UTC (rev 292843)
+++ trunk/Tools/ChangeLog 2022-04-13 23:43:01 UTC (rev 292844)
@@ -1,3 +1,21 @@
+2022-04-13 Jonathan Bedard
+
+[git-webkit] Found branch name instead of hash
+https://bugs.webkit.org/show_bug.cgi?id=239296
+
+
+Reviewed by Michael Catanzaro.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git.Cache.populate): Add --no-decorate to `git log` command.
+(Git.commit): Ditto.
+(Git.commits): Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
+(TestGit.test_log): Ditto.
+
2022-04-13 Ross Kirsling
Add PlayStation builds to bot watcher's dashboard.
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (292843 => 292844)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-13 23:24:40 UTC (rev 292843)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-13 23:43:01 UTC (rev 292844)
@@ -29,7 +29,7 @@
setup(
name='webkitscmpy',
-version='4.9.1',
+version='4.9.2',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (292843 => 292844)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-13 23:24:40 UTC (rev 292843)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-13 23:43:01 UTC (rev 292844)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(4, 9, 1)
+version = Version(4, 9, 2)
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('jinja2', Version(2, 11, 3)))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (292843 => 292844)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2022-04-13 23:24:40 UTC (rev 292843)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2022-04-13 23:43:01 UTC (rev 292844)
@@ -130,7 +130,7 @@
kwargs = dict(encoding='utf-8')
self._last_populated[branch] = time.time()
log = subprocess.Popen(
-[self.repo.executable(), 'log', branch],
+[self.repo.executable(), 'log', branch, '--no-decorate'],
cwd=self.repo.root_path,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
@@ -560,7 +560,7 @@
default_branch = self.default_branch
parsed_branch_point = None
-log_format = ['-1'] if include_log else ['-1', '--format=short']
+log_format = ['-1', '--no-decorate'] if include_log else ['-1', '--no-decorate', '--format=short']
# Determine the `git log` output and branch for a given identifier
if identifier is not None:
@@ -743,7 +743,7 @@
try:
log = None
log = subprocess.Popen(
-[self.executable(), 'log', '--format=fuller', '{}...{}'.format(end.hash, begin.hash)],
+[self.executable(), 'log', '--format=fuller', '--no-decorate', '{}...{}'.format(end.hash, begin.hash)],
cwd=self.root_path,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py (292843 => 292844)
[webkit-changes] [292843] trunk/Tools
Title: [292843] trunk/Tools
Revision 292843
Author ross.kirsl...@sony.com
Date 2022-04-13 16:24:40 -0700 (Wed, 13 Apr 2022)
Log Message
Add PlayStation builds to bot watcher's dashboard.
https://bugs.webkit.org/show_bug.cgi?id=239090
Reviewed by Jonathan Bedard.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png: Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.playstation img.logo):
Canonical link: https://commits.webkit.org/249616@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png
Diff
Added: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png
(Binary files differ)
Index: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png
===
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png 2022-04-13 23:17:19 UTC (rev 292842)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png 2022-04-13 23:24:40 UTC (rev 292843)
Property changes on: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png
___
Added: svn:mime-type
+image/png
\ No newline at end of property
Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js (292842 => 292843)
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js 2022-04-13 23:17:19 UTC (rev 292842)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js 2022-04-13 23:24:40 UTC (rev 292843)
@@ -44,6 +44,7 @@
LinuxWPE: { name : "linux-wpe", readableName: "Linux WPE", order: 90 },
LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 91 },
LinuxJSCOnly: { name : "linux-jsconly", readableName: "Linux JSCOnly", order: 92 },
+PlayStation: { name : "playstation", readableName: "PlayStation", order: 100 },
},
Branch: {},
Repository: {
Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js (292842 => 292843)
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-04-13 23:17:19 UTC (rev 292842)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-04-13 23:24:40 UTC (rev 292843)
@@ -104,6 +104,8 @@
"JSCOnly MIPS Testers": {platform: Dashboard.Platform.LinuxJSCOnly, heading: "MIPS", combinedQueues: {
"JSCOnly-Linux-MIPS32el-Release": {heading: "MIPS32el"},
}},
+"PlayStation-Release-Build": {platform: Dashboard.Platform.PlayStation, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
+"PlayStation-Debug-Build": {platform: Dashboard.Platform.PlayStation, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
};
Buildbot.call(this, "https://build.webkit.org/", queueInfo, {"USE_BUILDBOT_VERSION_LESS_THAN_09" : false});
Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css (292842 => 292843)
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css 2022-04-13 23:17:19 UTC (rev 292842)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css 2022-04-13 23:24:40 UTC (rev 292843)
@@ -253,6 +253,10 @@
content: url(../Images/SquirrelFish.png);
}
+table.queue-grid tr.platform.playstation img.logo {
+content: url(../Images/PlayStation.png);
+}
+
.popover-tracking:hover {
text-shadow: 0px 0px 3px rgba(0, 0, 0, 0.2)
}
Modified: trunk/Tools/ChangeLog (292842 => 292843)
--- trunk/Tools/ChangeLog 2022-04-13 23:17:19 UTC (rev 292842)
+++ trunk/Tools/ChangeLog 2022-04-13 23:24:40 UTC (rev 292843)
@@ -1,3 +1,15 @@
+2022-04-13 Ross Kirsling
+
+Add PlayStation builds to bot watcher's dashboard.
+https://bugs.webkit.org/show_bug.cgi?id=239090
+
+Reviewed by Jonathan Bedard .
+
+* CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png: Added.
+* CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
+* CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
+*
[webkit-changes] [292842] trunk/Source/WebKit
Title: [292842] trunk/Source/WebKit
Revision 292842
Author cdu...@apple.com
Date 2022-04-13 16:17:19 -0700 (Wed, 13 Apr 2022)
Log Message
WebContent crashes with SIGTERM_TIMEOUT on macOS
https://bugs.webkit.org/show_bug.cgi?id=239298
Reviewed by Darin Adler.
To make sure that WebProcesses cannot use any CPU time while in the WebProcess cache on macOS, I recently tried to
suspend these cached processes. However, since we haven't adopted RunningBoard on macOS yet, I was doing suspension
and resuming manually via the SIGSTOP & SIGCONT signals. While this properly suspended our cached processes, this
introduced SIGTERM_TIMEOUT crashes and potential delays when exiting Safari or logging out of macOS while Safari is
running. This is because our cached & suspended processes are unable to process the SIGTERM signal they receive and
thus don't cleanly exit. After a timeout, the system forcefully kills them and generates a crash log with
SIGTERM_TIMEOUT to let us know.
To address the issue, I am disabling the WebProcess suspension logic that I recently added. We can reconsider doing
something like this once we adopt RunningBoard on macOS, assuming the same issue doesn't affect suspension via
RunningBoard.
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292841 => 292842)
--- trunk/Source/WebKit/ChangeLog 2022-04-13 23:14:10 UTC (rev 292841)
+++ trunk/Source/WebKit/ChangeLog 2022-04-13 23:17:19 UTC (rev 292842)
@@ -1,3 +1,27 @@
+2022-04-13 Chris Dumez
+
+WebContent crashes with SIGTERM_TIMEOUT on macOS
+https://bugs.webkit.org/show_bug.cgi?id=239298
+
+
+Reviewed by Darin Adler.
+
+To make sure that WebProcesses cannot use any CPU time while in the WebProcess cache on macOS, I recently tried to
+suspend these cached processes. However, since we haven't adopted RunningBoard on macOS yet, I was doing suspension
+and resuming manually via the SIGSTOP & SIGCONT signals. While this properly suspended our cached processes, this
+introduced SIGTERM_TIMEOUT crashes and potential delays when exiting Safari or logging out of macOS while Safari is
+running. This is because our cached & suspended processes are unable to process the SIGTERM signal they receive and
+thus don't cleanly exit. After a timeout, the system forcefully kills them and generates a crash log with
+SIGTERM_TIMEOUT to let us know.
+
+To address the issue, I am disabling the WebProcess suspension logic that I recently added. We can reconsider doing
+something like this once we adopt RunningBoard on macOS, assuming the same issue doesn't affect suspension via
+RunningBoard.
+
+* UIProcess/mac/WebProcessProxyMac.mm:
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+
2022-04-13 Michael Catanzaro
Misc compiler warnings, April 2022 edition
Modified: trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm (292841 => 292842)
--- trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm 2022-04-13 23:14:10 UTC (rev 292841)
+++ trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm 2022-04-13 23:17:19 UTC (rev 292842)
@@ -80,20 +80,12 @@
void WebProcessProxy::platformSuspendProcess()
{
-RELEASE_LOG(Process, "%p - [PID=%i] WebProcessProxy::platformSuspendProcess", this, processIdentifier());
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-if (auto* connection = this->connection())
-xpc_connection_kill(connection->xpcConnection(), SIGSTOP);
-ALLOW_DEPRECATED_DECLARATIONS_END
+// FIXME: Adopt RunningBoard on macOS to support process suspension.
}
void WebProcessProxy::platformResumeProcess()
{
-RELEASE_LOG(Process, "%p - [PID=%i] WebProcessProxy::platformResumeProcess", this, processIdentifier());
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-if (auto* connection = this->connection())
-xpc_connection_kill(connection->xpcConnection(), SIGCONT);
-ALLOW_DEPRECATED_DECLARATIONS_END
+// FIXME: Adopt RunningBoard on macOS to support process suspension.
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292841] trunk/Source/JavaScriptCore
Title: [292841] trunk/Source/_javascript_Core
Revision 292841
Author commit-qu...@webkit.org
Date 2022-04-13 16:14:10 -0700 (Wed, 13 Apr 2022)
Log Message
GCC 12 -Wdangling-pointer warning spam from AbstractSlotVisitorInlines.h
https://bugs.webkit.org/show_bug.cgi?id=239299
Patch by Michael Catanzaro on 2022-04-13
Reviewed by Mark Lam.
Suppress this warning, so we can see other warnings.
* heap/AbstractSlotVisitorInlines.h:
(JSC::AbstractSlotVisitor::ReferrerContext::ReferrerContext):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/AbstractSlotVisitorInlines.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292840 => 292841)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-13 22:55:26 UTC (rev 292840)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-13 23:14:10 UTC (rev 292841)
@@ -1,5 +1,17 @@
2022-04-13 Michael Catanzaro
+GCC 12 -Wdangling-pointer warning spam from AbstractSlotVisitorInlines.h
+https://bugs.webkit.org/show_bug.cgi?id=239299
+
+Reviewed by Mark Lam.
+
+Suppress this warning, so we can see other warnings.
+
+* heap/AbstractSlotVisitorInlines.h:
+(JSC::AbstractSlotVisitor::ReferrerContext::ReferrerContext):
+
+2022-04-13 Michael Catanzaro
+
Misc compiler warnings, April 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=239290
Modified: trunk/Source/_javascript_Core/heap/AbstractSlotVisitorInlines.h (292840 => 292841)
--- trunk/Source/_javascript_Core/heap/AbstractSlotVisitorInlines.h 2022-04-13 22:55:26 UTC (rev 292840)
+++ trunk/Source/_javascript_Core/heap/AbstractSlotVisitorInlines.h 2022-04-13 23:14:10 UTC (rev 292841)
@@ -74,7 +74,9 @@
// An OpaqueRoot contexts can only be on the leaf.
RELEASE_ASSERT(!m_previous->m_isOpaqueRootContext);
}
+IGNORE_GCC_WARNINGS_BEGIN("dangling-pointer")
m_visitor.m_context = this;
+IGNORE_GCC_WARNINGS_END
}
inline AbstractSlotVisitor::ReferrerContext::ReferrerContext(AbstractSlotVisitor& visitor, AbstractSlotVisitor::OpaqueRootTag)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292840] trunk/Source
Title: [292840] trunk/Source
Revision 292840
Author commit-qu...@webkit.org
Date 2022-04-13 15:55:26 -0700 (Wed, 13 Apr 2022)
Log Message
Misc compiler warnings, April 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=239290
Patch by Michael Catanzaro on 2022-04-13
Reviewed by Adrian Perez de Castro.
Fix the usual spam of -Wreturn-type warnings.
Bonus warnings: unused variable, unknown pragmas, and redundant move.
* Source/_javascript_Core/bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::watchabilityToConcurrency):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
* Source/_javascript_Core/runtime/JSObject.h:
(JSC::JSObject::getDirect const):
* Source/_javascript_Core/runtime/Structure.h:
(JSC::Structure::get):
* Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::resolvedPath):
* Source/WebCore/dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canAccessResource const):
* Source/WebCore/page/DebugPageOverlays.cpp:
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
* Source/WebCore/platform/graphics/GraphicsContextState.cpp:
(WebCore::stateChangeName):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::categoryAtMostRecentPlayback const):
Canonical link: https://commits.webkit.org/249613@main
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/Structure.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/page/DebugPageOverlays.cpp
trunk/Source/WebCore/page/InteractionRegion.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContextState.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292839 => 292840)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-13 22:50:04 UTC (rev 292839)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-13 22:55:26 UTC (rev 292840)
@@ -1,3 +1,19 @@
+2022-04-13 Michael Catanzaro
+
+Misc compiler warnings, April 2022 edition
+https://bugs.webkit.org/show_bug.cgi?id=239290
+
+Reviewed by Adrian Perez de Castro.
+
+* bytecode/PropertyCondition.cpp:
+(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
+(JSC::watchabilityToConcurrency):
+(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
+* runtime/JSObject.h:
+(JSC::JSObject::getDirect const):
+* runtime/Structure.h:
+(JSC::Structure::get):
+
2022-04-13 Yusuke Suzuki
[JSC] Remove DeprecatedCallFrameForDebugger
Modified: trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp (292839 => 292840)
--- trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp 2022-04-13 22:50:04 UTC (rev 292839)
+++ trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp 2022-04-13 22:55:26 UTC (rev 292840)
@@ -263,7 +263,6 @@
}
RELEASE_ASSERT_NOT_REACHED();
-return false;
}
static ALWAYS_INLINE Concurrency watchabilityToConcurrency(PropertyCondition::WatchabilityEffort effort)
@@ -274,6 +273,7 @@
case PropertyCondition::WatchabilityEffort::MakeNoChanges:
return Concurrency::ConcurrentThread;
}
+RELEASE_ASSERT_NOT_REACHED();
}
bool PropertyCondition::validityRequiresImpurePropertyWatchpoint(Structure* structure) const
@@ -293,7 +293,6 @@
}
RELEASE_ASSERT_NOT_REACHED();
-return false;
}
bool PropertyCondition::isStillValid(Concurrency concurrency, Structure* structure, JSObject* base) const
Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (292839 => 292840)
--- trunk/Source/_javascript_Core/runtime/JSObject.h 2022-04-13 22:50:04 UTC (rev 292839)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h 2022-04-13 22:55:26 UTC (rev 292840)
@@ -1421,8 +1421,9 @@
case Concurrency::ConcurrentThread:
return getDirectConcurrently(expectedStructure, offset);
}
+RELEASE_ASSERT_NOT_REACHED();
+}
-}
inline JSValue JSObject::getDirectConcurrently(Structure* structure, PropertyOffset offset) const
{
ConcurrentJSLocker locker(structure->lock());
Modified: trunk/Source/_javascript_Core/runtime/Structure.h (292839 => 292840)
--- trunk/Source/_javascript_Core/runtime/Structure.h 2022-04-13 22:50:04 UTC
[webkit-changes] [292838] trunk/Source/WebCore
Title: [292838] trunk/Source/WebCore
Revision 292838
Author dp...@igalia.com
Date 2022-04-13 15:50:02 -0700 (Wed, 13 Apr 2022)
Log Message
Unreviewed, fix non-unified build after r292810
* editing/HTMLInterchange.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/HTMLInterchange.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292837 => 292838)
--- trunk/Source/WebCore/ChangeLog 2022-04-13 22:47:07 UTC (rev 292837)
+++ trunk/Source/WebCore/ChangeLog 2022-04-13 22:50:02 UTC (rev 292838)
@@ -1,3 +1,9 @@
+2022-04-13 Diego Pino Garcia
+
+Unreviewed, fix non-unified build after r292810
+
+* editing/HTMLInterchange.h:
+
2022-04-13 Sihui Liu
StorageMap::importItems may update currentSize wrongly in release build
Modified: trunk/Source/WebCore/editing/HTMLInterchange.h (292837 => 292838)
--- trunk/Source/WebCore/editing/HTMLInterchange.h 2022-04-13 22:47:07 UTC (rev 292837)
+++ trunk/Source/WebCore/editing/HTMLInterchange.h 2022-04-13 22:50:02 UTC (rev 292838)
@@ -26,6 +26,7 @@
#pragma once
#include
+#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292839] trunk/LayoutTests
Title: [292839] trunk/LayoutTests Revision 292839 Author tsav...@apple.com Date 2022-04-13 15:50:04 -0700 (Wed, 13 Apr 2022) Log Message [ Monterey WK2 ] media/media-source/media-source-webm-vorbis-partial.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=239308 Unreviewed test gardening * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292838 => 292839) --- trunk/LayoutTests/ChangeLog 2022-04-13 22:50:02 UTC (rev 292838) +++ trunk/LayoutTests/ChangeLog 2022-04-13 22:50:04 UTC (rev 292839) @@ -1,3 +1,12 @@ +2022-04-13 Truitt Savell + +[ Monterey WK2 ] media/media-source/media-source-webm-vorbis-partial.html is a constant failure +https://bugs.webkit.org/show_bug.cgi?id=239308 + +Unreviewed test gardening + +* platform/mac-wk2/TestExpectations: + 2022-04-13 Andres Gonzalez Rewrite accessibility/mac/stale-table-rows.html to properly check that the number of rows and columns are correct after grid changes. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292838 => 292839) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-13 22:50:02 UTC (rev 292838) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-13 22:50:04 UTC (rev 292839) @@ -1656,6 +1656,8 @@ webkit.org/b/239095 http/wpt/cache-storage/cache-storage-networkprocess-crash.html [ Pass Crash ] +webkit.org/b/239308 media/media-source/media-source-webm-vorbis-partial.html [ Failure ] + webkit.org/b/239300 http/tests/push-api/subscribe-default-permissions-iframe-same-origin.html [ Pass Failure ] webkit.org/b/239300 http/tests/push-api/subscribe-default-permissions.html [ Pass Failure ] webkit.org/b/239300 http/tests/push-api/subscribe-deny-permissions-on-prompt.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292837] trunk/LayoutTests
Title: [292837] trunk/LayoutTests Revision 292837 Author andresg...@apple.com Date 2022-04-13 15:47:07 -0700 (Wed, 13 Apr 2022) Log Message Rewrite accessibility/mac/stale-table-rows.html to properly check that the number of rows and columns are correct after grid changes. https://bugs.webkit.org/show_bug.cgi?id=239292 Reviewed by Chris Fleizach. This test had a weak success criterion that was passing when two expressions were equal without checking the actual value of the expressions, which was incorrect in isolated tree mode. This is a rewrite of the test that makes the success criteria more strict and modernize the test to be async so that it can pass in isolated tree mode. In addition, renamed the test to better reflect what it is actually doing. * accessibility/mac/grid-add-remove-rows-expected.txt: Added. * accessibility/mac/grid-add-remove-rows.html: Added. * accessibility/mac/stale-table-rows-expected.txt: Renamed to above. * accessibility/mac/stale-table-rows.html: Renamed to above. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/accessibility/mac/grid-add-remove-rows-expected.txt trunk/LayoutTests/accessibility/mac/grid-add-remove-rows.html Removed Paths trunk/LayoutTests/accessibility/mac/stale-table-rows-expected.txt trunk/LayoutTests/accessibility/mac/stale-table-rows.html Diff Modified: trunk/LayoutTests/ChangeLog (292836 => 292837) --- trunk/LayoutTests/ChangeLog 2022-04-13 22:44:04 UTC (rev 292836) +++ trunk/LayoutTests/ChangeLog 2022-04-13 22:47:07 UTC (rev 292837) @@ -1,3 +1,24 @@ +2022-04-13 Andres Gonzalez + +Rewrite accessibility/mac/stale-table-rows.html to properly check that the number of rows and columns are correct after grid changes. +https://bugs.webkit.org/show_bug.cgi?id=239292 + + +Reviewed by Chris Fleizach. + +This test had a weak success criterion that was passing when two +expressions were equal without checking the actual value of the +expressions, which was incorrect in isolated tree mode. This is a +rewrite of the test that makes the success criteria more strict and +modernize the test to be async so that it can pass in isolated tree +mode. In addition, renamed the test to better reflect what it is +actually doing. + +* accessibility/mac/grid-add-remove-rows-expected.txt: Added. +* accessibility/mac/grid-add-remove-rows.html: Added. +* accessibility/mac/stale-table-rows-expected.txt: Renamed to above. +* accessibility/mac/stale-table-rows.html: Renamed to above. + 2022-04-13 Karl Rackler [ Monterey wk2 release ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-inherits-from-initiator.sub.html is a flaky crash Added: trunk/LayoutTests/accessibility/mac/grid-add-remove-rows-expected.txt (0 => 292837) --- trunk/LayoutTests/accessibility/mac/grid-add-remove-rows-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/mac/grid-add-remove-rows-expected.txt 2022-04-13 22:47:07 UTC (rev 292837) @@ -0,0 +1,18 @@ +This tests that the number of rows and columns of a grid are correct after adding and removing rows and columns. +Initial count: +PASS: grid.rowCount === 1 +PASS: grid.columnCount === 3 +Count after adding 3 rows: +PASS: grid.rowCount === 4 +PASS: grid.columnCount === 3 +Count after clearing data: +PASS: grid.rowCount === 1 +PASS: grid.columnCount === 3 +Count after adding 3 rows again: +PASS: grid.rowCount === 4 +PASS: grid.columnCount === 3 + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/accessibility/mac/grid-add-remove-rows.html (0 => 292837) --- trunk/LayoutTests/accessibility/mac/grid-add-remove-rows.html (rev 0) +++ trunk/LayoutTests/accessibility/mac/grid-add-remove-rows.html 2022-04-13 22:47:07 UTC (rev 292837) @@ -0,0 +1,86 @@ + + + + + + +++ +++ ++A +B +C ++