[webkit-changes] [294382] trunk/metadata/contributors.json

[commit-queue]

Title: [294382] trunk/metadata/contributors.json








Revision 294382
Author commit-qu...@webkit.org
Date 2022-05-17 21:47:20 -0700 (Tue, 17 May 2022)


Log Message
Add jgriego to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240525

Patch by Joseph Griego  on 2022-05-17
Reviewed by Tim Nguyen.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/250679@main

Modified Paths

trunk/metadata/contributors.json




Diff

Modified: trunk/metadata/contributors.json (294381 => 294382)

--- trunk/metadata/contributors.json	2022-05-18 03:23:38 UTC (rev 294381)
+++ trunk/metadata/contributors.json	2022-05-18 04:47:20 UTC (rev 294382)
@@ -3777,6 +3777,17 @@
   ]
},
{
+  "emails" : [
+ "jgri...@igalia.com",
+ "joseph.j.gri...@gmail.com"
+  ],
+  "github" : "jjgriego",
+  "name" : "Joseph Griego",
+  "nicks" : [
+ "jgriego"
+  ]
+   },
+   {
   "aliases" : [
  "Joe Pecoraro"
   ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294381] trunk/Source/WebKit/UIProcess

[sihui_liu]

Title: [294381] trunk/Source/WebKit/UIProcess








Revision 294381
Author sihui_...@apple.com
Date 2022-05-17 20:23:38 -0700 (Tue, 17 May 2022)


Log Message
WebProcessProxy should not hold WebsiteDataStore alive when there is no page 
https://bugs.webkit.org/show_bug.cgi?id=238892


Reviewed by Youenn Fablet.

WebProcessProxy can outlive WebPageProxy, and because WebProcessProxy holds strong reference to WebsiteDataStore,
WebsiteDataStore will be kept alive even when it's not used by any page and will not be used by any page.

* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::~ProvisionalPageProxy):
* UIProcess/ProvisionalPageProxy.h:
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::findReusableSuspendedPageProcess):
* UIProcess/WebBackForwardCache.cpp:
(WebKit::WebBackForwardCache::removeEntriesForSession):
* UIProcess/WebLockRegistryProxy.cpp:
(WebKit::WebLockRegistryProxy::requestLock):
(WebKit::WebLockRegistryProxy::releaseLock):
(WebKit::WebLockRegistryProxy::abortLockRequest):
(WebKit::WebLockRegistryProxy::snapshot):
(WebKit::WebLockRegistryProxy::clientIsGoingAway):
(WebKit::WebLockRegistryProxy::processDidExit):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::commitProvisionalPage):
* UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::canCacheProcess const):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::clearAllProcessesForSession):
(WebKit::WebProcessCache::CachedProcess::CachedProcess):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::processForNavigationInternal):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::m_webLockRegistry):
(WebKit::WebProcessProxy::websiteDataStore const):
(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::isDummyProcessProxy const):
(WebKit::WebProcessProxy::updateRegistrationWithDataStore):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::getNetworkProcessConnection):
(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
(WebKit::WebProcessProxy::sessionID const):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::websiteDataStore const): Deleted.
* UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):

Modified Paths

trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.h
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebBackForwardCache.cpp
trunk/Source/WebKit/UIProcess/WebLockRegistryProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessCache.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp




Diff

Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (294380 => 294381)

--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2022-05-18 02:19:29 UTC (rev 294380)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2022-05-18 03:23:38 UTC (rev 294381)
@@ -370,7 +370,9 @@
 
 void GPUProcessProxy::createGPUProcessConnection(WebProcessProxy& webProcessProxy, IPC::Attachment&& connectionIdentifier, GPUProcessConnectionParameters&& parameters)
 {
-addSession(webProcessProxy.websiteDataStore());
+if (auto* store = webProcessProxy.websiteDataStore())
+addSession(*store);
+
 RELEASE_LOG(ProcessSuspension, "%p - GPUProcessProxy is taking a background assertion because a web process is requesting a connection", this);
 startResponsivenessTimer(UseLazyStop::No);
 sendWithAsyncReply(Messages::GPUProcess::CreateGPUConnectionToWebProcess { webProcessProxy.coreProcessIdentifier(), webProcessProxy.sessionID(), connectionIdentifier, parameters }, [this, weakThis = WeakPtr { *this }]() mutable {


Modified: trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp (294380 => 294381)

--- trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp	2022-05-18 02:19:29 UTC (rev 294380)
+++ trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp	2022-05-18 03:23:38 UTC (rev 294381)
@@ -84,8 +84,10 @@
 m_process->addMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_webPageID, *this);
 m_process->addProvisionalPageProxy(*this);
 
-if (_process->websiteDataStore() != _page.websiteDataStore())
-m_process->processPool().pageBeginUsingWebsiteDataStore(m_page.identifier(), m_process->websiteDataStore());

[webkit-changes] [294380] trunk/metadata/contributors.json

[commit-queue]

Title: [294380] trunk/metadata/contributors.json








Revision 294380
Author commit-qu...@webkit.org
Date 2022-05-17 19:19:29 -0700 (Tue, 17 May 2022)


Log Message
Add myself (Asumu Takikawa) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240546

Patch by Asumu Takikawa  on 2022-05-17
Reviewed by Yusuke Suzuki.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/250677@main

Modified Paths

trunk/metadata/contributors.json




Diff

Modified: trunk/metadata/contributors.json (294379 => 294380)

--- trunk/metadata/contributors.json	2022-05-18 01:45:35 UTC (rev 294379)
+++ trunk/metadata/contributors.json	2022-05-18 02:19:29 UTC (rev 294380)
@@ -947,6 +947,17 @@
},
{
   "emails" : [
+ "as...@igalia.com",
+ "atakik...@igalia.com"
+  ],
+  "github" : "takikawa",
+  "name" : "Asumu Takikawa",
+  "nicks" : [
+ "asumu"
+  ]
+   },
+   {
+  "emails" : [
  "ayumi_koj...@apple.com"
   ],
   "name" : "Ayumi Kojima",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294379] trunk/Tools/glib/generate-pdfjs-gresource-manifest.py

[commit-queue]

Title: [294379] trunk/Tools/glib/generate-pdfjs-gresource-manifest.py








Revision 294379
Author commit-qu...@webkit.org
Date 2022-05-17 18:45:35 -0700 (Tue, 17 May 2022)


Log Message
[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more careful about unknown files
https://bugs.webkit.org/show_bug.cgi?id=240536

Patch by Michael Catanzaro  on 2022-05-17
Reviewed by Adrian Perez de Castro.

Instead of silently ignoring unexpected files, let's create a list of
all files that we do not want to include in the resource manifest.
Anything unexpected will result in a build failure so that there are no
mistakes.

Also, change the lists at the top of the script into sets. Adrian
noticed that they do not need to be ordered.

* Tools/glib/generate-pdfjs-gresource-manifest.py:
(get_filenames):
(get_filenames.should_ignore_resource): Deleted.

Canonical link: https://commits.webkit.org/250668@main

Modified Paths

trunk/Tools/glib/generate-pdfjs-gresource-manifest.py




Diff

Modified: trunk/Tools/glib/generate-pdfjs-gresource-manifest.py (294378 => 294379)

--- trunk/Tools/glib/generate-pdfjs-gresource-manifest.py	2022-05-18 01:43:48 UTC (rev 294378)
+++ trunk/Tools/glib/generate-pdfjs-gresource-manifest.py	2022-05-18 01:45:35 UTC (rev 294379)
@@ -19,18 +19,20 @@
 import os
 import sys
 
-VALID_EXTENSIONS = ['.html', '.js', '.css', '.svg', '.png', '.gif', '.cur', '.bcmap', '.properties', '.pfb', '.ttf']
-COMPRESSIBLE_EXTENSIONS = ['.html', '.js', '.css', '.svg', '.properties']
-BASE_DIRS = ['pdfjs/', 'pdfjs-extras/']
+VALID_EXTENSIONS = {'.html', '.js', '.css', '.svg', '.png', '.gif', '.cur', '.bcmap', '.properties', '.pfb', '.ttf'}
+COMPRESSIBLE_EXTENSIONS = {'.html', '.js', '.css', '.svg', '.properties'}
+BASE_DIRS = {'pdfjs/', 'pdfjs-extras/'}
 
+IGNORE = {'LICENSE',
+  'README.webkit',
+  'web/cmaps/LICENSE',
+  'web/standard_fonts/LICENSE_FOXIT',
+  'web/standard_fonts/LICENSE_LIBERATION'}
 
+
 def get_filenames(directory):
 filenames = []
 
-def should_ignore_resource(resource):
-if os.path.splitext(resource)[1] not in VALID_EXTENSIONS:
-return True
-
 def resource_name(filename):
 for base_directory in BASE_DIRS:
 base_dir_index = filename.rfind(base_directory)
@@ -53,7 +55,10 @@
 # separator is properly replaced.
 if os.sep != '/':
 name = name.replace(os.sep, '/')
-if not should_ignore_resource(name):
+if name not in IGNORE:
+if os.path.splitext(name)[1] not in VALID_EXTENSIONS:
+print('Unexpected file %s, please teach generate-pdfjs-gresource-manifest.py how to handle it' % filename, file=sys.stderr)
+sys.exit(1)
 filenames.append(name)
 
 return filenames






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294377] trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp

[basuke . suzuki]

Title: [294377] trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp








Revision 294377
Author basuke.suz...@sony.com
Date 2022-05-17 18:42:26 -0700 (Tue, 17 May 2022)


Log Message
[WinCairo] Add memory usage of LibcMalloc category
https://bugs.webkit.org/show_bug.cgi?id=239660

Reviewed by Ross Kirsling.

WinCairo's memory timeline just displays _javascript_ memory usage. Adding
this info shows also Page
memory usage.

* page/win/ResourceUsageThreadWin.cpp:
(WebCore::ResourceUsageThread::platformCollectMemoryData):

Canonical link: https://commits.webkit.org/250668@main

Modified Paths

trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp




Diff

Modified: trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp (294376 => 294377)

--- trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp	2022-05-18 01:37:03 UTC (rev 294376)
+++ trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp	2022-05-18 01:42:26 UTC (rev 294377)
@@ -118,7 +118,7 @@
 
 void ResourceUsageThread::platformCollectMemoryData(JSC::VM* vm, ResourceUsageData& data)
 {
-data.totalDirtySize = memoryUsage();
+auto usage = data.totalDirtySize = memoryUsage();
 
 size_t currentGCHeapCapacity = vm->heap.blockBytesAllocated();
 size_t currentGCOwnedExtra = vm->heap.extraMemorySize();
@@ -129,6 +129,14 @@
 data.categories[MemoryCategory::GCOwned].dirtySize = currentGCOwnedExtra - currentGCOwnedExternal;
 data.categories[MemoryCategory::GCOwned].externalSize = currentGCOwnedExternal;
 
+usage -= currentGCHeapCapacity;
+// Following ResourceUsageThreadCocoa implementation
+auto currentGCOwnedGenerallyInMalloc = currentGCOwnedExtra - currentGCOwnedExternal;
+if (currentGCOwnedGenerallyInMalloc < usage)
+usage -= currentGCOwnedGenerallyInMalloc;
+
+data.categories[MemoryCategory::LibcMalloc].dirtySize = usage;
+
 data.totalExternalSize = currentGCOwnedExternal;
 
 data.timeOfNextEdenCollection = data.timestamp + vm->heap.edenActivityCallback()->timeUntilFire().value_or(Seconds(std::numeric_limits::infinity()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294375] tags/WebKit-7614.1.14.100.1/

[alancoon]

Title: [294375] tags/WebKit-7614.1.14.100.1/








Revision 294375
Author alanc...@apple.com
Date 2022-05-17 18:20:53 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.100.1.

Added Paths

tags/WebKit-7614.1.14.100.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294374] trunk

[yurys]

Title: [294374] trunk








Revision 294374
Author yu...@chromium.org
Date 2022-05-17 18:17:36 -0700 (Tue, 17 May 2022)


Log Message
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326

Reviewed by Devin Rousso.

* http/tests/inspector/network/eventsource-type-expected.txt: Added.
* http/tests/inspector/network/eventsource-type.html: Added.
* http/tests/inspector/network/resources/event-source.py: Added.
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326

* inspector/protocol/Page.json: added EventSource resource type.
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326

Network requests initiated by EventSource now have their own requester
type which allows to distinguish them from other requests.

Test: http/tests/inspector/network/eventsource-type.html

* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJSON):
(WebCore::InspectorPageAgent::inspectorResourceType):
* inspector/agents/InspectorPageAgent.h:
* page/EventSource.cpp:
(WebCore::EventSource::connect):
* platform/network/ResourceRequestBase.h:
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326

EventSource initiated requests are now displayed with their own type
in the network panel.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.canBeOverridden):
* UserInterface/Models/Resource.js:
(WI.Resource.displayNameForType):
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.displayNameForResource):

Canonical link: https://commits.webkit.org/250668@main

Modified Paths

trunk/Source/_javascript_Core/inspector/protocol/Page.json
trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorPageAgent.h
trunk/Source/WebCore/page/EventSource.cpp
trunk/Source/WebCore/platform/network/ResourceRequestBase.h
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js


Added Paths

trunk/LayoutTests/http/tests/inspector/network/eventsource-type-expected.txt
trunk/LayoutTests/http/tests/inspector/network/eventsource-type.html
trunk/LayoutTests/http/tests/inspector/network/resources/event-source.py




Diff

Added: trunk/LayoutTests/http/tests/inspector/network/eventsource-type-expected.txt (0 => 294374)

--- trunk/LayoutTests/http/tests/inspector/network/eventsource-type-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/eventsource-type-expected.txt	2022-05-18 01:17:36 UTC (rev 294374)
@@ -0,0 +1,20 @@
+Tests for Resource.Type.EventSource.
+
+
+== Running test suite: Resource.Type.EventSource
+-- Running test case: Resource.Type.EventSource.1.Event
+PASS: Resource should be EventSource type.
+PASS: Resource should be a GET request.
+EventSource events: onmessage: the end.
+PASS: Resource should have a 200 response.
+PASS: Resource should receive 'Success' in the response.
+PASS: Response should not be base64 encoded.
+
+-- Running test case: Resource.Type.EventSource.3.Events
+PASS: Resource should be EventSource type.
+PASS: Resource should be a GET request.
+EventSource events: user: alice,user: bill,onmessage: the end.
+PASS: Resource should have a 200 response.
+PASS: Resource should receive 'Success' in the response.
+PASS: Response should not be base64 encoded.
+


Added: trunk/LayoutTests/http/tests/inspector/network/eventsource-type.html (0 => 294374)

--- trunk/LayoutTests/http/tests/inspector/network/eventsource-type.html	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/eventsource-type.html	2022-05-18 01:17:36 UTC (rev 294374)
@@ -0,0 +1,74 @@
+
+
+
+
+
+function triggerEventSourceRequest(users) {
+const eventSource = new EventSource(`resources/event-source.py?users=${users}`);
+const messages = [];
+eventSource.addEventListener('user', e => {
+messages.push('user: ' + e.data);
+});
+eventSource._onmessage_ = e => {
+messages.push("onmessage: " + e.data);
+TestPage.dispatchEventToFrontend("Completed", messages);
+}
+}
+
+// 
+
+function test()
+{
+const suite = InspectorTest.createAsyncSuite("Resource.Type.EventSource");
+
+function addTestCase({name, description, _expression_, resourceHandler}) {
+suite.addTestCase({
+name, description,
+async test() {
+const completeEvent = InspectorTest.awaitEvent("Completed");
+InspectorTest.evaluateInPage(_expression_);
+const event = await 

[webkit-changes] [294373] trunk/Source/WebCore/Modules/WebGPU

[mmaxfield]

Title: [294373] trunk/Source/WebCore/Modules/WebGPU








Revision 294373
Author mmaxfi...@apple.com
Date 2022-05-17 18:09:07 -0700 (Tue, 17 May 2022)


Log Message
[WebGPU] Work around https://bugs.webkit.org/show_bug.cgi?id=240219
https://bugs.webkit.org/show_bug.cgi?id=240441

https://bugs.webkit.org/show_bug.cgi?id=240219 is about a bug where we can't
say "optional thingy = 0" in an IDL file. This patch works around that in WebGPU
by replacing it with "optional thingy" and then "thingy.value_or(0)" in the C++
code. This is temporary, until https://bugs.webkit.org/show_bug.cgi?id=240219 is
fixed.

No new tests because there is no behavior change.

* Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::mapAsync):
(WebCore::GPUBuffer::getMappedRange):
* Modules/WebGPU/GPUBuffer.h:
* Modules/WebGPU/GPUBuffer.idl:

Canonical link: https://commits.webkit.org/250668@main

Modified Paths

trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.h
trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.idl




Diff

Modified: trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp (294372 => 294373)

--- trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp	2022-05-18 00:59:47 UTC (rev 294372)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp	2022-05-18 01:09:07 UTC (rev 294373)
@@ -38,16 +38,16 @@
 m_backing->setLabel(WTFMove(label));
 }
 
-void GPUBuffer::mapAsync(GPUMapModeFlags mode, GPUSize64 offset, std::optional size, MapAsyncPromise&& promise)
+void GPUBuffer::mapAsync(GPUMapModeFlags mode, std::optional offset, std::optional size, MapAsyncPromise&& promise)
 {
-m_backing->mapAsync(convertMapModeFlagsToBacking(mode), offset, size, [promise = WTFMove(promise)] () mutable {
+m_backing->mapAsync(convertMapModeFlagsToBacking(mode), offset.value_or(0), size, [promise = WTFMove(promise)] () mutable {
 promise.resolve(nullptr);
 });
 }
 
-Ref GPUBuffer::getMappedRange(GPUSize64 offset, std::optional size)
+Ref GPUBuffer::getMappedRange(std::optional offset, std::optional size)
 {
-auto mappedRange = m_backing->getMappedRange(offset, size);
+auto mappedRange = m_backing->getMappedRange(offset.value_or(0), size);
 return ArrayBuffer::create(mappedRange.source, mappedRange.byteLength);
 }
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.h (294372 => 294373)

--- trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.h	2022-05-18 00:59:47 UTC (rev 294372)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.h	2022-05-18 01:09:07 UTC (rev 294373)
@@ -49,8 +49,8 @@
 void setLabel(String&&);
 
 using MapAsyncPromise = DOMPromiseDeferred;
-void mapAsync(GPUMapModeFlags, GPUSize64 offset, std::optional sizeForMap, MapAsyncPromise&&);
-Ref getMappedRange(GPUSize64 offset, std::optional rangeSize);
+void mapAsync(GPUMapModeFlags, std::optional offset, std::optional sizeForMap, MapAsyncPromise&&);
+Ref getMappedRange(std::optional offset, std::optional rangeSize);
 void unmap();
 
 void destroy();


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.idl (294372 => 294373)

--- trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.idl	2022-05-18 00:59:47 UTC (rev 294372)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.idl	2022-05-18 01:09:07 UTC (rev 294373)
@@ -35,8 +35,9 @@
 SecureContext
 ]
 interface GPUBuffer {
-Promise mapAsync(GPUMapModeFlags mode, optional GPUSize64 offset = 0, optional GPUSize64 size);
-ArrayBuffer getMappedRange(optional GPUSize64 offset = 0, optional GPUSize64 size);
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=240219 The next two lines should be able to say "optional thingy = 0" instead of just "optional thingy".
+Promise mapAsync(GPUMapModeFlags mode, optional GPUSize64 offset, optional GPUSize64 size);
+ArrayBuffer getMappedRange(optional GPUSize64 offset, optional GPUSize64 size);
 undefined unmap();
 
 undefined destroy();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294372] tags/WebKit-7614.1.14.11.2/

[repstein]

Title: [294372] tags/WebKit-7614.1.14.11.2/








Revision 294372
Author repst...@apple.com
Date 2022-05-17 17:59:47 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.11.2.

Added Paths

tags/WebKit-7614.1.14.11.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294371] trunk/Source/WebKit

[commit-queue]

Title: [294371] trunk/Source/WebKit








Revision 294371
Author commit-qu...@webkit.org
Date 2022-05-17 17:55:16 -0700 (Tue, 17 May 2022)


Log Message
Private relay should fail closed for third party loads if the main resource was loaded over private relay 
https://bugs.webkit.org/show_bug.cgi?id=240483


Patch by Alex Christensen  on 2022-05-17
Reviewed by Chris Dumez.

This re-lands the change from r293861 along with r293481 which should fix problems related to rdar://92336270
along with r293591 which should fix performance regressions related to rdar://92458995 but was insufficient.
During a basic browsing test, I found two more places where we were making a NetworkDataTask without setting the
parameters' top origin, one in the SpeculativeLoad constructor and another in WebLoaderStrategy::preconnectTo.

* Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
* Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):

Modified Paths

trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp




Diff

Modified: trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp (294370 => 294371)

--- trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp	2022-05-18 00:50:46 UTC (rev 294370)
+++ trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp	2022-05-18 00:55:16 UTC (rev 294371)
@@ -75,6 +75,8 @@
 m_loadInformation = NetworkTransactionInformation { NetworkTransactionInformation::Type::Preflight, loadParameters.request, { }, { } };
 
 loadParameters.webPageProxyID = m_parameters.webPageProxyID;
+loadParameters.topOrigin = m_parameters.topOrigin;
+loadParameters.sourceOrigin = m_parameters.sourceOrigin.ptr();
 
 if (auto* networkSession = m_networkProcess->networkSession(m_parameters.sessionID)) {
 m_task = NetworkDataTask::create(*networkSession, *this, WTFMove(loadParameters));


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp (294370 => 294371)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp	2022-05-18 00:50:46 UTC (rev 294370)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp	2022-05-18 00:55:16 UTC (rev 294371)
@@ -67,6 +67,7 @@
 parameters.contentSniffingPolicy = ContentSniffingPolicy::DoNotSniffContent;
 parameters.contentEncodingSniffingPolicy = ContentEncodingSniffingPolicy::Sniff;
 parameters.request = m_originalRequest;
+parameters.topOrigin = SecurityOrigin::create(m_originalRequest.firstPartyForCookies());
 parameters.isNavigatingToAppBoundDomain = isNavigatingToAppBoundDomain;
 m_networkLoad = makeUnique(*this, nullptr, WTFMove(parameters), *networkSession);
 m_networkLoad->startWithScheduling();


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (294370 => 294371)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2022-05-18 00:50:46 UTC (rev 294370)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2022-05-18 00:55:16 UTC (rev 294371)
@@ -340,6 +340,14 @@
 RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
 RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
 
+if (parameters.isMainFrameNavigation
+|| parameters.hadMainFrameMainResourcePrivateRelayed
+|| !parameters.topOrigin
+|| request.url().host() == parameters.topOrigin->host()) {
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+}
+
 #if ENABLE(APP_PRIVACY_REPORT)
 mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
 #endif


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (294370 => 294371)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2022-05-18 00:50:46 UTC (rev 294370)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2022-05-18 00:55:16 UTC (rev 294371)
@@ -936,7 +936,9 @@
 
 

[webkit-changes] [294370] branches/safari-7614.1.14.11-branch/Source

[repstein]

Title: [294370] branches/safari-7614.1.14.11-branch/Source








Revision 294370
Author repst...@apple.com
Date 2022-05-17 17:50:46 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.11.2

Modified Paths

branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 11;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 11;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 11;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 11;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 11;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig (294369 => 294370)

--- branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-18 00:37:45 UTC (rev 294369)
+++ branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-18 00:50:46 UTC (rev 294370)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 

[webkit-changes] [294369] trunk/Source/WebCore/platform/graphics/FontCascade.cpp

[cdumez]

Title: [294369] trunk/Source/WebCore/platform/graphics/FontCascade.cpp








Revision 294369
Author cdu...@apple.com
Date 2022-05-17 17:37:45 -0700 (Tue, 17 May 2022)


Log Message
Stop using ASCIILiteral::fromLiteralUnsafe() in FontCascade.cpp https://bugs.webkit.org/show_bug.cgi?id=240548

Reviewed by Myles C. Maxfield.

Stop using ASCIILiteral::fromLiteralUnsafe() in FontCascade.cpp and use ASCIILiteral
directly.

* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::useBackslashAsYenSignForFamily):

Canonical link: https://commits.webkit.org/250668@main

Modified Paths

trunk/Source/WebCore/platform/graphics/FontCascade.cpp




Diff

Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (294368 => 294369)

--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2022-05-18 00:27:10 UTC (rev 294368)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2022-05-18 00:37:45 UTC (rev 294369)
@@ -53,16 +53,16 @@
 return false;
 static NeverDestroyed set = [] {
 MemoryCompactLookupOnlyRobinHoodHashSet set;
-auto add = [] (const char* name, std::initializer_list unicodeName) {
-set.add(AtomString { ASCIILiteral::fromLiteralUnsafe(name) });
+auto add = [] (ASCIILiteral name, std::initializer_list unicodeName) {
+set.add(AtomString { name });
 unsigned unicodeNameLength = unicodeName.size();
 set.add(AtomString { unicodeName.begin(), unicodeNameLength });
 };
-add("MS PGothic", { 0xFF2D, 0xFF33, 0x0020, 0xFF30, 0x30B4, 0x30B7, 0x30C3, 0x30AF });
-add("MS PMincho", { 0xFF2D, 0xFF33, 0x0020, 0xFF30, 0x660E, 0x671D });
-add("MS Gothic", { 0xFF2D, 0xFF33, 0x0020, 0x30B4, 0x30B7, 0x30C3, 0x30AF });
-add("MS Mincho", { 0xFF2D, 0xFF33, 0x0020, 0x660E, 0x671D });
-add("Meiryo", { 0x30E1, 0x30A4, 0x30EA, 0x30AA });
+add("MS PGothic"_s, { 0xFF2D, 0xFF33, 0x0020, 0xFF30, 0x30B4, 0x30B7, 0x30C3, 0x30AF });
+add("MS PMincho"_s, { 0xFF2D, 0xFF33, 0x0020, 0xFF30, 0x660E, 0x671D });
+add("MS Gothic"_s, { 0xFF2D, 0xFF33, 0x0020, 0x30B4, 0x30B7, 0x30C3, 0x30AF });
+add("MS Mincho"_s, { 0xFF2D, 0xFF33, 0x0020, 0x660E, 0x671D });
+add("Meiryo"_s, { 0x30E1, 0x30A4, 0x30EA, 0x30AA });
 return set;
 }();
 return set.get().contains(family);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294368] branches/safari-7614.1.12-branch/Source

[alancoon]

Title: [294368] branches/safari-7614.1.12-branch/Source








Revision 294368
Author alanc...@apple.com
Date 2022-05-17 17:27:10 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.12.5

Modified Paths

branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.12-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (294367 => 294368)

--- branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-05-18 00:20:12 UTC (rev 294367)
+++ branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-05-18 00:27:10 UTC (rev 294368)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 

[webkit-changes] [294366] tags/WebKit-7614.1.14.0.3/

[alancoon]

Title: [294366] tags/WebKit-7614.1.14.0.3/








Revision 294366
Author alanc...@apple.com
Date 2022-05-17 17:05:39 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.0.3.

Added Paths

tags/WebKit-7614.1.14.0.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294365] tags/WebKit-7614.1.14.1.3/

[alancoon]

Title: [294365] tags/WebKit-7614.1.14.1.3/








Revision 294365
Author alanc...@apple.com
Date 2022-05-17 16:58:25 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.1.3.

Added Paths

tags/WebKit-7614.1.14.1.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294364] trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c

[basuke . suzuki]

Title: [294364] trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c








Revision 294364
Author basuke.suz...@sony.com
Date 2022-05-17 16:54:32 -0700 (Tue, 17 May 2022)


Log Message
[libpas] Suppress warnings for %llu format specifier for uint64_t.
https://bugs.webkit.org/show_bug.cgi?id=240541

Reviewed by Yusuke Suzuki.

Use PRIu64 instead.

* libpas/src/libpas/pas_utils.c:
(pas_assertion_failed_no_inline_with_extra_detail):

Canonical link: https://commits.webkit.org/250667@main

Modified Paths

trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c




Diff

Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c (294363 => 294364)

--- trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c	2022-05-17 23:50:32 UTC (rev 294363)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c	2022-05-17 23:54:32 UTC (rev 294364)
@@ -32,6 +32,7 @@
 #include "pas_lock.h"
 #include "pas_log.h"
 #include "pas_string_stream.h"
+#include 
 #include 
 #include 
 #include 
@@ -113,7 +114,7 @@
 void pas_assertion_failed_no_inline_with_extra_detail(const char* filename, int line, const char* function, const char* _expression_, uint64_t extra)
 {
 pas_log("[%d] pas assertion failed (with extra detail): ", getpid());
-pas_log("%s:%d: %s: assertion %s failed. Extra data: %llu.\n", filename, line, function, _expression_, extra);
+pas_log("%s:%d: %s: assertion %s failed. Extra data: %" PRIu64 ".\n", filename, line, function, _expression_, extra);
 pas_crash_with_info_impl((uint64_t)filename, line, (uint64_t) function, (uint64_t) _expression_, extra, 1337, 0xbeef0bff);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294362] trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

[pvollan]

Title: [294362] trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in








Revision 294362
Author pvol...@apple.com
Date 2022-05-17 16:45:30 -0700 (Tue, 17 May 2022)


Log Message
[macOS][WP] Add required methods to graphics filters
https://bugs.webkit.org/show_bug.cgi?id=240398


Reviewed by Geoffrey Garen.

Add required methods to graphics filters. These have been observed being used in telemetry.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/250665@main

Modified Paths

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (294361 => 294362)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2022-05-17 23:23:29 UTC (rev 294361)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2022-05-17 23:45:30 UTC (rev 294362)
@@ -178,6 +178,7 @@
 41
 42
 43
+46
 48
 49
 256
@@ -256,6 +257,7 @@
 36
 38
 39
+43
 44
 )
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294361] trunk/Source/JavaScriptCore/inspector/remote

[pangle]

Title: [294361] trunk/Source/_javascript_Core/inspector/remote








Revision 294361
Author pan...@apple.com
Date 2022-05-17 16:23:29 -0700 (Tue, 17 May 2022)


Log Message
[Cocoa] Web Driver: `RemoteAutomationTarget`s marked for termination and targets that have never been paired may briefly be indistinguishable in application target listing
https://bugs.webkit.org/show_bug.cgi?id=240524


Reviewed by BJ Burg and Devin Rousso.

A `RemoteAutomationTarget` has multiple possible entries it may provide in an application listing to webinspectord,
which are then interpreted by webinspectord to determine the current state of that target. The key pieces for this bug
are that a `WIRConnectionIdentifierKey` which when present is taken to mean that the target is no longer pristine and
`WIRAutomationTargetIsPairedKey` which when true indicates that the target is paired. When a connection identifier is
present and we are no longer paired, the connection is considered terminated.

There exists a race condition where webinspectord preemptively set the targets state to "Terminated" upon sending a
close request in order to make sure that the target is no longer used. Upon receiving the close message for the target
the connection identifier is removed from the map of known connection identifiers before scheduling the actual target to
be torn down asyncronously. In most cases this works fine, but sometimes an application listing is created and sent
between removing the identifier from the map of known connections and actually tearing down the target, and that is
where this issue occurs. We will in that case send a listing for the automation target with no connection identifier
(since we removed it from the map already), which is then interpreted as a listing for a pristine automation target. At
that point, it is possible that automation sessions that are being rapidly created and destroyed will attempt to pair
with the seemingly pristine existing session, even though that session is about to be torn down.

* Source/_javascript_Core/inspector/remote/RemoteAutomationTarget.h:
* Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:
(Inspector::RemoteConnectionToTarget::close):
* Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::listingForAutomationTarget const):

Canonical link: https://commits.webkit.org/250664@main

Modified Paths

trunk/Source/_javascript_Core/inspector/remote/RemoteAutomationTarget.h
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm




Diff

Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteAutomationTarget.h (294360 => 294361)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteAutomationTarget.h	2022-05-17 23:19:06 UTC (rev 294360)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteAutomationTarget.h	2022-05-17 23:23:29 UTC (rev 294361)
@@ -41,6 +41,9 @@
 bool isPaired() const { return m_paired; }
 void setIsPaired(bool);
 
+bool isPendingTermination() const { return m_pendingTermination; }
+void setIsPendingTermination() { m_pendingTermination = true; }
+
 virtual String name() const = 0;
 RemoteControllableTarget::Type type() const override { return RemoteControllableTarget::Type::Automation; }
 bool remoteControlAllowed() const override { return !m_paired; };
@@ -47,6 +50,7 @@
 
 private:
 bool m_paired { false };
+bool m_pendingTermination { false };
 };
 
 } // namespace Inspector


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm (294360 => 294361)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm	2022-05-17 23:19:06 UTC (rev 294360)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm	2022-05-17 23:23:29 UTC (rev 294361)
@@ -198,6 +198,9 @@
 void RemoteConnectionToTarget::close()
 {
 auto targetIdentifier = m_target ? m_target->targetIdentifier() : 0;
+
+if (auto* automationTarget = dynamicDowncast(m_target))
+automationTarget->setIsPendingTermination();
 
 dispatchAsyncOnTarget([this, targetIdentifier, strongThis = Ref { *this }]() {
 Locker locker { m_targetMutex };


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (294360 => 294361)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2022-05-17 23:19:06 UTC (rev 294360)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2022-05-17 23:23:29 UTC (rev 294361)
@@ -466,6 +466,9 @@
 // implemented by non-threadsafe JSC / WebCore classes such as JSGlobalObject or WebCore::Page.
 ASSERT(isMainThread());
 
+if (target.isPendingTermination())
+return nullptr;
+
 RetainPtr listing = adoptNS([[NSMutableDictionary alloc] init]);
   

[webkit-changes] [294360] releases/WebKitGTK/webkit-2.36.2/

[aperez]

Title: [294360] releases/WebKitGTK/webkit-2.36.2/








Revision 294360
Author ape...@igalia.com
Date 2022-05-17 16:19:06 -0700 (Tue, 17 May 2022)


Log Message
WebKitGTK 2.36.2

Added Paths

releases/WebKitGTK/webkit-2.36.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294358] trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script

[aperez]

Title: [294358] trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script








Revision 294358
Author ape...@igalia.com
Date 2022-05-17 16:17:48 -0700 (Tue, 17 May 2022)


Log Message
[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543

Reviewed by Michael Catanzaro.

* Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
  shebang to use "python3", and pass an "encoding" argument to the Popen
  constructor to read strings instead of bytes from the subprocess pipe.

Canonical link: https://commits.webkit.org/250663@main

Modified Paths

trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script




Diff

Modified: trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script (294357 => 294358)

--- trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:45 UTC (rev 294357)
+++ trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:48 UTC (rev 294358)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import subprocess
 import sys
@@ -25,7 +25,7 @@
 
 
 symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
 data = ""
 
 symbols = []






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294359] releases/WebKitGTK/webkit-2.36

[aperez]

Title: [294359] releases/WebKitGTK/webkit-2.36








Revision 294359
Author ape...@igalia.com
Date 2022-05-17 16:17:50 -0700 (Tue, 17 May 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.2 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.36.2.

Modified Paths

releases/WebKitGTK/webkit-2.36/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (294358 => 294359)

--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-05-17 23:17:48 UTC (rev 294358)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-05-17 23:17:50 UTC (rev 294359)
@@ -1,3 +1,9 @@
+2022-05-17  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.2 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-04-21  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.1 release


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (294358 => 294359)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-05-17 23:17:48 UTC (rev 294358)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-05-17 23:17:50 UTC (rev 294359)
@@ -1,3 +1,9 @@
+2022-05-17  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.2 release
+
+* gtk/NEWS: Add release notes for 2.36.2.
+
 2022-04-02  Yury Semikhatsky  
 
 GTK doesn't compile with ENABLE_ACCESSIBILITY=0


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS (294358 => 294359)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-05-17 23:17:48 UTC (rev 294358)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-05-17 23:17:50 UTC (rev 294359)
@@ -1,4 +1,15 @@
 
+WebKitGTK 2.36.2
+
+
+What's new in WebKitGTK 2.36.2?
+
+  - Fix some pages showing empty content boxes when using GTK4.
+  - Fix the build with accessibility disabled.
+  - Fix the build with newer Ruby versions.
+  - Fix several crashes and rendering issues.
+
+
 WebKitGTK 2.36.1
 
 


Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake (294358 => 294359)

--- releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-05-17 23:17:48 UTC (rev 294358)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-05-17 23:17:50 UTC (rev 294359)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 36 1)
+SET_PROJECT_VERSION(2 36 2)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 5 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 5 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 6 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 6 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 5 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 5 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 6 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 6 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294356] releases/WebKitGTK/webkit-2.36/Tools

[aperez]

Title: [294356] releases/WebKitGTK/webkit-2.36/Tools








Revision 294356
Author ape...@igalia.com
Date 2022-05-17 16:17:39 -0700 (Tue, 17 May 2022)


Log Message
Merge r290799 - [Python3] Switch a few more glib scripts to Python3
https://bugs.webkit.org/show_bug.cgi?id=237442

Reviewed by Adrian Perez de Castro.

* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
shebang.
(bss_symbols): Decode Popen bytes output.
* gtk/jhbuildrc: Update shebang.
* gtk/ycm_extra_conf.py: Ditto.
* jhbuild/jhbuild-wrapper: Ditto.
(jhbuild_at_expected_revision): Decode Popen bytes output.
* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
* wpe/jhbuildrc: Update shebang.

Modified Paths

releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs
releases/WebKitGTK/webkit-2.36/Tools/gtk/jhbuildrc
releases/WebKitGTK/webkit-2.36/Tools/gtk/ycm_extra_conf.py
releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuild-wrapper
releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuildrc_common.py
releases/WebKitGTK/webkit-2.36/Tools/wpe/jhbuildrc




Diff

Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,3 +1,20 @@
+2022-03-03  Lauro Moura  
+
+[Python3] Switch a few more glib scripts to Python3
+https://bugs.webkit.org/show_bug.cgi?id=237442
+
+Reviewed by Adrian Perez de Castro.
+
+* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
+shebang.
+(bss_symbols): Decode Popen bytes output.
+* gtk/jhbuildrc: Update shebang.
+* gtk/ycm_extra_conf.py: Ditto.
+* jhbuild/jhbuild-wrapper: Ditto.
+(jhbuild_at_expected_revision): Decode Popen bytes output.
+* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
+* wpe/jhbuildrc: Update shebang.
+
 2022-04-21  Carlos Garcia Campos  
 
 [GTK][WPE] Make make-dist script python3 only


Modified: releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import re
 import subprocess
@@ -10,7 +10,7 @@
 data = ""
 pattern = re.compile('^[0-9a-f]+ ([a-zA-Z ])[a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ] \.bss\t[0-9a-f]+ +(.*)$')
 for line in data.splitlines():
-m = pattern.match(line)
+m = pattern.match(line.decode('utf-8', 'ignore'))
 if not m:
 continue
 if sfilter is None or sfilter(m.group(1)):


Modified: releases/WebKitGTK/webkit-2.36/Tools/gtk/jhbuildrc (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/gtk/jhbuildrc	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/gtk/jhbuildrc	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011-2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or


Modified: releases/WebKitGTK/webkit-2.36/Tools/gtk/ycm_extra_conf.py (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/gtk/ycm_extra_conf.py	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/gtk/ycm_extra_conf.py	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2013 Danilo Cesar Lemes de Paula 
 # Copyright (C) 2014 ChangSeok Oh 
 #


Modified: releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuild-wrapper (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuild-wrapper	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuild-wrapper	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011 Igalia S.L.
 # Copyright (C) 2012 Gustavo Noronha Silva 
 # Copyright (C) 2012 Intel Corporation
@@ -59,7 +59,7 @@
 if process.returncode != 0:
 raise Exception('failed to find jhbuild revision: %s' % err)
 
-return output.strip() == jhbuild_revision
+return output.strip().decode('utf-8', 'ignore') == jhbuild_revision
 
 
 def update_jhbuild():


Modified: releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuildrc_common.py (294355 => 294356)

--- releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuildrc_common.py	2022-05-17 22:41:45 UTC (rev 294355)
+++ releases/WebKitGTK/webkit-2.36/Tools/jhbuild/jhbuildrc_common.py	2022-05-17 23:17:39 UTC (rev 294356)
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # Copyright 

[webkit-changes] [294357] releases/WebKitGTK/webkit-2.36/Tools

[aperez]

Title: [294357] releases/WebKitGTK/webkit-2.36/Tools








Revision 294357
Author ape...@igalia.com
Date 2022-05-17 16:17:45 -0700 (Tue, 17 May 2022)


Log Message
Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543

Unreviewed build fix.

* Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
shebang to use "python3", and pass an "encoding" argument to the Popen
constructor to read strings instead of bytes from the subprocess pipe.

Modified Paths

releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script




Diff

Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (294356 => 294357)

--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 23:17:39 UTC (rev 294356)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 23:17:45 UTC (rev 294357)
@@ -1,3 +1,14 @@
+2022-05-17  Adrian Perez de Castro  
+
+Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
+https://bugs.webkit.org/show_bug.cgi?id=240543
+
+Unreviewed build fix.
+
+* Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
+shebang to use "python3", and pass an "encoding" argument to the Popen
+constructor to read strings instead of bytes from the subprocess pipe.
+
 2022-03-03  Lauro Moura  
 
 [Python3] Switch a few more glib scripts to Python3


Modified: releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script (294356 => 294357)

--- releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:39 UTC (rev 294356)
+++ releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:45 UTC (rev 294357)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import subprocess
 import sys
@@ -25,7 +25,7 @@
 
 
 symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
 data = ""
 
 symbols = []






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294355] trunk/Source/WebKit/WebProcess/GPU/graphics/ RemoteImageBufferProxy.h

[mattwoodrow]

Title: [294355] trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h








Revision 294355
Author mattwood...@apple.com
Date 2022-05-17 15:41:45 -0700 (Tue, 17 May 2022)


Log Message
Don't synchronously flush when destroying RemoteImageBufferProxy

Reviewed by Said Abou-Hallawa.

No correctness tests added, since this should just be a performance improvement.

* WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):

Modified Paths

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h




Diff

Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (294354 => 294355)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2022-05-17 22:31:25 UTC (rev 294354)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2022-05-17 22:41:45 UTC (rev 294355)
@@ -69,7 +69,7 @@
 return;
 }
 
-flushDrawingContext();
+flushDrawingContextAsync();
 m_remoteRenderingBackendProxy->remoteResourceCacheProxy().releaseImageBuffer(m_renderingResourceIdentifier);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294354] trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/ html/semantics/forms/constraints/

[rackler]

Title: [294354] trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/








Revision 294354
Author rack...@apple.com
Date 2022-05-17 15:31:25 -0700 (Tue, 17 May 2022)


Log Message
[Gardening]: REGRESSION (r294317): [ iOS ] Eight imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240538

Unreviewed test gardening.

* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.

Canonical link: https://commits.webkit.org/250661@main

Removed Paths

trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294352] tags/WebKit-7614.1.12.4/

[alancoon]

Title: [294352] tags/WebKit-7614.1.12.4/








Revision 294352
Author alanc...@apple.com
Date 2022-05-17 15:08:44 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.12.4.

Added Paths

tags/WebKit-7614.1.12.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294349] branches/safari-7614.1.14.1-branch

[alancoon]

Title: [294349] branches/safari-7614.1.14.1-branch








Revision 294349
Author alanc...@apple.com
Date 2022-05-17 14:34:55 -0700 (Tue, 17 May 2022)


Log Message
Cherry-pick r294285. rdar://problem/93385094

Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094

Reviewed by Tim Horton.

This method was only intended for use in MiniBrowser, and should ship as public API on WKWebView. Move the
declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
(respectively), and additionally prefix this testing-only SPI with an underscore.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
* UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
* UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _retrieveAccessibilityTreeData:]):
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094

Reviewed by Tim Horton.

See WebKit/ChangeLog for more details.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController logAccessibilityTrees:]):

Canonical link: https://commits.webkit.org/250629@main

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm
branches/safari-7614.1.14.1-branch/Tools/ChangeLog
branches/safari-7614.1.14.1-branch/Tools/MiniBrowser/mac/WK2BrowserWindowController.m




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog (294348 => 294349)

--- branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog	2022-05-17 21:34:51 UTC (rev 294348)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog	2022-05-17 21:34:55 UTC (rev 294349)
@@ -1,5 +1,60 @@
 2022-05-17  Alan Coon  
 
+Cherry-pick r294285. rdar://problem/93385094
+
+Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
+https://bugs.webkit.org/show_bug.cgi?id=240494
+rdar://93385094
+
+Reviewed by Tim Horton.
+
+This method was only intended for use in MiniBrowser, and should ship as public API on WKWebView. Move the
+declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
+(respectively), and additionally prefix this testing-only SPI with an underscore.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
+* UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
+* UIProcess/API/mac/WKWebViewTestingMac.mm:
+(-[WKWebView _retrieveAccessibilityTreeData:]):
+Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
+https://bugs.webkit.org/show_bug.cgi?id=240494
+rdar://93385094
+
+Reviewed by Tim Horton.
+
+See WebKit/ChangeLog for more details.
+
+* MiniBrowser/mac/WK2BrowserWindowController.m:
+(-[WK2BrowserWindowController logAccessibilityTrees:]):
+
+Canonical link: https://commits.webkit.org/250629@main
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-16  Wenson Hsieh  
+
+Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
+https://bugs.webkit.org/show_bug.cgi?id=240494
+rdar://93385094
+
+Reviewed by Tim Horton.
+
+This method was only intended for use in MiniBrowser, and should not ship as public API on WKWebView. Move the
+declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
+(respectively), and additionally prefix this testing-only SPI with an underscore.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
+* UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
+* UIProcess/API/mac/WKWebViewTestingMac.mm:
+(-[WKWebView _retrieveAccessibilityTreeData:]):
+
+2022-05-17  Alan Coon  
+
 Cherry-pick r294190. rdar://problem/91006582
 
 SharedBuffer should be copied and then attributed back to WebContent


Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h (294348 => 294349)

--- 

[webkit-changes] [294347] branches/safari-7614.1.14.1-branch/Source/WebKit

[alancoon]

Title: [294347] branches/safari-7614.1.14.1-branch/Source/WebKit








Revision 294347
Author alanc...@apple.com
Date 2022-05-17 14:31:47 -0700 (Tue, 17 May 2022)


Log Message
Cherry-pick r294175. rdar://problem/91441895

[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
https://bugs.webkit.org/show_bug.cgi?id=240393
rdar://91441895

Reviewed by Wenson Hsieh.

Some WebKit clients use SPI on WKWebView to support "find from selection"
functionality (the Cmd+E shortcut). However, to support general
find functionality, they use new find API that uses a different codepath
to draw highlights. Mixing use of the API and SPI can currently result
in two highlights showing up.

To fix, ensure SPI highlights are removed once the API is being used.
The long term solution is for clients to adopt API for the
"find from selection" functionality, but in the short term the SPI
should remain supported.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::clearAllDecoratedFoundText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog (294346 => 294347)

--- branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog	2022-05-17 21:24:05 UTC (rev 294346)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog	2022-05-17 21:31:47 UTC (rev 294347)
@@ -1,3 +1,52 @@
+2022-05-17  Alan Coon  
+
+Cherry-pick r294175. rdar://problem/91441895
+
+[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
+https://bugs.webkit.org/show_bug.cgi?id=240393
+rdar://91441895
+
+Reviewed by Wenson Hsieh.
+
+Some WebKit clients use SPI on WKWebView to support "find from selection"
+functionality (the Cmd+E shortcut). However, to support general
+find functionality, they use new find API that uses a different codepath
+to draw highlights. Mixing use of the API and SPI can currently result
+in two highlights showing up.
+
+To fix, ensure SPI highlights are removed once the API is being used.
+The long term solution is for clients to adopt API for the
+"find from selection" functionality, but in the short term the SPI
+should remain supported.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::clearAllDecoratedFoundText):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-13  Aditya Keerthi  
+
+[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
+https://bugs.webkit.org/show_bug.cgi?id=240393
+rdar://91441895
+
+Reviewed by Wenson Hsieh.
+
+Some WebKit clients use SPI on WKWebView to support "find from selection"
+functionality (the Cmd+E shortcut). However, to support general
+find functionality, they use new find API that uses a different codepath
+to draw highlights. Mixing use of the API and SPI can currently result
+in two highlights showing up.
+
+To fix, ensure SPI highlights are removed once the API is being used.
+The long term solution is for clients to adopt API for the
+"find from selection" functionality, but in the short term the SPI
+should remain supported.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::clearAllDecoratedFoundText):
+
 2022-05-16  Russell Epstein  
 
 Cherry-pick r294264. rdar://problem/93118830


Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp (294346 => 294347)

--- branches/safari-7614.1.14.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-05-17 21:24:05 UTC (rev 294346)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-05-17 21:31:47 UTC (rev 294347)
@@ -4875,6 +4875,7 @@
 
 void WebPage::clearAllDecoratedFoundText()
 {
+hideFindUI();
 foundTextRangeController().clearAllDecoratedFoundText();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294345] branches/safari-7614.1.14.1-branch/Source

[alancoon]

Title: [294345] branches/safari-7614.1.14.1-branch/Source








Revision 294345
Author alanc...@apple.com
Date 2022-05-17 14:23:03 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.1.3

Modified Paths

branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig (294344 => 294345)

--- branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
+++ branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-17 21:23:03 UTC (rev 294345)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;

[webkit-changes] [294344] branches/safari-7614.1.14.0-branch/Source

[alancoon]

Title: [294344] branches/safari-7614.1.14.0-branch/Source








Revision 294344
Author alanc...@apple.com
Date 2022-05-17 14:18:22 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.0.3

Modified Paths

branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig (294343 => 294344)

--- branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-17 21:12:01 UTC (rev 294343)
+++ branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-17 21:18:22 UTC (rev 294344)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 0;

[webkit-changes] [294343] tags/WebKit-7614.1.14.1.2/

[alancoon]

Title: [294343] tags/WebKit-7614.1.14.1.2/








Revision 294343
Author alanc...@apple.com
Date 2022-05-17 14:12:01 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.1.2.

Added Paths

tags/WebKit-7614.1.14.1.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294342] trunk/metadata/contributors.json

[yurys]

Title: [294342] trunk/metadata/contributors.json








Revision 294342
Author yu...@chromium.org
Date 2022-05-17 14:11:55 -0700 (Tue, 17 May 2022)


Log Message
Add my github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240539

Reviewed by Jonathan Bedard.

* metadata/contributors.json: add my github username.

Canonical link: https://commits.webkit.org/250657@main

Modified Paths

trunk/metadata/contributors.json




Diff

Modified: trunk/metadata/contributors.json (294341 => 294342)

--- trunk/metadata/contributors.json	2022-05-17 20:42:58 UTC (rev 294341)
+++ trunk/metadata/contributors.json	2022-05-17 21:11:55 UTC (rev 294342)
@@ -7067,6 +7067,7 @@
  "yu...@chromium.org"
   ],
   "expertise" : "Developer Tools, Web Inspector",
+  "github" : "yury-s",
   "name" : "Yury Semikhatsky",
   "nicks" : [
  "yurys"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294341] tags/WebKit-7614.1.14.11.1/

[repstein]

Title: [294341] tags/WebKit-7614.1.14.11.1/








Revision 294341
Author repst...@apple.com
Date 2022-05-17 13:42:58 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.11.1.

Added Paths

tags/WebKit-7614.1.14.11.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294340] branches/safari-7614.1.14.11-branch/Source

[alancoon]

Title: [294340] branches/safari-7614.1.14.11-branch/Source








Revision 294340
Author alanc...@apple.com
Date 2022-05-17 13:37:49 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.11.1

Modified Paths

branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294339 => 294340)

--- branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 20:22:34 UTC (rev 294339)
+++ branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 20:37:49 UTC (rev 294340)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294339 => 294340)

--- branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 20:22:34 UTC (rev 294339)
+++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 20:37:49 UTC (rev 294340)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294339 => 294340)

--- branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 20:22:34 UTC (rev 294339)
+++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 20:37:49 UTC (rev 294340)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig (294339 => 294340)

--- branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 20:22:34 UTC (rev 294339)
+++ branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 20:37:49 UTC (rev 294340)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294339 => 294340)

--- branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 20:22:34 UTC (rev 294339)
+++ branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 20:37:49 UTC (rev 294340)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;

[webkit-changes] [294339] trunk/LayoutTests/platform/ios-wk2/TestExpectations

[jenner]

Title: [294339] trunk/LayoutTests/platform/ios-wk2/TestExpectations








Revision 294339
Author jen...@apple.com
Date 2022-05-17 13:22:34 -0700 (Tue, 17 May 2022)


Log Message
[ Gardening ] REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure (240352)
https://bugs.webkit.org/show_bug.cgi?id=240352

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/250656@main

Modified Paths

trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (294338 => 294339)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-05-17 20:15:52 UTC (rev 294338)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-05-17 20:22:34 UTC (rev 294339)
@@ -2237,3 +2237,5 @@
 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/simulated-click-inert.html [ Failure ]
 
 fast/text/install-font-style-recalc.html [ Pass ]
+
+webkit.org/b/240352 system-preview/badge.html [ ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294338] branches/safari-7614.1.14.11-branch/

[repstein]

Title: [294338] branches/safari-7614.1.14.11-branch/








Revision 294338
Author repst...@apple.com
Date 2022-05-17 13:15:52 -0700 (Tue, 17 May 2022)


Log Message
New branch.

Added Paths

branches/safari-7614.1.14.11-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294337] tags/WebKit-7614.1.14.0.2/

[alancoon]

Title: [294337] tags/WebKit-7614.1.14.0.2/








Revision 294337
Author alanc...@apple.com
Date 2022-05-17 13:12:22 -0700 (Tue, 17 May 2022)


Log Message
Tag WebKit-7614.1.14.0.2.

Added Paths

tags/WebKit-7614.1.14.0.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294336] trunk/Tools/CISupport/ews-build

[jbedard]

Title: [294336] trunk/Tools/CISupport/ews-build








Revision 294336
Author jbed...@apple.com
Date 2022-05-17 13:10:39 -0700 (Tue, 17 May 2022)


Log Message
Forbid ChangeLog modification (Follow-up fix) 
https://bugs.webkit.org/show_bug.cgi?id=240461


Reviewed by Aakash Jain.

Run Canonicalize on committed patches.

* Tools/CISupport/ews-build/steps.py:
(Canonicalize.doStepIf): Deleted.
(Canonicalize.hideStepIf): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (294335 => 294336)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-05-17 19:58:18 UTC (rev 294335)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-05-17 20:10:39 UTC (rev 294336)
@@ -5116,13 +5116,7 @@
 return {'step': f'Failed to canonicalize {commit_pluralized}'}
 return super(Canonicalize, self).getResultSummary()
 
-def doStepIf(self, step):
-return self.getProperty('github.number', False)
 
-def hideStepIf(self, results, step):
-return not self.doStepIf(step)
-
-
 class PushPullRequestBranch(shell.ShellCommand):
 name = 'push-pull-request-branch'
 haltOnFailure = True


Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (294335 => 294336)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-05-17 19:58:18 UTC (rev 294335)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-05-17 20:10:39 UTC (rev 294336)
@@ -6206,10 +6206,29 @@
 def tearDown(self):
 return self.tearDownBuildStep()
 
-def test_skipped_patch(self):
+def test_patch(self):
 self.setupStep(Canonicalize())
 self.setProperty('patch_id', '1234')
-self.expectOutcome(result=SKIPPED, state_string='Canonicalize Commit (skipped)')
+
+self.expectRemoteCommands(
+ExpectShell(
+workdir='wkdir',
+timeout=300,
+logEnviron=False,
+command=['git', 'pull', 'origin', 'main', '--rebase'],
+) + 0, ExpectShell(
+workdir='wkdir',
+timeout=300,
+logEnviron=False,
+command=['git', 'checkout', 'main'],
+) + 0, ExpectShell(
+workdir='wkdir',
+timeout=300,
+logEnviron=False,
+command=['python3', 'Tools/Scripts/git-webkit', 'canonicalize', '-n', '1'],
+) + 0,
+)
+self.expectOutcome(result=SUCCESS, state_string='Canonicalized commit')
 return self.runStep()
 
 def test_success(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294335] branches/safari-7614.1.13-branch/Source

[repstein]

Title: [294335] branches/safari-7614.1.13-branch/Source








Revision 294335
Author repst...@apple.com
Date 2022-05-17 12:58:18 -0700 (Tue, 17 May 2022)


Log Message
Versioning.

WebKit-7614.1.13.5

Modified Paths

branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.13-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294334 => 294335)

--- branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 19:46:29 UTC (rev 294334)
+++ branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-17 19:58:18 UTC (rev 294335)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
-MICRO_VERSION = 0;
+TINY_VERSION = 13;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294334 => 294335)

--- branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 19:46:29 UTC (rev 294334)
+++ branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-17 19:58:18 UTC (rev 294335)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
-MICRO_VERSION = 0;
+TINY_VERSION = 13;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294334 => 294335)

--- branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 19:46:29 UTC (rev 294334)
+++ branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-17 19:58:18 UTC (rev 294335)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
-MICRO_VERSION = 0;
+TINY_VERSION = 13;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig (294334 => 294335)

--- branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 19:46:29 UTC (rev 294334)
+++ branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-17 19:58:18 UTC (rev 294335)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
-MICRO_VERSION = 0;
+TINY_VERSION = 13;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294334 => 294335)

--- branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 19:46:29 UTC (rev 294334)
+++ branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-17 19:58:18 UTC (rev 294335)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
-MICRO_VERSION = 0;
+TINY_VERSION = 13;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
-FULL_VERSION = 

[webkit-changes] [294334] trunk/Source/WebCore/platform/mediastream/mac/ MockAudioSharedUnit.mm

[commit-queue]

Title: [294334] trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm








Revision 294334
Author commit-qu...@webkit.org
Date 2022-05-17 12:46:29 -0700 (Tue, 17 May 2022)


Log Message
MockAudioSharedInternalUnit::render should return kAudio_ParamError if input buffer is too small
https://bugs.webkit.org/show_bug.cgi?id=240518
rdar://93409662

Patch by Youenn Fablet  on 2022-05-17
Reviewed by Eric Carlson.

The input buffer given to render should be large enough to copy enough frameCount samples.
If that is not the case, mimick what the real audio unit is doing and return kAudio_ParamError.
We also more closely mimick the real audio unit by sending chunks of at most AudioSession::sharedSession().bufferSize().

Covered by existing tests.

* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
(WebCore::MockAudioSharedInternalUnit::render):

Canonical link: https://commits.webkit.org/250654@main

Modified Paths

trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm




Diff

Modified: trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm (294333 => 294334)

--- trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm	2022-05-17 19:39:36 UTC (rev 294333)
+++ trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm	2022-05-17 19:46:29 UTC (rev 294334)
@@ -320,7 +320,7 @@
 reconfigure();
 
 uint32_t totalFrameCount = alignTo16Bytes(delta.seconds() * sampleRate());
-uint32_t frameCount = std::min(totalFrameCount, m_maximiumFrameCount);
+uint32_t frameCount = std::min(totalFrameCount, static_cast(AudioSession::sharedSession().bufferSize()));
 
 while (frameCount) {
 uint32_t bipBopStart = m_samplesRendered % m_bipBopBuffer.size();
@@ -334,7 +334,7 @@
 emitSampleBuffers(bipBopCount);
 m_samplesRendered += bipBopCount;
 totalFrameCount -= bipBopCount;
-frameCount = std::min(totalFrameCount, m_maximiumFrameCount);
+frameCount = std::min(totalFrameCount, static_cast(AudioSession::sharedSession().bufferSize()));
 }
 }
 
@@ -344,10 +344,15 @@
 if (buffer->mNumberBuffers > sourceBuffer->mNumberBuffers)
 return kAudio_ParamError;
 
+auto copySize = frameCount * m_streamFormat.mBytesPerPacket;
 for (uint32_t i = 0; i < buffer->mNumberBuffers; i++) {
+ASSERT(copySize <= sourceBuffer->mBuffers[i].mDataByteSize);
+if (copySize > buffer->mBuffers[i].mDataByteSize)
+return kAudio_ParamError;
+
 auto* source = static_cast(sourceBuffer->mBuffers[i].mData);
 auto* destination = static_cast(buffer->mBuffers[i].mData);
-memcpy(destination, source, frameCount * m_streamFormat.mBytesPerPacket);
+memcpy(destination, source, copySize);
 }
 
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294333] trunk/ReadMe.md

[ap]

Title: [294333] trunk/ReadMe.md








Revision 294333
Author a...@apple.com
Date 2022-05-17 12:39:36 -0700 (Tue, 17 May 2022)


Log Message
Clearly recommend checking out from GitHub using https
https://bugs.webkit.org/show_bug.cgi?id=240528

Reviewed by Jonathan Bedard.

* ReadMe.md:

Canonical link: https://commits.webkit.org/250653@main

Modified Paths

trunk/ReadMe.md




Diff

Modified: trunk/ReadMe.md (294332 => 294333)

--- trunk/ReadMe.md	2022-05-17 19:09:56 UTC (rev 294332)
+++ trunk/ReadMe.md	2022-05-17 19:39:36 UTC (rev 294333)
@@ -27,12 +27,6 @@
 Run the following command to clone WebKit's Git SVN repository:
 
 ```
-git clone g...@github.com:WebKit/WebKit.git WebKit
-```
-
-or
-
-```
 git clone https://github.com/WebKit/WebKit.git WebKit
 ```
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294332] trunk

[j_pascoe]

Title: [294332] trunk








Revision 294332
Author j_pas...@apple.com
Date 2022-05-17 12:09:56 -0700 (Tue, 17 May 2022)


Log Message
[WebAuthn] Add SPI to update platform credential's displayName
https://bugs.webkit.org/show_bug.cgi?id=240471


Reviewed by Brent Fulgham.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
Updated API test.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]):
(+[_WKWebAuthenticationPanel setDisplayNameForLocalCredentialWithGroupAndID:credential:displayName:]):
This change introduces setDisplayNameForLocalCredentialWithGroupAndID, which will supercede
the existing setUsernameForLocalCredentialWithGroupAndID once all callers are updated.

Canonical link: https://commits.webkit.org/250652@main

Modified Paths

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h (294331 => 294332)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h	2022-05-17 19:02:27 UTC (rev 294331)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h	2022-05-17 19:09:56 UTC (rev 294332)
@@ -128,6 +128,7 @@
 + (void)clearAllLocalAuthenticatorCredentials WK_API_AVAILABLE(macos(12.0), ios(15.0));
 + (void)setUsernameForLocalCredentialWithID:(NSData *)credentialID username: (NSString *)username WK_API_AVAILABLE(macos(12.0), ios(15.0));
 + (void)setUsernameForLocalCredentialWithGroupAndID:(NSString * _Nullable)group credential:(NSData *)credentialID username: (NSString *)username WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
++ (void)setDisplayNameForLocalCredentialWithGroupAndID:(NSString * _Nullable)group credential:(NSData *)credentialID displayName: (NSString *)displayName WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 + (NSData *)exportLocalAuthenticatorCredentialWithID:(NSData *)credentialID error:(NSError **)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 + (NSData *)exportLocalAuthenticatorCredentialWithGroupAndID:(NSString * _Nullable)group credential:(NSData *)credentialID error:(NSError **)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (294331 => 294332)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2022-05-17 19:02:27 UTC (rev 294331)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2022-05-17 19:09:56 UTC (rev 294332)
@@ -363,6 +363,7 @@
 [self setUsernameForLocalCredentialWithGroupAndID:nil credential:credentialID username:username];
 }
 
+// rdar://93366441 - Remove this method once callers updated
 + (void)setUsernameForLocalCredentialWithGroupAndID:(NSString *)group credential:(NSData *)credentialID username: (NSString *)username
 {
 #if ENABLE(WEB_AUTHN)
@@ -428,7 +429,71 @@
 #endif
 }
 
++ (void)setDisplayNameForLocalCredentialWithGroupAndID:(NSString *)group credential:(NSData *)credentialID displayName: (NSString *)displayName
+{
 #if ENABLE(WEB_AUTHN)
+auto query = adoptNS([[NSMutableDictionary alloc] init]);
+[query setDictionary:@{
+(__bridge id)kSecClass: bridge_id_cast(kSecClassKey),
+(__bridge id)kSecReturnAttributes: @YES,
+(__bridge id)kSecAttrApplicationLabel: credentialID,
+(__bridge id)kSecReturnPersistentRef : bridge_id_cast(kCFBooleanTrue),
+(__bridge id)kSecAttrSynchronizable: (id)kSecAttrSynchronizableAny,
+(__bridge id)kSecUseDataProtectionKeychain: @YES
+}];
+updateQueryForGroupIfNecessary(query.get(), group);
+
+CFTypeRef attributesArrayRef = nullptr;
+OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query.get(), );
+if (status && status != errSecItemNotFound) {
+ASSERT_NOT_REACHED();
+return;
+}
+NSDictionary *attributes = (__bridge NSDictionary *)attributesArrayRef;
+auto decodedResponse = cbor::CBORReader::read(vectorFromNSData(attributes[bridge_id_cast(kSecAttrApplicationTag)]));
+if (!decodedResponse || !decodedResponse->isMap()) {
+ASSERT_NOT_REACHED();
+return;
+}
+auto& previousUserMap = decodedResponse->getMap();
+
+bool nameSet = false;
+cbor::CBORValue::MapValue updatedUserMap;
+for (auto it = previousUserMap.begin(); it != previousUserMap.end(); ++it) {
+if (it->first.isString() && it->first.getString() == fido::kDisplayNameMapKey) {
+if (displayName)
+updatedUserMap[it->first.clone()] = cbor::CBORValue(String(displayName));
+nameSet = true;
+} else
+

[webkit-changes] [294331] trunk

[j_pascoe]

Title: [294331] trunk








Revision 294331
Author j_pas...@apple.com
Date 2022-05-17 12:02:27 -0700 (Tue, 17 May 2022)


Log Message
[WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator
https://bugs.webkit.org/show_bug.cgi?id=240459


Reviewed by Brent Fulgham.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
(TestWebKitAPI::TEST):
Updated API test to account for displayName.
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):

Canonical link: https://commits.webkit.org/250651@main

Modified Paths

trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (294330 => 294331)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm	2022-05-17 17:53:44 UTC (rev 294330)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm	2022-05-17 19:02:27 UTC (rev 294331)
@@ -187,6 +187,9 @@
 response->setGroup(group);
 if ([[attributes allKeys] containsObject:bridge_cast(kSecAttrSynchronizable)])
 response->setSynchronizable([attributes[(id)kSecAttrSynchronizable] isEqual:@YES]);
+it = responseMap.find(CBOR(fido::kDisplayNameMapKey));
+if (it != responseMap.end() && it->second.isString())
+response->setDisplayName(it->second.getString());
 
 result.uncheckedAppend(WTFMove(response));
 }


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm (294330 => 294331)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm	2022-05-17 17:53:44 UTC (rev 294330)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm	2022-05-17 19:02:27 UTC (rev 294331)
@@ -83,6 +83,7 @@
 static String testUserEntityBundleBase64 = "omJpZEoAAQIDBAUGBwgJZG5hbWVkSm9obg=="_s; // { "id": h'00010203040506070809', "name": "John" }
 static String testUserEntityBundleNoUserHandleBase64 = "oWRuYW1lbE1DIE5vLUhhbmRsZQ=="_s; // {"name": "MC No-Handle"}
 static String webAuthenticationPanelSelectedCredentialName;
+static String webAuthenticationPanelSelectedCredentialDisplayName;
 static String testWebKitAPIAccessGroup = "com.apple.TestWebKitAPI"_s;
 static String testWebKitAPIAlternateAccessGroup = "com.apple.TestWebKitAPIAlternate"_s;
 static bool laContextRequested = false;
@@ -174,6 +175,7 @@
 [object setLAContext:laContext.get()];
 
 webAuthenticationPanelSelectedCredentialName = object.name;
+webAuthenticationPanelSelectedCredentialDisplayName = object.displayName;
 completionHandler(object);
 return;
 }
@@ -1510,7 +1512,7 @@
 [webView focus];
 
 ASSERT_TRUE(addKeyToKeychain(testES256PrivateKeyBase64, emptyString(), testUserEntityBundleBase64));
-ASSERT_TRUE(addKeyToKeychain("BBRoi2JbR0IXTeJmvXUp1YIuM4sph/Lu3eGf75F7n+HojHKG70a4R0rB2PQce5/SJle6T7OO5Cqet/LJZVM6NQ8yDDxWvayf71GTDp2yUtuIbqJLFVbpWymlj9WRizgX3A=="_s, emptyString(), "omJpZEoAAQIDBAUGBwgJZG5hbWVkSmFuZQ=="_s/* { "id": h'00010203040506070809', "name": "Jane" } */, true /* synchronizable */));
+ASSERT_TRUE(addKeyToKeychain("BBRoi2JbR0IXTeJmvXUp1YIuM4sph/Lu3eGf75F7n+HojHKG70a4R0rB2PQce5/SJle6T7OO5Cqet/LJZVM6NQ8yDDxWvayf71GTDp2yUtuIbqJLFVbpWymlj9WRizgX3A=="_s, emptyString(), "o2JpZEoAAQIDBAUGBwgJZG5hbWVkSmFuZWtkaXNwbGF5TmFtZWpKYW5lIFNtaXRo"_s/* { "id": h'00010203040506070809', "name": "Jane", "displayName": "Jane Smith" } */, true /* synchronizable */));
 
 [webView loadRequest:[NSURLRequest requestWithURL:testURL.get()]];
 [webView waitForMessage:@"Succeeded!"];
@@ -1519,6 +1521,7 @@
 [webView loadRequest:[NSURLRequest requestWithURL:testURL.get()]];
 [webView waitForMessage:@"Succeeded!"];
 EXPECT_WK_STREQ(webAuthenticationPanelSelectedCredentialName, "Jane");
+EXPECT_WK_STREQ(webAuthenticationPanelSelectedCredentialDisplayName, "Jane Smith");
 
 cleanUpKeychain(emptyString());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294329] trunk/Source/WebCore/rendering/RenderElement.h

[commit-queue]

Title: [294329] trunk/Source/WebCore/rendering/RenderElement.h








Revision 294329
Author commit-qu...@webkit.org
Date 2022-05-17 10:49:31 -0700 (Tue, 17 May 2022)


Log Message
Remove some RenderElement API 
https://bugs.webkit.org/show_bug.cgi?id=240520

Patch by Rob Buis  on 2022-05-17
Reviewed by Alan Bujtas.

Remove some unused RenderElement API, instead attachRendererInternal/detachRendererInternal are used.

* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::setFirstChild): Deleted.
(WebCore::RenderElement::setLastChild): Deleted.

Modified Paths

trunk/Source/WebCore/rendering/RenderElement.h




Diff

Modified: trunk/Source/WebCore/rendering/RenderElement.h (294328 => 294329)

--- trunk/Source/WebCore/rendering/RenderElement.h	2022-05-17 17:47:18 UTC (rev 294328)
+++ trunk/Source/WebCore/rendering/RenderElement.h	2022-05-17 17:49:31 UTC (rev 294329)
@@ -312,9 +312,6 @@
 enum StylePropagationType { PropagateToAllChildren, PropagateToBlockChildrenOnly };
 void propagateStyleToAnonymousChildren(StylePropagationType);
 
-void setFirstChild(RenderObject* child) { m_firstChild = child; }
-void setLastChild(RenderObject* child) { m_lastChild = child; }
-
 bool repaintBeforeStyleChange(StyleDifference, const RenderStyle& oldStyle, const RenderStyle& newStyle);
 
 virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294327] trunk/Tools/CISupport/ews-build

[jbedard]

Title: [294327] trunk/Tools/CISupport/ews-build








Revision 294327
Author jbed...@apple.com
Date 2022-05-17 10:35:22 -0700 (Tue, 17 May 2022)


Log Message
Forbid ChangeLog modification 
https://bugs.webkit.org/show_bug.cgi?id=240461


Rubber-stamped by Aakash Jain.

* Tools/CISupport/ews-build/factories.py:
(CommitQueueFactory.__init__): Only accept patches with commit messages,
respect those commit messages.
(MergeQueueFactoryBase.__init__): Use commit author in commit.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps.test_all_expected_steps):
* CISupport/ews-build/steps.py:
(CommitPatch): Add step which commits a patch, including it's commit message.
(PushCommitToWebKitRepo.evaluateCommand): Use GitHub checkout on Commit-Queue.
(ValidateSquashed.start): Support committed patches.
(AddReviewerToCommitMessage.start): Ditto.
(DetermineAuthor): Extract author from local commit.
(AddAuthorToCommitMessage): Use 'author' property as set by 'DetermineAuthor'.
(ValidateCommitMessage._files): Support patches.
(ValidateCommitMessage.run): Support committed patches.
(ValidateCommitMessage.getResultSummary): Support patches.
(Canonicalize.run): Support committed patches.
(ValidateSquashed.doStepIf): Deleted.
(ValidateSquashed.hideStepIf): Deleted.
(AddAuthorToCommitMessage.author): Deleted.
(ValidateCommitMessage.doStepIf): Deleted.
(ValidateCommitMessage.hideStepIf): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:

Modified Paths

trunk/Tools/CISupport/ews-build/factories.py
trunk/Tools/CISupport/ews-build/factories_unittest.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py




Diff

Modified: trunk/Tools/CISupport/ews-build/factories.py (294326 => 294327)

--- trunk/Tools/CISupport/ews-build/factories.py	2022-05-17 17:31:26 UTC (rev 294326)
+++ trunk/Tools/CISupport/ews-build/factories.py	2022-05-17 17:35:22 UTC (rev 294327)
@@ -24,10 +24,10 @@
 from buildbot.process import factory
 from buildbot.steps import trigger
 
-from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, ApplyPatch, ApplyWatchList, Canonicalize,
+from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, ApplyPatch, ApplyWatchList, Canonicalize, CommitPatch,
CheckOutPullRequest, CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance,
CheckPatchStatusOnEWSQueues, CheckStyle, CleanGitRepo, CompileJSC, CompileWebKit, ConfigureBuild, CreateLocalGITCommit,
-   DownloadBuiltProduct, ExtractBuiltProduct, FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitSvnFetch,
+   DetermineAuthor, DownloadBuiltProduct, ExtractBuiltProduct, FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitSvnFetch,
InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo,
RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunBuildbotCheckConfigForBuildWebKit, RunBuildbotCheckConfigForEWS,
RunEWSUnitTests, RunResultsdbpyTests, RunJavaScriptCoreTests, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
@@ -292,15 +292,21 @@
 self.addStep(ValidateChange(verifycqplus=True))
 self.addStep(ValidateCommitterAndReviewer())
 self.addStep(PrintConfiguration())
-self.addStep(CleanGitRepo(default_branch='master'))
-self.addStep(CheckOutSource(repourl='https://git.webkit.org/git/WebKit-https'))
+self.addStep(CleanGitRepo())
+self.addStep(CheckOutSource())
+self.addStep(GitSvnFetch())  # FIXME: Remove when migrating to pure git
 self.addStep(FetchBranches())
 self.addStep(ShowIdentifier())
 self.addStep(VerifyGitHubIntegrity())
 self.addStep(UpdateWorkingDirectory())
-self.addStep(ApplyPatch())
-self.addStep(ValidateChangeLogAndReviewer())
-self.addStep(FindModifiedChangeLogs())
+self.addStep(CommitPatch())
+
+self.addStep(ValidateSquashed())
+self.addStep(AddReviewerToCommitMessage())
+self.addStep(DetermineAuthor())
+self.addStep(AddAuthorToCommitMessage())
+self.addStep(ValidateCommitMessage())
+
 self.addStep(KillOldProcesses())
 self.addStep(CompileWebKit(skipUpload=True))
 self.addStep(KillOldProcesses())
@@ -308,11 +314,8 @@
 self.addStep(CheckPatchStatusOnEWSQueues())
 self.addStep(RunWebKitTests())
 self.addStep(ValidateChange(addURLs=False, verifycqplus=True))
-self.addStep(CheckOutSource(repourl='https://git.webkit.org/git/WebKit-https'))
-self.addStep(ShowIdentifier())
-self.addStep(UpdateWorkingDirectory())
-self.addStep(ApplyPatch())
-self.addStep(CreateLocalGITCommit())
+
+self.addStep(Canonicalize())
 self.addStep(PushCommitToWebKitRepo())
 

[webkit-changes] [294326] trunk/Source/WebKit/UIProcess/Launcher/glib/ ProcessLauncherGLib.cpp

[commit-queue]

Title: [294326] trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp








Revision 294326
Author commit-qu...@webkit.org
Date 2022-05-17 10:31:26 -0700 (Tue, 17 May 2022)


Log Message
Unreviewed, fix typo in comment

Patch by Michael Catanzaro  on 2022-05-17
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/250646@main

Modified Paths

trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp




Diff

Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp (294325 => 294326)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp	2022-05-17 16:38:25 UTC (rev 294325)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp	2022-05-17 17:31:26 UTC (rev 294326)
@@ -128,7 +128,7 @@
 argv[i++] = nullptr;
 
 // Warning: do not set a child setup function, because we want GIO to be able to spawn with
-// posix_spawn() rather than fork()/exec(), in order to better accomodate applications that use
+// posix_spawn() rather than fork()/exec(), in order to better accommodate applications that use
 // a huge amount of memory or address space in the UI process, like Eclipse.
 GRefPtr launcher = adoptGRef(g_subprocess_launcher_new(G_SUBPROCESS_FLAGS_INHERIT_FDS));
 g_subprocess_launcher_take_fd(launcher.get(), socketPair.client, socketPair.client);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294325] trunk

[wenson_hsieh]

Title: [294325] trunk








Revision 294325
Author wenson_hs...@apple.com
Date 2022-05-17 09:38:25 -0700 (Tue, 17 May 2022)


Log Message
Refactor ImageAnalysisQueue to take source and target identifier strings
https://bugs.webkit.org/show_bug.cgi?id=240485
rdar://93280471

Reviewed by Tim Horton.

Plumb a `source` identifier string alongside the existing target identifier string when kicking off the image
analysis queue. See WebKit changes  for more details.

* html/shadow/imageOverlay.css:
(div.image-overlay-block):

Drive-by fix: tweak some styles in the image overlay, related to block-style image overlays installed by the
image analysis queue.

* page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::resumeProcessing):
(WebCore::ImageAnalysisQueue::clear):
* page/ImageAnalysisQueue.h:
* platform/TextRecognitionOptions.h:

Change `-[WKWebView _startImageAnalysis:]` to `-[WKWebView _startImageAnalysis:target:]`, and have it take
separate source and target identifier strings. We pass these strings through to the page and store them on
`ImageAnalysisQueue`, where they eventually bubble back up to the UI process when trigger batch image analysis,
via the new `source` and `target` arguments on `requestTextRecognition()`.

No change in behavior; covered by adjusting existing API tests to use the adjusted SPI.

* Platform/cocoa/ImageAnalysisUtilities.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _startImageAnalysis:target:]):
(-[WKWebView _startImageAnalysis:]): Deleted.

Rename this SPI entirely; this is safe to rename because the only existing client of this method (apart from API
tests) will simultaneously adopt the new SPI method with both `source` and `target` arguments.

* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestTextRecognition):
* UIProcess/PageClient.h:
(WebKit::PageClient::requestTextRecognition):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestTextRecognition):
(WebKit::WebPageProxy::startImageAnalysis):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::requestTextRecognition):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestTextRecognition:imageData:source:target:completionHandler:]):
(-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]): Deleted.
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::requestTextRecognition):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestTextRecognition):
(WebKit::WebPage::startImageAnalysis):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

See WebKit changes for more information.

* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/250645@main

Modified Paths

trunk/Source/WebCore/html/shadow/imageOverlay.css
trunk/Source/WebCore/page/ImageAnalysisQueue.cpp
trunk/Source/WebCore/page/ImageAnalysisQueue.h
trunk/Source/WebCore/platform/TextRecognitionOptions.h
trunk/Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.h
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm




Diff

Modified: trunk/Source/WebCore/html/shadow/imageOverlay.css (294324 => 294325)

--- trunk/Source/WebCore/html/shadow/imageOverlay.css	2022-05-17 15:40:24 UTC (rev 294324)
+++ trunk/Source/WebCore/html/shadow/imageOverlay.css	2022-05-17 16:38:25 UTC (rev 294325)
@@ -62,6 +62,8 @@
 line-height: 1.2em;
 box-sizing: border-box;
 white-space: normal;
+word-break: break-word;
+letter-spacing: normal;
 }
 
 div.image-overlay-line, .image-overlay-text, div.image-overlay-block {


Modified: trunk/Source/WebCore/page/ImageAnalysisQueue.cpp (294324 => 294325)

--- trunk/Source/WebCore/page/ImageAnalysisQueue.cpp	2022-05-17 15:40:24 UTC (rev 294324)
+++ 

[webkit-changes] [294324] trunk/Source/WebCore/rendering/updating/ RenderTreeBuilderFirstLetter.cpp

[commit-queue]

Title: [294324] trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp








Revision 294324
Author commit-qu...@webkit.org
Date 2022-05-17 08:40:24 -0700 (Tue, 17 May 2022)


Log Message
[GTK] Fix build after 250633@main
https://bugs.webkit.org/show_bug.cgi?id=240521

Patch by Philippe Normand  on 2022-05-17
Unreviewed, fix GTK build.

* rendering/updating/RenderTreeBuilderFirstLetter.cpp:

Canonical link: https://commits.webkit.org/250644@main

Modified Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp




Diff

Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp (294323 => 294324)

--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp	2022-05-17 14:10:45 UTC (rev 294323)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp	2022-05-17 15:40:24 UTC (rev 294324)
@@ -34,6 +34,7 @@
 #include "RenderTable.h"
 #include "RenderTextFragment.h"
 #include "RenderTreeBuilder.h"
+#include "RenderView.h"
 #include "StyleChange.h"
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294323] trunk/Tools

[jbedard]

Title: [294323] trunk/Tools








Revision 294323
Author jbed...@apple.com
Date 2022-05-17 07:10:45 -0700 (Tue, 17 May 2022)


Log Message
[Merge-Queue] Forbid ChangeLog modification
https://bugs.webkit.org/show_bug.cgi?id=239413


Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/factories.py:
(MergeQueueFactoryBase.__init__): Remove AddReviewerToChangeLog and ValidateChangeLogAndReviewer.
* CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(PushCommitToWebKitRepo.evaluateCommand): Remove AddReviewerToChangeLog.
(ValidateCommitMessage._files): List all modified files.
(ValidateCommitMessage.evaluateCommand): Fail step if no ChangeLog modified.
(AddReviewerToChangeLog): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/250643@main

Modified Paths

trunk/Tools/CISupport/ews-build/factories.py
trunk/Tools/CISupport/ews-build/factories_unittest.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/factories.py (294322 => 294323)

--- trunk/Tools/CISupport/ews-build/factories.py	2022-05-17 13:22:50 UTC (rev 294322)
+++ trunk/Tools/CISupport/ews-build/factories.py	2022-05-17 14:10:45 UTC (rev 294323)
@@ -24,7 +24,7 @@
 from buildbot.process import factory
 from buildbot.steps import trigger
 
-from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, AddReviewerToChangeLog, ApplyPatch, ApplyWatchList, Canonicalize,
+from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, ApplyPatch, ApplyWatchList, Canonicalize,
CheckOutPullRequest, CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance,
CheckPatchStatusOnEWSQueues, CheckStyle, CleanGitRepo, CompileJSC, CompileWebKit, ConfigureBuild, CreateLocalGITCommit,
DownloadBuiltProduct, ExtractBuiltProduct, FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitSvnFetch,
@@ -335,9 +335,7 @@
 self.addStep(ValidateSquashed())
 self.addStep(AddReviewerToCommitMessage())
 self.addStep(AddAuthorToCommitMessage())
-self.addStep(AddReviewerToChangeLog())
 self.addStep(ValidateCommitMessage())
-self.addStep(ValidateChangeLogAndReviewer())
 
 
 class MergeQueueFactory(MergeQueueFactoryBase):


Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (294322 => 294323)

--- trunk/Tools/CISupport/ews-build/factories_unittest.py	2022-05-17 13:22:50 UTC (rev 294322)
+++ trunk/Tools/CISupport/ews-build/factories_unittest.py	2022-05-17 14:10:45 UTC (rev 294323)
@@ -642,9 +642,7 @@
 'validate-squashed',
 'add-reviewer-to-commit-message',
 'add-author-to-commit-message',
-'add-reviewer-to-changelog',
 'validate-commit-message',
-'validate-changelog-and-reviewer',
 'kill-old-processes',
 'compile-webkit',
 'kill-old-processes',
@@ -669,9 +667,7 @@
 'validate-squashed',
 'add-reviewer-to-commit-message',
 'add-author-to-commit-message',
-'add-reviewer-to-changelog',
 'validate-commit-message',
-'validate-changelog-and-reviewer',
 'validate-change',
 'canonicalize-commit',
 'push-commit-to-webkit-repo',


Modified: trunk/Tools/CISupport/ews-build/steps.py (294322 => 294323)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-05-17 13:22:50 UTC (rev 294322)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-05-17 14:10:45 UTC (rev 294323)
@@ -4569,7 +4569,6 @@
 CheckOutPullRequest(),
 AddReviewerToCommitMessage(),
 AddAuthorToCommitMessage(),
-AddReviewerToChangeLog(),
 ValidateChange(verifyMergeQueue=True, verifyNoDraftForMergeQueue=True),
 Canonicalize(),
 PushCommitToWebKitRepo(),
@@ -4926,54 +4925,6 @@
 return not self.doStepIf(step)
 
 
-class AddReviewerToChangeLog(steps.ShellSequence, ShellMixin, AddReviewerMixin):
-name = 'add-reviewer-to-changelog'
-haltOnFailure = True
-
-def __init__(self, **kwargs):
-super(AddReviewerToChangeLog, self).__init__(logEnviron=False, timeout=60, **kwargs)
-
-def _files(self):
-sourcestamp = self.build.getSourceStamp(self.getProperty('codebase', ''))
-if sourcestamp and sourcestamp.changes:
-return sourcestamp.changes[0].files
-return []
-
-def run(self, BufferLogObserverClass=logobserver.BufferLogObserver):
-self.commands = []
-for file in self._files():
-if not file.startswith('+++') or not file.endswith('ChangeLog'):
-continue
-

[webkit-changes] [294322] trunk/Source/WebKit

[clord]

Title: [294322] trunk/Source/WebKit








Revision 294322
Author cl...@igalia.com
Date 2022-05-17 06:22:50 -0700 (Tue, 17 May 2022)


Log Message
[WPE] Use new libwpe API to synchronise display refreshes fully to the screen refresh rate
https://bugs.webkit.org/show_bug.cgi?id=240453

Reviewed by Adrian Perez de Castro.

Use new libwpe API to track the target refresh rate and use it in
ThreadedDisplayRefreshMonitor for DisplayUpdate objects.

* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::targetRefreshRateDidChange):
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::setTargetRefreshRate):
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_backend):
* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::targetRefreshRateDidChange):
* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:
* UIProcess/DrawingAreaProxy.h:
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::targetRefreshRateDidChange):
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::targetRefreshRateDidChange):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::targetRefreshRateDidChange):
* WebProcess/WebPage/DrawingArea.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h
trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp
trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h
trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h
trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (294321 => 294322)

--- trunk/Source/WebKit/ChangeLog	2022-05-17 13:22:01 UTC (rev 294321)
+++ trunk/Source/WebKit/ChangeLog	2022-05-17 13:22:50 UTC (rev 294322)
@@ -1,3 +1,36 @@
+2022-05-17  Chris Lord  
+
+[WPE] Use new libwpe API to synchronise display refreshes fully to the screen refresh rate
+https://bugs.webkit.org/show_bug.cgi?id=240453
+
+Reviewed by Adrian Perez de Castro.
+
+Use new libwpe API to track the target refresh rate and use it in
+ThreadedDisplayRefreshMonitor for DisplayUpdate objects.
+
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+(WebKit::ThreadedCompositor::targetRefreshRateDidChange):
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
+(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
+(WebKit::ThreadedDisplayRefreshMonitor::setTargetRefreshRate):
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
+* UIProcess/API/wpe/WPEView.cpp:
+(WKWPE::m_backend):
+* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
+(WebKit::DrawingAreaProxyCoordinatedGraphics::targetRefreshRateDidChange):
+* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:
+* UIProcess/DrawingAreaProxy.h:
+* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+(WebKit::DrawingAreaCoordinatedGraphics::targetRefreshRateDidChange):
+* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
+* WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
+(WebKit::LayerTreeHost::targetRefreshRateDidChange):
+* WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
+* WebProcess/WebPage/DrawingArea.h:
+

[webkit-changes] [294321] trunk

[commit-queue]

Title: [294321] trunk








Revision 294321
Author commit-qu...@webkit.org
Date 2022-05-17 06:22:01 -0700 (Tue, 17 May 2022)


Log Message
[GTK] Build MiniBrowser by default
https://bugs.webkit.org/show_bug.cgi?id=240515

Patch by Michael Catanzaro  on 2022-05-17
Reviewed by Philippe Normand.

* Source/cmake/OptionsGTK.cmake:

Canonical link: https://commits.webkit.org/250641@main

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (294320 => 294321)

--- trunk/ChangeLog	2022-05-17 13:13:45 UTC (rev 294320)
+++ trunk/ChangeLog	2022-05-17 13:22:01 UTC (rev 294321)
@@ -1,3 +1,12 @@
+2022-05-17  Michael Catanzaro  
+
+[GTK] Build MiniBrowser by default
+https://bugs.webkit.org/show_bug.cgi?id=240515
+
+Reviewed by Philippe Normand.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2022-05-13  Geza Lore  
 
 Add self to contributors.json


Modified: trunk/Source/cmake/OptionsGTK.cmake (294320 => 294321)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-05-17 13:13:45 UTC (rev 294320)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-05-17 13:22:01 UTC (rev 294321)
@@ -92,10 +92,8 @@
 
 SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})
 if (DEVELOPER_MODE)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE ON)
 else ()
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE OFF)
 endif ()
 
@@ -122,6 +120,7 @@
 # changing the value of the option.
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PDFJS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294320] trunk/Tools/CISupport/ews-build/config.json

[aakash_jain]

Title: [294320] trunk/Tools/CISupport/ews-build/config.json








Revision 294320
Author aakash_j...@apple.com
Date 2022-05-17 06:13:45 -0700 (Tue, 17 May 2022)


Log Message
[ews] Move few bots from mac wk1 queues to wk2 queue
https://bugs.webkit.org/show_bug.cgi?id=240513

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/250640@main

Modified Paths

trunk/Tools/CISupport/ews-build/config.json




Diff

Modified: trunk/Tools/CISupport/ews-build/config.json (294319 => 294320)

--- trunk/Tools/CISupport/ews-build/config.json	2022-05-17 12:12:38 UTC (rev 294319)
+++ trunk/Tools/CISupport/ews-build/config.json	2022-05-17 13:13:45 UTC (rev 294320)
@@ -186,7 +186,7 @@
   "factory": "macOSWK2Factory", "platform": "mac-bigsur",
   "configuration": "release", "architectures": ["x86_64"],
   "triggered_by": ["macos-bigsur-release-build-ews"],
-  "workernames": ["ews104", "ews106", "ews107"]
+  "workernames": ["ews104", "ews106", "ews107", "ews113", "ews115"]
 },
 {
   "name": "macOS-Release-WK2-Stress-Tests-EWS", "shortname": "mac-wk2-stress", "icon": "testOnly",
@@ -200,7 +200,7 @@
   "factory": "macOSBuildFactory", "platform": "mac-bigsur",
   "configuration": "debug", "architectures": ["x86_64"],
   "triggers": ["macos-bigsur-debug-wk1-tests-ews"],
-  "workernames": ["ews112", "ews113", "ews115", "ews117", "ews153"]
+  "workernames": ["ews112", "ews117", "ews153"]
 },
 {
   "name": "macOS-BigSur-Debug-WK1-Tests-EWS", "shortname": "mac-debug-wk1", "icon": "testOnly",
@@ -207,7 +207,7 @@
   "factory": "macOSWK1Factory", "platform": "mac-bigsur",
   "configuration": "debug", "architectures": ["x86_64"],
   "triggered_by": ["macos-bigsur-debug-build-ews"],
-  "workernames": ["ews112", "ews113", "ews115", "ews117"]
+  "workernames": ["ews112"]
 },
 {
   "name": "watchOS-8-Build-EWS", "shortname": "watch", "icon": "buildOnly",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294319] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [294319] trunk/Source/_javascript_Core








Revision 294319
Author ysuz...@apple.com
Date 2022-05-17 05:12:38 -0700 (Tue, 17 May 2022)


Log Message
[JSC] Always have non nullptr for WebAssembly.Memory buffer
https://bugs.webkit.org/show_bug.cgi?id=240510

Reviewed by Mark Lam.

This patch adds CagedUniquePtr to allocate a pointer for that.

* Source/_javascript_Core/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::makeShared):
* Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp:
(JSC::JSWebAssemblyMemory::buffer):

Canonical link: https://commits.webkit.org/250639@main

Modified Paths

trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp




Diff

Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp (294318 => 294319)

--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2022-05-17 11:05:11 UTC (rev 294318)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2022-05-17 12:12:38 UTC (rev 294319)
@@ -332,6 +332,7 @@
 {
 m_contents.makeShared();
 m_locked = true;
+ASSERT(!isDetached());
 }
 
 void ArrayBuffer::makeWasmMemory()


Modified: trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp (294318 => 294319)

--- trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2022-05-17 11:05:11 UTC (rev 294318)
+++ trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2022-05-17 12:12:38 UTC (rev 294319)
@@ -90,8 +90,23 @@
 }
 
 Ref protectedHandle = m_memory->handle();
-auto destructor = createSharedTask([protectedHandle = WTFMove(protectedHandle)] (void*) { });
-m_buffer = ArrayBuffer::createFromBytes(m_memory->memory(), m_memory->size(), WTFMove(destructor));
+CagedUniquePtr pointerForEmpty;
+
+void* memory = m_memory->memory();
+size_t size = m_memory->size();
+if (!memory) {
+ASSERT(!size);
+constexpr unsigned allocationSize = 1;
+pointerForEmpty = CagedUniquePtr::tryCreate(allocationSize);
+if (!pointerForEmpty) {
+throwOutOfMemoryError(globalObject, throwScope);
+return nullptr;
+}
+memory = pointerForEmpty.get(allocationSize);
+}
+ASSERT(memory);
+auto destructor = createSharedTask([protectedHandle = WTFMove(protectedHandle), pointerForEmpty = WTFMove(pointerForEmpty)] (void*) { });
+m_buffer = ArrayBuffer::createFromBytes(memory, size, WTFMove(destructor));
 m_buffer->makeWasmMemory();
 if (m_memory->sharingMode() == Wasm::MemorySharingMode::Shared)
 m_buffer->makeShared();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294318] trunk/LayoutTests

[ntim]

Title: [294318] trunk/LayoutTests








Revision 294318
Author n...@apple.com
Date 2022-05-17 04:05:11 -0700 (Tue, 17 May 2022)


Log Message
[iOS] Rebaseline 2 tests in imported/w3c/web-platform-tests/html/semantics/forms/
https://bugs.webkit.org/show_bug.cgi?id=240512

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added.
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added.

Canonical link: https://commits.webkit.org/250638@main

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (294317 => 294318)

--- trunk/LayoutTests/ChangeLog	2022-05-17 09:47:30 UTC (rev 294317)
+++ trunk/LayoutTests/ChangeLog	2022-05-17 11:05:11 UTC (rev 294318)
@@ -1,3 +1,13 @@
+2022-05-17  Tim Nguyen  
+
+[iOS] Rebaseline 2 tests in imported/w3c/web-platform-tests/html/semantics/forms/
+https://bugs.webkit.org/show_bug.cgi?id=240512
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added.
+* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added.
+
 2022-05-17  Ziran Sun  
 
 tidy up some test expectations files after resync html/semantics/forms tests


Added: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt (0 => 294318)

--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt	2022-05-17 11:05:11 UTC (rev 294318)
@@ -0,0 +1,21 @@
+
+
+Harness Error (TIMEOUT), message = null
+
+TIMEOUT  Test timed out
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+NOTRUN 
+


Added: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt (0 => 294318)

--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt	2022-05-17 11:05:11 UTC (rev 294318)
@@ -0,0 +1,4 @@
+
+
+FAIL whitespace should not be eaten after parent style recalculation assert_equals: expected "a b" but got ""
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294317] trunk/Source

[commit-queue]

Title: [294317] trunk/Source








Revision 294317
Author commit-qu...@webkit.org
Date 2022-05-17 02:47:30 -0700 (Tue, 17 May 2022)


Log Message
ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
https://bugs.webkit.org/show_bug.cgi?id=240452

Patch by Kimmo Kinnunen  on 2022-05-17
Reviewed by Simon Fraser.

Source/WebCore:

Remove ImageBuffer::releaseGraphicsContext().
It only made sense to be used before ImageBuffer::setVolatile().
The call setVolatile only made sense after releaseGraphicsContext().
Instead, make releasing the graphics context part of the
setVolatile() contract.

ImageBufferBackend::applyBaseTransformToContext() invoked a virtual
function context(). This was called from the middle of the inheritance chain,
from a constructor.
If a class later in the inheritance chain would override context(), the
call would not be invoked correctly. Currently no class suffered from this, but
in future some might.
ImageBufferIOSurfaceBackend call to applyBaseTransformToContext() would also
recurse through context() back to applyBaseTransformToContext() in non-intuitive
way through overridden ::context() which would re-enter applyBaseTransformToContext().
Based on current knowledge doubly invoking the logic did not cause any harm.

* platform/graphics/ConcreteImageBuffer.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageBufferBackend.cpp:
(WebCore::ImageBufferBackend::applyBaseTransform):
(WebCore::ImageBufferBackend::applyBaseTransformToContext const): Deleted.
* platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::isInUse const):
(WebCore::ImageBufferBackend::releaseGraphicsContext): Deleted.
* platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:
(WebCore::ImageBufferCGBitmapBackend::ImageBufferCGBitmapBackend):
* platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
(WebCore::ImageBufferIOSurfaceBackend::initializeContext):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext): Deleted.
* platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

Source/WebKit:

Adjust after removing ImageBuffer::releaseGraphicsContext().

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::setBufferVolatile):
* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBufferBackend.cpp
trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (294316 => 294317)

--- trunk/Source/WebCore/ChangeLog	2022-05-17 09:08:43 UTC (rev 294316)
+++ trunk/Source/WebCore/ChangeLog	2022-05-17 09:47:30 UTC (rev 294317)
@@ -1,3 +1,46 @@
+2022-05-17  Kimmo Kinnunen  
+
+ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
+https://bugs.webkit.org/show_bug.cgi?id=240452
+
+Reviewed by Simon Fraser.
+
+Remove ImageBuffer::releaseGraphicsContext().
+It only made sense to be used before ImageBuffer::setVolatile().
+The call setVolatile only made sense after releaseGraphicsContext().
+Instead, make releasing the graphics context part of the
+setVolatile() contract.
+
+ImageBufferBackend::applyBaseTransformToContext() invoked a virtual
+function context(). This was called from the middle of the inheritance chain,
+from a constructor.
+If a class later in the inheritance chain would override context(), the
+call would not be invoked correctly. Currently no class suffered from this, but
+in future some might.
+ImageBufferIOSurfaceBackend call to applyBaseTransformToContext() would also
+recurse through context() back to applyBaseTransformToContext() in non-intuitive
+way through overridden ::context() which would re-enter applyBaseTransformToContext().
+Based on current knowledge doubly invoking the logic did not cause any harm.
+
+* platform/graphics/ConcreteImageBuffer.h:
+* 

[webkit-changes] [294316] trunk/LayoutTests

[zsun]

Title: [294316] trunk/LayoutTests








Revision 294316
Author z...@igalia.com
Date 2022-05-17 02:08:43 -0700 (Tue, 17 May 2022)


Log Message
tidy up some test expectations files after resync html/semantics/forms tests
https://bugs.webkit.org/show_bug.cgi?id=240451

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
* web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:

LayoutTests:

This is to tidy up some test expectation files are WPT upstream resync at bug 240301.

* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
* 

[webkit-changes] [294315] trunk

[commit-queue]

Title: [294315] trunk








Revision 294315
Author commit-qu...@webkit.org
Date 2022-05-17 01:38:13 -0700 (Tue, 17 May 2022)


Log Message
Allow Service Workers to run for a little longer in case of functional events
https://bugs.webkit.org/show_bug.cgi?id=240454

Patch by Youenn Fablet  on 2022-05-17
Reviewed by Chris Dumez.

Functional events should usually trigger opening a new web page on the same origin as the service worker.
There are good chances that the service worker will control the new web page, it is thus potentially useful to
keep the service worker around for a bit, to not pay the cost of stopping and restarting it.
To do so, we introduce a timer in SWServerWorker that handles the termination in case of functional events/debugger.

Covered by updated API test.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
* Source/WebCore/workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::startTermination):
(WebCore::SWServerWorker::shouldBeTerminated const):
(WebCore::SWServerWorker::terminateIfPossible):
(WebCore::SWServerWorker::terminationIfPossibleTimerFired):
* Source/WebCore/workers/service/server/SWServerWorker.h:

Canonical link: https://commits.webkit.org/250635@main

Modified Paths

trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.h
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm




Diff

Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp (294314 => 294315)

--- trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp	2022-05-17 06:18:04 UTC (rev 294314)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp	2022-05-17 08:38:13 UTC (rev 294315)
@@ -63,6 +63,7 @@
 , m_registrableDomain(m_data.scriptURL)
 , m_scriptResourceMap(WTFMove(scriptResourceMap))
 , m_terminationTimer(*this, ::terminationTimerFired)
+, m_terminationIfPossibleTimer(*this, ::terminationIfPossibleTimerFired)
 , m_lastNavigationWasAppInitiated(m_server->clientIsAppInitiatedForRegistrableDomain(m_registrableDomain))
 {
 m_data.scriptURL.removeFragmentIdentifier();
@@ -141,6 +142,7 @@
 
 m_terminationCallbacks.append(WTFMove(callback));
 m_terminationTimer.startOneShot(SWServer::defaultTerminationDelay);
+m_terminationIfPossibleTimer.stop();
 
 contextConnection->terminateWorker(identifier());
 }
@@ -410,11 +412,26 @@
 terminateIfPossible();
 }
 
+bool SWServerWorker::shouldBeTerminated() const
+{
+return !m_functionalEventCounter && !m_isInspected && m_server && !m_server->hasClientsWithOrigin(origin());
+}
+
 void SWServerWorker::terminateIfPossible()
 {
-if (m_functionalEventCounter || m_isInspected || !m_server || m_server->hasClientsWithOrigin(origin()))
+if (!shouldBeTerminated()) {
+m_terminationIfPossibleTimer.stop();
 return;
+}
 
+m_terminationIfPossibleTimer.startOneShot(SWServer::defaultFunctionalEventDuration);
+}
+
+void SWServerWorker::terminationIfPossibleTimerFired()
+{
+if (!shouldBeTerminated())
+return;
+
 terminate();
 m_server->removeContextConnectionIfPossible(registrableDomain());
 }


Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.h (294314 => 294315)

--- trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2022-05-17 06:18:04 UTC (rev 294314)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2022-05-17 08:38:13 UTC (rev 294315)
@@ -156,8 +156,10 @@
 void startTermination(CompletionHandler&&);
 void terminationCompleted();
 void terminationTimerFired();
+void terminationIfPossibleTimerFired();
 void callTerminationCallbacks();
 void terminateIfPossible();
+bool shouldBeTerminated() const;
 
 WeakPtr m_server;
 ServiceWorkerRegistrationKey m_registrationKey;
@@ -179,6 +181,7 @@
 bool m_hasTimedOutAnyFetchTasks { false };
 Vector> m_terminationCallbacks;
 Timer m_terminationTimer;
+Timer m_terminationIfPossibleTimer;
 LastNavigationWasAppInitiated m_lastNavigationWasAppInitiated;
 int m_functionalEventCounter { 0 };
 bool m_isInspected { false };


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm (294314 => 294315)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm	2022-05-17 06:18:04 UTC (rev 294314)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm	2022-05-17 08:38:13 UTC (rev 294315)
@@ -393,6 +393,11 @@
 return;
 }
 if (event.data.text() === 'third') {
+if (self.previousMessageData !== 'second')
+event.waitUntil(Promise.reject('expected second'));
+return;
+}
+if (event.data.text() === 'fourth') {
 if (self.previousMessageData !== undefined)
 event.waitUntil(Promise.reject('expected undefined'));
 return;
@@ -463,6 +468,19 @@
 pushMessageProcessed = true;
 }];
 TestWebKitAPI::Util::run();
+

[webkit-changes] [294314] branches/safari-7614.1.14.0-branch/Source/WTF

[alancoon]

Title: [294314] branches/safari-7614.1.14.0-branch/Source/WTF








Revision 294314
Author alanc...@apple.com
Date 2022-05-16 23:18:04 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294272. rdar://problem/93118830

Correct erroneous guard in Platform file
https://bugs.webkit.org/show_bug.cgi?id=240469


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WTF/wtf/PlatformEnableCocoa.h




Diff

Modified: branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog (294313 => 294314)

--- branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:18:02 UTC (rev 294313)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:18:04 UTC (rev 294314)
@@ -1,5 +1,27 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r294272. rdar://problem/93118830
+
+Correct erroneous guard in Platform file
+https://bugs.webkit.org/show_bug.cgi?id=240469
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-16  Brent Fulgham  
+
+Correct erroneous guard in Platform file
+https://bugs.webkit.org/show_bug.cgi?id=240469
+
+
+Reviewed by Geoff Garen.
+
+SSIA.
+
+* wtf/PlatformEnableCocoa.h:
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r294265. rdar://problem/93118830
 
 Remove abandoned WebKitAdditionsFeature1 flag (240462)


Modified: branches/safari-7614.1.14.0-branch/Source/WTF/wtf/PlatformEnableCocoa.h (294313 => 294314)

--- branches/safari-7614.1.14.0-branch/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-17 06:18:02 UTC (rev 294313)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-17 06:18:04 UTC (rev 294314)
@@ -441,7 +441,7 @@
 #define ENABLE_NON_VISIBLE_WEBPROCESS_MEMORY_CLEANUP_TIMER 1
 #endif
 
-#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS))
+#if !defined(ENABLE_NOTIFICATIONS) && PLATFORM(MAC)
 #define ENABLE_NOTIFICATIONS 1
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294313] branches/safari-7614.1.14.0-branch/Source/WTF

[alancoon]

Title: [294313] branches/safari-7614.1.14.0-branch/Source/WTF








Revision 294313
Author alanc...@apple.com
Date 2022-05-16 23:18:02 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294265. rdar://problem/93118830

Remove abandoned WebKitAdditionsFeature1 flag (240462)
https://bugs.webkit.org/show_bug.cgi?id=240462


Reviewed by Alex Christensen.

Remove the abandoned WebKitAdditionsFeature1 preference, since
it ended up not being needed and now just complicates the build
and generated preferences.

* Scripts/Preferences/WebPreferencesExperimental.yaml:
* wtf/ExperimentalFeatureNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
branches/safari-7614.1.14.0-branch/Source/WTF/wtf/ExperimentalFeatureNames.h




Diff

Modified: branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog (294312 => 294313)

--- branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:17:59 UTC (rev 294312)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:18:02 UTC (rev 294313)
@@ -1,5 +1,40 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r294265. rdar://problem/93118830
+
+Remove abandoned WebKitAdditionsFeature1 flag (240462)
+https://bugs.webkit.org/show_bug.cgi?id=240462
+
+
+Reviewed by Alex Christensen.
+
+Remove the abandoned WebKitAdditionsFeature1 preference, since
+it ended up not being needed and now just complicates the build
+and generated preferences.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+* wtf/ExperimentalFeatureNames.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-16  Brent Fulgham  
+
+Remove abandoned WebKitAdditionsFeature1 flag (240462)
+https://bugs.webkit.org/show_bug.cgi?id=240462
+
+
+Reviewed by Alex Christensen.
+
+Remove the abandoned WebKitAdditionsFeature1 preference, since
+it ended up not being needed and now just complicates the build
+and generated preferences.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+* wtf/ExperimentalFeatureNames.h:
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r294264. rdar://problem/93118830
 
 Remove abandoned UseScreenCaptureKit preference


Modified: branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (294312 => 294313)

--- branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-05-17 06:17:59 UTC (rev 294312)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-05-17 06:18:02 UTC (rev 294313)
@@ -1660,18 +1660,6 @@
   "HAVE(WEBGL_COMPATIBLE_METAL)": true
   default: false
 
-WebKitAdditionsFeature1Enabled:
-  type: bool
-  humanReadableName: WebKitAdditionsFeature1HumanReadableName
-  humanReadableDescription: WebKitAdditionsFeature1HumanReadableDescription
-  defaultValue:
-WebKitLegacy:
-  default: false
-WebKit:
-  default: false
-WebCore:
-  default: false
-
 WebLocksAPIEnabled:
   type: bool
   humanReadableName: "Web Locks API"


Modified: branches/safari-7614.1.14.0-branch/Source/WTF/wtf/ExperimentalFeatureNames.h (294312 => 294313)

--- branches/safari-7614.1.14.0-branch/Source/WTF/wtf/ExperimentalFeatureNames.h	2022-05-17 06:17:59 UTC (rev 294312)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/wtf/ExperimentalFeatureNames.h	2022-05-17 06:18:02 UTC (rev 294313)
@@ -31,11 +31,6 @@
 
 #include 
 
-#else
-
-#define WebKitAdditionsFeature1HumanReadableName "WebKitAdditions Feature"
-#define WebKitAdditionsFeature1HumanReadableDescription "WebKitAdditions Feature"
-
 #endif
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294312] branches/safari-7614.1.14.0-branch

[alancoon]

Title: [294312] branches/safari-7614.1.14.0-branch








Revision 294312
Author alanc...@apple.com
Date 2022-05-16 23:17:59 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294264. rdar://problem/93118830

Remove abandoned UseScreenCaptureKit preference
https://bugs.webkit.org/show_bug.cgi?id=240460


Reviewed by Youenn Fablet.

We no longer need this switch to activate ScreenCaptureKit, and this code is no
longer used. We should remove it to simplify the build and reduce complexity.

Source/WebCore:

* platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted.
(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.

Source/WebKit:

* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultScreenCaptureKitEnabled): Deleted.
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _useScreenCaptureKit]): Deleted.
(-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updatePreferences):
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
branches/safari-7614.1.14.0-branch/Source/WebCore/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
branches/safari-7614.1.14.0-branch/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
branches/safari-7614.1.14.0-branch/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
branches/safari-7614.1.14.0-branch/Source/WebKit/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WebKit/GPUProcess/GPUProcess.cpp
branches/safari-7614.1.14.0-branch/Source/WebKit/GPUProcess/GPUProcess.h
branches/safari-7614.1.14.0-branch/Source/WebKit/GPUProcess/GPUProcess.messages.in
branches/safari-7614.1.14.0-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
branches/safari-7614.1.14.0-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h
branches/safari-7614.1.14.0-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
branches/safari-7614.1.14.0-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
branches/safari-7614.1.14.0-branch/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
branches/safari-7614.1.14.0-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
branches/safari-7614.1.14.0-branch/Tools/ChangeLog
branches/safari-7614.1.14.0-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm




Diff

Modified: branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog (294311 => 294312)

--- branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:17:52 UTC (rev 294311)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:17:59 UTC (rev 294312)
@@ -1,5 +1,66 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r294264. rdar://problem/93118830
+
+Remove abandoned UseScreenCaptureKit preference
+https://bugs.webkit.org/show_bug.cgi?id=240460
+
+
+Reviewed by Youenn Fablet.
+
+We no longer need this switch to activate ScreenCaptureKit, and this code is no
+longer used. We should remove it to simplify the build and reduce complexity.
+
+Source/WebCore:
+
+* platform/mediastream/RealtimeMediaSourceCenter.h:
+(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted.
+(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.
+
+Source/WebKit:
+
+* GPUProcess/GPUProcess.cpp:
+(WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
+* GPUProcess/GPUProcess.h:
+* GPUProcess/GPUProcess.messages.in:
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultScreenCaptureKitEnabled): Deleted.
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _useScreenCaptureKit]): Deleted.
+(-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::updatePreferences):
+* 

[webkit-changes] [294311] branches/safari-7614.1.14.0-branch

[alancoon]

Title: [294311] branches/safari-7614.1.14.0-branch








Revision 294311
Author alanc...@apple.com
Date 2022-05-16 23:17:52 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294208. rdar://problem/93118830

AX: Remove CSSDisplayContentsAXSupportEnabled flag
https://bugs.webkit.org/show_bug.cgi?id=240409

Reviewed by Chris Fleizach.

Source/WebCore:

We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.

* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.

Source/WebKitLegacy/mac:

We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted.
(-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
branches/safari-7614.1.14.0-branch/Source/WebCore/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WebCore/page/RuntimeEnabledFeatures.h
branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
branches/safari-7614.1.14.0-branch/Tools/ChangeLog
branches/safari-7614.1.14.0-branch/Tools/DumpRenderTree/TestOptions.cpp




Diff

Modified: branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog (294310 => 294311)

--- branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:17:52 UTC (rev 294310)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/ChangeLog	2022-05-17 06:17:52 UTC (rev 294311)
@@ -1,3 +1,53 @@
+2022-05-16  Alan Coon  
+
+Cherry-pick r294208. rdar://problem/93118830
+
+AX: Remove CSSDisplayContentsAXSupportEnabled flag
+https://bugs.webkit.org/show_bug.cgi?id=240409
+
+Reviewed by Chris Fleizach.
+
+Source/WebCore:
+
+We added initial support without using this flag and will continue to
+fix bugs as we find them, making this flag unnecessary.
+
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted.
+(WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.
+
+Source/WebKitLegacy/mac:
+
+We added initial support without using this flag and will continue to
+fix bugs as we find them, making this flag unnecessary.
+
+* WebView/WebPreferenceKeysPrivate.h:
+* WebView/WebPreferences.mm:
+(-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted.
+(-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
+* WebView/WebPreferencesPrivate.h:
+
+Source/WTF:
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
+Tools:
+
+* DumpRenderTree/TestOptions.cpp:
+(WTR::TestOptions::defaults):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-14  Tyler Wilcock  
+
+AX: Remove CSSDisplayContentsAXSupportEnabled flag
+https://bugs.webkit.org/show_bug.cgi?id=240409
+
+Reviewed by Chris Fleizach.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2022-05-06  Brent Fulgham  
 
 Remove unused ApplePayRemoteUIEnabled preference


Modified: branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (294310 => 294311)

--- branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-05-17 06:17:52 UTC (rev 294310)
+++ branches/safari-7614.1.14.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-05-17 06:17:52 UTC (rev 294311)
@@ -107,17 +107,6 @@
 WebKit:
   default: true
 
-CSSDisplayContentsAXSupportEnabled:
-  type: bool
-  humanReadableName: "Accessibility support for display: contents elements"
-  humanReadableDescription: "Enable work-in-progress accessibility support for display: contents elements"
-  webcoreBinding: RuntimeEnabledFeatures
-  defaultValue:
-WebKitLegacy:
-  default: 

[webkit-changes] [294309] branches/safari-7614.1.14.1-branch/Source/WTF

[alancoon]

Title: [294309] branches/safari-7614.1.14.1-branch/Source/WTF








Revision 294309
Author alanc...@apple.com
Date 2022-05-16 23:17:50 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294265. rdar://problem/93118830

Remove abandoned WebKitAdditionsFeature1 flag (240462)
https://bugs.webkit.org/show_bug.cgi?id=240462


Reviewed by Alex Christensen.

Remove the abandoned WebKitAdditionsFeature1 preference, since
it ended up not being needed and now just complicates the build
and generated preferences.

* Scripts/Preferences/WebPreferencesExperimental.yaml:
* wtf/ExperimentalFeatureNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
branches/safari-7614.1.14.1-branch/Source/WTF/wtf/ExperimentalFeatureNames.h




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog (294308 => 294309)

--- branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:47 UTC (rev 294308)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:50 UTC (rev 294309)
@@ -1,5 +1,40 @@
 2022-05-16  Russell Epstein  
 
+Cherry-pick r294265. rdar://problem/93118830
+
+Remove abandoned WebKitAdditionsFeature1 flag (240462)
+https://bugs.webkit.org/show_bug.cgi?id=240462
+
+
+Reviewed by Alex Christensen.
+
+Remove the abandoned WebKitAdditionsFeature1 preference, since
+it ended up not being needed and now just complicates the build
+and generated preferences.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+* wtf/ExperimentalFeatureNames.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-16  Brent Fulgham  
+
+Remove abandoned WebKitAdditionsFeature1 flag (240462)
+https://bugs.webkit.org/show_bug.cgi?id=240462
+
+
+Reviewed by Alex Christensen.
+
+Remove the abandoned WebKitAdditionsFeature1 preference, since
+it ended up not being needed and now just complicates the build
+and generated preferences.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+* wtf/ExperimentalFeatureNames.h:
+
+2022-05-16  Russell Epstein  
+
 Cherry-pick r294264. rdar://problem/93118830
 
 Remove abandoned UseScreenCaptureKit preference


Modified: branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (294308 => 294309)

--- branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-05-17 06:17:47 UTC (rev 294308)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-05-17 06:17:50 UTC (rev 294309)
@@ -1660,18 +1660,6 @@
   "HAVE(WEBGL_COMPATIBLE_METAL)": true
   default: false
 
-WebKitAdditionsFeature1Enabled:
-  type: bool
-  humanReadableName: WebKitAdditionsFeature1HumanReadableName
-  humanReadableDescription: WebKitAdditionsFeature1HumanReadableDescription
-  defaultValue:
-WebKitLegacy:
-  default: false
-WebKit:
-  default: false
-WebCore:
-  default: false
-
 WebLocksAPIEnabled:
   type: bool
   humanReadableName: "Web Locks API"


Modified: branches/safari-7614.1.14.1-branch/Source/WTF/wtf/ExperimentalFeatureNames.h (294308 => 294309)

--- branches/safari-7614.1.14.1-branch/Source/WTF/wtf/ExperimentalFeatureNames.h	2022-05-17 06:17:47 UTC (rev 294308)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/wtf/ExperimentalFeatureNames.h	2022-05-17 06:17:50 UTC (rev 294309)
@@ -31,11 +31,6 @@
 
 #include 
 
-#else
-
-#define WebKitAdditionsFeature1HumanReadableName "WebKitAdditions Feature"
-#define WebKitAdditionsFeature1HumanReadableDescription "WebKitAdditions Feature"
-
 #endif
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294310] branches/safari-7614.1.14.1-branch/Source/WTF

[alancoon]

Title: [294310] branches/safari-7614.1.14.1-branch/Source/WTF








Revision 294310
Author alanc...@apple.com
Date 2022-05-16 23:17:52 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294272. rdar://problem/93118830

Correct erroneous guard in Platform file
https://bugs.webkit.org/show_bug.cgi?id=240469


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WTF/wtf/PlatformEnableCocoa.h




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog (294309 => 294310)

--- branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:50 UTC (rev 294309)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:52 UTC (rev 294310)
@@ -1,5 +1,27 @@
 2022-05-16  Russell Epstein  
 
+Cherry-pick r294272. rdar://problem/93118830
+
+Correct erroneous guard in Platform file
+https://bugs.webkit.org/show_bug.cgi?id=240469
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-16  Brent Fulgham  
+
+Correct erroneous guard in Platform file
+https://bugs.webkit.org/show_bug.cgi?id=240469
+
+
+Reviewed by Geoff Garen.
+
+SSIA.
+
+* wtf/PlatformEnableCocoa.h:
+
+2022-05-16  Russell Epstein  
+
 Cherry-pick r294265. rdar://problem/93118830
 
 Remove abandoned WebKitAdditionsFeature1 flag (240462)


Modified: branches/safari-7614.1.14.1-branch/Source/WTF/wtf/PlatformEnableCocoa.h (294309 => 294310)

--- branches/safari-7614.1.14.1-branch/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-17 06:17:50 UTC (rev 294309)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-17 06:17:52 UTC (rev 294310)
@@ -441,7 +441,7 @@
 #define ENABLE_NON_VISIBLE_WEBPROCESS_MEMORY_CLEANUP_TIMER 1
 #endif
 
-#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS))
+#if !defined(ENABLE_NOTIFICATIONS) && PLATFORM(MAC)
 #define ENABLE_NOTIFICATIONS 1
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294308] branches/safari-7614.1.14.1-branch

[alancoon]

Title: [294308] branches/safari-7614.1.14.1-branch








Revision 294308
Author alanc...@apple.com
Date 2022-05-16 23:17:47 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294264. rdar://problem/93118830

Remove abandoned UseScreenCaptureKit preference
https://bugs.webkit.org/show_bug.cgi?id=240460


Reviewed by Youenn Fablet.

We no longer need this switch to activate ScreenCaptureKit, and this code is no
longer used. We should remove it to simplify the build and reduce complexity.

Source/WebCore:

* platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted.
(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.

Source/WebKit:

* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultScreenCaptureKitEnabled): Deleted.
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _useScreenCaptureKit]): Deleted.
(-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updatePreferences):
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
branches/safari-7614.1.14.1-branch/Source/WebCore/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
branches/safari-7614.1.14.1-branch/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
branches/safari-7614.1.14.1-branch/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebKit/GPUProcess/GPUProcess.cpp
branches/safari-7614.1.14.1-branch/Source/WebKit/GPUProcess/GPUProcess.h
branches/safari-7614.1.14.1-branch/Source/WebKit/GPUProcess/GPUProcess.messages.in
branches/safari-7614.1.14.1-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
branches/safari-7614.1.14.1-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
branches/safari-7614.1.14.1-branch/Tools/ChangeLog
branches/safari-7614.1.14.1-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog (294307 => 294308)

--- branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:40 UTC (rev 294307)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:47 UTC (rev 294308)
@@ -1,5 +1,66 @@
 2022-05-16  Russell Epstein  
 
+Cherry-pick r294264. rdar://problem/93118830
+
+Remove abandoned UseScreenCaptureKit preference
+https://bugs.webkit.org/show_bug.cgi?id=240460
+
+
+Reviewed by Youenn Fablet.
+
+We no longer need this switch to activate ScreenCaptureKit, and this code is no
+longer used. We should remove it to simplify the build and reduce complexity.
+
+Source/WebCore:
+
+* platform/mediastream/RealtimeMediaSourceCenter.h:
+(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted.
+(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.
+
+Source/WebKit:
+
+* GPUProcess/GPUProcess.cpp:
+(WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
+* GPUProcess/GPUProcess.h:
+* GPUProcess/GPUProcess.messages.in:
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultScreenCaptureKitEnabled): Deleted.
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _useScreenCaptureKit]): Deleted.
+(-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::updatePreferences):
+* 

[webkit-changes] [294307] branches/safari-7614.1.14.1-branch

[alancoon]

Title: [294307] branches/safari-7614.1.14.1-branch








Revision 294307
Author alanc...@apple.com
Date 2022-05-16 23:17:40 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294208. rdar://problem/93118830

AX: Remove CSSDisplayContentsAXSupportEnabled flag
https://bugs.webkit.org/show_bug.cgi?id=240409

Reviewed by Chris Fleizach.

Source/WebCore:

We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.

* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.

Source/WebKitLegacy/mac:

We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted.
(-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
branches/safari-7614.1.14.1-branch/Source/WebCore/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebCore/page/RuntimeEnabledFeatures.h
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
branches/safari-7614.1.14.1-branch/Tools/ChangeLog
branches/safari-7614.1.14.1-branch/Tools/DumpRenderTree/TestOptions.cpp




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog (294306 => 294307)

--- branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:19 UTC (rev 294306)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog	2022-05-17 06:17:40 UTC (rev 294307)
@@ -1,3 +1,53 @@
+2022-05-16  Russell Epstein  
+
+Cherry-pick r294208. rdar://problem/93118830
+
+AX: Remove CSSDisplayContentsAXSupportEnabled flag
+https://bugs.webkit.org/show_bug.cgi?id=240409
+
+Reviewed by Chris Fleizach.
+
+Source/WebCore:
+
+We added initial support without using this flag and will continue to
+fix bugs as we find them, making this flag unnecessary.
+
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted.
+(WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.
+
+Source/WebKitLegacy/mac:
+
+We added initial support without using this flag and will continue to
+fix bugs as we find them, making this flag unnecessary.
+
+* WebView/WebPreferenceKeysPrivate.h:
+* WebView/WebPreferences.mm:
+(-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted.
+(-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
+* WebView/WebPreferencesPrivate.h:
+
+Source/WTF:
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
+Tools:
+
+* DumpRenderTree/TestOptions.cpp:
+(WTR::TestOptions::defaults):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-14  Tyler Wilcock  
+
+AX: Remove CSSDisplayContentsAXSupportEnabled flag
+https://bugs.webkit.org/show_bug.cgi?id=240409
+
+Reviewed by Chris Fleizach.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2022-05-16  Alan Coon  
 
 Cherry-pick r294218. rdar://problem/90400867


Modified: branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (294306 => 294307)

--- branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-05-17 06:17:19 UTC (rev 294306)
+++ branches/safari-7614.1.14.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-05-17 06:17:40 UTC (rev 294307)
@@ -107,17 +107,6 @@
 WebKit:
   default: true
 
-CSSDisplayContentsAXSupportEnabled:
-  type: bool
-  humanReadableName: "Accessibility support for display: contents elements"
-  humanReadableDescription: "Enable work-in-progress accessibility support for display: contents elements"
-  webcoreBinding: RuntimeEnabledFeatures
-  defaultValue:
-WebKitLegacy:
-  default: 

[webkit-changes] [294306] trunk

[ross . kirsling]

Title: [294306] trunk








Revision 294306
Author ross.kirsl...@sony.com
Date 2022-05-16 23:17:19 -0700 (Mon, 16 May 2022)


Log Message
ISO8601::parseCalendarTime must throw in cases of time/date ambiguity
https://bugs.webkit.org/show_bug.cgi?id=240498

Reviewed by Yusuke Suzuki.

The CalendarTime production (https://tc39.es/proposal-temporal/#prod-CalendarTime) goes to a lot of trouble
to ensure that ambiguous parses are not allowed; this patch ensures that our implementation does so too.

In short:
- CalendarTime is basically TimeDesignator[opt] TimeSpec TimeZone[opt] Calendar[opt].
- When we don't have a TimeDesignator or a Calendar, we're in danger of ambiguity:
  -MM, MM, MM-DD, MMDD look the same as HHMM-UU, HHMMSS, HH-UU, HHMM (where UU is a UTC offset).
- The solution is to attempt to reparse the string as one of these date formats and throw if we succeed.

* stress/temporal-plaintime.js: Adjust expectations.
* test262/expectations.yaml: Mark 10 test cases as passing.

* runtime/ISO8601.cpp:
(JSC::ISO8601::isAmbiguousCalendarTime):
(JSC::ISO8601::parseCalendarTime):
(JSC::ISO8601::daysInMonth):
* runtime/ISO8601.h:

Canonical link: https://commits.webkit.org/250634@main

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/temporal-plaintime.js
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ISO8601.cpp
trunk/Source/_javascript_Core/runtime/ISO8601.h




Diff

Modified: trunk/JSTests/ChangeLog (294305 => 294306)

--- trunk/JSTests/ChangeLog	2022-05-17 06:11:13 UTC (rev 294305)
+++ trunk/JSTests/ChangeLog	2022-05-17 06:17:19 UTC (rev 294306)
@@ -1,3 +1,13 @@
+2022-05-16  Ross Kirsling  
+
+ISO8601::parseCalendarTime must throw in cases of time/date ambiguity
+https://bugs.webkit.org/show_bug.cgi?id=240498
+
+Reviewed by Yusuke Suzuki.
+
+* stress/temporal-plaintime.js: Adjust expectations.
+* test262/expectations.yaml: Mark 10 test cases as passing.
+
 2022-05-15  Angelos Oikonomopoulos  
 
 Skip flaky test on ARM


Modified: trunk/JSTests/stress/temporal-plaintime.js (294305 => 294306)

--- trunk/JSTests/stress/temporal-plaintime.js	2022-05-17 06:11:13 UTC (rev 294305)
+++ trunk/JSTests/stress/temporal-plaintime.js	2022-05-17 06:17:19 UTC (rev 294306)
@@ -95,13 +95,16 @@
 }
 
 shouldBe(String(Temporal.PlainTime.from('03')), `03:00:00`);
-shouldBe(String(Temporal.PlainTime.from('0314')), `03:14:00`);
+shouldBe(String(Temporal.PlainTime.from('T0314')), `03:14:00`);
+shouldThrow(() => Temporal.PlainTime.from('0314'), RangeError);
 shouldBe(String(Temporal.PlainTime.from('031415')), `03:14:15`);
 shouldBe(String(Temporal.PlainTime.from('03:14')), `03:14:00`);
 shouldBe(String(Temporal.PlainTime.from('03:14:15')), `03:14:15`);
 shouldBe(String(Temporal.PlainTime.from('03:24:30')), `03:24:30`);
-shouldBe(String(Temporal.PlainTime.from('2020-01')), `20:20:00`); // -01 UTC offset
-shouldBe(String(Temporal.PlainTime.from('01-01')), `01:00:00`); // -01 UTC offset
+shouldBe(String(Temporal.PlainTime.from('T2020-01')), `20:20:00`); // -01 UTC offset
+shouldThrow(() => Temporal.PlainTime.from('2020-01'), RangeError);
+shouldBe(String(Temporal.PlainTime.from('T01-01')), `01:00:00`); // -01 UTC offset
+shouldThrow(() => Temporal.PlainTime.from('01-01'), RangeError);
 shouldBe(String(Temporal.PlainTime.from('03:24:30[u-ca=japanese]')), `03:24:30`);
 shouldBe(String(Temporal.PlainTime.from('03:24:30+01:00[Europe/Brussels][u-ca=japanese]')), `03:24:30`);
 shouldBe(String(Temporal.PlainTime.from('03:24:30+01:00[u-ca=japanese]')), `03:24:30`);


Modified: trunk/JSTests/test262/expectations.yaml (294305 => 294306)

--- trunk/JSTests/test262/expectations.yaml	2022-05-17 06:11:13 UTC (rev 294305)
+++ trunk/JSTests/test262/expectations.yaml	2022-05-17 06:17:19 UTC (rev 294306)
@@ -1065,9 +1065,6 @@
 test/built-ins/Temporal/Instant/prototype/toString/timezone-string-multiple-offsets.js:
   default: 'RangeError: argument needs to be UTC offset string, TimeZone identifier, or temporal Instant string'
   strict mode: 'RangeError: argument needs to be UTC offset string, TimeZone identifier, or temporal Instant string'
-test/built-ins/Temporal/PlainTime/compare/argument-string-time-designator-required-for-disambiguation.js:
-  default: 'Test262Error: 2021-12 is ambiguous and requires T prefix (first argument) Expected a RangeError to be thrown but no exception was thrown at all'
-  strict mode: 'Test262Error: 2021-12 is ambiguous and requires T prefix (first argument) Expected a RangeError to be thrown but no exception was thrown at all'
 test/built-ins/Temporal/PlainTime/compare/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-not-callable.js:
   default: "TypeError: undefined is not a constructor (evaluating 'new Temporal.ZonedDateTime(1_000_000_000_987_654_321n, timeZone)')"
   strict mode: "TypeError: undefined is not a constructor (evaluating 'new 

[webkit-changes] [294304] branches/safari-613-branch

[alancoon]

Title: [294304] branches/safari-613-branch








Revision 294304
Author alanc...@apple.com
Date 2022-05-16 23:11:08 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293987. rdar://problem/92775435

Implement CSS :modal pseudo class
https://bugs.webkit.org/show_bug.cgi?id=240109

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Add and extend tests for :modal pseudo-class.

* web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt: Added.
* web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html: Added.
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-show-modal.html:

Source/WebCore:

Test: imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html

Renames :-internal-modal-dialog to :modal and adds :has() invalidation support.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* css/SelectorCheckerTestFunctions.h:
(WebCore::matchesModalPseudoClass):
(WebCore::matchesModalDialogPseudoClass): Deleted.
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* css/dialog.css:
(dialog:modal):
(dialog:-internal-modal-dialog): Deleted.
* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::removedFromAncestor):
(WebCore::HTMLDialogElement::setIsModal):
* html/HTMLDialogElement.h:

LayoutTests:

Removes :-internal-modal-dialog from internal pseudo classes.

* fast/css/pseudo-class-internal-expected.txt:
* fast/css/pseudo-class-internal.html:

Canonical link: https://commits.webkit.org/250424@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/fast/css/pseudo-class-internal-expected.txt
branches/safari-613-branch/LayoutTests/fast/css/pseudo-class-internal.html
branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-show-modal.html
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/css/CSSSelector.cpp
branches/safari-613-branch/Source/WebCore/css/CSSSelector.h
branches/safari-613-branch/Source/WebCore/css/SelectorChecker.cpp
branches/safari-613-branch/Source/WebCore/css/SelectorCheckerTestFunctions.h
branches/safari-613-branch/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
branches/safari-613-branch/Source/WebCore/css/dialog.css
branches/safari-613-branch/Source/WebCore/css/parser/CSSSelectorParser.cpp
branches/safari-613-branch/Source/WebCore/cssjit/SelectorCompiler.cpp
branches/safari-613-branch/Source/WebCore/html/HTMLDialogElement.cpp
branches/safari-613-branch/Source/WebCore/html/HTMLDialogElement.h


Added Paths

branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294303 => 294304)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:11:01 UTC (rev 294303)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:11:08 UTC (rev 294304)
@@ -1,5 +1,74 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293987. rdar://problem/92775435
+
+Implement CSS :modal pseudo class
+https://bugs.webkit.org/show_bug.cgi?id=240109
+
+Reviewed by Simon Fraser.
+
+LayoutTests/imported/w3c:
+
+Add and extend tests for :modal pseudo-class.
+
+* web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt: Added.
+* web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html: Added.
+* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-show-modal.html:
+
+Source/WebCore:
+
+Test: imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html
+
+Renames :-internal-modal-dialog to :modal and adds :has() invalidation support.
+
+* css/CSSSelector.cpp:
+(WebCore::CSSSelector::selectorText const):
+* css/CSSSelector.h:
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::checkOne const):
+* 

[webkit-changes] [294301] branches/safari-613-branch/Source

[alancoon]

Title: [294301] branches/safari-613-branch/Source








Revision 294301
Author alanc...@apple.com
Date 2022-05-16 23:10:55 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293894. rdar://problem/74201964

[iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
https://bugs.webkit.org/show_bug.cgi?id=239744


Reviewed by Eric Carlson.

Source/WebCore:

Even after fullscreen is correctly torn down during an immediate exit, fullscreen can never again
be entered for the lifetime of the page. This is due to the ivar m_pendingExitFullscreen being set
to true with no opportunity for that state to be cleared. This occurs because the callbacks for
exiting fullscreen are performed before the lambda form FullscreenManager::exitFullscreen() is
called.

Set m_pendingExitFullscreen inside exitFullscreen(), rather than the lambda, and clear it explicitly
in the cases where fullscreen exiting is not actually necessary.

The mock behavior of Fullscreen inside DumpRenderTree and WebKitTestRunner are not able to exercise
this same path. Track improvements to this mock in bug #239747.

* dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::setAnimatingFullscreen):
(WebCore::FullscreenManager::setFullscreenControlsHidden):

Source/WebKit:

When exiting fullscreen immediately, we trigger the correct state transition by calling
-[self exitFullScreen]. However, when no fullscreen manager exists (as may happen during
navigation), -exitFullscreen may itself call -_exitFullscreenImmediately, which causes an
infinite recursion and stack overflow.

Unroll the implementation by performing all the same pieces as would have been done by
-exitFullScreen, but inline. Refactor out common behavior into -_reinsertWebViewUnderPlaceholder,
and call that both from -_exitFullscreenImmediately and _completedExitFullScreen.

Unfortunately, no API tests are possible here because TestWebKitAPI is not an actual iOS UI
application.

* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController _reinsertWebViewUnderPlaceholder]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):

Canonical link: https://commits.webkit.org/250352@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/dom/FullscreenManager.cpp
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm




Diff

Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294300 => 294301)

--- branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:51 UTC (rev 294300)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:55 UTC (rev 294301)
@@ -1,5 +1,84 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293894. rdar://problem/74201964
+
+[iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
+https://bugs.webkit.org/show_bug.cgi?id=239744
+
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+Even after fullscreen is correctly torn down during an immediate exit, fullscreen can never again
+be entered for the lifetime of the page. This is due to the ivar m_pendingExitFullscreen being set
+to true with no opportunity for that state to be cleared. This occurs because the callbacks for
+exiting fullscreen are performed before the lambda form FullscreenManager::exitFullscreen() is
+called.
+
+Set m_pendingExitFullscreen inside exitFullscreen(), rather than the lambda, and clear it explicitly
+in the cases where fullscreen exiting is not actually necessary.
+
+The mock behavior of Fullscreen inside DumpRenderTree and WebKitTestRunner are not able to exercise
+this same path. Track improvements to this mock in bug #239747.
+
+* dom/FullscreenManager.cpp:
+(WebCore::FullscreenManager::requestFullscreenForElement):
+(WebCore::FullscreenManager::exitFullscreen):
+(WebCore::FullscreenManager::setAnimatingFullscreen):
+(WebCore::FullscreenManager::setFullscreenControlsHidden):
+
+Source/WebKit:
+
+When exiting fullscreen immediately, we trigger the correct state transition by calling
+-[self exitFullScreen]. However, when no fullscreen manager exists (as may happen during
+navigation), -exitFullscreen may itself call -_exitFullscreenImmediately, which causes an
+infinite recursion and stack overflow.
+
+Unroll the 

[webkit-changes] [294303] branches/safari-613-branch/Source/WebCore

[alancoon]

Title: [294303] branches/safari-613-branch/Source/WebCore








Revision 294303
Author alanc...@apple.com
Date 2022-05-16 23:11:01 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293981. rdar://problem/92084291

ASSERT in WebCore::RenderTreeUpdater::updateRenderTree
https://bugs.webkit.org/show_bug.cgi?id=240237

Reviewed by Antti Koivisto.

There are instances where calling findRenderingRoots() in RenderTreeUpdater::commit will
returns two rendering roots, with one of them being an ancestor of the other.

Calling updateRenderTree on the ancestor rendering root could end up removing
the renderer of the descendant rendering root.

This patch  merges findRenderingRoots() to RenderTreeUpdater::commit() which, and now we will
ignore the nested root if there is no longer a renderer when it is being processed.

* rendering/updating/RenderTreeUpdater.cpp:

Canonical link: https://commits.webkit.org/250419@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp




Diff

Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294302 => 294303)

--- branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:58 UTC (rev 294302)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:11:01 UTC (rev 294303)
@@ -1,5 +1,46 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293981. rdar://problem/92084291
+
+ASSERT in WebCore::RenderTreeUpdater::updateRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=240237
+
+Reviewed by Antti Koivisto.
+
+There are instances where calling findRenderingRoots() in RenderTreeUpdater::commit will
+returns two rendering roots, with one of them being an ancestor of the other.
+
+Calling updateRenderTree on the ancestor rendering root could end up removing
+the renderer of the descendant rendering root.
+
+This patch  merges findRenderingRoots() to RenderTreeUpdater::commit() which, and now we will
+ignore the nested root if there is no longer a renderer when it is being processed.
+
+* rendering/updating/RenderTreeUpdater.cpp:
+
+Canonical link: https://commits.webkit.org/250419@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-09  Gabriel Nava Marino  
+
+ASSERT in WebCore::RenderTreeUpdater::updateRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=240237
+
+Reviewed by Antti Koivisto.
+
+There are instances where calling findRenderingRoots() in RenderTreeUpdater::commit will
+returns two rendering roots, with one of them being an ancestor of the other.
+
+Calling updateRenderTree on the ancestor rendering root could end up removing
+the renderer of the descendant rendering root.
+
+This patch  merges findRenderingRoots() to RenderTreeUpdater::commit() which, and now we will
+ignore the nested root if there is no longer a renderer when it is being processed.
+
+* rendering/updating/RenderTreeUpdater.cpp:
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r293894. rdar://problem/74201964
 
 [iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]


Modified: branches/safari-613-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp (294302 => 294303)

--- branches/safari-613-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2022-05-17 06:10:58 UTC (rev 294302)
+++ branches/safari-613-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2022-05-17 06:11:01 UTC (rev 294303)
@@ -100,18 +100,6 @@
 return nullptr;
 }
 
-static ListHashSet findRenderingRoots(const Style::Update& update)
-{
-ListHashSet renderingRoots;
-for (auto& root : update.roots()) {
-auto* renderingRoot = findRenderingRoot(*root);
-if (!renderingRoot)
-continue;
-renderingRoots.add(renderingRoot);
-}
-return renderingRoots;
-}
-
 void RenderTreeUpdater::commit(std::unique_ptr styleUpdate)
 {
 ASSERT(_document == >document());
@@ -123,8 +111,12 @@
 
 m_styleUpdate = WTFMove(styleUpdate);
 
-for (auto* root : findRenderingRoots(*m_styleUpdate))
-updateRenderTree(*root);
+for (auto& root : m_styleUpdate->roots()) {
+auto* renderingRoot = findRenderingRoot(*root);
+if (!renderingRoot)
+continue;
+updateRenderTree(*renderingRoot);
+}
 
 generatedContent().updateRemainingQuotes();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294299] branches/safari-613-branch/Source/WebCore

[alancoon]

Title: [294299] branches/safari-613-branch/Source/WebCore








Revision 294299
Author alanc...@apple.com
Date 2022-05-16 23:10:49 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293647. rdar://problem/92257660

Only stretch the percent height  when it is the document element's child
https://bugs.webkit.org/show_bug.cgi?id=239932


Reviewed by Antti Koivisto.

This IE quirk should only be applied to when the body is actually the document element's child (stretching case).

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight const):
* rendering/RenderBox.h:
(WebCore::RenderBox::parentBox const):

Canonical link: https://commits.webkit.org/250151@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294298 => 294299)

--- branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:46 UTC (rev 294298)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:49 UTC (rev 294299)
@@ -1,5 +1,40 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293647. rdar://problem/92257660
+
+Only stretch the percent height  when it is the document element's child
+https://bugs.webkit.org/show_bug.cgi?id=239932
+
+
+Reviewed by Antti Koivisto.
+
+This IE quirk should only be applied to when the body is actually the document element's child (stretching case).
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalHeight const):
+* rendering/RenderBox.h:
+(WebCore::RenderBox::parentBox const):
+
+Canonical link: https://commits.webkit.org/250151@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-30  Alan Bujtas  
+
+Only stretch the percent height  when it is the document element's child
+https://bugs.webkit.org/show_bug.cgi?id=239932
+
+
+Reviewed by Antti Koivisto.
+
+This IE quirk should only be applied to when the body is actually the document element's child (stretching case).
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalHeight const):
+* rendering/RenderBox.h:
+(WebCore::RenderBox::parentBox const):
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r293264. rdar://problem/92130849
 
 Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs


Modified: branches/safari-613-branch/Source/WebCore/rendering/RenderBox.cpp (294298 => 294299)

--- branches/safari-613-branch/Source/WebCore/rendering/RenderBox.cpp	2022-05-17 06:10:46 UTC (rev 294298)
+++ branches/safari-613-branch/Source/WebCore/rendering/RenderBox.cpp	2022-05-17 06:10:49 UTC (rev 294299)
@@ -3176,14 +3176,20 @@
 }
 }
 
-// WinIE quirk: The  block always fills the entire canvas in quirks mode.  The  always fills the
-//  block in quirks mode.  Only apply this quirk if the block is normal flow and no height
+// WinIE quirk: The  block always fills the entire canvas in quirks mode. The  always fills the
+//  block in quirks mode. Only apply this quirk if the block is normal flow and no height
 // is specified. When we're printing, we also need this quirk if the body or root has a percentage 
 // height since we don't set a height in RenderView when we're printing. So without this quirk, the 
 // height has nothing to be a percentage of, and it ends up being 0. That is bad.
-bool paginatedContentNeedsBaseHeight = document().printing() && h.isPercentOrCalculated()
-&& (isDocumentElementRenderer() || (isBody() && document().documentElement()->renderer()->style().logicalHeight().isPercentOrCalculated())) && !isInline();
-if (stretchesToViewport() || paginatedContentNeedsBaseHeight) {
+auto paginatedContentNeedsBaseHeight = [&] {
+if (!document().printing() || !h.isPercentOrCalculated() || isInline())
+return false;
+if (isDocumentElementRenderer())
+return true;
+auto* documentElementRenderer = document().documentElement()->renderer();
+return isBody() && parent() == documentElementRenderer && documentElementRenderer->style().logicalHeight().isPercentOrCalculated();
+};
+if (stretchesToViewport() || paginatedContentNeedsBaseHeight()) {
 LayoutUnit margins = collapsedMarginBefore() + collapsedMarginAfter();
 LayoutUnit visibleHeight = view().pageOrViewLogicalHeight();
 if (isDocumentElementRenderer())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [294298] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [294298] branches/safari-613-branch/Source/WebKit








Revision 294298
Author alanc...@apple.com
Date 2022-05-16 23:10:46 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293433. rdar://problem/91981865

[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
https://bugs.webkit.org/show_bug.cgi?id=239746
rdar://91981865

Reviewed by Brent Fulgham.

Passing platform in requestTypes breaks the UI in registerations with the syncing platform
authenticator off and local service is unavailable. This patch stops passing it in this case.

* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureRegistrationRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

Canonical link: https://commits.webkit.org/249993@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (294297 => 294298)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-17 06:10:43 UTC (rev 294297)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-17 06:10:46 UTC (rev 294298)
@@ -1,5 +1,40 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293433. rdar://problem/91981865
+
+[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
+https://bugs.webkit.org/show_bug.cgi?id=239746
+rdar://91981865
+
+Reviewed by Brent Fulgham.
+
+Passing platform in requestTypes breaks the UI in registerations with the syncing platform
+authenticator off and local service is unavailable. This patch stops passing it in this case.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::configureRegistrationRequestContext):
+(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
+
+Canonical link: https://commits.webkit.org/249993@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-26  J Pascoe  
+
+[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
+https://bugs.webkit.org/show_bug.cgi?id=239746
+rdar://91981865
+
+Reviewed by Brent Fulgham.
+
+Passing platform in requestTypes breaks the UI in registerations with the syncing platform
+authenticator off and local service is unavailable. This patch stops passing it in this case.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::configureRegistrationRequestContext):
+(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r293170. rdar://problem/91117803
 
 AVSampleBufferRenderSynchronizer timeline sometimes goes backwards when playback begins


Modified: branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (294297 => 294298)

--- branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2022-05-17 06:10:43 UTC (rev 294297)
+++ branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2022-05-17 06:10:46 UTC (rev 294298)
@@ -190,6 +190,8 @@
 
 shouldRequireResidentKey = authenticatorSelection->requireResidentKey;
 }
+if (!LocalService::isAvailable())
+requestTypes &= ~ASCCredentialRequestTypePlatformPublicKeyRegistration;
 
 auto requestContext = adoptNS([allocASCCredentialRequestContextInstance() initWithRequestTypes:requestTypes]);
 [requestContext setRelyingPartyIdentifier:options.rp.id];
@@ -370,6 +372,10 @@
 
 void WebAuthenticatorCoordinatorProxy::performRequest(RetainPtr requestContext, RequestCompletionHandler&& handler)
 {
+if (requestContext.get().requestTypes == ASCCredentialRequestTypeNone) {
+handler({ }, (AuthenticatorAttachment)0, ExceptionData { NotAllowedError, "This request has been cancelled by the user."_s });
+return;
+}
 m_proxy = adoptNS([allocASCAgentProxyInstance() init]);
 #if PLATFORM(IOS)
 [m_proxy performAuthorizationRequestsForContext:requestContext.get() withCompletionHandler:makeBlockPtr([handler = WTFMove(handler)](id credential, NSError *error) mutable {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294302] branches/safari-613-branch/Source/bmalloc

[alancoon]

Title: [294302] branches/safari-613-branch/Source/bmalloc








Revision 294302
Author alanc...@apple.com
Date 2022-05-16 23:10:58 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293952. rdar://problem/92913312

Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209

Reviewed by Yusuke Suzuki.

Clang currently optimizes all crash sites into one in each function.  Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there.  This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.

Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.

Size-wise, there is some increase.  The following is the "size" output on
_javascript_Core on M1:

  __TEXT.   __DATA  __OBJC  othersdec   hex
old   19628032  180224  0   18792448  38600704  24d
new   19644416  180224  0   19251200  39075840  2544000

diff  16384 0   0   458752475136

The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses.  These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.

* libpas/src/libpas/pas_utils.h:
(pas_assertion_failed):

Canonical link: https://commits.webkit.org/250398@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/bmalloc/ChangeLog
branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_utils.h




Diff

Modified: branches/safari-613-branch/Source/bmalloc/ChangeLog (294301 => 294302)

--- branches/safari-613-branch/Source/bmalloc/ChangeLog	2022-05-17 06:10:55 UTC (rev 294301)
+++ branches/safari-613-branch/Source/bmalloc/ChangeLog	2022-05-17 06:10:58 UTC (rev 294302)
@@ -1,3 +1,68 @@
+2022-05-16  Alan Coon  
+
+Cherry-pick r293952. rdar://problem/92913312
+
+Force PAS_ASSERT to generate different crash sites for each assertion.
+https://bugs.webkit.org/show_bug.cgi?id=240209
+
+Reviewed by Yusuke Suzuki.
+
+Clang currently optimizes all crash sites into one in each function.  Hence, if we
+get a crash address at the 1 crash site, we don't know which failed assertion got
+us there.  This patch uses an asm statement to force Clang to emit a different
+crash site for each assertion.
+
+Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
+
+Size-wise, there is some increase.  The following is the "size" output on
+_javascript_Core on M1:
+
+  __TEXT.   __DATA  __OBJC  othersdec   hex
+old   19628032  180224  0   18792448  38600704  24d
+new   19644416  180224  0   19251200  39075840  2544000
+
+diff  16384 0   0   458752475136
+
+The increase in the "others" categories are mostly in the String Table, Symbol
+Table, and Function Start Addresses.  These take up disk space but should not
+impact RAM usage unless they are accessed by a a debugger.
+
+* libpas/src/libpas/pas_utils.h:
+(pas_assertion_failed):
+
+Canonical link: https://commits.webkit.org/250398@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-07  Mark Lam  
+
+Force PAS_ASSERT to generate different crash sites for each assertion.
+https://bugs.webkit.org/show_bug.cgi?id=240209
+
+Reviewed by Yusuke Suzuki.
+
+Clang currently optimizes all crash sites into one in each function.  Hence, if we
+get a crash address at the 1 crash site, we don't know which failed assertion got
+us there.  This patch uses an asm statement to force Clang to emit a different
+crash site for each assertion.
+
+Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
+
+Size-wise, there is some increase.  The following is the "size" output on
+_javascript_Core on M1:
+
+  __TEXT.   __DATA  __OBJC  othersdec   hex
+old   19628032  180224  0   18792448  38600704  24d
+new   19644416  180224  0   19251200  39075840  2544000
+
+diff  16384 0   0   458752475136
+
+The increase in the "others" categories are mostly in the String Table, Symbol
+Table, and Function Start Addresses.  These take up disk space but should not
+impact RAM usage unless they are accessed by a a debugger.
+
+* libpas/src/libpas/pas_utils.h:
+(pas_assertion_failed):
+
 2022-03-21  Alan Coon  
 
 Cherry-pick r291199. 

[webkit-changes] [294297] branches/safari-613-branch

[alancoon]

Title: [294297] branches/safari-613-branch








Revision 294297
Author alanc...@apple.com
Date 2022-05-16 23:10:43 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293264. rdar://problem/92130849

Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs
https://bugs.webkit.org/show_bug.cgi?id=239667

Reviewed by Devin Rousso.

Source/WebCore:

Updated tests:
- http/tests/inspector/network/resource-response-source-disk-cache.html
- http/tests/inspector/network/resource-response-source-memory-cache.html

r287684 introduced a subtle bug when calling InspectorInstrumentation::didReceiveData. We rely
on there being a difference between real, but empty, data buffer and not having a data buffer,
but after r287684 an empty SharedBuffer would be passed in the later case. Instead, we should
continue to pass nullptr if there is no buffer so that InspectorNetworkAgent::didReceiveData
can distiguish between the two.

The bug is the result of having a non-nullptr `data` in `InspectorNetworkAgent::didReceiveData`,
which causes us to call `maybeAddResourceData`, which means by the time
`InspectorNetworkAgent::getResponseBody` is called, the ResourceData for the request will have
an empty, not non-existant, `content()`, which means we will return the empty content instead,
since we believe the response had actual content.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveDataImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveData):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidReceiveData):

LayoutTests:

Add test steps to ensure that the resource has content, and that the base64Encoded value matches our
expectations. While only the memory cache was affected by this regression, add the test steps to both
the memory and disk caches to defend this functionality.

* http/tests/inspector/network/resource-response-source-memory-cache-expected.txt:
* http/tests/inspector/network/resource-response-source-memory-cache.html:
* http/tests/inspector/network/resource-response-source-disk-cache-expected.txt:
* http/tests/inspector/network/resource-response-source-disk-cache.html:

Canonical link: https://commits.webkit.org/249905@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/http/tests/inspector/network/resource-response-source-disk-cache-expected.txt
branches/safari-613-branch/LayoutTests/http/tests/inspector/network/resource-response-source-disk-cache.html
branches/safari-613-branch/LayoutTests/http/tests/inspector/network/resource-response-source-memory-cache-expected.txt
branches/safari-613-branch/LayoutTests/http/tests/inspector/network/resource-response-source-memory-cache.html
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/inspector/InspectorInstrumentation.cpp
branches/safari-613-branch/Source/WebCore/inspector/InspectorInstrumentation.h
branches/safari-613-branch/Source/WebCore/loader/ResourceLoadNotifier.cpp




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294296 => 294297)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:38 UTC (rev 294296)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:43 UTC (rev 294297)
@@ -1,5 +1,69 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293264. rdar://problem/92130849
+
+Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs
+https://bugs.webkit.org/show_bug.cgi?id=239667
+
+Reviewed by Devin Rousso.
+
+Source/WebCore:
+
+Updated tests:
+- http/tests/inspector/network/resource-response-source-disk-cache.html
+- http/tests/inspector/network/resource-response-source-memory-cache.html
+
+r287684 introduced a subtle bug when calling InspectorInstrumentation::didReceiveData. We rely
+on there being a difference between real, but empty, data buffer and not having a data buffer,
+but after r287684 an empty SharedBuffer would be passed in the later case. Instead, we should
+continue to pass nullptr if there is no buffer so that InspectorNetworkAgent::didReceiveData
+can distiguish between the two.
+
+The bug is the result of having a non-nullptr `data` in `InspectorNetworkAgent::didReceiveData`,
+which causes us to call `maybeAddResourceData`, which means by the time
+`InspectorNetworkAgent::getResponseBody` is called, the ResourceData for the request will have
+an empty, not non-existant, `content()`, which means we will return the empty content instead,
+

[webkit-changes] [294296] branches/safari-613-branch/Source

[alancoon]

Title: [294296] branches/safari-613-branch/Source








Revision 294296
Author alanc...@apple.com
Date 2022-05-16 23:10:38 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293220. rdar://problem/91924480

Apply purifyNaN in more places.
https://bugs.webkit.org/show_bug.cgi?id=239619


Reviewed by Yusuke Suzuki.

Source/_javascript_Core:

* wasm/js/JSWebAssemblyHelpers.h:
(JSC::toJSValue):

Source/WebCore:

* bindings/js/IDBBindingUtilities.cpp:
(WebCore::toJS):
* bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertObjcValueToValue):

Canonical link: https://commits.webkit.org/249889@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/_javascript_Core/ChangeLog
branches/safari-613-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyHelpers.h
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/bindings/js/IDBBindingUtilities.cpp
branches/safari-613-branch/Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp
branches/safari-613-branch/Source/WebCore/bindings/js/SerializedScriptValue.cpp
branches/safari-613-branch/Source/WebCore/bridge/objc/objc_utility.mm




Diff

Modified: branches/safari-613-branch/Source/_javascript_Core/ChangeLog (294295 => 294296)

--- branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-05-17 06:10:33 UTC (rev 294295)
+++ branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-05-17 06:10:38 UTC (rev 294296)
@@ -1,3 +1,43 @@
+2022-05-16  Alan Coon  
+
+Cherry-pick r293220. rdar://problem/91924480
+
+Apply purifyNaN in more places.
+https://bugs.webkit.org/show_bug.cgi?id=239619
+
+
+Reviewed by Yusuke Suzuki.
+
+Source/_javascript_Core:
+
+* wasm/js/JSWebAssemblyHelpers.h:
+(JSC::toJSValue):
+
+Source/WebCore:
+
+* bindings/js/IDBBindingUtilities.cpp:
+(WebCore::toJS):
+* bindings/js/JSDOMConvertWebGL.cpp:
+(WebCore::convertToJSValue):
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::CloneDeserializer::readTerminal):
+* bridge/objc/objc_utility.mm:
+(JSC::Bindings::convertObjcValueToValue):
+
+Canonical link: https://commits.webkit.org/249889@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-22  Mark Lam  
+
+Apply purifyNaN in more places.
+https://bugs.webkit.org/show_bug.cgi?id=239619
+
+
+Reviewed by Yusuke Suzuki.
+
+* wasm/js/JSWebAssemblyHelpers.h:
+(JSC::toJSValue):
+
 2022-04-29  Alan Coon  
 
 Cherry-pick r287877. rdar://problem/92357915


Modified: branches/safari-613-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyHelpers.h (294295 => 294296)

--- branches/safari-613-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyHelpers.h	2022-05-17 06:10:33 UTC (rev 294295)
+++ branches/safari-613-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyHelpers.h	2022-05-17 06:10:38 UTC (rev 294296)
@@ -153,7 +153,7 @@
 case Wasm::TypeKind::I32:
 return jsNumber(static_cast(bits));
 case Wasm::TypeKind::F32:
-return jsNumber(bitwise_cast(static_cast(bits)));
+return jsNumber(purifyNaN(bitwise_cast(static_cast(bits;
 case Wasm::TypeKind::F64:
 return jsNumber(bitwise_cast(bits));
 case Wasm::TypeKind::I64:


Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294295 => 294296)

--- branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:33 UTC (rev 294295)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog	2022-05-17 06:10:38 UTC (rev 294296)
@@ -1,5 +1,51 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293220. rdar://problem/91924480
+
+Apply purifyNaN in more places.
+https://bugs.webkit.org/show_bug.cgi?id=239619
+
+
+Reviewed by Yusuke Suzuki.
+
+Source/_javascript_Core:
+
+* wasm/js/JSWebAssemblyHelpers.h:
+(JSC::toJSValue):
+
+Source/WebCore:
+
+* bindings/js/IDBBindingUtilities.cpp:
+(WebCore::toJS):
+* bindings/js/JSDOMConvertWebGL.cpp:
+(WebCore::convertToJSValue):
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::CloneDeserializer::readTerminal):
+* bridge/objc/objc_utility.mm:
+(JSC::Bindings::convertObjcValueToValue):
+
+Canonical link: https://commits.webkit.org/249889@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-22  Mark Lam  
+
+Apply purifyNaN in more places.
+https://bugs.webkit.org/show_bug.cgi?id=239619
+
+
+

[webkit-changes] [294300] branches/safari-613-branch/Source/WebCore/platform/graphics/ avfoundation/objc

[alancoon]

Title: [294300] branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc








Revision 294300
Author alanc...@apple.com
Date 2022-05-16 23:10:51 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293877. rdar://problem/92676179

[Cocoa] QueuedVideoOutput constructor missing nil check
https://bugs.webkit.org/show_bug.cgi?id=240149

Reviewed by Eric Carlson.

Covered by existing tests.
* Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h:
* Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm:
(WebCore::QueuedVideoOutput::create):
(WebCore::QueuedVideoOutput::QueuedVideoOutput):
(WebCore::QueuedVideoOutput::valid):

Canonical link: https://commits.webkit.org/250335@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h
branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm




Diff

Modified: branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h (294299 => 294300)

--- branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h	2022-05-17 06:10:49 UTC (rev 294299)
+++ branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h	2022-05-17 06:10:51 UTC (rev 294300)
@@ -49,9 +49,10 @@
 , public CanMakeWeakPtr {
 WTF_MAKE_FAST_ALLOCATED;
 public:
-static Ref create(AVPlayerItem*, AVPlayer*);
+static RefPtr create(AVPlayerItem*, AVPlayer*);
 ~QueuedVideoOutput();
 
+bool valid();
 void invalidate();
 bool hasImageForTime(const MediaTime&) const;
 


Modified: branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm (294299 => 294300)

--- branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm	2022-05-17 06:10:49 UTC (rev 294299)
+++ branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm	2022-05-17 06:10:51 UTC (rev 294300)
@@ -123,9 +123,10 @@
 return globalQueue;
 }
 
-Ref QueuedVideoOutput::create(AVPlayerItem* item, AVPlayer* player)
+RefPtr QueuedVideoOutput::create(AVPlayerItem* item, AVPlayer* player)
 {
-return adoptRef(*new QueuedVideoOutput(item, player));
+auto queuedVideoOutput = adoptRef(new QueuedVideoOutput(item, player));
+return queuedVideoOutput->valid() ? queuedVideoOutput : nullptr;
 }
 
 QueuedVideoOutput::QueuedVideoOutput(AVPlayerItem* item, AVPlayer* player)
@@ -137,6 +138,9 @@
 [m_videoOutput setDelegate:m_delegate.get() queue:globalOutputDelegateQueue()];
 [m_videoOutput requestNotificationOfMediaDataChangeAsSoonAsPossible];
 
+if (!m_videoOutput)
+return;
+
 [m_playerItem addOutput:m_videoOutput.get()];
 
 [m_player addObserver:m_delegate.get() forKeyPath:@"rate" options:(NSKeyValueObservingOptionNew | NSKeyValueObservingOptionInitial) context:nil];
@@ -159,6 +163,14 @@
 invalidate();
 }
 
+bool QueuedVideoOutput::valid()
+{
+return m_videoTimebaseObserver
+&& m_videoOutput
+&& m_player
+&& m_playerItem;
+}
+
 void QueuedVideoOutput::invalidate()
 {
 if (m_videoTimebaseObserver) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294305] branches/safari-613-branch

[alancoon]

Title: [294305] branches/safari-613-branch








Revision 294305
Author alanc...@apple.com
Date 2022-05-16 23:11:13 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r294012. rdar://problem/92425915

Fix inertness of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=239831

Reviewed by Antti Koivisto.

When we adjust style for a pseudo-element, `m_element` and `document().activeModalDialog()` are both null. So we accidentally reset inertness to false in those cases.

Fix this by making checking for m_element's existence too.

LayoutTests/imported/w3c:

* web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
* web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.

Source/WebCore:

Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html

* style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

LayoutTests:

* platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.

Canonical link: https://commits.webkit.org/250446@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/style/StyleAdjuster.cpp


Added Paths

branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html
branches/safari-613-branch/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294304 => 294305)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:11:08 UTC (rev 294304)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:11:13 UTC (rev 294305)
@@ -1,5 +1,50 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r294012. rdar://problem/92425915
+
+Fix inertness of pseudo-elements
+https://bugs.webkit.org/show_bug.cgi?id=239831
+
+Reviewed by Antti Koivisto.
+
+When we adjust style for a pseudo-element, `m_element` and `document().activeModalDialog()` are both null. So we accidentally reset inertness to false in those cases.
+
+Fix this by making checking for m_element's existence too.
+
+LayoutTests/imported/w3c:
+
+* web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
+* web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.
+
+Source/WebCore:
+
+Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html
+
+* style/StyleAdjuster.cpp:
+(WebCore::Style::Adjuster::adjust const):
+
+LayoutTests:
+
+* platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
+
+Canonical link: https://commits.webkit.org/250446@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-10  Tim Nguyen  
+
+Fix inertness of pseudo-elements
+https://bugs.webkit.org/show_bug.cgi?id=239831
+
+Reviewed by Antti Koivisto.
+
+When we adjust style for a pseudo-element, `m_element` and `document().activeModalDialog()` are both null. So we accidentally reset inertness to false in those cases.
+
+Fix this by making checking for m_element's existence too.
+
+* platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
+
+2022-05-16  Alan Coon  
+
 Cherry-pick r293987. rdar://problem/92775435
 
 Implement CSS :modal pseudo class


Modified: branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog (294304 => 294305)

--- branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog	2022-05-17 06:11:08 UTC (rev 294304)
+++ branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog	2022-05-17 06:11:13 UTC (rev 294305)
@@ -1,5 +1,51 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r294012. rdar://problem/92425915
+
+Fix inertness of pseudo-elements
+https://bugs.webkit.org/show_bug.cgi?id=239831
+
+Reviewed by Antti Koivisto.
+
+When we adjust style for a pseudo-element, `m_element` and `document().activeModalDialog()` are both null. So we accidentally reset inertness to false in those cases.
+
+Fix this by making checking for m_element's existence too.
+
+LayoutTests/imported/w3c:
+
+* web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
+* web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.
+
+

[webkit-changes] [294292] branches/safari-613-branch

[alancoon]

Title: [294292] branches/safari-613-branch








Revision 294292
Author alanc...@apple.com
Date 2022-05-16 23:10:19 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r292350. rdar://problem/90589355

intersectsWithAncestor should take fragmented boxes into account.
https://bugs.webkit.org/show_bug.cgi?id=238648

Reviewed by Dean Jackson.

Source/WebCore:

Test: compositing/backing/backing-store-columns-inside-position-fixed.html

* rendering/RenderLayerBacking.cpp:
(WebCore::intersectsWithAncestor):

Use boundingBox() for intersectsWithAncestor, so that we can explicitly request the box that contains
all fragment boxes.

LayoutTests:

* compositing/backing/backing-store-columns-inside-position-fixed-expected.txt: Added.
* compositing/backing/backing-store-columns-inside-position-fixed.html: Added.

Adds new test that scrolls content split into columns until the first column is offscreen, to confirm
that we still have a backing store.

Canonical link: https://commits.webkit.org/249215@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed-expected.txt
branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294291 => 294292)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 05:59:55 UTC (rev 294291)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:19 UTC (rev 294292)
@@ -1,3 +1,46 @@
+2022-05-16  Alan Coon  
+
+Cherry-pick r292350. rdar://problem/90589355
+
+intersectsWithAncestor should take fragmented boxes into account.
+https://bugs.webkit.org/show_bug.cgi?id=238648
+
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+Test: compositing/backing/backing-store-columns-inside-position-fixed.html
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::intersectsWithAncestor):
+
+Use boundingBox() for intersectsWithAncestor, so that we can explicitly request the box that contains
+all fragment boxes.
+
+LayoutTests:
+
+* compositing/backing/backing-store-columns-inside-position-fixed-expected.txt: Added.
+* compositing/backing/backing-store-columns-inside-position-fixed.html: Added.
+
+Adds new test that scrolls content split into columns until the first column is offscreen, to confirm
+that we still have a backing store.
+
+Canonical link: https://commits.webkit.org/249215@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-04  Matt Woodrow  
+
+intersectsWithAncestor should take fragmented boxes into account.
+https://bugs.webkit.org/show_bug.cgi?id=238648
+
+Reviewed by Dean Jackson.
+
+* compositing/backing/backing-store-columns-inside-position-fixed-expected.txt: Added.
+* compositing/backing/backing-store-columns-inside-position-fixed.html: Added.
+
+Adds new test that scrolls content split into columns until the first column is offscreen, to confirm
+that we still have a backing store.
+
 2022-05-03  Sihui Liu  
 
 StorageMap::removeItem may fail to remove item from map


Added: branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed-expected.txt (0 => 294292)

--- branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed-expected.txt	(rev 0)
+++ branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed-expected.txt	2022-05-17 06:10:19 UTC (rev 294292)
@@ -0,0 +1,21 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (backingStoreAttached 1)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (backingStoreAttached 1)
+  (children 1
+(GraphicsLayer
+  (position 8.00 0.00)
+  (bounds 600.00 600.00)
+  (drawsContent 1)
+  (backingStoreAttached 1)
+)
+  )
+)
+  )
+)
+


Added: branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed.html (0 => 294292)

--- branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed.html	(rev 0)
+++ branches/safari-613-branch/LayoutTests/compositing/backing/backing-store-columns-inside-position-fixed.html	2022-05-17 06:10:19 UTC (rev 294292)
@@ 

[webkit-changes] [294293] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [294293] branches/safari-613-branch/Source/WebKit








Revision 294293
Author alanc...@apple.com
Date 2022-05-16 23:10:23 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r292738. rdar://problem/91295875

Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=239089


Patch by Alex Christensen  on 2022-04-11
Reviewed by Chris Dumez.

The latter dereferences the frame loader which can be null.

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

Canonical link: https://commits.webkit.org/249522@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (294292 => 294293)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-17 06:10:19 UTC (rev 294292)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-17 06:10:23 UTC (rev 294293)
@@ -1,3 +1,35 @@
+2022-05-16  Alan Coon  
+
+Cherry-pick r292738. rdar://problem/91295875
+
+Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=239089
+
+
+Patch by Alex Christensen  on 2022-04-11
+Reviewed by Chris Dumez.
+
+The latter dereferences the frame loader which can be null.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
+
+Canonical link: https://commits.webkit.org/249522@main
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-11  Alex Christensen  
+
+Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=239089
+
+
+Reviewed by Chris Dumez.
+
+The latter dereferences the frame loader which can be null.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
+
 2022-05-02  Alan Coon  
 
 Apply patch. rdar://problem/92617943


Modified: branches/safari-613-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (294292 => 294293)

--- branches/safari-613-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2022-05-17 06:10:19 UTC (rev 294292)
+++ branches/safari-613-branch/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2022-05-17 06:10:23 UTC (rev 294293)
@@ -308,8 +308,8 @@
 && resourceLoader.frameLoader()->notifier().isInitialRequestIdentifier(identifier)
 ? MainFrameMainResource::Yes : MainFrameMainResource::No;
 if (!page->allowsLoadFromURL(request.url(), mainFrameMainResource)) {
-RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader }] {
-resourceLoader->didFail(resourceLoader->blockedError());
+RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader }, error = blockedError(request)] {
+resourceLoader->didFail(error);
 });
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294294] branches/safari-613-branch

[alancoon]

Title: [294294] branches/safari-613-branch








Revision 294294
Author alanc...@apple.com
Date 2022-05-16 23:10:28 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293126. rdar://problem/90483049

REGRESSION (r281913): Map toolbar flickers when dragging the map on https://gis.ee/
https://bugs.webkit.org/show_bug.cgi?id=238589


Reviewed by Alan Bujtas.
Source/WebCore:

If a layer has negative z-order descendants, and one of those descendants becomes
composited, then that layer also has to composite, because its foreground needs to render in
front of those descendants. But this is tricky, because the compositing toggle is
out-of-order; we only know that the layer has to get composited after processing
descendants.

In particular, this created a problem with the overlap map, which tracks sets of rectangles
in "compositing scopes" via LayerOverlapMap. The delayed compositing toggle of the layer
with negative z-order descendants meant that any layers processed up to that point had their
bounds added in the wrong overlap scope. This resulted in subsequent bad overlap testing,
and a failure to make later layers composited.

The previous fix in this area (r281913) was incorrect. Revert it, and do a better fix, which
is to speculatively push an overlap map entry for the layer with negative z-order
descendants, if necessary. If this layer ends up not getting composited, we unwind the
speculative push, which will merge that scope with its parent scope.

In addition give OverlapMapContainer (an "overlap scope") a RenderLayer& which we can use
for logging, and to assert on correct behavior; it is not otherwise used in release builds.

Tests: compositing/layer-creation/overlap-with-negative-z-layers.html
   compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html

* rendering/LayerOverlapMap.cpp:
(WebCore::OverlapMapContainer::OverlapMapContainer):
(WebCore::OverlapMapContainer::scopeLayer const):
(WebCore::OverlapMapContainer::dump const):
(WebCore::LayerOverlapMap::LayerOverlapMap):
(WebCore::LayerOverlapMap::add):
(WebCore::LayerOverlapMap::pushCompositingContainer):
(WebCore::LayerOverlapMap::popCompositingContainer):
* rendering/LayerOverlapMap.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateOverlapMap const):

LayoutTests:

Move subtree-div-overlaps-multiple-negative-z-divs.html into the layer-creation directory.
Add a new test.

* compositing/layer-creation/overlap-with-negative-z-layers-expected.html: Added.
* compositing/layer-creation/overlap-with-negative-z-layers.html: Added.
* compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs-expected.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs-expected.html.
* compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs.html.
* fast/harness/render-tree-as-text-options-expected.txt: Test progressed; update results.

Canonical link: https://commits.webkit.org/249828@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/fast/harness/render-tree-as-text-options-expected.txt
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/rendering/LayerOverlapMap.cpp
branches/safari-613-branch/Source/WebCore/rendering/LayerOverlapMap.h
branches/safari-613-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

branches/safari-613-branch/LayoutTests/compositing/layer-creation/overlap-with-negative-z-layers-expected.html
branches/safari-613-branch/LayoutTests/compositing/layer-creation/overlap-with-negative-z-layers.html
branches/safari-613-branch/LayoutTests/compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs-expected.html
branches/safari-613-branch/LayoutTests/compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html


Removed Paths

branches/safari-613-branch/LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs-expected.html
branches/safari-613-branch/LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294293 => 294294)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:23 UTC (rev 294293)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:28 UTC (rev 294294)
@@ -1,5 +1,84 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293126. 

[webkit-changes] [294295] branches/safari-613-branch

[alancoon]

Title: [294295] branches/safari-613-branch








Revision 294295
Author alanc...@apple.com
Date 2022-05-16 23:10:33 -0700 (Mon, 16 May 2022)


Log Message
Cherry-pick r293170. rdar://problem/91117803

AVSampleBufferRenderSynchronizer timeline sometimes goes backwards when playback begins
https://bugs.webkit.org/show_bug.cgi?id=239471
rdar://91117803

Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-source/media-source-current-time.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Log current time and requested
playback rate.
(WebCore::HTMLMediaElement::setPausedInternal): Log.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
If time has gone backward, clamp to the most recent seek time.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime const): Use clampTimeToLastSeekTime.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::clampTimeToLastSeekTime const): New,
clamp time value to the most recent seek time.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCurrentTimeDidChangeCallback):
Use clampTimeToLastSeekTime.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableVideoFrame): INFO_LOG -> ALWAYS_LOG
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): INFO_LOG -> ALWAYS_LOG

Source/WebKit:

* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::currentTimeChanged): Log when time jumps backwards.

LayoutTests:

* media/media-source/media-source-current-time-expected.txt: Added.
* media/media-source/media-source-current-time.html: Added.

Canonical link: https://commits.webkit.org/249852@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp


Added Paths

branches/safari-613-branch/LayoutTests/media/media-source/media-source-current-time-expected.txt
branches/safari-613-branch/LayoutTests/media/media-source/media-source-current-time.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294294 => 294295)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:28 UTC (rev 294294)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-05-17 06:10:33 UTC (rev 294295)
@@ -1,5 +1,65 @@
 2022-05-16  Alan Coon  
 
+Cherry-pick r293170. rdar://problem/91117803
+
+AVSampleBufferRenderSynchronizer timeline sometimes goes backwards when playback begins
+https://bugs.webkit.org/show_bug.cgi?id=239471
+rdar://91117803
+
+Reviewed by Jer Noble.
+
+Source/WebCore:
+
+Test: media/media-source/media-source-current-time.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Log current time and requested
+playback rate.
+(WebCore::HTMLMediaElement::setPausedInternal): Log.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
+If time has gone backward, clamp to the most recent seek time.
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): INFO_LOG -> ALWAYS_LOG
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal): Ditto.
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime const): Use clampTimeToLastSeekTime.
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::clampTimeToLastSeekTime const): New,
+clamp time value to the most recent seek time.
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCurrentTimeDidChangeCallback):
+Use 

[webkit-changes] [294291] trunk

[antti]

Title: [294291] trunk








Revision 294291
Author an...@apple.com
Date 2022-05-16 22:59:55 -0700 (Mon, 16 May 2022)


Log Message
Resolve ::first-letter eagerly
https://bugs.webkit.org/show_bug.cgi?id=239844

Reviewed by Alan Bujtas.

Source/WebCore:

::first-letter pseudo-element should be resolved eagerly during style resolution, similar to ::first-line.
This will clean up the architecture. It also makes ::first-letter animatable.

* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange): Deleted.
* rendering/RenderTextFragment.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::removeCachedPseudoStyle): Deleted.

We always create a new style. There is no need to removed pseudo element styles.

* rendering/style/RenderStyle.h:
* rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::styleForFirstLetter):

Pull first-letter style from the parent style instead of resolving it in the middle of render tree building.

(WebCore::RenderTreeBuilder::FirstLetter::updateAfterDescendants):
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):

Delete the renderer if we no longer have a style.

(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
* rendering/updating/RenderTreeBuilderFirstLetter.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):

Resove first-letter.

(WebCore::Style::TreeResolver::resolvePseudoElement):
(WebCore::Style::TreeResolver::resolveInheritedPseudoElement):

Factor into a function.

(WebCore::Style::isChildInBlockFormattingContext):
(WebCore::Style::TreeResolver::resolveAncestorFirstLinePseudoElement):
(WebCore::Style::TreeResolver::resolveAncestorFirstLetterPseudoElement):

Resolving first-letter is similar to first-line except it is always a leaf and so won't be inherited from.

(WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement):
(WebCore::Style::TreeResolver::makeResolutionContextForInheritedFirstLine):
* style/StyleTreeResolver.h:

LayoutTests:

* fast/css-generated-content/first-letter-in-nested-before-expected.html: Added.
* fast/css-generated-content/first-letter-in-nested-before-expected.png: Removed.
* fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.html: Copied from LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Removed.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* fast/css-generated-content/first-letter-in-nested-before-table.html:
* fast/css-generated-content/first-letter-in-nested-before.html:

Make reftest and update the behavior. ::first-letter won't affect ::before/after with display:table,
matching Firefox behavior (and spec logic).

* platform/glib/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* platform/gtk/fast/css-generated-content/first-letter-in-nested-before-expected.png: Removed.
* platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Removed.
* platform/ios/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* platform/mac/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* platform/win/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* platform/wincairo/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextFragment.cpp
trunk/Source/WebCore/rendering/RenderTextFragment.h
trunk/Source/WebCore/rendering/TextAutoSizing.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp
trunk/Source/WebCore/style/StyleTreeResolver.h


Added Paths

trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-expected.html
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.html


Removed Paths

trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-expected.png
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-expected.txt
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt