[webkit-changes] [235537] trunk
Title: [235537] trunk
Revision 235537
Author za...@apple.com
Date 2018-08-30 21:27:44 -0700 (Thu, 30 Aug 2018)
Log Message
CounterMaps should hold a unique_ptr of CounterMap.
https://bugs.webkit.org/show_bug.cgi?id=189174
Reviewed by Ryosuke Niwa.
Source/WebCore:
In certain cases calls to CounterMaps might lead to unexpected deletion of the CounterMap object.
Test: fast/css/counters/crash-when-cloning-body.html
* rendering/RenderCounter.cpp:
(WebCore::makeCounterNode):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(showCounterRendererTree):
LayoutTests:
* fast/css/counters/crash-when-cloning-body-expected.txt: Added.
* fast/css/counters/crash-when-cloning-body.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderCounter.cpp
Added Paths
trunk/LayoutTests/fast/css/counters/crash-when-cloning-body-expected.txt
trunk/LayoutTests/fast/css/counters/crash-when-cloning-body.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235536 => 235537)
--- trunk/LayoutTests/ChangeLog 2018-08-31 04:17:19 UTC (rev 235536)
+++ trunk/LayoutTests/ChangeLog 2018-08-31 04:27:44 UTC (rev 235537)
@@ -1,3 +1,14 @@
+2018-08-30 Zalan Bujtas
+
+CounterMaps should hold a unique_ptr of CounterMap.
+https://bugs.webkit.org/show_bug.cgi?id=189174
+
+
+Reviewed by Ryosuke Niwa.
+
+* fast/css/counters/crash-when-cloning-body-expected.txt: Added.
+* fast/css/counters/crash-when-cloning-body.html: Added.
+
2018-08-30 Truitt Savell
Unreviewed, rolling out r235516.
Added: trunk/LayoutTests/fast/css/counters/crash-when-cloning-body-expected.txt (0 => 235537)
--- trunk/LayoutTests/fast/css/counters/crash-when-cloning-body-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/counters/crash-when-cloning-body-expected.txt 2018-08-31 04:27:44 UTC (rev 235537)
@@ -0,0 +1,2 @@
+Pass if no crash.
+Pass if no crash.
Added: trunk/LayoutTests/fast/css/counters/crash-when-cloning-body.html (0 => 235537)
--- trunk/LayoutTests/fast/css/counters/crash-when-cloning-body.html (rev 0)
+++ trunk/LayoutTests/fast/css/counters/crash-when-cloning-body.html 2018-08-31 04:27:44 UTC (rev 235537)
@@ -0,0 +1,41 @@
+
+
+
+
+*:first-child {
+ display: table;
+ counter-increment: foo2;
+}
+
+* {
+ display: inline;
+ -webkit-appearance: unset;
+ visibility: hidden;
+}
+
+:nth-last-child(1) {
+ counter-reset: foo1;
+}
+
+
+
+
+
+Pass if no crash.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.body.offsetHeight;
+
+let div = document.createElement('div');
+div.appendChild(document.body.cloneNode(true))
+
+document.styleSheets[0].addRule('#firstDiv::after','content: counter(foobar)');
+
+secondDiv.appendChild(document.createElement('input'))
+firstDiv.appendChild(div);
+
+
Modified: trunk/Source/WebCore/ChangeLog (235536 => 235537)
--- trunk/Source/WebCore/ChangeLog 2018-08-31 04:17:19 UTC (rev 235536)
+++ trunk/Source/WebCore/ChangeLog 2018-08-31 04:27:44 UTC (rev 235537)
@@ -1,3 +1,23 @@
+2018-08-30 Zalan Bujtas
+
+CounterMaps should hold a unique_ptr of CounterMap.
+https://bugs.webkit.org/show_bug.cgi?id=189174
+
+
+Reviewed by Ryosuke Niwa.
+
+In certain cases calls to CounterMaps might lead to unexpected deletion of the CounterMap object.
+
+Test: fast/css/counters/crash-when-cloning-body.html
+
+* rendering/RenderCounter.cpp:
+(WebCore::makeCounterNode):
+(WebCore::destroyCounterNodeWithoutMapRemoval):
+(WebCore::RenderCounter::destroyCounterNodes):
+(WebCore::RenderCounter::destroyCounterNode):
+(WebCore::updateCounters):
+(showCounterRendererTree):
+
2018-08-30 Ross Kirsling
Speculative build fix for WPE after r235531.
Modified: trunk/Source/WebCore/rendering/RenderCounter.cpp (235536 => 235537)
--- trunk/Source/WebCore/rendering/RenderCounter.cpp 2018-08-31 04:17:19 UTC (rev 235536)
+++ trunk/Source/WebCore/rendering/RenderCounter.cpp 2018-08-31 04:27:44 UTC (rev 235537)
@@ -47,7 +47,7 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(RenderCounter);
using CounterMap = HashMap>;
-using CounterMaps = HashMap;
+using CounterMaps = HashMap>;
static CounterNode* makeCounterNode(RenderElement&, const AtomicString& identifier, bool alwaysCreateCounter);
@@ -296,7 +296,7 @@
{
if (renderer.hasCounterNodeMap()) {
ASSERT(counterMaps().contains());
-if (auto* node = counterMaps().find()->value.get(identifier))
+if (auto* node = counterMaps().find()->value->get(identifier))
return node;
}
@@ -312,7 +312,7 @@
if (place.parent)
place.parent->insertAfter(newNode, place.previousSibling.get(), identifier);
-maps.add(, CounterMap {
[webkit-changes] [235536] trunk/Source/WebCore
Title: [235536] trunk/Source/WebCore
Revision 235536
Author ross.kirsl...@sony.com
Date 2018-08-30 21:17:19 -0700 (Thu, 30 Aug 2018)
Log Message
Speculative build fix for WPE after r235531.
* platform/graphics/filters/PointLightSource.cpp:
Add missing include.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/PointLightSource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235535 => 235536)
--- trunk/Source/WebCore/ChangeLog 2018-08-31 02:26:26 UTC (rev 235535)
+++ trunk/Source/WebCore/ChangeLog 2018-08-31 04:17:19 UTC (rev 235536)
@@ -1,3 +1,10 @@
+2018-08-30 Ross Kirsling
+
+Speculative build fix for WPE after r235531.
+
+* platform/graphics/filters/PointLightSource.cpp:
+Add missing include.
+
2018-08-30 Ryosuke Niwa
Add assignedElements to HTMLSlotElement
Modified: trunk/Source/WebCore/platform/graphics/filters/PointLightSource.cpp (235535 => 235536)
--- trunk/Source/WebCore/platform/graphics/filters/PointLightSource.cpp 2018-08-31 02:26:26 UTC (rev 235535)
+++ trunk/Source/WebCore/platform/graphics/filters/PointLightSource.cpp 2018-08-31 04:17:19 UTC (rev 235536)
@@ -31,6 +31,7 @@
#include "config.h"
#include "PointLightSource.h"
+#include "FilterEffect.h"
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235535] trunk
Title: [235535] trunk Revision 235535 Author rn...@webkit.org Date 2018-08-30 19:26:26 -0700 (Thu, 30 Aug 2018) Log Message Add assignedElements to HTMLSlotElement https://bugs.webkit.org/show_bug.cgi?id=189146 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaselined the tests now that we're passing all test cases. * web-platform-tests/shadow-dom/slots-expected.txt: * web-platform-tests/shadow-dom/slots-fallback-expected.txt: Source/WebCore: Added assignedElements to HTMLSlotElement. For now, we simply filter the results returned by assignedNodes. Also fixed a bug that assignedNodes was returning the fallback content when the slot is not in a shadow tree, which is specified in step 2 of the concept to find flattened slotables for a slot. Spec: https://html.spec.whatwg.org/multipage/scripting.html#dom-slot-assignedelements https://dom.spec.whatwg.org/#find-flattened-slotables Tests: imported/w3c/web-platform-tests/shadow-dom/slots.html imported/w3c/web-platform-tests/shadow-dom/slots-fallback.html * html/HTMLSlotElement.cpp: (WebCore::flattenAssignedNodes): Updated to take Vector> for consistency. (WebCore::HTMLSlotElement::assignedNodes const): Ditto. (WebCore::HTMLSlotElement::assignedElements const): * html/HTMLSlotElement.h: * html/HTMLSlotElement.idl: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-fallback-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLSlotElement.cpp trunk/Source/WebCore/html/HTMLSlotElement.h trunk/Source/WebCore/html/HTMLSlotElement.idl Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (235534 => 235535) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-31 01:03:35 UTC (rev 235534) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-31 02:26:26 UTC (rev 235535) @@ -1,3 +1,15 @@ +2018-08-30 Ryosuke Niwa + +Add assignedElements to HTMLSlotElement +https://bugs.webkit.org/show_bug.cgi?id=189146 + +Reviewed by Darin Adler. + +Rebaselined the tests now that we're passing all test cases. + +* web-platform-tests/shadow-dom/slots-expected.txt: +* web-platform-tests/shadow-dom/slots-fallback-expected.txt: + 2018-08-30 Andy Estes [Payment Request] Implement the PaymentMethodChangeEvent and PaymentMethodChangeEventInit interfaces Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-expected.txt (235534 => 235535) --- trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-expected.txt 2018-08-31 01:03:35 UTC (rev 235534) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-expected.txt 2018-08-31 02:26:26 UTC (rev 235535) @@ -1,11 +1,11 @@ PASS Slots: Basic. -FAIL Slots: Basic, elements only. n.s1.assignedElements is not a function. (In 'n.s1.assignedElements()', 'n.s1.assignedElements' is undefined) +PASS Slots: Basic, elements only. PASS Slots: Slots in closed. -FAIL Slots: Slots in closed, elements only. n.s1.assignedElements is not a function. (In 'n.s1.assignedElements()', 'n.s1.assignedElements' is undefined) +PASS Slots: Slots in closed, elements only. PASS Slots: Slots not in a shadow tree. -FAIL Slots: Slots not in a shadow tree, elements only. n.s1.assignedElements is not a function. (In 'n.s1.assignedElements()', 'n.s1.assignedElements' is undefined) -FAIL Slots: Distributed nodes for Slots not in a shadow tree. assert_array_equals: lengths differ, expected 0 got 1 +PASS Slots: Slots not in a shadow tree, elements only. +PASS Slots: Distributed nodes for Slots not in a shadow tree. PASS Slots: Name matching PASS Slots: No direct host child. PASS Slots: Default Slot. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-fallback-expected.txt (235534 => 235535) --- trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-fallback-expected.txt 2018-08-31 01:03:35 UTC (rev 235534) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slots-fallback-expected.txt 2018-08-31 02:26:26 UTC (rev 235535) @@ -1,15 +1,15 @@ PASS Slots fallback: Basic. -FAIL Slots fallback: Basic, elements only. n.s1.assignedElements is not a function. (In 'n.s1.assignedElements()', 'n.s1.assignedElements' is undefined) +PASS Slots fallback: Basic, elements only. PASS Slots fallback: Slots in Slots. -FAIL Slots fallback: Slots in Slots, elements only. n.s1.assignedElements is not a function. (In 'n.s1.assignedElements()', 'n.s1.assignedElements' is undefined) +PASS Slots fallback: Slots in Slots, elements only. PASS Slots fallback: Fallback contents should not be used if a node is assigned. PASS Slots fallback: Slots in Slots: Assigned nodes should be used as fallback contents of another slot PASS Slots fallback: Complex case. -FAIL Slots fallback: Complex case, elements only.
[webkit-changes] [235534] trunk/Source/WebKit
Title: [235534] trunk/Source/WebKit
Revision 235534
Author timothy_hor...@apple.com
Date 2018-08-30 18:03:35 -0700 (Thu, 30 Aug 2018)
Log Message
One more build fix
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView shareSheetDidDismiss:]):
Actually tested this time.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235533 => 235534)
--- trunk/Source/WebKit/ChangeLog 2018-08-31 00:39:09 UTC (rev 235533)
+++ trunk/Source/WebKit/ChangeLog 2018-08-31 01:03:35 UTC (rev 235534)
@@ -1,3 +1,11 @@
+2018-08-30 Tim Horton
+
+One more build fix
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView shareSheetDidDismiss:]):
+Actually tested this time.
+
2018-08-30 Chris Dumez
Add WKPageLoadFile SPI variant which returns a navigation object
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (235533 => 235534)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-31 00:39:09 UTC (rev 235533)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-31 01:03:35 UTC (rev 235534)
@@ -4724,15 +4724,15 @@
#endif
}
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
- (void)shareSheetDidDismiss:(WKShareSheet *)shareSheet
{
-#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
ASSERT(_shareSheet == shareSheet);
[_shareSheet setDelegate:nil];
_shareSheet = nil;
+}
#endif
-}
#pragma mark - UITextInputMultiDocument
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235533] trunk/Tools
Title: [235533] trunk/Tools
Revision 235533
Author commit-qu...@webkit.org
Date 2018-08-30 17:39:09 -0700 (Thu, 30 Aug 2018)
Log Message
[WHLSL] Fix array indexing behavior
https://bugs.webkit.org/show_bug.cgi?id=189175
Array, pointer, and array ref types are now parsed and then constructed
in reverse so that the declaration order matches the indexing order, as
in C/C++.
Patch by Thomas Denney on 2018-08-30
Reviewed by Myles C. Maxfield.
* WebGPUShadingLanguageRI/Parse.js:
(parseType):
* WebGPUShadingLanguageRI/Test.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/Parse.js
trunk/Tools/WebGPUShadingLanguageRI/Test.js
Diff
Modified: trunk/Tools/ChangeLog (235532 => 235533)
--- trunk/Tools/ChangeLog 2018-08-30 23:32:14 UTC (rev 235532)
+++ trunk/Tools/ChangeLog 2018-08-31 00:39:09 UTC (rev 235533)
@@ -1,3 +1,18 @@
+2018-08-30 Thomas Denney
+
+[WHLSL] Fix array indexing behavior
+https://bugs.webkit.org/show_bug.cgi?id=189175
+
+Array, pointer, and array ref types are now parsed and then constructed
+in reverse so that the declaration order matches the indexing order, as
+in C/C++.
+
+Reviewed by Myles C. Maxfield.
+
+* WebGPUShadingLanguageRI/Parse.js:
+(parseType):
+* WebGPUShadingLanguageRI/Test.js:
+
2018-08-30 Wenson Hsieh
Followup to [iOS] TestWebKitAPI.PasteImage tests are flaky failures
Modified: trunk/Tools/WebGPUShadingLanguageRI/Parse.js (235532 => 235533)
--- trunk/Tools/WebGPUShadingLanguageRI/Parse.js 2018-08-30 23:32:14 UTC (rev 235532)
+++ trunk/Tools/WebGPUShadingLanguageRI/Parse.js 2018-08-31 00:39:09 UTC (rev 235533)
@@ -259,24 +259,33 @@
return consume(...addressSpaces).text;
}
-while (token = tryConsume("*", "[")) {
+const typeConstructorStack = [ ];
+
+for (let token; token = tryConsume("*", "[");) {
if (token.text == "*") {
-type = new PtrType(token, getAddressSpace(), type);
+// Likewise, the address space must be parsed before parsing continues.
+const addressSpace = getAddressSpace();
+typeConstructorStack.unshift(type => new PtrType(token, addressSpace, type));
continue;
}
-
+
if (tryConsume("]")) {
-type = new ArrayRefType(token, getAddressSpace(), type);
+const addressSpace = getAddressSpace();
+typeConstructorStack.unshift(type => new ArrayRefType(token, addressSpace, type));
continue;
}
-
-type = new ArrayType(token, type, parseConstexpr());
+
+const lengthExpr = parseConstexpr();
+typeConstructorStack.unshift(type => new ArrayType(token, type, lengthExpr));
consume("]");
}
-
+
+for (let constructor of typeConstructorStack)
+type = constructor(type);
+
if (addressSpace && !addressSpaceConsumed)
lexer.fail("Address space specified for type that does not need address space");
-
+
return type;
}
Modified: trunk/Tools/WebGPUShadingLanguageRI/Test.js (235532 => 235533)
--- trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-08-30 23:32:14 UTC (rev 235532)
+++ trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-08-31 00:39:09 UTC (rev 235533)
@@ -5551,7 +5551,7 @@
checkFloat(program, callFunction(program, "foo13", []), 29 * 7 + 43 * 11 + 61 * 13);
}
-tests.DISABLED_arrayIndex = function() {
+tests.arrayIndex = function() {
let program = doPrep(`
uint innerArrayLength() {
int[2][3] array;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235532] trunk/Source/WebKit
Title: [235532] trunk/Source/WebKit
Revision 235532
Author cdu...@apple.com
Date 2018-08-30 16:32:14 -0700 (Thu, 30 Aug 2018)
Log Message
Add WKPageLoadFile SPI variant which returns a navigation object
https://bugs.webkit.org/show_bug.cgi?id=189168
Reviewed by Alex Christensen.
Add WKPageLoadFile SPI variant which returns a navigation object, similarly to WKPageLoadURLRequestReturningNavigation().
This is needed in order to implement .
* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm:
(WKPageLoadFileReturningNavigation):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.h
trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235531 => 235532)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 23:28:10 UTC (rev 235531)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 23:32:14 UTC (rev 235532)
@@ -1,3 +1,18 @@
+2018-08-30 Chris Dumez
+
+Add WKPageLoadFile SPI variant which returns a navigation object
+https://bugs.webkit.org/show_bug.cgi?id=189168
+
+
+Reviewed by Alex Christensen.
+
+Add WKPageLoadFile SPI variant which returns a navigation object, similarly to WKPageLoadURLRequestReturningNavigation().
+This is needed in order to implement .
+
+* UIProcess/API/C/mac/WKPagePrivateMac.h:
+* UIProcess/API/C/mac/WKPagePrivateMac.mm:
+(WKPageLoadFileReturningNavigation):
+
2018-08-30 Tim Horton
Try to fix the watchOS and tvOS build
Modified: trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.h (235531 => 235532)
--- trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.h 2018-08-30 23:28:10 UTC (rev 235531)
+++ trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.h 2018-08-30 23:32:14 UTC (rev 235532)
@@ -62,6 +62,7 @@
#if !TARGET_OS_IPHONE && (defined(__clang__) && defined(__APPLE__) && !defined(__i386__))
@class WKNavigation;
WK_EXPORT WKNavigation *WKPageLoadURLRequestReturningNavigation(WKPageRef page, WKURLRequestRef request);
+WK_EXPORT WKNavigation *WKPageLoadFileReturningNavigation(WKPageRef page, WKURLRef fileURL, WKURLRef resourceDirectoryURL);
#endif
#endif // __OBJC__
Modified: trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm (235531 => 235532)
--- trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm 2018-08-30 23:28:10 UTC (rev 235531)
+++ trunk/Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm 2018-08-30 23:32:14 UTC (rev 235532)
@@ -145,6 +145,11 @@
auto resourceRequest = toImpl(urlRequestRef)->resourceRequest();
return wrapper(toImpl(pageRef)->loadRequest(WTFMove(resourceRequest)));
}
+
+WKNavigation *WKPageLoadFileReturningNavigation(WKPageRef pageRef, WKURLRef fileURL, WKURLRef resourceDirectoryURL)
+{
+return wrapper(toImpl(pageRef)->loadFile(toWTFString(fileURL), toWTFString(resourceDirectoryURL)));
+}
#endif
#if PLATFORM(MAC)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235530] trunk/Source/WebKit
Title: [235530] trunk/Source/WebKit
Revision 235530
Author timothy_hor...@apple.com
Date 2018-08-30 16:10:51 -0700 (Thu, 30 Aug 2018)
Log Message
Try to fix the watchOS and tvOS build
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showShareSheet:completionHandler:]):
(-[WKContentView shareSheetDidDismiss:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235529 => 235530)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 22:55:27 UTC (rev 235529)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 23:10:51 UTC (rev 235530)
@@ -1,3 +1,11 @@
+2018-08-30 Tim Horton
+
+Try to fix the watchOS and tvOS build
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _showShareSheet:completionHandler:]):
+(-[WKContentView shareSheetDidDismiss:]):
+
2018-08-30 Justin Michaud
[GTK] Touchscreen pinch to zoom should scale the page like other platforms
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (235529 => 235530)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 22:55:27 UTC (rev 235529)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 23:10:51 UTC (rev 235530)
@@ -4710,9 +4710,9 @@
_fileUploadPanel = nil;
}
-#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
- (void)_showShareSheet:(const ShareDataWithParsedURL&)data completionHandler:(CompletionHandler&&)completionHandler
{
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
ASSERT(!_shareSheet);
if (_shareSheet)
return;
@@ -4721,16 +4721,18 @@
[_shareSheet setDelegate:self];
[_shareSheet presentWithParameters:data completionHandler:WTFMove(completionHandler)];
+#endif
}
- (void)shareSheetDidDismiss:(WKShareSheet *)shareSheet
{
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
ASSERT(_shareSheet == shareSheet);
[_shareSheet setDelegate:nil];
_shareSheet = nil;
+#endif
}
-#endif
#pragma mark - UITextInputMultiDocument
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235529] trunk/Source/WebKit
Title: [235529] trunk/Source/WebKit
Revision 235529
Author commit-qu...@webkit.org
Date 2018-08-30 15:55:27 -0700 (Thu, 30 Aug 2018)
Log Message
[GTK] Touchscreen pinch to zoom should scale the page like other platforms
https://bugs.webkit.org/show_bug.cgi?id=188746
Changes the pinch-to-zoom gesture to magnify/scale the page, rather than zooming in. Also resets this magnification when the zoom level is changed.
Patch by Justin Michaud on 2018-08-30
Reviewed by Michael Catanzaro.
* UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_set_zoom_level):
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::zoom): Deleted.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
* UIProcess/gtk/GestureController.cpp:
(WebKit::GestureController::ZoomGesture::handleZoom):
(WebKit::GestureController::ZoomGesture::scaleChanged):
* UIProcess/gtk/GestureController.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit/UIProcess/gtk/GestureController.cpp
trunk/Source/WebKit/UIProcess/gtk/GestureController.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (235528 => 235529)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 22:50:33 UTC (rev 235528)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 22:55:27 UTC (rev 235529)
@@ -1,3 +1,23 @@
+2018-08-30 Justin Michaud
+
+[GTK] Touchscreen pinch to zoom should scale the page like other platforms
+https://bugs.webkit.org/show_bug.cgi?id=188746
+
+Changes the pinch-to-zoom gesture to magnify/scale the page, rather than zooming in. Also resets this magnification when the zoom level is changed.
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/API/glib/WebKitWebView.cpp:
+(webkit_web_view_set_zoom_level):
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::zoom): Deleted.
+* UIProcess/API/gtk/PageClientImpl.h:
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+* UIProcess/gtk/GestureController.cpp:
+(WebKit::GestureController::ZoomGesture::handleZoom):
+(WebKit::GestureController::ZoomGesture::scaleChanged):
+* UIProcess/gtk/GestureController.h:
+
2018-08-30 Tim Horton
Bundle unified sources more tightly in projects with deep directory structures
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp (235528 => 235529)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp 2018-08-30 22:50:33 UTC (rev 235528)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp 2018-08-30 22:55:27 UTC (rev 235529)
@@ -3118,6 +3118,7 @@
return;
auto& page = getPage(webView);
+page.scalePage(1.0, IntPoint()); // Reset page scale when zoom level is changed
if (webkit_settings_get_zoom_text_only(webView->priv->settings.get()))
page.setTextZoomFactor(zoomLevel);
else
Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (235528 => 235529)
--- trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp 2018-08-30 22:50:33 UTC (rev 235528)
+++ trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp 2018-08-30 22:55:27 UTC (rev 235529)
@@ -473,14 +473,4 @@
}
#endif
-void PageClientImpl::zoom(double zoomLevel)
-{
-if (WEBKIT_IS_WEB_VIEW(m_viewWidget)) {
-webkit_web_view_set_zoom_level(WEBKIT_WEB_VIEW(m_viewWidget), zoomLevel);
-return;
-}
-
-webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_viewWidget))->setPageZoomFactor(zoomLevel);
-}
-
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h (235528 => 235529)
--- trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h 2018-08-30 22:50:33 UTC (rev 235528)
+++ trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h 2018-08-30 22:55:27 UTC (rev 235529)
@@ -53,8 +53,6 @@
GtkWidget* viewWidget() { return m_viewWidget; }
-void zoom(double);
-
private:
// PageClient
std::unique_ptr createDrawingAreaProxy() override;
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (235528 => 235529)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2018-08-30 22:50:33 UTC (rev 235528)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2018-08-30 22:55:27 UTC (rev 235529)
@@ -1116,15 +1116,18 @@
void startZoom(const IntPoint& center, double& initialScale, IntPoint& initialPoint) final
{
-auto* page = webkitWebViewBaseGetPage(m_webView);
+auto* page = m_webView->priv->pageProxy.get();
ASSERT(page);
-initialScale = page->pageZoomFactor();
+initialScale = page->pageScaleFactor();
page->getCenterForZoomGesture(center, initialPoint);
}
-void zoom(double scale) final
+
[webkit-changes] [235528] trunk/Tools
Title: [235528] trunk/Tools
Revision 235528
Author wenson_hs...@apple.com
Date 2018-08-30 15:50:33 -0700 (Thu, 30 Aug 2018)
Log Message
Followup to [iOS] TestWebKitAPI.PasteImage tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=185965
Reviewed by Andy Estes.
The first attempt to fix these flaky tests on iOS caused timeouts on macOS while waiting for a "loaded" message
from the page. To (hopefully) fix this across both platforms, make sure that we first register our script
message handlers in the UI process *before* evaluating script that could propagate the script message.
* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
(-[TestWKWebView waitForMessage:afterEvaluatingScript:]):
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
Diff
Modified: trunk/Tools/ChangeLog (235527 => 235528)
--- trunk/Tools/ChangeLog 2018-08-30 22:37:34 UTC (rev 235527)
+++ trunk/Tools/ChangeLog 2018-08-30 22:50:33 UTC (rev 235528)
@@ -1,3 +1,18 @@
+2018-08-30 Wenson Hsieh
+
+Followup to [iOS] TestWebKitAPI.PasteImage tests are flaky failures
+https://bugs.webkit.org/show_bug.cgi?id=185965
+
+Reviewed by Andy Estes.
+
+The first attempt to fix these flaky tests on iOS caused timeouts on macOS while waiting for a "loaded" message
+from the page. To (hopefully) fix this across both platforms, make sure that we first register our script
+message handlers in the UI process *before* evaluating script that could propagate the script message.
+
+* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+(-[TestWKWebView waitForMessage:afterEvaluatingScript:]):
+(TEST):
+
2018-08-30 Thomas Denney
[WHLSL] Implement tests to verify array indexing order matches our desires
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm (235527 => 235528)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm 2018-08-30 22:37:34 UTC (rev 235527)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm 2018-08-30 22:50:33 UTC (rev 235528)
@@ -49,6 +49,28 @@
}
#endif
+@interface TestWKWebView (PasteImage)
+- (void)waitForMessage:(NSString *)message afterEvaluatingScript:(NSString *)script;
+@end
+
+@implementation TestWKWebView (PasteImage)
+
+- (void)waitForMessage:(NSString *)message afterEvaluatingScript:(NSString *)script
+{
+__block bool evaluatedScript = false;
+__block bool receivedMessage = false;
+[self performAfterReceivingMessage:message action:^{
+receivedMessage = true;
+}];
+[self evaluateJavaScript:script completionHandler:^(id, NSError *) {
+evaluatedScript = true;
+}];
+TestWebKitAPI::Util::run();
+TestWebKitAPI::Util::run();
+}
+
+@end
+
TEST(PasteImage, PasteGIFImage)
{
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400)]);
@@ -66,8 +88,7 @@
EXPECT_WK_STREQ("image.gif", [webView stringByEvaluatingJavaScript:@"gifItem.file.name"]);
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(gifItem.file).toString()"]);
-[webView stringByEvaluatingJavaScript:@"insertFileAsImage(gifItem.file)"];
-[webView waitForMessage:@"loaded"];
+[webView waitForMessage:@"loaded" afterEvaluatingScript:@"insertFileAsImage(gifItem.file)"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("400", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
@@ -89,8 +110,7 @@
EXPECT_WK_STREQ("image.jpeg", [webView stringByEvaluatingJavaScript:@"jpegItem.file.name"]);
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(jpegItem.file).toString()"]);
-[webView stringByEvaluatingJavaScript:@"insertFileAsImage(jpegItem.file)"];
-[webView waitForMessage:@"loaded"];
+[webView waitForMessage:@"loaded" afterEvaluatingScript:@"insertFileAsImage(jpegItem.file)"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("600", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
@@ -112,8 +132,7 @@
EXPECT_WK_STREQ("image.png", [webView stringByEvaluatingJavaScript:@"pngItem.file.name"]);
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(pngItem.file).toString()"]);
-[webView stringByEvaluatingJavaScript:@"insertFileAsImage(pngItem.file)"];
-[webView waitForMessage:@"loaded"];
+[webView waitForMessage:@"loaded" afterEvaluatingScript:@"insertFileAsImage(pngItem.file)"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("200", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
[webkit-changes] [235526] tags/Safari-607.1.4/Source/WebKit
Title: [235526] tags/Safari-607.1.4/Source/WebKit Revision 235526 Author bshaf...@apple.com Date 2018-08-30 15:36:05 -0700 (Thu, 30 Aug 2018) Log Message Cherry-pick r235511. rdar://problem/43906230 Unreviewed, rolling out r235413 and r235444. https://bugs.webkit.org/show_bug.cgi?id=189163 Causes crashes when running layout tests under GuardMalloc (Requested by ryanhaddad on #webkit). Reverted changesets: "NetworkLoad::didReceiveResponse should pass its completion handler to its client" https://bugs.webkit.org/show_bug.cgi?id=188701 https://trac.webkit.org/changeset/235413 "Remove assertion introduced in r235413" https://bugs.webkit.org/show_bug.cgi?id=188701 https://trac.webkit.org/changeset/235444 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235511 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths tags/Safari-607.1.4/Source/WebKit/ChangeLog tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkDataTask.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkDataTask.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkLoad.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkLoad.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkLoadClient.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/NetworkResourceLoader.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/PingLoad.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/PingLoad.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/PreconnectTask.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/PreconnectTask.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp tags/Safari-607.1.4/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h tags/Safari-607.1.4/Source/WebKit/NetworkProcess/capture/NetworkDataTaskReplay.cpp Diff Modified: tags/Safari-607.1.4/Source/WebKit/ChangeLog (235525 => 235526) --- tags/Safari-607.1.4/Source/WebKit/ChangeLog 2018-08-30 21:53:43 UTC (rev 235525) +++ tags/Safari-607.1.4/Source/WebKit/ChangeLog 2018-08-30 22:36:05 UTC (rev 235526) @@ -1,3 +1,45 @@ +2018-08-30 Babak Shafiei + +Cherry-pick r235511. rdar://problem/43906230 + +Unreviewed, rolling out r235413 and r235444. +https://bugs.webkit.org/show_bug.cgi?id=189163 + +Causes crashes when running layout tests under GuardMalloc +(Requested by ryanhaddad on #webkit). + +Reverted changesets: + +"NetworkLoad::didReceiveResponse should pass its completion +handler to its client" +https://bugs.webkit.org/show_bug.cgi?id=188701 +https://trac.webkit.org/changeset/235413 + +"Remove assertion introduced in r235413" +https://bugs.webkit.org/show_bug.cgi?id=188701 +https://trac.webkit.org/changeset/235444 + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235511 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2018-08-30 Commit Queue + +Unreviewed, rolling out r235413 and r235444. +https://bugs.webkit.org/show_bug.cgi?id=189163 + +Causes crashes when running layout tests under GuardMalloc +(Requested by ryanhaddad on #webkit). + +Reverted changesets: + +"NetworkLoad::didReceiveResponse should pass its completion +handler to its client" +https://bugs.webkit.org/show_bug.cgi?id=188701 +https://trac.webkit.org/changeset/235413 + +"Remove assertion introduced in r235413" +https://bugs.webkit.org/show_bug.cgi?id=188701 +https://trac.webkit.org/changeset/235444 + 2018-08-29 Babak Shafiei Cherry-pick r235492. rdar://problem/43860224 Modified: tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp (235525 => 235526) --- tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp 2018-08-30 21:53:43 UTC (rev 235525) +++ tags/Safari-607.1.4/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp 2018-08-30 22:36:05 UTC (rev 235526) @@ -85,10 +85,10 @@ ASSERT_UNUSED(addResult, addResult.isNewEntry); } -void DownloadManager::convertNetworkLoadToDownload(DownloadID downloadID, std::unique_ptr&& networkLoad, ResponseCompletionHandler&& completionHandler, Vector>&& blobFileReferences, const ResourceRequest& request, const ResourceResponse& response) +void
[webkit-changes] [235527] trunk/Source/JavaScriptCore
Title: [235527] trunk/Source/_javascript_Core
Revision 235527
Author sbar...@apple.com
Date 2018-08-30 15:37:34 -0700 (Thu, 30 Aug 2018)
Log Message
Switch int8_t to GPRReg in StructureStubInfo because sizeof(GPRReg) == sizeof(int8_t)
https://bugs.webkit.org/show_bug.cgi?id=189166
Reviewed by Mark Lam.
* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
* bytecode/GetterSetterAccessCase.cpp:
(JSC::GetterSetterAccessCase::emitDOMJITGetter):
* bytecode/InlineAccess.cpp:
(JSC::getScratchRegister):
* bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::valueRegs const):
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITInstanceOfGenerator::JITInstanceOfGenerator):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/AccessCase.cpp
trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp
trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp
trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/jit/JITInlineCacheGenerator.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (235526 => 235527)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-30 22:36:05 UTC (rev 235526)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-30 22:37:34 UTC (rev 235527)
@@ -1,5 +1,27 @@
2018-08-30 Saam barati
+Switch int8_t to GPRReg in StructureStubInfo because sizeof(GPRReg) == sizeof(int8_t)
+https://bugs.webkit.org/show_bug.cgi?id=189166
+
+Reviewed by Mark Lam.
+
+* bytecode/AccessCase.cpp:
+(JSC::AccessCase::generateImpl):
+* bytecode/GetterSetterAccessCase.cpp:
+(JSC::GetterSetterAccessCase::emitDOMJITGetter):
+* bytecode/InlineAccess.cpp:
+(JSC::getScratchRegister):
+* bytecode/PolymorphicAccess.cpp:
+(JSC::PolymorphicAccess::regenerate):
+* bytecode/StructureStubInfo.h:
+(JSC::StructureStubInfo::valueRegs const):
+* jit/JITInlineCacheGenerator.cpp:
+(JSC::JITByIdGenerator::JITByIdGenerator):
+(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
+(JSC::JITInstanceOfGenerator::JITInstanceOfGenerator):
+
+2018-08-30 Saam barati
+
InlineAccess should do StringLength
https://bugs.webkit.org/show_bug.cgi?id=158911
Modified: trunk/Source/_javascript_Core/bytecode/AccessCase.cpp (235526 => 235527)
--- trunk/Source/_javascript_Core/bytecode/AccessCase.cpp 2018-08-30 22:36:05 UTC (rev 235526)
+++ trunk/Source/_javascript_Core/bytecode/AccessCase.cpp 2018-08-30 22:37:34 UTC (rev 235527)
@@ -1066,7 +1066,7 @@
ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);
allocator.lock(baseGPR);
#if USE(JSVALUE32_64)
-allocator.lock(static_cast(stubInfo.patch.baseTagGPR));
+allocator.lock(stubInfo.patch.baseTagGPR);
#endif
allocator.lock(valueRegs);
allocator.lock(scratchGPR);
Modified: trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp (235526 => 235527)
--- trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2018-08-30 22:36:05 UTC (rev 235526)
+++ trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2018-08-30 22:37:34 UTC (rev 235527)
@@ -141,7 +141,7 @@
ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);
allocator.lock(baseGPR);
#if USE(JSVALUE32_64)
-allocator.lock(static_cast(stubInfo.patch.baseTagGPR));
+allocator.lock(stubInfo.patch.baseTagGPR);
#endif
allocator.lock(valueRegs);
allocator.lock(scratchGPR);
Modified: trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp (235526 => 235527)
--- trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp 2018-08-30 22:36:05 UTC (rev 235526)
+++ trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp 2018-08-30 22:37:34 UTC (rev 235527)
@@ -198,10 +198,10 @@
{
ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);
allocator.lock(stubInfo.baseGPR());
-allocator.lock(static_cast(stubInfo.patch.valueGPR));
+allocator.lock(stubInfo.patch.valueGPR);
#if USE(JSVALUE32_64)
-allocator.lock(static_cast(stubInfo.patch.baseTagGPR));
-allocator.lock(static_cast(stubInfo.patch.valueTagGPR));
+allocator.lock(stubInfo.patch.baseTagGPR);
+allocator.lock(stubInfo.patch.valueTagGPR);
#endif
GPRReg scratch = allocator.allocateScratchGPR();
if (allocator.didReuseRegisters())
Modified: trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp (235526 => 235527)
--- trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp 2018-08-30 22:36:05 UTC (rev 235526)
+++ trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp 2018-08-30 22:37:34 UTC (rev 235527)
@@
[webkit-changes] [235525] trunk/Tools
Title: [235525] trunk/Tools
Revision 235525
Author commit-qu...@webkit.org
Date 2018-08-30 14:53:43 -0700 (Thu, 30 Aug 2018)
Log Message
[WHLSL] Implement tests to verify array indexing order matches our desires
https://bugs.webkit.org/show_bug.cgi?id=189099
Patch by Thomas Denney on 2018-08-30
Reviewed by Myles C. Maxfield.
* WebGPUShadingLanguageRI/Test.js: Add new test for array indexing order
and the option to explicitly disable tests (this test is disabled by
default).
* WebGPUShadingLanguageRI/TypeRef.js:
(TypeRef.wrap): Fixes typo.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/Test.js
trunk/Tools/WebGPUShadingLanguageRI/TypeRef.js
Diff
Modified: trunk/Tools/ChangeLog (235524 => 235525)
--- trunk/Tools/ChangeLog 2018-08-30 21:33:38 UTC (rev 235524)
+++ trunk/Tools/ChangeLog 2018-08-30 21:53:43 UTC (rev 235525)
@@ -1,3 +1,16 @@
+2018-08-30 Thomas Denney
+
+[WHLSL] Implement tests to verify array indexing order matches our desires
+https://bugs.webkit.org/show_bug.cgi?id=189099
+
+Reviewed by Myles C. Maxfield.
+
+* WebGPUShadingLanguageRI/Test.js: Add new test for array indexing order
+and the option to explicitly disable tests (this test is disabled by
+default).
+* WebGPUShadingLanguageRI/TypeRef.js:
+(TypeRef.wrap): Fixes typo.
+
2018-08-30 Sihui Liu
WKNavigation.ProcessCrashDuringCallback is failing on iOS
Modified: trunk/Tools/WebGPUShadingLanguageRI/Test.js (235524 => 235525)
--- trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-08-30 21:33:38 UTC (rev 235524)
+++ trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-08-30 21:53:43 UTC (rev 235525)
@@ -5551,9 +5551,44 @@
checkFloat(program, callFunction(program, "foo13", []), 29 * 7 + 43 * 11 + 61 * 13);
}
+tests.DISABLED_arrayIndex = function() {
+let program = doPrep(`
+uint innerArrayLength() {
+int[2][3] array;
+return array[0].length;
+}
+
+uint outerArrayLength() {
+int[2][3] array;
+return array.length;
+}
+
+int arrayIndexing(uint i, uint j) {
+int[2][3] array;
+array[0][0] = 1;
+array[0][1] = 2;
+array[0][2] = 3;
+array[1][0] = 4;
+array[1][1] = 5;
+array[1][2] = 6;
+return array[i][j];
+}
+`);
+
+checkUint(program, callFunction(program, "innerArrayLength", []), 3);
+checkUint(program, callFunction(program, "outerArrayLength", []), 2);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 0), makeUint(program, 0) ]), 1);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 0), makeUint(program, 1) ]), 2);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 0), makeUint(program, 2) ]), 3);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 1), makeUint(program, 0) ]), 4);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 1), makeUint(program, 1) ]), 5);
+checkInt(program, callFunction(program, "arrayIndexing", [ makeUint(program, 1), makeUint(program, 2) ]), 6);
+}
+
okToTest = true;
let testFilter = /.*/; // run everything by default
+let testExclusionFilter = /^DISABLED_/;
if (this["arguments"]) {
for (let i = 0; i < arguments.length; i++) {
switch (arguments[0]) {
@@ -5583,12 +5618,16 @@
names.sort();
for (let s of names) {
if (s.match(testFilter)) {
-print("TEST: " + s + "...");
-yield;
-const testBefore = preciseTime();
-tests[s]();
-const testAfter = preciseTime();
-print(`OK, took ${Math.round((testAfter - testBefore) * 1000)} ms`);
+if (s.match(testExclusionFilter)) {
+print(`Skipping ${s} because it is disabled.`);
+} else {
+print("TEST: " + s + "...");
+yield;
+const testBefore = preciseTime();
+tests[s]();
+const testAfter = preciseTime();
+print(`OK, took ${Math.round((testAfter - testBefore) * 1000)} ms`);
+}
}
}
Modified: trunk/Tools/WebGPUShadingLanguageRI/TypeRef.js (235524 => 235525)
--- trunk/Tools/WebGPUShadingLanguageRI/TypeRef.js 2018-08-30 21:33:38 UTC (rev 235524)
+++ trunk/Tools/WebGPUShadingLanguageRI/TypeRef.js 2018-08-30 21:53:43 UTC (rev 235525)
@@ -42,7 +42,7 @@
if (type instanceof NativeType)
result = new TypeRef(type.origin, type.name, type.typeArguments);
else
-result = new TypeRef(type.orgin, type.name);
+result = new TypeRef(type.origin, type.name);
result.type = type;
return result;
}
[webkit-changes] [235524] trunk/Source/WebCore
Title: [235524] trunk/Source/WebCore
Revision 235524
Author commit-qu...@webkit.org
Date 2018-08-30 14:33:38 -0700 (Thu, 30 Aug 2018)
Log Message
REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
https://bugs.webkit.org/show_bug.cgi?id=189170
Patch by Olivia Barnett on 2018-08-30
Reviewed by Tim Horton.
No new tests; fixing a failing existing test.
* page/Navigator.cpp:
(WebCore::Navigator::share):
Added null check for frame.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Navigator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235523 => 235524)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 20:54:35 UTC (rev 235523)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 21:33:38 UTC (rev 235524)
@@ -1,3 +1,16 @@
+2018-08-30 Olivia Barnett
+
+REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
+https://bugs.webkit.org/show_bug.cgi?id=189170
+
+Reviewed by Tim Horton.
+
+No new tests; fixing a failing existing test.
+
+* page/Navigator.cpp:
+(WebCore::Navigator::share):
+Added null check for frame.
+
2018-08-30 Truitt Savell
Unreviewed, rolling out r235516.
Modified: trunk/Source/WebCore/page/Navigator.cpp (235523 => 235524)
--- trunk/Source/WebCore/page/Navigator.cpp 2018-08-30 20:54:35 UTC (rev 235523)
+++ trunk/Source/WebCore/page/Navigator.cpp 2018-08-30 21:33:38 UTC (rev 235524)
@@ -99,7 +99,7 @@
void Navigator::share(ScriptExecutionContext& context, ShareData data, Ref&& promise)
{
-if (!m_frame->page()) {
+if (!m_frame || !m_frame->page()) {
promise->reject(TypeError);
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235523] trunk
Title: [235523] trunk
Revision 235523
Author tsav...@apple.com
Date 2018-08-30 13:54:35 -0700 (Thu, 30 Aug 2018)
Log Message
Unreviewed, rolling out r235516.
Caused 50 Crashes on Sierra
Reverted changeset:
"The width of a nullptr TextRun should be zero"
https://bugs.webkit.org/show_bug.cgi?id=189154
https://trac.webkit.org/changeset/235516
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
Removed Paths
trunk/LayoutTests/fast/text/null-string-textrun-expected.txt
trunk/LayoutTests/fast/text/null-string-textrun.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235522 => 235523)
--- trunk/LayoutTests/ChangeLog 2018-08-30 20:47:30 UTC (rev 235522)
+++ trunk/LayoutTests/ChangeLog 2018-08-30 20:54:35 UTC (rev 235523)
@@ -1,3 +1,15 @@
+2018-08-30 Truitt Savell
+
+Unreviewed, rolling out r235516.
+
+Caused 50 Crashes on Sierra
+
+Reverted changeset:
+
+"The width of a nullptr TextRun should be zero"
+https://bugs.webkit.org/show_bug.cgi?id=189154
+https://trac.webkit.org/changeset/235516
+
2018-08-30 Youenn Fablet
Remove WebRTC legacy API implementation
Deleted: trunk/LayoutTests/fast/text/null-string-textrun-expected.txt (235522 => 235523)
--- trunk/LayoutTests/fast/text/null-string-textrun-expected.txt 2018-08-30 20:47:30 UTC (rev 235522)
+++ trunk/LayoutTests/fast/text/null-string-textrun-expected.txt 2018-08-30 20:54:35 UTC (rev 235523)
@@ -1,6 +0,0 @@
-This test confirms that a null text run doesn't trigger a crash. It passes if it loads without crashing.
-
-
-
-
-
Deleted: trunk/LayoutTests/fast/text/null-string-textrun.html (235522 => 235523)
--- trunk/LayoutTests/fast/text/null-string-textrun.html 2018-08-30 20:47:30 UTC (rev 235522)
+++ trunk/LayoutTests/fast/text/null-string-textrun.html 2018-08-30 20:54:35 UTC (rev 235523)
@@ -1,19 +0,0 @@
-
-
-
-if (window.testRunner)
-testRunner.dumpAsText();
-
-
-
-This test confirms that a null text run doesn't trigger a crash. It passes if it loads without crashing.
-
-
-
-
-
-
-
-
-
-
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (235522 => 235523)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 20:47:30 UTC (rev 235522)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 20:54:35 UTC (rev 235523)
@@ -1,3 +1,15 @@
+2018-08-30 Truitt Savell
+
+Unreviewed, rolling out r235516.
+
+Caused 50 Crashes on Sierra
+
+Reverted changeset:
+
+"The width of a nullptr TextRun should be zero"
+https://bugs.webkit.org/show_bug.cgi?id=189154
+https://trac.webkit.org/changeset/235516
+
2018-08-30 Tim Horton
Bundle unified sources more tightly in projects with deep directory structures
Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (235522 => 235523)
--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2018-08-30 20:47:30 UTC (rev 235522)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2018-08-30 20:54:35 UTC (rev 235523)
@@ -341,9 +341,6 @@
ASSERT(from <= to);
ASSERT(to <= run.length());
-if (!run.length())
-return 0;
-
float offsetBeforeRange = 0;
float offsetAfterRange = 0;
float totalWidth = 0;
@@ -388,9 +385,6 @@
float FontCascade::width(const TextRun& run, HashSet* fallbackFonts, GlyphOverflow* glyphOverflow) const
{
-if (!run.length())
-return 0;
-
CodePath codePathToUse = codePath(run);
if (codePathToUse != Complex) {
// The complex path is more restrictive about returning fallback fonts than the simple path, so we need an explicit test to make their behaviors match.
@@ -610,8 +604,6 @@
if (s_codePath != Auto)
return s_codePath;
-ASSERT(run.length());
-
#if !USE(FREETYPE)
// FIXME: Use the fast code path once it handles partial runs with kerning and ligatures. See http://webkit.org/b/100050
if ((enableKerning() || requiresShaping()) && (from.value_or(0) || to.value_or(run.length()) != run.length()))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235522] tags/Safari-607.1.4/Source/WebCore
Title: [235522] tags/Safari-607.1.4/Source/WebCore Revision 235522 Author bshaf...@apple.com Date 2018-08-30 13:47:30 -0700 (Thu, 30 Aug 2018) Log Message Revert r235363. rdar://problem/43899483 Modified Paths tags/Safari-607.1.4/Source/WebCore/ChangeLog tags/Safari-607.1.4/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp Diff Modified: tags/Safari-607.1.4/Source/WebCore/ChangeLog (235521 => 235522) --- tags/Safari-607.1.4/Source/WebCore/ChangeLog 2018-08-30 20:31:32 UTC (rev 235521) +++ tags/Safari-607.1.4/Source/WebCore/ChangeLog 2018-08-30 20:47:30 UTC (rev 235522) @@ -1,3 +1,7 @@ +2018-08-30 Babak Shafiei + +Revert r235363. rdar://problem/43899483 + 2018-08-29 Ali Juma [IntersectionObserver] Implement intersection logic for the same-document implicit root case Modified: tags/Safari-607.1.4/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp (235521 => 235522) --- tags/Safari-607.1.4/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp 2018-08-30 20:31:32 UTC (rev 235521) +++ tags/Safari-607.1.4/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp 2018-08-30 20:47:30 UTC (rev 235522) @@ -42,7 +42,7 @@ #include #include -#if PLATFORM(IOS) && !PLATFORM(IOSMAC) +#if PLATFORM(IOS) static const SInt32 fnfErr = -43; #elif PLATFORM(MAC) #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235521] trunk/Source
Title: [235521] trunk/Source Revision 235521 Author timothy_hor...@apple.com Date 2018-08-30 13:31:32 -0700 (Thu, 30 Aug 2018) Log Message Bundle unified sources more tightly in projects with deep directory structures https://bugs.webkit.org/show_bug.cgi?id=189009 Reviewed by Simon Fraser. * Scripts/generate-unified-source-bundles.rb: It turns out our plan to switch unified source bundle every time the directory changes is not a good fit for projects like WebKit2 with many small directories. It leaves many unified source bundles with only a single source file, achieving only ~40% density. Instead, switch unified source bundles every time the top-level directory changes. This still achieves the goal of *usually* only rebuilding the one top-level directory you touched, and increases source bundle density wildly, to ~95%. Fix a variety of unification errors due to reshuffling the bundles. * Modules/mediastream/RTCController.cpp: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * crypto/algorithms/CryptoAlgorithmECDSA.cpp: (WebCore::CryptoAlgorithmECDSA::importKey): * dom/Document.h: * html/parser/HTMLTreeBuilder.cpp: * loader/appcache/ApplicationCacheResourceLoader.h: * page/AlternativeTextClient.h: * platform/Pasteboard.h: * platform/graphics/DisplayRefreshMonitor.cpp: * platform/graphics/FontFamilySpecificationNull.cpp: * platform/graphics/cocoa/WebGLLayer.mm: (-[WebGLLayer initWithGraphicsContext3D:]): (-[WebGLLayer copyImageSnapshotWithColorSpace:]): (-[WebGLLayer display]): (-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]): * platform/graphics/cocoa/WebGPULayer.mm: (-[WebGPULayer initWithGPUDevice:]): * platform/graphics/metal/GPUCommandQueueMetal.mm: * platform/mac/PasteboardMac.mm: * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp: * platform/network/ResourceRequestBase.cpp: * rendering/updating/RenderTreeBuilderBlockFlow.cpp: * rendering/updating/RenderTreeBuilderInline.cpp: * Shared/APIWebArchive.mm: * Shared/APIWebArchiveResource.mm: * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: * Shared/Plugins/Netscape/mac/PluginInformationMac.mm: * SourcesCocoa.txt: * SourcesGTK.txt: * UIProcess/API/APIAutomationSessionClient.h: (API::AutomationSessionClient::sessionIdentifier const): (API::AutomationSessionClient::messageOfCurrentJavaScriptDialogOnPage): (API::AutomationSessionClient::setUserInputForCurrentJavaScriptPromptOnPage): * UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: (-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]): (-[WKCustomProtocolLoader connection:didFailWithError:]): (-[WKCustomProtocolLoader connection:didReceiveResponse:]): * UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::generatePluginProcessCallbackID): (WebKit::PluginProcessProxy::fetchWebsiteData): (WebKit::PluginProcessProxy::deleteWebsiteData): (WebKit::PluginProcessProxy::deleteWebsiteDataForHostNames): (WebKit::generateCallbackID): Deleted. * UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): * UIProcess/Storage/StorageProcessProxy.cpp: (WebKit::generateStorageProcessCallbackID): (WebKit::StorageProcessProxy::fetchWebsiteData): (WebKit::StorageProcessProxy::deleteWebsiteData): (WebKit::StorageProcessProxy::deleteWebsiteDataForOrigins): (WebKit::generateCallbackID): Deleted. * WebKit.xcodeproj/project.pbxproj: * WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFPluginAccessibilityObject accessibilityPerformAction:]): (-[WKPDFPluginAccessibilityObject accessibilityFocusedUIElement]): (-[WKPDFPluginAccessibilityObject accessibilityAssociatedControlForAnnotation:]): (-[WKPDFPluginAccessibilityObject accessibilityHitTest:]): (-[WKPDFLayerControllerDelegate updateScrollPosition:]): (WebKit::PDFPlugin::updateCursor): (WebKit::coreCursor): (appendValuesInPDFNameSubtreeToVector): Deleted. (getAllValuesInPDFNameTree): Deleted. (getAllScriptsInPDFDocument): Deleted. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb trunk/Source/WTF/wtf/Platform.h trunk/Source/WTF/wtf/text/StringBuffer.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp trunk/Source/WebCore/Modules/mediastream/RTCController.cpp trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp trunk/Source/WebCore/PAL/pal/crypto/gcrypt/Utilities.h trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/SourcesGTK.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp trunk/Source/WebCore/crypto/gcrypt/GCryptUtilities.h trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp trunk/Source/WebCore/loader/appcache/ApplicationCacheResourceLoader.h trunk/Source/WebCore/page/AlternativeTextClient.h
[webkit-changes] [235520] trunk/Source/WebKit
Title: [235520] trunk/Source/WebKit
Revision 235520
Author timothy_hor...@apple.com
Date 2018-08-30 13:01:46 -0700 (Thu, 30 Aug 2018)
Log Message
Fix the watchOS and tvOS build
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView invokeShareSheetWithResolution:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235519 => 235520)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 20:01:33 UTC (rev 235519)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 20:01:46 UTC (rev 235520)
@@ -1,3 +1,11 @@
+2018-08-30 Tim Horton
+
+Fix the watchOS and tvOS build
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView cleanupInteraction]):
+(-[WKContentView invokeShareSheetWithResolution:]):
+
2018-08-30 Eric Carlson
Mock video devices should only support discrete sizes
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (235519 => 235520)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 20:01:33 UTC (rev 235519)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 20:01:46 UTC (rev 235520)
@@ -779,13 +779,15 @@
[_fileUploadPanel dismiss];
_fileUploadPanel = nil;
}
-
+
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
if (_shareSheet) {
[_shareSheet setDelegate:nil];
[_shareSheet dismiss];
_shareSheet = nil;
}
-
+#endif
+
_inputViewUpdateDeferrer = nullptr;
_assistedNodeInformation = { };
@@ -5889,7 +5891,9 @@
- (void)invokeShareSheetWithResolution:(BOOL)resolved
{
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
[_shareSheet invokeShareSheetWithResolution:resolved];
+#endif
}
- (NSDictionary *)_contentsOfUserInterfaceItem:(NSString *)userInterfaceItem
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235519] trunk/LayoutTests
Title: [235519] trunk/LayoutTests Revision 235519 Author you...@apple.com Date 2018-08-30 13:01:33 -0700 (Thu, 30 Aug 2018) Log Message Remove WebRTC legacy API implementation https://bugs.webkit.org/show_bug.cgi?id=189040 Unreviewed. * platform/ios/TestExpectations: Use default expectations for the folder. This allows skipping imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (235518 => 235519) --- trunk/LayoutTests/ChangeLog 2018-08-30 19:57:19 UTC (rev 235518) +++ trunk/LayoutTests/ChangeLog 2018-08-30 20:01:33 UTC (rev 235519) @@ -1,3 +1,14 @@ +2018-08-30 Youenn Fablet + +Remove WebRTC legacy API implementation +https://bugs.webkit.org/show_bug.cgi?id=189040 + + +Unreviewed. + +* platform/ios/TestExpectations: Use default expectations for the folder. +This allows skipping imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription.html + 2018-08-30 Brent Fulgham The width of a nullptr TextRun should be zero Modified: trunk/LayoutTests/platform/ios/TestExpectations (235518 => 235519) --- trunk/LayoutTests/platform/ios/TestExpectations 2018-08-30 19:57:19 UTC (rev 235518) +++ trunk/LayoutTests/platform/ios/TestExpectations 2018-08-30 20:01:33 UTC (rev 235519) @@ -1060,7 +1060,6 @@ css3/color-filters/color-filter-ignore-semantic.html [ Skip ] # Run webrtc tests on iOS 11 -imported/w3c/web-platform-tests/webrtc [ Pass ] fast/mediastream/RTCIceCandidate.html [ Pass ] fast/mediastream/RTCPeerConnection-add-removeTrack.html [ Pass ] fast/mediastream/RTCPeerConnection-addIceCandidate.html [ Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235518] trunk
Title: [235518] trunk Revision 235518 Author aes...@apple.com Date 2018-08-30 12:57:19 -0700 (Thu, 30 Aug 2018) Log Message [Payment Request] Implement the PaymentMethodChangeEvent and PaymentMethodChangeEventInit interfaces https://bugs.webkit.org/show_bug.cgi?id=189100 Reviewed by Daniel Bates. LayoutTests/imported/w3c: * web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt: * web-platform-tests/payment-request/PaymentMethodChangeEvent/methodName-attribute.https-expected.txt: * web-platform-tests/payment-request/onpaymentmenthodchange-attribute.https-expected.txt: Source/WebCore: Implement the PaymentMethodChangeEvent interface and PaymentMethodChangeEventInit dictionary defined in the Payment Request API W3C Editor's Draft of 30 August 2018. The "payment method changed" algorithm will be implemented in a follow-up. Covered by existing web platform tests. * CMakeLists.txt: * DerivedSources.make: * Modules/paymentrequest/PaymentMethodChangeEvent.cpp: Added. (WebCore::PaymentMethodChangeEvent::eventInterface const): (WebCore::PaymentMethodChangeEvent::PaymentMethodChangeEvent): * Modules/paymentrequest/PaymentMethodChangeEvent.h: Added. * Modules/paymentrequest/PaymentMethodChangeEvent.idl: Added. * Modules/paymentrequest/PaymentMethodChangeEventInit.h: Added. * Modules/paymentrequest/PaymentMethodChangeEventInit.idl: Added. * Modules/paymentrequest/PaymentRequest.idl: * Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: (WebCore::PaymentRequestUpdateEvent::PaymentRequestUpdateEvent): * Modules/paymentrequest/PaymentRequestUpdateEvent.h: * Modules/paymentrequest/PaymentRequestUpdateEventInit.h: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/WebCoreBuiltinNames.h: * dom/EventNames.h: * dom/EventNames.in: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodName-attribute.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/onpaymentmenthodchange-attribute.https-expected.txt trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.idl trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.h trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEventInit.h trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/dom/EventNames.in Added Paths trunk/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.cpp trunk/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.h trunk/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.idl trunk/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEventInit.h trunk/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEventInit.idl Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (235517 => 235518) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-30 19:46:56 UTC (rev 235517) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-30 19:57:19 UTC (rev 235518) @@ -1,3 +1,14 @@ +2018-08-30 Andy Estes + +[Payment Request] Implement the PaymentMethodChangeEvent and PaymentMethodChangeEventInit interfaces +https://bugs.webkit.org/show_bug.cgi?id=189100 + +Reviewed by Daniel Bates. + +* web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt: +* web-platform-tests/payment-request/PaymentMethodChangeEvent/methodName-attribute.https-expected.txt: +* web-platform-tests/payment-request/onpaymentmenthodchange-attribute.https-expected.txt: + 2018-08-29 Olivia Barnett Implement the Web Share API Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt (235517 => 235518) --- trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt 2018-08-30 19:46:56 UTC (rev 235517) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https-expected.txt 2018-08-30 19:57:19 UTC (rev 235518) @@ -1,3 +1,3 @@ -FAIL Must have a methodDetails IDL attribute, which is initialized with to the methodName dictionary value Can't find variable: PaymentMethodChangeEvent +PASS Must have a methodDetails IDL attribute, which is initialized with to the methodName dictionary value Modified:
[webkit-changes] [235517] trunk/Source/JavaScriptCore
Title: [235517] trunk/Source/_javascript_Core
Revision 235517
Author sbar...@apple.com
Date 2018-08-30 12:46:56 -0700 (Thu, 30 Aug 2018)
Log Message
InlineAccess should do StringLength
https://bugs.webkit.org/show_bug.cgi?id=158911
Reviewed by Yusuke Suzuki.
This patch extends InlineAccess to support StringLength. This patch also
fixes AccessCase::fromStructureStubInfo to support ArrayLength and StringLength.
I forgot to implement this for ArrayLength in the initial InlineAccess
implementation. Supporting StringLength is a natural extension of the
InlineAccess machinery.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::patchableBranch8):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::patchableBranch8):
* bytecode/AccessCase.cpp:
(JSC::AccessCase::fromStructureStubInfo):
* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper::printGetByIdCacheStatus):
* bytecode/InlineAccess.cpp:
(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::generateSelfInAccess):
(JSC::InlineAccess::generateStringLength):
* bytecode/InlineAccess.h:
* bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::initStringLength):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::propagateTransitions):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::baseGPR const):
* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/bytecode/AccessCase.cpp
trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp
trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp
trunk/Source/_javascript_Core/bytecode/InlineAccess.h
trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/jit/Repatch.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (235516 => 235517)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-30 19:37:37 UTC (rev 235516)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-30 19:46:56 UTC (rev 235517)
@@ -1,5 +1,47 @@
2018-08-30 Saam barati
+InlineAccess should do StringLength
+https://bugs.webkit.org/show_bug.cgi?id=158911
+
+Reviewed by Yusuke Suzuki.
+
+This patch extends InlineAccess to support StringLength. This patch also
+fixes AccessCase::fromStructureStubInfo to support ArrayLength and StringLength.
+I forgot to implement this for ArrayLength in the initial InlineAccess
+implementation. Supporting StringLength is a natural extension of the
+InlineAccess machinery.
+
+* assembler/MacroAssembler.h:
+(JSC::MacroAssembler::patchableBranch8):
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::patchableBranch8):
+* bytecode/AccessCase.cpp:
+(JSC::AccessCase::fromStructureStubInfo):
+* bytecode/BytecodeDumper.cpp:
+(JSC::BytecodeDumper::printGetByIdCacheStatus):
+* bytecode/InlineAccess.cpp:
+(JSC::InlineAccess::dumpCacheSizesAndCrash):
+(JSC::InlineAccess::generateSelfPropertyAccess):
+(JSC::getScratchRegister):
+(JSC::InlineAccess::generateSelfPropertyReplace):
+(JSC::InlineAccess::generateArrayLength):
+(JSC::InlineAccess::generateSelfInAccess):
+(JSC::InlineAccess::generateStringLength):
+* bytecode/InlineAccess.h:
+* bytecode/PolymorphicAccess.cpp:
+(JSC::PolymorphicAccess::regenerate):
+* bytecode/StructureStubInfo.cpp:
+(JSC::StructureStubInfo::initStringLength):
+(JSC::StructureStubInfo::deref):
+(JSC::StructureStubInfo::aboutToDie):
+(JSC::StructureStubInfo::propagateTransitions):
+* bytecode/StructureStubInfo.h:
+(JSC::StructureStubInfo::baseGPR const):
+* jit/Repatch.cpp:
+(JSC::tryCacheGetByID):
+
+2018-08-30 Saam barati
+
CSE DataViewGet* DFG nodes
https://bugs.webkit.org/show_bug.cgi?id=188768
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (235516 => 235517)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2018-08-30 19:37:37 UTC (rev 235516)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2018-08-30 19:46:56 UTC (rev 235517)
@@ -450,6 +450,11 @@
return PatchableJump(branch32(cond, reg, imm));
}
+PatchableJump patchableBranch8(RelationalCondition cond, Address address, TrustedImm32 imm)
+{
+return PatchableJump(branch8(cond, address,
[webkit-changes] [235516] trunk
Title: [235516] trunk
Revision 235516
Author bfulg...@apple.com
Date 2018-08-30 12:37:37 -0700 (Thu, 30 Aug 2018)
Log Message
The width of a nullptr TextRun should be zero
https://bugs.webkit.org/show_bug.cgi?id=189154
Reviewed by Zalan Bujtas.
Source/WebCore:
If a page has an empty TextRun and attempts to paint it we can crash with a nullptr.
This patch recognizes that an empty TextRun should always produce a zero width, rather than
attempt to compute this value from font data.
Test: fast/text/null-string-textrun.html
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthOfTextRange const): An empty TextRun has zero width.
(WebCore::FontCascade::width const): Ditto.
(WebCore::FontCascade::codePath const): ASSERT that the TextRun is non-empty.
LayoutTests:
* fast/text/null-string-textrun-expected.txt: Added.
* fast/text/null-string-textrun.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
Added Paths
trunk/LayoutTests/fast/text/null-string-textrun-expected.txt
trunk/LayoutTests/fast/text/null-string-textrun.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235515 => 235516)
--- trunk/LayoutTests/ChangeLog 2018-08-30 19:27:56 UTC (rev 235515)
+++ trunk/LayoutTests/ChangeLog 2018-08-30 19:37:37 UTC (rev 235516)
@@ -1,3 +1,14 @@
+2018-08-30 Brent Fulgham
+
+The width of a nullptr TextRun should be zero
+https://bugs.webkit.org/show_bug.cgi?id=189154
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/text/null-string-textrun-expected.txt: Added.
+* fast/text/null-string-textrun.html: Added.
+
2018-08-30 Eric Carlson
Mock video devices should only support discrete sizes
Added: trunk/LayoutTests/fast/text/null-string-textrun-expected.txt (0 => 235516)
--- trunk/LayoutTests/fast/text/null-string-textrun-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/null-string-textrun-expected.txt 2018-08-30 19:37:37 UTC (rev 235516)
@@ -0,0 +1,6 @@
+This test confirms that a null text run doesn't trigger a crash. It passes if it loads without crashing.
+
+
+
+
+
Added: trunk/LayoutTests/fast/text/null-string-textrun.html (0 => 235516)
--- trunk/LayoutTests/fast/text/null-string-textrun.html (rev 0)
+++ trunk/LayoutTests/fast/text/null-string-textrun.html 2018-08-30 19:37:37 UTC (rev 235516)
@@ -0,0 +1,19 @@
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+This test confirms that a null text run doesn't trigger a crash. It passes if it loads without crashing.
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (235515 => 235516)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 19:27:56 UTC (rev 235515)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 19:37:37 UTC (rev 235516)
@@ -1,3 +1,23 @@
+2018-08-30 Brent Fulgham
+
+The width of a nullptr TextRun should be zero
+https://bugs.webkit.org/show_bug.cgi?id=189154
+
+
+Reviewed by Zalan Bujtas.
+
+If a page has an empty TextRun and attempts to paint it we can crash with a nullptr.
+
+This patch recognizes that an empty TextRun should always produce a zero width, rather than
+attempt to compute this value from font data.
+
+Test: fast/text/null-string-textrun.html
+
+* platform/graphics/FontCascade.cpp:
+(WebCore::FontCascade::widthOfTextRange const): An empty TextRun has zero width.
+(WebCore::FontCascade::width const): Ditto.
+(WebCore::FontCascade::codePath const): ASSERT that the TextRun is non-empty.
+
2018-08-30 Eric Carlson
Mock video devices should only support discrete sizes
Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (235515 => 235516)
--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2018-08-30 19:27:56 UTC (rev 235515)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2018-08-30 19:37:37 UTC (rev 235516)
@@ -341,6 +341,9 @@
ASSERT(from <= to);
ASSERT(to <= run.length());
+if (!run.length())
+return 0;
+
float offsetBeforeRange = 0;
float offsetAfterRange = 0;
float totalWidth = 0;
@@ -385,6 +388,9 @@
float FontCascade::width(const TextRun& run, HashSet* fallbackFonts, GlyphOverflow* glyphOverflow) const
{
+if (!run.length())
+return 0;
+
CodePath codePathToUse = codePath(run);
if (codePathToUse != Complex) {
// The complex path is more restrictive about returning fallback fonts than the simple path, so we need an explicit test to make their behaviors match.
@@ -604,6 +610,8 @@
if (s_codePath != Auto)
return s_codePath;
+ASSERT(run.length());
+
#if !USE(FREETYPE)
// FIXME: Use the fast code path once it handles partial runs with kerning and
[webkit-changes] [235515] trunk
Title: [235515] trunk
Revision 235515
Author sbar...@apple.com
Date 2018-08-30 12:27:56 -0700 (Thu, 30 Aug 2018)
Log Message
CSE DataViewGet* DFG nodes
https://bugs.webkit.org/show_bug.cgi?id=188768
Reviewed by Yusuke Suzuki.
JSTests:
* microbenchmarks/dataview-cse.js: Added.
(assert):
(test):
* stress/dataview-get-cse.js: Added.
(assert):
(test1.foo):
(test1):
(test2.foo):
(test2):
(test3.foo):
(test3):
(test4.foo):
(test4):
(test5.foo):
(test5):
(test6.foo):
(test6):
Source/_javascript_Core:
This patch makes it so that we CSE DataViewGet* accesses. To do this,
I needed to add a third descriptor to HeapLocation to represent the
isLittleEndian child. This patch is neutral on compile time benchmarks,
and is a 50% speedup on a trivial CSE microbenchmark that I added.
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
* dfg/DFGHeapLocation.h:
(JSC::DFG::HeapLocation::HeapLocation):
(JSC::DFG::HeapLocation::hash const):
(JSC::DFG::HeapLocation::operator== const):
(JSC::DFG::indexedPropertyLocForResultType):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGHeapLocation.cpp
trunk/Source/_javascript_Core/dfg/DFGHeapLocation.h
Added Paths
trunk/JSTests/microbenchmarks/dataview-cse.js
trunk/JSTests/stress/dataview-get-cse.js
Diff
Modified: trunk/JSTests/ChangeLog (235514 => 235515)
--- trunk/JSTests/ChangeLog 2018-08-30 19:05:34 UTC (rev 235514)
+++ trunk/JSTests/ChangeLog 2018-08-30 19:27:56 UTC (rev 235515)
@@ -1,3 +1,28 @@
+2018-08-30 Saam barati
+
+CSE DataViewGet* DFG nodes
+https://bugs.webkit.org/show_bug.cgi?id=188768
+
+Reviewed by Yusuke Suzuki.
+
+* microbenchmarks/dataview-cse.js: Added.
+(assert):
+(test):
+* stress/dataview-get-cse.js: Added.
+(assert):
+(test1.foo):
+(test1):
+(test2.foo):
+(test2):
+(test3.foo):
+(test3):
+(test4.foo):
+(test4):
+(test5.foo):
+(test5):
+(test6.foo):
+(test6):
+
2018-08-30 Yusuke Suzuki
output of toString() of Generator is wrong
Added: trunk/JSTests/microbenchmarks/dataview-cse.js (0 => 235515)
--- trunk/JSTests/microbenchmarks/dataview-cse.js (rev 0)
+++ trunk/JSTests/microbenchmarks/dataview-cse.js 2018-08-30 19:27:56 UTC (rev 235515)
@@ -0,0 +1,28 @@
+"use strict";
+
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function test(dv, littleEndian) {
+return dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
++ dv.getInt32(0, littleEndian)
+}
+noInline(test);
+
+let ab = new ArrayBuffer(4);
+let dv = new DataView(ab);
+dv.setInt32(0, 10, true);
+for (let i = 0; i < 100; ++i) {
+let result = test(dv, true);
+assert(result === 10*10);
+}
Added: trunk/JSTests/stress/dataview-get-cse.js (0 => 235515)
--- trunk/JSTests/stress/dataview-get-cse.js (rev 0)
+++ trunk/JSTests/stress/dataview-get-cse.js 2018-08-30 19:27:56 UTC (rev 235515)
@@ -0,0 +1,137 @@
+"use strict";
+
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+
+function test1() {
+function foo(dv) {
+return [dv.getFloat32(0), dv.getFloat64(0)];
+}
+noInline(foo);
+
+let ab = new ArrayBuffer(8);
+let dv = new DataView(ab);
+dv.setFloat64(0, 128431.42342189432, false);
+for (let i = 0; i < 1; ++i) {
+let result = foo(dv);
+assert(result[0] !== result[1]);
+}
+}
+test1();
+
+function test2() {
+function foo(dv) {
+return [dv.getFloat32(0), dv.getFloat32(0)];
+}
+noInline(foo);
+
+let ab = new ArrayBuffer(8);
+let dv = new DataView(ab);
+dv.setFloat64(0, 128431.42342189432, false);
+for (let i = 0; i < 1; ++i) {
+let result = foo(dv);
+assert(result[0] === result[1]);
+}
+}
+test2();
+
+function test3() {
+function foo(dv, ta) {
+let a = dv.getFloat64(0, true);
+ta[0] = Math.PI;
+let b = dv.getFloat64(0, true);
+return [a, b];
+}
+noInline(foo);
+
+let ab = new ArrayBuffer(8);
+let dv = new DataView(ab);
+let ta = new Float64Array(ab);
+for (let i = 0; i < 4; ++i) {
+dv.setFloat64(0, 0.0, true);
+let result = foo(dv, ta);
+assert(result[0] === 0.0);
+assert(result[1] === Math.PI);
+}
+}
+test3();
+
+function test4() {
+function foo(dv) {
+let a =
[webkit-changes] [235514] trunk
Title: [235514] trunk
Revision 235514
Author yusukesuz...@slowstart.org
Date 2018-08-30 12:05:34 -0700 (Thu, 30 Aug 2018)
Log Message
output of toString() of Generator is wrong
https://bugs.webkit.org/show_bug.cgi?id=188952
Reviewed by Saam Barati.
JSTests:
* stress/function-to-string.js: Added.
(shouldBe):
(shouldBe.test):
(test):
(shouldBe.async.test):
(async.test):
(shouldBe.async):
(async):
* test262/expectations.yaml:
Source/_javascript_Core:
Function#toString does not respect generator and async generator.
This patch fixes them and supports all the function types.
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/FunctionPrototype.cpp
Added Paths
trunk/JSTests/stress/function-to-string.js
Diff
Modified: trunk/JSTests/ChangeLog (235513 => 235514)
--- trunk/JSTests/ChangeLog 2018-08-30 19:03:55 UTC (rev 235513)
+++ trunk/JSTests/ChangeLog 2018-08-30 19:05:34 UTC (rev 235514)
@@ -1,3 +1,20 @@
+2018-08-30 Yusuke Suzuki
+
+output of toString() of Generator is wrong
+https://bugs.webkit.org/show_bug.cgi?id=188952
+
+Reviewed by Saam Barati.
+
+* stress/function-to-string.js: Added.
+(shouldBe):
+(shouldBe.test):
+(test):
+(shouldBe.async.test):
+(async.test):
+(shouldBe.async):
+(async):
+* test262/expectations.yaml:
+
2018-08-29 Mark Lam
Add some missing exception checks in JSRopeString::resolveRopeToAtomicString().
Added: trunk/JSTests/stress/function-to-string.js (0 => 235514)
--- trunk/JSTests/stress/function-to-string.js (rev 0)
+++ trunk/JSTests/stress/function-to-string.js 2018-08-30 19:05:34 UTC (rev 235514)
@@ -0,0 +1,11 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+shouldBe((function test() { }).toString(), `function test() { }`);
+shouldBe((() => { }).toString(), `() => { }`);
+shouldBe((function* test() { }).toString(), `function* test() { }`);
+shouldBe((async function* test() { }).toString(), `async function* test() { }`);
+shouldBe((async function test() { }).toString(), `async function test() { }`);
+shouldBe((async () => { }).toString(), `async () => { }`);
Modified: trunk/JSTests/test262/expectations.yaml (235513 => 235514)
--- trunk/JSTests/test262/expectations.yaml 2018-08-30 19:03:55 UTC (rev 235513)
+++ trunk/JSTests/test262/expectations.yaml 2018-08-30 19:05:34 UTC (rev 235514)
@@ -909,8 +909,8 @@
default: "SyntaxError: Unexpected token '}'. Expected a ')' or a ',' after a parameter declaration."
strict mode: "SyntaxError: Unexpected token '}'. Expected a ')' or a ',' after a parameter declaration."
test/built-ins/Function/prototype/toString/async-arrow-function.js:
- default: "Test262Error: Conforms to NativeFunction Syntax: 'async function ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ }'.(async /* a */ ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ })"
- strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'async function ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ }'.(async /* a */ ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ })"
+ default: "Test262Error: Conforms to NativeFunction Syntax: 'async ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ }'.(async /* a */ ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ })"
+ strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'async ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ }'.(async /* a */ ( /* b */ a /* c */ , /* d */ b /* e */ ) /* f */ => /* g */ { /* h */ ; /* i */ })"
test/built-ins/Function/prototype/toString/async-function-declaration.js:
default: "Test262Error: Conforms to NativeFunction Syntax: 'async function f( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ }'.(async function /* a */ f /* b */ ( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ })"
strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'async function f( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ }'.(async function /* a */ f /* b */ ( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ })"
@@ -942,14 +942,14 @@
default: "Test262Error: Conforms to NativeFunction Syntax: 'function F( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ }'.(function /* a */ F /* b */ ( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ })"
strict mode: "Test262Error: Conforms to NativeFunction
[webkit-changes] [235512] trunk/Source/WebKit
Title: [235512] trunk/Source/WebKit
Revision 235512
Author commit-qu...@webkit.org
Date 2018-08-30 11:29:58 -0700 (Thu, 30 Aug 2018)
Log Message
Web Share API compatible with AppleTV and WatchOS
https://bugs.webkit.org/show_bug.cgi?id=189157
Patch by Olivia Barnett on 2018-08-30
Reviewed by Tim Horton.
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView fileUploadPanelDidDismiss:]):
* UIProcess/ios/forms/WKShareSheet.h:
* UIProcess/ios/forms/WKShareSheet.mm:
(-[WKShareSheet invokeShareSheetWithResolution:]):
Added platform checks.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKShareSheet.h
trunk/Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235511 => 235512)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 18:21:45 UTC (rev 235511)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 18:29:58 UTC (rev 235512)
@@ -1,3 +1,19 @@
+2018-08-30 Olivia Barnett
+
+Web Share API compatible with AppleTV and WatchOS
+https://bugs.webkit.org/show_bug.cgi?id=189157
+
+Reviewed by Tim Horton.
+
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView fileUploadPanelDidDismiss:]):
+* UIProcess/ios/forms/WKShareSheet.h:
+* UIProcess/ios/forms/WKShareSheet.mm:
+(-[WKShareSheet invokeShareSheetWithResolution:]):
+Added platform checks.
+
2018-08-30 Commit Queue
Unreviewed, rolling out r235413 and r235444.
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (235511 => 235512)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-08-30 18:21:45 UTC (rev 235511)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-08-30 18:29:58 UTC (rev 235512)
@@ -65,7 +65,6 @@
#define DEFAULT_TEXT_AREAS_ARE_RESIZABLE false
#define DEFAULT_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY false
#define DEFAULT_SHOULD_RESPECT_IMAGE_ORIENTATION true
-#define DEFAULT_WEB_SHARE_ENABLED true
#define DEFAULT_PASSWORD_ECHO_ENABLED true
#define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK false
#define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_AFTER_FULLSCREEN true
@@ -174,6 +173,12 @@
#endif
+#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
+#define DEFAULT_WEB_SHARE_ENABLED true
+#else
+#define DEFAULT_WEB_SHARE_ENABLED false
+#endif
+
#if !PLATFORM(WATCHOS)
#define DEFAULT_AVFOUNDATION_ENABLED true
#else
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (235511 => 235512)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-08-30 18:21:45 UTC (rev 235511)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-08-30 18:29:58 UTC (rev 235512)
@@ -27,6 +27,10 @@
#import "WKContentView.h"
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
+#import "WKShareSheet.h"
+#endif
+
#import "AssistedNodeInformation.h"
#import "DragDropInteractionState.h"
#import "EditorState.h"
@@ -176,7 +180,9 @@
#endif
RetainPtr _formInputSession;
RetainPtr _fileUploadPanel;
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
RetainPtr _shareSheet;
+#endif
RetainPtr _previewGestureRecognizer;
RetainPtr _previewSecondaryGestureRecognizer;
Vector _focusStateStack;
@@ -265,7 +271,11 @@
@end
-@interface WKContentView (WKInteraction) +@interface WKContentView (WKInteraction) #if ENABLE(DATA_INTERACTION)
, UIDragInteractionDelegate, UIDropInteractionDelegate
#endif
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (235511 => 235512)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 18:21:45 UTC (rev 235511)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-30 18:29:58 UTC (rev 235512)
@@ -4700,6 +4700,15 @@
[_fileUploadPanel presentWithParameters:parameters resultListener:listener];
}
+- (void)fileUploadPanelDidDismiss:(WKFileUploadPanel *)fileUploadPanel
+{
+ASSERT(_fileUploadPanel.get() == fileUploadPanel);
+
+[_fileUploadPanel setDelegate:nil];
+_fileUploadPanel = nil;
+}
+
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
- (void)_showShareSheet:(const ShareDataWithParsedURL&)data completionHandler:(CompletionHandler&&)completionHandler
{
ASSERT(!_shareSheet);
@@ -4712,14 +4721,6 @@
[_shareSheet presentWithParameters:data completionHandler:WTFMove(completionHandler)];
}
-- (void)fileUploadPanelDidDismiss:(WKFileUploadPanel *)fileUploadPanel
-{
-ASSERT(_fileUploadPanel.get() == fileUploadPanel);
-
-[_fileUploadPanel setDelegate:nil];
-_fileUploadPanel =
[webkit-changes] [235511] trunk/Source/WebKit
Title: [235511] trunk/Source/WebKit
Revision 235511
Author commit-qu...@webkit.org
Date 2018-08-30 11:21:45 -0700 (Thu, 30 Aug 2018)
Log Message
Unreviewed, rolling out r235413 and r235444.
https://bugs.webkit.org/show_bug.cgi?id=189163
Causes crashes when running layout tests under GuardMalloc
(Requested by ryanhaddad on #webkit).
Reverted changesets:
"NetworkLoad::didReceiveResponse should pass its completion
handler to its client"
https://bugs.webkit.org/show_bug.cgi?id=188701
https://trac.webkit.org/changeset/235413
"Remove assertion introduced in r235413"
https://bugs.webkit.org/show_bug.cgi?id=188701
https://trac.webkit.org/changeset/235444
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp
trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit/NetworkProcess/NetworkLoadClient.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/NetworkProcess/PingLoad.cpp
trunk/Source/WebKit/NetworkProcess/PingLoad.h
trunk/Source/WebKit/NetworkProcess/PreconnectTask.cpp
trunk/Source/WebKit/NetworkProcess/PreconnectTask.h
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
trunk/Source/WebKit/NetworkProcess/capture/NetworkDataTaskReplay.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (235510 => 235511)
--- trunk/Source/WebKit/ChangeLog 2018-08-30 18:13:01 UTC (rev 235510)
+++ trunk/Source/WebKit/ChangeLog 2018-08-30 18:21:45 UTC (rev 235511)
@@ -1,3 +1,22 @@
+2018-08-30 Commit Queue
+
+Unreviewed, rolling out r235413 and r235444.
+https://bugs.webkit.org/show_bug.cgi?id=189163
+
+Causes crashes when running layout tests under GuardMalloc
+(Requested by ryanhaddad on #webkit).
+
+Reverted changesets:
+
+"NetworkLoad::didReceiveResponse should pass its completion
+handler to its client"
+https://bugs.webkit.org/show_bug.cgi?id=188701
+https://trac.webkit.org/changeset/235413
+
+"Remove assertion introduced in r235413"
+https://bugs.webkit.org/show_bug.cgi?id=188701
+https://trac.webkit.org/changeset/235444
+
2018-08-30 Basuke Suzuki
[Curl][WebKit] Bugfix on redirect.
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp (235510 => 235511)
--- trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp 2018-08-30 18:13:01 UTC (rev 235510)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp 2018-08-30 18:21:45 UTC (rev 235511)
@@ -85,10 +85,10 @@
ASSERT_UNUSED(addResult, addResult.isNewEntry);
}
-void DownloadManager::convertNetworkLoadToDownload(DownloadID downloadID, std::unique_ptr&& networkLoad, ResponseCompletionHandler&& completionHandler, Vector>&& blobFileReferences, const ResourceRequest& request, const ResourceResponse& response)
+void DownloadManager::convertNetworkLoadToDownload(DownloadID downloadID, std::unique_ptr&& networkLoad, Vector>&& blobFileReferences, const ResourceRequest& request, const ResourceResponse& response)
{
ASSERT(!m_pendingDownloads.contains(downloadID));
-m_pendingDownloads.add(downloadID, std::make_unique(WTFMove(networkLoad), WTFMove(completionHandler), downloadID, request, response));
+m_pendingDownloads.add(downloadID, std::make_unique(WTFMove(networkLoad), downloadID, request, response));
}
void DownloadManager::continueDecidePendingDownloadDestination(DownloadID downloadID, String destination, SandboxExtension::Handle&& sandboxExtensionHandle, bool allowOverwrite)
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h (235510 => 235511)
--- trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h 2018-08-30 18:13:01 UTC (rev 235510)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h 2018-08-30 18:21:45 UTC (rev 235511)
@@ -79,7 +79,7 @@
void dataTaskBecameDownloadTask(DownloadID, std::unique_ptr&&);
void continueWillSendRequest(DownloadID, WebCore::ResourceRequest&&);
void willDecidePendingDownloadDestination(NetworkDataTask&, ResponseCompletionHandler&&);
-void convertNetworkLoadToDownload(DownloadID, std::unique_ptr&&, ResponseCompletionHandler&&, Vector>&&, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+void convertNetworkLoadToDownload(DownloadID,
[webkit-changes] [235509] trunk/Tools
Title: [235509] trunk/Tools Revision 235509 Author sihui_...@apple.com Date 2018-08-30 10:03:01 -0700 (Thu, 30 Aug 2018) Log Message WKNavigation.ProcessCrashDuringCallback is failing on iOS https://bugs.webkit.org/show_bug.cgi?id=189148 Reviewed by Chris Dumez. We should not deference WebView or we may get WKErrorWebViewInvalidated error, because WebView could be destroyed before Web Process termination is noticed. * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: (TEST): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm Diff Modified: trunk/Tools/ChangeLog (235508 => 235509) --- trunk/Tools/ChangeLog 2018-08-30 16:53:01 UTC (rev 235508) +++ trunk/Tools/ChangeLog 2018-08-30 17:03:01 UTC (rev 235509) @@ -1,3 +1,16 @@ +2018-08-30 Sihui Liu + +WKNavigation.ProcessCrashDuringCallback is failing on iOS +https://bugs.webkit.org/show_bug.cgi?id=189148 + +Reviewed by Chris Dumez. + +We should not deference WebView or we may get WKErrorWebViewInvalidated error, because +WebView could be destroyed before Web Process termination is noticed. + +* TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: +(TEST): + 2018-08-30 Zalan Bujtas [LFC][Floating] Formatting context roots avoid floats. Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm (235508 => 235509) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-30 16:53:01 UTC (rev 235508) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-30 17:03:01 UTC (rev 235509) @@ -275,8 +275,6 @@ // Simulate a crash, which should invalidate all pending callbacks. [webView _killWebContentProcess]; -webView = nullptr; - TestWebKitAPI::Util::run(); TestWebKitAPI::Util::sleep(0.5); EXPECT_EQ(6U, callbackCount); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235508] trunk/LayoutTests
Title: [235508] trunk/LayoutTests
Revision 235508
Author you...@apple.com
Date 2018-08-30 09:53:01 -0700 (Thu, 30 Aug 2018)
Log Message
fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
https://bugs.webkit.org/show_bug.cgi?id=189155
Reviewed by Eric Carlson.
* fast/mediastream/RTCPeerConnection-overloaded-operations.html:
createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
Make sure that these promises are handled.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235507 => 235508)
--- trunk/LayoutTests/ChangeLog 2018-08-30 16:35:46 UTC (rev 235507)
+++ trunk/LayoutTests/ChangeLog 2018-08-30 16:53:01 UTC (rev 235508)
@@ -1,3 +1,14 @@
+2018-08-30 Youenn Fablet
+
+fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
+https://bugs.webkit.org/show_bug.cgi?id=189155
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/RTCPeerConnection-overloaded-operations.html:
+createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
+Make sure that these promises are handled.
+
2018-08-30 Zalan Bujtas
[LFC][Floating] Formatting context roots avoid floats.
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html (235507 => 235508)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html 2018-08-30 16:35:46 UTC (rev 235507)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html 2018-08-30 16:53:01 UTC (rev 235508)
@@ -27,9 +27,11 @@
shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc)");
shouldBeType("result", "Promise");
+result.then(() => { }, () => { });
shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc, {})");
shouldBeType("result", "Promise");
+result.then(() => { }, () => { });
}
// Test setLocal/RemoteDescription()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235507] trunk/Source/WebKit
Title: [235507] trunk/Source/WebKit Revision 235507 Author akeer...@apple.com Date 2018-08-30 09:35:46 -0700 (Thu, 30 Aug 2018) Log Message [macOS] Color picker layout is broken if suggested colors are specified https://bugs.webkit.org/show_bug.cgi?id=189117 Reviewed by Tim Horton. NSPopoverColorWell recently changed the size of its swatches. We need to update the width of the swatches we provide to match the width of the other swatches, in order to avoid breaking the layout. While such a solution is not a good precedent, we do not have fully-functional SPI to customize the suggested colors. A FIXME has been added for this reason. However, even once we obtain SPI, we will need to find a way to support older clients, making conditional compilation a potential necessity. * UIProcess/mac/WebColorPickerMac.mm: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm Diff Modified: trunk/Source/WebKit/ChangeLog (235506 => 235507) --- trunk/Source/WebKit/ChangeLog 2018-08-30 16:30:11 UTC (rev 235506) +++ trunk/Source/WebKit/ChangeLog 2018-08-30 16:35:46 UTC (rev 235507) @@ -1,3 +1,21 @@ +2018-08-30 Aditya Keerthi + +[macOS] Color picker layout is broken if suggested colors are specified +https://bugs.webkit.org/show_bug.cgi?id=189117 + +Reviewed by Tim Horton. + +NSPopoverColorWell recently changed the size of its swatches. We need to update +the width of the swatches we provide to match the width of the other swatches, +in order to avoid breaking the layout. + +While such a solution is not a good precedent, we do not have fully-functional SPI +to customize the suggested colors. A FIXME has been added for this reason. +However, even once we obtain SPI, we will need to find a way to support older +clients, making conditional compilation a potential necessity. + +* UIProcess/mac/WebColorPickerMac.mm: + 2018-08-30 Brent Fulgham [macOS] Whitelist Network process features for VPN Modified: trunk/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm (235506 => 235507) --- trunk/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm 2018-08-30 16:30:11 UTC (rev 235506) +++ trunk/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm 2018-08-30 16:35:46 UTC (rev 235507) @@ -44,9 +44,15 @@ static const size_t maxColorSuggestions = 12; static const CGFloat colorPickerMatrixNumColumns = 12.0; -static const CGFloat colorPickerMatrixSwatchWidth = 12.0; static const CGFloat colorPickerMatrixBorderWidth = 1.0; +// FIXME: We should not have to track changes in NSPopoverColorWell's implementation. +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 +static const CGFloat colorPickerMatrixSwatchWidth = 13.0; +#else +static const CGFloat colorPickerMatrixSwatchWidth = 12.0; +#endif + @protocol WKPopoverColorWellDelegate - (void)didClosePopover; @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235506] trunk/Source/WebKit
Title: [235506] trunk/Source/WebKit Revision 235506 Author bfulg...@apple.com Date 2018-08-30 09:30:11 -0700 (Thu, 30 Aug 2018) Log Message [macOS] Whitelist Network process features for VPN https://bugs.webkit.org/show_bug.cgi?id=189023 Reviewed by Eric Carlson. CFNetwork needs access to some VPN preference files to configure networking, and need to be allowed to communicate with the VPN process from the Network Process sandbox. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (235505 => 235506) --- trunk/Source/WebKit/ChangeLog 2018-08-30 14:44:59 UTC (rev 235505) +++ trunk/Source/WebKit/ChangeLog 2018-08-30 16:30:11 UTC (rev 235506) @@ -1,3 +1,17 @@ +2018-08-30 Brent Fulgham + +[macOS] Whitelist Network process features for VPN +https://bugs.webkit.org/show_bug.cgi?id=189023 + + +Reviewed by Eric Carlson. + +CFNetwork needs access to some VPN preference files to configure networking, and +need to be allowed to communicate with the VPN process from the Network Process +sandbox. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: + 2018-08-30 Yoshiaki Jitsukawa [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (235505 => 235506) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2018-08-30 14:44:59 UTC (rev 235505) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2018-08-30 16:30:11 UTC (rev 235506) @@ -155,6 +155,7 @@ (global-name "com.apple.cookied") (global-name "com.apple.cfnetwork.AuthBrokerAgent") (global-name "com.apple.cfnetwork.cfnetworkagent") +(global-name "com.apple.ist.ds.appleconnect2.service.kdctunnelcontroller") (global-name "com.apple.lsd.mapdb") (global-name "com.apple.nesessionmanager.flow-divert-token") ) @@ -197,8 +198,17 @@ (literal "/Library/Preferences/com.apple.security.revocation.plist") (home-literal "/Library/Application Support/SyncServices/Local/ClientsWithChanges/com.apple.Keychain") (home-literal "/Library/Preferences/com.apple.security.plist") - (home-literal "/Library/Preferences/com.apple.security.revocation.plist")) + (home-literal "/Library/Preferences/com.apple.security.revocation.plist") + ; Likewise for + (literal "/Library/Preferences/com.apple.ist.ds.appleconnect2.plist") + (literal "/Library/Preferences/com.apple.ist.ds.appleconnect2.production.plist") + (home-literal "/Library/Preferences/com.apple.ist.ds.appleconnect2.plist") + (home-literal "/Library/Preferences/com.apple.ist.ds.appleconnect2.production.plist") + (home-regex (string-append "/Library/Preferences/ByHost/com\.apple\.ist\.ds\.appleconnect2\." (uuid-regex-string) "\.plist$")) + (home-regex (string-append "/Library/Preferences/ByHost/com\.apple\.ist\.ds\.appleconnect2\.production\." (uuid-regex-string) "\.plist$")) +) + (allow ipc-posix-shm-read* ipc-posix-shm-write-data (ipc-posix-name "com.apple.AppleDatabaseChanged")) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235505] trunk
Title: [235505] trunk Revision 235505 Author za...@apple.com Date 2018-08-30 07:44:59 -0700 (Thu, 30 Aug 2018) Log Message Source/WebCore: [LFC][Floating] Block formatting context roots avoid floats. https://bugs.webkit.org/show_bug.cgi?id=189150 Reviewed by Antti Koivisto. This patch implements the float avoiding behaviour for block formatting context roots. When a box establishes a block formatting context, floats from outside of the context can't interfere with content inside. In order to achive this, such formatting root boxes need to be positioned so that they don't overlap with floats (floats that share the same context with the formatting root). In ltr block direction, roots start with avoiding floats on the left, while in rtl on the right. Tests: fast/block/block-only/float-avoider-multiple-roots.html fast/block/block-only/float-avoider-simple-left.html fast/block/block-only/float-avoider-simple-right.html fast/block/block-only/float-avoider-with-margins.html * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): (WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const): (WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const): * layout/blockformatting/BlockFormattingContext.h: * layout/floats/FloatAvoider.cpp: (WebCore::Layout::FloatAvoider::FloatAvoider): * layout/floats/FloatingContext.cpp: (WebCore::Layout::FloatingContext::positionForFloatAvoiding const): * layout/floats/FloatingContext.h: Tools: [LFC][Floating] Formatting context roots avoid floats. https://bugs.webkit.org/show_bug.cgi?id=189150 Reviewed by Antti Koivisto. * LayoutReloaded/misc/LFC-passing-tests.txt: LayoutTests: [LFC][Floating] Formatting context roots avoid floats. https://bugs.webkit.org/show_bug.cgi?id=189150 Reviewed by Antti Koivisto. * fast/block/block-only/float-avoider-multiple-roots-expected.txt: Added. * fast/block/block-only/float-avoider-multiple-roots.html: Added. * fast/block/block-only/float-avoider-simple-left-expected.txt: Added. * fast/block/block-only/float-avoider-simple-left.html: Added. * fast/block/block-only/float-avoider-simple-right-expected.txt: Added. * fast/block/block-only/float-avoider-simple-right.html: Added. * fast/block/block-only/float-avoider-with-margins-expected.txt: Added. * fast/block/block-only/float-avoider-with-margins.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h trunk/Source/WebCore/layout/floats/FloatAvoider.cpp trunk/Source/WebCore/layout/floats/FloatingContext.cpp trunk/Source/WebCore/layout/floats/FloatingContext.h trunk/Tools/ChangeLog trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt Added Paths trunk/LayoutTests/fast/block/block-only/float-avoider-multiple-roots-expected.txt trunk/LayoutTests/fast/block/block-only/float-avoider-multiple-roots.html trunk/LayoutTests/fast/block/block-only/float-avoider-simple-left-expected.txt trunk/LayoutTests/fast/block/block-only/float-avoider-simple-left.html trunk/LayoutTests/fast/block/block-only/float-avoider-simple-right-expected.txt trunk/LayoutTests/fast/block/block-only/float-avoider-simple-right.html trunk/LayoutTests/fast/block/block-only/float-avoider-with-margins-expected.txt trunk/LayoutTests/fast/block/block-only/float-avoider-with-margins.html Diff Modified: trunk/LayoutTests/ChangeLog (235504 => 235505) --- trunk/LayoutTests/ChangeLog 2018-08-30 14:35:27 UTC (rev 235504) +++ trunk/LayoutTests/ChangeLog 2018-08-30 14:44:59 UTC (rev 235505) @@ -1,3 +1,19 @@ +2018-08-30 Zalan Bujtas + +[LFC][Floating] Formatting context roots avoid floats. +https://bugs.webkit.org/show_bug.cgi?id=189150 + +Reviewed by Antti Koivisto. + +* fast/block/block-only/float-avoider-multiple-roots-expected.txt: Added. +* fast/block/block-only/float-avoider-multiple-roots.html: Added. +* fast/block/block-only/float-avoider-simple-left-expected.txt: Added. +* fast/block/block-only/float-avoider-simple-left.html: Added. +* fast/block/block-only/float-avoider-simple-right-expected.txt: Added. +* fast/block/block-only/float-avoider-simple-right.html: Added. +* fast/block/block-only/float-avoider-with-margins-expected.txt: Added. +* fast/block/block-only/float-avoider-with-margins.html: Added. + 2018-08-29 Aditya Keerthi [Datalist] Display prefix-matched suggestions first Added: trunk/LayoutTests/fast/block/block-only/float-avoider-multiple-roots-expected.txt (0 => 235505) --- trunk/LayoutTests/fast/block/block-only/float-avoider-multiple-roots-expected.txt (rev 0) +++ trunk/LayoutTests/fast/block/block-only/float-avoider-multiple-roots-expected.txt 2018-08-30 14:44:59
[webkit-changes] [235504] trunk/Tools
Title: [235504] trunk/Tools
Revision 235504
Author wenson_hs...@apple.com
Date 2018-08-30 07:35:27 -0700 (Thu, 30 Aug 2018)
Log Message
[iOS] TestWebKitAPI.PasteImage tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=185965
Reviewed by Andy Estes.
These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
this by waiting for the "load" event (which is also done in some of the other tests in this file).
* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
Diff
Modified: trunk/Tools/ChangeLog (235503 => 235504)
--- trunk/Tools/ChangeLog 2018-08-30 14:32:29 UTC (rev 235503)
+++ trunk/Tools/ChangeLog 2018-08-30 14:35:27 UTC (rev 235504)
@@ -1,3 +1,18 @@
+2018-08-30 Wenson Hsieh
+
+[iOS] TestWebKitAPI.PasteImage tests are flaky failures
+https://bugs.webkit.org/show_bug.cgi?id=185965
+
+Reviewed by Andy Estes.
+
+These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
+element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
+because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
+this by waiting for the "load" event (which is also done in some of the other tests in this file).
+
+* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+(TEST):
+
2018-08-30 Michael Catanzaro
Unreviewed, rolling out r235114.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm (235503 => 235504)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm 2018-08-30 14:32:29 UTC (rev 235503)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm 2018-08-30 14:35:27 UTC (rev 235504)
@@ -67,6 +67,7 @@
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(gifItem.file).toString()"]);
[webView stringByEvaluatingJavaScript:@"insertFileAsImage(gifItem.file)"];
+[webView waitForMessage:@"loaded"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("400", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
@@ -89,6 +90,7 @@
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(jpegItem.file).toString()"]);
[webView stringByEvaluatingJavaScript:@"insertFileAsImage(jpegItem.file)"];
+[webView waitForMessage:@"loaded"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("600", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
@@ -111,6 +113,7 @@
EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(pngItem.file).toString()"]);
[webView stringByEvaluatingJavaScript:@"insertFileAsImage(pngItem.file)"];
+[webView waitForMessage:@"loaded"];
EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = "" URL(imageElement.src); url.protocol"]);
EXPECT_WK_STREQ("200", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235503] trunk/Source/WebCore
Title: [235503] trunk/Source/WebCore
Revision 235503
Author za...@apple.com
Date 2018-08-30 07:32:29 -0700 (Thu, 30 Aug 2018)
Log Message
[LFC][Floating] Move containing block constraint logic from FloatAvoider to FloatingContext
https://bugs.webkit.org/show_bug.cgi?id=189145
Reviewed by Antti Koivisto.
When the float avoider is constrained horizontally, simply align it with the left/right edge of its containing block (with the combination of the constraints)
and check the overflow as part of the FloatingContext::floatingPosition() logic. It simplifies the constraint logic/helps implementing the non-float avoider
case.
* layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):
* layout/floats/FloatAvoider.h:
* layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::floatingPosition const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/floats/FloatAvoider.cpp
trunk/Source/WebCore/layout/floats/FloatAvoider.h
trunk/Source/WebCore/layout/floats/FloatingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235502 => 235503)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 14:28:54 UTC (rev 235502)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 14:32:29 UTC (rev 235503)
@@ -1,5 +1,23 @@
2018-08-30 Zalan Bujtas
+[LFC][Floating] Move containing block constraint logic from FloatAvoider to FloatingContext
+https://bugs.webkit.org/show_bug.cgi?id=189145
+
+Reviewed by Antti Koivisto.
+
+When the float avoider is constrained horizontally, simply align it with the left/right edge of its containing block (with the combination of the constraints)
+and check the overflow as part of the FloatingContext::floatingPosition() logic. It simplifies the constraint logic/helps implementing the non-float avoider
+case.
+
+* layout/floats/FloatAvoider.cpp:
+(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
+(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):
+* layout/floats/FloatAvoider.h:
+* layout/floats/FloatingContext.cpp:
+(WebCore::Layout::FloatingContext::floatingPosition const):
+
+2018-08-30 Zalan Bujtas
+
[LFC][Floating] Use non-computed horizontal margins when intersecting floats with float avoiders.
https://bugs.webkit.org/show_bug.cgi?id=189143
Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.cpp (235502 => 235503)
--- trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-30 14:28:54 UTC (rev 235502)
+++ trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-30 14:32:29 UTC (rev 235503)
@@ -59,13 +59,12 @@
// Horizontal position is constrained by the containing block's content box.
// Compute the horizontal position for the new floating by taking both the contining block and the current left/right floats into account.
auto containingBlockContentBoxLeft = m_containingBlockAbsoluteDisplayBox.left() + m_containingBlockAbsoluteDisplayBox.contentBoxLeft();
+if (isLeftAligned())
+return std::max(containingBlockContentBoxLeft + marginLeft(), left);
+
+// Make sure it does not overflow the containing block on the right.
auto containingBlockContentBoxRight = containingBlockContentBoxLeft + m_containingBlockAbsoluteDisplayBox.contentBoxWidth();
-// Align it with the containing block's left edge first.
-left = std::max(containingBlockContentBoxLeft + marginLeft(), left);
-// Make sure it does not overflow the containing block on the right.
-left = std::min(left, containingBlockContentBoxRight - marginBoxWidth() + marginLeft());
-
-return left;
+return std::min(left, containingBlockContentBoxRight - marginBoxWidth() + marginLeft());
};
auto positionCandidate = horizontalPositionCandidate(horizontalConstraints);
@@ -104,6 +103,20 @@
return left;
}
+bool FloatAvoider::overflowsContainingBlock() const
+{
+auto containingBlockContentBoxLeft = m_containingBlockAbsoluteDisplayBox.left() + m_containingBlockAbsoluteDisplayBox.contentBoxLeft();
+auto left = displayBox().left() - marginLeft();
+
+if (containingBlockContentBoxLeft > left)
+return true;
+
+auto containingBlockContentBoxRight = containingBlockContentBoxLeft + m_containingBlockAbsoluteDisplayBox.contentBoxWidth();
+auto right = displayBox().right() + marginRight();
+
+return containingBlockContentBoxRight < right;
+}
+
Display::Box::Rect FloatAvoider::rectInContainingBlock() const
{
// From formatting root coordinate system back to containing block's.
Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.h (235502 => 235503)
--- trunk/Source/WebCore/layout/floats/FloatAvoider.h 2018-08-30 14:28:54 UTC (rev 235502)
+++ trunk/Source/WebCore/layout/floats/FloatAvoider.h
[webkit-changes] [235502] trunk/Source/WebCore
Title: [235502] trunk/Source/WebCore Revision 235502 Author za...@apple.com Date 2018-08-30 07:28:54 -0700 (Thu, 30 Aug 2018) Log Message [LFC][Floating] Use non-computed horizontal margins when intersecting floats with float avoiders. https://bugs.webkit.org/show_bug.cgi?id=189143 Reviewed by Antti Koivisto. * layout/Verification.cpp: (WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const): * layout/floats/FloatAvoider.cpp: (WebCore::Layout::FloatAvoider::setHorizontalConstraints): (WebCore::Layout::FloatAvoider::initialHorizontalPosition const): * layout/floats/FloatAvoider.h: (WebCore::Layout::FloatAvoider::marginTop const): (WebCore::Layout::FloatAvoider::marginBottom const): (WebCore::Layout::FloatAvoider::marginLeft const): (WebCore::Layout::FloatAvoider::marginRight const): (WebCore::Layout::FloatAvoider::marginBoxWidth const): * layout/floats/FloatBox.cpp: (WebCore::Layout::FloatBox::rect const): (WebCore::Layout::FloatBox::horizontalPositionCandidate): (WebCore::Layout::FloatBox::verticalPositionCandidate): (WebCore::Layout::FloatBox::initialVerticalPosition const): * layout/floats/FloatBox.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/floats/FloatAvoider.cpp trunk/Source/WebCore/layout/floats/FloatAvoider.h trunk/Source/WebCore/layout/floats/FloatBox.cpp trunk/Source/WebCore/layout/floats/FloatBox.h Diff Modified: trunk/Source/WebCore/ChangeLog (235501 => 235502) --- trunk/Source/WebCore/ChangeLog 2018-08-30 14:25:45 UTC (rev 235501) +++ trunk/Source/WebCore/ChangeLog 2018-08-30 14:28:54 UTC (rev 235502) @@ -1,5 +1,30 @@ 2018-08-30 Zalan Bujtas +[LFC][Floating] Use non-computed horizontal margins when intersecting floats with float avoiders. +https://bugs.webkit.org/show_bug.cgi?id=189143 + +Reviewed by Antti Koivisto. + +* layout/Verification.cpp: +(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const): +* layout/floats/FloatAvoider.cpp: +(WebCore::Layout::FloatAvoider::setHorizontalConstraints): +(WebCore::Layout::FloatAvoider::initialHorizontalPosition const): +* layout/floats/FloatAvoider.h: +(WebCore::Layout::FloatAvoider::marginTop const): +(WebCore::Layout::FloatAvoider::marginBottom const): +(WebCore::Layout::FloatAvoider::marginLeft const): +(WebCore::Layout::FloatAvoider::marginRight const): +(WebCore::Layout::FloatAvoider::marginBoxWidth const): +* layout/floats/FloatBox.cpp: +(WebCore::Layout::FloatBox::rect const): +(WebCore::Layout::FloatBox::horizontalPositionCandidate): +(WebCore::Layout::FloatBox::verticalPositionCandidate): +(WebCore::Layout::FloatBox::initialVerticalPosition const): +* layout/floats/FloatBox.h: + +2018-08-30 Zalan Bujtas + [LFC][Margins] Add non-computed horizontal margins to DisplayBox https://bugs.webkit.org/show_bug.cgi?id=189141 Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.cpp (235501 => 235502) --- trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-30 14:25:45 UTC (rev 235501) +++ trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-30 14:28:54 UTC (rev 235502) @@ -61,10 +61,9 @@ auto containingBlockContentBoxLeft = m_containingBlockAbsoluteDisplayBox.left() + m_containingBlockAbsoluteDisplayBox.contentBoxLeft(); auto containingBlockContentBoxRight = containingBlockContentBoxLeft + m_containingBlockAbsoluteDisplayBox.contentBoxWidth(); // Align it with the containing block's left edge first. -left = std::max(containingBlockContentBoxLeft + m_absoluteDisplayBox.marginLeft(), left); +left = std::max(containingBlockContentBoxLeft + marginLeft(), left); // Make sure it does not overflow the containing block on the right. -auto marginBoxSize = m_absoluteDisplayBox.marginBox().width(); -left = std::min(left, containingBlockContentBoxRight - marginBoxSize + m_absoluteDisplayBox.marginLeft()); +left = std::min(left, containingBlockContentBoxRight - marginBoxWidth() + marginLeft()); return left; }; @@ -99,8 +98,8 @@ auto containingBlockContentBoxLeft = m_containingBlockAbsoluteDisplayBox.left() + m_containingBlockAbsoluteDisplayBox.contentBoxLeft(); auto containingBlockContentBoxRight = containingBlockContentBoxLeft + m_containingBlockAbsoluteDisplayBox.contentBoxWidth(); -auto left = isLeftAligned() ? containingBlockContentBoxLeft : containingBlockContentBoxRight - m_absoluteDisplayBox.marginBox().width(); -left += m_absoluteDisplayBox.marginLeft(); +auto left = isLeftAligned() ? containingBlockContentBoxLeft : containingBlockContentBoxRight - marginBoxWidth(); +left += marginLeft(); return left; } Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.h (235501 => 235502) ---
[webkit-changes] [235501] trunk/Source/WebCore
Title: [235501] trunk/Source/WebCore Revision 235501 Author za...@apple.com Date 2018-08-30 07:25:45 -0700 (Thu, 30 Aug 2018) Log Message [LFC][Margins] Add non-computed horizontal margins to DisplayBox https://bugs.webkit.org/show_bug.cgi?id=189141 Reviewed by Antti Koivisto. Inflow block boxes' horizontal margins extend all the way to the left/right edge of their containing block. See https://www.w3.org/TR/CSS22/visudet.html#blockwidth for example "... 10.3.3 Block-level, non-replaced elements in normal flow 'margin-left' + 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' + 'margin-right' = width of containing block ..." In certain cases (float avoiding) we need to know the original (non-extended) horiztonal margin values. * layout/FormattingContext.cpp: (WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const): (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const): * layout/FormattingContextGeometry.cpp: (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry): (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry): (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin): (WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin): * layout/LayoutContext.cpp: (WebCore::Layout::LayoutContext::initializeRoot): * layout/LayoutUnits.h: * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::computeInFlowWidthAndMargin const): * layout/blockformatting/BlockFormattingContextGeometry.cpp: (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin): (WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin): * layout/displaytree/DisplayBox.h: (WebCore::Display::Box::setHasValidHorizontalNonComputedMargin): (WebCore::Display::Box::setHorizontalNonComputedMargin): (WebCore::Display::Box::nonComputedMarginLeft const): (WebCore::Display::Box::nonComputedMarginRight const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/FormattingContext.cpp trunk/Source/WebCore/layout/FormattingContextGeometry.cpp trunk/Source/WebCore/layout/LayoutContext.cpp trunk/Source/WebCore/layout/LayoutUnits.h trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp trunk/Source/WebCore/layout/displaytree/DisplayBox.cpp trunk/Source/WebCore/layout/displaytree/DisplayBox.h Diff Modified: trunk/Source/WebCore/ChangeLog (235500 => 235501) --- trunk/Source/WebCore/ChangeLog 2018-08-30 14:21:42 UTC (rev 235500) +++ trunk/Source/WebCore/ChangeLog 2018-08-30 14:25:45 UTC (rev 235501) @@ -1,3 +1,41 @@ +2018-08-30 Zalan Bujtas + +[LFC][Margins] Add non-computed horizontal margins to DisplayBox +https://bugs.webkit.org/show_bug.cgi?id=189141 + +Reviewed by Antti Koivisto. + +Inflow block boxes' horizontal margins extend all the way to the left/right edge of their containing block. +See https://www.w3.org/TR/CSS22/visudet.html#blockwidth for example +"... +10.3.3 Block-level, non-replaced elements in normal flow +'margin-left' + 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' + 'margin-right' = width of containing block +..." + +In certain cases (float avoiding) we need to know the original (non-extended) horiztonal margin values. + +* layout/FormattingContext.cpp: +(WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const): +(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const): +* layout/FormattingContextGeometry.cpp: +(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry): +(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry): +(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin): +(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin): +* layout/LayoutContext.cpp: +(WebCore::Layout::LayoutContext::initializeRoot): +* layout/LayoutUnits.h: +* layout/blockformatting/BlockFormattingContext.cpp: +(WebCore::Layout::BlockFormattingContext::computeInFlowWidthAndMargin const): +* layout/blockformatting/BlockFormattingContextGeometry.cpp: +(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin): +(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin): +* layout/displaytree/DisplayBox.h: +(WebCore::Display::Box::setHasValidHorizontalNonComputedMargin): +(WebCore::Display::Box::setHorizontalNonComputedMargin): +(WebCore::Display::Box::nonComputedMarginLeft const): +
[webkit-changes] [235500] trunk/Tools
Title: [235500] trunk/Tools
Revision 235500
Author mcatanz...@igalia.com
Date 2018-08-30 07:21:42 -0700 (Thu, 30 Aug 2018)
Log Message
Unreviewed, rolling out r235114.
ostree server deleted our commits?
Reverted changeset:
"[Flatpak] Update to GNOME master runtime"
https://bugs.webkit.org/show_bug.cgi?id=188731
https://trac.webkit.org/changeset/235114
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
trunk/Tools/flatpak/org.webkit.GTK.yaml
trunk/Tools/flatpak/org.webkit.WebKit.yaml
Added Paths
trunk/Tools/flatpak/files/httpd-autogen.sh
trunk/Tools/flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch
trunk/Tools/flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch
Diff
Modified: trunk/Tools/ChangeLog (235499 => 235500)
--- trunk/Tools/ChangeLog 2018-08-30 14:01:49 UTC (rev 235499)
+++ trunk/Tools/ChangeLog 2018-08-30 14:21:42 UTC (rev 235500)
@@ -1,3 +1,15 @@
+2018-08-30 Michael Catanzaro
+
+Unreviewed, rolling out r235114.
+
+ostree server deleted our commits?
+
+Reverted changeset:
+
+"[Flatpak] Update to GNOME master runtime"
+https://bugs.webkit.org/show_bug.cgi?id=188731
+https://trac.webkit.org/changeset/235114
+
2018-08-29 Myles C. Maxfield
[WHLSL] Test row-majorness of matrices
Added: trunk/Tools/flatpak/files/httpd-autogen.sh (0 => 235500)
--- trunk/Tools/flatpak/files/httpd-autogen.sh (rev 0)
+++ trunk/Tools/flatpak/files/httpd-autogen.sh 2018-08-30 14:21:42 UTC (rev 235500)
@@ -0,0 +1 @@
+autoreconf
\ No newline at end of file
Property changes on: trunk/Tools/flatpak/files/httpd-autogen.sh
___
Added: svn:executable
+*
\ No newline at end of property
Modified: trunk/Tools/flatpak/flatpakutils.py (235499 => 235500)
--- trunk/Tools/flatpak/flatpakutils.py 2018-08-30 14:01:49 UTC (rev 235499)
+++ trunk/Tools/flatpak/flatpakutils.py 2018-08-30 14:21:42 UTC (rev 235500)
@@ -612,9 +612,9 @@
repos = FlatpakRepos()
self.sdk_repo = repos.add(
-FlatpakRepo("gnome-nightly",
-url=""
-repo_file="https://sdk.gnome.org/gnome-nightly.flatpakrepo"))
+FlatpakRepo("flathub",
+url=""
+repo_file="https://dl.flathub.org/repo/flathub.flatpakrepo"))
manifest = load_manifest(self.manifest_path)
if not manifest:
Modified: trunk/Tools/flatpak/org.webkit.GTK.yaml (235499 => 235500)
--- trunk/Tools/flatpak/org.webkit.GTK.yaml 2018-08-30 14:01:49 UTC (rev 235499)
+++ trunk/Tools/flatpak/org.webkit.GTK.yaml 2018-08-30 14:21:42 UTC (rev 235500)
@@ -1,8 +1,8 @@
- name: mesa
sources:
- type: archive
- url: https://mesa.freedesktop.org/archive/mesa-18.0.5.tar.xz
- sha256: 5187bba8d72aea78f2062d134ec6079a508e8216062dce9ec9048b5eb2c4fc6b
+ url: https://mesa.freedesktop.org/archive/mesa-18.0.3.tar.xz
+ sha256: 099d9667327a76a61741a533f95067d76ea71a656e66b91507b3c0caf1d49e30
config-opts:
- --prefix=/app/softGL
- --disable-dri3
Modified: trunk/Tools/flatpak/org.webkit.WebKit.yaml (235499 => 235500)
--- trunk/Tools/flatpak/org.webkit.WebKit.yaml 2018-08-30 14:01:49 UTC (rev 235499)
+++ trunk/Tools/flatpak/org.webkit.WebKit.yaml 2018-08-30 14:21:42 UTC (rev 235500)
@@ -1,14 +1,14 @@
app-id: %(PORTNAME)s
runtime: org.gnome.Platform
-runtime-version: "master"
+runtime-version: "3.28"
# Control the exact version of the Sdk/Runtime that is being used.
-sdk-hash: 381c97c2d71033d9b09b15da363af75a49500b691245396adbc85ddca548410c
-runtime-hash: 235289b568ff0fe78771eeae45562c1415104821abbffe6559380aae58f06c58
+sdk-hash: cea71fe86d6961b4fe58046170f8dc8f8d4d04141ddf211e7cc6db44a18a0c49
+runtime-hash: 9785cf7dc62290d76eef4bf0f5d25240fc5bb3d73128c25e95c4e4cb90bb3560
sdk: org.gnome.Sdk
command: %(COMMAND)s
finish-args:
# Basically no sandboxing, the goal here is to make it flexible
- # for developers, not really to isolate (opening all devices
+ # for developers, not really to isolate (openning all devices
# to allow acces video cameras until we have a portal at least).
- --share=ipc
- --socket=x11
@@ -42,14 +42,21 @@
- --with-apr=/app/bin/apr-1-config
- name: httpd
sources:
- - type: archive
-url: http://mirror.metrocast.net/apache//httpd/httpd-2.4.34.tar.gz
-sha256: 6eaef0313b071d105eb3ca49289fc0f1431392e1061e1df420ca5775caed2211
+ - type: git
+url: https://github.com/apache/httpd.git
+branch: 2.4.33
+ - type : file
+path : files/httpd-autogen.sh
+dest-filename : autogen.sh
+ # The version embedded in the sandbox doesn't have a working pcre-config
+ - type: patch
+path: patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch
config-opts:
-
[webkit-changes] [235498] trunk/Source/WebCore
Title: [235498] trunk/Source/WebCore
Revision 235498
Author yusukesuz...@slowstart.org
Date 2018-08-30 03:24:15 -0700 (Thu, 30 Aug 2018)
Log Message
Unreviewed, add comments about enum names to bitfields
https://bugs.webkit.org/show_bug.cgi?id=188944
* xml/XMLHttpRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (235497 => 235498)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 10:17:36 UTC (rev 235497)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 10:24:15 UTC (rev 235498)
@@ -1,6 +1,13 @@
2018-08-30 Yusuke Suzuki
Unreviewed, add comments about enum names to bitfields
+https://bugs.webkit.org/show_bug.cgi?id=188944
+
+* xml/XMLHttpRequest.h:
+
+2018-08-30 Yusuke Suzuki
+
+Unreviewed, add comments about enum names to bitfields
https://bugs.webkit.org/show_bug.cgi?id=188945
* html/HTMLCollection.h:
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.h (235497 => 235498)
--- trunk/Source/WebCore/xml/XMLHttpRequest.h 2018-08-30 10:17:36 UTC (rev 235497)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.h 2018-08-30 10:24:15 UTC (rev 235498)
@@ -199,8 +199,8 @@
unsigned m_wasAbortedByClient : 1;
unsigned m_responseCacheIsValid : 1;
unsigned m_dispatchErrorOnResuming : 1;
-unsigned m_readyState : 3;
-unsigned m_responseType : 3;
+unsigned m_readyState : 3; // State
+unsigned m_responseType : 3; // ResponseType
unsigned m_timeoutMilliseconds { 0 };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235497] trunk/Source/WebCore
Title: [235497] trunk/Source/WebCore Revision 235497 Author yusukesuz...@slowstart.org Date 2018-08-30 03:17:36 -0700 (Thu, 30 Aug 2018) Log Message Unreviewed, add comments about enum names to bitfields https://bugs.webkit.org/show_bug.cgi?id=188945 * html/HTMLCollection.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLCollection.h Diff Modified: trunk/Source/WebCore/ChangeLog (235496 => 235497) --- trunk/Source/WebCore/ChangeLog 2018-08-30 05:05:19 UTC (rev 235496) +++ trunk/Source/WebCore/ChangeLog 2018-08-30 10:17:36 UTC (rev 235497) @@ -1,3 +1,10 @@ +2018-08-30 Yusuke Suzuki + +Unreviewed, add comments about enum names to bitfields +https://bugs.webkit.org/show_bug.cgi?id=188945 + +* html/HTMLCollection.h: + 2018-08-29 Andy Estes Addressed additional review feedback after r235342. Modified: trunk/Source/WebCore/html/HTMLCollection.h (235496 => 235497) --- trunk/Source/WebCore/html/HTMLCollection.h 2018-08-30 05:05:19 UTC (rev 235496) +++ trunk/Source/WebCore/html/HTMLCollection.h 2018-08-30 10:17:36 UTC (rev 235497) @@ -103,9 +103,9 @@ mutable Lock m_namedElementCacheAssignmentLock; -const unsigned m_collectionType : 5; -const unsigned m_invalidationType : 4; -const unsigned m_rootType : 1; +const unsigned m_collectionType : 5; // CollectionType +const unsigned m_invalidationType : 4; // NodeListInvalidationType +const unsigned m_rootType : 1; // RootType Ref m_ownerNode; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
