[webkit-changes] [236958] trunk/Tools
Title: [236958] trunk/Tools
Revision 236958
Author wenson_hs...@apple.com
Date 2018-10-08 20:28:31 -0700 (Mon, 08 Oct 2018)
Log Message
[macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
https://bugs.webkit.org/show_bug.cgi?id=190386
Reviewed by Ryosuke Niwa.
Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
of macOS.
* TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm
Diff
Modified: trunk/Tools/ChangeLog (236957 => 236958)
--- trunk/Tools/ChangeLog 2018-10-09 02:37:24 UTC (rev 236957)
+++ trunk/Tools/ChangeLog 2018-10-09 03:28:31 UTC (rev 236958)
@@ -1,5 +1,19 @@
2018-10-08 Wenson Hsieh
+[macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
+https://bugs.webkit.org/show_bug.cgi?id=190386
+
+Reviewed by Ryosuke Niwa.
+
+Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
+Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
+of macOS.
+
+* TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
+(TEST):
+
+2018-10-08 Wenson Hsieh
+
[Cocoa] [WK2] Add support for text alignment and text lists in font attributes
https://bugs.webkit.org/show_bug.cgi?id=190342
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm (236957 => 236958)
--- trunk/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm 2018-10-09 02:37:24 UTC (rev 236957)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm 2018-10-09 03:28:31 UTC (rev 236958)
@@ -78,7 +78,7 @@
{
NSPasteboard *pasteboard = [NSPasteboard pasteboardWithUniqueName];
[pasteboard declareTypes:@[NSColorPboardType] owner:nil];
-[[NSColor redColor] writeToPasteboard:pasteboard];
+[[NSColor colorWithRed:1 green:0 blue:0 alpha:1] writeToPasteboard:pasteboard];
auto simulator = adoptNS([[DragAndDropSimulator alloc] initWithWebViewFrame:NSMakeRect(0, 0, 400, 400)]);
TestWKWebView *webView = [simulator webView];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236957] trunk/LayoutTests
Title: [236957] trunk/LayoutTests
Revision 236957
Author drou...@apple.com
Date 2018-10-08 19:37:24 -0700 (Mon, 08 Oct 2018)
Log Message
Fix inspector/canvas/recording.html after r236952
Unreviewed. Test gardening.
* inspector/canvas/recording-expected.txt:
* inspector/canvas/recording.html:
Recordings default to only capturing a single frame, so add a parameter to ensure that we
are capturing multiple frames.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/canvas/recording-expected.txt
trunk/LayoutTests/inspector/canvas/recording.html
Diff
Modified: trunk/LayoutTests/ChangeLog (236956 => 236957)
--- trunk/LayoutTests/ChangeLog 2018-10-09 02:17:42 UTC (rev 236956)
+++ trunk/LayoutTests/ChangeLog 2018-10-09 02:37:24 UTC (rev 236957)
@@ -1,3 +1,14 @@
+2018-10-08 Devin Rousso
+
+Fix inspector/canvas/recording.html after r236952
+
+Unreviewed. Test gardening.
+
+* inspector/canvas/recording-expected.txt:
+* inspector/canvas/recording.html:
+Recordings default to only capturing a single frame, so add a parameter to ensure that we
+are capturing multiple frames.
+
2018-10-08 Wenson Hsieh
[Cocoa] [WK2] Add support for text alignment and text lists in font attributes
Modified: trunk/LayoutTests/inspector/canvas/recording-expected.txt (236956 => 236957)
--- trunk/LayoutTests/inspector/canvas/recording-expected.txt 2018-10-09 02:17:42 UTC (rev 236956)
+++ trunk/LayoutTests/inspector/canvas/recording-expected.txt 2018-10-09 02:37:24 UTC (rev 236957)
@@ -15,8 +15,6 @@
PASS: There should be a recording for canvas 2.
-- Running test case: Canvas.startRecording.InvalidCanvasId
-ERROR: No active recording for canvas
-ERROR: No active recording for canvas
PASS: Should produce an error.
Error: No canvas for given identifier.
Modified: trunk/LayoutTests/inspector/canvas/recording.html (236956 => 236957)
--- trunk/LayoutTests/inspector/canvas/recording.html 2018-10-09 02:17:42 UTC (rev 236956)
+++ trunk/LayoutTests/inspector/canvas/recording.html 2018-10-09 02:37:24 UTC (rev 236957)
@@ -20,6 +20,8 @@
name: "Canvas.multipleRecording",
description: "Check that multiple recordings are able to be started/stopped at the same time.",
test(resolve, reject) {
+const singleFrame = false;
+
let canvases = WI.canvasManager.canvases;
InspectorTest.assert(canvases.length === 2, "There should be two canvas contexts.");
@@ -58,11 +60,11 @@
InspectorTest.expectThat(canvases[0].recordingActive, "Recording started of canvas 1");
InspectorTest.log("Starting a recording of canvas 2...");
-canvases[1].startRecording();
+canvases[1].startRecording(singleFrame);
});
InspectorTest.log("Starting a recording of canvas 1...");
-canvases[0].startRecording();
+canvases[0].startRecording(singleFrame);
},
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236956] trunk/Websites/perf.webkit.org
Title: [236956] trunk/Websites/perf.webkit.org
Revision 236956
Author rn...@webkit.org
Date 2018-10-08 19:17:42 -0700 (Mon, 08 Oct 2018)
Log Message
/api/report takes 15+ minutes submitting some test results
https://bugs.webkit.org/show_bug.cgi?id=190382
Rubber-stamped by Alexey Proskuryakov and unofficially reviewed by Dewei Zhu.
The issue was that recursively_ensure_tests would issue thousands of dependent queries.
Since most reporting of results would be happening after all the tests and test metrics had been created,
simply fetch the list of all tests and test metrics upfront in memory.
This would slow-down the reporting of other test results but in practice doesn't matter (an extra few seconds
of overhead) but for slow reporting, it can significantly reduce the runtime from ~10 minutes to ~10 seconds.
* public/include/report-processor.php:
(ReportProcessor::process): Call fetch_tests before recursively_ensure_tests.
(ReportProcessor::fetch_tests): Added. This builds up a mapping of tests based on a parent test ID as well as
a mapping of metrics per test based on its name and then its aggregator's name.
(ReportProcessor::recursively_ensure_tests): Added. Use the in-memory maps built in fetch_tests when possible.
(ReportProcessor::aggregator_list_if_exists): Take a reference instead of passing it by value.
(TestRunsGenerator::add_aggregated_metric): Now takes metric ID. The code to add the test metric had been moved
to recursively_ensure_tests.
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/report-processor.php
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (236955 => 236956)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-10-09 01:52:49 UTC (rev 236955)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-10-09 02:17:42 UTC (rev 236956)
@@ -1,3 +1,27 @@
+2018-10-08 Ryosuke Niwa
+
+/api/report takes 15+ minutes submitting some test results
+https://bugs.webkit.org/show_bug.cgi?id=190382
+
+Rubber-stamped by Alexey Proskuryakov and unofficially reviewed by Dewei Zhu.
+
+The issue was that recursively_ensure_tests would issue thousands of dependent queries.
+
+Since most reporting of results would be happening after all the tests and test metrics had been created,
+simply fetch the list of all tests and test metrics upfront in memory.
+
+This would slow-down the reporting of other test results but in practice doesn't matter (an extra few seconds
+of overhead) but for slow reporting, it can significantly reduce the runtime from ~10 minutes to ~10 seconds.
+
+* public/include/report-processor.php:
+(ReportProcessor::process): Call fetch_tests before recursively_ensure_tests.
+(ReportProcessor::fetch_tests): Added. This builds up a mapping of tests based on a parent test ID as well as
+a mapping of metrics per test based on its name and then its aggregator's name.
+(ReportProcessor::recursively_ensure_tests): Added. Use the in-memory maps built in fetch_tests when possible.
+(ReportProcessor::aggregator_list_if_exists): Take a reference instead of passing it by value.
+(TestRunsGenerator::add_aggregated_metric): Now takes metric ID. The code to add the test metric had been moved
+to recursively_ensure_tests.
+
2018-10-01 Dewei Zhu
Add retry for test groups with failed build requests.
Modified: trunk/Websites/perf.webkit.org/public/include/report-processor.php (236955 => 236956)
--- trunk/Websites/perf.webkit.org/public/include/report-processor.php 2018-10-09 01:52:49 UTC (rev 236955)
+++ trunk/Websites/perf.webkit.org/public/include/report-processor.php 2018-10-09 02:17:42 UTC (rev 236956)
@@ -38,6 +38,7 @@
$this->ensure_aggregators();
+$this->fetch_tests();
$this->runs = new TestRunsGenerator($this->db, $this->name_to_aggregator_id, $this->report_id);
$this->recursively_ensure_tests($report['tests']);
@@ -186,10 +187,38 @@
$this->exit_with_error($message, $details);
}
+private function fetch_tests() {
+$test_rows = $this->db->fetch_table('tests');
+$tests = array();
+$test_by_id = array();
+foreach ($test_rows as &$test) {
+$test_by_id[$test['test_id']] = &$test;
+$test['metrics'] = array();
+$parent_id = $test['test_parent'];
+if ($parent_id == NULL)
+$parent_id = 0;
+$parent_array = _ensure_item_has_array($tests, $parent_id);
+$parent_array[$test['test_name']] = &$test;
+}
+$this->tests = &$tests;
+
+$metric_rows = $this->db->fetch_table('test_metrics');
+foreach ($metric_rows as &$metric) {
+$test = &$test_by_id[$metric['metric_test']];
+$metrics_by_name = _ensure_item_has_array($test['metrics'], $metric['metric_name']);
+
[webkit-changes] [236955] trunk
Title: [236955] trunk
Revision 236955
Author wenson_hs...@apple.com
Date 2018-10-08 18:52:49 -0700 (Mon, 08 Oct 2018)
Log Message
[Cocoa] [WK2] Add support for text alignment and text lists in font attributes
https://bugs.webkit.org/show_bug.cgi?id=190342
Reviewed by Tim Horton.
Source/WebCore:
Adds support for computing and encoding information about text alignment and enclosing list elements in the font
attributes dictionary, exposed to the UI delegate on Cocoa platforms. This is exposed through NSParagraphStyle,
which contains properties for both `NSTextAlignment` and an array of enclosing `NSTextList` objects.
Test: FontAttributes.NestedTextListsWithHorizontalAlignment
FontAttributes.FontAttributesAfterChangingSelection
* editing/Editor.cpp:
(WebCore::editableTextListsAtPositionInDescendingOrder):
Add a helper function to ascend the DOM, starting at the given position, in search of enclosing list elements.
For each enclosing list element we find within the scope of the editable root, we create a `TextList`
representing the list element.
(WebCore::Editor::fontAttributesAtSelectionStart const):
Compute and set enclosing text lists and text alignment. For text alignment, we convert the initial text-align
value, `start`, to NSTextAlignmentNatural (the default text alignment type on Cocoa platforms); other values
then map to Left, Right, Center, and Justified as expected (taking direction into account).
* editing/FontAttributes.h:
(WebCore::TextList::encode const):
(WebCore::TextList::decode):
Introduce TextList, a platform-agnostic representation of an unordered or ordered list. On Cocoa, this can be
used to construct a corresponding NSTextList.
* editing/cocoa/FontAttributesCocoa.mm:
(WebCore::cocoaTextListMarkerName):
Attempt to map a WebCore list style type to a `NSTextListMarker*` constant. While most of the Cocoa marker
formats have a corresponding web-exposed list style type, many web-exposed types have no Cocoa equivalent; as
such, fall back to default marker formats: "{disc}" for unordered lists and "{decimal}" for ordered lists.
(WebCore::TextList::createTextList const):
(WebCore::FontAttributes::createDictionary const):
Include an NSParagraphStyle in the dictionary of font attributes that includes information about text alignment
and enclosing text lists (per Cocoa convention, in order from outermost list to innermost list).
Source/WebCore/PAL:
* pal/ios/UIKitSoftLink.h:
* pal/ios/UIKitSoftLink.mm:
Add NSParagraphStyle and NSTextList to the UIKit soft link header.
* pal/spi/cocoa/NSAttributedStringSPI.h:
* pal/spi/ios/UIKitSPI.h:
Add some SPI declarations for NSMutableParagraphStyle and NSTextList when building with a non-internal iOS SDK,
and import and when building with an internal iOS SDK.
Additionally, define some internal UIFoundation string constants that denote NSTextList marker formats. These
constants are API on macOS, but are neither exposed as API nor SPI on iOS.
Source/WebKit:
Add encoding and decoding for text alignment and text lists in FontAttributes.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
moving the selection around text inside nested list elements.
(TestWebKitAPI::checkParagraphStyles):
Add a new helper to check an NSParagraphStyle against expected results.
(TestWebKitAPI::webViewForTestingFontAttributes):
Allow each test to pass in the name of the test page to load.
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
* TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
LayoutTests:
* editing/mac/attributed-string/attributed-string-for-typing-expected.txt:
* editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt:
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-for-typing-expected.txt:
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt:
Rebaseline these two layout tests, now that typing attributes include an NSParagraphStyle.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/mac/attributed-string/attributed-string-for-typing-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt
trunk/LayoutTests/platform/mac-sierra/editing/mac/attributed-string/attributed-string-for-typing-expected.txt
trunk/LayoutTests/platform/mac-sierra/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt
[webkit-changes] [236953] trunk/Source/WebInspectorUI
Title: [236953] trunk/Source/WebInspectorUI
Revision 236953
Author drou...@apple.com
Date 2018-10-08 17:19:40 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: Dark Mode: canvas recording glyph is black on gray
https://bugs.webkit.org/show_bug.cgi?id=190367
Reviewed by Joseph Pecoraro.
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview .content-view.canvas > footer .view-recording): Added.
(.content-view.canvas-overview .content-view.canvas > footer > .recordings::before): Deleted.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236952 => 236953)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-09 00:14:52 UTC (rev 236952)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-09 00:19:40 UTC (rev 236953)
@@ -1,5 +1,17 @@
2018-10-08 Devin Rousso
+Web Inspector: Dark Mode: canvas recording glyph is black on gray
+https://bugs.webkit.org/show_bug.cgi?id=190367
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/CanvasOverviewContentView.css:
+(.content-view.canvas-overview .content-view.canvas > footer .view-recording): Added.
+(.content-view.canvas-overview .content-view.canvas > footer > .recordings::before): Deleted.
+
+2018-10-08 Devin Rousso
+
Web Inspector: allow multiple canvases to be recorded at the same time
https://bugs.webkit.org/show_bug.cgi?id=190305
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css (236952 => 236953)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css 2018-10-09 00:14:52 UTC (rev 236952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css 2018-10-09 00:19:40 UTC (rev 236953)
@@ -214,7 +214,7 @@
color: var(--text-color-secondary);
}
-.content-view.canvas-overview .content-view.canvas > footer > .recordings::before {
+.content-view.canvas-overview .content-view.canvas > footer .view-recording {
filter: invert();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236952] trunk
Title: [236952] trunk Revision 236952 Author drou...@apple.com Date 2018-10-08 17:14:52 -0700 (Mon, 08 Oct 2018) Log Message Web Inspector: allow multiple canvases to be recorded at the same time https://bugs.webkit.org/show_bug.cgi?id=190305 Reviewed by Brian Burg. Source/WebInspectorUI: Moved the logic for maintaining whether a canvas is actively recording from `WI.CanvasManager` to `WI.Canvas`, meaning that each canvas can now record independently of every other canvas in the page. If multiple recordings are all finished simultaneously, only show the first one to be recieved by the frontend. * UserInterface/Controllers/CanvasManager.js: (WI.CanvasManager): (WI.CanvasManager.prototype.recordingProgress): (WI.CanvasManager.prototype.recordingFinished): (WI.CanvasManager.prototype.programCreated): (WI.CanvasManager.prototype.programDeleted): (WI.CanvasManager.prototype._removeCanvas): (WI.CanvasManager.prototype._mainResourceDidChange): (WI.CanvasManager.prototype.get recordingCanvas): Deleted. (WI.CanvasManager.prototype.startRecording): Deleted. (WI.CanvasManager.prototype.stopRecording): Deleted. (WI.CanvasManager.prototype._dispatchShaderProgramRemoved): Deleted. * UserInterface/Models/Canvas.js: (WI.Canvas.prototype.get recordingFrameCount): Added. (WI.Canvas.prototype.get recordingBufferUsed): Added. (WI.Canvas.prototype.get recordingActive): Added. (WI.Canvas.prototype.get isRecording): Deleted. (WI.Canvas.prototype.startRecording): Added. (WI.Canvas.prototype.stopRecording): Added. (WI.Canvas.prototype.recordingProgress): Added. (WI.Canvas.prototype.recordingFinished): Added. * UserInterface/Views/CanvasTabContentView.js: (WI.CanvasTabContentView.prototype.attached): (WI.CanvasTabContentView.prototype.detached): (WI.CanvasTabContentView.prototype._recordingImportedOrStopped): (WI.CanvasTabContentView.prototype._handleSpace): (WI.CanvasTabContentView): * UserInterface/Views/CanvasOverviewContentView.css: (.content-view.canvas-overview .content-view.canvas.recording-active): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header > .titles > .title): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header > .titles > .subtitle): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header > .navigation-bar > .item): Added. (.content-view.canvas-overview .content-view.canvas:matches(:hover, .recording-active) > header > .navigation-bar): Added. (.content-view.canvas-overview .content-view.canvas:not(.recording-active) > header > .navigation-bar > .item.record-start-stop.disabled): Added. (.content-view.canvas-overview .content-view.canvas:not(.recording-active) > header > .navigation-bar > .item.record-start-stop:not(.disabled):hover): Added. (.content-view.canvas-overview .content-view.canvas:not(.recording-active) > header > .navigation-bar > .item.record-start-stop:not(.disabled):active): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > .progress-vie): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > .preview): Added. (.content-view.canvas-overview .content-view.canvas.recording-active): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header): Added. (.content-view.canvas-overview .content-view.canvas.recording-active > header > .titles > .subtitle): Added. (.content-view.canvas-overview .content-view.canvas.is-recording): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header > .titles > .title): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header > .titles > .subtitle): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header > .navigation-bar > .item): Deleted. (.content-view.canvas-overview .content-view.canvas:matches(:hover, .is-recording) > header > .navigation-bar): Deleted. (.content-view.canvas-overview .content-view.canvas:not(.is-recording) > header > .navigation-bar > .item.record-start-stop.disabled): Deleted. (.content-view.canvas-overview .content-view.canvas:not(.is-recording) > header > .navigation-bar > .item.record-start-stop:not(.disabled):hover): Deleted. (.content-view.canvas-overview .content-view.canvas:not(.is-recording) > header > .navigation-bar > .item.record-start-stop:not(.disabled):active): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > .progress-vie): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > .preview): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header): Deleted. (.content-view.canvas-overview .content-view.canvas.is-recording > header > .titles > .subtitle):
[webkit-changes] [236951] trunk/Source/WebKit
Title: [236951] trunk/Source/WebKit Revision 236951 Author wenson_hs...@apple.com Date 2018-10-08 17:11:54 -0700 (Mon, 08 Oct 2018) Log Message Followup to r236942: Make input type=color an internal feature https://bugs.webkit.org/show_bug.cgi?id=189162 Rubber-stamped by Dean Jackson. I've learned from Dean that an internal feature is more suitable than an experimental feature in this scenario. * Shared/WebPreferences.yaml: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: trunk/Source/WebKit/ChangeLog (236950 => 236951) --- trunk/Source/WebKit/ChangeLog 2018-10-09 00:07:24 UTC (rev 236950) +++ trunk/Source/WebKit/ChangeLog 2018-10-09 00:11:54 UTC (rev 236951) @@ -1,3 +1,14 @@ +2018-10-08 Wenson Hsieh + +Followup to r236942: Make input type=color an internal feature +https://bugs.webkit.org/show_bug.cgi?id=189162 + +Rubber-stamped by Dean Jackson. + +I've learned from Dean that an internal feature is more suitable than an experimental feature in this scenario. + +* Shared/WebPreferences.yaml: + 2018-10-08 Aditya Keerthi Make a runtime enabled (on-by-default) feature Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (236950 => 236951) --- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-10-09 00:07:24 UTC (rev 236950) +++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-10-09 00:11:54 UTC (rev 236951) @@ -1392,6 +1392,6 @@ defaultValue: true humanReadableName: "Color Inputs" humanReadableDescription: "Enable input elements of type color" - category: experimental + category: internal webcoreBinding: RuntimeEnabledFeatures condition: ENABLE(INPUT_TYPE_COLOR) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236950] trunk/Source/WebInspectorUI
Title: [236950] trunk/Source/WebInspectorUI
Revision 236950
Author drou...@apple.com
Date 2018-10-08 17:07:24 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: replace Range.svg icon
https://bugs.webkit.org/show_bug.cgi?id=190372
Reviewed by Joseph Pecoraro.
* UserInterface/Images/Range.svg:
* UserInterface/Images/RangeLarge.svg: Added.
* UserInterface/Models/Resource.js:
(WI.Resource.classNameForResource): Added.
Create a static function for specializing the `className` of `WI.Resource` objects.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateNameCell):
* UserInterface/Views/ResourceTreeElement.js:
(WI.ResourceTreeElement):
* UserInterface/Views/ResourceIcons.css:
(.resource-icon.resource-type-ping .icon, .resource-icon.resource-type-beacon .icon, .large .resource-icon.resource-type-ping .icon, .large .resource-icon.resource-type-beacon .icon):
(.resource-icon.resource-type-range .icon):
(.large .resource-icon.resource-type-range .icon): Added.
Drive-by: added `.large` versions of `ping` and `beacon` icons for the
`WI.OpenResourceDialog` elements.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Images/Range.svg
trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js
Added Paths
trunk/Source/WebInspectorUI/UserInterface/Images/RangeLarge.svg
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236949 => 236950)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 23:20:34 UTC (rev 236949)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-09 00:07:24 UTC (rev 236950)
@@ -1,5 +1,32 @@
2018-10-08 Devin Rousso
+Web Inspector: replace Range.svg icon
+https://bugs.webkit.org/show_bug.cgi?id=190372
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Images/Range.svg:
+* UserInterface/Images/RangeLarge.svg: Added.
+
+* UserInterface/Models/Resource.js:
+(WI.Resource.classNameForResource): Added.
+Create a static function for specializing the `className` of `WI.Resource` objects.
+
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype._populateNameCell):
+
+* UserInterface/Views/ResourceTreeElement.js:
+(WI.ResourceTreeElement):
+
+* UserInterface/Views/ResourceIcons.css:
+(.resource-icon.resource-type-ping .icon, .resource-icon.resource-type-beacon .icon, .large .resource-icon.resource-type-ping .icon, .large .resource-icon.resource-type-beacon .icon):
+(.resource-icon.resource-type-range .icon):
+(.large .resource-icon.resource-type-range .icon): Added.
+Drive-by: added `.large` versions of `ping` and `beacon` icons for the
+`WI.OpenResourceDialog` elements.
+
+2018-10-08 Devin Rousso
+
Web Inspector: group media network entries by the node that triggered the request
https://bugs.webkit.org/show_bug.cgi?id=189606
Modified: trunk/Source/WebInspectorUI/UserInterface/Images/Range.svg (236949 => 236950)
--- trunk/Source/WebInspectorUI/UserInterface/Images/Range.svg 2018-10-08 23:20:34 UTC (rev 236949)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Range.svg 2018-10-09 00:07:24 UTC (rev 236950)
@@ -1,8 +1,43 @@
-
+
-
-
-
-
+
+.text {
+color: hsl(0, 0%, 30%);
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/Source/WebInspectorUI/UserInterface/Images/RangeLarge.svg (0 => 236950)
--- trunk/Source/WebInspectorUI/UserInterface/Images/RangeLarge.svg (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/RangeLarge.svg 2018-10-09 00:07:24 UTC (rev 236950)
@@ -0,0 +1,36 @@
+
+
+
+
+.text {
+color: hsl(0, 0%, 30%);
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (236949 => 236950)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2018-10-08 23:20:34 UTC (rev 236949)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2018-10-09 00:07:24 UTC (rev 236950)
@@ -174,6 +174,15 @@
}
}
+static classNameForResource(resource)
+{
+if (resource.type === WI.Resource.Type.Other) {
+if
[webkit-changes] [236948] tags/Safari-607.1.10/Source/WebCore/PAL
Title: [236948] tags/Safari-607.1.10/Source/WebCore/PAL Revision 236948 Author kocsen_ch...@apple.com Date 2018-10-08 16:20:26 -0700 (Mon, 08 Oct 2018) Log Message Revert r236876. rdar://problem/45109065 Modified Paths tags/Safari-607.1.10/Source/WebCore/PAL/ChangeLog tags/Safari-607.1.10/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h Diff Modified: tags/Safari-607.1.10/Source/WebCore/PAL/ChangeLog (236947 => 236948) --- tags/Safari-607.1.10/Source/WebCore/PAL/ChangeLog 2018-10-08 23:20:23 UTC (rev 236947) +++ tags/Safari-607.1.10/Source/WebCore/PAL/ChangeLog 2018-10-08 23:20:26 UTC (rev 236948) @@ -1,3 +1,7 @@ +2018-10-08 Kocsen Chung + +Revert r236876. rdar://problem/45109065 + 2018-10-05 Jer Noble Unreviewed build fix: internal builds can't find AVVideoPerformanceMetrics. Modified: tags/Safari-607.1.10/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h (236947 => 236948) --- tags/Safari-607.1.10/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h 2018-10-08 23:20:23 UTC (rev 236947) +++ tags/Safari-607.1.10/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h 2018-10-08 23:20:26 UTC (rev 236948) @@ -160,6 +160,16 @@ #endif // USE(APPLE_INTERNAL_SDK) +#if !USE(APPLE_INTERNAL_SDK) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) +@interface AVVideoPerformanceMetrics : NSObject +@property (nonatomic, readonly) unsigned long totalNumberOfVideoFrames; +@property (nonatomic, readonly) unsigned long numberOfDroppedVideoFrames; +@property (nonatomic, readonly) unsigned long numberOfCorruptedVideoFrames; +@property (nonatomic, readonly) unsigned long numberOfDisplayCompositedVideoFrames; +@property (nonatomic, readonly) double totalFrameDelay; +@end +#endif + #if PLATFORM(MAC) && !USE(APPLE_INTERNAL_SDK) NS_ASSUME_NONNULL_BEGIN @interface AVStreamDataParser (AVStreamDataParserPrivate) @@ -298,20 +308,6 @@ #endif // __has_include() -#if !USE(APPLE_INTERNAL_SDK) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) -@interface AVVideoPerformanceMetrics : NSObject -@property (nonatomic, readonly) unsigned long totalNumberOfVideoFrames; -@property (nonatomic, readonly) unsigned long numberOfDroppedVideoFrames; -@property (nonatomic, readonly) unsigned long numberOfCorruptedVideoFrames; -@property (nonatomic, readonly) unsigned long numberOfDisplayCompositedVideoFrames; -@property (nonatomic, readonly) double totalFrameDelay; -@end -#else -@interface AVVideoPerformanceMetrics (AVVideoPerformanceMetricsDisplayCompositedVideoFrames) -@property (nonatomic, readonly) unsigned long numberOfDisplayCompositedVideoFrames; -@end -#endif - #if !USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR) && !PLATFORM(IOSMAC) #import ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236949] tags/Safari-607.1.10
Title: [236949] tags/Safari-607.1.10
Revision 236949
Author kocsen_ch...@apple.com
Date 2018-10-08 16:20:34 -0700 (Mon, 08 Oct 2018)
Log Message
Revert r236875. rdar://problem/45109065
Modified Paths
tags/Safari-607.1.10/Source/WebCore/ChangeLog
tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp
tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h
tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl
tags/Safari-607.1.10/Source/WebCore/PAL/ChangeLog
tags/Safari-607.1.10/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h
tags/Safari-607.1.10/Source/WebCore/html/HTMLMediaElement.cpp
tags/Safari-607.1.10/Source/WebCore/html/HTMLMediaElement.h
tags/Safari-607.1.10/Source/WebCore/html/HTMLMediaElement.idl
tags/Safari-607.1.10/Source/WebCore/page/Settings.yaml
tags/Safari-607.1.10/Source/WebCore/platform/graphics/MediaPlayer.cpp
tags/Safari-607.1.10/Source/WebCore/platform/graphics/MediaPlayer.h
tags/Safari-607.1.10/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
tags/Safari-607.1.10/Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp
tags/Safari-607.1.10/Source/WebKit/ChangeLog
tags/Safari-607.1.10/Source/WebKit/Shared/WebPreferences.yaml
tags/Safari-607.1.10/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
tags/Safari-607.1.10/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
tags/Safari-607.1.10/Tools/ChangeLog
tags/Safari-607.1.10/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Removed Paths
tags/Safari-607.1.10/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm
Diff
Modified: tags/Safari-607.1.10/Source/WebCore/ChangeLog (236948 => 236949)
--- tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:20:26 UTC (rev 236948)
+++ tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:20:34 UTC (rev 236949)
@@ -1,5 +1,9 @@
2018-10-08 Kocsen Chung
+Revert r236875. rdar://problem/45109065
+
+2018-10-08 Kocsen Chung
+
Revert r236878. rdar://problem/45109065
2018-10-08 Kocsen Chung
Modified: tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp (236948 => 236949)
--- tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp 2018-10-08 23:20:26 UTC (rev 236948)
+++ tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp 2018-10-08 23:20:34 UTC (rev 236949)
@@ -26,22 +26,19 @@
#include "config.h"
#include "VideoPlaybackQuality.h"
-#include "MediaPlayer.h"
-
namespace WebCore {
-Ref VideoPlaybackQuality::create(double creationTime, const VideoPlaybackQualityMetrics& metrics)
+Ref VideoPlaybackQuality::create(double creationTime, unsigned totalVideoFrames, unsigned droppedVideoFrames, unsigned corruptedVideoFrames, double totalFrameDelay)
{
-return adoptRef(*new VideoPlaybackQuality(creationTime, metrics));
+return adoptRef(*new VideoPlaybackQuality(creationTime, totalVideoFrames, droppedVideoFrames, corruptedVideoFrames, totalFrameDelay));
}
-VideoPlaybackQuality::VideoPlaybackQuality(double creationTime, const VideoPlaybackQualityMetrics& metrics)
+VideoPlaybackQuality::VideoPlaybackQuality(double creationTime, unsigned totalVideoFrames, unsigned droppedVideoFrames, unsigned corruptedVideoFrames, double totalFrameDelay)
: m_creationTime(creationTime)
-, m_totalVideoFrames(metrics.totalVideoFrames)
-, m_droppedVideoFrames(metrics.droppedVideoFrames)
-, m_corruptedVideoFrames(metrics.corruptedVideoFrames)
-, m_displayCompositedVideoFrames(metrics.displayCompositedVideoFrames)
-, m_totalFrameDelay(metrics.totalFrameDelay)
+, m_totalVideoFrames(totalVideoFrames)
+, m_droppedVideoFrames(droppedVideoFrames)
+, m_corruptedVideoFrames(corruptedVideoFrames)
+, m_totalFrameDelay(totalFrameDelay)
{
}
Modified: tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h (236948 => 236949)
--- tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h 2018-10-08 23:20:26 UTC (rev 236948)
+++ tags/Safari-607.1.10/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h 2018-10-08 23:20:34 UTC (rev 236949)
@@ -30,28 +30,24 @@
namespace WebCore {
-struct VideoPlaybackQualityMetrics;
-
class VideoPlaybackQuality : public RefCounted {
WTF_MAKE_NONCOPYABLE(VideoPlaybackQuality)
public:
-static Ref create(double creationTime, const VideoPlaybackQualityMetrics&);
+static Ref create(double creationTime, unsigned totalVideoFrames, unsigned droppedVideoFrames, unsigned corruptedVideoFrames, double
[webkit-changes] [236947] tags/Safari-607.1.10/Source/WebCore
Title: [236947] tags/Safari-607.1.10/Source/WebCore
Revision 236947
Author kocsen_ch...@apple.com
Date 2018-10-08 16:20:23 -0700 (Mon, 08 Oct 2018)
Log Message
Revert r236878. rdar://problem/45109065
Modified Paths
tags/Safari-607.1.10/Source/WebCore/ChangeLog
tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: tags/Safari-607.1.10/Source/WebCore/ChangeLog (236946 => 236947)
--- tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:20:21 UTC (rev 236946)
+++ tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:20:23 UTC (rev 236947)
@@ -1,5 +1,9 @@
2018-10-08 Kocsen Chung
+Revert r236878. rdar://problem/45109065
+
+2018-10-08 Kocsen Chung
+
Revert r236882. rdar://problem/45109065
2018-10-08 Yacine Bandou
Modified: tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (236946 => 236947)
--- tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-08 23:20:21 UTC (rev 236946)
+++ tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-08 23:20:23 UTC (rev 236947)
@@ -3266,7 +3266,6 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunknown-pragmas"
#pragma clang diagnostic ignored "-Wunguarded-availability-new"
-#if !PLATFORM(WATCHOS)
auto metrics = [m_videoLayer videoPerformanceMetrics];
if (!metrics)
return std::nullopt;
@@ -3274,7 +3273,6 @@
uint32_t displayCompositedFrames = 0;
if ([metrics respondsToSelector:@selector(numberOfDisplayCompositedVideoFrames)])
displayCompositedFrames = [metrics numberOfDisplayCompositedVideoFrames];
-#endif
#pragma clang diagnostic pop
return VideoPlaybackQualityMetrics {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236946] tags/Safari-607.1.10/Source/WebCore
Title: [236946] tags/Safari-607.1.10/Source/WebCore
Revision 236946
Author kocsen_ch...@apple.com
Date 2018-10-08 16:20:21 -0700 (Mon, 08 Oct 2018)
Log Message
Revert r236882. rdar://problem/45109065
Modified Paths
tags/Safari-607.1.10/Source/WebCore/ChangeLog
tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: tags/Safari-607.1.10/Source/WebCore/ChangeLog (236945 => 236946)
--- tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:19:25 UTC (rev 236945)
+++ tags/Safari-607.1.10/Source/WebCore/ChangeLog 2018-10-08 23:20:21 UTC (rev 236946)
@@ -1,3 +1,7 @@
+2018-10-08 Kocsen Chung
+
+Revert r236882. rdar://problem/45109065
+
2018-10-08 Yacine Bandou
[EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc"
Modified: tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (236945 => 236946)
--- tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-08 23:19:25 UTC (rev 236945)
+++ tags/Safari-607.1.10/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-08 23:20:21 UTC (rev 236946)
@@ -3263,12 +3263,10 @@
if (![m_videoLayer respondsToSelector:@selector(videoPerformanceMetrics)])
return std::nullopt;
-#if PLATFORM(WATCHOS)
-return std::nullopt;
-#else
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunknown-pragmas"
#pragma clang diagnostic ignored "-Wunguarded-availability-new"
+#if !PLATFORM(WATCHOS)
auto metrics = [m_videoLayer videoPerformanceMetrics];
if (!metrics)
return std::nullopt;
@@ -3276,6 +3274,8 @@
uint32_t displayCompositedFrames = 0;
if ([metrics respondsToSelector:@selector(numberOfDisplayCompositedVideoFrames)])
displayCompositedFrames = [metrics numberOfDisplayCompositedVideoFrames];
+#endif
+#pragma clang diagnostic pop
return VideoPlaybackQualityMetrics {
static_cast([metrics totalNumberOfVideoFrames]),
@@ -3284,8 +3284,6 @@
[metrics totalFrameDelay],
displayCompositedFrames,
};
-#pragma clang diagnostic pop
-#endif
}
NSArray* assetMetadataKeyNames()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236945] trunk
Title: [236945] trunk
Revision 236945
Author d...@apple.com
Date 2018-10-08 16:19:25 -0700 (Mon, 08 Oct 2018)
Log Message
CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
https://bugs.webkit.org/show_bug.cgi?id=190376
Reviewed by Tim Horton.
Source/WebCore:
Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
depth from 256 to 128.
Modified existing test: compositing/layer-creation/deep-tree.html
* platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
LayoutTests:
* compositing/layer-creation/deep-tree.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/layer-creation/deep-tree.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (236944 => 236945)
--- trunk/LayoutTests/ChangeLog 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/LayoutTests/ChangeLog 2018-10-08 23:19:25 UTC (rev 236945)
@@ -1,3 +1,13 @@
+2018-10-08 Dean Jackson
+
+CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+https://bugs.webkit.org/show_bug.cgi?id=190376
+
+
+Reviewed by Tim Horton.
+
+* compositing/layer-creation/deep-tree.html:
+
2018-10-08 Aditya Keerthi
Make a runtime enabled (on-by-default) feature
Modified: trunk/LayoutTests/compositing/layer-creation/deep-tree.html (236944 => 236945)
--- trunk/LayoutTests/compositing/layer-creation/deep-tree.html 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/LayoutTests/compositing/layer-creation/deep-tree.html 2018-10-08 23:19:25 UTC (rev 236945)
@@ -33,7 +33,7 @@
function doTest()
{
-makeDeepTree(500, document.getElementById('deep'));
+makeDeepTree(129, document.getElementById('deep'));
}
window.addEventListener('load', doTest, false);
Modified: trunk/Source/WebCore/ChangeLog (236944 => 236945)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 23:19:25 UTC (rev 236945)
@@ -1,3 +1,18 @@
+2018-10-08 Dean Jackson
+
+CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+https://bugs.webkit.org/show_bug.cgi?id=190376
+
+
+Reviewed by Tim Horton.
+
+Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+depth from 256 to 128.
+
+Modified existing test: compositing/layer-creation/deep-tree.html
+
+* platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
2018-10-08 Commit Queue
Unreviewed, rolling out r236941.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (236944 => 236945)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-10-08 23:19:25 UTC (rev 236945)
@@ -89,7 +89,7 @@
#endif
// Derived empirically:
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
// About 10 screens of an iPhone 6 Plus.
static const unsigned cMaxTotalBackdropFilterArea = 1242 * 2208 * 10;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236944] tags/Safari-607.1.10/
Title: [236944] tags/Safari-607.1.10/ Revision 236944 Author alanc...@apple.com Date 2018-10-08 15:34:58 -0700 (Mon, 08 Oct 2018) Log Message Tag Safari-607.1.10. Added Paths tags/Safari-607.1.10/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236943] trunk
Title: [236943] trunk
Revision 236943
Author commit-qu...@webkit.org
Date 2018-10-08 15:27:48 -0700 (Mon, 08 Oct 2018)
Log Message
Unreviewed, rolling out r236941.
https://bugs.webkit.org/show_bug.cgi?id=190374
Causing API test failures in new test (Requested by jernoble
on #webkit).
Reverted changeset:
"ISOTrackEncryptionBox returns incorrect defaultKeyID"
https://bugs.webkit.org/show_bug.cgi?id=190368
https://trac.webkit.org/changeset/236941
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/iso/ISOBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp
trunk/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Removed Paths
trunk/Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236942 => 236943)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 22:08:41 UTC (rev 236942)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 22:27:48 UTC (rev 236943)
@@ -1,3 +1,17 @@
+2018-10-08 Commit Queue
+
+Unreviewed, rolling out r236941.
+https://bugs.webkit.org/show_bug.cgi?id=190374
+
+Causing API test failures in new test (Requested by jernoble
+on #webkit).
+
+Reverted changeset:
+
+"ISOTrackEncryptionBox returns incorrect defaultKeyID"
+https://bugs.webkit.org/show_bug.cgi?id=190368
+https://trac.webkit.org/changeset/236941
+
2018-10-08 Aditya Keerthi
Make a runtime enabled (on-by-default) feature
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (236942 => 236943)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-08 22:08:41 UTC (rev 236942)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-08 22:27:48 UTC (rev 236943)
@@ -4011,13 +4011,6 @@
CD5896E21CD2B15100B3BCC8 /* WebPlaybackControlsManager.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5896E01CD2B15100B3BCC8 /* WebPlaybackControlsManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD5D27781E8318E000D80A3D /* WebCoreDecompressionSession.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5D27761E8318E000D80A3D /* WebCoreDecompressionSession.h */; };
CD5E5B5F1A15CE54000C609E /* PageConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5E5B5E1A15CE54000C609E /* PageConfiguration.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF4972162E2B7004BD86F /* ISOTrackEncryptionBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C661FB52B6800F0B965 /* ISOTrackEncryptionBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF4992162E2BE004BD86F /* ISOBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C621FB52B6500F0B965 /* ISOBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF49A2162E4A6004BD86F /* ISOSchemeInformationBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C641FB52B6700F0B965 /* ISOSchemeInformationBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF49B2162E4B7004BD86F /* ISOSchemeTypeBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C5C1FB52B6300F0B965 /* ISOSchemeTypeBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF49C2162E4CF004BD86F /* ISOProtectionSystemSpecificHeaderBox.h in Headers */ = {isa = PBXBuildFile; fileRef = 12F75A9A86EA03DAF24B7971 /* ISOProtectionSystemSpecificHeaderBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF49D2162E4DB004BD86F /* ISOProtectionSchemeInfoBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C601FB52B6500F0B965 /* ISOProtectionSchemeInfoBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
- CD5FF49E2162E4E8004BD86F /* ISOOriginalFormatBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C671FB52B6800F0B965 /* ISOOriginalFormatBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD61FE681794AADB004101EB /* MediaSourceRegistry.h in Headers */ = {isa = PBXBuildFile; fileRef = B1A942E215B5CE2200D525D1 /* MediaSourceRegistry.h */; };
CD62FB961AF018E70012ED7D /* GenericTaskQueue.h in Headers */ = {isa = PBXBuildFile; fileRef = CD62FB941AF018E70012ED7D /* GenericTaskQueue.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD641EB31818F5ED00EE4C41 /* MediaSourcePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = CD641EB11818F5ED00EE4C41 /* MediaSourcePrivate.h */; };
@@ -28587,13 +28580,6 @@
11310CF120BA4A1B0065A8D0 /* Invalidation.h in Headers */,
2D0B4AAB18DA1CCD00434DE1 /* IOSurface.h in Headers */,
1C21E57D183ED1FF001C289D /*
[webkit-changes] [236942] trunk
Title: [236942] trunk Revision 236942 Author akeer...@apple.com Date 2018-10-08 15:08:41 -0700 (Mon, 08 Oct 2018) Log Message Make a runtime enabled (on-by-default) feature https://bugs.webkit.org/show_bug.cgi?id=189162 Reviewed by Wenson Hsieh and Tim Horton. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: Enable the build-time flag INPUT_TYPE_COLOR by default and introduce a runtime-enabled feature for input type color, also on by default. Covered by rebaselining existing layout tests. * Configurations/FeatureDefines.xcconfig: * html/InputType.cpp: (WebCore::createInputTypeFactoryMap): * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::inputTypeColorEnabled const): (WebCore::RuntimeEnabledFeatures::setInputTypeColorEnabled): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit: * Configurations/FeatureDefines.xcconfig: * Shared/WebPreferences.yaml: Add an experimental feature flag for input type=color. * UIProcess/mac/WebColorPickerMac.mm: (-[WKPopoverColorWell webDelegate]): (-[WKPopoverColorWell setWebDelegate:]): Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: Source/WTF: * wtf/FeatureDefines.h: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: LayoutTests: Rebaseline layout tests after enabling input type=color by default. * platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: * platform/ios/fast/forms/color/input-appearance-color-expected.txt: * platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Added. * platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color-expected.txt: * platform/mac/accessibility/roles-exposed-expected.txt: * platform/mac/fast/selectors/read-only-read-write-input-basics-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: * platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/fast/forms/color/input-appearance-color-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/mac/fast/selectors/read-only-read-write-input-basics-expected.txt trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt
[webkit-changes] [236941] trunk
Title: [236941] trunk
Revision 236941
Author jer.no...@apple.com
Date 2018-10-08 14:12:12 -0700 (Mon, 08 Oct 2018)
Log Message
ISOTrackEncryptionBox returns incorrect defaultKeyID
https://bugs.webkit.org/show_bug.cgi?id=190368
Reviewed by Eric Carlson.
Source/WebCore:
Test: TestWebKitAPI.ISOBox.ISOProtectionSchemeInfoBox
ISOTrackEncryptionBox::parse() increments the data offset by an incorrect amount.
Drive-by fix: add EXPORT macros to all the ISO box classes so that tests can be written in TestWebKitAPI.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/iso/ISOBox.h:
* platform/graphics/iso/ISOOriginalFormatBox.h:
* platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h:
* platform/graphics/iso/ISOSchemeInformationBox.h:
* platform/graphics/iso/ISOSchemeTypeBox.h:
* platform/graphics/iso/ISOTrackEncryptionBox.cpp:
(WebCore::ISOTrackEncryptionBox::parse):
* platform/graphics/iso/ISOTrackEncryptionBox.h:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/iso/ISOBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h
trunk/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp
trunk/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236940 => 236941)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 21:10:47 UTC (rev 236940)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 21:12:12 UTC (rev 236941)
@@ -1,3 +1,27 @@
+2018-10-08 Jer Noble
+
+ISOTrackEncryptionBox returns incorrect defaultKeyID
+https://bugs.webkit.org/show_bug.cgi?id=190368
+
+Reviewed by Eric Carlson.
+
+Test: TestWebKitAPI.ISOBox.ISOProtectionSchemeInfoBox
+
+ISOTrackEncryptionBox::parse() increments the data offset by an incorrect amount.
+
+Drive-by fix: add EXPORT macros to all the ISO box classes so that tests can be written in TestWebKitAPI.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/iso/ISOBox.h:
+* platform/graphics/iso/ISOOriginalFormatBox.h:
+* platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
+* platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h:
+* platform/graphics/iso/ISOSchemeInformationBox.h:
+* platform/graphics/iso/ISOSchemeTypeBox.h:
+* platform/graphics/iso/ISOTrackEncryptionBox.cpp:
+(WebCore::ISOTrackEncryptionBox::parse):
+* platform/graphics/iso/ISOTrackEncryptionBox.h:
+
2018-10-08 Antti Koivisto
Move SystemFontDatabase to a file of its own
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (236940 => 236941)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-08 21:10:47 UTC (rev 236940)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-08 21:12:12 UTC (rev 236941)
@@ -4011,6 +4011,13 @@
CD5896E21CD2B15100B3BCC8 /* WebPlaybackControlsManager.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5896E01CD2B15100B3BCC8 /* WebPlaybackControlsManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD5D27781E8318E000D80A3D /* WebCoreDecompressionSession.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5D27761E8318E000D80A3D /* WebCoreDecompressionSession.h */; };
CD5E5B5F1A15CE54000C609E /* PageConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5E5B5E1A15CE54000C609E /* PageConfiguration.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD5FF4972162E2B7004BD86F /* ISOTrackEncryptionBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C661FB52B6800F0B965 /* ISOTrackEncryptionBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD5FF4992162E2BE004BD86F /* ISOBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C621FB52B6500F0B965 /* ISOBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD5FF49A2162E4A6004BD86F /* ISOSchemeInformationBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C641FB52B6700F0B965 /* ISOSchemeInformationBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD5FF49B2162E4B7004BD86F /* ISOSchemeTypeBox.h in Headers */ = {isa = PBXBuildFile; fileRef = CD871C5C1FB52B6300F0B965 /* ISOSchemeTypeBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD5FF49C2162E4CF004BD86F /* ISOProtectionSystemSpecificHeaderBox.h
[webkit-changes] [236940] trunk/Source/WebKit
Title: [236940] trunk/Source/WebKit Revision 236940 Author timothy_hor...@apple.com Date 2018-10-08 14:10:47 -0700 (Mon, 08 Oct 2018) Log Message Try to fix the build * UIProcess/ios/WKKeyboardScrollingAnimator.mm: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm Diff Modified: trunk/Source/WebKit/ChangeLog (236939 => 236940) --- trunk/Source/WebKit/ChangeLog 2018-10-08 21:02:20 UTC (rev 236939) +++ trunk/Source/WebKit/ChangeLog 2018-10-08 21:10:47 UTC (rev 236940) @@ -1,3 +1,9 @@ +2018-10-08 Tim Horton + +Try to fix the build + +* UIProcess/ios/WKKeyboardScrollingAnimator.mm: + 2018-10-08 Brian Burg [Mac] Web Automation: some keyboard interactions don't generate events, causing event simulation to stall Modified: trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm (236939 => 236940) --- trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-10-08 21:02:20 UTC (rev 236939) +++ trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-10-08 21:10:47 UTC (rev 236940) @@ -29,6 +29,7 @@ #if PLATFORM(IOS) #import "UIKitSPI.h" +#import #import #import #import ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236939] trunk/Source/WebKit
Title: [236939] trunk/Source/WebKit Revision 236939 Author bb...@apple.com Date 2018-10-08 14:02:20 -0700 (Mon, 08 Oct 2018) Log Message [Mac] Web Automation: some keyboard interactions don't generate events, causing event simulation to stall https://bugs.webkit.org/show_bug.cgi?id=190316 Reviewed by Tim Horton. Some users have reported that Cmd-A for Select All no longer works in safaridriver. Instead, this hangs the session. This happens because the WebAutomationSession class assumes that each call to simulateKeyboardInteraction causes keyboard events to be processed, but in corner cases like Cmd-A, some events that we simulate are swallowed by AppKit and never make it back to WebKit. Because the session never gets the "keyboard events flushed" callback, it assumes the interaction is still ongoing, and never returns, causing a hang. This patch consists of two parts: - Add logging of important state changes and events when simulating user input. - Make code more robust when simulating key actions that generate no events on macOS. This change progresses WPT test key_shortcuts.py::test_mod_a_and_backspace_deletes_all_text on Mac. * Platform/Logging.h: Add a logging channel. * UIProcess/Automation/SimulatedInputDispatcher.cpp: (WebKit::SimulatedInputDispatcher::keyFrameTransitionDurationTimerFired): (WebKit::SimulatedInputDispatcher::transitionBetweenKeyFrames): (WebKit::SimulatedInputDispatcher::transitionInputSourceToState): (WebKit::SimulatedInputDispatcher::run): (WebKit::SimulatedInputDispatcher::finishDispatching): Add a bunch of logging so its easier to figure out where things get stuck. * UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::simulateKeyboardInteraction): In some cases, no keyboard events need to be processed for the simulated interaction. When that happens, early exit rather than waiting for keyboard events to be flushed. * UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::sendSynthesizedEventsToPage): Logging. (WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): On Mac, if you tap a character key while Command is held down, only a KeyDown event is forwarded to the first responder by AppKit, even if you send a KeyUp event too. In this case don't send an NSEvent since it won't ever be delivered back to WebKit. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isProcessingKeyboardEvents const): Expose this state for keyboard events too. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/Logging.h trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h Diff Modified: trunk/Source/WebKit/ChangeLog (236938 => 236939) --- trunk/Source/WebKit/ChangeLog 2018-10-08 20:37:26 UTC (rev 236938) +++ trunk/Source/WebKit/ChangeLog 2018-10-08 21:02:20 UTC (rev 236939) @@ -1,3 +1,50 @@ +2018-10-08 Brian Burg + +[Mac] Web Automation: some keyboard interactions don't generate events, causing event simulation to stall +https://bugs.webkit.org/show_bug.cgi?id=190316 + + +Reviewed by Tim Horton. + +Some users have reported that Cmd-A for Select All no longer works in safaridriver. +Instead, this hangs the session. This happens because the WebAutomationSession class +assumes that each call to simulateKeyboardInteraction causes keyboard events to be processed, +but in corner cases like Cmd-A, some events that we simulate are swallowed by AppKit and +never make it back to WebKit. Because the session never gets the "keyboard events flushed" +callback, it assumes the interaction is still ongoing, and never returns, causing a hang. + +This patch consists of two parts: + - Add logging of important state changes and events when simulating user input. + - Make code more robust when simulating key actions that generate no events on macOS. + +This change progresses WPT test key_shortcuts.py::test_mod_a_and_backspace_deletes_all_text on Mac. + +* Platform/Logging.h: Add a logging channel. +* UIProcess/Automation/SimulatedInputDispatcher.cpp: +(WebKit::SimulatedInputDispatcher::keyFrameTransitionDurationTimerFired): +(WebKit::SimulatedInputDispatcher::transitionBetweenKeyFrames): +(WebKit::SimulatedInputDispatcher::transitionInputSourceToState): +(WebKit::SimulatedInputDispatcher::run): +(WebKit::SimulatedInputDispatcher::finishDispatching): +Add a bunch of logging so its easier to figure out where things get stuck. + +* UIProcess/Automation/WebAutomationSession.cpp: +(WebKit::WebAutomationSession::simulateKeyboardInteraction): +
[webkit-changes] [236938] trunk/Source/WebCore
Title: [236938] trunk/Source/WebCore Revision 236938 Author an...@apple.com Date 2018-10-08 13:37:26 -0700 (Mon, 08 Oct 2018) Log Message Move SystemFontDatabase to a file of its own https://bugs.webkit.org/show_bug.cgi?id=190347 Reviewed by Chris Dumez. Also rename it to SystemFontDatabaseCoreText as it is CoreText specific. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * page/MemoryRelease.cpp: (WebCore::releaseNoncriticalMemory): * page/cocoa/MemoryReleaseCocoa.mm: Release SystemFontDatabaseCoreText directly from platform specific cleanup code. (WebCore::platformReleaseMemory): * platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::FontDescription::invalidateCaches): (WebCore::systemFontCascadeList): (WebCore::FontCascadeDescription::effectiveFamilyCount const): (WebCore::FontCascadeDescription::effectiveFamilyAt const): (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParameters): Deleted. (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::isHashTableDeletedValue const): Deleted. (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::operator== const): Deleted. (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::hash const): Deleted. (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParametersHash::hash): Deleted. (WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParametersHash::equal): Deleted. (): Deleted. (WebCore::SystemFontDatabase::singleton): Deleted. (WebCore::SystemFontDatabase::systemFontCascadeList): Deleted. (WebCore::SystemFontDatabase::clear): Deleted. (WebCore::SystemFontDatabase::SystemFontDatabase): Deleted. (WebCore::SystemFontDatabase::applyWeightItalicsAndFallbackBehavior): Deleted. (WebCore::SystemFontDatabase::removeCascadeList): Deleted. (WebCore::SystemFontDatabase::computeCascadeList): Deleted. (WebCore::systemFontParameters): Deleted. * platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: Added. (WebCore::SystemFontDatabaseCoreText::singleton): (WebCore::SystemFontDatabaseCoreText::SystemFontDatabaseCoreText): (WebCore::SystemFontDatabaseCoreText::systemFontCascadeList): (WebCore::SystemFontDatabaseCoreText::clear): (WebCore::SystemFontDatabaseCoreText::applyWeightItalicsAndFallbackBehavior): (WebCore::SystemFontDatabaseCoreText::removeCascadeList): (WebCore::SystemFontDatabaseCoreText::computeCascadeList): (WebCore::SystemFontDatabaseCoreText::systemFontParameters): * platform/graphics/cocoa/SystemFontDatabaseCoreText.h: Added. (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::CascadeListParameters): (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::isHashTableDeletedValue const): (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::operator== const): (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::hash const): (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::CascadeListParametersHash::hash): (WebCore::SystemFontDatabaseCoreText::CascadeListParameters::CascadeListParametersHash::equal): * platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/MemoryRelease.cpp trunk/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm trunk/Source/WebCore/platform/graphics/FontDescription.cpp trunk/Source/WebCore/platform/graphics/FontDescription.h trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp trunk/Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp Added Paths trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h Diff Modified: trunk/Source/WebCore/ChangeLog (236937 => 236938) --- trunk/Source/WebCore/ChangeLog 2018-10-08 20:24:56 UTC (rev 236937) +++ trunk/Source/WebCore/ChangeLog 2018-10-08 20:37:26 UTC (rev 236938) @@ -1,3 +1,59 @@ +2018-10-08 Antti Koivisto + +Move SystemFontDatabase to a file of its own +https://bugs.webkit.org/show_bug.cgi?id=190347 + +Reviewed by Chris Dumez. + +Also rename it to SystemFontDatabaseCoreText as it is CoreText specific. + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* page/MemoryRelease.cpp: +(WebCore::releaseNoncriticalMemory): +* page/cocoa/MemoryReleaseCocoa.mm: + +Release SystemFontDatabaseCoreText directly from platform specific cleanup code. + +(WebCore::platformReleaseMemory): +* platform/graphics/cocoa/FontDescriptionCocoa.cpp: +(WebCore::FontDescription::invalidateCaches): +(WebCore::systemFontCascadeList): +(WebCore::FontCascadeDescription::effectiveFamilyCount const): +(WebCore::FontCascadeDescription::effectiveFamilyAt const): +
[webkit-changes] [236937] trunk/LayoutTests
Title: [236937] trunk/LayoutTests Revision 236937 Author ryanhad...@apple.com Date 2018-10-08 13:24:56 -0700 (Mon, 08 Oct 2018) Log Message Move test expectations from ios-12 to ios directory https://bugs.webkit.org/show_bug.cgi?id=189839 Unreviewed test gardening.. * platform/ios-11/http/tests/quicklook/hide-referer-on-navigation-expected.txt: Removed. * platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed. * platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt: Removed. * platform/ios-11/platform/ios/ios/fast/text/opticalFont-expected.txt: Removed. * platform/ios-11/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Removed. * platform/ios-11/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Removed. * platform/ios-11/quicklook/powerpoint-expected.txt: Removed. * platform/ios-11/quicklook/powerpoint-legacy-expected.txt: Removed. * platform/ios-11/quicklook/word-expected.txt: Removed. * platform/ios-11/quicklook/word-legacy-expected.txt: Removed. * platform/ios-11/svg/batik/text/longTextOnPath-expected.txt: Removed. * platform/ios-12/TestExpectations: Removed. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Removed Paths trunk/LayoutTests/platform/ios-11/ trunk/LayoutTests/platform/ios-12/ Diff Modified: trunk/LayoutTests/ChangeLog (236936 => 236937) --- trunk/LayoutTests/ChangeLog 2018-10-08 20:22:00 UTC (rev 236936) +++ trunk/LayoutTests/ChangeLog 2018-10-08 20:24:56 UTC (rev 236937) @@ -1,3 +1,24 @@ +2018-10-08 Ryan Haddad + +Move test expectations from ios-12 to ios directory +https://bugs.webkit.org/show_bug.cgi?id=189839 + +Unreviewed test gardening.. + +* platform/ios-11/http/tests/quicklook/hide-referer-on-navigation-expected.txt: Removed. +* platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker-expected.txt: Removed. +* platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt: Removed. +* platform/ios-11/platform/ios/ios/fast/text/opticalFont-expected.txt: Removed. +* platform/ios-11/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Removed. +* platform/ios-11/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Removed. +* platform/ios-11/quicklook/powerpoint-expected.txt: Removed. +* platform/ios-11/quicklook/powerpoint-legacy-expected.txt: Removed. +* platform/ios-11/quicklook/word-expected.txt: Removed. +* platform/ios-11/quicklook/word-legacy-expected.txt: Removed. +* platform/ios-11/svg/batik/text/longTextOnPath-expected.txt: Removed. +* platform/ios-12/TestExpectations: Removed. +* platform/ios/TestExpectations: + 2018-10-08 Truitt Savell Attempt to fix test failure after 236915 Modified: trunk/LayoutTests/platform/ios/TestExpectations (236936 => 236937) --- trunk/LayoutTests/platform/ios/TestExpectations 2018-10-08 20:22:00 UTC (rev 236936) +++ trunk/LayoutTests/platform/ios/TestExpectations 2018-10-08 20:24:56 UTC (rev 236937) @@ -3169,3 +3169,40 @@ webkit.org/b/190032 animations/stop-animation-on-suspend.html [ Failure ] +http/tests/cookies/same-site [ Pass ] + +system-preview [ Pass ] + +editing/selection/character-granularity-rect.html [ Pass ] + +# < iOS12 doesn't support the CG needed for Conic Gradients +fast/gradients/conic-repeating.html [ Pass ] +fast/gradients/conic.html [ Pass ] +fast/gradients/conic-off-center.html [ Pass ] +fast/gradients/conic-center-outside-box.html [ Pass ] +fast/gradients/conic-extended-stops.html [ Pass ] +fast/gradients/conic-from-angle.html [ Pass ] +fast/gradients/conic-repeating-last-stop.html [ Pass ] +fast/gradients/conic-gradient-alpha.html [ Pass ] +fast/gradients/conic-gradient-extended-stops.html [ Pass ] +fast/gradients/conic-gradient.html [ Pass ] +fast/gradients/conic-two-hints.html [ Pass ] + +# LayoutTest compositing/ios/overflow-scroll-touch-tiles.html is a flaky failure +compositing/ios/overflow-scroll-touch-tiles.html [ Pass Failure ] + +# REGRESSION: LayoutTest svg/custom/subpaths-moveto-only-rendering.svg is failing +svg/custom/subpaths-moveto-only-rendering.svg [ Failure ] + +# LayoutTest fast/events/focusing-element-with-tabindex-by-tap-or-click.html is a flaky failure +fast/events/focusing-element-with-tabindex-by-tap-or-click.html [ Pass Failure ] + +# quicklook/keynote.html and quicklook/pages.html are failing with a 0.09% image diff +quicklook/keynote.html [ ImageOnlyFailure ] +quicklook/pages.html [ ImageOnlyFailure ] + +# REGRESSION: LayoutTest compositing/contents-scale/non-decomposable-matrix.html is failing +compositing/contents-scale/non-decomposable-matrix.html [ ImageOnlyFailure ] + +# REGRESSION:
[webkit-changes] [236936] trunk/Source/WebKit
Title: [236936] trunk/Source/WebKit
Revision 236936
Author you...@apple.com
Date 2018-10-08 13:22:00 -0700 (Mon, 08 Oct 2018)
Log Message
NetworkCache::Storage should be WTF::DestructionThread::Main
https://bugs.webkit.org/show_bug.cgi?id=190324
Reviewed by Alex Christensen.
Use WTF::DestructionThread::Main to make sure that Storage is destroyed in the main thread.
Remove the code that was making sure that any ref was destroyed in the main thread.
* NetworkProcess/cache/CacheStorageEngineCaches.cpp: Make sure the completion handler is not null.
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation): Make it clear that a ref is taken.
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::synchronize): Protect 'this' when dispatching back to the main thread.
Move the code that was after dispatch before dispatch to allow moving protectedThis in the dispatch lambda.
(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::clear):
(WebKit::NetworkCache::Storage::deleteOldVersions):
* NetworkProcess/cache/NetworkCacheStorage.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (236935 => 236936)
--- trunk/Source/WebKit/ChangeLog 2018-10-08 20:18:26 UTC (rev 236935)
+++ trunk/Source/WebKit/ChangeLog 2018-10-08 20:22:00 UTC (rev 236936)
@@ -1,3 +1,25 @@
+2018-10-08 Youenn Fablet
+
+NetworkCache::Storage should be WTF::DestructionThread::Main
+https://bugs.webkit.org/show_bug.cgi?id=190324
+
+Reviewed by Alex Christensen.
+
+Use WTF::DestructionThread::Main to make sure that Storage is destroyed in the main thread.
+Remove the code that was making sure that any ref was destroyed in the main thread.
+
+* NetworkProcess/cache/CacheStorageEngineCaches.cpp: Make sure the completion handler is not null.
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation): Make it clear that a ref is taken.
+(WebKit::NetworkCache::Storage::Storage):
+(WebKit::NetworkCache::Storage::synchronize): Protect 'this' when dispatching back to the main thread.
+Move the code that was after dispatch before dispatch to allow moving protectedThis in the dispatch lambda.
+(WebKit::NetworkCache::Storage::remove):
+(WebKit::NetworkCache::Storage::traverse):
+(WebKit::NetworkCache::Storage::clear):
+(WebKit::NetworkCache::Storage::deleteOldVersions):
+* NetworkProcess/cache/NetworkCacheStorage.h:
+
2018-10-08 Tim Horton
Adjust keyboard scrolling animator to springy and semiphysical
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp (236935 => 236936)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp 2018-10-08 20:18:26 UTC (rev 236935)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp 2018-10-08 20:22:00 UTC (rev 236936)
@@ -348,7 +348,7 @@
auto position = m_removedCaches.findMatching([&](const auto& item) { return item.identifier() == cache.identifier(); });
if (position != notFound) {
if (m_storage)
-m_storage->remove(cache.keys(), { });
+m_storage->remove(cache.keys(), [] { });
m_removedCaches.remove(position);
return;
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (236935 => 236936)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2018-10-08 20:18:26 UTC (rev 236935)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2018-10-08 20:22:00 UTC (rev 236936)
@@ -124,8 +124,8 @@
struct Storage::TraverseOperation {
WTF_MAKE_FAST_ALLOCATED;
public:
-TraverseOperation(Storage& storage, const String& type, OptionSet flags, TraverseHandler&& handler)
-: storage(storage)
+TraverseOperation(Ref&& storage, const String& type, OptionSet flags, TraverseHandler&& handler)
+: storage(WTFMove(storage))
, type(type)
, flags(flags)
, handler(WTFMove(handler))
@@ -233,6 +233,8 @@
, m_serialBackgroundIOQueue(WorkQueue::create("com.apple.WebKit.Cache.Storage.serialBackground", WorkQueue::Type::Serial, WorkQueue::QOS::Background))
, m_blobStorage(makeBlobDirectoryPath(baseDirectoryPath), m_salt)
{
+ASSERT(RunLoop::isMain());
+
deleteOldVersions();
synchronize();
}
@@ -325,7 +327,13 @@
if (!shouldComputeExactRecordsSize)
recordsSize = estimateRecordsSize(recordCount, blobCount);
-RunLoop::main().dispatch([this, recordFilter = WTFMove(recordFilter),
[webkit-changes] [236935] trunk/Source/WebKit
Title: [236935] trunk/Source/WebKit Revision 236935 Author timothy_hor...@apple.com Date 2018-10-08 13:18:26 -0700 (Mon, 08 Oct 2018) Log Message Adjust keyboard scrolling animator to springy and semiphysical https://bugs.webkit.org/show_bug.cgi?id=190345 Reviewed by Simon Fraser. Introduce WKKeyboardScrollViewAnimator, which wraps WKKeyboardScrollingAnimator and provides a reasonable set of default behaviors for UIScrollView. This is the first step on the way to WKKeyboardScrollingAnimator being platform- and toolkit-agnostic, and helps avoid adding a whole bunch of code to WKContentView. Adopt UIKit's scroll-to-top animation curve for whole-document scrolls. Adjust WKKeyboardScrollingAnimator's physics; it now simulates a spring attached to the page when decelerating. When a key is pressed, it applies a constant force to the page (up to some maximum velocity). When released, the spring causes the page to decelerate smoothly. Add rubber-banding to keyboard scrolling, based on the same spring that decelerates the page. Remove the initial bounce on keydown before starting the smooth scroll. Remove arrow key commands from WKContentView; this avoids double-processing incoming arrow key events, makes the event stream make more sense, and was entirely unnecessary. * Platform/spi/ios/UIKitSPI.h: Add a wide variety of useful SPI. * UIProcess/API/Cocoa/WKWebView.mm: * UIProcess/API/Cocoa/WKWebViewInternal.h: Remove _scrollByContentOffset:animated: because it's only used by the keyboard scrolling mechanism. Remove _arrowKey because we're removing the arrow key commands. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): Create a WKKeyboardScrollViewAnimator (which knows how to directly manipulate a UIScrollView) instead of a WKKeyboardScrollingAnimator (which requires its clients to implement everything in terms of an abstract interface. (-[WKContentView scrollViewWillStartPanOrPinchGesture]): Inform the keyboard scrolling animator that the user is going to start an interactive gesture that needs control of the scroll view, so it can stop its current animated scroll. (-[WKContentView canPerformActionForWebView:withSender:]): (-[WKContentView keyCommands]): (-[WKContentView _arrowKeyForWebView:]): Deleted. Remove arrow key commands. (-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:]): Scale from content to WKWebView coordinate space; the keyboard scrolling animator operates in WKWebView coordinates. This was broken before. (-[WKContentView keyboardScrollViewAnimatorWillScroll:]): (-[WKContentView isScrollableForKeyboardScrollViewAnimator:]): (-[WKContentView isKeyboardScrollable]): Deleted. (-[WKContentView distanceForScrollingIncrement:]): Deleted. (-[WKContentView scrollByContentOffset:animated:]): Deleted. Reimplement these as keyboardScrollViewAnimator delegate methods. * UIProcess/ios/WKKeyboardScrollingAnimator.h: Add WKKeyboardScrollViewAnimator, hide the interface for WKKeyboardScrollingAnimator itself in the implementation file. * UIProcess/ios/WKKeyboardScrollingAnimator.mm: (-[WKKeyboardScrollingAnimator initWithScrollable:]): (-[WKKeyboardScrollingAnimator parameters]): (-[WKKeyboardScrollingAnimator invalidate]): (unitVector): Return a unit vector in the given direction. (perpendicularAbsoluteUnitVector): Return a positive unit vector perpendicular to the axis of the given direction. Useful for multiplying with another vector to remove the component in the axis of the given direction. (boxSide): Convert ScrollingDirection to WebCore::PhysicalBoxSide, for use with RectEdges. (-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]): Instead of just returning the desired increment, compute everything we'll need for the lifetime of the scroll (including the force applied, maximum velocity, etc.) and return them together. (-[WKKeyboardScrollingAnimator beginWithEvent:]): Use the scrollable's native scroll-to-extent animation (e.g. UIScrollView's scroll-to-top curve) for whole-document scrolls. Remove the first discrete scroll; start the smooth scroll immediately. (-[WKKeyboardScrollingAnimator handleKeyEvent:]): (farthestPointInDirection): (-[WKKeyboardScrollingAnimator stopAnimatedScroll]): Stop the current scroll. Let the spring coast to its natural stopping point given the system's current energy, unless that stopping point is less than one increment from the starting point. In that case, we attach the spring to /that/ point and let it run. (-[WKKeyboardScrollingAnimator startDisplayLinkIfNeeded]): (-[WKKeyboardScrollingAnimator stopDisplayLink]): (-[WKKeyboardScrollingAnimator willStartInteractiveScroll]): Immediately stop all motion if the user touches the screen to scroll or zoom with fingers. (-[WKKeyboardScrollingAnimator displayLinkFired:]): Update the position of the scrollable based on the applied force and spring. See the comments in this function for more details.
[webkit-changes] [236934] trunk/Source
Title: [236934] trunk/Source
Revision 236934
Author commit-qu...@webkit.org
Date 2018-10-08 13:15:22 -0700 (Mon, 08 Oct 2018)
Log Message
Remove dead code: VideoFullscreenModel::isVisible()
https://bugs.webkit.org/show_bug.cgi?id=190356
Patch by Jeremy Jones on 2018-10-08
Reviewed by Jon Lee.
Source/WebCore:
No new tests because there is no behavior change.
Remove isVisible() since it is no longer used.
* platform/cocoa/VideoFullscreenModel.h:
* platform/cocoa/VideoFullscreenModelVideoElement.h:
* platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::isVisible const): Deleted.
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::isVisible const): Deleted.
Source/WebKit:
Remove isVisible since it is no longer used.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenModelContext::isVisible const): Deleted.
(WebKit::VideoFullscreenManagerProxy::isVisible const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236933 => 236934)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 20:14:10 UTC (rev 236933)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 20:15:22 UTC (rev 236934)
@@ -1,5 +1,23 @@
2018-10-08 Jeremy Jones
+Remove dead code: VideoFullscreenModel::isVisible()
+https://bugs.webkit.org/show_bug.cgi?id=190356
+
+Reviewed by Jon Lee.
+
+No new tests because there is no behavior change.
+
+Remove isVisible() since it is no longer used.
+
+* platform/cocoa/VideoFullscreenModel.h:
+* platform/cocoa/VideoFullscreenModelVideoElement.h:
+* platform/cocoa/VideoFullscreenModelVideoElement.mm:
+(WebCore::VideoFullscreenModelVideoElement::isVisible const): Deleted.
+* platform/ios/WebVideoFullscreenControllerAVKit.mm:
+(VideoFullscreenControllerContext::isVisible const): Deleted.
+
+2018-10-08 Jeremy Jones
+
Remove dead code: resetMediaState.
https://bugs.webkit.org/show_bug.cgi?id=190355
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h (236933 => 236934)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h 2018-10-08 20:14:10 UTC (rev 236933)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h 2018-10-08 20:15:22 UTC (rev 236934)
@@ -53,7 +53,6 @@
virtual void setVideoLayerGravity(MediaPlayerEnums::VideoGravity) = 0;
virtual void fullscreenModeChanged(HTMLMediaElementEnums::VideoFullscreenMode) = 0;
-virtual bool isVisible() const = 0;
virtual FloatSize videoDimensions() const = 0;
virtual bool hasVideo() const = 0;
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h (236933 => 236934)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h 2018-10-08 20:14:10 UTC (rev 236933)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h 2018-10-08 20:15:22 UTC (rev 236934)
@@ -69,7 +69,6 @@
WEBCORE_EXPORT void setVideoLayerFrame(FloatRect) override;
WEBCORE_EXPORT void setVideoLayerGravity(MediaPlayerEnums::VideoGravity) override;
WEBCORE_EXPORT void fullscreenModeChanged(HTMLMediaElementEnums::VideoFullscreenMode) override;
-WEBCORE_EXPORT bool isVisible() const override;
FloatSize videoDimensions() const override { return m_videoDimensions; }
bool hasVideo() const override { return m_hasVideo; }
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm (236933 => 236934)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2018-10-08 20:14:10 UTC (rev 236933)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2018-10-08 20:15:22 UTC (rev 236934)
@@ -201,17 +201,6 @@
m_clients.remove();
}
-bool VideoFullscreenModelVideoElement::isVisible() const
-{
-if (!m_videoElement)
-return false;
-
-if (Page* page = m_videoElement->document().page())
-return page->isVisible();
-
-return false;
-}
-
void VideoFullscreenModelVideoElement::setHasVideo(bool hasVideo)
{
if (hasVideo == m_hasVideo)
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm (236933 => 236934)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2018-10-08 20:14:10 UTC (rev 236933)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
[webkit-changes] [236933] trunk/Source
Title: [236933] trunk/Source
Revision 236933
Author commit-qu...@webkit.org
Date 2018-10-08 13:14:10 -0700 (Mon, 08 Oct 2018)
Log Message
Remove dead code: resetMediaState.
https://bugs.webkit.org/show_bug.cgi?id=190355
Patch by Jeremy Jones on 2018-10-08
Reviewed by Jon Lee.
Source/WebCore:
No new tests because no behavior change.
Remove resetMediaState since it is no longer used.
* platform/cocoa/PlaybackSessionInterface.h:
(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface):
* platform/ios/PlaybackSessionInterfaceAVKit.h:
* platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::PlaybackSessionInterfaceAVKit::resetMediaState): Deleted.
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController resetMediaState]): Deleted.
* platform/mac/PlaybackSessionInterfaceMac.h:
* platform/mac/PlaybackSessionInterfaceMac.mm:
(WebCore::PlaybackSessionInterfaceMac::resetMediaState): Deleted.
Source/WebKit:
Remove resetMediaState since it is no longer used.
* UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
* UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionManagerProxy::resetMediaState): Deleted.
* WebProcess/cocoa/PlaybackSessionManager.h:
* WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionInterfaceContext::resetMediaState): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h
trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/WebAVPlayerController.h
trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm
trunk/Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h
trunk/Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in
trunk/Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236932 => 236933)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 20:12:22 UTC (rev 236932)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 20:14:10 UTC (rev 236933)
@@ -1,5 +1,28 @@
2018-10-08 Jeremy Jones
+Remove dead code: resetMediaState.
+https://bugs.webkit.org/show_bug.cgi?id=190355
+
+Reviewed by Jon Lee.
+
+No new tests because no behavior change.
+
+Remove resetMediaState since it is no longer used.
+
+* platform/cocoa/PlaybackSessionInterface.h:
+(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface):
+* platform/ios/PlaybackSessionInterfaceAVKit.h:
+* platform/ios/PlaybackSessionInterfaceAVKit.mm:
+(WebCore::PlaybackSessionInterfaceAVKit::resetMediaState): Deleted.
+* platform/ios/WebAVPlayerController.h:
+* platform/ios/WebAVPlayerController.mm:
+(-[WebAVPlayerController resetMediaState]): Deleted.
+* platform/mac/PlaybackSessionInterfaceMac.h:
+* platform/mac/PlaybackSessionInterfaceMac.mm:
+(WebCore::PlaybackSessionInterfaceMac::resetMediaState): Deleted.
+
+2018-10-08 Jeremy Jones
+
Use MediaPlayerEnums::VideoGravity in VideoFullscreenModel.
https://bugs.webkit.org/show_bug.cgi?id=190357
Modified: trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h (236932 => 236933)
--- trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2018-10-08 20:12:22 UTC (rev 236932)
+++ trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2018-10-08 20:14:10 UTC (rev 236933)
@@ -37,7 +37,6 @@
class PlaybackSessionInterface {
public:
virtual ~PlaybackSessionInterface() { };
-virtual void resetMediaState() = 0;
};
}
Modified: trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h (236932 => 236933)
--- trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2018-10-08 20:12:22 UTC (rev 236932)
+++ trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2018-10-08 20:14:10 UTC (rev 236933)
@@ -64,9 +64,6 @@
virtual ~PlaybackSessionInterfaceAVKit();
PlaybackSessionModel* playbackSessionModel() const { return m_playbackSessionModel; }
-// PlaybackSessionInterface
-WEBCORE_EXPORT void resetMediaState() override;
-
// PlaybackSessionModelClient
WEBCORE_EXPORT void durationChanged(double) override;
WEBCORE_EXPORT void currentTimeChanged(double currentTime, double anchorTime) override;
Modified: trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm (236932 => 236933)
--- trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm 2018-10-08
[webkit-changes] [236931] trunk/Source
Title: [236931] trunk/Source
Revision 236931
Author commit-qu...@webkit.org
Date 2018-10-08 13:00:35 -0700 (Mon, 08 Oct 2018)
Log Message
Use MediaPlayerEnums::VideoGravity in VideoFullscreenModel.
https://bugs.webkit.org/show_bug.cgi?id=190357
Patch by Jeremy Jones on 2018-10-08
Reviewed by Jon Lee.
Source/WebCore:
No new tests because no behavior change.
Use MediaPlayerEnums::VideoGravity instead of creating another identical enum in VideoFullscreenModel.
* platform/cocoa/VideoFullscreenModel.h:
(): Deleted.
* platform/cocoa/VideoFullscreenModelVideoElement.h:
* platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::setVideoLayerGravity):
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer setVideoGravity:]):
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::setVideoLayerGravity):
* platform/mac/VideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC setUpPIPForVideoView:withFrame:inWindow:]):
(-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]):
Source/WebKit:
Use MediaPlayerEnums::VideoGravity instead of creating another identical enum in VideoFullscreenModel.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenModelContext::setVideoLayerGravity):
(WebKit::VideoFullscreenManagerProxy::setVideoLayerGravity):
* WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::setVideoLayerGravityEnum):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236930 => 236931)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 19:58:09 UTC (rev 236930)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 20:00:35 UTC (rev 236931)
@@ -1,3 +1,27 @@
+2018-10-08 Jeremy Jones
+
+Use MediaPlayerEnums::VideoGravity in VideoFullscreenModel.
+https://bugs.webkit.org/show_bug.cgi?id=190357
+
+Reviewed by Jon Lee.
+
+No new tests because no behavior change.
+
+Use MediaPlayerEnums::VideoGravity instead of creating another identical enum in VideoFullscreenModel.
+
+* platform/cocoa/VideoFullscreenModel.h:
+(): Deleted.
+* platform/cocoa/VideoFullscreenModelVideoElement.h:
+* platform/cocoa/VideoFullscreenModelVideoElement.mm:
+(WebCore::VideoFullscreenModelVideoElement::setVideoLayerGravity):
+* platform/ios/VideoFullscreenInterfaceAVKit.mm:
+(-[WebAVPlayerLayer setVideoGravity:]):
+* platform/ios/WebVideoFullscreenControllerAVKit.mm:
+(VideoFullscreenControllerContext::setVideoLayerGravity):
+* platform/mac/VideoFullscreenInterfaceMac.mm:
+(-[WebVideoFullscreenInterfaceMacObjC setUpPIPForVideoView:withFrame:inWindow:]):
+(-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]):
+
2018-10-08 Devin Rousso
Web Inspector: group media network entries by the node that triggered the request
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h (236930 => 236931)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h 2018-10-08 19:58:09 UTC (rev 236930)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h 2018-10-08 20:00:35 UTC (rev 236931)
@@ -30,6 +30,7 @@
#include "FloatRect.h"
#include "HTMLMediaElementEnums.h"
+#include "MediaPlayerEnums.h"
#include "PlaybackSessionModel.h"
#if PLATFORM(IOS)
@@ -49,8 +50,7 @@
virtual void requestFullscreenMode(HTMLMediaElementEnums::VideoFullscreenMode, bool finishedWithMedia = false) = 0;
virtual void setVideoLayerFrame(FloatRect) = 0;
-enum VideoGravity { VideoGravityResize, VideoGravityResizeAspect, VideoGravityResizeAspectFill };
-virtual void setVideoLayerGravity(VideoGravity) = 0;
+virtual void setVideoLayerGravity(MediaPlayerEnums::VideoGravity) = 0;
virtual void fullscreenModeChanged(HTMLMediaElementEnums::VideoFullscreenMode) = 0;
virtual bool isVisible() const = 0;
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h (236930 => 236931)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h 2018-10-08 19:58:09 UTC (rev 236930)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h 2018-10-08 20:00:35 UTC (rev 236931)
@@
[webkit-changes] [236930] trunk
Title: [236930] trunk Revision 236930 Author achristen...@apple.com Date 2018-10-08 12:58:09 -0700 (Mon, 08 Oct 2018) Log Message Remove WKBundleFileHandleRef https://bugs.webkit.org/show_bug.cgi?id=190360 Reviewed by Tim Horton. Source/WebKit: WKBundleFrameGetJavaScriptWrapperForFileForWorld and WKBundleFileHandleCreateWithPath were only used in Mail and were removed in rdar://problem/44955158 I need to remove them for rdar://problem/24576194 * Shared/API/APIObject.h: * Shared/API/c/WKDeprecated.h: * Shared/API/c/WKDeprecatedFunctions.cpp: (WKBundleFrameGetJavaScriptWrapperForFileForWorld): (WKBundleFileHandleCreateWithPath): * Sources.txt: * SourcesCocoa.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: * WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.cpp: Removed. * WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h: * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptWrapperForFileForWorld): Deleted. * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: * WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.cpp: Removed. * WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.h: Removed. * WebProcess/WebPage/WebFrame.cpp: * WebProcess/WebPage/WebFrame.h: Tools: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed. * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/API/APIObject.h trunk/Source/WebKit/Shared/API/c/WKDeprecated.h trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.h trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp trunk/Source/WebKit/WebProcess/WebPage/WebFrame.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Removed Paths trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.cpp trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.cpp trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.h trunk/Tools/TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (236929 => 236930) --- trunk/Source/WebKit/ChangeLog 2018-10-08 19:53:29 UTC (rev 236929) +++ trunk/Source/WebKit/ChangeLog 2018-10-08 19:58:09 UTC (rev 236930) @@ -1,3 +1,33 @@ +2018-10-08 Alex Christensen + +Remove WKBundleFileHandleRef +https://bugs.webkit.org/show_bug.cgi?id=190360 + +Reviewed by Tim Horton. + +WKBundleFrameGetJavaScriptWrapperForFileForWorld and WKBundleFileHandleCreateWithPath were only used in Mail +and were removed in rdar://problem/44955158 +I need to remove them for rdar://problem/24576194 + +* Shared/API/APIObject.h: +* Shared/API/c/WKDeprecated.h: +* Shared/API/c/WKDeprecatedFunctions.cpp: +(WKBundleFrameGetJavaScriptWrapperForFileForWorld): +(WKBundleFileHandleCreateWithPath): +* Sources.txt: +* SourcesCocoa.txt: +* WebKit.xcodeproj/project.pbxproj: +* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: +* WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.cpp: Removed. +* WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h: +* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: +(WKBundleFrameGetJavaScriptWrapperForFileForWorld): Deleted. +* WebProcess/InjectedBundle/API/c/WKBundleFrame.h: +* WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.cpp: Removed. +* WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.h: Removed. +* WebProcess/WebPage/WebFrame.cpp: +* WebProcess/WebPage/WebFrame.h: + 2018-10-08 Konstantin Tokarev Validation in Connection::readBytesFromSocket() is too aggressive Modified: trunk/Source/WebKit/Shared/API/APIObject.h (236929 => 236930) --- trunk/Source/WebKit/Shared/API/APIObject.h 2018-10-08 19:53:29 UTC (rev 236929) +++ trunk/Source/WebKit/Shared/API/APIObject.h 2018-10-08 19:58:09 UTC (rev 236930) @@ -177,7 +177,6 @@ BundleBackForwardListItem, BundleCSSStyleDeclarationHandle, BundleDOMWindowExtension, -BundleFileHandle, BundleFrame, BundleHitTestResult, BundleInspector, Modified: trunk/Source/WebKit/Shared/API/c/WKDeprecated.h (236929 => 236930) --- trunk/Source/WebKit/Shared/API/c/WKDeprecated.h 2018-10-08 19:53:29 UTC
[webkit-changes] [236928] trunk/Source/WebKit
Title: [236928] trunk/Source/WebKit
Revision 236928
Author annu...@yandex.ru
Date 2018-10-08 12:12:28 -0700 (Mon, 08 Oct 2018)
Log Message
Validation in Connection::readBytesFromSocket() is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=190281
Reviewed by Michael Catanzaro.
Since r217206 Connection::readBytesFromSocket() validates size of
control message. However, it compares cmsg_len with attachmentMaxAmount,
while Connection::sendOutgoingMessage() computes it as
CMSG_LEN(sizeof(int) * attachmentFDBufferLength) where
attachmentFDBufferLength <= attachmentMaxAmount. This mismatch between
sender and receiver leads to possibility of assertion failure with large
number of attachments, e.g. here 62 attachments have cmsg_length == 264.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236927 => 236928)
--- trunk/Source/WebKit/ChangeLog 2018-10-08 18:25:52 UTC (rev 236927)
+++ trunk/Source/WebKit/ChangeLog 2018-10-08 19:12:28 UTC (rev 236928)
@@ -1,3 +1,21 @@
+2018-10-08 Konstantin Tokarev
+
+Validation in Connection::readBytesFromSocket() is too aggressive
+https://bugs.webkit.org/show_bug.cgi?id=190281
+
+Reviewed by Michael Catanzaro.
+
+Since r217206 Connection::readBytesFromSocket() validates size of
+control message. However, it compares cmsg_len with attachmentMaxAmount,
+while Connection::sendOutgoingMessage() computes it as
+CMSG_LEN(sizeof(int) * attachmentFDBufferLength) where
+attachmentFDBufferLength <= attachmentMaxAmount. This mismatch between
+sender and receiver leads to possibility of assertion failure with large
+number of attachments, e.g. here 62 attachments have cmsg_length == 264.
+
+* Platform/IPC/unix/ConnectionUnix.cpp:
+(IPC::readBytesFromSocket):
+
2018-10-08 Chris Dumez
Have DOMWindowProperty get is frame from its associated DOMWindow
Modified: trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp (236927 => 236928)
--- trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp 2018-10-08 18:25:52 UTC (rev 236927)
+++ trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp 2018-10-08 19:12:28 UTC (rev 236928)
@@ -273,7 +273,7 @@
struct cmsghdr* controlMessage;
for (controlMessage = CMSG_FIRSTHDR(); controlMessage; controlMessage = CMSG_NXTHDR(, controlMessage)) {
if (controlMessage->cmsg_level == SOL_SOCKET && controlMessage->cmsg_type == SCM_RIGHTS) {
-if (controlMessage->cmsg_len < CMSG_LEN(0) || controlMessage->cmsg_len > attachmentMaxAmount) {
+if (controlMessage->cmsg_len < CMSG_LEN(0) || controlMessage->cmsg_len > CMSG_LEN(sizeof(int) * attachmentMaxAmount)) {
ASSERT_NOT_REACHED();
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236927] trunk
Title: [236927] trunk Revision 236927 Author drou...@apple.com Date 2018-10-08 11:25:52 -0700 (Mon, 08 Oct 2018) Log Message Web Inspector: group media network entries by the node that triggered the request https://bugs.webkit.org/show_bug.cgi?id=189606 Reviewed by Brian Burg. Source/_javascript_Core: * inspector/protocol/Network.json: Add an optional `nodeId` field to the `Initiator` object that is set it is possible to determine which ancestor node triggered the load. It may not correspond directly to the node with the href/src, as that url may only be used by an ancestor for loading. Source/WebCore: Test: http/tests/inspector/network/resource-initiatorNode.html Add extra arguments to functions that create `ResourceRequest` objects for media resources so that `initiatorNodeIdentifier` can be set for WebInspector frontend to use for grouping. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): * loader/FrameLoader.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): Handles initial (e.g. DNT) resource requests. * loader/ImageLoader.cpp: (ImageLoader::updateFromElement): Handles "poster" requests. * loader/MediaResourceLoader.cpp: (MediaResourceLoader::requestResource): Handles byte-range requests. * html/track/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::loadTimerFired): * loader/TextTrackLoader.h: * loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::load): * html/HTMLTrackElement.h: Handles (e.g. subtitle) requests. * inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::identifierForNode): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::identifierForNode): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForNodeImpl): Allows callers to get a `DOM.nodeId` for the given `Node`, which is (in this patch) attached to the `ResourceRequest` and later used by `InspectorNetworkAgent`. * inspector/agents/InspectorNetworkAgent.h: * inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::willSendRequest): (WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorNetworkAgent::buildInitiatorObject): * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::initiatorNodeIdentifier const): (WebCore::ResourceRequestBase::setInitiatorNodeIdentifier): * platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setAsIsolatedCopy): * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache): * inspector/InspectorCanvas.h: * inspector/InspectorCanvas.cpp: (WebCore::InspectorCanvas::buildObjectForCanvas): * inspector/agents/InspectorCanvasAgent.cpp: (WebCore::InspectorCanvasAgent::enable): (WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext): Don't try to push the canvas' node to the frontend, as this will create a dangling node in `InspectorDOMAgent` if the canvas' node is detached from the DOM. Source/WebInspectorUI: Introduces a `WI.NavigationItem` for changing whether network entries are grouped by the node that initiated the load (if applicable). When grouped by node, a tree-like layout of the table cells (including expand/collapse) is used for resources that share the same initiator node. The values for the node's cell are based on it's initated resources. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Base/Setting.js: * UserInterface/Controllers/DOMManager.js: (WI.DOMManager): (WI.DOMManager.prototype._mainResourceDidChange): Added. Whenever the frame navigates, re-request the document so that `NetworkAgent` is able to send valid `nodeId` for each request's `initiatorNode`. This means that the document should always be available. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView): (WI.NetworkTableContentView.prototype.get filterNavigationItems): (WI.NetworkTableContentView.prototype.closed): (WI.NetworkTableContentView.prototype.reset): (WI.NetworkTableContentView.prototype.tableSortChanged): (WI.NetworkTableContentView.prototype.tableSelectedRowChanged): (WI.NetworkTableContentView.prototype.tablePopulateCell): (WI.NetworkTableContentView.prototype._populateNameCell.createIconElement): Added. (WI.NetworkTableContentView.prototype._populateNameCell): (WI.NetworkTableContentView.prototype._populateDomainCell.createIconAndText): Added. (WI.NetworkTableContentView.prototype._populateDomainCell): (WI.NetworkTableContentView.prototype._populateInitiatorCell): (WI.NetworkTableContentView.prototype._populateTransferSizeCell): (WI.NetworkTableContentView.prototype._generateSortComparator): (WI.NetworkTableContentView.prototype._processPendingEntries):
[webkit-changes] [236926] branches/safari-606.2.104.1-branch/LayoutTests
Title: [236926] branches/safari-606.2.104.1-branch/LayoutTests Revision 236926 Author ryanhad...@apple.com Date 2018-10-08 10:51:20 -0700 (Mon, 08 Oct 2018) Log Message Unreviewed, update TestExpectations for . * platform/mac-wk2/TestExpectations: Modified Paths branches/safari-606.2.104.1-branch/LayoutTests/ChangeLog branches/safari-606.2.104.1-branch/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: branches/safari-606.2.104.1-branch/LayoutTests/ChangeLog (236925 => 236926) --- branches/safari-606.2.104.1-branch/LayoutTests/ChangeLog 2018-10-08 17:34:45 UTC (rev 236925) +++ branches/safari-606.2.104.1-branch/LayoutTests/ChangeLog 2018-10-08 17:51:20 UTC (rev 236926) @@ -1,3 +1,9 @@ +2018-10-08 Ryan Haddad + +Unreviewed, update TestExpectations for . + +* platform/mac-wk2/TestExpectations: + 2018-09-28 Babak Shafiei Cherry-pick r236615. rdar://problem/44883290 Modified: branches/safari-606.2.104.1-branch/LayoutTests/platform/mac-wk2/TestExpectations (236925 => 236926) --- branches/safari-606.2.104.1-branch/LayoutTests/platform/mac-wk2/TestExpectations 2018-10-08 17:34:45 UTC (rev 236925) +++ branches/safari-606.2.104.1-branch/LayoutTests/platform/mac-wk2/TestExpectations 2018-10-08 17:51:20 UTC (rev 236926) @@ -742,7 +742,6 @@ [ HighSierra+ ] http/tests/storageAccess/request-storage-access-same-origin-sandboxed-iframe.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-nested-iframe.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction.html [ Pass ] -[ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-without-user-interaction.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-storage-access-top-frame.html [ Pass ] @@ -750,11 +749,14 @@ [ HighSierra+ ] http/tests/storageAccess/has-storage-access-from-prevalent-domain-with-non-recent-user-interaction.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/has-storage-access-from-prevalent-domain-with-recent-user-interaction.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html [ Pass ] -[ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Pass ] -[ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/deny-storage-access-under-opener.html [ Pass ] [ HighSierra+ ] http/tests/storageAccess/grant-storage-access-under-opener.html [ Pass ] +# +[ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Failure ] +[ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Failure ] +[ HighSierra+ ] http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame.html [ Failure ] + # As of https://trac.webkit.org/changeset/227762 the timestampResolution is just 5 seconds which makes this test flaky http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236925] tags/Safari-607.1.9.0.1/Source
Title: [236925] tags/Safari-607.1.9.0.1/Source Revision 236925 Author bshaf...@apple.com Date 2018-10-08 10:34:45 -0700 (Mon, 08 Oct 2018) Log Message Versioning. Modified Paths tags/Safari-607.1.9.0.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-607.1.9.0.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-607.1.9.0.1/Source/_javascript_Core/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -25,8 +25,8 @@ MINOR_VERSION = 1; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.9.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -25,8 +25,8 @@ MINOR_VERSION = 1; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.9.0.1/Source/WebCore/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/WebCore/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/WebCore/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -25,8 +25,8 @@ MINOR_VERSION = 1; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.9.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -25,8 +25,8 @@ MINOR_VERSION = 1; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.9.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -2,8 +2,8 @@ MINOR_VERSION = 1; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-607.1.9.0.1/Source/WebKit/Configurations/Version.xcconfig (236924 => 236925) --- tags/Safari-607.1.9.0.1/Source/WebKit/Configurations/Version.xcconfig 2018-10-08 17:32:46 UTC (rev 236924) +++ tags/Safari-607.1.9.0.1/Source/WebKit/Configurations/Version.xcconfig 2018-10-08 17:34:45 UTC (rev 236925) @@ -25,8 +25,8 @@
[webkit-changes] [236924] tags/Safari-607.1.9.0.1/
Title: [236924] tags/Safari-607.1.9.0.1/ Revision 236924 Author bshaf...@apple.com Date 2018-10-08 10:32:46 -0700 (Mon, 08 Oct 2018) Log Message Tag Safari-607.1.9.0.1. Added Paths tags/Safari-607.1.9.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236923] trunk/Source/WebInspectorUI
Title: [236923] trunk/Source/WebInspectorUI
Revision 236923
Author drou...@apple.com
Date 2018-10-08 10:24:15 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: clicking initiator link in Network Tab table doesn't automatically switch to Preview section
https://bugs.webkit.org/show_bug.cgi?id=190286
Reviewed by Brian Burg.
* UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView.prototype.shown):
(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236922 => 236923)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:22:18 UTC (rev 236922)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:24:15 UTC (rev 236923)
@@ -1,5 +1,16 @@
2018-10-08 Devin Rousso
+Web Inspector: clicking initiator link in Network Tab table doesn't automatically switch to Preview section
+https://bugs.webkit.org/show_bug.cgi?id=190286
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/NetworkResourceDetailView.js:
+(WI.NetworkResourceDetailView.prototype.shown):
+(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
+
+2018-10-08 Devin Rousso
+
Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=190304
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js (236922 => 236923)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js 2018-10-08 17:22:18 UTC (rev 236922)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js 2018-10-08 17:24:15 UTC (rev 236923)
@@ -58,6 +58,9 @@
this._showPreferredContentView();
if (this._contentViewCookie) {
+if ("lineNumber" in this._contentViewCookie && "columnNumber" in this._contentViewCookie)
+this._contentBrowser.navigationBar.selectedNavigationItem = this._previewNavigationItem;
+
this._contentBrowser.showContentView(this._contentBrowser.currentContentView, this._contentViewCookie);
this._contentViewCookie = null;
}
@@ -183,7 +186,11 @@
_showContentViewForNavigationItem(navigationItem)
{
-switch (navigationItem.identifier) {
+let identifier = navigationItem.identifier;
+if (this._contentViewCookie && "lineNumber" in this._contentViewCookie && "columnNumber" in this._contentViewCookie)
+identifier = this._previewNavigationItem.identifier;
+
+switch (identifier) {
case "preview":
if (!this._resourceContentView)
this._resourceContentView = this._contentBrowser.showContentViewForRepresentedObject(this._resource);
@@ -210,6 +217,8 @@
this._contentBrowser.showContentView(this._timingContentView, this._contentViewCookie);
break;
}
+
+this._contentViewCookie = null;
}
_navigationItemSelected(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236922] trunk
Title: [236922] trunk
Revision 236922
Author aes...@apple.com
Date 2018-10-08 10:22:18 -0700 (Mon, 08 Oct 2018)
Log Message
[Payment Request] Requests should be aborted after details settle when the user cancels
https://bugs.webkit.org/show_bug.cgi?id=190333
Reviewed by Alex Christensen.
Source/WebCore:
In Payment Request's "update a PaymentRequest's details" algorithm, user agents are expected
to disable the payment UI when PaymentRequest details are being updated by the merchant.
This is to prevent the user from accepting a payment before updated details are displayed.
Further, Payment Request's "user aborts the payment request" algorithm says that the
algorithm should be terminated prior to throwing an AbortError if the request is currently
being updated, and also that user agents SHOULD ensure this never occurs. This is based on
the assumption that payment UIs are disabled during details updates.
For Apple Pay, while it is true that a payment cannot be accepted by the user while details
are being updated by the merchant, the payment UI is not completely disabled. In particular,
the user is allowed to abort the payment while details are being updated. We need to honor
the user's request to abort without doing so in the middle of a details update.
This patch defers a user-initiated abort until after details are settled, at which point the
promise returned by show() is rejected with an AbortError. This behaves as if the details
update promise were rejected by the merchant.
Added a test case to http/tests/paymentrequest/payment-request-show-method.https.html.
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::settleDetailsPromise):
(WebCore::PaymentRequest::whenDetailsSettled):
(WebCore::PaymentRequest::cancel):
* Modules/paymentrequest/PaymentRequest.h:
LayoutTests:
* http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
* http/tests/paymentrequest/payment-request-show-method.https.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.h
Diff
Modified: trunk/LayoutTests/ChangeLog (236921 => 236922)
--- trunk/LayoutTests/ChangeLog 2018-10-08 17:19:09 UTC (rev 236921)
+++ trunk/LayoutTests/ChangeLog 2018-10-08 17:22:18 UTC (rev 236922)
@@ -1,3 +1,13 @@
+2018-10-08 Andy Estes
+
+[Payment Request] Requests should be aborted after details settle when the user cancels
+https://bugs.webkit.org/show_bug.cgi?id=190333
+
+Reviewed by Alex Christensen.
+
+* http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
+* http/tests/paymentrequest/payment-request-show-method.https.html:
+
2018-10-08 Ryan Haddad
REGRESSION (r235630?): [Mojave WK1] Layout test compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html is a flaky image failure
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt (236921 => 236922)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt 2018-10-08 17:19:09 UTC (rev 236921)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt 2018-10-08 17:22:18 UTC (rev 236922)
@@ -4,6 +4,7 @@
PASS If the user agent's "payment request is showing" boolean is true, then return a promise rejected with an "AbortError" DOMException.
PASS If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.
PASS If the user aborts the payment request algorithm, then return a promise rejected with an "AbortError" DOMException.
+PASS If the user aborts the payment request algorithm while details are updating, then reject the accept promise with an "AbortError" when the details settle.
PASS A request is updated when show()'s detail promise resolves.
PASS Change events do not occur until show()'s detail promise resolves.
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html (236921 => 236922)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html 2018-10-08 17:19:09 UTC (rev 236921)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html 2018-10-08 17:22:18 UTC (rev 236922)
@@ -78,6 +78,17 @@
user_activation_test(async t => {
const request = new PaymentRequest(defaultMethods, defaultDetails);
+ const acceptPromise = request.show(new Promise(resolve => {
+window.setTimeout(() => {
+ internals.mockPaymentCoordinator.cancelPayment();
+ window.setTimeout(() => resolve(defaultDetails));
+});
+ })); // Sets
[webkit-changes] [236921] trunk/LayoutTests
Title: [236921] trunk/LayoutTests Revision 236921 Author ryanhad...@apple.com Date 2018-10-08 10:19:09 -0700 (Mon, 08 Oct 2018) Log Message REGRESSION (r235630?): [Mojave WK1] Layout test compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=189756 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236920 => 236921) --- trunk/LayoutTests/ChangeLog 2018-10-08 17:17:21 UTC (rev 236920) +++ trunk/LayoutTests/ChangeLog 2018-10-08 17:19:09 UTC (rev 236921) @@ -1,3 +1,12 @@ +2018-10-08 Ryan Haddad + +REGRESSION (r235630?): [Mojave WK1] Layout test compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html is a flaky image failure +https://bugs.webkit.org/show_bug.cgi?id=189756 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2018-10-08 David Fenton Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (236920 => 236921) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-10-08 17:17:21 UTC (rev 236920) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-10-08 17:19:09 UTC (rev 236921) @@ -629,4 +629,6 @@ imported/w3c/web-platform-tests/css/css-properties-values-api/ [ Skip ] css-custom-properties-api [ Skip ] -webkit.org/b/189908 imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Failure ] \ No newline at end of file +webkit.org/b/189908 imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Failure ] + +webkit.org/b/189756 [ Mojave+ ] compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236920] trunk/Source/WebInspectorUI
Title: [236920] trunk/Source/WebInspectorUI
Revision 236920
Author drou...@apple.com
Date 2018-10-08 10:17:21 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=190304
Reviewed by Brian Burg.
* UserInterface/Base/Main.js:
(WI.tabContentViewClassForRepresentedObject):
* UserInterface/Views/ResourcesTabContentView.js:
(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236919 => 236920)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:17:21 UTC (rev 236920)
@@ -1,5 +1,17 @@
2018-10-08 Devin Rousso
+Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
+https://bugs.webkit.org/show_bug.cgi?id=190304
+
+Reviewed by Brian Burg.
+
+* UserInterface/Base/Main.js:
+(WI.tabContentViewClassForRepresentedObject):
+* UserInterface/Views/ResourcesTabContentView.js:
+(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
+
+2018-10-08 Devin Rousso
+
Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name)
https://bugs.webkit.org/show_bug.cgi?id=178153
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (236919 => 236920)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-08 17:17:21 UTC (rev 236920)
@@ -1099,10 +1099,13 @@
}
if (representedObject instanceof WI.Frame
+|| representedObject instanceof WI.FrameCollection
|| representedObject instanceof WI.Resource
+|| representedObject instanceof WI.ResourceCollection
|| representedObject instanceof WI.Script
+|| representedObject instanceof WI.ScriptCollection
|| representedObject instanceof WI.CSSStyleSheet
-|| (representedObject instanceof WI.Collection && !(representedObject instanceof WI.CanvasCollection)))
+|| representedObject instanceof WI.CSSStyleSheetCollection)
return WI.ResourcesTabContentView;
if (representedObject instanceof WI.DOMStorageObject || representedObject instanceof WI.CookieStorageObject ||
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js (236919 => 236920)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2018-10-08 17:17:21 UTC (rev 236920)
@@ -55,10 +55,13 @@
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WI.Frame
+|| representedObject instanceof WI.FrameCollection
|| representedObject instanceof WI.Resource
+|| representedObject instanceof WI.ResourceCollection
|| representedObject instanceof WI.Script
+|| representedObject instanceof WI.ScriptCollection
|| representedObject instanceof WI.CSSStyleSheet
-|| (representedObject instanceof WI.Collection && !(representedObject instanceof WI.CanvasCollection));
+|| representedObject instanceof WI.CSSStyleSheetCollection;
}
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236919] trunk/LayoutTests
Title: [236919] trunk/LayoutTests Revision 236919 Author realda...@apple.com Date 2018-10-08 10:16:30 -0700 (Mon, 08 Oct 2018) Log Message Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. https://bugs.webkit.org/show_bug.cgi?id=190353 Unreviewed. Remove the tests from TestExpectations file. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236918 => 236919) --- trunk/LayoutTests/ChangeLog 2018-10-08 17:15:19 UTC (rev 236918) +++ trunk/LayoutTests/ChangeLog 2018-10-08 17:16:30 UTC (rev 236919) @@ -1,3 +1,12 @@ +2018-10-08 David Fenton + +Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. +https://bugs.webkit.org/show_bug.cgi?id=190353 + +Unreviewed. Remove the tests from TestExpectations file. + +* platform/mac/TestExpectations: + 2018-10-08 Dawei Fenton Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. Modified: trunk/LayoutTests/platform/mac/TestExpectations (236918 => 236919) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-10-08 17:15:19 UTC (rev 236918) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-10-08 17:16:30 UTC (rev 236919) @@ -1773,6 +1773,4 @@ webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Slow ] -webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji-1.html [ Pass ] -webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji-9.html [ Pass ] -webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji.html [ Pass ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236918] trunk/Source/WebInspectorUI
Title: [236918] trunk/Source/WebInspectorUI
Revision 236918
Author drou...@apple.com
Date 2018-10-08 10:15:19 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name)
https://bugs.webkit.org/show_bug.cgi?id=178153
Reviewed by Brian Burg.
* UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._populateResourceTreeOutline):
* UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog .tree-outline.large .item .titles[data-path]): Added.
(.open-resource-dialog .tree-outline.large .item .titles[data-path]::after): Added.
(.open-resource-dialog .tree-outline.large .item .titles .title): Added.
(.open-resource-dialog .tree-outline.large .item .titles .subtitle): Added.
(.open-resource-dialog .tree-outline.large .item .titles): Deleted.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css
trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236917 => 236918)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:12:38 UTC (rev 236917)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:15:19 UTC (rev 236918)
@@ -1,3 +1,20 @@
+2018-10-08 Devin Rousso
+
+Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name)
+https://bugs.webkit.org/show_bug.cgi?id=178153
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/OpenResourceDialog.js:
+(WI.OpenResourceDialog.prototype._populateResourceTreeOutline):
+* UserInterface/Views/OpenResourceDialog.css:
+(.open-resource-dialog .tree-outline.large .item .titles[data-path]): Added.
+(.open-resource-dialog .tree-outline.large .item .titles[data-path]::after): Added.
+(.open-resource-dialog .tree-outline.large .item .titles .title): Added.
+(.open-resource-dialog .tree-outline.large .item .titles .subtitle): Added.
+(.open-resource-dialog .tree-outline.large .item .titles): Deleted.
+
2018-10-05 Devin Rousso
Web Inspector: add WebVTT MIME/file type mappings to the frontend
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css (236917 => 236918)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css 2018-10-08 17:12:38 UTC (rev 236917)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css 2018-10-08 17:15:19 UTC (rev 236918)
@@ -174,10 +174,24 @@
margin-top: 6px;
}
-.open-resource-dialog .tree-outline.large .item .titles {
-top: 14px;
+.open-resource-dialog .tree-outline.large .item .titles[data-path] {
+top: 6px;
}
+.open-resource-dialog .tree-outline.large .item .titles[data-path]::after {
+display: block;
+font-size: 10px;
+content: attr(data-path);
+}
+
+.open-resource-dialog .tree-outline.large .item .titles .title {
+font-size: 15px;
+}
+
+.open-resource-dialog .tree-outline.large .item .titles .subtitle {
+vertical-align: 2px;
+}
+
body[dir=ltr] .open-resource-dialog > .tree-outline .item {
padding-left: var(--open-resource-dialog-tree-outline-item-padding-start);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js (236917 => 236918)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js 2018-10-08 17:12:38 UTC (rev 236917)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js 2018-10-08 17:15:19 UTC (rev 236918)
@@ -110,6 +110,15 @@
continue;
treeElement.mainTitle = createHighlightedTitleFragment(resource.displayName, result.matchingTextRanges);
+
+let path = resource.urlComponents.path;
+let lastPathComponent = resource.urlComponents.lastPathComponent;
+if (path && lastPathComponent) {
+let parentPath = path.substring(0, path.length - lastPathComponent.length);
+if (parentPath.length && parentPath !== "/")
+treeElement.titlesElement.dataset.path = parentPath;
+}
+
treeElement[WI.OpenResourceDialog.ResourceMatchCookieDataSymbol] = result.cookie;
this._treeOutline.appendChild(treeElement);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236916] trunk/LayoutTests
Title: [236916] trunk/LayoutTests Revision 236916 Author realda...@apple.com Date 2018-10-08 09:58:18 -0700 (Mon, 08 Oct 2018) Log Message Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. https://bugs.webkit.org/show_bug.cgi?id=190353 Unreviewed test gardening. Patch by Dawei Fenton on 2018-10-08 * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236915 => 236916) --- trunk/LayoutTests/ChangeLog 2018-10-08 16:48:21 UTC (rev 236915) +++ trunk/LayoutTests/ChangeLog 2018-10-08 16:58:18 UTC (rev 236916) @@ -1,3 +1,12 @@ +2018-10-08 Dawei Fenton + +Layout Tests editing/deleting/delete-emoji.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-9.html are passing. +https://bugs.webkit.org/show_bug.cgi?id=190353 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2018-10-08 Truitt Savell Rebaseline imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.worker.html for Mojave Modified: trunk/LayoutTests/platform/mac/TestExpectations (236915 => 236916) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-10-08 16:48:21 UTC (rev 236915) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-10-08 16:58:18 UTC (rev 236916) @@ -1773,6 +1773,6 @@ webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Slow ] -[ Mojave+ ] editing/deleting/delete-emoji-1.html [ Failure ] -[ Mojave+ ] editing/deleting/delete-emoji-9.html [ Failure ] -[ Mojave+ ] editing/deleting/delete-emoji.html [ Failure ] +webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji-1.html [ Pass ] +webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji-9.html [ Pass ] +webkit.org/b/190353 [ Mojave+ ] editing/deleting/delete-emoji.html [ Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236914] trunk
Title: [236914] trunk Revision 236914 Author an...@apple.com Date 2018-10-08 09:09:28 -0700 (Mon, 08 Oct 2018) Log Message Move FontCascadeDescription to a file of its own https://bugs.webkit.org/show_bug.cgi?id=190348 Reviewed by Chris Dumez. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/FontCascade.h: * platform/graphics/FontCascadeDescription.cpp: Copied from Source/WebCore/platform/graphics/FontDescription.cpp. (WebCore::FontDescription::FontDescription): Deleted. (WebCore::m_shouldAllowUserInstalledFonts): Deleted. (WebCore::FontDescription::setLocale): Deleted. (WebCore::FontDescription::invalidateCaches): Deleted. * platform/graphics/FontCascadeDescription.h: Copied from Source/WebCore/platform/graphics/FontDescription.h. (WebCore::FontDescription::operator!= const): Deleted. (WebCore::FontDescription::computedSize const): Deleted. (WebCore::FontDescription::computedPixelSize const): Deleted. (WebCore::FontDescription::italic const): Deleted. (WebCore::FontDescription::stretch const): Deleted. (WebCore::FontDescription::weight const): Deleted. (WebCore::FontDescription::fontSelectionRequest const): Deleted. (WebCore::FontDescription::renderingMode const): Deleted. (WebCore::FontDescription::textRenderingMode const): Deleted. (WebCore::FontDescription::script const): Deleted. (WebCore::FontDescription::locale const): Deleted. (WebCore::FontDescription::orientation const): Deleted. (WebCore::FontDescription::nonCJKGlyphOrientation const): Deleted. (WebCore::FontDescription::widthVariant const): Deleted. (WebCore::FontDescription::featureSettings const): Deleted. (WebCore::FontDescription::variationSettings const): Deleted. (WebCore::FontDescription::fontSynthesis const): Deleted. (WebCore::FontDescription::variantCommonLigatures const): Deleted. (WebCore::FontDescription::variantDiscretionaryLigatures const): Deleted. (WebCore::FontDescription::variantHistoricalLigatures const): Deleted. (WebCore::FontDescription::variantContextualAlternates const): Deleted. (WebCore::FontDescription::variantPosition const): Deleted. (WebCore::FontDescription::variantCaps const): Deleted. (WebCore::FontDescription::variantNumericFigure const): Deleted. (WebCore::FontDescription::variantNumericSpacing const): Deleted. (WebCore::FontDescription::variantNumericFraction const): Deleted. (WebCore::FontDescription::variantNumericOrdinal const): Deleted. (WebCore::FontDescription::variantNumericSlashedZero const): Deleted. (WebCore::FontDescription::variantAlternates const): Deleted. (WebCore::FontDescription::variantEastAsianVariant const): Deleted. (WebCore::FontDescription::variantEastAsianWidth const): Deleted. (WebCore::FontDescription::variantEastAsianRuby const): Deleted. (WebCore::FontDescription::variantSettings const): Deleted. (WebCore::FontDescription::opticalSizing const): Deleted. (WebCore::FontDescription::fontStyleAxis const): Deleted. (WebCore::FontDescription::shouldAllowUserInstalledFonts const): Deleted. (WebCore::FontDescription::setComputedSize): Deleted. (WebCore::FontDescription::setItalic): Deleted. (WebCore::FontDescription::setStretch): Deleted. (WebCore::FontDescription::setIsItalic): Deleted. (WebCore::FontDescription::setWeight): Deleted. (WebCore::FontDescription::setRenderingMode): Deleted. (WebCore::FontDescription::setTextRenderingMode): Deleted. (WebCore::FontDescription::setOrientation): Deleted. (WebCore::FontDescription::setNonCJKGlyphOrientation): Deleted. (WebCore::FontDescription::setWidthVariant): Deleted. (WebCore::FontDescription::setFeatureSettings): Deleted. (WebCore::FontDescription::setVariationSettings): Deleted. (WebCore::FontDescription::setFontSynthesis): Deleted. (WebCore::FontDescription::setVariantCommonLigatures): Deleted. (WebCore::FontDescription::setVariantDiscretionaryLigatures): Deleted. (WebCore::FontDescription::setVariantHistoricalLigatures): Deleted. (WebCore::FontDescription::setVariantContextualAlternates): Deleted. (WebCore::FontDescription::setVariantPosition): Deleted. (WebCore::FontDescription::setVariantCaps): Deleted. (WebCore::FontDescription::setVariantNumericFigure): Deleted. (WebCore::FontDescription::setVariantNumericSpacing): Deleted. (WebCore::FontDescription::setVariantNumericFraction): Deleted. (WebCore::FontDescription::setVariantNumericOrdinal): Deleted. (WebCore::FontDescription::setVariantNumericSlashedZero): Deleted. (WebCore::FontDescription::setVariantAlternates): Deleted. (WebCore::FontDescription::setVariantEastAsianVariant): Deleted. (WebCore::FontDescription::setVariantEastAsianWidth): Deleted. (WebCore::FontDescription::setVariantEastAsianRuby): Deleted. (WebCore::FontDescription::setOpticalSizing): Deleted. (WebCore::FontDescription::setFontStyleAxis): Deleted. (WebCore::FontDescription::setShouldAllowUserInstalledFonts): Deleted. (WebCore::FontDescription::operator== const): Deleted. * platform/graphics/FontDescription.cpp: (WebCore::FontDescription::invalidateCaches):
[webkit-changes] [236913] trunk
Title: [236913] trunk Revision 236913 Author m...@apple.com Date 2018-10-08 06:55:14 -0700 (Mon, 08 Oct 2018) Log Message Source/ThirdParty: gtest part of [Xcode] Update some build settings as recommended by Xcode 10 https://bugs.webkit.org/show_bug.cgi?id=190250 Reviewed by Anders Carlsson. Didn’t turn on any of the warnings Xcode recommended for this third-party test support library. * gtest/xcode/Config/DebugProject.xcconfig: Set the deployment target in engineering builds like we do in other projects. This addresses a build-time warning when building clients of the library that its deployment target doesn’t match theirs. * gtest/xcode/Config/ReleaseProject.xcconfig: Ditto. * gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. Tools: Tools part of [Xcode] Update some build settings as recommended by Xcode 10 https://bugs.webkit.org/show_bug.cgi?id=190250 Reviewed by Anders Carlsson. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED. * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning. * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning around deprecated methods or categories on deprecated classes. * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto. (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): * DumpRenderTree/mac/TestRunnerMac.mm: Ditto. (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning. * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning. * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo), CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase. * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED. Made the WebKit headers be treated as system headers to avoid dealing with the fact that many C SPI headers trigger the strict prototypes warning. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. * TestWebKitAPI/Tests/WebKitCocoa/Download.mm: (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm: (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]): * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm: (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]): (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]): * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]): (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]): (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]): * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm: (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]): * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]): (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted. * TestWebKitAPI/mac/TestDraggingInfo.mm:
[webkit-changes] [236912] trunk/Source/WebCore
Title: [236912] trunk/Source/WebCore
Revision 236912
Author commit-qu...@webkit.org
Date 2018-10-08 06:25:02 -0700 (Mon, 08 Oct 2018)
Log Message
[EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc"
https://bugs.webkit.org/show_bug.cgi?id=189239
Patch by Yacine Bandou on 2018-10-08
Reviewed by Xabier Rodriguez-Calvar.
Add the support of GStreamer caps "application/x-webm-enc" in GStreamerCommon.
The DRM system id field in the encrypted event is set to GST_PROTECTION_UNSPECIFIED_SYSTEM_ID
in case of WebM, for details, see https://bugzilla.gnome.org/attachment.cgi?id=365211.
Tests: media/encrypted-media/clearKey/clearKey-encrypted-webm-eventmse.html
media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::capsMediaType):
(WebCore::areEncryptedCaps):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptTransformCaps):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236911 => 236912)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 06:18:17 UTC (rev 236911)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 13:25:02 UTC (rev 236912)
@@ -1,3 +1,27 @@
+2018-10-08 Yacine Bandou
+
+[EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc"
+https://bugs.webkit.org/show_bug.cgi?id=189239
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Add the support of GStreamer caps "application/x-webm-enc" in GStreamerCommon.
+
+The DRM system id field in the encrypted event is set to GST_PROTECTION_UNSPECIFIED_SYSTEM_ID
+in case of WebM, for details, see https://bugzilla.gnome.org/attachment.cgi?id=365211.
+
+Tests: media/encrypted-media/clearKey/clearKey-encrypted-webm-eventmse.html
+ media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html
+
+* platform/graphics/gstreamer/GStreamerCommon.cpp:
+(WebCore::capsMediaType):
+(WebCore::areEncryptedCaps):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
+* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
+* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
+(webkitMediaCommonEncryptionDecryptTransformCaps):
+
2018-10-07 Dan Bernstein
Fixed building with the latest macOS SDK
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (236911 => 236912)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2018-10-08 06:18:17 UTC (rev 236911)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2018-10-08 13:25:02 UTC (rev 236912)
@@ -151,7 +151,7 @@
return nullptr;
}
#if ENABLE(ENCRYPTED_MEDIA)
-if (gst_structure_has_name(structure, "application/x-cenc"))
+if (gst_structure_has_name(structure, "application/x-cenc") || gst_structure_has_name(structure, "application/x-webm-enc"))
return gst_structure_get_string(structure, "original-media-type");
#endif
return gst_structure_get_name(structure);
@@ -176,7 +176,7 @@
GST_WARNING("caps are empty");
return false;
}
-return gst_structure_has_name(structure, "application/x-cenc");
+return gst_structure_has_name(structure, "application/x-cenc") || gst_structure_has_name(structure, "application/x-webm-enc");
#else
UNUSED_PARAM(caps);
return false;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (236911 => 236912)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-10-08 06:18:17 UTC (rev 236911)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-10-08 13:25:02 UTC (rev 236912)
@@ -1274,7 +1274,7 @@
// Check if the system key of the protection event is the same of the CDM instance.
// For example: we can receive a new Widevine protection event but the CDM instance initialized with
// Playready, so we ignore this event.
-if (m_cdmInstance && g_strcmp0(GStreamerEMEUtilities::keySystemToUuid(m_cdmInstance->keySystem()), eventKeySystemUUID)) {
+if (m_cdmInstance &&
[webkit-changes] [236911] trunk/Tools
Title: [236911] trunk/Tools Revision 236911 Author commit-qu...@webkit.org Date 2018-10-07 23:18:17 -0700 (Sun, 07 Oct 2018) Log Message [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux https://bugs.webkit.org/show_bug.cgi?id=189238 Patch by Yacine Bandou on 2018-10-07 Reviewed by Xabier Rodriguez-Calvar. Modifications on GStreamer, tracked in GStreamer bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=797231 https://bugzilla.gnome.org/show_bug.cgi?id=765275 * gstreamer/jhbuild.modules: Add new patches. * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added. * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added. * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added. * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gstreamer/jhbuild.modules Added Paths trunk/Tools/gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch trunk/Tools/gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch trunk/Tools/gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch trunk/Tools/gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch Diff Modified: trunk/Tools/ChangeLog (236910 => 236911) --- trunk/Tools/ChangeLog 2018-10-07 22:53:12 UTC (rev 236910) +++ trunk/Tools/ChangeLog 2018-10-08 06:18:17 UTC (rev 236911) @@ -1,3 +1,20 @@ +2018-10-07 Yacine Bandou + +[GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux +https://bugs.webkit.org/show_bug.cgi?id=189238 + +Reviewed by Xabier Rodriguez-Calvar. + +Modifications on GStreamer, tracked in GStreamer bugzilla: +https://bugzilla.gnome.org/show_bug.cgi?id=797231 +https://bugzilla.gnome.org/show_bug.cgi?id=765275 + +* gstreamer/jhbuild.modules: Add new patches. +* gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added. +* gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added. +* gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added. +* gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added. + 2018-10-06 Dan Bernstein [Xcode] Never build yasm with ASAN Modified: trunk/Tools/gstreamer/jhbuild.modules (236910 => 236911) --- trunk/Tools/gstreamer/jhbuild.modules 2018-10-07 22:53:12 UTC (rev 236910) +++ trunk/Tools/gstreamer/jhbuild.modules 2018-10-08 06:18:17 UTC (rev 236911) @@ -52,6 +52,8 @@ + + @@ -89,6 +91,8 @@ + + Added: trunk/Tools/gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch (0 => 236911) --- trunk/Tools/gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch (rev 0) +++ trunk/Tools/gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch 2018-10-08 06:18:17 UTC (rev 236911) @@ -0,0 +1,842 @@ +From 69d896a02acef5cda9d727f46818bf0221fb82eb Mon Sep 17 00:00:00 2001 +From: Yacine Bandou +Date: Sun, 30 Sep 2018 19:28:07 +0200 +Subject: [PATCH] matroska: Add the WebM encrypted content support in + matroskademux + +This commit: + +1. Reads the WebM and Matroska ContentEncryption subelements. + +2. Creates a GST_PROTECTION event for each ContentEncryption, which + will be sent before pushing the first source buffer. + The DRM system id field in this event is set to GST_PROTECTION_UNSPECIFIED_SYSTEM_ID, + because it isn't specified neither by Matroska nor by the WebM spec. + +3. Reads the protection information of encrypted Block/SimpleBlock and + extracts the IV and the partitioning format (subsamples). + +4. Creates the metadata protection for each encrypted Block/SimpleBlock, + with those informations: KeyID (extracted from ContentEncryption element), + IV and partitioning format. + +5. Adds a new caps for WebM encrypted content named "application/x-webm-enc", + with the following new fields: + + "encryption-algorithm": The encryption algorithm used. + values: "None", "DES", "3DES", "Twofish", "Blowfish", "AES". + + "encoding-scope": The field that describes which Elements have been modified. + Values: "frame", "codec-data", "next-content". + + "cipher-mode": The cipher mode used in the encryption. + Values: "None", "CTR". +
