[webkit-changes] [238064] trunk/Source
Title: [238064] trunk/Source Revision 238064 Author za...@apple.com Date 2018-11-09 22:39:20 -0800 (Fri, 09 Nov 2018) Log Message [iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired. https://bugs.webkit.org/show_bug.cgi?id=191078 Reviewed by Antti Koivisto. Source/WebCore: 1. Improve visuallyNonEmpty milestone confidence level. Ignore whitespace and non visible text content. Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading. Check if the html/body is actually visible. 2. Issue initial paint soon after the milestone fires. Use a 0ms timer to flush the initial paint. Throttle additional flushes for 500ms and 1.5s (original behaviour). 3. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint. * dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::shouldScheduleLayout): * page/ChromeClient.h: * page/FrameView.cpp: (WebCore::FrameView::resetLayoutMilestones): (WebCore::FrameView::qualifiesAsVisuallyNonEmpty const): (WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded): (WebCore::FrameView::updateIsVisuallyNonEmpty): * page/FrameView.h: (WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content. * platform/graphics/FontCascade.h: * rendering/RenderText.cpp: Check whether the text is actually visible at this point. (WebCore::RenderText::RenderText): Source/WebKit: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::layerFlushThrottlingIsActive const): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/AcceleratedDrawingArea.cpp: (WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint): * WebProcess/WebPage/AcceleratedDrawingArea.h: * WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::layerFlushThrottlingIsActive const): * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea): (WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen): (WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint): (WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint): (WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush): * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/graphics/FontCascade.h trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.cpp trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: trunk/Source/WebCore/ChangeLog (238063 => 238064) --- trunk/Source/WebCore/ChangeLog 2018-11-10 04:50:03 UTC (rev 238063) +++ trunk/Source/WebCore/ChangeLog 2018-11-10 06:39:20 UTC (rev 238064) @@ -1,3 +1,39 @@ +2018-11-09 Zalan Bujtas + +[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired. +https://bugs.webkit.org/show_bug.cgi?id=191078 + + +Reviewed by Antti Koivisto. + +1. Improve visuallyNonEmpty milestone confidence level. +Ignore whitespace and non visible text content. +Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading. +Check if the html/body is actually visible. + +2. Issue initial paint soon after the milestone fires. +Use a 0ms timer to flush the initial paint. +Throttle additional flushes for 500ms and 1.5s (original behaviour). + +3. Suspend optional style recalcs and layouts while painting is being throttled. + When parsing yields we initiate a 0ms style recalc/layout timer. + These optional layouts produce content that we have no intention to paint. + +*
[webkit-changes] [238063] trunk/Source
Title: [238063] trunk/Source Revision 238063 Author wilan...@apple.com Date 2018-11-09 20:50:03 -0800 (Fri, 09 Nov 2018) Log Message Add ability to configure document.cookie lifetime cap through user defaults https://bugs.webkit.org/show_bug.cgi?id=191480 Reviewed by Chris Dumez. Source/WebCore: No new tests. Existing test makes sure we don't regress. This change makes the capped lifetime in seconds configurable through user defaults. * platform/network/NetworkStorageSession.h: * platform/network/cf/NetworkStorageSessionCFNet.cpp: (WebCore::NetworkStorageSession::setAgeCapForClientSideCookies): (WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted. Renamed setAgeCapForClientSideCookies(). * platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::filterCookies): (WebCore::NetworkStorageSession::setCookiesFromDOM const): Source/WebKit: This change makes the capped lifetime in seconds configurable through user defaults. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setAgeCapForClientSideCookies): (WebKit::NetworkProcess::setShouldCapLifetimeForClientSideCookies): Deleted. Renamed setAgeCapForClientSideCookies(). * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm: (WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded): * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::setAgeCapForClientSideCookies): (WebKit::NetworkProcessProxy::didSetAgeCapForClientSideCookies): (WebKit::NetworkProcessProxy::setShouldCapLifetimeForClientSideCookies): Deleted. Renamed setAgeCapForClientSideCookies(). (WebKit::NetworkProcessProxy::didSetShouldCapLifetimeForClientSideCookies): Deleted. Renamed didSetAgeCapForClientSideCookies(). * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::setAgeCapForClientSideCookies): (WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap): (WebKit::ResourceLoadStatisticsMemoryStore::didCreateNetworkProcess): New function that handles all the things that need to be done when a network process has been created. * UIProcess/ResourceLoadStatisticsMemoryStore.h: * UIProcess/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess): Now just calls the corresponding function on its memory store where all the configuration parameters are available. * UIProcess/WebResourceLoadStatisticsStore.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::setAgeCapForClientSideCookies): (WebKit::WebsiteDataStore::setShouldCapLifetimeForClientSideCookies): Deleted. Renamed setAgeCapForClientSideCookies(). * UIProcess/WebsiteData/WebsiteDataStore.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/NetworkStorageSession.h trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp trunk/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in trunk/Source/WebKit/UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.h trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h Diff Modified: trunk/Source/WebCore/ChangeLog (238062 => 238063) --- trunk/Source/WebCore/ChangeLog 2018-11-10 01:40:18 UTC (rev 238062) +++ trunk/Source/WebCore/ChangeLog 2018-11-10 04:50:03 UTC (rev 238063) @@ -1,3 +1,25 @@ +2018-11-09 John Wilander + +Add ability to configure document.cookie lifetime cap through user defaults +https://bugs.webkit.org/show_bug.cgi?id=191480 + + +Reviewed by Chris Dumez. + +No new tests. Existing test makes sure we don't regress. + +This change makes the capped lifetime in seconds configurable through +user defaults. + +* platform/network/NetworkStorageSession.h: +* platform/network/cf/NetworkStorageSessionCFNet.cpp: +(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies): +(WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted. +Renamed
[webkit-changes] [238062] trunk
Title: [238062] trunk Revision 238062 Author ryanhad...@apple.com Date 2018-11-09 17:40:18 -0800 (Fri, 09 Nov 2018) Log Message Unreviewed, rolling out r238047. Introduced layout test failures on iOS simulator. Reverted changeset: "[iOS] Draw caps lock indicator in password fields" https://bugs.webkit.org/show_bug.cgi?id=190565 https://trac.webkit.org/changeset/238047 Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebCore/platform/cocoa/KeyEventCocoa.mm trunk/Source/WebCore/platform/ios/KeyEventIOS.mm trunk/Source/WebCore/platform/ios/WebEvent.h trunk/Source/WebCore/platform/ios/WebEvent.mm trunk/Source/WebCore/platform/mac/KeyEventMac.mm trunk/Source/WebCore/rendering/RenderThemeCocoa.h trunk/Source/WebCore/rendering/RenderThemeCocoa.mm trunk/Source/WebCore/rendering/RenderThemeIOS.h trunk/Source/WebCore/rendering/RenderThemeIOS.mm trunk/Source/WebCore/rendering/RenderThemeMac.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd Diff Modified: trunk/Source/WebCore/ChangeLog (238061 => 238062) --- trunk/Source/WebCore/ChangeLog 2018-11-10 00:24:08 UTC (rev 238061) +++ trunk/Source/WebCore/ChangeLog 2018-11-10 01:40:18 UTC (rev 238062) @@ -1,3 +1,15 @@ +2018-11-09 Ryan Haddad + +Unreviewed, rolling out r238047. + +Introduced layout test failures on iOS simulator. + +Reverted changeset: + +"[iOS] Draw caps lock indicator in password fields" +https://bugs.webkit.org/show_bug.cgi?id=190565 +https://trac.webkit.org/changeset/238047 + 2018-11-09 Tim Horton Normal-flow-only flex items don't correctly respect z-index Modified: trunk/Source/WebCore/PAL/ChangeLog (238061 => 238062) --- trunk/Source/WebCore/PAL/ChangeLog 2018-11-10 00:24:08 UTC (rev 238061) +++ trunk/Source/WebCore/PAL/ChangeLog 2018-11-10 01:40:18 UTC (rev 238062) @@ -1,3 +1,15 @@ +2018-11-09 Ryan Haddad + +Unreviewed, rolling out r238047. + +Introduced layout test failures on iOS simulator. + +Reverted changeset: + +"[iOS] Draw caps lock indicator in password fields" +https://bugs.webkit.org/show_bug.cgi?id=190565 +https://trac.webkit.org/changeset/238047 + 2018-11-09 Daniel Bates [iOS] Draw caps lock indicator in password fields Modified: trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h (238061 => 238062) --- trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2018-11-10 00:24:08 UTC (rev 238061) +++ trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2018-11-10 01:40:18 UTC (rev 238062) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2014-2018 Apple Inc. All rights reserved. + * Copyright (C) 2014 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -43,12 +43,6 @@ void GSFontInitialize(void); void GSFontPurgeFontCache(void); -typedef struct __GSKeyboard* GSKeyboardRef; -uint32_t GSKeyboardGetModifierState(GSKeyboardRef); -Boolean GSEventIsHardwareKeyboardAttached(); - -extern const char *kGSEventHardwareKeyboardAvailabilityChangedNotification; - WTF_EXTERN_C_END #endif Modified: trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h (238061 => 238062) --- trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h 2018-11-10 00:24:08 UTC (rev 238061) +++ trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h 2018-11-10 01:40:18 UTC (rev 238062) @@ -23,10 +23,6 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ -WTF_EXTERN_C_BEGIN -typedef struct __GSKeyboard* GSKeyboardRef; -WTF_EXTERN_C_END - #if USE(APPLE_INTERNAL_SDK) #import @@ -48,7 +44,6 @@ @interface UIApplication () + (UIApplicationSceneClassicMode)_classicMode; -- (GSKeyboardRef)_hardwareKeyboard; @end #else @@ -80,9 +75,10 @@ @end @interface UIApplication () + - (BOOL)_isClassic; + (UIApplicationSceneClassicMode)_classicMode; -- (GSKeyboardRef)_hardwareKeyboard; + @end @interface UIColor () Modified:
[webkit-changes] [238061] trunk
Title: [238061] trunk
Revision 238061
Author cdu...@apple.com
Date 2018-11-09 16:24:08 -0800 (Fri, 09 Nov 2018)
Log Message
Suspended page persists even after back/forward list item is gone
https://bugs.webkit.org/show_bug.cgi?id=191488
Reviewed by Geoffrey Garen.
Source/WebKit:
Currently, the WebProcessPool owns the SuspendedPageProxy objects and makes sure we cap how
many we can have. The WebBackForwardListItem merely has a WeakPtr to its associated
SuspendedPageProxy. However, there is no point in having the WebProcessPool keeping a
SuspendedPageProxy object alive if there is no longer any WebBackForwardListItem pointing
to it.
To address the issue, WebBackForwardListItem nows tells the WebProcessPool to destroy
its SuspendedPageProxy when necessary. WebBackForwardList also takes care of nulling
out the WebBackForwardListItem's SuspendedPageProxy after the item has been removed
from the list (in case somebody keeps the item alive).
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setSuspendedPage):
(WebKit::WebBackForwardListItem::suspendedPageIsNoLongerNeeded):
* Shared/WebBackForwardListItem.h:
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::didRemoveItem):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::removeSuspendedPageProxy):
* UIProcess/WebProcessPool.h:
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp
trunk/Source/WebKit/Shared/WebBackForwardListItem.h
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebBackForwardList.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238060 => 238061)
--- trunk/Source/WebKit/ChangeLog 2018-11-09 23:10:47 UTC (rev 238060)
+++ trunk/Source/WebKit/ChangeLog 2018-11-10 00:24:08 UTC (rev 238061)
@@ -1,3 +1,35 @@
+2018-11-09 Chris Dumez
+
+Suspended page persists even after back/forward list item is gone
+https://bugs.webkit.org/show_bug.cgi?id=191488
+
+
+Reviewed by Geoffrey Garen.
+
+Currently, the WebProcessPool owns the SuspendedPageProxy objects and makes sure we cap how
+many we can have. The WebBackForwardListItem merely has a WeakPtr to its associated
+SuspendedPageProxy. However, there is no point in having the WebProcessPool keeping a
+SuspendedPageProxy object alive if there is no longer any WebBackForwardListItem pointing
+to it.
+
+To address the issue, WebBackForwardListItem nows tells the WebProcessPool to destroy
+its SuspendedPageProxy when necessary. WebBackForwardList also takes care of nulling
+out the WebBackForwardListItem's SuspendedPageProxy after the item has been removed
+from the list (in case somebody keeps the item alive).
+
+* Shared/WebBackForwardListItem.cpp:
+(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
+(WebKit::WebBackForwardListItem::setSuspendedPage):
+(WebKit::WebBackForwardListItem::suspendedPageIsNoLongerNeeded):
+* Shared/WebBackForwardListItem.h:
+* UIProcess/SuspendedPageProxy.cpp:
+(WebKit::SuspendedPageProxy::SuspendedPageProxy):
+* UIProcess/WebBackForwardList.cpp:
+(WebKit::WebBackForwardList::didRemoveItem):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::removeSuspendedPageProxy):
+* UIProcess/WebProcessPool.h:
+
2018-11-09 Wenson Hsieh
[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
Modified: trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp (238060 => 238061)
--- trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp 2018-11-09 23:10:47 UTC (rev 238060)
+++ trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp 2018-11-10 00:24:08 UTC (rev 238061)
@@ -27,6 +27,8 @@
#include "WebBackForwardListItem.h"
#include "SuspendedPageProxy.h"
+#include "WebProcessPool.h"
+#include "WebProcessProxy.h"
#include
#include
@@ -51,6 +53,8 @@
{
ASSERT(allItems().get(m_itemState.identifier) == this);
allItems().remove(m_itemState.identifier);
+
+removeSuspendedPageFromProcessPool();
}
HashMap& WebBackForwardListItem::allItems()
@@ -113,11 +117,24 @@
return documentTreesAreEqual(mainFrameState, otherMainFrameState);
}
-void WebBackForwardListItem::setSuspendedPage(SuspendedPageProxy& page)
+void WebBackForwardListItem::setSuspendedPage(SuspendedPageProxy* page)
[webkit-changes] [238060] trunk/LayoutTests
Title: [238060] trunk/LayoutTests
Revision 238060
Author megan_gard...@apple.com
Date 2018-11-09 15:10:47 -0800 (Fri, 09 Nov 2018)
Log Message
Fix Test Expectations for Reveal Test
https://bugs.webkit.org/show_bug.cgi?id=191476
Unreviewed test gardening.
Put the test expectation in the correct location to deal with
the different behaviour old platforms.
* platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/editing/mac/selection/
trunk/LayoutTests/platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt
Removed Paths
trunk/LayoutTests/platform/mac-highsierra/editing/mac/
Diff
Modified: trunk/LayoutTests/ChangeLog (238059 => 238060)
--- trunk/LayoutTests/ChangeLog 2018-11-09 23:04:58 UTC (rev 238059)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 23:10:47 UTC (rev 238060)
@@ -1,3 +1,15 @@
+2018-11-09 Megan Gardner
+
+Fix Test Expectations for Reveal Test
+https://bugs.webkit.org/show_bug.cgi?id=191476
+
+Unreviewed test gardening.
+
+Put the test expectation in the correct location to deal with
+the different behaviour old platforms.
+
+* platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt.
+
2018-11-09 Tim Horton
Normal-flow-only flex items don't correctly respect z-index
Copied: trunk/LayoutTests/platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt (from rev 238059, trunk/LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt) (0 => 238060)
--- trunk/LayoutTests/platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt 2018-11-09 23:10:47 UTC (rev 238060)
@@ -0,0 +1,15 @@
+This test checks that conext menu selection allows whitespace for non-editable fields. To test manually, right click on the blank text in the input box.
+
+The crowd says: New York, New Yorkis a helluva town!
+The crowd says: New York, New Yorkis a helluva town!
+
+
+
+
+PASS getSelectionForId('inputWhitespace') is ""
+FAIL getSelectionForId('readOnlyWhitespace') should be . Was New York, New York.
+PASS successfullyParsed is true
+Some tests failed.
+
+TEST COMPLETE
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238059] trunk/Source/WebKitLegacy/win
Title: [238059] trunk/Source/WebKitLegacy/win
Revision 238059
Author ross.kirsl...@sony.com
Date 2018-11-09 15:04:58 -0800 (Fri, 09 Nov 2018)
Log Message
Unreviewed Windows build fix for r238049.
* WebView.cpp:
(WebView::initWithFrame):
Modified Paths
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238058 => 238059)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-09 22:57:31 UTC (rev 238058)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-09 23:04:58 UTC (rev 238059)
@@ -1,5 +1,12 @@
2018-11-09 Ross Kirsling
+Unreviewed Windows build fix for r238049.
+
+* WebView.cpp:
+(WebView::initWithFrame):
+
+2018-11-09 Ross Kirsling
+
Unreviewed MSVC build fix after r238039 (and r238046).
* WebDocumentLoader.h:
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (238058 => 238059)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2018-11-09 22:57:31 UTC (rev 238058)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2018-11-09 23:04:58 UTC (rev 238059)
@@ -3128,10 +3128,8 @@
m_page = new Page(WTFMove(configuration));
provideGeolocationTo(m_page, *new WebGeolocationClient(this));
-unsigned layoutMilestones = DidFirstLayout | DidFirstVisuallyNonEmptyLayout;
-m_page->addLayoutMilestones(static_cast(layoutMilestones));
+m_page->addLayoutMilestones({ DidFirstLayout, DidFirstVisuallyNonEmptyLayout });
-
if (m_uiDelegate) {
BString path;
if (SUCCEEDED(m_uiDelegate->ftpDirectoryTemplatePath(this, )))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238058] trunk
Title: [238058] trunk
Revision 238058
Author timothy_hor...@apple.com
Date 2018-11-09 14:57:31 -0800 (Fri, 09 Nov 2018)
Log Message
Normal-flow-only flex items don't correctly respect z-index
https://bugs.webkit.org/show_bug.cgi?id=191486
Reviewed by Simon Fraser.
Source/WebCore:
Test: css3/flexbox/z-index-with-normal-flow-only.html
* rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
r125693 did not ensure that flex items which would otherwise be
normal-flow-only would be put into the z-order tree when necessary.
Fix by respecting the same trigger we use to make layers for flex items;
namely, not having auto z-index.
LayoutTests:
* css3/flexbox/z-index-with-normal-flow-only-expected.html: Added.
* css3/flexbox/z-index-with-normal-flow-only.html: Added.
Add a test that a with z-index 50 correctly stacks below
a that is a flex-item with z-index 100.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only-expected.html
trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238057 => 238058)
--- trunk/LayoutTests/ChangeLog 2018-11-09 22:50:47 UTC (rev 238057)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 22:57:31 UTC (rev 238058)
@@ -1,3 +1,15 @@
+2018-11-09 Tim Horton
+
+Normal-flow-only flex items don't correctly respect z-index
+https://bugs.webkit.org/show_bug.cgi?id=191486
+
+Reviewed by Simon Fraser.
+
+* css3/flexbox/z-index-with-normal-flow-only-expected.html: Added.
+* css3/flexbox/z-index-with-normal-flow-only.html: Added.
+Add a test that a with z-index 50 correctly stacks below
+a that is a flex-item with z-index 100.
+
2018-11-09 Jer Noble
SourceBuffer throws an error when appending a second init segment after changeType().
Added: trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only-expected.html (0 => 238058)
--- trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only-expected.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only-expected.html 2018-11-09 22:57:31 UTC (rev 238058)
@@ -0,0 +1,9 @@
+
+
+div {
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+
Added: trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only.html (0 => 238058)
--- trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/z-index-with-normal-flow-only.html 2018-11-09 22:57:31 UTC (rev 238058)
@@ -0,0 +1,19 @@
+
+
+canvas {
+width: 100px;
+height: 100px;
+}
+
+.positioned {
+position: absolute;
+left: 0;
+top: 0;
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (238057 => 238058)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 22:50:47 UTC (rev 238057)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 22:57:31 UTC (rev 238058)
@@ -1,3 +1,19 @@
+2018-11-09 Tim Horton
+
+Normal-flow-only flex items don't correctly respect z-index
+https://bugs.webkit.org/show_bug.cgi?id=191486
+
+Reviewed by Simon Fraser.
+
+Test: css3/flexbox/z-index-with-normal-flow-only.html
+
+* rendering/RenderLayer.cpp:
+(WebCore::canCreateStackingContext):
+r125693 did not ensure that flex items which would otherwise be
+normal-flow-only would be put into the z-order tree when necessary.
+Fix by respecting the same trigger we use to make layers for flex items;
+namely, not having auto z-index.
+
2018-11-09 Wenson Hsieh
[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (238057 => 238058)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-11-09 22:50:47 UTC (rev 238057)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-11-09 22:57:31 UTC (rev 238058)
@@ -529,6 +529,7 @@
|| renderer.isPositioned() // Note that this only creates stacking context in conjunction with explicit z-index.
|| renderer.hasReflection()
|| renderer.style().hasIsolation()
+|| !renderer.style().hasAutoZIndex()
#if PLATFORM(IOS_FAMILY)
|| layer.canUseAcceleratedTouchScrolling()
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238057] trunk
Title: [238057] trunk
Revision 238057
Author wenson_hs...@apple.com
Date 2018-11-09 14:50:47 -0800 (Fri, 09 Nov 2018)
Log Message
[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
https://bugs.webkit.org/show_bug.cgi?id=191471
Reviewed by Tim Horton.
Source/WebCore:
Add new method stubs for changing the list type for the current selection (to be implemented in a future patch).
* editing/Editor.cpp:
(WebCore::Editor::canChangeSelectionListType):
(WebCore::Editor::changeSelectionListType):
* editing/Editor.h:
Source/WebKit:
Implement these method stubs by calling into Editor.
Test: WKWebViewEditActions.ModifyListLevel
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):
Tools:
Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (238056 => 238057)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 22:34:47 UTC (rev 238056)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 22:50:47 UTC (rev 238057)
@@ -1,3 +1,18 @@
+2018-11-09 Wenson Hsieh
+
+[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
+https://bugs.webkit.org/show_bug.cgi?id=191471
+
+
+Reviewed by Tim Horton.
+
+Add new method stubs for changing the list type for the current selection (to be implemented in a future patch).
+
+* editing/Editor.cpp:
+(WebCore::Editor::canChangeSelectionListType):
+(WebCore::Editor::changeSelectionListType):
+* editing/Editor.h:
+
2018-11-09 Keith Rollin
Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
Modified: trunk/Source/WebCore/editing/Editor.cpp (238056 => 238057)
--- trunk/Source/WebCore/editing/Editor.cpp 2018-11-09 22:34:47 UTC (rev 238056)
+++ trunk/Source/WebCore/editing/Editor.cpp 2018-11-09 22:50:47 UTC (rev 238057)
@@ -1476,6 +1476,17 @@
setStartNewKillRingSequence(false);
}
+bool Editor::canChangeSelectionListType()
+{
+// FIXME: Not implemented.
+return false;
+}
+
+void Editor::changeSelectionListType()
+{
+// FIXME: Not implemented.
+}
+
void Editor::simplifyMarkup(Node* startNode, Node* endNode)
{
if (!startNode)
Modified: trunk/Source/WebCore/editing/Editor.h (238056 => 238057)
--- trunk/Source/WebCore/editing/Editor.h 2018-11-09 22:34:47 UTC (rev 238056)
+++ trunk/Source/WebCore/editing/Editor.h 2018-11-09 22:50:47 UTC (rev 238057)
@@ -206,6 +206,8 @@
WEBCORE_EXPORT RefPtr increaseSelectionListLevelOrdered();
WEBCORE_EXPORT RefPtr increaseSelectionListLevelUnordered();
WEBCORE_EXPORT void decreaseSelectionListLevel();
+WEBCORE_EXPORT bool canChangeSelectionListType();
+WEBCORE_EXPORT void changeSelectionListType();
void removeFormattingAndStyle();
Modified: trunk/Source/WebKit/ChangeLog (238056 => 238057)
--- trunk/Source/WebKit/ChangeLog 2018-11-09 22:34:47 UTC (rev 238056)
+++ trunk/Source/WebKit/ChangeLog 2018-11-09 22:50:47 UTC (rev 238057)
@@ -1,3 +1,20 @@
+2018-11-09 Wenson Hsieh
+
+[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
+https://bugs.webkit.org/show_bug.cgi?id=191471
+
+
+Reviewed by Tim Horton.
+
+Implement these method stubs by calling into Editor.
+
+Test: WKWebViewEditActions.ModifyListLevel
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::increaseListLevel):
+(WebKit::WebPage::decreaseListLevel):
+(WebKit::WebPage::changeListType):
+
2018-11-09 Keith Rollin
Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (238056 => 238057)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-11-09 22:34:47 UTC (rev 238056)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-11-09 22:50:47 UTC (rev 238057)
@@ -1152,17 +1152,23 @@
void WebPage::increaseListLevel()
{
-// FIXME: Not implemented.
+auto& editor = m_page->focusController().focusedOrMainFrame().editor();
+if (editor.canIncreaseSelectionListLevel())
+editor.increaseSelectionListLevel();
}
void WebPage::decreaseListLevel()
{
-// FIXME: Not implemented.
+auto& editor = m_page->focusController().focusedOrMainFrame().editor();
+if (editor.canDecreaseSelectionListLevel())
+editor.decreaseSelectionListLevel();
}
void
[webkit-changes] [238056] trunk/Websites/webkit.org
Title: [238056] trunk/Websites/webkit.org
Revision 238056
Author j...@apple.com
Date 2018-11-09 14:34:47 -0800 (Fri, 09 Nov 2018)
Log Message
Clean-up stray whitespace in theme files
https://bugs.webkit.org/show_bug.cgi?id=191430
Reviewed by Dean Jackson.
* wp-content/themes/webkit/css-status.php:
* wp-content/themes/webkit/footer.php:
* wp-content/themes/webkit/front-page.php:
* wp-content/themes/webkit/includes.php:
* wp-content/themes/webkit/nightly-start.php:
* wp-content/themes/webkit/nightly-survey.php:
* wp-content/themes/webkit/page.php:
* wp-content/themes/webkit/scripts/global.js:
* wp-content/themes/webkit/scripts/searchbuilds.js:
(initsearch):
(initsearch.displayError):
* wp-content/themes/webkit/single.php:
* wp-content/themes/webkit/sitemap.php:
* wp-content/themes/webkit/team.php:
* wp-content/themes/webkit/widgets/icon.php:
* wp-content/themes/webkit/widgets/page.php:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/css-status.php
trunk/Websites/webkit.org/wp-content/themes/webkit/footer.php
trunk/Websites/webkit.org/wp-content/themes/webkit/front-page.php
trunk/Websites/webkit.org/wp-content/themes/webkit/includes.php
trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php
trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-survey.php
trunk/Websites/webkit.org/wp-content/themes/webkit/page.php
trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/global.js
trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/searchbuilds.js
trunk/Websites/webkit.org/wp-content/themes/webkit/single.php
trunk/Websites/webkit.org/wp-content/themes/webkit/sitemap.php
trunk/Websites/webkit.org/wp-content/themes/webkit/team.php
trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php
trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/page.php
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (238055 => 238056)
--- trunk/Websites/webkit.org/ChangeLog 2018-11-09 22:32:12 UTC (rev 238055)
+++ trunk/Websites/webkit.org/ChangeLog 2018-11-09 22:34:47 UTC (rev 238056)
@@ -1,3 +1,27 @@
+2018-11-09 Jon Davis
+
+Clean-up stray whitespace in theme files
+https://bugs.webkit.org/show_bug.cgi?id=191430
+
+Reviewed by Dean Jackson.
+
+* wp-content/themes/webkit/css-status.php:
+* wp-content/themes/webkit/footer.php:
+* wp-content/themes/webkit/front-page.php:
+* wp-content/themes/webkit/includes.php:
+* wp-content/themes/webkit/nightly-start.php:
+* wp-content/themes/webkit/nightly-survey.php:
+* wp-content/themes/webkit/page.php:
+* wp-content/themes/webkit/scripts/global.js:
+* wp-content/themes/webkit/scripts/searchbuilds.js:
+(initsearch):
+(initsearch.displayError):
+* wp-content/themes/webkit/single.php:
+* wp-content/themes/webkit/sitemap.php:
+* wp-content/themes/webkit/team.php:
+* wp-content/themes/webkit/widgets/icon.php:
+* wp-content/themes/webkit/widgets/page.php:
+
2018-11-02 Jon Davis
Follow-up fix for the webkit.org blog index page
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/css-status.php (238055 => 238056)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/css-status.php 2018-11-09 22:32:12 UTC (rev 238055)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/css-status.php 2018-11-09 22:34:47 UTC (rev 238056)
@@ -564,7 +564,7 @@
'obsolete',
'removed',
];
-
+
const readableStatus = {
'supported': 'Supported',
'in-development': 'In Development',
@@ -636,7 +636,7 @@
container.appendChild(link);
return container;
}
-
+
function appendValueWithLink(container, value, link)
{
if (link) {
@@ -646,7 +646,7 @@
container.appendChild(anchor);
return;
}
-
+
container.textContent = value;
}
@@ -729,15 +729,15 @@
longhandLink.textContent = longhand;
longhandsDiv.appendChild(longhandLink);
}
-
+
toggledContentContainer.appendChild(longhandsDiv);
}
-
+
function collapsePrefixedValues(values)
{
var remainingValues = [];
var prefixMap = {};
-
+
for (var valueObj of values) {
var valueName = valueObj.value;
@@ -750,15 +750,15 @@
continue;
}
}
-
+
remainingValues.push(valueObj);
}
-
+
for (var prefixed in prefixMap) {
var unprefixedValue = findValueByName(remainingValues, prefixed);
unprefixedValue.aliases = prefixMap[prefixed];
}
-
+
[webkit-changes] [238055] trunk/Source
Title: [238055] trunk/Source
Revision 238055
Author krol...@apple.com
Date 2018-11-09 14:32:12 -0800 (Fri, 09 Nov 2018)
Log Message
Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
Remove the use of .xcfilelists until their side-effects are better
understood.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj:
Source/WebCore:
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (238054 => 238055)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-09 22:32:12 UTC (rev 238055)
@@ -1,3 +1,12 @@
+2018-11-09 Keith Rollin
+
+Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
+
+Remove the use of .xcfilelists until their side-effects are better
+understood.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+
2018-11-09 Keith Miller
LLInt VectorSizeOffset should be based on offset extraction
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (238054 => 238055)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2018-11-09 22:32:12 UTC (rev 238055)
@@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
- objectVersion = 51;
+ objectVersion = 46;
objects = {
/* Begin PBXAggregateTarget section */
@@ -10163,7 +10163,6 @@
);
name = "Generate Unified Sources";
outputFileListPaths = (
-"$(SRCROOT)/UnifiedSources.xcfilelist",
);
outputPaths = (
);
@@ -10273,7 +10272,6 @@
);
name = "Generate Derived Sources";
outputFileListPaths = (
-"$(SRCROOT)/DerivedSources.xcfilelist",
);
outputPaths = (
);
Modified: trunk/Source/WebCore/ChangeLog (238054 => 238055)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 22:32:12 UTC (rev 238055)
@@ -1,3 +1,12 @@
+2018-11-09 Keith Rollin
+
+Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
+
+Remove the use of .xcfilelists until their side-effects are better
+understood.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2018-11-09 Jer Noble
SourceBuffer throws an error when appending a second init segment after changeType().
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (238054 => 238055)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-11-09 22:32:12 UTC (rev 238055)
@@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
- objectVersion = 51;
+ objectVersion = 46;
objects = {
/* Begin PBXAggregateTarget section */
@@ -32019,7 +32019,6 @@
);
name = "Generate Unified Sources";
outputFileListPaths = (
-"$(SRCROOT)/UnifiedSources.xcfilelist",
);
outputPaths = (
);
@@ -32124,7 +32123,6 @@
);
name = "Generate Derived Sources";
outputFileListPaths = (
-"$(SRCROOT)/DerivedSources.xcfilelist",
);
outputPaths = (
);
Modified: trunk/Source/WebKit/ChangeLog (238054 => 238055)
--- trunk/Source/WebKit/ChangeLog 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/WebKit/ChangeLog 2018-11-09 22:32:12 UTC (rev 238055)
@@ -1,3 +1,12 @@
+2018-11-09 Keith Rollin
+
+Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
+
+Remove the use of .xcfilelists until their side-effects are better
+understood.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2018-11-09 Basuke Suzuki
[Curl][WebKit] Implement Proxy configuration API.
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (238054 => 238055)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-11-09 21:59:22 UTC (rev 238054)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-11-09 22:32:12 UTC (rev 238055)
@@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
- objectVersion = 51;
+ objectVersion = 46;
objects = {
/* Begin PBXAggregateTarget section */
@@ -10189,7 +10189,6 @@
);
name = "Generate Unified Sources";
outputFileListPaths = (
-"$(SRCROOT)/UnifiedSources.xcfilelist",
);
outputPaths = (
);
@@ -10553,7 +10552,6 @@
);
name = "Generate Derived Sources";
outputFileListPaths = (
-"$(SRCROOT)/DerivedSources.xcfilelist",
);
outputPaths = (
[webkit-changes] [238054] trunk
Title: [238054] trunk
Revision 238054
Author jer.no...@apple.com
Date 2018-11-09 13:59:22 -0800 (Fri, 09 Nov 2018)
Log Message
SourceBuffer throws an error when appending a second init segment after changeType().
https://bugs.webkit.org/show_bug.cgi?id=191474
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-changetype-second-init.html
When encountering an initialization segment after changeType(), add the parsed codec types
to the list of allowed codecs.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::validateInitializationSegment):
* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::supportsType):
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::canSwitchToType):
* platform/mock/mediasource/MockSourceBufferPrivate.h:
LayoutTests:
* media/media-source/media-source-changetype-second-init-expected.txt: Added.
* media/media-source/media-source-changetype-second-init.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp
trunk/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp
trunk/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h
Added Paths
trunk/LayoutTests/media/media-source/media-source-changetype-second-init-expected.txt
trunk/LayoutTests/media/media-source/media-source-changetype-second-init.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238053 => 238054)
--- trunk/LayoutTests/ChangeLog 2018-11-09 21:26:16 UTC (rev 238053)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 21:59:22 UTC (rev 238054)
@@ -1,3 +1,13 @@
+2018-11-09 Jer Noble
+
+SourceBuffer throws an error when appending a second init segment after changeType().
+https://bugs.webkit.org/show_bug.cgi?id=191474
+
+Reviewed by Eric Carlson.
+
+* media/media-source/media-source-changetype-second-init-expected.txt: Added.
+* media/media-source/media-source-changetype-second-init.html: Added.
+
2018-11-09 Andy Estes
[Payment Request] canMakePayment() should not consider serialized payment method data
Added: trunk/LayoutTests/media/media-source/media-source-changetype-second-init-expected.txt (0 => 238054)
--- trunk/LayoutTests/media/media-source/media-source-changetype-second-init-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-changetype-second-init-expected.txt 2018-11-09 21:59:22 UTC (rev 238054)
@@ -0,0 +1,13 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock"))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.changeType("video/mock; codecs=kcom"))
+RUN(sourceBuffer.appendBuffer(initSegment2))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(initSegment2))
+EVENT(updateend)
+END OF TEST
+
Added: trunk/LayoutTests/media/media-source/media-source-changetype-second-init.html (0 => 238054)
--- trunk/LayoutTests/media/media-source/media-source-changetype-second-init.html (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-changetype-second-init.html 2018-11-09 21:59:22 UTC (rev 238054)
@@ -0,0 +1,48 @@
+
+
+
+mock-media-source
+
+var source;
+var sourceBuffer;
+var initSegment;
+var initSegment2;
+var samples;
+
+if (window.internals)
+internals.initializeMockMediaSource();
+
+async function runTest() {
+findMediaElement();
+
+source = new MediaSource();
+testExpected('source.readyState', 'closed');
+
+video.srcObject = source;
+await waitFor(source, 'sourceopen');
+
+run('sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock")');
+initSegment = makeAInit(8, [makeATrack(1, 'mock', TRACK_KIND.VIDEO)]);
+run('sourceBuffer.appendBuffer(initSegment)');
+await waitFor(sourceBuffer, 'updateend');
+
+run('sourceBuffer.changeType("video/mock; codecs=kcom")');
+
+initSegment2 = makeAInit(8, [makeATrack(1, 'kcom', TRACK_KIND.VIDEO)]);
+run('sourceBuffer.appendBuffer(initSegment2)');
+await waitFor(sourceBuffer, 'updateend');
+
+run('sourceBuffer.appendBuffer(initSegment2)');
+await waitFor(sourceBuffer, 'updateend');
+
+endTest()
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (238053 => 238054)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 21:26:16 UTC (rev 238053)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 21:59:22 UTC (rev 238054)
@@ -1,3 +1,23 @@
+2018-11-09 Jer Noble
+
+SourceBuffer throws an error when appending a second init segment after changeType().
+https://bugs.webkit.org/show_bug.cgi?id=191474
+
+
[webkit-changes] [238053] trunk/Source/WebCore
Title: [238053] trunk/Source/WebCore
Revision 238053
Author eric.carl...@apple.com
Date 2018-11-09 13:26:16 -0800 (Fri, 09 Nov 2018)
Log Message
[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
https://bugs.webkit.org/show_bug.cgi?id=191479
Reviewed by Jer Noble.
No new tests, tested manually.
* platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::standardVideoSizes): Drive-by fix: add a few more standard
video frame sizes, correct a typo.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate): Drive-by fix: don't consider
rescaled sized when we already have an exact or aspect ratio match because it won't be used.
* platform/mediastream/mac/AVVideoCaptureSource.h:
(WebCore::AVVideoCaptureSource::width const): Deleted.
(WebCore::AVVideoCaptureSource::height const): Deleted.
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset): Delete m_requestedSize.
(WebCore::AVVideoCaptureSource::shutdownCaptureSession): Delete m_width and m_height.
(WebCore::AVVideoCaptureSource::processNewFrame): Don't call setSize with captured size,
the frame may be resized before deliver.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (238052 => 238053)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 21:10:26 UTC (rev 238052)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 21:26:16 UTC (rev 238053)
@@ -1,3 +1,28 @@
+2018-11-09 Eric Carlson
+
+[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
+https://bugs.webkit.org/show_bug.cgi?id=191479
+
+
+Reviewed by Jer Noble.
+
+No new tests, tested manually.
+
+* platform/mediastream/RealtimeVideoSource.cpp:
+(WebCore::RealtimeVideoSource::standardVideoSizes): Drive-by fix: add a few more standard
+video frame sizes, correct a typo.
+(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate): Drive-by fix: don't consider
+rescaled sized when we already have an exact or aspect ratio match because it won't be used.
+
+* platform/mediastream/mac/AVVideoCaptureSource.h:
+(WebCore::AVVideoCaptureSource::width const): Deleted.
+(WebCore::AVVideoCaptureSource::height const): Deleted.
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset): Delete m_requestedSize.
+(WebCore::AVVideoCaptureSource::shutdownCaptureSession): Delete m_width and m_height.
+(WebCore::AVVideoCaptureSource::processNewFrame): Don't call setSize with captured size,
+the frame may be resized before deliver.
+
2018-11-09 Ross Kirsling
Unreviewed MSVC build fix after r238039 (and r238046).
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp (238052 => 238053)
--- trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp 2018-11-09 21:10:26 UTC (rev 238052)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp 2018-11-09 21:26:16 UTC (rev 238053)
@@ -103,6 +103,7 @@
{ 112, 112 },
{ 160, 160 },
{ 160, 120 }, // 4:3, QQVGA
+{ 176, 144 }, // 4:3, QCIF
{ 192, 192 },
{ 192, 112 }, // 16:9
{ 192, 144 }, // 3:4
@@ -109,7 +110,7 @@
{ 240, 240 },
{ 240, 160 }, // 3:2, HQVGA
{ 320, 320 },
-{ 320, 176 }, // 16:9
+{ 320, 180 }, // 16:9
{ 320, 240 }, // 4:3, QVGA
{ 352, 288 }, // CIF
{ 480, 272 }, // 16:9
@@ -116,7 +117,7 @@
{ 480, 360 }, // 4:3
{ 480, 480 },
{ 640, 640 },
-{ 640, 368 }, // 16:9
+{ 640, 360 }, // 16:9, 360p nHD
{ 640, 480 }, // 4:3
{ 720, 720 },
{ 800, 600 }, // 4:3, SVGA
@@ -127,7 +128,8 @@
{ 1280, 1024 }, // 5:4, SXGA
{ 1280, 720 }, // 16:9, WXGA
{ 1366, 768 }, // 16:9, HD
-{ 1920, 1080 }, // 16:9, FHD
+{ 1600, 1200}, // 4:3, UXGA
+{ 1920, 1080 }, // 16:9, 1080p FHD
{ 2560, 1440 }, // 16:9, QHD
{ 2592, 1936 },
{ 3264, 2448 }, // 3:4
@@ -301,6 +303,9 @@
}
}
+if (exactSizePreset || aspectRatioPreset)
+continue;
+
if (requestedWidth && requestedHeight) {
const auto& minStandardSize = standardVideoSizes()[0];
if (requestedWidth.value() >= minStandardSize.width() && requestedHeight.value() >= minStandardSize.height()) {
Modified:
[webkit-changes] [238052] trunk/Source
Title: [238052] trunk/Source
Revision 238052
Author ross.kirsl...@sony.com
Date 2018-11-09 13:10:26 -0800 (Fri, 09 Nov 2018)
Log Message
Unreviewed MSVC build fix after r238039 (and r238046).
Source/WebCore:
* bindings/js/JSWorkerGlobalScopeBase.cpp:
* bindings/js/JSWorkerGlobalScopeBase.h:
Source/WebKitLegacy/win:
* WebDocumentLoader.h:
* WebView.cpp:
(WebView::setShouldApplyMacFontAscentHack):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebDocumentLoader.h
trunk/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (238051 => 238052)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 21:10:26 UTC (rev 238052)
@@ -1,3 +1,10 @@
+2018-11-09 Ross Kirsling
+
+Unreviewed MSVC build fix after r238039 (and r238046).
+
+* bindings/js/JSWorkerGlobalScopeBase.cpp:
+* bindings/js/JSWorkerGlobalScopeBase.h:
+
2018-11-09 Basuke Suzuki
[Curl][WebKit] Implement Proxy configuration API.
Modified: trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp (238051 => 238052)
--- trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp 2018-11-09 21:10:26 UTC (rev 238052)
@@ -38,6 +38,7 @@
#include "WorkerThread.h"
#include <_javascript_Core/JSCInlines.h>
#include <_javascript_Core/JSCJSValueInlines.h>
+#include <_javascript_Core/JSProxy.h>
#include <_javascript_Core/Microtask.h>
#include
Modified: trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h (238051 => 238052)
--- trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h 2018-11-09 21:10:26 UTC (rev 238052)
@@ -28,12 +28,15 @@
#include "JSDOMGlobalObject.h"
#include "JSDOMWrapper.h"
-#include <_javascript_Core/JSProxy.h>
#if ENABLE(SERVICE_WORKER)
#include "ServiceWorkerGlobalScope.h"
#endif
+namespace JSC {
+class JSProxy;
+}
+
namespace WebCore {
class JSDedicatedWorkerGlobalScope;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238051 => 238052)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-09 21:10:26 UTC (rev 238052)
@@ -1,3 +1,11 @@
+2018-11-09 Ross Kirsling
+
+Unreviewed MSVC build fix after r238039 (and r238046).
+
+* WebDocumentLoader.h:
+* WebView.cpp:
+(WebView::setShouldApplyMacFontAscentHack):
+
2018-11-09 Antti Koivisto
Use OptionSet for layout milestones
Modified: trunk/Source/WebKitLegacy/win/WebDocumentLoader.h (238051 => 238052)
--- trunk/Source/WebKitLegacy/win/WebDocumentLoader.h 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebKitLegacy/win/WebDocumentLoader.h 2018-11-09 21:10:26 UTC (rev 238052)
@@ -26,12 +26,10 @@
#include "WebDataSource.h"
#include
-using namespace WebCore;
-
-class WebDocumentLoader : public DocumentLoader
+class WebDocumentLoader : public WebCore::DocumentLoader
{
public:
-static Ref create(const ResourceRequest&, const SubstituteData&);
+static Ref create(const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
~WebDocumentLoader();
@@ -43,7 +41,7 @@
virtual void detachFromFrame();
private:
-WebDocumentLoader(const ResourceRequest&, const SubstituteData&);
+WebDocumentLoader(const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
WebDataSource* m_dataSource;
WebDataSource* m_detachedDataSource; // not retained
};
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (238051 => 238052)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2018-11-09 20:43:23 UTC (rev 238051)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2018-11-09 21:10:26 UTC (rev 238052)
@@ -6030,7 +6030,7 @@
HRESULT WebView::setShouldApplyMacFontAscentHack(BOOL b)
{
-Font::setShouldApplyMacAscentHack(b);
+WebCore::Font::setShouldApplyMacAscentHack(b);
return S_OK;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238050] trunk
Title: [238050] trunk Revision 238050 Author wenson_hs...@apple.com Date 2018-11-09 12:16:32 -0800 (Fri, 09 Nov 2018) Log Message [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists https://bugs.webkit.org/show_bug.cgi?id=191410 Reviewed by Dean Jackson. Source/WebKit: Prefixes a few iOS-only SPI methods declared on WKWebView in r236867 with underscores, and also exposes some more cross-platform Cocoa editing SPI. Once the unprefixed SPI methods are no longer used by internal clients, these will need to be removed (see followup bug: webkit.org/b/191450). See below for more details. Covered by new and existing API tests in WKWebViewEditActions. * UIProcess/API/Cocoa/WKWebView.mm: Hoist the definition (and undefinition) of `FORWARD_ACTION_TO_WKCONTENTVIEW` to encompass both the WKWebView implementation and the WKWebView (WKPrivate) implementation. This allows us to use this macro when implementing SPI methods in the WKPrivate category, as well as methods that are part of the main WKWebView implementation. (-[WKWebView canPerformAction:withSender:]): (-[WKWebView targetForAction:withSender:]): Add forwarding for the new editing commands in -canPerformAction: and -targetForAction:. (-[WKWebView _toggleStrikeThrough:]): (-[WKWebView _increaseListLevel:]): (-[WKWebView _decreaseListLevel:]): (-[WKWebView _changeListType:]): (-[WKWebView _setFont:sender:]): (-[WKWebView _setFontSize:sender:]): (-[WKWebView _setTextColor:sender:]): Add definitions for the new editing methods on WKWebView, using macros (`WEBCORE_PRIVATE_COMMAND` on macOS and `FORWARD_ACTION_TO_WKCONTENTVIEW` on iOS) to help reduce the code duplication. (-[WKWebView _pasteAsQuotation:]): Deleted. Remove this method definition, which is now replaced by macros on iOS and macOS. * UIProcess/API/Cocoa/WKWebViewPrivate.h: Introduce the new SPI to WKWebView (WKPrivate), and add FIXMEs to remove old, unprefixed variants of the SPI. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::increaseListLevel): (WebKit::WebPageProxy::decreaseListLevel): (WebKit::WebPageProxy::changeListType): Add plumbing for these list editing commands. * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _increaseListLevelForWebView:]): (-[WKContentView _decreaseListLevelForWebView:]): (-[WKContentView _changeListTypeForWebView:]): (-[WKContentView _toggleStrikeThroughForWebView:]): (-[WKContentView _setFontForWebView:sender:]): (-[WKContentView _setFontSizeForWebView:sender:]): (-[WKContentView _setTextColorForWebView:sender:]): (-[WKContentView toggleStrikeThroughForWebView:]): (-[WKContentView setFontForWebView:sender:]): (-[WKContentView setFontSizeForWebView:sender:]): (-[WKContentView setTextColorForWebView:sender:]): (-[WKContentView canPerformActionForWebView:withSender:]): Check for the new action selectors here, and additionally add validation for `_pasteAsQuotation:`. Let the unprefixed versions of these methods simply call the prefixed versions (these method implementations will be removed in a followup once doing so would not affect any clients of WebKit). * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::increaseListLevel): (WebKit::WebPage::decreaseListLevel): (WebKit::WebPage::changeListType): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Add stubs for several list editing commands that are yet to be hooked up to WebCore. These will be implemented in a future patch. Tools: Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS. Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are hooked up to their respective editing commands. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm. (-[TestWKWebView querySelectorExists:]): (-[TestWKWebView insertString:]): Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by invoking the WKWebView directly on macOS and calling on the content view on iOS. (TestWebKitAPI::webViewForEditActionTesting): (TestWebKitAPI::TEST): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
[webkit-changes] [238049] trunk/Source
Title: [238049] trunk/Source Revision 238049 Author an...@apple.com Date 2018-11-09 11:47:15 -0800 (Fri, 09 Nov 2018) Log Message Use OptionSet for layout milestones https://bugs.webkit.org/show_bug.cgi?id=191470 Reviewed by Dean Jackson. Source/WebCore: * WebCore.xcodeproj/project.pbxproj: * loader/EmptyFrameLoaderClient.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::didReachLayoutMilestone): * loader/FrameLoader.h: * loader/FrameLoaderClient.h: * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::addPaintPendingMilestones): (WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded): (WebCore::FrameView::firePaintRelatedMilestonesIfNeeded): * page/FrameView.h: * page/LayoutMilestone.h: Copied from Source/WebCore/page/LayoutMilestones.h. Renamed to appease WK2 IPC code generation. * page/LayoutMilestones.h: Removed. * page/Page.cpp: (WebCore::Page::addLayoutMilestones): (WebCore::Page::removeLayoutMilestones): (WebCore::Page::isCountingRelevantRepaintedObjects const): * page/Page.h: (WebCore::Page::requestedLayoutMilestones const): Source/WebKit: * Shared/API/Cocoa/_WKRenderingProgressEventsInternal.h: (renderingProgressEvents): * Shared/API/c/WKSharedAPICast.h: (WebKit::toWKLayoutMilestones): (WebKit::toLayoutMilestones): * Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h: (WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones const): (WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones): * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * UIProcess/API/APILoaderClient.h: (API::LoaderClient::didReachLayoutMilestone): * UIProcess/API/APINavigationClient.h: (API::NavigationClient::renderingProgressDidChange): * UIProcess/API/C/WKPage.cpp: (WKPageSetPageLoaderClient): (WKPageSetPageNavigationClient): * UIProcess/API/C/WKPageRenderingProgressEventsInternal.h: (pageRenderingProgressEvents): * UIProcess/API/Cocoa/WKWebView.mm: (layoutMilestones): * UIProcess/Cocoa/NavigationState.h: * UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::renderingProgressDidChange): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::listenForLayoutMilestones): (WebKit::WebPageProxy::didLayoutForCustomContentProvider): (WebKit::WebPageProxy::didReachLayoutMilestone): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didCommitLayerTree): * WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h: (API::InjectedBundle::PageLoaderClient::didReachLayoutMilestone): (API::InjectedBundle::PageLoaderClient::layoutMilestones const): * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone): (WebKit::InjectedBundlePageLoaderClient::layoutMilestones const): * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::dispatchDidReachLayoutMilestone): * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::flushLayers): (WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone): * WebProcess/WebPage/WebPage.cpp: (WebKit::m_shouldAttachDrawingAreaOnPageTransition): (WebKit::WebPage::listenForLayoutMilestones): (WebKit::WebPage::dispatchDidReachLayoutMilestone): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedLayoutMilestones): (WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): Source/WebKitLegacy/mac: * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReachLayoutMilestone): * WebView/WebView.mm: (coreLayoutMilestones): (kitLayoutMilestones): (-[WebView _cacheFrameLoadDelegateImplementations]): * WebView/WebViewInternal.h: Source/WebKitLegacy/win: * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidReachLayoutMilestone): * WebCoreSupport/WebFrameLoaderClient.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/loader/EmptyFrameLoaderClient.h trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/FrameLoader.h trunk/Source/WebCore/loader/FrameLoaderClient.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h
[webkit-changes] [238048] trunk/Source/WebInspectorUI
Title: [238048] trunk/Source/WebInspectorUI Revision 238048 Author joep...@webkit.org Date 2018-11-09 11:23:42 -0800 (Fri, 09 Nov 2018) Log Message Web Inspector: Start moving toward better multi-target support https://bugs.webkit.org/show_bug.cgi?id=191345 Reviewed by Devin Rousso. This change continues the move toward better multi-target support by explicitly using explicit target agents in more places, and converting generalized feature checks into target agnostic versions that use the new InspectorBackend.domains, which does not vary based on the connected targets / debuggable type. I also audited uses of RuntimeAgent, ConsoleAgent, and DebuggerAgent for better multi-target support since these agents should already have complete multi-target support. * UserInterface/Protocol/Target.js: (WI.Target.prototype.initialize): Move explicitly to target.Agent feature checks with a known target. * UserInterface/Controllers/DebuggerManager.js: (WI.DebuggerManager.prototype.initializeTarget): (WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange): Move explicitly to target.DebuggerAgent for feature checks with a known target. * UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.initializeTarget): Move explicitly to target.NetworkAgent for feature checks with a known target. * UserInterface/Controllers/RuntimeManager.js: (WI.RuntimeManager.prototype.initializeTarget): (WI.RuntimeManager.prototype.saveResult): * UserInterface/Protocol/RemoteObject.js: (WI.RemoteObject.prototype.updatePreview): (WI.RemoteObject.prototype.getDisplayablePropertyDescriptors): (WI.RemoteObject.prototype.deprecatedGetDisplayableProperties): * UserInterface/Views/SourceCodeTextEditor.js: (WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator): (WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator): Move explicitly to target.RuntimeAgent for feature checks with a known target. * UserInterface/Models/CSSCompletions.js: (WI.CSSCompletions.initializeCSSCompletions): Move explicitly to target.CSSAgent for feature checks with a known target. * UserInterface/Views/ContextMenuUtilities.js: Use the DebuggerAgent from the target associated with the DOMNode's remote object instead of assuming the main target. * UserInterface/Views/SettingsTabContentView.js: (WI.SettingsTabContentView.prototype._createGeneralSettingsView): Update the ConsoleAgent setting on all targets that support it. * UserInterface/Views/BreakpointActionView.js: (WI.BreakpointActionView): All backends support BreakpointActionType, the assertion can go away. * UserInterface/Views/LogContentView.js: (WI.LogContentView.prototype.get navigationItems): * UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView.prototype.get navigationItems): Include additional `window.FooAgent` checks for these since they will need to be revisited in the future. * UserInterface/Protocol/InspectorBackend.js: (InspectorBackendClass.prototype.get domains): (InspectorBackendClass.prototype.activateDomain): Expose InspectorBackend.domains. for feature checking. * UserInterface/Controllers/BreakpointPopoverController.js: (WI.BreakpointPopoverController.prototype._createPopoverContent): * UserInterface/Controllers/CSSManager.js: (WI.CSSManager): (WI.CSSManager.prototype._mainResourceDidChange): * UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager.prototype._attemptAutoCapturingForFrame): (WI.TimelineManager.prototype._updateAutoCaptureInstruments): (WI.TimelineManager): * UserInterface/Models/Canvas.js: (WI.Canvas.prototype.startRecording): (WI.Canvas.prototype.recordingFinished): * UserInterface/Models/ScriptSyntaxTree.js: (WI.ScriptSyntaxTree.functionReturnDivot): * UserInterface/Protocol/DebuggerObserver.js: (WI.DebuggerObserver): * UserInterface/Protocol/NetworkObserver.js: (WI.NetworkObserver.prototype.requestWillBeSent): * UserInterface/Views/DebuggerSidebarPanel.js: (WI.DebuggerSidebarPanel): (WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointClicked): * UserInterface/Views/NetworkTimelineView.js: (WI.NetworkTimelineView): * UserInterface/Views/ResourceDetailsSidebarPanel.js: (WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse): * UserInterface/Views/WebSocketContentView.js: (WI.WebSocketContentView): (WI.NetworkManager.prototype.webSocketWillSendHandshakeRequest): (WI.DebuggerManager.prototype.debuggerDidResume): Feature check in a target agnostic way. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/BreakpointPopoverController.js trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
[webkit-changes] [238047] trunk
Title: [238047] trunk Revision 238047 Author dba...@webkit.org Date 2018-11-09 11:10:27 -0800 (Fri, 09 Nov 2018) Log Message [iOS] Draw caps lock indicator in password fields https://bugs.webkit.org/show_bug.cgi?id=190565 Reviewed by Dean Jackson. Source/WebCore: Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password fields on iOS more closely match the behavior of password fields on Mac. For now, we only draw the indicator when caps locks is enabled via the hardware keyboard. We will look to support the software keyboard in a subsequent commit (see ). The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS. In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult the store in the WebProcess. A smaller part of this patch is having both the legacy and modern web views listen for keyboard availability changes so as to update the the caps lock state when a hardware keyboard is detached or attached. * WebCore.xcodeproj/project.pbxproj: * page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent() so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code. (WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged(). * page/EventHandler.h: * platform/cocoa/KeyEventCocoa.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm. * platform/ios/KeyEventIOS.mm: (WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state. (WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation. * platform/ios/WebEvent.h: * platform/ios/WebEvent.mm: (+[WebEvent modifierFlags]): Added. * platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared by both Mac and iOS. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared by both Mac and iOS. * rendering/RenderThemeCocoa.h: * rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm. * rendering/RenderThemeIOS.h: * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted. * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be shared by both Mac and iOS. Source/WebCore/PAL: Forward declare some more SPI. * pal/spi/ios/GraphicsServicesSPI.h: * pal/spi/ios/UIKitSPI.h: Source/WebKit: Notify the WebContent process with the current modifer state on window activation changes. Notify the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached). * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications. (-[WKWebView dealloc]): Unregister from hardware availability changed notifications. (hardwareKeyboardAvailabilityChangedCallback): Added. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS. * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware keyboard flags changed event. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::hardwareKeyboardAvailabilityChanged): Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged so that we toggle visibility of the caps lock indicator. Source/WebKitLegacy/mac: Update the caps lock state when a hardware keyboard is attached or detached. * WebView/WebHTMLView.mm: (hardwareKeyboardAvailabilityChangedCallback): Added. (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications. (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications. WebKitLibraries: Expose some more symbols. *
[webkit-changes] [238046] trunk/Source/WebCore
Title: [238046] trunk/Source/WebCore Revision 238046 Author cdu...@apple.com Date 2018-11-09 11:04:01 -0800 (Fri, 09 Nov 2018) Log Message Unreviewed attempt to fix WinCairo build after r238039. * bindings/js/JSWorkerGlobalScopeBase.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h Diff Modified: trunk/Source/WebCore/ChangeLog (238045 => 238046) --- trunk/Source/WebCore/ChangeLog 2018-11-09 18:58:08 UTC (rev 238045) +++ trunk/Source/WebCore/ChangeLog 2018-11-09 19:04:01 UTC (rev 238046) @@ -1,3 +1,9 @@ +2018-11-09 Chris Dumez + +Unreviewed attempt to fix WinCairo build after r238039. + +* bindings/js/JSWorkerGlobalScopeBase.h: + 2018-11-09 Fujii Hironori Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] Modified: trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h (238045 => 238046) --- trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h 2018-11-09 18:58:08 UTC (rev 238045) +++ trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h 2018-11-09 19:04:01 UTC (rev 238046) @@ -28,6 +28,7 @@ #include "JSDOMGlobalObject.h" #include "JSDOMWrapper.h" +#include <_javascript_Core/JSProxy.h> #if ENABLE(SERVICE_WORKER) #include "ServiceWorkerGlobalScope.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238045] trunk/Source/WebKit
Title: [238045] trunk/Source/WebKit
Revision 238045
Author timothy_hor...@apple.com
Date 2018-11-09 10:58:08 -0800 (Fri, 09 Nov 2018)
Log Message
Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
https://bugs.webkit.org/show_bug.cgi?id=191449
Reviewed by Eric Carlson.
UIRemoteView has some nice process assertion management that it would
be nice to not duplicate. So, we can just use it instead of CALayerHost!
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::page const):
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(-[WKUIRemoteView hitTest:withEvent:]):
(-[WKUIRemoteView description]):
(createRemoteView):
(WebKit::RemoteLayerTreeHost::createLayer):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238044 => 238045)
--- trunk/Source/WebKit/ChangeLog 2018-11-09 18:42:24 UTC (rev 238044)
+++ trunk/Source/WebKit/ChangeLog 2018-11-09 18:58:08 UTC (rev 238045)
@@ -1,3 +1,23 @@
+2018-11-09 Tim Horton
+
+Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
+https://bugs.webkit.org/show_bug.cgi?id=191449
+
+
+Reviewed by Eric Carlson.
+
+UIRemoteView has some nice process assertion management that it would
+be nice to not duplicate. So, we can just use it instead of CALayerHost!
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/DrawingAreaProxy.h:
+(WebKit::DrawingAreaProxy::page const):
+* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
+(-[WKUIRemoteView hitTest:withEvent:]):
+(-[WKUIRemoteView description]):
+(createRemoteView):
+(WebKit::RemoteLayerTreeHost::createLayer):
+
2018-11-09 Eric Carlson
[MediaStream] Make screen capture an experimental feature
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (238044 => 238045)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-11-09 18:42:24 UTC (rev 238044)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-11-09 18:58:08 UTC (rev 238045)
@@ -1043,6 +1043,13 @@
- (CGFloat)getVerticalOverlapForView:(UIView *)view usingKeyboardInfo:(NSDictionary *)info;
@end
+@interface _UILayerHostView : UIView
+@end
+
+@interface _UIRemoteView : _UILayerHostView
+- (instancetype)initWithFrame:(CGRect)frame pid:(pid_t)pid contextID:(uint32_t)contextID;
+@end
+
#if __has_include()
#import
#else
Modified: trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h (238044 => 238045)
--- trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h 2018-11-09 18:42:24 UTC (rev 238044)
+++ trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h 2018-11-09 18:58:08 UTC (rev 238045)
@@ -106,6 +106,8 @@
virtual void dispatchPresentationCallbacksAfterFlushingLayers(const Vector&) { }
+WebPageProxy& page() const { return m_webPageProxy; }
+
protected:
explicit DrawingAreaProxy(DrawingAreaType, WebPageProxy&);
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm (238044 => 238045)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm 2018-11-09 18:42:24 UTC (rev 238044)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm 2018-11-09 18:58:08 UTC (rev 238045)
@@ -28,7 +28,9 @@
#if PLATFORM(IOS_FAMILY)
+#import "RemoteLayerTreeDrawingAreaProxy.h"
#import "UIKitSPI.h"
+#import "WebPageProxy.h"
#import
#import
@@ -155,6 +157,44 @@
@end
+#if USE(UIREMOTEVIEW_CONTEXT_HOSTING)
+@interface WKUIRemoteView : _UIRemoteView
+@end
+
+@implementation WKUIRemoteView
+
+- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
+{
+return [self _findDescendantViewAtPoint:point withEvent:event];
+}
+
+- (NSString *)description
+{
+NSString *viewDescription = [super description];
+NSString *webKitDetails = [NSString stringWithFormat:@" layerID = %llu \"%@\"", WebKit::RemoteLayerTreeHost::layerID(self.layer), self.layer.name ? self.layer.name : @""];
+return [viewDescription stringByAppendingString:webKitDetails];
+}
+
+@end
+#endif
+
+static RetainPtr createRemoteView(pid_t pid, uint32_t contextID)
+{
+#if USE(UIREMOTEVIEW_CONTEXT_HOSTING)
+// FIXME: Remove this respondsToSelector check when possible.
+static BOOL canUseUIRemoteView;
+static std::once_flag initializeCanUseUIRemoteView;
+std::call_once(initializeCanUseUIRemoteView, [] {
+canUseUIRemoteView = [_UIRemoteView instancesRespondToSelector:@selector(initWithFrame:pid:contextID:)];
+});
+if (canUseUIRemoteView)
+return adoptNS([[WKUIRemoteView alloc] initWithFrame:CGRectZero pid:pid contextID:contextID]);
+#else
+UNUSED_PARAM(pid);
+#endif
+return adoptNS([[WKRemoteView alloc]
[webkit-changes] [238044] trunk/Source/WebCore
Title: [238044] trunk/Source/WebCore
Revision 238044
Author hironori.fu...@sony.com
Date 2018-11-09 10:42:24 -0800 (Fri, 09 Nov 2018)
Log Message
Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
https://bugs.webkit.org/show_bug.cgi?id=191451
Reviewed by Dean Jackson.
No new tests because there is no behavior change.
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback): Deleted unused method.
* platform/graphics/opengl/Extensions3DOpenGLES.h: Marked 'override'.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238043 => 238044)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 18:35:43 UTC (rev 238043)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 18:42:24 UTC (rev 238044)
@@ -1,3 +1,16 @@
+2018-11-09 Fujii Hironori
+
+Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+https://bugs.webkit.org/show_bug.cgi?id=191451
+
+Reviewed by Dean Jackson.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
+(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback): Deleted unused method.
+* platform/graphics/opengl/Extensions3DOpenGLES.h: Marked 'override'.
+
2018-11-09 Andy Estes
[Payment Request] canMakePayment() should not consider serialized payment method data
Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp (238043 => 238044)
--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp 2018-11-09 18:35:43 UTC (rev 238043)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp 2018-11-09 18:42:24 UTC (rev 238044)
@@ -206,11 +206,6 @@
return false;
}
-void Extensions3DOpenGLES::setEXTContextLostCallback(std::unique_ptr callback)
-{
-m_contextLostCallback = WTFMove(callback);
-}
-
void Extensions3DOpenGLES::readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data)
{
if (m_glReadnPixelsEXT) {
Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h (238043 => 238044)
--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h 2018-11-09 18:35:43 UTC (rev 238043)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h 2018-11-09 18:42:24 UTC (rev 238044)
@@ -71,40 +71,38 @@
Extensions3DOpenGLES(GraphicsContext3D*, bool useIndexedGetString);
virtual ~Extensions3DOpenGLES();
-bool isEnabled(const String&) override;
-
virtual void framebufferTexture2DMultisampleIMG(unsigned long target, unsigned long attachment, unsigned long textarget, unsigned int texture, int level, unsigned long samples);
virtual void renderbufferStorageMultisampleIMG(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height);
// Extension3D methods
-virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter);
-virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height);
-virtual void insertEventMarkerEXT(const String&);
-virtual void pushGroupMarkerEXT(const String&);
-virtual void popGroupMarkerEXT(void);
+bool isEnabled(const String&) override;
+void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter) override;
+void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height) override;
+void insertEventMarkerEXT(const String&) override;
+void pushGroupMarkerEXT(const String&) override;
+void popGroupMarkerEXT(void) override;
-virtual Platform3DObject createVertexArrayOES();
-virtual void deleteVertexArrayOES(Platform3DObject);
-virtual GC3Dboolean isVertexArrayOES(Platform3DObject);
-virtual void bindVertexArrayOES(Platform3DObject);
-virtual void drawBuffersEXT(GC3Dsizei, const GC3Denum*);
+Platform3DObject createVertexArrayOES() override;
+void deleteVertexArrayOES(Platform3DObject) override;
+GC3Dboolean isVertexArrayOES(Platform3DObject) override;
+void bindVertexArrayOES(Platform3DObject) override;
+void drawBuffersEXT(GC3Dsizei, const GC3Denum*) override;
-virtual void
[webkit-changes] [238043] trunk/Source/WebKit
Title: [238043] trunk/Source/WebKit Revision 238043 Author eric.carl...@apple.com Date 2018-11-09 10:35:43 -0800 (Fri, 09 Nov 2018) Log Message [MediaStream] Make screen capture an experimental feature https://bugs.webkit.org/show_bug.cgi?id=191472 Reviewed by Jer Noble. * Shared/WebPreferences.yaml: Make ScreenCaptureEnabled an experimental feature. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: trunk/Source/WebKit/ChangeLog (238042 => 238043) --- trunk/Source/WebKit/ChangeLog 2018-11-09 18:27:35 UTC (rev 238042) +++ trunk/Source/WebKit/ChangeLog 2018-11-09 18:35:43 UTC (rev 238043) @@ -1,3 +1,13 @@ +2018-11-09 Eric Carlson + +[MediaStream] Make screen capture an experimental feature +https://bugs.webkit.org/show_bug.cgi?id=191472 + + +Reviewed by Jer Noble. + +* Shared/WebPreferences.yaml: Make ScreenCaptureEnabled an experimental feature. + 2018-11-09 Daniel Bates [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (238042 => 238043) --- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-11-09 18:27:35 UTC (rev 238042) +++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-11-09 18:35:43 UTC (rev 238043) @@ -498,6 +498,9 @@ defaultValue: false webcoreBinding: RuntimeEnabledFeatures condition: ENABLE(MEDIA_STREAM) + humanReadableName: "ScreenCapture" + humanReadableDescription: "Enable ScreenCapture" + category: experimental PeerConnectionEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238041] trunk
Title: [238041] trunk
Revision 238041
Author aes...@apple.com
Date 2018-11-09 10:22:14 -0800 (Fri, 09 Nov 2018)
Log Message
Source/WebCore:
[Payment Request] PaymentResponse.details should be updated when the user accepts a retried payment
https://bugs.webkit.org/show_bug.cgi?id=191440
Reviewed by Dean Jackson.
PaymentResponse.details was being initialized in the PaymentResponse constructor and never
updated when the user accepts a retried payment. We need to update it.
Added a test case to http/tests/paymentrequest/payment-response-retry-method.https.html.
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::accept):
* Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::setDetailsFunction):
* Modules/paymentrequest/PaymentResponse.h:
LayoutTests:
[Payment Request] PaymentResponse.details should be updated when the user accepts a rpayment retry
https://bugs.webkit.org/show_bug.cgi?id=191440
Reviewed by Dean Jackson.
* http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
* http/tests/paymentrequest/payment-response-retry-method.https.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https-expected.txt
trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentResponse.h
Diff
Modified: trunk/LayoutTests/ChangeLog (238040 => 238041)
--- trunk/LayoutTests/ChangeLog 2018-11-09 18:19:07 UTC (rev 238040)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 18:22:14 UTC (rev 238041)
@@ -1,3 +1,13 @@
+2018-11-09 Andy Estes
+
+[Payment Request] PaymentResponse.details should be updated when the user accepts a rpayment retry
+https://bugs.webkit.org/show_bug.cgi?id=191440
+
+Reviewed by Dean Jackson.
+
+* http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
+* http/tests/paymentrequest/payment-response-retry-method.https.html:
+
2018-11-09 Chris Dumez
HTML form validation bubble disappears
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https-expected.txt (238040 => 238041)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https-expected.txt 2018-11-09 18:19:07 UTC (rev 238040)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https-expected.txt 2018-11-09 18:22:14 UTC (rev 238041)
@@ -11,4 +11,5 @@
PASS When "abort the update" occurs because of an update error, the `retryPromise` is rejected and response.[[complete]] becomes true.
PASS Calling retry() multiple times is always a new object.
PASS When retrying without errors, the user is shown an `unknown` error.
+PASS response.details should be updated after the user accepts a retry.
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https.html (238040 => 238041)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https.html 2018-11-09 18:19:07 UTC (rev 238040)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-response-retry-method.https.html 2018-11-09 18:22:14 UTC (rev 238041)
@@ -199,4 +199,14 @@
await response.complete("success");
}, "When retrying without errors, the user is shown an `unknown` error.");
+promise_test(async t => {
+ const { response, request } = await getPaymentRequestResponse({ requestShipping: true });
+ var originalDetails = response.details;
+ const retryPromise = response.retry();
+ internals.mockPaymentCoordinator.acceptPayment();
+ await retryPromise;
+ assert_not_equals(response.details, originalDetails, "response.details should be a new object after the user accepts a retry");
+ await response.complete("success");
+}, "response.details should be updated after the user accepts a retry.");
+
Modified: trunk/Source/WebCore/ChangeLog (238040 => 238041)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 18:19:07 UTC (rev 238040)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 18:22:14 UTC (rev 238041)
@@ -1,3 +1,22 @@
+2018-11-09 Andy Estes
+
+[Payment Request] PaymentResponse.details should be updated when the user accepts a retried payment
+https://bugs.webkit.org/show_bug.cgi?id=191440
+
+Reviewed by Dean Jackson.
+
+PaymentResponse.details was being initialized in the PaymentResponse constructor and never
+updated when the user accepts a retried payment. We need to update it.
+
+Added a test case to http/tests/paymentrequest/payment-response-retry-method.https.html.
+
+* Modules/paymentrequest/PaymentRequest.cpp:
+(WebCore::PaymentRequest::accept):
+*
[webkit-changes] [238040] trunk/Source/WebCore
Title: [238040] trunk/Source/WebCore
Revision 238040
Author hironori.fu...@sony.com
Date 2018-11-09 10:19:07 -0800 (Fri, 09 Nov 2018)
Log Message
MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
https://bugs.webkit.org/show_bug.cgi?id=191453
Reviewed by Per Arne Vollan.
No new tests because there is no behavior change.
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: Marked with 'override' and removed 'virtual'.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238039 => 238040)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 17:48:37 UTC (rev 238039)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 18:19:07 UTC (rev 238040)
@@ -1,3 +1,14 @@
+2018-11-09 Fujii Hironori
+
+MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+https://bugs.webkit.org/show_bug.cgi?id=191453
+
+Reviewed by Per Arne Vollan.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: Marked with 'override' and removed 'virtual'.
+
2018-11-09 Chris Dumez
Unreviewed attempt to fix internal build on macOS.
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (238039 => 238040)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2018-11-09 17:48:37 UTC (rev 238039)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2018-11-09 18:19:07 UTC (rev 238040)
@@ -358,66 +358,66 @@
HRESULT STDMETHODCALLTYPE ReleaseServicePointers(void) override;
// IMFGetService
-virtual HRESULT STDMETHODCALLTYPE GetService(REFGUID guidService, REFIID riid, LPVOID *ppvObject);
+HRESULT STDMETHODCALLTYPE GetService(REFGUID guidService, REFIID riid, LPVOID *ppvObject) override;
// IMFActivate
-virtual HRESULT STDMETHODCALLTYPE ActivateObject(REFIID riid, void **ppv);
-virtual HRESULT STDMETHODCALLTYPE DetachObject();
-virtual HRESULT STDMETHODCALLTYPE ShutdownObject();
+HRESULT STDMETHODCALLTYPE ActivateObject(REFIID riid, void **ppv) override;
+HRESULT STDMETHODCALLTYPE DetachObject() override;
+HRESULT STDMETHODCALLTYPE ShutdownObject() override;
// IMFAttributes
-virtual HRESULT STDMETHODCALLTYPE GetItem(__RPC__in REFGUID guidKey, __RPC__inout_opt PROPVARIANT *pValue) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetItemType(__RPC__in REFGUID guidKey, __RPC__out MF_ATTRIBUTE_TYPE *pType) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE CompareItem(__RPC__in REFGUID guidKey, __RPC__in REFPROPVARIANT Value, __RPC__out BOOL *pbResult) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE Compare(__RPC__in_opt IMFAttributes *pTheirs, MF_ATTRIBUTES_MATCH_TYPE MatchType, __RPC__out BOOL *pbResult) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetUINT32(__RPC__in REFGUID guidKey, __RPC__out UINT32 *punValue) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetUINT64(__RPC__in REFGUID guidKey, __RPC__out UINT64 *punValue) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetDouble(__RPC__in REFGUID guidKey, __RPC__out double *pfValue) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetGUID(__RPC__in REFGUID guidKey, __RPC__out GUID *pguidValue) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetStringLength(__RPC__in REFGUID guidKey, __RPC__out UINT32 *pcchLength) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetString(__RPC__in REFGUID guidKey, __RPC__out_ecount_full(cchBufSize) LPWSTR pwszValue, UINT32 cchBufSize, __RPC__inout_opt UINT32 *pcchLength) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetAllocatedString(__RPC__in REFGUID guidKey, __RPC__deref_out_ecount_full_opt((*pcchLength + 1)) LPWSTR *ppwszValue, __RPC__out UINT32 *pcchLength) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetBlobSize(__RPC__in REFGUID guidKey, __RPC__out UINT32 *pcbBlobSize) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetBlob(__RPC__in REFGUID guidKey, __RPC__out_ecount_full(cbBufSize) UINT8 *pBuf, UINT32 cbBufSize, __RPC__inout_opt UINT32 *pcbBlobSize) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetAllocatedBlob(__RPC__in REFGUID guidKey, __RPC__deref_out_ecount_full_opt(*pcbSize) UINT8 **ppBuf, __RPC__out UINT32 *pcbSize) { return E_NOTIMPL; }
-virtual HRESULT STDMETHODCALLTYPE GetUnknown(__RPC__in REFGUID guidKey, __RPC__in REFIID riid, __RPC__deref_out_opt LPVOID *ppv) { return
[webkit-changes] [238039] trunk/Source/WebCore
Title: [238039] trunk/Source/WebCore
Revision 238039
Author cdu...@apple.com
Date 2018-11-09 09:48:37 -0800 (Fri, 09 Nov 2018)
Log Message
Unreviewed attempt to fix internal build on macOS.
'Export' is defined in several headers.
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bridge/jsc/BridgeJSC.cpp:
* bridge/jsc/BridgeJSC.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h
trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp
trunk/Source/WebCore/bridge/jsc/BridgeJSC.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238038 => 238039)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 17:37:52 UTC (rev 238038)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 17:48:37 UTC (rev 238039)
@@ -1,5 +1,16 @@
2018-11-09 Chris Dumez
+Unreviewed attempt to fix internal build on macOS.
+
+'Export' is defined in several headers.
+
+* bindings/js/JSDOMGlobalObject.cpp:
+* bindings/js/JSDOMGlobalObject.h:
+* bridge/jsc/BridgeJSC.cpp:
+* bridge/jsc/BridgeJSC.h:
+
+2018-11-09 Chris Dumez
+
HTML form validation bubble disappears
https://bugs.webkit.org/show_bug.cgi?id=191418
Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp (238038 => 238039)
--- trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2018-11-09 17:37:52 UTC (rev 238038)
+++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2018-11-09 17:48:37 UTC (rev 238039)
@@ -50,6 +50,7 @@
#include <_javascript_Core/CodeBlock.h>
#include <_javascript_Core/JSInternalPromise.h>
#include <_javascript_Core/JSInternalPromiseDeferred.h>
+#include <_javascript_Core/StructureInlines.h>
namespace WebCore {
using namespace JSC;
Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h (238038 => 238039)
--- trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h 2018-11-09 17:37:52 UTC (rev 238038)
+++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h 2018-11-09 17:48:37 UTC (rev 238039)
@@ -30,7 +30,6 @@
#include <_javascript_Core/HeapInlines.h>
#include <_javascript_Core/JSGlobalObject.h>
#include <_javascript_Core/LockDuringMarking.h>
-#include <_javascript_Core/StructureInlines.h>
namespace WebCore {
Modified: trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp (238038 => 238039)
--- trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp 2018-11-09 17:37:52 UTC (rev 238038)
+++ trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp 2018-11-09 17:48:37 UTC (rev 238039)
@@ -31,6 +31,7 @@
#include "JSDOMWindowBase.h"
#include "runtime_object.h"
#include "runtime_root.h"
+#include <_javascript_Core/JSCInlines.h>
#include <_javascript_Core/JSLock.h>
#include <_javascript_Core/ObjectPrototype.h>
Modified: trunk/Source/WebCore/bridge/jsc/BridgeJSC.h (238038 => 238039)
--- trunk/Source/WebCore/bridge/jsc/BridgeJSC.h 2018-11-09 17:37:52 UTC (rev 238038)
+++ trunk/Source/WebCore/bridge/jsc/BridgeJSC.h 2018-11-09 17:48:37 UTC (rev 238039)
@@ -28,7 +28,6 @@
#define BridgeJSC_h
#include "Bridge.h"
-#include <_javascript_Core/JSCInlines.h>
#include <_javascript_Core/JSString.h>
#include
#include
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238038] trunk
Title: [238038] trunk Revision 238038 Author cdu...@apple.com Date 2018-11-09 09:37:52 -0800 (Fri, 09 Nov 2018) Log Message HTML form validation bubble disappears https://bugs.webkit.org/show_bug.cgi?id=191418 Reviewed by Simon Fraser. Source/WebCore: If we validate a form and find an invalid form control, we'll scroll it into view and show the validation bubble. However, scrolling the element into view may be an asynchronous operation, in which case it would discard the validation bubble prematurely because scrolling hides the validation bubble. To address the issue, we now show the validation message asynchronously after focusing the element (and potentially scrolling it into view). Test: fast/forms/scroll-into-view-and-show-validation-message.html * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::focusAndShowValidationMessage): LayoutTests: Add API test coverage and update existing tests to use form-validation.js and avoid code duplication. * fast/forms/form-validation.js: Added. (getValidationBubbleContents): (getValidationBubble.return.new.Promise.): (getValidationBubble): * fast/forms/ios/validation-bubble-dismiss-on-tap-expected.txt: * fast/forms/ios/validation-bubble-dismiss-on-tap.html: * fast/forms/navigation-dismisses-validation-bubbles-expected.txt: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt. * fast/forms/navigation-dismisses-validation-bubbles.html: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html. * fast/forms/resources/check-validation-bubble-not-visible.html: Renamed from LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html. * fast/forms/scroll-into-view-and-show-validation-message-expected.txt: Added. * fast/forms/scroll-into-view-and-show-validation-message.html: Added. * fast/forms/validation-bubble-disappears-when-input-detached-expected.txt: * fast/forms/validation-bubble-disappears-when-input-detached.html: * fast/forms/validation-bubble-disappears-when-input-moved-expected.txt: * fast/forms/validation-bubble-disappears-when-input-moved.html: * fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt: * fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html: * fast/forms/validation-bubble-escape-key-dismiss-expected.txt: * fast/forms/validation-bubble-escape-key-dismiss.html: * fast/forms/validation-custom-message-expected.txt: * fast/forms/validation-custom-message.html: * fast/forms/validation-message-detached-iframe-expected.txt: * fast/forms/validation-message-detached-iframe.html: * fast/forms/validation-message-detached-iframe2-expected.txt: * fast/forms/validation-message-detached-iframe2.html: * fast/forms/validation-message-minimum-font-size-expected.txt: * fast/forms/validation-message-minimum-font-size.html: * fast/forms/validation-messages-expected.txt: * fast/forms/validation-messages.html: * platform/gtk/TestExpectations: * platform/ios-wk1/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/ios-simulator/form-control-validation-message-expected.txt trunk/LayoutTests/accessibility/ios-simulator/form-control-validation-message.html trunk/LayoutTests/fast/forms/ios/validation-bubble-dismiss-on-tap-expected.txt trunk/LayoutTests/fast/forms/ios/validation-bubble-dismiss-on-tap.html trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-detached-expected.txt trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-detached.html trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-moved-expected.txt trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-moved.html trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt trunk/LayoutTests/fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html trunk/LayoutTests/fast/forms/validation-bubble-escape-key-dismiss-expected.txt trunk/LayoutTests/fast/forms/validation-bubble-escape-key-dismiss.html trunk/LayoutTests/fast/forms/validation-custom-message-expected.txt trunk/LayoutTests/fast/forms/validation-custom-message.html trunk/LayoutTests/fast/forms/validation-message-detached-iframe-expected.txt trunk/LayoutTests/fast/forms/validation-message-detached-iframe.html trunk/LayoutTests/fast/forms/validation-message-detached-iframe2-expected.txt trunk/LayoutTests/fast/forms/validation-message-detached-iframe2.html trunk/LayoutTests/fast/forms/validation-message-minimum-font-size-expected.txt trunk/LayoutTests/fast/forms/validation-message-minimum-font-size.html trunk/LayoutTests/fast/forms/validation-messages-expected.txt trunk/LayoutTests/fast/forms/validation-messages.html trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios-wk1/TestExpectations
[webkit-changes] [238037] trunk/Source/WebCore
Title: [238037] trunk/Source/WebCore
Revision 238037
Author bfulg...@apple.com
Date 2018-11-09 09:32:32 -0800 (Fri, 09 Nov 2018)
Log Message
[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
https://bugs.webkit.org/show_bug.cgi?id=191452
Reviewed by Zalan Bujtas.
Do a better job of balancing the BeginFigure/EndFigure calls in
the PathDirect2D implementation. Failure to do so puts the Geometry sink
into an error state that prevents it from producing drawing output.
* platform/graphics/Path.h:
* platform/graphics/win/GraphicsContextDirect2D.cpp:
(WebCore::GraphicsContext::drawPath): Flush is needed here.
(WebCore::GraphicsContext::fillPath): Ditto.
(WebCore::GraphicsContext::strokePath): Ditto.
* platform/graphics/win/PathDirect2D.cpp:
(WebCore::Path::drawDidComplete):
(WebCore::Path::closeAnyOpenGeometries):
(WebCore::Path::transform):
(WebCore::Path::openFigureAtCurrentPointIfNecessary):
(WebCore::Path::moveTo):
(WebCore::Path::closeSubpath):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/PathDirect2D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (238036 => 238037)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 17:27:34 UTC (rev 238036)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 17:32:32 UTC (rev 238037)
@@ -1,3 +1,29 @@
+2018-11-09 Brent Fulgham
+
+[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
+https://bugs.webkit.org/show_bug.cgi?id=191452
+
+
+Reviewed by Zalan Bujtas.
+
+Do a better job of balancing the BeginFigure/EndFigure calls in
+the PathDirect2D implementation. Failure to do so puts the Geometry sink
+into an error state that prevents it from producing drawing output.
+
+
+* platform/graphics/Path.h:
+* platform/graphics/win/GraphicsContextDirect2D.cpp:
+(WebCore::GraphicsContext::drawPath): Flush is needed here.
+(WebCore::GraphicsContext::fillPath): Ditto.
+(WebCore::GraphicsContext::strokePath): Ditto.
+* platform/graphics/win/PathDirect2D.cpp:
+(WebCore::Path::drawDidComplete):
+(WebCore::Path::closeAnyOpenGeometries):
+(WebCore::Path::transform):
+(WebCore::Path::openFigureAtCurrentPointIfNecessary):
+(WebCore::Path::moveTo):
+(WebCore::Path::closeSubpath):
+
2018-11-09 Jer Noble
[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
Modified: trunk/Source/WebCore/platform/graphics/Path.h (238036 => 238037)
--- trunk/Source/WebCore/platform/graphics/Path.h 2018-11-09 17:27:34 UTC (rev 238036)
+++ trunk/Source/WebCore/platform/graphics/Path.h 2018-11-09 17:32:32 UTC (rev 238037)
@@ -201,6 +201,7 @@
HRESULT initializePathState();
void openFigureAtCurrentPointIfNecessary();
+void closeAnyOpenGeometries();
#endif
#ifndef NDEBUG
@@ -212,7 +213,7 @@
COMPtr m_path;
COMPtr m_activePathGeometry;
COMPtr m_activePath;
-bool m_doesHaveOpenFigure { false };
+size_t m_openFigureCount { 0 };
#else
PlatformPathPtr m_path { nullptr };
#endif
Modified: trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp (238036 => 238037)
--- trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp 2018-11-09 17:27:34 UTC (rev 238036)
+++ trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp 2018-11-09 17:32:32 UTC (rev 238037)
@@ -940,6 +940,8 @@
auto brush = m_state.strokePattern ? patternStrokeBrush() : solidStrokeBrush();
renderTarget->DrawGeometry(path.platformPath(), brush, strokeThickness(), m_data->strokeStyle());
});
+
+flush();
}
void GraphicsContext::drawWithoutShadow(const FloatRect& /*boundingRect*/, const WTF::Function& drawCommands)
@@ -1043,6 +1045,8 @@
drawWithShadow(boundingRect, drawFunction);
else
drawWithoutShadow(boundingRect, drawFunction);
+
+flush();
return;
}
@@ -1059,6 +1063,8 @@
auto brush = m_state.fillPattern ? patternFillBrush() : solidFillBrush();
renderTarget->FillGeometry(pathToFill.get(), brush);
});
+
+flush();
}
void GraphicsContext::strokePath(const Path& path)
@@ -1089,6 +1095,7 @@
else
drawWithoutShadow(boundingRect, drawFunction);
+flush();
return;
}
@@ -1102,6 +1109,8 @@
auto brush = m_state.strokePattern ? patternStrokeBrush() : solidStrokeBrush();
renderTarget->DrawGeometry(path.platformPath(), brush, strokeThickness(), m_data->strokeStyle());
});
+
+flush();
}
void GraphicsContext::fillRect(const FloatRect& rect)
Modified:
[webkit-changes] [238036] trunk/Source/WebKitLegacy
Title: [238036] trunk/Source/WebKitLegacy
Revision 238036
Author sihui_...@apple.com
Date 2018-11-09 09:27:34 -0800 (Fri, 09 Nov 2018)
Log Message
Remove legacy storage tracker database file after r237330
https://bugs.webkit.org/show_bug.cgi?id=191423
Reviewed by Geoffrey Garen.
r237330 changed the file name of storage tracker database, but it did not remove the old
file before using the new one.
* Storage/StorageTracker.cpp:
(WebKit::StorageTracker::internalInitialize):
Modified Paths
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp
Diff
Modified: trunk/Source/WebKitLegacy/ChangeLog (238035 => 238036)
--- trunk/Source/WebKitLegacy/ChangeLog 2018-11-09 17:24:50 UTC (rev 238035)
+++ trunk/Source/WebKitLegacy/ChangeLog 2018-11-09 17:27:34 UTC (rev 238036)
@@ -1,3 +1,16 @@
+2018-11-09 Sihui Liu
+
+Remove legacy storage tracker database file after r237330
+https://bugs.webkit.org/show_bug.cgi?id=191423
+
+Reviewed by Geoffrey Garen.
+
+r237330 changed the file name of storage tracker database, but it did not remove the old
+file before using the new one.
+
+* Storage/StorageTracker.cpp:
+(WebKit::StorageTracker::internalInitialize):
+
2018-11-01 Sihui Liu
Add a storage limit for IndexedDB
Modified: trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp (238035 => 238036)
--- trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp 2018-11-09 17:24:50 UTC (rev 238035)
+++ trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp 2018-11-09 17:27:34 UTC (rev 238036)
@@ -79,6 +79,10 @@
storageTracker->setIsActive(true);
storageTracker->m_thread->start();
storageTracker->importOriginIdentifiers();
+
+m_thread->dispatch([this] {
+FileSystem::deleteFile(FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db"));
+});
}
StorageTracker& StorageTracker::tracker()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238035] trunk
Title: [238035] trunk
Revision 238035
Author jer.no...@apple.com
Date 2018-11-09 09:24:50 -0800 (Fri, 09 Nov 2018)
Log Message
[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
https://bugs.webkit.org/show_bug.cgi?id=191396
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Modify the changetype test suite to include a HEVC version.
* web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4: Added.
* web-platform-tests/media-source/mediasource-changetype-util.js:
(findSupportedChangeTypeTestTypes):
Source/WebCore:
When changeType() is called, exempt video and text tracks (in addition to just audio tracks)
from "same codec" requirements.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::validateInitializationSegment):
LayoutTests:
* platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-changetype-util.js
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/hevc/
trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4
trunk/LayoutTests/platform/mac-sierra/imported/w3c/web-platform-tests/media-source/
trunk/LayoutTests/platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (238034 => 238035)
--- trunk/LayoutTests/ChangeLog 2018-11-09 17:16:01 UTC (rev 238034)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 17:24:50 UTC (rev 238035)
@@ -1,3 +1,13 @@
+2018-11-09 Jer Noble
+
+[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
+https://bugs.webkit.org/show_bug.cgi?id=191396
+
+Reviewed by Eric Carlson.
+
+* platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
+* platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
+
2018-11-09 Ryan Haddad
Clean up test expectations after r237942
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238034 => 238035)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-09 17:16:01 UTC (rev 238034)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-09 17:24:50 UTC (rev 238035)
@@ -1,3 +1,16 @@
+2018-11-09 Jer Noble
+
+[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
+https://bugs.webkit.org/show_bug.cgi?id=191396
+
+Reviewed by Eric Carlson.
+
+Modify the changetype test suite to include a HEVC version.
+
+* web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4: Added.
+* web-platform-tests/media-source/mediasource-changetype-util.js:
+(findSupportedChangeTypeTestTypes):
+
2018-11-08 Andy Estes
[Payment Request] Update web platform tests
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4 (0 => 238035)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4 (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4 2018-11-09 17:24:50 UTC (rev 238035)
@@ -0,0 +1,344 @@
+ÀÀÀ ftypisomÀÀÀisomiso2iso6mp41ÀÀ
+\xDDmoovÀÀÀlmvhdÀÀÀÀÀÀÀÀÀÀÀÀÀÀ\xE8ÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ@ÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ \xDFtrakÀÀÀ\tkhdÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ@ÀÀÀ@ÀÀÀ\xF0ÀÀÀÀ {mdiaÀÀÀ mdhdÀÀÀÀÀÀÀÀÀÀÀÀÀÀ0ÀÀÀÀÀU\xC4ÀÀÀÀÀ-hdlrÀÀÀÀÀÀÀÀvideÀÀÀÀÀÀÀÀÀÀÀÀVideoHandlerÀÀÀ ÀÀÀvmhdÀÀÀÀÀÀÀÀÀÀÀÀÀÀ$dinfÀÀÀ drefÀÀÀÀÀÀÀÀÀÀ url ÀÀÀÀÀ\xE6stblÀÀ\x9AstsdÀÀÀÀÀÀÀÀÀ\x8Ahev1ÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ@À\xF0ÀHÀÀÀHÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ\xFF\xFFÀÀ$hvcC`ÀÀÀ\x90ÀÀÀÀÀ<\xF0À\xFC\xFD\xF8\xF8ÀÀ ÀÀ@ \xFF\xFF`ÀÀÀ\x90ÀÀÀÀÀ<\x95\x94 !ÀÀ(B`ÀÀÀ\x90À
ÀÀÀÀ<\xA0
[webkit-changes] [238034] trunk/LayoutTests
Title: [238034] trunk/LayoutTests Revision 238034 Author ryanhad...@apple.com Date 2018-11-09 09:16:01 -0800 (Fri, 09 Nov 2018) Log Message Clean up test expectations after r237942 https://bugs.webkit.org/show_bug.cgi?id=191448 Unreviewed test gardening. Add test expectation files for Sierra WK1. * platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added. * platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (238033 => 238034) --- trunk/LayoutTests/ChangeLog 2018-11-09 17:06:50 UTC (rev 238033) +++ trunk/LayoutTests/ChangeLog 2018-11-09 17:16:01 UTC (rev 238034) @@ -1,3 +1,15 @@ +2018-11-09 Ryan Haddad + +Clean up test expectations after r237942 +https://bugs.webkit.org/show_bug.cgi?id=191448 + +Unreviewed test gardening. + +Add test expectation files for Sierra WK1. + +* platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added. +* platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added. + 2018-11-09 Daniel Bates [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor Added: trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt (0 => 238034) --- trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt 2018-11-09 17:16:01 UTC (rev 238034) @@ -0,0 +1,63 @@ + +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 785.00 2016.00) + (children 1 +(GraphicsLayer + (bounds 785.00 2016.00) + (contentsOpaque 1) + (children 2 +(GraphicsLayer + (offsetFromRenderer width=-14 height=-14) + (position 14.00 14.00) + (bounds 432.00 332.00) + (drawsContent 1) + (repaint rects +(rect 16.00 16.00 400.00 300.00) + ) + (children 1 +(GraphicsLayer + (position 16.00 16.00) + (children 1 +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 400.00 300.00) + (children 1 +(GraphicsLayer + (position 0.00 -100.00) + (children 1 +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 400.00 1016.00) + (children 1 +(GraphicsLayer + (bounds 400.00 1016.00) + (drawsContent 1) + (children 1 +(GraphicsLayer + (position 8.00 8.00) + (bounds 100.00 100.00) + (contentsOpaque 1) +) + ) +) + ) +) + ) +) + ) +) + ) +) + ) +) +(GraphicsLayer + (position 8.00 369.00) + (anchor 1.00 1.00) + (bounds 1.00 1.00) +) + ) +) + ) +) + Added: trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt (0 => 238034) --- trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt 2018-11-09 17:16:01 UTC (rev 238034) @@ -0,0 +1,67 @@ + +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 785.00 2016.00) + (children 1 +(GraphicsLayer + (bounds 785.00 2016.00) + (contentsOpaque 1) + (children 2 +(GraphicsLayer + (offsetFromRenderer width=-14 height=-14) + (position 14.00 14.00) + (bounds 432.00 332.00) + (drawsContent 1) + (repaint rects +(rect 16.00 16.00 400.00 300.00) + ) +
[webkit-changes] [238033] trunk
Title: [238033] trunk
Revision 238033
Author dba...@webkit.org
Date 2018-11-09 09:06:50 -0800 (Fri, 09 Nov 2018)
Log Message
[iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
action when forward delete is pressed outside a text field
https://bugs.webkit.org/show_bug.cgi?id=190566
Reviewed by Wenson Hsieh.
Source/WebKit:
Override -_deleteForwardAndNotify to perform a forward deletion and remove the dead code that
expected UIKit to send us a character string with 0xF728 for the forward delete key. UIKit
ceased doing this many years ago. We may revist this decision once
is fixed.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView _deleteForwardAndNotify:]):
Source/WebKitLegacy/mac:
Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
in UIKit. We may revist this decision once is fixed.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):
LayoutTests:
Add a test to ensure that pressing the forward delete key deletes the next character.
* fast/events/ios/forward-delete-in-editable-expected.txt: Added.
* fast/events/ios/forward-delete-in-editable.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Added Paths
trunk/LayoutTests/fast/events/ios/forward-delete-in-editable-expected.txt
trunk/LayoutTests/fast/events/ios/forward-delete-in-editable.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238032 => 238033)
--- trunk/LayoutTests/ChangeLog 2018-11-09 16:42:49 UTC (rev 238032)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 17:06:50 UTC (rev 238033)
@@ -1,3 +1,17 @@
+2018-11-09 Daniel Bates
+
+[iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
+action when forward delete is pressed outside a text field
+https://bugs.webkit.org/show_bug.cgi?id=190566
+
+
+Reviewed by Wenson Hsieh.
+
+Add a test to ensure that pressing the forward delete key deletes the next character.
+
+* fast/events/ios/forward-delete-in-editable-expected.txt: Added.
+* fast/events/ios/forward-delete-in-editable.html: Added.
+
2018-11-09 Carlos Garcia Campos
REGRESSION(r236365): [GTK] Many form-related tests are failing
Added: trunk/LayoutTests/fast/events/ios/forward-delete-in-editable-expected.txt (0 => 238033)
--- trunk/LayoutTests/fast/events/ios/forward-delete-in-editable-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/ios/forward-delete-in-editable-expected.txt 2018-11-09 17:06:50 UTC (rev 238033)
@@ -0,0 +1,10 @@
+Tests that pressing the forward delete key in an editable element deletes the next character. To run this test manually, press the forward delete key and then click Check Result.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.getElementById("input").value is "ext"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/ios/forward-delete-in-editable.html (0 => 238033)
--- trunk/LayoutTests/fast/events/ios/forward-delete-in-editable.html (rev 0)
+++ trunk/LayoutTests/fast/events/ios/forward-delete-in-editable.html 2018-11-09 17:06:50 UTC (rev 238033)
@@ -0,0 +1,44 @@
+
+
+
+
+
+
+
+
+
+