[webkit-changes] [239007] trunk/Source/WebKit

2018-12-07 Thread commit-queue 
Title: [239007] trunk/Source/WebKit








Revision 239007
Author commit-qu...@webkit.org
Date 2018-12-07 23:35:47 -0800 (Fri, 07 Dec 2018)


Log Message
Remove unused API in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=192415

Patch by Rob Buis  on 2018-12-07
Reviewed by Alex Christensen.

This patch removed some unused API and headers in NetworkProcess.

* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkContentRuleListManager.h:
* NetworkProcess/NetworkDataTask.cpp:
* NetworkProcess/NetworkDataTask.h:
* NetworkProcess/NetworkDataTaskBlob.cpp:
* NetworkProcess/NetworkLoad.cpp:
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkLoadChecker.cpp:
* NetworkProcess/NetworkLoadChecker.h:
* NetworkProcess/NetworkLoadClient.h:
* NetworkProcess/NetworkLoadParameters.h:
* NetworkProcess/NetworkProcess.cpp:
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveBuffer):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkSession.cpp:
* NetworkProcess/NetworkSession.h:
* NetworkProcess/NetworkSocketStream.cpp:
* NetworkProcess/NetworkSocketStream.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
* NetworkProcess/PingLoad.h:
* NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::PreconnectTask):
(WebKit::PreconnectTask::frameID const): Deleted.
(WebKit::PreconnectTask::pageID const): Deleted.
* NetworkProcess/PreconnectTask.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.h
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkLoadClient.h
trunk/Source/WebKit/NetworkProcess/NetworkLoadParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.h
trunk/Source/WebKit/NetworkProcess/PingLoad.cpp
trunk/Source/WebKit/NetworkProcess/PingLoad.h
trunk/Source/WebKit/NetworkProcess/PreconnectTask.cpp
trunk/Source/WebKit/NetworkProcess/PreconnectTask.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239006 => 239007)

--- trunk/Source/WebKit/ChangeLog	2018-12-08 03:11:36 UTC (rev 239006)
+++ trunk/Source/WebKit/ChangeLog	2018-12-08 07:35:47 UTC (rev 239007)
@@ -1,3 +1,50 @@
+2018-12-07  Rob Buis  
+
+Remove unused API in NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=192415
+
+Reviewed by Alex Christensen.
+
+This patch removed some unused API and headers in NetworkProcess.
+
+* NetworkProcess/NetworkCORSPreflightChecker.cpp:
+(WebKit::NetworkCORSPreflightChecker::startPreflight):
+* NetworkProcess/NetworkCORSPreflightChecker.h:
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/NetworkContentRuleListManager.h:
+* NetworkProcess/NetworkDataTask.cpp:
+* NetworkProcess/NetworkDataTask.h:
+* NetworkProcess/NetworkDataTaskBlob.cpp:
+* NetworkProcess/NetworkLoad.cpp:
+* NetworkProcess/NetworkLoad.h:
+* NetworkProcess/NetworkLoadChecker.cpp:
+* NetworkProcess/NetworkLoadChecker.h:
+* NetworkProcess/NetworkLoadClient.h:
+* NetworkProcess/NetworkLoadParameters.h:
+* NetworkProcess/NetworkProcess.cpp:
+*

[webkit-changes] [239006] trunk

2018-12-07 Thread eric . carlson 
Title: [239006] trunk








Revision 239006
Author eric.carl...@apple.com
Date 2018-12-07 19:11:36 -0800 (Fri, 07 Dec 2018)


Log Message
[MediaStream] 'devicechange' event should not fire in frames that can't access capture devices
https://bugs.webkit.org/show_bug.cgi?id=192511


Reviewed by Youenn Fablet.

Source/WebCore:

Test: http/tests/media/media-stream/device-change-event-in-iframe.html

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::addEventListener): Don't fire the event unless the document can
access a camera or microphone.

Source/WebKit:

* UIProcess/UserMediaPermissionCheckProxy.cpp:
(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Remove userMediaID parameter.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): ID not passed to callback.
* UIProcess/UserMediaPermissionCheckProxy.h:
(WebKit::UserMediaPermissionCheckProxy::create):
(WebKit::UserMediaPermissionCheckProxy::completionHandler): Deleted.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::generateRequestID): New.
(WebKit::UserMediaPermissionRequestManagerProxy::captureDevicesChanged): Don't notify if
the page does not have a granted request and does not have persistent access.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Use generateRequestID.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Change variable name.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Use generateRequestID.
* UIProcess/UserMediaPermissionRequestManagerProxy.h:

LayoutTests:

* fast/mediastream/device-change-event.html: Fix bogus title.
* http/tests/media/media-stream/device-change-event-in-iframe-expected.txt: Added.
* http/tests/media/media-stream/device-change-event-in-iframe.html: Added.
* http/tests/media/media-stream/resources/device-change-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/device-change-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in


Added Paths

trunk/LayoutTests/http/tests/media/media-stream/device-change-event-in-iframe-expected.txt
trunk/LayoutTests/http/tests/media/media-stream/device-change-event-in-iframe.html
trunk/LayoutTests/http/tests/media/media-stream/resources/device-change-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239005 => 239006)

--- trunk/LayoutTests/ChangeLog	2018-12-08 03:10:39 UTC (rev 239005)
+++ trunk/LayoutTests/ChangeLog	2018-12-08 03:11:36 UTC (rev 239006)
@@ -1,3 +1,16 @@
+2018-12-07  Eric Carlson  
+
+[MediaStream] 'devicechange' event should not fire in frames that can't access capture devices
+https://bugs.webkit.org/show_bug.cgi?id=192511
+
+
+Reviewed by Youenn Fablet.
+
+* fast/mediastream/device-change-event.html: Fix bogus title.
+* http/tests/media/media-stream/device-change-event-in-iframe-expected.txt: Added.
+* http/tests/media/media-stream/device-change-event-in-iframe.html: Added.
+* http/tests/media/media-stream/resources/device-change-iframe.html: Added.
+
 2018-12-07  Truitt Savell  
 
 [ MacOS Debug ] Layout Test webgl/2.0.0/conformance2/textures/misc/tex-unpack-params.html is flaky timeout


Modified: trunk/LayoutTests/fast/mediastream/device-change-event.html (239005 => 239006)

--- trunk/LayoutTests/fast/mediastream/device-change-event.html	2018-12-08 03:10:39 UTC (rev 239005)
+++ trunk/LayoutTests/fast/mediastream/device-change-event.html	2018-12-08 03:11:36 UTC (rev 239006)
@@ -2,7 +2,7 @@
 
 
 
-Testing local audio capture playback causes "playing" event to fire
+'devicechange' event tests