[webkit-changes] [239098] trunk
Title: [239098] trunk Revision 239098 Author justin_mich...@apple.com Date 2018-12-11 21:54:17 -0800 (Tue, 11 Dec 2018) Log Message Implement feature flag for CSS Typed OM https://bugs.webkit.org/show_bug.cgi?id=192610 Reviewed by Ryosuke Niwa. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: * bindings/js/JSTypedOMCSSStyleValueCustom.cpp: * css/typedom/StylePropertyMapReadOnly.h: * css/typedom/StylePropertyMapReadOnly.idl: * css/typedom/TypedOMCSSImageValue.h: * css/typedom/TypedOMCSSImageValue.idl: * css/typedom/TypedOMCSSNumericValue.h: * css/typedom/TypedOMCSSNumericValue.idl: * css/typedom/TypedOMCSSStyleValue.h: * css/typedom/TypedOMCSSStyleValue.idl: * css/typedom/TypedOMCSSUnitValue.h: * css/typedom/TypedOMCSSUnitValue.idl: * css/typedom/TypedOMCSSUnparsedValue.h: * css/typedom/TypedOMCSSUnparsedValue.idl: * features.json: * html/ImageBitmap.cpp: * html/ImageBitmap.h: * html/canvas/CanvasDrawImage.idl: * html/canvas/CanvasFillStrokeStyles.idl: * html/canvas/CanvasRenderingContext2DBase.cpp: * html/canvas/CanvasRenderingContext2DBase.h: * inspector/InspectorCanvas.cpp: (WebCore::InspectorCanvas::buildAction): * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setCSSTypedOMEnabled): (WebCore::RuntimeEnabledFeatures::cssTypedOMEnabled const): * page/WindowOrWorkerGlobalScope.idl: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit: * Configurations/FeatureDefines.xcconfig: * Shared/WebPreferences.yaml: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/bindings/js/JSTypedOMCSSStyleValueCustom.cpp trunk/Source/WebCore/css/typedom/StylePropertyMapReadOnly.h trunk/Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl trunk/Source/WebCore/css/typedom/TypedOMCSSImageValue.h trunk/Source/WebCore/css/typedom/TypedOMCSSImageValue.idl trunk/Source/WebCore/css/typedom/TypedOMCSSNumericValue.h trunk/Source/WebCore/css/typedom/TypedOMCSSNumericValue.idl trunk/Source/WebCore/css/typedom/TypedOMCSSStyleValue.h trunk/Source/WebCore/css/typedom/TypedOMCSSStyleValue.idl trunk/Source/WebCore/css/typedom/TypedOMCSSUnitValue.h trunk/Source/WebCore/css/typedom/TypedOMCSSUnitValue.idl trunk/Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.h trunk/Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.idl trunk/Source/WebCore/features.json trunk/Source/WebCore/html/ImageBitmap.cpp trunk/Source/WebCore/html/ImageBitmap.h trunk/Source/WebCore/html/canvas/CanvasDrawImage.idl trunk/Source/WebCore/html/canvas/CanvasFillStrokeStyles.idl trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h trunk/Source/WebCore/inspector/InspectorCanvas.cpp trunk/Source/WebCore/page/RuntimeEnabledFeatures.h trunk/Source/WebCore/page/WindowOrWorkerGlobalScope.idl trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/Shared/WebPreferences.yaml trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (239097 => 239098) --- trunk/Source/_javascript_Core/ChangeLog 2018-12-12 05:18:42 UTC (rev 239097) +++ trunk/Source/_javascript_Core/ChangeLog 2018-12-12 05:54:17 UTC (rev 239098) @@ -1,3 +1,12 @@ +2018-12-11 Justin Michaud + +Implement feature flag for CSS Typed OM +https://bugs.webkit.org/show_bug.cgi?id=192610 + +Reviewed by Ryosuke Niwa. + +* Configurations/FeatureDefines.xcconfig: + 2018-12-10 Don Olmstead Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (239097 => 239098) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-12-12 05:18:42 UTC (rev 239097) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-12-12 05:54:17 UTC (rev 239098) @@ -94,6 +94,8 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD; +ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM; + ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS; ENABLE_CSS_CONIC_GRADIENTS = $(ENABLE_CSS_CONIC_GRADIENTS_$(WK_PLATFORM_NAME));
[webkit-changes] [239097] trunk/Source/WebKitLegacy
Title: [239097] trunk/Source/WebKitLegacy
Revision 239097
Author hironori.fu...@sony.com
Date 2018-12-11 21:18:42 -0800 (Tue, 11 Dec 2018)
Log Message
[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
https://bugs.webkit.org/show_bug.cgi?id=192581
Reviewed by Alex Christensen.
Conventionally, WebKit COM interface adds a new interface with
same name methods with the old interface. For example, both
IWebEditingDelegate and IWebEditingDelegate2 interfaces has
shouldInsertNode method.
This is a part of public API, can't be renamed.
* PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option
for WebKitLegacy
Modified Paths
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/PlatformWin.cmake
Diff
Modified: trunk/Source/WebKitLegacy/ChangeLog (239096 => 239097)
--- trunk/Source/WebKitLegacy/ChangeLog 2018-12-12 03:58:41 UTC (rev 239096)
+++ trunk/Source/WebKitLegacy/ChangeLog 2018-12-12 05:18:42 UTC (rev 239097)
@@ -1,3 +1,20 @@
+2018-12-11 Fujii Hironori
+
+[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
+https://bugs.webkit.org/show_bug.cgi?id=192581
+
+Reviewed by Alex Christensen.
+
+Conventionally, WebKit COM interface adds a new interface with
+same name methods with the old interface. For example, both
+IWebEditingDelegate and IWebEditingDelegate2 interfaces has
+shouldInsertNode method.
+
+This is a part of public API, can't be renamed.
+
+* PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option
+for WebKitLegacy
+
2018-12-06 Alex Christensen
Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (239096 => 239097)
--- trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-12-12 03:58:41 UTC (rev 239096)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-12-12 05:18:42 UTC (rev 239097)
@@ -277,6 +277,10 @@
endif ()
endif ()
+if (COMPILER_IS_GCC_OR_CLANG)
+WEBKIT_ADD_TARGET_CXX_FLAGS(WebKitLegacy -Wno-overloaded-virtual)
+endif ()
+
list(APPEND WebKitLegacy_SOURCES ${WebKitLegacy_INCLUDES} ${WebKitLegacy_SOURCES_Classes} ${WebKitLegacy_SOURCES_WebCoreSupport})
source_group(Includes FILES ${WebKitLegacy_INCLUDES})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239096] trunk
Title: [239096] trunk Revision 239096 Author rn...@webkit.org Date 2018-12-11 19:58:41 -0800 (Tue, 11 Dec 2018) Log Message connectedCallback is invoked during the removal of the element inside another element's connectedCallback https://bugs.webkit.org/show_bug.cgi?id=183586 Reviewed by Frédéric Wang. Source/WebCore: Align WebKit's behavior with Chrome/Firefox with regards to https://github.com/w3c/webcomponents/issues/760 After much discussion, it's unclear that there is a clear path forward to fixing the oddness that the presence of a custom element reaction changes the timing at which another reaction callback gets invoked. So matching Chrome/Firefox behaviors in this case seems the path of the least resistance to interoperability. Namely, this patch makes WebKit not insert a custom element to the appropriate element queue when the element does not have a matching reaction callback. Put it another way, steps 3-5 in would be done before step 6 in: https://html.spec.whatwg.org/multipage/custom-elements.html#enqueue-a-custom-element-callback-reaction 1. Let definition be element's custom element definition. 2. Let callback be the value of the entry in definition's lifecycle callbacks with key callbackName. 3. If callback is null, then return 4. If callbackName is "attributeChangedCallback", then: 1. Let attributeName be the first element of args. 2. If definition's observed attributes does not contain attributeName, then return. 5. Add a new callback reaction to element's custom element reaction queue, with callback function callback and arguments args. 6. Enqueue an element on the appropriate element queue given element. Test: fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html * dom/CustomElementReactionQueue.cpp: (WebCore::CustomElementReactionQueue::enqueueElementUpgrade): (WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded): (WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded): (WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded): (WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded): (WebCore::CustomElementReactionQueue::enqueuePostUpgradeReactions): (WebCore::CustomElementReactionQueue::enqueueElementOnAppropriateElementQueue): Renamed from ensureCurrentQueue. * dom/CustomElementReactionQueue.h: LayoutTests: Added a W3C style testharness test. * fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Added. * fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp trunk/Source/WebCore/dom/CustomElementReactionQueue.h Added Paths trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html Diff Modified: trunk/LayoutTests/ChangeLog (239095 => 239096) --- trunk/LayoutTests/ChangeLog 2018-12-12 02:54:17 UTC (rev 239095) +++ trunk/LayoutTests/ChangeLog 2018-12-12 03:58:41 UTC (rev 239096) @@ -1,3 +1,16 @@ +2018-12-10 Ryosuke Niwa + +connectedCallback is invoked during the removal of the element inside another element's connectedCallback +https://bugs.webkit.org/show_bug.cgi?id=183586 + + +Reviewed by Frédéric Wang. + +Added a W3C style testharness test. + +* fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Added. +* fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Added. + 2018-12-11 Justin Fan [WebGPU] Implement WebGPUBuffer Added: trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt (0 => 239096) --- trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt (rev 0) +++ trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt 2018-12-12 03:58:41 UTC (rev 239096) @@ -0,0 +1,10 @@ + +PASS Disconnecting an element with disconnectedCallback while it has a connectedCallback in its custom element reaction queue must result in connectedCallback getting invoked before the removal completes +PASS Disconnecting an element without disconnectedCallback while it has a connectedCallback in its custom element reaction queue must not result in connectedCallback getting invoked before the removal completes +PASS Connecting a element with connectedCallback while it has a disconnectedCallback in its custom element reaction queue must result in disconnectedCallback
[webkit-changes] [239095] trunk/Tools
Title: [239095] trunk/Tools Revision 239095 Author cdu...@apple.com Date 2018-12-11 18:54:17 -0800 (Tue, 11 Dec 2018) Log Message Unreviewed, fix bad check in API test added in r239080. * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Diff Modified: trunk/Tools/ChangeLog (239094 => 239095) --- trunk/Tools/ChangeLog 2018-12-12 01:40:06 UTC (rev 239094) +++ trunk/Tools/ChangeLog 2018-12-12 02:54:17 UTC (rev 239095) @@ -1,3 +1,9 @@ +2018-12-11 Chris Dumez + +Unreviewed, fix bad check in API test added in r239080. + +* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: + 2018-12-11 Fujii Hironori [Win][Clang] Fix warning -Wmissing-field-initializers Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (239094 => 239095) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-12-12 01:40:06 UTC (rev 239094) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-12-12 02:54:17 UTC (rev 239095) @@ -2534,7 +2534,7 @@ TestWebKitAPI::Util::run(); done = false; -EXPECT_EQ(webkitPID, [webView _webProcessIdentifier]); +EXPECT_NE(applePID, [webView _webProcessIdentifier]); EXPECT_WK_STREQ(@"pson://www.webkit.org/main.html", [[webView URL] absoluteString]); EXPECT_WK_STREQ(@"pson://www.webkit.org/main.html", [backForwardList.currentItem.URL absoluteString]); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239094] trunk
Title: [239094] trunk Revision 239094 Author justin_...@apple.com Date 2018-12-11 17:40:06 -0800 (Tue, 11 Dec 2018) Log Message Source/WebCore: [WebGPU] Implement WebGPUBuffer, and some nullibility consistency in WebGPU https://bugs.webkit.org/show_bug.cgi?id=192516 Reviewed by Dean Jackson. Test: webgpu/buffers.html Enable basic creation of WebGPUBuffers, and fix nullability inconsitencies in WebGPU implementation. Add necessary symbols and files for Web/GPUBuffer, Web/GPUBufferUsage, and Web/GPUBufferDescriptor: * CMakeLists.txt: * DerivedSources.make: * Sources.txt: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/WebCoreBuiltinNames.h: * Modules/webgpu/WebGPUBuffer.cpp: Added. (WebCore::WebGPUBuffer::create): (WebCore::WebGPUBuffer::WebGPUBuffer): * Modules/webgpu/WebGPUBuffer.h: Added. (WebCore::WebGPUBuffer::mapping const): (WebCore::WebGPUBuffer::unmap): Unimplemented stub, for now, as Metal equivalent is unclear. (WebCore::WebGPUBuffer::destroy): Unimplemented stub. * Modules/webgpu/WebGPUBuffer.idl: Added. * Modules/webgpu/WebGPUBufferDescriptor.h: Added. * Modules/webgpu/WebGPUBufferDescriptor.idl: Added. * Modules/webgpu/WebGPUDevice.cpp: (WebCore::WebGPUDevice::createBuffer const): Added. * platform/graphics/gpu/GPUBuffer.h: (WebCore::GPUBuffer::platformBuffer const): (WebCore::GPUBuffer::mapping const): * platform/graphics/gpu/GPUBufferDescriptor.h: Added. * platform/graphics/gpu/GPUDevice.cpp: (WebCore::GPUDevice::createBuffer const): Added. * platform/graphics/gpu/GPUDevice.h: * platform/graphics/gpu/cocoa/GPUBufferMetal.mm: Added. (WebCore::GPUBuffer::create): Attempt to create a page-aligned Gigacage to back the GPUBuffer's ArrayBuffer. (WebCore::GPUBuffer::GPUBuffer): (WebCore::GPUBuffer::~GPUBuffer): Dereference mapped ArrayBuffer first. Small benign edits, most to make nullability more consistent in WebGPU classes: * Modules/webgpu/WebGPUCommandBuffer.cpp: (WebCore::WebGPUCommandBuffer::create): (WebCore::WebGPUCommandBuffer::beginRenderPass): * Modules/webgpu/WebGPUCommandBuffer.h: * Modules/webgpu/WebGPUDevice.cpp: (WebCore::WebGPUDevice::create): (WebCore::WebGPUDevice::WebGPUDevice): (WebCore::WebGPUDevice::createShaderModule const): (WebCore::WebGPUDevice::createRenderPipeline const): (WebCore::WebGPUDevice::createCommandBuffer const): * Modules/webgpu/WebGPUDevice.h: (WebCore::WebGPUDevice::device const): * Modules/webgpu/WebGPUDevice.idl: * Modules/webgpu/WebGPUQueue.cpp: (WebCore::WebGPUQueue::create): * Modules/webgpu/WebGPURenderPassEncoder.cpp: (WebCore::WebGPURenderPassEncoder::create): * Modules/webgpu/WebGPURenderPassEncoder.h: * Modules/webgpu/WebGPUShaderModule.cpp: (WebCore::WebGPUShaderModule::create): (WebCore::WebGPUShaderModule::WebGPUShaderModule): * Modules/webgpu/WebGPUShaderModule.h: (WebCore::WebGPUShaderModule::module const): * Modules/webgpu/WebGPUSwapChain.idl: Sync with IDL changes. * Modules/webgpu/WebGPUTexture.cpp: (WebCore::WebGPUTexture::create): (WebCore::WebGPUTexture::createDefaultTextureView): * Modules/webgpu/WebGPUTextureView.cpp: (WebCore::WebGPUTextureView::create): * Modules/webgpu/WebGPUTextureView.h: * platform/graphics/gpu/cocoa/GPUQueueMetal.mm: (WebCore::GPUQueue::create): * platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm: (WebCore::GPURenderPipeline::create): * platform/graphics/gpu/cocoa/GPUShaderModuleMetal.mm: (WebCore::GPUShaderModule::create): * platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm: (WebCore::GPUSwapChain::setDevice): * platform/graphics/gpu/cocoa/GPUTextureMetal.mm: (WebCore::GPUTexture::GPUTexture): LayoutTests: [WebGPU] Implement WebGPUBuffer https://bugs.webkit.org/show_bug.cgi?id=192516 Reviewed by Dean Jackson. Basic test to create a WebGPUBuffer and ensure that its memory is valid. * webgpu/buffers-expected.txt: Added. * webgpu/buffers.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.h trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.h trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.idl trunk/Source/WebCore/Modules/webgpu/WebGPUQueue.cpp trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h trunk/Source/WebCore/Modules/webgpu/WebGPUShaderModule.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUShaderModule.h trunk/Source/WebCore/Modules/webgpu/WebGPUSwapChain.idl trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUTextureView.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUTextureView.h trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
[webkit-changes] [239093] trunk/Source/WTF
Title: [239093] trunk/Source/WTF
Revision 239093
Author hironori.fu...@sony.com
Date 2018-12-11 17:34:05 -0800 (Tue, 11 Dec 2018)
Log Message
[Win][Clang] Fix compilation warnings of WTF
https://bugs.webkit.org/show_bug.cgi?id=192583
Reviewed by Alex Christensen.
clang-cl reports the following warnings.
> [92/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\StackBounds.cpp.obj
> ..\..\Source\WTF\wtf\StackBounds.cpp(163,48): warning: missing field 'AllocationBase' initializer [-Wmissing-field-initializers]
> MEMORY_BASIC_INFORMATION stackOrigin = { 0 };
>^
> 1 warning generated.
> [160/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\win\RunLoopWin.cpp.obj
> ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(34,54): warning: ISO C++11 does not allow conversion from string literal to 'const LPWSTR' (aka 'wchar_t *const') [-Wwritable-strings]
> static const LPWSTR kRunLoopMessageWindowClassName = L"RunLoopMessageWindow";
> ^
> ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(86,32): warning: missing field 'lpfnWndProc' initializer [-Wmissing-field-initializers]
> WNDCLASS windowClass = { 0 };
>^
> 2 warnings generated.
> [175/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\DateMath.cpp.obj
> ..\..\Source\WTF\wtf\DateMath.cpp(125,20): warning: unused function 'getLocalTime' [-Wunused-function]
> static inline void getLocalTime(const time_t* localTime, struct tm* localTM)
>^
> 1 warning generated.
* wtf/DateMath.cpp:
(WTF::getLocalTime): Defined only if used.
* wtf/StackBounds.cpp:
(WTF::StackBounds::currentThreadStackBoundsInternal): Initialize stackOrigin with '{ }'.
* wtf/win/RunLoopWin.cpp: Change the type of kRunLoopMessageWindowClassName to LPCWSTR.
(WTF::RunLoop::registerRunLoopMessageWindowClass): Initialize windowClass with '{ }'.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DateMath.cpp
trunk/Source/WTF/wtf/StackBounds.cpp
trunk/Source/WTF/wtf/win/RunLoopWin.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (239092 => 239093)
--- trunk/Source/WTF/ChangeLog 2018-12-12 01:15:55 UTC (rev 239092)
+++ trunk/Source/WTF/ChangeLog 2018-12-12 01:34:05 UTC (rev 239093)
@@ -1,3 +1,38 @@
+2018-12-11 Fujii Hironori
+
+[Win][Clang] Fix compilation warnings of WTF
+https://bugs.webkit.org/show_bug.cgi?id=192583
+
+Reviewed by Alex Christensen.
+
+clang-cl reports the following warnings.
+
+> [92/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\StackBounds.cpp.obj
+> ..\..\Source\WTF\wtf\StackBounds.cpp(163,48): warning: missing field 'AllocationBase' initializer [-Wmissing-field-initializers]
+> MEMORY_BASIC_INFORMATION stackOrigin = { 0 };
+>^
+> 1 warning generated.
+> [160/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\win\RunLoopWin.cpp.obj
+> ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(34,54): warning: ISO C++11 does not allow conversion from string literal to 'const LPWSTR' (aka 'wchar_t *const') [-Wwritable-strings]
+> static const LPWSTR kRunLoopMessageWindowClassName = L"RunLoopMessageWindow";
+> ^
+> ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(86,32): warning: missing field 'lpfnWndProc' initializer [-Wmissing-field-initializers]
+> WNDCLASS windowClass = { 0 };
+>^
+> 2 warnings generated.
+> [175/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\DateMath.cpp.obj
+> ..\..\Source\WTF\wtf\DateMath.cpp(125,20): warning: unused function 'getLocalTime' [-Wunused-function]
+> static inline void getLocalTime(const time_t* localTime, struct tm* localTM)
+>^
+> 1 warning generated.
+
+* wtf/DateMath.cpp:
+(WTF::getLocalTime): Defined only if used.
+* wtf/StackBounds.cpp:
+(WTF::StackBounds::currentThreadStackBoundsInternal): Initialize stackOrigin with '{ }'.
+* wtf/win/RunLoopWin.cpp: Change the type of kRunLoopMessageWindowClassName to LPCWSTR.
+(WTF::RunLoop::registerRunLoopMessageWindowClass): Initialize windowClass with '{ }'.
+
2018-12-11 Andy Estes
Introduce makeBlockPtr for lambdas
Modified: trunk/Source/WTF/wtf/DateMath.cpp (239092 => 239093)
--- trunk/Source/WTF/wtf/DateMath.cpp 2018-12-12 01:15:55 UTC (rev 239092)
+++ trunk/Source/WTF/wtf/DateMath.cpp 2018-12-12 01:34:05 UTC (rev 239093)
@@ -122,16 +122,16 @@
{0, 31, 60, 91, 121, 152, 182, 213, 244, 274, 305, 335}
};
+#if !OS(WINDOWS) || HAVE(TM_GMTOFF)
static inline void getLocalTime(const time_t* localTime, struct tm* localTM)
{
-#if COMPILER(MSVC)
-localtime_s(localTM, localTime);
-#elif
[webkit-changes] [239092] trunk
Title: [239092] trunk
Revision 239092
Author hironori.fu...@sony.com
Date 2018-12-11 17:15:55 -0800 (Tue, 11 Dec 2018)
Log Message
[Win][Clang] Fix warning -Wmissing-field-initializers
https://bugs.webkit.org/show_bug.cgi?id=192584
Reviewed by Yusuke Suzuki.
Initialize a struct with '{ }' instead of '= {0}'.
Source/WebCore:
No new tests, no behavior changes.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::lastResortFallbackFont):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::setFileDescriptorData):
(WebCore::setFileContentData):
(WebCore::setUCharData):
(WebCore::setUtf8Data):
(WebCore::setCFData):
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* platform/win/DefWndProcWindowClass.cpp:
(WebCore::registerClass):
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
* platform/win/PasteboardWin.cpp:
(WebCore::writeURL):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writePlainTextToDataObject):
(WebCore::writeFileToDataObject):
(WebCore::Pasteboard::writeMarkup):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::show):
* platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
Source/WebKit:
* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::initializeToolTipWindow):
(WebKit::WebView::setToolTip):
Source/WebKitLegacy/win:
* WebKitMessageLoop.cpp:
(WebKitMessageLoop::run):
* WebView.cpp:
(WebView::onMenuCommand):
(WebView::gesture):
(WebView::setShouldInvertColors):
(WebView::initializeToolTipWindow):
(WebView::setToolTip):
(WebView::fullScreenClientForceRepaint):
Tools:
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
* DumpRenderTree/win/EventSender.cpp:
(makeMsg):
(replaySavedEvents):
(beginDragWithFilesCallback):
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
* MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
(updateMenuItemForHistoryItem):
* MiniBrowser/win/WinMain.cpp:
(wWinMain):
* TestWebKitAPI/win/HostWindow.cpp:
(TestWebKitAPI::HostWindow::clientRect const):
(TestWebKitAPI::HostWindow::registerWindowClass):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::registerWindowClass):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::registerWindowClass):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::windowSnapshotImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp
trunk/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp
trunk/Source/WebCore/platform/win/CursorWin.cpp
trunk/Source/WebCore/platform/win/DefWndProcWindowClass.cpp
trunk/Source/WebCore/platform/win/DragImageWin.cpp
trunk/Source/WebCore/platform/win/PasteboardWin.cpp
trunk/Source/WebCore/platform/win/PopupMenuWin.cpp
trunk/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp
trunk/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp
trunk/Source/WebKit/UIProcess/win/WebView.cpp
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebKitMessageLoop.cpp
trunk/Source/WebKitLegacy/win/WebView.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/win/EventSender.cpp
trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp
trunk/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp
trunk/Tools/MiniBrowser/win/WinMain.cpp
trunk/Tools/TestWebKitAPI/win/HostWindow.cpp
trunk/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (239091 => 239092)
--- trunk/Source/WebCore/ChangeLog 2018-12-12 00:18:13 UTC (rev 239091)
+++ trunk/Source/WebCore/ChangeLog 2018-12-12 01:15:55 UTC (rev 239092)
@@ -1,3 +1,42 @@
+2018-12-11 Fujii Hironori
+
+[Win][Clang] Fix warning -Wmissing-field-initializers
+https://bugs.webkit.org/show_bug.cgi?id=192584
+
+Reviewed by Yusuke Suzuki.
+
+Initialize a struct with '{ }' instead of '= {0}'.
+
+No new tests, no behavior changes.
+
+* platform/graphics/win/FontCacheWin.cpp:
+(WebCore::FontCache::lastResortFallbackFont):
+* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
+(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):
+* platform/win/ClipboardUtilitiesWin.cpp:
+(WebCore::setFileDescriptorData):
+(WebCore::setFileContentData):
+
[webkit-changes] [239091] trunk/Source/WebCore
Title: [239091] trunk/Source/WebCore
Revision 239091
Author jer.no...@apple.com
Date 2018-12-11 16:18:13 -0800 (Tue, 11 Dec 2018)
Log Message
Globally namespaced objects shouldn't use framework-prefixed names
https://bugs.webkit.org/show_bug.cgi?id=192600
Reviewed by Eric Carlson.
Rename CMSampleBufferIs... -> isCMSampleBuffer...
* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::isCMSampleBufferRandomAccess):
(WebCore::isCMSampleBufferNonDisplaying):
(WebCore::MediaSampleAVFObjC::flags const):
(WebCore::CMSampleBufferIsRandomAccess): Deleted.
(WebCore::CMSampleBufferIsNonDisplaying): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (239090 => 239091)
--- trunk/Source/WebCore/ChangeLog 2018-12-11 22:34:40 UTC (rev 239090)
+++ trunk/Source/WebCore/ChangeLog 2018-12-12 00:18:13 UTC (rev 239091)
@@ -1,3 +1,19 @@
+2018-12-11 Jer Noble
+
+Globally namespaced objects shouldn't use framework-prefixed names
+https://bugs.webkit.org/show_bug.cgi?id=192600
+
+Reviewed by Eric Carlson.
+
+Rename CMSampleBufferIs... -> isCMSampleBuffer...
+
+* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
+(WebCore::isCMSampleBufferRandomAccess):
+(WebCore::isCMSampleBufferNonDisplaying):
+(WebCore::MediaSampleAVFObjC::flags const):
+(WebCore::CMSampleBufferIsRandomAccess): Deleted.
+(WebCore::CMSampleBufferIsNonDisplaying): Deleted.
+
2018-12-11 Brent Fulgham
Don't attempt to compute animated values when there is no relevant animation
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm (239090 => 239091)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm 2018-12-11 22:34:40 UTC (rev 239090)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm 2018-12-12 00:18:13 UTC (rev 239091)
@@ -119,7 +119,7 @@
return CVPixelBufferGetPixelFormatType(pixelBuffer);
}
-static bool CMSampleBufferIsRandomAccess(CMSampleBufferRef sample)
+static bool isCMSampleBufferRandomAccess(CMSampleBufferRef sample)
{
CFArrayRef attachments = CMSampleBufferGetSampleAttachmentsArray(sample, false);
if (!attachments)
@@ -133,7 +133,7 @@
return true;
}
-static bool CMSampleBufferIsNonDisplaying(CMSampleBufferRef sample)
+static bool isCMSampleBufferNonDisplaying(CMSampleBufferRef sample)
{
CFArrayRef attachments = CMSampleBufferGetSampleAttachmentsArray(sample, false);
if (!attachments)
@@ -152,10 +152,10 @@
{
int returnValue = MediaSample::None;
-if (CMSampleBufferIsRandomAccess(m_sample.get()))
+if (isCMSampleBufferRandomAccess(m_sample.get()))
returnValue |= MediaSample::IsSync;
-if (CMSampleBufferIsNonDisplaying(m_sample.get()))
+if (isCMSampleBufferNonDisplaying(m_sample.get()))
returnValue |= MediaSample::IsNonDisplaying;
return SampleFlags(returnValue);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239090] trunk
Title: [239090] trunk Revision 239090 Author bfulg...@apple.com Date 2018-12-11 14:34:40 -0800 (Tue, 11 Dec 2018) Log Message Don't attempt to compute animated values when there is no relevant animation https://bugs.webkit.org/show_bug.cgi?id=192591 Reviewed by Dean Jackson. Source/WebCore: Check if the property is supposed to be animated, or has animatable features, before attempting to calculate the current animated value. Test: svg/animations/avoid-calculating-for-non-animating-elements.html * svg/SVGAnimateElementBase.cpp: (WebCore::SVGAnimateElementBase::calculateAnimatedValue): LayoutTests: * svg/animations/avoid-calculating-for-non-animating-elements-expected.txt: Added. * svg/animations/avoid-calculating-for-non-animating-elements.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp Added Paths trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements-expected.txt trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements.html Diff Modified: trunk/LayoutTests/ChangeLog (239089 => 239090) --- trunk/LayoutTests/ChangeLog 2018-12-11 22:00:30 UTC (rev 239089) +++ trunk/LayoutTests/ChangeLog 2018-12-11 22:34:40 UTC (rev 239090) @@ -1,3 +1,14 @@ +2018-12-11 Brent Fulgham + +Don't attempt to compute animated values when there is no relevant animation +https://bugs.webkit.org/show_bug.cgi?id=192591 + + +Reviewed by Dean Jackson. + +* svg/animations/avoid-calculating-for-non-animating-elements-expected.txt: Added. +* svg/animations/avoid-calculating-for-non-animating-elements.html: Added. + 2018-12-11 Chris Dumez Unreviewed, fix typos in console log from r239087. Added: trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements-expected.txt (0 => 239090) --- trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements-expected.txt (rev 0) +++ trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements-expected.txt 2018-12-11 22:34:40 UTC (rev 239090) @@ -0,0 +1,4 @@ +The test passes if it does not crash. + +A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. A certain amount of content is needed in the page to trigger the bug. + Added: trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements.html (0 => 239090) --- trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements.html (rev 0) +++ trunk/LayoutTests/svg/animations/avoid-calculating-for-non-animating-elements.html 2018-12-11 22:34:40 UTC (rev 239090) @@ -0,0 +1,32 @@ + + + +Test request animation value for non-animating element + +if (window.testRunner) +testRunner.dumpAsText(true); + + + +The test passes if it does not crash. + +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. +A certain amount of content is needed in the page to trigger the bug. + + + + + + + + Modified: trunk/Source/WebCore/ChangeLog (239089 => 239090) --- trunk/Source/WebCore/ChangeLog 2018-12-11 22:00:30 UTC (rev 239089) +++ trunk/Source/WebCore/ChangeLog 2018-12-11 22:34:40 UTC (rev 239090) @@ -1,3 +1,19 @@ +2018-12-11 Brent Fulgham + +Don't attempt to compute animated values when there is no relevant animation +
[webkit-changes] [239089] trunk
Title: [239089] trunk
Revision 239089
Author cdu...@apple.com
Date 2018-12-11 14:00:30 -0800 (Tue, 11 Dec 2018)
Log Message
Unreviewed, fix typos in console log from r239087.
Source/WebCore:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
LayoutTests:
* http/tests/events/device-orientation-motion-non-secure-context.html:
* platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html
trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (239088 => 239089)
--- trunk/LayoutTests/ChangeLog 2018-12-11 21:54:20 UTC (rev 239088)
+++ trunk/LayoutTests/ChangeLog 2018-12-11 22:00:30 UTC (rev 239089)
@@ -1,5 +1,12 @@
2018-12-11 Chris Dumez
+Unreviewed, fix typos in console log from r239087.
+
+* http/tests/events/device-orientation-motion-non-secure-context.html:
+* platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt:
+
+2018-12-11 Chris Dumez
+
Restrict DeviceMotion / DeviceOrientation APIs to secure contexts
https://bugs.webkit.org/show_bug.cgi?id=192595
Modified: trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html (239088 => 239089)
--- trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html 2018-12-11 21:54:20 UTC (rev 239088)
+++ trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html 2018-12-11 22:00:30 UTC (rev 239089)
@@ -27,7 +27,7 @@
debug("* Registering device motion listener");
addEventListener("devicemotion", function() { });
internals.postTask(() => {
-shouldBeEqualToString("lastConsoleMessage", "Blocked attempt add device motion or orientation listener because the browsing context is not secure.");
+shouldBeEqualToString("lastConsoleMessage", "Blocked attempt to add a device motion or orientation listener because the browsing context is not secure.");
finishJSTest();
});
}
@@ -44,7 +44,7 @@
debug("* Registering device orientation listener");
addEventListener("deviceorientation", function() { });
internals.postTask(() => {
-shouldBeEqualToString("lastConsoleMessage", "Blocked attempt add device motion or orientation listener because the browsing context is not secure.");
+shouldBeEqualToString("lastConsoleMessage", "Blocked attempt to add a device motion or orientation listener because the browsing context is not secure.");
runDeviceMotionTest();
});
}
Modified: trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt (239088 => 239089)
--- trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt 2018-12-11 21:54:20 UTC (rev 239088)
+++ trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt 2018-12-11 22:00:30 UTC (rev 239089)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 45: Blocked attempt add device motion or orientation listener because the browsing context is not secure.
-CONSOLE MESSAGE: line 28: Blocked attempt add device motion or orientation listener because the browsing context is not secure.
+CONSOLE MESSAGE: line 45: Blocked attempt to add a device motion or orientation listener because the browsing context is not secure.
+CONSOLE MESSAGE: line 28: Blocked attempt to add a device motion or orientation listener because the browsing context is not secure.
Tests that trying to set an event listener for deviceorientation and deviceorientation logs an error in non-secure contexts.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -6,10 +6,10 @@
* Registering device orientation listener
-PASS lastConsoleMessage is "Blocked attempt add device motion or orientation listener because the browsing context is not secure."
+PASS lastConsoleMessage is "Blocked attempt to add a device motion or orientation listener because the browsing context is not secure."
* Registering device motion listener
-PASS lastConsoleMessage is "Blocked attempt add device motion or orientation listener because the browsing context is not secure."
+PASS lastConsoleMessage is "Blocked attempt to add a device motion or orientation listener because the browsing context is not secure."
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (239088 => 239089)
--- trunk/Source/WebCore/ChangeLog 2018-12-11 21:54:20 UTC (rev 239088)
+++ trunk/Source/WebCore/ChangeLog 2018-12-11 22:00:30 UTC (rev 239089)
@@ -1,3 +1,10 @@
+2018-12-11 Chris Dumez
+
+Unreviewed,
[webkit-changes] [239088] trunk/Source
Title: [239088] trunk/Source
Revision 239088
Author timothy_hor...@apple.com
Date 2018-12-11 13:54:20 -0800 (Tue, 11 Dec 2018)
Log Message
WebCore shouldn't have a Objective-C class named NSCursor
https://bugs.webkit.org/show_bug.cgi?id=192602
Reviewed by Wenson Hsieh.
Source/WebCore:
* platform/ios/wak/WAKAppKitStubs.h:
* platform/ios/wak/WAKAppKitStubs.m:
(+[NSCursor setHiddenUntilMouseMoves:]): Deleted.
Get rid of the class.
Also remove a comment that seems to have detached from wherever it's supposed to be.
Source/WebKitLegacy/mac:
* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:keyDown:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView keyDown:]):
(-[WebHTMLView performKeyEquivalent:]):
Only use NSCursor on macOS.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h
trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (239087 => 239088)
--- trunk/Source/WebCore/ChangeLog 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebCore/ChangeLog 2018-12-11 21:54:20 UTC (rev 239088)
@@ -1,3 +1,17 @@
+2018-12-11 Tim Horton
+
+WebCore shouldn't have a Objective-C class named NSCursor
+https://bugs.webkit.org/show_bug.cgi?id=192602
+
+
+Reviewed by Wenson Hsieh.
+
+* platform/ios/wak/WAKAppKitStubs.h:
+* platform/ios/wak/WAKAppKitStubs.m:
+(+[NSCursor setHiddenUntilMouseMoves:]): Deleted.
+Get rid of the class.
+Also remove a comment that seems to have detached from wherever it's supposed to be.
+
2018-12-11 Chris Dumez
Restrict DeviceMotion / DeviceOrientation APIs to secure contexts
Modified: trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h (239087 => 239088)
--- trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h 2018-12-11 21:54:20 UTC (rev 239088)
@@ -23,8 +23,6 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-/* Unicodes we reserve for function keys on the keyboard, OpenStep reserves the range 0xF700-0xF8FF for this purpose. The availability of various keys will be system dependent. */
-
#ifndef WAKAppKitStubs_h
#define WAKAppKitStubs_h
@@ -205,10 +203,6 @@
NSSelectingPrevious
} NSSelectionDirection;
-WEBCORE_EXPORT @interface NSCursor : NSObject
-+ (void)setHiddenUntilMouseMoves:(BOOL)flag;
-@end
-
#endif // TARGET_OS_IPHONE
#endif // WAKAppKitStubs_h
Modified: trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m (239087 => 239088)
--- trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m 2018-12-11 21:54:20 UTC (rev 239088)
@@ -30,11 +30,4 @@
id NSApp = nil;
-@implementation NSCursor
-+ (void)setHiddenUntilMouseMoves:(BOOL)flag
-{
-UNUSED_PARAM(flag);
-}
-@end
-
#endif // PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (239087 => 239088)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-11 21:54:20 UTC (rev 239088)
@@ -1,3 +1,18 @@
+2018-12-11 Tim Horton
+
+WebCore shouldn't have a Objective-C class named NSCursor
+https://bugs.webkit.org/show_bug.cgi?id=192602
+
+
+Reviewed by Wenson Hsieh.
+
+* WebView/WebFrameView.mm:
+(-[WebFrameView keyDown:keyDown:]):
+* WebView/WebHTMLView.mm:
+(-[WebHTMLView keyDown:]):
+(-[WebHTMLView performKeyEquivalent:]):
+Only use NSCursor on macOS.
+
2018-12-10 Don Olmstead
Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm (239087 => 239088)
--- trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm 2018-12-11 21:54:20 UTC (rev 239088)
@@ -1087,8 +1087,10 @@
if (callSuper) {
[super keyDown:event];
} else {
-// if we did something useful, get the cursor out of the way
+#if PLATFORM(MAC)
+// If we did something useful, get the cursor out of the way.
[NSCursor setHiddenUntilMouseMoves:YES];
+#endif
}
}
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm (239087 => 239088)
--- trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm 2018-12-11 21:49:51 UTC (rev 239087)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm 2018-12-11 21:54:20 UTC (rev 239088)
@@ -4976,8 +4976,11 @@
if (callSuper)
[super keyDown:event];
-else
+else {
+#if PLATFORM(MAC)
[NSCursor setHiddenUntilMouseMoves:YES];
+#endif
+}
}
-
[webkit-changes] [239087] trunk
Title: [239087] trunk
Revision 239087
Author cdu...@apple.com
Date 2018-12-11 13:49:51 -0800 (Tue, 11 Dec 2018)
Log Message
Restrict DeviceMotion / DeviceOrientation APIs to secure contexts
https://bugs.webkit.org/show_bug.cgi?id=192595
Reviewed by Dean Jackson.
Source/WebCore:
Tests: http/tests/events/device-orientation-motion-non-secure-context.html
http/tests/events/device-orientation-motion-secure-context.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::setIsPotentiallyTrustworthy):
* testing/Internals.cpp:
(WebCore::Internals::markContextAsInsecure):
(WebCore::Internals::postTask):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
Add layout test coverage. Note however that we currently do not have mock data providers
for these APIs.
* http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
* http/tests/events/device-orientation-motion-non-secure-context.html: Added.
* http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.
* http/tests/events/device-orientation-motion-secure-context.html: Added.
* platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
* platform/ios/http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context-expected.txt
trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html
trunk/LayoutTests/http/tests/events/device-orientation-motion-secure-context-expected.txt
trunk/LayoutTests/http/tests/events/device-orientation-motion-secure-context.html
trunk/LayoutTests/platform/ios/http/tests/events/
trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt
trunk/LayoutTests/platform/ios/http/tests/events/device-orientation-motion-secure-context-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (239086 => 239087)
--- trunk/LayoutTests/ChangeLog 2018-12-11 21:13:32 UTC (rev 239086)
+++ trunk/LayoutTests/ChangeLog 2018-12-11 21:49:51 UTC (rev 239087)
@@ -1,3 +1,21 @@
+2018-12-11 Chris Dumez
+
+Restrict DeviceMotion / DeviceOrientation APIs to secure contexts
+https://bugs.webkit.org/show_bug.cgi?id=192595
+
+
+Reviewed by Dean Jackson.
+
+Add layout test coverage. Note however that we currently do not have mock data providers
+for these APIs.
+
+* http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
+* http/tests/events/device-orientation-motion-non-secure-context.html: Added.
+* http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.
+* http/tests/events/device-orientation-motion-secure-context.html: Added.
+* platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
+* platform/ios/http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.
+
2018-12-10 Brent Fulgham
SVGViewSpec objects should mark relevant SVG elements
Added: trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context-expected.txt (0 => 239087)
--- trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context-expected.txt 2018-12-11 21:49:51 UTC (rev 239087)
@@ -0,0 +1,11 @@
+CONSOLE MESSAGE: line 38: Device Orientation API is not supported
+CONSOLE MESSAGE: line 20: Device Motion API is not supported
+Tests that trying to set an event listener for deviceorientation and deviceorientation logs an error in non-secure contexts.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html (0 => 239087)
--- trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html (rev 0)
+++ trunk/LayoutTests/http/tests/events/device-orientation-motion-non-secure-context.html 2018-12-11 21:49:51 UTC (rev 239087)
@@ -0,0 +1,55 @@
+
+
+
+
+description("Tests that trying to set an event listener for deviceorientation and deviceorientation logs an error in non-secure contexts.");
+jsTestIsAsync = true;
+
+// localhost is secure by default.
+internals.markContextAsInsecure();
+
+let lastConsoleMessage = null;
[webkit-changes] [239086] trunk/Source/WebCore
Title: [239086] trunk/Source/WebCore Revision 239086 Author wenson_hs...@apple.com Date 2018-12-11 13:13:32 -0800 (Tue, 11 Dec 2018) Log Message [iOS] Send the full list of file upload URLs and types in PasteboardItemInfo https://bugs.webkit.org/show_bug.cgi?id=192598 Work towards Reviewed by Tim Horton. Refactors PasteboardItemInfo to contain lists of file URLs and corresponding pasteboard types, instead of just a "preferred" file upload URL and type. See below for more details. * platform/PasteboardItemInfo.h: (WebCore::PasteboardItemInfo::pathForContentType const): Add a helper method to find a file upload URL corresponding to a given type. (WebCore::PasteboardItemInfo::encode const): (WebCore::PasteboardItemInfo::decode): Change `pathForFileUpload` to `pathsForFileUpload`, and `contentTypeForFileUpload` to `contentTypesForFileUpload`. * platform/ios/AbstractPasteboard.h: * platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::readRespectingUTIFidelities): Adjust this to take the file path for the highest fidelity representation in `pathsForContentType`. (WebCore::Pasteboard::readFilePaths): * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex): * platform/ios/WebItemProviderPasteboard.h: * platform/ios/WebItemProviderPasteboard.mm: (-[NSItemProvider web_containsFileURLAndFileUploadContent]): (-[NSItemProvider web_fileUploadContentTypes]): Replace `web_containsFileUploadContent` with `web_fileUploadContentTypes`, which returns the full list of file upload content types (rather than just a `BOOL` indicating whether one or more of these types exist). (-[WebItemProviderPasteboard fileUploadURLsAtIndex:fileTypes:]): (-[WebItemProviderPasteboard numberOfFiles]): (-[NSItemProvider web_containsFileUploadContent]): Deleted. (-[WebItemProviderPasteboard preferredFileUploadURLAtIndex:fileType:]): Deleted. Replaced with `-fileUploadURLsAtIndex:fileTypes:`. This implementation currently just returns the highest fidelity loaded type identifier, but this is wrong because it doesn't take into account inline data types that shouldn't be represented as data for file uploads (for instance, it never makes sense to upload the internal data serialization for an `NSURL` as a file on the web). Instead, use existing logic in `web_fileUploadContentTypes` to determine which file types can be treated as file uploads, and return all of these file types that we've loaded. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/PasteboardItemInfo.h trunk/Source/WebCore/platform/ios/AbstractPasteboard.h trunk/Source/WebCore/platform/ios/PasteboardIOS.mm trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm Diff Modified: trunk/Source/WebCore/ChangeLog (239085 => 239086) --- trunk/Source/WebCore/ChangeLog 2018-12-11 21:12:11 UTC (rev 239085) +++ trunk/Source/WebCore/ChangeLog 2018-12-11 21:13:32 UTC (rev 239086) @@ -1,3 +1,54 @@ +2018-12-11 Wenson Hsieh + +[iOS] Send the full list of file upload URLs and types in PasteboardItemInfo +https://bugs.webkit.org/show_bug.cgi?id=192598 +Work towards + +Reviewed by Tim Horton. + +Refactors PasteboardItemInfo to contain lists of file URLs and corresponding pasteboard types, instead of just +a "preferred" file upload URL and type. See below for more details. + +* platform/PasteboardItemInfo.h: +(WebCore::PasteboardItemInfo::pathForContentType const): + +Add a helper method to find a file upload URL corresponding to a given type. + +(WebCore::PasteboardItemInfo::encode const): +(WebCore::PasteboardItemInfo::decode): + +Change `pathForFileUpload` to `pathsForFileUpload`, and `contentTypeForFileUpload` to `contentTypesForFileUpload`. + +* platform/ios/AbstractPasteboard.h: +* platform/ios/PasteboardIOS.mm: +(WebCore::Pasteboard::readRespectingUTIFidelities): + +Adjust this to take the file path for the highest fidelity representation in `pathsForContentType`. + +(WebCore::Pasteboard::readFilePaths): +* platform/ios/PlatformPasteboardIOS.mm: +(WebCore::PlatformPasteboard::informationForItemAtIndex): +* platform/ios/WebItemProviderPasteboard.h: +* platform/ios/WebItemProviderPasteboard.mm: +(-[NSItemProvider web_containsFileURLAndFileUploadContent]): +(-[NSItemProvider web_fileUploadContentTypes]): + +Replace `web_containsFileUploadContent` with `web_fileUploadContentTypes`, which returns the full list of file +upload content types (rather than just a `BOOL` indicating whether one or more of these types exist). + +(-[WebItemProviderPasteboard fileUploadURLsAtIndex:fileTypes:]): +(-[WebItemProviderPasteboard numberOfFiles]): +(-[NSItemProvider
[webkit-changes] [239085] branches/safari-606-branch
Title: [239085] branches/safari-606-branch Revision 239085 Author alanc...@apple.com Date 2018-12-11 13:12:11 -0800 (Tue, 11 Dec 2018) Log Message Cherry-pick r238877. rdar://problem/45997440 Don't report resource timing to parent frame for history items https://bugs.webkit.org/show_bug.cgi?id=192273 Reviewed by Youenn Fablet. Source/WebCore: We should not report history items to its parent frame as those are less interested to its parent and might not be the first navigation in the iframes. This change aligns the behavior when a cached document is not available for the history item with the available case as we don't report resource timing for any cached main document. Test: http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadDifferentDocumentItem): LayoutTests: * http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt: Added. * http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html: Copied from LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html. * http/tests/misc/resource-timing-navigation-in-restored-iframe.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238877 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-606-branch/LayoutTests/ChangeLog branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html branches/safari-606-branch/Source/WebCore/ChangeLog branches/safari-606-branch/Source/WebCore/loader/FrameLoader.cpp Added Paths branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html Diff Modified: branches/safari-606-branch/LayoutTests/ChangeLog (239084 => 239085) --- branches/safari-606-branch/LayoutTests/ChangeLog 2018-12-11 21:12:07 UTC (rev 239084) +++ branches/safari-606-branch/LayoutTests/ChangeLog 2018-12-11 21:12:11 UTC (rev 239085) @@ -1,3 +1,47 @@ +2018-12-11 Alan Coon + +Cherry-pick r238877. rdar://problem/45997440 + +Don't report resource timing to parent frame for history items +https://bugs.webkit.org/show_bug.cgi?id=192273 + + +Reviewed by Youenn Fablet. + +Source/WebCore: + +We should not report history items to its parent frame as those are less +interested to its parent and might not be the first navigation in the iframes. + +This change aligns the behavior when a cached document is not available for the +history item with the available case as we don't report resource timing for any +cached main document. + +Test: http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html + +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::loadDifferentDocumentItem): + +LayoutTests: + +* http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt: Added. +* http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html: Copied from LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html. +* http/tests/misc/resource-timing-navigation-in-restored-iframe.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238877 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2018-11-30 Jiewen Tan + +Don't report resource timing to parent frame for history items +https://bugs.webkit.org/show_bug.cgi?id=192273 + + +Reviewed by Youenn Fablet. + +* http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt: Added. +* http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html: Copied from LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html. +* http/tests/misc/resource-timing-navigation-in-restored-iframe.html: + 2018-12-05 Alan Coon Apply patch. rdar://problem/45997392 Added: branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt (0 => 239085) --- branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt (rev 0) +++ branches/safari-606-branch/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt 2018-12-11 21:12:11 UTC (rev 239085) @@ -0,0 +1,12 @@ +ALERT: Going back. +Tests that an iframe restored from history does not report resource timing. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS resources.length is 1 +PASS resources[0].name is "http://127.0.0.1:8000/js-test-resources/js-test.js" +PASS successfullyParsed is true + +TEST COMPLETE + Copied:
[webkit-changes] [239083] branches/safari-606-branch/Source/WebCore
Title: [239083] branches/safari-606-branch/Source/WebCore
Revision 239083
Author alanc...@apple.com
Date 2018-12-11 13:12:04 -0800 (Tue, 11 Dec 2018)
Log Message
Cherry-pick r238232. rdar://problem/46085281
Modernize RTCPeerConnection handling of pendingActivity
https://bugs.webkit.org/show_bug.cgi?id=191661
Reviewed by Eric Carlson.
makePendingActivity is the modern way to handle set/unset of pending activity.
No change of behavior.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::doStop):
* Modules/mediastream/RTCPeerConnection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
Diff
Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (239082 => 239083)
--- branches/safari-606-branch/Source/WebCore/ChangeLog 2018-12-11 21:12:01 UTC (rev 239082)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog 2018-12-11 21:12:04 UTC (rev 239083)
@@ -1,3 +1,37 @@
+2018-12-11 Alan Coon
+
+Cherry-pick r238232. rdar://problem/46085281
+
+Modernize RTCPeerConnection handling of pendingActivity
+https://bugs.webkit.org/show_bug.cgi?id=191661
+
+Reviewed by Eric Carlson.
+
+makePendingActivity is the modern way to handle set/unset of pending activity.
+No change of behavior.
+
+* Modules/mediastream/RTCPeerConnection.cpp:
+(WebCore::RTCPeerConnection::create):
+(WebCore::RTCPeerConnection::doStop):
+* Modules/mediastream/RTCPeerConnection.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-11-15 Youenn Fablet
+
+Modernize RTCPeerConnection handling of pendingActivity
+https://bugs.webkit.org/show_bug.cgi?id=191661
+
+Reviewed by Eric Carlson.
+
+makePendingActivity is the modern way to handle set/unset of pending activity.
+No change of behavior.
+
+* Modules/mediastream/RTCPeerConnection.cpp:
+(WebCore::RTCPeerConnection::create):
+(WebCore::RTCPeerConnection::doStop):
+* Modules/mediastream/RTCPeerConnection.h:
+
2018-12-10 Mark Lam
Cherry-pick r239062. rdar://problem/46603464
Modified: branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (239082 => 239083)
--- branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2018-12-11 21:12:01 UTC (rev 239082)
+++ branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2018-12-11 21:12:04 UTC (rev 239083)
@@ -68,7 +68,7 @@
// RTCPeerConnection may send events at about any time during its lifetime.
// Let's make it uncollectable until the pc is closed by JS or the page stops it.
if (!peerConnection->isClosed()) {
-peerConnection->setPendingActivity(peerConnection.ptr());
+peerConnection->m_pendingActivity = peerConnection->makePendingActivity(peerConnection.get());
if (auto* page = downcast(context).page())
peerConnection->registerToController(page->rtcController());
}
@@ -451,8 +451,7 @@
m_isStopped = true;
m_backend->stop();
-
-unsetPendingActivity(this);
+m_pendingActivity = nullptr;
}
void RTCPeerConnection::registerToController(RTCController& controller)
Modified: branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h (239082 => 239083)
--- branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2018-12-11 21:12:01 UTC (rev 239082)
+++ branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2018-12-11 21:12:04 UTC (rev 239083)
@@ -215,6 +215,8 @@
RTCConfiguration m_configuration;
RTCController* m_controller { nullptr };
+Vector> m_certificates;
+RefPtr> m_pendingActivity;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239084] branches/safari-606-branch/Source/WebCore
Title: [239084] branches/safari-606-branch/Source/WebCore
Revision 239084
Author alanc...@apple.com
Date 2018-12-11 13:12:07 -0800 (Tue, 11 Dec 2018)
Log Message
Cherry-pick r238582. rdar://problem/46085283
Refactor duplicate code for calling into media controls
https://bugs.webkit.org/show_bug.cgi?id=192040
Reviewed by Youenn Fablet.
No new tests, no functional change.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setupAndCallJS):
(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
* html/HTMLMediaElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (239083 => 239084)
--- branches/safari-606-branch/Source/WebCore/ChangeLog 2018-12-11 21:12:04 UTC (rev 239083)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog 2018-12-11 21:12:07 UTC (rev 239084)
@@ -1,5 +1,51 @@
2018-12-11 Alan Coon
+Cherry-pick r238582. rdar://problem/46085283
+
+Refactor duplicate code for calling into media controls
+https://bugs.webkit.org/show_bug.cgi?id=192040
+
+
+Reviewed by Youenn Fablet.
+
+No new tests, no functional change.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setupAndCallJS):
+(WebCore::HTMLMediaElement::updateCaptionContainer):
+(WebCore::HTMLMediaElement::configureTextTrackDisplay):
+(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
+(WebCore::HTMLMediaElement::setControllerJSProperty):
+(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
+(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
+(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
+* html/HTMLMediaElement.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-11-27 Eric Carlson
+
+Refactor duplicate code for calling into media controls
+https://bugs.webkit.org/show_bug.cgi?id=192040
+
+
+Reviewed by Youenn Fablet.
+
+No new tests, no functional change.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setupAndCallJS):
+(WebCore::HTMLMediaElement::updateCaptionContainer):
+(WebCore::HTMLMediaElement::configureTextTrackDisplay):
+(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
+(WebCore::HTMLMediaElement::setControllerJSProperty):
+(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
+(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
+(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
+* html/HTMLMediaElement.h:
+
+2018-12-11 Alan Coon
+
Cherry-pick r238232. rdar://problem/46085281
Modernize RTCPeerConnection handling of pendingActivity
Modified: branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp (239083 => 239084)
--- branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp 2018-12-11 21:12:04 UTC (rev 239083)
+++ branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp 2018-12-11 21:12:07 UTC (rev 239084)
@@ -4322,6 +4322,26 @@
m_creatingControls = false;
}
+bool HTMLMediaElement::setupAndCallJS(const JSSetupFunction& task)
+{
+Page* page = document().page();
+if (!page)
+return false;
+
+auto pendingActivity = makePendingActivity(*this);
+auto& world = ensureIsolatedWorld();
+auto& scriptController = document().frame()->script();
+auto* globalObject = JSC::jsCast(scriptController.globalObject(world));
+auto& vm = globalObject->vm();
+JSC::JSLockHolder lock(vm);
+auto scope = DECLARE_THROW_SCOPE(vm);
+auto* exec = globalObject->globalExec();
+
+RETURN_IF_EXCEPTION(scope, false);
+
+return task(*globalObject, *exec, scriptController, world);
+}
+
void HTMLMediaElement::updateCaptionContainer()
{
#if ENABLE(MEDIA_CONTROLS_SCRIPT)
@@ -4328,12 +4348,6 @@
if (m_haveSetUpCaptionContainer)
return;
-Page* page = document().page();
-if (!page)
-return;
-
-DOMWrapperWorld& world = ensureIsolatedWorld();
-
if
[webkit-changes] [239082] branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/ webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
Title: [239082] branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
Revision 239082
Author alanc...@apple.com
Date 2018-12-11 13:12:01 -0800 (Tue, 11 Dec 2018)
Log Message
Apply patch. rdar://problem/46603462
Modified Paths
branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
Diff
Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc (239081 => 239082)
--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc 2018-12-11 20:25:21 UTC (rev 239081)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc 2018-12-11 21:12:01 UTC (rev 239082)
@@ -80,7 +80,11 @@
<< "Received RED packet with different SSRC than expected; dropping.";
return -1;
}
-
+ if (packet_length > IP_PACKET_SIZE) {
+RTC_LOG(LS_WARNING) << "Received RED packet with length exceeds maximum IP "
+ "packet size; dropping.";
+return -1;
+ }
rtc::CritScope cs(_sect_);
uint8_t red_header_length = 1;
@@ -180,6 +184,7 @@
} else if (received_packet->is_fec) {
++packet_counter_.num_fec_packets;
+
// everything behind the RED header
memcpy(received_packet->pkt->data,
incoming_rtp_packet + header.headerLength + red_header_length,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239080] trunk
Title: [239080] trunk Revision 239080 Author cdu...@apple.com Date 2018-12-11 12:24:06 -0800 (Tue, 11 Dec 2018) Log Message PSON logic gets confused by concurrent decidePolicyForNavigationAction requests https://bugs.webkit.org/show_bug.cgi?id=192482 Reviewed by Antti Koivisto. Source/WebKit: It is possible to get 2 parallel decidePolicyForNavigationAction() requests from the WebProcess when a new load is started before responding to the existing policy decision. This would lead to several issues with regards to PSON: - We would decide to swap for the first policy decision and tell the WebProcess to suspend. However, because the WebProcess issued a new decidePolicyForNavigationAction since for the same frame, the previous one is invalidated and the WebProcess would ignore our request to suspend. - We would hit assertions later on because the navigation has been destroyed and yet we're getting a didStartProvisionalLoad for it. - swapToWebProcess() was asynchronous so that it would wait for the destination SuspendedPage to finish suspending before asking it to unsuspend. This led to various problems because anything can happen in the UIProcess while we're waiting for the suspension (e.g. another load). Also, we may create the SuspendedPageProxy for the current page too late and start getting IPC from the previous process about the suspension load to about:blank. To address these issues, the following design is now implemented: - swapToWebProcess() is no longer asynchronous - instead, WebProcessPool::processForNavigation() is now asynchronous. This is better because at this point we have not yet told the WebProcess about the policy decision. We already properly deal with the policy decision being made asynchronously. This also allows us to choose another process if the SuspendedPage we'd like to use failed to suspend. - If the WebProcess receives a PolicyAction::Suspend but ignores it, have it send an IPC to the UIProcess so that the SuspendedPageProxy knows about it. We then destroy the SuspendedPageProxy and make sure it is not used. - After the asynchronous process selection, if the navigation has been destroy, abort the process-swap to avoid hitting assertions later on due to doing a load for a destroyed navigation. * UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::~SuspendedPageProxy): Make sure m_whenReadyToConsume completion handler gets called if necessary if the SuspendedPageProxy gets destroyed. We pass null so that the SuspendedPage is not used. (WebKit::SuspendedPageProxy::whenReadyToConsume): Add whenReadyToConsume() utility method to get a completion handler called when the SuspendedPageProxy is ready to be used. This basically means we have to wait for the page to finish its about:blank suspension load. If the suspension fails then we call the completion handler with null to indicate that the suspended page is not usable. (WebKit::SuspendedPageProxy::unsuspendAndConsume): Rename unsuspend() to unsuspendAndConsume() and make it synchronous. This only gets called after whenReadyToConsume()'s completion handler has been called and if we do decide to use the SuspendedPageProxy. It tells the WebProcess to unsuspend and removes the SuspendedPageProxy from the WebProcessPool. (WebKit::SuspendedPageProxy::didFinishLoad): rename m_finishedSuspendingHandler to m_whenReadyToConsume. (WebKit::SuspendedPageProxy::didFailToSuspend): Add new didFailToSuspend() that gets called when the WebProcess sends us an IPC telling us it ignored our request to suspend. We then call m_whenReadyToConsume completion handler with null and destroy the SuspendedPageProxy. (WebKit::SuspendedPageProxy::didReceiveMessage): * UIProcess/SuspendedPageProxy.h: * UIProcess/WebNavigationState.h: (WebKit::WebNavigationState::hasNavigation const): Add utility function to query if a navigation is still valid. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::swapToWebProcess): Update method so that it is no longer asynchronous. Some of its code was also moved to continueNavigationInNewProcess() for clarity. (WebKit::WebPageProxy::receivedNavigationPolicyDecision): Deal with WebProcessPool::processForNavigation() now being asynchronous. (WebKit::WebPageProxy::continueNavigationInNewProcess): Update code now that swapToWebProcess() is no longer asynchronous. Some of the swapToWebProcess() code was also moved here for clarity. (WebKit::WebPageProxy::didFailToSuspendAfterProcessSwap): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: Add new DidFailToSuspendAfterProcessSwap IPC message. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): (WebKit::WebProcessPool::processForNavigationInternal): * UIProcess/WebProcessPool.h: Make asynchronous. If we decide to use a SuspendedPageProxy's process, then call whenReadyToConsume() on it to wait for it to suspend. If the SuspendedPageProxy fails to suspend use a new process
[webkit-changes] [239079] trunk/Source/WebCore
Title: [239079] trunk/Source/WebCore
Revision 239079
Author drou...@apple.com
Date 2018-12-11 11:27:26 -0800 (Tue, 11 Dec 2018)
Log Message
Web Inspector: overlay bounds rulers don't match element when page is scrolled
https://bugs.webkit.org/show_bug.cgi?id=192577
Reviewed by Joseph Pecoraro.
When drawing the highlight for a node, the canvas is translated based on the scroll position
of the node. This translation was not applied to the bounds calculations, which meant that
the bounds always drew where the node would have been if it wasn't scrolled.
* inspector/InspectorOverlayPage.js:
(Bounds.prototype.get minX):
(Bounds.prototype.get minY):
(Bounds.prototype.get maxX):
(Bounds.prototype.get maxY):
(Bounds.prototype.offset): Added.
(drawNodeHighlight):
Drive-by: draw bounds for every node being highlighted instead of just the first one.
Drive-by: switch the bounds color to be a semi-transparent red for more visibility/contrast.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorOverlayPage.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (239078 => 239079)
--- trunk/Source/WebCore/ChangeLog 2018-12-11 19:21:38 UTC (rev 239078)
+++ trunk/Source/WebCore/ChangeLog 2018-12-11 19:27:26 UTC (rev 239079)
@@ -1,3 +1,24 @@
+2018-12-11 Devin Rousso
+
+Web Inspector: overlay bounds rulers don't match element when page is scrolled
+https://bugs.webkit.org/show_bug.cgi?id=192577
+
+Reviewed by Joseph Pecoraro.
+
+When drawing the highlight for a node, the canvas is translated based on the scroll position
+of the node. This translation was not applied to the bounds calculations, which meant that
+the bounds always drew where the node would have been if it wasn't scrolled.
+
+* inspector/InspectorOverlayPage.js:
+(Bounds.prototype.get minX):
+(Bounds.prototype.get minY):
+(Bounds.prototype.get maxX):
+(Bounds.prototype.get maxY):
+(Bounds.prototype.offset): Added.
+(drawNodeHighlight):
+Drive-by: draw bounds for every node being highlighted instead of just the first one.
+Drive-by: switch the bounds color to be a semi-transparent red for more visibility/contrast.
+
2018-12-11 Andy Estes
Introduce makeBlockPtr for lambdas
Modified: trunk/Source/WebCore/inspector/InspectorOverlayPage.js (239078 => 239079)
--- trunk/Source/WebCore/inspector/InspectorOverlayPage.js 2018-12-11 19:21:38 UTC (rev 239078)
+++ trunk/Source/WebCore/inspector/InspectorOverlayPage.js 2018-12-11 19:27:26 UTC (rev 239079)
@@ -1,4 +1,4 @@
-const boundsColor = "rgba(0,0,0,0.4)";
+const boundsColor = "rgba(255,0,0,0.6)";
const lightGridColor = "rgba(0,0,0,0.2)";
const darkGridColor = "rgba(0,0,0,0.5)";
const transparentColor = "rgba(0, 0, 0, 0)";
@@ -22,14 +22,17 @@
this._minY = Number.MAX_VALUE;
this._maxX = Number.MIN_VALUE;
this._maxY = Number.MIN_VALUE;
+
+this._offsetX = 0;
+this._offsetY = 0;
}
// Public
-get minX() { return this._minX; }
-get minY() { return this._minY; }
-get maxX() { return this._maxX; }
-get maxY() { return this._maxY; }
+get minX() { return this._minX + this._offsetX; }
+get minY() { return this._minY + this._offsetY; }
+get maxX() { return this._maxX + this._offsetX; }
+get maxY() { return this._maxY + this._offsetY; }
update(x, y)
{
@@ -38,6 +41,12 @@
this._maxX = Math.max(this._maxX, x);
this._maxY = Math.max(this._maxY, y);
}
+
+offset(x, y)
+{
+this._offsetX = x || 0;
+this._offsetY = y || 0;
+}
}
function drawPausedInDebuggerMessage(message)
@@ -50,9 +59,10 @@
function drawNodeHighlight(allHighlights)
{
-let bounds = new Bounds;
+for (let highlight of allHighlights) {
+let bounds = new Bounds;
+bounds.offset(-highlight.scrollOffset.x, -highlight.scrollOffset.y);
-for (let highlight of allHighlights) {
_isolateActions(() => {
context.translate(-highlight.scrollOffset.x, -highlight.scrollOffset.y);
@@ -62,11 +72,11 @@
if (highlight.elementData && highlight.elementData.shapeOutsideData)
_drawShapeHighlight(highlight.elementData.shapeOutsideData, bounds);
});
+
+if (DATA.showRulers)
+_drawBounds(bounds);
}
-if (DATA.showRulers)
-_drawBounds(bounds);
-
if (allHighlights.length === 1) {
for (let fragment of allHighlights[0].fragments)
_drawElementTitle(allHighlights[0].elementData, fragment, allHighlights[0].scrollOffset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239078] trunk
Title: [239078] trunk Revision 239078 Author aes...@apple.com Date 2018-12-11 11:21:38 -0800 (Tue, 11 Dec 2018) Log Message Introduce makeBlockPtr for lambdas https://bugs.webkit.org/show_bug.cgi?id=192594 Reviewed by Alex Christensen. Source/WebCore: Adopted makeBlockPtr. * platform/cocoa/FileMonitorCocoa.mm: (WebCore::FileMonitor::FileMonitor): * platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.mm: (WebCore::VideoFullscreenLayerManagerObjC::setVideoFullscreenLayer): * platform/graphics/gpu/legacy/cocoa/GPULegacyCommandBufferMetal.mm: (WebCore::GPULegacyCommandBuffer::GPULegacyCommandBuffer): * platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSession addDelegateOperation:]): (-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]): * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]): Source/WebCore/PAL: Adopted makeBlockPtr. * pal/Logging.cpp: (PAL::registerNotifyCallback): Source/WebKit: Adopted makeBlockPtr. * NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm: (-[WKDownloadProgress initWithDownloadTask:download:URL:sandboxExtension:]): * NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm: (WebKit::NetworkCache::IOChannel::read): (WebKit::NetworkCache::IOChannel::write): * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::clearDiskCache): (WebKit::saveCookies): * NetworkProcess/watchos/NetworkProximityAssertion.mm: (WebKit::BluetoothProximityAssertion::suspend): * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setInputDelegate:]): * UIProcess/API/mac/WKView.mm: (-[WKView maybeInstallIconLoadingClient]): * UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard): (WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup): * UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): * UIProcess/Cocoa/AutomationSessionClient.mm: (WebKit::AutomationSessionClient::requestNewPageWithOptions): (WebKit::AutomationSessionClient::requestSwitchToPage): (WebKit::AutomationSessionClient::requestHideWindowOfPage): (WebKit::AutomationSessionClient::requestRestoreWindowOfPage): (WebKit::AutomationSessionClient::requestMaximizeWindowOfPage): * UIProcess/Cocoa/DownloadClient.mm: (WebKit::DownloadClient::didReceiveAuthenticationChallenge): (WebKit::DownloadClient::decideDestinationWithSuggestedFilename): * UIProcess/Cocoa/IconLoadingDelegate.mm: (WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon): * UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad): (WebKit::NavigationState::NavigationClient::webGLLoadPolicy const): (WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse): (WebKit::NavigationState::NavigationClient::didReceiveAuthenticationChallenge): * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu): (WebKit::UIDelegate::UIClient::createNewPage): (WebKit::UIDelegate::UIClient::runJavaScriptAlert): (WebKit::UIDelegate::UIClient::runJavaScriptConfirm): (WebKit::UIDelegate::UIClient::runJavaScriptPrompt): (WebKit::UIDelegate::UIClient::requestStorageAccessConfirm): (WebKit::UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest): (WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel): (WebKit::UIDelegate::UIClient::exceededDatabaseQuota): (WebKit::UIDelegate::UIClient::windowFrame): (WebKit::UIDelegate::UIClient::toolbarsAreVisible): (WebKit::UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest): (WebKit::UIDelegate::UIClient::runOpenPanel): (WebKit::requestUserMediaAuthorizationForDevices): (WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): (WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin): (WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota): (WebKit::UIDelegate::UIClient::requestPointerLock): * UIProcess/Cocoa/WKSafeBrowsingWarning.mm: (-[WKSafeBrowsingWarning clickedOnLink:]): * UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::beginSafeBrowsingCheck): * UIProcess/WebAuthentication/Cocoa/HidConnection.mm: (WebKit::HidConnection::send): * UIProcess/WebAuthentication/Cocoa/LocalConnection.mm: (WebKit::LocalConnection::getUserConsent const): (WebKit::LocalConnection::getAttestation const): * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: (WebKit::MockHidConnection::send): * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::requestPasswordForQuickLookDocument): * UIProcess/ios/WKGeolocationProviderIOS.mm: (-[WKGeolocationProviderIOS geolocationAuthorizationGranted]): *
[webkit-changes] [239077] trunk/Tools
Title: [239077] trunk/Tools
Revision 239077
Author cdu...@apple.com
Date 2018-12-11 11:10:48 -0800 (Tue, 11 Dec 2018)
Log Message
REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
https://bugs.webkit.org/show_bug.cgi?id=192361
Reviewed by Alex Christensen.
Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
fixes the failures for me locally.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Diff
Modified: trunk/Tools/ChangeLog (239076 => 239077)
--- trunk/Tools/ChangeLog 2018-12-11 18:45:27 UTC (rev 239076)
+++ trunk/Tools/ChangeLog 2018-12-11 19:10:48 UTC (rev 239077)
@@ -1,3 +1,16 @@
+2018-12-11 Chris Dumez
+
+REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
+https://bugs.webkit.org/show_bug.cgi?id=192361
+
+
+Reviewed by Alex Christensen.
+
+Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
+fixes the failures for me locally.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+
2018-12-11 Philippe Normand
Unreviewed, WPE build fix after r239028
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (239076 => 239077)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-12-11 18:45:27 UTC (rev 239076)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-12-11 19:10:48 UTC (rev 239077)
@@ -394,7 +394,7 @@
7C83DF321D0A590C00FEBCF3 /* StringBuilder.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 81B50192140F232300D9EB58 /* StringBuilder.cpp */; };
7C83DF361D0A590C00FEBCF3 /* StringHasher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93ABA80816DDAB91002DB2FA /* StringHasher.cpp */; };
7C83DF371D0A590C00FEBCF3 /* StringImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26F1B44315CA434F00D1E4BF /* StringImpl.cpp */; };
- 7C83DF381D0A590C00FEBCF3 /* StringOperators.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C01363C713C3997300EF3964 /* StringOperators.cpp */; };
+ 7C83DF381D0A590C00FEBCF3 /* StringOperators.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C01363C713C3997300EF3964 /* StringOperators.cpp */; settings = {COMPILER_FLAGS = "-O1"; }; };
7C83DF3A1D0A590C00FEBCF3 /* StringView.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C74D42D188228F300E5ED57 /* StringView.cpp */; };
7C83DF3D1D0A590C00FEBCF3 /* SetForScope.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0BCD85691485C98B00EA2003 /* SetForScope.cpp */; };
7C83DF401D0A590C00FEBCF3 /* TestsController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC131AA8117131FC00B69727 /* TestsController.cpp */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239076] trunk/Source/WebKit
Title: [239076] trunk/Source/WebKit
Revision 239076
Author achristen...@apple.com
Date 2018-12-11 10:45:27 -0800 (Tue, 11 Dec 2018)
Log Message
Fix an internal build failure after r239014
https://bugs.webkit.org/show_bug.cgi?id=192205
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(fontOfSize):
There's a system that doesn't have safe browsing or UIFontTextStyleLargeTitle.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (239075 => 239076)
--- trunk/Source/WebKit/ChangeLog 2018-12-11 18:12:21 UTC (rev 239075)
+++ trunk/Source/WebKit/ChangeLog 2018-12-11 18:45:27 UTC (rev 239076)
@@ -1,3 +1,12 @@
+2018-12-11 Alex Christensen
+
+Fix an internal build failure after r239014
+https://bugs.webkit.org/show_bug.cgi?id=192205
+
+* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+(fontOfSize):
+There's a system that doesn't have safe browsing or UIFontTextStyleLargeTitle.
+
2018-12-11 Brian Burg
SimulatedInputDispatcher::transitionInputSourceToState() can reuse a moved-from completion handler
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm (239075 => 239076)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-12-11 18:12:21 UTC (rev 239075)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-12-11 18:45:27 UTC (rev 239076)
@@ -82,7 +82,7 @@
case WarningTextSize::Body:
return [NSFont systemFontOfSize:14];
}
-#else
+#elif HAVE(SAFE_BROWSING)
switch (size) {
case WarningTextSize::Title:
return [UIFont preferredFontForTextStyle:UIFontTextStyleLargeTitle];
@@ -89,6 +89,8 @@
case WarningTextSize::Body:
return [UIFont preferredFontForTextStyle:UIFontTextStyleBody];
}
+#else
+return nil;
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239075] branches/safari-606-branch
Title: [239075] branches/safari-606-branch Revision 239075 Author mark@apple.com Date 2018-12-11 10:12:21 -0800 (Tue, 11 Dec 2018) Log Message Cherry-pick r239062. rdar://problem/46603464 2018-12-10 Mark Lam PropertyAttribute needs a CustomValue bit. https://bugs.webkit.org/show_bug.cgi?id=191993 Reviewed by Saam Barati. JSTests: * stress/regress-191993.js: Added. Source/_javascript_Core: This is because GetByIdStatus needs to distinguish CustomValue properties from other types, and its only means of doing so is via the property's attributes. Previously, there's nothing in the property's attributes that can indicate that the property is a CustomValue. We fix this by doing the following: 1. Added a PropertyAttribute::CustomValue bit. 2. Added a PropertyAttribute::CustomAccessorOrValue convenience bit mask that is CustomAccessor | CustomValue. 3. Since CustomGetterSetter properties are only set via JSObject::putDirectCustomAccessor(), we added a check in JSObject::putDirectCustomAccessor() to see if the attributes bits include PropertyAttribute::CustomAccessor. If not, then the property must be a CustomValue, and we'll add the PropertyAttribute::CustomValue bit to the attributes bits. This ensures that the property attributes is sufficient to tell us if the property contains a CustomGetterSetter. 4. Updated all checks for PropertyAttribute::CustomAccessor to check for PropertyAttribute::CustomAccessorOrValue instead if their intent is to check for the presence of a CustomGetterSetter as opposed to checking specifically for one that is used as a CustomAccessor. This includes all the Structure transition code that needs to capture the attributes change when a CustomValue has been added. 5. Filtered out the PropertyAttribute::CustomValue bit in PropertyDescriptor. The fact that we're using a CustomGetterSetter as a CustomValue should remain invisible to the descriptor. This is because the descriptor should describe a CustomValue no differently from a plain value. 6. Added some asserts to ensure that property attributes are as expected, and to document some invariants. * bytecode/GetByIdStatus.cpp: (JSC::GetByIdStatus::computeFromLLInt): (JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback): (JSC::GetByIdStatus::computeFor): * bytecode/InByIdStatus.cpp: (JSC::InByIdStatus::computeForStubInfoWithoutExitSiteFeedback): * bytecode/PropertyCondition.cpp: (JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const): * bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::computeFor): * runtime/JSFunction.cpp: (JSC::getCalculatedDisplayName): * runtime/JSObject.cpp: (JSC::JSObject::putDirectCustomAccessor): (JSC::JSObject::putDirectNonIndexAccessor): (JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength): * runtime/JSObject.h: (JSC::JSObject::putDirectIndex): (JSC::JSObject::fillCustomGetterPropertySlot): (JSC::JSObject::putDirect): * runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal): * runtime/PropertyDescriptor.cpp: (JSC::PropertyDescriptor::setDescriptor): (JSC::PropertyDescriptor::setCustomDescriptor): (JSC::PropertyDescriptor::setAccessorDescriptor): * runtime/PropertySlot.h: (JSC::PropertySlot::setCustomGetterSetter): Source/WebCore: This patch revealed a bug in the CodeGenerator where a constructor property is set with a ReadOnly attribute. This conflicts with the WebIDL link (see clause 12 in https://heycam.github.io/webidl/#interface-prototype-object) which states that it should be [Writable]. The ReadOnly attribute is now removed. On the WebCore side, this change is covered by existing tests. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp: (WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Modified Paths branches/safari-606-branch/JSTests/ChangeLog branches/safari-606-branch/Source/_javascript_Core/ChangeLog branches/safari-606-branch/Source/_javascript_Core/bytecode/GetByIdStatus.cpp branches/safari-606-branch/Source/_javascript_Core/bytecode/InByIdStatus.cpp branches/safari-606-branch/Source/_javascript_Core/bytecode/PropertyCondition.cpp branches/safari-606-branch/Source/_javascript_Core/bytecode/PutByIdStatus.cpp branches/safari-606-branch/Source/_javascript_Core/runtime/JSFunction.cpp branches/safari-606-branch/Source/_javascript_Core/runtime/JSObject.cpp branches/safari-606-branch/Source/_javascript_Core/runtime/JSObject.h branches/safari-606-branch/Source/_javascript_Core/runtime/JSObjectInlines.h branches/safari-606-branch/Source/_javascript_Core/runtime/PropertyDescriptor.cpp
[webkit-changes] [239074] trunk/Source/WebKit
Title: [239074] trunk/Source/WebKit
Revision 239074
Author bb...@apple.com
Date 2018-12-11 09:39:16 -0800 (Tue, 11 Dec 2018)
Log Message
SimulatedInputDispatcher::transitionInputSourceToState() can reuse a moved-from completion handler
https://bugs.webkit.org/show_bug.cgi?id=191155
Reviewed by Joseph Pecoraro.
* UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
Add an ASSERT to guard against unexpected inputs where >1 VirtualKey changes per state.
webkitdriver needs to be updated to not produce such states in this scenario, but this will
avoid a runtime crash caused by trying to call a moved-out completion handler a second time.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (239073 => 239074)
--- trunk/Source/WebKit/ChangeLog 2018-12-11 15:14:51 UTC (rev 239073)
+++ trunk/Source/WebKit/ChangeLog 2018-12-11 17:39:16 UTC (rev 239074)
@@ -1,3 +1,17 @@
+2018-12-11 Brian Burg
+
+SimulatedInputDispatcher::transitionInputSourceToState() can reuse a moved-from completion handler
+https://bugs.webkit.org/show_bug.cgi?id=191155
+
+
+Reviewed by Joseph Pecoraro.
+
+* UIProcess/Automation/SimulatedInputDispatcher.cpp:
+(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
+Add an ASSERT to guard against unexpected inputs where >1 VirtualKey changes per state.
+webkitdriver needs to be updated to not produce such states in this scenario, but this will
+avoid a runtime crash caused by trying to call a moved-out completion handler a second time.
+
2018-12-11 Commit Queue
Unreviewed, rolling out r239071.
Modified: trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp (239073 => 239074)
--- trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-12-11 15:14:51 UTC (rev 239073)
+++ trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-12-11 17:39:16 UTC (rev 239074)
@@ -297,8 +297,13 @@
LOG(Automation, "SimulatedInputDispatcher[%p]: simulating KeyRelease[key=%c] for transition to %d.%d", this, a.pressedCharKey.value(), m_keyframeIndex, m_inputSourceStateIndex);
m_client.simulateKeyboardInteraction(m_page, KeyboardInteraction::KeyRelease, a.pressedCharKey.value(), WTFMove(eventDispatchFinished));
} else if (a.pressedVirtualKeys != b.pressedVirtualKeys) {
+bool simulatedAnInteraction = false;
for (VirtualKey key : b.pressedVirtualKeys) {
if (!a.pressedVirtualKeys.contains(key)) {
+ASSERT_WITH_MESSAGE(!simulatedAnInteraction, "Only one VirtualKey may differ at a time between two input source states.");
+if (simulatedAnInteraction)
+continue;
+simulatedAnInteraction = true;
#if !LOG_DISABLED
String virtualKeyName = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(key);
LOG(Automation, "SimulatedInputDispatcher[%p]: simulating KeyPress[key=%s] for transition to %d.%d", this, virtualKeyName.utf8().data(), m_keyframeIndex, m_inputSourceStateIndex);
@@ -309,6 +314,10 @@
for (VirtualKey key : a.pressedVirtualKeys) {
if (!b.pressedVirtualKeys.contains(key)) {
+ASSERT_WITH_MESSAGE(!simulatedAnInteraction, "Only one VirtualKey may differ at a time between two input source states.");
+if (simulatedAnInteraction)
+continue;
+simulatedAnInteraction = true;
#if !LOG_DISABLED
String virtualKeyName = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(key);
LOG(Automation, "SimulatedInputDispatcher[%p]: simulating KeyRelease[key=%s] for transition to %d.%d", this, virtualKeyName.utf8().data(), m_keyframeIndex, m_inputSourceStateIndex);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [239073] trunk/Tools
Title: [239073] trunk/Tools
Revision 239073
Author ph...@webkit.org
Date 2018-12-11 07:14:51 -0800 (Tue, 11 Dec 2018)
Log Message
Unreviewed, WPE build fix after r239028
The FLATPAK_USER_DIR env var is not set early enough, leading to:
Traceback (most recent call last):
File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in
sys.exit(WebkitFlatpak.load_from_args().run())
File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
if not self.clean_args():
File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
_log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
raise KeyError(key)
KeyError: 'FLATPAK_USER_DIR'
* flatpak/flatpakutils.py:
(WebkitFlatpak.clean_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
Diff
Modified: trunk/Tools/ChangeLog (239072 => 239073)
--- trunk/Tools/ChangeLog 2018-12-11 14:33:36 UTC (rev 239072)
+++ trunk/Tools/ChangeLog 2018-12-11 15:14:51 UTC (rev 239073)
@@ -1,3 +1,23 @@
+2018-12-11 Philippe Normand
+
+Unreviewed, WPE build fix after r239028
+
+The FLATPAK_USER_DIR env var is not set early enough, leading to:
+
+Traceback (most recent call last):
+File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in
+ sys.exit(WebkitFlatpak.load_from_args().run())
+File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
+ if not self.clean_args():
+File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
+ _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
+File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
+ raise KeyError(key)
+KeyError: 'FLATPAK_USER_DIR'
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.clean_args):
+
2018-12-10 Don Olmstead
Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
Modified: trunk/Tools/flatpak/flatpakutils.py (239072 => 239073)
--- trunk/Tools/flatpak/flatpakutils.py 2018-12-11 14:33:36 UTC (rev 239072)
+++ trunk/Tools/flatpak/flatpakutils.py 2018-12-11 15:14:51 UTC (rev 239073)
@@ -570,6 +570,12 @@
self.icc_version = None
def clean_args(self):
+os.environ["FLATPAK_USER_DIR"] = os.environ.get("WEBKIT_FLATPAK_USER_DIR", os.path.realpath(os.path.join(scriptdir, "../../WebKitBuild", "UserFlatpak")))
+try:
+os.makedirs(os.environ["FLATPAK_USER_DIR"])
+except OSError as e:
+pass
+
configure_logging(logging.DEBUG if self.verbose else logging.INFO)
_log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
@@ -593,12 +599,6 @@
self.manifest_path = os.path.abspath(os.path.join(scriptdir, '../flatpak/org.webkit.WebKit.yaml'))
self.build_name = self.name + "-generated"
-os.environ["FLATPAK_USER_DIR"] = os.environ.get("WEBKIT_FLATPAK_USER_DIR", os.path.realpath(os.path.join(scriptdir, "../../WebKitBuild", "UserFlatpak")))
-try:
-os.makedirs(os.environ["FLATPAK_USER_DIR"])
-except OSError as e:
-pass
-
build_root = os.path.join(self.source_root, 'WebKitBuild')
self.flatpak_build_path = os.path.join(build_root, self.platform, "FlatpakTree" + self.build_type)
self.cache_path = os.path.join(build_root, "FlatpakCache")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
