date:20190114

Title: [239970] trunk/Source/WTF








Revision 239970
Author mcatanz...@igalia.com
Date 2019-01-14 19:26:04 -0800 (Mon, 14 Jan 2019)


Log Message
Use unorm2_normalize instead of precomposedStringWithCanonicalMapping in userVisibleString
https://bugs.webkit.org/show_bug.cgi?id=192945

Reviewed by Alex Christensen.

Replace use of the nice NSString function precomposedStringWithCanonicalMapping with the ICU
API unorm2_normalize. This is to prep the code for translation to cross-platform C++. Of
course this is much worse than the preexisting code, but this is just a transitional
measure and not the final state of the code. It wouldn't make sense to do this if the code
were to remain Objective C++.

* wtf/cocoa/NSURLExtras.mm:
(WTF::toNormalizationFormC):
(WTF::userVisibleString):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (239969 => 239970)

--- trunk/Source/WTF/ChangeLog	2019-01-15 03:01:31 UTC (rev 239969)
+++ trunk/Source/WTF/ChangeLog	2019-01-15 03:26:04 UTC (rev 239970)
@@ -1,3 +1,20 @@
+2019-01-14  Michael Catanzaro  
+
+Use unorm2_normalize instead of precomposedStringWithCanonicalMapping in userVisibleString
+https://bugs.webkit.org/show_bug.cgi?id=192945
+
+Reviewed by Alex Christensen.
+
+Replace use of the nice NSString function precomposedStringWithCanonicalMapping with the ICU
+API unorm2_normalize. This is to prep the code for translation to cross-platform C++. Of
+course this is much worse than the preexisting code, but this is just a transitional
+measure and not the final state of the code. It wouldn't make sense to do this if the code
+were to remain Objective C++.
+
+* wtf/cocoa/NSURLExtras.mm:
+(WTF::toNormalizationFormC):
+(WTF::userVisibleString):
+
 2019-01-14  Alex Christensen  
 
 Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters


Modified: trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm (239969 => 239970)

--- trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm	2019-01-15 03:01:31 UTC (rev 239969)
+++ trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm	2019-01-15 03:26:04 UTC (rev 239970)
@@ -32,6 +32,7 @@
 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -1105,6 +1106,31 @@
 return CFStringCreateWithCharacters(nullptr, outBuffer.data(), outBuffer.size());
 }
 
+static String toNormalizationFormC(const String& string)
+{
+auto sourceBuffer = string.charactersWithNullTermination();
+ASSERT(sourceBuffer.last() == '\0');
+sourceBuffer.removeLast();
+
+String result;
+Vector normalizedCharacters(sourceBuffer.size());
+UErrorCode uerror = U_ZERO_ERROR;
+int32_t normalizedLength = 0;
+const UNormalizer2 *normalizer = unorm2_getNFCInstance();
+if (!U_FAILURE(uerror)) {
+normalizedLength = unorm2_normalize(normalizer, sourceBuffer.data(), sourceBuffer.size(), normalizedCharacters.data(), normalizedCharacters.size(), );
+if (uerror == U_BUFFER_OVERFLOW_ERROR) {
+uerror = U_ZERO_ERROR;
+normalizedCharacters.resize(normalizedLength);
+normalizedLength = unorm2_normalize(normalizer, sourceBuffer.data(), sourceBuffer.size(), normalizedCharacters.data(), normalizedLength, );
+}
+if (!U_FAILURE(uerror))
+result = String(normalizedCharacters.data(), normalizedLength);
+}
+
+return result;
+}
+
 NSString *userVisibleString(NSURL *URL)
 {
 NSData *data = ""
@@ -1175,7 +1201,9 @@
 result = mappedResult;
 }
 
-result = [result precomposedStringWithCanonicalMapping];
+auto wtfString = String(result.get());
+auto normalized = toNormalizationFormC(wtfString);
+result = static_cast(normalized);
 return CFBridgingRelease(createStringWithEscapedUnsafeCharacters((__bridge CFStringRef)result.get()));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239969] trunk/Source/JavaScriptCore

2019-01-14 Thread msaboff

Title: [239969] trunk/Source/_javascript_Core








Revision 239969
Author msab...@apple.com
Date 2019-01-14 19:01:31 -0800 (Mon, 14 Jan 2019)


Log Message
Add option to JSC to dump memory footprint on script completion
https://bugs.webkit.org/show_bug.cgi?id=193422

Reviewed by Mark Lam.

Added the --footprint option to dump peak and current memory usage.  This uses the same
OS calls added in r2362362.

* jsc.cpp:
(printUsageStatement):
(CommandLine::parseArguments):
(jscmain):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239968 => 239969)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-15 02:37:33 UTC (rev 239968)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-15 03:01:31 UTC (rev 239969)
@@ -1,3 +1,18 @@
+2019-01-14  Michael Saboff  
+
+Add option to JSC to dump memory footprint on script completion
+https://bugs.webkit.org/show_bug.cgi?id=193422
+
+Reviewed by Mark Lam.
+
+Added the --footprint option to dump peak and current memory usage.  This uses the same
+OS calls added in r2362362.
+
+* jsc.cpp:
+(printUsageStatement):
+(CommandLine::parseArguments):
+(jscmain):
+
 2019-01-14  Yusuke Suzuki  
 
 [JSC] AI should check the given constant's array type when folding GetByVal into constant


Modified: trunk/Source/_javascript_Core/jsc.cpp (239968 => 239969)

--- trunk/Source/_javascript_Core/jsc.cpp	2019-01-15 02:37:33 UTC (rev 239968)
+++ trunk/Source/_javascript_Core/jsc.cpp	2019-01-15 03:01:31 UTC (rev 239969)
@@ -420,6 +420,7 @@
 String m_uncaughtExceptionName;
 bool m_treatWatchdogExceptionAsSuccess { false };
 bool m_alwaysDumpUncaughtException { false };
+bool m_dumpMemoryFootprint { false };
 bool m_dumpSamplingProfilerData { false };
 bool m_enableRemoteDebugging { false };
 
@@ -2572,6 +2573,7 @@
 fprintf(stderr, "  --exception= Check the last script exits with an uncaught exception with the specified name\n");
 fprintf(stderr, "  --watchdog-exception-okUncaught watchdog exceptions exit with success\n");
 fprintf(stderr, "  --dumpExceptionDump uncaught exception text\n");
+fprintf(stderr, "  --footprintDump memory footprint after done executing\n");
 fprintf(stderr, "  --options  Dumps all JSC VM options and exits\n");
 fprintf(stderr, "  --dumpOptions  Dumps all non-default JSC VM options before continuing\n");
 fprintf(stderr, "  --=  Sets the specified JSC VM option\n");
@@ -2720,6 +2722,11 @@
 continue;
 }
 
+if (!strcmp(arg, "--footprint")) {
+m_dumpMemoryFootprint = true;
+continue;
+}
+
 static const unsigned exceptionStrLength = strlen("--exception=");
 if (!strncmp(arg, "--exception=", exceptionStrLength)) {
 m_uncaughtExceptionName = String(arg + exceptionStrLength);
@@ -2928,6 +2935,12 @@
 
 printSuperSamplerState();
 
+if (options.m_dumpMemoryFootprint) {
+MemoryFootprint footprint = MemoryFootprint::now();
+
+printf("Memory Footprint:\nCurrent Footprint: %llu\nPeak Footprint: %llu\n", footprint.current, footprint.peak);
+}
+
 return result;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239968] trunk/JSTests

2019-01-14 Thread keith_miller

Title: [239968] trunk/JSTests








Revision 239968
Author keith_mil...@apple.com
Date 2019-01-14 18:37:33 -0800 (Mon, 14 Jan 2019)


Log Message
Skip type-check-hoisting-phase-hoist... with no jit
https://bugs.webkit.org/show_bug.cgi?id=193421

Reviewed by Mark Lam.

It's timing out the 32-bit bots and takes 330 seconds
on my machine when run by itself.

* stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js




Diff

Modified: trunk/JSTests/ChangeLog (239967 => 239968)

--- trunk/JSTests/ChangeLog	2019-01-15 02:14:16 UTC (rev 239967)
+++ trunk/JSTests/ChangeLog	2019-01-15 02:37:33 UTC (rev 239968)
@@ -1,3 +1,15 @@
+2019-01-14  Keith Miller  
+
+Skip type-check-hoisting-phase-hoist... with no jit
+https://bugs.webkit.org/show_bug.cgi?id=193421
+
+Reviewed by Mark Lam.
+
+It's timing out the 32-bit bots and takes 330 seconds
+on my machine when run by itself.
+
+* stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js:
+
 2019-01-14  Yusuke Suzuki  
 
 [JSC] AI should check the given constant's array type when folding GetByVal into constant


Modified: trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js (239967 => 239968)

--- trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js	2019-01-15 02:14:16 UTC (rev 239967)
+++ trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js	2019-01-15 02:37:33 UTC (rev 239968)
@@ -1,3 +1,5 @@
+//@ skip if not $jitTests
+
 function __isPropertyOfType(obj, name, type) {
 desc = Object.getOwnPropertyDescriptor(obj, name)
 return typeof type === 'undefined' || typeof desc.value === type;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239967] trunk

2019-01-14 Thread achristensen

Title: [239967] trunk








Revision 239967
Author achristen...@apple.com
Date 2019-01-14 18:14:16 -0800 (Mon, 14 Jan 2019)


Log Message
Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
https://bugs.webkit.org/show_bug.cgi?id=193411


Reviewed by Alexey Proskuryakov.

Source/WTF:

* wtf/cocoa/NSURLExtras.mm:
(WTF::allCharactersAllowedByTLDRules):

LayoutTests:

* fast/url/user-visible/cyrillic-NFD-expected.txt:
* fast/url/user-visible/cyrillic-NFD.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt
trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD.html
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (239966 => 239967)

--- trunk/LayoutTests/ChangeLog	2019-01-15 01:51:13 UTC (rev 239966)
+++ trunk/LayoutTests/ChangeLog	2019-01-15 02:14:16 UTC (rev 239967)
@@ -1,3 +1,14 @@
+2019-01-14  Alex Christensen  
+
+Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
+https://bugs.webkit.org/show_bug.cgi?id=193411
+
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/url/user-visible/cyrillic-NFD-expected.txt:
+* fast/url/user-visible/cyrillic-NFD.html:
+
 2019-01-14  John Wilander  
 
 Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness


Modified: trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt (239966 => 239967)

--- trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt	2019-01-15 01:51:13 UTC (rev 239966)
+++ trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt	2019-01-15 02:14:16 UTC (rev 239967)
@@ -5,6 +5,11 @@
 
 PASS test('http://спецодежда.онлайн/') is 'http://спецодежда.онлайн/'
 PASS test('http://спецодежда.онлайн/') is 'http://спецодежда.онлайн/'
+PASS test('http://ж1-2.бг/') is 'http://ж1-2.бг/'
+PASS test('http://жabc.бг/') is 'http://xn--abc-udd.xn--90ae/'
+PASS test('http://abc.бг/') is 'http://abc.xn--90ae/'
+PASS test('http://ы.бг/') is 'http://xn--01a.xn--90ae/'
+PASS test('http://э.бг/') is 'http://xn--21a.xn--90ae/'
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD.html (239966 => 239967)

--- trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD.html	2019-01-15 01:51:13 UTC (rev 239966)
+++ trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD.html	2019-01-15 02:14:16 UTC (rev 239967)
@@ -17,6 +17,11 @@
 
 shouldBe("test('http://спецодежда.онла\u0439н/')", "'http://спецодежда.онлайн/'");
 shouldBe("test('http://спецодежда.онла\u0438\u0306н/')", "'http://спецодежда.онлайн/'");
+shouldBe("test('http://ж1-2.бг/')", "'http://ж1-2.бг/'");
+shouldBe("test('http://жabc.бг/')", "'http://xn--abc-udd.xn--90ae/'");
+shouldBe("test('http://abc.бг/')", "'http://abc.xn--90ae/'");
+shouldBe("test('http://ы.бг/')", "'http://xn--01a.xn--90ae/'");
+shouldBe("test('http://э.бг/')", "'http://xn--21a.xn--90ae/'");

[webkit-changes] [239966] trunk/LayoutTests

2019-01-14 Thread wilander

Title: [239966] trunk/LayoutTests








Revision 239966
Author wilan...@apple.com
Date 2019-01-14 17:51:13 -0800 (Mon, 14 Jan 2019)


Log Message
Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness
https://bugs.webkit.org/show_bug.cgi?id=191211


Unreviewed test gardening.

This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and
redirect which may avoid the code that changed in
https://trac.webkit.org/changeset/237735/webkit and made the test more flaky.


* http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt:
* http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239965 => 239966)

--- trunk/LayoutTests/ChangeLog	2019-01-15 01:31:48 UTC (rev 239965)
+++ trunk/LayoutTests/ChangeLog	2019-01-15 01:51:13 UTC (rev 239966)
@@ -1,3 +1,18 @@
+2019-01-14  John Wilander  
+
+Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness
+https://bugs.webkit.org/show_bug.cgi?id=191211
+
+
+Unreviewed test gardening.
+
+This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and
+redirect which may avoid the code that changed in
+https://trac.webkit.org/changeset/237735/webkit and made the test more flaky.
+
+* http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt:
+* http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html:
+
 2019-01-14  Simon Fraser  
 
 Animation and other code is too aggressive about invalidating layer composition


Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt (239965 => 239966)

--- trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt	2019-01-15 01:31:48 UTC (rev 239965)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt	2019-01-15 01:51:13 UTC (rev 239966)
@@ -11,6 +11,12 @@
 
 Frame: ''
 
+Set cookie.
+
+
+
+Frame: ''
+
 Should receive first-party cookie.
 Received cookie named 'firstPartyCookie'.
 Did not receive cookie named 'partitionedCookie'.
@@ -17,7 +23,7 @@
 Client-side document.cookie: firstPartyCookie=value
 
 
-Frame: ''
+Frame: ''
 
 Redirect case 1, should receive first-party cookie for 127.0.0.1.
 Received cookie named 'firstPartyCookie'.
@@ -25,13 +31,13 @@
 Client-side document.cookie: firstPartyCookie=127.0.0.1
 
 
-Frame: ''
+Frame: ''
 
 Try to set third-party cookie in blocked mode.
 
 
 
-Frame: ''
+Frame: ''
 
 Should receive no cookie.
 Did not receive cookie named 'firstPartyCookie'.
@@ -39,7 +45,7 @@
 Client-side document.cookie:
 
 
-Frame: ''
+Frame: ''
 
 Redirect case 2, should receive first-party cookie for 127.0.0.1.
 Received cookie named 'firstPartyCookie'.


Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html (239965 => 239966)

--- trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html	2019-01-15 01:31:48 UTC (rev 239965)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html	2019-01-15 01:51:13 UTC (rev 239966)
@@ -18,7 +18,6 @@
 const subPathToSetFirstPartyCookie = "/set-cookie.php?name=" + firstPartyCookieName + "=value";
 const partitionedCookieName = "partitionedCookie";
 const subPathToSetPartitionedCookie = "/set-cookie.php?name=" + partitionedCookieName + "=value";
-const returnUrl = "http://" + partitionHost + "/resourceLoadStatistics/remove-blocking-in-redirect.html";
 const subPathToGetCookies = "/get-cookies.php?name1=" + firstPartyCookieName + "=" + partitionedCookieName;
 const redirectChainUrl = thirdPartyOrigin + resourcePath + "/redirect.php?redirectTo=http://" + partitionHost + resourcePath + subPathToGetCookies;
 
@@ -35,12 +34,17 @@
 switch (document.location.hash) {
 case "#step1":
 // Set first-party cookies for 127.0.0.1 and localhost.
+document.location.hash = "step2";
 document.cookie = firstPartyCookieName + "=127.0.0.1;path='/'";
-document.location.href = "" + subPathToSetFirstPartyCookie + "#" + returnUrl + "#step2";
+if (window.testRunner)
+testRunner.setAlwaysAcceptCookies(true);
+openIframe(thirdPartyBaseUrl + subPathToSetFirstPartyCookie + "=Set cookie.", runTest);
 break;
 case "#step2":
 // Check that the cookie gets sent for localhost under

[webkit-changes] [239965] trunk

2019-01-14 Thread simon . fraser

Title: [239965] trunk








Revision 239965
Author simon.fra...@apple.com
Date 2019-01-14 17:31:48 -0800 (Mon, 14 Jan 2019)


Log Message
Animation and other code is too aggressive about invalidating layer composition
https://bugs.webkit.org/show_bug.cgi?id=193343

Reviewed by Antoine Quint.

Source/WebCore:

We used to have the concept of a "SyntheticStyleChange", which was used to trigger
style updates for animation, and also to get compositing updated.

That morphed into a call to Element::invalidateStyleAndLayerComposition(), which causes
a style update to result in a "RecompositeLayer" diff, which in turn triggers compositing work,
and dirties DOM touch event regions (which can be expensive to update).

However, not all the callers of Element::invalidateStyleAndLayerComposition() need to trigger
compositing, and doing so from animations caused excessive touch event regions on yahoo.com,
which has several visibility:hidden elements with background-position animation.

So fix callers of invalidateStyleAndLayerComposition() which don't care about compositing to instead
call just invalidateStyle().

Also fix KeyframeAnimation::animate to correctly return true when animation state changes—it failed to
do so, because fireAnimationEventsIfNeeded() can run the state machine and change state.

* animation/KeyframeEffect.cpp:
(WebCore::invalidateElement):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::setNeedsStyleRecalc):
* page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::updateAnimations):
(WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::CSSAnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::CSSAnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::CSSAnimationController::cancelAnimations):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
* svg/SVGAnimateElementBase.cpp:
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):

LayoutTests:

This test was clobbering the 'box' class on the animating element and therefore making it disappear.

* legacy-animation-engine/compositing/animation/animation-compositing.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/legacy-animation-engine/compositing/animation/animation-compositing.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/page/animation/AnimationBase.cpp
trunk/Source/WebCore/page/animation/CSSAnimationController.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp
trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (239964 => 239965)

--- trunk/LayoutTests/ChangeLog	2019-01-15 01:26:43 UTC (rev 239964)
+++ trunk/LayoutTests/ChangeLog	2019-01-15 01:31:48 UTC (rev 239965)
@@ -1,3 +1,14 @@
+2019-01-14  Simon Fraser  
+
+Animation and other code is too aggressive about invalidating layer composition
+https://bugs.webkit.org/show_bug.cgi?id=193343
+
+Reviewed by Antoine Quint.
+
+This test was clobbering the 'box' class on the animating element and therefore making it disappear.
+
+* legacy-animation-engine/compositing/animation/animation-compositing.html:
+
 2019-01-14  Charles Vazac  
 
 Import current Resource-Timing WPTs


Modified: trunk/LayoutTests/legacy-animation-engine/compositing/animation/animation-compositing.html (239964 => 239965)

--- trunk/LayoutTests/legacy-animation-engine/compositing/animation/animation-compositing.html	2019-01-15 01:26:43 UTC (rev 239964)
+++ trunk/LayoutTests/legacy-animation-engine/compositing/animation/animation-compositing.html	2019-01-15 01:31:48 UTC (rev 239965)
@@ -39,7 +39,7 @@
 testRunner.notifyDone();
 }
   }, false);
-  document.getElementById('box').className = 'spinning';
+  document.getElementById('box').classList.add('spinning');
 }
 
 window.addEventListener('load', doTest, false);


Modified: trunk/Source/WebCore/ChangeLog (239964 => 239965)

--- trunk/Source/WebCore/ChangeLog	2019-01-15 01:26:43 UTC (rev 239964)
+++ trunk/Source/WebCore/ChangeLog	2019-01-15 01:31:48 UTC (rev 239965)
@@ -1,3 +1,51 @@
+2019-01-14  Simon Fraser  
+
+Animation and other code is too aggressive about invalidating layer composition
+https://bugs.webkit.org/show_bug.cgi?id=193343
+
+Reviewed by Antoine Quint.
+
+

[webkit-changes] [239964] trunk

2019-01-14 Thread yusukesuzuki

Title: [239964] trunk








Revision 239964
Author yusukesuz...@slowstart.org
Date 2019-01-14 17:26:43 -0800 (Mon, 14 Jan 2019)


Log Message
[JSC] AI should check the given constant's array type when folding GetByVal into constant
https://bugs.webkit.org/show_bug.cgi?id=193413


Reviewed by Keith Miller.

JSTests:

This test is super flaky. It causes crash in r238109, but it does not crash with `--useConcurrentJIT=false`.
It does not cause any crashes on the latest revision too. Basically, it highly depends on the timing, and
without this patch, the root cause is not fixed yet. If GetLocal is turned into JSConstant in AI,
but GetByVal does not have appropriate ArrayModes, JSC crashes.

* stress/ai-should-perform-array-check-on-get-by-val-constant-folding.js: Added.
(compareArray):

Source/_javascript_Core:

If GetByVal's DFG::ArrayMode's type is Array::Double, we expect that the result of GetByVal is Double, since we already performed CheckStructure or CheckArray
to ensure this array type. But this assumption on the given value becomes wrong in AI, since CheckStructure may not perform filtering. And the proven AbstractValue
in GetByVal would not be expected one.

We have the graph before performing constant folding.

53: GetLocal(Check:Untyped:@77, JS|MustGen|UseAsOther, Array, arg2(C/FlushedCell), R:Stack(7), bc#37, ExitValid)  predicting Array
54:< 1:-> JSConstant(JS|PureNum|UseAsOther|UseAsInt|ReallyWantsInt, BoolInt32, Int32: 0, bc#37, ExitValid)
93: CheckStructure(Cell:@53, MustGen, [%C7:Array], R:JSCell_structureID, Exits, bc#37, ExitValid)
94:< 1:-> GetButterfly(Check:Cell:@53, Storage|PureInt, R:JSObject_butterfly, Exits, bc#37, ExitValid)
55: GetByVal(Check:KnownCell:@53, Check:Int32:@54, Check:Untyped:@94, Double|MustGen|VarArgs|PureInt, AnyIntAsDouble|NonIntAsdouble, Double+OriginalCopyOnWriteArray+SaneChain+AsIs+Read, R:Butterfly_publicLength,IndexedDoubleProperties, Exits, bc#37, ExitValid)  predicting StringIdent|NonIntAsdouble

And 53 is converted to JSConstant in the constant folding. It leads to constant folding attempt in GetByVal.

53:< 1:-> JSConstant(JS|UseAsOther, Array, Weak:Object: 0x117fb4370 with butterfly 0x8000e4050 (Structure %BV:Array), StructureID: 104, bc#37, ExitValid)
54:< 1:-> JSConstant(JS|PureNum|UseAsOther|UseAsInt|ReallyWantsInt, BoolInt32, Int32: 0, bc#37, ExitValid)
93: CheckStructure(Cell:@53, MustGen, [%C7:Array], R:JSCell_structureID, Exits, bc#37, ExitValid)
94:< 1:-> GetButterfly(Check:Cell:@53, Storage|PureInt, R:JSObject_butterfly, Exits, bc#37, ExitValid)
55: GetByVal(Check:KnownCell:@53, Check:Int32:@54, Check:Untyped:@94, Double|MustGen|VarArgs|PureInt, AnyIntAsDouble|NonIntAsdouble, Double+OriginalCopyOnWriteArray+SaneChain+AsIs+Read, R:Butterfly_publicLength,IndexedDoubleProperties, Exits, bc#37, ExitValid)  predicting StringIdent|NonIntAsdouble

GetByVal gets constant Array from @53, and attempt to perform constant folding by leverating CoW state: if the given array's butterfly is CoW and we performed CoW array check for this GetByVal, the array would not be changed as long as the check works.
However, CheckStructure for @53 does not filter anything at AI. So, if @53 is CopyOnWrite | Contiguous array (not CopyOnWrite | Double array!), GetByVal will get a JSValue. But it does not meet the requirement of GetByVal since it has Double Array mode, and says it returns Double.
Here, CheckStructure is valid because structure of the constant object would be changed. What we should do is additional CoW & ArrayShape check in GetByVal when folding since this node leverages CoW's interesting feature,
"If CoW array check (CheckStructure etc.) is emitted by GetByVal's DFG::ArrayMode, the content is not changed from the creation!".

This patch adds ArrayShape check in addition to CoW status check in GetByVal.

Unfortunately, this crash is very flaky. In the above case, if @53 stays GetLocal after the constant folding phase, this issue does not occur. We can see this crash in r238109, but it is really hard to reproduce it in the current ToT.
I verified this fix works in r238109 with the attached test.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::fixTypeForRepresentation):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.cpp


Added Paths

trunk/JSTests/stress/ai-should-perform-array-check-on-get-by-val-constant-folding.js




Diff

Modified: trunk/JSTests/ChangeLog (239963 => 239964)

--- trunk/JSTests/ChangeLog	2019-01-15 00:55:51 UTC (rev 239963)
+++ trunk/JSTests/ChangeLog	2019-01-15 01:26:43 UTC (rev 239964)
@@ -1,3 +1,19 @@
+2019-01-14  Yusuke Suzuki  
+
+[JSC] AI should check the given constant's array type when folding GetByVal into constant
+

[webkit-changes] [239963] trunk/Source/WebKit

2019-01-14 Thread pvollan

Title: [239963] trunk/Source/WebKit








Revision 239963
Author pvol...@apple.com
Date 2019-01-14 16:55:51 -0800 (Mon, 14 Jan 2019)


Log Message
[macOS] Remove reporting for mach lookups confirmed in-use
https://bugs.webkit.org/show_bug.cgi?id=193415


Reviewed by Brent Fulgham.

Also, start denying the services which have not been confirmed to be in use.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239962 => 239963)

--- trunk/Source/WebKit/ChangeLog	2019-01-15 00:49:06 UTC (rev 239962)
+++ trunk/Source/WebKit/ChangeLog	2019-01-15 00:55:51 UTC (rev 239963)
@@ -1,3 +1,15 @@
+2019-01-14  Per Arne Vollan  
+
+[macOS] Remove reporting for mach lookups confirmed in-use
+https://bugs.webkit.org/show_bug.cgi?id=193415
+
+
+Reviewed by Brent Fulgham.
+
+Also, start denying the services which have not been confirmed to be in use.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-01-14  Commit Queue  
 
 Unreviewed, rolling out r239901, r239909, r239910, r239912,


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239962 => 239963)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-15 00:49:06 UTC (rev 239962)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-15 00:55:51 UTC (rev 239963)
@@ -579,6 +579,7 @@
(global-name "com.apple.audio.AudioComponentRegistrar")
 #endif
(global-name "com.apple.assertiond.processassertionconnection")
+   (global-name "com.apple.audio.SystemSoundServer-OSX")
(global-name "com.apple.audio.audiohald")
(global-name "com.apple.awdd")
(global-name "com.apple.cfprefsd.agent")
@@ -608,36 +609,6 @@
 #endif
 )
 
-(allow mach-lookup (with report)
-(global-name "com.apple.FileCoordination")
-(global-name "com.apple.FontObjectsServer")
-(global-name "com.apple.GSSCred")
-(global-name "com.apple.SystemConfiguration.PPPController")
-(global-name "com.apple.audio.SystemSoundServer-OSX")
-(global-name "com.apple.audio.coreaudiod")
-(global-name "com.apple.cfnetwork.AuthBrokerAgent")
-; "com.apple.coremedia.endpointpicker.xpc" can be removed when  is resolved.
-(global-name "com.apple.coremedia.endpointpicker.xpc")
-(global-name "com.apple.coremedia.endpointplaybacksession.xpc")
-(global-name "com.apple.dock.server")
-(global-name "com.apple.dyld.closured")
-;; OpenGL memory debugging
-(global-name "com.apple.gpumemd.source")
-(global-name "com.apple.nesessionmanager.flow-divert-token")
-#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
-(xpc-service-name "com.apple.ist.ds.appleconnect2.HelperService")
-(xpc-service-name "com.apple.signpost.signpost-notificationd")
-#endif
-(global-name "com.apple.speech.synthesis.console")
-(global-name "com.apple.system.DirectoryService.libinfo_v1")
-(global-name "com.apple.system.opendirectoryd.api")
-(global-name "com.apple.trustd")
-(global-name "com.apple.window_proxies")
-(global-name "com.apple.xpc.activity.unmanaged")
-(global-name "com.apple.xpcd")
-(global-name "org.h5l.kcm")
-)
-
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 (deny mach-lookup (with no-log)
 (global-name "com.apple.ViewBridgeAuxiliary")
@@ -754,6 +725,7 @@
 (allow mach-lookup
 (global-name "com.apple.coremedia.endpoint.xpc")
 (global-name "com.apple.coremedia.endpointstream.xpc")
+(global-name "com.apple.coremedia.endpointplaybacksession.xpc")
 ; 
 (global-name "com.apple.coremedia.endpointremotecontrolsession.xpc")
 #if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239962] tags/Safari-607.1.20.2/Source

Title: [239962] tags/Safari-607.1.20.2/Source








Revision 239962
Author alanc...@apple.com
Date 2019-01-14 16:49:06 -0800 (Mon, 14 Jan 2019)


Log Message
Versioning.

Modified Paths

tags/Safari-607.1.20.2/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-607.1.20.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-607.1.20.2/Source/_javascript_Core/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/_javascript_Core/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/_javascript_Core/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/WebCore/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/WebCore/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/WebCore/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/WebCore/PAL/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/WebInspectorUI/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/WebKit/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/WebKit/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/WebKit/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-607.1.20.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (239961 => 239962)

--- tags/Safari-607.1.20.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-01-15 00:39:28 UTC (rev 239961)
+++ tags/Safari-607.1.20.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-01-15 00:49:06 UTC (rev 239962)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239960] trunk/Source/WebCore

2019-01-14 Thread sihui_liu

Title: [239960] trunk/Source/WebCore








Revision 239960
Author sihui_...@apple.com
Date 2019-01-14 16:19:17 -0800 (Mon, 14 Jan 2019)


Log Message
IndexedDB: When deleting databases, some open databases might be missed
https://bugs.webkit.org/show_bug.cgi?id=193090

Reviewed by Brady Eidson.

We should close all databases with an open backing store instead of looking at which ones have an open database
connection. This is because a database might be in the process of getting a backing store before its connection
has been created.

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239959 => 239960)

--- trunk/Source/WebCore/ChangeLog	2019-01-15 00:00:04 UTC (rev 239959)
+++ trunk/Source/WebCore/ChangeLog	2019-01-15 00:19:17 UTC (rev 239960)
@@ -1,3 +1,18 @@
+2019-01-14  Sihui Liu  
+
+IndexedDB: When deleting databases, some open databases might be missed
+https://bugs.webkit.org/show_bug.cgi?id=193090
+
+Reviewed by Brady Eidson.
+
+We should close all databases with an open backing store instead of looking at which ones have an open database
+connection. This is because a database might be in the process of getting a backing store before its connection
+has been created.
+
+* Modules/indexeddb/server/IDBServer.cpp:
+(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
+(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
+
 2019-01-14  Ryosuke Niwa  
 
 Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides


Modified: trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp (239959 => 239960)

--- trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp	2019-01-15 00:00:04 UTC (rev 239959)
+++ trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp	2019-01-15 00:19:17 UTC (rev 239960)
@@ -509,8 +509,8 @@
 }
 
 HashSet openDatabases;
-for (auto* connection : m_databaseConnections.values())
-openDatabases.add(connection->database());
+for (auto& database : m_uniqueIDBDatabaseMap.values())
+openDatabases.add(database.get());
 
 for (auto& database : openDatabases)
 database->immediateCloseForUserDelete();
@@ -525,14 +525,11 @@
 ASSERT_UNUSED(addResult, addResult.isNewEntry);
 
 HashSet openDatabases;
-for (auto* connection : m_databaseConnections.values()) {
-auto database = connection->database();
-ASSERT(database);
-
+for (auto& database : m_uniqueIDBDatabaseMap.values()) {
 const auto& identifier = database->identifier();
 for (auto& origin : origins) {
 if (identifier.isRelatedToOrigin(origin)) {
-openDatabases.add(database);
+openDatabases.add(database.get());
 break;
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239958] trunk/LayoutTests

2019-01-14 Thread jiewen_tan

Title: [239958] trunk/LayoutTests








Revision 239958
Author jiewen_...@apple.com
Date 2019-01-14 15:45:41 -0800 (Mon, 14 Jan 2019)


Log Message
Unreviewed, test fixes after r239852.

* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-u2f.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239957 => 239958)

--- trunk/LayoutTests/ChangeLog	2019-01-14 23:24:24 UTC (rev 239957)
+++ trunk/LayoutTests/ChangeLog	2019-01-14 23:45:41 UTC (rev 239958)
@@ -1,3 +1,12 @@
+2019-01-14  Jiewen Tan  
+
+Unreviewed, test fixes after r239852.
+
+* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+* http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
+* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
+* http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
+
 2019-01-14  Justin Fan  
 
 [WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html (239957 => 239958)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html	2019-01-14 23:24:24 UTC (rev 239957)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html	2019-01-14 23:45:41 UTC (rev 239958)
@@ -47,7 +47,7 @@
 },
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-timeout: 10
+timeout: 100
 }
 };
 
@@ -70,7 +70,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 authenticatorSelection: { authenticatorAttachment: "cross-platform" },
-timeout: 10
+timeout: 100
 }
 };
 
@@ -93,7 +93,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 authenticatorSelection: { requireResidentKey: false },
-timeout: 10
+timeout: 100
 }
 };
 
@@ -116,7 +116,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 authenticatorSelection: { userVerification: "preferred" },
-timeout: 10
+timeout: 100
 }
 };
 
@@ -139,7 +139,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 authenticatorSelection: { userVerification: "discouraged" },
-timeout: 10
+timeout: 100
 }
 };
 
@@ -162,7 +162,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" },
-timeout: 10
+timeout: 100
 }
 };
 


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html (239957 => 239958)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html	2019-01-14 23:24:24 UTC (rev 239957)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html	2019-01-14 23:45:41 UTC (rev 239958)
@@ -42,7 +42,7 @@
 },
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-timeout: 10
+timeout: 100
 }
 };
 
@@ -67,7 +67,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
 excludeCredentials: [{ type: "public-key", id: Base64URL.parse(testCredentialIdBase64) }],
-timeout: 10
+timeout: 100
 }
 };
 
@@ -92,7 +92,7 @@
 challenge: Base64URL.parse("MTIzNDU2"),
 pubKeyCredParams: [{ type:

[webkit-changes] [239957] releases/WebKitGTK/webkit-2.22/Source

Title: [239957] releases/WebKitGTK/webkit-2.22/Source








Revision 239957
Author mcatanz...@igalia.com
Date 2019-01-14 15:24:24 -0800 (Mon, 14 Jan 2019)


Log Message
Merge r239787 - Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292


Reviewed by Yusuke Suzuki.

Source/bmalloc:

Previously, when GIGACAGE_ALLOCATION_CAN_FAIL is true, we allow the Gigacage to
be disabled if we fail to allocate memory for it.  However, Gigacage::primitiveGigacageDisabled()
still always assumes that the Gigacage is always enabled after ensureGigacage() is
called.

This patch updates Gigacage::primitiveGigacageDisabled() to allow the Gigacage to
already be disabled if GIGACAGE_ALLOCATION_CAN_FAIL is true and wasEnabled() is
false.

In this patch, we also put the wasEnabled flag in the 0th slot of the
g_gigacageBasePtrs buffer to ensure that it is also protected against writes just
like the Gigacage base pointers.

To achieve this, we do the following:
1. Added a reservedForFlags field in struct BasePtrs.
2. Added a ReservedForFlagsAndNotABasePtr Gigacage::Kind.
3. Added assertions to ensure that the BasePtrs::primitive is at the offset
   matching the offset computed from Gigacage::Primitive.  Ditto for
   BasePtrs::jsValue and Gigacage::JSValue.
4. Added assertions to ensure that Gigacage::ReservedForFlagsAndNotABasePtr is not
   used for fetching a Gigacage base pointer.
5. Added RELEASE_BASSERT_NOT_REACHED() to implement such assertions in bmalloc.

No test added because this issue requires Gigacage allocation to fail in order to
manifest.  I've tested it manually by modifying the code locally to force an
allocation failure.

* bmalloc/BAssert.h:
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::primitiveGigacageDisabled):
* bmalloc/Gigacage.h:
(Gigacage::wasEnabled):
(Gigacage::setWasEnabled):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::size):
* bmalloc/HeapKind.h:
(bmalloc::heapKind):

Source/_javascript_Core:

* runtime/VM.h:
(JSC::VM::gigacageAuxiliarySpace):

Source/WTF:

Update the USE_SYSTEM_MALLOC version of Gigacage.h to match the bmalloc version.

* wtf/Gigacage.h:

Modified Paths

releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/VM.h
releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WTF/wtf/Gigacage.h
releases/WebKitGTK/webkit-2.22/Source/bmalloc/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/BAssert.h
releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.cpp
releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.h
releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/HeapKind.h




Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog (239956 => 239957)

--- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2019-01-14 23:24:19 UTC (rev 239956)
+++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2019-01-14 23:24:24 UTC (rev 239957)
@@ -1,3 +1,14 @@
+2019-01-09  Mark Lam  
+
+Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
+https://bugs.webkit.org/show_bug.cgi?id=193292
+
+
+Reviewed by Yusuke Suzuki.
+
+* runtime/VM.h:
+(JSC::VM::gigacageAuxiliarySpace):
+
 2018-12-18  Mark Lam  
 
 JSPropertyNameEnumerator should cache the iterated object's structure only after getting its property names.


Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/VM.h (239956 => 239957)

--- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/VM.h	2019-01-14 23:24:19 UTC (rev 239956)
+++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/VM.h	2019-01-14 23:24:24 UTC (rev 239957)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2019 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -344,6 +344,8 @@
 ALWAYS_INLINE CompleteSubspace& gigacageAuxiliarySpace(Gigacage::Kind kind)
 {
 switch (kind) {
+case Gigacage::ReservedForFlagsAndNotABasePtr:
+RELEASE_ASSERT_NOT_REACHED();
 case Gigacage::Primitive:
 return primitiveGigacageAuxiliarySpace;
 case Gigacage::JSValue:


Modified: releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog (239956 => 239957)

--- releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog	2019-01-14 23:24:19 UTC (rev 239956)
+++ releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog	2019-01-14 23:24:24 UTC (rev 239957)
@@ -1,3 +1,15 @@
+2019-01-09  Mark Lam  
+
+Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
+https://bugs.webkit.org/show_bug.cgi?id=193292
+
+
+

[webkit-changes] [239956] releases/WebKitGTK/webkit-2.22/Source/bmalloc

Title: [239956] releases/WebKitGTK/webkit-2.22/Source/bmalloc








Revision 239956
Author mcatanz...@igalia.com
Date 2019-01-14 15:24:19 -0800 (Mon, 14 Jan 2019)


Log Message
Merge r239245 - Gigacage runway should immediately follow the primitive cage
https://bugs.webkit.org/show_bug.cgi?id=192733

Reviewed by Saam Barati.

This patch makes sure that the Gigacage runway is always
immediately after the primitive cage. Since writing outside the
primitive gigacage is likely to be more dangerous than the JSValue
cage. The ordering of the cages is still random however.

* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):

Modified Paths

releases/WebKitGTK/webkit-2.22/Source/bmalloc/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/bmalloc/ChangeLog (239955 => 239956)

--- releases/WebKitGTK/webkit-2.22/Source/bmalloc/ChangeLog	2019-01-14 23:22:46 UTC (rev 239955)
+++ releases/WebKitGTK/webkit-2.22/Source/bmalloc/ChangeLog	2019-01-14 23:24:19 UTC (rev 239956)
@@ -1,3 +1,18 @@
+2018-12-14  Keith Miller  
+
+Gigacage runway should immediately follow the primitive cage
+https://bugs.webkit.org/show_bug.cgi?id=192733
+
+Reviewed by Saam Barati.
+
+This patch makes sure that the Gigacage runway is always
+immediately after the primitive cage. Since writing outside the
+primitive gigacage is likely to be more dangerous than the JSValue
+cage. The ordering of the cages is still random however.
+
+* bmalloc/Gigacage.cpp:
+(Gigacage::ensureGigacage):
+
 2018-08-16  Tomas Popela  
 
 bmalloc: Coverity scan issues


Modified: releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.cpp (239955 => 239956)

--- releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.cpp	2019-01-14 23:22:46 UTC (rev 239955)
+++ releases/WebKitGTK/webkit-2.22/Source/bmalloc/bmalloc/Gigacage.cpp	2019-01-14 23:24:19 UTC (rev 239956)
@@ -99,6 +99,19 @@
 Vector callbacks;
 };
 
+#if GIGACAGE_ENABLED
+size_t runwaySize(Kind kind)
+{
+switch (kind) {
+case Kind::Primitive:
+return static_cast(GIGACAGE_RUNWAY);
+case Kind::JSValue:
+return static_cast(0);
+}
+return static_cast(0);
+}
+#endif
+
 } // anonymous namespace
 
 void ensureGigacage()
@@ -140,10 +153,10 @@
 
 for (Kind kind : shuffledKinds) {
 totalSize = bump(kind, alignTo(kind, totalSize));
+totalSize += runwaySize(kind);
 maxAlignment = std::max(maxAlignment, alignment(kind));
 }
-totalSize += GIGACAGE_RUNWAY;
-
+
 // FIXME: Randomize where this goes.
 // https://bugs.webkit.org/show_bug.cgi?id=175245
 void* base = tryVMAllocate(maxAlignment, totalSize);
@@ -155,21 +168,20 @@
 BCRASH();
 }
 
-if (GIGACAGE_RUNWAY > 0) {
-char* runway = reinterpret_cast(base) + totalSize - GIGACAGE_RUNWAY;
-// Make OOB accesses into the runway crash.
-vmRevokePermissions(runway, GIGACAGE_RUNWAY);
-}
-
-vmDeallocatePhysicalPages(base, totalSize);
-
 size_t nextCage = 0;
 for (Kind kind : shuffledKinds) {
 nextCage = alignTo(kind, nextCage);
 basePtr(kind) = reinterpret_cast(base) + nextCage;
 nextCage = bump(kind, nextCage);
+if (runwaySize(kind) > 0) {
+char* runway = reinterpret_cast(base) + nextCage;
+// Make OOB accesses into the runway crash.
+vmRevokePermissions(runway, runwaySize(kind));
+nextCage += runwaySize(kind);
+}
 }
 
+vmDeallocatePhysicalPages(base, totalSize);
 protectGigacageBasePtrs();
 g_wasEnabled = true;
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239955] trunk/Source/WebInspectorUI

2019-01-14 Thread drousso

Title: [239955] trunk/Source/WebInspectorUI








Revision 239955
Author drou...@apple.com
Date 2019-01-14 15:22:46 -0800 (Mon, 14 Jan 2019)


Log Message
Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
https://bugs.webkit.org/show_bug.cgi?id=193384

Reviewed by Joseph Pecoraro.

* UserInterface/Views/EventBreakpointPopover.js:
(WI.EventBreakpointPopover.prototype.show):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239954 => 239955)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 22:59:51 UTC (rev 239954)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 23:22:46 UTC (rev 239955)
@@ -1,5 +1,15 @@
 2019-01-14  Devin Rousso  
 
+Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
+https://bugs.webkit.org/show_bug.cgi?id=193384
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/EventBreakpointPopover.js:
+(WI.EventBreakpointPopover.prototype.show):
+
+2019-01-14  Devin Rousso  
+
 Web Inspector: Event breakpoints: text field and completion popover fonts should match
 https://bugs.webkit.org/show_bug.cgi?id=193249
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js (239954 => 239955)

--- trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js	2019-01-14 22:59:51 UTC (rev 239954)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js	2019-01-14 23:22:46 UTC (rev 239955)
@@ -107,7 +107,7 @@
 .then((eventNames) => {
 this._currentCompletions = [];
 for (let eventName of eventNames) {
-if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value))
+if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value.toLowerCase()))
 this._currentCompletions.push(eventName);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239954] tags/Safari-607.1.20.2/

Title: [239954] tags/Safari-607.1.20.2/








Revision 239954
Author alanc...@apple.com
Date 2019-01-14 14:59:51 -0800 (Mon, 14 Jan 2019)


Log Message
New tag.

Added Paths

tags/Safari-607.1.20.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239953] trunk/Source/WebInspectorUI

2019-01-14 Thread drousso

Title: [239953] trunk/Source/WebInspectorUI








Revision 239953
Author drou...@apple.com
Date 2019-01-14 14:52:31 -0800 (Mon, 14 Jan 2019)


Log Message
Web Inspector: Event breakpoints: text field and completion popover fonts should match
https://bugs.webkit.org/show_bug.cgi?id=193249

Reviewed by Matt Baker.

* UserInterface/Views/EventBreakpointPopover.css:
(.popover .event-breakpoint-content > .event-type > input): Added.
(.popover .event-breakpoint-content > .event-type > input::placeholder): Added.
* UserInterface/Views/EventBreakpointPopover.js:
(WI.EventBreakpointPopover.prototype.show):
(WI.EventBreakpointPopover.prototype._showSuggestionsView):
Subtract the  border and padding from the bounds position so the  text lines
up with the `WI.CompletionSuggestionsView` text.

* UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView):
Drive-by: force `dir=ltr` to match the `text-align: left;` CSS styling.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js
trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css
trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239952 => 239953)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 22:51:56 UTC (rev 239952)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 22:52:31 UTC (rev 239953)
@@ -1,3 +1,23 @@
+2019-01-14  Devin Rousso  
+
+Web Inspector: Event breakpoints: text field and completion popover fonts should match
+https://bugs.webkit.org/show_bug.cgi?id=193249
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/EventBreakpointPopover.css:
+(.popover .event-breakpoint-content > .event-type > input): Added.
+(.popover .event-breakpoint-content > .event-type > input::placeholder): Added.
+* UserInterface/Views/EventBreakpointPopover.js:
+(WI.EventBreakpointPopover.prototype.show):
+(WI.EventBreakpointPopover.prototype._showSuggestionsView):
+Subtract the  border and padding from the bounds position so the  text lines
+up with the `WI.CompletionSuggestionsView` text.
+
+* UserInterface/Views/CompletionSuggestionsView.js:
+(WI.CompletionSuggestionsView):
+Drive-by: force `dir=ltr` to match the `text-align: left;` CSS styling.
+
 2019-01-14  Nikita Vasilyev  
 
 Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js (239952 => 239953)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js	2019-01-14 22:51:56 UTC (rev 239952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js	2019-01-14 22:52:31 UTC (rev 239953)
@@ -36,6 +36,7 @@
 this._moveIntervalIdentifier = null;
 
 this._element = document.createElement("div");
+this._element.setAttribute("dir", "ltr");
 this._element.classList.add("completion-suggestions", WI.Popover.IgnoreAutoDismissClassName);
 
 this._containerElement = document.createElement("div");


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css (239952 => 239953)

--- trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css	2019-01-14 22:51:56 UTC (rev 239952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css	2019-01-14 22:52:31 UTC (rev 239953)
@@ -32,3 +32,12 @@
 display: flex;
 margin-top: 4px;
 }
+
+.popover .event-breakpoint-content > .event-type > input {
+font-family: Menlo, monospace;
+text-align: left;
+}
+
+.popover .event-breakpoint-content > .event-type > input::placeholder {
+font-family: system-ui;
+}


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js (239952 => 239953)

--- trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js	2019-01-14 22:51:56 UTC (rev 239952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js	2019-01-14 22:52:31 UTC (rev 239953)
@@ -82,6 +82,7 @@
 this._typeSelectElement.hidden = true;
 
 this._domEventNameInputElement = typeContainer.appendChild(document.createElement("input"));
+this._domEventNameInputElement.setAttribute("dir", "ltr");
 this._domEventNameInputElement.placeholder = WI.UIString("Example: \u201C%s\u201D").format("click");
 this._domEventNameInputElement.spellcheck = false;
 this._domEventNameInputElement.addEventListener("keydown", (event) => {
@@ -190,6 +191,12 @@
 
  _showSuggestionsView()
  {
-this._suggestionsView.show(WI.Rect.rectFromClientRect(this._domEventNameInputElement.getBoundingClientRect()));
+let computedStyle = window.getComputedStyle(this._domEventNameInputElement);
+

[webkit-changes] [239952] trunk/Source/WebCore

2019-01-14 Thread rniwa

Title: [239952] trunk/Source/WebCore








Revision 239952
Author rn...@webkit.org
Date 2019-01-14 14:51:56 -0800 (Mon, 14 Jan 2019)


Log Message
Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides
https://bugs.webkit.org/show_bug.cgi?id=193410

Reviewed by Simon Fraser.

Removed redundant checks for check for alignAttr and hiddenAttr in isPresentationAttribute overrides
in HTMLElement subclasses since HTMLElement::isPresentationAttribute already checks for those attributes.

* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::isPresentationAttribute const): Deleted.
* html/HTMLDivElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isPresentationAttribute const): Deleted.
* html/HTMLEmbedElement.h:
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::isPresentationAttribute const):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute const):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isPresentationAttribute const):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPresentationAttribute const):
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::isPresentationAttribute const): Deleted.
* html/HTMLParagraphElement.h:
* html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::isPresentationAttribute const): Deleted.
* html/HTMLTableCaptionElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isPresentationAttribute const):
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::isPresentationAttribute const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDivElement.cpp
trunk/Source/WebCore/html/HTMLDivElement.h
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLEmbedElement.h
trunk/Source/WebCore/html/HTMLHRElement.cpp
trunk/Source/WebCore/html/HTMLIFrameElement.cpp
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLParagraphElement.cpp
trunk/Source/WebCore/html/HTMLParagraphElement.h
trunk/Source/WebCore/html/HTMLTableCaptionElement.cpp
trunk/Source/WebCore/html/HTMLTableCaptionElement.h
trunk/Source/WebCore/html/HTMLTableElement.cpp
trunk/Source/WebCore/html/HTMLTablePartElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239951 => 239952)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 22:31:06 UTC (rev 239951)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 22:51:56 UTC (rev 239952)
@@ -1,3 +1,38 @@
+2019-01-14  Ryosuke Niwa  
+
+Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides
+https://bugs.webkit.org/show_bug.cgi?id=193410
+
+Reviewed by Simon Fraser.
+
+Removed redundant checks for check for alignAttr and hiddenAttr in isPresentationAttribute overrides
+in HTMLElement subclasses since HTMLElement::isPresentationAttribute already checks for those attributes.
+
+* html/HTMLDivElement.cpp:
+(WebCore::HTMLDivElement::isPresentationAttribute const): Deleted.
+* html/HTMLDivElement.h:
+* html/HTMLEmbedElement.cpp:
+(WebCore::HTMLEmbedElement::isPresentationAttribute const): Deleted.
+* html/HTMLEmbedElement.h:
+* html/HTMLHRElement.cpp:
+(WebCore::HTMLHRElement::isPresentationAttribute const):
+* html/HTMLIFrameElement.cpp:
+(WebCore::HTMLIFrameElement::isPresentationAttribute const):
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::isPresentationAttribute const):
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::isPresentationAttribute const):
+* html/HTMLParagraphElement.cpp:
+(WebCore::HTMLParagraphElement::isPresentationAttribute const): Deleted.
+* html/HTMLParagraphElement.h:
+* html/HTMLTableCaptionElement.cpp:
+(WebCore::HTMLTableCaptionElement::isPresentationAttribute const): Deleted.
+* html/HTMLTableCaptionElement.h:
+* html/HTMLTableElement.cpp:
+(WebCore::HTMLTableElement::isPresentationAttribute const):
+* html/HTMLTablePartElement.cpp:
+(WebCore::HTMLTablePartElement::isPresentationAttribute const):
+
 2019-01-14  Commit Queue  
 
 Unreviewed, rolling out r239901, r239909, r239910, r239912,


Modified: trunk/Source/WebCore/html/HTMLDivElement.cpp (239951 => 239952)

--- trunk/Source/WebCore/html/HTMLDivElement.cpp	2019-01-14 22:31:06 UTC (rev 239951)
+++ trunk/Source/WebCore/html/HTMLDivElement.cpp	2019-01-14 22:51:56 UTC (rev 239952)
@@ -50,13 +50,6 @@
 return adoptRef(*new HTMLDivElement(tagName, document));
 }
 
-bool HTMLDivElement::isPresentationAttribute(const QualifiedName& name) const
-{
-if (name == alignAttr)
-return true;
-return HTMLElement::isPresentationAttribute(name);
-}
-
 void HTMLDivElement::collectStyleForPresentationAttribute(const QualifiedName& name,

[webkit-changes] [239951] trunk

2019-01-14 Thread yusukesuzuki

Title: [239951] trunk








Revision 239951
Author yusukesuz...@slowstart.org
Date 2019-01-14 14:31:06 -0800 (Mon, 14 Jan 2019)


Log Message
[JSC] Do not use asArrayModes() with Structures because it discards TypedArray information
https://bugs.webkit.org/show_bug.cgi?id=193372

Reviewed by Saam Barati.

JSTests:

* stress/typed-array-array-modes-profile.js: Added.
(foo):

Source/_javascript_Core:

When RegisteredStructureSet is filtered with AbstractValue, we use structure, SpeculationType, and ArrayModes.
However, we use asArrayModes() function with IndexingMode to compute the ArrayModes in AbstractValue. This is
wrong since this discards TypedArray ArrayModes. As a result, if RegisteredStructureSet with TypedArrays is
filtered with ArrayModes of AbstractValue populated from TypedArrays, we filter all the structures out since
AbstractValue's ArrayModes become NonArray, which is wrong with the TypedArrays' ArrayModes. This leads to
incorrect FTL code generation with MultiGetByOffset etc. nodes because,

1. AI think that this MultiGetByOffset never succeeds since all the values of RegisteredStructureSet are filtered out by the AbstractValue.
2. AI says the state of MultiGetByOffset is invalid since AI think it never succeeds.
3. So subsequent code becomes FTL crash code since AI think the execution should do OSR exit.
4. Then, FTL emits the code for MultiGetByOffset, and emits crash after that.
5. But in reality, the incoming value can match to the one of the RegisteredStructureSet value since (1)'s structures are incorrectly filtered by the incorrect ArrayModes.
6. Then, the execution goes on, and falls into the FTL crash.

This patch fixes the incorrect ArrayModes calculation by the following changes

1. Rename asArrayModes to asArrayModesIgnoringTypedArrays.
2. Fix incorrect asArrayModesIgnoringTypedArrays use in our code. Use arrayModesFromStructure instead.
3. Fix OSR exit code which stores incorrect ArrayModes to the profiles.

* bytecode/ArrayProfile.cpp:
(JSC::dumpArrayModes):
(JSC::ArrayProfile::computeUpdatedPrediction):
* bytecode/ArrayProfile.h:
(JSC::asArrayModesIgnoringTypedArrays):
(JSC::arrayModesFromStructure):
(JSC::arrayModesIncludeIgnoringTypedArrays):
(JSC::shouldUseSlowPutArrayStorage):
(JSC::shouldUseFastArrayStorage):
(JSC::shouldUseContiguous):
(JSC::shouldUseDouble):
(JSC::shouldUseInt32):
(JSC::asArrayModes): Deleted.
(JSC::arrayModeFromStructure): Deleted.
(JSC::arrayModesInclude): Deleted.
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::observeTransitions):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::mergeOSREntryValue):
(JSC::DFG::AbstractValue::contains const):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::observeTransition):
(JSC::DFG::AbstractValue::validate const):
(JSC::DFG::AbstractValue::observeIndexingTypeTransition):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::alreadyChecked const):
* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape const):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::OSRExit::compileExit):
* dfg/DFGRegisteredStructureSet.cpp:
(JSC::DFG::RegisteredStructureSet::filterArrayModes):
(JSC::DFG::RegisteredStructureSet::arrayModesFromStructures const):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* jit/JITInlines.h:
(JSC::JIT::chooseArrayMode):
(JSC::arrayProfileSaw): Deleted.
* runtime/JSType.h:
(JSC::isTypedArrayType):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ArrayProfile.cpp
trunk/Source/_javascript_Core/bytecode/ArrayProfile.h
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.cpp
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h
trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp
trunk/Source/_javascript_Core/dfg/DFGRegisteredStructureSet.cpp
trunk/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp
trunk/Source/_javascript_Core/jit/JITInlines.h
trunk/Source/_javascript_Core/runtime/JSType.h


Added Paths

trunk/JSTests/stress/typed-array-array-modes-profile.js




Diff

Modified: trunk/JSTests/ChangeLog (239950 => 239951)

--- trunk/JSTests/ChangeLog	2019-01-14 22:23:30 UTC (rev 239950)
+++ trunk/JSTests/ChangeLog	2019-01-14 22:31:06 UTC (rev 239951)
@@ -1,3 +1,13 @@
+2019-01-14  Yusuke Suzuki  
+
+[JSC] Do not use asArrayModes() with Structures because it discards TypedArray information
+https://bugs.webkit.org/show_bug.cgi?id=193372
+
+Reviewed by Saam Barati.
+
+* stress/typed-array-array-modes-profile.js: Added.
+(foo):
+
 2019-01-14  Mark Lam  
 
 Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).


Added:

[webkit-changes] [239949] releases/WebKitGTK/webkit-2.22

Title: [239949] releases/WebKitGTK/webkit-2.22








Revision 239949
Author mcatanz...@igalia.com
Date 2019-01-14 14:23:26 -0800 (Mon, 14 Jan 2019)


Log Message
Merge r239642 - Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=193155


Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/loader/comment-only-_javascript_-url.html

Make a special case for URLs beginning with '_javascript_:'. We should always
treat these as JS URLs, even if the content contained within the URL
string might match other parts of the URL parsing spec.

* html/URLUtils.h:
(WebCore::URLUtils::protocol const):

LayoutTests:

* fast/loader/comment-only-_javascript_-url-expected.txt: Added.
* fast/loader/comment-only-_javascript_-url.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/html/URLUtils.h


Added Paths

releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url-expected.txt
releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url.html




Diff

Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (239948 => 239949)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog	2019-01-14 22:19:50 UTC (rev 239948)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog	2019-01-14 22:23:26 UTC (rev 239949)
@@ -1,3 +1,14 @@
+2019-01-04  Brent Fulgham  
+
+Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox
+https://bugs.webkit.org/show_bug.cgi?id=193155
+
+
+Reviewed by Chris Dumez.
+
+* fast/loader/comment-only-_javascript_-url-expected.txt: Added.
+* fast/loader/comment-only-_javascript_-url.html: Added.
+
 2018-12-21  Zalan Bujtas  
 
 Synchronous media query evaluation could destroy current Frame/FrameView.


Added: releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url-expected.txt (0 => 239949)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url-expected.txt	2019-01-14 22:23:26 UTC (rev 239949)
@@ -0,0 +1,18 @@
+ALERT: 0
+ALERT: 1
+ALERT: 2
+ALERT: 3
+ALERT: 4
+ALERT: 5
+ALERT: 6
+Tests that we properly handle _javascript_ URLs containing comment characters, newlines, and carriage returns.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS No _javascript_ URLs executed.
+PASS _javascript_ URLs were executed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url.html (0 => 239949)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/fast/loader/comment-only-_javascript_-url.html	2019-01-14 22:23:26 UTC (rev 239949)
@@ -0,0 +1,66 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+jsTestIsAsync = true;
+var count = 0;
+
+
+
+
+function filtered(url){
+var parser = document.createElement('a');
+parser.href = ""
+if (parser.protocol.indexOf("_javascript_") == -1) {
+  	parser.click();
+}
+}
+
+function unfiltered(url){
+var parser = document.createElement('a');
+parser.href = ""
+if (parser.protocol === "_javascript_:") {
+  	parser.click();
+};
+}
+
+description("Tests that we properly handle _javascript_ URLs containing comment characters, newlines, and carriage returns.");
+
+let cases = [ "_javascript_:alert(count); ++count;",
+"_javascript_:// A fun test%0aalert(count); ++count;",
+"_javascript_://:%0aalert(count); ++count;",
+"_javascript_://:%0dalert(count); ++count;",
+"_javascript_://:%0a%0dalert(count); ++count;",
+"_javascript_://%0a://%0dalert(count); ++count;",
+"_javascript_://%0d//:%0aalert(count); ++count;"
+];
+
+for (var c in cases)
+filtered(cases[c]);
+
+setTimeout(function () {
+if (!count)
+testPassed("No _javascript_ URLs executed.");
+else
+testFailed("_javascript_ URLs were executed.")
+
+for (var c in cases)
+unfiltered(cases[c]);
+
+setTimeout(function() {
+if (count == cases.length)
+testPassed("_javascript_ URLs were executed.")
+else
+testFailed("No _javascript_ URLs executed.");
+
+	finishJSTest();
+}, 0);
+}, 0);
+
+
+


Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (239948 => 239949)

--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2019-01-14

[webkit-changes] [239950] releases/WebKitGTK/webkit-2.22/Source/WTF

Title: [239950] releases/WebKitGTK/webkit-2.22/Source/WTF








Revision 239950
Author mcatanz...@igalia.com
Date 2019-01-14 14:23:30 -0800 (Mon, 14 Jan 2019)


Log Message
Merge r239873 - WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350

Reviewed by Brent Fulgham.

The non COCOA version of WorkQueue::concurrentApply() creates a temporary
String for the threadName and passes the raw pointer of this String to
Thread::create(). After freeing this String, Thread::entryPoint() uses
the raw char pointer to internally initialize the thread.

The fix is to use a single literal string for all the threads' names since
they are created for a thread-pool.

* wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply):

Modified Paths

releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WTF/wtf/WorkQueue.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog (239949 => 239950)

--- releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog	2019-01-14 22:23:26 UTC (rev 239949)
+++ releases/WebKitGTK/webkit-2.22/Source/WTF/ChangeLog	2019-01-14 22:23:30 UTC (rev 239950)
@@ -1,3 +1,21 @@
+2019-01-11  Said Abou-Hallawa  
+
+WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
+https://bugs.webkit.org/show_bug.cgi?id=191350
+
+Reviewed by Brent Fulgham.
+
+The non COCOA version of WorkQueue::concurrentApply() creates a temporary
+String for the threadName and passes the raw pointer of this String to
+Thread::create(). After freeing this String, Thread::entryPoint() uses
+the raw char pointer to internally initialize the thread.
+
+The fix is to use a single literal string for all the threads' names since
+they are created for a thread-pool.
+
+* wtf/WorkQueue.cpp:
+(WTF::WorkQueue::concurrentApply):
+
 2018-12-14  Darin Adler  
 
 Verify size is valid in USE_SYSTEM_MALLOC version of tryAllocateZeroedVirtualPages


Modified: releases/WebKitGTK/webkit-2.22/Source/WTF/wtf/WorkQueue.cpp (239949 => 239950)

--- releases/WebKitGTK/webkit-2.22/Source/WTF/wtf/WorkQueue.cpp	2019-01-14 22:23:26 UTC (rev 239949)
+++ releases/WebKitGTK/webkit-2.22/Source/WTF/wtf/WorkQueue.cpp	2019-01-14 22:23:30 UTC (rev 239950)
@@ -75,7 +75,7 @@
 
 m_workers.reserveInitialCapacity(threadCount);
 for (unsigned i = 0; i < threadCount; ++i) {
-m_workers.append(Thread::create(String::format("ThreadPool Worker %u", i).utf8().data(), [this] {
+m_workers.append(Thread::create("ThreadPool Worker", [this] {
 threadBody();
 }));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239948] trunk

Title: [239948] trunk








Revision 239948
Author commit-qu...@webkit.org
Date 2019-01-14 14:19:50 -0800 (Mon, 14 Jan 2019)


Log Message
Unreviewed, rolling out r239901, r239909, r239910, r239912,
r239913, and r239914.
https://bugs.webkit.org/show_bug.cgi?id=193407

These revisions caused an internal failure (Requested by
Truitt on #webkit).

Reverted changesets:

"[Cocoa] Avoid importing directly from subumbrella frameworks"
https://bugs.webkit.org/show_bug.cgi?id=186016
https://trac.webkit.org/changeset/239901

"Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
https://trac.webkit.org/changeset/239909

"Tried to fix the build."
https://trac.webkit.org/changeset/239910

"Fixed iOS builds after r239910."
https://trac.webkit.org/changeset/239912

"More build fixing."
https://trac.webkit.org/changeset/239913

"Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
https://trac.webkit.org/changeset/239914

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig
trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/MetadataSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h
trunk/Source/WebCore/PAL/pal/spi/mac/SpeechSynthesisSPI.h
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm
trunk/Source/WebCore/editing/mac/DictionaryLookupLegacy.mm
trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm
trunk/Source/WebCore/platform/text/mac/TextEncodingRegistryMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm
trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm
trunk/Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.h
trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowAdapter.mm
trunk/Source/WebKitLegacy/mac/Carbon/CarbonWindowFrame.m
trunk/Source/WebKitLegacy/mac/Carbon/HIViewAdapter.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCarbon.mm
trunk/Source/WebKitLegacy/mac/WebView/PDFViewSPI.h
trunk/Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPDFView.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig
trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239947 => 239948)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 22:16:50 UTC (rev 239947)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 22:19:50 UTC (rev 239948)
@@ -1,3 +1,33 @@
+2019-01-14  Commit Queue  
+
+Unreviewed, rolling out r239901, r239909, r239910, r239912,
+r239913, and r239914.
+https://bugs.webkit.org/show_bug.cgi?id=193407
+
+These revisions caused an internal failure (Requested by
+Truitt on #webkit).
+
+Reverted changesets:
+
+"[Cocoa] Avoid importing directly from subumbrella frameworks"
+https://bugs.webkit.org/show_bug.cgi?id=186016
+https://trac.webkit.org/changeset/239901
+
+"Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
+https://trac.webkit.org/changeset/239909
+
+"Tried to fix the build."
+https://trac.webkit.org/changeset/239910
+
+"Fixed iOS builds after r239910."
+https://trac.webkit.org/changeset/239912
+
+"More build fixing."
+https://trac.webkit.org/changeset/239913
+
+"Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
+https://trac.webkit.org/changeset/239914
+
 2019-01-14  Mark Lam  
 
 Re-enable ability to build --cloop

[webkit-changes] [239947] trunk

2019-01-14 Thread mark . lam

Title: [239947] trunk








Revision 239947
Author mark@apple.com
Date 2019-01-14 14:16:50 -0800 (Mon, 14 Jan 2019)


Log Message
Re-enable ability to build --cloop builds.
https://bugs.webkit.org/show_bug.cgi?id=192955
Source/_javascript_Core:



Reviewed by Saam barati and Keith Miller.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:


Reviewed by Saam barati and Keith Miller.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:



Reviewed by Saam barati and Keith Miller.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:



Reviewed by Saam barati and Keith Miller.

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:



Reviewed by Saam barati and Keith Miller.

* Configurations/FeatureDefines.xcconfig:

Tools:



Reviewed by Saam barati and Keith Miller.

The --cloop build option was being ignored this whole time since r236381.
This patch makes it possible to build CLoop builds again.

* Scripts/build-jsc:
* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239946 => 239947)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-14 22:10:18 UTC (rev 239946)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-14 22:16:50 UTC (rev 239947)
@@ -1,5 +1,15 @@
 2019-01-14  Mark Lam  
 
+Re-enable ability to build --cloop builds.
+https://bugs.webkit.org/show_bug.cgi?id=192955
+
+
+Reviewed by Saam barati and Keith Miller.
+
+* Configurations/FeatureDefines.xcconfig:
+
+2019-01-14  Mark Lam  
+
 Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).
 https://bugs.webkit.org/show_bug.cgi?id=193402
 


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (239946 => 239947)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-01-14 22:10:18 UTC (rev 239946)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2019-01-14 22:16:50 UTC (rev 239947)
@@ -402,4 +402,4 @@
 
 ENABLE_XSLT = ENABLE_XSLT;
 
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EX
 PERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_M
 EDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE)

[webkit-changes] [239946] trunk/Source/WebCore

2019-01-14 Thread jer . noble

Title: [239946] trunk/Source/WebCore








Revision 239946
Author jer.no...@apple.com
Date 2019-01-14 14:10:18 -0800 (Mon, 14 Jan 2019)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=193403


Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239945 => 239946)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 22:02:18 UTC (rev 239945)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 22:10:18 UTC (rev 239946)
@@ -1,3 +1,16 @@
+2019-01-14  Jer Noble  
+
+https://bugs.webkit.org/show_bug.cgi?id=193403
+
+
+Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):
+
 2019-01-14  Justin Fan  
 
 [WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h (239945 => 239946)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h	2019-01-14 22:02:18 UTC (rev 239945)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h	2019-01-14 22:10:18 UTC (rev 239946)
@@ -180,7 +180,7 @@
 MediaSourcePrivateAVFObjC* m_mediaSource;
 SourceBufferPrivateClient* m_client { nullptr };
 #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
-CDMSessionMediaSourceAVFObjC* m_session { nullptr };
+WeakPtr m_session { nullptr };
 #endif
 #if ENABLE(ENCRYPTED_MEDIA) && HAVE(AVCONTENTKEYSESSION)
 RefPtr m_cdmInstance;


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (239945 => 239946)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm	2019-01-14 22:02:18 UTC (rev 239945)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm	2019-01-14 22:10:18 UTC (rev 239946)
@@ -908,7 +908,7 @@
 if (m_session)
 m_session->removeSourceBuffer(this);
 
-m_session = session;
+m_session = makeWeakPtr(session);
 
 if (m_session) {
 m_session->addSourceBuffer(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239945] trunk/Tools

2019-01-14 Thread jbedard

Title: [239945] trunk/Tools








Revision 239945
Author jbed...@apple.com
Date 2019-01-14 14:02:18 -0800 (Mon, 14 Jan 2019)


Log Message
webkitpy: Expose device_type from host-like objects
https://bugs.webkit.org/show_bug.cgi?id=193406


Reviewed by Lucas Forschler.

Devices should expose device_type. As a result, all host objects should
provide a device_type property, even if they do not yet define a device_type.

* Scripts/webkitpy/common/system/systemhost.py:
(SystemHost):
(SystemHost.device_type):
* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost):
(MockSystemHost.device_type):
* Scripts/webkitpy/port/device.py:
(Device):
(Device.device_type):
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._find_exisiting_device_for_request):
(SimulatedDeviceManager._disambiguate_device_type):
(SimulatedDeviceManager._does_fulfill_request):
(SimulatedDeviceManager.device_count_for_type):
(SimulatedDeviceManager.initialize_devices):
* Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_available_devices):
(test_swapping_devices):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/systemhost.py
trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py
trunk/Tools/Scripts/webkitpy/port/device.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (239944 => 239945)

--- trunk/Tools/ChangeLog	2019-01-14 21:56:07 UTC (rev 239944)
+++ trunk/Tools/ChangeLog	2019-01-14 22:02:18 UTC (rev 239945)
@@ -1,5 +1,35 @@
 2019-01-14  Jonathan Bedard  
 
+webkitpy: Expose device_type from host-like objects
+https://bugs.webkit.org/show_bug.cgi?id=193406
+
+
+Reviewed by Lucas Forschler.
+
+Devices should expose device_type. As a result, all host objects should
+provide a device_type property, even if they do not yet define a device_type.
+
+* Scripts/webkitpy/common/system/systemhost.py:
+(SystemHost):
+(SystemHost.device_type):
+* Scripts/webkitpy/common/system/systemhost_mock.py:
+(MockSystemHost):
+(MockSystemHost.device_type):
+* Scripts/webkitpy/port/device.py:
+(Device):
+(Device.device_type):
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager._find_exisiting_device_for_request):
+(SimulatedDeviceManager._disambiguate_device_type):
+(SimulatedDeviceManager._does_fulfill_request):
+(SimulatedDeviceManager.device_count_for_type):
+(SimulatedDeviceManager.initialize_devices):
+* Scripts/webkitpy/xcode/simulated_device_unittest.py:
+(test_available_devices):
+(test_swapping_devices):
+
+2019-01-14  Jonathan Bedard  
+
 webkitpy: Support alternate simctl device list output (Follow-up fix)
 https://bugs.webkit.org/show_bug.cgi?id=193362
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/systemhost.py (239944 => 239945)

--- trunk/Tools/Scripts/webkitpy/common/system/systemhost.py	2019-01-14 21:56:07 UTC (rev 239944)
+++ trunk/Tools/Scripts/webkitpy/common/system/systemhost.py	2019-01-14 22:02:18 UTC (rev 239945)
@@ -1,4 +1,5 @@
 # Copyright (c) 2011 Google Inc. All rights reserved.
+# Copyright (C) 2019 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
@@ -54,3 +55,7 @@
 if not self.platform.is_mac():
 return ''
 return self.executive.run_command(['xcrun', 'lldb', '--python-path'], return_stderr=False).rstrip()
+
+@property
+def device_type(self):
+return None


Modified: trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py (239944 => 239945)

--- trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py	2019-01-14 21:56:07 UTC (rev 239944)
+++ trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py	2019-01-14 22:02:18 UTC (rev 239945)
@@ -1,30 +1,31 @@
-# Copyright (c) 2011 Google Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are
-# met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above
-# copyright notice, this list of conditions and the following disclaimer
-# in the documentation and/or other materials provided with the
-# distribution.
-# * Neither the name of Google Inc. nor the names of its
-# contributors may be used to endorse or promote products derived from
-# this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE

[webkit-changes] [239944] trunk

2019-01-14 Thread justin_fan

Title: [239944] trunk








Revision 239944
Author justin_...@apple.com
Date 2019-01-14 13:56:07 -0800 (Mon, 14 Jan 2019)


Log Message
[WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing
https://bugs.webkit.org/show_bug.cgi?id=193405

Reviewed by Dean Jackson.

Source/WebCore:

When creating a WebGPUBindGroupLayout, cache the WebGPUBindGroupLayoutDescriptor's list of BindGroupLayoutBindings
in a HashMap, keyed by binding number, for quick reference during the WebGPUProgrammablePassEncoder::setBindGroups
implementation to follow. Also add error-checking e.g. detecting duplicate binding numbers in the same WebGPUBindGroupLayout
and non-existent binding numbers when creating the WebGPUBindGroup.

No new tests. BindGroups and BindGroupLayouts reflect the (canonical?) strategy of returning empty
objects upon creation failure and reporting errors elswhere. Since error reporting is not yet implemented,
the error checks aren't testable from LayoutTests right now. Expected behavior unchanged and covered by existing tests.

* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createBindGroup const):
Number of bindings must be consistent between bindings and layout bindings.
BindGroupBindings should only refer to existing BindGroupLayoutBindings.
* platform/graphics/gpu/GPUBindGroup.h:
* platform/graphics/gpu/GPUBindGroupLayout.h:
(WebCore::GPUBindGroupLayout::bindingsMap const): Added. Cache map of BindGroupLayoutBindings.
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm: Disallow duplicate binding numbers in BindGroupLayoutBindings.
(WebCore::GPUBindGroupLayout::tryCreate):
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout):

LayoutTests:

Small fixes that do not alter behavior.

* webgpu/bind-groups.html:
* webgpu/pipeline-layouts.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgpu/bind-groups.html
trunk/LayoutTests/webgpu/pipeline-layouts.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroup.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (239943 => 239944)

--- trunk/LayoutTests/ChangeLog	2019-01-14 21:44:46 UTC (rev 239943)
+++ trunk/LayoutTests/ChangeLog	2019-01-14 21:56:07 UTC (rev 239944)
@@ -1,3 +1,15 @@
+2019-01-14  Justin Fan  
+
+[WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing
+https://bugs.webkit.org/show_bug.cgi?id=193405
+
+Reviewed by Dean Jackson.
+
+Small fixes that do not alter behavior.
+
+* webgpu/bind-groups.html:
+* webgpu/pipeline-layouts.html:
+
 2019-01-14  Zalan Bujtas  
 
 [LFC][BFC] Add basic box-sizing support.


Modified: trunk/LayoutTests/webgpu/bind-groups.html (239943 => 239944)

--- trunk/LayoutTests/webgpu/bind-groups.html	2019-01-14 21:44:46 UTC (rev 239943)
+++ trunk/LayoutTests/webgpu/bind-groups.html	2019-01-14 21:56:07 UTC (rev 239944)
@@ -17,7 +17,7 @@
 type: "storageBuffer"
 };
 
-const bindGroupLayout = device.createBindGroupLayout({ bindings: [bufferLayoutBinding]});
+const bindGroupLayout = device.createBindGroupLayout({ bindings: [bufferLayoutBinding] });
 
 const buffer = device.createBuffer({ size: 16, usage: WebGPUBufferUsage.STORAGE });
 const bufferBinding = { buffer: buffer, offset: 0, size: 16 };


Modified: trunk/LayoutTests/webgpu/pipeline-layouts.html (239943 => 239944)

--- trunk/LayoutTests/webgpu/pipeline-layouts.html	2019-01-14 21:44:46 UTC (rev 239943)
+++ trunk/LayoutTests/webgpu/pipeline-layouts.html	2019-01-14 21:56:07 UTC (rev 239944)
@@ -22,7 +22,7 @@
 }, "Create a basic WebGPUBindGroupLayoutDescriptor."); 
 
 promise_test(async () => {
-const device = await window.getBasicDevice();
+const device = await getBasicDevice();
 const bindGroupLayout = device.createBindGroupLayout({ bindings: [createBindGroupLayoutBinding()] });
 assert_true(bindGroupLayout instanceof WebGPUBindGroupLayout, "createBindGroupLayout returned a WebGPUBindGroupLayout");
 


Modified: trunk/Source/WebCore/ChangeLog (239943 => 239944)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 21:44:46 UTC (rev 239943)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 21:56:07 UTC (rev 239944)
@@ -1,3 +1,30 @@
+2019-01-14  Justin Fan  
+
+[WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing
+https://bugs.webkit.org/show_bug.cgi?id=193405
+
+Reviewed by Dean Jackson.
+
+When creating a WebGPUBindGroupLayout, cache the WebGPUBindGroupLayoutDescriptor's list of BindGroupLayoutBindings
+in a HashMap, keyed by binding number, for quick reference during the

[webkit-changes] [239943] tags/Safari-606.4.5.3.1/

Title: [239943] tags/Safari-606.4.5.3.1/








Revision 239943
Author alanc...@apple.com
Date 2019-01-14 13:44:46 -0800 (Mon, 14 Jan 2019)


Log Message
Tag Safari-606.4.5.3.1.

Added Paths

tags/Safari-606.4.5.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239942] branches/safari-606.4.5.3-branch/Source

Title: [239942] branches/safari-606.4.5.3-branch/Source








Revision 239942
Author alanc...@apple.com
Date 2019-01-14 13:41:43 -0800 (Mon, 14 Jan 2019)


Log Message
Versioning.

Modified Paths

branches/safari-606.4.5.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606.4.5.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606.4.5.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (239941 => 239942)

--- branches/safari-606.4.5.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-01-14 21:35:39 UTC (rev 239941)
+++ branches/safari-606.4.5.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-01-14 21:41:43 UTC (rev 239942)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.4.5.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (239941 => 239942)

--- branches/safari-606.4.5.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-01-14 21:35:39 UTC (rev 239941)
+++ branches/safari-606.4.5.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-01-14 21:41:43 UTC (rev 239942)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.4.5.3-branch/Source/WebCore/Configurations/Version.xcconfig (239941 => 239942)

--- branches/safari-606.4.5.3-branch/Source/WebCore/Configurations/Version.xcconfig	2019-01-14 21:35:39 UTC (rev 239941)
+++ branches/safari-606.4.5.3-branch/Source/WebCore/Configurations/Version.xcconfig	2019-01-14 21:41:43 UTC (rev 239942)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.4.5.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (239941 => 239942)

--- branches/safari-606.4.5.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-01-14 21:35:39 UTC (rev 239941)
+++ branches/safari-606.4.5.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-01-14 21:41:43 UTC (rev 239942)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.4.5.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (239941 => 239942)

--- branches/safari-606.4.5.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-01-14 21:35:39 UTC (rev 239941)
+++ branches/safari-606.4.5.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-01-14 21:41:43 UTC (rev 239942)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
 TINY_VERSION = 5;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on

[webkit-changes] [239941] branches/safari-607-branch/Tools

2019-01-14 Thread ryanhaddad

Title: [239941] branches/safari-607-branch/Tools








Revision 239941
Author ryanhad...@apple.com
Date 2019-01-14 13:35:39 -0800 (Mon, 14 Jan 2019)


Log Message
Cherry-pick r239939. rdar://problem/47255372

webkitpy: Support alternate simctl device list output (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=193362


Rubber-stamped by Lucas Forschler.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.populate_available_devices):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-607-branch/Tools/ChangeLog
branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py




Diff

Modified: branches/safari-607-branch/Tools/ChangeLog (239940 => 239941)

--- branches/safari-607-branch/Tools/ChangeLog	2019-01-14 21:34:47 UTC (rev 239940)
+++ branches/safari-607-branch/Tools/ChangeLog	2019-01-14 21:35:39 UTC (rev 239941)
@@ -1,5 +1,32 @@
 2019-01-14  Ryan Haddad  
 
+Cherry-pick r239939. rdar://problem/47255372
+
+webkitpy: Support alternate simctl device list output (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=193362
+
+
+Rubber-stamped by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.populate_available_devices):
+
+
+git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14  Jonathan Bedard  
+
+webkitpy: Support alternate simctl device list output (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=193362
+
+
+Rubber-stamped by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.populate_available_devices):
+
+2019-01-14  Ryan Haddad  
+
 Cherry-pick r239878. rdar://problem/47255372
 
 webkitpy: Support alternate simctl device list output


Modified: branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py (239940 => 239941)

--- branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 21:34:47 UTC (rev 239940)
+++ branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 21:35:39 UTC (rev 239941)
@@ -139,7 +139,7 @@
 devices = devices_for_runtime['devices']
 break
 else:
-devices = simctl_json['devices'][runtime.name]
+devices = simctl_json['devices'].get(runtime.name, None) or simctl_json['devices'].get(runtime.identifier, [])
 
 for device_json in devices:
 device = SimulatedDeviceManager._create_device_with_runtime(host, runtime, device_json)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239940] trunk

2019-01-14 Thread mark . lam

Title: [239940] trunk

Revision 239940
Author mark@apple.com
Date 2019-01-14 13:34:47 -0800 (Mon, 14 Jan 2019)

Log Message
Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).
https://bugs.webkit.org/show_bug.cgi?id=193402

Reviewed by Keith Miller.

JSTests:

* stress/regexp-compile-oom.js:
- Skip this test for !$jitTests because it is tuned for stack usage when the JIT
is enabled. As a result, it will fail on cloop builds though there is no bug.

Source/_javascript_Core:

The CLoop builds via build-jsc were previously completely disabled after our
change to enable ASM LLInt build without the JIT. As a result, JSC tests have
regressed on CLoop builds. The CLoop builds and tests will be re-enabled when
the fix for https://bugs.webkit.org/show_bug.cgi?id=192955 lands. This patch
fixes all the regressions (and some old bugs) so that the CLoop test bots won't
be red when CLoop build gets re-enabled.

In this patch, we do the following:

1. Change CLoopStack::grow() to set the new CLoop stack top at the maximum
allocated capacity (after discounting the reserved zone) as opposed to setting
it only at the level that the client requested.

This fixes a small performance bug that I happened to noticed when I was
debugging a stack issue. It does not affect correctness.

2. In LowLevelInterpreter32_64.asm:

1. Fix loadConstantOrVariableTag() to use subi for computing the constant
index because the VirtualRegister offset and FirstConstantRegisterIndex
values it is operating on are both signed ints. This is just to be
pedantic. The previous use of subu will still produce a correct value.

2. Fix llintOpWithReturn() to use getu (instead of get) for reading
OpIsCellWithType::type because it is of type JSType, which is a uint8_t.

3. Fix llintOpWithMetadata() to use loadis for loading
OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t5] because it
is of type PropertyOffset, which is a signed int.

4. Fix commonCallOp() to use getu for loading fields argv and argc because they
are of type unsigned for OpCall, OpConstruct, and OpTailCall, which are the
clients of commonCallOp.

5. Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading
OpGetFromScope::Metadata::operand because it is of type uintptr_t.

3. In LowLevelInterpreter64.asm:

1. Fix llintOpWithReturn() to use getu for reading OpIsCellWithType::type
because it is of type JSType, which is a uint8_t.

2. Fix llintOpWithMetadata() to use loadi for loading
OpGetById::Metadata::modeMetadata.protoLoadMode.structure[t2] because it is
of type StructureID, which is a uint32_t.

Fix llintOpWithMetadata() to use loadis for loading
OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t2] because it
is of type PropertyOffset, which is a signed int.

3. commonOp() should reload the metadataTable for op_catch because unlike
for the ASM LLInt, the exception unwinding code is not able to restore
"callee saved registers" for the CLoop interpreter because the CLoop uses
pseudo-registers (see the CLoopRegister class).

This was the source of many exotic Cloop failures after the bytecode format
change (which introduced the metadataTable callee saved register). Hence,
we fix it by reloading metadataTable's value on re-entry via op_catch for
exception handling. We already take care of restoring it in op_ret.

4. Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading
OpGetFromScope::Metadata::operand because it is of type uintptr_t.

4. In LowLevelInterpreter.asm:

Fix metadata() to use loadi for loading metadataTable offsets because they are
of type unsigned. This was also a source of many exotic CLoop test failures.

5. Change CLoopRegister into a class with a uintptr_t as its storage element.
Previously, we were using a union to convert between various value types that
we would store in this pseudo-register. This method of type conversion is
undefined behavior according to the C++ spec. As a result, the C++ compiler
may choose to elide some CLoop statements, thereby resulting in some exotic
bugs.

We fix this by now always using accessor methods and assignment operators to
ensure that we use bitwise_cast to do the type conversions. Since bitwise_cast
uses a memcpy, this ensures that there's no undefined behavior, and that CLoop
statements won't get elided willy-nilly by the compiler.

Ditto for the CloopDobleRegisters.

Similarly, use bitwise_cast for ints2Double() and double2Ints() utility
functions.

Also use bitwise_cast (instead of reinterpret_cast) for the CLoop CAST macro.

6. Fix cloop.rb to use the new CLoopRegister and CLoopDoubleRegister classes.

Add a clLValue accessor for offlineasm operand types to distinguish
LValue use

[webkit-changes] [239939] trunk/Tools

2019-01-14 Thread jbedard

Title: [239939] trunk/Tools








Revision 239939
Author jbed...@apple.com
Date 2019-01-14 13:32:49 -0800 (Mon, 14 Jan 2019)


Log Message
webkitpy: Support alternate simctl device list output (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=193362


Rubber-stamped by Lucas Forschler.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.populate_available_devices):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py




Diff

Modified: trunk/Tools/ChangeLog (239938 => 239939)

--- trunk/Tools/ChangeLog	2019-01-14 21:27:59 UTC (rev 239938)
+++ trunk/Tools/ChangeLog	2019-01-14 21:32:49 UTC (rev 239939)
@@ -1,3 +1,14 @@
+2019-01-14  Jonathan Bedard  
+
+webkitpy: Support alternate simctl device list output (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=193362
+
+
+Rubber-stamped by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.populate_available_devices):
+
 2019-01-14  Wenson Hsieh  
 
 [iOS] Expose SPI to access the current sentence boundary and selection state


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (239938 => 239939)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 21:27:59 UTC (rev 239938)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 21:32:49 UTC (rev 239939)
@@ -139,7 +139,7 @@
 devices = devices_for_runtime['devices']
 break
 else:
-devices = simctl_json['devices'][runtime.name]
+devices = simctl_json['devices'].get(runtime.name, None) or simctl_json['devices'].get(runtime.identifier, [])
 
 for device_json in devices:
 device = SimulatedDeviceManager._create_device_with_runtime(host, runtime, device_json)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239938] trunk/Source/WebKit

Title: [239938] trunk/Source/WebKit








Revision 239938
Author commit-qu...@webkit.org
Date 2019-01-14 13:27:59 -0800 (Mon, 14 Jan 2019)


Log Message
Remove unused networking entitlement from iOS WebProcess entitlements
https://bugs.webkit.org/show_bug.cgi?id=193267

Patch by Alex Christensen  on 2019-01-14
Reviewed by Dean Jackson.

* Configurations/WebContent-iOS.entitlements:
This gave access to VPN stuff.  It's not needed any more.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebContent-iOS.entitlements




Diff

Modified: trunk/Source/WebKit/ChangeLog (239937 => 239938)

--- trunk/Source/WebKit/ChangeLog	2019-01-14 21:17:10 UTC (rev 239937)
+++ trunk/Source/WebKit/ChangeLog	2019-01-14 21:27:59 UTC (rev 239938)
@@ -1,3 +1,13 @@
+2019-01-14  Alex Christensen  
+
+Remove unused networking entitlement from iOS WebProcess entitlements
+https://bugs.webkit.org/show_bug.cgi?id=193267
+
+Reviewed by Dean Jackson.
+
+* Configurations/WebContent-iOS.entitlements:
+This gave access to VPN stuff.  It's not needed any more.
+
 2019-01-14  Youenn Fablet  
 
 Enable MDNS ICE candidate support by default


Modified: trunk/Source/WebKit/Configurations/WebContent-iOS.entitlements (239937 => 239938)

--- trunk/Source/WebKit/Configurations/WebContent-iOS.entitlements	2019-01-14 21:17:10 UTC (rev 239937)
+++ trunk/Source/WebKit/Configurations/WebContent-iOS.entitlements	2019-01-14 21:27:59 UTC (rev 239938)
@@ -4,8 +4,6 @@
 
 	com.apple.private.allow-explicit-graphics-priority
 	
-	com.apple.private.network.socket-delegate
-	
 	com.apple.private.webinspector.allow-remote-inspection
 	
 	com.apple.private.webinspector.proxy-application






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239937] branches/safari-606.4.5.3-branch/

Title: [239937] branches/safari-606.4.5.3-branch/








Revision 239937
Author alanc...@apple.com
Date 2019-01-14 13:17:10 -0800 (Mon, 14 Jan 2019)


Log Message
New branch.

Added Paths

branches/safari-606.4.5.3-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239936] trunk/Source/WebKit

2019-01-14 Thread youenn

Title: [239936] trunk/Source/WebKit








Revision 239936
Author you...@apple.com
Date 2019-01-14 13:13:26 -0800 (Mon, 14 Jan 2019)


Log Message
Enable MDNS ICE candidate support by default
https://bugs.webkit.org/show_bug.cgi?id=193358

Reviewed by Geoffrey Garen.

* Shared/WebPreferences.yaml:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: trunk/Source/WebKit/ChangeLog (239935 => 239936)

--- trunk/Source/WebKit/ChangeLog	2019-01-14 21:07:57 UTC (rev 239935)
+++ trunk/Source/WebKit/ChangeLog	2019-01-14 21:13:26 UTC (rev 239936)
@@ -1,3 +1,12 @@
+2019-01-14  Youenn Fablet  
+
+Enable MDNS ICE candidate support by default
+https://bugs.webkit.org/show_bug.cgi?id=193358
+
+Reviewed by Geoffrey Garen.
+
+* Shared/WebPreferences.yaml:
+
 2019-01-11  Matt Rajca  
 
 Expose preference for site-specific quirks on iOS


Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (239935 => 239936)

--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-01-14 21:07:57 UTC (rev 239935)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-01-14 21:13:26 UTC (rev 239936)
@@ -557,7 +557,7 @@
 
 WebRTCMDNSICECandidatesEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "WebRTC mDNS ICE candidates"
   humanReadableDescription: "Enable WebRTC mDNS ICE candidates"
   webcoreBinding: RuntimeEnabledFeatures






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239935] trunk/Source/WebInspectorUI

2019-01-14 Thread nvasilyev

Title: [239935] trunk/Source/WebInspectorUI








Revision 239935
Author nvasil...@apple.com
Date 2019-01-14 13:07:57 -0800 (Mon, 14 Jan 2019)


Log Message
Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover
https://bugs.webkit.org/show_bug.cgi?id=193098


Reviewed by Devin Rousso.

Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar.
Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may
move from wrapping text.

* UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView.prototype.hide):
(WI.CompletionSuggestionsView.prototype.show):
(WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed.
(WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added.
(WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added.
(WI.CompletionSuggestionsView):

* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype.set suggestionHint):
(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._showSuggestionsView): Added.

(WI.SpreadsheetTextField.prototype._reAttachSuggestionHint):
Drive-by: abstract out repeating code into a private method.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239934 => 239935)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 21:01:43 UTC (rev 239934)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 21:07:57 UTC (rev 239935)
@@ -1,3 +1,33 @@
+2019-01-14  Nikita Vasilyev  
+
+Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover
+https://bugs.webkit.org/show_bug.cgi?id=193098
+
+
+Reviewed by Devin Rousso.
+
+Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar.
+Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may
+move from wrapping text.
+
+* UserInterface/Views/CompletionSuggestionsView.js:
+(WI.CompletionSuggestionsView.prototype.hide):
+(WI.CompletionSuggestionsView.prototype.show):
+(WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed.
+(WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added.
+(WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added.
+(WI.CompletionSuggestionsView):
+
+* UserInterface/Views/SpreadsheetTextField.js:
+(WI.SpreadsheetTextField.prototype.set suggestionHint):
+(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
+(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
+(WI.SpreadsheetTextField.prototype._updateCompletions):
+(WI.SpreadsheetTextField.prototype._showSuggestionsView): Added.
+
+(WI.SpreadsheetTextField.prototype._reAttachSuggestionHint):
+Drive-by: abstract out repeating code into a private method.
+
 2019-01-14  Devin Rousso  
 
 Web Inspector: Settings: group titles should vertically align with the first editor


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js (239934 => 239935)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js	2019-01-14 21:01:43 UTC (rev 239934)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js	2019-01-14 21:07:57 UTC (rev 239935)
@@ -33,7 +33,7 @@
 this._preventBlur = preventBlur || false;
 
 this._selectedIndex = NaN;
-this._anchorBounds = null;
+this._moveIntervalIdentifier = null;
 
 this._element = document.createElement("div");
 this._element.classList.add("completion-suggestions", WI.Popover.IgnoreAutoDismissClassName);
@@ -112,6 +112,8 @@
 
 show(anchorBounds)
 {
+let scrollTop = this._containerElement.scrollTop;
+
 // Measure the container so we can know the intrinsic size of the items.
 this._containerElement.style.position = "absolute";
 document.body.appendChild(this._containerElement);
@@ -156,40 +158,30 @@
 this._element.style.height = height + "px";
 
 document.body.appendChild(this._element);
+
+if (scrollTop)
+this._containerElement.scrollTop = scrollTop;
 }
 
-showUntilAnchorMoves(getAnchorBounds)
+hide()
 {
-this._anchorBounds = getAnchorBounds();
-if (!this._anchorBounds) {
-this.hide();
-return;
-

[webkit-changes] [239934] trunk/Source/WebKit

2019-01-14 Thread mrajca

Title: [239934] trunk/Source/WebKit








Revision 239934
Author mra...@apple.com
Date 2019-01-14 13:01:43 -0800 (Mon, 14 Jan 2019)


Log Message
Expose preference for site-specific quirks on iOS
https://bugs.webkit.org/show_bug.cgi?id=193353

Reviewed by Dean Jackson.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setNeedsSiteSpecificQuirks:]):
(-[WKPreferences _needsSiteSpecificQuirks]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239933 => 239934)

--- trunk/Source/WebKit/ChangeLog	2019-01-14 20:27:17 UTC (rev 239933)
+++ trunk/Source/WebKit/ChangeLog	2019-01-14 21:01:43 UTC (rev 239934)
@@ -1,3 +1,15 @@
+2019-01-11  Matt Rajca  
+
+Expose preference for site-specific quirks on iOS
+https://bugs.webkit.org/show_bug.cgi?id=193353
+
+Reviewed by Dean Jackson.
+
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _setNeedsSiteSpecificQuirks:]):
+(-[WKPreferences _needsSiteSpecificQuirks]):
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
 2019-01-14  Wenson Hsieh  
 
 [iOS] Expose SPI to access the current sentence boundary and selection state


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (239933 => 239934)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2019-01-14 20:27:17 UTC (rev 239933)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2019-01-14 21:01:43 UTC (rev 239934)
@@ -829,6 +829,16 @@
 return _preferences->shouldIgnoreMetaViewport();
 }
 
+- (void)_setNeedsSiteSpecificQuirks:(BOOL)enabled
+{
+_preferences->setNeedsSiteSpecificQuirks(enabled);
+}
+
+- (BOOL)_needsSiteSpecificQuirks
+{
+return _preferences->needsSiteSpecificQuirks();
+}
+
 #if PLATFORM(MAC)
 - (void)_setJavaEnabledForLocalFiles:(BOOL)enabled
 {
@@ -870,16 +880,6 @@
 return _preferences->defaultTextEncodingName();
 }
 
-- (void)_setNeedsSiteSpecificQuirks:(BOOL)enabled
-{
-_preferences->setNeedsSiteSpecificQuirks(enabled);
-}
-
-- (BOOL)_needsSiteSpecificQuirks
-{
-return _preferences->needsSiteSpecificQuirks();
-}
-
 - (void)_setAuthorAndUserStylesEnabled:(BOOL)enabled
 {
 _preferences->setAuthorAndUserStylesEnabled(enabled);


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (239933 => 239934)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2019-01-14 20:27:17 UTC (rev 239933)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2019-01-14 21:01:43 UTC (rev 239934)
@@ -151,6 +151,7 @@
 @property (nonatomic, setter=_setVideoQualityIncludesDisplayCompositingEnabled:) BOOL _videoQualityIncludesDisplayCompositingEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setWebAnimationsCSSIntegrationEnabled:) BOOL _webAnimationsCSSIntegrationEnabled WK_API_AVAILABLE(macosx(10.14), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setDeviceOrientationEventEnabled:) BOOL _deviceOrientationEventEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+@property (nonatomic, setter=_setNeedsSiteSpecificQuirks:) BOOL _needsSiteSpecificQuirks WK_API_AVAILABLE(macosx(10.13.4), ios(WK_IOS_TBA));
 
 #if !TARGET_OS_IPHONE
 @property (nonatomic, setter=_setWebGLEnabled:) BOOL _webGLEnabled WK_API_AVAILABLE(macosx(10.13.4));
@@ -158,7 +159,6 @@
 @property (nonatomic, setter=_setCanvasUsesAcceleratedDrawing:) BOOL _canvasUsesAcceleratedDrawing WK_API_AVAILABLE(macosx(10.13.4));
 @property (nonatomic, setter=_setAcceleratedCompositingEnabled:) BOOL _acceleratedCompositingEnabled WK_API_AVAILABLE(macosx(10.13.4));
 @property (nonatomic, setter=_setDefaultTextEncodingName:) NSString *_defaultTextEncodingName WK_API_AVAILABLE(macosx(10.13.4));
-@property (nonatomic, setter=_setNeedsSiteSpecificQuirks:) BOOL _needsSiteSpecificQuirks WK_API_AVAILABLE(macosx(10.13.4));
 @property (nonatomic, setter=_setAuthorAndUserStylesEnabled:) BOOL _authorAndUserStylesEnabled WK_API_AVAILABLE(macosx(10.13.4));
 @property (nonatomic, setter=_setDOMTimersThrottlingEnabled:) BOOL _domTimersThrottlingEnabled WK_API_AVAILABLE(macosx(10.13.4));
 @property (nonatomic, setter=_setWebArchiveDebugModeEnabled:) BOOL _webArchiveDebugModeEnabled WK_API_AVAILABLE(macosx(10.13.4));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239933] trunk/Source/JavaScriptCore

2019-01-14 Thread keith_miller

Title: [239933] trunk/Source/_javascript_Core








Revision 239933
Author keith_mil...@apple.com
Date 2019-01-14 12:27:17 -0800 (Mon, 14 Jan 2019)


Log Message
JSC should have a module loader API
https://bugs.webkit.org/show_bug.cgi?id=191121

Reviewed by Michael Saboff.

This patch adds a new delegate to JSContext that is called to fetch
any resolved module. The resolution of a module identifier is computed
as if it were a URL on the web with the caveat that it must be a file URL.

A new class JSScript has also been added that is similar to JSScriptRef.
Right now all JSScripts are copied into memory. In the future we should
mmap the provided file into memory so the OS can evict it to disk under
pressure. Additionally, the API does not make use of the code signing path
nor the bytecode caching path, which we will add in subsequent patches.

Lastly, a couple of new convenience methods have been added. C API
conversion, can now toRef a JSValue with just a vm rather than
requiring an ExecState. Secondly, there is now a call wrapper that
does not require CallData and CallType since many places don't
care about this.

* API/APICast.h:
(toRef):
* API/JSAPIGlobalObject.cpp: Copied from Source/_javascript_Core/API/JSVirtualMachineInternal.h.
* API/JSAPIGlobalObject.h: Added.
(JSC::JSAPIGlobalObject::create):
(JSC::JSAPIGlobalObject::createStructure):
(JSC::JSAPIGlobalObject::JSAPIGlobalObject):
* API/JSAPIGlobalObject.mm: Added.
(JSC::JSAPIGlobalObject::moduleLoaderResolve):
(JSC::JSAPIGlobalObject::moduleLoaderImportModule):
(JSC::JSAPIGlobalObject::moduleLoaderFetch):
(JSC::JSAPIGlobalObject::moduleLoaderCreateImportMetaProperties):
* API/JSAPIValueWrapper.h:
(JSC::jsAPIValueWrapper): Deleted.
* API/JSContext.h:
* API/JSContext.mm:
(-[JSContext moduleLoaderDelegate]):
(-[JSContext setModuleLoaderDelegate:]):
* API/JSContextInternal.h:
* API/JSContextPrivate.h:
* API/JSContextRef.cpp:
(JSGlobalContextCreateInGroup):
* API/JSScript.h: Added.
* API/JSScript.mm: Added.
(+[JSScript scriptWithSource:inVirtualMachine:]):
(fillBufferWithContentsOfFile):
(+[JSScript scriptFromUTF8File:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
(getJSScriptSourceCode):
* API/JSScriptInternal.h: Copied from Source/_javascript_Core/API/JSVirtualMachineInternal.h.
* API/JSValueInternal.h:
* API/JSVirtualMachineInternal.h:
* API/tests/testapi.mm:
(+[JSContextFetchDelegate contextWithBlockForFetch:]):
(-[JSContextFetchDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):
(checkModuleCodeRan):
(checkModuleWasRejected):
(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testLoaderRejectsNilScriptURL):
(testLoaderRejectsFailedFetch):
(testImportModuleTwice):
(+[JSContextFileLoaderDelegate newContext]):
(resolvePathToScripts):
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):
(testLoadBasicFile):
(testObjectiveCAPI):
* API/tests/testapiScripts/basic.js: Copied from Source/_javascript_Core/API/JSVirtualMachineInternal.h.
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* SourcesCocoa.txt:
* config.h:
* postprocess-headers.sh:
* runtime/CallData.cpp:
(JSC::call):
* runtime/CallData.h:
* runtime/Completion.cpp:
(JSC::loadAndEvaluateModule):
* runtime/Completion.h:
* runtime/JSCast.h:
(JSC::jsSecureCast):
* runtime/JSGlobalObject.cpp:
(JSC::createProxyProperty):

Modified Paths

trunk/Source/_javascript_Core/API/APICast.h
trunk/Source/_javascript_Core/API/JSAPIValueWrapper.h
trunk/Source/_javascript_Core/API/JSContext.h
trunk/Source/_javascript_Core/API/JSContext.mm
trunk/Source/_javascript_Core/API/JSContextInternal.h
trunk/Source/_javascript_Core/API/JSContextPrivate.h
trunk/Source/_javascript_Core/API/JSContextRef.cpp
trunk/Source/_javascript_Core/API/JSValueInternal.h
trunk/Source/_javascript_Core/API/JSVirtualMachineInternal.h
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/SourcesCocoa.txt
trunk/Source/_javascript_Core/config.h
trunk/Source/_javascript_Core/postprocess-headers.sh
trunk/Source/_javascript_Core/runtime/CallData.cpp
trunk/Source/_javascript_Core/runtime/CallData.h
trunk/Source/_javascript_Core/runtime/Completion.cpp
trunk/Source/_javascript_Core/runtime/Completion.h
trunk/Source/_javascript_Core/runtime/JSCast.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp


Added Paths

trunk/Source/_javascript_Core/API/JSAPIGlobalObject.cpp
trunk/Source/_javascript_Core/API/JSAPIGlobalObject.h
trunk/Source/_javascript_Core/API/JSAPIGlobalObject.mm
trunk/Source/_javascript_Core/API/JSScript.h
trunk/Source/_javascript_Core/API/JSScript.mm
trunk/Source/_javascript_Core/API/JSScriptInternal.h
trunk/Source/_javascript_Core/API/tests/testapiScripts/

[webkit-changes] [239932] trunk/Source/WebInspectorUI

2019-01-14 Thread drousso

Title: [239932] trunk/Source/WebInspectorUI








Revision 239932
Author drou...@apple.com
Date 2019-01-14 12:17:24 -0800 (Mon, 14 Jan 2019)


Log Message
Web Inspector: Settings: group titles should vertically align with the first editor
https://bugs.webkit.org/show_bug.cgi?id=193391

Reviewed by Dean Jackson.

* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239931 => 239932)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 20:09:58 UTC (rev 239931)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-14 20:17:24 UTC (rev 239932)
@@ -1,3 +1,17 @@
+2019-01-14  Devin Rousso  
+
+Web Inspector: Settings: group titles should vertically align with the first editor
+https://bugs.webkit.org/show_bug.cgi?id=193391
+
+Reviewed by Dean Jackson.
+
+* UserInterface/Views/SettingsTabContentView.css:
+(.content-view.settings > .settings-view > .container):
+(.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
+(.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
+(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
+(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
+
 2019-01-11  Matt Baker  
 
 Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css (239931 => 239932)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css	2019-01-14 20:09:58 UTC (rev 239931)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css	2019-01-14 20:17:24 UTC (rev 239932)
@@ -55,7 +55,6 @@
 
 .content-view.settings > .settings-view > .container {
 display: flex;
-align-items: center;
 margin-top: 1em;
 font-size: 13px;
 }
@@ -85,6 +84,14 @@
 flex-direction: column;
 }
 
+.content-view.settings > .settings-view > .container > .editor-group > .editor {
+--settings-editor-child-margin-top: 0;
+}
+
+.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > * {
+margin-top: var(--settings-editor-child-margin-top);
+}
+
 .content-view.settings > .settings-view > .container > .editor-group > .editor input {
 font-size: inherit;
 }
@@ -103,16 +110,18 @@
 font-size: 16px;
 
 /* Vertically align  with the group title text. */
-margin-top: 0;
+--settings-editor-child-margin-top: -2px;
 }
 
 .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"] {
-/* Vertically align  with the group title text. */
-margin-top: -1px;
-
 max-width: 48px;
+padding-top: 0;
+padding-bottom: 0;
 text-align: end;
+vertical-align: 1px;
 
+/* Vertically align  with the group title text. */
+--settings-editor-child-margin-top: -2px;
 --settings-input-number-margin-start: 2px;
 --settings-input-number-margin-end: 5px;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239931] trunk

2019-01-14 Thread wenson_hsieh

Title: [239931] trunk








Revision 239931
Author wenson_hs...@apple.com
Date 2019-01-14 12:09:58 -0800 (Mon, 14 Jan 2019)


Log Message
[iOS] Expose SPI to access the current sentence boundary and selection state
https://bugs.webkit.org/show_bug.cgi?id=193398


Reviewed by Dean Jackson.

Source/WebKit:

Expose SPI on WKWebView for internal clients to grab information about attributes at the current selection; so
far, this only includes whether the selection is a caret or a range, and whether or not the start of the
selection is at the start of a new sentence.

Test: EditorStateTests.ObserveSelectionAttributeChanges

* Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
* Shared/EditorState.h:

Add a new bit in EditorState on iOS to compute whether or not the start of the selection is at the start of a
new sentence. This is computed and set when sending post-layout data in `WebPageIOS.mm`.

* UIProcess/API/Cocoa/WKWebView.mm:
(selectionAttributes):
(-[WKWebView _didChangeEditorState]):
(-[WKWebView _selectionAttributes]):

Make the new SPI property support KVO by invoking `-willChangeValueForKey:` and `-didChangeValueForKey:`
whenever the selection attributes change.

* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState const):

Tools:

Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
expected.

* TestWebKitAPI/EditingTestHarness.h:
* TestWebKitAPI/EditingTestHarness.mm:
(-[EditingTestHarness moveBackward]):
(-[EditingTestHarness moveForward]):
(-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):

Add a couple of new helper methods on EditingTestHarness.

* TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
(-[SelectionChangeObserver initWithWebView:]):
(-[SelectionChangeObserver webView]):
(-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
(-[SelectionChangeObserver currentSelectionAttributes]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EditorState.cpp
trunk/Source/WebKit/Shared/EditorState.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/EditingTestHarness.h
trunk/Tools/TestWebKitAPI/EditingTestHarness.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239930 => 239931)

--- trunk/Source/WebKit/ChangeLog	2019-01-14 19:21:50 UTC (rev 239930)
+++ trunk/Source/WebKit/ChangeLog	2019-01-14 20:09:58 UTC (rev 239931)
@@ -1,3 +1,37 @@
+2019-01-14  Wenson Hsieh  
+
+[iOS] Expose SPI to access the current sentence boundary and selection state
+https://bugs.webkit.org/show_bug.cgi?id=193398
+
+
+Reviewed by Dean Jackson.
+
+Expose SPI on WKWebView for internal clients to grab information about attributes at the current selection; so
+far, this only includes whether the selection is a caret or a range, and whether or not the start of the
+selection is at the start of a new sentence.
+
+Test: EditorStateTests.ObserveSelectionAttributeChanges
+
+* Shared/EditorState.cpp:
+(WebKit::EditorState::PostLayoutData::encode const):
+(WebKit::EditorState::PostLayoutData::decode):
+* Shared/EditorState.h:
+
+Add a new bit in EditorState on iOS to compute whether or not the start of the selection is at the start of a
+new sentence. This is computed and set when sending post-layout data in `WebPageIOS.mm`.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(selectionAttributes):
+(-[WKWebView _didChangeEditorState]):
+(-[WKWebView _selectionAttributes]):
+
+Make the new SPI property support KVO by invoking `-willChangeValueForKey:` and `-didChangeValueForKey:`
+whenever the selection attributes change.
+
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::platformEditorState const):
+
 2019-01-14  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.3 release


Modified: trunk/Source/WebKit/Shared/EditorState.cpp (239930 => 239931)

--- trunk/Source/WebKit/Shared/EditorState.cpp	2019-01-14 19:21:50 UTC (rev 239930)
+++ trunk/Source/WebKit/Shared/EditorState.cpp	2019-01-14 20:09:58 UTC (rev 239931)
@@ -132,6 +132,7 @@
 encoder << hasPlainText;
 encoder << elementIsTransparentOrFullyClipped;
 encoder << caretColor;
+encoder << atStartOfSentence;
 #endif
 #if PLATFORM(MAC)
 encoder << candidateRequestStartPosition;
@@ -191,6 +192,8 @@

[webkit-changes] [239928] branches/safari-607-branch/Tools

2019-01-14 Thread ryanhaddad

Title: [239928] branches/safari-607-branch/Tools








Revision 239928
Author ryanhad...@apple.com
Date 2019-01-14 10:00:22 -0800 (Mon, 14 Jan 2019)


Log Message
Cherry-pick r239878. rdar://problem/47255372

webkitpy: Support alternate simctl device list output
https://bugs.webkit.org/show_bug.cgi?id=193362


Reviewed by Lucas Forschler.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.populate_available_devices):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-607-branch/Tools/ChangeLog
branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py




Diff

Modified: branches/safari-607-branch/Tools/ChangeLog (239927 => 239928)

--- branches/safari-607-branch/Tools/ChangeLog	2019-01-14 15:51:41 UTC (rev 239927)
+++ branches/safari-607-branch/Tools/ChangeLog	2019-01-14 18:00:22 UTC (rev 239928)
@@ -1,3 +1,30 @@
+2019-01-14  Ryan Haddad  
+
+Cherry-pick r239878. rdar://problem/47255372
+
+webkitpy: Support alternate simctl device list output
+https://bugs.webkit.org/show_bug.cgi?id=193362
+
+
+Reviewed by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.populate_available_devices):
+
+
+git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-11  Jonathan Bedard  
+
+webkitpy: Support alternate simctl device list output
+https://bugs.webkit.org/show_bug.cgi?id=193362
+
+
+Reviewed by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.populate_available_devices):
+
 2019-01-09  Kocsen Chung  
 
 Cherry-pick r239758. rdar://problem/47158613


Modified: branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py (239927 => 239928)

--- branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 15:51:41 UTC (rev 239927)
+++ branches/safari-607-branch/Tools/Scripts/webkitpy/xcode/simulated_device.py	2019-01-14 18:00:22 UTC (rev 239928)
@@ -131,7 +131,17 @@
 SimulatedDeviceManager.AVAILABLE_RUNTIMES = SimulatedDeviceManager._create_runtimes(simctl_json['runtimes'])
 
 for runtime in SimulatedDeviceManager.AVAILABLE_RUNTIMES:
-for device_json in simctl_json['devices'][runtime.name]:
+# Needed for 
+devices = []
+if isinstance(simctl_json['devices'], list):
+for devices_for_runtime in simctl_json['devices']:
+if devices_for_runtime['name'] == runtime.name:
+devices = devices_for_runtime['devices']
+break
+else:
+devices = simctl_json['devices'][runtime.name]
+
+for device_json in devices:
 device = SimulatedDeviceManager._create_device_with_runtime(host, runtime, device_json)
 if not device:
 continue






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239926] trunk

2019-01-14 Thread zalan

Title: [239926] trunk








Revision 239926
Author za...@apple.com
Date 2019-01-14 07:42:21 -0800 (Mon, 14 Jan 2019)


Log Message
[LFC][BFC] Add basic box-sizing support.
https://bugs.webkit.org/show_bug.cgi?id=193392

Reviewed by Antti Koivisto.

Source/WebCore:

No min/max support yet.

Test: fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
* page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt: Added.
* fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt


Added Paths

trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt
trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239925 => 239926)

--- trunk/LayoutTests/ChangeLog	2019-01-14 15:22:43 UTC (rev 239925)
+++ trunk/LayoutTests/ChangeLog	2019-01-14 15:42:21 UTC (rev 239926)
@@ -1,3 +1,13 @@
+2019-01-14  Zalan Bujtas  
+
+[LFC][BFC] Add basic box-sizing support.
+https://bugs.webkit.org/show_bug.cgi?id=193392
+
+Reviewed by Antti Koivisto.
+
+* fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt: Added.
+* fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html: Added.
+
 2019-01-14  Zan Dobersek  
 
 Unreviewed WPE gardening. Updating baselines for failures that in


Added: trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt (0 => 239926)

--- trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt	2019-01-14 15:42:21 UTC (rev 239926)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,10) size 784x580
+  RenderBlock {DIV} at (10,0) size 20x20 [border: (2px solid #00)]
+  RenderBlock {DIV} at (10,30) size 20x20 [border: (2px solid #00)]
+layer at (18,80) size 20x20
+  RenderBlock (positioned) {DIV} at (18,80) size 20x20 [border: (2px solid #00)]
+layer at (48,80) size 20x20
+  RenderBlock (positioned) {DIV} at (48,80) size 20x20 [border: (2px solid #00)]


Added: trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html (0 => 239926)

--- trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html	(rev 0)
+++ trunk/LayoutTests/fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html	2019-01-14 15:42:21 UTC (rev 239926)
@@ -0,0 +1,12 @@
+
+div {
+  border: 2px solid black;
+  padding: 4px;
+  -webkit-box-sizing: border-box;
+  margin: 10px;
+}
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (239925 => 239926)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 15:22:43 UTC (rev 239925)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 15:42:21 UTC (rev 239926)
@@ -1,3 +1,23 @@
+2019-01-14  Zalan Bujtas  
+
+[LFC][BFC] Add basic box-sizing support.
+https://bugs.webkit.org/show_bug.cgi?id=193392
+
+Reviewed by Antti Koivisto.
+
+No min/max support yet.
+
+Test: fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html
+
+* layout/FormattingContextGeometry.cpp:
+(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
+(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
+* layout/blockformatting/BlockFormattingContextGeometry.cpp:
+(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
+(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
+* page/FrameViewLayoutContext.cpp:
+(WebCore::layoutUsingFormattingContext):
+
 2019-01-14  Thibault Saunier  
 
 [GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations


Modified:

[webkit-changes] [239925] trunk/Source/WebCore

Title: [239925] trunk/Source/WebCore








Revision 239925
Author commit-qu...@webkit.org
Date 2019-01-14 07:22:43 -0800 (Mon, 14 Jan 2019)


Log Message
[GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
https://bugs.webkit.org/show_bug.cgi?id=193397

This was necessary but wasn't done.

Patch by Thibault Saunier  on 2019-01-14
Reviewed by Philippe Normand.

No test required as this fixes a regression in all WebRTC tests when built in debug mode.

* platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (239924 => 239925)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 15:22:43 UTC (rev 239925)
@@ -1,3 +1,17 @@
+2019-01-14  Thibault Saunier  
+
+[GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
+https://bugs.webkit.org/show_bug.cgi?id=193397
+
+This was necessary but wasn't done.
+
+Reviewed by Philippe Normand.
+
+No test required as this fixes a regression in all WebRTC tests when built in debug mode.
+
+* platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
+* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
+
 2019-01-14  Zan Dobersek  
 
 Unreviewed WPE debug build fix after r239921.


Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h (239924 => 239925)

--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h	2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h	2019-01-14 15:22:43 UTC (rev 239925)
@@ -22,6 +22,7 @@
 #pragma once
 
 #if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
+#include "CaptureDevice.h"
 #include "GStreamerAudioCapturer.h"
 #include "GStreamerCaptureDevice.h"
 #include "RealtimeMediaSource.h"
@@ -45,6 +46,7 @@
 virtual ~GStreamerAudioCaptureSource();
 void startProducingData() override;
 void stopProducingData() override;
+CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Microphone; }
 
 mutable Optional m_capabilities;
 mutable Optional m_currentSettings;


Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h (239924 => 239925)

--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h	2019-01-14 15:09:56 UTC (rev 239924)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h	2019-01-14 15:22:43 UTC (rev 239925)
@@ -22,6 +22,7 @@
 #pragma once
 
 #if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
+#include "CaptureDevice.h"
 #include "GStreamerVideoCapturer.h"
 #include "RealtimeVideoSource.h"
 
@@ -52,6 +53,7 @@
 
 mutable Optional m_capabilities;
 mutable Optional m_currentSettings;
+CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Camera; }
 
 private:
 static GstFlowReturn newSampleCallback(GstElement*, GStreamerVideoCaptureSource*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239922] trunk/Tools

2019-01-14 Thread cturner

Title: [239922] trunk/Tools








Revision 239922
Author ctur...@igalia.com
Date 2019-01-14 04:41:01 -0800 (Mon, 14 Jan 2019)


Log Message
[WPE] API test gardening
https://bugs.webkit.org/show_bug.cgi?id=193319

Reviewed by Michael Catanzaro.

* TestWebKitAPI/glib/TestExpectations.json: Remove some now
passing tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (239921 => 239922)

--- trunk/Tools/ChangeLog	2019-01-14 12:31:13 UTC (rev 239921)
+++ trunk/Tools/ChangeLog	2019-01-14 12:41:01 UTC (rev 239922)
@@ -1,5 +1,15 @@
 2019-01-14  Charlie Turner  
 
+[WPE] API test gardening
+https://bugs.webkit.org/show_bug.cgi?id=193319
+
+Reviewed by Michael Catanzaro.
+
+* TestWebKitAPI/glib/TestExpectations.json: Remove some now
+passing tests.
+
+2019-01-14  Charlie Turner  
+
 [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
 https://bugs.webkit.org/show_bug.cgi?id=192977
 


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (239921 => 239922)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2019-01-14 12:31:13 UTC (rev 239921)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2019-01-14 12:41:01 UTC (rev 239922)
@@ -12,9 +12,6 @@
 },
 "/webkit/WebKitWebView/audio-usermedia-permission-request": {
 "expected": {"gtk": {"status": ["TIMEOUT"], "bug": "webkit.org/b/158257"}}
-},
-"/webkit/WebKitWebView/disallow-modal-dialogs": {
-"expected": {"wpe": {"status": ["FAIL"]}}
 }
 }
 },
@@ -54,9 +51,6 @@
 "/webkit/WebKitWebsiteData/appcache": {
 "expected": {"all": {"status": ["PASS", "FAIL"], "bug": "webkit.org/b/188117"}}
 },
-"/webkit/WebKitWebsiteData/configuration": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-},
 "/webkit/WebKitWebsiteData/storage": {
 "expected": {"wpe": {"status": ["PASS", "FAIL"]}}
 },
@@ -75,16 +69,6 @@
 }
 }
 },
-"TestWebKitWebView": {
-"subtests": {
-"/webkit/WebKitWebView/backend": {
-"expected": {"wpe": {"status": ["CRASH"], "bug": "webkit.org/b/179884"}}
-},
-"/webkit/WebKitWebView/run-_javascript_": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
 "TestInspectorServer": {
 "expected": {"all": {"slow": true}},
 "subtests": {
@@ -176,22 +160,6 @@
 }
 }
 },
-"TestLoaderClient": {
-"subtests": {
-"/webkit/WebKitWebPage/get-uri": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-},
-"/webkit/WebKitURIRequest/http-method": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-},
-"/webkit/WebKitWebView/is-loading": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-},
-"/webkit/WebKitWebView/active-uri": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
 "TestResources": {
 "subtests": {
 "/webkit/WebKitWebResource/get-data-error": {
@@ -199,37 +167,6 @@
 }
 }
 },
-"TestAuthentication": {
-"subtests": {
-"/webkit/Authentication/authentication-no-credential": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
-"TestDownloads": {
-"subtests": {
-"/webkit/Downloads/policy-decision-download": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
-"TestConsoleMessage": {
-"subtests": {
-"/webkit/WebKitConsoleMessage/js-exception": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
-"TestWebKitUserContentManager": {
-"subtests": {
-"/webkit/WebKitUserContentManager/injected-script": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-},
-"/webkit/WebKitUserContentManager/script-message-received": {
-"expected": {"wpe": {"status": ["FAIL"]}}
-}
-}
-},
 "TestJSC": {
 "subtests": {
 "/jsc/vm": {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239921] trunk

2019-01-14 Thread cturner

Title: [239921] trunk








Revision 239921
Author ctur...@igalia.com
Date 2019-01-14 04:31:13 -0800 (Mon, 14 Jan 2019)


Log Message
[GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
https://bugs.webkit.org/show_bug.cgi?id=192977

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Add a utility method on GstMappedBuffer to return a SharedBuffer
view over the mapped data with no copies.

This patch also introduces a new gstreamer port API test
directory, and includes some tests for GstMappedBuffer.

New tests in the API section.

* platform/SharedBuffer.cpp: Add a new overload for
GstMappedBuffer that allows sharing the mapped GStreamer buffers
with zero copies.
(WebCore::SharedBuffer::create):
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::DataSegment::data const):
(WebCore::SharedBuffer::DataSegment::size const):
* platform/SharedBuffer.h:
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcAllocateBuffersAndRenderAudio): Update to new
API.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::GstMappedBuffer::createSharedBuffer): Return a shared
buffer sharing this mapped buffer. The buffer must be shareable to
use this method.
* platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedBuffer::create): Make GstMappedBuffer RefCounted
(WebCore::GstMappedBuffer::~GstMappedBuffer):
(WebCore::GstMappedBuffer::data):
(WebCore::GstMappedBuffer::data const):
(WebCore::GstMappedBuffer::size const):
(WebCore::GstMappedBuffer::isSharable const): New predicate to
check whether this buffer can be shared (i.e., is not writable)
(WebCore::GstMappedBuffer::GstMappedBuffer):
(WebCore::GstMappedBuffer::operator bool const): Deleted.
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
Update to use new API.
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
(WebCore::InitData::InitData): Ditto.
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorFindAndSetKey): Ditto.
(webKitMediaClearKeyDecryptorDecrypt): Ditto.
* platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp:
(WebCore::WrappedMockRealtimeAudioSource::render): Ditto.
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData): Ditto.
* platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingVideoSourceLibWebRTC::createBlackFrame): Ditto.
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::Fragmentize): Ditto.

Tools:

* TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
* TestWebKitAPI/PlatformWPE.cmake: Ditto.
* TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
(TestWebKitAPI::GStreamerTest::SetUp):
(TestWebKitAPI::GStreamerTest::TearDown):
* TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
* TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/PlatformWPE.cmake


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebCore/gstreamer/
trunk/Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h
trunk/Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239920 => 239921)

--- trunk/Source/WebCore/ChangeLog	2019-01-14 10:59:06 UTC (rev 239920)
+++ trunk/Source/WebCore/ChangeLog	2019-01-14 12:31:13 UTC (rev 239921)
@@ -1,3 +1,60 @@
+2019-01-14  Charlie Turner  
+
+[GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
+https://bugs.webkit.org/show_bug.cgi?id=192977
+
+Reviewed by Carlos Garcia Campos.
+
+Add a utility method on GstMappedBuffer to return a SharedBuffer
+

[webkit-changes] [239920] trunk/Tools

2019-01-14 Thread cturner

Title: [239920] trunk/Tools








Revision 239920
Author ctur...@igalia.com
Date 2019-01-14 02:59:06 -0800 (Mon, 14 Jan 2019)


Log Message
[WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
https://bugs.webkit.org/show_bug.cgi?id=193332

Reviewed by Michael Catanzaro.

* TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
defined as a char16_t, which changed in ICU 59, the
StringTypeAdapter overload catches casts to
unsigned short. This test is relying on the behaviour that
UChar=unsigned short, which doesn't hold across platforms and ICU
library versions. The full fix would be a special syntax for
literal characters so that these ambiguities do not arise. That
work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp




Diff

Modified: trunk/Tools/ChangeLog (239919 => 239920)

--- trunk/Tools/ChangeLog	2019-01-14 10:32:03 UTC (rev 239919)
+++ trunk/Tools/ChangeLog	2019-01-14 10:59:06 UTC (rev 239920)
@@ -1,3 +1,20 @@
+2019-01-14  Charlie Turner  
+
+[WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
+https://bugs.webkit.org/show_bug.cgi?id=193332
+
+Reviewed by Michael Catanzaro.
+
+* TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
+defined as a char16_t, which changed in ICU 59, the
+StringTypeAdapter overload catches casts to
+unsigned short. This test is relying on the behaviour that
+UChar=unsigned short, which doesn't hold across platforms and ICU
+library versions. The full fix would be a special syntax for
+literal characters so that these ambiguities do not arise. That
+work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
+(TestWebKitAPI::TEST):
+
 2019-01-14  Carlos Garcia Campos  
 
 Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp (239919 => 239920)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp	2019-01-14 10:32:03 UTC (rev 239919)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp	2019-01-14 10:59:06 UTC (rev 239920)
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace TestWebKitAPI {
 
@@ -81,7 +82,7 @@
 EXPECT_EQ("hello 0 world", makeString("hello ", 0u , " world"));
 
 EXPECT_EQ("hello 42 world", makeString("hello ", static_cast(42) , " world"));
-#if PLATFORM(WIN)
+#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59
 EXPECT_EQ("hello 42 world", makeString("hello ", static_cast(42) , " world"));
 #else
 EXPECT_EQ("hello * world", makeString("hello ", static_cast(42) , " world")); // Treated as a character.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239919] trunk