[webkit-changes] [240199] trunk

[rniwa]

Title: [240199] trunk








Revision 240199
Author rn...@webkit.org
Date 2019-01-18 23:53:14 -0800 (Fri, 18 Jan 2019)


Log Message
iOS: Updating input mode should update the software keyboard
https://bugs.webkit.org/show_bug.cgi?id=193565


Reviewed by Wenson Hsieh.

Source/WebCore:

Let the chrome client know that the focused element's inputmode had changed.

Test: fast/forms/ios/inputmode-none-removed.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
* page/ChromeClient.h:

Source/WebKit:

Update the software keyboard when the inputmode content attribute on the focused element had been mutated.

* Scripts/webkit/messages.py:
* Shared/WebCoreArgumentCoders.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::focusedElementDidChangeInputMode):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didUpdateInputMode:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::focusedElementDidChangeInputMode):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementDidChangeInputMode):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedElementDidChangeInputMode):
* WebProcess/WebPage/WebPage.h:

LayoutTests:

Added a regression test for removing inputmode content attribute with the value of "none".

The test methodology is different between testRunner and in-browser since we don't force
software keyboard while running layout tests inside simulator which can elimiate
the visual viewport difference inside the test runner, and in-browser testing obviously
doesn't have access to the internal keyboard metrics.

* fast/forms/ios/inputmode-none-removed-expected.txt: Added.
* fast/forms/ios/inputmode-none-removed.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h


Added Paths

trunk/LayoutTests/fast/forms/ios/inputmode-none-removed-expected.txt
trunk/LayoutTests/fast/forms/ios/inputmode-none-removed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (240198 => 240199)

--- trunk/LayoutTests/ChangeLog	2019-01-19 05:42:58 UTC (rev 240198)
+++ trunk/LayoutTests/ChangeLog	2019-01-19 07:53:14 UTC (rev 240199)
@@ -1,3 +1,21 @@
+2019-01-18  Ryosuke Niwa  
+
+iOS: Updating input mode should update the software keyboard
+https://bugs.webkit.org/show_bug.cgi?id=193565
+
+
+Reviewed by Wenson Hsieh.
+
+Added a regression test for removing inputmode content attribute with the value of "none".
+
+The test methodology is different between testRunner and in-browser since we don't force
+software keyboard while running layout tests inside simulator which can elimiate
+the visual viewport difference inside the test runner, and in-browser testing obviously
+doesn't have access to the internal keyboard metrics.
+
+* fast/forms/ios/inputmode-none-removed-expected.txt: Added.
+* fast/forms/ios/inputmode-none-removed.html: Added.
+
 2019-01-18  Justin Fan  
 
 (WIP) [WebGPU] WebGPUProgrammablePassEncoder::setBindGroup prototype


Added: trunk/LayoutTests/fast/forms/ios/inputmode-none-removed-expected.txt (0 => 240199)

--- trunk/LayoutTests/fast/forms/ios/inputmode-none-removed-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/inputmode-none-removed-expected.txt	2019-01-19 07:53:14 UTC (rev 240199)
@@ -0,0 +1,16 @@
+This tests updating inputmode of an input element from "none" to "text". The software keyboard should be updated.
+To manually test, focus the input element below. The software keyboard should show up after 3 seconds
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Element has inputmode=none
+PASS keyboardRect.height is 0
+
+inputmode has been removed
+PASS keyboardRect.height > 0 is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+


Added: 

[webkit-changes] [240198] trunk/Source/WebKit

[timothy_horton]

Title: [240198] trunk/Source/WebKit








Revision 240198
Author timothy_hor...@apple.com
Date 2019-01-18 21:42:58 -0800 (Fri, 18 Jan 2019)


Log Message
Adjust WKDrawingView protocol method name
https://bugs.webkit.org/show_bug.cgi?id=193604

Reviewed by Wenson Hsieh.

* UIProcess/ios/WKDrawingView.mm:
(-[WKDrawingView canvasViewDrawingDidChange:]):
(-[WKDrawingView drawingDidChange:]): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (240197 => 240198)

--- trunk/Source/WebKit/ChangeLog	2019-01-19 05:28:24 UTC (rev 240197)
+++ trunk/Source/WebKit/ChangeLog	2019-01-19 05:42:58 UTC (rev 240198)
@@ -1,3 +1,14 @@
+2019-01-18  Tim Horton  
+
+Adjust WKDrawingView protocol method name
+https://bugs.webkit.org/show_bug.cgi?id=193604
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKDrawingView.mm:
+(-[WKDrawingView canvasViewDrawingDidChange:]):
+(-[WKDrawingView drawingDidChange:]): Deleted.
+
 2019-01-18  David Kilzer  
 
 [WebKit] Change Xcode folders to map to folders on disk


Modified: trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm (240197 => 240198)

--- trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm	2019-01-19 05:28:24 UTC (rev 240197)
+++ trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm	2019-01-19 05:42:58 UTC (rev 240198)
@@ -163,7 +163,7 @@
 [_pencilView setDrawing:drawing.get()];
 }
 
-- (void)drawingDidChange:(PKCanvasView *)canvasView
+- (void)canvasViewDrawingDidChange:(PKCanvasView *)canvasView
 {
 [self invalidateAttachment];
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240197] trunk/Source/WebKit

[ddkilzer]

Title: [240197] trunk/Source/WebKit








Revision 240197
Author ddkil...@apple.com
Date 2019-01-18 21:28:24 -0800 (Fri, 18 Jan 2019)


Log Message
[WebKit] Change Xcode folders to map to folders on disk

* WebKit.xcodeproj/project.pbxproj: Update these folders:
- Shared/Authentication
- Shared/Authentication/cocoa

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (240196 => 240197)

--- trunk/Source/WebKit/ChangeLog	2019-01-19 05:28:11 UTC (rev 240196)
+++ trunk/Source/WebKit/ChangeLog	2019-01-19 05:28:24 UTC (rev 240197)
@@ -1,3 +1,11 @@
+2019-01-18  David Kilzer  
+
+[WebKit] Change Xcode folders to map to folders on disk
+
+* WebKit.xcodeproj/project.pbxproj: Update these folders:
+- Shared/Authentication
+- Shared/Authentication/cocoa
+
 2019-01-18  Brian Burg  
 
 Automation.computeElementLayout should return visual viewport-aware coordinates


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (240196 => 240197)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2019-01-19 05:28:11 UTC (rev 240196)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2019-01-19 05:28:24 UTC (rev 240197)
@@ -3219,9 +3219,9 @@
 		518ACF1012B015F800B04B83 /* WKCredentialTypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKCredentialTypes.h; sourceTree = ""; };
 		518D2CAB12D5153B003BB93B /* WebBackForwardListItem.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebBackForwardListItem.cpp; sourceTree = ""; };
 		518D2CAC12D5153B003BB93B /* WebBackForwardListItem.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebBackForwardListItem.h; sourceTree = ""; };
-		518E8EF316B2091C00E91429 /* AuthenticationManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = AuthenticationManager.cpp; path = Authentication/AuthenticationManager.cpp; sourceTree = ""; };
-		518E8EF416B2091C00E91429 /* AuthenticationManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AuthenticationManager.h; path = Authentication/AuthenticationManager.h; sourceTree = ""; };
-		518E8EF516B2091C00E91429 /* AuthenticationManager.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = AuthenticationManager.messages.in; path = Authentication/AuthenticationManager.messages.in; sourceTree = ""; };
+		518E8EF316B2091C00E91429 /* AuthenticationManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AuthenticationManager.cpp; sourceTree = ""; };
+		518E8EF416B2091C00E91429 /* AuthenticationManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AuthenticationManager.h; sourceTree = ""; };
+		518E8EF516B2091C00E91429 /* AuthenticationManager.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = AuthenticationManager.messages.in; sourceTree = ""; };
 		51933DEB1965EB24008AC3EA /* MenuUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MenuUtilities.h; sourceTree = ""; };
 		51933DEC1965EB24008AC3EA /* MenuUtilities.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = MenuUtilities.mm; sourceTree = ""; };
 		5194B3861F192FB900FA4708 /* CookieStorageUtilsCF.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CookieStorageUtilsCF.h; sourceTree = ""; };
@@ -3359,8 +3359,8 @@
 		578DC2972155A0010074E815 /* LocalAuthenticationSoftLink.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = LocalAuthenticationSoftLink.h; sourceTree = ""; };
 		57AC8F4E217FEED90055438C /* HidConnection.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = HidConnection.h; sourceTree = ""; };
 		57AC8F4F217FEED90055438C /* HidConnection.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = HidConnection.mm; sourceTree = ""; };
-		57B4B45D20B504AB00D4AD79 /* AuthenticationManagerCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AuthenticationManagerCocoa.mm; path = Authentication/cocoa/AuthenticationManagerCocoa.mm; sourceTree = ""; };
-		57B4B45E20B504AB00D4AD79 /* ClientCertificateAuthenticationXPCConstants.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ClientCertificateAuthenticationXPCConstants.h; path = Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h; sourceTree = ""; };
+		57B4B45D20B504AB00D4AD79 /* AuthenticationManagerCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 

[webkit-changes] [240196] trunk/Source/WebCore/PAL

[ddkilzer]

Title: [240196] trunk/Source/WebCore/PAL








Revision 240196
Author ddkil...@apple.com
Date 2019-01-18 21:28:11 -0800 (Fri, 18 Jan 2019)


Log Message
[PAL] Change Xcode folders to map to folders on disk

Found by tidy-Xcode-project-file script (see Bug 188754).

* PAL.xcodeproj/project.pbxproj: Update these folders:
- pal/avfoundation
- pal/crypto/commoncrypto
- pal/ios

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (240195 => 240196)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-01-19 04:22:41 UTC (rev 240195)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-01-19 05:28:11 UTC (rev 240196)
@@ -1,5 +1,16 @@
 2019-01-18  David Kilzer  
 
+[PAL] Change Xcode folders to map to folders on disk
+
+Found by tidy-Xcode-project-file script (see Bug 188754).
+
+* PAL.xcodeproj/project.pbxproj: Update these folders:
+- pal/avfoundation
+- pal/crypto/commoncrypto
+- pal/ios
+
+2019-01-18  David Kilzer  
+
 Follow-up: Override the session configuration for cookieAcceptPolicy
 
 


Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (240195 => 240196)

--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2019-01-19 04:22:41 UTC (rev 240195)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2019-01-19 05:28:11 UTC (rev 240196)
@@ -171,8 +171,8 @@
 /* End PBXContainerItemProxy section */
 
 /* Begin PBXFileReference section */
-		0C00CFD11F68CE4600AAC26D /* MediaTimeAVFoundation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MediaTimeAVFoundation.cpp; path = avfoundation/MediaTimeAVFoundation.cpp; sourceTree = ""; };
-		0C00CFD21F68CE4600AAC26D /* MediaTimeAVFoundation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MediaTimeAVFoundation.h; path = avfoundation/MediaTimeAVFoundation.h; sourceTree = ""; };
+		0C00CFD11F68CE4600AAC26D /* MediaTimeAVFoundation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaTimeAVFoundation.cpp; sourceTree = ""; };
+		0C00CFD21F68CE4600AAC26D /* MediaTimeAVFoundation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaTimeAVFoundation.h; sourceTree = ""; };
 		0C2D9E721EEF5AF600DBC317 /* ExportMacros.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ExportMacros.h; sourceTree = ""; };
 		0C2DA0671F33CA8400DBC317 /* CFLocaleSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFLocaleSPI.h; sourceTree = ""; };
 		0C2DA0681F33CA8400DBC317 /* CFNetworkConnectionCacheSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFNetworkConnectionCacheSPI.h; sourceTree = ""; };
@@ -248,11 +248,11 @@
 		0C7785861F45130F00F4EBB6 /* QTKitSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QTKitSPI.h; sourceTree = ""; };
 		0C7785871F45130F00F4EBB6 /* QuickLookMacSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QuickLookMacSPI.h; sourceTree = ""; };
 		0C7785881F45130F00F4EBB6 /* TUCallSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TUCallSPI.h; sourceTree = ""; };
-		0CF99CA61F738436007EE793 /* CoreMediaSoftLink.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CoreMediaSoftLink.cpp; path = pal/cf/CoreMediaSoftLink.cpp; sourceTree = SOURCE_ROOT; };
-		0CF99CA71F738437007EE793 /* CoreMediaSoftLink.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CoreMediaSoftLink.h; path = pal/cf/CoreMediaSoftLink.h; sourceTree = SOURCE_ROOT; };
+		0CF99CA61F738436007EE793 /* CoreMediaSoftLink.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CoreMediaSoftLink.cpp; sourceTree = ""; };
+		0CF99CA71F738437007EE793 /* CoreMediaSoftLink.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CoreMediaSoftLink.h; sourceTree = ""; };
 		1C09D03D1E31C32800725F18 /* libPAL.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libPAL.a; sourceTree = BUILT_PRODUCTS_DIR; };
 		1C09D0521E31C44100725F18 /* CryptoDigest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CryptoDigest.h; sourceTree = ""; };
-		1C09D0551E31C46500725F18 /* CryptoDigestCommonCrypto.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CryptoDigestCommonCrypto.cpp; path = commoncrypto/CryptoDigestCommonCrypto.cpp; sourceTree = ""; };
+		1C09D0551E31C46500725F18 /* 

[webkit-changes] [240195] trunk/Source

[bburg]

Title: [240195] trunk/Source








Revision 240195
Author bb...@apple.com
Date 2019-01-18 20:22:41 -0800 (Fri, 18 Jan 2019)


Log Message
Automation.computeElementLayout should return visual viewport-aware coordinates
https://bugs.webkit.org/show_bug.cgi?id=193598


Reviewed by Simon Fraser.

Source/WebCore:

* page/FrameView.h: export symbol to be usable from WebKit.
* page/FrameView.cpp:
(WebCore::FrameView::clientToLayoutViewportRect const): Added.
Do the same thing as clientToLayoutViewportPoint with a rect instead.

Source/WebKit:

Previously I added CoordinateSystem::VisualViewport to stub out this for iOS.
But I think that it's a mistake for safaridriver to care about VisualViewport
being enabled or not, because it is a runtime-switchable setting.

This patch removes CoordinateSystem::VisualViewport. Make the existing
CoordinateSystem::LayoutViewport use visual viewport semantics if needed.

This is tested by WebDriver element clicking tests. There should not be any
difference in behavior until it is possible to zoom with gestures via WebDriver.

* Shared/CoordinateSystem.h:
* UIProcess/Automation/Automation.json:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::protocolStringToCoordinateSystem):
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::computeElementLayout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/CoordinateSystem.h
trunk/Source/WebKit/UIProcess/Automation/Automation.json
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (240194 => 240195)

--- trunk/Source/WebCore/ChangeLog	2019-01-19 03:35:44 UTC (rev 240194)
+++ trunk/Source/WebCore/ChangeLog	2019-01-19 04:22:41 UTC (rev 240195)
@@ -1,3 +1,17 @@
+2019-01-18  Brian Burg  
+
+Automation.computeElementLayout should return visual viewport-aware coordinates
+https://bugs.webkit.org/show_bug.cgi?id=193598
+
+
+Reviewed by Simon Fraser.
+
+* page/FrameView.h: export symbol to be usable from WebKit.
+* page/FrameView.cpp:
+(WebCore::FrameView::clientToLayoutViewportRect const): Added.
+Do the same thing as clientToLayoutViewportPoint with a rect instead.
+
+
 2019-01-18  Eric Carlson  
 
 Revert r238815, it broke WK1 video fullscreen on Mac


Modified: trunk/Source/WebCore/page/FrameView.cpp (240194 => 240195)

--- trunk/Source/WebCore/page/FrameView.cpp	2019-01-19 03:35:44 UTC (rev 240194)
+++ trunk/Source/WebCore/page/FrameView.cpp	2019-01-19 04:22:41 UTC (rev 240195)
@@ -4883,6 +4883,13 @@
 return p.scaled(frame().frameScaleFactor());
 }
 
+FloatRect FrameView::clientToLayoutViewportRect(FloatRect rect) const
+{
+ASSERT(frame().settings().visualViewportEnabled());
+rect.scale(frame().pageZoomFactor());
+return rect;
+}
+
 FloatPoint FrameView::clientToLayoutViewportPoint(FloatPoint p) const
 {
 ASSERT(frame().settings().visualViewportEnabled());


Modified: trunk/Source/WebCore/page/FrameView.h (240194 => 240195)

--- trunk/Source/WebCore/page/FrameView.h	2019-01-19 03:35:44 UTC (rev 240194)
+++ trunk/Source/WebCore/page/FrameView.h	2019-01-19 04:22:41 UTC (rev 240195)
@@ -486,7 +486,8 @@
 FloatPoint layoutViewportToAbsolutePoint(FloatPoint) const;
 
 // Unlike client coordinates, layout viewport coordinates are affected by page zoom.
-FloatPoint clientToLayoutViewportPoint(FloatPoint) const;
+WEBCORE_EXPORT FloatRect clientToLayoutViewportRect(FloatRect) const;
+WEBCORE_EXPORT FloatPoint clientToLayoutViewportPoint(FloatPoint) const;
 
 bool isFrameViewScrollCorner(const RenderScrollbarPart& scrollCorner) const { return m_scrollCorner.get() ==  }
 


Modified: trunk/Source/WebKit/ChangeLog (240194 => 240195)

--- trunk/Source/WebKit/ChangeLog	2019-01-19 03:35:44 UTC (rev 240194)
+++ trunk/Source/WebKit/ChangeLog	2019-01-19 04:22:41 UTC (rev 240195)
@@ -1,3 +1,28 @@
+2019-01-18  Brian Burg  
+
+Automation.computeElementLayout should return visual viewport-aware coordinates
+https://bugs.webkit.org/show_bug.cgi?id=193598
+
+
+Reviewed by Simon Fraser.
+
+Previously I added CoordinateSystem::VisualViewport to stub out this for iOS.
+But I think that it's a mistake for safaridriver to care about VisualViewport
+being enabled or not, because it is a runtime-switchable setting.
+
+This patch removes CoordinateSystem::VisualViewport. Make the existing
+CoordinateSystem::LayoutViewport use visual viewport semantics if needed.
+
+This is tested by WebDriver element clicking tests. There should not be any
+difference in behavior until it is possible to zoom with gestures via WebDriver.
+
+* 

[webkit-changes] [240194] trunk/Source/JavaScriptCore

[keith_miller]

Title: [240194] trunk/Source/_javascript_Core








Revision 240194
Author keith_mil...@apple.com
Date 2019-01-18 19:35:44 -0800 (Fri, 18 Jan 2019)


Log Message
JSScript API should only take ascii files.
https://bugs.webkit.org/show_bug.cgi?id=193420

Reviewed by Saam Barati.

This patch leaves the UTF8 method for binary compatablity, which
will be removed later.

* API/JSScript.h:
* API/JSScript.mm:
(fillBufferWithContentsOfFile):
(+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
(+[JSScript scriptFromUTF8File:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
* API/tests/testapi.mm:
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):

Modified Paths

trunk/Source/_javascript_Core/API/JSScript.h
trunk/Source/_javascript_Core/API/JSScript.mm
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSScript.h (240193 => 240194)

--- trunk/Source/_javascript_Core/API/JSScript.h	2019-01-19 03:27:29 UTC (rev 240193)
+++ trunk/Source/_javascript_Core/API/JSScript.h	2019-01-19 03:35:44 UTC (rev 240194)
@@ -52,7 +52,15 @@
  @param cachePath A URL containing the path where the VM should cache for future execution.
  @result The new script.
  @discussion the files at filePath, codeSigningPath, and cachePath should not be externally modified  for the lifecycle of vm. Note that codeSigningPath and cachePath are not used currently, but that will change in the near future.
+
+ If the file at filePath is not ascii this method will return nil.
  */
++ (nullable instancetype)scriptFromASCIIFile:(NSURL *)filePath inVirtualMachine:(JSVirtualMachine *)vm withCodeSigning:(nullable NSURL *)codeSigningPath andBytecodeCache:(nullable NSURL *)cachePath;
+
+
+/*!
+ This is deprecated and is equivalent to scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:.
+ */
 + (nullable instancetype)scriptFromUTF8File:(NSURL *)filePath inVirtualMachine:(JSVirtualMachine *)vm withCodeSigning:(nullable NSURL *)codeSigningPath andBytecodeCache:(nullable NSURL *)cachePath;
 
 @end


Modified: trunk/Source/_javascript_Core/API/JSScript.mm (240193 => 240194)

--- trunk/Source/_javascript_Core/API/JSScript.mm	2019-01-19 03:27:29 UTC (rev 240193)
+++ trunk/Source/_javascript_Core/API/JSScript.mm	2019-01-19 03:35:44 UTC (rev 240194)
@@ -62,7 +62,7 @@
 return readSize == buffer.size() - initialSize;
 }
 
-static bool fillBufferWithContentsOfFile(const String& fileName, Vector& buffer)
+static bool fillBufferWithContentsOfFile(const String& fileName, Vector& buffer)
 {
 FILE* f = fopen(fileName.utf8().data(), "rb");
 if (!f) {
@@ -77,7 +77,7 @@
 }
 
 
-+ (instancetype)scriptFromUTF8File:(NSURL *)filePath inVirtualMachine:(JSVirtualMachine *)vm withCodeSigning:(NSURL *)codeSigningPath andBytecodeCache:(NSURL *)cachePath
++ (instancetype)scriptFromASCIIFile:(NSURL *)filePath inVirtualMachine:(JSVirtualMachine *)vm withCodeSigning:(NSURL *)codeSigningPath andBytecodeCache:(NSURL *)cachePath
 {
 // FIXME: This should check codeSigning.
 UNUSED_PARAM(codeSigningPath);
@@ -88,15 +88,23 @@
 if (!filePathURL.isLocalFile())
 return nil;
 // FIXME: This should mmap the contents of the file instead of copying it into dirty memory.
-Vector buffer;
+Vector buffer;
 if (!fillBufferWithContentsOfFile(filePathURL.fileSystemPath(), buffer))
 return nil;
 
+if (!charactersAreAllASCII(buffer.data(), buffer.size()))
+return nil;
+
 JSScript *result = [[JSScript alloc] init];
 result->m_source = String::fromUTF8WithLatin1Fallback(buffer.data(), buffer.size());
 return result;
 }
 
++ (instancetype)scriptFromUTF8File:(NSURL *)filePath inVirtualMachine:(JSVirtualMachine *)vm withCodeSigning:(NSURL *)codeSigningPath andBytecodeCache:(NSURL *)cachePath
+{
+return [JSScript scriptFromASCIIFile:filePath inVirtualMachine:vm withCodeSigning:codeSigningPath andBytecodeCache:cachePath];
+}
+
 const String& getJSScriptSourceCode(JSScript *module) { return module->m_source; }
 
 @end


Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (240193 => 240194)

--- trunk/Source/_javascript_Core/API/tests/testapi.mm	2019-01-19 03:27:29 UTC (rev 240193)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm	2019-01-19 03:35:44 UTC (rev 240194)
@@ -2017,7 +2017,7 @@
 - (void)context:(JSContext *)context fetchModuleForIdentifier:(JSValue *)identifier withResolveHandler:(JSValue *)resolve andRejectHandler:(JSValue *)reject
 {
 NSURL *filePath = [NSURL URLWithString:[identifier toString]];
-auto *script = [JSScript scriptFromUTF8File:filePath inVirtualMachine:[context virtualMachine] withCodeSigning:nil andBytecodeCache:nil];
+auto *script = [JSScript scriptFromASCIIFile:filePath inVirtualMachine:[context virtualMachine] withCodeSigning:nil andBytecodeCache:nil];
 if (script)
 

[webkit-changes] [240193] trunk/Source/bmalloc

[keith_miller]

Title: [240193] trunk/Source/bmalloc








Revision 240193
Author keith_mil...@apple.com
Date 2019-01-18 19:27:29 -0800 (Fri, 18 Jan 2019)


Log Message
gigacage slide should randomize both start and end
https://bugs.webkit.org/show_bug.cgi?id=193601

Reviewed by Yusuke Suzuki.

This patch makes it so that the gigacade slide has an arbitrary
distance from the end as well as the start. This is done by
picking a random size then based on that size picking an random
starting offset.

* bmalloc/Gigacage.h:
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Algorithm.h
trunk/Source/bmalloc/bmalloc/Gigacage.h
trunk/Source/bmalloc/bmalloc/Heap.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (240192 => 240193)

--- trunk/Source/bmalloc/ChangeLog	2019-01-19 03:05:09 UTC (rev 240192)
+++ trunk/Source/bmalloc/ChangeLog	2019-01-19 03:27:29 UTC (rev 240193)
@@ -1,3 +1,19 @@
+2019-01-18  Keith Miller  
+
+gigacage slide should randomize both start and end
+https://bugs.webkit.org/show_bug.cgi?id=193601
+
+Reviewed by Yusuke Suzuki.
+
+This patch makes it so that the gigacade slide has an arbitrary
+distance from the end as well as the start. This is done by
+picking a random size then based on that size picking an random
+starting offset.
+
+* bmalloc/Gigacage.h:
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::Heap):
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (240192 => 240193)

--- trunk/Source/bmalloc/bmalloc/Algorithm.h	2019-01-19 03:05:09 UTC (rev 240192)
+++ trunk/Source/bmalloc/bmalloc/Algorithm.h	2019-01-19 03:27:29 UTC (rev 240193)
@@ -99,9 +99,16 @@
 template inline T roundDownToMultipleOf(size_t divisor, T x)
 {
 BASSERT(isPowerOfTwo(divisor));
-return reinterpret_cast(mask(reinterpret_cast(x), ~(divisor - 1ul)));
+static_assert(sizeof(T) == sizeof(uintptr_t), "sizeof(T) must be equal to sizeof(uintptr_t).");
+return static_cast(mask(static_cast(x), ~(divisor - 1ul)));
 }
 
+template inline T* roundDownToMultipleOf(size_t divisor, T* x)
+{
+BASSERT(isPowerOfTwo(divisor));
+return reinterpret_cast(mask(reinterpret_cast(x), ~(divisor - 1ul)));
+}
+
 template constexpr T roundDownToMultipleOf(T x)
 {
 static_assert(isPowerOfTwo(divisor), "'divisor' must be a power of two.");


Modified: trunk/Source/bmalloc/bmalloc/Gigacage.h (240192 => 240193)

--- trunk/Source/bmalloc/bmalloc/Gigacage.h	2019-01-19 03:05:09 UTC (rev 240192)
+++ trunk/Source/bmalloc/bmalloc/Gigacage.h	2019-01-19 03:27:29 UTC (rev 240193)
@@ -70,13 +70,13 @@
 constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB;
 constexpr size_t jsValueGigacageSize = 1 * bmalloc::Sizes::GB;
 constexpr size_t gigacageBasePtrsSize = 16 * bmalloc::Sizes::kB;
-constexpr size_t minimumCageSizeAfterSlide = bmalloc::Sizes::GB / 2;
+constexpr size_t maximumCageSizeReductionForSlide = bmalloc::Sizes::GB / 2;
 #define GIGACAGE_ALLOCATION_CAN_FAIL 1
 #else
 constexpr size_t primitiveGigacageSize = 32 * bmalloc::Sizes::GB;
 constexpr size_t jsValueGigacageSize = 16 * bmalloc::Sizes::GB;
 constexpr size_t gigacageBasePtrsSize = 4 * bmalloc::Sizes::kB;
-constexpr size_t minimumCageSizeAfterSlide = 4 * bmalloc::Sizes::GB;
+constexpr size_t maximumCageSizeReductionForSlide = 4 * bmalloc::Sizes::GB;
 #define GIGACAGE_ALLOCATION_CAN_FAIL 0
 #endif
 
@@ -90,8 +90,8 @@
 
 static_assert(bmalloc::isPowerOfTwo(primitiveGigacageSize), "");
 static_assert(bmalloc::isPowerOfTwo(jsValueGigacageSize), "");
-static_assert(primitiveGigacageSize > minimumCageSizeAfterSlide, "");
-static_assert(jsValueGigacageSize > minimumCageSizeAfterSlide, "");
+static_assert(primitiveGigacageSize > maximumCageSizeReductionForSlide, "");
+static_assert(jsValueGigacageSize > maximumCageSizeReductionForSlide, "");
 
 constexpr size_t gigacageSizeToMask(size_t size) { return size - 1; }
 


Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (240192 => 240193)

--- trunk/Source/bmalloc/bmalloc/Heap.cpp	2019-01-19 03:05:09 UTC (rev 240192)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp	2019-01-19 03:27:29 UTC (rev 240193)
@@ -62,12 +62,12 @@
 #if GIGACAGE_ENABLED
 if (usingGigacage()) {
 RELEASE_BASSERT(gigacageBasePtr());
-uint64_t random;
-cryptoRandom(reinterpret_cast(), sizeof(random));
-ptrdiff_t offset = random % (gigacageSize() - Gigacage::minimumCageSizeAfterSlide);
-offset = reinterpret_cast(roundDownToMultipleOf(vmPageSize(), reinterpret_cast(offset)));
+uint64_t random[2];
+cryptoRandom(reinterpret_cast(random), sizeof(random));
+size_t size = roundDownToMultipleOf(vmPageSize(), gigacageSize() - (random[0] % Gigacage::maximumCageSizeReductionForSlide));
+ptrdiff_t offset = 

[webkit-changes] [240192] trunk/PerformanceTests

[sbarati]

Title: [240192] trunk/PerformanceTests








Revision 240192
Author sbar...@apple.com
Date 2019-01-18 19:05:09 -0800 (Fri, 18 Jan 2019)


Log Message
Use scores everywhere in JetStream2's UI
https://bugs.webkit.org/show_bug.cgi?id=193593

Reviewed by Keith Miller.

* JetStream2/JetStreamDriver.js:
(DefaultBenchmark.prototype.processResults):
(DefaultBenchmark.prototype.get score):
(DefaultBenchmark.scoreDescription):
(WSLBenchmark.prototype.processResults):
(WSLBenchmark.prototype.get score):
(WSLBenchmark.scoreDescription):
(WasmBenchmark.prototype.processResults):
(WasmBenchmark.prototype.get score):
(WasmBenchmark.scoreDescription):
* JetStream2/index.html:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/JetStream2/JetStreamDriver.js
trunk/PerformanceTests/JetStream2/index.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (240191 => 240192)

--- trunk/PerformanceTests/ChangeLog	2019-01-19 01:06:47 UTC (rev 240191)
+++ trunk/PerformanceTests/ChangeLog	2019-01-19 03:05:09 UTC (rev 240192)
@@ -1,3 +1,22 @@
+2019-01-18  Saam Barati  
+
+Use scores everywhere in JetStream2's UI
+https://bugs.webkit.org/show_bug.cgi?id=193593
+
+Reviewed by Keith Miller.
+
+* JetStream2/JetStreamDriver.js:
+(DefaultBenchmark.prototype.processResults):
+(DefaultBenchmark.prototype.get score):
+(DefaultBenchmark.scoreDescription):
+(WSLBenchmark.prototype.processResults):
+(WSLBenchmark.prototype.get score):
+(WSLBenchmark.scoreDescription):
+(WasmBenchmark.prototype.processResults):
+(WasmBenchmark.prototype.get score):
+(WasmBenchmark.scoreDescription):
+* JetStream2/index.html:
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/PerformanceTests/JetStream2/JetStreamDriver.js (240191 => 240192)

--- trunk/PerformanceTests/JetStream2/JetStreamDriver.js	2019-01-19 01:06:47 UTC (rev 240191)
+++ trunk/PerformanceTests/JetStream2/JetStreamDriver.js	2019-01-19 03:05:09 UTC (rev 240192)
@@ -588,7 +588,7 @@
 }
 results = copyArray(results);
 
-this.firstIteration = results[0];
+this.firstIteration = toScore(results[0]);
 
 results = results.slice(1);
 results.sort((a, b) => a < b ? 1 : -1);
@@ -598,12 +598,12 @@
 let worstCase = [];
 for (let i = 0; i < this.worstCaseCount; ++i)
 worstCase.push(results[i]);
-this.worst4 = mean(worstCase);
-this.average = mean(results);
+this.worst4 = toScore(mean(worstCase));
+this.average = toScore(mean(results));
 }
 
 get score() {
-return toScore(geomean([this.firstIteration, this.worst4, this.average]));
+return geomean([this.firstIteration, this.worst4, this.average]);
 }
 
 subTimes() {
@@ -615,7 +615,7 @@
 }
 
 static scoreDescription() {
-return ["First (ms)", "Worst (ms)", "Average (ms)", "Score"];
+return ["First", "Worst", "Average", "Score"];
 }
 
 scoreIdentifiers() {
@@ -674,12 +674,12 @@
 }
 
 processResults(results) {
-this.stdlib = results[0];
-this.mainRun = results[1];
+this.stdlib = toScore(results[0]);
+this.mainRun = toScore(results[1]);
 }
 
 get score() {
-return toScore(geomean([this.stdlib, this.mainRun]));
+return geomean([this.stdlib, this.mainRun]);
 }
 
 get runnerCode() {
@@ -710,7 +710,7 @@
 }
 
 static scoreDescription() {
-return ["Stdlib (ms)", "MainRun (ms)", "Score"];
+return ["Stdlib", "MainRun", "Score"];
 }
 
 scoreIdentifiers() {
@@ -747,12 +747,12 @@
 }
 
 processResults(results) {
-this.startupTime = results[0];
-this.runTime = results[1];
+this.startupTime = toScore(results[0]);
+this.runTime = toScore(results[1]);
 }
 
 get score() {
-return toScore(geomean([this.startupTime, this.runTime]));
+return geomean([this.startupTime, this.runTime]);
 }
 
 get wasmPath() {
@@ -857,7 +857,7 @@
 }
 
 static scoreDescription() {
-return ["Startup (ms)", "Runtime (ms)", "Score"];
+return ["Startup", "Runtime", "Score"];
 }
 
 get startupID() {


Modified: trunk/PerformanceTests/JetStream2/index.html (240191 => 240192)

--- trunk/PerformanceTests/JetStream2/index.html	2019-01-19 01:06:47 UTC (rev 240191)
+++ trunk/PerformanceTests/JetStream2/index.html	2019-01-19 03:05:09 UTC (rev 240192)
@@ -52,7 +52,7 @@
 
 
 JetStream 2
-JetStream is a _javascript_ benchmark suite focused on the most advanced web applications. For more information, read the . Higher scores are better.
+JetStream 2 is a _javascript_ benchmark suite focused on the most advanced web applications. For more information, read the . Higher scores are better.
 
 
 

[webkit-changes] [240191] trunk/Tools

[commit-queue]

Title: [240191] trunk/Tools








Revision 240191
Author commit-qu...@webkit.org
Date 2019-01-18 17:06:47 -0800 (Fri, 18 Jan 2019)


Log Message
Disable the run-jsc-stress-test remote host key check [second round].
https://bugs.webkit.org/show_bug.cgi?id=192988

Patch by Zhifei FANG  on 2019-01-18
Reviewed by Dewei Zhu.

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Tools/ChangeLog (240190 => 240191)

--- trunk/Tools/ChangeLog	2019-01-19 00:22:41 UTC (rev 240190)
+++ trunk/Tools/ChangeLog	2019-01-19 01:06:47 UTC (rev 240191)
@@ -1,3 +1,12 @@
+2019-01-18  Zhifei FANG  
+
+Disable the run-jsc-stress-test remote host key check [second round].
+https://bugs.webkit.org/show_bug.cgi?id=192988
+
+Reviewed by Dewei Zhu.
+
+* Scripts/run-jsc-stress-tests:
+
 2019-01-18  Aakash Jain  
 
 [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist


Modified: trunk/Tools/Scripts/run-jsc-stress-tests (240190 => 240191)

--- trunk/Tools/Scripts/run-jsc-stress-tests	2019-01-19 00:22:41 UTC (rev 240190)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2019-01-19 01:06:47 UTC (rev 240191)
@@ -1920,7 +1920,7 @@
 remoteScript += "export JSCTEST_timeout=#{Shellwords.shellescape(ENV['JSCTEST_timeout'])} && "
 $envVars.each { |var| remoteScript += "export " << var << "\n" }
 remoteScript += "#{testRunnerCommand(remoteIndex)}\""
-runAndMonitorTestRunnerCommand("ssh", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", remoteScript)
+runAndMonitorTestRunnerCommand("ssh", "-o", "NoHostAuthenticationForLocalhost=yes", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", remoteScript)
 else
 Dir.chdir($runnerDir) {
 runAndMonitorTestRunnerCommand(testRunnerCommand)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240190] trunk/Source

[eric . carlson]

Title: [240190] trunk/Source








Revision 240190
Author eric.carl...@apple.com
Date 2019-01-18 16:22:41 -0800 (Fri, 18 Jan 2019)


Log Message
Revert r238815, it broke WK1 video fullscreen on Mac
https://bugs.webkit.org/show_bug.cgi?id=193586


Reviewed by Jer Noble.

Source/WebCore:

* PlatformMac.cmake:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen const):

Source/WebKitLegacy:

* WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

* WebView/WebVideoFullscreenController.h: Added.
* WebView/WebVideoFullscreenController.mm: Added.
(SOFT_LINK_CLASS):
(-[WebVideoFullscreenController init]):
(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController fullscreenWindow]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController videoElement]):
(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController clearFadeAnimation]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(-[WebVideoFullscreenController windowDidEnterFullscreen]):
(-[WebVideoFullscreenController videoElementRect]):
(-[WebVideoFullscreenController applicationDidResignActive:]):
(frameExpandedToRatioOfFrame):
(createBackgroundFullscreenWindow):
(-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
(-[WebVideoFullscreenController enterFullscreen:]):
(-[WebVideoFullscreenController exitFullscreen]):
(-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
(-[WebVideoFullscreenController _requestExit]):
(-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
(-[WebVideoFullscreenController requestExitFullscreen]):
(-[WebVideoFullscreenController fadeHUDIn]):
(-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
(-[WebVideoFullscreenController rateChanged:]):
(-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
(-[WebVideoFullscreenWindow dealloc]):
(-[WebVideoFullscreenWindow resignFirstResponder]):
(-[WebVideoFullscreenWindow canBecomeKeyWindow]):
(-[WebVideoFullscreenWindow mouseDown:]):
(-[WebVideoFullscreenWindow cancelOperation:]):
(-[WebVideoFullscreenWindow animatedResizeDidEnd]):
(-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
(-[WebVideoFullscreenWindow animationDidEnd:]):
(-[WebVideoFullscreenWindow mouseMoved:]):
* WebView/WebVideoFullscreenHUDWindowController.h: Added.
* WebView/WebVideoFullscreenHUDWindowController.mm: Added.
(-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
(-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
(-[WebVideoFullscreenHUDWindow cancelOperation:]):
(-[WebVideoFullscreenHUDWindow center]):
(-[WebVideoFullscreenHUDWindow keyDown:]):
(-[WebVideoFullscreenHUDWindow resignFirstResponder]):
(-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
(-[WebVideoFullscreenHUDWindowController init]):
(-[WebVideoFullscreenHUDWindowController dealloc]):
(-[WebVideoFullscreenHUDWindowController setArea:]):
(-[WebVideoFullscreenHUDWindowController keyDown:]):
(-[WebVideoFullscreenHUDWindowController delegate]):
(-[WebVideoFullscreenHUDWindowController setDelegate:]):
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
(-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
(-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
(-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
(-[WebVideoFullscreenHUDWindowController closeWindow]):
(createMediaUIControl):
(createControlWithMediaUIControlType):
(createTimeTextField):
(createMediaUIBackgroundView):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
(-[WebVideoFullscreenHUDWindowController updateVolume]):
(-[WebVideoFullscreenHUDWindowController updateTime]):
(-[WebVideoFullscreenHUDWindowController endScrubbing]):
(-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
(-[WebVideoFullscreenHUDWindowController currentTime]):
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController duration]):
(-[WebVideoFullscreenHUDWindowController maxVolume]):
(-[WebVideoFullscreenHUDWindowController volumeChanged:]):
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
(-[WebVideoFullscreenHUDWindowController decrementVolume]):
(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(-[WebVideoFullscreenHUDWindowController volume]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):
(-[WebVideoFullscreenHUDWindowController updatePlayButton]):
(-[WebVideoFullscreenHUDWindowController updateRate]):
(-[WebVideoFullscreenHUDWindowController togglePlaying:]):
(-[WebVideoFullscreenHUDWindowController playing]):
(-[WebVideoFullscreenHUDWindowController setPlaying:]):
(timeToString):
(-[WebVideoFullscreenHUDWindowController 

[webkit-changes] [240189] trunk/Tools

[aakash_jain]

Title: [240189] trunk/Tools








Revision 240189
Author aakash_j...@apple.com
Date 2019-01-18 16:18:08 -0800 (Fri, 18 Jan 2019)


Log Message
[build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=193597

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (240188 => 240189)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-01-19 00:13:28 UTC (rev 240188)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-01-19 00:18:08 UTC (rev 240189)
@@ -551,7 +551,6 @@
 'JSCOnly Linux AArch64 Release': ['configure build', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
 'JSCOnly Linux MIPS32el Release': ['configure build', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
 
-'GTK Linux 32-bit Release': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'compile-webkit', 'jscore-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'generate-jsc-bundle', 'API tests', 'webdriver-test'],
 'GTK Linux 64-bit Debug (Build)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],
 'GTK Linux 64-bit Debug (Tests)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand', 'API tests', 'webdriver-test'],
 'GTK Linux 64-bit Release (Build)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'compile-webkit', 'archive-built-product', 'upload', 'generate-jsc-bundle', 'transfer-to-s3', 'trigger'],


Modified: trunk/Tools/ChangeLog (240188 => 240189)

--- trunk/Tools/ChangeLog	2019-01-19 00:13:28 UTC (rev 240188)
+++ trunk/Tools/ChangeLog	2019-01-19 00:18:08 UTC (rev 240189)
@@ -1,5 +1,14 @@
 2019-01-18  Aakash Jain  
 
+[build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
+https://bugs.webkit.org/show_bug.cgi?id=193597
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
+
+2019-01-18  Aakash Jain  
+
 [build.webkit.org] api tests failures are incorrectly named as unit test failures
 https://bugs.webkit.org/show_bug.cgi?id=193595
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240188] trunk/Source/WebCore

[drousso]

Title: [240188] trunk/Source/WebCore








Revision 240188
Author drou...@apple.com
Date 2019-01-18 16:13:28 -0800 (Fri, 18 Jan 2019)


Log Message
Web Inspector: Audit: don't keep the injected sub-objects alive between runs
https://bugs.webkit.org/show_bug.cgi?id=193594


Reviewed by Joseph Pecoraro.

Rather than save the `InspectorAuditAccessibilityObject` and `InspectorAuditDOMObject`
between individual `Audit.setup` invocations, we should only keep them alive so long as the
injected `WebInspectorAudit` object is alive (e.g. from `Audit.setup` to `Audit.teardown`).

This change fixes inspector/audit/run-accessibility.html.

* inspector/agents/page/PageAuditAgent.h:
* inspector/agents/page/PageAuditAgent.cpp:
(WebCore::PageAuditAgent::populateAuditObject):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.cpp
trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (240187 => 240188)

--- trunk/Source/WebCore/ChangeLog	2019-01-19 00:10:19 UTC (rev 240187)
+++ trunk/Source/WebCore/ChangeLog	2019-01-19 00:13:28 UTC (rev 240188)
@@ -1,3 +1,21 @@
+2019-01-18  Devin Rousso  
+
+Web Inspector: Audit: don't keep the injected sub-objects alive between runs
+https://bugs.webkit.org/show_bug.cgi?id=193594
+
+
+Reviewed by Joseph Pecoraro.
+
+Rather than save the `InspectorAuditAccessibilityObject` and `InspectorAuditDOMObject`
+between individual `Audit.setup` invocations, we should only keep them alive so long as the
+injected `WebInspectorAudit` object is alive (e.g. from `Audit.setup` to `Audit.teardown`).
+
+This change fixes inspector/audit/run-accessibility.html.
+
+* inspector/agents/page/PageAuditAgent.h:
+* inspector/agents/page/PageAuditAgent.cpp:
+(WebCore::PageAuditAgent::populateAuditObject):
+
 2019-01-18  Daniel Bates  
 
 Another attempt to fix the iOS build following 


Modified: trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.cpp (240187 => 240188)

--- trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.cpp	2019-01-19 00:10:19 UTC (rev 240187)
+++ trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.cpp	2019-01-19 00:13:28 UTC (rev 240188)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "PageAuditAgent.h"
 
+#include "InspectorAuditAccessibilityObject.h"
+#include "InspectorAuditDOMObject.h"
 #include "JSInspectorAuditAccessibilityObject.h"
 #include "JSInspectorAuditDOMObject.h"
 #include "Page.h"
@@ -81,15 +83,11 @@
 if (auto* globalObject = JSC::jsCast(execState->lexicalGlobalObject())) {
 JSC::JSLockHolder lock(execState);
 
-#define ADD_AUDIT_OBJECT(name) \
-if (!m_audit##name##Object) \
-m_audit##name##Object = InspectorAudit##name##Object::create(*this); \
-if (JSC::JSValue inspectorAudit##name##Object = toJS(execState, globalObject, *m_audit##name##Object)) \
-auditObject->putDirect(execState->vm(), JSC::Identifier::fromString(execState, "" #name ""), inspectorAudit##name##Object);
+if (JSC::JSValue jsInspectorAuditAccessibilityObject = toJSNewlyCreated(execState, globalObject, InspectorAuditAccessibilityObject::create(*this))) \
+auditObject->putDirect(execState->vm(), JSC::Identifier::fromString(execState, "Accessibility"), jsInspectorAuditAccessibilityObject);
 
-ADD_AUDIT_OBJECT(Accessibility);
-ADD_AUDIT_OBJECT(DOM);
-#undef ADD_AUDIT_OBJECT
+if (JSC::JSValue jsInspectorAuditDOMObject = toJSNewlyCreated(execState, globalObject, InspectorAuditDOMObject::create(*this))) \
+auditObject->putDirect(execState->vm(), JSC::Identifier::fromString(execState, "DOM"), jsInspectorAuditDOMObject);
 }
 }
 


Modified: trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.h (240187 => 240188)

--- trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.h	2019-01-19 00:10:19 UTC (rev 240187)
+++ trunk/Source/WebCore/inspector/agents/page/PageAuditAgent.h	2019-01-19 00:13:28 UTC (rev 240188)
@@ -25,8 +25,6 @@
 
 #pragma once
 
-#include "InspectorAuditAccessibilityObject.h"
-#include "InspectorAuditDOMObject.h"
 #include "InspectorWebAgentBase.h"
 #include <_javascript_Core/InspectorAuditAgent.h>
 
@@ -50,8 +48,6 @@
 void unmuteConsole() override;
 
 Page& m_inspectedPage;
-RefPtr m_auditAccessibilityObject;
-RefPtr m_auditDOMObject;
 };
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240187] trunk/Tools

[aakash_jain]

Title: [240187] trunk/Tools








Revision 240187
Author aakash_j...@apple.com
Date 2019-01-18 16:10:19 -0800 (Fri, 18 Jan 2019)


Log Message
[build.webkit.org] api tests failures are incorrectly named as unit test failures
https://bugs.webkit.org/show_bug.cgi?id=193595

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
* BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py (240186 => 240187)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	2019-01-19 00:10:19 UTC (rev 240187)
@@ -90,7 +90,7 @@
 self.addStep(self.LayoutTestClass())
 
 if platform.startswith('win') or platform.startswith('mac') or platform.startswith('ios-simulator'):
-self.addStep(RunUnitTests())
+self.addStep(RunAPITests())
 self.addStep(RunPythonTests())
 self.addStep(RunPerlTests())
 self.addStep(RunBindingsTests())


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (240186 => 240187)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2019-01-19 00:10:19 UTC (rev 240187)
@@ -503,12 +503,12 @@
 return RunWebKitTests.start(self)
 
 
-class RunUnitTests(TestWithFailureCount):
+class RunAPITests(TestWithFailureCount):
 name = "run-api-tests"
-description = ["unit tests running"]
-descriptionDone = ["unit-tests"]
+description = ["api tests running"]
+descriptionDone = ["api-tests"]
 command = ["python", "./Tools/Scripts/run-api-tests", "--no-build", WithProperties("--%(configuration)s"), "--verbose"]
-failedTestsFormatString = "%d unit test%s failed or timed out"
+failedTestsFormatString = "%d api test%s failed or timed out"
 
 def start(self):
 appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (240186 => 240187)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-01-19 00:10:19 UTC (rev 240187)
@@ -260,13 +260,13 @@
 self.assertResults(SUCCESS, ['webkit-32bit-jsc-test'], 0,  '0 failures found.')
 
 
-class RunUnitTestsTest(unittest.TestCase):
+class RunAPITestsTest(unittest.TestCase):
 def assertFailures(self, expected_failure_count, stdio):
 if expected_failure_count:
 rc = 1
 expected_results = FAILURE
 plural_suffix = "" if expected_failure_count == 1 else "s"
-expected_text = '%d unit test%s failed or timed out' % (expected_failure_count, plural_suffix)
+expected_text = '%d api test%s failed or timed out' % (expected_failure_count, plural_suffix)
 else:
 rc = 0
 expected_results = SUCCESS
@@ -273,7 +273,7 @@
 expected_text = 'run-api-tests'
 
 cmd = StubRemoteCommand(rc, stdio)
-step = RunUnitTests()
+step = RunAPITests()
 step.commandComplete(cmd)
 actual_results = step.evaluateCommand(cmd)
 actual_failure_count = step.failedTestCount


Modified: trunk/Tools/ChangeLog (240186 => 240187)

--- trunk/Tools/ChangeLog	2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/ChangeLog	2019-01-19 00:10:19 UTC (rev 240187)
@@ -1,3 +1,14 @@
+2019-01-18  Aakash Jain  
+
+[build.webkit.org] api tests failures are incorrectly named as unit test failures
+https://bugs.webkit.org/show_bug.cgi?id=193595
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
+* BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
+* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
+
 2019-01-18  Chris Dumez  
 
 Regression(PSON) Content blockers are sometimes lost on back navigation cross-site






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240186] trunk/Source/JavaScriptCore

[ddkilzer]

Title: [240186] trunk/Source/_javascript_Core








Revision 240186
Author ddkil...@apple.com
Date 2019-01-18 16:08:21 -0800 (Fri, 18 Jan 2019)


Log Message
Follow-up: Gigacages should start allocations from a slide



* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_PARAM(kind) to
fix the build.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (240185 => 240186)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-18 23:45:42 UTC (rev 240185)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-19 00:08:21 UTC (rev 240186)
@@ -1,3 +1,13 @@
+2019-01-18  David Kilzer  
+
+Follow-up: Gigacages should start allocations from a slide
+
+
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_PARAM(kind) to
+fix the build.
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (240185 => 240186)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-18 23:45:42 UTC (rev 240185)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-19 00:08:21 UTC (rev 240186)
@@ -13882,6 +13882,7 @@
 // https://bugs.webkit.org/show_bug.cgi?id=175493
 return m_out.opaque(result);
 #else
+UNUSED_PARAM(kind);
 return ptr;
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240185] trunk/Source/WebCore

[dbates]

Title: [240185] trunk/Source/WebCore








Revision 240185
Author dba...@webkit.org
Date 2019-01-18 15:45:42 -0800 (Fri, 18 Jan 2019)


Log Message
Another attempt to fix the iOS build following 
(https://bugs.webkit.org/show_bug.cgi?id=193583)

Substitute ENABLE(FULL_KEYBOARD_ACCESS) for PLATFORM(MAC). On Mac, we always build with
ENABLE(FULL_KEYBOARD_ACCESS) enabled.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (240184 => 240185)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 23:44:31 UTC (rev 240184)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 23:45:42 UTC (rev 240185)
@@ -1,5 +1,16 @@
 2019-01-18  Daniel Bates  
 
+Another attempt to fix the iOS build following 
+(https://bugs.webkit.org/show_bug.cgi?id=193583)
+
+Substitute ENABLE(FULL_KEYBOARD_ACCESS) for PLATFORM(MAC). On Mac, we always build with
+ENABLE(FULL_KEYBOARD_ACCESS) enabled.
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::paintFocusRing):
+
+2019-01-18  Daniel Bates  
+
 Fix some build issues.
 
 Including UIKitSoftLinking.h is not compatible with unified builds.


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (240184 => 240185)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2019-01-18 23:44:31 UTC (rev 240184)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2019-01-18 23:45:42 UTC (rev 240185)
@@ -1820,7 +1820,7 @@
 pixelSnappedFocusRingRects.append(snapRectToDevicePixels(rect, deviceScaleFactor));
 }
 // FIXME: The following code should only be compiled for Mac. See .
-#if PLATFORM(COCOA)
+#if ENABLE(FULL_KEYBOARD_ACCESS)
 bool needsRepaint;
 if (style.hasBorderRadius()) {
 Path path = PathUtilities::pathWithShrinkWrappedRectsForOutline(pixelSnappedFocusRingRects, style.border(), outlineOffset, style.direction(), style.writingMode(),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240184] trunk/Source/WebCore/PAL

[ddkilzer]

Title: [240184] trunk/Source/WebCore/PAL








Revision 240184
Author ddkil...@apple.com
Date 2019-01-18 15:44:31 -0800 (Fri, 18 Jan 2019)


Log Message
Follow-up: Override the session configuration for cookieAcceptPolicy



Discussed with John Wilander.

* pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal
macOS 10.12 Sierra SDK since it will never appear in those
headers.  This fixes the build for trunk WebKit on Sierra.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (240183 => 240184)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 23:34:06 UTC (rev 240183)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 23:44:31 UTC (rev 240184)
@@ -1,3 +1,15 @@
+2019-01-18  David Kilzer  
+
+Follow-up: Override the session configuration for cookieAcceptPolicy
+
+
+
+Discussed with John Wilander.
+
+* pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal
+macOS 10.12 Sierra SDK since it will never appear in those
+headers.  This fixes the build for trunk WebKit on Sierra.
+
 2019-01-18  Tim Horton  
 
 Get rid of ADVANCED_SPELL_CHECKING


Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (240183 => 240184)

--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2019-01-18 23:34:06 UTC (rev 240183)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2019-01-18 23:44:31 UTC (rev 240184)
@@ -62,6 +62,15 @@
 #import 
 #endif
 
+// This only needs to be declared on macOS 10.12 Sierra because
+// it will never appear in those SDK headers.  See also
+// HAVE(CFNETWORK_OVERRIDE_SESSION_COOKIE_ACCEPT_POLICY).
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 101200
+@interface NSHTTPCookieStorage ()
+@property (nonatomic, readwrite) BOOL _overrideSessionCookieAcceptPolicy;
+@end
+#endif
+
 #else // !PLATFORM(WIN) && !USE(APPLE_INTERNAL_SDK)
 
 typedef CF_ENUM(int64_t, _TimingDataOptions)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240183] trunk/Source

[dbates]

Title: [240183] trunk/Source








Revision 240183
Author dba...@webkit.org
Date 2019-01-18 15:34:06 -0800 (Fri, 18 Jan 2019)


Log Message
Fix some build issues.

Source/WebCore:

Including UIKitSoftLinking.h is not compatible with unified builds.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Include missing header WKDrawingCoordinator.

* UIProcess/ios/WKInkPickerView.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKInkPickerView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (240182 => 240183)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 23:26:52 UTC (rev 240182)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 23:34:06 UTC (rev 240183)
@@ -1,3 +1,12 @@
+2019-01-18  Daniel Bates  
+
+Fix some build issues.
+
+Including UIKitSoftLinking.h is not compatible with unified builds.
+
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+
 2019-01-18  Justin Fan  
 
 (WIP) [WebGPU] WebGPUProgrammablePassEncoder::setBindGroup prototype


Modified: trunk/Source/WebCore/SourcesCocoa.txt (240182 => 240183)

--- trunk/Source/WebCore/SourcesCocoa.txt	2019-01-18 23:26:52 UTC (rev 240182)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2019-01-18 23:34:06 UTC (rev 240183)
@@ -425,10 +425,10 @@
 platform/ios/WebAVPlayerController.mm
 platform/ios/WebBackgroundTaskController.mm
 platform/ios/WebCoreMotionManager.mm
-platform/ios/WebEvent.mm
+platform/ios/WebEvent.mm @no-unify
 platform/ios/WebItemProviderPasteboard.mm @no-unify
 platform/ios/WebSQLiteDatabaseTrackerClient.mm
-platform/ios/WebVideoFullscreenControllerAVKit.mm
+platform/ios/WebVideoFullscreenControllerAVKit.mm @no-unify
 platform/ios/WidgetIOS.mm
 
 platform/ios/wak/FloatingPointEnvironment.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (240182 => 240183)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-01-18 23:26:52 UTC (rev 240182)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-01-18 23:34:06 UTC (rev 240183)
@@ -4219,6 +4219,8 @@
 		CECADFC9153778FF00E37068 /* DictationCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = CECADFC5153778FF00E37068 /* DictationCommand.h */; };
 		CECADFCE1537791D00E37068 /* TextInsertionBaseCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = CECADFCC1537791D00E37068 /* TextInsertionBaseCommand.h */; };
 		CECCFC3B141973D5002A0AC1 /* DecodeEscapeSequences.h in Headers */ = {isa = PBXBuildFile; fileRef = CECCFC3A141973D5002A0AC1 /* DecodeEscapeSequences.h */; };
+		CECDC93C21F2972900976BD1 /* WebVideoFullscreenControllerAVKit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3F42B31C1881191B00278AAC /* WebVideoFullscreenControllerAVKit.mm */; };
+		CECDC93D21F2973200976BD1 /* WebEvent.mm in Sources */ = {isa = PBXBuildFile; fileRef = FE0D84EA1048436E001A179E /* WebEvent.mm */; };
 		CED06AD11C77754800FDFAF1 /* JSSecurityPolicyViolationEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = CED06ACF1C77754800FDFAF1 /* JSSecurityPolicyViolationEvent.h */; };
 		CEDA12D7152CA1CB00D9E08D /* AlternativeTextClient.h in Headers */ = {isa = PBXBuildFile; fileRef = CEDA12D6152CA1CB00D9E08D /* AlternativeTextClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CEEFCD7A19DB31F7003876D7 /* MediaResourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = CEEFCD7819DB31F7003876D7 /* MediaResourceLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -33456,6 +33458,7 @@
 CD7E05221651C28200C1201F /* WebCoreAVFResourceLoader.mm in Sources */,
 CD225C0B1C46FBF400140761 /* WebCoreNSURLSession.mm in Sources */,
 93F19B0708245E59001E9ABC /* WebCoreView.m in Sources */,
+CECDC93D21F2973200976BD1 /* WebEvent.mm in Sources */,
 D3F3D36D1A69B7DC0059FC2B /* WebGL2RenderingContext.cpp in Sources */,
 49C7B9C81042D32F0009D447 /* WebGLBuffer.cpp in Sources */,
 D08B00E220A282490004BC0A /* WebGLCompressedTextureASTC.cpp in Sources */,
@@ -33498,6 +33501,7 @@
 7C48A6D0191C9D6500026674 /* WebKitNamespace.cpp in Sources */,
 0709D7921AE5557E004E42F8 /* WebMediaSessionManagerMac.cpp in Sources */,
 1CAF34820A6C405200ABE06E /* WebScriptObject.mm in Sources */,
+CECDC93C21F2972900976BD1 /* WebVideoFullscreenControllerAVKit.mm in Sources */,
 F12171F516A8CED253CA /* WebVTTElement.cpp in Sources */,
 5D21A80213ECE5DF00BB7064 /* WebVTTParser.cpp in Sources */,
 B10B6981140C174000BC1C26 /* WebVTTTokenizer.cpp in Sources */,


Modified: trunk/Source/WebKit/ChangeLog (240182 => 240183)

--- trunk/Source/WebKit/ChangeLog	2019-01-18 23:26:52 UTC (rev 240182)
+++ trunk/Source/WebKit/ChangeLog	2019-01-18 23:34:06 UTC (rev 240183)
@@ -1,3 +1,11 @@
+2019-01-18  Daniel Bates  
+
+Fix some build issues.
+
+Include missing header WKDrawingCoordinator.
+
+* 

[webkit-changes] [240182] trunk/Websites/perf.webkit.org

[dewei_zhu]

Title: [240182] trunk/Websites/perf.webkit.org








Revision 240182
Author dewei_...@apple.com
Date 2019-01-18 15:26:52 -0800 (Fri, 18 Jan 2019)


Log Message
Test group results notification should not say a build request to build had failed even when it had successfully completed.
https://bugs.webkit.org/show_bug.cgi?id=193064

Reviewed by Ryosuke Niwa.

Should show 'Build completed' or 'Build failed' for build type build requests.

* browser-tests/test-group-result-page-tests.js: Added a unit test to guard this bug.
* tools/js/test-group-result-page.js: Show 'Build completed' or 'Build failed' for build type build requests.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/browser-tests/test-group-result-page-tests.js
trunk/Websites/perf.webkit.org/tools/js/test-group-result-page.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (240181 => 240182)

--- trunk/Websites/perf.webkit.org/ChangeLog	2019-01-18 23:15:56 UTC (rev 240181)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2019-01-18 23:26:52 UTC (rev 240182)
@@ -1,3 +1,15 @@
+2018-12-31  Dewei Zhu  
+
+Test group results notification should not say a build request to build had failed even when it had successfully completed.
+https://bugs.webkit.org/show_bug.cgi?id=193064
+
+Reviewed by Ryosuke Niwa.
+
+Should show 'Build completed' or 'Build failed' for build type build requests.
+
+* browser-tests/test-group-result-page-tests.js: Added a unit test to guard this bug.
+* tools/js/test-group-result-page.js: Show 'Build completed' or 'Build failed' for build type build requests.
+
 2018-12-21  Dewei Zhu  
 
 Add UI in analysis task page to show commit testability information.


Modified: trunk/Websites/perf.webkit.org/browser-tests/test-group-result-page-tests.js (240181 => 240182)

--- trunk/Websites/perf.webkit.org/browser-tests/test-group-result-page-tests.js	2019-01-18 23:15:56 UTC (rev 240181)
+++ trunk/Websites/perf.webkit.org/browser-tests/test-group-result-page-tests.js	2019-01-18 23:26:52 UTC (rev 240182)
@@ -6,7 +6,7 @@
 'models/data-model.js', 'models/metric.js', '../shared/statistics.js',], 'TestGroupResultPage', 'Metric');
 }
 
-async function prepareTestGroupResultPage(context, resultA, resultB)
+async function prepareTestGroupResultPage(context, buildRequestsA, buildRequestsB)
 {
 const [TestGroupResultPage, Metric] = await importMarkupComponent(context);
 
@@ -20,15 +20,15 @@
 
 const mockTestGroup = {
 requestedCommitSets: () => ['A', 'B'],
-test: () => ({test: () => 'speeodmeter-2', name: () => 'speedometer-2'}),
+test: () => ({test: () => 'speedometer-2', name: () => 'speedometer-2'}),
 labelForCommitSet: (commitSet) => commitSet,
-requestsForCommitSet: (commitSet) => ({'A': resultA, 'B': resultB}[commitSet]),
+requestsForCommitSet: (commitSet) => ({'A': buildRequestsA, 'B': buildRequestsB}[commitSet]),
 compareTestResults: (...args) => ({isStatisticallySignificant: true, changeType: 'worse'}),
 name: () => 'mock-test-group',
 };
 
 const mockAnalysisResults = {
-viewForMetric: (metric) => ({resultForRequest: (buildRequest) => (buildRequest === null ? null : {value: buildRequest})})
+viewForMetric: (metric) => ({resultForRequest: (buildRequest) => (buildRequest.value === null ? null : {value: buildRequest.value})})
 };
 
 const page = new TestGroupResultPage('test');
@@ -40,9 +40,19 @@
 return page;
 }
 
+function prepareBuildRequests(buildRequestValues, isTestBooleanList, hasCompletedBooleanList)
+{
+return Array.from(buildRequestValues.entries()).map((entry) => {
+const [index, value] = entry;
+const isTest = isTestBooleanList ? isTestBooleanList[index] : true;
+const hasCompleted = hasCompletedBooleanList ? hasCompletedBooleanList[index] : true;
+return {value, isTest: () => isTest, isBuild: () => !isTest, hasCompleted: () => hasCompleted};
+});
+}
+
 it('should render failed test group with empty bar', async () => {
 const context = new BrowsingContext();
-const page = await prepareTestGroupResultPage(context, [null, 3, 5], [2, 4, 6]);
+const page = await prepareTestGroupResultPage(context, prepareBuildRequests([null, 3, 5]), prepareBuildRequests([2, 4, 6]));
 await page.enqueueToRender();
 const document = context.document;
 document.open();
@@ -56,7 +66,7 @@
 const context = new BrowsingContext();
 const resultA = [1, 3, 5];
 const resultB = [2, 4, 6];
-const page = await prepareTestGroupResultPage(context, resultA, resultB);
+const page = await prepareTestGroupResultPage(context, prepareBuildRequests(resultA), prepareBuildRequests(resultB));
 

[webkit-changes] [240181] trunk/Source

[timothy_horton]

Title: [240181] trunk/Source








Revision 240181
Author timothy_hor...@apple.com
Date 2019-01-18 15:15:56 -0800 (Fri, 18 Jan 2019)


Log Message
Get rid of ADVANCED_SPELL_CHECKING
https://bugs.webkit.org/show_bug.cgi?id=193592

Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

* pal/spi/mac/NSSpellCheckerSPI.h:
It's always true on macOS, and all but one use of it is already inside PLATFORM(MAC)

Source/WebKit:

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestCandidatesForSelectionIfNeeded):
(WebKit::WebViewImpl::insertText):
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::getGuessesForWord):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebEditorClient.mm:
(insertionPointFromCurrentSelection):
(WebEditorClient::checkTextOfParagraph):
(WebEditorClient::getGuessesForWord):
(WebEditorClient::requestCandidatesForSelection):
(WebEditorClient::requestCheckingOfString):
* WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/mac/TextCheckerMac.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (240180 => 240181)

--- trunk/Source/WTF/ChangeLog	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WTF/ChangeLog	2019-01-18 23:15:56 UTC (rev 240181)
@@ -1,3 +1,12 @@
+2019-01-18  Tim Horton  
+
+Get rid of ADVANCED_SPELL_CHECKING
+https://bugs.webkit.org/show_bug.cgi?id=193592
+
+Reviewed by Wenson Hsieh.
+
+* wtf/Platform.h:
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/WTF/wtf/Platform.h (240180 => 240181)

--- trunk/Source/WTF/wtf/Platform.h	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WTF/wtf/Platform.h	2019-01-18 23:15:56 UTC (rev 240181)
@@ -1340,7 +1340,6 @@
 
 #if PLATFORM(MAC)
 #define HAVE_TOUCH_BAR 1
-#define HAVE_ADVANCED_SPELL_CHECKING 1
 #define USE_DICTATION_ALTERNATIVES 1
 
 #if defined(__LP64__)


Modified: trunk/Source/WebCore/PAL/ChangeLog (240180 => 240181)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 23:15:56 UTC (rev 240181)
@@ -1,3 +1,13 @@
+2019-01-18  Tim Horton  
+
+Get rid of ADVANCED_SPELL_CHECKING
+https://bugs.webkit.org/show_bug.cgi?id=193592
+
+Reviewed by Wenson Hsieh.
+
+* pal/spi/mac/NSSpellCheckerSPI.h:
+It's always true on macOS, and all but one use of it is already inside PLATFORM(MAC)
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h (240180 => 240181)

--- trunk/Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h	2019-01-18 23:15:56 UTC (rev 240181)
@@ -31,18 +31,12 @@
 
 #else
 
-#if HAVE(ADVANCED_SPELL_CHECKING)
 extern NSString *NSTextCheckingInsertionPointKey;
-#endif
-
 extern NSString *NSTextCheckingSuppressInitialCapitalizationKey;
 
 @interface NSSpellChecker ()
 
-#if HAVE(ADVANCED_SPELL_CHECKING)
 - (BOOL)deletesAutospaceBeforeString:(NSString *)string language:(NSString *)language;
-#endif
-
 - (void)_preflightChosenSpellServer;
 
 @end


Modified: trunk/Source/WebKit/ChangeLog (240180 => 240181)

--- trunk/Source/WebKit/ChangeLog	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WebKit/ChangeLog	2019-01-18 23:15:56 UTC (rev 240181)
@@ -1,3 +1,17 @@
+2019-01-18  Tim Horton  
+
+Get rid of ADVANCED_SPELL_CHECKING
+https://bugs.webkit.org/show_bug.cgi?id=193592
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::requestCandidatesForSelectionIfNeeded):
+(WebKit::WebViewImpl::insertText):
+* UIProcess/mac/TextCheckerMac.mm:
+(WebKit::TextChecker::checkTextOfParagraph):
+(WebKit::TextChecker::getGuessesForWord):
+
 2019-01-18  Chris Dumez  
 
 Regression(PSON) Content blockers are sometimes lost on back navigation cross-site


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (240180 => 240181)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2019-01-18 23:09:38 UTC (rev 240180)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2019-01-18 23:15:56 UTC (rev 240181)
@@ -3229,7 +3229,6 @@
 auto& postLayoutData = editorState.postLayoutData();
 m_lastStringForCandidateRequest = postLayoutData.stringForCandidateRequest;
 

[webkit-changes] [240180] trunk

[justin_fan]

Title: [240180] trunk








Revision 240180
Author justin_...@apple.com
Date 2019-01-18 15:09:38 -0800 (Fri, 18 Jan 2019)


Log Message
(WIP) [WebGPU] WebGPUProgrammablePassEncoder::setBindGroup prototype
https://bugs.webkit.org/show_bug.cgi?id=193457


Reviewed by Dean Jackson.

Source/WebCore:

Enable WebGPU developers to assign buffer bind groups and access them via render pipeline.

Test: webgpu/buffer-resource-triangles.html

* Modules/webgpu/WebGPUBindGroup.h:
(WebCore::WebGPUBindGroup::bindGroup const): Added getter.
* Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:
(WebCore::WebGPUProgrammablePassEncoder::setBindGroup const): Added. Delegates call to GPUProgrammablePassEncoder.
* Modules/webgpu/WebGPUProgrammablePassEncoder.h: Enable setBindGroup.
* Modules/webgpu/WebGPUProgrammablePassEncoder.idl: ditto.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/GPUBindGroup.h:
(WebCore::GPUBindGroup::layout const): Added getter.
(WebCore::GPUBindGroup::bindings const): ditto.
* platform/graphics/gpu/GPUBindGroupLayout.h: Added ArgumentEncoderBuffer struct to retain ptr to both MTLArgumentEncoders and their argument MTLBuffers.
(WebCore::GPUBindGroupLayout::ArgumentEncoderBuffer::operator! const):
(WebCore::GPUBindGroupLayout::vertexArguments const): Added. Getter.
(WebCore::GPUBindGroupLayout::fragmentArguments const): ditto.
(WebCore::GPUBindGroupLayout::computeArguments const): ditto.
* platform/graphics/gpu/GPUDevice.cpp: Refactored unnecessary header include.
* platform/graphics/gpu/GPUDevice.h: ditto.
* platform/graphics/gpu/GPUProgrammablePassEncoder.h:
(WebCore::GPUProgrammablePassEncoder::setVertexBuffer): Added. Delegates to MTLCommandEncoder call.
(WebCore::GPUProgrammablePassEncoder::setFragmentBuffer): ditto.
* platform/graphics/gpu/GPURenderPassEncoder.h:
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
(WebCore::tryCreateArgumentEncoderAndBuffer): Replace newEncoder(). Now create an ArgumentEncoderBuffer object from an array of MTLArgumentDescriptors, if able.
(WebCore::GPUBindGroupLayout::tryCreate): Refactor to support ArgumentEncoderBuffers, and allocate MTLBuffers for argument encoders.
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout): Support ArgumentEncoderBuffers.
(WebCore::newEncoder): Deleted.
* platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:
(WebCore::GPUCommandBuffer::GPUCommandBuffer):
* platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm:
(WebCore::GPUProgrammablePassEncoder::setResourceAsBufferOnEncoder): Set a buffer resource on the MTLArgumentEncoder, and call useResource on the command encoder.
(WebCore::GPUProgrammablePassEncoder::setBindGroup): Parses the bind group to assign each resource on its matching MTLArgumentEncoder.
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::GPURenderPassEncoder::useResource): Resolves call from GPUProgrammablePassEncoder to call on MTLRenderCommandEncoder.
(WebCore::GPURenderPassEncoder::setVertexBuffer): ditto.
(WebCore::GPURenderPassEncoder::setFragmentBuffer): ditto.

LayoutTests:

Draw 3 triangles via WebGPU to create a green square canvas, with reference.
Each vertex is stored in its own WebGPUBuffer and they are mix/matched per bind group.
This tests multiple resource bindings in one bind group as well as setting multiple
bind groups per draw call and per command encoder.

* webgpu/buffer-resource-triangles-expected.html: Added. Reference generated using 2D canvas.
* webgpu/buffer-resource-triangles.html: Added.
1) Draw top two triangles using two bind groups in one draw call.
2) Swap first bind group and issue second draw call to draw middle triangle.
* webgpu/js/webgpu-functions.js:
(createBasicPipeline): Now handles new primitive topologies.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgpu/js/webgpu-functions.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WebGPUBindGroup.h
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroup.h
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.h
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.h
trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h
trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm


Added Paths

[webkit-changes] [240179] trunk/Source/WebCore

[dbates]

Title: [240179] trunk/Source/WebCore








Revision 240179
Author dba...@webkit.org
Date 2019-01-18 15:05:57 -0800 (Fri, 18 Jan 2019)


Log Message
Another attempt to fix the iOS build following 
(https://bugs.webkit.org/show_bug.cgi?id=193583)

Only override RenderTheme::platformFocusRingColor() when building with ENABLE(FULL_KEYBOARD_ACCESS)
enabled.

* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeIOS.h
trunk/Source/WebCore/rendering/RenderThemeIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (240178 => 240179)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 23:02:55 UTC (rev 240178)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 23:05:57 UTC (rev 240179)
@@ -1,5 +1,16 @@
 2019-01-18  Daniel Bates  
 
+Another attempt to fix the iOS build following 
+(https://bugs.webkit.org/show_bug.cgi?id=193583)
+
+Only override RenderTheme::platformFocusRingColor() when building with ENABLE(FULL_KEYBOARD_ACCESS)
+enabled.
+
+* rendering/RenderThemeIOS.h:
+* rendering/RenderThemeIOS.mm:
+
+2019-01-18  Daniel Bates  
+
 Attempt to fix the iOS build following 
 (https://bugs.webkit.org/show_bug.cgi?id=193583)
 


Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.h (240178 => 240179)

--- trunk/Source/WebCore/rendering/RenderThemeIOS.h	2019-01-18 23:02:55 UTC (rev 240178)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.h	2019-01-18 23:05:57 UTC (rev 240179)
@@ -113,7 +113,9 @@
 
 Color platformActiveSelectionBackgroundColor(OptionSet) const override;
 Color platformInactiveSelectionBackgroundColor(OptionSet) const override;
+#if ENABLE(FULL_KEYBOARD_ACCESS)
 Color platformFocusRingColor(OptionSet) const final;
+#endif
 
 #if ENABLE(TOUCH_EVENTS)
 Color platformTapHighlightColor() const override { return 0x4D1A1A1A; }


Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (240178 => 240179)

--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2019-01-18 23:02:55 UTC (rev 240178)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2019-01-18 23:05:57 UTC (rev 240179)
@@ -1123,10 +1123,12 @@
 return Color::transparent;
 }
 
+#if ENABLE(FULL_KEYBOARD_ACCESS)
 Color RenderThemeIOS::platformFocusRingColor(OptionSet) const
 {
 return colorFromUIColor([PAL::getUIColorClass() keyboardFocusIndicatorColor]);
 }
+#endif
 
 bool RenderThemeIOS::shouldHaveSpinButton(const HTMLInputElement&) const
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240178] trunk

[cdumez]

Title: [240178] trunk








Revision 240178
Author cdu...@apple.com
Date 2019-01-18 15:02:55 -0800 (Fri, 18 Jan 2019)


Log Message
Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
https://bugs.webkit.org/show_bug.cgi?id=193588


Reviewed by Alex Christensen.

Source/WebKit:

When the WebPageProxy needs to create initialization parameters for its WebPage in the
WebContent process, it calls WebProcessProxy::addWebUserContentControllerProxy()
which calls WebUserContentControllerProxy::addProcess(). This last call is supposed to
register the WebProcessProxy with the WebUserContentControllerProxy and adding the
contentRuleLists to the WebPageCreationParameters. The issue is that if the
WebUserContentControllerProxy already knows about this WebProcessProxy, it would return
early and not populate the WebPageCreationParameters.

In PSON world, when navigating back to a page that failed to enter page cache, we reuse
the process where we previously loaded the page but re-create a new WebPage on the
WebContent process site. When this happens, WebUserContentControllerProxy would not
add the contentRuleLists to the WebPageCreationParameters and the new WebPage in the
previously-suspended process would be missing them.

* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::addProcess):

Tools:

Add layout test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (240177 => 240178)

--- trunk/Source/WebKit/ChangeLog	2019-01-18 22:55:56 UTC (rev 240177)
+++ trunk/Source/WebKit/ChangeLog	2019-01-18 23:02:55 UTC (rev 240178)
@@ -1,3 +1,28 @@
+2019-01-18  Chris Dumez  
+
+Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
+https://bugs.webkit.org/show_bug.cgi?id=193588
+
+
+Reviewed by Alex Christensen.
+
+When the WebPageProxy needs to create initialization parameters for its WebPage in the
+WebContent process, it calls WebProcessProxy::addWebUserContentControllerProxy()
+which calls WebUserContentControllerProxy::addProcess(). This last call is supposed to
+register the WebProcessProxy with the WebUserContentControllerProxy and adding the
+contentRuleLists to the WebPageCreationParameters. The issue is that if the
+WebUserContentControllerProxy already knows about this WebProcessProxy, it would return
+early and not populate the WebPageCreationParameters.
+
+In PSON world, when navigating back to a page that failed to enter page cache, we reuse
+the process where we previously loaded the page but re-create a new WebPage on the
+WebContent process site. When this happens, WebUserContentControllerProxy would not
+add the contentRuleLists to the WebPageCreationParameters and the new WebPage in the
+previously-suspended process would be missing them.
+
+* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
+(WebKit::WebUserContentControllerProxy::addProcess):
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp (240177 => 240178)

--- trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp	2019-01-18 22:55:56 UTC (rev 240177)
+++ trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp	2019-01-18 23:02:55 UTC (rev 240178)
@@ -84,11 +84,9 @@
 
 void WebUserContentControllerProxy::addProcess(WebProcessProxy& webProcessProxy, WebPageCreationParameters& parameters)
 {
-if (!m_processes.add().isNewEntry)
-return;
+if (m_processes.add().isNewEntry)
+webProcessProxy.addMessageReceiver(Messages::WebUserContentControllerProxy::messageReceiverName(), identifier().toUInt64(), *this);
 
-webProcessProxy.addMessageReceiver(Messages::WebUserContentControllerProxy::messageReceiverName(), identifier().toUInt64(), *this);
-
 ASSERT(parameters.userContentWorlds.isEmpty());
 for (const auto& world : m_userContentWorlds)
 parameters.userContentWorlds.append(std::make_pair(world.key->identifier(), world.key->name()));


Modified: trunk/Tools/ChangeLog (240177 => 240178)

--- trunk/Tools/ChangeLog	2019-01-18 22:55:56 UTC (rev 240177)
+++ trunk/Tools/ChangeLog	2019-01-18 23:02:55 UTC (rev 240178)
@@ -1,3 +1,15 @@
+2019-01-18  Chris Dumez  
+
+Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
+https://bugs.webkit.org/show_bug.cgi?id=193588
+
+
+Reviewed by Alex Christensen.
+
+Add layout test coverage.
+
+ 

[webkit-changes] [240177] trunk/Source/WebCore

[dbates]

Title: [240177] trunk/Source/WebCore








Revision 240177
Author dba...@webkit.org
Date 2019-01-18 14:55:56 -0800 (Fri, 18 Jan 2019)


Log Message
Attempt to fix the iOS build following 
(https://bugs.webkit.org/show_bug.cgi?id=193583)

Namespace qualify call to getUIColorClass().

* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::platformFocusRingColor const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (240176 => 240177)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 22:53:49 UTC (rev 240176)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 22:55:56 UTC (rev 240177)
@@ -1,3 +1,13 @@
+2019-01-18  Daniel Bates  
+
+Attempt to fix the iOS build following 
+(https://bugs.webkit.org/show_bug.cgi?id=193583)
+
+Namespace qualify call to getUIColorClass().
+
+* rendering/RenderThemeIOS.mm:
+(WebCore::RenderThemeIOS::platformFocusRingColor const):
+
 2019-01-18  Jer Noble  
 
 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds


Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (240176 => 240177)

--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2019-01-18 22:53:49 UTC (rev 240176)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2019-01-18 22:55:56 UTC (rev 240177)
@@ -1125,7 +1125,7 @@
 
 Color RenderThemeIOS::platformFocusRingColor(OptionSet) const
 {
-return colorFromUIColor([getUIColorClass() keyboardFocusIndicatorColor]);
+return colorFromUIColor([PAL::getUIColorClass() keyboardFocusIndicatorColor]);
 }
 
 bool RenderThemeIOS::shouldHaveSpinButton(const HTMLInputElement&) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240176] trunk

[jer . noble]

Title: [240176] trunk








Revision 240176
Author jer.no...@apple.com
Date 2019-01-18 14:53:49 -0800 (Fri, 18 Jan 2019)


Log Message
SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
https://bugs.webkit.org/show_bug.cgi?id=189553

Reviewed by Tim Horton.

.:

* Makefile.shared:

PerformanceTests:

* MediaTime/Configurations/Base.xcconfig:
* MediaTime/Configurations/SDKVariant.xcconfig: Added.

Source/bmalloc:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/_javascript_Core:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.
* Configurations/WebCore.xcconfig:

Source/WebCore/PAL:

* Configurations/Base.xcconfig:
* Configurations/PAL.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/WebInspectorUI:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/WebKit:

* Configurations/Base.xcconfig:
* Configurations/BaseTarget.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.
* Configurations/WebKitLegacy.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/SDKVariant.xcconfig: Added.

Tools:

Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.

* ContentExtensionTester/Configurations/Base.xcconfig:
* ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
* ImageDiff/cg/Configurations/Base.xcconfig:
* ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
* MobileMiniBrowser/Configurations/Base.xcconfig:
* MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
* Scripts/webkitpy/style/checker.py:
(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):
* Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
(SDKVariantChecker):
(SDKVariantChecker.__init__):
(SDKVariantChecker.check):
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
* WebEditingTester/Configurations/Base.xcconfig:
* WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
* WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
* lldb/lldbWebKitTester/Configurations/Base.xcconfig:
* lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.

Modified Paths

trunk/ChangeLog
trunk/Makefile.shared
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/Base.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/Base.xcconfig
trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Configurations/Base.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/Configurations/Base.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/ContentExtensionTester/Configurations/Base.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig
trunk/Tools/MiniBrowser/Configurations/Base.xcconfig
trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig
trunk/Tools/Scripts/webkitpy/style/checker.py
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig
trunk/Tools/WebEditingTester/Configurations/Base.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig
trunk/Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig


Added Paths

trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig

[webkit-changes] [240175] trunk/Source

[keith_miller]

Title: [240175] trunk/Source








Revision 240175
Author keith_mil...@apple.com
Date 2019-01-18 14:48:22 -0800 (Fri, 18 Jan 2019)


Log Message
Gigacages should start allocations from a slide
https://bugs.webkit.org/show_bug.cgi?id=193523

Reviewed by Mark Lam.

Source/bmalloc:

This patch makes it so that Gigacage Heaps slide the start of the
cage by some random amount. We still ensure that there is always
at least 4/2GB, on MacOS/iOS respectively, of VA space available
for allocation.

Also, this patch changes some macros into constants since macros
are the devil.

* bmalloc/Gigacage.cpp:
(Gigacage::bmalloc::protectGigacageBasePtrs):
(Gigacage::bmalloc::unprotectGigacageBasePtrs):
(Gigacage::bmalloc::runwaySize):
(Gigacage::ensureGigacage):
(Gigacage::shouldBeEnabled):
* bmalloc/Gigacage.h:
(Gigacage::name):
(Gigacage::gigacageSizeToMask):
(Gigacage::size):
(Gigacage::mask):
(Gigacage::basePtr):
(Gigacage::ensureGigacage):
(Gigacage::wasEnabled):
(Gigacage::isCaged):
(Gigacage::isEnabled):
(Gigacage::caged):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
* bmalloc/Sizes.h:
(bmalloc::Sizes::maskSizeClass):
(bmalloc::Sizes::maskObjectSize):
(bmalloc::Sizes::logSizeClass):
(bmalloc::Sizes::logObjectSize):
(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize):
(bmalloc::Sizes::pageSize):

Source/_javascript_Core:

This patch changes some macros into constants since macros are the
devil.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
* llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch changes some macros into constants since macros are the
devil.

* wtf/Gigacage.cpp:
* wtf/Gigacage.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Gigacage.cpp
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Gigacage.cpp
trunk/Source/bmalloc/bmalloc/Gigacage.h
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Sizes.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (240174 => 240175)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-18 22:26:37 UTC (rev 240174)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-18 22:48:22 UTC (rev 240175)
@@ -1,3 +1,17 @@
+2019-01-18  Keith Miller  
+
+Gigacages should start allocations from a slide
+https://bugs.webkit.org/show_bug.cgi?id=193523
+
+Reviewed by Mark Lam.
+
+This patch changes some macros into constants since macros are the
+devil.
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::caged):
+* llint/LowLevelInterpreter64.asm:
+
 2019-01-18  Matt Lewis  
 
 Unreviewed, rolling out r240160.


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (240174 => 240175)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-18 22:26:37 UTC (rev 240174)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-01-18 22:48:22 UTC (rev 240175)
@@ -13852,6 +13852,7 @@
 
 LValue caged(Gigacage::Kind kind, LValue ptr)
 {
+#if GIGACAGE_ENABLED
 if (!Gigacage::isEnabled(kind))
 return ptr;
 
@@ -13880,6 +13881,9 @@
 // and possibly other smart things if we want to be able to remove this opaque.
 // https://bugs.webkit.org/show_bug.cgi?id=175493
 return m_out.opaque(result);
+#else
+return ptr;
+#endif
 }
 
 void buildSwitch(SwitchData* data, LType type, LValue switchValue)


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (240174 => 240175)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 22:26:37 UTC (rev 240174)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 22:48:22 UTC (rev 240175)
@@ -1315,7 +1315,7 @@
 arrayProfile(OpGetById::Metadata::m_modeMetadata.arrayLengthMode.arrayProfile, t0, t2, t5)
 btiz t0, IsArray, .opGetByIdSlow
 btiz t0, IndexingShapeMask, .opGetByIdSlow
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, JSObject::m_butterfly[t3], t0, t1)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr Gigacage::jsValueGigacageMask, JSObject::m_butterfly[t3], t0, t1)
 loadi -sizeof IndexingHeader + IndexingHeader::u.lengths.publicLength[t0], t0
 bilt t0, 0, .opGetByIdSlow
 orq tagTypeNumber, t0
@@ -1438,7 +1438,7 @@
 loadConstantOrVariableInt32(size, t3, t1, .opGetByValSlow)
 sxi2q t1, t1
 
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, 

[webkit-changes] [240174] trunk/Source/WebCore

[dbates]

Title: [240174] trunk/Source/WebCore








Revision 240174
Author dba...@webkit.org
Date 2019-01-18 14:26:37 -0800 (Fri, 18 Jan 2019)


Log Message
CSS auto focus-ring outlines don't render on iOS
https://bugs.webkit.org/show_bug.cgi?id=193583


Reviewed by Simon Fraser.

Source/WebCore:

Implement support for drawing focus rings on iOS when built with ENABLE(FULL_KEYBOARD_ACCESS)
enabled.

For now the focus ring drawing for iOS is tangled up into the Mac-specific code to draw
animated focus rings. I will fix this in .

* SourcesCocoa.txt: Add file ColorIOS.mm.
* WebCore.xcodeproj/project.pbxproj: Add files ColorIOS.{h, mm}.

* platform/graphics/GraphicsContext.h:
* platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::drawFocusRingAtTime):
(WebCore::GraphicsContext::drawFocusRing):
Compile focus ring drawing code when building with ENABLE(FULL_KEYBOARD_ACCESS) enabled.
This is always enabled on Mac.

* platform/ios/ColorIOS.h: Added.
* platform/ios/ColorIOS.mm: Added.
(WebCore::colorFromUIColor): Convert a UIColor to a WebCore::Color.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):
Compile focus ring drawing code when building with ENABLE(FULL_KEYBOARD_ACCESS) enabled.
This is always enabled on Mac.

* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::platformFocusRingColor const): Implement this override for iOS.
(WebCore::RenderThemeIOS::supportsFocusRing const): Implement this override for iOS to always
return false - the iOS theme code does not support painting focus rings. By returning false we
will use the platform-independent, non-theme code path to draw focus rings.

Source/WebCore/PAL:

Forward declare some IPI.

* pal/spi/ios/UIKitSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderThemeIOS.h
trunk/Source/WebCore/rendering/RenderThemeIOS.mm


Added Paths

trunk/Source/WebCore/platform/ios/ColorIOS.h
trunk/Source/WebCore/platform/ios/ColorIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (240173 => 240174)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 22:21:02 UTC (rev 240173)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 22:26:37 UTC (rev 240174)
@@ -1,3 +1,45 @@
+2019-01-18  Daniel Bates  
+
+CSS auto focus-ring outlines don't render on iOS
+https://bugs.webkit.org/show_bug.cgi?id=193583
+
+
+Reviewed by Simon Fraser.
+
+Implement support for drawing focus rings on iOS when built with ENABLE(FULL_KEYBOARD_ACCESS)
+enabled.
+
+For now the focus ring drawing for iOS is tangled up into the Mac-specific code to draw
+animated focus rings. I will fix this in .
+
+* SourcesCocoa.txt: Add file ColorIOS.mm.
+* WebCore.xcodeproj/project.pbxproj: Add files ColorIOS.{h, mm}.
+
+* platform/graphics/GraphicsContext.h:
+* platform/graphics/cocoa/GraphicsContextCocoa.mm:
+(WebCore::drawFocusRingAtTime):
+(WebCore::GraphicsContext::drawFocusRing):
+Compile focus ring drawing code when building with ENABLE(FULL_KEYBOARD_ACCESS) enabled.
+This is always enabled on Mac.
+
+* platform/ios/ColorIOS.h: Added.
+* platform/ios/ColorIOS.mm: Added.
+(WebCore::colorFromUIColor): Convert a UIColor to a WebCore::Color.
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::paintFocusRing):
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::paintAreaElementFocusRing):
+Compile focus ring drawing code when building with ENABLE(FULL_KEYBOARD_ACCESS) enabled.
+This is always enabled on Mac.
+
+* rendering/RenderThemeIOS.h:
+* rendering/RenderThemeIOS.mm:
+(WebCore::RenderThemeIOS::platformFocusRingColor const): Implement this override for iOS.
+(WebCore::RenderThemeIOS::supportsFocusRing const): Implement this override for iOS to always
+return false - the iOS theme code does not support painting focus rings. By returning false we
+will use the platform-independent, non-theme code path to draw focus rings.
+
 2019-01-18  David Kilzer  
 
 Follow-up: Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}


Modified: trunk/Source/WebCore/PAL/ChangeLog (240173 => 240174)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 22:21:02 UTC (rev 240173)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-01-18 22:26:37 UTC (rev 240174)
@@ -1,3 +1,15 @@

[webkit-changes] [240173] trunk/Source/WebInspectorUI

[drousso]

Title: [240173] trunk/Source/WebInspectorUI








Revision 240173
Author drou...@apple.com
Date 2019-01-18 14:21:02 -0800 (Fri, 18 Jan 2019)


Log Message
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'resource.finished')
https://bugs.webkit.org/show_bug.cgi?id=193589

Reviewed by Joseph Pecoraro.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.get supportsSave):
(WI.NetworkTableContentView.prototype._HARResources):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (240172 => 240173)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-18 21:33:34 UTC (rev 240172)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-18 22:21:02 UTC (rev 240173)
@@ -1,3 +1,14 @@
+2019-01-18  Devin Rousso  
+
+Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'resource.finished')
+https://bugs.webkit.org/show_bug.cgi?id=193589
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype.get supportsSave):
+(WI.NetworkTableContentView.prototype._HARResources):
+
 2019-01-17  Truitt Savell  
 
 Unreviewed, rolling out r240124.


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (240172 => 240173)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2019-01-18 21:33:34 UTC (rev 240172)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2019-01-18 22:21:02 UTC (rev 240173)
@@ -224,7 +224,7 @@
 
 get supportsSave()
 {
-return this._filteredEntries.some((entry) => entry.resource.finished);
+return this._canExportHAR();
 }
 
 get saveData()
@@ -1890,6 +1890,11 @@
 let resources = this._filteredEntries.map((x) => x.resource);
 const supportedHARSchemes = new Set(["http", "https", "ws", "wss"]);
 return resources.filter((resource) => {
+if (!resource) {
+// DOM node entries are also added to `_filteredEntries`.
+return false;
+}
+
 if (!resource.finished)
 return false;
 if (!resource.requestSentDate)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240172] tags/Safari-607.1.25/

[kocsen_chung]

Title: [240172] tags/Safari-607.1.25/








Revision 240172
Author kocsen_ch...@apple.com
Date 2019-01-18 13:33:34 -0800 (Fri, 18 Jan 2019)


Log Message
Tag Safari-607.1.25.

Added Paths

tags/Safari-607.1.25/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240171] trunk/Source

[jlewis3]

Title: [240171] trunk/Source








Revision 240171
Author jlew...@apple.com
Date 2019-01-18 13:32:32 -0800 (Fri, 18 Jan 2019)


Log Message
Unreviewed, rolling out r240160.

This broke multiple internal builds.

Reverted changeset:

"Gigacages should start allocations from a slide"
https://bugs.webkit.org/show_bug.cgi?id=193523
https://trac.webkit.org/changeset/240160

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Gigacage.cpp
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Gigacage.cpp
trunk/Source/bmalloc/bmalloc/Gigacage.h
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Sizes.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (240170 => 240171)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-18 21:30:07 UTC (rev 240170)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-18 21:32:32 UTC (rev 240171)
@@ -1,3 +1,15 @@
+2019-01-18  Matt Lewis  
+
+Unreviewed, rolling out r240160.
+
+This broke multiple internal builds.
+
+Reverted changeset:
+
+"Gigacages should start allocations from a slide"
+https://bugs.webkit.org/show_bug.cgi?id=193523
+https://trac.webkit.org/changeset/240160
+
 2019-01-18  Keith Miller  
 
 Gigacages should start allocations from a slide


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (240170 => 240171)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 21:30:07 UTC (rev 240170)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 21:32:32 UTC (rev 240171)
@@ -1315,7 +1315,7 @@
 arrayProfile(OpGetById::Metadata::m_modeMetadata.arrayLengthMode.arrayProfile, t0, t2, t5)
 btiz t0, IsArray, .opGetByIdSlow
 btiz t0, IndexingShapeMask, .opGetByIdSlow
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr Gigacage::jsValueGigacageMask, JSObject::m_butterfly[t3], t0, t1)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, JSObject::m_butterfly[t3], t0, t1)
 loadi -sizeof IndexingHeader + IndexingHeader::u.lengths.publicLength[t0], t0
 bilt t0, 0, .opGetByIdSlow
 orq tagTypeNumber, t0
@@ -1438,7 +1438,7 @@
 loadConstantOrVariableInt32(size, t3, t1, .opGetByValSlow)
 sxi2q t1, t1
 
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr Gigacage::jsValueGigacageMask, JSObject::m_butterfly[t0], t3, tagTypeNumber)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, JSObject::m_butterfly[t0], t3, tagTypeNumber)
 move TagTypeNumber, tagTypeNumber
 
 andi IndexingShapeMask, t2
@@ -1504,7 +1504,7 @@
 bia t2, Int8ArrayType - FirstTypedArrayType, .opGetByValUint8ArrayOrUint8ClampedArray
 
 # We have Int8ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, JSArrayBufferView::m_vector[t0], t3, t2)
 loadbs [t3, t1], t0
 finishIntGetByVal(t0, t1)
 
@@ -1512,13 +1512,13 @@
 bia t2, Uint8ArrayType - FirstTypedArrayType, .opGetByValUint8ClampedArray
 
 # We have Uint8ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, JSArrayBufferView::m_vector[t0], t3, t2)
 loadb [t3, t1], t0
 finishIntGetByVal(t0, t1)
 
 .opGetByValUint8ClampedArray:
 # We have Uint8ClampedArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, JSArrayBufferView::m_vector[t0], t3, t2)
 loadb [t3, t1], t0
 finishIntGetByVal(t0, t1)
 
@@ -1527,13 +1527,13 @@
 bia t2, Int16ArrayType - FirstTypedArrayType, .opGetByValUint16Array
 
 # We have Int16ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, JSArrayBufferView::m_vector[t0], t3, t2)
 loadhs [t3, t1, 2], t0
 finishIntGetByVal(t0, t1)
 
 .opGetByValUint16Array:
 # We have Uint16ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + 

[webkit-changes] [240170] branches/safari-607-branch

[kocsen_chung]

Title: [240170] branches/safari-607-branch








Revision 240170
Author kocsen_ch...@apple.com
Date 2019-01-18 13:30:07 -0800 (Fri, 18 Jan 2019)


Log Message
Cherry-pick r240118. rdar://problem/47394122

[Win] gperf command not found
https://bugs.webkit.org/show_bug.cgi?id=193538


Reviewed by Brent Fulgham.

CMake only searches for gperf if ENABLE_WEBCORE is on. ENABLE_WEBCORE needs to be set to ON.

* Source/cmake/OptionsAppleWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-607-branch/ChangeLog
branches/safari-607-branch/Source/cmake/OptionsAppleWin.cmake




Diff

Modified: branches/safari-607-branch/ChangeLog (240169 => 240170)

--- branches/safari-607-branch/ChangeLog	2019-01-18 21:16:33 UTC (rev 240169)
+++ branches/safari-607-branch/ChangeLog	2019-01-18 21:30:07 UTC (rev 240170)
@@ -1,3 +1,32 @@
+2019-01-18  Kocsen Chung  
+
+Cherry-pick r240118. rdar://problem/47394122
+
+[Win] gperf command not found
+https://bugs.webkit.org/show_bug.cgi?id=193538
+
+
+Reviewed by Brent Fulgham.
+
+CMake only searches for gperf if ENABLE_WEBCORE is on. ENABLE_WEBCORE needs to be set to ON.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-17  Per Arne Vollan  
+
+[Win] gperf command not found
+https://bugs.webkit.org/show_bug.cgi?id=193538
+
+
+Reviewed by Brent Fulgham.
+
+CMake only searches for gperf if ENABLE_WEBCORE is on. ENABLE_WEBCORE needs to be set to ON.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
 2018-12-30  Yusuke Suzuki  
 
 gperf is only used in WebCore


Modified: branches/safari-607-branch/Source/cmake/OptionsAppleWin.cmake (240169 => 240170)

--- branches/safari-607-branch/Source/cmake/OptionsAppleWin.cmake	2019-01-18 21:16:33 UTC (rev 240169)
+++ branches/safari-607-branch/Source/cmake/OptionsAppleWin.cmake	2019-01-18 21:30:07 UTC (rev 240170)
@@ -4,6 +4,8 @@
 
 include(OptionsWin)
 
+set(ENABLE_WEBCORE ON)
+
 SET_AND_EXPOSE_TO_BUILD(USE_CF ON)
 SET_AND_EXPOSE_TO_BUILD(USE_CFURLCONNECTION ON)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240169] trunk/Source/WebCore

[ddkilzer]

Title: [240169] trunk/Source/WebCore








Revision 240169
Author ddkil...@apple.com
Date 2019-01-18 13:16:33 -0800 (Fri, 18 Jan 2019)


Log Message
Follow-up: Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}



* editing/cocoa/DictionaryLookup.mm:
(-[WebRevealHighlight drawHighlightContentForItem:context:]):
Fix the build by changing getUIApplicationClass() to
PAL::getUIApplicationClass().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (240168 => 240169)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 20:41:58 UTC (rev 240168)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 21:16:33 UTC (rev 240169)
@@ -1,5 +1,16 @@
 2019-01-18  David Kilzer  
 
+Follow-up: Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
+
+
+
+* editing/cocoa/DictionaryLookup.mm:
+(-[WebRevealHighlight drawHighlightContentForItem:context:]):
+Fix the build by changing getUIApplicationClass() to
+PAL::getUIApplicationClass().
+
+2019-01-18  David Kilzer  
+
 Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
 
 


Modified: trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm (240168 => 240169)

--- trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm	2019-01-18 20:41:58 UTC (rev 240168)
+++ trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm	2019-01-18 21:16:33 UTC (rev 240169)
@@ -239,7 +239,7 @@
 WebCore::CGContextStateSaver saveState(context);
 CGAffineTransform contextTransform = CGContextGetCTM(context);
 CGFloat backingScale = contextTransform.a;
-CGFloat iOSMacScaleFactor = [getUIApplicationClass() sharedApplication]._iOSMacScale;
+CGFloat iOSMacScaleFactor = [PAL::getUIApplicationClass() sharedApplication]._iOSMacScale;
 CGAffineTransform transform = CGAffineTransformMakeScale(iOSMacScaleFactor * backingScale, iOSMacScaleFactor * backingScale);
 CGContextSetCTM(context, transform);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240168] trunk

[ddkilzer]

Title: [240168] trunk








Revision 240168
Author ddkil...@apple.com
Date 2019-01-18 12:41:58 -0800 (Fri, 18 Jan 2019)


Log Message
Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}



Reviewed by Alex Christensen.

Source/WebCore:

This does the following:
- Removes local soft-linking of UIKit.
- Switches to using PAL functions for soft-linking.

* SourcesCocoa.txt: Add 4 source files to UnifiedSources.
* WebCore.xcodeproj/project.pbxproj: Remove 4 sources files
from WebCore target now that they are in UnifiedSources.
* editing/cocoa/DictionaryLookup.mm:
* editing/cocoa/HTMLConverter.mm: Move SPI to UIKitSPI.h. Remove
declarations in public headers.
(_fontForNameAndSize): Change use of getUIFontClass() to
PlatformFontClass.
(HTMLConverter::_processElement): Add cast here since compiler
finds the wrong selector for +clearColor and thinks it returns a
`CIColor *` object.  The same cast already exists in
VideoFullscreenInterfaceAVKit.mm.
* page/cocoa/SettingsBaseCocoa.mm:
(WebCore::SettingsBase::defaultTextAutosizingEnabled):
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::exernalDeviceDisplayNameForPlayer):
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
* platform/ios/DragImageIOS.mm:
(WebCore::scaleDragImage):
(WebCore::createDragImageFromImage):
(WebCore::cascadeForSystemFont):
(WebCore::createDragImageForLink):
(WebCore::createDragImageForSelection):
(WebCore::createDragImageForRange):
(WebCore::createDragImageForColor):
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::color):
(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::setColor):
* platform/ios/ThemeIOS.mm:
(WebCore::ThemeIOS::userPrefersReducedMotion const):
* platform/ios/UserAgentIOS.mm:
(WebCore::isClassic):
(WebCore::isClassicPad):
(WebCore::isClassicPhone):
* platform/ios/ValidationBubbleIOS.mm:
(-[WebValidationBubbleTapRecognizer initWithPopoverController:]):
(WebCore::ValidationBubble::ValidationBubble):
(WebCore::ValidationBubble::show):
(WebCore::fallbackViewController):
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(clearUIColor):
(allocWebAVPictureInPicturePlayerLayerViewInstance):
(WebAVPlayerLayerView_videoView):
(fallbackViewController):
(VideoFullscreenInterfaceAVKit::doSetup):
* platform/ios/WebEvent.mm:
(+[WebEvent modifierFlags]):
* platform/ios/WebItemProviderPasteboard.mm:
(allLoadableClasses):
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::setUpFullscreen):
* platform/network/mac/WebCoreURLResponse.mm: Add missing header
after unified sources were updated.
* rendering/RenderThemeIOS.mm:
(WebCore::contentSizeCategoryDidChange):
(WebCore::RenderThemeIOS::RenderThemeIOS):
(WebCore::RenderThemeIOS::contentSizeCategory):
(WebCore::RenderThemeIOS::systemColor const):
(WebCore::attachmentActionColor):
(WebCore::attachmentTitleColor):
(WebCore::attachmentSubtitleColor):
(WebCore::iconForAttachment):
* testing/Internals.mm:
(WebCore::Internals::userPrefersReducedMotion const):

Source/WebCore/PAL:

* pal/ios/UIKitSoftLink.h:
* pal/ios/UIKitSoftLink.mm:
- Add constants, classes and functions that were previously
  soft-linked in separate source files.
- UIAccessibilityAnnouncementNotification is declared as a
  variable because this constant is not marked as `const` in
  UIKit.
* pal/spi/ios/UIKitSPI.h:
- Move SPI declarations from HTMLConverter.mm to here.

Source/WebKitLegacy/mac:

* WebView/WebView.mm:
- Remove unused soft-linking macros.
(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
(-[WebUITextIndicatorData initWithImage:scale:]):
- Update to use exported PAL functions.

Tools:

Make sure no one re-introduces UIKit soft-linking by adding a
style rule.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Add softlink/uikit check.
(CppChecker): Enable softlink/uikit check.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest): Add test for softlink/uikit.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/ios/UIKitSoftLink.h
trunk/Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm
trunk/Source/WebCore/page/cocoa/SettingsBaseCocoa.mm
trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm
trunk/Source/WebCore/platform/ios/DragImageIOS.mm

[webkit-changes] [240167] trunk/Websites/bugs.webkit.org

[commit-queue]

Title: [240167] trunk/Websites/bugs.webkit.org








Revision 240167
Author commit-qu...@webkit.org
Date 2019-01-18 12:39:32 -0800 (Fri, 18 Jan 2019)


Log Message
Update Bugzilla running on bugs.webkit.org and bugs.webkit-uat.org to version 5.0.4
https://bugs.webkit.org/show_bug.cgi?id=193477


Patch by Ling Ho  on 2019-01-18
Reviewed by Lucas Forschler.

* Bugzilla/Config.pm:
(write_params):
(read_param_file):
* Bugzilla/Constants.pm:
* Bugzilla/DB/Sqlite.pm:
(sql_date_format):
* Bugzilla/Install/Filesystem.pm:
(update_filesystem):
(_update_old_mining_filenames):
* Bugzilla/Install/Requirements.pm:
(REQUIRED_MODULES):
* Bugzilla/JobQueue.pm:
(subprocess_worker):
(kill_worker):
* Bugzilla/Migrate.pm:
(parse_date):
* Bugzilla/Template.pm:
(_concatenate_css):
(_concatenate_js):
* Bugzilla/Util.pm:
(read_text):
(write_text):
(datetime_from):
* contrib/jb2bz.py:
(process_reply_file):
(maybe_add_attachment):
(process_text_plain):
(process_multi_part):
(process_jitterbug):
(process_mime_body): Deleted.
* docs/en/rst/conf.py:
* docs/en/rst/installing/linux.rst:
* docs/en/rst/installing/mac-os-x.rst:
* docs/en/rst/installing/migrating-from-2.inc.rst:
* docs/en/rst/installing/migrating.rst:
* docs/en/rst/installing/quick-start.rst:
* docs/en/rst/installing/upgrading-with-git.rst:
* docs/en/rst/installing/windows.rst:
* docs/en/rst/integrating/extensions.rst:
* docs/en/rst/integrating/skins.rst:
* editflagtypes.cgi:
(get_products_and_components):
* taskgraph.json:
* template/en/default/pages/release-notes.html.tmpl:

Modified Paths

trunk/Websites/bugs.webkit.org/Bugzilla/Config.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Constants.pm
trunk/Websites/bugs.webkit.org/Bugzilla/DB/Sqlite.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Install/Filesystem.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Install/Requirements.pm
trunk/Websites/bugs.webkit.org/Bugzilla/JobQueue.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Migrate.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Template.pm
trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/contrib/jb2bz.py
trunk/Websites/bugs.webkit.org/docs/en/rst/conf.py
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/linux.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/mac-os-x.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/migrating-from-2.inc.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/migrating.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/quick-start.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/upgrading-with-git.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/installing/windows.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/integrating/extensions.rst
trunk/Websites/bugs.webkit.org/docs/en/rst/integrating/skins.rst
trunk/Websites/bugs.webkit.org/editflagtypes.cgi
trunk/Websites/bugs.webkit.org/taskgraph.json
trunk/Websites/bugs.webkit.org/template/en/default/pages/release-notes.html.tmpl




Diff

Modified: trunk/Websites/bugs.webkit.org/Bugzilla/Config.pm (240166 => 240167)

--- trunk/Websites/bugs.webkit.org/Bugzilla/Config.pm	2019-01-18 20:39:24 UTC (rev 240166)
+++ trunk/Websites/bugs.webkit.org/Bugzilla/Config.pm	2019-01-18 20:39:32 UTC (rev 240167)
@@ -16,10 +16,9 @@
 
 use Bugzilla::Constants;
 use Bugzilla::Hook;
-use Bugzilla::Util qw(trick_taint);
+use Bugzilla::Util qw(trick_taint read_text write_text);
 
 use JSON::XS;
-use File::Slurp;
 use File::Temp;
 use File::Basename;
 
@@ -284,7 +283,7 @@
 my $param_file = bz_locations()->{'datadir'} . '/params.json';
 
 my $json_data = JSON::XS->new->canonical->pretty->encode($param_data);
-write_file($param_file, { binmode => ':utf8', atomic => 1 }, \$json_data);
+write_text($param_file, $json_data);
 
 # It's not common to edit parameters and loading
 # Bugzilla::Install::Filesystem is slow.
@@ -301,8 +300,8 @@
 my $file = bz_locations()->{'datadir'} . '/params.json';
 
 if (-e $file) {
-my $data;
-read_file($file, binmode => ':utf8', buf_ref => \$data);
+my $data = ""
+trick_taint($data);
 
 # If params.json has been manually edited and e.g. some quotes are
 # missing, we don't want JSON::XS to leak the content of the file


Modified: trunk/Websites/bugs.webkit.org/Bugzilla/Constants.pm (240166 => 240167)

--- trunk/Websites/bugs.webkit.org/Bugzilla/Constants.pm	2019-01-18 20:39:24 UTC (rev 240166)
+++ trunk/Websites/bugs.webkit.org/Bugzilla/Constants.pm	2019-01-18 20:39:32 UTC (rev 240167)
@@ -201,7 +201,7 @@
 # CONSTANTS
 #
 # Bugzilla version
-use constant BUGZILLA_VERSION => "5.0.3";
+use constant BUGZILLA_VERSION => "5.0.4";
 
 # A base link to the current REST Documentation. We place it here
 # as it will need to be updated to whatever the current release is.


Modified: trunk/Websites/bugs.webkit.org/Bugzilla/DB/Sqlite.pm (240166 => 240167)

--- trunk/Websites/bugs.webkit.org/Bugzilla/DB/Sqlite.pm	2019-01-18 20:39:24 UTC (rev 

[webkit-changes] [240166] branches/safari-607-branch/Source/WebKit

[timothy_horton]

Title: [240166] branches/safari-607-branch/Source/WebKit








Revision 240166
Author timothy_hor...@apple.com
Date 2019-01-18 12:39:24 -0800 (Fri, 18 Jan 2019)


Log Message
REGRESSION (r236935): Holding down arrow key does not cause repeated DOM keydown events on device
https://bugs.webkit.org/show_bug.cgi?id=191408


Rubber-stamped by Simon Fraser.

* SourcesCocoa.txt:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByContentOffset:]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView scrollViewWillStartPanOrPinchGesture]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView keyCommands]):
(-[WKContentView _arrowKeyForWebView:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
(-[WKContentView _scrollOffsetForEvent:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]): Deleted.
(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:]): Deleted.
(-[WKContentView keyboardScrollViewAnimatorWillScroll:]): Deleted.
(-[WKContentView keyboardScrollViewAnimatorDidFinishScrolling:]): Deleted.
* UIProcess/ios/WKKeyboardScrollingAnimator.h: Removed.
* UIProcess/ios/WKKeyboardScrollingAnimator.mm: Removed.
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView dealloc]):
(-[WKPDFView web_handleKeyEvent:]):
(-[WKPDFView web_initWithFrame:webView:mimeType:]):
* WebKit.xcodeproj/project.pbxproj:
Revert WKKeyboardScrollingAnimator.

Modified Paths

branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/SourcesCocoa.txt
branches/safari-607-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-607-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
branches/safari-607-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
branches/safari-607-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-607-branch/Source/WebKit/UIProcess/ios/WKPDFView.mm
branches/safari-607-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Removed Paths

branches/safari-607-branch/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h
branches/safari-607-branch/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm




Diff

Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240165 => 240166)

--- branches/safari-607-branch/Source/WebKit/ChangeLog	2019-01-18 20:38:28 UTC (rev 240165)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog	2019-01-18 20:39:24 UTC (rev 240166)
@@ -1,3 +1,39 @@
+2019-01-18  Tim Horton  
+
+REGRESSION (r236935): Holding down arrow key does not cause repeated DOM keydown events on device
+https://bugs.webkit.org/show_bug.cgi?id=191408
+
+
+Rubber-stamped by Simon Fraser.
+
+* SourcesCocoa.txt:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _scrollByContentOffset:]):
+* UIProcess/API/Cocoa/WKWebViewInternal.h:
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView setupInteraction]):
+(-[WKContentView cleanupInteraction]):
+(-[WKContentView scrollViewWillStartPanOrPinchGesture]):
+(-[WKContentView canPerformActionForWebView:withSender:]):
+(-[WKContentView keyCommands]):
+(-[WKContentView _arrowKeyForWebView:]):
+(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
+(-[WKContentView _scrollOffsetForEvent:]):
+(-[WKContentView _interpretKeyEvent:isCharEvent:]):
+(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]): Deleted.
+(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:]): Deleted.
+(-[WKContentView keyboardScrollViewAnimatorWillScroll:]): Deleted.
+(-[WKContentView keyboardScrollViewAnimatorDidFinishScrolling:]): Deleted.
+* UIProcess/ios/WKKeyboardScrollingAnimator.h: Removed.
+* UIProcess/ios/WKKeyboardScrollingAnimator.mm: Removed.
+* UIProcess/ios/WKPDFView.mm:
+(-[WKPDFView dealloc]):
+(-[WKPDFView web_handleKeyEvent:]):
+(-[WKPDFView web_initWithFrame:webView:mimeType:]):
+* WebKit.xcodeproj/project.pbxproj:
+Revert WKKeyboardScrollingAnimator.
+
 2019-01-16  Alan Coon  
 
 Apply patch. rdar://problem/47260377


Modified: branches/safari-607-branch/Source/WebKit/SourcesCocoa.txt (240165 => 240166)

--- branches/safari-607-branch/Source/WebKit/SourcesCocoa.txt	2019-01-18 20:38:28 UTC (rev 240165)
+++ branches/safari-607-branch/Source/WebKit/SourcesCocoa.txt	2019-01-18 20:39:24 UTC (rev 240166)
@@ -395,7 +395,6 @@
 UIProcess/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm
 UIProcess/ios/WKInkPickerView.mm
 UIProcess/ios/WKInspectorNodeSearchGestureRecognizer.mm

[webkit-changes] [240164] releases/WebKitGTK/webkit-2.22

[mcatanzaro]

Title: [240164] releases/WebKitGTK/webkit-2.22








Revision 240164
Author mcatanz...@igalia.com
Date 2019-01-18 12:28:42 -0800 (Fri, 18 Jan 2019)


Log Message
Merge r240158 - FetchResponse::url should return the empty string for tainted responses
https://bugs.webkit.org/show_bug.cgi?id=193553

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
(fetchNoCors):

Source/WebCore:

Check whether the response is tainted in FetchResponse::url, to match
the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.

* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::url const):

LayoutTests:

* http/wpt/fetch/response-opaque-clone.html:

Modified Paths

releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html
releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (240163 => 240164)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog	2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog	2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,12 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+* http/wpt/fetch/response-opaque-clone.html:
+
 2019-01-04  Brent Fulgham  
 
 Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox


Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html (240163 => 240164)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html	2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html	2019-01-18 20:28:42 UTC (rev 240164)
@@ -16,6 +16,7 @@
 assert_equals(response.type, "opaque", testName + " type");
 assert_equals(response.status, 0, testName + " status");
 assert_equals(response.statusText, "", testName + " statusText");
+assert_equals(response.url, "", testName + " url");
 assert_false(response.redirected, testName + " redirected");
 assert_true(response.headers.values().next().done, testName + " headers");
 assert_equals(response.body, null, testName + " opaque response body should be null");


Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog (240163 => 240164)

--- releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog	2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog	2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,13 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+(fetchNoCors):
+
 2018-09-15  Rob Buis  
 
 XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response


Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (240163 => 240164)

--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,16 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+Check whether the response is tainted in FetchResponse::url, to match
+the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::url const):
+
 2019-01-04  Brent Fulgham  
 
 Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox


Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp (240163 => 240164)

--- releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp	2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp	2019-01-18 20:28:42 UTC (rev 240164)
@@ -205,7 +205,7 @@
 const String& FetchResponse::url() const
 {
 if (m_responseURL.isNull()) {
-URL url = ""
+URL url = ""
 url.removeFragmentIdentifier();
 m_responseURL = url.string();
 }

[webkit-changes] [240163] trunk/Tools

[jbedard]

Title: [240163] trunk/Tools








Revision 240163
Author jbed...@apple.com
Date 2019-01-18 12:12:38 -0800 (Fri, 18 Jan 2019)


Log Message
webkitpy: Add iPhone and iPad ports
https://bugs.webkit.org/show_bug.cgi?id=193537


Reviewed by Lucas Forschler.

Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
ports. Note that this separation is optional, the --ios-simulator command remains.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_device_type_test_division): Drive-by fix.
(RunTest.test_device_type_specific_listing): Ditto.
(RunTest.test_ipad_test_division):
(RunTest):
(RunTest.test_ipad_listing):
* Scripts/webkitpy/port/factory.py:
(platform_options): Add --iphone-simulator and --ipad-simulator flags.
(PortFactory):
* Scripts/webkitpy/port/ios_simulator.py:
(IPhoneSimulatorPort):
(IPadSimulatorPort):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/Scripts/webkitpy/port/factory.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py




Diff

Modified: trunk/Tools/ChangeLog (240162 => 240163)

--- trunk/Tools/ChangeLog	2019-01-18 20:07:44 UTC (rev 240162)
+++ trunk/Tools/ChangeLog	2019-01-18 20:12:38 UTC (rev 240163)
@@ -1,3 +1,27 @@
+2019-01-18  Jonathan Bedard  
+
+webkitpy: Add iPhone and iPad ports
+https://bugs.webkit.org/show_bug.cgi?id=193537
+
+
+Reviewed by Lucas Forschler.
+
+Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
+ports. Note that this separation is optional, the --ios-simulator command remains.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(RunTest.test_device_type_test_division): Drive-by fix.
+(RunTest.test_device_type_specific_listing): Ditto.
+(RunTest.test_ipad_test_division):
+(RunTest):
+(RunTest.test_ipad_listing):
+* Scripts/webkitpy/port/factory.py:
+(platform_options): Add --iphone-simulator and --ipad-simulator flags.
+(PortFactory):
+* Scripts/webkitpy/port/ios_simulator.py:
+(IPhoneSimulatorPort):
+(IPadSimulatorPort):
+
 2019-01-18  Chris Dumez  
 
 Regression(PSON) Scroll position is not always restored properly when navigating back


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (240162 => 240163)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2019-01-18 20:07:44 UTC (rev 240162)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2019-01-18 20:12:38 UTC (rev 240163)
@@ -28,18 +28,8 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import codecs
 import json
-import logging
-import os
-import platform
-import Queue
-import re
 import StringIO
-import sys
-import thread
-import time
-import threading
 import unittest
 
 from webkitpy.common.system import outputcapture, path
@@ -48,12 +38,9 @@
 from webkitpy.common.host import Host
 from webkitpy.common.host_mock import MockHost
 
-from webkitpy import port
 from webkitpy.layout_tests import run_webkit_tests
 from webkitpy.layout_tests.models.test_run_results import INTERRUPTED_EXIT_STATUS
-from webkitpy.port import Port
 from webkitpy.port import test
-from webkitpy.test.skip import skip_if
 from webkitpy.xcode.device_type import DeviceType
 
 
@@ -857,7 +844,7 @@
 for line in logging.getvalue():
 if str(DeviceType.from_string('iPhone SE')) in line:
 self.assertTrue('Skipping 2 tests' in line)
-elif str(DeviceType.from_string('iPhone (5th generation)')) in line:
+elif str(DeviceType.from_string('iPad (5th generation)')) in line:
 self.assertTrue('Skipping 1 test' in line)
 elif str(DeviceType.from_string('iPhone 7')) in line:
 self.assertTrue('Skipping 0 tests' in line)
@@ -881,7 +868,7 @@
 current_type = None
 by_type = {}
 for line in output.splitlines():
-if not line:
+if not line or 'skip' in line:
 continue
 if 'Tests to run' in line:
 current_type = DeviceType.from_string(line.split('for ')[-1].split(' running')[0]) if 'for ' in line else None
@@ -894,7 +881,60 @@
 self.assertEqual(1, len(by_type[DeviceType.from_string('iPad (5th generation)')]))
 self.assertEqual(0, len(by_type[DeviceType.from_string('iPhone 7')]))
 
+def test_ipad_test_division(self):
+host = MockHost()
+port = host.port_factory.get('ipad-simulator')
 
+host.filesystem.write_text_file('/mock-checkout/LayoutTests/test1.html', '')
+

[webkit-changes] [240162] trunk

[antti]

Title: [240162] trunk








Revision 240162
Author an...@apple.com
Date 2019-01-18 12:07:44 -0800 (Fri, 18 Jan 2019)


Log Message
Implement asynchronous frame scrolling for iOS
https://bugs.webkit.org/show_bug.cgi?id=193539


Reviewed by Simon Fraser.

Source/WebCore:

This patch implements UIScrollView based frame scrolling on iOS, enabled by the "Async Frame Scrolling"
internal setting (still off by default).

* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollLayer const): Deleted.
* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::setScrollPosition):

Export ScrollingTreeFrameScrollingNodeIOS.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::visibleRectForLayerFlushing const):
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateScrollLayerClipping):

If we don't have a separate clip layer, just resize and position the scroll layer.

(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):

Use GraphicsLayer::Type::Scrolling as the scroll layer type when async frame scrolling is enabled.
Don't create a separate clip layer since the scroll layer will handle clipping.

* rendering/RenderLayerCompositor.h:

Source/WebKit:

Add a scrolling node type that can handle UIScrollView backed frames.
It basically just instantiates and forwards to the existing ScrollingTreeScrollingNodeDelegateIOS.

* UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createScrollingTreeNode):
* UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
* UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h: Added.
* UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm: Added.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::create):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::ScrollingTreeFrameScrollingNodeRemoteIOS):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::~ScrollingTreeFrameScrollingNodeRemoteIOS):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateBeforeChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateAfterChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateLayersAfterAncestorChange):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::scrollPosition const):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::setScrollLayerPosition):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateLayersAfterDelegatedScroll):
* WebKit.xcodeproj/project.pbxproj:

LayoutTests:

* platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h
trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (240161 => 240162)

--- trunk/LayoutTests/ChangeLog	2019-01-18 19:47:33 UTC (rev 240161)
+++ trunk/LayoutTests/ChangeLog	2019-01-18 20:07:44 UTC (rev 240162)
@@ -1,3 +1,13 @@
+2019-01-18  Antti Koivisto  
+
+Implement asynchronous frame scrolling for iOS
+https://bugs.webkit.org/show_bug.cgi?id=193539
+
+
+Reviewed by Simon Fraser.
+
+* platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:
+
 2019-01-18  Ali Juma  
 
 FetchResponse::url should return the empty string for tainted responses


Modified: trunk/LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt (240161 => 240162)

--- trunk/LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt	2019-01-18 19:47:33 UTC (rev 240161)
+++ trunk/LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt	2019-01-18 20:07:44 UTC (rev 240162)
@@ -40,51 +40,41 @@
   (contentsScale 2.00)
   (children 1
 (GraphicsLayer
- 

[webkit-changes] [240161] trunk

[cdumez]

Title: [240161] trunk








Revision 240161
Author cdu...@apple.com
Date 2019-01-18 11:47:33 -0800 (Fri, 18 Jan 2019)


Log Message
Regression(PSON) Scroll position is not always restored properly when navigating back
https://bugs.webkit.org/show_bug.cgi?id=193578


Reviewed by Tim Horton.

Source/WebKit:

Fix issues causing the scroll position to not be restored at all (or incorrectly) when
navigating back cross-site with PSON enabled. Also make sure that the swipe gesture
snapshot really stays up until we've restored the scroll position.

Note that even after those changes, I can still sometimes reproduce a white flash when
swiping back to Google search results (scroll position being correct now). This is
tracked by  and happens even if I disable PSON entirely.

* Shared/SessionState.cpp:
(WebKit::FrameState::encode const):
(WebKit::FrameState::decode):
* Shared/SessionState.h:
* WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFrameState):
(WebKit::applyFrameState):
obscuredInsets is present on the HistoryItem in the WebProcess but was never passed to
or stored by the UIProcess on the WebBackForwardListItem. obscuredInsets is needed to
properly restore the scrollPosition (position was 70px off on my iPad without this).
With PSON enabled, if you swipe back cross-process and the previous page was not put
into PageCache, then the HistoryItem is gone on the WebProcess side. What happens is
that the UIProcess sends its WebBackForwardListItem to the WebProcess, which restores
the HistoryItem there, and then asks it to load it. The obscuredInsets was getting lost
in the process since the UIProcess never knew about it.

* UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::didReachMainFrameLoadTerminalState):
Drop logic that was causing the ViewGestureController to not wait for the scroll position
to be restored before taking down the snapshot, when UI-side compositing is enabled.
If you look at the comment above the code, you'll see that the code in question was meant
to impact only the non-UI side compositing code path. As a matter of fact, when the code
was reviewed at https://bugs.webkit.org/show_bug.cgi?id=151224, it was protected by a
#if PLATFORM(MAC), before getting modified the wrong way before landing. In practice, we
would have often restored the scroll position by the time the load is finished so it would
not cause a flash in most cases. However, with PSON enabled and the layer tree freezing we
do on process-swap, the first post-scroll restoration layer tree commit may now occur a
little bit later and we would lose the race more often.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::updateBackForwardItem):
* UIProcess/WebProcessProxy.h:
When adding PageCache support to PSON, we used to navigate the "suspended" page to
about:blank. This would lead to unwanted WebProcessProxy::updateBackForwardItem()
calls from the WebProcess which we wanted to ignore. We thus added logic to ignore
updateBackForwardItem() IPC from the old WebProcess after a swap. The issue with this
is that we sometimes miss/ignore legit updates to the HistoryItem from the old process,
in particular with regards to the scroll position and the pageScaleFactor. So if you
swiped and then quickly enough did a cross-site navigation, the UIProcess'
WebBackForwardList would not get updated with the latest scroll position and we would
thus fail to restore it later on. To address the issue, we now stop ignoring updates
from the old WebProcess after a swap. This logic is no longer needed since we no longer
navigate the old page to about:blank after a swap, we merely suspend it "in place".

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/SessionState.cpp
trunk/Source/WebKit/Shared/SessionState.h
trunk/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (240160 => 240161)

--- trunk/Source/WebKit/ChangeLog	2019-01-18 19:38:56 UTC (rev 240160)
+++ trunk/Source/WebKit/ChangeLog	2019-01-18 19:47:33 UTC (rev 240161)
@@ -1,3 +1,63 @@
+2019-01-18  Chris Dumez  
+
+Regression(PSON) Scroll position is not always restored properly when navigating back
+https://bugs.webkit.org/show_bug.cgi?id=193578
+
+
+Reviewed by Tim Horton.
+
+Fix issues causing the scroll position to not be restored at all (or incorrectly) when
+navigating back cross-site with PSON enabled. Also make sure that the swipe gesture
+snapshot really stays up until we've restored the scroll position.
+
+Note that even after those changes, I can 

[webkit-changes] [240160] trunk/Source

[keith_miller]

Title: [240160] trunk/Source








Revision 240160
Author keith_mil...@apple.com
Date 2019-01-18 11:38:56 -0800 (Fri, 18 Jan 2019)


Log Message
Gigacages should start allocations from a slide
https://bugs.webkit.org/show_bug.cgi?id=193523

Reviewed by Mark Lam.

Source/bmalloc:

This patch makes it so that Gigacage Heaps slide the start of the
cage by some random amount. We still ensure that there is always
at least 4/2GB, on MacOS/iOS respectively, of VA space available
for allocation.

Also, this patch changes some macros into constants since macros
are the devil.

* bmalloc/Gigacage.cpp:
(Gigacage::bmalloc::protectGigacageBasePtrs):
(Gigacage::bmalloc::unprotectGigacageBasePtrs):
(Gigacage::bmalloc::runwaySize):
(Gigacage::ensureGigacage):
(Gigacage::shouldBeEnabled):
* bmalloc/Gigacage.h:
(Gigacage::name):
(Gigacage::gigacageSizeToMask):
(Gigacage::size):
(Gigacage::mask):
(Gigacage::basePtr):
(Gigacage::ensureGigacage):
(Gigacage::wasEnabled):
(Gigacage::isCaged):
(Gigacage::caged):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
* bmalloc/Sizes.h:
(bmalloc::Sizes::maskSizeClass):
(bmalloc::Sizes::maskObjectSize):
(bmalloc::Sizes::logSizeClass):
(bmalloc::Sizes::logObjectSize):
(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize):
(bmalloc::Sizes::pageSize):

Source/_javascript_Core:

This patch changes some macros into constants since macros are the
devil.

* llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch changes some macros into constants since macros are the
devil.

* wtf/Gigacage.cpp:
* wtf/Gigacage.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Gigacage.cpp
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Gigacage.cpp
trunk/Source/bmalloc/bmalloc/Gigacage.h
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Sizes.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (240159 => 240160)

--- trunk/Source/_javascript_Core/ChangeLog	2019-01-18 19:10:04 UTC (rev 240159)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-18 19:38:56 UTC (rev 240160)
@@ -1,3 +1,15 @@
+2019-01-18  Keith Miller  
+
+Gigacages should start allocations from a slide
+https://bugs.webkit.org/show_bug.cgi?id=193523
+
+Reviewed by Mark Lam.
+
+This patch changes some macros into constants since macros are the
+devil.
+
+* llint/LowLevelInterpreter64.asm:
+
 2019-01-17  Mark Lam  
 
 Audit bytecode fields and ensure that LLInt instructions for accessing them are appropriate.


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (240159 => 240160)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 19:10:04 UTC (rev 240159)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2019-01-18 19:38:56 UTC (rev 240160)
@@ -1315,7 +1315,7 @@
 arrayProfile(OpGetById::Metadata::m_modeMetadata.arrayLengthMode.arrayProfile, t0, t2, t5)
 btiz t0, IsArray, .opGetByIdSlow
 btiz t0, IndexingShapeMask, .opGetByIdSlow
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, JSObject::m_butterfly[t3], t0, t1)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr Gigacage::jsValueGigacageMask, JSObject::m_butterfly[t3], t0, t1)
 loadi -sizeof IndexingHeader + IndexingHeader::u.lengths.publicLength[t0], t0
 bilt t0, 0, .opGetByIdSlow
 orq tagTypeNumber, t0
@@ -1438,7 +1438,7 @@
 loadConstantOrVariableInt32(size, t3, t1, .opGetByValSlow)
 sxi2q t1, t1
 
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr JSVALUE_GIGACAGE_MASK, JSObject::m_butterfly[t0], t3, tagTypeNumber)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::jsValue, constexpr Gigacage::jsValueGigacageMask, JSObject::m_butterfly[t0], t3, tagTypeNumber)
 move TagTypeNumber, tagTypeNumber
 
 andi IndexingShapeMask, t2
@@ -1504,7 +1504,7 @@
 bia t2, Int8ArrayType - FirstTypedArrayType, .opGetByValUint8ArrayOrUint8ClampedArray
 
 # We have Int8ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, JSArrayBufferView::m_vector[t0], t3, t2)
+loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr Gigacage::primitiveGigacageMask, JSArrayBufferView::m_vector[t0], t3, t2)
 loadbs [t3, t1], t0
 finishIntGetByVal(t0, t1)
 
@@ -1512,13 +1512,13 @@
 bia t2, Uint8ArrayType - FirstTypedArrayType, .opGetByValUint8ClampedArray
 
 # We have Uint8ArrayType.
-loadCaged(_g_gigacageBasePtrs + Gigacage::BasePtrs::primitive, constexpr PRIMITIVE_GIGACAGE_MASK, 

[webkit-changes] [240159] trunk/Source/WebKit

[wenson_hsieh]

Title: [240159] trunk/Source/WebKit








Revision 240159
Author wenson_hs...@apple.com
Date 2019-01-18 11:10:04 -0800 (Fri, 18 Jan 2019)


Log Message
Remove some last vestiges of assisted node terminology in WebKit
https://bugs.webkit.org/show_bug.cgi?id=193572

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/_WKFocusedElementInfo.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView _showKeyboard]):
(-[WKContentView _hideKeyboard]):

Add a FIXME about invoking `-reloadInputViews` on watchOS when the focused element is blurred.

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView updateCurrentFocusedElementInformation:]):
(-[WKContentView _startAssistingKeyboard]): Deleted.
(-[WKContentView _stopAssistingKeyboard]): Deleted.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getFocusedElementInformation):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFocusedElementInfo.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (240158 => 240159)

--- trunk/Source/WebKit/ChangeLog	2019-01-18 18:44:54 UTC (rev 240158)
+++ trunk/Source/WebKit/ChangeLog	2019-01-18 19:10:04 UTC (rev 240159)
@@ -1,3 +1,27 @@
+2019-01-18  Wenson Hsieh  
+
+Remove some last vestiges of assisted node terminology in WebKit
+https://bugs.webkit.org/show_bug.cgi?id=193572
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/_WKFocusedElementInfo.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizerShouldBegin:]):
+(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
+(-[WKContentView _showKeyboard]):
+(-[WKContentView _hideKeyboard]):
+
+Add a FIXME about invoking `-reloadInputViews` on watchOS when the focused element is blurred.
+
+(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
+(-[WKContentView _elementDidBlur]):
+(-[WKContentView updateCurrentFocusedElementInformation:]):
+(-[WKContentView _startAssistingKeyboard]): Deleted.
+(-[WKContentView _stopAssistingKeyboard]): Deleted.
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::getFocusedElementInformation):
+
 2019-01-18  Youenn Fablet  
 
 Add a new SPI to request for cache storage quota increase


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFocusedElementInfo.h (240158 => 240159)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFocusedElementInfo.h	2019-01-18 18:44:54 UTC (rev 240158)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFocusedElementInfo.h	2019-01-18 19:10:04 UTC (rev 240159)
@@ -58,9 +58,9 @@
 };
 
 /**
- * The _WKFocusedElementInfo provides basic information about an element
- * that has been focused (either programmatically or through user interaction)
- * but has not yet been assisted.
+ * The _WKFocusedElementInfo provides basic information about an element that
+ * has been focused (either programmatically or through user interaction) but
+ * is not causing any input UI (e.g. keyboard, date picker, etc.) to be shown.
  */
 @protocol _WKFocusedElementInfo 
 


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240158 => 240159)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-01-18 18:44:54 UTC (rev 240158)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-01-18 19:10:04 UTC (rev 240159)
@@ -1736,7 +1736,7 @@
 
 if (hasFocusedElement(_focusedElementInformation)) {
 // Request information about the position with sync message.
-// If the assisted node is the same, prevent the gesture.
+// If the focused element is the same, prevent the gesture.
 if (![self ensurePositionInformationIsUpToDate:WebKit::InteractionInformationRequest(WebCore::roundedIntPoint(point))])
 return NO;
 if (_positionInformation.nodeAtPositionIsFocusedElement)
@@ -1746,7 +1746,7 @@
 
 if (gestureRecognizer == _highlightLongPressGestureRecognizer) {
 if (hasFocusedElement(_focusedElementInformation)) {
-// This is a different node than the assisted one.
+// This is a different element than the focused one.
 // Prevent the gesture if there is no node.
 // Allow the gesture if it is a node that wants highlight or if there is an action for it.
 if (!_positionInformation.isElement)
@@ -1885,7 +1885,7 @@
 return NO;
 #endif
 
-// If we're currently editing an assisted node, only allow the selection to move within that 

[webkit-changes] [240158] trunk

[ajuma]

Title: [240158] trunk








Revision 240158
Author aj...@chromium.org
Date 2019-01-18 10:44:54 -0800 (Fri, 18 Jan 2019)


Log Message
FetchResponse::url should return the empty string for tainted responses
https://bugs.webkit.org/show_bug.cgi?id=193553

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
(fetchNoCors):

Source/WebCore:

Check whether the response is tainted in FetchResponse::url, to match
the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.

* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::url const):

LayoutTests:

* http/wpt/fetch/response-opaque-clone.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/fetch/response-opaque-clone.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (240157 => 240158)

--- trunk/LayoutTests/ChangeLog	2019-01-18 18:37:11 UTC (rev 240157)
+++ trunk/LayoutTests/ChangeLog	2019-01-18 18:44:54 UTC (rev 240158)
@@ -1,3 +1,12 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+* http/wpt/fetch/response-opaque-clone.html:
+
 2019-01-18  Jonathan Bedard  
 
 webkitpy: Implement device type specific expected results (Follow-up fix)


Modified: trunk/LayoutTests/http/wpt/fetch/response-opaque-clone.html (240157 => 240158)

--- trunk/LayoutTests/http/wpt/fetch/response-opaque-clone.html	2019-01-18 18:37:11 UTC (rev 240157)
+++ trunk/LayoutTests/http/wpt/fetch/response-opaque-clone.html	2019-01-18 18:44:54 UTC (rev 240158)
@@ -16,6 +16,7 @@
 assert_equals(response.type, "opaque", testName + " type");
 assert_equals(response.status, 0, testName + " status");
 assert_equals(response.statusText, "", testName + " statusText");
+assert_equals(response.url, "", testName + " url");
 assert_false(response.redirected, testName + " redirected");
 assert_true(response.headers.values().next().done, testName + " headers");
 assert_equals(response.body, null, testName + " opaque response body should be null");


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (240157 => 240158)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-01-18 18:37:11 UTC (rev 240157)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-01-18 18:44:54 UTC (rev 240158)
@@ -1,3 +1,13 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+(fetchNoCors):
+
 2019-01-14  Charles Vazac  
 
 Import current Resource-Timing WPTs


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js (240157 => 240158)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js	2019-01-18 18:37:11 UTC (rev 240157)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js	2019-01-18 18:44:54 UTC (rev 240158)
@@ -7,6 +7,7 @@
   return fetch(url + urlQuery, {"mode": "no-cors"}).then(function(resp) {
 assert_equals(resp.status, 0, "Opaque filter: status is 0");
 assert_equals(resp.statusText, "", "Opaque filter: statusText is \"\"");
+assert_equals(resp.url, "", "Opaque filter: url is \"\"");
 assert_equals(resp.type , "opaque", "Opaque filter: response's type is opaque");
 assert_equals(resp.headers.get("x-is-filtered"), null, "Header x-is-filtered is filtered");
   });


Modified: trunk/Source/WebCore/ChangeLog (240157 => 240158)

--- trunk/Source/WebCore/ChangeLog	2019-01-18 18:37:11 UTC (rev 240157)
+++ trunk/Source/WebCore/ChangeLog	2019-01-18 18:44:54 UTC (rev 240158)
@@ -1,3 +1,16 @@
+2019-01-18  Ali Juma  
+
+FetchResponse::url should return the empty string for tainted responses
+https://bugs.webkit.org/show_bug.cgi?id=193553
+
+Reviewed by Youenn Fablet.
+
+Check whether the response is tainted in FetchResponse::url, to match
+the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::url const):
+
 2019-01-18  Youenn Fablet  
 
 A track source should be unmuted whenever reenabled after setDirection changes


Modified: trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp (240157 => 240158)

--- trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp	2019-01-18 18:37:11 UTC (rev 240157)
+++ 

[webkit-changes] [240157] trunk/LayoutTests

[jbedard]

Title: [240157] trunk/LayoutTests








Revision 240157
Author jbed...@apple.com
Date 2019-01-18 10:37:11 -0800 (Fri, 18 Jan 2019)


Log Message
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162


Unreviewed test gardening.

* tiled-drawing/ios/iphone7: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/tiled-drawing/ios/iphone7/




Diff

Modified: trunk/LayoutTests/ChangeLog (240156 => 240157)

--- trunk/LayoutTests/ChangeLog	2019-01-18 18:19:40 UTC (rev 240156)
+++ trunk/LayoutTests/ChangeLog	2019-01-18 18:37:11 UTC (rev 240157)
@@ -1,3 +1,13 @@
+2019-01-18  Jonathan Bedard  
+
+webkitpy: Implement device type specific expected results (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=192162
+
+
+Unreviewed test gardening.
+
+* tiled-drawing/ios/iphone7: Removed.
+
 2019-01-18  Youenn Fablet  
 
 Add a new SPI to request for cache storage quota increase






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240156] trunk

[youenn]

Title: [240156] trunk








Revision 240156
Author you...@apple.com
Date 2019-01-18 10:19:40 -0800 (Fri, 18 Jan 2019)


Log Message
Add a new SPI to request for cache storage quota increase
https://bugs.webkit.org/show_bug.cgi?id=193323

Reviewed by Alex Christensen.

Source/WebKit:

Add a delegate on the WebSiteDataStore for WebKit to ask for quota update.
The current SPI is currently CacheStorage specific but future work should
make it so that other storage like IDB use the same mechanism.
By default, quota remains unchanged if delegate is not implemented.

* NetworkProcess/NetworkProcess.cpp:
* UIProcess/API/Cocoa/WKStorageQuotaDelegatePrivate.h: Added.
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(WebsiteDataStoreQuotaManager::WebsiteDataStoreQuotaManager):
(-[WKWebsiteDataStore _quotaDelegate]):
(-[WKWebsiteDataStore set_quotaDelegate:]):
* UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h:
* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::requestCacheStorageSpace):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::quotaManager):
(WebKit::WebsiteDataStore::setQuotaManager):
* UIProcess/WebsiteData/WebsiteDataStoreQuotaManager.h: Added.
(WebKit::WebsiteDataStoreQuotaManager::~WebsiteDataStoreQuotaManager):
(WebKit::WebsiteDataStoreQuotaManager::requestCacheStorageSpace):
* WebKit.xcodeproj/project.pbxproj:

Tools:

Implement WebsiteDataStore quota delegate to handle quota requests.
By default, do not update quota.
Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::allowCacheStorageQuotaIncrease):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::allowCacheStorageQuotaIncrease):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(-[CacheStorageQuotaManager init]):
(-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
(WTR::initializeWebViewConfiguration):
(WTR::TestController::cocoaResetStateToConsistentValues):
(WTR::TestController::allowCacheStorageQuotaIncrease):

LayoutTests:

Use new testRunner method to bump the cache quota and verify adding a
cache entry works when bumping the cache quota.

* http/wpt/cache-storage/cache-quota.any.js:
(promise_test):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/cache-storage/cache-quota.any.js
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm


Added Paths

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h
trunk/Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h
trunk/Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (240155 => 240156)

--- trunk/LayoutTests/ChangeLog	2019-01-18 18:16:16 UTC (rev 240155)
+++ trunk/LayoutTests/ChangeLog	2019-01-18 18:19:40 UTC (rev 240156)
@@ -1,5 +1,18 @@
 2019-01-18  Youenn Fablet  
 
+Add a new SPI to request for cache storage quota increase
+https://bugs.webkit.org/show_bug.cgi?id=193323
+
+Reviewed by Alex Christensen.
+
+Use new testRunner method to bump the cache quota and verify adding a
+cache entry works when bumping the cache quota.
+
+* http/wpt/cache-storage/cache-quota.any.js:
+(promise_test):
+
+2019-01-18  Youenn Fablet  
+
 A track source should be unmuted whenever reenabled after setDirection changes
 https://bugs.webkit.org/show_bug.cgi?id=193554
 


Modified: trunk/LayoutTests/http/wpt/cache-storage/cache-quota.any.js (240155 => 240156)

--- 

[webkit-changes] [240155] trunk/Tools

[aakash_jain]

Title: [240155] trunk/Tools








Revision 240155
Author aakash_j...@apple.com
Date 2019-01-18 10:16:16 -0800 (Fri, 18 Jan 2019)


Log Message
[ews-build] Pass owner to the triggered builds
https://bugs.webkit.org/show_bug.cgi?id=193574

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/factories.py:
(BuildFactory.propertiesToPassToTriggers):

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-build/factories.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (240154 => 240155)

--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py	2019-01-18 18:14:08 UTC (rev 240154)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py	2019-01-18 18:16:16 UTC (rev 240155)
@@ -85,6 +85,7 @@
 "platform": Property("platform"),
 "fullPlatform": Property("fullPlatform"),
 "architecture": Property("architecture"),
+"owner": Property("owner"),
 }
 
 


Modified: trunk/Tools/ChangeLog (240154 => 240155)

--- trunk/Tools/ChangeLog	2019-01-18 18:14:08 UTC (rev 240154)
+++ trunk/Tools/ChangeLog	2019-01-18 18:16:16 UTC (rev 240155)
@@ -1,5 +1,15 @@
 2019-01-18  Aakash Jain  
 
+[ews-build] Pass owner to the triggered builds
+https://bugs.webkit.org/show_bug.cgi?id=193574
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-build/factories.py:
+(BuildFactory.propertiesToPassToTriggers):
+
+2019-01-18  Aakash Jain  
+
 [ews-app] Send patch author as a build property
 https://bugs.webkit.org/show_bug.cgi?id=193560
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240154] trunk/Tools

[aakash_jain]

Title: [240154] trunk/Tools








Revision 240154
Author aakash_j...@apple.com
Date 2019-01-18 10:14:08 -0800 (Fri, 18 Jan 2019)


Log Message
[ews-app] Send patch author as a build property
https://bugs.webkit.org/show_bug.cgi?id=193560

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/fetcher.py:
(BugzillaPatchFetcher.fetch):

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py (240153 => 240154)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py	2019-01-18 17:54:52 UTC (rev 240153)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py	2019-01-18 18:14:08 UTC (rev 240154)
@@ -62,7 +62,8 @@
 _log.warn('Patch is obsolete, skipping')
 Patch.set_obsolete(patch_id)
 continue
-rc = Buildbot.send_patch_to_buildbot(bz_patch['path'], properties=['patch_id={}'.format(patch_id), 'bug_id={}'.format(bz_patch['bug_id'])])
+rc = Buildbot.send_patch_to_buildbot(bz_patch['path'],
+ properties=['patch_id={}'.format(patch_id), 'bug_id={}'.format(bz_patch['bug_id']), 'owner={}'.format(bz_patch.get('creator', ''))])
 if rc == 0:
 Patch.set_bug_id(patch_id, bz_patch['bug_id'])
 Patch.set_sent_to_buildbot(patch_id)


Modified: trunk/Tools/ChangeLog (240153 => 240154)

--- trunk/Tools/ChangeLog	2019-01-18 17:54:52 UTC (rev 240153)
+++ trunk/Tools/ChangeLog	2019-01-18 18:14:08 UTC (rev 240154)
@@ -1,3 +1,13 @@
+2019-01-18  Aakash Jain  
+
+[ews-app] Send patch author as a build property
+https://bugs.webkit.org/show_bug.cgi?id=193560
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/fetcher.py:
+(BugzillaPatchFetcher.fetch):
+
 2019-01-18  Jonathan Bedard  
 
 webkitpy: Implement device type specific expected results (Follow-up fix)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240153] trunk/Tools

[jbedard]

Title: [240153] trunk/Tools








Revision 240153
Author jbed...@apple.com
Date 2019-01-18 09:54:52 -0800 (Fri, 18 Jan 2019)


Log Message
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162


Unreviewed infrastructure fix.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Don't boot a device if no tests are available to run on it.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py




Diff

Modified: trunk/Tools/ChangeLog (240152 => 240153)

--- trunk/Tools/ChangeLog	2019-01-18 17:19:26 UTC (rev 240152)
+++ trunk/Tools/ChangeLog	2019-01-18 17:54:52 UTC (rev 240153)
@@ -6,6 +6,17 @@
 
 Unreviewed infrastructure fix.
 
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run): Don't boot a device if no tests are available to run on it.
+
+2019-01-18  Jonathan Bedard  
+
+webkitpy: Implement device type specific expected results (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=192162
+
+
+Unreviewed infrastructure fix.
+
 * Scripts/webkitpy/api_tests/manager.py:
 (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (240152 => 240153)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2019-01-18 17:19:26 UTC (rev 240152)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2019-01-18 17:54:52 UTC (rev 240153)
@@ -252,6 +252,8 @@
 
 _log.info('Running {}{}'.format(pluralize(len(tests_to_run_by_device[device_type]), 'test'), ' for {}'.format(str(device_type)) if device_type else ''))
 _log.info('')
+if not tests_to_run_by_device[device_type]:
+continue
 if not self._set_up_run(tests_to_run_by_device[device_type], device_type=device_type):
 return test_run_results.RunDetails(exit_code=-1)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240152] trunk

[youenn]

Title: [240152] trunk








Revision 240152
Author you...@apple.com
Date 2019-01-18 09:19:26 -0800 (Fri, 18 Jan 2019)


Log Message
A track source should be unmuted whenever reenabled after setDirection changes
https://bugs.webkit.org/show_bug.cgi?id=193554


Reviewed by Eric Carlson.

Source/WebCore:

Ensure that track gets unmuted after being fired as part of track event.
Test is triggering some existing issues with MediaPlayerPrivateMediaStreamAVFObjC.
Given the enqueuing of samples happens in a different frame than the thread used to update media stream and the active video track,
some enqueued samples might not be from the right active video track or there might be no active video track.

Test: webrtc/video-setDirection.html

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::fireTrackEvent):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData):

LayoutTests:

* webrtc/video-setDirection-expected.txt: Added.
* webrtc/video-setDirection.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm


Added Paths

trunk/LayoutTests/webrtc/video-setDirection-expected.txt
trunk/LayoutTests/webrtc/video-setDirection.html




Diff

Modified: trunk/LayoutTests/ChangeLog (240151 => 240152)

--- trunk/LayoutTests/ChangeLog	2019-01-18 16:54:23 UTC (rev 240151)
+++ trunk/LayoutTests/ChangeLog	2019-01-18 17:19:26 UTC (rev 240152)
@@ -1,3 +1,14 @@
+2019-01-18  Youenn Fablet  
+
+A track source should be unmuted whenever reenabled after setDirection changes
+https://bugs.webkit.org/show_bug.cgi?id=193554
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/video-setDirection-expected.txt: Added.
+* webrtc/video-setDirection.html: Added.
+
 2019-01-18  Jonathan Bedard  
 
 webkitpy: Implement device type specific expected results (Part 2)


Added: trunk/LayoutTests/webrtc/video-setDirection-expected.txt (0 => 240152)

--- trunk/LayoutTests/webrtc/video-setDirection-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/video-setDirection-expected.txt	2019-01-18 17:19:26 UTC (rev 240152)
@@ -0,0 +1,5 @@
+
+
+PASS Going from sendrecv to inactive and back to sendrecv 
+FAIL The MediaStream should remain the same assert_equals: expected object "[object MediaStream]" but got object "[object MediaStream]"
+


Added: trunk/LayoutTests/webrtc/video-setDirection.html (0 => 240152)

--- trunk/LayoutTests/webrtc/video-setDirection.html	(rev 0)
+++ trunk/LayoutTests/webrtc/video-setDirection.html	2019-01-18 17:19:26 UTC (rev 240152)
@@ -0,0 +1,108 @@
+
+
+
+
+Testing video exchange using setDirection with renegotiation from offerer to receiver
+
+
+
+
+