[webkit-changes] [268341] tags/Safari-611.1.3.1/
Title: [268341] tags/Safari-611.1.3.1/ Revision 268341 Author bshaf...@apple.com Date 2020-10-11 21:58:39 -0700 (Sun, 11 Oct 2020) Log Message Tag Safari-611.1.3.1. Added Paths tags/Safari-611.1.3.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268340] tags/Safari-610.3.2/
Title: [268340] tags/Safari-610.3.2/ Revision 268340 Author bshaf...@apple.com Date 2020-10-11 21:35:59 -0700 (Sun, 11 Oct 2020) Log Message Tag Safari-610.3.2. Added Paths tags/Safari-610.3.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268338] branches/safari-611.1.3-branch/Source
Title: [268338] branches/safari-611.1.3-branch/Source
Revision 268338
Author kocsen_ch...@apple.com
Date 2020-10-11 19:21:13 -0700 (Sun, 11 Oct 2020)
Log Message
Cherry-pick r268327. rdar://problem/70168426
Ignore deployment suffix and identifier when computing major OS version for macOS
Big Sur and newer
https://bugs.webkit.org/show_bug.cgi?id=217584
rdar://70168426
Patch by Luming Yin on 2020-10-11
Reviewed by Darin Adler.
Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
Only use the deployment target base for macOS Big Sur and newer. Keep the manual
definitions for legacy versions of macOS.
* Configurations/Base.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WTF/ChangeLog
branches/safari-611.1.3-branch/Source/WTF/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WebCore/ChangeLog
branches/safari-611.1.3-branch/Source/WebCore/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WebCore/PAL/ChangeLog
branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WebInspectorUI/ChangeLog
branches/safari-611.1.3-branch/Source/WebInspectorUI/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WebKit/ChangeLog
branches/safari-611.1.3-branch/Source/WebKit/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-611.1.3-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
branches/safari-611.1.3-branch/Source/bmalloc/ChangeLog
branches/safari-611.1.3-branch/Source/bmalloc/Configurations/Base.xcconfig
Diff
Modified: branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog (268337 => 268338)
--- branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog 2020-10-12 02:15:23 UTC (rev 268337)
+++ branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog 2020-10-12 02:21:13 UTC (rev 268338)
@@ -1,3 +1,38 @@
+2020-10-11 Kocsen Chung
+
+Cherry-pick r268327. rdar://problem/70168426
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Patch by Luming Yin on 2020-10-11
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-10-11 Luming Yin
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
2020-10-03 Yusuke Suzuki
[JSC] Introduce JITOperationList to validate JIT-caged pointers
Modified: branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268337 => 268338)
--- branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 02:15:23 UTC (rev 268337)
+++ branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 02:21:13 UTC (rev 268338)
@@ -102,13 +102,15 @@
HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
-TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
-TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500;
-TARGET_MAC_OS_X_VERSION_MAJOR_11_0 = 11;
-TARGET_MAC_OS_X_VERSION_MAJOR_12_0 = 12;
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
[webkit-changes] [268339] branches/safari-611.1.3-branch/Source
Title: [268339] branches/safari-611.1.3-branch/Source Revision 268339 Author kocsen_ch...@apple.com Date 2020-10-11 19:21:21 -0700 (Sun, 11 Oct 2020) Log Message Cherry-pick r268330. rdar://problem/70188497 Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur or later https://bugs.webkit.org/show_bug.cgi?id=217594 rdar://70188497 Patch by Luming Yin on 2020-10-11 Reviewed by Darin Adler. To ensure successful Mac Catalyst WebKit builds, strip the patch version from TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. * Configurations/Base.xcconfig: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/ChangeLog branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/ChangeLog branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WTF/ChangeLog branches/safari-611.1.3-branch/Source/WTF/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WebCore/ChangeLog branches/safari-611.1.3-branch/Source/WebCore/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WebCore/PAL/ChangeLog branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WebInspectorUI/ChangeLog branches/safari-611.1.3-branch/Source/WebInspectorUI/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WebKit/ChangeLog branches/safari-611.1.3-branch/Source/WebKit/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-611.1.3-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig branches/safari-611.1.3-branch/Source/bmalloc/ChangeLog branches/safari-611.1.3-branch/Source/bmalloc/Configurations/Base.xcconfig Diff Modified: branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog (268338 => 268339) --- branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog 2020-10-12 02:21:13 UTC (rev 268338) +++ branches/safari-611.1.3-branch/Source/_javascript_Core/ChangeLog 2020-10-12 02:21:21 UTC (rev 268339) @@ -1,5 +1,38 @@ 2020-10-11 Kocsen Chung +Cherry-pick r268330. rdar://problem/70188497 + +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Patch by Luming Yin on 2020-10-11 +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-10-11 Luming Yin + +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +2020-10-11 Kocsen Chung + Cherry-pick r268327. rdar://problem/70168426 Ignore deployment suffix and identifier when computing major OS version for macOS Modified: branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268338 => 268339) --- branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 02:21:13 UTC (rev 268338) +++ branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 02:21:21 UTC (rev 268339) @@ -106,7 +106,7 @@ TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier) TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER)) -TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base) +TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base) TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300 TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400 TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500 Modified: branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/ChangeLog (268338 => 268339) --- branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/ChangeLog 2020-10-12 02:21:13 UTC (rev 268338) +++
[webkit-changes] [268336] branches/safari-611.1.3-branch/Source
Title: [268336] branches/safari-611.1.3-branch/Source Revision 268336 Author kocsen_ch...@apple.com Date 2020-10-11 19:14:45 -0700 (Sun, 11 Oct 2020) Log Message Versioning. WebKit-7611.1.3.1 Modified Paths branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-611.1.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (268335 => 268336) --- branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) +++ branches/safari-611.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-10-12 02:14:45 UTC (rev 268336) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (268335 => 268336) --- branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) +++ branches/safari-611.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-10-12 02:14:45 UTC (rev 268336) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (268335 => 268336) --- branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) +++ branches/safari-611.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-10-12 02:14:45 UTC (rev 268336) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.3-branch/Source/WebCore/Configurations/Version.xcconfig (268335 => 268336) --- branches/safari-611.1.3-branch/Source/WebCore/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) +++ branches/safari-611.1.3-branch/Source/WebCore/Configurations/Version.xcconfig 2020-10-12 02:14:45 UTC (rev 268336) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (268335 => 268336) --- branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) +++ branches/safari-611.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-10-12 02:14:45 UTC (rev 268336) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION =
[webkit-changes] [268337] trunk/Tools
Title: [268337] trunk/Tools
Revision 268337
Author commit-qu...@webkit.org
Date 2020-10-11 19:15:23 -0700 (Sun, 11 Oct 2020)
Log Message
-Wdeprecated-declarations caused by WKTR using WKBundlePostSynchronousMessage
https://bugs.webkit.org/show_bug.cgi?id=217591
Patch by Michael Catanzaro on 2020-10-11
Reviewed by Darin Adler.
Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::postSynchronousMessage):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
Diff
Modified: trunk/Tools/ChangeLog (268336 => 268337)
--- trunk/Tools/ChangeLog 2020-10-12 02:14:45 UTC (rev 268336)
+++ trunk/Tools/ChangeLog 2020-10-12 02:15:23 UTC (rev 268337)
@@ -1,3 +1,15 @@
+2020-10-11 Michael Catanzaro
+
+-Wdeprecated-declarations caused by WKTR using WKBundlePostSynchronousMessage
+https://bugs.webkit.org/show_bug.cgi?id=217591
+
+Reviewed by Darin Adler.
+
+Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
+
+* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
+(WTR::postSynchronousMessage):
+
2020-10-11 Darin Adler
[macOS] Harden more build configurations against macOS versions 11 and higher as well as inclusion of patch versions
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h (268336 => 268337)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h 2020-10-12 02:14:45 UTC (rev 268336)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h 2020-10-12 02:15:23 UTC (rev 268337)
@@ -243,7 +243,9 @@
template void postSynchronousMessage(const char* name, const WKRetainPtr& value)
{
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
WKBundlePostSynchronousMessage(InjectedBundle::singleton().bundle(), toWK(name).get(), value.get(), nullptr);
+ALLOW_DEPRECATED_DECLARATIONS_END
}
template void postPageMessage(const char* name, const WKRetainPtr& value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268335] branches/safari-610-branch/Source
Title: [268335] branches/safari-610-branch/Source Revision 268335 Author kocsen_ch...@apple.com Date 2020-10-11 19:02:51 -0700 (Sun, 11 Oct 2020) Log Message Versioning. WebKit-7610.3.2 Modified Paths branches/safari-610-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610-branch/Source/_javascript_Core/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/WebCore/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/WebCore/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/WebCore/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -1,6 +1,6 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/WebKit/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/WebKit/Configurations/Version.xcconfig 2020-10-12 01:38:57 UTC (rev 268334) +++ branches/safari-610-branch/Source/WebKit/Configurations/Version.xcconfig 2020-10-12 02:02:51 UTC (rev 268335) @@ -23,7 +23,7 @@ MAJOR_VERSION = 610; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-610-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (268334 => 268335) --- branches/safari-610-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2020-10-12 01:38:57
[webkit-changes] [268334] trunk/Source/WTF
Title: [268334] trunk/Source/WTF
Revision 268334
Author commit-qu...@webkit.org
Date 2020-10-11 18:38:57 -0700 (Sun, 11 Oct 2020)
Log Message
GeneratePreferences.rb is noisy
https://bugs.webkit.org/show_bug.cgi?id=217589
Patch by Michael Catanzaro on 2020-10-11
Reviewed by Sam Weinig.
Don't print anything when the script is successful. Since it runs during the build, it
should only print errors.
* Scripts/GeneratePreferences.rb:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/GeneratePreferences.rb
Diff
Modified: trunk/Source/WTF/ChangeLog (268333 => 268334)
--- trunk/Source/WTF/ChangeLog 2020-10-12 01:34:58 UTC (rev 268333)
+++ trunk/Source/WTF/ChangeLog 2020-10-12 01:38:57 UTC (rev 268334)
@@ -1,3 +1,15 @@
+2020-10-11 Michael Catanzaro
+
+GeneratePreferences.rb is noisy
+https://bugs.webkit.org/show_bug.cgi?id=217589
+
+Reviewed by Sam Weinig.
+
+Don't print anything when the script is successful. Since it runs during the build, it
+should only print errors.
+
+* Scripts/GeneratePreferences.rb:
+
2020-10-11 Luming Yin
Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur
Modified: trunk/Source/WTF/Scripts/GeneratePreferences.rb (268333 => 268334)
--- trunk/Source/WTF/Scripts/GeneratePreferences.rb 2020-10-12 01:34:58 UTC (rev 268333)
+++ trunk/Source/WTF/Scripts/GeneratePreferences.rb 2020-10-12 01:38:57 UTC (rev 268334)
@@ -215,8 +215,6 @@
end
def renderTemplate(templateFile, outputDirectory)
-puts "Generating output for template file: #{templateFile}"
-
resultFile = File.join(outputDirectory, File.basename(templateFile, ".erb"))
tempResultFile = resultFile + ".tmp"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268333] branches/safari-610-branch/Source
Title: [268333] branches/safari-610-branch/Source Revision 268333 Author kocsen_ch...@apple.com Date 2020-10-11 18:34:58 -0700 (Sun, 11 Oct 2020) Log Message Cherry-pick r268330. rdar://problem/70189394 Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur or later https://bugs.webkit.org/show_bug.cgi?id=217594 rdar://70188497 Patch by Luming Yin on 2020-10-11 Reviewed by Darin Adler. To ensure successful Mac Catalyst WebKit builds, strip the patch version from TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. * Configurations/Base.xcconfig: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/Source/_javascript_Core/ChangeLog branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig branches/safari-610-branch/Source/ThirdParty/ANGLE/ChangeLog branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig branches/safari-610-branch/Source/ThirdParty/libwebrtc/ChangeLog branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig branches/safari-610-branch/Source/WTF/ChangeLog branches/safari-610-branch/Source/WTF/Configurations/Base.xcconfig branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/Configurations/Base.xcconfig branches/safari-610-branch/Source/WebCore/PAL/ChangeLog branches/safari-610-branch/Source/WebCore/PAL/Configurations/Base.xcconfig branches/safari-610-branch/Source/WebInspectorUI/ChangeLog branches/safari-610-branch/Source/WebInspectorUI/Configurations/Base.xcconfig branches/safari-610-branch/Source/WebKit/ChangeLog branches/safari-610-branch/Source/WebKit/Configurations/Base.xcconfig branches/safari-610-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-610-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig branches/safari-610-branch/Source/bmalloc/ChangeLog branches/safari-610-branch/Source/bmalloc/Configurations/Base.xcconfig Diff Modified: branches/safari-610-branch/Source/_javascript_Core/ChangeLog (268332 => 268333) --- branches/safari-610-branch/Source/_javascript_Core/ChangeLog 2020-10-12 01:34:48 UTC (rev 268332) +++ branches/safari-610-branch/Source/_javascript_Core/ChangeLog 2020-10-12 01:34:58 UTC (rev 268333) @@ -1,5 +1,38 @@ 2020-10-11 Kocsen Chung +Cherry-pick r268330. rdar://problem/70189394 + +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Patch by Luming Yin on 2020-10-11 +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-10-11 Luming Yin + +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +2020-10-11 Kocsen Chung + Cherry-pick r268327. rdar://problem/70189401 Ignore deployment suffix and identifier when computing major OS version for macOS Modified: branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268332 => 268333) --- branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 01:34:48 UTC (rev 268332) +++ branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 01:34:58 UTC (rev 268333) @@ -106,7 +106,7 @@ TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier) TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER)) -TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base) +TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base) TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300 TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400 TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500 Modified: branches/safari-610-branch/Source/ThirdParty/ANGLE/ChangeLog (268332 => 268333) --- branches/safari-610-branch/Source/ThirdParty/ANGLE/ChangeLog 2020-10-12 01:34:48 UTC (rev 268332) +++ branches/safari-610-branch/Source/ThirdParty/ANGLE/ChangeLog 2020-10-12 01:34:58 UTC (rev 268333) @@ -1,5 +1,38 @@ 2020-10-11 Kocsen
[webkit-changes] [268332] branches/safari-610-branch/Source
Title: [268332] branches/safari-610-branch/Source
Revision 268332
Author kocsen_ch...@apple.com
Date 2020-10-11 18:34:48 -0700 (Sun, 11 Oct 2020)
Log Message
Cherry-pick r268327. rdar://problem/70189401
Ignore deployment suffix and identifier when computing major OS version for macOS
Big Sur and newer
https://bugs.webkit.org/show_bug.cgi?id=217584
rdar://70168426
Patch by Luming Yin on 2020-10-11
Reviewed by Darin Adler.
Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
Only use the deployment target base for macOS Big Sur and newer. Keep the manual
definitions for legacy versions of macOS.
* Configurations/Base.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/Source/_javascript_Core/ChangeLog
branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig
branches/safari-610-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-610-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-610-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-610-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WTF/ChangeLog
branches/safari-610-branch/Source/WTF/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WebCore/ChangeLog
branches/safari-610-branch/Source/WebCore/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WebCore/PAL/ChangeLog
branches/safari-610-branch/Source/WebCore/PAL/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WebInspectorUI/ChangeLog
branches/safari-610-branch/Source/WebInspectorUI/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WebKit/ChangeLog
branches/safari-610-branch/Source/WebKit/Configurations/Base.xcconfig
branches/safari-610-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-610-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
branches/safari-610-branch/Source/bmalloc/ChangeLog
branches/safari-610-branch/Source/bmalloc/Configurations/Base.xcconfig
Diff
Modified: branches/safari-610-branch/Source/_javascript_Core/ChangeLog (268331 => 268332)
--- branches/safari-610-branch/Source/_javascript_Core/ChangeLog 2020-10-12 01:25:46 UTC (rev 268331)
+++ branches/safari-610-branch/Source/_javascript_Core/ChangeLog 2020-10-12 01:34:48 UTC (rev 268332)
@@ -1,3 +1,38 @@
+2020-10-11 Kocsen Chung
+
+Cherry-pick r268327. rdar://problem/70189401
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Patch by Luming Yin on 2020-10-11
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-10-11 Luming Yin
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
2020-09-27 Alan Coon
Cherry-pick r267304. rdar://problem/69594380
Modified: branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268331 => 268332)
--- branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 01:25:46 UTC (rev 268331)
+++ branches/safari-610-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 01:34:48 UTC (rev 268332)
@@ -102,13 +102,15 @@
HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
-TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
-TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500;
-TARGET_MAC_OS_X_VERSION_MAJOR_11_0 = 11;
-TARGET_MAC_OS_X_VERSION_MAJOR_12_0 = 12;
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
+TARGET_MAC_OS_X_VERSION_MAJOR =
[webkit-changes] [268331] trunk
Title: [268331] trunk Revision 268331 Author da...@apple.com Date 2020-10-11 18:25:46 -0700 (Sun, 11 Oct 2020) Log Message [macOS] Harden more build configurations against macOS versions 11 and higher as well as inclusion of patch versions https://bugs.webkit.org/show_bug.cgi?id=217595 Reviewed by Alexey Proskuryakov. PerformanceTests: * MediaTime/Configurations/Base.xcconfig: Updated to same idiom used elsewhere. Tools: * ContentExtensionTester/Configurations/Base.xcconfig: Updated to same idiom used elsewhere. * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto. * ImageDiff/cg/Configurations/Base.xcconfig: Ditto. * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Ditto. * Scripts/webkitpy/common/config/contributors.json: Added contributor Luming Yin, an engineer who works on Safari at Apple who has been contributing build fixes like these. Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig trunk/Tools/ChangeLog trunk/Tools/ContentExtensionTester/Configurations/Base.xcconfig trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig trunk/Tools/Scripts/webkitpy/common/config/contributors.json trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig trunk/Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig Diff Modified: trunk/PerformanceTests/ChangeLog (268330 => 268331) --- trunk/PerformanceTests/ChangeLog 2020-10-12 01:11:44 UTC (rev 268330) +++ trunk/PerformanceTests/ChangeLog 2020-10-12 01:25:46 UTC (rev 268331) @@ -1,3 +1,12 @@ +2020-10-11 Darin Adler + +[macOS] Harden more build configurations against macOS versions 11 and higher as well as inclusion of patch versions +https://bugs.webkit.org/show_bug.cgi?id=217595 + +Reviewed by Alexey Proskuryakov. + +* MediaTime/Configurations/Base.xcconfig: Updated to same idiom used elsewhere. + 2020-07-30 Jer Noble [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting. Modified: trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig (268330 => 268331) --- trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig 2020-10-12 01:11:44 UTC (rev 268330) +++ trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig 2020-10-12 01:25:46 UTC (rev 268331) @@ -85,14 +85,15 @@ WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla; HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(DSTROOT)/usr/local/include icu $(HEADER_SEARCH_PATHS); -TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)); -TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300; -TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400; -TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500; -TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600; -TARGET_MAC_OS_X_VERSION_MAJOR_11_0 = 11; -TARGET_MAC_OS_X_VERSION_MAJOR_12_0 = 12; +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base)) +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier) +TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER)) +TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base) +TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300 +TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400 +TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500 + SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator; _javascript_CORE_FRAMEWORKS_DIR = $(SYSTEM_LIBRARY_DIR)/Frameworks; Modified: trunk/Tools/ChangeLog (268330 => 268331) --- trunk/Tools/ChangeLog 2020-10-12 01:11:44 UTC (rev 268330) +++ trunk/Tools/ChangeLog 2020-10-12 01:25:46 UTC (rev 268331) @@ -1,3 +1,19 @@ +2020-10-11 Darin Adler + +[macOS] Harden more build configurations against macOS versions 11 and higher as well as inclusion of patch versions +https://bugs.webkit.org/show_bug.cgi?id=217595 + +Reviewed by Alexey Proskuryakov. + +* ContentExtensionTester/Configurations/Base.xcconfig: Updated to same idiom used elsewhere. +* DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto. +* ImageDiff/cg/Configurations/Base.xcconfig: Ditto. +* WebKitTestRunner/Configurations/Base.xcconfig: Ditto. +* lldb/lldbWebKitTester/Configurations/Base.xcconfig: Ditto. + +* Scripts/webkitpy/common/config/contributors.json: Added contributor Luming Yin, an engineer who works on Safari at +Apple who has been contributing
[webkit-changes] [268330] trunk/Source
Title: [268330] trunk/Source Revision 268330 Author da...@apple.com Date 2020-10-11 18:11:44 -0700 (Sun, 11 Oct 2020) Log Message Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur or later https://bugs.webkit.org/show_bug.cgi?id=217594 rdar://70188497 Patch by Luming Yin on 2020-10-11 Reviewed by Darin Adler. To ensure successful Mac Catalyst WebKit builds, strip the patch version from TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. * Configurations/Base.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/Base.xcconfig trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/Base.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/Base.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/Base.xcconfig trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Configurations/Base.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/Base.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/Configurations/Base.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (268329 => 268330) --- trunk/Source/_javascript_Core/ChangeLog 2020-10-12 00:39:22 UTC (rev 268329) +++ trunk/Source/_javascript_Core/ChangeLog 2020-10-12 01:11:44 UTC (rev 268330) @@ -1,5 +1,19 @@ 2020-10-11 Luming Yin +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +2020-10-11 Luming Yin + Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer https://bugs.webkit.org/show_bug.cgi?id=217584 Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (268329 => 268330) --- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 00:39:22 UTC (rev 268329) +++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-12 01:11:44 UTC (rev 268330) @@ -106,7 +106,7 @@ TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier) TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER)) -TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base) +TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base) TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300 TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400 TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500 Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (268329 => 268330) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-10-12 00:39:22 UTC (rev 268329) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-10-12 01:11:44 UTC (rev 268330) @@ -1,5 +1,19 @@ 2020-10-11 Luming Yin +Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur +or later +https://bugs.webkit.org/show_bug.cgi?id=217594 +rdar://70188497 + +Reviewed by Darin Adler. + +To ensure successful Mac Catalyst WebKit builds, strip the patch version from +TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET. + +* Configurations/Base.xcconfig: + +2020-10-11 Luming Yin + Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer https://bugs.webkit.org/show_bug.cgi?id=217584 Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (268329 => 268330) --- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2020-10-12 00:39:22 UTC (rev 268329) +++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2020-10-12 01:11:44 UTC (rev 268330) @@ -73,7 +73,7 @@ TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier) TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER)) -TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base) +TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base) TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300 TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400 TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500 Modified:
[webkit-changes] [268329] trunk/Source/WebCore
Title: [268329] trunk/Source/WebCore
Revision 268329
Author commit-qu...@webkit.org
Date 2020-10-11 17:39:22 -0700 (Sun, 11 Oct 2020)
Log Message
Build failures and warning under Source/WebCore/layout/integration/
https://bugs.webkit.org/show_bug.cgi?id=217593
Unreviewed, fix two build failures caused by missing #includes. (Forward declarations are
not enough here, we need to #include the necessary header.)
Also, fix an unused function warning when LFC is not enabled.
Patch by Michael Catanzaro on 2020-10-11
* layout/integration/LayoutIntegrationLineIterator.cpp:
* layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:
* layout/integration/LayoutIntegrationRunIterator.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (268328 => 268329)
--- trunk/Source/WebCore/ChangeLog 2020-10-12 00:16:53 UTC (rev 268328)
+++ trunk/Source/WebCore/ChangeLog 2020-10-12 00:39:22 UTC (rev 268329)
@@ -1,3 +1,17 @@
+2020-10-11 Michael Catanzaro
+
+Build failures and warning under Source/WebCore/layout/integration/
+https://bugs.webkit.org/show_bug.cgi?id=217593
+
+Unreviewed, fix two build failures caused by missing #includes. (Forward declarations are
+not enough here, we need to #include the necessary header.)
+
+Also, fix an unused function warning when LFC is not enabled.
+
+* layout/integration/LayoutIntegrationLineIterator.cpp:
+* layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:
+* layout/integration/LayoutIntegrationRunIterator.cpp:
+
2020-10-11 Luming Yin
Ignore deployment suffix and identifier when computing major OS version for macOS
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp (268328 => 268329)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp 2020-10-12 00:16:53 UTC (rev 268328)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp 2020-10-12 00:39:22 UTC (rev 268329)
@@ -27,6 +27,7 @@
#include "LayoutIntegrationLineIterator.h"
#include "LayoutIntegrationLineLayout.h"
+#include "LayoutIntegrationRunIterator.h"
namespace WebCore {
namespace LayoutIntegration {
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h (268328 => 268329)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h 2020-10-12 00:16:53 UTC (rev 268328)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h 2020-10-12 00:39:22 UTC (rev 268329)
@@ -26,6 +26,7 @@
#pragma once
#include "LayoutIntegrationInlineContent.h"
+#include "LayoutIntegrationRunIteratorLegacyPath.h"
#include "RootInlineBox.h"
namespace WebCore {
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp (268328 => 268329)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp 2020-10-12 00:16:53 UTC (rev 268328)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp 2020-10-12 00:39:22 UTC (rev 268329)
@@ -160,6 +160,7 @@
return *this;
}
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
static const RenderBlockFlow* lineLayoutSystemFlowForRenderer(const RenderObject& renderer)
{
// In currently supported cases the renderer is always direct child of the flow.
@@ -167,6 +168,7 @@
return nullptr;
return downcast(renderer.parent());
}
+#endif
TextRunIterator firstTextRunFor(const RenderText& text)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268328] trunk/Source/WebKit
Title: [268328] trunk/Source/WebKit Revision 268328 Author commit-qu...@webkit.org Date 2020-10-11 17:16:53 -0700 (Sun, 11 Oct 2020) Log Message -Wreorder in MediaPlayerPrivateRemote.cpp https://bugs.webkit.org/show_bug.cgi?id=217590 Patch by Michael Catanzaro on 2020-10-11 Reviewed by Eric Carlson. Reorder initializer list to avoid misleading initialization order. It might be nicer to actually reorder the member variables in the class itself, which would probably be safe, but that would be a behavior change and I'd rather avoid changing behavior. * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (268327 => 268328) --- trunk/Source/WebKit/ChangeLog 2020-10-11 23:34:10 UTC (rev 268327) +++ trunk/Source/WebKit/ChangeLog 2020-10-12 00:16:53 UTC (rev 268328) @@ -1,3 +1,19 @@ +2020-10-11 Michael Catanzaro + +-Wreorder in MediaPlayerPrivateRemote.cpp +https://bugs.webkit.org/show_bug.cgi?id=217590 + +Reviewed by Eric Carlson. + +Reorder initializer list to avoid misleading initialization order. + +It might be nicer to actually reorder the member variables in the class itself, which would +probably be safe, but that would be a behavior change and I'd rather avoid changing +behavior. + +* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: +(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): + 2020-10-11 Luming Yin Ignore deployment suffix and identifier when computing major OS version for macOS Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (268327 => 268328) --- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-11 23:34:10 UTC (rev 268327) +++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-12 00:16:53 UTC (rev 268328) @@ -92,11 +92,13 @@ #if !PLATFORM(COCOA) MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerIdentifier playerIdentifier, RemoteMediaPlayerManager& manager) -: m_player(player) +: #if !RELEASE_LOG_DISABLED -, m_logger(player->mediaPlayerLogger()) + m_logger(player->mediaPlayerLogger()) , m_logIdentifier(player->mediaPlayerLogIdentifier()) +, #endif + m_player(player) , m_mediaResourceLoader(*player->createResourceLoader()) , m_manager(manager) , m_remoteEngineIdentifier(engineIdentifier) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268327] trunk/Source
Title: [268327] trunk/Source
Revision 268327
Author commit-qu...@webkit.org
Date 2020-10-11 16:34:10 -0700 (Sun, 11 Oct 2020)
Log Message
Ignore deployment suffix and identifier when computing major OS version for macOS
Big Sur and newer
https://bugs.webkit.org/show_bug.cgi?id=217584
rdar://70168426
Patch by Luming Yin on 2020-10-11
Reviewed by Darin Adler.
Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
Only use the deployment target base for macOS Big Sur and newer. Keep the manual
definitions for legacy versions of macOS.
* Configurations/Base.xcconfig:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/Base.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/Base.xcconfig
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Configurations/Base.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/Configurations/Base.xcconfig
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (268326 => 268327)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-11 23:11:05 UTC (rev 268326)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-11 23:34:10 UTC (rev 268327)
@@ -1,3 +1,18 @@
+2020-10-11 Luming Yin
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
2020-10-11 Yusuke Suzuki
Unreviewed, mark missing custom getter and setters
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (268326 => 268327)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-11 23:11:05 UTC (rev 268326)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2020-10-11 23:34:10 UTC (rev 268327)
@@ -102,13 +102,15 @@
HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
-TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
-TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500;
-TARGET_MAC_OS_X_VERSION_MAJOR_11_0 = 11;
-TARGET_MAC_OS_X_VERSION_MAJOR_12_0 = 12;
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
+TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER))
+TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base)
+TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300
+TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400
+TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500
+
WK_TARGET_IOS_VERSION_MAJOR = $(IPHONEOS_DEPLOYMENT_TARGET:base); // e.g. iOS 9.3 => 9
WK_TARGET_TVOS_VERSION_MAJOR = $(TVOS_DEPLOYMENT_TARGET:base);
WK_TARGET_WATCHOS_VERSION_MAJOR = $(WATCHOS_DEPLOYMENT_TARGET:base);
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (268326 => 268327)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-10-11 23:11:05 UTC (rev 268326)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-10-11 23:34:10 UTC (rev 268327)
@@ -1,3 +1,18 @@
+2020-10-11 Luming Yin
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
2020-10-07 Keith Rollin
Update post-processing rules for headers to not unnecessarily change timestamps
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (268326 => 268327)
---
[webkit-changes] [268326] trunk/Source/WebCore
Title: [268326] trunk/Source/WebCore Revision 268326 Author commit-qu...@webkit.org Date 2020-10-11 16:11:05 -0700 (Sun, 11 Oct 2020) Log Message -Wunused-param in MediaRecorder.cpp https://bugs.webkit.org/show_bug.cgi?id=217587 Unreviewed, fix build warning Patch by Michael Catanzaro on 2020-10-11 * Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::isTypeSupported): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (268325 => 268326) --- trunk/Source/WebCore/ChangeLog 2020-10-11 21:54:48 UTC (rev 268325) +++ trunk/Source/WebCore/ChangeLog 2020-10-11 23:11:05 UTC (rev 268326) @@ -1,3 +1,13 @@ +2020-10-11 Michael Catanzaro + +-Wunused-param in MediaRecorder.cpp +https://bugs.webkit.org/show_bug.cgi?id=217587 + +Unreviewed, fix build warning + +* Modules/mediarecorder/MediaRecorder.cpp: +(WebCore::MediaRecorder::isTypeSupported): + 2020-10-11 Rob Buis Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmultiscriptsTag or ASSERTION FAILED: tagName == mrootTag Modified: trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp (268325 => 268326) --- trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp 2020-10-11 21:54:48 UTC (rev 268325) +++ trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp 2020-10-11 23:11:05 UTC (rev 268326) @@ -53,6 +53,7 @@ return page && page->mediaRecorderProvider().isSupported(value); #else UNUSED_PARAM(document); +UNUSED_PARAM(value); return false; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268325] trunk/Source/JavaScriptCore
Title: [268325] trunk/Source/_javascript_Core
Revision 268325
Author ysuz...@apple.com
Date 2020-10-11 14:54:48 -0700 (Sun, 11 Oct 2020)
Log Message
Unreviewed, mark missing custom getter and setters
https://bugs.webkit.org/show_bug.cgi?id=217500
* tools/JSDollarVM.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tools/JSDollarVM.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (268324 => 268325)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-11 19:16:49 UTC (rev 268324)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-11 21:54:48 UTC (rev 268325)
@@ -1,5 +1,12 @@
2020-10-11 Yusuke Suzuki
+Unreviewed, mark missing custom getter and setters
+https://bugs.webkit.org/show_bug.cgi?id=217500
+
+* tools/JSDollarVM.cpp:
+
+2020-10-11 Yusuke Suzuki
+
[JSC] arguments.callee should become ThrowTypeError if function has non simple parameter list
https://bugs.webkit.org/show_bug.cgi?id=217574
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (268324 => 268325)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-10-11 19:16:49 UTC (rev 268324)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-10-11 21:54:48 UTC (rev 268325)
@@ -671,6 +671,7 @@
};
static JSC_DECLARE_CUSTOM_GETTER(testStaticAccessorGetter);
+static JSC_DECLARE_CUSTOM_SETTER(testStaticAccessorPutter);
JSC_DEFINE_CUSTOM_GETTER(testStaticAccessorGetter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, PropertyName))
{
@@ -685,7 +686,7 @@
return JSValue::encode(jsUndefined());
}
-static bool testStaticAccessorPutter(JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value)
+JSC_DEFINE_CUSTOM_SETTER(testStaticAccessorPutter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value))
{
DollarVMAssertScope assertScope;
VM& vm = globalObject->vm();
@@ -746,13 +747,16 @@
}
};
-static EncodedJSValue testStaticValueGetter(JSGlobalObject*, EncodedJSValue, PropertyName)
+static JSC_DECLARE_CUSTOM_GETTER(testStaticValueGetter);
+static JSC_DECLARE_CUSTOM_SETTER(testStaticValuePutter);
+
+JSC_DEFINE_CUSTOM_GETTER(testStaticValueGetter, (JSGlobalObject*, EncodedJSValue, PropertyName))
{
DollarVMAssertScope assertScope;
return JSValue::encode(jsUndefined());
}
-static bool testStaticValuePutter(JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value)
+JSC_DEFINE_CUSTOM_SETTER(testStaticValuePutter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value))
{
DollarVMAssertScope assertScope;
VM& vm = globalObject->vm();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268324] trunk
Title: [268324] trunk Revision 268324 Author commit-qu...@webkit.org Date 2020-10-11 12:16:49 -0700 (Sun, 11 Oct 2020) Log Message Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmultiscriptsTag or ASSERTION FAILED: tagName == mrootTag https://bugs.webkit.org/show_bug.cgi?id=202804 Patch by Rob Buis on 2020-10-11 Reviewed by Frédéric Wang. Source/WebCore: Both rootTypeOf and scriptTypeOf were expecting the qualified name to have no prefix, however it is possible in xhtml that prefixes are set, as seen in the Gecko test cases. Failing to detect the qname would hit an ASSERT in both cases. So use QualifiedName.matches which ignores prefixes. Tests: mathml/scripts-with-prefixes.xhtml mathml/square-roots-with-prefixes.xhtml * mathml/MathMLRootElement.cpp: (WebCore::rootTypeOf): * mathml/MathMLScriptsElement.cpp: (WebCore::scriptTypeOf): LayoutTests: Reduce Gecko test crashes into two tests. * mathml/scripts-with-prefixes-expected.txt: Added. * mathml/scripts-with-prefixes.xhtml: Added. * mathml/square-roots-with-prefixes-expected.txt: Added. * mathml/square-roots-with-prefixes.xhtml: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/mathml/MathMLRootElement.cpp trunk/Source/WebCore/mathml/MathMLScriptsElement.cpp Added Paths trunk/LayoutTests/mathml/scripts-with-prefixes-expected.txt trunk/LayoutTests/mathml/scripts-with-prefixes.xhtml trunk/LayoutTests/mathml/square-roots-with-prefixes-expected.txt trunk/LayoutTests/mathml/square-roots-with-prefixes.xhtml Diff Modified: trunk/LayoutTests/ChangeLog (268323 => 268324) --- trunk/LayoutTests/ChangeLog 2020-10-11 18:21:10 UTC (rev 268323) +++ trunk/LayoutTests/ChangeLog 2020-10-11 19:16:49 UTC (rev 268324) @@ -1,3 +1,17 @@ +2020-10-11 Rob Buis + +Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmultiscriptsTag or ASSERTION FAILED: tagName == mrootTag +https://bugs.webkit.org/show_bug.cgi?id=202804 + +Reviewed by Frédéric Wang. + +Reduce Gecko test crashes into two tests. + +* mathml/scripts-with-prefixes-expected.txt: Added. +* mathml/scripts-with-prefixes.xhtml: Added. +* mathml/square-roots-with-prefixes-expected.txt: Added. +* mathml/square-roots-with-prefixes.xhtml: Added. + 2020-10-10 Darin Adler REGRESSION (r267761): editing/mac/spelling/autocorrection-contraction.html is a constant timeout on macOS wk2 Debug Added: trunk/LayoutTests/mathml/scripts-with-prefixes-expected.txt (0 => 268324) --- trunk/LayoutTests/mathml/scripts-with-prefixes-expected.txt (rev 0) +++ trunk/LayoutTests/mathml/scripts-with-prefixes-expected.txt 2020-10-11 19:16:49 UTC (rev 268324) @@ -0,0 +1,2 @@ +This test passes if it does not crash. + Added: trunk/LayoutTests/mathml/scripts-with-prefixes.xhtml (0 => 268324) --- trunk/LayoutTests/mathml/scripts-with-prefixes.xhtml (rev 0) +++ trunk/LayoutTests/mathml/scripts-with-prefixes.xhtml 2020-10-11 19:16:49 UTC (rev 268324) @@ -0,0 +1,21 @@ + + + + +if (window.testRunner) +testRunner.dumpAsText(); + + + + +This test passes if it does not crash. + + + + + + + + + + Added: trunk/LayoutTests/mathml/square-roots-with-prefixes-expected.txt (0 => 268324) --- trunk/LayoutTests/mathml/square-roots-with-prefixes-expected.txt (rev 0) +++ trunk/LayoutTests/mathml/square-roots-with-prefixes-expected.txt 2020-10-11 19:16:49 UTC (rev 268324) @@ -0,0 +1,2 @@ +This test passes if it does not crash. + Added: trunk/LayoutTests/mathml/square-roots-with-prefixes.xhtml (0 => 268324) --- trunk/LayoutTests/mathml/square-roots-with-prefixes.xhtml (rev 0) +++ trunk/LayoutTests/mathml/square-roots-with-prefixes.xhtml 2020-10-11 19:16:49 UTC (rev 268324) @@ -0,0 +1,16 @@ + + + + +if (window.testRunner) +testRunner.dumpAsText(); + + + + +This test passes if it does not crash. + + + + + Modified: trunk/Source/WebCore/ChangeLog (268323 => 268324) --- trunk/Source/WebCore/ChangeLog 2020-10-11 18:21:10 UTC (rev 268323) +++ trunk/Source/WebCore/ChangeLog 2020-10-11 19:16:49 UTC (rev 268324) @@ -1,3 +1,24 @@ +2020-10-11 Rob Buis + +Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmultiscriptsTag or ASSERTION FAILED: tagName == mrootTag +https://bugs.webkit.org/show_bug.cgi?id=202804 + +Reviewed by Frédéric Wang. + +Both rootTypeOf and scriptTypeOf were expecting the qualified name +to have no prefix, however it is possible in xhtml that prefixes are +set, as seen in the Gecko test cases. Failing to detect the qname +would hit an ASSERT in both cases. So use QualifiedName.matches +which ignores prefixes. + +Tests: mathml/scripts-with-prefixes.xhtml +
[webkit-changes] [268323] trunk
Title: [268323] trunk Revision 268323 Author ysuz...@apple.com Date 2020-10-11 11:21:10 -0700 (Sun, 11 Oct 2020) Log Message [JSC] arguments.callee should become ThrowTypeError if function has non simple parameter list https://bugs.webkit.org/show_bug.cgi?id=217574 Reviewed by Darin Adler. JSTests: * stress/arguments-and-non-simple-parameters.js: Added. (shouldBe): (ThrowTypeError.Object.getOwnPropertyDescriptor): (testUnmappedArguments): (testMappedArguments): (argumentGenerator2.inner): (argumentGenerator2): (argumentGenerator3.inner): (argumentGenerator3): (argumentGenerator4): (argumentGenerator5.inner.inner2): (argumentGenerator5.inner): (argumentGenerator5): (argumentGenerator6): (argumentGenerator7.inner): (argumentGenerator7): (argumentGenerator8.inner): (argumentGenerator8): (argumentGenerator9.inner): (argumentGenerator9): (argumentGenerator10.inner.inner2): (argumentGenerator10.inner): (argumentGenerator10): * test262/expectations.yaml: Source/_javascript_Core: We should set ThrowTypeError in ClonedArguments when the callee is strict mode or callee has non simple parameter list[1]. We propagate NonSimpleParameterList information from parser and use it when materializing "callee" property of ClonedArguments. [1]: https://tc39.es/ecma262/#sec-functiondeclarationinstantiation * parser/Nodes.h: (JSC::ScopeNode::isStrictMode const): (JSC::ScopeNode::usesNonSimpleParameterList const): (JSC::ScopeNode::setFeatures): Deleted. (JSC::ScopeNode::setUsesArguments): Deleted. * parser/Parser.cpp: (JSC::Parser::parseInner): * parser/ParserModes.h: * runtime/ClonedArguments.cpp: (JSC::ClonedArguments::getOwnPropertySlot): (JSC::ClonedArguments::materializeSpecials): * runtime/ScriptExecutable.h: (JSC::ScriptExecutable::usesNonSimpleParameterList const): Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/parser/Nodes.h trunk/Source/_javascript_Core/parser/Parser.cpp trunk/Source/_javascript_Core/parser/ParserModes.h trunk/Source/_javascript_Core/runtime/ClonedArguments.cpp trunk/Source/_javascript_Core/runtime/ScriptExecutable.h Added Paths trunk/JSTests/stress/arguments-and-non-simple-parameters.js Diff Modified: trunk/JSTests/ChangeLog (268322 => 268323) --- trunk/JSTests/ChangeLog 2020-10-11 18:14:28 UTC (rev 268322) +++ trunk/JSTests/ChangeLog 2020-10-11 18:21:10 UTC (rev 268323) @@ -1,5 +1,37 @@ 2020-10-11 Yusuke Suzuki +[JSC] arguments.callee should become ThrowTypeError if function has non simple parameter list +https://bugs.webkit.org/show_bug.cgi?id=217574 + +Reviewed by Darin Adler. + +* stress/arguments-and-non-simple-parameters.js: Added. +(shouldBe): +(ThrowTypeError.Object.getOwnPropertyDescriptor): +(testUnmappedArguments): +(testMappedArguments): +(argumentGenerator2.inner): +(argumentGenerator2): +(argumentGenerator3.inner): +(argumentGenerator3): +(argumentGenerator4): +(argumentGenerator5.inner.inner2): +(argumentGenerator5.inner): +(argumentGenerator5): +(argumentGenerator6): +(argumentGenerator7.inner): +(argumentGenerator7): +(argumentGenerator8.inner): +(argumentGenerator8): +(argumentGenerator9.inner): +(argumentGenerator9): +(argumentGenerator10.inner.inner2): +(argumentGenerator10.inner): +(argumentGenerator10): +* test262/expectations.yaml: + +2020-10-11 Yusuke Suzuki + [JSC] BigInt constructor should be constructible while it always throws an error https://bugs.webkit.org/show_bug.cgi?id=217575 Added: trunk/JSTests/stress/arguments-and-non-simple-parameters.js (0 => 268323) --- trunk/JSTests/stress/arguments-and-non-simple-parameters.js (rev 0) +++ trunk/JSTests/stress/arguments-and-non-simple-parameters.js 2020-10-11 18:21:10 UTC (rev 268323) @@ -0,0 +1,124 @@ +// Copyright (C) 2012-2013 Ecma International +// Copyright (C) 2016 André Bargull. All rights reserved. +// Copyright (C) 2020 Apple Inc. All rights reserved. +// All rights reserved. +// +// Redistribution and use in source and binary forms, with or without modification, are permitted provided that the +// following conditions are met: +// 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following +// disclaimer. +// 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the +// following disclaimer in the documentation and/or other materials provided with the distribution. +// 3. Neither the name of the authors nor Ecma International may be used to endorse or promote products derived from +// this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE ECMA INTERNATIONAL
[webkit-changes] [268322] trunk
Title: [268322] trunk
Revision 268322
Author ysuz...@apple.com
Date 2020-10-11 11:14:28 -0700 (Sun, 11 Oct 2020)
Log Message
[JSC] BigInt constructor should be constructible while it always throws an error
https://bugs.webkit.org/show_bug.cgi?id=217575
Reviewed by Darin Adler.
JSTests:
* stress/is-constructor.js:
* stress/non-constructable-constructors.js: Added.
(shouldThrow):
Source/_javascript_Core:
In terms of the spec, BigInt constructor should be a constructor. So we should put constructBigIntConstructor function instead of nullptr.
But it should always throw a TypeError. Error message looks a bit awkward ("TypeError: function is not a constructor..."), but this looks
most intuitive to users. Note that V8 and SpiderMonkey throw similar messages ("is not a constructor").
* runtime/BigIntConstructor.cpp:
(JSC::BigIntConstructor::BigIntConstructor):
(JSC::JSC_DEFINE_HOST_FUNCTION):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/is-constructor.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp
Added Paths
trunk/JSTests/stress/non-constructable-constructors.js
Diff
Modified: trunk/JSTests/ChangeLog (268321 => 268322)
--- trunk/JSTests/ChangeLog 2020-10-11 18:03:14 UTC (rev 268321)
+++ trunk/JSTests/ChangeLog 2020-10-11 18:14:28 UTC (rev 268322)
@@ -1,5 +1,16 @@
2020-10-11 Yusuke Suzuki
+[JSC] BigInt constructor should be constructible while it always throws an error
+https://bugs.webkit.org/show_bug.cgi?id=217575
+
+Reviewed by Darin Adler.
+
+* stress/is-constructor.js:
+* stress/non-constructable-constructors.js: Added.
+(shouldThrow):
+
+2020-10-11 Yusuke Suzuki
+
[JSC] LowerCase when LanguageTag checks duplicate variants
https://bugs.webkit.org/show_bug.cgi?id=217571
Modified: trunk/JSTests/stress/is-constructor.js (268321 => 268322)
--- trunk/JSTests/stress/is-constructor.js 2020-10-11 18:03:14 UTC (rev 268321)
+++ trunk/JSTests/stress/is-constructor.js 2020-10-11 18:14:28 UTC (rev 268322)
@@ -26,6 +26,7 @@
// Builtin constructors.
assert(isConstructor(Array));
assert(isConstructor(ArrayBuffer));
+assert(isConstructor(BigInt));
assert(isConstructor(Boolean));
assert(isConstructor(Date));
assert(isConstructor(Error));
Added: trunk/JSTests/stress/non-constructable-constructors.js (0 => 268322)
--- trunk/JSTests/stress/non-constructable-constructors.js (rev 0)
+++ trunk/JSTests/stress/non-constructable-constructors.js 2020-10-11 18:14:28 UTC (rev 268322)
@@ -0,0 +1,19 @@
+function shouldThrow(func, errorMessage) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+}
+
+shouldThrow(() => new Symbol(), `TypeError: function is not a constructor (evaluating 'new Symbol()')`);
+shouldThrow(() => new Symbol(Symbol("Hey")), `TypeError: function is not a constructor (evaluating 'new Symbol(Symbol("Hey"))')`);
+shouldThrow(() => new BigInt(), `TypeError: function is not a constructor (evaluating 'new BigInt()')`);
+shouldThrow(() => new BigInt(0), `TypeError: function is not a constructor (evaluating 'new BigInt(0)')`);
Modified: trunk/Source/_javascript_Core/ChangeLog (268321 => 268322)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-11 18:03:14 UTC (rev 268321)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-11 18:14:28 UTC (rev 268322)
@@ -1,5 +1,20 @@
2020-10-11 Yusuke Suzuki
+[JSC] BigInt constructor should be constructible while it always throws an error
+https://bugs.webkit.org/show_bug.cgi?id=217575
+
+Reviewed by Darin Adler.
+
+In terms of the spec, BigInt constructor should be a constructor. So we should put constructBigIntConstructor function instead of nullptr.
+But it should always throw a TypeError. Error message looks a bit awkward ("TypeError: function is not a constructor..."), but this looks
+most intuitive to users. Note that V8 and SpiderMonkey throw similar messages ("is not a constructor").
+
+* runtime/BigIntConstructor.cpp:
+(JSC::BigIntConstructor::BigIntConstructor):
+(JSC::JSC_DEFINE_HOST_FUNCTION):
+
+2020-10-11 Yusuke Suzuki
+
[JSC] LowerCase when LanguageTag checks duplicate variants
https://bugs.webkit.org/show_bug.cgi?id=217571
Modified: trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp (268321 => 268322)
--- trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp 2020-10-11 18:03:14 UTC (rev 268321)
+++ trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp 2020-10-11 18:14:28 UTC (rev 268322)
@@ -55,9 +55,10 @@
*/
static JSC_DECLARE_HOST_FUNCTION(callBigIntConstructor);
+static
[webkit-changes] [268321] trunk
Title: [268321] trunk Revision 268321 Author da...@apple.com Date 2020-10-11 11:03:14 -0700 (Sun, 11 Oct 2020) Log Message REGRESSION (r267761): editing/mac/spelling/autocorrection-contraction.html is a constant timeout on macOS wk2 Debug https://bugs.webkit.org/show_bug.cgi?id=217548 Reviewed by Alexey Proskuryakov. Tools: * TestRunnerShared/Bindings/JSBasics.cpp: (WTR::objectProperty): Use JSValueIsObject instead of JSValueToObject. The latter function is *very* slow when passed undefined or null, creating an exception object every time, even when we pass nullptr to indicate that we don't want the exception object, and also invoking debugging machinery to inform the "inspector" about this exception, which results in logging to the console while running tests. This inefficiency is something we can fix in _javascript_Core if we like, and makes it a bad idea to call the function on undefined and null. And also points out the problem with passing exceptions to anyone except the caller: there's no reason the inspector needs to know about the exception in a case like this. Because the uses of this function in the test runners don't need that behavior of converting non-object values to objects, it was best just to stop using JSValueToObject entirely. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): Use uint64Value here. Just something missed in my earlier refactoring and spotted while debugging. LayoutTests: * editing/mac/spelling/autocorrection-contraction-expected.html: Added. * editing/mac/spelling/autocorrection-contraction-expected.png: Removed. * editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. * editing/mac/spelling/autocorrection-contraction.html: Simplified this and changed it to a ref test. * platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.png: Removed. * platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. * platform/win/editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. * platform/mac/TestExpectations: Remove failure and timeout expectations for autocorrection-contraction.html. Both because the slowness in WebKitTestRunner causing the timeout issue was fixed, and because the new reference test is unlikely to be flaky. * platform/wk2/TestExpectations: Removed timeout expectations for two other tests affected by the same bug in WebKitTestRunner. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction.html trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/wk2/TestExpectations trunk/Tools/ChangeLog trunk/Tools/TestRunnerShared/Bindings/JSBasics.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp Added Paths trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction-expected.html Removed Paths trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction-expected.png trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction-expected.txt trunk/LayoutTests/platform/mac-wk2/editing/mac/ trunk/LayoutTests/platform/win/editing/mac/spelling/autocorrection-contraction-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (268320 => 268321) --- trunk/LayoutTests/ChangeLog 2020-10-11 16:33:34 UTC (rev 268320) +++ trunk/LayoutTests/ChangeLog 2020-10-11 18:03:14 UTC (rev 268321) @@ -1,3 +1,25 @@ +2020-10-10 Darin Adler + +REGRESSION (r267761): editing/mac/spelling/autocorrection-contraction.html is a constant timeout on macOS wk2 Debug +https://bugs.webkit.org/show_bug.cgi?id=217548 + +Reviewed by Alexey Proskuryakov. + +* editing/mac/spelling/autocorrection-contraction-expected.html: Added. +* editing/mac/spelling/autocorrection-contraction-expected.png: Removed. +* editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. +* editing/mac/spelling/autocorrection-contraction.html: Simplified this and changed it to a ref test. +* platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.png: Removed. +* platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. +* platform/win/editing/mac/spelling/autocorrection-contraction-expected.txt: Removed. + +* platform/mac/TestExpectations: Remove failure and timeout expectations for autocorrection-contraction.html. +Both because the slowness in WebKitTestRunner causing the timeout issue was fixed, and because the new +reference test is unlikely to be flaky. + +* platform/wk2/TestExpectations: Removed timeout expectations for two other tests affected by the same +bug in WebKitTestRunner. + 2020-10-10 Oriol Brufau Fix mac expectations for text-selection.html Added: trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction-expected.html (0 => 268321) ---
[webkit-changes] [268320] trunk/Source/WebCore
Title: [268320] trunk/Source/WebCore Revision 268320 Author wenson_hs...@apple.com Date 2020-10-11 09:33:34 -0700 (Sun, 11 Oct 2020) Log Message [MotionMark] Computing the fast bounding rect of an arc should not materialize a CGPathRef https://bugs.webkit.org/show_bug.cgi?id=217563 Reviewed by Darin Adler. Avoid hitting the slow case when asking for the fast bounding rect of a `Path`, in the case where the path consists of a single circular arc. This fast bounding rect is intended to be a conservative way to estimate the bounds of the path, such that the actual bounds of the path must lie within the bounds of this fast rect. At the cost of being less accurate, we can make this fast computation much cheaper in the case of a circular arc by simply returning the bounding rect of the circle containing the arc. * platform/graphics/InlinePathData.h: (WebCore::ArcData::encode const): (WebCore::ArcData::decode): Additionally rename what is currently `ArcData`'s `offset` member to `start` instead, and `hasOffset` to `hasStart` for clarity. This point optionally provides the starting point of a line segment that is connected to the circular arc defined by the center point, radius, and start and end angles. Note that this starting point needs to be included in the fast bounding rect computation for this reason (see above). * platform/graphics/Path.cpp: (WebCore::Path::addArc): (WebCore::Path::fastBoundingRect const): (WebCore::Path::fastBoundingRectFromInlineData const): (WebCore::Path::boundingRectFromInlineData const): * platform/graphics/Path.h: * platform/graphics/cg/PathCG.cpp: (WebCore::Path::createCGPath const): * platform/graphics/displaylists/DisplayListItems.cpp: (WebCore::DisplayList::StrokePath::localBounds const): Also, use the fast bounding rect when estimating `localBounds` of the `StrokePath` item; these local bounds are only used in an optimization that skips display list items during playback, based on the extent of the item, so it's safe to use extents that are potentially inflated. Using the fast bounding rect also helps in the case of the more complex paths encountered in the Canvas Paths subtest of MotionMark, where each Path contains multiple components and cannot be expressed solely with inline path data. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/InlinePathData.h trunk/Source/WebCore/platform/graphics/Path.cpp trunk/Source/WebCore/platform/graphics/Path.h trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (268319 => 268320) --- trunk/Source/WebCore/ChangeLog 2020-10-11 16:12:38 UTC (rev 268319) +++ trunk/Source/WebCore/ChangeLog 2020-10-11 16:33:34 UTC (rev 268320) @@ -1,3 +1,42 @@ +2020-10-11 Wenson Hsieh + +[MotionMark] Computing the fast bounding rect of an arc should not materialize a CGPathRef +https://bugs.webkit.org/show_bug.cgi?id=217563 + +Reviewed by Darin Adler. + +Avoid hitting the slow case when asking for the fast bounding rect of a `Path`, in the case where the path +consists of a single circular arc. This fast bounding rect is intended to be a conservative way to estimate the +bounds of the path, such that the actual bounds of the path must lie within the bounds of this fast rect. At the +cost of being less accurate, we can make this fast computation much cheaper in the case of a circular arc by +simply returning the bounding rect of the circle containing the arc. + +* platform/graphics/InlinePathData.h: +(WebCore::ArcData::encode const): +(WebCore::ArcData::decode): + +Additionally rename what is currently `ArcData`'s `offset` member to `start` instead, and `hasOffset` to +`hasStart` for clarity. This point optionally provides the starting point of a line segment that is connected to +the circular arc defined by the center point, radius, and start and end angles. Note that this starting point +needs to be included in the fast bounding rect computation for this reason (see above). + +* platform/graphics/Path.cpp: +(WebCore::Path::addArc): +(WebCore::Path::fastBoundingRect const): +(WebCore::Path::fastBoundingRectFromInlineData const): +(WebCore::Path::boundingRectFromInlineData const): +* platform/graphics/Path.h: +* platform/graphics/cg/PathCG.cpp: +(WebCore::Path::createCGPath const): +* platform/graphics/displaylists/DisplayListItems.cpp: +(WebCore::DisplayList::StrokePath::localBounds const): + +Also, use the fast bounding rect when estimating `localBounds` of the `StrokePath` item; these local bounds are +only used in an optimization that skips display list items during playback, based on the extent of the item, so +it's safe to use extents that are potentially
[webkit-changes] [268319] trunk/Tools
Title: [268319] trunk/Tools
Revision 268319
Author jbed...@apple.com
Date 2020-10-11 09:12:38 -0700 (Sun, 11 Oct 2020)
Log Message
[webkitscmpy] Support json encoding of Commit object
https://bugs.webkit.org/show_bug.cgi?id=217533
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:
(Commit.__repr__): Support identifiers being 0.
(Commit.Encoder): Encode commit as dictionary.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (268318 => 268319)
--- trunk/Tools/ChangeLog 2020-10-11 10:26:11 UTC (rev 268318)
+++ trunk/Tools/ChangeLog 2020-10-11 16:12:38 UTC (rev 268319)
@@ -1,3 +1,17 @@
+2020-10-11 Jonathan Bedard
+
+[webkitscmpy] Support json encoding of Commit object
+https://bugs.webkit.org/show_bug.cgi?id=217533
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:
+(Commit.__repr__): Support identifiers being 0.
+(Commit.Encoder): Encode commit as dictionary.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
+
2020-10-11 Yusuke Suzuki
Unreviewed, fix WK2 Debug test failures
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (268318 => 268319)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2020-10-11 10:26:11 UTC (rev 268318)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2020-10-11 16:12:38 UTC (rev 268319)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(0, 1, 2)
+version = Version(0, 1, 3)
AutoInstall.register(Package('dateutil', Version(2, 8, 1), pypi_name='python-dateutil'))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py (268318 => 268319)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py 2020-10-11 10:26:11 UTC (rev 268318)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py 2020-10-11 16:12:38 UTC (rev 268319)
@@ -20,6 +20,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import json
import six
import re
@@ -33,6 +34,26 @@
IDENTIFIER_RE = re.compile(r'^((?P\d+)\.)?(?P-?\d+)(@(?P\S+))?$')
NUMBER_RE = re.compile(r'^-?\d*$')
+class Encoder(json.JSONEncoder):
+
+def default(self, obj):
+if not isinstance(obj, Commit):
+return super(Commit.Encoder, self).default(obj)
+
+result = dict()
+for attribute in ['hash', 'revision', 'branch', 'timestamp', 'message']:
+value = getattr(obj, attribute, None)
+if value is not None:
+result[attribute] = value
+
+if obj.author:
+result['author'] = obj.author.email or obj.author.name
+
+if obj.identifier is not None:
+result['identifier'] = str(obj)
+
+return result
+
@classmethod
def _parse_hash(cls, hash, do_assert=False):
if hash is None:
@@ -214,15 +235,15 @@
return result
def __repr__(self):
-if self.branch_point and self.identifier and self.branch:
+if self.branch_point and self.identifier is not None and self.branch:
return '{}.{}@{}'.format(self.branch_point, self.identifier, self.branch)
-if self.identifier and self.branch:
+if self.identifier is not None and self.branch:
return '{}@{}'.format(self.identifier, self.branch)
if self.revision:
return 'r{}'.format(self.revision)
if self.hash:
return self.hash[:12]
-if self.identifier:
+if self.identifier is not None:
return str(self.identifier)
raise ValueError('Incomplete commit format')
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py (268318 => 268319)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py 2020-10-11 10:26:11 UTC (rev 268318)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py 2020-10-11 16:12:38 UTC (rev 268319)
@@ -20,6 +20,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import json
import unittest
from datetime import datetime
@@ -209,3 +210,49 @@
[webkit-changes] [268318] trunk
Title: [268318] trunk
Revision 268318
Author ysuz...@apple.com
Date 2020-10-11 03:26:11 -0700 (Sun, 11 Oct 2020)
Log Message
[JSC] LowerCase when LanguageTag checks duplicate variants
https://bugs.webkit.org/show_bug.cgi?id=217571
Reviewed by Ross Kirsling.
JSTests:
* stress/intl-language-tag.js:
Source/_javascript_Core:
Since Unicode LanguageTag is case insensitive, we need to recognize "VARIANT0" and "variant0" are the same language tag variants.
To achieve that, we perform toASCIILower when computing VariantCode.
* runtime/IntlObject.cpp:
(JSC::parseVariantCode):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-language-tag.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlObject.cpp
Diff
Modified: trunk/JSTests/ChangeLog (268317 => 268318)
--- trunk/JSTests/ChangeLog 2020-10-11 08:48:50 UTC (rev 268317)
+++ trunk/JSTests/ChangeLog 2020-10-11 10:26:11 UTC (rev 268318)
@@ -1,3 +1,12 @@
+2020-10-11 Yusuke Suzuki
+
+[JSC] LowerCase when LanguageTag checks duplicate variants
+https://bugs.webkit.org/show_bug.cgi?id=217571
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-language-tag.js:
+
2020-10-07 Ross Kirsling
[JSC] Revert String.prototype.item
Modified: trunk/JSTests/stress/intl-language-tag.js (268317 => 268318)
--- trunk/JSTests/stress/intl-language-tag.js 2020-10-11 08:48:50 UTC (rev 268317)
+++ trunk/JSTests/stress/intl-language-tag.js 2020-10-11 10:26:11 UTC (rev 268318)
@@ -96,4 +96,15 @@
shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-a0-000-a1"), RangeError);
shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-a0-a1"), RangeError);
shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GBB"), RangeError);
+
+shouldThrow(() => Intl.getCanonicalLocales("en-US-variant0-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-Variant0-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-VARIANt0-VARIANT0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-variant0-testing-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-Variant0-testing-variant0"), RangeError);
+
shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-variant0-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-Variant0-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-VARIANt0-VARIANT0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-variant0-testing-variant0"), RangeError);
+shouldThrow(() => Intl.getCanonicalLocales("en-US-t-en-GB-Variant0-testing-variant0"), RangeError);
Modified: trunk/Source/_javascript_Core/ChangeLog (268317 => 268318)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-11 08:48:50 UTC (rev 268317)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-11 10:26:11 UTC (rev 268318)
@@ -1,3 +1,16 @@
+2020-10-11 Yusuke Suzuki
+
+[JSC] LowerCase when LanguageTag checks duplicate variants
+https://bugs.webkit.org/show_bug.cgi?id=217571
+
+Reviewed by Ross Kirsling.
+
+Since Unicode LanguageTag is case insensitive, we need to recognize "VARIANT0" and "variant0" are the same language tag variants.
+To achieve that, we perform toASCIILower when computing VariantCode.
+
+* runtime/IntlObject.cpp:
+(JSC::parseVariantCode):
+
2020-10-09 Yusuke Suzuki
[JSC] Assert Operation and HostFunction are in JITOperationsList
Modified: trunk/Source/_javascript_Core/runtime/IntlObject.cpp (268317 => 268318)
--- trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2020-10-11 08:48:50 UTC (rev 268317)
+++ trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2020-10-11 10:26:11 UTC (rev 268318)
@@ -1015,7 +1015,7 @@
static_assert(sizeof(VariantCode) == sizeof(Code));
Code code { };
for (unsigned index = 0; index < string.length(); ++index)
-code.characters[index] = string[index];
+code.characters[index] = toASCIILower(string[index]);
VariantCode result = bitwise_cast(code);
ASSERT(result); // Not possible since some characters exist.
ASSERT(result != static_cast(-1)); // Not possible since all characters are ASCII (not Latin-1).
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268317] trunk/Tools
Title: [268317] trunk/Tools Revision 268317 Author ysuz...@apple.com Date 2020-10-11 01:48:50 -0700 (Sun, 11 Oct 2020) Log Message Unreviewed, fix WK2 Debug test failures https://bugs.webkit.org/show_bug.cgi?id=217500 WebKitTestRunner also uses WebCoreTestSupport's JIT operations so we need to populate them too. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::initialize): Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp Diff Modified: trunk/Tools/ChangeLog (268316 => 268317) --- trunk/Tools/ChangeLog 2020-10-11 05:27:28 UTC (rev 268316) +++ trunk/Tools/ChangeLog 2020-10-11 08:48:50 UTC (rev 268317) @@ -1,3 +1,13 @@ +2020-10-11 Yusuke Suzuki + +Unreviewed, fix WK2 Debug test failures +https://bugs.webkit.org/show_bug.cgi?id=217500 + +WebKitTestRunner also uses WebCoreTestSupport's JIT operations so we need to populate them too. + +* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: +(WTR::InjectedBundle::initialize): + 2020-10-09 Yusuke Suzuki [JSC] Assert Operation and HostFunction are in JITOperationsList Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (268316 => 268317) --- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2020-10-11 05:27:28 UTC (rev 268316) +++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2020-10-11 08:48:50 UTC (rev 268317) @@ -104,6 +104,7 @@ WKBundleSetClient(m_bundle, ); WKBundleSetServiceWorkerProxyCreationCallback(m_bundle, WebCoreTestSupport::setupNewlyCreatedServiceWorker); platformInitialize(initializationUserData); +WebCoreTestSupport::populateJITOperations(); activateFonts(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
