[webkit-changes] [281488] trunk/Source/WebCore

[heycam]

Title: [281488] trunk/Source/WebCore








Revision 281488
Author hey...@apple.com
Date 2021-08-23 22:37:49 -0700 (Mon, 23 Aug 2021)


Log Message
Avoid unnecessary CGColor creation in Gradient::createCGGradient for common sRGB-only cases
https://bugs.webkit.org/show_bug.cgi?id=229422


Reviewed by Sam Weinig.

* platform/graphics/Gradient.h:
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::hasOnlyBoundedSRGBColorStops const):
(WebCore::Gradient::createCGGradient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Gradient.h
trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281487 => 281488)

--- trunk/Source/WebCore/ChangeLog	2021-08-24 05:07:32 UTC (rev 281487)
+++ trunk/Source/WebCore/ChangeLog	2021-08-24 05:37:49 UTC (rev 281488)
@@ -1,3 +1,16 @@
+2021-08-23  Cameron McCormack  
+
+Avoid unnecessary CGColor creation in Gradient::createCGGradient for common sRGB-only cases
+https://bugs.webkit.org/show_bug.cgi?id=229422
+
+
+Reviewed by Sam Weinig.
+
+* platform/graphics/Gradient.h:
+* platform/graphics/cg/GradientCG.cpp:
+(WebCore::Gradient::hasOnlyBoundedSRGBColorStops const):
+(WebCore::Gradient::createCGGradient):
+
 2021-08-23  Rob Buis  
 
 Null check scriptExecutionContext


Modified: trunk/Source/WebCore/platform/graphics/Gradient.h (281487 => 281488)

--- trunk/Source/WebCore/platform/graphics/Gradient.h	2021-08-24 05:07:32 UTC (rev 281487)
+++ trunk/Source/WebCore/platform/graphics/Gradient.h	2021-08-24 05:37:49 UTC (rev 281488)
@@ -145,6 +145,7 @@
 
 #if USE(CG)
 void createCGGradient();
+bool hasOnlyBoundedSRGBColorStops() const;
 #endif
 
 Data m_data;


Modified: trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp (281487 => 281488)

--- trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp	2021-08-24 05:07:32 UTC (rev 281487)
+++ trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp	2021-08-24 05:37:49 UTC (rev 281488)
@@ -40,11 +40,19 @@
 m_gradient = nullptr;
 }
 
+bool Gradient::hasOnlyBoundedSRGBColorStops() const
+{
+for (const auto& stop : m_stops) {
+if (stop.color.colorSpace() != ColorSpace::SRGB)
+return false;
+}
+return true;
+}
+
 void Gradient::createCGGradient()
 {
 sortStops();
 
-auto colorsArray = adoptCF(CFArrayCreateMutable(0, m_stops.size(), ));
 unsigned numStops = m_stops.size();
 
 const int reservedStops = 3;
@@ -51,26 +59,29 @@
 Vector locations;
 locations.reserveInitialCapacity(numStops);
 
-Vector colorComponents;
-colorComponents.reserveInitialCapacity(numStops * 4);
+// If all the stops are bounded sRGB (as represented by the color having the color space
+// ColorSpace::SRGB), it is faster to create a gradient using components than CGColors.
+if (hasOnlyBoundedSRGBColorStops()) {
+Vector colorComponents;
+colorComponents.reserveInitialCapacity(numStops * 4);
 
-// FIXME: Consider making this into two loops to avoid unnecessary allocation of the
-// CGColorRefs in the common case of all ColorSpace::SRGB.
+for (const auto& stop : m_stops) {
+auto [colorSpace, components] = stop.color.colorSpaceAndComponents();
+auto [r, g, b, a] = components;
+colorComponents.uncheckedAppend(r);
+colorComponents.uncheckedAppend(g);
+colorComponents.uncheckedAppend(b);
+colorComponents.uncheckedAppend(a);
 
-bool hasOnlyBoundedSRGBColorStops = true;
-for (const auto& stop : m_stops) {
-// If all the stops are bounded sRGB (as represented by the color having the color space
-// ColorSpace::SRGB, it is faster to create a gradient using components than CGColors.
-if (stop.color.colorSpace() != ColorSpace::SRGB)
-hasOnlyBoundedSRGBColorStops = false;
+locations.uncheckedAppend(stop.offset);
+}
 
-auto [colorSpace, components] = stop.color.colorSpaceAndComponents();
-auto [r, g, b, a] = components;
-colorComponents.uncheckedAppend(r);
-colorComponents.uncheckedAppend(g);
-colorComponents.uncheckedAppend(b);
-colorComponents.uncheckedAppend(a);
+m_gradient = adoptCF(CGGradientCreateWithColorComponents(sRGBColorSpaceRef(), colorComponents.data(), locations.data(), numStops));
+return;
+}
 
+auto colorsArray = adoptCF(CFArrayCreateMutable(0, m_stops.size(), ));
+for (const auto& stop : m_stops) {
 CFArrayAppendValue(colorsArray.get(), cachedCGColor(stop.color));
 locations.uncheckedAppend(stop.offset);
 }
@@ -81,10 +92,7 @@
 auto extendedColorsGradientColorSpace = sRGBColorSpaceRef();
 #endif
 
-if (hasOnlyBoundedSRGBColorStops)
-m_gradient = adoptCF(CGGradientCreateWithColorComponents(sRGBColorSpaceRef(), colorComponents.data(), 

[webkit-changes] [281487] trunk

[commit-queue]

Title: [281487] trunk








Revision 281487
Author commit-qu...@webkit.org
Date 2021-08-23 22:07:32 -0700 (Mon, 23 Aug 2021)


Log Message
Null check scriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=229272

Patch by Rob Buis  on 2021-08-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

Null check scriptExecutionContext in ensureLocalFontFacesForFamilyRegistered.

Tests: fast/text/font-face-set-add-crash.html

* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):

LayoutTests:

* fast/text/font-face-set-add-crash-expected.txt: Added.
* fast/text/font-face-set-add-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSet.cpp


Added Paths

trunk/LayoutTests/fast/text/font-face-set-add-crash-expected.txt
trunk/LayoutTests/fast/text/font-face-set-add-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281486 => 281487)

--- trunk/LayoutTests/ChangeLog	2021-08-24 03:38:06 UTC (rev 281486)
+++ trunk/LayoutTests/ChangeLog	2021-08-24 05:07:32 UTC (rev 281487)
@@ -1,3 +1,13 @@
+2021-08-23  Rob Buis  
+
+Null check scriptExecutionContext
+https://bugs.webkit.org/show_bug.cgi?id=229272
+
+Reviewed by Ryosuke Niwa.
+
+* fast/text/font-face-set-add-crash-expected.txt: Added.
+* fast/text/font-face-set-add-crash.html: Added.
+
 2021-08-23  John Wilander  
 
 PCM: Support ephemeral measurement with non-persistent WebCore::PrivateClickMeasurement


Added: trunk/LayoutTests/fast/text/font-face-set-add-crash-expected.txt (0 => 281487)

--- trunk/LayoutTests/fast/text/font-face-set-add-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/font-face-set-add-crash-expected.txt	2021-08-24 05:07:32 UTC (rev 281487)
@@ -0,0 +1 @@
+Test passes if it does not crash.


Added: trunk/LayoutTests/fast/text/font-face-set-add-crash.html (0 => 281487)

--- trunk/LayoutTests/fast/text/font-face-set-add-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/text/font-face-set-add-crash.html	2021-08-24 05:07:32 UTC (rev 281487)
@@ -0,0 +1,19 @@
+
+  if (window.testRunner)
+window.testRunner.dumpAsText();
+  _onload_ = () => {
+let div0 = document.createElement('div');
+let progress0 = document.createElement('progress');
+div0.appendChild(progress0);
+let document2 = new Document();
+document2.appendChild(div0);
+progress0.cloneNode();
+let fontFace = new FontFace('a', 'url()');
+let fontFaceSet = document2.fonts;
+queueMicrotask(() => {
+  window.GCController?.collect();
+  fontFaceSet.add(fontFace);
+  document.write("Test passes if it does not crash.");
+});
+  };
+


Modified: trunk/Source/WebCore/ChangeLog (281486 => 281487)

--- trunk/Source/WebCore/ChangeLog	2021-08-24 03:38:06 UTC (rev 281486)
+++ trunk/Source/WebCore/ChangeLog	2021-08-24 05:07:32 UTC (rev 281487)
@@ -1,3 +1,17 @@
+2021-08-23  Rob Buis  
+
+Null check scriptExecutionContext
+https://bugs.webkit.org/show_bug.cgi?id=229272
+
+Reviewed by Ryosuke Niwa.
+
+Null check scriptExecutionContext in ensureLocalFontFacesForFamilyRegistered.
+
+Tests: fast/text/font-face-set-add-crash.html
+
+* css/CSSFontFaceSet.cpp:
+(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
+
 2021-08-23  Alex Christensen  
 
 ThreadSanitizer: data race of WTF::StringImpl in WebCoreNSURLSessionDataTask._metrics instance variable


Modified: trunk/Source/WebCore/css/CSSFontFaceSet.cpp (281486 => 281487)

--- trunk/Source/WebCore/css/CSSFontFaceSet.cpp	2021-08-24 03:38:06 UTC (rev 281486)
+++ trunk/Source/WebCore/css/CSSFontFaceSet.cpp	2021-08-24 05:07:32 UTC (rev 281487)
@@ -109,9 +109,9 @@
 if (m_locallyInstalledFacesLookupTable.contains(familyName))
 return;
 
-AllowUserInstalledFonts allowUserInstalledFonts = AllowUserInstalledFonts::Yes;
-if (m_owningFontSelector->scriptExecutionContext())
-allowUserInstalledFonts = m_owningFontSelector->scriptExecutionContext()->settingsValues().shouldAllowUserInstalledFonts ? AllowUserInstalledFonts::Yes : AllowUserInstalledFonts::No;
+if (!m_owningFontSelector->scriptExecutionContext())
+return;
+AllowUserInstalledFonts allowUserInstalledFonts = m_owningFontSelector->scriptExecutionContext()->settingsValues().shouldAllowUserInstalledFonts ? AllowUserInstalledFonts::Yes : AllowUserInstalledFonts::No;
 Vector capabilities = m_owningFontSelector->scriptExecutionContext()->fontCache().getFontSelectionCapabilitiesInFamily(familyName, allowUserInstalledFonts);
 if (capabilities.isEmpty())
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281486] trunk/Source/WebCore

[commit-queue]

Title: [281486] trunk/Source/WebCore








Revision 281486
Author commit-qu...@webkit.org
Date 2021-08-23 20:38:06 -0700 (Mon, 23 Aug 2021)


Log Message
ThreadSanitizer: data race of WTF::StringImpl in WebCoreNSURLSessionDataTask._metrics instance variable
https://bugs.webkit.org/show_bug.cgi?id=229435

Patch by Alex Christensen  on 2021-08-23
Reviewed by David Kilzer.

Move the isolated copy to the WebCoreNSURLSessionTaskMetrics instead of keeping a copy on the delegate thread
and a copy on whatever thread our media stack wants to use the WebCoreNSURLSessionTaskMetrics on.

* platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:]):
(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:]):
(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:metrics:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (281485 => 281486)

--- trunk/Source/WebCore/ChangeLog	2021-08-24 02:59:56 UTC (rev 281485)
+++ trunk/Source/WebCore/ChangeLog	2021-08-24 03:38:06 UTC (rev 281486)
@@ -1,3 +1,18 @@
+2021-08-23  Alex Christensen  
+
+ThreadSanitizer: data race of WTF::StringImpl in WebCoreNSURLSessionDataTask._metrics instance variable
+https://bugs.webkit.org/show_bug.cgi?id=229435
+
+Reviewed by David Kilzer.
+
+Move the isolated copy to the WebCoreNSURLSessionTaskMetrics instead of keeping a copy on the delegate thread
+and a copy on whatever thread our media stack wants to use the WebCoreNSURLSessionTaskMetrics on.
+
+* platform/network/cocoa/WebCoreNSURLSession.mm:
+(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:]):
+(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:]):
+(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:metrics:]):
+
 2021-08-23  John Wilander  
 
 PCM: Support ephemeral measurement with non-persistent WebCore::PrivateClickMeasurement


Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm (281485 => 281486)

--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2021-08-24 02:59:56 UTC (rev 281485)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2021-08-24 03:38:06 UTC (rev 281486)
@@ -54,7 +54,7 @@
 }
 
 @interface WebCoreNSURLSessionTaskTransactionMetrics : NSObject
-- (instancetype)_initWithMetrics:(const WebCore::NetworkLoadMetrics&)metrics;
+- (instancetype)_initWithMetrics:(WebCore::NetworkLoadMetrics&&)metrics;
 @property (nullable, copy, readonly) NSDate *fetchStartDate;
 @property (nullable, copy, readonly) NSDate *domainLookupStartDate;
 @property (nullable, copy, readonly) NSDate *domainLookupEndDate;
@@ -79,7 +79,7 @@
 WebCore::NetworkLoadMetrics _metrics;
 }
 
-- (instancetype)_initWithMetrics:(const WebCore::NetworkLoadMetrics&)metrics
+- (instancetype)_initWithMetrics:(WebCore::NetworkLoadMetrics&&)metrics
 {
 if (!(self = [super init]))
 return nil;
@@ -206,7 +206,7 @@
 @end
 
 @interface WebCoreNSURLSessionTaskMetrics : NSObject
-- (instancetype)_initWithMetrics:(const WebCore::NetworkLoadMetrics&)metrics;
+- (instancetype)_initWithMetrics:(WebCore::NetworkLoadMetrics&&)metrics;
 @property (copy, readonly) NSArray *transactionMetrics;
 @end
 
@@ -214,11 +214,11 @@
 RetainPtr _transactionMetrics;
 }
 
-- (instancetype)_initWithMetrics:(const WebCore::NetworkLoadMetrics&)metrics
+- (instancetype)_initWithMetrics:(WebCore::NetworkLoadMetrics&&)metrics
 {
 if (!(self = [super init]))
 return nil;
-_transactionMetrics = adoptNS([[WebCoreNSURLSessionTaskTransactionMetrics alloc] _initWithMetrics:metrics]);
+_transactionMetrics = adoptNS([[WebCoreNSURLSessionTaskTransactionMetrics alloc] _initWithMetrics:WTFMove(metrics)]);
 return self;
 }
 
@@ -941,11 +941,11 @@
 RetainPtr strongSelf { self };
 RetainPtr strongSession { self.session };
 RetainPtr strongError { error };
-[self.session addDelegateOperation:[strongSelf, strongSession, strongError, metrics = metrics.isolatedCopy()] {
+[self.session addDelegateOperation:[strongSelf, strongSession, strongError, metrics = metrics.isolatedCopy()] () mutable {
 id delegate = (id)strongSession.get().delegate;
 
 if ([delegate respondsToSelector:@selector(URLSession:task:didFinishCollectingMetrics:)])
-[delegate URLSession:(NSURLSession *)strongSession.get() task:(NSURLSessionDataTask *)strongSelf.get() didFinishCollectingMetrics:(NSURLSessionTaskMetrics *)adoptNS([[WebCoreNSURLSessionTaskMetrics alloc] _initWithMetrics:metrics]).get()];
+[delegate URLSession:(NSURLSession *)strongSession.get() task:(NSURLSessionDataTask *)strongSelf.get() didFinishCollectingMetrics:(NSURLSessionTaskMetrics *)adoptNS([[WebCoreNSURLSessionTaskMetrics alloc] _initWithMetrics:WTFMove(metrics)]).get()];
 
 if 

[webkit-changes] [281485] trunk

[sbarati]

Title: [281485] trunk








Revision 281485
Author sbar...@apple.com
Date 2021-08-23 19:59:56 -0700 (Mon, 23 Aug 2021)


Log Message
Disable peephole optimizations in the byte code generator after rewriting instructions for for-in
https://bugs.webkit.org/show_bug.cgi?id=229420


Reviewed by Keith Miller.

JSTests:

* stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js: Added.
(foo):

Source/_javascript_Core:

The final instruction in a for-in loop might be the get by val that
we're rewriting because there was an escape. We won't ever actually
do peephole optimizations on this get_by_val today, but it breaks
some bookkeeping that the bytecode generator does. This patch makes
sure the bookkeeping is up to date.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::ForInContext::finalize):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp


Added Paths

trunk/JSTests/stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js




Diff

Modified: trunk/JSTests/ChangeLog (281484 => 281485)

--- trunk/JSTests/ChangeLog	2021-08-24 01:28:17 UTC (rev 281484)
+++ trunk/JSTests/ChangeLog	2021-08-24 02:59:56 UTC (rev 281485)
@@ -1,5 +1,16 @@
 2021-08-23  Saam Barati  
 
+Disable peephole optimizations in the byte code generator after rewriting instructions for for-in
+https://bugs.webkit.org/show_bug.cgi?id=229420
+
+
+Reviewed by Keith Miller.
+
+* stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js: Added.
+(foo):
+
+2021-08-23  Saam Barati  
+
 compileEnumeratorHasProperty uses flushRegisters incorrectly
 https://bugs.webkit.org/show_bug.cgi?id=229412
 


Added: trunk/JSTests/stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js (0 => 281485)

--- trunk/JSTests/stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js	(rev 0)
+++ trunk/JSTests/stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite.js	2021-08-24 02:59:56 UTC (rev 281485)
@@ -0,0 +1,9 @@
+function foo() {
+for (let x in []) {
+x in undefined;
+x = 0;
+[][x];
+}
+}
+foo();
+


Modified: trunk/Source/_javascript_Core/ChangeLog (281484 => 281485)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-24 01:28:17 UTC (rev 281484)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-24 02:59:56 UTC (rev 281485)
@@ -1,5 +1,22 @@
 2021-08-23  Saam Barati  
 
+Disable peephole optimizations in the byte code generator after rewriting instructions for for-in
+https://bugs.webkit.org/show_bug.cgi?id=229420
+
+
+Reviewed by Keith Miller.
+
+The final instruction in a for-in loop might be the get by val that
+we're rewriting because there was an escape. We won't ever actually
+do peephole optimizations on this get_by_val today, but it breaks
+some bookkeeping that the bytecode generator does. This patch makes
+sure the bookkeeping is up to date.
+
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::ForInContext::finalize):
+
+2021-08-23  Saam Barati  
+
 compileEnumeratorHasProperty uses flushRegisters incorrectly
 https://bugs.webkit.org/show_bug.cgi?id=229412
 


Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (281484 => 281485)

--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp	2021-08-24 01:28:17 UTC (rev 281484)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp	2021-08-24 02:59:56 UTC (rev 281485)
@@ -5369,9 +5369,6 @@
 if (!escaped)
 return;
 
-OpcodeID lastOpcodeID = generator.m_lastOpcodeID;
-InstructionStream::MutableRef lastInstruction = generator.m_lastInstruction;
-
 for (const auto& instTuple : m_getInsts)
 rewriteOp(generator, instTuple);
 
@@ -5390,8 +5387,6 @@
 
 generator.m_writer.seek(branchInstIndex);
 
-generator.disablePeepholeOptimization();
-
 OpJmp::emit(, BoundLabel(static_cast(newBranchTarget) - static_cast(branchInstIndex)));
 
 while (generator.m_writer.position() < end)
@@ -5398,11 +5393,9 @@
 OpNop::emit();
 }
 
+generator.disablePeepholeOptimization(); // We might've just changed the last bytecode that was emitted.
+
 generator.m_writer.seek(generator.m_writer.size());
-if (generator.m_lastInstruction.offset() + generator.m_lastInstruction->size() != generator.m_writer.size()) {
-generator.m_lastOpcodeID = lastOpcodeID;
-generator.m_lastInstruction = lastInstruction;
-}
 }
 
 void StaticPropertyAnalysis::record()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281484] tags/Safari-612.2.2/

[repstein]

Title: [281484] tags/Safari-612.2.2/








Revision 281484
Author repst...@apple.com
Date 2021-08-23 18:28:17 -0700 (Mon, 23 Aug 2021)


Log Message
Tag Safari-612.2.2.

Added Paths

tags/Safari-612.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281483] tags/Safari-612.2.2/

[repstein]

Title: [281483] tags/Safari-612.2.2/








Revision 281483
Author repst...@apple.com
Date 2021-08-23 18:23:57 -0700 (Mon, 23 Aug 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-612.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281482] tags/Safari-612.1.29.1/

[repstein]

Title: [281482] tags/Safari-612.1.29.1/








Revision 281482
Author repst...@apple.com
Date 2021-08-23 18:02:09 -0700 (Mon, 23 Aug 2021)


Log Message
Tag Safari-612.1.29.1.

Added Paths

tags/Safari-612.1.29.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281481] tags/Safari-612.2.2/

[repstein]

Title: [281481] tags/Safari-612.2.2/








Revision 281481
Author repst...@apple.com
Date 2021-08-23 18:00:25 -0700 (Mon, 23 Aug 2021)


Log Message
Tag Safari-612.2.2.

Added Paths

tags/Safari-612.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281480] trunk

[wilander]

Title: [281480] trunk








Revision 281480
Author wilan...@apple.com
Date 2021-08-23 17:33:32 -0700 (Mon, 23 Aug 2021)


Log Message
PCM: Support ephemeral measurement with non-persistent WebCore::PrivateClickMeasurement
https://bugs.webkit.org/show_bug.cgi?id=228984


Reviewed by Kate Cheney.

This patch adds support for ephemeral measurement with non-persistent
WebCore::PrivateClickMeasurement for direct response advertising.
Such advertising means there is only one pending click, held in memory,
and only stored right before the triggering event causes attribution
reports to be scheduled.

Source/WebCore:

Test: http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html

* loader/PrivateClickMeasurement.h:
(WebCore::PrivateClickMeasurement::SourceSite::operator!= const):
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::operator!= const):
(WebCore::PrivateClickMeasurement::PrivateClickMeasurement):
Now takes an optional PrivateClickMeasurementAttributionEphemeral
parameter, set to PrivateClickMeasurementAttributionEphemeral::No
by default.
(WebCore::PrivateClickMeasurement::isEphemeral const):
(WebCore::PrivateClickMeasurement::setEphemeral):
(WebCore::PrivateClickMeasurement::encode const):
(WebCore::PrivateClickMeasurement::decode):

Source/WebKit:

* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::attributePrivateClickMeasurement):
Now takes an optional ephemeral PrivateClickMeasurement parameter
and stores it right before moving on with attribution.
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setPrivateClickMeasurementEphemeralMeasurementForTesting):
Test infrastructure.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setPrivateClickMeasurementEphemeralMeasurementForTesting):
Test infrastructure.
* NetworkProcess/NetworkSession.h:
* NetworkProcess/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::storeUnattributed):
(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):
(WebKit::PrivateClickMeasurementManager::insertPrivateClickMeasurement):
New convenience function. Only stores in memory if the
PrivateClickMeasurement parameter is marked as ephemeral.
(WebKit::PrivateClickMeasurementManager::attribute):
Checks that the triggering event matches the ephemeral measurement if
it exists, and if so, forwards it.
(WebKit::PrivateClickMeasurementManager::clear):
Now clears the ephemeral state too.
* NetworkProcess/PrivateClickMeasurementManager.h:
(WebKit::PrivateClickMeasurementManager::setEphemeralMeasurementForTesting):
Test infrastructure.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPrivateClickMeasurementEphemeralMeasurementForTesting):
Test infrastructure.
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setPrivateClickMeasurementEphemeralMeasurementForTesting):
Test infrastructure.
* UIProcess/WebPageProxy.h:

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPrivateClickMeasurementEphemeralMeasurementForTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::setPrivateClickMeasurementEphemeralMeasurementForTesting):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Added.
* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html: Added.
* http/tests/privateClickMeasurement/resources/util.js:
(tearDownAndFinish):
Resets the new testRunner.setPrivateClickMeasurementEphemeralMeasurementForTesting().

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/privateClickMeasurement/resources/util.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/PrivateClickMeasurement.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.h
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h

[webkit-changes] [281479] trunk/Source/WebCore

[zalan]

Title: [281479] trunk/Source/WebCore








Revision 281479
Author za...@apple.com
Date 2021-08-23 17:20:27 -0700 (Mon, 23 Aug 2021)


Log Message
[LFC][IFC] Decouple line box building and vertical aligning
https://bugs.webkit.org/show_bug.cgi?id=229162


Reviewed by Antti Koivisto.

This is in preparation for supporting incremental inline layout.
We should be able to vertically align the inline level boxes on any line without rebuilding the LineBox.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::rootInlineBoxLogicalTop const): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::lineBoxHeight const): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::setEnabled): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::isEnabled const): Deleted.
(): Deleted.
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::SimplifiedVerticalAlignment): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::align): Deleted.
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::adjust): Deleted.
* layout/formattingContexts/inline/InlineLevelBox.h:
* layout/formattingContexts/inline/InlineLineBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h


Added Paths

trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281478 => 281479)

--- trunk/Source/WebCore/ChangeLog	2021-08-23 23:52:10 UTC (rev 281478)
+++ trunk/Source/WebCore/ChangeLog	2021-08-24 00:20:27 UTC (rev 281479)
@@ -1,3 +1,32 @@
+2021-08-23  Alan Bujtas  
+
+[LFC][IFC] Decouple line box building and vertical aligning
+https://bugs.webkit.org/show_bug.cgi?id=229162
+
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for supporting incremental inline layout.
+We should be able to vertically align the inline level boxes on any line without rebuilding the LineBox.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
+(WebCore::Layout::LineBoxBuilder::build):
+(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::rootInlineBoxLogicalTop const): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::lineBoxHeight const): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::setEnabled): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::isEnabled const): Deleted.
+(): Deleted.
+(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::SimplifiedVerticalAlignment): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::align): Deleted.
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::adjust): Deleted.
+* layout/formattingContexts/inline/InlineLevelBox.h:
+* layout/formattingContexts/inline/InlineLineBox.h:
+
 2021-08-23  Alex Christensen  
 
 Setting window.location.href to an invalid URL should throw a TypeError


Modified: trunk/Source/WebCore/Sources.txt (281478 => 281479)

--- trunk/Source/WebCore/Sources.txt	2021-08-23 23:52:10 UTC (rev 281478)
+++ trunk/Source/WebCore/Sources.txt	2021-08-24 00:20:27 UTC (rev 281479)
@@ -1460,6 +1460,7 @@
 layout/formattingContexts/inline/InlineLine.cpp
 layout/formattingContexts/inline/InlineLineBox.cpp
 layout/formattingContexts/inline/InlineLineBuilder.cpp
+layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
 layout/formattingContexts/inline/InlineTextItem.cpp
 layout/formattingContexts/inline/text/TextUtil.cpp
 layout/integration/LayoutIntegrationBoxTree.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (281478 => 281479)

--- 

[webkit-changes] [281478] trunk/LayoutTests

[ayumi_kojima]

Title: [281478] trunk/LayoutTests








Revision 281478
Author ayumi_koj...@apple.com
Date 2021-08-23 16:52:10 -0700 (Mon, 23 Aug 2021)


Log Message
[ Catalina EWS ] http/tests/media/hls/range-request.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=229424

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281477 => 281478)

--- trunk/LayoutTests/ChangeLog	2021-08-23 22:52:37 UTC (rev 281477)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 23:52:10 UTC (rev 281478)
@@ -1,3 +1,12 @@
+2021-08-23  Ayumi Kojima  
+
+[ Catalina EWS ] http/tests/media/hls/range-request.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=229424
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2021-08-23  Wenson Hsieh  
 
 fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing in iOS 15


Modified: trunk/LayoutTests/platform/mac/TestExpectations (281477 => 281478)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 22:52:37 UTC (rev 281477)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 23:52:10 UTC (rev 281478)
@@ -1918,6 +1918,8 @@
 [ BigSur+ ] http/tests/media/hls/range-request.html [ Skip ]
 [ BigSur+ ] http/tests/media/hls/video-cookie.html [ Skip ]
 
+webkit.org/b/229424 [ Catalina ] http/tests/media/hls/range-request.html [ Pass Failure ]
+
 # rdar://0680 (REGRESSION (20A2327a-20A2348b): media/video-canvas-createPattern.html is failing)
 [ BigSur+ ] media/video-canvas-createPattern.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281477] trunk/LayoutTests

[wenson_hsieh]

Title: [281477] trunk/LayoutTests








Revision 281477
Author wenson_hs...@apple.com
Date 2021-08-23 15:52:37 -0700 (Mon, 23 Aug 2021)


Log Message
fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing in iOS 15
https://bugs.webkit.org/show_bug.cgi?id=229417
rdar://80385777

Reviewed by Tim Horton.

This test is failing in iOS 15 because "command + shift + /" now triggers a system-wide key command that shows
a help menu; this key command is handled very early on in UIKit, before keyboard code gets a chance to handle
the event as a WebEvent and dispatch it to the page.

rdar://82257764 tracks making this key command preventable by marking it as a key command that should be handled
after dispatching key events. For the time being, add this to the list of system key commands that we should
avoid in `key-tester.js`, and rebaseline the test.

* fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt:
* fast/events/ios/resources/key-tester.js:
* platform/ios-14/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt
trunk/LayoutTests/fast/events/ios/resources/key-tester.js
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-14/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281476 => 281477)

--- trunk/LayoutTests/ChangeLog	2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 22:52:37 UTC (rev 281477)
@@ -1,3 +1,24 @@
+2021-08-23  Wenson Hsieh  
+
+fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing in iOS 15
+https://bugs.webkit.org/show_bug.cgi?id=229417
+rdar://80385777
+
+Reviewed by Tim Horton.
+
+This test is failing in iOS 15 because "command + shift + /" now triggers a system-wide key command that shows
+a help menu; this key command is handled very early on in UIKit, before keyboard code gets a chance to handle
+the event as a WebEvent and dispatch it to the page.
+
+rdar://82257764 tracks making this key command preventable by marking it as a key command that should be handled
+after dispatching key events. For the time being, add this to the list of system key commands that we should
+avoid in `key-tester.js`, and rebaseline the test.
+
+* fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt:
+* fast/events/ios/resources/key-tester.js:
+* platform/ios-14/TestExpectations:
+* platform/ios/TestExpectations:
+
 2021-08-23  Eric Hutchison  
 
 [BigSur wk2 Debug] http/tests/inspector/network/fetch-network-data.html is a flaky failure.


Modified: trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt (281476 => 281477)

--- trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt	2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt	2021-08-23 22:52:37 UTC (rev 281477)
@@ -320,11 +320,3 @@
 type: keyup, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
 type: keyup, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: false, shiftKey: false, location: 1, keyLocation: 1
 
-Test Command + Shift + /:
-type: keydown, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
-type: keydown, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 1, keyLocation: 1
-type: keydown, key: /, code: Slash, keyIdentifier: U+003F, keyCode: 191, charCode: 0, keyCode: 191, which: 191, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 0, keyLocation: 0
-type: keypress, key: /, code: Slash, keyIdentifier: , keyCode: 47, charCode: 47, keyCode: 47, which: 47, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 0, keyLocation: 0
-type: keyup, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
-type: keyup, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: false, shiftKey: false, location: 1, keyLocation: 1
-


Modified: trunk/LayoutTests/fast/events/ios/resources/key-tester.js (281476 => 281477)

--- 

[webkit-changes] [281476] trunk/LayoutTests

[ehutchison]

Title: [281476] trunk/LayoutTests








Revision 281476
Author ehutchi...@apple.com
Date 2021-08-23 15:40:11 -0700 (Mon, 23 Aug 2021)


Log Message
[BigSur wk2 Debug] http/tests/inspector/network/fetch-network-data.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=229429.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281475 => 281476)

--- trunk/LayoutTests/ChangeLog	2021-08-23 22:02:49 UTC (rev 281475)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 22:40:11 UTC (rev 281476)
@@ -1,5 +1,14 @@
 2021-08-23  Eric Hutchison  
 
+[BigSur wk2 Debug] http/tests/inspector/network/fetch-network-data.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=229429.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 [Mac wk1] fast/canvas/webgl/texImage2D-video-flipY-false.html is a flaky timeout.
 https://bugs.webkit.org/show_bug.cgi?id=229425.
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (281475 => 281476)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 22:02:49 UTC (rev 281475)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 22:40:11 UTC (rev 281476)
@@ -1599,5 +1599,7 @@
 
 webkit.org/b/226789 [ Catalina Release ] imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html [ Pass Failure ]
 
+webkit.org/b/229429 [ BigSur Debug ] http/tests/inspector/network/fetch-network-data.html [ Pass Failure ]
+
 # rdar://82002352 ([ Monterey wk2 Release ] css3/blending/background-blend-mode-background-clip-content-box.html is flaky image failing)
 [ Monterey Release ] css3/blending/background-blend-mode-background-clip-content-box.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281475] trunk/LayoutTests

[ehutchison]

Title: [281475] trunk/LayoutTests








Revision 281475
Author ehutchi...@apple.com
Date 2021-08-23 15:02:49 -0700 (Mon, 23 Aug 2021)


Log Message
[Mac wk1] fast/canvas/webgl/texImage2D-video-flipY-false.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=229425.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281474 => 281475)

--- trunk/LayoutTests/ChangeLog	2021-08-23 22:00:37 UTC (rev 281474)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 22:02:49 UTC (rev 281475)
@@ -1,3 +1,12 @@
+2021-08-23  Eric Hutchison  
+
+[Mac wk1] fast/canvas/webgl/texImage2D-video-flipY-false.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=229425.
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-08-23  Alex Christensen  
 
 Setting window.location.href to an invalid URL should throw a TypeError


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281474 => 281475)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-23 22:00:37 UTC (rev 281474)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-23 22:02:49 UTC (rev 281475)
@@ -1390,4 +1390,6 @@
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
 [ Monterey ] webrtc/h264-high.html [ Failure ]
 
+webkit.org/b/229425 fast/canvas/webgl/texImage2D-video-flipY-false.html [ Pass Timeout ]
+
 webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281474] branches/safari-612-branch

[repstein]

Title: [281474] branches/safari-612-branch








Revision 281474
Author repst...@apple.com
Date 2021-08-23 15:00:37 -0700 (Mon, 23 Aug 2021)


Log Message
Cherry-pick r281473. rdar://problem/82262986

compileEnumeratorHasProperty uses flushRegisters incorrectly
https://bugs.webkit.org/show_bug.cgi?id=229412


Reviewed by Keith Miller.

JSTests:

* stress/for-in-has-own-property-shouldnt-flush-registers.js: Added.
(foo):
* stress/for-in-in-by-val-shouldnt-flush-registers.js: Added.
(a.toString):

Source/_javascript_Core:

We were calling flushRegisters() inside code that isn't always runs inside the
EnumeratorInByVal/EnumeratorHasOwnProperty nodes. That is a violation of how
flushRegisters() must be used, since flushRegisters() updates global register
allocation state, and therefore must run each time a node is run. To fix, we
move flushRegisters() before the code starts emitting branches.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileEnumeratorHasProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/JSTests/ChangeLog
branches/safari-612-branch/Source/_javascript_Core/ChangeLog
branches/safari-612-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

branches/safari-612-branch/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js
branches/safari-612-branch/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js




Diff

Modified: branches/safari-612-branch/JSTests/ChangeLog (281473 => 281474)

--- branches/safari-612-branch/JSTests/ChangeLog	2021-08-23 21:44:19 UTC (rev 281473)
+++ branches/safari-612-branch/JSTests/ChangeLog	2021-08-23 22:00:37 UTC (rev 281474)
@@ -1,3 +1,47 @@
+2021-08-23  Alan Coon  
+
+Cherry-pick r281473. rdar://problem/82262986
+
+compileEnumeratorHasProperty uses flushRegisters incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=229412
+
+
+Reviewed by Keith Miller.
+
+JSTests:
+
+* stress/for-in-has-own-property-shouldnt-flush-registers.js: Added.
+(foo):
+* stress/for-in-in-by-val-shouldnt-flush-registers.js: Added.
+(a.toString):
+
+Source/_javascript_Core:
+
+We were calling flushRegisters() inside code that isn't always runs inside the
+EnumeratorInByVal/EnumeratorHasOwnProperty nodes. That is a violation of how
+flushRegisters() must be used, since flushRegisters() updates global register
+allocation state, and therefore must run each time a node is run. To fix, we
+move flushRegisters() before the code starts emitting branches.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileEnumeratorHasProperty):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-23  Saam Barati  
+
+compileEnumeratorHasProperty uses flushRegisters incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=229412
+
+
+Reviewed by Keith Miller.
+
+* stress/for-in-has-own-property-shouldnt-flush-registers.js: Added.
+(foo):
+* stress/for-in-in-by-val-shouldnt-flush-registers.js: Added.
+(a.toString):
+
 2021-08-17  Mikhail R. Gadelha  
 
 Unreviewed. Skip failing MIPS tests


Added: branches/safari-612-branch/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js (0 => 281474)

--- branches/safari-612-branch/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js	(rev 0)
+++ branches/safari-612-branch/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js	2021-08-23 22:00:37 UTC (rev 281474)
@@ -0,0 +1,11 @@
+function foo(o) {
+for (let p in o) {
+o.hasOwnProperty(p);
+o.__proto__ = undefined;
+}
+}
+
+for (let i = 0; i < 10; ++i) {
+foo({f:42});
+}
+


Added: branches/safari-612-branch/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js (0 => 281474)

--- branches/safari-612-branch/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js	(rev 0)
+++ branches/safari-612-branch/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js	2021-08-23 22:00:37 UTC (rev 281474)
@@ -0,0 +1,13 @@
+const a = [undefined];
+a.toString = ()=>{};
+
+function foo() {
+for (let x in a) {
+  x in a;
+  +x;
+}
+}
+
+for (let i=0; i<1; i++) {
+  foo();
+}


Modified: branches/safari-612-branch/Source/_javascript_Core/ChangeLog (281473 => 281474)

--- branches/safari-612-branch/Source/_javascript_Core/ChangeLog	2021-08-23 21:44:19 UTC (rev 281473)
+++ branches/safari-612-branch/Source/_javascript_Core/ChangeLog	2021-08-23 22:00:37 UTC (rev 281474)
@@ -1,3 +1,51 @@
+2021-08-23  Alan Coon  
+
+Cherry-pick r281473. rdar://problem/82262986
+
+

[webkit-changes] [281473] trunk

[sbarati]

Title: [281473] trunk








Revision 281473
Author sbar...@apple.com
Date 2021-08-23 14:44:19 -0700 (Mon, 23 Aug 2021)


Log Message
compileEnumeratorHasProperty uses flushRegisters incorrectly
https://bugs.webkit.org/show_bug.cgi?id=229412


Reviewed by Keith Miller.

JSTests:

* stress/for-in-has-own-property-shouldnt-flush-registers.js: Added.
(foo):
* stress/for-in-in-by-val-shouldnt-flush-registers.js: Added.
(a.toString):

Source/_javascript_Core:

We were calling flushRegisters() inside code that isn't always runs inside the
EnumeratorInByVal/EnumeratorHasOwnProperty nodes. That is a violation of how
flushRegisters() must be used, since flushRegisters() updates global register
allocation state, and therefore must run each time a node is run. To fix, we
move flushRegisters() before the code starts emitting branches.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileEnumeratorHasProperty):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

trunk/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js
trunk/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js




Diff

Modified: trunk/JSTests/ChangeLog (281472 => 281473)

--- trunk/JSTests/ChangeLog	2021-08-23 21:39:37 UTC (rev 281472)
+++ trunk/JSTests/ChangeLog	2021-08-23 21:44:19 UTC (rev 281473)
@@ -1,3 +1,16 @@
+2021-08-23  Saam Barati  
+
+compileEnumeratorHasProperty uses flushRegisters incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=229412
+
+
+Reviewed by Keith Miller.
+
+* stress/for-in-has-own-property-shouldnt-flush-registers.js: Added.
+(foo):
+* stress/for-in-in-by-val-shouldnt-flush-registers.js: Added.
+(a.toString):
+
 2021-08-22  Yusuke Suzuki  
 
 [JSC] Remove already-shipped wasm option flags


Added: trunk/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js (0 => 281473)

--- trunk/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js	(rev 0)
+++ trunk/JSTests/stress/for-in-has-own-property-shouldnt-flush-registers.js	2021-08-23 21:44:19 UTC (rev 281473)
@@ -0,0 +1,11 @@
+function foo(o) {
+for (let p in o) {
+o.hasOwnProperty(p);
+o.__proto__ = undefined;
+}
+}
+
+for (let i = 0; i < 10; ++i) {
+foo({f:42});
+}
+


Added: trunk/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js (0 => 281473)

--- trunk/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js	(rev 0)
+++ trunk/JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js	2021-08-23 21:44:19 UTC (rev 281473)
@@ -0,0 +1,13 @@
+const a = [undefined];
+a.toString = ()=>{};
+
+function foo() {
+for (let x in a) {
+  x in a;
+  +x;
+}
+}
+
+for (let i=0; i<1; i++) {
+  foo();
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (281472 => 281473)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-23 21:39:37 UTC (rev 281472)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-23 21:44:19 UTC (rev 281473)
@@ -1,3 +1,20 @@
+2021-08-23  Saam Barati  
+
+compileEnumeratorHasProperty uses flushRegisters incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=229412
+
+
+Reviewed by Keith Miller.
+
+We were calling flushRegisters() inside code that isn't always runs inside the
+EnumeratorInByVal/EnumeratorHasOwnProperty nodes. That is a violation of how
+flushRegisters() must be used, since flushRegisters() updates global register
+allocation state, and therefore must run each time a node is run. To fix, we
+move flushRegisters() before the code starts emitting branches.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileEnumeratorHasProperty):
+
 2021-08-23  Yusuke Suzuki  
 
 [JSC] emitArrayProfilingSiteWithCell should not load indexingType unnecessarily


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (281472 => 281473)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2021-08-23 21:39:37 UTC (rev 281472)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2021-08-23 21:44:19 UTC (rev 281473)
@@ -13692,6 +13692,8 @@
 GPRReg modeGPR = mode.gpr();
 GPRReg enumeratorGPR = enumerator.gpr();
 
+flushRegisters();
+
 JSValueRegsTemporary result(this);
 JSValueRegs resultRegs = result.regs();
 
@@ -13711,7 +13713,6 @@
 
 operationCases.link(_jit);
 
-flushRegisters();
 #if USE(JSVALUE32_64)
 m_jit.move(TrustedImm32(JSValue::CellTag), resultRegs.tagGPR());
 auto baseRegs = JSValueRegs(baseCellGPR, resultRegs.tagGPR());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281472] trunk

[commit-queue]

Title: [281472] trunk








Revision 281472
Author commit-qu...@webkit.org
Date 2021-08-23 14:39:37 -0700 (Mon, 23 Aug 2021)


Log Message
Setting window.location.href to an invalid URL should throw a TypeError
https://bugs.webkit.org/show_bug.cgi?id=229303

Patch by Alex Christensen  on 2021-08-23
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/url/failure-expected.txt:

Source/WebCore:

This matches Firefox and the specification, and Chrome also throws an exception in this case.

* page/Location.cpp:
(WebCore::Location::setLocation):

LayoutTests:

* fast/dom/location-new-window-no-crash-expected.txt:
* fast/dom/location-new-window-no-crash.html:
* fast/loader/file-URL-with-port-number.html:
* fast/loader/location-port.html:
* fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt:
* fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed.html:
* fast/url/navigate-non-ascii.html:
* platform/ios-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt: Removed.
* platform/mac-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/location-new-window-no-crash-expected.txt
trunk/LayoutTests/fast/dom/location-new-window-no-crash.html
trunk/LayoutTests/fast/loader/file-URL-with-port-number.html
trunk/LayoutTests/fast/loader/location-port.html
trunk/LayoutTests/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt
trunk/LayoutTests/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed.html
trunk/LayoutTests/fast/url/navigate-non-ascii.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Location.cpp


Removed Paths

trunk/LayoutTests/platform/ios-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt
trunk/LayoutTests/platform/mac-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (281471 => 281472)

--- trunk/LayoutTests/ChangeLog	2021-08-23 21:38:41 UTC (rev 281471)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 21:39:37 UTC (rev 281472)
@@ -1,3 +1,20 @@
+2021-08-23  Alex Christensen  
+
+Setting window.location.href to an invalid URL should throw a TypeError
+https://bugs.webkit.org/show_bug.cgi?id=229303
+
+Reviewed by Chris Dumez.
+
+* fast/dom/location-new-window-no-crash-expected.txt:
+* fast/dom/location-new-window-no-crash.html:
+* fast/loader/file-URL-with-port-number.html:
+* fast/loader/location-port.html:
+* fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt:
+* fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed.html:
+* fast/url/navigate-non-ascii.html:
+* platform/ios-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt: Removed.
+* platform/mac-wk1/fast/loader/redirect-to-invalid-url-using-_javascript_-disallowed-expected.txt: Removed.
+
 2021-08-23  Ayumi Kojima  
 
 [ BigSur EWS ] http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html is flaky crash.


Modified: trunk/LayoutTests/fast/dom/location-new-window-no-crash-expected.txt (281471 => 281472)

--- trunk/LayoutTests/fast/dom/location-new-window-no-crash-expected.txt	2021-08-23 21:38:41 UTC (rev 281471)
+++ trunk/LayoutTests/fast/dom/location-new-window-no-crash-expected.txt	2021-08-23 21:39:37 UTC (rev 281472)
@@ -14,11 +14,11 @@
 PASS testWindow.location.hash is ''
 PASS testWindow.location.href = '' is 'data:text/plain,b'
 PASS testWindow.location.protocol = 'data' is 'data'
-PASS testWindow.location.host = 'c' is 'c'
-PASS testWindow.location.hostname = 'd' is 'd'
-PASS testWindow.location.port = 'e' is 'e'
-PASS testWindow.location.pathname = 'f' is 'f'
-PASS testWindow.location.search = 'g' is 'g'
+PASS testWindow.location.host = 'c' threw exception TypeError: Invalid URL.
+PASS testWindow.location.hostname = 'd' threw exception TypeError: Invalid URL.
+PASS testWindow.location.port = 'e' threw exception TypeError: Invalid URL.
+PASS testWindow.location.pathname = 'f' threw exception TypeError: Invalid URL.
+PASS testWindow.location.search = 'g' threw exception TypeError: Invalid URL.
 PASS testWindow.location.hash = 'h' is 'h'
 PASS testWindow.location.assign('data:text/plain,i') is undefined
 PASS testWindow.location.replace('data:text/plain,j') is undefined


Modified: trunk/LayoutTests/fast/dom/location-new-window-no-crash.html (281471 => 281472)

--- trunk/LayoutTests/fast/dom/location-new-window-no-crash.html	2021-08-23 21:38:41 UTC (rev 281471)
+++ trunk/LayoutTests/fast/dom/location-new-window-no-crash.html	2021-08-23 21:39:37 UTC (rev 281472)
@@ -30,11 +30,11 @@
 
 

[webkit-changes] [281471] trunk/LayoutTests

[ayumi_kojima]

Title: [281471] trunk/LayoutTests








Revision 281471
Author ayumi_koj...@apple.com
Date 2021-08-23 14:38:41 -0700 (Mon, 23 Aug 2021)


Log Message
[ BigSur EWS ] http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html is flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=229423

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281470 => 281471)

--- trunk/LayoutTests/ChangeLog	2021-08-23 21:36:38 UTC (rev 281470)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 21:38:41 UTC (rev 281471)
@@ -1,5 +1,14 @@
 2021-08-23  Ayumi Kojima  
 
+[ BigSur EWS ] http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html is flaky crash.
+https://bugs.webkit.org/show_bug.cgi?id=229423
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2021-08-23  Ayumi Kojima  
+
 [iOS 14] imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html is a flaky failure.
 https://bugs.webkit.org/show_bug.cgi?id=226789
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (281470 => 281471)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 21:36:38 UTC (rev 281470)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 21:38:41 UTC (rev 281471)
@@ -53,6 +53,8 @@
 fast/visual-viewport/rubberbanding-viewport-rects.html [ Pass ]
 fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html  [ Pass ]
 
+webkit.org/b/229423 [ BigSur Debug arm64 ] http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html [ Pass Crash ]
+
 http/tests/paymentrequest [ Pass ]
 http/tests/paymentrequest/ApplePayModifier-additionalLineItems.https.html [ Skip ]
 http/tests/paymentrequest/ApplePayModifier-additionalShippingMethods.https.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281470] trunk

[heycam]

Title: [281470] trunk








Revision 281470
Author hey...@apple.com
Date 2021-08-23 14:36:38 -0700 (Mon, 23 Aug 2021)


Log Message
LayoutTests/imported/w3c:
Preserve color space when getting current color in DisplayListDrawGlyphsRecorder.
https://bugs.webkit.org/show_bug.cgi?id=229024


Reviewed by Sam Weinig.

Add tests for calling fillText() and strokeText() with a display-p3
color for fillStyle, strokeStyle, and shadowColor, on a display-p3 canvas.

* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText-expected.txt: Added.
* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.html: Added.
* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow-expected.txt: Added.
* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow.html: Added.
* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText-expected.txt: Added.
* web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText.html: Added.
* web-platform-tests/html/canvas/tools/yaml/element/color_space.yaml:

Source/WebCore:
Preserve color space when getting current color in DisplayList::DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=229024


Reviewed by Sam Weinig.

When GPU canvas is enabled, DrawGlyphsRecorder records the text fill,
stroke, and shadow colors by getting them from the context using
CGGStateGetFillColor etc.  This is done so that color glyphs have each
part painted in the right color.  But the current conversion from
CGColor to WebCore::Color lossily converts to sRGB.  So we need to get
the color space and color components from the CGColor and preserve them.

The existing Color(CGColorRef) constructor is replaced by two
constructor functions, createAndPreserveColorSpace and
roundAndClampToSRGBALossy, so the conversion behavior is clear at call
sites.  createAndPreserveColorSpace will match the CGColor's color
space to one of the predefined spaces that WebCore::Color can
represent.  If it's some other color space, we convert to XYZ (on
platforms where that's available), since that will result in the least
loss, or to sRGB (on platforms where XYZ is not available).

CGColorSpaceEqualToColorSpace, which is used when determining the
CGColor's color space, is not very expensive, but it will do more than a
pointer comparison in case we pass in two CGColorSpaceRefs that are
equivalent but not the same pointer value.  Since our new
colorSpaceForCGColorSpace function will be used with CGColors that have
been set WebCore during canvas drawing, we will get back the same
pointers that we have cached in sRGBColorSpaceRef(),
displayP3ColorSpaceRef(), etc.  If calling CGColorSpaceEqualToColorSpace
on all our supported color spaces turns out to be too expensive, we
could start by doing a pointer comparison on each before calling
CGColorSpaceEqualToColorSpace.

The way colorSpaceForCGColorSpace is written we could end up
instantiating all of our supported color spaces, if an author used an
XYZ color when drawing text (the last color profile we check).  We
could try harder to avoid doing this if it's important.

Tests: imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.html
   imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow.html
   imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText.html

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsWindowCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextColor const):
* platform/graphics/Color.h:
(WebCore::Color::createAndPreserveColorSpace):
(WebCore::Color::createAndLosslesslyConvertToSupportedColorSpace):
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::backgroundColor const):
* platform/graphics/ca/cocoa/WebTiledBackingLayer.mm:
(-[WebTiledBackingLayer setBorderColor:]):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::backgroundColor const):
(printColor):
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::drawRepaintCounters):
* platform/graphics/cg/ColorCG.cpp:
(WebCore::roundAndClampToSRGBALossy):
(WebCore::Color::createAndLosslesslyConvertToSupportedColorSpace):
(WebCore::Color::createAndPreserveColorSpace):
(WebCore::platformConvertColorComponents):
* platform/graphics/cg/ColorSpaceCG.cpp:
(WebCore::colorSpaceForCGColorSpace):
* platform/graphics/cg/ColorSpaceCG.h:
* platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:
(WebCore::DisplayList::DrawGlyphsRecorder::updateShadow):
(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawGlyphs):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

[webkit-changes] [281469] trunk/LayoutTests

[ayumi_kojima]

Title: [281469] trunk/LayoutTests








Revision 281469
Author ayumi_koj...@apple.com
Date 2021-08-23 14:05:44 -0700 (Mon, 23 Aug 2021)


Log Message
[iOS 14] imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=226789

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281468 => 281469)

--- trunk/LayoutTests/ChangeLog	2021-08-23 20:52:43 UTC (rev 281468)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 21:05:44 UTC (rev 281469)
@@ -1,3 +1,12 @@
+2021-08-23  Ayumi Kojima  
+
+[iOS 14] imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=226789
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-08-23  Wenson Hsieh  
 
 editing/selection/ios/select-text-in-existing-selection.html fails on iOS 15


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (281468 => 281469)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 20:52:43 UTC (rev 281468)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-23 21:05:44 UTC (rev 281469)
@@ -1595,5 +1595,7 @@
 #rdar://82044002 ([Monterey] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https.html is a constant failure)
 [ Monterey ]  imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https.html [ Pass Failure ]
 
+webkit.org/b/226789 [ Catalina Release ] imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html [ Pass Failure ]
+
 # rdar://82002352 ([ Monterey wk2 Release ] css3/blending/background-blend-mode-background-clip-content-box.html is flaky image failing)
 [ Monterey Release ] css3/blending/background-blend-mode-background-clip-content-box.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281468] trunk

[wenson_hsieh]

Title: [281468] trunk








Revision 281468
Author wenson_hs...@apple.com
Date 2021-08-23 13:52:43 -0700 (Mon, 23 Aug 2021)


Log Message
editing/selection/ios/select-text-in-existing-selection.html fails on iOS 15
https://bugs.webkit.org/show_bug.cgi?id=229411
rdar://80385434

Reviewed by Tim Horton.

Tools:

After the changes in rdar://70851909, UIKit's text selection interaction (which encompasses the loupe text
interaction gesture) is no longer allowed to transition to `Began` state when long pressing inside an existing
text selection. This causes us to no longer enter floating caret mode (via loupe gesture) and change the
selection when triggering a long press in selected text, which causes this layout test to fail.

This layout test was originally intended to test a fix for text selection via trackpad on iPadOS failing to
begin when clicking and dragging inside text that has already been selected. At that time, I intentionally wrote
this test in a way that didn't involve the trackpad at all, and instead simply exercised the codechange in
`-[WKContentView textInteractionGesture:shouldBeginAtPoint:]` by synthesizing touches.

Since UIKit no longer supports this behavior, we can rewrite this test to be more robust by calling and checking
the value of `-textInteractionGesture:shouldBeginAtPoint:` in an API test. This patch deletes the existing
layout test, and replaces it with an API test that directly exercises the SPI on `UIWKInteractionViewProtocol`.

Note that the original bug that was fixed by the change that came along with this failing test remains fixed,
because trackpad-based text selection on iPadOS uses `UITextLoupeCursorBehavior` rather than
`UITextLoupeTouchBehavior`, which (unlike the former) contains logic to explicitly avoid starting the loupe
text interaction when long pressing inside of selected text.

Test: UIWKInteractionViewProtocol.TextInteractionCanBeginInExistingSelection

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(-[TestWKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted.
* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(-[TestWKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted.

Drive-by fix: also fix a build warning by pulling duplicate implementations of this testing helper method into
a common location in `WKWebView (TestWebKitAPI)`, inside of `TestWKWebView.h`.

* TestWebKitAPI/Tests/WebKitCocoa/editable-responsive-body.html: Added.
* TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
* TestWebKitAPI/ios/UIKitSPI.h:

LayoutTests:

Remove this failing layout test, along with its test expectations. See API test in Tools/ChangeLog for more
details.

* editing/selection/ios/select-text-in-existing-selection-expected.txt: Removed.
* editing/selection/ios/select-text-in-existing-selection.html: Removed.
* platform/ios-14/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-14/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm
trunk/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/editable-responsive-body.html


Removed Paths

trunk/LayoutTests/editing/selection/ios/select-text-in-existing-selection-expected.txt
trunk/LayoutTests/editing/selection/ios/select-text-in-existing-selection.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281467 => 281468)

--- trunk/LayoutTests/ChangeLog	2021-08-23 20:38:03 UTC (rev 281467)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 20:52:43 UTC (rev 281468)
@@ -1,3 +1,19 @@
+2021-08-23  Wenson Hsieh  
+
+editing/selection/ios/select-text-in-existing-selection.html fails on iOS 15
+https://bugs.webkit.org/show_bug.cgi?id=229411
+rdar://80385434
+
+Reviewed by Tim Horton.
+
+Remove this failing layout test, along with its test expectations. See API test in Tools/ChangeLog for more
+details.
+
+* editing/selection/ios/select-text-in-existing-selection-expected.txt: Removed.
+* editing/selection/ios/select-text-in-existing-selection.html: Removed.
+* platform/ios-14/TestExpectations:
+* platform/ios/TestExpectations:
+
 2021-08-23  Eric Hutchison  
 
 Set test expectations for fast/events/ios/rotation/basic-rotation.html.


Deleted: 

[webkit-changes] [281467] trunk/LayoutTests

[ehutchison]

Title: [281467] trunk/LayoutTests








Revision 281467
Author ehutchi...@apple.com
Date 2021-08-23 13:38:03 -0700 (Mon, 23 Aug 2021)


Log Message
Set test expectations for fast/events/ios/rotation/basic-rotation.html.
.

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281466 => 281467)

--- trunk/LayoutTests/ChangeLog	2021-08-23 20:38:00 UTC (rev 281466)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 20:38:03 UTC (rev 281467)
@@ -1,5 +1,14 @@
 2021-08-23  Eric Hutchison  
 
+Set test expectations for fast/events/ios/rotation/basic-rotation.html.
+.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
 .
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281466 => 281467)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 20:38:00 UTC (rev 281466)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 20:38:03 UTC (rev 281467)
@@ -2031,5 +2031,7 @@
 
 #rdar://80385777 fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing) [ iOS15 ] fast/events/ios/key-events-comprehensive/key-events-meta-shift.html [ Failure ]
 
+#rdar://82259067 ([iOS Debug]fast/events/ios/rotation/basic-rotation.html is a constant crash) fast/events/ios/rotation/basic-rotation.html [ Pass Crash Failure ]
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281466] trunk/LayoutTests/ChangeLog

[ehutchison]

Title: [281466] trunk/LayoutTests/ChangeLog








Revision 281466
Author ehutchi...@apple.com
Date 2021-08-23 13:38:00 -0700 (Mon, 23 Aug 2021)


Log Message
Add a new option '--show-window' to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=229253

Reviewed by Simon Fraser.

Add the new option so that we can let WKTR show a window with webview.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/port/driver.py:
(Driver.cmd_line):
* WebKitTestRunner/Options.cpp:
(WTR::handleOptionShowWindow):
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionShowWebView): Deleted.
* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::shouldShowWindow const):
(WTR::TestOptions::shouldShowWebView const): Deleted.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::finishCreatingPlatformWebView):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::setWindowFrame):

Modified Paths

trunk/LayoutTests/ChangeLog




Diff

Modified: trunk/LayoutTests/ChangeLog (281465 => 281466)

--- trunk/LayoutTests/ChangeLog	2021-08-23 20:29:28 UTC (rev 281465)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 20:38:00 UTC (rev 281466)
@@ -1,3 +1,12 @@
+2021-08-23  Eric Hutchison  
+
+Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
+.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-08-23  Alan Bujtas  
 
 Simplified text measuring only works with the primary font






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281465] trunk

[zalan]

Title: [281465] trunk








Revision 281465
Author za...@apple.com
Date 2021-08-23 13:29:28 -0700 (Mon, 23 Aug 2021)


Log Message
Simplified text measuring only works with the primary font
https://bugs.webkit.org/show_bug.cgi?id=228617


Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-fonts/font-display/font-display-failure-fallback-expected.txt:

Source/WebCore:

This is in preparation for adding fallback font support (IFC).

The reason why this works on trunk is because computeCanUseSimplifiedTextMeasuring() is only used by
the modern line layout codepath which does not support fallback font support yet.

* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuring):
* rendering/RenderText.cpp:
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):

LayoutTests:

While running DumpRenderTree:
  - DOMContentLoaded event is dispatched (parsing is done, DOM is built)
  - window load event is dispatched (JS, CSS are finished loading)
  - dispatchDidFinishLoad is called (this is when all the loads are complete, including web fonts)

dispatchDidFinishLoad is when DumpRenderTree declares the test complete and takes the snapshot.

Without the early font access (i.e. requesting the font during paint), the window load event and
dispatchDidFinishLoad happen the same time.
As dispatchDidFinishLoad triggers the snapshot, we initiate the font load,
but at this point the test is already declared complete so we are not going to wait for these pending loads.
We simply paint the content with whatever is available.

Now the early font access (at render tree building) triggers the font load which in turn delays the dispatchDidFinishLoad callback.
It also means the snapshot is taken at a later time when the font load is complete.

Let's adjust these test cases to make sure the test framework is not going to wait for the font loads.

* TestExpectations: Fails both with FF and Chrome (tested locally).
* fast/text/font-promises-gc-expected.txt:
* http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html:
* http/tests/webfont/font-loading-system-fallback-visibility.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/text/font-promises-gc-expected.txt
trunk/LayoutTests/http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html
trunk/LayoutTests/http/tests/webfont/font-loading-system-fallback-visibility.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-display/font-display-failure-fallback-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
trunk/Source/WebCore/rendering/RenderText.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (281464 => 281465)

--- trunk/LayoutTests/ChangeLog	2021-08-23 20:00:06 UTC (rev 281464)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 20:29:28 UTC (rev 281465)
@@ -1,3 +1,34 @@
+2021-08-23  Alan Bujtas  
+
+Simplified text measuring only works with the primary font
+https://bugs.webkit.org/show_bug.cgi?id=228617
+
+
+Reviewed by Myles C. Maxfield.
+
+While running DumpRenderTree:
+  - DOMContentLoaded event is dispatched (parsing is done, DOM is built)
+  - window load event is dispatched (JS, CSS are finished loading)
+  - dispatchDidFinishLoad is called (this is when all the loads are complete, including web fonts)
+
+dispatchDidFinishLoad is when DumpRenderTree declares the test complete and takes the snapshot.
+
+Without the early font access (i.e. requesting the font during paint), the window load event and
+dispatchDidFinishLoad happen the same time.
+As dispatchDidFinishLoad triggers the snapshot, we initiate the font load,
+but at this point the test is already declared complete so we are not going to wait for these pending loads.
+We simply paint the content with whatever is available.
+
+Now the early font access (at render tree building) triggers the font load which in turn delays the dispatchDidFinishLoad callback.
+It also means the snapshot is taken at a later time when the font load is complete.
+
+Let's adjust these test cases to make sure the test framework is not going to wait for the font loads.
+
+* TestExpectations: Fails both with FF and Chrome (tested locally).
+* fast/text/font-promises-gc-expected.txt:
+* http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html:
+* http/tests/webfont/font-loading-system-fallback-visibility.html:
+
 2021-08-23  Arcady Goldmints-Orlov  
 
 [GLIB] imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-* fail


Modified: trunk/LayoutTests/TestExpectations (281464 => 281465)

--- trunk/LayoutTests/TestExpectations	2021-08-23 20:00:06 UTC (rev 281464)
+++ 

[webkit-changes] [281464] trunk/LayoutTests

[commit-queue]

Title: [281464] trunk/LayoutTests








Revision 281464
Author commit-qu...@webkit.org
Date 2021-08-23 13:00:06 -0700 (Mon, 23 Aug 2021)


Log Message
[GLIB] imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-* fail
https://bugs.webkit.org/show_bug.cgi?id=229389

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-08-23

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281463 => 281464)

--- trunk/LayoutTests/ChangeLog	2021-08-23 19:38:18 UTC (rev 281463)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 20:00:06 UTC (rev 281464)
@@ -1,3 +1,12 @@
+2021-08-23  Arcady Goldmints-Orlov  
+
+[GLIB] imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-* fail
+https://bugs.webkit.org/show_bug.cgi?id=229389
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
 2021-08-23  Alan Bujtas  
 
 Pre-formatted content gets distorted when attempting to select content


Modified: trunk/LayoutTests/platform/glib/TestExpectations (281463 => 281464)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-08-23 19:38:18 UTC (rev 281463)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-08-23 20:00:06 UTC (rev 281464)
@@ -477,6 +477,68 @@
 webkit.org/b/228920 imported/w3c/web-platform-tests/css/css-overflow/clip-006.html [ ImageOnlyFailure ]
 webkit.org/b/228920 imported/w3c/web-platform-tests/css/css-overflow/clip-007.html [ ImageOnlyFailure ]
 
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-001.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-002.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-003.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-004.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-005.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-006.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-007.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-008.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00B.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00C.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00E.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00F.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-010.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-011.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-012.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-013.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-014.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-015.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-016.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-017.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-018.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-019.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01A.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01B.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01C.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01D.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01E.html [ ImageOnlyFailure ]
+webkit.org/b/229389 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01F.html [ 

[webkit-changes] [281463] trunk

[zalan]

Title: [281463] trunk








Revision 281463
Author za...@apple.com
Date 2021-08-23 12:38:18 -0700 (Mon, 23 Aug 2021)


Log Message
Pre-formatted content gets distorted when attempting to select content
https://bugs.webkit.org/show_bug.cgi?id=228655


Reviewed by Simon Fraser.

Source/WebCore:

https://drafts.csswg.org/css-text/#overflow-wrap-property

"This property specifies whether the UA may break at otherwise disallowed points within
a line to prevent overflow, when an otherwise-unbreakable string is too long to fit within the line box.
It only has an effect when white-space allows wrapping."

(also see https://trac.webkit.org/changeset/10095/webkit where the wrapping behavior was introduced)

Test: fast/text/no-wrap-in-pre-with-word-wrap.html

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):

LayoutTests:

* fast/text/no-wrap-in-pre-with-word-wrap-expected.html: Added.
* fast/text/no-wrap-in-pre-with-word-wrap.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
trunk/LayoutTests/platform/mac/fast/text/whitespace/tab-character-basics-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/line/BreakingContext.h


Added Paths

trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap-expected.html
trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281462 => 281463)

--- trunk/LayoutTests/ChangeLog	2021-08-23 19:17:30 UTC (rev 281462)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 19:38:18 UTC (rev 281463)
@@ -1,3 +1,14 @@
+2021-08-23  Alan Bujtas  
+
+Pre-formatted content gets distorted when attempting to select content
+https://bugs.webkit.org/show_bug.cgi?id=228655
+
+
+Reviewed by Simon Fraser.
+
+* fast/text/no-wrap-in-pre-with-word-wrap-expected.html: Added.
+* fast/text/no-wrap-in-pre-with-word-wrap.html: Added.
+
 2021-08-23  Eric Hutchison  
 
 [Monterey] fast/animation/request-animation-frame-throttling-detached-iframe.html is failing.


Added: trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap-expected.html (0 => 281463)

--- trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap-expected.html	2021-08-23 19:38:18 UTC (rev 281463)
@@ -0,0 +1,8 @@
+ 
+
+pre {
+  width: 100px;
+  font-family: Ahem;
+}
+
+Wrapping is not allowed. We should not break the content even when word-wrap: break-word is on.	


Added: trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap.html (0 => 281463)

--- trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap.html	(rev 0)
+++ trunk/LayoutTests/fast/text/no-wrap-in-pre-with-word-wrap.html	2021-08-23 19:38:18 UTC (rev 281463)
@@ -0,0 +1,9 @@
+ 
+
+pre {
+  word-wrap: break-word;
+  width: 100px;
+  font-family: Ahem;
+}
+
+Wrapping is not allowed. We should not break the content even when word-wrap: break-word is on.	


Modified: trunk/LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt (281462 => 281463)

--- trunk/LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt	2021-08-23 19:17:30 UTC (rev 281462)
+++ trunk/LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt	2021-08-23 19:38:18 UTC (rev 281463)
@@ -588,14 +588,11 @@
 text run at (0,28) width 56: "TUVWXYZ"
 text run at (55,28) width 4: " "
 text run at (0,42) width 127: "abcdefghijklmnopqrstuv"
-layer at (3,644) size 168x34 clip at (4,645) size 151x32 scrollHeight 60
+layer at (3,644) size 168x34 clip at (4,645) size 151x17 scrollWidth 434 scrollHeight 18
   RenderTextControl {TEXTAREA} at (3,33) size 168x34 [bgcolor=#FF] [border: (1px solid #3C3C4399)]
-RenderBlock {DIV} at (6,3) size 141x56
-  RenderText {#text} at (0,0) size 137x56
-text run at (0,0) width 135: "Lorem ipsum  dolor ABCD"
-text run at (0,14) width 132: "EFGHIJKLMNOPQRSTUV"
-text run at (0,28) width 137: "WXYZ abcdefghijklmnopq"
-text run at (0,42) width 27: "rstuv"
+RenderBlock {DIV} at (6,3) size 156x14
+  RenderText {#text} at (0,0) size 429x14
+text run at (0,0) width 429: "Lorem ipsum  dolor ABCDEFGHIJKLMNOPQRSTUVWXYZ abcdefghijklmnopqrstuv"
 layer at (177,644) size 168x34 clip at (178,645) size 151x32 scrollHeight 60
   RenderTextControl {TEXTAREA} at (3,33) size 168x34 [bgcolor=#FF] [border: (1px solid #3C3C4399)]
 RenderBlock {DIV} at (6,3) size 141x56
@@ -1325,14 +1322,11 @@
 text run at (0,28) width 56: "TUVWXYZ"
 text run at (55,28) width 4: " "
 text run at (0,42) 

[webkit-changes] [281462] trunk/LayoutTests

[ehutchison]

Title: [281462] trunk/LayoutTests








Revision 281462
Author ehutchi...@apple.com
Date 2021-08-23 12:17:30 -0700 (Mon, 23 Aug 2021)


Log Message
[Monterey] fast/animation/request-animation-frame-throttling-detached-iframe.html is failing.
.

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281461 => 281462)

--- trunk/LayoutTests/ChangeLog	2021-08-23 19:04:25 UTC (rev 281461)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 19:17:30 UTC (rev 281462)
@@ -1,5 +1,14 @@
 2021-08-23  Eric Hutchison  
 
+[Monterey] fast/animation/request-animation-frame-throttling-detached-iframe.html is failing.
+.
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
 .
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (281461 => 281462)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 19:04:25 UTC (rev 281461)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 19:17:30 UTC (rev 281462)
@@ -2333,4 +2333,6 @@
 
 webkit.org/b/168961 [ Catalina ] fast/events/wheelevent-in-frame.html [ Pass Timeout ]
 
+#rdar://80333935 (REGRESSION (Star21A236a-21A254): [ Monterey wk2 arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html and request-animation-frame-throttling-lowPowerMode.html failing) [ Monterey ] fast/animation/request-animation-frame-throttling-detached-iframe.html [ Pass Failure ]
+
 webkit.org/b/228176 [ Mojave Catalina BigSur Monterey ] fast/text/variable-system-font-2.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281461] trunk/Tools

[peng . liu6]

Title: [281461] trunk/Tools








Revision 281461
Author peng.l...@apple.com
Date 2021-08-23 12:04:25 -0700 (Mon, 23 Aug 2021)


Log Message
Add a new option '--show-window' to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=229253

Reviewed by Simon Fraser.

Add the new option so that we can let WKTR show a window with webview.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/port/driver.py:
(Driver.cmd_line):
* WebKitTestRunner/Options.cpp:
(WTR::handleOptionShowWindow):
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionShowWebView): Deleted.
* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::shouldShowWindow const):
(WTR::TestOptions::shouldShowWebView const): Deleted.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::finishCreatingPlatformWebView):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::setWindowFrame):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/driver.py
trunk/Tools/WebKitTestRunner/Options.cpp
trunk/Tools/WebKitTestRunner/TestOptions.cpp
trunk/Tools/WebKitTestRunner/TestOptions.h
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp




Diff

Modified: trunk/Tools/ChangeLog (281460 => 281461)

--- trunk/Tools/ChangeLog	2021-08-23 18:59:07 UTC (rev 281460)
+++ trunk/Tools/ChangeLog	2021-08-23 19:04:25 UTC (rev 281461)
@@ -1,3 +1,33 @@
+2021-08-23  Peng Liu  
+
+Add a new option '--show-window' to run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=229253
+
+Reviewed by Simon Fraser.
+
+Add the new option so that we can let WKTR show a window with webview.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(parse_args):
+* Scripts/webkitpy/port/driver.py:
+(Driver.cmd_line):
+* WebKitTestRunner/Options.cpp:
+(WTR::handleOptionShowWindow):
+(WTR::OptionsHandler::OptionsHandler):
+(WTR::handleOptionShowWebView): Deleted.
+* WebKitTestRunner/TestOptions.cpp:
+(WTR::TestOptions::defaults):
+(WTR::TestOptions::keyTypeMapping):
+* WebKitTestRunner/TestOptions.h:
+(WTR::TestOptions::shouldShowWindow const):
+(WTR::TestOptions::shouldShowWebView const): Deleted.
+* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+(WTR::TestController::finishCreatingPlatformWebView):
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::PlatformWebView):
+* WebKitTestRunner/win/PlatformWebViewWin.cpp:
+(WTR::PlatformWebView::setWindowFrame):
+
 2021-08-23  Jonathan Bedard  
 
 [Cygwin] Support Python 3 in run-webkit-tests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (281460 => 281461)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2021-08-23 18:59:07 UTC (rev 281460)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2021-08-23 19:04:25 UTC (rev 281461)
@@ -343,6 +343,7 @@
 optparse.make_option(
 "--prefer-integrated-gpu", action="" default=False,
 help=("Prefer using the lower-power integrated GPU on a dual-GPU system. Note that other running applications and the tests themselves can override this request.")),
+optparse.make_option('--show-window', action="" default=False, help="Make the test runner window visible during testing."),
 ]))
 
 option_group_definitions.append(("Web Platform Test Server Options", [


Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (281460 => 281461)

--- trunk/Tools/Scripts/webkitpy/port/driver.py	2021-08-23 18:59:07 UTC (rev 281460)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py	2021-08-23 19:04:25 UTC (rev 281461)
@@ -537,6 +537,8 @@
 cmd.append('--no-timeout')
 if self._port.get_option('show_touches'):
 cmd.append('--show-touches')
+if self._port.get_option('show_window'):
+cmd.append('--show-window')
 if self._port.get_option('accessibility_isolated_tree'):
 cmd.append('--accessibility-isolated-tree')
 


Modified: trunk/Tools/WebKitTestRunner/Options.cpp (281460 => 281461)

--- trunk/Tools/WebKitTestRunner/Options.cpp	2021-08-23 18:59:07 UTC (rev 281460)
+++ trunk/Tools/WebKitTestRunner/Options.cpp	2021-08-23 19:04:25 UTC (rev 281461)
@@ -76,9 +76,9 @@
 return true;
 }
 
-static bool handleOptionShowWebView(Options& options, const char*, const char*)
+static bool handleOptionShowWindow(Options& options, const char*, const char*)
 {
-

[webkit-changes] [281460] trunk/LayoutTests

[ehutchison]

Title: [281460] trunk/LayoutTests








Revision 281460
Author ehutchi...@apple.com
Date 2021-08-23 11:59:07 -0700 (Mon, 23 Aug 2021)


Log Message
Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
.

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281459 => 281460)

--- trunk/LayoutTests/ChangeLog	2021-08-23 18:38:34 UTC (rev 281459)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 18:59:07 UTC (rev 281460)
@@ -1,5 +1,14 @@
 2021-08-23  Eric Hutchison  
 
+Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
+.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Updated test expectations for fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html and fast/events/touch/ios/long-press-then-drag-to-select-text.html.
 , .
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281459 => 281460)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 18:38:34 UTC (rev 281459)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 18:59:07 UTC (rev 281460)
@@ -2025,9 +2025,11 @@
 
 webkit.org/b/168961 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
 
-#rdar://80386061 (REGRESSION (Sky19A163?): fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]) [ iOS15 ]  fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]
+#rdar://80386061 (REGRESSION (iOS15 19A163?): fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]) [ iOS15 ]  fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]
 
-#rdar://80386523 (REGRESSION (Sky19A224?): fast/events/touch/ios/long-press-then-drag-to-select-text.html is failing) [ iOS15 ] fast/events/touch/ios/long-press-then-drag-to-select-text.html [ Failure ] 
+#rdar://80386523 (REGRESSION (iOS15 19A224?): fast/events/touch/ios/long-press-then-drag-to-select-text.html is failing) [ iOS15 ] fast/events/touch/ios/long-press-then-drag-to-select-text.html [ Failure ]
 
+#rdar://80385777 fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing) [ iOS15 ] fast/events/ios/key-events-comprehensive/key-events-meta-shift.html [ Failure ]
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281459] trunk/Source

[repstein]

Title: [281459] trunk/Source








Revision 281459
Author repst...@apple.com
Date 2021-08-23 11:38:34 -0700 (Mon, 23 Aug 2021)


Log Message
Versioning.

WebKit-7613.1.1

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -1,6 +1,6 @@
-MAJOR_VERSION = 612;
+MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (281458 => 281459)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2021-08-23 18:27:24 UTC (rev 281458)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2021-08-23 18:38:34 UTC (rev 281459)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION 

[webkit-changes] [281458] trunk/LayoutTests

[ehutchison]

Title: [281458] trunk/LayoutTests








Revision 281458
Author ehutchi...@apple.com
Date 2021-08-23 11:27:24 -0700 (Mon, 23 Aug 2021)


Log Message
Updated test expectations for fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html and fast/events/touch/ios/long-press-then-drag-to-select-text.html.
, .

Unreviewed test gardening.

* platform/ios-14/TestExpectations:
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-14/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281457 => 281458)

--- trunk/LayoutTests/ChangeLog	2021-08-23 18:00:49 UTC (rev 281457)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 18:27:24 UTC (rev 281458)
@@ -1,5 +1,15 @@
 2021-08-23  Eric Hutchison  
 
+Updated test expectations for fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html and fast/events/touch/ios/long-press-then-drag-to-select-text.html.
+, .
+
+Unreviewed test gardening.
+
+* platform/ios-14/TestExpectations:
+* platform/ios-wk2/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Update test expectations for fast/events/touch/page-scaled-touch-gesture-click.html.
 https://bugs.webkit.org/show_bug.cgi?id=168961.
 


Modified: trunk/LayoutTests/platform/ios-14/TestExpectations (281457 => 281458)

--- trunk/LayoutTests/platform/ios-14/TestExpectations	2021-08-23 18:00:49 UTC (rev 281457)
+++ trunk/LayoutTests/platform/ios-14/TestExpectations	2021-08-23 18:27:24 UTC (rev 281458)
@@ -48,12 +48,6 @@
 # rdar://80383672 ([ iOS15 ] accessibility/misspelling-range.html is failing)
 accessibility/misspelling-range.html  [ Pass ]
 
-# rdar://80386523 ([ iOS15 ] fast/events/touch/ios/long-press-then-drag-to-select-text.html is failing)
-fast/events/touch/ios/long-press-then-drag-to-select-text.html  [ Pass ]
-
-# rdar://80386061 ([ iOS15 ] fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ])
-fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Pass ]
-
 # rdar://80392559 ([ iOS15 ] fast/text/simple-line-layout-do-not-support-unicode-range.html is a constant failure)
 fast/text/simple-line-layout-do-not-support-unicode-range.html [ Pass ]
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281457 => 281458)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 18:00:49 UTC (rev 281457)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 18:27:24 UTC (rev 281458)
@@ -2025,5 +2025,9 @@
 
 webkit.org/b/168961 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
 
+#rdar://80386061 (REGRESSION (Sky19A163?): fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]) [ iOS15 ]  fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html [ Failure ]
+
+#rdar://80386523 (REGRESSION (Sky19A224?): fast/events/touch/ios/long-press-then-drag-to-select-text.html is failing) [ iOS15 ] fast/events/touch/ios/long-press-then-drag-to-select-text.html [ Failure ] 
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281457] branches/safari-612-branch/Source

[repstein]

Title: [281457] branches/safari-612-branch/Source








Revision 281457
Author repst...@apple.com
Date 2021-08-23 11:00:49 -0700 (Mon, 23 Aug 2021)


Log Message
Cherry-pick r281384. rdar://problem/82218757

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.

Reviewed by Brady Eidson.

* wtf/CrossThreadTask.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WTF/ChangeLog
branches/safari-612-branch/Source/WTF/wtf/CrossThreadTask.h
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/Modules/indexeddb/IDBRequest.cpp




Diff

Modified: branches/safari-612-branch/Source/WTF/ChangeLog (281456 => 281457)

--- branches/safari-612-branch/Source/WTF/ChangeLog	2021-08-23 17:58:38 UTC (rev 281456)
+++ branches/safari-612-branch/Source/WTF/ChangeLog	2021-08-23 18:00:49 UTC (rev 281457)
@@ -1,3 +1,42 @@
+2021-08-23  Russell Epstein  
+
+Cherry-pick r281384. rdar://problem/82218757
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Source/WebCore:
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
+Source/WTF:
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
 2021-08-18  Ryosuke Niwa  
 
 [ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing


Modified: branches/safari-612-branch/Source/WTF/wtf/CrossThreadTask.h (281456 => 281457)

--- branches/safari-612-branch/Source/WTF/wtf/CrossThreadTask.h	2021-08-23 17:58:38 UTC (rev 281456)
+++ branches/safari-612-branch/Source/WTF/wtf/CrossThreadTask.h	2021-08-23 18:00:49 UTC (rev 281457)
@@ -87,7 +87,7 @@
 callMemberFunctionForCrossThreadTaskImpl(object, function, std::forward(args), ArgsIndicies());
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = makeRefPtr(), method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {
@@ -95,7 +95,7 @@
 });
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = , method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {


Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (281456 => 281457)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-08-23 17:58:38 UTC (rev 281456)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-08-23 18:00:49 UTC (rev 281457)
@@ -1,3 +1,44 @@
+2021-08-23  Russell Epstein  
+
+Cherry-pick r281384. rdar://problem/82218757
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Source/WebCore:
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
+Source/WTF:
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
+
+ 

[webkit-changes] [281456] branches/safari-612-branch/Source

[repstein]

Title: [281456] branches/safari-612-branch/Source








Revision 281456
Author repst...@apple.com
Date 2021-08-23 10:58:38 -0700 (Mon, 23 Aug 2021)


Log Message
Versioning.

WebKit-7612.2.2

Modified Paths

branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC (rev 281455)
+++ branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-23 17:58:38 UTC (rev 281456)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (281455 => 281456)

--- branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-08-23 17:57:47 UTC 

[webkit-changes] [281455] branches/safari-612.1.29-branch/Source

[repstein]

Title: [281455] branches/safari-612.1.29-branch/Source








Revision 281455
Author repst...@apple.com
Date 2021-08-23 10:57:47 -0700 (Mon, 23 Aug 2021)


Log Message
Cherry-pick r281384. rdar://problem/82218757

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.

Reviewed by Brady Eidson.

* wtf/CrossThreadTask.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.29-branch/Source/WTF/ChangeLog
branches/safari-612.1.29-branch/Source/WTF/wtf/CrossThreadTask.h
branches/safari-612.1.29-branch/Source/WebCore/ChangeLog
branches/safari-612.1.29-branch/Source/WebCore/Modules/indexeddb/IDBRequest.cpp




Diff

Modified: branches/safari-612.1.29-branch/Source/WTF/ChangeLog (281454 => 281455)

--- branches/safari-612.1.29-branch/Source/WTF/ChangeLog	2021-08-23 17:36:45 UTC (rev 281454)
+++ branches/safari-612.1.29-branch/Source/WTF/ChangeLog	2021-08-23 17:57:47 UTC (rev 281455)
@@ -1,3 +1,42 @@
+2021-08-23  Russell Epstein  
+
+Cherry-pick r281384. rdar://problem/82218757
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Source/WebCore:
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
+Source/WTF:
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
 2021-08-18  Ryosuke Niwa  
 
 [ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing


Modified: branches/safari-612.1.29-branch/Source/WTF/wtf/CrossThreadTask.h (281454 => 281455)

--- branches/safari-612.1.29-branch/Source/WTF/wtf/CrossThreadTask.h	2021-08-23 17:36:45 UTC (rev 281454)
+++ branches/safari-612.1.29-branch/Source/WTF/wtf/CrossThreadTask.h	2021-08-23 17:57:47 UTC (rev 281455)
@@ -87,7 +87,7 @@
 callMemberFunctionForCrossThreadTaskImpl(object, function, std::forward(args), ArgsIndicies());
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = makeRefPtr(), method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {
@@ -95,7 +95,7 @@
 });
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = , method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {


Modified: branches/safari-612.1.29-branch/Source/WebCore/ChangeLog (281454 => 281455)

--- branches/safari-612.1.29-branch/Source/WebCore/ChangeLog	2021-08-23 17:36:45 UTC (rev 281454)
+++ branches/safari-612.1.29-branch/Source/WebCore/ChangeLog	2021-08-23 17:57:47 UTC (rev 281455)
@@ -1,3 +1,44 @@
+2021-08-23  Russell Epstein  
+
+Cherry-pick r281384. rdar://problem/82218757
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Source/WebCore:
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
+Source/WTF:
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+

[webkit-changes] [281454] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [281454] trunk/Source/_javascript_Core








Revision 281454
Author ysuz...@apple.com
Date 2021-08-23 10:36:45 -0700 (Mon, 23 Aug 2021)


Log Message
[JSC] emitArrayProfilingSiteWithCell should not load indexingType unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=229396

Reviewed by Saam Barati.

emitArrayProfilingSiteWithCell is always loading indexingType after profiling a cell.
But (possibly) this is old code, and there is no reason to do that. This patch removes it.

* jit/JIT.h:
* jit/JITInlines.h:
(JSC::JIT::emitArrayProfilingSiteWithCell):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emit_op_enumerator_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_in_by_val):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlines.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281453 => 281454)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-23 17:16:44 UTC (rev 281453)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-23 17:36:45 UTC (rev 281454)
@@ -1,3 +1,28 @@
+2021-08-23  Yusuke Suzuki  
+
+[JSC] emitArrayProfilingSiteWithCell should not load indexingType unnecessarily
+https://bugs.webkit.org/show_bug.cgi?id=229396
+
+Reviewed by Saam Barati.
+
+emitArrayProfilingSiteWithCell is always loading indexingType after profiling a cell.
+But (possibly) this is old code, and there is no reason to do that. This patch removes it.
+
+* jit/JIT.h:
+* jit/JITInlines.h:
+(JSC::JIT::emitArrayProfilingSiteWithCell):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emit_op_get_by_val):
+(JSC::JIT::emit_op_put_by_val):
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::emit_op_in_by_val):
+(JSC::JIT::emit_op_enumerator_get_by_val):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_get_by_val):
+(JSC::JIT::emit_op_put_by_val):
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::emit_op_in_by_val):
+
 2021-08-22  Yusuke Suzuki  
 
 [JSC] Remove already-shipped wasm option flags


Modified: trunk/Source/_javascript_Core/jit/JIT.h (281453 => 281454)

--- trunk/Source/_javascript_Core/jit/JIT.h	2021-08-23 17:16:44 UTC (rev 281453)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2021-08-23 17:36:45 UTC (rev 281454)
@@ -381,7 +381,7 @@
 std::enable_if_t::value, void>
 emitValueProfilingSiteIfProfiledOpcode(Op bytecode);
 
-void emitArrayProfilingSiteWithCell(RegisterID cell, RegisterID indexingType, ArrayProfile*);
+void emitArrayProfilingSiteWithCell(RegisterID cellGPR, ArrayProfile*, RegisterID scratchGPR);
 void emitArrayProfileStoreToHoleSpecialCase(ArrayProfile*);
 void emitArrayProfileOutOfBoundsSpecialCase(ArrayProfile*);
 


Modified: trunk/Source/_javascript_Core/jit/JITInlines.h (281453 => 281454)

--- trunk/Source/_javascript_Core/jit/JITInlines.h	2021-08-23 17:16:44 UTC (rev 281453)
+++ trunk/Source/_javascript_Core/jit/JITInlines.h	2021-08-23 17:36:45 UTC (rev 281454)
@@ -344,14 +344,12 @@
 }
 #endif
 
-inline void JIT::emitArrayProfilingSiteWithCell(RegisterID cell, RegisterID indexingType, ArrayProfile* arrayProfile)
+inline void JIT::emitArrayProfilingSiteWithCell(RegisterID cellGPR, ArrayProfile* arrayProfile, RegisterID scratchGPR)
 {
 if (shouldEmitProfiling()) {
-load32(MacroAssembler::Address(cell, JSCell::structureIDOffset()), indexingType);
-store32(indexingType, arrayProfile->addressOfLastSeenStructureID());
+load32(MacroAssembler::Address(cellGPR, JSCell::structureIDOffset()), scratchGPR);
+store32(scratchGPR, arrayProfile->addressOfLastSeenStructureID());
 }
-
-load8(Address(cell, JSCell::indexingTypeAndMiscOffset()), indexingType);
 }
 
 inline void JIT::emitArrayProfileStoreToHoleSpecialCase(ArrayProfile* arrayProfile)


Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (281453 => 281454)

--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2021-08-23 17:16:44 UTC (rev 281453)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2021-08-23 17:36:45 UTC (rev 281454)
@@ -60,12 +60,12 @@
 
 if (metadata.m_seenIdentifiers.count() > Options::getByValICMaxNumberOfIdentifiers()) {
 auto notCell = branchIfNotCell(regT0);
-emitArrayProfilingSiteWithCell(regT0, regT2, profile);
+emitArrayProfilingSiteWithCell(regT0, profile, regT2);
 notCell.link(this);
 callOperationWithProfile(bytecode.metadata(m_codeBlock), operationGetByVal, dst, 

[webkit-changes] [281453] trunk/LayoutTests

[ehutchison]

Title: [281453] trunk/LayoutTests








Revision 281453
Author ehutchi...@apple.com
Date 2021-08-23 10:16:44 -0700 (Mon, 23 Aug 2021)


Log Message
Update test expectations for fast/events/touch/page-scaled-touch-gesture-click.html.
https://bugs.webkit.org/show_bug.cgi?id=168961.

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281452 => 281453)

--- trunk/LayoutTests/ChangeLog	2021-08-23 17:02:55 UTC (rev 281452)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 17:16:44 UTC (rev 281453)
@@ -1,5 +1,14 @@
 2021-08-23  Eric Hutchison  
 
+Update test expectations for fast/events/touch/page-scaled-touch-gesture-click.html.
+https://bugs.webkit.org/show_bug.cgi?id=168961.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Update test expectations for fast/events/wheelevent-in-frame.html.
 https://bugs.webkit.org/show_bug.cgi?id=168961.
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281452 => 281453)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 17:02:55 UTC (rev 281452)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 17:16:44 UTC (rev 281453)
@@ -2023,5 +2023,7 @@
 
 webkit.org/b/168961 fast/events/wheelevent-in-frame.html [ Pass Timeout ]
 
+webkit.org/b/168961 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281452] trunk/LayoutTests

[ehutchison]

Title: [281452] trunk/LayoutTests








Revision 281452
Author ehutchi...@apple.com
Date 2021-08-23 10:02:55 -0700 (Mon, 23 Aug 2021)


Log Message
Update test expectations for fast/events/wheelevent-in-frame.html.
https://bugs.webkit.org/show_bug.cgi?id=168961.

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281451 => 281452)

--- trunk/LayoutTests/ChangeLog	2021-08-23 16:45:05 UTC (rev 281451)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 17:02:55 UTC (rev 281452)
@@ -1,5 +1,15 @@
 2021-08-23  Eric Hutchison  
 
+Update test expectations for fast/events/wheelevent-in-frame.html.
+https://bugs.webkit.org/show_bug.cgi?id=168961.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
+2021-08-23  Eric Hutchison  
+
 Update test expectations for fast/forms/ios/ipad/open-picker-using-keyboard.html and fast/forms/ios/accessory-bar-navigation.html.
 , .
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281451 => 281452)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 16:45:05 UTC (rev 281451)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 17:02:55 UTC (rev 281452)
@@ -2021,5 +2021,7 @@
 
 #rdar://80390931 (REGRESSION (r271861): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout) fast/forms/ios/accessory-bar-navigation.html [ Timeout ] 
 
+webkit.org/b/168961 fast/events/wheelevent-in-frame.html [ Pass Timeout ]
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (281451 => 281452)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 16:45:05 UTC (rev 281451)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-23 17:02:55 UTC (rev 281452)
@@ -2330,4 +2330,7 @@
 
 webkit.org/b/228176 [ Mojave Catalina BigSur ] fast/text/variable-system-font.html [ ImageOnlyFailure ]
 webkit.org/b/228176 [ Monterey ] fast/text/variable-system-font.html [ Pass ]
+
+webkit.org/b/168961 [ Catalina ] fast/events/wheelevent-in-frame.html [ Pass Timeout ]
+
 webkit.org/b/228176 [ Mojave Catalina BigSur Monterey ] fast/text/variable-system-font-2.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281451] trunk/LayoutTests

[ehutchison]

Title: [281451] trunk/LayoutTests








Revision 281451
Author ehutchi...@apple.com
Date 2021-08-23 09:45:05 -0700 (Mon, 23 Aug 2021)


Log Message
Update test expectations for fast/forms/ios/ipad/open-picker-using-keyboard.html and fast/forms/ios/accessory-bar-navigation.html.
, .

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281450 => 281451)

--- trunk/LayoutTests/ChangeLog	2021-08-23 16:41:50 UTC (rev 281450)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 16:45:05 UTC (rev 281451)
@@ -1,3 +1,12 @@
+2021-08-23  Eric Hutchison  
+
+Update test expectations for fast/forms/ios/ipad/open-picker-using-keyboard.html and fast/forms/ios/accessory-bar-navigation.html.
+, .
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-08-23  Wenson Hsieh  
 
 REGRESSION (r271146): editing/selection/ios/scrolling-to-focused-element-inside-iframe.html is failing


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281450 => 281451)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 16:41:50 UTC (rev 281450)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-23 16:45:05 UTC (rev 281451)
@@ -2017,5 +2017,9 @@
 
 # rdar://80393995 ([ iOS15 ] http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html is a constant timeout) http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html [ Timeout ]
 
+#rdar://80391927 ([ iOS ] fast/forms/ios/ipad/open-picker-using-keyboard.html is a flaky timeout) fast/forms/ios/ipad/open-picker-using-keyboard.html [ Pass Timeout ]
+
+#rdar://80390931 (REGRESSION (r271861): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout) fast/forms/ios/accessory-bar-navigation.html [ Timeout ] 
+
 #rdar://82183980 ([ iOS 15 ]editing/selection/ios/hide-selection-in-tiny-contenteditable.html is a flaky failure)
 editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281450] trunk

[wenson_hsieh]

Title: [281450] trunk








Revision 281450
Author wenson_hs...@apple.com
Date 2021-08-23 09:41:50 -0700 (Mon, 23 Aug 2021)


Log Message
REGRESSION (r271146): editing/selection/ios/scrolling-to-focused-element-inside-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=229376
rdar://80384683

Reviewed by Megan Gardner.

Source/WebKit:

This iOS-specific test verifies that tapping on an element that makes itself contenteditable inside of a click
event handler both (1) brings up the software keyboard, and (2) scrolls to reveal the focused, newly editable
element such that it is not obscured by the software keyboard. This test began failing after the changes in
r271146 -- specifically, the fact that the call to `Element::setFocus()` moved to before the focus event is
dispatched, rather than afterwards.

The following timeline of events (annotated with web and UI processes) illustrates why this happens:

(WEB)   1.  The click event on the element inside the subframe is handled; the element is made contentEditable,
and we make it focused, by first calling `Element::setFocus` and then `Element::dispatchFocusEvent`.
Right before dispatching the "focus" event, we call out to the client layer, via
`WebPage::elementDidFocus`, and compute a FocusedElementInformation struct to encode and send to the
UI process in the WebPageProxy::ElementDidFocus IPC message.

2.  In the process of populating this struct in `WebPage::focusedElementInformation`, we observe that
layout is dirty, and immediately compute and send an EditorState underneath
`WebPage::sendEditorStateUpdate()`.

3.  We then proceed to construct and send FocusedElementInformation to the UI process via
`Messages::WebPageProxy::ElementDidFocus`.

(UI)4.  We receive the EditorState that was computed and sent in step (2), which contains the up-to-date
state corresponding to the newly focused contentEditable `div`.

5.  We then receive the FocusedElementInformation computed and sent in step (3), which makes us begin
waiting for the next post-layout EditorState update before zooming to reveal the focused element, by
setting WebPageProxy's `m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement` flag. However,
this post-layout EditorState after focusing the `div` never arrives, since we've already computed it
and sent it in step (2).

6.  The software keyboard finishes animating in, causing us to resolve the UIScriptController promise
that we began to await after calling `UIHelper.activateAndWaitForInputSessionAt` in the test.

(WEB)   7.  The test finishes, calls `testRunner.notifyDone()`, and we destroy the focused subframe and clear
the editable selection as well. This selection change causes us to compute another post-layout
editor state and send it to the UI process.

(UI)8.  The UI process *finally* receives the post-layout EditorState computed in (7). However, it's too
late, since (a) the test has already finished, and (b) the post-layout EditorState is computed after
the editable selection has already been cleared, so it's missing selection rect information anyways.

Prior to r271146, the call to `Element::setFocus` came *after* step (3), and caused us to compute and send
another EditorState to the UI process, which ensured that an up-to-date post layout EditorState would arrive in
the UI process shortly after step (5).

To fix this, we should avoid immediately computing and sending an EditorState to the UI process in the middle of
`WebPage::focusedElementInformation`, and instead simply schedule an EditorState during the next rendering
update. This ensures that the editor state triggered during element focus will always arrive after
`WebPageProxy::ElementDidFocus` in the UI process, rather than before, which allows us to scroll to the correct
selection rect in the UI process when focusing an editable element.

This also has the additional benefit of avoiding redundant EditorState computation and updates in the case where
focus is programmatically thrashed between elements during the same rendering update, since all of the editor
state updates are effectively batched together and dispatched at the end of the current rendering update.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::focusedElementInformation):

LayoutTests:

Adjust test expectations for the layout test, which should now pass.

* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (281449 => 281450)

--- trunk/LayoutTests/ChangeLog	

[webkit-changes] [281449] branches/safari-612.1.29-branch/Source

[repstein]

Title: [281449] branches/safari-612.1.29-branch/Source








Revision 281449
Author repst...@apple.com
Date 2021-08-23 09:38:16 -0700 (Mon, 23 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.29.1

Modified Paths

branches/safari-612.1.29-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.29-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.29-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281448 => 281449)

--- branches/safari-612.1.29-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 16:33:58 UTC (rev 281448)
+++ branches/safari-612.1.29-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 16:38:16 UTC (rev 281449)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.29-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281448 => 281449)

--- branches/safari-612.1.29-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 16:33:58 UTC (rev 281448)
+++ branches/safari-612.1.29-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 16:38:16 UTC (rev 281449)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.29-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281448 => 281449)

--- branches/safari-612.1.29-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 16:33:58 UTC (rev 281448)
+++ branches/safari-612.1.29-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 16:38:16 UTC (rev 281449)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.29-branch/Source/WebCore/Configurations/Version.xcconfig (281448 => 281449)

--- branches/safari-612.1.29-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 16:33:58 UTC (rev 281448)
+++ branches/safari-612.1.29-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 16:38:16 UTC (rev 281449)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.29-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281448 => 281449)

--- branches/safari-612.1.29-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 16:33:58 UTC (rev 281448)
+++ branches/safari-612.1.29-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 16:38:16 UTC (rev 281449)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 

[webkit-changes] [281448] trunk/Tools

[jbedard]

Title: [281448] trunk/Tools








Revision 281448
Author jbed...@apple.com
Date 2021-08-23 09:33:58 -0700 (Mon, 23 Aug 2021)


Log Message
[Cygwin] Support Python 3 in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=229360


Reviewed by Dewei Zhu.

* Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py:
(TaskPoolUnittest): Skip some tests on cygwin.
* Scripts/webkitpy/common/system/abstractexecutive.py:
(AbstractExecutive.command_for_printing): Strings might be bytes on some platforms.
* Scripts/webkitpy/common/system/path.py:
(_CygPath.convert): Cygwin path process is not unicode.
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._win_version_str): Return Windows version string as unicode string.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/abstractexecutive.py
trunk/Tools/Scripts/webkitpy/common/system/path.py
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py




Diff

Modified: trunk/Tools/ChangeLog (281447 => 281448)

--- trunk/Tools/ChangeLog	2021-08-23 16:01:29 UTC (rev 281447)
+++ trunk/Tools/ChangeLog	2021-08-23 16:33:58 UTC (rev 281448)
@@ -1,3 +1,22 @@
+2021-08-23  Jonathan Bedard  
+
+[Cygwin] Support Python 3 in run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=229360
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitcorepy/setup.py: Bump version.
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
+* Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py:
+(TaskPoolUnittest): Skip some tests on cygwin.
+* Scripts/webkitpy/common/system/abstractexecutive.py:
+(AbstractExecutive.command_for_printing): Strings might be bytes on some platforms.
+* Scripts/webkitpy/common/system/path.py:
+(_CygPath.convert): Cygwin path process is not unicode.
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo._win_version_str): Return Windows version string as unicode string.
+
 2021-08-22  Yusuke Suzuki  
 
 [JSC] Remove already-shipped wasm option flags


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/setup.py (281447 => 281448)

--- trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-08-23 16:01:29 UTC (rev 281447)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-08-23 16:33:58 UTC (rev 281448)
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitcorepy',
-version='0.9.0',
+version='0.9.1',
 description='Library containing various Python support classes and functions.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (281447 => 281448)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-08-23 16:01:29 UTC (rev 281447)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-08-23 16:33:58 UTC (rev 281448)
@@ -41,7 +41,7 @@
 from webkitcorepy.nested_fuzzy_dict import NestedFuzzyDict
 from webkitcorepy.call_by_need import CallByNeed
 
-version = Version(0, 9, 0)
+version = Version(0, 9, 1)
 
 from webkitcorepy.autoinstall import Package, AutoInstall
 if sys.version_info > (3, 0):


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py (281447 => 281448)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py	2021-08-23 16:01:29 UTC (rev 281447)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py	2021-08-23 16:33:58 UTC (rev 281448)
@@ -22,6 +22,7 @@
 
 import logging
 import time
+import sys
 import unittest
 
 from webkitcorepy import OutputCapture, TaskPool, log as logger
@@ -59,16 +60,6 @@
 class TaskPoolUnittest(unittest.TestCase):
 alphabet = 'abcdefghijklmnopqrstuvwxyz'
 
-def test_single(self):
-with OutputCapture(level=logging.WARNING) as captured:
-with TaskPool(workers=1, force_fork=True) as pool:
-pool.do(action, 'a')
-pool.do(log, logging.WARNING, '1')
-pool.wait()
-
-self.assertEqual(captured.stdout.getvalue(), 'action(a)\n')
-self.assertEqual(captured.webkitcorepy.log.getvalue(), 'worker/0 1\n')
-
 def test_single_no_fork(self):
 with OutputCapture(level=logging.WARNING) as captured:
 with TaskPool(workers=1, force_fork=False) as pool:
@@ -79,20 +70,6 @@
 self.assertEqual(captured.stdout.getvalue(), 'action(a)\n')
 self.assertEqual(captured.webkitcorepy.log.getvalue(), '1\n')
 
-def test_multiple(self):
-with 

[webkit-changes] [281447] trunk/LayoutTests/imported/w3c

[sihui_liu]

Title: [281447] trunk/LayoutTests/imported/w3c








Revision 281447
Author sihui_...@apple.com
Date 2021-08-23 09:01:29 -0700 (Mon, 23 Aug 2021)


Log Message
Import permissions tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=229349

Reviewed by Chris Dumez.

* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/permissions/META.yml: Added.
* web-platform-tests/permissions/feature-policy-permissions-query.html: Added.
* web-platform-tests/permissions/idlharness.any-expected.txt: Added.
* web-platform-tests/permissions/idlharness.any.html: Added.
* web-platform-tests/permissions/idlharness.any.js: Added.
(async idl_array):
* web-platform-tests/permissions/idlharness.any.worker-expected.txt: Added.
* web-platform-tests/permissions/idlharness.any.worker.html: Added.
* web-platform-tests/permissions/nfc-permission-expected.txt: Added.
* web-platform-tests/permissions/nfc-permission.html: Added.
* web-platform-tests/permissions/permissions-query-feature-policy-attribute.https.sub-expected.txt: Added.
* web-platform-tests/permissions/permissions-query-feature-policy-attribute.https.sub.html: Added.
* web-platform-tests/permissions/permissionsstatus-name-expected.txt: Added.
* web-platform-tests/permissions/permissionsstatus-name.html: Added.
* web-platform-tests/permissions/screen-wake-lock-permission-expected.txt: Added.
* web-platform-tests/permissions/screen-wake-lock-permission.html: Added.
* web-platform-tests/permissions/test-background-fetch-permission-expected.txt: Added.
* web-platform-tests/permissions/test-background-fetch-permission.html: Added.
* web-platform-tests/permissions/test-periodic-background-sync-permission-expected.txt: Added.
* web-platform-tests/permissions/test-periodic-background-sync-permission.html: Added.
* web-platform-tests/permissions/w3c-import.log: Added.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json
trunk/LayoutTests/imported/w3c/resources/resource-files.json


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/META.yml
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/feature-policy-permissions-query.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.js
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.worker.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/nfc-permission-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/nfc-permission.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/permissions-query-feature-policy-attribute.https.sub-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/permissions-query-feature-policy-attribute.https.sub.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/permissionsstatus-name-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/permissionsstatus-name.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/screen-wake-lock-permission-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/screen-wake-lock-permission.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/test-background-fetch-permission-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/test-background-fetch-permission.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/test-periodic-background-sync-permission-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/test-periodic-background-sync-permission.html
trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/w3c-import.log




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281446 => 281447)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 15:11:36 UTC (rev 281446)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 16:01:29 UTC (rev 281447)
@@ -1,3 +1,34 @@
+2021-08-23  Sihui Liu  
+
+Import permissions tests from WPT
+https://bugs.webkit.org/show_bug.cgi?id=229349
+
+Reviewed by Chris Dumez.
+
+* resources/import-expectations.json:
+* resources/resource-files.json:
+* web-platform-tests/permissions/META.yml: Added.
+* web-platform-tests/permissions/feature-policy-permissions-query.html: Added.
+* web-platform-tests/permissions/idlharness.any-expected.txt: Added.
+* web-platform-tests/permissions/idlharness.any.html: Added.
+* web-platform-tests/permissions/idlharness.any.js: Added.
+(async idl_array):
+* 

[webkit-changes] [281446] trunk

[mrobinson]

Title: [281446] trunk








Revision 281446
Author mrobin...@webkit.org
Date 2021-08-23 08:11:36 -0700 (Mon, 23 Aug 2021)


Log Message
Sticky position should not use transformed position to compute sticky offset.
https://bugs.webkit.org/show_bug.cgi?id=164292


Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt: Update results
of test to show pass.

Source/WebCore:

No new tests. This change is tested by the following WPT test:
  web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): When calling localToContainerQuad,
pass 0 for the mode which means that the transformation between coordinate systems does not include
transforms.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281445 => 281446)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 15:02:30 UTC (rev 281445)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 15:11:36 UTC (rev 281446)
@@ -1,3 +1,14 @@
+2021-08-23  Martin Robinson  
+
+Sticky position should not use transformed position to compute sticky offset.
+https://bugs.webkit.org/show_bug.cgi?id=164292
+
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt: Update results
+of test to show pass.
+
 2021-08-23  Chris Dumez  
 
 WebKit2 can only have one active navigation policy check for a given frame


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt (281445 => 281446)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt	2021-08-23 15:02:30 UTC (rev 281445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt	2021-08-23 15:11:36 UTC (rev 281446)
@@ -1,5 +1,5 @@
 
 PASS Translation transform can move sticky element past sticking point
 PASS Stuck elements can still be moved via translations
-FAIL The sticky element should stick before the container is offset by a translation assert_equals: expected 150 but got 100
+PASS The sticky element should stick before the container is offset by a translation
 


Modified: trunk/Source/WebCore/ChangeLog (281445 => 281446)

--- trunk/Source/WebCore/ChangeLog	2021-08-23 15:02:30 UTC (rev 281445)
+++ trunk/Source/WebCore/ChangeLog	2021-08-23 15:11:36 UTC (rev 281446)
@@ -1,3 +1,19 @@
+2021-08-23  Martin Robinson  
+
+Sticky position should not use transformed position to compute sticky offset.
+https://bugs.webkit.org/show_bug.cgi?id=164292
+
+
+Reviewed by Simon Fraser.
+
+No new tests. This change is tested by the following WPT test:
+  web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): When calling localToContainerQuad,
+pass 0 for the mode which means that the transformation between coordinate systems does not include
+transforms.
+
 2021-08-23  Carlos Garcia Campos  
 
 Create a RenderLineBreak when BR element has unsupported content data style


Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (281445 => 281446)

--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2021-08-23 15:02:30 UTC (rev 281445)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2021-08-23 15:11:36 UTC (rev 281446)
@@ -488,8 +488,9 @@
 // Compute the container-relative area within which the sticky element is allowed to move.
 containerContentRect.contract(minMargin);
 
-// Finally compute container rect relative to the scrolling ancestor.
-FloatRect containerRectRelativeToScrollingAncestor = containingBlock->localToContainerQuad(FloatRect(containerContentRect), ).boundingBox();
+// Finally compute container rect relative to the scrolling ancestor. We pass an empty
+// mode here, because sticky positioning should ignore transforms.
+FloatRect containerRectRelativeToScrollingAncestor = containingBlock->localToContainerQuad(FloatRect(containerContentRect), , { } /* ignore transforms */).boundingBox();
 if (enclosingClippingLayer) {
 FloatPoint containerLocationRelativeToScrollingAncestor = containerRectRelativeToScrollingAncestor.location() -
 

[webkit-changes] [281445] trunk

[cdumez]

Title: [281445] trunk








Revision 281445
Author cdu...@apple.com
Date 2021-08-23 08:02:30 -0700 (Mon, 23 Aug 2021)


Log Message
WebKit2 can only have one active navigation policy check for a given frame
https://bugs.webkit.org/show_bug.cgi?id=229012

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test that is now passing one more check.

* web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt:

Source/WebKit:

WebKit2 could only have one active navigation policy check for a given frame
and there was a FIXME comment about this in the code. This was causing some
WPT tests to timeout in WebKit2 only because those tests would trigger
several navigations (e.g. in new windows) and only the last one would proceed
(earlier ones would get cancelled).

This patch updates the policy checking logic in WebFrame so that we can support
several concurrent policy checks.

No new tests, unskipped / rebaselined existing tests.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::cancelPolicyCheck):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::~WebFrame):
(WebKit::WebFrame::setUpPolicyListener):
(WebKit::WebFrame::setUpWillSubmitFormListener):
(WebKit::WebFrame::continueWillSubmitForm):
(WebKit::WebFrame::invalidatePolicyListeners):
(WebKit::WebFrame::didReceivePolicyDecision):
* WebProcess/WebPage/WebFrame.h:

LayoutTests:

Unskip a couple of tests that are no longer timing out in WebKit2.

* platform/ios-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt
trunk/LayoutTests/platform/wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.h


Removed Paths

trunk/LayoutTests/platform/ios-wk1/imported/w3c/web-platform-tests/html/browsers/windows/
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/windows/




Diff

Modified: trunk/LayoutTests/ChangeLog (281444 => 281445)

--- trunk/LayoutTests/ChangeLog	2021-08-23 14:53:04 UTC (rev 281444)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 15:02:30 UTC (rev 281445)
@@ -1,3 +1,16 @@
+2021-08-23  Chris Dumez  
+
+WebKit2 can only have one active navigation policy check for a given frame
+https://bugs.webkit.org/show_bug.cgi?id=229012
+
+Reviewed by Youenn Fablet.
+
+Unskip a couple of tests that are no longer timing out in WebKit2.
+
+* platform/ios-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
+* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
+* platform/wk2/TestExpectations:
+
 2021-08-23  Carlos Garcia Campos  
 
 Create a RenderLineBreak when BR element has unsupported content data style


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281444 => 281445)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 14:53:04 UTC (rev 281444)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 15:02:30 UTC (rev 281445)
@@ -1,5 +1,16 @@
 2021-08-23  Chris Dumez  
 
+WebKit2 can only have one active navigation policy check for a given frame
+https://bugs.webkit.org/show_bug.cgi?id=229012
+
+Reviewed by Youenn Fablet.
+
+Rebaseline test that is now passing one more check.
+
+* web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt:
+
+2021-08-23  Chris Dumez  
+
 HTMLStyleElement should be able to fire the load event more than once
 https://bugs.webkit.org/show_bug.cgi?id=228975
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt (281444 => 281445)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt	2021-08-23 14:53:04 UTC (rev 281444)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt	2021-08-23 15:02:30 UTC (rev 281445)
@@ -1,7 +1,7 @@
 
 Harness Error (TIMEOUT), message = null
 
-TIMEOUT Following a noreferrer link with a named target should not cause creation of a window that can be targeted by another noreferrer link with the same named target Test timed out
+PASS Following a noreferrer link with a named target should not cause creation of a window that can be targeted by another noreferrer link with the same named target
 PASS Targeting a rel=noreferrer 

[webkit-changes] [281444] trunk

[commit-queue]

Title: [281444] trunk








Revision 281444
Author commit-qu...@webkit.org
Date 2021-08-23 07:53:04 -0700 (Mon, 23 Aug 2021)


Log Message
Create a RenderLineBreak when BR element has unsupported content data style
https://bugs.webkit.org/show_bug.cgi?id=224849

Patch by Carlos Garcia Campos  on 2021-08-23
Reviewed by Antti Koivisto.

Source/WebCore:

Instead of falling back to RenderElement::createFor(), create a RenderLineBreak just ignoring the unsupported
content data.

* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::createElementRenderer):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::isContentDataSupported):
(WebCore::RenderElement::createFor):
* rendering/RenderElement.h:

LayoutTests:

* editing/execCommand/insert-image-in-composed-list-expected.txt: Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/execCommand/insert-image-in-composed-list-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLBRElement.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (281443 => 281444)

--- trunk/LayoutTests/ChangeLog	2021-08-23 14:50:46 UTC (rev 281443)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 14:53:04 UTC (rev 281444)
@@ -1,3 +1,12 @@
+2021-08-23  Carlos Garcia Campos  
+
+Create a RenderLineBreak when BR element has unsupported content data style
+https://bugs.webkit.org/show_bug.cgi?id=224849
+
+Reviewed by Antti Koivisto.
+
+* editing/execCommand/insert-image-in-composed-list-expected.txt: Rebaseline.
+
 2021-08-23  Chris Dumez  
 
 HTMLStyleElement should be able to fire the load event more than once


Modified: trunk/LayoutTests/editing/execCommand/insert-image-in-composed-list-expected.txt (281443 => 281444)

--- trunk/LayoutTests/editing/execCommand/insert-image-in-composed-list-expected.txt	2021-08-23 14:50:46 UTC (rev 281443)
+++ trunk/LayoutTests/editing/execCommand/insert-image-in-composed-list-expected.txt	2021-08-23 14:53:04 UTC (rev 281444)
@@ -1 +1,2 @@
-Test passes if it does not crash.
+Test passes if it does not crash. 
+


Modified: trunk/Source/WebCore/ChangeLog (281443 => 281444)

--- trunk/Source/WebCore/ChangeLog	2021-08-23 14:50:46 UTC (rev 281443)
+++ trunk/Source/WebCore/ChangeLog	2021-08-23 14:53:04 UTC (rev 281444)
@@ -1,3 +1,20 @@
+2021-08-23  Carlos Garcia Campos  
+
+Create a RenderLineBreak when BR element has unsupported content data style
+https://bugs.webkit.org/show_bug.cgi?id=224849
+
+Reviewed by Antti Koivisto.
+
+Instead of falling back to RenderElement::createFor(), create a RenderLineBreak just ignoring the unsupported
+content data.
+
+* html/HTMLBRElement.cpp:
+(WebCore::HTMLBRElement::createElementRenderer):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::isContentDataSupported):
+(WebCore::RenderElement::createFor):
+* rendering/RenderElement.h:
+
 2021-08-23  Chris Dumez  
 
 HTMLStyleElement should be able to fire the load event more than once


Modified: trunk/Source/WebCore/html/HTMLBRElement.cpp (281443 => 281444)

--- trunk/Source/WebCore/html/HTMLBRElement.cpp	2021-08-23 14:50:46 UTC (rev 281443)
+++ trunk/Source/WebCore/html/HTMLBRElement.cpp	2021-08-23 14:53:04 UTC (rev 281444)
@@ -75,7 +75,7 @@
 
 RenderPtr HTMLBRElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
 {
-if (style.hasContent())
+if (style.hasContent() && RenderElement::isContentDataSupported(*style.contentData()))
 return RenderElement::createFor(*this, WTFMove(style));
 
 return createRenderer(*this, WTFMove(style));


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (281443 => 281444)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2021-08-23 14:50:46 UTC (rev 281443)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2021-08-23 14:53:04 UTC (rev 281444)
@@ -145,13 +145,19 @@
 ASSERT(!m_firstChild);
 }
 
-RenderPtr RenderElement::createFor(Element& element, RenderStyle&& style, OptionSet rendererTypeOverride)
+bool RenderElement::isContentDataSupported(const ContentData& contentData)
 {
 // Minimal support for content properties replacing an entire element.
 // Works only if we have exactly one piece of content and it's a URL.
 // Otherwise acts as if we didn't support this feature.
+return is(contentData) && !contentData.next();
+}
+
+RenderPtr RenderElement::createFor(Element& element, RenderStyle&& style, OptionSet rendererTypeOverride)
+{
+
 const ContentData* contentData = style.contentData();
-if (!rendererTypeOverride && contentData && !contentData->next() && is(*contentData) && !element.isPseudoElement()) {
+if (!rendererTypeOverride && contentData && isContentDataSupported(*contentData) && !element.isPseudoElement()) {
 Style::loadPendingResources(style, 

[webkit-changes] [281443] trunk

[cdumez]

Title: [281443] trunk








Revision 281443
Author cdu...@apple.com
Date 2021-08-23 07:50:46 -0700 (Mon, 23 Aug 2021)


Log Message
HTMLStyleElement should be able to fire the load event more than once
https://bugs.webkit.org/show_bug.cgi?id=228975

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing. This test was already passing in both Firefox and Chrome.

* web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt:

Source/WebCore:

HTMLStyleElement should be able to fire the load event more than once. WebKit has a flag
preventing the load event to fire more than once but this behavior is not present in the
HTML specification and doesn't match other browsers.

No new tests, rebaselined existing test.

* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):
* html/HTMLStyleElement.h:

LayoutTests:

Unskip test that is no longer timing out.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (281442 => 281443)

--- trunk/LayoutTests/ChangeLog	2021-08-23 14:32:41 UTC (rev 281442)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 14:50:46 UTC (rev 281443)
@@ -1,3 +1,14 @@
+2021-08-23  Chris Dumez  
+
+HTMLStyleElement should be able to fire the load event more than once
+https://bugs.webkit.org/show_bug.cgi?id=228975
+
+Reviewed by Youenn Fablet.
+
+Unskip test that is no longer timing out.
+
+* TestExpectations:
+
 2021-08-23  Xan Lopez  
 
 Skip failing test on 32bit (ARMv7/MIPS)


Modified: trunk/LayoutTests/TestExpectations (281442 => 281443)

--- trunk/LayoutTests/TestExpectations	2021-08-23 14:32:41 UTC (rev 281442)
+++ trunk/LayoutTests/TestExpectations	2021-08-23 14:50:46 UTC (rev 281443)
@@ -540,7 +540,6 @@
 imported/w3c/web-platform-tests/html/interaction/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-order.html [ Skip ]
 imported/w3c/web-platform-tests/html/interaction/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-positive.html [ Skip ]
 imported/w3c/web-platform-tests/html/interaction/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-zero.html [ Skip ]
-imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/loop-from-ended.tentative.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/src_object_blob.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue.html [ Skip ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281442 => 281443)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 14:32:41 UTC (rev 281442)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-23 14:50:46 UTC (rev 281443)
@@ -1,3 +1,14 @@
+2021-08-23  Chris Dumez  
+
+HTMLStyleElement should be able to fire the load event more than once
+https://bugs.webkit.org/show_bug.cgi?id=228975
+
+Reviewed by Youenn Fablet.
+
+Rebaseline WPT test that is now passing. This test was already passing in both Firefox and Chrome.
+
+* web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt:
+
 2021-08-22  Myles C. Maxfield  
 
 Control characters (Unicode category Cc) should be rendered visibly


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt (281442 => 281443)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt	2021-08-23 14:32:41 UTC (rev 281442)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style_load_event-expected.txt	2021-08-23 14:50:46 UTC (rev 281443)
@@ -1,5 +1,3 @@
 
-Harness Error (TIMEOUT), message = null
+PASS style load event should fire when textContent changed
 
-TIMEOUT style load event should fire when textContent changed Test timed out
-


Modified: trunk/Source/WebCore/ChangeLog (281442 => 281443)

--- trunk/Source/WebCore/ChangeLog	2021-08-23 14:32:41 UTC (rev 281442)
+++ trunk/Source/WebCore/ChangeLog	2021-08-23 14:50:46 UTC (rev 281443)
@@ -1,3 +1,20 @@
+2021-08-23  Chris Dumez  
+
+HTMLStyleElement should be able to fire the load event more than 

[webkit-changes] [281442] trunk/LayoutTests

[commit-queue]

Title: [281442] trunk/LayoutTests








Revision 281442
Author commit-qu...@webkit.org
Date 2021-08-23 07:32:41 -0700 (Mon, 23 Aug 2021)


Log Message
Skip failing test on 32bit (ARMv7/MIPS)
https://bugs.webkit.org/show_bug.cgi?id=229407

Unreviewed test gardening.

Patch by Xan Lopez  on 2021-08-23

* js/script-tests/reserved-words.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/reserved-words.js




Diff

Modified: trunk/LayoutTests/ChangeLog (281441 => 281442)

--- trunk/LayoutTests/ChangeLog	2021-08-23 14:20:50 UTC (rev 281441)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 14:32:41 UTC (rev 281442)
@@ -1,3 +1,12 @@
+2021-08-23  Xan Lopez  
+
+Skip failing test on 32bit (ARMv7/MIPS)
+https://bugs.webkit.org/show_bug.cgi?id=229407
+
+Unreviewed test gardening.
+
+* js/script-tests/reserved-words.js:
+
 2021-08-23  Alicia Boya García  
 
 [MSE][GStreamer] Implement multi-track support


Modified: trunk/LayoutTests/js/script-tests/reserved-words.js (281441 => 281442)

--- trunk/LayoutTests/js/script-tests/reserved-words.js	2021-08-23 14:20:50 UTC (rev 281441)
+++ trunk/LayoutTests/js/script-tests/reserved-words.js	2021-08-23 14:32:41 UTC (rev 281442)
@@ -1,3 +1,4 @@
+//@ skip if (["arm", "mips"].include?($architecture) and $hostOS == "linux")
 function isReserved(word)
 {
 try {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281441] trunk/Source/WebInspectorUI

[rcaliman]

Title: [281441] trunk/Source/WebInspectorUI








Revision 281441
Author rcali...@apple.com
Date 2021-08-23 07:20:50 -0700 (Mon, 23 Aug 2021)


Log Message
Web Inspector: CSS Changes: changes are not updated live
https://bugs.webkit.org/show_bug.cgi?id=229153


Reviewed by Devin Rousso.

Dispatch an event whenever the list of modified styles changes.
Re-layout the Changes details sidebar panel in response to this event
to reflect the latest state of the modified styles.

* UserInterface/Controllers/CSSManager.js:
(WI.CSSManager.prototype.addModifiedStyle):
(WI.CSSManager.prototype.removeModifiedStyle):
* UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype.attached):
(WI.ChangesDetailsSidebarPanel.prototype.detached):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (281440 => 281441)

--- trunk/Source/WebInspectorUI/ChangeLog	2021-08-23 13:22:29 UTC (rev 281440)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-08-23 14:20:50 UTC (rev 281441)
@@ -1,3 +1,22 @@
+2021-08-23  Razvan Caliman  
+
+Web Inspector: CSS Changes: changes are not updated live
+https://bugs.webkit.org/show_bug.cgi?id=229153
+
+
+Reviewed by Devin Rousso.
+
+Dispatch an event whenever the list of modified styles changes.
+Re-layout the Changes details sidebar panel in response to this event
+to reflect the latest state of the modified styles.
+
+* UserInterface/Controllers/CSSManager.js:
+(WI.CSSManager.prototype.addModifiedStyle):
+(WI.CSSManager.prototype.removeModifiedStyle):
+* UserInterface/Views/ChangesDetailsSidebarPanel.js:
+(WI.ChangesDetailsSidebarPanel.prototype.attached):
+(WI.ChangesDetailsSidebarPanel.prototype.detached):
+
 2021-08-19  Alex Christensen  
 
 Remove more non-inclusive language from Source


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js (281440 => 281441)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js	2021-08-23 13:22:29 UTC (rev 281440)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js	2021-08-23 14:20:50 UTC (rev 281441)
@@ -355,6 +355,8 @@
 addModifiedStyle(style)
 {
 this._modifiedStyles.set(style.stringId, style);
+
+this.dispatchEventToListeners(WI.CSSManager.Event.ModifiedStylesChanged);
 }
 
 getModifiedStyle(style)
@@ -365,6 +367,8 @@
 removeModifiedStyle(style)
 {
 this._modifiedStyles.delete(style.stringId);
+
+this.dispatchEventToListeners(WI.CSSManager.Event.ModifiedStylesChanged);
 }
 
 // PageObserver
@@ -674,6 +678,7 @@
 WI.CSSManager.Event = {
 StyleSheetAdded: "css-manager-style-sheet-added",
 StyleSheetRemoved: "css-manager-style-sheet-removed",
+ModifiedStylesChanged: "css-manager-modified-styles-changed",
 DefaultAppearanceDidChange: "css-manager-default-appearance-did-change",
 ForcedAppearanceDidChange: "css-manager-forced-appearance-did-change",
 };


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js (281440 => 281441)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js	2021-08-23 13:22:29 UTC (rev 281440)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js	2021-08-23 14:20:50 UTC (rev 281441)
@@ -45,11 +45,13 @@
 super.attached();
 
 WI.Frame.addEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
+WI.CSSManager.addEventListener(WI.CSSManager.Event.ModifiedStylesChanged, this.needsLayout, this);
 }
 
 detached()
 {
 WI.Frame.removeEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
+WI.CSSManager.removeEventListener(WI.CSSManager.Event.ModifiedStylesChanged, this.needsLayout, this);
 
 super.detached();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281440] trunk

[aboya]

Title: [281440] trunk








Revision 281440
Author ab...@igalia.com
Date 2021-08-23 06:22:29 -0700 (Mon, 23 Aug 2021)


Log Message
[MSE][GStreamer] Implement multi-track support
https://bugs.webkit.org/show_bug.cgi?id=229072

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

This patch adds support for SourceBuffer having more than one track in
the GStreamer port.

This fixes the following LayoutTests:

imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
media/media-source/media-source-has-audio-video.html
media/media-source/only-bcp47-language-tags-accepted-as-valid.html

* platform/graphics/gstreamer/GStreamerCommon.h:
(GstIteratorAdaptor::GstIteratorAdaptor):
(GstIteratorAdaptor::iterator::iterator):
(GstIteratorAdaptor::iterator::operator*):
(GstIteratorAdaptor::iterator::operator++):
(GstIteratorAdaptor::iterator::operator==):
(GstIteratorAdaptor::iterator::operator!=):
(GstIteratorAdaptor::begin):
(GstIteratorAdaptor::end):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
(WebCore::AppendPipeline::appsinkCapsChanged):
(WebCore::AppendPipeline::handleEndOfAppend):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::AppendPipeline::consumeAppsinksAvailableSamples):
(WebCore::AppendPipeline::resetParserState):
(WebCore::AppendPipeline::handleAppsinkNewSampleFromStreamingThread):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::generateTrackId):
(WebCore::AppendPipeline::tryCreateTrackFromPad):
(WebCore::AppendPipeline::tryMatchPadToExistingTrack):
(WebCore::AppendPipeline::linkPadWithTrack):
(WebCore::AppendPipeline::makeWebKitTrack):
(WebCore::AppendPipeline::Track::initializeElements):
(WebCore::AppendPipeline::hookTrackEvents):
(WebCore::AppendPipeline::streamTypeToString):
(WebCore::AppendPipeline::id): Deleted.
(WebCore::AppendPipeline::trackId): Deleted.
(WebCore::AppendPipeline::consumeAppsinkAvailableSamples): Deleted.
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromStreamingThread): Deleted.
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink): Deleted.
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread): Deleted.
* platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::sourceBufferPrivate):
(WebCore::AppendPipeline::Track::Track):
(WebCore::AppendPipeline::appsrc):
(WebCore::AppendPipeline::appsinkCaps): Deleted.
(WebCore::AppendPipeline::track): Deleted.
(WebCore::AppendPipeline::appsink): Deleted.
(WebCore::AppendPipeline::demuxerSrcPadCaps): Deleted.
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::setInitialVideoSize):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected): Deleted.
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

LayoutTests:

Update expectations and rebaseline one test is which the buffered
ranges have changed slightly due to the audio track previously
discarded now being parsed.

* platform/glib/TestExpectations:
* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h




Diff

Modified: trunk/LayoutTests/ChangeLog (281439 => 281440)

--- trunk/LayoutTests/ChangeLog	2021-08-23 07:11:41 UTC (rev 281439)
+++ trunk/LayoutTests/ChangeLog	2021-08-23 13:22:29 UTC (rev 281440)
@@ -1,3 +1,17 @@
+2021-08-23  Alicia Boya García  
+
+[MSE][GStreamer] Implement multi-track support
+https://bugs.webkit.org/show_bug.cgi?id=229072
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Update expectations and rebaseline one test is which the buffered
+ranges have changed slightly due to the audio track previously
+discarded now being parsed.
+
+* platform/glib/TestExpectations:
+* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
+
 2021-08-22  Yusuke Suzuki  
 
 [JSC] Remove already-shipped wasm option flags


Modified: trunk/LayoutTests/platform/glib/TestExpectations (281439 => 281440)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-08-23 07:11:41 UTC (rev 281439)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-08-23 

[webkit-changes] [281439] trunk/Source/WebCore

[carlosgc]

Title: [281439] trunk/Source/WebCore








Revision 281439
Author carlo...@webkit.org
Date 2021-08-23 00:11:41 -0700 (Mon, 23 Aug 2021)


Log Message
[Freetype] Set maximum allowed font size for Freetype
https://bugs.webkit.org/show_bug.cgi?id=228893

Reviewed by Michael Catanzaro.

Maximum allowed font size in Freetype2 is 65535 because x_ppem and y_ppem fields in FreeType structs are of type
'unsigned short'.

* rendering/style/RenderStyleConstants.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281438 => 281439)

--- trunk/Source/WebCore/ChangeLog	2021-08-23 06:28:16 UTC (rev 281438)
+++ trunk/Source/WebCore/ChangeLog	2021-08-23 07:11:41 UTC (rev 281439)
@@ -1,3 +1,15 @@
+2021-08-22  Carlos Garcia Campos  
+
+[Freetype] Set maximum allowed font size for Freetype
+https://bugs.webkit.org/show_bug.cgi?id=228893
+
+Reviewed by Michael Catanzaro.
+
+Maximum allowed font size in Freetype2 is 65535 because x_ppem and y_ppem fields in FreeType structs are of type
+'unsigned short'.
+
+* rendering/style/RenderStyleConstants.h:
+
 2021-08-22  Alan Bujtas  
 
 [LFC][IFC] Add support for vertical-align: super


Modified: trunk/Source/WebCore/rendering/style/RenderStyleConstants.h (281438 => 281439)

--- trunk/Source/WebCore/rendering/style/RenderStyleConstants.h	2021-08-23 06:28:16 UTC (rev 281438)
+++ trunk/Source/WebCore/rendering/style/RenderStyleConstants.h	2021-08-23 07:11:41 UTC (rev 281439)
@@ -1108,8 +1108,13 @@
 Fit
 };
 
+#if USE(FREETYPE)
+// Maximum allowed font size in Freetype2 is 65535 because x_ppem and y_ppem fields in FreeType structs are of type 'unsigned short'.
+static const float maximumAllowedFontSize = std::numeric_limits::max();
+#else
 // Reasonable maximum to prevent insane font sizes from causing crashes on some platforms (such as Windows).
 static const float maximumAllowedFontSize = 100.0f;
+#endif
 
 enum class TextIndentLine : uint8_t {
 FirstLine,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281438] trunk

[ysuzuki]

Title: [281438] trunk








Revision 281438
Author ysuz...@apple.com
Date 2021-08-22 23:28:16 -0700 (Sun, 22 Aug 2021)


Log Message
[JSC] Remove already-shipped wasm option flags
https://bugs.webkit.org/show_bug.cgi?id=229386

Reviewed by Ross Kirsling.

JSTests:

* wasm/references/element_active_mod.js:
* wasm/references/element_parsing.js:
* wasm/references/externref_globals.js:
* wasm/references/externref_modules.js:
* wasm/references/externref_table.js:
* wasm/references/externref_table_import.js:
* wasm/references/func_ref.js:
* wasm/references/globals.js:
* wasm/references/is_null.js:
* wasm/references/memory_copy.js:
* wasm/references/memory_copy_shared.js:
* wasm/references/memory_fill_shared.js:
* wasm/references/multitable.js:
* wasm/references/parse_unreachable.js:
* wasm/references/table_js_api.js:
* wasm/references/table_misc.js:
* wasm/references/validation.js:
* wasm/stress/immutable-globals.js:
* wasm/stress/local-ref.js:
* wasm/stress/mutable-globals.js:
* wasm/stress/table-grow-table-size.js:

Source/_javascript_Core:

This patch removes some wasm option flags which are already shipped.

* runtime/OptionsList.h:
* wasm/WasmFormat.h:
(JSC::Wasm::isValueType):
* wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::parseExpression):
(JSC::Wasm::FunctionParser::parseUnreachableExpression):
* wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
* wasm/WasmParser.h:
(JSC::Wasm::Parser::parseBlockSignature):
* wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseType):
(JSC::Wasm::SectionParser::parseElement):
(JSC::Wasm::SectionParser::parseData):
(JSC::Wasm::SectionParser::parseDataCount):
* wasm/js/JSWebAssembly.cpp:
(JSC::JSWebAssembly::finishCreation):
* wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* wasm/js/WebAssemblyTableConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Tools:

* Scripts/run-jsc-stress-tests:

LayoutTests:

* workers/wasm-references.html:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/references/element_active_mod.js
trunk/JSTests/wasm/references/element_parsing.js
trunk/JSTests/wasm/references/externref_globals.js
trunk/JSTests/wasm/references/externref_modules.js
trunk/JSTests/wasm/references/externref_table.js
trunk/JSTests/wasm/references/externref_table_import.js
trunk/JSTests/wasm/references/func_ref.js
trunk/JSTests/wasm/references/globals.js
trunk/JSTests/wasm/references/is_null.js
trunk/JSTests/wasm/references/memory_copy.js
trunk/JSTests/wasm/references/memory_copy_shared.js
trunk/JSTests/wasm/references/memory_fill_shared.js
trunk/JSTests/wasm/references/multitable.js
trunk/JSTests/wasm/references/parse_unreachable.js
trunk/JSTests/wasm/references/table_js_api.js
trunk/JSTests/wasm/references/table_misc.js
trunk/JSTests/wasm/references/validation.js
trunk/JSTests/wasm/spec-tests/data.wast.js
trunk/JSTests/wasm/stress/immutable-globals.js
trunk/JSTests/wasm/stress/local-ref.js
trunk/JSTests/wasm/stress/mutable-globals.js
trunk/JSTests/wasm/stress/table-grow-table-size.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/workers/wasm-references.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/OptionsList.h
trunk/Source/_javascript_Core/wasm/WasmFormat.h
trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h
trunk/Source/_javascript_Core/wasm/WasmOperations.cpp
trunk/Source/_javascript_Core/wasm/WasmParser.h
trunk/Source/_javascript_Core/wasm/WasmSectionParser.cpp
trunk/Source/_javascript_Core/wasm/js/JSWebAssembly.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyGlobalConstructor.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyTableConstructor.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyTablePrototype.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/JSTests/ChangeLog (281437 => 281438)

--- trunk/JSTests/ChangeLog	2021-08-23 06:22:37 UTC (rev 281437)
+++ trunk/JSTests/ChangeLog	2021-08-23 06:28:16 UTC (rev 281438)
@@ -1,5 +1,34 @@
 2021-08-22  Yusuke Suzuki  
 
+[JSC] Remove already-shipped wasm option flags
+https://bugs.webkit.org/show_bug.cgi?id=229386
+
+Reviewed by Ross Kirsling.
+
+* wasm/references/element_active_mod.js:
+* wasm/references/element_parsing.js:
+* wasm/references/externref_globals.js:
+* wasm/references/externref_modules.js:
+* wasm/references/externref_table.js:
+* wasm/references/externref_table_import.js:
+* wasm/references/func_ref.js:
+* wasm/references/globals.js:
+* wasm/references/is_null.js:
+* wasm/references/memory_copy.js:
+* wasm/references/memory_copy_shared.js:
+* wasm/references/memory_fill_shared.js:
+* wasm/references/multitable.js:
+* wasm/references/parse_unreachable.js:
+* wasm/references/table_js_api.js:
+* wasm/references/table_misc.js:
+ 

[webkit-changes] [281437] tags/Safari-612.1.27.3.7/

[bshafiei]

Title: [281437] tags/Safari-612.1.27.3.7/








Revision 281437
Author bshaf...@apple.com
Date 2021-08-22 23:22:37 -0700 (Sun, 22 Aug 2021)


Log Message
Tag Safari-612.1.27.3.7.

Added Paths

tags/Safari-612.1.27.3.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281436] branches/safari-612.1.27.3-branch/Source/JavaScriptCore

[bshafiei]

Title: [281436] branches/safari-612.1.27.3-branch/Source/_javascript_Core








Revision 281436
Author bshaf...@apple.com
Date 2021-08-22 23:17:56 -0700 (Sun, 22 Aug 2021)


Log Message
Apply patch. rdar://problem/82196634

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog (281435 => 281436)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-23 05:46:11 UTC (rev 281435)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-23 06:17:56 UTC (rev 281436)
@@ -1,3 +1,16 @@
+2021-08-22  Russell Epstein  
+
+Apply patch. rdar://problem/82196634
+
+2021-08-22  Mark Lam  
+
+Build fix for bad cherry-pick of r281178.
+rdar://problem/82083485
+
+Not reviewed.
+
+* b3/testb3_3.cpp:
+
 2021-08-20  Russell Epstein  
 
 Cherry-pick r281178. rdar://problem/82083485


Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp (281435 => 281436)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-23 05:46:11 UTC (rev 281435)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-23 06:17:56 UTC (rev 281436)
@@ -3993,10 +3993,10 @@
 RUN(testZShrArgImm32(0x, 63));
 
 if (Options::useB3CanonicalizePrePostIncrements()) {
-RUN(testStorePreIndex32());
-RUN(testStorePreIndex64());
-RUN(testStorePostIndex32());
-RUN(testStorePostIndex64());
+RUN(testLoadPreIndex32());
+RUN(testLoadPreIndex64());
+RUN(testLoadPostIndex32());
+RUN(testLoadPostIndex64());
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes