[webkit-changes] [293880] trunk/Source/WebCore

[simon . fraser]

Title: [293880] trunk/Source/WebCore








Revision 293880
Author simon.fra...@apple.com
Date 2022-05-05 21:10:27 -0700 (Thu, 05 May 2022)


Log Message
Reduce the number of calls to canContainFixedPositionObjects()
https://bugs.webkit.org/show_bug.cgi?id=240150

Reviewed by Alan Bujtas.

canContainFixedPositionObjects() isn't super cheap, so only call it when we need to remove
the IsFixed bit.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer const):
(WebCore::RenderBox::mapAbsoluteToLocalPoint const):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293879 => 293880)

--- trunk/Source/WebCore/ChangeLog	2022-05-06 02:34:31 UTC (rev 293879)
+++ trunk/Source/WebCore/ChangeLog	2022-05-06 04:10:27 UTC (rev 293880)
@@ -1,3 +1,19 @@
+2022-05-05  Simon Fraser  
+
+Reduce the number of calls to canContainFixedPositionObjects()
+https://bugs.webkit.org/show_bug.cgi?id=240150
+
+Reviewed by Alan Bujtas.
+
+canContainFixedPositionObjects() isn't super cheap, so only call it when we need to remove
+the IsFixed bit.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::mapLocalToContainer const):
+(WebCore::RenderBox::mapAbsoluteToLocalPoint const):
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::mapLocalToContainer const):
+
 2022-05-05  Chris Dumez  
 
 Identifier::string() should return an AtomString


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (293879 => 293880)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2022-05-06 02:34:31 UTC (rev 293879)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2022-05-06 04:10:27 UTC (rev 293880)
@@ -2322,7 +2322,7 @@
 // and may itself also be fixed position. So propagate 'fixed' up only if this box is fixed position.
 if (isFixedPos)
 mode.add(IsFixed);
-else if (canContainFixedPositionObjects())
+else if (mode.contains(IsFixed) && canContainFixedPositionObjects())
 mode.remove(IsFixed);
 
 if (wasFixed)
@@ -2396,7 +2396,7 @@
 bool isFixedPos = isFixedPositioned();
 if (isFixedPos)
 mode.add(IsFixed);
-else if (canContainFixedPositionObjects()) {
+else if (mode.contains(IsFixed) && canContainFixedPositionObjects()) {
 // If this box has a transform, it acts as a fixed position container for fixed descendants,
 // and may itself also be fixed position. So propagate 'fixed' up only if this box is fixed position.
 mode.remove(IsFixed);


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (293879 => 293880)

--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp	2022-05-06 02:34:31 UTC (rev 293879)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp	2022-05-06 04:10:27 UTC (rev 293880)
@@ -519,7 +519,7 @@
 // and may itself also be fixed position. So propagate 'fixed' up only if this box is fixed position.
 if (isFixedPos)
 mode.add(IsFixed);
-else if (canContainFixedPositionObjects())
+else if (mode.contains(IsFixed) && canContainFixedPositionObjects())
 mode.remove(IsFixed);
 
 if (wasFixed)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293879] trunk/Source

[cdumez]

Title: [293879] trunk/Source








Revision 293879
Author cdu...@apple.com
Date 2022-05-05 19:34:31 -0700 (Thu, 05 May 2022)


Log Message
Identifier::string() should return an AtomString
https://bugs.webkit.org/show_bug.cgi?id=240122

Reviewed by Yusuke Suzuki.

Identifier::string() should return an AtomString instead of a String, since
it holds an AtomString internally.

Also add some overloads to jsString() to resolve ambiguity for some callers.

* Source/_javascript_Core/API/JSContext.mm:
(-[JSContext dependencyIdentifiersForModuleJSScript:]):
* Source/_javascript_Core/bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
* Source/_javascript_Core/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/_javascript_Core/inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::functionDetails):
* Source/_javascript_Core/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
* Source/_javascript_Core/runtime/Error.cpp:
(JSC::addErrorInfo):
* Source/_javascript_Core/runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::finishCreation):
* Source/_javascript_Core/runtime/ErrorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/_javascript_Core/runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::toStringSlow):
* Source/_javascript_Core/runtime/Identifier.h:
(JSC::Identifier::string const):
(JSC::Identifier::atomString const): Deleted.
* Source/_javascript_Core/runtime/IdentifierInlines.h:
(JSC::identifierToJSValue):
(JSC::identifierToSafePublicJSValue):
* Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::format const):
(JSC::IntlDateTimeFormat::formatRange):
* Source/_javascript_Core/runtime/IntlDisplayNames.cpp:
(JSC::IntlDisplayNames::of const):
* Source/_javascript_Core/runtime/IntlListFormat.cpp:
(JSC::IntlListFormat::format const):
* Source/_javascript_Core/runtime/IntlRelativeTimeFormat.cpp:
(JSC::IntlRelativeTimeFormat::format const):
* Source/_javascript_Core/runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
* Source/_javascript_Core/runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::requestImportModule):
* Source/_javascript_Core/runtime/JSString.h:
(JSC::jsString):
* Source/_javascript_Core/runtime/JSStringInlines.h:
(JSC::repeatCharacter):
* Source/_javascript_Core/runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::toLocaleCase):
(JSC::normalize):
* Source/_javascript_Core/runtime/SymbolPrototype.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
* Source/WTF/wtf/PrintStream.cpp:
(WTF::printInternal):
* Source/WTF/wtf/PrintStream.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::processKeyframeLikeObject):
* Source/WebCore/inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::getInternalProperties):

Canonical link: https://commits.webkit.org/250337@main

Modified Paths

trunk/Source/_javascript_Core/API/JSContext.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/inspector/JSInjectedScriptHost.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/Error.cpp
trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp
trunk/Source/_javascript_Core/runtime/ErrorPrototype.cpp
trunk/Source/_javascript_Core/runtime/FunctionExecutable.cpp
trunk/Source/_javascript_Core/runtime/Identifier.h
trunk/Source/_javascript_Core/runtime/IdentifierInlines.h
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlDisplayNames.cpp
trunk/Source/_javascript_Core/runtime/IntlListFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlRelativeTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSModuleLoader.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/JSStringInlines.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/_javascript_Core/runtime/SymbolPrototype.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PrintStream.cpp
trunk/Source/WTF/wtf/PrintStream.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/inspector/WebInjectedScriptHost.cpp




Diff

Modified: trunk/Source/_javascript_Core/API/JSContext.mm (293878 => 293879)

--- trunk/Source/_javascript_Core/API/JSContext.mm	2022-05-06 02:23:22 UTC (rev 293878)
+++ trunk/Source/_javascript_Core/API/JSContext.mm	2022-05-06 02:34:31 UTC (rev 293879)
@@ -159,7 +159,7 @@
 }
 
 auto scope = DECLARE_CATCH_SCOPE(vm);
-JSC::JSArray* result = globalObject->moduleLoader()->dependencyKeysIfEvaluated(globalObject, JSC::jsString(vm, [[script sourceURL] absoluteString]));
+JSC::JSArray* result = globalObject->moduleLoader()->dependencyKeysIfEvaluated(globalObject, JSC::jsString(vm, String([[script sourceURL] absoluteString])));
 if (scope.exception()) {
 JSValueRef 

[webkit-changes] [293878] trunk

[jer . noble]

Title: [293878] trunk








Revision 293878
Author jer.no...@apple.com
Date 2022-05-05 19:23:22 -0700 (Thu, 05 May 2022)


Log Message
Removing x-webkit-wirelessvideoplaybackdisabled attribute from video does not enable AirPlay.
https://bugs.webkit.org/show_bug.cgi?id=239031

Reviewed by Jer Noble.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::setWirelessVideoPlaybackDisabled):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setWirelessVideoPlaybackDisabled):
Test: media/airplay-wirelessvideoplaybackdisabled.html
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute):
* LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt: Added.
* LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html: Added.

Canonical link: https://commits.webkit.org/250336@main

Modified Paths

trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp


Added Paths

trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt
trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html




Diff

Added: trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt (0 => 293878)

--- trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt	2022-05-06 02:23:22 UTC (rev 293878)
@@ -0,0 +1,19 @@
+
+Test that 'wirelessvideoplaybackdisabled' attribute is set correctly after removing the 'x-webkit-wirelessvideoplaybackdisabled' attribute.
+
+Test a video element without a source.
+EXPECTED (video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled") == 'true') OK
+EXPECTED (video.webkitWirelessVideoPlaybackDisabled == 'true') OK
+RUN(video.removeAttribute("x-webkit-wirelessvideoplaybackdisabled"))
+EXPECTED (video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled") == 'false') OK
+EXPECTED (video.webkitWirelessVideoPlaybackDisabled == 'true') OK
+Test a video element with a source.
+EVENT(canplaythrough)
+RUN(video.setAttribute("x-webkit-wirelessvideoplaybackdisabled", ""))
+EXPECTED (video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled") == 'true') OK
+EXPECTED (video.webkitWirelessVideoPlaybackDisabled == 'true') OK
+RUN(video.removeAttribute("x-webkit-wirelessvideoplaybackdisabled"))
+EXPECTED (video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled") == 'false') OK
+EXPECTED (video.webkitWirelessVideoPlaybackDisabled == 'false') OK
+END OF TEST
+


Added: trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html (0 => 293878)

--- trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html	(rev 0)
+++ trunk/LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html	2022-05-06 02:23:22 UTC (rev 293878)
@@ -0,0 +1,53 @@
+
+
+
+
+
+
+async function start()
+{
+findMediaElement();
+
+consoleWrite('Test a video element without a source.');
+
+testExpected('video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled")', true);
+testExpected('video.webkitWirelessVideoPlaybackDisabled', true);
+
+
+run('video.removeAttribute("x-webkit-wirelessvideoplaybackdisabled")');
+
+testExpected('video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled")', false);
+testExpected('video.webkitWirelessVideoPlaybackDisabled', true);
+
+
+consoleWrite('Test a video element with a source.');
+
+video.src = "" 'content/test');
+
+await waitFor(video, 'canplaythrough');
+
+run('video.setAttribute("x-webkit-wirelessvideoplaybackdisabled", "")');
+
+
+testExpected('video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled")', true);
+testExpected('video.webkitWirelessVideoPlaybackDisabled', true);
+
+
+run('video.removeAttribute("x-webkit-wirelessvideoplaybackdisabled")');
+
+testExpected('video.hasAttribute("x-webkit-wirelessvideoplaybackdisabled")', false);
+testExpected('video.webkitWirelessVideoPlaybackDisabled', false);
+
+
+endTest();
+}
+
+
+
+
+
+
+

[webkit-changes] [293876] trunk/LayoutTests

[rackler]

Title: [293876] trunk/LayoutTests








Revision 293876
Author rack...@apple.com
Date 2022-05-05 17:59:01 -0700 (Thu, 05 May 2022)


Log Message
[ iOS ] fast/images/exif-orientation-background-image-repeat.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240148

Unreviewed test gardening.

Canonical link: https://commits.webkit.org/250334@main

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (293875 => 293876)

--- trunk/LayoutTests/ChangeLog	2022-05-06 00:49:04 UTC (rev 293875)
+++ trunk/LayoutTests/ChangeLog	2022-05-06 00:59:01 UTC (rev 293876)
@@ -1,3 +1,12 @@
+2022-05-05  Karl Rackler  
+
+[ iOS ] fast/images/exif-orientation-background-image-repeat.html is a consistent image failure
+https://bugs.webkit.org/show_bug.cgi?id=240148
+
+Unreviewed test gardening. 
+
+* platform/ios/TestExpectations:
+
 2022-05-05  Manuel Rego Casasnovas  
 
 ARIA reflection for Element attributes


Modified: trunk/LayoutTests/platform/ios/TestExpectations (293875 => 293876)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-05-06 00:49:04 UTC (rev 293875)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-05-06 00:59:01 UTC (rev 293876)
@@ -3451,7 +3451,6 @@
 
 # webkit.org/b/201982 These are flaky failures on iOS
 fast/images/exif-orientation-svg-feimage.html [ Pass Failure ]
-fast/images/exif-orientation-background-image-repeat.html [ Pass Failure ]
 fast/images/image-orientation-dynamic-from-image.html [ Pass Failure ]
 fast/images/image-orientation-none.html [ Pass Failure ]
 
@@ -3609,3 +3608,6 @@
 webkit.org/b/240123 imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html [ Pass Failure ]
 
 webkit.org/b/239568 imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html [ Pass Failure ]
+
+webkit.org/b/240148 fast/images/exif-orientation-background-image-repeat.html [ Pass Failure ImageOnlyFailure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293875] trunk/Tools

[jbedard]

Title: [293875] trunk/Tools








Revision 293875
Author jbed...@apple.com
Date 2022-05-05 17:49:04 -0700 (Thu, 05 May 2022)


Log Message
[git-webkit] Automatically file bug
https://bugs.webkit.org/show_bug.cgi?id=240139


Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): If a project has defined bug trackers and the user provides a bug title instead of a bug
url or branch name (determined by spaces in the provided string), walk the user through bug creation.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch): Add mock issues, rebase prompts.
(TestBranch.test_create_bug): Added.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
(TestRevert.test_github): Add mock issues, rebase prompts.
(TestRevert.test_modified): Ditto.

Canonical link: https://commits.webkit.org/250333@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (293874 => 293875)

--- trunk/Tools/ChangeLog	2022-05-06 00:24:01 UTC (rev 293874)
+++ trunk/Tools/ChangeLog	2022-05-06 00:49:04 UTC (rev 293875)
@@ -1,3 +1,24 @@
+2022-05-05  Jonathan Bedard  
+
+[git-webkit] Automatically file bug
+https://bugs.webkit.org/show_bug.cgi?id=240139
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
+(Branch.main): If a project has defined bug trackers and the user provides a bug title instead of a bug
+url or branch name (determined by spaces in the provided string), walk the user through bug creation.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
+(TestBranch): Add mock issues, rebase prompts.
+(TestBranch.test_create_bug): Added.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
+(TestRevert.test_github): Add mock issues, rebase prompts.
+(TestRevert.test_modified): Ditto.
+
 2022-05-05  Sihui Liu  
 
 SuspendableWorkQueue::suspend should invoke callback immediately when queue is suspended


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (293874 => 293875)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-06 00:24:01 UTC (rev 293874)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-06 00:49:04 UTC (rev 293875)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='4.12.4',
+version='4.13.0',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (293874 => 293875)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-06 00:24:01 UTC (rev 293874)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-06 00:49:04 UTC (rev 293875)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(4, 12, 4)
+version = Version(4, 13, 0)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py (293874 => 293875)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py	2022-05-06 00:24:01 UTC (rev 293874)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py	2022-05-06 00:49:04 UTC (rev 293875)
@@ -98,7 +98,11 @@
 return 1
 
 if not args.issue:
-args.issue = Terminal.input('{}nter name of new branch (or bug URL): '.format('{}, e'.format(why) if why else 'E'))
+if Tracker.instance():
+prompt = '{}nter issue URL or title of new issue: '.format('{}, e'.format(why) if why else 'E')
+else:
+prompt = '{}nter name of new branch (or issue URL): '.format('{}, e'.format(why) if why else 'E')
+args.issue = Terminal.input(prompt)
 
 if 

[webkit-changes] [293874] tags/WebKit-7613.3.1/

[alancoon]

Title: [293874] tags/WebKit-7613.3.1/








Revision 293874
Author alanc...@apple.com
Date 2022-05-05 17:24:01 -0700 (Thu, 05 May 2022)


Log Message
Tag WebKit-7613.3.1.

Added Paths

tags/WebKit-7613.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293873] trunk

[pvollan]

Title: [293873] trunk








Revision 293873
Author pvol...@apple.com
Date 2022-05-05 17:12:45 -0700 (Thu, 05 May 2022)


Log Message
Add GitHub user name
https://bugs.webkit.org/show_bug.cgi?id=240144

Unreviewed, add github user name to contributors.json.


* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (293872 => 293873)

--- trunk/ChangeLog	2022-05-06 00:03:51 UTC (rev 293872)
+++ trunk/ChangeLog	2022-05-06 00:12:45 UTC (rev 293873)
@@ -1,3 +1,12 @@
+2022-05-05  Per Arne Vollan  
+
+Add GitHub user name
+https://bugs.webkit.org/show_bug.cgi?id=240144
+
+Unreviewed, add github user name to contributors.json.
+
+* metadata/contributors.json:
+
 2022-05-05  Megan Gardner  
 
 Add github info for myself to contributors.json


Modified: trunk/metadata/contributors.json (293872 => 293873)

--- trunk/metadata/contributors.json	2022-05-06 00:03:51 UTC (rev 293872)
+++ trunk/metadata/contributors.json	2022-05-06 00:12:45 UTC (rev 293873)
@@ -5379,6 +5379,7 @@
  "pvol...@apple.com",
  "pe...@outlook.com"
   ],
+  "github" : "pvollan",
   "name" : "Per Arne Vollan",
   "nicks" : [
  "peavo"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293872] tags/WebKit-7614.1.11.7/

[alancoon]

Title: [293872] tags/WebKit-7614.1.11.7/








Revision 293872
Author alanc...@apple.com
Date 2022-05-05 17:03:51 -0700 (Thu, 05 May 2022)


Log Message
Tag WebKit-7614.1.11.7.

Added Paths

tags/WebKit-7614.1.11.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293871] branches/safari-614.1.11-branch/Source

[alancoon]

Title: [293871] branches/safari-614.1.11-branch/Source








Revision 293871
Author alanc...@apple.com
Date 2022-05-05 17:01:06 -0700 (Thu, 05 May 2022)


Log Message
Versioning.

WebKit-7614.1.11.7

Modified Paths

branches/safari-614.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-614.1.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-614.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/WebCore/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (293870 => 293871)

--- branches/safari-614.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-05-05 23:50:17 UTC (rev 293870)
+++ branches/safari-614.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-05-06 00:01:06 UTC (rev 293871)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;

[webkit-changes] [293870] trunk/Source/WebCore

[nmouchtaris]

Title: [293870] trunk/Source/WebCore








Revision 293870
Author nmouchta...@apple.com
Date 2022-05-05 16:50:17 -0700 (Thu, 05 May 2022)


Log Message
Add check if referenced element is SVG for clip-path
https://bugs.webkit.org/show_bug.cgi?id=240096

Reviewed by Simon Fraser.

Add check when creating new ReferencePathOperation that it is referencing
an svg element.

* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/style/StyleBuilderConverter.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (293869 => 293870)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 23:43:45 UTC (rev 293869)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 23:50:17 UTC (rev 293870)
@@ -1,3 +1,16 @@
+2022-05-05  Nikolaos Mouchtaris  
+
+Add check if referenced element is SVG for clip-path
+https://bugs.webkit.org/show_bug.cgi?id=240096
+
+Reviewed by Simon Fraser.
+
+Add check when creating new ReferencePathOperation that it is referencing
+an svg element.
+
+* style/StyleBuilderConverter.h:
+(WebCore::Style::BuilderConverter::convertPathOperation):
+
 2022-05-05  Cameron McCormack  
 
 Avoid using WebCore::Colors created with out-of-line components in DrawGlyphsRecorder


Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (293869 => 293870)

--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2022-05-05 23:43:45 UTC (rev 293869)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2022-05-05 23:50:17 UTC (rev 293870)
@@ -1527,7 +1527,7 @@
 case PathOperation::Shape:
 return downcast(operation).pathForReferenceRect(box);
 case PathOperation::Reference:
-if (!is(downcast(operation).element()) && !is(downcast(operation).element()))
+if (!downcast(operation).element() || (!is(downcast(operation).element()) && !is(downcast(operation).element(
 return std::nullopt;
 return pathFromGraphicsElement(downcast(operation).element());
 case PathOperation::Box:


Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (293869 => 293870)

--- trunk/Source/WebCore/style/StyleBuilderConverter.h	2022-05-05 23:43:45 UTC (rev 293869)
+++ trunk/Source/WebCore/style/StyleBuilderConverter.h	2022-05-05 23:50:17 UTC (rev 293870)
@@ -629,7 +629,9 @@
 auto fragment = SVGURIReference::fragmentIdentifierFromIRIString(cssURLValue, builderState.document());
 // FIXME: It doesn't work with external SVG references (see https://bugs.webkit.org/show_bug.cgi?id=126133)
 auto target = SVGURIReference::targetElementFromIRIString(cssURLValue, builderState.document());
-return ReferencePathOperation::create(cssURLValue, fragment, downcast(target.element.get()));
+if (is(target.element.get()))
+return ReferencePathOperation::create(cssURLValue, fragment, downcast(target.element.get()));
+return ReferencePathOperation::create(cssURLValue, fragment, nullptr);
 }
 ASSERT(primitiveValue.valueID() == CSSValueNone);
 return nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293869] trunk/JSTests

[keith_miller]

Title: [293869] trunk/JSTests








Revision 293869
Author keith_mil...@apple.com
Date 2022-05-05 16:43:45 -0700 (Thu, 05 May 2022)


Log Message
Rebaseline icu tests to public sdk's icu
https://bugs.webkit.org/show_bug.cgi?id=240142

Reviewed by Yusuke Suzuki.

* test262/expectations.yaml:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml




Diff

Modified: trunk/JSTests/ChangeLog (293868 => 293869)

--- trunk/JSTests/ChangeLog	2022-05-05 23:28:27 UTC (rev 293868)
+++ trunk/JSTests/ChangeLog	2022-05-05 23:43:45 UTC (rev 293869)
@@ -1,3 +1,12 @@
+2022-05-05  Keith Miller  
+
+Rebaseline icu tests to public sdk's icu
+https://bugs.webkit.org/show_bug.cgi?id=240142
+
+Reviewed by Yusuke Suzuki.
+
+* test262/expectations.yaml:
+
 2022-05-04  Yusuke Suzuki  
 
 [JSC] Intl.NumberFormat lacks some validation for rounding-increment


Modified: trunk/JSTests/test262/expectations.yaml (293868 => 293869)

--- trunk/JSTests/test262/expectations.yaml	2022-05-05 23:28:27 UTC (rev 293868)
+++ trunk/JSTests/test262/expectations.yaml	2022-05-05 23:43:45 UTC (rev 293869)
@@ -1344,9 +1344,27 @@
 test/intl402/Intl/getCanonicalLocales/non-iana-canon.js:
   default: 'Test262Error: The value of Intl.getCanonicalLocales(tag)[0] equals the value of `canonical` Expected SameValue(«en-US-u-va-posix», «posix») to be true'
   strict mode: 'Test262Error: The value of Intl.getCanonicalLocales(tag)[0] equals the value of `canonical` Expected SameValue(«en-US-u-va-posix», «posix») to be true'
+test/intl402/Intl/getCanonicalLocales/preferred-grandfathered.js:
+  default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
+test/intl402/Intl/getCanonicalLocales/transformed-ext-canonical.js:
+  default: 'Test262Error: Expected SameValue(«sl-t-sl-rozaj-biske-1994», «sl-t-sl-1994-biske-rozaj») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«sl-t-sl-rozaj-biske-1994», «sl-t-sl-1994-biske-rozaj») to be true'
+test/intl402/Intl/getCanonicalLocales/unicode-ext-canonicalize-region.js:
+  default: 'Test262Error: Expected SameValue(«und-u-rg-no23», «und-u-rg-no50») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«und-u-rg-no23», «und-u-rg-no50») to be true'
+test/intl402/Intl/getCanonicalLocales/unicode-ext-canonicalize-subdivision.js:
+  default: 'Test262Error: Expected SameValue(«und-NO-u-sd-no23», «und-NO-u-sd-no50») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«und-NO-u-sd-no23», «und-NO-u-sd-no50») to be true'
 test/intl402/Locale/extensions-grandfathered.js:
   default: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true'
   strict mode: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true'
+test/intl402/Locale/getters-grandfathered.js:
+  default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
+test/intl402/Locale/likely-subtags-grandfathered.js:
+  default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true'
 test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js:
   default: 'Test262Error: "und".minimize() should be "en" Expected SameValue(«en-u-va-posix», «en») to be true'
   strict mode: 'Test262Error: "und".minimize() should be "en" Expected SameValue(«en-u-va-posix», «en») to be true'
@@ -1362,6 +1380,78 @@
 test/intl402/NumberFormat/prototype/format/value-decimal-string.js:
   default: 'Test262Error: Expected SameValue(«1», «1.0001») to be true'
   strict mode: 'Test262Error: Expected SameValue(«1», «1.0001») to be true'
+test/intl402/NumberFormat/prototype/formatRange/builtin.js:
+  default: 'Test262Error: The [[Class]] internal property of a built-in function must be "Function". Expected SameValue(«[object Undefined]», «[object Function]») to be true'
+  strict mode: 'Test262Error: The [[Class]] internal property of a built-in function must be "Function". Expected SameValue(«[object Undefined]», «[object Function]») to be true'
+test/intl402/NumberFormat/prototype/formatRange/en-US.js:
+  default: "TypeError: nf.formatRange is not a function. (In 'nf.formatRange(3, 5)', 'nf.formatRange' is undefined)"
+  strict mode: "TypeError: nf.formatRange is not a function. (In 'nf.formatRange(3, 5)', 'nf.formatRange' is undefined)"
+test/intl402/NumberFormat/prototype/formatRange/invoked-as-func.js:
+  default: 'Test262Error: Expected SameValue(«undefined», «function») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«undefined», «function») to be true'
+test/intl402/NumberFormat/prototype/formatRange/length.js:
+  default: "TypeError: undefined is not an 

[webkit-changes] [293868] branches/safari-613-branch/Source

[alancoon]

Title: [293868] branches/safari-613-branch/Source








Revision 293868
Author alanc...@apple.com
Date 2022-05-05 16:28:27 -0700 (Thu, 05 May 2022)


Log Message
Versioning.

WebKit-7613.3.1

Modified Paths

branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig (293867 => 293868)

--- branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-05 23:15:31 UTC (rev 293867)
+++ branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-05 23:28:27 UTC (rev 293868)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 2;
-TINY_VERSION = 7;
+MINOR_VERSION = 3;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (293867 => 293868)

--- 

[webkit-changes] [293867] trunk/Source/WebCore

[heycam]

Title: [293867] trunk/Source/WebCore








Revision 293867
Author hey...@apple.com
Date 2022-05-05 16:15:31 -0700 (Thu, 05 May 2022)


Log Message
Avoid using WebCore::Colors created with out-of-line components in DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=235604
rdar://88345680

Reviewed by Simon Fraser.

Source/WebCore:

In DrawGlyphsRecorder::recordDrawGlyphs we interrogate the CGContext's
state to find out the current fill and stroke color. This needed to
record color font glyphs correctly. When we're not using a color font,
the CGColors for the fill and stroke will be the same as we set them
in prepareInternalContext.

Those CGColors we create in prepareInternalContext from the
WebCore::Colors (created by calling cachedCGColor) don't record the
exact form the original colors had. CGColors only expose float
components, so Color::createAndPreserveColorSpace conservatively
creates a Color with out-of-line components to store those float
values, even if the original Color the CGColor was created from had
uint8_t components.

Color::operator== treats colors of different forms as being different,
which means we generate additional, unnecessary SetState display list
items changing say the fill color from Color(255, 255, 255) (inline) to
Color(1.0, 1.0, 1.0) (out of line).

We can avoid this by checking whether the context state's fill and
stroke CGColors are the same object as the ones we set in
prepareInternalContext, and if so, set the current fill/stroke brush
based on m_originalState.fillBrush/strokeBrush. In the common case of
a non-color glyph, this brush change will be detected as the same as
the current value, and the SetState item generation will be avoided.

This improves the MotionMark design subtest by 2.4%, and the overall
score by 0.7%, when GPUP DOM rendering is enabled.

* platform/graphics/DrawGlyphsRecorder.h:
* platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::recordInitialColors):
(WebCore::DrawGlyphsRecorder::prepareInternalContext):
(WebCore::DrawGlyphsRecorder::updateFillColor):
(WebCore::DrawGlyphsRecorder::updateStrokeColor):

Source/WebCore/PAL:

* pal/spi/cg/CoreGraphicsSPI.h: Add CGContextGetStrokeColorAsColor.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h
trunk/Source/WebCore/platform/graphics/DrawGlyphsRecorder.h
trunk/Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293866 => 293867)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 23:11:30 UTC (rev 293866)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 23:15:31 UTC (rev 293867)
@@ -1,3 +1,47 @@
+2022-05-05  Cameron McCormack  
+
+Avoid using WebCore::Colors created with out-of-line components in DrawGlyphsRecorder
+https://bugs.webkit.org/show_bug.cgi?id=235604
+rdar://88345680
+
+Reviewed by Simon Fraser.
+
+In DrawGlyphsRecorder::recordDrawGlyphs we interrogate the CGContext's
+state to find out the current fill and stroke color. This needed to
+record color font glyphs correctly. When we're not using a color font,
+the CGColors for the fill and stroke will be the same as we set them
+in prepareInternalContext.
+
+Those CGColors we create in prepareInternalContext from the
+WebCore::Colors (created by calling cachedCGColor) don't record the
+exact form the original colors had. CGColors only expose float
+components, so Color::createAndPreserveColorSpace conservatively
+creates a Color with out-of-line components to store those float
+values, even if the original Color the CGColor was created from had
+uint8_t components.
+
+Color::operator== treats colors of different forms as being different,
+which means we generate additional, unnecessary SetState display list
+items changing say the fill color from Color(255, 255, 255) (inline) to
+Color(1.0, 1.0, 1.0) (out of line).
+
+We can avoid this by checking whether the context state's fill and
+stroke CGColors are the same object as the ones we set in
+prepareInternalContext, and if so, set the current fill/stroke brush
+based on m_originalState.fillBrush/strokeBrush. In the common case of
+a non-color glyph, this brush change will be detected as the same as
+the current value, and the SetState item generation will be avoided.
+
+This improves the MotionMark design subtest by 2.4%, and the overall
+score by 0.7%, when GPUP DOM rendering is enabled.
+
+* platform/graphics/DrawGlyphsRecorder.h:
+* platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
+(WebCore::DrawGlyphsRecorder::recordInitialColors):
+(WebCore::DrawGlyphsRecorder::prepareInternalContext):
+

[webkit-changes] [293865] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [293865] branches/safari-613-branch/Source/WebKit








Revision 293865
Author alanc...@apple.com
Date 2022-05-05 16:11:24 -0700 (Thu, 05 May 2022)


Log Message
Revert r293851. rdar://problem/88904160

This reverts a patch application at r293851.

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (293864 => 293865)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 23:10:18 UTC (rev 293864)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 23:11:24 UTC (rev 293865)
@@ -4,63 +4,6 @@
 
 2022-04-22  Kimmo Kinnunen  
 
-Multiple concurrency violations in LibWebRTCCodecsProxy
-https://bugs.webkit.org/show_bug.cgi?id=236767
-
-
-Reviewed by Antti Koivisto.
-
-- ThreadMessageReceivers should not add IPC listeners in constructors,
-as the delivery starts right away and uses the unconstructed virtual pointer.
-- The work queue functions should not use GPUConnectionToWebProcess, as that is
-main thread object.
-- Locked m_encoders, m_decoders are sometimes accessed without lock.
-
-Instead:
-- Add the IPC listeners in initialize function.
-- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
-- Store the thread-safe conection, video frame object heap, process identity
-objects as member variables.
-- Do not lock m_encoders, m_decoders. If they are work queue instances,
-just access them in the work queue functions. Add thread requirements
-to the variables so that the compiler checks the access.
-- Use IPC testing assertions when skipping incorrect messages.
-- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
-
-No new tests, tested with existing tests and ASAN.
-
-* GPUProcess/GPUConnectionToWebProcess.cpp:
-(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
-(WebKit::GPUConnectionToWebProcess::didClose):
-* GPUProcess/GPUConnectionToWebProcess.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
-(WebKit::LibWebRTCCodecsProxy::create):
-(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
-(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
-(WebKit::LibWebRTCCodecsProxy::initialize):
-(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
-(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
-(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
-(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
-(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
-(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
-(WebKit::LibWebRTCCodecsProxy::createEncoder):
-(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
-(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
-(WebKit::LibWebRTCCodecsProxy::findEncoder):
-(WebKit::LibWebRTCCodecsProxy::encodeFrame):
-(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
-(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
-
-2022-05-05  Alan Coon  
-
-Apply patch. rdar://problem/88904160
-
-2022-04-22  Kimmo Kinnunen  
-
 Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues
 https://bugs.webkit.org/show_bug.cgi?id=236832
 


Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (293864 => 293865)

--- branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 23:10:18 UTC (rev 293864)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 23:11:24 UTC (rev 293865)
@@ -274,6 +274,9 @@
 #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
 m_sampleBufferDisplayLayerManager->close();
 #endif
+#if PLATFORM(COCOA) && USE(LIBWEBRTC)
+m_libWebRTCCodecsProxy->close();
+#endif
 
 --gObjectCountForTesting;
 }
@@ -306,9 +309,7 @@
 WCContentBufferManager::singleton().removeAllContentBuffersForProcess(webProcessIdentifier);
 });
 #endif
-#if PLATFORM(COCOA) && USE(LIBWEBRTC)
-

[webkit-changes] [293864] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [293864] branches/safari-613-branch/Source/WebKit








Revision 293864
Author alanc...@apple.com
Date 2022-05-05 16:10:18 -0700 (Thu, 05 May 2022)


Log Message
Revert r293852. rdar://problem/88904160

This reverts a patch application at r293852.

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (293863 => 293864)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 22:42:01 UTC (rev 293863)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 23:10:18 UTC (rev 293864)
@@ -2,63 +2,6 @@
 
 Apply patch. rdar://problem/88904160
 
-2022-05-05  Kimmo Kinnunen  
-
-Multiple concurrency violations in LibWebRTCCodecsProxy
-https://bugs.webkit.org/show_bug.cgi?id=236767
-
-
-Reviewed by Antti Koivisto.
-
-- ThreadMessageReceivers should not add IPC listeners in constructors,
-as the delivery starts right away and uses the unconstructed virtual pointer.
-- The work queue functions should not use GPUConnectionToWebProcess, as that is
-main thread object.
-- Locked m_encoders, m_decoders are sometimes accessed without lock.
-
-Instead:
-- Add the IPC listeners in initialize function.
-- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
-- Store the thread-safe conection, video frame object heap, process identity
-objects as member variables.
-- Do not lock m_encoders, m_decoders. If they are work queue instances,
-just access them in the work queue functions. Add thread requirements
-to the variables so that the compiler checks the access.
-- Use IPC testing assertions when skipping incorrect messages.
-- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
-
-No new tests, tested with existing tests and ASAN.
-
-* GPUProcess/GPUConnectionToWebProcess.cpp:
-(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
-(WebKit::GPUConnectionToWebProcess::didClose):
-* GPUProcess/GPUConnectionToWebProcess.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
-(WebKit::LibWebRTCCodecsProxy::create):
-(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
-(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
-(WebKit::LibWebRTCCodecsProxy::initialize):
-(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
-(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
-(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
-(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
-(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
-(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
-(WebKit::LibWebRTCCodecsProxy::createEncoder):
-(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
-(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
-(WebKit::LibWebRTCCodecsProxy::findEncoder):
-(WebKit::LibWebRTCCodecsProxy::encodeFrame):
-(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
-(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
-
-2022-05-05  Alan Coon  
-
-Apply patch. rdar://problem/88904160
-
 2022-04-22  Kimmo Kinnunen  
 
 Multiple concurrency violations in LibWebRTCCodecsProxy


Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp (293863 => 293864)

--- branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp	2022-05-05 22:42:01 UTC (rev 293863)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp	2022-05-05 23:10:18 UTC (rev 293864)
@@ -252,7 +252,7 @@
 
 void RemoteGraphicsContextGL::copyTextureFromMedia(WebCore::MediaPlayerIdentifier mediaPlayerIdentifier, uint32_t texture, uint32_t target, int32_t level, uint32_t internalFormat, uint32_t format, uint32_t type, bool premultiplyAlpha, bool flipY, CompletionHandler&& completionHandler)
 {
-assertIsCurrent(workQueue());
+assertIsCurrent(m_workQueue());
 #if USE(AVFOUNDATION)
 UNUSED_VARIABLE(premultiplyAlpha);
 ASSERT_UNUSED(target, target == GraphicsContextGL::TEXTURE_2D);


Modified: 

[webkit-changes] [293863] trunk/Source

[bfulgham]

Title: [293863] trunk/Source








Revision 293863
Author bfulg...@apple.com
Date 2022-05-05 15:42:01 -0700 (Thu, 05 May 2022)


Log Message
Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
https://bugs.webkit.org/show_bug.cgi?id=240130

Reviewed by Simon Fraser.

The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.

Source/WebCore:

* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::canUseCompositedScrolling const):

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences _setAlwaysUseAcceleratedOverflowScroll:]): Deleted.
(-[WebPreferences _alwaysUseAcceleratedOverflowScroll]): Deleted.
* WebView/WebPreferencesPrivate.h:

Source/WTF:

* Scripts/Preferences/WebPreferences.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h




Diff

Modified: trunk/Source/WTF/ChangeLog (293862 => 293863)

--- trunk/Source/WTF/ChangeLog	2022-05-05 22:27:01 UTC (rev 293862)
+++ trunk/Source/WTF/ChangeLog	2022-05-05 22:42:01 UTC (rev 293863)
@@ -1,3 +1,14 @@
+2022-05-05  Brent Fulgham  
+
+Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
+https://bugs.webkit.org/show_bug.cgi?id=240130
+
+Reviewed by Simon Fraser.
+
+The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.
+
+* Scripts/Preferences/WebPreferences.yaml:
+
 2022-05-05  Manuel Rego Casasnovas  
 
 ARIA reflection for Element attributes


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (293862 => 293863)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2022-05-05 22:27:01 UTC (rev 293862)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2022-05-05 22:42:01 UTC (rev 293863)
@@ -232,16 +232,6 @@
 WebCore:
   default: false
 
-AlwaysUseAcceleratedOverflowScroll:
-  type: bool
-  defaultValue:
-WebKitLegacy:
-  default: false
-WebKit:
-  default: false
-WebCore:
-  default: false
-
 AnimatedImageAsyncDecodingEnabled:
   type: bool
   defaultValue:


Modified: trunk/Source/WebCore/ChangeLog (293862 => 293863)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 22:27:01 UTC (rev 293862)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 22:42:01 UTC (rev 293863)
@@ -1,3 +1,15 @@
+2022-05-05  Brent Fulgham  
+
+Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
+https://bugs.webkit.org/show_bug.cgi?id=240130
+
+Reviewed by Simon Fraser.
+
+The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.
+
+* rendering/RenderLayerScrollableArea.cpp:
+(WebCore::RenderLayerScrollableArea::canUseCompositedScrolling const):
+
 2022-05-05  Manuel Rego Casasnovas  
 
 ARIA reflection for Element attributes


Modified: trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp (293862 => 293863)

--- trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp	2022-05-05 22:27:01 UTC (rev 293862)
+++ trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp	2022-05-05 22:42:01 UTC (rev 293863)
@@ -483,7 +483,7 @@
 return isVisible && scrollsOverflow() && !m_layer.isInsideSVGForeignObject();
 
 #if PLATFORM(IOS_FAMILY) && ENABLE(OVERFLOW_SCROLLING_TOUCH)
-return isVisible && scrollsOverflow() && (renderer.style().useTouchOverflowScrolling() || renderer.settings().alwaysUseAcceleratedOverflowScroll());
+return isVisible && scrollsOverflow() && renderer.style().useTouchOverflowScrolling();
 #else
 return false;
 #endif


Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (293862 => 293863)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2022-05-05 22:27:01 UTC (rev 293862)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2022-05-05 22:42:01 UTC (rev 293863)
@@ -1,3 +1,18 @@
+2022-05-05  Brent Fulgham  
+
+Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
+https://bugs.webkit.org/show_bug.cgi?id=240130
+
+Reviewed by Simon Fraser.
+
+The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.
+
+* WebView/WebPreferenceKeysPrivate.h:
+* WebView/WebPreferences.mm:
+(-[WebPreferences _setAlwaysUseAcceleratedOverflowScroll:]): Deleted.
+(-[WebPreferences _alwaysUseAcceleratedOverflowScroll]): Deleted.
+* WebView/WebPreferencesPrivate.h:
+
 2022-05-04  Brent 

[webkit-changes] [293862] trunk

[megan_gardner]

Title: [293862] trunk








Revision 293862
Author megan_gard...@apple.com
Date 2022-05-05 15:27:01 -0700 (Thu, 05 May 2022)


Log Message
Add github info for myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240140

Unreviewed metadata addition.


* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (293861 => 293862)

--- trunk/ChangeLog	2022-05-05 22:14:41 UTC (rev 293861)
+++ trunk/ChangeLog	2022-05-05 22:27:01 UTC (rev 293862)
@@ -1,3 +1,12 @@
+2022-05-05  Megan Gardner  
+
+Add github info for myself to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=240140
+
+Unreviewed metadata addition.
+
+* metadata/contributors.json:
+
 2022-05-02  Yijia Huang  
 
 Update yijia's info in constributors


Modified: trunk/metadata/contributors.json (293861 => 293862)

--- trunk/metadata/contributors.json	2022-05-05 22:14:41 UTC (rev 293861)
+++ trunk/metadata/contributors.json	2022-05-05 22:27:01 UTC (rev 293862)
@@ -4791,6 +4791,7 @@
  "megan_gard...@apple.com"
   ],
   "expertise" : "iOS Selection",
+  "github" : "megangardner",
   "name" : "Megan Gardner",
   "nicks" : [
  "GameMaker"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293861] trunk/Source/WebKit

[achristensen]

Title: [293861] trunk/Source/WebKit








Revision 293861
Author achristen...@apple.com
Date 2022-05-05 15:14:41 -0700 (Thu, 05 May 2022)


Log Message
Unreviewed, reverting r293697.

Mergred to branch, not needed on trunk

Reverted changeset:

"Revert all use of
_setPrivacyProxyFailClosedForUnreachableNonMainHosts"
https://bugs.webkit.org/show_bug.cgi?id=239977
https://commits.webkit.org/r293697

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (293860 => 293861)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 21:40:17 UTC (rev 293860)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 22:14:41 UTC (rev 293861)
@@ -1,5 +1,18 @@
 2022-05-05  Alex Christensen  
 
+Unreviewed, reverting r293697.
+
+Mergred to branch, not needed on trunk
+
+Reverted changeset:
+
+"Revert all use of
+_setPrivacyProxyFailClosedForUnreachableNonMainHosts"
+https://bugs.webkit.org/show_bug.cgi?id=239977
+https://commits.webkit.org/r293697
+
+2022-05-05  Alex Christensen  
+
 Allow hw.cpu64bit_capable sysctl-read in network process sandbox on iOS
 https://bugs.webkit.org/show_bug.cgi?id=240124
 


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (293860 => 293861)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2022-05-05 21:40:17 UTC (rev 293860)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2022-05-05 22:14:41 UTC (rev 293861)
@@ -340,6 +340,14 @@
 RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
 RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
 
+if (parameters.isMainFrameNavigation
+|| parameters.hadMainFrameMainResourcePrivateRelayed
+|| !parameters.topOrigin
+|| request.url().host() == parameters.topOrigin->host()) {
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+}
+
 #if ENABLE(APP_PRIVACY_REPORT)
 mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
 #endif


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (293860 => 293861)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2022-05-05 21:40:17 UTC (rev 293860)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2022-05-05 22:14:41 UTC (rev 293861)
@@ -1713,6 +1713,17 @@
 appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
 #endif
 
+// FIXME: This function can make up to 3 copies of a request.
+// Reduce that to one if the protocol is null, the request isn't app initiated,
+// or the main frame main resource was private relayed, then set all properties
+// on the one copy.
+if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
+RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+nsRequest = WTFMove(mutableRequest);
+}
+
 auto& sessionSet = sessionSetForPage(webPageProxyID);
 RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293860] trunk

[rego]

Title: [293860] trunk








Revision 293860
Author r...@igalia.com
Date 2022-05-05 14:40:17 -0700 (Thu, 05 May 2022)


Log Message
ARIA reflection for Element attributes
https://bugs.webkit.org/show_bug.cgi?id=239852

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Small fix on the test and update test results with the new PASS.
Add new test case to cover elements moved to a different document.

* web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
* web-platform-tests/dom/nodes/aria-element-reflection.tentative.html:

Source/WebCore:

Implement ARIA reflection for attributes that refer to a single Element:
aria-activedescendant & aria-errormessage.
For the properties names this patch uses "Element" suffix:
ariaActiveDescendantElement & ariaErrorMessageElement;
this matches Chromium implementation and AOM explainer, but not AOM spec:
https://github.com/w3c/aria/issues/1732

This implementation is done following the proposed spec text defined at:
https://github.com/whatwg/html/pull/3917

* accessibility/AriaAttributes.idl: Add ariaActiveDescendantElement &
ariaErrorMessageElement.
* bindings/scripts/CodeGenerator.pm:
(GetterExpression): Add function for Element attributes.
(SetterExpression): Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Add tests for element
attribute reflection.
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObj_reflectedElementAttrGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestObj_reflectedElementAttrSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):
* bindings/scripts/test/TestObj.idl: Add reflectedElementAttr
attribute.
* dom/Element.cpp:
(WebCore::isElementReflectionAttribute): Utility function to identify
Element reflection attributes.
(WebCore::Element::attributeChanged): If an element reflection
attribute has changed we need to synchronize the map entry by removing
it as it'll be properly updated in setElementAttribute() when needed.
(WebCore::Element::explicitlySetAttrElementsMap): Kind of getter
for the ExplicitlySetAttrElementsMap but that creates the map if it
doesn't exist yet.
(WebCore::Element::explicitlySetAttrElementsMapIfExists const):
Getter for the map.
(WebCore::Element::getElementAttribute const): Implement getter for
element attribute.
(WebCore::Element::setElementAttribute): Implement setter for
element attribute.
* dom/Element.h: Add new method headers and defines the
ExplicitlySetAttrElementsMap, which so far only stores one Element in
the Vector, but uses a Vector in preparation for supporting
FrozenArray reflection in the future.
* dom/ElementRareData.cpp: Update size of SameSizeAsElementRareData to
include the new pointer.
* dom/ElementRareData.h: Add m_explicitlySetAttrElementsMap attribute.
(WebCore::ElementRareData::explicitlySetAttrElementsMap): Getter.
(WebCore::ElementRareData::useTypes const):Include
ExplicitlySetAttrElementsMap.
* dom/Node.cpp:
(WebCore::stringForRareDataUseType): Add ExplicitlySetAttrElementsMap.
* dom/NodeRareData.h: Ditto.

Source/WTF:

Add new runtime flag AriaReflectionForElementReferencesEnabled.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

Update test to include the new reflected attributes.

* accessibility/ARIA-reflection-expected.txt:
* accessibility/ARIA-reflection.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt
trunk/LayoutTests/accessibility/ARIA-reflection.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AriaAttributes.idl
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementRareData.cpp
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/NodeRareData.h




Diff

Modified: trunk/LayoutTests/ChangeLog (293859 => 293860)

--- trunk/LayoutTests/ChangeLog	2022-05-05 21:10:01 UTC (rev 293859)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 21:40:17 UTC (rev 293860)
@@ -1,3 +1,15 @@
+2022-05-05  Manuel Rego Casasnovas  
+
+ARIA reflection for Element attributes
+https://bugs.webkit.org/show_bug.cgi?id=239852
+
+Reviewed by Chris Dumez.
+
+Update test to include the new reflected attributes.
+
+* accessibility/ARIA-reflection-expected.txt:
+* accessibility/ARIA-reflection.html:
+
 2022-05-05  Karl Rackler  
 
 [ iOS ][ Monterey Release wk2 ] 

[webkit-changes] [293859] trunk/LayoutTests

[rackler]

Title: [293859] trunk/LayoutTests








Revision 293859
Author rack...@apple.com
Date 2022-05-05 14:10:01 -0700 (Thu, 05 May 2022)


Log Message
[ iOS ][ Monterey Release wk2 ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239568

Unreviewed test gardening.

Canonical link: https://commits.webkit.org/250324@main

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (293858 => 293859)

--- trunk/LayoutTests/ChangeLog	2022-05-05 19:44:58 UTC (rev 293858)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 21:10:01 UTC (rev 293859)
@@ -1,3 +1,12 @@
+2022-05-05  Karl Rackler  
+
+[ iOS ][ Monterey Release wk2 ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=239568
+
+Unreviewed test gardening. 
+
+* platform/ios/TestExpectations:
+
 2022-05-05  Robert Jenner  
 
 Remove and cleanup platform expectations folders 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (293858 => 293859)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-05-05 19:44:58 UTC (rev 293858)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-05-05 21:10:01 UTC (rev 293859)
@@ -3607,3 +3607,5 @@
 webkit.org/b/240104 fast/text/international/system-language/navigator-language/navigator-language-fr.html [ Pass Failure ]
 
 webkit.org/b/240123 imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html [ Pass Failure ]
+
+webkit.org/b/239568 imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293858] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [293858] trunk/Source/_javascript_Core








Revision 293858
Author ysuz...@apple.com
Date 2022-05-05 12:44:58 -0700 (Thu, 05 May 2022)


Log Message
Unreviewed, partial revert of r293813 because of proposal's issue.
https://bugs.webkit.org/show_bug.cgi?id=240102

* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (293857 => 293858)

--- trunk/Source/_javascript_Core/ChangeLog	2022-05-05 18:58:04 UTC (rev 293857)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-05-05 19:44:58 UTC (rev 293858)
@@ -1,5 +1,13 @@
 2022-05-05  Yusuke Suzuki  
 
+Unreviewed, partial revert of r293813 because of proposal's issue.
+https://bugs.webkit.org/show_bug.cgi?id=240102
+
+* runtime/IntlNumberFormat.cpp:
+(JSC::IntlNumberFormat::initializeNumberFormat):
+
+2022-05-05  Yusuke Suzuki  
+
 [JSC] Clean up StructureID related data
 https://bugs.webkit.org/show_bug.cgi?id=240114
 


Modified: trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp (293857 => 293858)

--- trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp	2022-05-05 18:58:04 UTC (rev 293857)
+++ trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp	2022-05-05 19:44:58 UTC (rev 293858)
@@ -399,10 +399,9 @@
 throwTypeError(globalObject, scope, "rounding type is not fraction-digits while roundingIncrement is specified"_s);
 return;
 }
-if (m_maximumFractionDigits != m_minimumFractionDigits) {
-throwRangeError(globalObject, scope, "maximum and minimum fraction-digits are not equal while roundingIncrement is specified"_s);
-return;
-}
+// FIXME: The proposal has m_maximumFractionDigits != m_minimumFractionDigits check here, but it breaks the use case.
+// We intentionally do not follow to that here until the issue is fixed.
+// https://github.com/tc39/proposal-intl-numberformat-v3/issues/97
 }
 
 m_trailingZeroDisplay = intlOption(globalObject, options, vm.propertyNames->trailingZeroDisplay, { { "auto"_s, TrailingZeroDisplay::Auto }, { "stripIfInteger"_s, TrailingZeroDisplay::StripIfInteger } }, "trailingZeroDisplay must be either \"auto\" or \"stripIfInteger\""_s, TrailingZeroDisplay::Auto);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293857] trunk/Source/WebCore

[commit-queue]

Title: [293857] trunk/Source/WebCore








Revision 293857
Author commit-qu...@webkit.org
Date 2022-05-05 11:58:04 -0700 (Thu, 05 May 2022)


Log Message
Remove unnecessary calls to CachedResource::updateBuffer and CachedResource::updateData
https://bugs.webkit.org/show_bug.cgi?id=240126

Patch by Alex Christensen  on 2022-05-05
Reviewed by Chris Dumez.

It adds a function call that does nothing but a redundant assert.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::updateBufferInternal):
(WebCore::CachedImage::updateBuffer):
(WebCore::CachedImage::updateData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293856 => 293857)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 18:54:37 UTC (rev 293856)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 18:58:04 UTC (rev 293857)
@@ -1,3 +1,17 @@
+2022-05-05  Alex Christensen  
+
+Remove unnecessary calls to CachedResource::updateBuffer and CachedResource::updateData
+https://bugs.webkit.org/show_bug.cgi?id=240126
+
+Reviewed by Chris Dumez.
+
+It adds a function call that does nothing but a redundant assert.
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::updateBufferInternal):
+(WebCore::CachedImage::updateBuffer):
+(WebCore::CachedImage::updateData):
+
 2022-05-05  Said Abou-Hallawa  
 
 [GPU Process] NativeImage should share the ShareableBitmap data when it's sent to GPU Process


Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (293856 => 293857)

--- trunk/Source/WebCore/loader/cache/CachedImage.cpp	2022-05-05 18:54:37 UTC (rev 293856)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp	2022-05-05 18:58:04 UTC (rev 293857)
@@ -506,10 +506,10 @@
 if (encodedDataStatus == EncodedDataStatus::Error || m_image->isNull()) {
 // Image decoding failed. Either we need more image data or the image data is malformed.
 error(errorOccurred() ? status() : DecodeError);
+if (inCache())
+MemoryCache::singleton().remove(*this);
 if (m_loader && encodedDataStatus == EncodedDataStatus::Error)
 m_loader->cancel();
-if (inCache())
-MemoryCache::singleton().remove(*this);
 return;
 }
 
@@ -554,7 +554,6 @@
 {
 ASSERT(dataBufferingPolicy() == DataBufferingPolicy::BufferData);
 updateBufferInternal(buffer.makeContiguous());
-CachedResource::updateBuffer(buffer);
 }
 
 void CachedImage::updateData(const SharedBuffer& data)
@@ -561,7 +560,6 @@
 {
 ASSERT(dataBufferingPolicy() == DataBufferingPolicy::DoNotBufferData);
 updateBufferInternal(data);
-CachedResource::updateData(data);
 }
 
 void CachedImage::finishLoading(const FragmentedSharedBuffer* data, const NetworkLoadMetrics& metrics)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293856] tags/WebKit-7613.2.7.1.9/

[alancoon]

Title: [293856] tags/WebKit-7613.2.7.1.9/








Revision 293856
Author alanc...@apple.com
Date 2022-05-05 11:54:37 -0700 (Thu, 05 May 2022)


Log Message
Tag WebKit-7613.2.7.1.9.

Added Paths

tags/WebKit-7613.2.7.1.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293855] branches/safari-613.2.7.1-branch/Source

[alancoon]

Title: [293855] branches/safari-613.2.7.1-branch/Source








Revision 293855
Author alanc...@apple.com
Date 2022-05-05 11:50:43 -0700 (Thu, 05 May 2022)


Log Message
Versioning.

WebKit-7613.2.7.1.9

Modified Paths

branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.2.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig (293854 => 293855)

--- branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-05 18:42:03 UTC (rev 293854)
+++ branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-05 18:50:43 UTC (rev 293855)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = 

[webkit-changes] [293854] trunk/LayoutTests

[jenner]

Title: [293854] trunk/LayoutTests








Revision 293854
Author jen...@apple.com
Date 2022-05-05 11:42:03 -0700 (Thu, 05 May 2022)


Log Message
Remove and cleanup platform expectations folders
https://bugs.webkit.org/show_bug.cgi?id=240131

Unreviewed test gardening.

* platform/mac-catalina-wk1/TestExpectations: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/anchor-element-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attrib-string-colors-with-color-filter-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attribute-string-for-copy-with-color-filter-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-for-typing-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/basic-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/comment-cdata-section-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/font-size-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/font-weight-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/letter-spacing-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/text-decorations-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/mac/attributed-string/vertical-align-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
* platform/mac-catalina-wk1/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
* platform/mac-catalina-wk1/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
* platform/mac-catalina-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Removed.
* platform/mac-catalina-wk2/fast/events/contextmenu-lookup-action-for-image-expected.txt: Removed.
* platform/mac-catalina-wk2/http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Removed.
* platform/mac-catalina-wk2/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/basic-auth.any-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/basic-auth.any.worker-expected.txt: Removed.
* platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/remove-own-iframe-during-onerror.window-expected.txt: Removed.
* platform/mac-catalina/TestExpectations: Removed.
* platform/mac-catalina/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/mac-catalina/editing/pasteboard/pasting-tabs-expected.txt: Removed.
* platform/mac-catalina/editing/selection/3690703-2-expected.txt: Removed.
* platform/mac-catalina/editing/selection/3690703-expected.txt: Removed.
* platform/mac-catalina/editing/selection/3690719-expected.txt: Removed.
* platform/mac-catalina/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
* platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Removed.
* platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-br-mixed-expected.txt: Removed.
* platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Removed.
* 

[webkit-changes] [293853] trunk/Source/WebKit

[commit-queue]

Title: [293853] trunk/Source/WebKit








Revision 293853
Author commit-qu...@webkit.org
Date 2022-05-05 11:37:36 -0700 (Thu, 05 May 2022)


Log Message
Allow hw.cpu64bit_capable sysctl-read in network process sandbox on iOS
https://bugs.webkit.org/show_bug.cgi?id=240124


Patch by Alex Christensen  on 2022-05-05
Reviewed by Per Arne Vollan.

It's used on watchOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (293852 => 293853)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 18:36:01 UTC (rev 293852)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 18:37:36 UTC (rev 293853)
@@ -1,3 +1,15 @@
+2022-05-05  Alex Christensen  
+
+Allow hw.cpu64bit_capable sysctl-read in network process sandbox on iOS
+https://bugs.webkit.org/show_bug.cgi?id=240124
+
+
+Reviewed by Per Arne Vollan.
+
+It's used on watchOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
+
 2022-05-05  Said Abou-Hallawa  
 
 [GPU Process] NativeImage should share the ShareableBitmap data when it's sent to GPU Process


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in (293852 => 293853)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in	2022-05-05 18:36:01 UTC (rev 293852)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in	2022-05-05 18:37:36 UTC (rev 293853)
@@ -481,6 +481,9 @@
 (allow sysctl-read
 (sysctl-name
 "hw.activecpu"
+#if PLATFORM(WATCHOS)
+"hw.cpu64bit_capable"
+#endif
 "hw.machine"
 "hw.memsize"
 "hw.ncpu"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293852] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [293852] branches/safari-613-branch/Source/WebKit








Revision 293852
Author alanc...@apple.com
Date 2022-05-05 11:36:01 -0700 (Thu, 05 May 2022)


Log Message
Apply patch. rdar://problem/88904160

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (293851 => 293852)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:35:58 UTC (rev 293851)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:36:01 UTC (rev 293852)
@@ -2,6 +2,63 @@
 
 Apply patch. rdar://problem/88904160
 
+2022-05-05  Kimmo Kinnunen  
+
+Multiple concurrency violations in LibWebRTCCodecsProxy
+https://bugs.webkit.org/show_bug.cgi?id=236767
+
+
+Reviewed by Antti Koivisto.
+
+- ThreadMessageReceivers should not add IPC listeners in constructors,
+as the delivery starts right away and uses the unconstructed virtual pointer.
+- The work queue functions should not use GPUConnectionToWebProcess, as that is
+main thread object.
+- Locked m_encoders, m_decoders are sometimes accessed without lock.
+
+Instead:
+- Add the IPC listeners in initialize function.
+- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
+- Store the thread-safe conection, video frame object heap, process identity
+objects as member variables.
+- Do not lock m_encoders, m_decoders. If they are work queue instances,
+just access them in the work queue functions. Add thread requirements
+to the variables so that the compiler checks the access.
+- Use IPC testing assertions when skipping incorrect messages.
+- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
+
+No new tests, tested with existing tests and ASAN.
+
+* GPUProcess/GPUConnectionToWebProcess.cpp:
+(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
+(WebKit::GPUConnectionToWebProcess::didClose):
+* GPUProcess/GPUConnectionToWebProcess.h:
+* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
+* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
+(WebKit::LibWebRTCCodecsProxy::create):
+(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
+(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
+(WebKit::LibWebRTCCodecsProxy::initialize):
+(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
+(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
+(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
+(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
+(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
+(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
+(WebKit::LibWebRTCCodecsProxy::createEncoder):
+(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
+(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
+(WebKit::LibWebRTCCodecsProxy::findEncoder):
+(WebKit::LibWebRTCCodecsProxy::encodeFrame):
+(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
+(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
+(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
+(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
+
+2022-05-05  Alan Coon  
+
+Apply patch. rdar://problem/88904160
+
 2022-04-22  Kimmo Kinnunen  
 
 Multiple concurrency violations in LibWebRTCCodecsProxy


Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp (293851 => 293852)

--- branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp	2022-05-05 18:35:58 UTC (rev 293851)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp	2022-05-05 18:36:01 UTC (rev 293852)
@@ -252,7 +252,7 @@
 
 void RemoteGraphicsContextGL::copyTextureFromMedia(WebCore::MediaPlayerIdentifier mediaPlayerIdentifier, uint32_t texture, uint32_t target, int32_t level, uint32_t internalFormat, uint32_t format, uint32_t type, bool premultiplyAlpha, bool flipY, CompletionHandler&& completionHandler)
 {
-assertIsCurrent(m_workQueue());
+assertIsCurrent(workQueue());
 #if USE(AVFOUNDATION)
 UNUSED_VARIABLE(premultiplyAlpha);
 ASSERT_UNUSED(target, target == GraphicsContextGL::TEXTURE_2D);


Modified: 

[webkit-changes] [293851] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [293851] branches/safari-613-branch/Source/WebKit








Revision 293851
Author alanc...@apple.com
Date 2022-05-05 11:35:58 -0700 (Thu, 05 May 2022)


Log Message
Apply patch. rdar://problem/88904160

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (293850 => 293851)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:35:55 UTC (rev 293850)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:35:58 UTC (rev 293851)
@@ -4,6 +4,63 @@
 
 2022-04-22  Kimmo Kinnunen  
 
+Multiple concurrency violations in LibWebRTCCodecsProxy
+https://bugs.webkit.org/show_bug.cgi?id=236767
+
+
+Reviewed by Antti Koivisto.
+
+- ThreadMessageReceivers should not add IPC listeners in constructors,
+as the delivery starts right away and uses the unconstructed virtual pointer.
+- The work queue functions should not use GPUConnectionToWebProcess, as that is
+main thread object.
+- Locked m_encoders, m_decoders are sometimes accessed without lock.
+
+Instead:
+- Add the IPC listeners in initialize function.
+- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
+- Store the thread-safe conection, video frame object heap, process identity
+objects as member variables.
+- Do not lock m_encoders, m_decoders. If they are work queue instances,
+just access them in the work queue functions. Add thread requirements
+to the variables so that the compiler checks the access.
+- Use IPC testing assertions when skipping incorrect messages.
+- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
+
+No new tests, tested with existing tests and ASAN.
+
+* GPUProcess/GPUConnectionToWebProcess.cpp:
+(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
+(WebKit::GPUConnectionToWebProcess::didClose):
+* GPUProcess/GPUConnectionToWebProcess.h:
+* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
+* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
+(WebKit::LibWebRTCCodecsProxy::create):
+(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
+(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
+(WebKit::LibWebRTCCodecsProxy::initialize):
+(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
+(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
+(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
+(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
+(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
+(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
+(WebKit::LibWebRTCCodecsProxy::createEncoder):
+(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
+(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
+(WebKit::LibWebRTCCodecsProxy::findEncoder):
+(WebKit::LibWebRTCCodecsProxy::encodeFrame):
+(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
+(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
+(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
+(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
+
+2022-05-05  Alan Coon  
+
+Apply patch. rdar://problem/88904160
+
+2022-04-22  Kimmo Kinnunen  
+
 Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues
 https://bugs.webkit.org/show_bug.cgi?id=236832
 


Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (293850 => 293851)

--- branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 18:35:55 UTC (rev 293850)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 18:35:58 UTC (rev 293851)
@@ -274,9 +274,6 @@
 #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
 m_sampleBufferDisplayLayerManager->close();
 #endif
-#if PLATFORM(COCOA) && USE(LIBWEBRTC)
-m_libWebRTCCodecsProxy->close();
-#endif
 
 --gObjectCountForTesting;
 }
@@ -309,7 +306,9 @@
 WCContentBufferManager::singleton().removeAllContentBuffersForProcess(webProcessIdentifier);
 });
 #endif
-
+#if PLATFORM(COCOA) && USE(LIBWEBRTC)
+m_libWebRTCCodecsProxy = nullptr;
+#endif
 

[webkit-changes] [293849] trunk/Websites/bugs.webkit.org

[jbedard]

Title: [293849] trunk/Websites/bugs.webkit.org








Revision 293849
Author jbed...@apple.com
Date 2022-05-05 11:31:57 -0700 (Thu, 05 May 2022)


Log Message
[bugs.webkit.org] Replace svn.webkit.org in committers autocomplete
https://bugs.webkit.org/show_bug.cgi?id=240090


Reviewed by Aakash Jain.

* Websites/bugs.webkit.org/committers-autocomplete.js: Replace
svn.webkit.org with raw.githubusercontent.com.

Canonical link: https://commits.webkit.org/250319@main

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/committers-autocomplete.js




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (293848 => 293849)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2022-05-05 18:28:40 UTC (rev 293848)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2022-05-05 18:31:57 UTC (rev 293849)
@@ -1,3 +1,13 @@
+2022-05-04  Jonathan Bedard  
+
+[bugs.webkit.org] Replace svn.webkit.org in committers autocomplete
+https://bugs.webkit.org/show_bug.cgi?id=240090
+
+
+Reviewed by Aakash Jain.
+
+* committers-autocomplete.js: Replace svn.webkit.org with raw.githubusercontent.com.
+
 2022-03-31  Myles C. Maxfield  
 
 [Bugzilla] Code reviews show non-ASCII characters in patches as garbage


Modified: trunk/Websites/bugs.webkit.org/committers-autocomplete.js (293848 => 293849)

--- trunk/Websites/bugs.webkit.org/committers-autocomplete.js	2022-05-05 18:28:40 UTC (rev 293848)
+++ trunk/Websites/bugs.webkit.org/committers-autocomplete.js	2022-05-05 18:31:57 UTC (rev 293849)
@@ -24,7 +24,7 @@
 // DAMAGE.
 
 WebKitCommitters = (function() {
-var COMMITTERS_URL = 'https://svn.webkit.org/repository/webkit/trunk/metadata/contributors.json';
+var COMMITTERS_URL = 'https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json';
 var m_committers;
 
 function statusToType(status) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293848] branches/safari-613-branch/Source/WebKit

[alancoon]

Title: [293848] branches/safari-613-branch/Source/WebKit








Revision 293848
Author alanc...@apple.com
Date 2022-05-05 11:28:40 -0700 (Thu, 05 May 2022)


Log Message
Revert r293791. rdar://problem/88904160

This reverts the application of a patch landed at r293791.

Modified Paths

branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (293847 => 293848)

--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:26:07 UTC (rev 293847)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-05-05 18:28:40 UTC (rev 293848)
@@ -1,60 +1,3 @@
-2022-05-04  Alan Coon  
-
-Apply patch. rdar://problem/88904160
-
-2022-05-04  Kimmo Kinnunen  
-
-Multiple concurrency violations in LibWebRTCCodecsProxy
-https://bugs.webkit.org/show_bug.cgi?id=236767
-
-
-Reviewed by Antti Koivisto.
-
-- ThreadMessageReceivers should not add IPC listeners in constructors,
-as the delivery starts right away and uses the unconstructed virtual pointer.
-- The work queue functions should not use GPUConnectionToWebProcess, as that is
-main thread object.
-- Locked m_encoders, m_decoders are sometimes accessed without lock.
-
-Instead:
-- Add the IPC listeners in initialize function.
-- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
-- Store the thread-safe conection, video frame object heap, process identity
-objects as member variables.
-- Do not lock m_encoders, m_decoders. If they are work queue instances,
-just access them in the work queue functions. Add thread requirements
-to the variables so that the compiler checks the access.
-- Use IPC testing assertions when skipping incorrect messages.
-- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
-
-No new tests, tested with existing tests and ASAN.
-
-* GPUProcess/GPUConnectionToWebProcess.cpp:
-(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
-(WebKit::GPUConnectionToWebProcess::didClose):
-* GPUProcess/GPUConnectionToWebProcess.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
-(WebKit::LibWebRTCCodecsProxy::create):
-(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
-(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
-(WebKit::LibWebRTCCodecsProxy::initialize):
-(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
-(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
-(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
-(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
-(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
-(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
-(WebKit::LibWebRTCCodecsProxy::createEncoder):
-(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
-(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
-(WebKit::LibWebRTCCodecsProxy::findEncoder):
-(WebKit::LibWebRTCCodecsProxy::encodeFrame):
-(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
-(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
-
 2022-05-02  Alan Coon  
 
 Apply patch. rdar://problem/92617943


Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (293847 => 293848)

--- branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 18:26:07 UTC (rev 293847)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2022-05-05 18:28:40 UTC (rev 293848)
@@ -274,6 +274,9 @@
 #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
 m_sampleBufferDisplayLayerManager->close();
 #endif
+#if PLATFORM(COCOA) && USE(LIBWEBRTC)
+m_libWebRTCCodecsProxy->close();
+#endif
 
 --gObjectCountForTesting;
 }
@@ -306,9 +309,7 @@
 WCContentBufferManager::singleton().removeAllContentBuffersForProcess(webProcessIdentifier);
 });
 #endif
-#if PLATFORM(COCOA) && USE(LIBWEBRTC)
-m_libWebRTCCodecsProxy = nullptr;
-#endif
+
 

[webkit-changes] [293847] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [293847] trunk/Source/_javascript_Core








Revision 293847
Author ysuz...@apple.com
Date 2022-05-05 11:26:07 -0700 (Thu, 05 May 2022)


Log Message
[JSC] Clean up StructureID related data
https://bugs.webkit.org/show_bug.cgi?id=240114

Reviewed by Mark Lam.

This patch moves structureHeapAddressSize to StructureID. And define it only when we use it.
We also use decontaminate() in ADDRESS32 tryDecode. Strictly speaking, it is not necessary
for now since 32bit environment does not have concurrent GC & concurrent JIT compiler, but
it can have that.

* Source/_javascript_Core/runtime/JSCConfig.h:
* Source/_javascript_Core/runtime/StructureID.h:
(JSC::StructureID::tryDecode const):

Canonical link: https://commits.webkit.org/250318@main

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCConfig.h
trunk/Source/_javascript_Core/runtime/StructureID.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (293846 => 293847)

--- trunk/Source/_javascript_Core/ChangeLog	2022-05-05 18:00:15 UTC (rev 293846)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-05-05 18:26:07 UTC (rev 293847)
@@ -1,3 +1,19 @@
+2022-05-05  Yusuke Suzuki  
+
+[JSC] Clean up StructureID related data
+https://bugs.webkit.org/show_bug.cgi?id=240114
+
+Reviewed by Mark Lam.
+
+This patch moves structureHeapAddressSize to StructureID. And define it only when we use it.
+We also use decontaminate() in ADDRESS32 tryDecode. Strictly speaking, it is not necessary
+for now since 32bit environment does not have concurrent GC & concurrent JIT compiler, but
+it can have that.
+
+* runtime/JSCConfig.h:
+* runtime/StructureID.h:
+(JSC::StructureID::tryDecode const):
+
 2022-05-05  Diego Pino Garcia  
 
 [GCC] REGRESSION(r293605): error: cannot convert ‘’ to ‘unsigned char:3’ in initialization


Modified: trunk/Source/_javascript_Core/runtime/JSCConfig.h (293846 => 293847)

--- trunk/Source/_javascript_Core/runtime/JSCConfig.h	2022-05-05 18:00:15 UTC (rev 293846)
+++ trunk/Source/_javascript_Core/runtime/JSCConfig.h	2022-05-05 18:26:07 UTC (rev 293847)
@@ -41,14 +41,6 @@
 using JITWriteSeparateHeapsFunction = void (*)(off_t, const void*, size_t);
 #endif
 
-#if defined(STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB) && STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB > 0
-constexpr uintptr_t structureHeapAddressSize = STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB * MB;
-#elif PLATFORM(IOS_FAMILY) && CPU(ARM64) && !CPU(ARM64E)
-constexpr uintptr_t structureHeapAddressSize = 512 * MB;
-#else
-constexpr uintptr_t structureHeapAddressSize = 4 * GB;
-#endif
-
 struct Config {
 static Config& singleton();
 


Modified: trunk/Source/_javascript_Core/runtime/StructureID.h (293846 => 293847)

--- trunk/Source/_javascript_Core/runtime/StructureID.h	2022-05-05 18:00:15 UTC (rev 293846)
+++ trunk/Source/_javascript_Core/runtime/StructureID.h	2022-05-05 18:26:07 UTC (rev 293847)
@@ -34,8 +34,10 @@
 
 class Structure;
 
+#if CPU(ADDRESS64)
+
 // We would like to define this value in PlatformEnable.h, but it is not possible since the following is relying on MACH_VM_MAX_ADDRESS.
-#if CPU(ADDRESS64) && CPU(ARM64) && OS(DARWIN)
+#if CPU(ARM64) && OS(DARWIN)
 #if MACH_VM_MAX_ADDRESS_RAW < (1ULL << 36)
 #define ENABLE_STRUCTURE_ID_WITH_SHIFT 1
 static_assert(MACH_VM_MAX_ADDRESS_RAW == MACH_VM_MAX_ADDRESS);
@@ -42,6 +44,18 @@
 #endif
 #endif
 
+#if !ENABLE(STRUCTURE_ID_WITH_SHIFT)
+#if defined(STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB) && STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB > 0
+constexpr uintptr_t structureHeapAddressSize = STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB * MB;
+#elif PLATFORM(IOS_FAMILY) && CPU(ARM64) && !CPU(ARM64E)
+constexpr uintptr_t structureHeapAddressSize = 512 * MB;
+#else
+constexpr uintptr_t structureHeapAddressSize = 4 * GB;
+#endif
+#endif // !ENABLE(STRUCTURE_ID_WITH_SHIFT)
+
+#endif // CPU(ADDRESS64)
+
 class StructureID {
 public:
 static constexpr uint32_t nukedStructureIDBit = 1;
@@ -145,7 +159,7 @@
 
 ALWAYS_INLINE Structure* StructureID::tryDecode() const
 {
-return reinterpret_cast(m_bits);
+return reinterpret_cast(decontaminate().m_bits);
 }
 
 ALWAYS_INLINE StructureID StructureID::encode(const Structure* structure)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293846] trunk/Source

[said]

Title: [293846] trunk/Source








Revision 293846
Author s...@apple.com
Date 2022-05-05 11:00:15 -0700 (Thu, 05 May 2022)


Log Message
[GPU Process] NativeImage should share the ShareableBitmap data when it's sent to GPU Process
https://bugs.webkit.org/show_bug.cgi?id=239874
rdar://92031359

Reviewed by Simon Fraser.

Source/WebCore:

* Headers.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/BackingStoreCopy.h: Added.
* platform/graphics/ImageBufferBackend.h:
(): Deleted.

Source/WebKit:

Instead of allocating a new memory buffer in GPUProcess and copying the
ShareableBitmap data to it, we can create a PlatformImage that directly
references this data. This will make all the NativeImages data be attributed
to WebProcess.

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheNativeImageWithQualifiedIdentifier):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::createPlatformImage):
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createPlatformImage):
(WebKit::ShareableBitmap::createCGImage const):
(WebKit::ShareableBitmap::releaseDataProviderData): Deleted.
* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::copyNativeImage const):
* WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
trunk/Source/WebKit/Shared/ShareableBitmap.h
trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h


Added Paths

trunk/Source/WebCore/platform/graphics/CopyImageOptions.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (293845 => 293846)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 17:27:25 UTC (rev 293845)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 18:00:15 UTC (rev 293846)
@@ -1,3 +1,17 @@
+2022-05-05  Said Abou-Hallawa  
+
+[GPU Process] NativeImage should share the ShareableBitmap data when it's sent to GPU Process
+https://bugs.webkit.org/show_bug.cgi?id=239874
+rdar://92031359
+
+Reviewed by Simon Fraser.
+
+* Headers.cmake:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/BackingStoreCopy.h: Added.
+* platform/graphics/ImageBufferBackend.h:
+(): Deleted.
+
 2022-05-05  Jer Noble  
 
 [WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()


Modified: trunk/Source/WebCore/Headers.cmake (293845 => 293846)

--- trunk/Source/WebCore/Headers.cmake	2022-05-05 17:27:25 UTC (rev 293845)
+++ trunk/Source/WebCore/Headers.cmake	2022-05-05 18:00:15 UTC (rev 293846)
@@ -1439,6 +1439,7 @@
 platform/graphics/AnimationFrameRate.h
 platform/graphics/AudioTrackPrivate.h
 platform/graphics/AudioTrackPrivateClient.h
+platform/graphics/CopyImageOptions.h
 platform/graphics/BifurcatedGraphicsContext.h
 platform/graphics/BitmapImage.h
 platform/graphics/Color.h


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (293845 => 293846)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2022-05-05 17:27:25 UTC (rev 293845)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2022-05-05 18:00:15 UTC (rev 293846)
@@ -2370,6 +2370,7 @@
 		72B8B0362753441400F752AA /* FilterImage.h in Headers */ = {isa = PBXBuildFile; fileRef = 72435EF4273D07670005E7EE /* FilterImage.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		72BAC3AE23E1F0B0008D741C /* ImageBufferBackend.h in Headers */ = {isa = PBXBuildFile; fileRef = 72BAC3A523E17328008D741C /* ImageBufferBackend.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		72D73644278461A000398663 /* FilterResults.h in Headers */ = {isa = PBXBuildFile; fileRef = 7211B5D6276536820076FEF8 /* FilterResults.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		72E5768B281B2B5500A75432 /* CopyImageOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 72E5768A281B292600A75432 /* CopyImageOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		72F667E1260C26AC00EE36AD /* DiagnosticLoggingDomain.h in Headers */ = {isa = PBXBuildFile; fileRef = 72F667DF260C264400EE36AD /* DiagnosticLoggingDomain.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		72F7E746279B8F7500D82D2D /* SourceImage.h in Headers */ = {isa = PBXBuildFile; fileRef = 72F7E744279B8F7400D82D2D /* SourceImage.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		72FD30AC27E3217B0023CDAC /* SourceBrush.h in Headers */ = {isa = PBXBuildFile; fileRef = 72FD30AA27E3217B0023CDAC /* SourceBrush.h */; settings = {ATTRIBUTES = 

[webkit-changes] [293845] trunk/LayoutTests

[jenner]

Title: [293845] trunk/LayoutTests








Revision 293845
Author jen...@apple.com
Date 2022-05-05 10:27:25 -0700 (Thu, 05 May 2022)


Log Message
[ Catalina EWS ] webgl/2.0.0/* tests are flaky crashing ASSERTION FAILED: !needsLayout()
https://bugs.webkit.org/show_bug.cgi?id=229580

Unreviewed test gardening. Skip WebGL tests on mac-wk1.

* platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/250316@main

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (293844 => 293845)

--- trunk/LayoutTests/ChangeLog	2022-05-05 17:13:32 UTC (rev 293844)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 17:27:25 UTC (rev 293845)
@@ -1,3 +1,12 @@
+2022-05-05  Robert Jenner  
+
+[ Catalina EWS ] webgl/2.0.0/* tests are flaky crashing ASSERTION FAILED: !needsLayout()
+https://bugs.webkit.org/show_bug.cgi?id=229580
+
+Unreviewed test gardening. Skip WebGL tests on mac-wk1.
+
+* platform/mac-wk1/TestExpectations:
+
 2022-05-05  Karl Rackler  
 
 [ iOS ][ macOS ] imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html is a flaky failure


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (293844 => 293845)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-05-05 17:13:32 UTC (rev 293844)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-05-05 17:27:25 UTC (rev 293845)
@@ -850,8 +850,6 @@
 # repaint rects work differently on WK1
 fast/repaint/vertical-text-repaint.html [ Pass Failure ]
 
-webkit.org/b/158585 webgl/webgl-backing-store-size-update.html [ Pass Timeout ]
-
 # 
 editing/spelling/spelling-insert-html.html [ Pass Timeout ]
 
@@ -959,12 +957,6 @@
 # auto-sizing produces inconsistent image results
 css3/viewport-percentage-lengths/vh-auto-size.html [ Skip ]
 
-webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ]
-
-webkit.org/b/231514 [ BigSur+ ] webgl/1.0.3/conformance/uniforms/uniform-default-values.html [ Pass Timeout ]
-
-webkit.org/b/231541 [ BigSur+ Debug ] webgl/1.0.3/conformance/glsl/bugs/long-expressions-should-not-crash.html [ Pass Timeout ]
-
 # This was a WK2-only fix.
 http/tests/css/filters-on-iframes.html [ Skip ]
 
@@ -1147,8 +1139,6 @@
 
 webkit.org/b/198459 [ Debug ] inspector/canvas/recording-webgl-full.html [ Slow ]
 
-webkit.org/b/219449 [ Debug ] webgl/2.0.0/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Skip ]
-
 webkit.org/b/196508 compositing/repaint/scroller-with-foreground-layer-repaints.html [ Pass Failure ]
 
 webkit.org/b/198676 imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html [ Pass Failure ]
@@ -1243,13 +1233,6 @@
 
 webkit.org/b/208449 [ Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/209479 [ Debug ] webgl/2.0.0/conformance2/rendering/blitframebuffer-filter-outofbounds.html [ Pass Timeout ]
-
-webkit.org/b/209480 [ Debug ] webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html [ Pass Timeout ]
-
-webkit.org/b/229580 [ Debug ] webgl/2.0.0/conformance/textures/misc/texture-upload-size.html [ Pass Crash ]
-webkit.org/b/229580 [ Debug ] webgl/2.0.0/conformance2/textures/misc/tex-srgb-mipmap.html [ Pass Crash ]
-
 webkit.org/b/208825 [ Debug ] inspector/script-profiler/event-type-Microtask.html [ Pass Failure ]
 
 webkit.org/b/209180 inspector/script-profiler/event-type-Other.html [ Pass Failure ]
@@ -1266,8 +1249,6 @@
 
 webkit.org/b/230072 [ Release ] inspector/dom/shadow-and-non-shadow-children.html [ Pass Failure ]
 
-webkit.org/b/210198 webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ]
-
 webkit.org/b/208477 accessibility/mac/text-marker-for-index.html [ Skip ]
 accessibility/mac/textmarker-range-for-range.html [ Skip ]
 accessibility/mac/isolated-tree-mode-on-off.html [ Skip ]
@@ -1425,9 +1406,6 @@
 
 webkit.org/b/219498 imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-padding-003.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/217761 [ Debug ] webgl/conformance/extensions/s3tc-and-rgtc.html [ Skip ]
-webkit.org/b/217761 [ Debug ] webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Skip ]
-
 webkit.org/b/221009 fast/harness/render-tree-as-text-options.html [ Pass Failure ]
 
 webkit.org/b/221095 [ BigSur+ ] media/mediacapabilities/vp9.html [ Skip ]
@@ -1626,10 +1604,6 @@
 # webkit.org/b/214448 Web Share API is not implemented for mac-wk1
 http/tests/webshare/ [ Skip ]
 
-webkit.org/b/230835 [ BigSur Debug ] webgl/2.0.y/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Pass Crash ]
-webkit.org/b/230835 [ BigSur Debug ] webgl/1.0.3/conformance/extensions/oes-texture-float.html [ Pass Crash ]
-webkit.org/b/230835 [ BigSur Debug ] webgl/2.0.0/conformance/extensions/ext-blend-minmax.html [ Pass Crash ]
-
 webkit.org/b/230842 [ 

[webkit-changes] [293844] tags/WebKit-7614.1.12/

[repstein]

Title: [293844] tags/WebKit-7614.1.12/








Revision 293844
Author repst...@apple.com
Date 2022-05-05 10:13:32 -0700 (Thu, 05 May 2022)


Log Message
Tag WebKit-7614.1.12.

Added Paths

tags/WebKit-7614.1.12/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293843] branches/safari-7614.1.12-branch/Source/WebCore

[repstein]

Title: [293843] branches/safari-7614.1.12-branch/Source/WebCore








Revision 293843
Author repst...@apple.com
Date 2022-05-05 09:52:22 -0700 (Thu, 05 May 2022)


Log Message
Cherry-pick r293825. rdar://problem/92635752

[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=240100
rdar://92635752

Reviewed by Simon Fraser.

The scaling factor is not set in the GraphicsContext of the
ImageBufferShareableBitmapBackend.

To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
outside the ImageBuffer creation. This is similar to what we do in
GraphicsContext::createAlignedImageBuffer() where we scale the size and
create the ImageBuffer with scaleFactor = 1.

* page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-7614.1.12-branch/Source/WebCore/ChangeLog
branches/safari-7614.1.12-branch/Source/WebCore/page/FrameSnapshotting.cpp




Diff

Modified: branches/safari-7614.1.12-branch/Source/WebCore/ChangeLog (293842 => 293843)

--- branches/safari-7614.1.12-branch/Source/WebCore/ChangeLog	2022-05-05 16:40:55 UTC (rev 293842)
+++ branches/safari-7614.1.12-branch/Source/WebCore/ChangeLog	2022-05-05 16:52:22 UTC (rev 293843)
@@ -1,3 +1,46 @@
+2022-05-05  Russell Epstein  
+
+Cherry-pick r293825. rdar://problem/92635752
+
+[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=240100
+rdar://92635752
+
+Reviewed by Simon Fraser.
+
+The scaling factor is not set in the GraphicsContext of the
+ImageBufferShareableBitmapBackend.
+
+To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
+outside the ImageBuffer creation. This is similar to what we do in
+GraphicsContext::createAlignedImageBuffer() where we scale the size and
+create the ImageBuffer with scaleFactor = 1.
+
+* page/FrameSnapshotting.cpp:
+(WebCore::snapshotFrameRectWithClip):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-05  Said Abou-Hallawa  
+
+[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=240100
+rdar://92635752
+
+Reviewed by Simon Fraser.
+
+The scaling factor is not set in the GraphicsContext of the
+ImageBufferShareableBitmapBackend.
+
+To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
+outside the ImageBuffer creation. This is similar to what we do in
+GraphicsContext::createAlignedImageBuffer() where we scale the size and
+create the ImageBuffer with scaleFactor = 1.
+
+* page/FrameSnapshotting.cpp:
+(WebCore::snapshotFrameRectWithClip):
+
 2022-04-29  Don Olmstead  
 
 The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)


Modified: branches/safari-7614.1.12-branch/Source/WebCore/page/FrameSnapshotting.cpp (293842 => 293843)

--- branches/safari-7614.1.12-branch/Source/WebCore/page/FrameSnapshotting.cpp	2022-05-05 16:40:55 UTC (rev 293842)
+++ branches/safari-7614.1.12-branch/Source/WebCore/page/FrameSnapshotting.cpp	2022-05-05 16:52:22 UTC (rev 293843)
@@ -115,19 +115,23 @@
 if (options.flags.contains(SnapshotFlags::PaintWithIntegralScaleFactor))
 scaleFactor = ceilf(scaleFactor);
 
+auto scaledImageRect = imageRect;
+scaledImageRect.scale(scaleFactor);
+
 auto purpose = options.flags.contains(SnapshotFlags::Shareable) ? RenderingPurpose::ShareableSnapshot : RenderingPurpose::Snapshot;
 auto hostWindow = (document->view() && document->view()->root()) ? document->view()->root()->hostWindow() : nullptr;
 
-auto buffer = ImageBuffer::create(imageRect.size(), purpose, scaleFactor, options.colorSpace, options.pixelFormat, { }, { hostWindow });
+auto buffer = ImageBuffer::create(scaledImageRect.size(), purpose, 1, options.colorSpace, options.pixelFormat, { }, { hostWindow });
 if (!buffer)
 return nullptr;
 
-buffer->context().translate(-imageRect.x(), -imageRect.y());
+buffer->context().translate(-scaledImageRect.location());
+buffer->context().scale(scaleFactor);
 
 if (!clipRects.isEmpty()) {
 Path clipPath;
 for (auto& rect : clipRects)
-clipPath.addRect(encloseRectToDevicePixels(rect, scaleFactor));
+clipPath.addRect(rect);
 buffer->context().clipPath(clipPath);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [293842] trunk

[sihui_liu]

Title: [293842] trunk








Revision 293842
Author sihui_...@apple.com
Date 2022-05-05 09:40:55 -0700 (Thu, 05 May 2022)


Log Message
SuspendableWorkQueue::suspend should invoke callback immediately when queue is suspended
https://bugs.webkit.org/show_bug.cgi?id=240070

Reviewed by Chris Dumez.

Source/WTF:

With current implementation, if suspend() is called when queue is suspended, the completionHandler is not
invoked unitl the queue is resumed and suspended again. This might cause confusion for callers. To fix it,
now SuspendableWorkQueue will invoke callback immediately when queue is already suspended.

API test: WTF_SuspendableWorkQueue.SuspendTwice

* wtf/SuspendableWorkQueue.cpp:
(WTF::SuspendableWorkQueue::suspend):
(WTF::SuspendableWorkQueue::resume):
(WTF::SuspendableWorkQueue::dispatchSync):
(WTF::SuspendableWorkQueue::suspendIfNeeded):
* wtf/SuspendableWorkQueue.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/SuspendableWorkQueue.cpp: Added.
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/SuspendableWorkQueue.cpp
trunk/Source/WTF/wtf/SuspendableWorkQueue.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WTF/SuspendableWorkQueue.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (293841 => 293842)

--- trunk/Source/WTF/ChangeLog	2022-05-05 16:34:33 UTC (rev 293841)
+++ trunk/Source/WTF/ChangeLog	2022-05-05 16:40:55 UTC (rev 293842)
@@ -1,3 +1,23 @@
+2022-05-05  Sihui Liu  
+
+SuspendableWorkQueue::suspend should invoke callback immediately when queue is suspended
+https://bugs.webkit.org/show_bug.cgi?id=240070
+
+Reviewed by Chris Dumez.
+
+With current implementation, if suspend() is called when queue is suspended, the completionHandler is not 
+invoked unitl the queue is resumed and suspended again. This might cause confusion for callers. To fix it,
+now SuspendableWorkQueue will invoke callback immediately when queue is already suspended.
+
+API test: WTF_SuspendableWorkQueue.SuspendTwice
+
+* wtf/SuspendableWorkQueue.cpp:
+(WTF::SuspendableWorkQueue::suspend):
+(WTF::SuspendableWorkQueue::resume):
+(WTF::SuspendableWorkQueue::dispatchSync):
+(WTF::SuspendableWorkQueue::suspendIfNeeded):
+* wtf/SuspendableWorkQueue.h:
+
 2022-05-04  Kimmo Kinnunen  
 
 SharedMemory::systemPageSize is redundant function


Modified: trunk/Source/WTF/wtf/SuspendableWorkQueue.cpp (293841 => 293842)

--- trunk/Source/WTF/wtf/SuspendableWorkQueue.cpp	2022-05-05 16:34:33 UTC (rev 293841)
+++ trunk/Source/WTF/wtf/SuspendableWorkQueue.cpp	2022-05-05 16:40:55 UTC (rev 293842)
@@ -44,13 +44,16 @@
 ASSERT(isMainThread());
 Locker suspensionLocker { m_suspensionLock };
 
+if (m_state == State::Suspended)
+return completionHandler();
+
 // Last suspend function will be the one that is used.
 m_suspendFunction = WTFMove(suspendFunction);
 m_suspensionCompletionHandlers.append(WTFMove(completionHandler));
-if (m_isOrWillBeSuspended)
+if (m_state == State::WillSuspend)
 return;
 
-m_isOrWillBeSuspended = true;
+m_state = State::WillSuspend;
 // Make sure queue will be suspended when there is no task scheduled on the queue.
 WorkQueue::dispatch([this] {
 suspendIfNeeded();
@@ -62,11 +65,13 @@
 ASSERT(isMainThread());
 Locker suspensionLocker { m_suspensionLock };
 
-if (!m_isOrWillBeSuspended)
+if (m_state == State::Running)
 return;
 
-m_isOrWillBeSuspended = false;
-m_suspensionCondition.notifyOne();
+if (m_state == State::Suspended)
+m_suspensionCondition.notifyOne();
+
+m_state = State::Running;
 }
 
 void SuspendableWorkQueue::dispatch(Function&& function)
@@ -92,7 +97,7 @@
 // otherwise thread may be blocked.
 if (isMainThread()) {
 Locker suspensionLocker { m_suspensionLock };
-RELEASE_ASSERT(!m_isOrWillBeSuspended);
+RELEASE_ASSERT(m_state == State::Running);
 }
 WorkQueue::dispatchSync(WTFMove(function));
 }
@@ -118,12 +123,14 @@
 
 Locker suspensionLocker { m_suspensionLock };
 auto suspendFunction = std::exchange(m_suspendFunction, { });
-if (m_isOrWillBeSuspended)
-suspendFunction();
+if (m_state != State::WillSuspend)
+return;
 
+m_state = State::Suspended;
+suspendFunction();
 invokeAllSuspensionCompletionHandlers();
 
-while (m_isOrWillBeSuspended)
+while (m_state != State::Running)
 m_suspensionCondition.wait(m_suspensionLock);
 }
 


Modified: trunk/Source/WTF/wtf/SuspendableWorkQueue.h (293841 => 293842)

--- trunk/Source/WTF/wtf/SuspendableWorkQueue.h	2022-05-05 16:34:33 UTC (rev 293841)
+++ trunk/Source/WTF/wtf/SuspendableWorkQueue.h	2022-05-05 16:40:55 UTC (rev 293842)
@@ -56,7 +56,8 @@
 
 Lock 

[webkit-changes] [293841] trunk

[cdumez]

Title: [293841] trunk








Revision 293841
Author cdu...@apple.com
Date 2022-05-05 09:34:33 -0700 (Thu, 05 May 2022)


Log Message
BroadcastChannel instance in data URL dedicated worker can communicate with creator context
https://bugs.webkit.org/show_bug.cgi?id=240016

Reviewed by Youenn Fablet.

For workers, we used to dispatch to the loader document and then get the origin from that loader document.
This normally works because the worker usually inherits the origin from its loader document. However, when
the worker is loaded from a data URL, its origin is opaque:
- https://html.spec.whatwg.org/multipage/workers.html#set-up-a-worker-environment-settings-object

To address the issue, we now get the security origin directly from the BroadcastChannel's
ScriptExecutionContext, before dispatching to the main thread.

This led to one issue though because I now have to call isolatedCopy() on the SecurityOrigin to pass it to
the main thread. In particular, 2 BroadcastChannels from the same opaque origin should be able to talk to
each other. This used to work because the SecurityOrigin objects would have the same pointers and
SecurityOrigin::isSameOriginAs() would check for pointer equality. However, now that I call isolatedCopy(),
we get new & different pointers so this wouldn't work anymore. To address this, I replaced the m_isUnique
boolean data member on SecurityOrigin with a global uniqueOriginIdentifier and we check this identifier
to see if 2 opaque/unique SecurityOrigin objects are for the same opaque/unique origin. This means the
check will still work if the SecurityOrigin objects are isolated-copied or even IPC'd.

* LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html:
Resync to get test coverage from upstream WPT.

* Source/WebCore/dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::MainThreadBridge::registerChannel):
* Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isSameOriginAs const):
(WebCore::SecurityOrigin::equal const):
* Source/WebCore/page/SecurityOrigin.h:
(WebCore::SecurityOrigin::isUnique const):
(WebCore::SecurityOrigin::encode const):
(WebCore::SecurityOrigin::decode):

Canonical link: https://commits.webkit.org/250314@main

Modified Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html
trunk/Source/WTF/wtf/Markable.h
trunk/Source/WebCore/dom/BroadcastChannel.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebCore/platform/ProcessQualified.h


Added Paths

trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt (293840 => 293841)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt	2022-05-05 16:29:25 UTC (rev 293840)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt	2022-05-05 16:34:33 UTC (rev 293841)
@@ -1,4 +1,6 @@
 
 PASS Opaque origin should be serialized to "null"
 PASS BroadcastChannel messages from opaque origins should be self-contained
+PASS BroadcastChannel messages from data URL dedicated workers should be self-contained
+PASS BroadcastChannel messages from data URL shared workers should be self-contained
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html (293840 => 293841)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html	2022-05-05 16:29:25 UTC (rev 293840)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html	2022-05-05 16:34:33 UTC (rev 293841)
@@ -79,6 +79,101 @@
 document.body.appendChild(iframe1);
 });
 }, "BroadcastChannel messages from opaque origins should be self-contained");
+
+const data_url_worker_src = (channel_name, worker_name) => {
+  const source = `
+const handler = (reply) => {
+  let bc2 = new BroadcastChannel("${channel_name}");
+  bc2._onmessage_ = (e) => {
+if (e.data == "from-${worker_name}") {
+  reply("${worker_name}-done");
+} else {
+  reply("fail");
+}
+  };
+  let bc3 = new BroadcastChannel("${channel_name}");
+  bc3.postMessage("from-${worker_name}");
+};
+// For dedicated workers:
+self.addEventListener("message", () => handler(self.postMessage));
+// For shared workers:
+self.addEventListener("connect", (e) => {
+  var port = e.ports[0];
+  handler(msg => port.postMessage(msg));
+});
+`;
+  return "data:,".concat(encodeURIComponent(source));
+}
+
+promise_test(t 

[webkit-changes] [293840] trunk/LayoutTests

[rackler]

Title: [293840] trunk/LayoutTests








Revision 293840
Author rack...@apple.com
Date 2022-05-05 09:29:25 -0700 (Thu, 05 May 2022)


Log Message
[ iOS ][ macOS ] imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240123

Unreviewed test gardening.

Canonical link: https://commits.webkit.org/250313@main

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (293839 => 293840)

--- trunk/LayoutTests/ChangeLog	2022-05-05 16:13:05 UTC (rev 293839)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 16:29:25 UTC (rev 293840)
@@ -1,5 +1,15 @@
 2022-05-05  Karl Rackler  
 
+[ iOS ][ macOS ] imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=240123
+
+Unreviewed test gardening. 
+
+* platform/ios/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
+2022-05-05  Karl Rackler  
+
 [Gardening]REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=240074
 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (293839 => 293840)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-05-05 16:13:05 UTC (rev 293839)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-05-05 16:29:25 UTC (rev 293840)
@@ -3605,3 +3605,5 @@
 webkit.org/b/240081 webaudio/AudioBuffer/huge-buffer.html [ Pass Timeout ]
 
 webkit.org/b/240104 fast/text/international/system-language/navigator-language/navigator-language-fr.html [ Pass Failure ]
+
+webkit.org/b/240123 imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (293839 => 293840)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-05-05 16:13:05 UTC (rev 293839)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-05-05 16:29:25 UTC (rev 293840)
@@ -1715,3 +1715,6 @@
 webkit.org/b/239818 [ Debug ] fast/css/identical-logical-height-decl.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/239818 [ Debug ] fast/css/variables/test-suite/168.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/240123 imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293839] trunk/Source

[jer . noble]

Title: [293839] trunk/Source








Revision 293839
Author jer.no...@apple.com
Date 2022-05-05 09:13:05 -0700 (Thu, 05 May 2022)


Log Message
[WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()
https://bugs.webkit.org/show_bug.cgi?id=240108


Reviewed by Simon Fraser.

Source/WebCore:

No longer pass a CVPixelBufferRef up through onNewVideoFrameMetadata().

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::onNewVideoFrameMetadata):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerOnNewVideoFrameMetadata):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::checkNewVideoFrameMetadata):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::checkNewVideoFrameMetadata):

Source/WebKit:

CVPixelBufferConformer makes use of hardware acceleration to perform colorspace conversions,
and these calls fail when IOKit access is blocked from the WebContent sandbox. The use of
CVPixelBufferConformer (via PixelBufferConformerCV) in nativeImageForCurrentTime() is a
convenince when a web page is using rVFC() to avoid a call into the GPU process when that
callback results in a video->canvas paint. However, this convenience is not strictly necessary,
and by reverting this optimization, the conformance of the resulting pixel buffer is
performed upon request in the GPU process instead.

* GPUProcess/media/RemoteMediaPlayerProxy.h:
* GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerOnNewVideoFrameMetadata):
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::stopVideoFrameMetadataGathering):
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::pushVideoFrameMetadata):
(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
trunk/Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in
trunk/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (293838 => 293839)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 16:02:39 UTC (rev 293838)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 16:13:05 UTC (rev 293839)
@@ -1,3 +1,22 @@
+2022-05-05  Jer Noble  
+
+[WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()
+https://bugs.webkit.org/show_bug.cgi?id=240108
+
+
+Reviewed by Simon Fraser.
+
+No longer pass a CVPixelBufferRef up through onNewVideoFrameMetadata().
+
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::onNewVideoFrameMetadata):
+* platform/graphics/MediaPlayer.h:
+(WebCore::MediaPlayerClient::mediaPlayerOnNewVideoFrameMetadata):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::checkNewVideoFrameMetadata):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::checkNewVideoFrameMetadata):
+
 2022-05-05  Kate Cheney  
 
 Right click using trackpad crashes Safari


Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (293838 => 293839)

--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp	2022-05-05 16:02:39 UTC (rev 293838)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp	2022-05-05 16:13:05 UTC (rev 293839)
@@ -1780,9 +1780,9 @@
 }
 
 #if PLATFORM(COCOA)
-void MediaPlayer::onNewVideoFrameMetadata(VideoFrameMetadata&& metadata, RetainPtr&& buffer)
+void MediaPlayer::onNewVideoFrameMetadata(VideoFrameMetadata&& metadata)
 {
-client().mediaPlayerOnNewVideoFrameMetadata(WTFMove(metadata), WTFMove(buffer));
+client().mediaPlayerOnNewVideoFrameMetadata(WTFMove(metadata));
 }
 #endif
 


Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (293838 => 293839)

--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h	

[webkit-changes] [293838] trunk/Tools/buildstream

[commit-queue]

Title: [293838] trunk/Tools/buildstream








Revision 293838
Author commit-qu...@webkit.org
Date 2022-05-05 09:02:39 -0700 (Thu, 05 May 2022)


Log Message
[Flatpak SDK] Bump to GStreamer 1.20.2
https://bugs.webkit.org/show_bug.cgi?id=240121

Patch by Philippe Normand  on 2022-05-05
Reviewed by Adrian Perez de Castro.

* elements/sdk/gst-libav.bst:
* elements/sdk/gst-plugins-bad.bst:
* elements/sdk/gst-plugins-base.bst:
* elements/sdk/gst-plugins-good.bst:
* elements/sdk/gst-plugins-ugly.bst:
* elements/sdk/gstreamer.bst:
* patches/gstreamer-0001-typefind-Skip-parsing-of-data-URIs.patch: Removed.
* patches/gstreamer-0002-uri-Build-doubly-linked-list-by-prepending-items.patch: Removed.

Canonical link: https://commits.webkit.org/250311@main

Modified Paths

trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/elements/sdk/gst-libav.bst
trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst
trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst
trunk/Tools/buildstream/elements/sdk/gst-plugins-good.bst
trunk/Tools/buildstream/elements/sdk/gst-plugins-ugly.bst
trunk/Tools/buildstream/elements/sdk/gstreamer.bst


Removed Paths

trunk/Tools/buildstream/patches/gstreamer-0001-typefind-Skip-parsing-of-data-URIs.patch
trunk/Tools/buildstream/patches/gstreamer-0002-uri-Build-doubly-linked-list-by-prepending-items.patch




Diff

Modified: trunk/Tools/buildstream/ChangeLog (293837 => 293838)

--- trunk/Tools/buildstream/ChangeLog	2022-05-05 15:55:46 UTC (rev 293837)
+++ trunk/Tools/buildstream/ChangeLog	2022-05-05 16:02:39 UTC (rev 293838)
@@ -1,3 +1,19 @@
+2022-05-05  Philippe Normand  
+
+[Flatpak SDK] Bump to GStreamer 1.20.2
+https://bugs.webkit.org/show_bug.cgi?id=240121
+
+Reviewed by Adrian Perez de Castro.
+
+* elements/sdk/gst-libav.bst:
+* elements/sdk/gst-plugins-bad.bst:
+* elements/sdk/gst-plugins-base.bst:
+* elements/sdk/gst-plugins-good.bst:
+* elements/sdk/gst-plugins-ugly.bst:
+* elements/sdk/gstreamer.bst:
+* patches/gstreamer-0001-typefind-Skip-parsing-of-data-URIs.patch: Removed.
+* patches/gstreamer-0002-uri-Build-doubly-linked-list-by-prepending-items.patch: Removed.
+
 2022-04-24  Philippe Normand  
 
 [Flatpak SDK] Partial revert of r249480


Modified: trunk/Tools/buildstream/elements/sdk/gst-libav.bst (293837 => 293838)

--- trunk/Tools/buildstream/elements/sdk/gst-libav.bst	2022-05-05 15:55:46 UTC (rev 293837)
+++ trunk/Tools/buildstream/elements/sdk/gst-libav.bst	2022-05-05 16:02:39 UTC (rev 293838)
@@ -1,8 +1,8 @@
 kind: meson
 sources:
 - kind: tar
-  url: gst_downloads:gst-libav/gst-libav-1.20.1.tar.xz
-  ref: 91a71fb633b75e1bd52e22a457845cb0ba563a2972ba5954ec88448f443a9fc7
+  url: gst_downloads:gst-libav/gst-libav-1.20.2.tar.xz
+  ref: b5c531dd8413bf771c79dab66b8e389f20b3991f745115133f0fa0b8e32809f9
 build-depends:
 - freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst
 - freedesktop-sdk.bst:components/nasm.bst


Modified: trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst (293837 => 293838)

--- trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst	2022-05-05 15:55:46 UTC (rev 293837)
+++ trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst	2022-05-05 16:02:39 UTC (rev 293838)
@@ -1,8 +1,8 @@
 kind: meson
 sources:
 - kind: tar
-  url: gst_downloads:gst-plugins-bad/gst-plugins-bad-1.20.1.tar.xz
-  ref: 09d3c2cf5911f0bc7da6bf557a55251779243d3de216b6a26cc90c445b423848
+  url: gst_downloads:gst-plugins-bad/gst-plugins-bad-1.20.2.tar.xz
+  ref: 4adc4c05f41051f8136b80cda99b0d049a34e777832f9fea7c5a70347658745b
 build-depends:
 - freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst
 depends:


Modified: trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst (293837 => 293838)

--- trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst	2022-05-05 15:55:46 UTC (rev 293837)
+++ trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst	2022-05-05 16:02:39 UTC (rev 293838)
@@ -1,8 +1,8 @@
 kind: meson
 sources:
 - kind: tar
-  url: gst_downloads:gst-plugins-base/gst-plugins-base-1.20.1.tar.xz
-  ref: 96d8a6413ba9394fbec1217aeef63741a729d476a505a797c1d5337d8fa7c204
+  url: gst_downloads:gst-plugins-base/gst-plugins-base-1.20.2.tar.xz
+  ref: ab0656f2ad4d38292a803e0cb4ca090943a9b43c8063f650b4d3e3606c317f17
 build-depends:
 - freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst
 depends:


Modified: trunk/Tools/buildstream/elements/sdk/gst-plugins-good.bst (293837 => 293838)

--- trunk/Tools/buildstream/elements/sdk/gst-plugins-good.bst	2022-05-05 15:55:46 UTC (rev 293837)
+++ trunk/Tools/buildstream/elements/sdk/gst-plugins-good.bst	2022-05-05 16:02:39 UTC (rev 293838)
@@ -1,8 +1,8 @@
 kind: meson
 sources:
 - kind: tar
-  url: gst_downloads:gst-plugins-good/gst-plugins-good-1.20.1.tar.xz
-  ref: 3c66876f821d507bcdbebffb08b4f31a322727d6753f65a0f02c905ecb7084aa
+  url: gst_downloads:gst-plugins-good/gst-plugins-good-1.20.2.tar.xz
+  ref: 

[webkit-changes] [293837] trunk/Source/WebKit

[simon . fraser]

Title: [293837] trunk/Source/WebKit








Revision 293837
Author simon.fra...@apple.com
Date 2022-05-05 08:55:46 -0700 (Thu, 05 May 2022)


Log Message
Optimize IPC Decoding for primitive types
https://bugs.webkit.org/show_bug.cgi?id=240106

Reviewed by Cameron McCormack.

Calls to memmove() showed up on profiles under Decoder::decodeFixedLengthData() for
primitive types. Allow the compiler to optimize these away by inlining Decoder::decodeFixedLengthData()
and related functions.

* Platform/IPC/Decoder.cpp:
(IPC::roundUpToAlignment): Deleted.
(IPC::alignedBufferIsLargeEnoughToContain): Deleted.
(IPC::Decoder::alignBufferPosition): Deleted.
(IPC::Decoder::bufferIsLargeEnoughToContain const): Deleted.
(IPC::Decoder::decodeFixedLengthData): Deleted.
* Platform/IPC/Decoder.h:
(IPC::roundUpToAlignment):
(IPC::alignedBufferIsLargeEnoughToContain):
(IPC::Decoder::alignBufferPosition):
(IPC::Decoder::bufferIsLargeEnoughToContain const):
(IPC::Decoder::decodeFixedLengthData):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Decoder.cpp
trunk/Source/WebKit/Platform/IPC/Decoder.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (293836 => 293837)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 15:48:01 UTC (rev 293836)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 15:55:46 UTC (rev 293837)
@@ -1,3 +1,27 @@
+2022-05-04  Simon Fraser  
+
+Optimize IPC Decoding for primitive types
+https://bugs.webkit.org/show_bug.cgi?id=240106
+
+Reviewed by Cameron McCormack.
+
+Calls to memmove() showed up on profiles under Decoder::decodeFixedLengthData() for
+primitive types. Allow the compiler to optimize these away by inlining Decoder::decodeFixedLengthData()
+and related functions.
+
+* Platform/IPC/Decoder.cpp:
+(IPC::roundUpToAlignment): Deleted.
+(IPC::alignedBufferIsLargeEnoughToContain): Deleted.
+(IPC::Decoder::alignBufferPosition): Deleted.
+(IPC::Decoder::bufferIsLargeEnoughToContain const): Deleted.
+(IPC::Decoder::decodeFixedLengthData): Deleted.
+* Platform/IPC/Decoder.h:
+(IPC::roundUpToAlignment):
+(IPC::alignedBufferIsLargeEnoughToContain):
+(IPC::Decoder::alignBufferPosition):
+(IPC::Decoder::bufferIsLargeEnoughToContain const):
+(IPC::Decoder::decodeFixedLengthData):
+
 2022-05-05  Youenn Fablet  
 
 Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases


Modified: trunk/Source/WebKit/Platform/IPC/Decoder.cpp (293836 => 293837)

--- trunk/Source/WebKit/Platform/IPC/Decoder.cpp	2022-05-05 15:48:01 UTC (rev 293836)
+++ trunk/Source/WebKit/Platform/IPC/Decoder.cpp	2022-05-05 15:55:46 UTC (rev 293837)
@@ -151,53 +151,6 @@
 return Decoder::create(wrappedMessage.data(), wrappedMessage.size(), WTFMove(attachments));
 }
 
-static inline const uint8_t* roundUpToAlignment(const uint8_t* ptr, size_t alignment)
-{
-// Assert that the alignment is a power of 2.
-ASSERT(alignment && !(alignment & (alignment - 1)));
-
-uintptr_t alignmentMask = alignment - 1;
-return reinterpret_cast((reinterpret_cast(ptr) + alignmentMask) & ~alignmentMask);
-}
-
-static inline bool alignedBufferIsLargeEnoughToContain(const uint8_t* alignedPosition, const uint8_t* bufferStart, const uint8_t* bufferEnd, size_t size)
-{
-// When size == 0 for the last argument and it's a variable length byte array,
-// bufferStart == alignedPosition == bufferEnd, so checking (bufferEnd >= alignedPosition)
-// is not an off-by-one error since (static_cast(bufferEnd - alignedPosition) >= size)
-// will catch issues when size != 0.
-return bufferEnd >= alignedPosition && bufferStart <= alignedPosition && static_cast(bufferEnd - alignedPosition) >= size;
-}
-
-bool Decoder::alignBufferPosition(size_t alignment, size_t size)
-{
-const uint8_t* alignedPosition = roundUpToAlignment(m_bufferPos, alignment);
-if (UNLIKELY(!alignedBufferIsLargeEnoughToContain(alignedPosition, m_buffer, m_bufferEnd, size))) {
-// We've walked off the end of this buffer.
-markInvalid();
-return false;
-}
-
-m_bufferPos = alignedPosition;
-return true;
-}
-
-bool Decoder::bufferIsLargeEnoughToContain(size_t alignment, size_t size) const
-{
-return alignedBufferIsLargeEnoughToContain(roundUpToAlignment(m_bufferPos, alignment), m_buffer, m_bufferEnd, size);
-}
-
-bool Decoder::decodeFixedLengthData(uint8_t* data, size_t size, size_t alignment)
-{
-if (!alignBufferPosition(alignment, size))
-return false;
-
-memcpy(data, m_bufferPos, size);
-m_bufferPos += size;
-
-return true;
-}
-
 const uint8_t* Decoder::decodeFixedLengthReference(size_t size, size_t alignment)
 {
 if (!alignBufferPosition(alignment, size))


Modified: trunk/Source/WebKit/Platform/IPC/Decoder.h (293836 => 293837)

--- trunk/Source/WebKit/Platform/IPC/Decoder.h	2022-05-05 15:48:01 UTC (rev 293836)
+++ 

[webkit-changes] [293835] trunk

[katherine_cheney]

Title: [293835] trunk








Revision 293835
Author katherine_che...@apple.com
Date 2022-05-05 08:36:07 -0700 (Thu, 05 May 2022)


Log Message
Right click using trackpad crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=240030
rdar://91786269

Reviewed by Tim Horton.

Source/WebCore:

Trackpad on iOS should mimic mac selection behavior and block context
menu clicks that are not made on a text node.

* page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestContextualWordOrLinkFromHitTestResult):
(WebCore::EventHandler::sendContextMenuEvent):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/emptyTable.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/emptyTable.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (293834 => 293835)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 15:18:38 UTC (rev 293834)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 15:36:07 UTC (rev 293835)
@@ -1,3 +1,18 @@
+2022-05-05  Kate Cheney  
+
+Right click using trackpad crashes Safari
+https://bugs.webkit.org/show_bug.cgi?id=240030
+rdar://91786269
+
+Reviewed by Tim Horton.
+
+Trackpad on iOS should mimic mac selection behavior and block context
+menu clicks that are not made on a text node.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::selectClosestContextualWordOrLinkFromHitTestResult):
+(WebCore::EventHandler::sendContextMenuEvent):
+
 2022-05-05  Youenn Fablet  
 
 Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases


Modified: trunk/Source/WebCore/page/EventHandler.cpp (293834 => 293835)

--- trunk/Source/WebCore/page/EventHandler.cpp	2022-05-05 15:18:38 UTC (rev 293834)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2022-05-05 15:36:07 UTC (rev 293835)
@@ -566,6 +566,12 @@
 
 void EventHandler::selectClosestContextualWordOrLinkFromHitTestResult(const HitTestResult& result, AppendTrailingWhitespace appendTrailingWhitespace)
 {
+// FIXME: In the editable case, word selection sometimes selects content that isn't underneath the mouse.
+// If the selection is non-editable, we do word selection to make it easier to use the contextual menu items
+// available for text selections. But only if we're above text.
+if (!m_frame.selection().selection().isContentEditable() && !is(result.targetNode()))
+return;
+
 RefPtr urlElement = result.URLElement();
 if (!urlElement || !isDraggableLink(*urlElement)) {
 if (RefPtr targetNode = result.targetNode()) {
@@ -3272,11 +3278,7 @@
 return false;
 
 if (m_frame.editor().behavior().shouldSelectOnContextualMenuClick()
-&& !m_frame.selection().contains(viewportPos)
-// FIXME: In the editable case, word selection sometimes selects content that isn't underneath the mouse.
-// If the selection is non-editable, we do word selection to make it easier to use the contextual menu items
-// available for text selections.  But only if we're above text.
-&& (m_frame.selection().selection().isContentEditable() || (mouseEvent.targetNode() && mouseEvent.targetNode()->isTextNode( {
+&& !m_frame.selection().contains(viewportPos)) {
 m_mouseDownMayStartSelect = true; // context menu events are always allowed to perform a selection
 selectClosestContextualWordOrLinkFromHitTestResult(mouseEvent.hitTestResult(), shouldAppendTrailingWhitespace(mouseEvent, m_frame));
 }


Modified: trunk/Tools/ChangeLog (293834 => 293835)

--- trunk/Tools/ChangeLog	2022-05-05 15:18:38 UTC (rev 293834)
+++ trunk/Tools/ChangeLog	2022-05-05 15:36:07 UTC (rev 293835)
@@ -1,3 +1,16 @@
+2022-05-05  Kate Cheney  
+
+Right click using trackpad crashes Safari
+https://bugs.webkit.org/show_bug.cgi?id=240030
+rdar://91786269
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit/emptyTable.html: Added.
+* TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
+(TEST):
+
 2022-05-04  Jonathan Bedard  
 
 [webkitbugspy] Include mocks in package


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (293834 => 293835)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2022-05-05 15:18:38 UTC (rev 293834)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2022-05-05 15:36:07 UTC (rev 293835)
@@ -258,6 +258,7 @@
 		498D030A26376B34009CBFAD /* resourceLoadStatisticsMissingUniqueIndex.db in Copy Resources */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [293834] trunk/LayoutTests

[rackler]

Title: [293834] trunk/LayoutTests








Revision 293834
Author rack...@apple.com
Date 2022-05-05 08:18:38 -0700 (Thu, 05 May 2022)


Log Message
[Gardening]REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240074

Unreviewed test gardening.

Canonical link: https://commits.webkit.org/250307@main

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (293833 => 293834)

--- trunk/LayoutTests/ChangeLog	2022-05-05 15:15:24 UTC (rev 293833)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 15:18:38 UTC (rev 293834)
@@ -1,3 +1,12 @@
+2022-05-05  Karl Rackler  
+
+[Gardening]REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=240074
+
+Unreviewed test gardening. 
+
+* platform/mac-wk2/TestExpectations:
+
 2022-05-05  Ziran Sun  
 
  should have box-sizing: border-box in UA stylesheet


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (293833 => 293834)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-05-05 15:15:24 UTC (rev 293833)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-05-05 15:18:38 UTC (rev 293834)
@@ -928,8 +928,6 @@
 
 webkit.org/b/183164 fast/dom/Window/window-focus-self.html [ Pass Failure ]
 
-webkit.org/b/180982 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html [ Slow ]
-
 webkit.org/b/229473 media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Pass Timeout ]
 
 webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293833] trunk/Source

[youenn]

Title: [293833] trunk/Source








Revision 293833
Author you...@apple.com
Date 2022-05-05 08:15:24 -0700 (Thu, 05 May 2022)


Log Message
Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases
https://bugs.webkit.org/show_bug.cgi?id=236066


Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

* platform/cocoa/SharedVideoFrameInfo.mm:
(WebCore::SharedVideoFrameInfo::writePixelBuffer):

Source/WebKit:

* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::prepareWriting):
(WebKit::SharedVideoFrameReader::readBufferFromSharedMemory):
(WebKit::SharedVideoFrameReader::readBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293832 => 293833)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 15:04:50 UTC (rev 293832)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 15:15:24 UTC (rev 293833)
@@ -1,3 +1,16 @@
+2022-05-05  Youenn Fablet  
+
+Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases
+https://bugs.webkit.org/show_bug.cgi?id=236066
+
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* platform/cocoa/SharedVideoFrameInfo.mm:
+(WebCore::SharedVideoFrameInfo::writePixelBuffer):
+
 2022-05-05  Ziran Sun  
 
  should have box-sizing: border-box in UA stylesheet


Modified: trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm (293832 => 293833)

--- trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm	2022-05-05 15:04:50 UTC (rev 293832)
+++ trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm	2022-05-05 15:15:24 UTC (rev 293833)
@@ -178,8 +178,10 @@
 bool SharedVideoFrameInfo::writePixelBuffer(CVPixelBufferRef pixelBuffer, uint8_t* data)
 {
 auto result = CVPixelBufferLockBaseAddress(pixelBuffer, kCVPixelBufferLock_ReadOnly);
-if (result != kCVReturnSuccess)
+if (result != kCVReturnSuccess) {
+RELEASE_LOG_ERROR(WebRTC, "SharedVideoFrameInfo::writePixelBuffer lock failed");
 return false;
+}
 
 auto scope = makeScopeExit([] {
 CVPixelBufferUnlockBaseAddress(pixelBuffer, kCVPixelBufferLock_ReadOnly);


Modified: trunk/Source/WebKit/ChangeLog (293832 => 293833)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 15:04:50 UTC (rev 293832)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 15:15:24 UTC (rev 293833)
@@ -1,3 +1,16 @@
+2022-05-05  Youenn Fablet  
+
+Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases
+https://bugs.webkit.org/show_bug.cgi?id=236066
+
+
+Reviewed by Eric Carlson.
+
+* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
+(WebKit::SharedVideoFrameWriter::prepareWriting):
+(WebKit::SharedVideoFrameReader::readBufferFromSharedMemory):
+(WebKit::SharedVideoFrameReader::readBuffer):
+
 2022-05-05  Kimmo Kinnunen  
 
 Connecting to GPU process may hang if UI process sends sync message simultaneously


Modified: trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp (293832 => 293833)

--- trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp	2022-05-05 15:04:50 UTC (rev 293832)
+++ trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp	2022-05-05 15:15:24 UTC (rev 293833)
@@ -79,16 +79,22 @@
 
 bool SharedVideoFrameWriter::prepareWriting(const SharedVideoFrameInfo& info, const Function& newSemaphoreCallback, const Function& newMemoryCallback)
 {
-if (!info.isReadWriteSupported())
+if (!info.isReadWriteSupported()) {
+RELEASE_LOG_ERROR(WebRTC, "SharedVideoFrameWriter::prepareWriting not supported");
 return false;
+}
 
-if (!wait(newSemaphoreCallback))
+if (!wait(newSemaphoreCallback)) {
+RELEASE_LOG_ERROR(WebRTC, "SharedVideoFrameReader::writeBuffer wait failed");
 return false;
+}
 
 size_t size = info.storageSize();
 if (!m_storage || m_storage->size() < size) {
-if (!allocateStorage(size, newMemoryCallback))
+if (!allocateStorage(size, newMemoryCallback)) {
+RELEASE_LOG_ERROR(WebRTC, "SharedVideoFrameReader::writeBuffer allocation failed");
 return false;
+}
 }
 return true;
 }
@@ -174,8 +180,10 @@
 
 RetainPtr SharedVideoFrameReader::readBufferFromSharedMemory()
 {
-if (!m_storage)
+if (!m_storage) {
+RELEASE_LOG_ERROR(WebRTC, "SharedVideoFrameReader::readBufferFromSharedMemory no storage");
 return { };
+}
 
 auto scope = makeScopeExit([&] {
 m_semaphore.signal();
@@ -183,14 +191,20 @@
 
 auto* data = "" uint8_t*>(m_storage->data());
 auto info = SharedVideoFrameInfo::decode({ data, m_storage->size() });
-if (!info)
+if (!info) {
+RELEASE_LOG_ERROR(WebRTC, 

[webkit-changes] [293832] trunk/Tools

[jbedard]

Title: [293832] trunk/Tools








Revision 293832
Author jbed...@apple.com
Date 2022-05-05 08:04:50 -0700 (Thu, 05 May 2022)


Log Message
[webkitbugspy] Include mocks in package
https://bugs.webkit.org/show_bug.cgi?id=240098


Reviewed by Aakash Jain.

* Scripts/libraries/webkitbugspy/setup.py:
* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py:

Canonical link: https://commits.webkit.org/250305@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitbugspy/setup.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py




Diff

Modified: trunk/Tools/ChangeLog (293831 => 293832)

--- trunk/Tools/ChangeLog	2022-05-05 15:01:54 UTC (rev 293831)
+++ trunk/Tools/ChangeLog	2022-05-05 15:04:50 UTC (rev 293832)
@@ -1,3 +1,14 @@
+2022-05-04  Jonathan Bedard  
+
+[webkitbugspy] Include mocks in package
+https://bugs.webkit.org/show_bug.cgi?id=240098
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitbugspy/setup.py:
+* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py:
+
 2022-05-05  Jonathan Bedard  
 
 [git-webkit] Fetch alternate remotes when adding remote


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/setup.py (293831 => 293832)

--- trunk/Tools/Scripts/libraries/webkitbugspy/setup.py	2022-05-05 15:01:54 UTC (rev 293831)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/setup.py	2022-05-05 15:04:50 UTC (rev 293832)
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitbugspy',
-version='0.5.4',
+version='0.6.0',
 description='Library containing a shared API for various bug trackers.',
 long_description=readme(),
 classifiers=[
@@ -49,6 +49,8 @@
 license='Modified BSD',
 packages=[
 'webkitbugspy',
+'webkitbugspy.mocks',
+'webkitbugspy.tests',
 ],
 install_requires=[
 'webkitcorepy',


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py (293831 => 293832)

--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py	2022-05-05 15:01:54 UTC (rev 293831)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py	2022-05-05 15:04:50 UTC (rev 293832)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(0, 5, 4)
+version = Version(0, 6, 0)
 
 from .user import User
 from .issue import Issue






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293831] trunk/Tools

[jbedard]

Title: [293831] trunk/Tools








Revision 293831
Author jbed...@apple.com
Date 2022-05-05 08:01:54 -0700 (Thu, 05 May 2022)


Log Message
[git-webkit] Fetch alternate remotes when adding remote
https://bugs.webkit.org/show_bug.cgi?id=240066


Reviewed by Ryan Haddad.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto,
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Mock `git fetch`
for non-fork remotes.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup._add_remote): Optionally fetch remote after adding it.
(Setup.git):

Canonical link: https://commits.webkit.org/250304@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py




Diff

Modified: trunk/Tools/ChangeLog (293830 => 293831)

--- trunk/Tools/ChangeLog	2022-05-05 14:45:07 UTC (rev 293830)
+++ trunk/Tools/ChangeLog	2022-05-05 15:01:54 UTC (rev 293831)
@@ -1,3 +1,19 @@
+2022-05-05  Jonathan Bedard  
+
+[git-webkit] Fetch alternate remotes when adding remote
+https://bugs.webkit.org/show_bug.cgi?id=240066
+
+
+Reviewed by Ryan Haddad.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto,
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Mock `git fetch`
+for non-fork remotes.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
+(Setup._add_remote): Optionally fetch remote after adding it.
+(Setup.git):
+
 2022-05-04  Chris Dumez  
 
 REGRESSION(r293703):[ BigSur+ iOS ] TestWTF.WTF_URLExtras.URLExtras_ParsingError (API-Test) is a constant failure


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (293830 => 293831)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-05 14:45:07 UTC (rev 293830)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-05 15:01:54 UTC (rev 293831)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='4.12.3',
+version='4.12.4',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (293830 => 293831)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-05 14:45:07 UTC (rev 293830)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-05 15:01:54 UTC (rev 293831)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(4, 12, 3)
+version = Version(4, 12, 4)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py (293830 => 293831)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py	2022-05-05 14:45:07 UTC (rev 293830)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py	2022-05-05 15:01:54 UTC (rev 293831)
@@ -1,4 +1,4 @@
-# Copyright (C) 2020, 2021 Apple Inc. All rights reserved.
+# Copyright (C) 2020-2022 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -449,7 +449,7 @@
 generator=lambda *args, **kwargs:
 self.edit_config(args[2], args[3]),
 ), mocks.Subprocess.Route(
-self.executable, 'fetch', 'fork',
+self.executable, 'fetch', re.compile(r'.+'),
 cwd=self.path,
 completion=mocks.ProcessCompletion(
 returncode=0,


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py (293830 => 293831)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py	2022-05-05 14:45:07 UTC (rev 293830)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py	2022-05-05 15:01:54 UTC (rev 293831)
@@ -95,7 +95,7 @@
 return result
 
 @classmethod
-def _add_remote(cls, repository, name, url):
+def _add_remote(cls, repository, name, url, fetch=True):
 returncode = run(
 [repository.executable(), 'remote', 'add', name, url],
 capture_output=True, cwd=repository.root_path,
@@ -110,6 +110,18 @@
 return 1
 
 log.info("Added remote '{}'".format(name))
+
+if not fetch:
+return 0
+
+returncode = run(
+[repository.executable(), 'fetch', 

[webkit-changes] [293830] trunk

[zsun]

Title: [293830] trunk








Revision 293830
Author z...@igalia.com
Date 2022-05-05 07:45:07 -0700 (Thu, 05 May 2022)


Log Message
 should have box-sizing: border-box in UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=197878

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

* web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:

Source/WebCore:

As discussed at [1], We should have box-sizing: border-box for , the same
as buttons. WebKit currently has content-box. This patch is to change it to box-box.

Since  is disabled with WebKitLegacy [2], this fix doesn't apply to it. Hence,
for mac-wk1 platform, the test expectation for html/rendering/non-replaced-elements/form-controls/resets.html
stays as it is.

[1] https://github.com/whatwg/html/issues/4281
[2] https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::colorInputStyleSheet const):

LayoutTests:

* platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderThemeIOS.mm


Added Paths

trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (293829 => 293830)

--- trunk/LayoutTests/ChangeLog	2022-05-05 13:42:39 UTC (rev 293829)
+++ trunk/LayoutTests/ChangeLog	2022-05-05 14:45:07 UTC (rev 293830)
@@ -1,3 +1,13 @@
+2022-05-05  Ziran Sun  
+
+ should have box-sizing: border-box in UA stylesheet
+https://bugs.webkit.org/show_bug.cgi?id=197878
+
+Reviewed by Tim Nguyen.
+
+* platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
+* platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt.
+
 2022-05-04  Devin Rousso  
 
 [Apple Pay] REGRESSION(r291588): `appearance: -apple-pay-button` doesn't work with `border-width: 0`


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293829 => 293830)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-05-05 13:42:39 UTC (rev 293829)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-05-05 14:45:07 UTC (rev 293830)
@@ -1,3 +1,12 @@
+2022-05-05  Ziran Sun  
+
+ should have box-sizing: border-box in UA stylesheet
+https://bugs.webkit.org/show_bug.cgi?id=197878
+
+Reviewed by Tim Nguyen.
+
+* web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
+
 2022-05-04  Ziran Sun  
 
 [InputElement] Selection after type change needs to follow HTML specification


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt (293829 => 293830)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-05-05 13:42:39 UTC (rev 293829)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-05-05 14:45:07 UTC (rev 293830)
@@ -134,7 +134,7 @@
 PASS  - text-shadow
 PASS  - text-align
 PASS  - display
-FAIL  - box-sizing assert_equals: expected "border-box" but got "content-box"
+PASS  - box-sizing
 PASS  - letter-spacing
 PASS  - word-spacing
 PASS  - line-height


Modified: trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt (293829 => 293830)

--- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-05-05 13:42:39 UTC (rev 293829)
+++ 

[webkit-changes] [293829] trunk/Source/WebKit

[commit-queue]

Title: [293829] trunk/Source/WebKit








Revision 293829
Author commit-qu...@webkit.org
Date 2022-05-05 06:42:39 -0700 (Thu, 05 May 2022)


Log Message
Connecting to GPU process may hang if UI process sends sync message simultaneously
https://bugs.webkit.org/show_bug.cgi?id=239905

Patch by Kimmo Kinnunen  on 2022-05-05
Reviewed by Chris Dumez.

Previously, establishing GPU process connection would be a sync message:
 1. WP -> UI sync GetGPUProcessConnection
 2. UI -> GPUP async CreateGPUConnectionToWebProcess
 3. GPUP -> UI async reply CreateGPUConnectionToWebProcess
 4. UI -> WP sync reply GetGPUProcessConnection

If UI would send a message to WP after step 3 and wait for reply, this
would never come as WP would be waiting for the sync reply for GetGPUProcessConnection.

This would happen for example with requestAutocorrectionContextWithCompletionHandler,
which would send HandleAutocorrectionContextRequest and wait for
Messages::WebPageProxy::HandleAutocorrectionContext messages.

Mitigate this by creating the GPU connection in WP and sending
that to GPUP through UI in an async message. This way WP does not block on the GPUP
connection initialization. Send the GPUP connection initialization result, audit token and
vp9 HW decoder presence, as the first user message through the new connection.

* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::create):
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
* GPUProcess/GPUConnectionToWebProcess.h:
* GPUProcess/GPUProcess.cpp:
(WebKit::asConnectionIdentifier):
(WebKit::GPUProcess::createGPUConnectionToWebProcess):
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* Shared/GPUProcessConnectionInitializationParameters.h:
(WebKit::GPUProcessConnectionInitializationParameters::decode):
* Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
* UIProcess/GPU/GPUProcessProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createGPUProcessConnection):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createGPUProcessConnection):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::getGPUProcessConnectionParameters):
(WebKit::GPUProcessConnection::create):
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::auditToken):
(WebKit::GPUProcessConnection::invalidate):
(WebKit::GPUProcessConnection::didInitialize):
(WebKit::GPUProcessConnection::waitForDidInitialize):
(WebKit::GPUProcessConnection::hasVP9HardwareDecoder):
* WebProcess/GPU/GPUProcessConnection.h:
* WebProcess/GPU/GPUProcessConnection.messages.in:
* WebProcess/GPU/GPUProcessConnectionInfo.h:
(WebKit::GPUProcessConnectionInfo::encode const):
(WebKit::GPUProcessConnectionInfo::decode):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureGPUProcessConnection):
* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in
trunk/Source/WebKit/Shared/GPUProcessConnectionParameters.h
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.messages.in
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnectionInfo.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm


Removed Paths

trunk/Source/WebKit/Shared/GPUProcessConnectionInitializationParameters.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (293828 => 293829)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 12:12:52 UTC (rev 293828)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 13:42:39 UTC (rev 293829)
@@ -1,3 +1,71 @@
+2022-05-05  Kimmo Kinnunen  
+
+Connecting to GPU process may hang if UI process sends sync message simultaneously
+https://bugs.webkit.org/show_bug.cgi?id=239905
+
+Reviewed by Chris Dumez.
+
+Previously, establishing GPU process connection would be a sync message:
+ 1. WP -> UI sync 

[webkit-changes] [293828] trunk/Source/JavaScriptCore

[dpino]

Title: [293828] trunk/Source/_javascript_Core








Revision 293828
Author dp...@igalia.com
Date 2022-05-05 05:12:52 -0700 (Thu, 05 May 2022)


Log Message
[GCC] REGRESSION(r293605): error: cannot convert ‘’ to ‘unsigned char:3’ in initialization
https://bugs.webkit.org/show_bug.cgi?id=239897

Reviewed by Yusuke Suzuki.

* bytecode/MethodOfGettingAValueProfile.h: Move initialization of 'm_kind' to class constructor.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/MethodOfGettingAValueProfile.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (293827 => 293828)

--- trunk/Source/_javascript_Core/ChangeLog	2022-05-05 09:48:57 UTC (rev 293827)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-05-05 12:12:52 UTC (rev 293828)
@@ -1,3 +1,12 @@
+2022-05-05  Diego Pino Garcia  
+
+[GCC] REGRESSION(r293605): error: cannot convert ‘’ to ‘unsigned char:3’ in initialization
+https://bugs.webkit.org/show_bug.cgi?id=239897
+
+Reviewed by Yusuke Suzuki.
+
+* bytecode/MethodOfGettingAValueProfile.h: Move initialization of 'm_kind' to class constructor.
+
 2022-05-04  Yusuke Suzuki  
 
 [JSC] Intl.NumberFormat lacks some validation for rounding-increment


Modified: trunk/Source/_javascript_Core/bytecode/MethodOfGettingAValueProfile.h (293827 => 293828)

--- trunk/Source/_javascript_Core/bytecode/MethodOfGettingAValueProfile.h	2022-05-05 09:48:57 UTC (rev 293827)
+++ trunk/Source/_javascript_Core/bytecode/MethodOfGettingAValueProfile.h	2022-05-05 12:12:52 UTC (rev 293828)
@@ -47,7 +47,10 @@
 
 class MethodOfGettingAValueProfile {
 public:
-MethodOfGettingAValueProfile() = default;
+MethodOfGettingAValueProfile()
+: m_kind(Kind::None)
+{
+}
 
 static MethodOfGettingAValueProfile unaryArithProfile(CodeOrigin codeOrigin)
 {
@@ -110,7 +113,7 @@
 
 CodeOrigin m_codeOrigin;
 uint64_t m_rawOperand : Operand::maxBits { 0 };
-Kind m_kind : bitsOfKind { Kind::None };
+Kind m_kind : bitsOfKind;
 };
 
 } // namespace JSC






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293827] trunk/Source/WebCore

[youenn]

Title: [293827] trunk/Source/WebCore








Revision 293827
Author you...@apple.com
Date 2022-05-05 02:48:57 -0700 (Thu, 05 May 2022)


Log Message
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978


Reviewed by Eric Carlson.

We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.

Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293826 => 293827)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 08:33:31 UTC (rev 293826)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 09:48:57 UTC (rev 293827)
@@ -1,3 +1,20 @@
+2022-05-05  Youenn Fablet  
+
+replaceTrack with different constraints stops sending packets
+https://bugs.webkit.org/show_bug.cgi?id=239978
+
+
+Reviewed by Eric Carlson.
+
+We should always reconfigure the microphone processor even if we are not using it,
+as VPIO expects that input and output formats should match.
+
+Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+so that we can write a regression test.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
 2022-05-05  Carlos Garcia Campos  
 
 REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (293826 => 293827)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2022-05-05 08:33:31 UTC (rev 293826)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2022-05-05 09:48:57 UTC (rev 293827)
@@ -298,9 +298,6 @@
 {
 ASSERT(isMainThread());
 
-if (!isProducingMicrophoneSamples())
-return noErr;
-
 AURenderCallbackStruct callback = { microphoneCallback, this };
 auto err = PAL::AudioUnitSetProperty(m_ioUnit, kAudioOutputUnitProperty_SetInputCallback, kAudioUnitScope_Global, inputBus, , sizeof(callback));
 if (err) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293826] trunk/Source/WebCore

[commit-queue]

Title: [293826] trunk/Source/WebCore








Revision 293826
Author commit-qu...@webkit.org
Date 2022-05-05 01:33:31 -0700 (Thu, 05 May 2022)


Log Message
REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
https://bugs.webkit.org/show_bug.cgi?id=239767

Patch by Carlos Garcia Campos  on 2022-05-05
Reviewed by Michael Catanzaro.

Handle the case of PlatformDisplay created with a nullptr GdkDisplay.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::PlatformDisplay):
* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
* platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp
trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293825 => 293826)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 08:19:13 UTC (rev 293825)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 08:33:31 UTC (rev 293826)
@@ -1,3 +1,21 @@
+2022-05-05  Carlos Garcia Campos  
+
+REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
+https://bugs.webkit.org/show_bug.cgi?id=239767
+
+Reviewed by Michael Catanzaro.
+
+Handle the case of PlatformDisplay created with a nullptr GdkDisplay.
+
+* platform/graphics/PlatformDisplay.cpp:
+(WebCore::PlatformDisplay::PlatformDisplay):
+* platform/graphics/wayland/PlatformDisplayWayland.cpp:
+(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
+(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
+* platform/graphics/x11/PlatformDisplayX11.cpp:
+(WebCore::PlatformDisplayX11::PlatformDisplayX11):
+(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
+
 2022-05-05  Said Abou-Hallawa  
 
 [GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor


Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp (293825 => 293826)

--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-05-05 08:19:13 UTC (rev 293825)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-05-05 08:33:31 UTC (rev 293826)
@@ -177,15 +177,17 @@
 , m_eglDisplay(EGL_NO_DISPLAY)
 #endif
 {
+if (m_sharedDisplay) {
 #if USE(ATSPI) && USE(GTK4)
-if (const char* atspiBusAddress = static_cast(g_object_get_data(G_OBJECT(display), "-gtk-atspi-bus-address")))
-m_accessibilityBusAddress = String::fromUTF8(atspiBusAddress);
+if (const char* atspiBusAddress = static_cast(g_object_get_data(G_OBJECT(m_sharedDisplay.get()), "-gtk-atspi-bus-address")))
+m_accessibilityBusAddress = String::fromUTF8(atspiBusAddress);
 #endif
 
-g_signal_connect(m_sharedDisplay.get(), "closed", G_CALLBACK(+[](GdkDisplay*, gboolean, gpointer userData) {
-auto& platformDisplay = *static_cast(userData);
-platformDisplay.sharedDisplayDidClose();
-}), this);
+g_signal_connect(m_sharedDisplay.get(), "closed", G_CALLBACK(+[](GdkDisplay*, gboolean, gpointer userData) {
+auto& platformDisplay = *static_cast(userData);
+platformDisplay.sharedDisplayDidClose();
+}), this);
+}
 }
 
 void PlatformDisplay::sharedDisplayDidClose()


Modified: trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp (293825 => 293826)

--- trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2022-05-05 08:19:13 UTC (rev 293825)
+++ trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp	2022-05-05 08:33:31 UTC (rev 293826)
@@ -86,7 +86,7 @@
 #if PLATFORM(GTK)
 PlatformDisplayWayland::PlatformDisplayWayland(GdkDisplay* display)
 : PlatformDisplay(display)
-, m_display(gdk_wayland_display_get_wl_display(display))
+, m_display(display ? gdk_wayland_display_get_wl_display(display) : nullptr)
 {
 }
 #endif
@@ -99,7 +99,7 @@
 bool nativeDisplayOwned = true;
 #endif
 
-if (nativeDisplayOwned) {
+if (nativeDisplayOwned && m_display) {
 m_compositor = nullptr;
 m_registry = nullptr;
 wl_display_disconnect(m_display);


Modified: trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp (293825 => 293826)

--- trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp	2022-05-05 08:19:13 UTC (rev 293825)
+++ trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp	2022-05-05 08:33:31 UTC (rev 293826)
@@ -96,7 +96,7 @@
 #if PLATFORM(GTK)
 PlatformDisplayX11::PlatformDisplayX11(GdkDisplay* display)
 : PlatformDisplay(display)
-, m_display(GDK_DISPLAY_XDISPLAY(display))

[webkit-changes] [293825] trunk/Source/WebCore

[said]

Title: [293825] trunk/Source/WebCore








Revision 293825
Author s...@apple.com
Date 2022-05-05 01:19:13 -0700 (Thu, 05 May 2022)


Log Message
[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=240100
rdar://92635752

Reviewed by Simon Fraser.

The scaling factor is not set in the GraphicsContext of the
ImageBufferShareableBitmapBackend.

To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
outside the ImageBuffer creation. This is similar to what we do in
GraphicsContext::createAlignedImageBuffer() where we scale the size and
create the ImageBuffer with scaleFactor = 1.

* page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameSnapshotting.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293824 => 293825)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 07:38:15 UTC (rev 293824)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 08:19:13 UTC (rev 293825)
@@ -1,3 +1,22 @@
+2022-05-05  Said Abou-Hallawa  
+
+[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=240100
+rdar://92635752
+
+Reviewed by Simon Fraser.
+
+The scaling factor is not set in the GraphicsContext of the
+ImageBufferShareableBitmapBackend.
+
+To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
+outside the ImageBuffer creation. This is similar to what we do in
+GraphicsContext::createAlignedImageBuffer() where we scale the size and
+create the ImageBuffer with scaleFactor = 1.
+
+* page/FrameSnapshotting.cpp:
+(WebCore::snapshotFrameRectWithClip):
+
 2022-05-05  Youenn Fablet  
 
 SWOriginStore is no longer needed


Modified: trunk/Source/WebCore/page/FrameSnapshotting.cpp (293824 => 293825)

--- trunk/Source/WebCore/page/FrameSnapshotting.cpp	2022-05-05 07:38:15 UTC (rev 293824)
+++ trunk/Source/WebCore/page/FrameSnapshotting.cpp	2022-05-05 08:19:13 UTC (rev 293825)
@@ -115,19 +115,23 @@
 if (options.flags.contains(SnapshotFlags::PaintWithIntegralScaleFactor))
 scaleFactor = ceilf(scaleFactor);
 
+auto scaledImageRect = imageRect;
+scaledImageRect.scale(scaleFactor);
+
 auto purpose = options.flags.contains(SnapshotFlags::Shareable) ? RenderingPurpose::ShareableSnapshot : RenderingPurpose::Snapshot;
 auto hostWindow = (document->view() && document->view()->root()) ? document->view()->root()->hostWindow() : nullptr;
 
-auto buffer = ImageBuffer::create(imageRect.size(), purpose, scaleFactor, options.colorSpace, options.pixelFormat, { }, { hostWindow });
+auto buffer = ImageBuffer::create(scaledImageRect.size(), purpose, 1, options.colorSpace, options.pixelFormat, { }, { hostWindow });
 if (!buffer)
 return nullptr;
 
-buffer->context().translate(-imageRect.x(), -imageRect.y());
+buffer->context().translate(-scaledImageRect.location());
+buffer->context().scale(scaleFactor);
 
 if (!clipRects.isEmpty()) {
 Path clipPath;
 for (auto& rect : clipRects)
-clipPath.addRect(encloseRectToDevicePixels(rect, scaleFactor));
+clipPath.addRect(rect);
 buffer->context().clipPath(clipPath);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293824] trunk/Source

[youenn]

Title: [293824] trunk/Source








Revision 293824
Author you...@apple.com
Date 2022-05-05 00:38:15 -0700 (Thu, 05 May 2022)


Log Message
SWOriginStore is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=240003

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing tests.

* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.cpp:
* workers/service/SWClientConnection.h:
* workers/service/WorkerSWClientConnection.cpp:
* workers/service/WorkerSWClientConnection.h:
* workers/service/server/SWOriginStore.cpp: Removed.
* workers/service/server/SWOriginStore.h: Removed.
* workers/service/server/SWServer.cpp:
* workers/service/server/SWServer.h:

Source/WebKit:

No observable change, we remove the SWOrigin optimization as its main remaining use
is to optimize the case of a page being loaded by service worker instead of app cache which is a tiny edge case.

* NetworkProcess/NetworkSession.cpp:
* NetworkProcess/NetworkSession.h:
* NetworkProcess/ServiceWorker/WebSWOriginStore.cpp: Removed.
* NetworkProcess/ServiceWorker/WebSWOriginStore.h: Removed.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
* NetworkProcess/ServiceWorker/WebSWServerConnection.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Storage/WebSWClientConnection.cpp:
* WebProcess/Storage/WebSWClientConnection.h:
* WebProcess/Storage/WebSWClientConnection.messages.in:
* WebProcess/Storage/WebSWOriginTable.cpp: Removed.
* WebProcess/Storage/WebSWOriginTable.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.h
trunk/Source/WebCore/workers/service/WorkerSWClientConnection.cpp
trunk/Source/WebCore/workers/service/WorkerSWClientConnection.h
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.h
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in
trunk/Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp


Removed Paths

trunk/Source/WebCore/workers/service/server/SWOriginStore.cpp
trunk/Source/WebCore/workers/service/server/SWOriginStore.h
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.cpp
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.h
trunk/Source/WebKit/WebProcess/Storage/WebSWOriginTable.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWOriginTable.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (293823 => 293824)

--- trunk/Source/WebCore/ChangeLog	2022-05-05 06:38:33 UTC (rev 293823)
+++ trunk/Source/WebCore/ChangeLog	2022-05-05 07:38:15 UTC (rev 293824)
@@ -1,3 +1,24 @@
+2022-05-05  Youenn Fablet  
+
+SWOriginStore is no longer needed
+https://bugs.webkit.org/show_bug.cgi?id=240003
+
+Reviewed by Chris Dumez.
+
+Covered by existing tests.
+
+* Headers.cmake:
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* loader/DocumentLoader.cpp:
+* workers/service/SWClientConnection.h:
+* workers/service/WorkerSWClientConnection.cpp:
+* workers/service/WorkerSWClientConnection.h:
+* workers/service/server/SWOriginStore.cpp: Removed.
+* workers/service/server/SWOriginStore.h: Removed.
+* workers/service/server/SWServer.cpp:
+* workers/service/server/SWServer.h:
+
 2022-05-04  Devin Rousso  
 
 [Apple Pay] REGRESSION(r291588): `appearance: -apple-pay-button` doesn't work with `border-width: 0`


Modified: trunk/Source/WebCore/Headers.cmake (293823 => 293824)

--- trunk/Source/WebCore/Headers.cmake	2022-05-05 06:38:33 UTC (rev 293823)
+++ trunk/Source/WebCore/Headers.cmake	2022-05-05 07:38:15 UTC (rev 293824)
@@ -2043,7 +2043,6 @@
 workers/service/context/ServiceWorkerThreadProxy.h
 
 workers/service/server/RegistrationDatabase.h
-workers/service/server/SWOriginStore.h
 workers/service/server/SWServer.h
 workers/service/server/SWServerRegistration.h
 workers/service/server/SWServerToContextConnection.h


Modified: trunk/Source/WebCore/Sources.txt (293823 => 293824)

--- trunk/Source/WebCore/Sources.txt	2022-05-05 06:38:33 UTC (rev 293823)
+++ trunk/Source/WebCore/Sources.txt	2022-05-05 07:38:15 UTC (rev 293824)
@@ -2801,7 +2801,6 @@
 

[webkit-changes] [293823] trunk/Source

[commit-queue]

Title: [293823] trunk/Source








Revision 293823
Author commit-qu...@webkit.org
Date 2022-05-04 23:38:33 -0700 (Wed, 04 May 2022)


Log Message
SharedMemory::systemPageSize is redundant function
https://bugs.webkit.org/show_bug.cgi?id=240057

Patch by Kimmo Kinnunen  on 2022-05-04
Reviewed by Antti Koivisto.

Source/WebKit:

Remove SharedMemory::systemPageSize().
Use WTF::pageSize() from PageBlock.h.

* Platform/SharedMemory.h:
* Platform/cocoa/SharedMemoryCocoa.cpp:
* Platform/unix/SharedMemoryUnix.cpp:
* Platform/win/SharedMemoryWin.cpp:
* Shared/SharedStringHashStore.cpp:
(WebKit::tableSizeForKeyCount):
* UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::calculateMemoryAvailable):
* mac/WebKit2.order:

Source/WTF:

* wtf/PageBlock.cpp:
(WTF::systemPageSize):
Remove pointless static variable from OS(WINDOWS) variant.
* wtf/linux/CurrentProcessMemoryStatus.cpp:
(WTF::currentProcessMemoryStatus):
Remove another redundant implementation.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PageBlock.cpp
trunk/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/SharedMemory.h
trunk/Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp
trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp
trunk/Source/WebKit/Shared/SharedStringHashStore.cpp
trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp
trunk/Source/WebKit/mac/WebKit2.order




Diff

Modified: trunk/Source/WTF/ChangeLog (293822 => 293823)

--- trunk/Source/WTF/ChangeLog	2022-05-05 06:36:37 UTC (rev 293822)
+++ trunk/Source/WTF/ChangeLog	2022-05-05 06:38:33 UTC (rev 293823)
@@ -1,3 +1,17 @@
+2022-05-04  Kimmo Kinnunen  
+
+SharedMemory::systemPageSize is redundant function
+https://bugs.webkit.org/show_bug.cgi?id=240057
+
+Reviewed by Antti Koivisto.
+
+* wtf/PageBlock.cpp:
+(WTF::systemPageSize):
+Remove pointless static variable from OS(WINDOWS) variant.
+* wtf/linux/CurrentProcessMemoryStatus.cpp:
+(WTF::currentProcessMemoryStatus):
+Remove another redundant implementation.
+
 2022-05-04  Brent Fulgham  
 
 Remove deprecated 'JavaEnabled' feature flag and related code


Modified: trunk/Source/WTF/wtf/PageBlock.cpp (293822 => 293823)

--- trunk/Source/WTF/wtf/PageBlock.cpp	2022-05-05 06:36:37 UTC (rev 293822)
+++ trunk/Source/WTF/wtf/PageBlock.cpp	2022-05-05 06:38:33 UTC (rev 293823)
@@ -51,11 +51,9 @@
 
 inline size_t systemPageSize()
 {
-static size_t size = 0;
 SYSTEM_INFO system_info;
 GetSystemInfo(_info);
-size = system_info.dwPageSize;
-return size;
+return system_info.dwPageSize;
 }
 
 #endif


Modified: trunk/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.cpp (293822 => 293823)

--- trunk/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.cpp	2022-05-05 06:36:37 UTC (rev 293822)
+++ trunk/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.cpp	2022-05-05 06:38:33 UTC (rev 293823)
@@ -29,17 +29,10 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace WTF {
 
-static inline size_t systemPageSize()
-{
-static size_t pageSize = 0;
-if (!pageSize)
-pageSize = sysconf(_SC_PAGE_SIZE);
-return pageSize;
-}
-
 void currentProcessMemoryStatus(ProcessMemoryStatus& memoryStatus)
 {
 FILE* file = fopen("/proc/self/statm", "r");
@@ -52,7 +45,7 @@
 if (!line)
 return;
 
-size_t pageSize = systemPageSize();
+size_t pageSize = WTF::pageSize();
 char* end = nullptr;
 unsigned long long intValue = strtoull(line, , 10);
 memoryStatus.size = intValue * pageSize;


Modified: trunk/Source/WebKit/ChangeLog (293822 => 293823)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 06:36:37 UTC (rev 293822)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 06:38:33 UTC (rev 293823)
@@ -1,5 +1,25 @@
 2022-05-04  Kimmo Kinnunen  
 
+SharedMemory::systemPageSize is redundant function
+https://bugs.webkit.org/show_bug.cgi?id=240057
+
+Reviewed by Antti Koivisto.
+
+Remove SharedMemory::systemPageSize().
+Use WTF::pageSize() from PageBlock.h.
+
+* Platform/SharedMemory.h:
+* Platform/cocoa/SharedMemoryCocoa.cpp:
+* Platform/unix/SharedMemoryUnix.cpp:
+* Platform/win/SharedMemoryWin.cpp:
+* Shared/SharedStringHashStore.cpp:
+(WebKit::tableSizeForKeyCount):
+* UIProcess/linux/MemoryPressureMonitor.cpp:
+(WebKit::calculateMemoryAvailable):
+* mac/WebKit2.order:
+
+2022-05-04  Kimmo Kinnunen  
+
 Empty remote backing store collection prepare starts up GPU process
 https://bugs.webkit.org/show_bug.cgi?id=240067
 


Modified: trunk/Source/WebKit/Platform/SharedMemory.h (293822 => 293823)

--- trunk/Source/WebKit/Platform/SharedMemory.h	2022-05-05 06:36:37 UTC (rev 293822)
+++ trunk/Source/WebKit/Platform/SharedMemory.h	2022-05-05 06:38:33 UTC (rev 293823)
@@ -151,9 +151,6 @@
  

[webkit-changes] [293822] trunk/Source/WebKit

[commit-queue]

Title: [293822] trunk/Source/WebKit








Revision 293822
Author commit-qu...@webkit.org
Date 2022-05-04 23:36:37 -0700 (Wed, 04 May 2022)


Log Message
Empty remote backing store collection prepare starts up GPU process
https://bugs.webkit.org/show_bug.cgi?id=240067

Patch by Kimmo Kinnunen  on 2022-05-04
Reviewed by Simon Fraser.

Avoid starting up GPU process by using an early return if
prepareBuffersForDisplay input array is empty.

* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (293821 => 293822)

--- trunk/Source/WebKit/ChangeLog	2022-05-05 05:48:33 UTC (rev 293821)
+++ trunk/Source/WebKit/ChangeLog	2022-05-05 06:36:37 UTC (rev 293822)
@@ -1,3 +1,16 @@
+2022-05-04  Kimmo Kinnunen  
+
+Empty remote backing store collection prepare starts up GPU process
+https://bugs.webkit.org/show_bug.cgi?id=240067
+
+Reviewed by Simon Fraser.
+
+Avoid starting up GPU process by using an early return if
+prepareBuffersForDisplay input array is empty.
+
+* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
+
 2022-05-04  Tim Horton  
 
 REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (293821 => 293822)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp	2022-05-05 05:48:33 UTC (rev 293821)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp	2022-05-05 06:36:37 UTC (rev 293822)
@@ -273,6 +273,9 @@
 
 auto RemoteRenderingBackendProxy::prepareBuffersForDisplay(const Vector& prepareBuffersInput) -> Vector
 {
+if (prepareBuffersInput.isEmpty())
+return { };
+
 auto bufferIdentifier = [](ImageBuffer* buffer) -> std::optional {
 if (!buffer)
 return std::nullopt;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes