[webkit-changes] [WebKit/WebKit] b63c11: Add fast abort case for StringCommon's equalCommon()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b63c1155dfa7bf35b055845ce270ac08d0244517 https://github.com/WebKit/WebKit/commit/b63c1155dfa7bf35b055845ce270ac08d0244517 Author: Chris Dumez Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WTF/wtf/text/StringCommon.h Log Message: --- Add fast abort case for StringCommon's equalCommon() https://bugs.webkit.org/show_bug.cgi?id=254819 Reviewed by Mark Lam and Geoffrey Garen. * Source/WTF/wtf/text/StringCommon.h: (WTF::equalCommon): Canonical link: https://commits.webkit.org/262467@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3426a: Keyboard scrolling in WebKit with Page Up / Down i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3426a32f875f4109c07a83d596f9e29539ad46e https://github.com/WebKit/WebKit/commit/f3426a32f875f4109c07a83d596f9e29539ad46e Author: Richard Robinson Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/editing/EditorCommand.cpp M Source/WebCore/page/EventHandler.h M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Log Message: --- Keyboard scrolling in WebKit with Page Up / Down is no longer smooth https://bugs.webkit.org/show_bug.cgi?id=254624 rdar://107214002 Reviewed by Simon Fraser. In `executeScrollPageForward` and `executeScrollPageBackward`, the check for `isKeyRepeat` would always return `false`, since the passed in `Event*` was always `nullptr`. Therefore, keyboard scrolling with Page Up or Page Down would not use the new smooth keyboard scrolling mechanism. This PR fixes this by propogating a bool value in `EventHandler` if the associated event is a key repeat or not. This information is passed in `executeKeypressCommandsInternal`, which is then read within the `executeScrollPage*` functions (and then immediately reset to preserve state). * Source/WebCore/editing/EditorCommand.cpp: (WebCore::executeScrollPageBackward): (WebCore::executeScrollPageForward): * Source/WebCore/page/EventHandler.h: (WebCore::EventHandler::setProcessingKeyRepeatForPotentialScroll): (WebCore::EventHandler::isProcessingKeyRepeatForPotentialScroll const): * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): Canonical link: https://commits.webkit.org/262466@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5bb7e: Add a fast abort path for StringImpl's equalIntern...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5bb7e500378f892814484eca2648286358c10ae https://github.com/WebKit/WebKit/commit/c5bb7e500378f892814484eca2648286358c10ae Author: Chris Dumez Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WTF/wtf/text/StringImpl.cpp Log Message: --- Add a fast abort path for StringImpl's equalInternal() https://bugs.webkit.org/show_bug.cgi?id=254766 Reviewed by Darin Adler and Geoffrey Garen. Abort early if the first character is not equal instead of calling equal() with all the characters unconditionally. * Source/WTF/wtf/text/StringImpl.cpp: (WTF::equalInternal): Canonical link: https://commits.webkit.org/262465@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ba7f4: unicode-range may cause us to use Times's font met...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7ba7f4d9fb851ed545353bb489d4b929f7f5e8cd
https://github.com/WebKit/WebKit/commit/7ba7f4d9fb851ed545353bb489d4b929f7f5e8cd
Author: Myles C. Maxfield
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
A LayoutTests/http/tests/text/primary-font-interstitial-expected.html
A LayoutTests/http/tests/text/primary-font-interstitial.html
A LayoutTests/http/tests/text/resources/Gulf-regular.ttf
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/platform/graphics/FontRanges.h
Log Message:
---
unicode-range may cause us to use Times's font metrics erroneously
https://bugs.webkit.org/show_bug.cgi?id=244757
Reviewed by Darin Adler.
When we lay out a line, we use the metrics of the primary font inside our
computation to determine line height.
If the content just says `font-family: a, b`; then it's clear that `a` is the
primary font. However, `a` can
actually be a composite font, as such:
```
@font-face {
font-family: a;
src: url("MyFont.ttf");
unicode-range: some range;
}
@font-face {
font-family: a;
src: url("MyOtherFont.ttf");
unicode-range: a distinct range that doesn't intersect the other font's
range;
}
```
In this situation, when laying out a line, should we use the metrics from
MyFont.ttf or MyOtherFont.ttf?
The spec isn't prescriptive here, so it's kind of up to us to determine what to
do. What we actually do is
from FontCascadeFonts::primaryFont():
A) If one of the `unicode-range`s includes the space character, use that one
(last one wins if there are
multiple). If we need to download this font, do so.
B) If none of the `unicode-range`s includes the space character, then use the
last @font-face block, but
set the flag to forbid downloads from occuring.
When we ask for a font that hasn't finished loading yet, the font object we get
back is an "interstitial"
font, which just means it's a temporary invisible font to use until the real
one finishes downloading. The
interstitial font is hardcoded to always be Times. When we set the flag to
forbid downloads from occurring,
the font we get back is this "interstitial" font, but we'll never switch from
the interstitial font to the
real one - because the real one will never finish downloading because it never
started downloading! So we
just use the metrics from Times indefinitely, which is a surprising result!
The solution here is just to allow downloads in both cases A) and B) above. By
allowing downloads in case
B), we start the font loading process which means we'll eventually switch off
of using Times's metrics.
Test: http/tests/text/primary-font-interstitial.html
* LayoutTests/http/tests/text/primary-font-interstitial-expected.html: Added.
* LayoutTests/http/tests/text/primary-font-interstitial.html: Added.
* LayoutTests/http/tests/text/resources/Gulf-regular.ttf: Added.
* Source/WebCore/platform/graphics/FontCascadeFonts.h:
(WebCore::FontCascadeFonts::primaryFont):
Canonical link: https://commits.webkit.org/262464@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e7c8d: Can't activate feature with all caps tag via font-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e7c8de0a165bc84743986dfccf6175e316a5fc3 https://github.com/WebKit/WebKit/commit/6e7c8de0a165bc84743986dfccf6175e316a5fc3 Author: Myles C. Maxfield Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/text/font-feature-settings-case-sensitive-expected.html A LayoutTests/fast/text/font-feature-settings-case-sensitive.html A LayoutTests/fast/text/resources/Ahem-feature-x-left-spacing.otf M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-valid-expected.txt M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp Log Message: --- Can't activate feature with all caps tag via font-feature-settings https://bugs.webkit.org/show_bug.cgi?id=254146 rdar://106966601 Reviewed by Tim Nguyen. The CSS spec[1] says: > The is a case-sensitive OpenType feature tag. Chrome and Firefox both treat it this way. [1] http://w3c.github.io/csswg-drafts/css-fonts-4/#font-feature-settings-prop Test: fast/text/font-feature-settings-case-sensitive.html * LayoutTests/fast/text/font-feature-settings-case-sensitive-expected.html: Added. * LayoutTests/fast/text/font-feature-settings-case-sensitive.html: Added. * LayoutTests/fast/text/resources/Ahem-feature-x-left-spacing.otf: Added. * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontTag): (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFeatureTagValue): Canonical link: https://commits.webkit.org/262463@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d795f7: [Win] WebInspector: enable "inspector-resource:" s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d795f7f4b71b6662187a863f24529844bef4f698 https://github.com/WebKit/WebKit/commit/d795f7f4b71b6662187a863f24529844bef4f698 Author: Haruhisa SHIN Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp Log Message: --- [Win] WebInspector: enable "inspector-resource:" scheme for remote inspector https://bugs.webkit.org/show_bug.cgi?id=254803 Reviewed by Fujii Hironori. Remote Inspector is unable to load the resources specified in the "inspector-resoure://" scheme. The fix for stand-alone Web Inspector was introduced in Bug 223619. https://bugs.webkit.org/show_bug.cgi?id=223619 235682@main This change should be enabled for the Remote Inspector as well. * Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp: (WebKit::RemoteWebInspectorUIProxy::platformCreateFrontendPageAndWindow): Canonical link: https://commits.webkit.org/262462@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b36dec: Fix !ENABLE(WEB_AUDIO) build after 262451@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b36decf27ea91f9ed21a4b46524d6c6781076d5c https://github.com/WebKit/WebKit/commit/b36decf27ea91f9ed21a4b46524d6c6781076d5c Author: Don Olmstead Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/page/MemoryRelease.cpp Log Message: --- Fix !ENABLE(WEB_AUDIO) build after 262451@main https://bugs.webkit.org/show_bug.cgi?id=254852 Unreviewed build fix. Add !ENABLE(WEB_AUDIO) guard. * Source/WebCore/page/MemoryRelease.cpp: Canonical link: https://commits.webkit.org/262461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db11df: Fix !ENABLE(ASYNC_SCROLLING) build after 262439@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db11df91f7ed3ff7c2e075fd6ed4192e2e3f1dbd https://github.com/WebKit/WebKit/commit/db11df91f7ed3ff7c2e075fd6ed4192e2e3f1dbd Author: Don Olmstead Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Fix !ENABLE(ASYNC_SCROLLING) build after 262439@main https://bugs.webkit.org/show_bug.cgi?id=254850 Unreviewed build fix. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: Canonical link: https://commits.webkit.org/262460@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dda771: [Wasm-GC] Implement basic support in tables for GC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dda771352e63f963e07d78df75adfbc1826598c8 https://github.com/WebKit/WebKit/commit/dda771352e63f963e07d78df75adfbc1826598c8 Author: Asumu Takikawa Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A JSTests/wasm/function-references/table.js M JSTests/wasm/gc-spec-harness.js A JSTests/wasm/gc-spec-tests/ref_cast.wast.js M JSTests/wasm/gc/arrays.js M JSTests/wasm/gc/i31.js M JSTests/wasm/gc/structs.js M JSTests/wasm/js-api/table.js M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmOperationsInlines.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmTable.cpp M Source/JavaScriptCore/wasm/WasmTable.h M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.h M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp Log Message: --- [Wasm-GC] Implement basic support in tables for GC types https://bugs.webkit.org/show_bug.cgi?id=251041 Reviewed by Justin Michaud. Updates Wasm table type parsing so that defaultable ref types other than externref and funcref are allowed. Also stores the Wasm element type in TableInformation, as the element type cannot be deduced from other information when other ref types are allowed. The internal implementations of the ref.cast and extern.internalize operations are also moved so that they can be used from table prototype methods. This also implements the part of the JS API for tables, which specifies that when JS tries to store a value into a table with a GC type, it is internalized and then cast to the appropriate type. The typed function reference proposal also extends tables to allow non-defaultable ref types as long as a table initializer expression is provided. This is not yet supported in this patch. * JSTests/wasm/function-references/table.js: Added. (module): (async testTypedFuncrefTable): * JSTests/wasm/gc-spec-harness.js: * JSTests/wasm/gc-spec-tests/ref_cast.wast.js: Added. * JSTests/wasm/gc/arrays.js: * JSTests/wasm/gc/i31.js: * JSTests/wasm/gc/structs.js: * JSTests/wasm/js-api/table.js: (assert.throws): * Source/JavaScriptCore/wasm/WasmFormat.h: (JSC::Wasm::internalizeExternref): (JSC::Wasm::TableInformation::TableInformation): (JSC::Wasm::TableInformation::wasmType const): * Source/JavaScriptCore/wasm/WasmOperationsInlines.h: (JSC::Wasm::refCast): (JSC::Wasm::externInternalize): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseTableHelper): * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): * Source/JavaScriptCore/wasm/WasmTable.cpp: (JSC::Wasm::Table::Table): (JSC::Wasm::Table::tryCreate): (JSC::Wasm::ExternRefTable::ExternRefTable): (JSC::Wasm::FuncRefTable::FuncRefTable): (JSC::Wasm::FuncRefTable::createFixedSized): (JSC::Wasm::Table::wasmType const): Deleted. * Source/JavaScriptCore/wasm/WasmTable.h: (JSC::Wasm::Table::wasmType const): * Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp: (JSC::Wasm::TypeInformation::castReference): * Source/JavaScriptCore/wasm/WasmTypeDefinition.h: * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::initializeExports): * Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/262459@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2950e9: Enable v3 sandbox telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2950e9e58ed642a55d277f293cc477adc6084fa3 https://github.com/WebKit/WebKit/commit/2950e9e58ed642a55d277f293cc477adc6084fa3 Author: Per Arne Vollan Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/Shared/Sandbox/common.sb Log Message: --- Enable v3 sandbox telemetry https://bugs.webkit.org/show_bug.cgi?id=254851 rdar://107494723 Reviewed by Tim Horton. Reenable parts of v3 sandbox telemetry that was removed in https://commits.webkit.org/262058@main. * Source/WebKit/Shared/Sandbox/common.sb: Canonical link: https://commits.webkit.org/262458@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27185f: Remove _webkit_fixedCarbonPOSIXPath
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27185f9bee793bfd09452c651b83385d488c3dea https://github.com/WebKit/WebKit/commit/27185f9bee793bfd09452c651b83385d488c3dea Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm M Source/WebKitLegacy/mac/WebKit.order Log Message: --- Remove _webkit_fixedCarbonPOSIXPath https://bugs.webkit.org/show_bug.cgi?id=252818 Reviewed by Alexey Proskuryakov. Safari 8 is long gone and no longer supported. We can remove this function/method. Canonical link: https://commits.webkit.org/262457@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 76ecf9: Bug 254830 - AX: remove shouldIgnoreGroup checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76ecf9b7d9903dcd3d22e944fa0e0cbf450240af https://github.com/WebKit/WebKit/commit/76ecf9b7d9903dcd3d22e944fa0e0cbf450240af Author: Chris Fleizach Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: R LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt R LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm Log Message: --- Bug 254830 - AX: remove shouldIgnoreGroup checks https://bugs.webkit.org/show_bug.cgi?id=254830 rdar://107478003 Reviewed by Tyler Wilcock. In shouldIgnoreGroup, we check if a group has an aria name that matches the text inside to avoid duplication. However, when we do this work at the wrong time (during layout), calling textUnderElement() leads to asserts being hit. There's no good way to do both of these things, so removing this heuristic seems like a better approach with the team. * LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt: Removed. * LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html: Removed. * Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const): (WebCore::shouldIgnoreGroup): Deleted. Canonical link: https://commits.webkit.org/262456@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 877878: image/jxl isn't added to the Accept: header when U...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8778787cbaef5a2237eb3cecd07ee515e59f6469 https://github.com/WebKit/WebKit/commit/8778787cbaef5a2237eb3cecd07ee515e59f6469 Author: Myles C. Maxfield Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/loader/cache/CachedResourceRequest.cpp Log Message: --- image/jxl isn't added to the Accept: header when USE(JPEGXL) is enabled https://bugs.webkit.org/show_bug.cgi?id=254780 rdar://107446115 Reviewed by Said Abou-Hallawa. Just like AVIF, if an image format is enabled, it should be advertised in the Accept: header. Because every port, AFAIK, has USE(JPEGXL) disabled, I didn't add an automated test for this. * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::acceptHeaderValueForJPEGXLImageResource): (WebCore::acceptHeaderValueForImageResource): Canonical link: https://commits.webkit.org/262455@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc5000: Skip check for superclasses when decoding _WKRemot...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc50003fa6c8b3bd2a8b3601a479faa7a9112faf https://github.com/WebKit/WebKit/commit/bc50003fa6c8b3bd2a8b3601a479faa7a9112faf Author: Alex Christensen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm Log Message: --- Skip check for superclasses when decoding _WKRemoteObjectRegistry classes on macOS https://bugs.webkit.org/show_bug.cgi?id=254818 Reviewed by David Kilzer. We added a RELEASE_LOG_FAULT to get logs on iOS, but on macOS we should just go ahead and throw the exception. Also remove the @try @catch to throw the exception all the way to the CFRunLoop. * Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm: (checkIfClassIsAllowed): Canonical link: https://commits.webkit.org/262454@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b59d14: [iOS] Rakuten cellular data activation portal is s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b59d14452d4ba35b25178124996ce560ea32d139 https://github.com/WebKit/WebKit/commit/b59d14452d4ba35b25178124996ce560ea32d139 Author: Wenson Hsieh Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [iOS] Rakuten cellular data activation portal is sometimes clipped when presented in a web sheet https://bugs.webkit.org/show_bug.cgi?id=254846 rdar://107301827 Reviewed by Chris Dumez. When activating a Rakuten cellular plan on Apple Watch via the Watch app on iOS 16.4, the web view can end up in a state where both `vw` and `vh` units are always 0. This causes main, scrollable container element with `height: 100vh;` on the page to become much, much shorter than intended, which makes interacting with the activation portal difficult. Some more important context: in the Watch app, the web view starts out at size `(0, 0)`, and is resized to fill the entire window only after the first navigation is complete. Rakuten's portal redirects cross-origin from a landing page, such that this size adjustment races against the second cross-origin navigation (which initiates a process swap). While the immediate cause of this is still unknown, the root cause is that during a process swap (in this particular case, from to ), it's possible for UIKit to call `-setFrame:` with the first non-empty frame after the new web process has been launched and `WebPageCreationParameters` are created, but before the process swap actually finishes. This causes: 1. A viewport size of `(0, 0)` to be sent to the newly created page via `WebPageCreationParameters`. 2. The newly updated, non-zero viewport size to be sent to the *old* page, via an IPC message. As such, the new webpage is stuck in a state where it thinks the viewport size is still `(0, 0)`. To fix this, we simply propagate the new viewport layout size to a provisional page upon process swap. Test: ProcessSwap.ChangeViewSizeDuringNavigationActionPolicyDecision * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::setViewportConfigurationViewLayoutSize): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/262453@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 656c0a: [UI-side compositing] Several layout tests fail wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 656c0aeae78bfa54346b7a5f5ed224574dd0b78d https://github.com/WebKit/WebKit/commit/656c0aeae78bfa54346b7a5f5ed224574dd0b78d Author: Richard Robinson Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-radius-clip-001.html M LayoutTests/svg/compositing/outermost-svg-with-border-padding.html Log Message: --- [UI-side compositing] Several layout tests fail with pixel tolerances https://bugs.webkit.org/show_bug.cgi?id=254836 rdar://107460054 Reviewed by Simon Fraser. Adjusts the pixel tolerances for the affected tests. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-radius-clip-001.html: * LayoutTests/svg/compositing/outermost-svg-with-border-padding.html: Canonical link: https://commits.webkit.org/262452@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf8b52: Cherry-pick 252432.1045@safari-7614-branch (77446d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf8b521ab2010b043f9ce89169149f479c5f02ac https://github.com/WebKit/WebKit/commit/cf8b521ab2010b043f9ce89169149f479c5f02ac Author: Mark Lam Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/JavaScriptCore/API/JSCallbackConstructor.h M Source/JavaScriptCore/API/JSCallbackFunction.h M Source/JavaScriptCore/API/JSClassRef.h M Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h M Source/JavaScriptCore/API/ObjCCallbackFunction.h M Source/JavaScriptCore/runtime/ClassInfo.h M Source/JavaScriptCore/runtime/Lookup.h Log Message: --- Cherry-pick 252432.1045@safari-7614-branch (77446d5c727e). rdar://107473787 [Re-land] Add additional PAC diversity for function pointers in JSC API data structures as we do for vtbls. https://bugs.webkit.org/show_bug.cgi?id=248702 Reviewed by Yusuke Suzuki. * Source/JavaScriptCore/API/JSCallbackConstructor.h: * Source/JavaScriptCore/API/JSCallbackFunction.h: * Source/JavaScriptCore/API/JSClassRef.h: * Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h: * Source/JavaScriptCore/API/ObjCCallbackFunction.h: * Source/JavaScriptCore/runtime/ClassInfo.h: * Source/JavaScriptCore/runtime/Lookup.h: Canonical link: https://commits.webkit.org/252432.1045@safari-7614-branch Canonical link: https://commits.webkit.org/262447@main Commit: bbd4b0ac5848fa94bbcb7c6aa87df4ab352acabf https://github.com/WebKit/WebKit/commit/bbd4b0ac5848fa94bbcb7c6aa87df4ab352acabf Author: Ryan Reno Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/JavaScriptCore/API/JSScript.mm M Source/JavaScriptCore/API/JSScriptRef.cpp M Source/JavaScriptCore/inspector/ScriptCallFrame.cpp M Source/JavaScriptCore/inspector/ScriptCallFrame.h M Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp M Source/JavaScriptCore/interpreter/StackVisitor.cpp M Source/JavaScriptCore/interpreter/StackVisitor.h M Source/JavaScriptCore/parser/SourceProvider.cpp M Source/JavaScriptCore/parser/SourceProvider.h M Source/JavaScriptCore/runtime/CachedTypes.cpp M Source/JavaScriptCore/runtime/ScriptExecutable.h M Source/WebCore/bindings/js/CachedScriptSourceProvider.h M Source/WebCore/bindings/js/ScriptBufferSourceProvider.h M Source/WebCore/bindings/js/ScriptModuleLoader.cpp M Source/WebCore/bindings/js/ScriptSourceCode.h M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerThread.cpp Log Message: --- Cherry-pick 259548.39@safari-7615-branch (c68b7da0d9b4). rdar://107474520 Cross-Site Information Leak: CSP violation reports may contain a post-redirect URL https://bugs.webkit.org/show_bug.cgi?id=251282 rdar://104753003 Reviewed by Yusuke Suzuki. The source-file field of a CSP violation report may contain a URL which has sensitive data in the query string if it was the result of a redirect. The CSP spec in non-normative terms suggests that in the case of a redirect (such as a login flow which appends a login token) we should report violations in the resulting resource with the pre-redirect URL to avoid cross-site information leaks via the CSP reporting API. Source/JavaScriptCore: Plubming code to make pre-redirect URLs available in ScriptCallStacks. When a ScriptCallStack is created by the StackVisitor the ScriptCallFrame objects will be populated with the pre-redirect URL by consulting the SourceProvider. WebCore will conditionally set the preRedirectURL member if the resource was obtained via a redirected response. * Source/JavaScriptCore/API/JSScript.mm: (-[JSScript sourceCode]): * Source/JavaScriptCore/API/JSScriptRef.cpp: * Source/JavaScriptCore/inspector/ScriptCallFrame.cpp: (Inspector::ScriptCallFrame::ScriptCallFrame): (Inspector::ScriptCallFrame::isEqual const): * Source/JavaScriptCore/inspector/ScriptCallFrame.h: * Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp: (Inspector::CreateScriptCallStackFunctor::operator() const): * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::Frame::preRedirectURL const): * Source/JavaScriptCore/interpreter/StackVisitor.h: * Source/JavaScriptCore/parser/SourceProvider.cpp: (JSC::SourceProvider::SourceProvider): (JSC::BaseWebAssemblySourceProvider::BaseWebAssemblySourceProvider): * Source/JavaScriptCore/parser/SourceProvider.h: (JSC::SourceProvider::preRedirectURL const): (JSC::StringSourceProvider::StringSourceProvider): * Source/JavaScriptCore/runtime/CachedTypes.cpp: (JSC::CachedSourceProviderShape::encode): * Source/JavaScriptCore/runtime/ScriptExecutable.h: (JSC::ScriptExecutable::preRedirectURL const):
[webkit-changes] [WebKit/WebKit] bdbb4b: Cherry-pick 259548.47@safari-7615-branch (0f2c1212...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bdbb4be89a2aaff918a9aa6c2cf23660e6ef1a35
https://github.com/WebKit/WebKit/commit/bdbb4be89a2aaff918a9aa6c2cf23660e6ef1a35
Author: Yusuke Suzuki
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
A
JSTests/stress/arguments-elimination-should-happen-only-when-stack-slot-is-available-at-replacement-site.js
M Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp
Log Message:
---
Cherry-pick 259548.47@safari-7615-branch (0f2c12121b0a). rdar://107474791
[JSC] FTL arguments elimination should ensure that replacement sites can
access to original stack slots
https://bugs.webkit.org/show_bug.cgi?id=251640
rdar://99273500
Reviewed by Mark Lam.
FTL arguments elimination does analysis and attempts to eliminate arguments
allocation if it is not escaped.
We emit stack access at `arguments[0]` site for example, and remove
`arguments` allocations.
But important thing is that stack slots used for the `arguments` need to be
available at `arguments[0]` access site.
Since we are using stack slots for different purpose when inlining
different functions, it is possible that the given
stack slot is no longer available when using `arguments[0]`. For example,
function a() { return arguments; }
function b() { do-something }
var arg = a()
b();
arg[0]; // If both "a" and "b" are inlined, stack slots used
for inlined "a" can be used for the other purpose for "b"
// As a result, it is possible that the slot is not
available at `arg[0]` access point.
We were doing stack slot interference analysis to avoid the above
problem[1]. However, it was not complete solution since it is only
checking block-local status. So if we have branch between a() and arg[0],
this analysis didn't work. Attached test
"arguments-elimination-should-happen-only-when-stack-slot-is-available-at-replacement-site.js"
is literally doing this.
function empty() {}
function bar2(...a0) {
return a0;
}
function foo() {
let xs = bar2(undefined);
'' == 1 && 0;
return empty(...xs, undefined);
}
Between bar2 and `...xs` site, we have branch due to &&. And at "...xs"
site, the stack slot were no longer available.
In this patch, we replace our existing interference analysis with the
revised fix. We use OSR availability which can describe the
state of each stack slot. For all arguments, initially, it is flushed state
with a node. Then, when slot gets unavailable or overridden,
we can see the availability change, which no longer points at the same node.
We first do this OSR availability analysis and capture availability map of
each candidates. And then, we analyze whether replacement sites
are still seeing the same availability for arguments. And if it becomes
different, we remove the candidate from optimization target. This change
simplifies our analysis significantly, and make it procedure global
(previous one was block local).
[1]: https://commits.webkit.org/212536@main
*
JSTests/stress/arguments-elimination-should-happen-only-when-stack-slot-is-available-at-replacement-site.js:
Added.
(empty):
(bar2):
(foo):
(main):
* Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp:
Canonical link: https://commits.webkit.org/259548.47@safari-7615-branch
Canonical link: https://commits.webkit.org/262442@main
Commit: 8e4a125888c6042c3d36639e96653123edb30163
https://github.com/WebKit/WebKit/commit/8e4a125888c6042c3d36639e96653123edb30163
Author: Antti Koivisto
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
A LayoutTests/fast/css/display-contents-slot-to-none-expected.txt
A LayoutTests/fast/css/display-contents-slot-to-none.html
M Source/WebCore/style/StyleTreeResolver.cpp
Log Message:
---
Cherry-pick 259548.51@safari-7615-branch (44f75343da9e). rdar://107475121
[be894cadcf68a52a] (REGRESSION 256601@main) ASAN_SEGV |
WebCore::RenderObject::pushOntoGeometryMap;
WebCore::RenderInline::pushMappingToContainer;
https://bugs.webkit.org/show_bug.cgi?id=251788
rdar://104793275
Reviewed by Alan Baradlay.
* LayoutTests/fast/css/display-contents-slot-to-none-expected.txt: Added.
* LayoutTests/fast/css/display-contents-slot-to-none.html: Added.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::affectsRenderedSubtree):
We may have had display:contents before and a rendered subtree may still be
affected.
Canonical link: https://commits.webkit.org/259548.51@safari-7615-branch
Canonical link: https://commits.webkit.org/262443@main
Commit: ea15ace73a2e2643dc73085a137791fb80f4339a
https://github.com/WebKit/WebKit/commit/ea15ace73a2e2643dc73085a137791fb80f4339a
Author:
[webkit-changes] [WebKit/WebKit] e3babf: REGRESSION (261705@main): [ iOS, macOS ] fast/text...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3babff08eae9716c831ae178073fcf8d94098fc https://github.com/WebKit/WebKit/commit/e3babff08eae9716c831ae178073fcf8d94098fc Author: Ryan Haddad Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- REGRESSION (261705@main): [ iOS, macOS ] fast/text/web-font-load-invisible-during-loading.html is a flaky text failure. https://bugs.webkit.org/show_bug.cgi?id=254637 rdar://107373558 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Mark the test as flaky. * LayoutTests/platform/mac/TestExpectations: Ditto. Canonical link: https://commits.webkit.org/262441@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f4a34f: [popover] Implement "check and possibly close popo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f4a34ff850554d9c85d9114b14a3a12bb01f1ccf https://github.com/WebKit/WebKit/commit/f4a34ff850554d9c85d9114b14a3a12bb01f1ccf Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled-expected.txt M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormControlElement.h M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- [popover] Implement "check and possibly close popover stack" algorithm https://bugs.webkit.org/show_bug.cgi?id=254382 Reviewed by Tim Nguyen. Implement "check and possibly close popover stack" algorithm as specified here: https://github.com/whatwg/html/pull/9048 This patch also imports the latest version of popover-target-element-disabled.html. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html: * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::checkAndPossiblyClosePopoverStackInternal): * Source/WebCore/html/HTMLElement.h: (WebCore::HTMLElement::checkAndPossiblyClosePopoverStack): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromAncestor): (WebCore::HTMLFormControlElement::parseAttribute): (WebCore::HTMLFormControlElement::disabledStateChanged): (WebCore::HTMLFormControlElement::didChangeForm): * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Canonical link: https://commits.webkit.org/262440@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6555fc: [UI-side compositing] History swipes can fail if y...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6555fc3844aa98b68a90c8d907f15ee1cd6bceb4 https://github.com/WebKit/WebKit/commit/6555fc3844aa98b68a90c8d907f15ee1cd6bceb4 Author: Simon Fraser Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- [UI-side compositing] History swipes can fail if you swipe over an element with a wheel event handler https://bugs.webkit.org/show_bug.cgi?id=254837 rdar://107481980 Reviewed by Tim Horton. `ThreadedScrollingCoordinator::handleWheelEventForScrolling()` checks to see if the current event can start a swipe gesture, and we need to do the same in `RemoteScrollingCoordinator::handleWheelEventForScrolling()`. However, we don't have a scrolling tree to ask in the web process, so we need to feed this information down from the UI Process. So plumb `willStartSwipe` through and check it. Tested by `LayoutTests/swipe` tests. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::continueWheelEventHandling): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::waitForEventDefaultHandlingCompletion): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): (WebKit::WebPageProxy::continueWheelEventHandling): (WebKit::WebPageProxy::sendWheelEvent): (WebKit::WebPageProxy::wheelEventHandlingCompleted): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::handleWheelEventForScrolling): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::handleWheelEvent): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/262439@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a7153: [macOS] TestWebKitAPI.WebKit.MediaBufferingPolicy ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a7153a9741eecce79f2752a91812bc5585f58dc https://github.com/WebKit/WebKit/commit/9a7153a9741eecce79f2752a91812bc5585f58dc Author: Miguel Salinas Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm Log Message: --- [macOS] TestWebKitAPI.WebKit.MediaBufferingPolicy is a constant failure https://bugs.webkit.org/show_bug.cgi?id=253658 rdar://problem/106508946 Reviewed by Jer Noble. macOS shouldn't purge media playback resources on page suspension. This behavior was changed in 261354@main. This is just aligning the test case * Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: (TEST): Canonical link: https://commits.webkit.org/262438@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d36d2: Share more code between local and remote postMessage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d36d22c64d6d2d01984b7b0a83bd7a19fbe6730 https://github.com/WebKit/WebKit/commit/3d36d22c64d6d2d01984b7b0a83bd7a19fbe6730 Author: Alex Christensen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/page/DOMWindow.cpp M Source/WebCore/page/DOMWindow.h A Source/WebCore/page/DOMWindow.idl M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalDOMWindow.h M Source/WebCore/page/LocalDOMWindow.idl M Source/WebCore/page/RemoteDOMWindow.cpp M Source/WebCore/page/RemoteDOMWindow.h M Source/WebCore/page/RemoteDOMWindow.idl A Source/WebCore/page/WindowPostMessageOptions.h A Source/WebCore/page/WindowPostMessageOptions.idl M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Share more code between local and remote postMessage https://bugs.webkit.org/show_bug.cgi?id=254773 Reviewed by Chris Dumez. Share the shape all the way down to the IDL. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::createTargetOriginForPostMessage): * Source/WebCore/page/DOMWindow.h: (WebCore::DOMWindow::identifier const): * Source/WebCore/page/DOMWindow.idl: Copied from Source/WebCore/page/DOMWindow.h. * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::postMessage): * Source/WebCore/page/LocalDOMWindow.h: (WebCore::WindowPostMessageOptions::WindowPostMessageOptions): Deleted. * Source/WebCore/page/LocalDOMWindow.idl: * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::postMessage): * Source/WebCore/page/RemoteDOMWindow.h: * Source/WebCore/page/RemoteDOMWindow.idl: * Source/WebCore/page/WindowPostMessageOptions.h: Copied from Source/WebCore/page/DOMWindow.h. (WebCore::WindowPostMessageOptions::WindowPostMessageOptions): * Source/WebCore/page/WindowPostMessageOptions.idl: Copied from Source/WebCore/page/DOMWindow.h. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/262437@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e25587: Deprecate WKContextSetCustomWebContentServiceBundl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e25587afd5cc80abe940cc20b2b82a130343e451 https://github.com/WebKit/WebKit/commit/e25587afd5cc80abe940cc20b2b82a130343e451 Author: Alex Christensen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/C/WKContext.cpp M Source/WebKit/UIProcess/API/C/WKContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm Log Message: --- Deprecate WKContextSetCustomWebContentServiceBundleIdentifier https://bugs.webkit.org/show_bug.cgi?id=254699 Reviewed by Geoffrey Garen. It was introduced as an experiment in Safari that was only fruitful in telling us that we did not want to proceed. I am removing that experiment to clean up the process launcher to have a finite and known set of processes it launches. The day may come when we want to redo the experiment, but the process launcher will look significantly different by then, and we will need to redo it from scratch anyways. * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::copy): * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h: * Source/WebKit/UIProcess/API/C/WKContext.cpp: (WKContextSetCustomWebContentServiceBundleIdentifier): * Source/WebKit/UIProcess/API/C/WKContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration customWebContentServiceBundleIdentifier]): (-[_WKProcessPoolConfiguration setCustomWebContentServiceBundleIdentifier:]): * Source/WebKit/UIProcess/Launcher/ProcessLauncher.h: * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::webContentServiceName): (WebKit::serviceName): (WebKit::ProcessLauncher::launchProcess): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier): Deleted. * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getLaunchOptions): Canonical link: https://commits.webkit.org/262436@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 403125: Make RemoteRenderingData::cacheFont reconstruct a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 403125028b31ca883f4ebac8354ee6533e36ecef https://github.com/WebKit/WebKit/commit/403125028b31ca883f4ebac8354ee6533e36ecef Author: Matt Woodrow Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/css/CSSFontFaceSource.h M Source/WebCore/loader/cache/CachedFont.cpp M Source/WebCore/loader/cache/CachedFont.h M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/Font.h M Source/WebCore/platform/graphics/FontCustomPlatformData.h M Source/WebCore/platform/graphics/FontPlatformData.cpp M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp M Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp M Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp M Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp M Source/WebCore/workers/WorkerFontLoadRequest.h M Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp M Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/playstation/WebCoreArgumentCodersPlayStation.cpp M Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp M Source/WebKit/Shared/win/WebCoreArgumentCodersWin.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h Log Message: --- Make RemoteRenderingData::cacheFont reconstruct a Font using Attributes, and a reference to FontCustomPlatformData. https://bugs.webkit.org/show_bug.cgi?id=254490 Reviewed by Myles C. Maxfield. Make FontCustomPlatformData refcounted, and owned by the FontPlatformData instead of CreationData We currently only have the CreationData accessible from Font, but when serializing a web font, we need the FontCustomPlatformData in order to share the parsed font data. This just makes the FontCustomPlatformData the shared object on FontPlatformData, and we can still access the CreationData through it. * Source/WebCore/css/CSSFontFaceSource.h: * Source/WebCore/loader/cache/CachedFont.cpp: (WebCore::CachedFont::createCustomFontData): * Source/WebCore/loader/cache/CachedFont.h: * Source/WebCore/platform/graphics/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): * Source/WebCore/platform/graphics/FontPlatformData.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::creationData const): * Source/WebCore/platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::customPlatformData const): (WebCore::FontPlatformData::creationData const): Deleted. * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::systemFallbackForCharacters): * Source/WebCore/platform/graphics/coretext/FontCoreText.cpp: (WebCore::createDerivativeFont): (WebCore::Font::createFontWithoutSynthesizableFeatures const): (WebCore::Font::platformCreateScaledFont const): * Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp: (WebCore::FontPlatformData::FontPlatformData): * Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData): (WebCore::FontCustomPlatformData::creationData const): * Source/WebCore/workers/WorkerFontLoadRequest.h: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::ArgumentCoder::decodePlatformData): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.h: Move POD serializable subset of Font into Attributes object In order to serialize a Font where the FontCustomPlatformData is already cached, we want to send the identifier of the data, plus the serialized remainder of the font. This creates an Attributes inner class for Font, containing the data needed to serialize the font, without the platform data. *
[webkit-changes] [WebKit/WebKit] 93920b: Fix build of SourceBrush.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93920b55f52ff8b883296f4845269e2ed746acb3 https://github.com/WebKit/WebKit/commit/93920b55f52ff8b883296f4845269e2ed746acb3 Author: Michael Catanzaro Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/platform/graphics/SourceBrush.cpp Log Message: --- Fix build of SourceBrush.cpp https://bugs.webkit.org/show_bug.cgi?id=254821 Unreviewed build fix. * Source/WebCore/platform/graphics/SourceBrush.cpp: (WebCore::SourceBrush::setGradient): (WebCore::SourceBrush::setPattern): Canonical link: https://commits.webkit.org/262434@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b6d01: AX: Don't include password input value in aria-lab...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b6d017ba868a66c08ca684570e44269fb2b1274 https://github.com/WebKit/WebKit/commit/3b6d017ba868a66c08ca684570e44269fb2b1274 Author: Tommy McHugh Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/accessibility-isolated-tree/TestExpectations A LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt A LayoutTests/accessibility/aria-labelledby-on-password-input.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/accessibility/AccessibilityNodeObject.cpp Log Message: --- AX: Don't include password input value in aria-labelledby description https://bugs.webkit.org/show_bug.cgi?id=248717 rdar://problem/102815043 Reviewed by Tyler Wilcock. accessibleNameForNode is erroneously returning the raw password input value when an element has an aria-labelledby attribute to an input element with a password type. This patch fixes that by checking HTMLInputElement::isPasswordField before returning the input's value and when there is a password field returning a masked value matching the length of the true value. * LayoutTests/accessibility-isolated-tree/TestExpectations: * LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt: Added. * LayoutTests/accessibility/aria-labelledby-on-password-input.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::accessibleNameForNode): Canonical link: https://commits.webkit.org/262433@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d93b0: AXObjectCache::characterOffsetFromVisiblePosition ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d93b07962d543ef64c35852350eceef1fd40260 https://github.com/WebKit/WebKit/commit/7d93b07962d543ef64c35852350eceef1fd40260 Author: Tyler Wilcock Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- AXObjectCache::characterOffsetFromVisiblePosition can deref a nullptr when underlying renderer is destroyed https://bugs.webkit.org/show_bug.cgi?id=254798 rdar://103456792 Reviewed by Chris Fleizach. AXObjectCache::characterOffsetFromVisiblePosition creates an AX object from the node backing a VisiblePosition at the beginning of the method. Then, it does non-trivial work that could cause the renderer backing the AX object to be destroyed, and afterwards unconditionally deferences that AX object's node() at the end of the method. This can cause a null pointer dereference crash (because AccessibilityRenderObject::node() depends on a non-null renderer), and is generally poor pointer hygiene. With this patch, we now keep the VisiblePosition's node in a `Ref` and re-use it at the end of the method to prevent a crash. I could not reproduce this crash myself in the browser or in a testcase, so this is a speculative fix based on crash reports. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::characterOffsetFromVisiblePosition): Canonical link: https://commits.webkit.org/262432@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b2c72: Remove support for TagName::command
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b2c72f4aa1f5fab6d19ec7e0ccf8bad40339436 https://github.com/WebKit/WebKit/commit/5b2c72f4aa1f5fab6d19ec7e0ccf8bad40339436 Author: Anne van Kesteren Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/html5lib/generated/run-tests25-data-expected.txt M LayoutTests/html5lib/generated/run-tests25-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=uri-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write_single-expected.txt M Source/WebCore/WebCore.order M Source/WebCore/WebCoreMacros.cmake M Source/WebCore/html/HTMLObjectElement.cpp M Source/WebCore/html/HTMLTagNames.in M Source/WebCore/html/parser/HTMLStackItem.h M Source/WebCore/html/parser/HTMLTreeBuilder.cpp Log Message: --- Remove support for TagName::command https://bugs.webkit.org/show_bug.cgi?id=254737 rdar://107416609 Reviewed by Ryosuke Niwa. After this change the X in X will be a child rather than a following sibling of the (unknown) command element, as HTML requires as of about a decade ago. * LayoutTests/html5lib/generated/run-tests25-data-expected.txt: * LayoutTests/html5lib/generated/run-tests25-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests25_run_type=write_single-expected.txt: * Source/WebCore/WebCore.order: * Source/WebCore/WebCoreMacros.cmake: Correct a typo in the file name for MathML attributes and merge MAIN_DEPENDENCY into DEPENDS for GENERATE_DOM_NAME_ENUM in the hopes of making WebKitGTK and WinCairo build correctly. * Source/WebCore/html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::renderFallbackContent): (WebCore::preventsParentObjectFromExposure): (WebCore::HTMLObjectElement::containsJavaApplet const): * Source/WebCore/html/HTMLTagNames.in: * Source/WebCore/html/parser/HTMLStackItem.h: (WebCore::isSpecialNode): * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInHead): Canonical link: https://commits.webkit.org/262431@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdf18d: [ iOS, macOS ] imported/w3c/web-platform-tests/mat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdf18de6921f72146c71bffcb6c52b043c174251 https://github.com/WebKit/WebKit/commit/fdf18de6921f72146c71bffcb6c52b043c174251 Author: Bri Harris Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [ iOS, macOS ] imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html is a constant text failure. https://bugs.webkit.org/show_bug.cgi?id=254621 rdar://107335821 Unreviewed test gardening. Removing test expectations for now-passing test. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/262430@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2fbff2: Unreviewed, reverting r262370@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2fbff230f9c82dcd7932d371f10e1e0f147ae7b4 https://github.com/WebKit/WebKit/commit/2fbff230f9c82dcd7932d371f10e1e0f147ae7b4 Author: Commit Queue Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WTF/wtf/spi/cocoa/IOSurfaceSPI.h M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebCore/platform/graphics/cocoa/IOSurface.h M Source/WebCore/platform/graphics/cocoa/IOSurface.mm M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp M Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm M Tools/TestWebKitAPI/Tests/WebCore/cocoa/IOSurfaceTests.mm Log Message: --- Unreviewed, reverting r262370@main. https://bugs.webkit.org/show_bug.cgi?id=254832 Re-land 262331@main as it did not cause an IOSurface memory use regression Reverted changeset: "Revert 262331@main: May have caused memory regression" https://bugs.webkit.org/show_bug.cgi?id=141586 https://commits.webkit.org/262370@main Canonical link: https://commits.webkit.org/262429@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8610b1: Re-import html/semantics/popovers WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8610b1f543e2d24265f9a02d40b953e9e3db4b99 https://github.com/WebKit/WebKit/commit/8610b1f543e2d24265f9a02d40b953e9e3db4b99 Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log Log Message: --- Re-import html/semantics/popovers WPT https://bugs.webkit.org/show_bug.cgi?id=254810 Reviewed by Tim Nguyen. Based on https://github.com/web-platform-tests/wpt/commit/8f71659306c53f3cabad054ed02ac7c4d14de693 * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log: Canonical link: https://commits.webkit.org/262428@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3526d: Unreviewed, reverting r262411@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3526d45b78a4c70d44b9c8d87af925d598e5a78 https://github.com/WebKit/WebKit/commit/f3526d45b78a4c70d44b9c8d87af925d598e5a78 Author: Commit Queue Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h Log Message: --- Unreviewed, reverting r262411@main. https://bugs.webkit.org/show_bug.cgi?id=254831 The actual cause of the memory spike seems to be that the crashes caused by 262263@main were breaking the test, so undo this revert Reverted changeset: "Unreviewed, reverting r262333@main." https://bugs.webkit.org/show_bug.cgi?id=254825 https://commits.webkit.org/262411@main Canonical link: https://commits.webkit.org/262427@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 16546e: Web Inspector: Fonts: Warning text for synthesized...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 16546e0d598306118d9440a1ffd5f35aa69d36ef https://github.com/WebKit/WebKit/commit/16546e0d598306118d9440a1ffd5f35aa69d36ef Author: Razvan Caliman Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js Log Message: --- Web Inspector: Fonts: Warning text for synthesized oblique/italic should mention the correct property value https://bugs.webkit.org/show_bug.cgi?id=254759 Reviewed by Devin Rousso. Show a warning message corresponding to the style that didn't have font support and was synthesized: italic vs oblique. * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js: (WI.FontDetailsPanel.prototype.update): Canonical link: https://commits.webkit.org/262426@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41db05: Make SMIL interval position calculations more resi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41db051039b0b4670106dc3937a4c8598c39ea48 https://github.com/WebKit/WebKit/commit/41db051039b0b4670106dc3937a4c8598c39ea48 Author: Ahmad Saleem Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/svg/animations/simple-duration-mutation-crash-expected.txt A LayoutTests/svg/animations/simple-duration-mutation-crash.html M Source/WebCore/svg/animation/SVGSMILElement.cpp Log Message: --- Make SMIL interval position calculations more resilient https://bugs.webkit.org/show_bug.cgi?id=254702 Reviewed by Simon Fraser. Merge - https://chromium.googlesource.com/chromium/src.git/+/c9db58439d9c5218b26640fa65780d6dd505734c When 'dur' is mutated, all dependent state is not updated at once, but rather lazily. This means that we can get into an inconsistent state where some timing parameters have been applied while some have not, and code that uses - and thus realizes - the state changes will be first to observe them. This can for instance lead to an interval position of NaN being computed, which would wreak havoc when computing values. For the specific case, we'd first get an 'indefinite' simple duration and compute an interval thereafter. When 'dur' is then modified to a finite value the simple duration will not be updated until the next frame is computed (triggered by mutation of 'end'), leaving us with a valid/finite simple duration but an infinite interval. (This then results in arithmetic with Inf, yielding a NaN value for |percent|.) Properly updating all the interval computation state on mutations is a somewhat involved task, so paper over it for now by computing the (last) active duration differently depending on the case we're in. While this change is a bit of a workaround, it should be a perfectly reasonable change on its own. * Source/WebCore/svg/animations/SVGSMILElement.cpp: (SVGSMILElement:: calculateAnimationPercentAndRepeat): Update 'percent' * LayoutTests/svg/animations/simple-duration-mutation-crash.html: Add Test Case * LayoutTests/svg/animations/simple-duration-mutation-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/262425@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bc64a: REGRESSION(259969@main): Screen sharing is no long...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bc64a5506e3a0324da4b6c4b99e3e99f4b3a947 https://github.com/WebKit/WebKit/commit/3bc64a5506e3a0324da4b6c4b99e3e99f4b3a947 Author: Eric Carlson Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h M Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm Log Message: --- REGRESSION(259969@main): Screen sharing is no longer working in public builds and causing UIProcess to crash https://bugs.webkit.org/show_bug.cgi?id=254155 rdar://107265903 Reviewed by Youenn Fablet. If the user agrees to share a screen on a version of macOS that doesn't have the ScreenCaptureKit picker, share the main screen. This restores the behavior before https://commits.webkit.org/259969@main. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h: * Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm: (WebCore::CGDisplayStreamScreenCaptureSource::screenCaptureDeviceForMainDisplay): * Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm: (WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia): Canonical link: https://commits.webkit.org/262424@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 226684: [margin-trim] Trigger layout on margin-trim style ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 226684b758a062ec07c68f2de73a6687844fbaf1 https://github.com/WebKit/WebKit/commit/226684b758a062ec07c68f2de73a6687844fbaf1 Author: Sammy Gill Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-style-change-triggers-layout-block-start-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-style-change-triggers-layout-block-start.html R LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-end-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-end-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-end.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-start-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-start-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block-start.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-column-style-change-triggers-layout-block.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-end-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-end-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-end.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-start-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-start-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline-start.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/flex-row-style-change-triggers-layout-inline.html M Source/WebCore/rendering/style/RenderStyle.cpp Log Message: --- [margin-trim] Trigger layout on margin-trim style change. https://bugs.webkit.org/show_bug.cgi?id=254300 rdar://107108810 Reviewed by Tim Nguyen. When the value of the margin-trim property changes on a box, it should trigger layout again so that the children can be relaid out properly. This patch takes the first step and has rareDataChangeRequiresLayout return true when the box's old margin-trim value is not the same as the new one. The 3 container types in which margin-trim is applicable to (flex, grid, and block) may need to have their styleDidChange function adjusted to actually relayout their children properly, but that will be done in a separate patch for each layout type. However, we can verify that this change works by attempting to trigger this logic for flexboxes. This is because when a flexbox goes through layout again, it will set the main axis margins for each of its children inside RenderFlexibleBox::prepareOrderIteratorAndMargins before it goes through and lays them out. Since the main axis margins for each child will be step at the beginning of flex layout each time it happens, the trimming logic will also apply each time. The cross axis margins will need to be handled and verified separately once the change is made to RenderFlexibleBox::styleDidChange. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-style-change-triggers-layout-block-start-expected.txt: Added. *
[webkit-changes] [WebKit/WebKit] 662bf7: Fix RemoteObjectRegistry debug API tests after 262...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 662bf75d08192f93eb7a2888b608aa4b4c64e620 https://github.com/WebKit/WebKit/commit/662bf75d08192f93eb7a2888b608aa4b4c64e620 Author: Alex Christensen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm Log Message: --- Fix RemoteObjectRegistry debug API tests after 262407@main https://bugs.webkit.org/show_bug.cgi?id=254827 rdar://107477420 Unreviewed. A few more known classes with subclasses are required to add the restriction. * Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm: (alwaysAllowedClasses): Canonical link: https://commits.webkit.org/262422@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96ab27: Cherry-pick 259548.22@safari-7615-branch (433aae06...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96ab27ee5dab69647ffea2ceb433d617f3c5e1e9 https://github.com/WebKit/WebKit/commit/96ab27ee5dab69647ffea2ceb433d617f3c5e1e9 Author: Gerald Squelart Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/platform/graphics/IntRect.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Cherry-pick 259548.22@safari-7615-branch (433aae06c3e1). rdar://107445621 Validate IPC-decoded IntRect's rdar://101324985 Reviewed by Dean Jackson. * Source/WebCore/platform/graphics/IntRect.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/259548.22@safari-7615-branch Canonical link: https://commits.webkit.org/262412@main Commit: b3d58f33f176547ce13963aee482b6697537ea24 https://github.com/WebKit/WebKit/commit/b3d58f33f176547ce13963aee482b6697537ea24 Author: Simon Fraser Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm Log Message: --- Cherry-pick 252432.1040@safari-7614-branch (5f64e30a652b). rdar://107445664 [CoreIPC] Type confusion bugs in RemoteScrollingCoordinatorProxyIOS::establishLayerTreeScrollingRelations https://bugs.webkit.org/show_bug.cgi?id=250812 Reviewed by Jonathan Bedard and Ryosuke Niwa. Add MESSAGE_CHECKing for two node types in code that runs in response to an IPC message. Add an early return checking the root node type in code that runs from user events. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: (WebKit::RemoteScrollingCoordinatorProxy::establishLayerTreeScrollingRelations): (WebKit::RemoteScrollingCoordinatorProxy::nearestActiveContentInsetAdjustedSnapOffset const): Canonical link: https://commits.webkit.org/252432.1040@safari-7614-branch Canonical link: https://commits.webkit.org/262413@main Commit: 8256763cced0d44f93e2d41a8de38396cc50bcdf https://github.com/WebKit/WebKit/commit/8256763cced0d44f93e2d41a8de38396cc50bcdf Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- Cherry-pick 256843.4@webkit-2022.12-embargoed (6234ec9c65b9). rdar://107445724 Do not issue repaints when in detached state https://bugs.webkit.org/show_bug.cgi?id=248773 rdar://102808328 Reviewed by Antti Koivisto. Do not issue repaints when the RenderObject is in detached state while removing render subtrees. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: Added. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderTableCell::willBeRemovedFromTree const): Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/262414@main Commit: 8a9408e8fc80e4be499eb9b34e5a816b4b4e4c1e https://github.com/WebKit/WebKit/commit/8a9408e8fc80e4be499eb9b34e5a816b4b4e4c1e Author: Justin Michaud Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A JSTests/wasm/stress/many-locals-small-wasm-stack.js A JSTests/wasm/stress/many-locals-small-wasm-stack.wasm A JSTests/wasm/stress/many-locals-small-wasm-stack.wat M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp Log Message: --- Cherry-pick 259548.25@safari-7615-branch (1a20160f826c). rdar://107446004 Locals should update max stack size rdar://104692168 Reviewed by Yusuke Suzuki. We can forget to update the max stack size, causing an OOB stack read in OSR entry. This only happens if you create a bunch of locals and never push anything to the stack, so it should be very rare and difficult to abuse. * JSTests/wasm/stress/many-locals-small-wasm-stack.js: Added. (async let): * JSTests/wasm/stress/many-locals-small-wasm-stack.wasm: Added. * JSTests/wasm/stress/many-locals-small-wasm-stack.wat: Added. * Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::addLocal): Canonical link: https://commits.webkit.org/259548.25@safari-7615-branch Canonical link: https://commits.webkit.org/262415@main Commit: 2365ae2ca2bdf6abfe47b97f025413f746f3 https://github.com/WebKit/WebKit/commit/2365ae2ca2bdf6abfe47b97f025413f746f3 Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html A
[webkit-changes] [WebKit/WebKit] 99b76e: Unreviewed, reverting r262333@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99b76ecafc37874d419608476dbb3af52b9f15bb https://github.com/WebKit/WebKit/commit/99b76ecafc37874d419608476dbb3af52b9f15bb Author: Commit Queue Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h Log Message: --- Unreviewed, reverting r262333@main. https://bugs.webkit.org/show_bug.cgi?id=254825 Caused large IOSurface-related memory regression Reverted changeset: "ASSERTION FAILED: Unhandled message RemoteSourceBufferProxy_SetTimestampOffset" https://bugs.webkit.org/show_bug.cgi?id=249703 https://commits.webkit.org/262333@main Canonical link: https://commits.webkit.org/262411@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e14c57: Always use originSaltFileName to create salt file ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e14c57a5efec24271da0f3f1bf76ec3faf08baab https://github.com/WebKit/WebKit/commit/e14c57a5efec24271da0f3f1bf76ec3faf08baab Author: Sihui Liu Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp Log Message: --- Always use originSaltFileName to create salt file path in CacheStorageManger https://bugs.webkit.org/show_bug.cgi?id=254705 rdar://107393253 Reviewed by Youenn Fablet. * Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp: (WebKit::saltFilePath): (WebKit::readOrMakeSalt): (WebKit::CacheStorageManager::cacheStorageOriginDirectory): (WebKit::CacheStorageManager::copySaltFileToOriginDirectory): (WebKit::CacheStorageManager::CacheStorageManager): Canonical link: https://commits.webkit.org/262410@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b097d: Web Inspector: Web inspector become unresponsive a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b097d0ecda363b302393bf22b53c771d197995e https://github.com/WebKit/WebKit/commit/9b097d0ecda363b302393bf22b53c771d197995e Author: Razvan Caliman Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/http/tests/inspector/network/resource-mime-type-expected.txt M LayoutTests/http/tests/inspector/network/resource-mime-type.html M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js Log Message: --- Web Inspector: Web inspector become unresponsive after opening online photos https://bugs.webkit.org/show_bug.cgi?id=254602 Reviewed by Patrick Angle and Devin Rousso. When the inspected main resource is an image, it is treated as a document regardless of its MIME type. Its resource type is incorrectly assigned on the backend as `InspectorPageAgent::Document`. See: `InspectorPageAgent::inspectorResourceType(CachedResource::Type type)` See: `CachedResourceLoader::requestMainResource(CachedResourceRequest&& request)` The Sources panel on the frontend represents resources of the type `WI.Resource.Type.Document` with a `WI.TextResourceContentView`. The payload of the image resource response is a blob of base64 text. When inspecting standalone images, Web Inspector passes this giant single-line blob of text to a `WI.SourceCodeTextEditor` where it runs expensive operations on the main thread and blocks it for long periods of time it if there's a lot of content. This patch modifies `InspectorPageAgent` on the backend to return the appropriate resource type for images, `InspectorPageAgent::ImageResource`, even when they are the main resource. This way, the frontend can represent images with the appropriate view: `WI.ImageResourceContentView`. * LayoutTests/http/tests/inspector/network/resource-mime-type-expected.txt: * LayoutTests/http/tests/inspector/network/resource-mime-type.html: Update test for resource type expectations when the document is an image. * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::inspectorResourceType): Canonical link: https://commits.webkit.org/262409@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fec4d0: HTML parser: correct CDATASectionDoubleRightSquare...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fec4d068176ff766a3583b178dcd2abac556efde https://github.com/WebKit/WebKit/commit/fec4d068176ff766a3583b178dcd2abac556efde Author: Anne van Kesteren Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/html5lib/generated/run-tests21-data-expected.txt M LayoutTests/html5lib/generated/run-tests21-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=uri-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=write_single-expected.txt M Source/WebCore/html/parser/HTMLTokenizer.cpp Log Message: --- HTML parser: correct CDATASectionDoubleRightSquareBracketState https://bugs.webkit.org/show_bug.cgi?id=254744 rdar://107421580 Reviewed by Ryosuke Niwa. Add a missing branch to the CDATA section end state to handle right square brackets correctly. * LayoutTests/html5lib/generated/run-tests21-data-expected.txt: * LayoutTests/html5lib/generated/run-tests21-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=uri-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21_run_type=write_single-expected.txt: * Source/WebCore/html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken): Canonical link: https://commits.webkit.org/262408@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f50839: Add RELEASE_LOG_FAULT when decoding child class of...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f50839f0e2654841a96d10e974fa1a326641cbbc https://github.com/WebKit/WebKit/commit/f50839f0e2654841a96d10e974fa1a326641cbbc Author: Alex Christensen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/Platform/Logging.h M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectInterface.mm Log Message: --- Add RELEASE_LOG_FAULT when decoding child class of allowed class through _WKRemoteObjectRegistry https://bugs.webkit.org/show_bug.cgi?id=254776 rdar://106810634 Reviewed by David Kilzer. * Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm: (alwaysAllowedClasses): (checkIfClassIsAllowed): * Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectInterface.mm: (initializeMethod): (isContainerClass): Deleted. (propertyListClasses): Deleted. Canonical link: https://commits.webkit.org/262407@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a07fdb: [git-webkit] Forward environment to cherry-pick
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a07fdbb0871f952b70ecb4237e21ff27c0a64f5d https://github.com/WebKit/WebKit/commit/a07fdbb0871f952b70ecb4237e21ff27c0a64f5d Author: Jonathan Bedard Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/cherry_pick.py Log Message: --- [git-webkit] Forward environment to cherry-pick https://bugs.webkit.org/show_bug.cgi?id=254786 rdar://107447403 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/cherry_pick.py: (CherryPick.main): Forward environment variables to `git cherry-pick` Canonical link: https://commits.webkit.org/262406@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 84f510: [GTK] Unreviewed, build fix for Ubuntu 20.04 after...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84f5108371981e77ec6c245eb788e2176efe69fc https://github.com/WebKit/WebKit/commit/84f5108371981e77ec6c245eb788e2176efe69fc Author: Diego Pino Garcia Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKit/WebProcess/WebProcess.h Log Message: --- [GTK] Unreviewed, build fix for Ubuntu 20.04 after 262210@main https://bugs.webkit.org/show_bug.cgi?id=252988 Variable 'm_displayForCompositing' was not declared for condition PLATFORM(GTK) && USE(EGL). * Source/WebKit/WebProcess/WebProcess.h: Canonical link: https://commits.webkit.org/262405@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe6383: REGRESSION (262337@main) swipe-back-with-passive-w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe6383eb455a364c711d2cc11f89543747a9b454 https://github.com/WebKit/WebKit/commit/fe6383eb455a364c711d2cc11f89543747a9b454 Author: Simon Fraser Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/swipe/resources/swipe-test.js M LayoutTests/swipe/swipe-back-with-active-wheel-listener-expected.txt M LayoutTests/swipe/swipe-back-with-passive-wheel-listener-expected.txt M LayoutTests/swipe/wheel-prevent-default-prevents-swipe-back-expected.txt Log Message: --- REGRESSION (262337@main) swipe-back-with-passive-wheel-listener.html fails https://bugs.webkit.org/show_bug.cgi?id=254795 rdar://107456894 Reviewed by Ryosuke Niwa. 262337@main failed to update the result for swipe-back-with-passive-wheel-listener.html, which no longer logs `startSwipeGesture`. Add a log to `startSlowSwipeGesture()` to make it match `startSwipeGesture()`, and update baselines accordingly. * LayoutTests/swipe/resources/swipe-test.js: (async startSlowSwipeGesture): * LayoutTests/swipe/swipe-back-with-active-wheel-listener-expected.txt: * LayoutTests/swipe/swipe-back-with-passive-wheel-listener-expected.txt: * LayoutTests/swipe/wheel-prevent-default-prevents-swipe-back-expected.txt: Canonical link: https://commits.webkit.org/262404@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 878b8e: fetch should compute its origin from its context
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 878b8e74ec2f636044a79b02027c044ca08c1462 https://github.com/WebKit/WebKit/commit/878b8e74ec2f636044a79b02027c044ca08c1462 Author: Youenn Fablet Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/http/wpt/fetch/origin-no-cors-disabled-expected.txt A LayoutTests/http/wpt/fetch/origin-no-cors-disabled.html A LayoutTests/http/wpt/fetch/resources/echo-origin-cors-disabled.py M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/SecurityOrigin.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl Log Message: --- fetch should compute its origin from its context https://bugs.webkit.org/show_bug.cgi?id=254734 rdar://problem/107414766 Reviewed by Chris Dumez. In case some security features are disabled, the referrer might not be same origin as the context origin for a fetch request. In that case, we should still stick to the context origin and not rely on referrer to compute the origin. We update CachedResourceRequest::updateReferrerAndOriginHeaders accordingly for fetch loads. * LayoutTests/http/wpt/fetch/origin-no-cors-disabled-expected.txt: Added. * LayoutTests/http/wpt/fetch/origin-no-cors-disabled.html: Added. * LayoutTests/http/wpt/fetch/resources/echo-origin-cors-disabled.py: Added. (main): * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::updateReferrerAndOriginHeaders): * Source/WebCore/page/Page.cpp: (WebCore::Page::addCORSDisablingPatternForTesting): * Source/WebCore/page/Page.h: * Source/WebCore/page/SecurityOrigin.h: * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::grantUniversalAccess): (WebCore::Internals::disableCORSForURL): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: Canonical link: https://commits.webkit.org/262403@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42f059: jsc.exe is unable to dump exception output to a file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42f05910565f4a78ddf4e19a548c3600ae5544c5 https://github.com/WebKit/WebKit/commit/42f05910565f4a78ddf4e19a548c3600ae5544c5 Author: Ross Kirsling Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- jsc.exe is unable to dump exception output to a file https://bugs.webkit.org/show_bug.cgi?id=254799 Reviewed by Keith Miller. Currently, Win JSC fails various ChakraCore tests due to diff failures. The crux of the issue is that this works: ``` > .\WebKitBuild\Debug\bin64\jsc.exe .\JSTests\ChakraCore\test\jsc-lib.js > .\JSTests\ChakraCore\test\Basics\bug650104.js name: push -288556213674691number undefined Exception: TypeError: Number().push is not a function. (In 'Number().push()', 'Number().push' is undefined) global code@.\JSTests\ChakraCore\test\Basics\bug650104.js:18:14 ``` But if we add `> out.txt` to the end, the file contains just the first two lines and lacks the dumped exception. The fix is simply to flush before exiting. * Source/JavaScriptCore/jsc.cpp: (dumpException): Canonical link: https://commits.webkit.org/262402@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b541f3: [WGSL] Don't attempt to resolve overloads when one...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b541f3acecef57ddfee4268fb84008d4fad60dde https://github.com/WebKit/WebKit/commit/b541f3acecef57ddfee4268fb84008d4fad60dde Author: Tadeu Zagallo Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebGPU/WGSL/Overload.cpp M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/overload.wgsl Log Message: --- [WGSL] Don't attempt to resolve overloads when one of the arguments is bottom https://bugs.webkit.org/show_bug.cgi?id=254741 rdar://107420386 Reviewed by Myles C. Maxfield. We use the bottom type to avoid expurious error messages related to a previous error that has already been reported. In this case, if one of the arguments is bottom it means that some invalid expressionn made its way into the arguments and we already reported an error for it. If we attempt to resolve the overload we'll unnecessarily report another error, since overload resolution will fail. * Source/WebGPU/WGSL/Overload.cpp: (WGSL::OverloadResolver::conversionRankImpl const): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::chooseOverload): * Source/WebGPU/WGSL/tests/invalid/overload.wgsl: Canonical link: https://commits.webkit.org/262401@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] afcf05: [CSS] Enable CSS Nesting feature
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afcf053c33949f71c449914803935cb3ca0ec31e https://github.com/WebKit/WebKit/commit/afcf053c33949f71c449914803935cb3ca0ec31e Author: Matthieu Dubet Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [CSS] Enable CSS Nesting feature https://bugs.webkit.org/show_bug.cgi?id=254767 rdar://106825062 Reviewed by Brent Fulgham. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/262400@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd0e31: [Margin-trim] Remove a virtual function call on th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd0e3196e1846ef93e142fd7867c2da57f6acdcd https://github.com/WebKit/WebKit/commit/dd0e3196e1846ef93e142fd7867c2da57f6acdcd Author: Alan Baradlay Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderFlexibleBox.h M Source/WebCore/rendering/RenderGrid.cpp M Source/WebCore/rendering/RenderGrid.h Log Message: --- [Margin-trim] Remove a virtual function call on this rare property while computing margins https://bugs.webkit.org/show_bug.cgi?id=254675 Reviewed by Chris Dumez. Do not call the virtual function to check if the child is eligible for margin trimming, unless this (rare) CSS property is on the containing block/flex/grid container. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::isChildEligibleForMarginTrim const): (WebCore::RenderBlockFlow::shouldTrimChildMargin const): Deleted. * Source/WebCore/rendering/RenderBlockFlow.h: * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::isChildEligibleForMarginTrim const): (WebCore::RenderBox::shouldTrimChildMargin const): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::isChildEligibleForMarginTrim const): (WebCore::RenderFlexibleBox::shouldTrimChildMargin const): Deleted. * Source/WebCore/rendering/RenderFlexibleBox.h: * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::isChildEligibleForMarginTrim const): (WebCore::RenderGrid::shouldTrimChildMargin const): Deleted. * Source/WebCore/rendering/RenderGrid.h: Canonical link: https://commits.webkit.org/262399@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f46788: [WGSL] Add typing for unary expressions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f46788aa00cb6852bf31148375ffc762cdb48642 https://github.com/WebKit/WebKit/commit/f46788aa00cb6852bf31148375ffc762cdb48642 Author: Tadeu Zagallo Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebGPU/WGSL/Overload.h M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/generator/main.rb M Source/WebGPU/WGSL/tests/invalid/overload.wgsl M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add typing for unary expressions https://bugs.webkit.org/show_bug.cgi?id=254748 rdar://107424606 Reviewed by Myles C. Maxfield. Make UnaryExpression use the existing overload resolution infrastructure. For now, I only added declarations for unary minus, but I'll add more operators as we go. * Source/WebGPU/WGSL/Overload.h: * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/generator/main.rb: * Source/WebGPU/WGSL/tests/invalid/overload.wgsl: * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/262398@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a349ab: Add masked corners support to InteractionRegions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a349ab55bc80966ce153a39824796e5341d7ce71 https://github.com/WebKit/WebKit/commit/a349ab55bc80966ce153a39824796e5341d7ce71 Author: Etienne Segonzac Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/interaction-region/border-radii-expected.txt A LayoutTests/interaction-region/border-radii.html M Source/WebCore/page/InteractionRegion.cpp M Source/WebCore/page/InteractionRegion.h M Source/WebCore/platform/graphics/RoundedRect.h M Source/WebCore/rendering/EventRegion.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm Log Message: --- Add masked corners support to InteractionRegions https://bugs.webkit.org/show_bug.cgi?id=254775 Reviewed by Tim Horton. Use the `CALayer#maskedCorners` property to refine Interaction layers. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebCore/page/InteractionRegion.h: (WebCore::operator==): Add a new `maskedCorners` OptionSet to the InteractionRegion struct. Re-order the members to keep the optional values at the end. * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): When a `border-radius` is partially applied to the element, use a CornerMask to indicate which corners it applies to. (WebCore::operator<<): Reflect the corner mask in the test dumps. * Source/WebCore/platform/graphics/RoundedRect.h: (WebCore::RoundedRect::Radii::maximumRadius const): Add a maximum radius method to easily detect cases where a corner mask is necessary. * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegionContext::uniteInteractionRegions): Relay the `maskedCorners` value when an InteractionRegion's rect gets split by the subtraction. We could refine this in the future once we have better shape support. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: (WebKit::convertToCACornerMask): (WebKit::updateLayersForInteractionRegions): Apply the corner mask to the Interaction CALayer. * LayoutTests/interaction-region/border-radii-expected.txt: Added. * LayoutTests/interaction-region/border-radii.html: Added. Add a new test file covering many `border-radius` scenarios. Canonical link: https://commits.webkit.org/262397@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b96c4a: Refactor StyleRuleCounterStyle for eliminating Sty...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b96c4a014f188f11c6fdfbb91937d42466fae41e https://github.com/WebKit/WebKit/commit/b96c4a014f188f11c6fdfbb91937d42466fae41e Author: Vitor Roriz Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/prefix-suffix-syntax-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/speak-as-syntax-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/symbols-syntax-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-prefix-suffix-syntax-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-speak-as-syntax-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-symbols-syntax-expected.txt M Source/WebCore/css/CSSCounterStyle.cpp M Source/WebCore/css/CSSCounterStyle.h M Source/WebCore/css/CSSCounterStyleDescriptors.cpp M Source/WebCore/css/CSSCounterStyleDescriptors.h M Source/WebCore/css/CSSCounterStyleRule.cpp M Source/WebCore/css/CSSCounterStyleRule.h M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/rendering/RenderListMarker.cpp Log Message: --- Refactor StyleRuleCounterStyle for eliminating StyleProperties https://bugs.webkit.org/show_bug.cgi?id=254524 rdar://107267784 Reviewed by Antti Koivisto. StyleRuleCounterStyle currently stores `StyleProperties` besides `CSSCounterStyleDescriptors`. This is used for facilitating serialization and read/write for the CSSOM api. We can get rid of the `StyleProperties` member and use only `CSSCounterStyleDescriptors` after we write a serializer for each descriptor and adapt the setter function for setting only the `CSSCounterStyleDescriptors` without havint to set the property that originated the descriptor. * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/prefix-suffix-syntax-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/speak-as-syntax-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/symbols-syntax-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-prefix-suffix-syntax-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-speak-as-syntax-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-symbols-syntax-expected.txt: - We and other browsers don't support url() as symbol for the counter-style at-rule, so these should be failing. They were suceeding, because we parsed it correctly, but since we don't support it, we shouldn't be able to use this value for setting the descriptor. - We don't support the speak-as descriptor, it should be failing. - Note that these tests are duplicated. We should re-import WPT and get rid of the dupes (rdar://107410996) * Source/WebCore/css/CSSCounterStyle.cpp: (WebCore::CSSCounterStyle::counterForSystemCyclic const): (WebCore::CSSCounterStyle::counterForSystemFixed const): (WebCore::CSSCounterStyle::counterForSystemSymbolic const): (WebCore::CSSCounterStyle::counterForSystemAlphabetic const): (WebCore::CSSCounterStyle::counterForSystemNumeric const): (WebCore::CSSCounterStyle::counterForSystemAdditive const): (WebCore::CSSCounterStyle::applyNegativeSymbols const): (WebCore::CSSCounterStyle::applyPadSymbols const): (WebCore::CSSCounterStyle::extendAndResolve): - Since now Symbols is a struct, to support correct serialization of custom-ident and string values, we should access the text value with the .text member. * Source/WebCore/css/CSSCounterStyle.h: (WebCore::CSSCounterStyle::isExtendsUnresolved): - Moving this flag to the descriptor so we can use it for serialization of the system. * Source/WebCore/css/CSSCounterStyleDescriptors.cpp: - We are renaming the translating functions, removing the 'translate' prefix to become in better compliance with WebKit style. - The translation functions are now exposed via the header because when a descriptor is set via CSSOM, we need to translate its CSSValue to the descriptor value. - Each descriptor has now a setter method, which will also take care of its validation. Before, the validation would happen through setterInternal() and newValueInvalidOrEqual() methods: (WebCore::rangeFromStyleProperties): (WebCore::rangeFromCSSValue): (WebCore::symbolFromCSSValue): (WebCore::nameFromCSSValue): (WebCore::additiveSymbolsFromStyleProperties): (WebCore::additiveSymbolsFromCSSValue): (WebCore::padFromStyleProperties): (WebCore::padFromCSSValue): (WebCore::negativeSymbolsFromStyleProperties): (WebCore::negativeSymbolsFromCSSValue):
[webkit-changes] [WebKit/WebKit] f486be: Support rendering non-native in vertical w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f486be28a10145a1cbb817618080f8f3481f2e0d https://github.com/WebKit/WebKit/commit/f486be28a10145a1cbb817618080f8f3481f2e0d Author: Tim Nguyen Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt M LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html M LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt M LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode-expected.html M LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode.html M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional.html M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log M LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt M Source/WebCore/css/horizontalFormControls.css M Source/WebCore/css/html.css M Source/WebCore/html/HTMLMeterElement.cpp M Source/WebCore/html/shadow/meterElementShadow.css Log Message: --- Support rendering non-native in vertical writing mode https://bugs.webkit.org/show_bug.cgi?id=248182 rdar://102595455 Reviewed by Aditya Keerthi. Use logical properties where needed. Also enable rendering behind VerticalFormControls preference. Native rendering will be done separately. * LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt: * LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html: * LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: * LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: * LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode.html: Adjust tests accordingly. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log: * LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt: Added. Imported from WPT upstream repo. * Source/WebCore/css/horizontalFormControls.css: (@namespace "http://www.w3.org/1999/xhtml;;): * Source/WebCore/css/html.css: (select, button, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])): (meter): (select, button, meter, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])): Deleted. * Source/WebCore/html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::didElementStateChange): * Source/WebCore/html/shadow/meterElementShadow.css: (div#value): (div#value.suboptimum): Remove some redundant rules covered by div#value (div#value.even-less-good): Canonical link: https://commits.webkit.org/262395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 90d00d: [CSS] Implement CSSOM insertRule() on StyleRule
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90d00dc15a7b02dda4a6088e22cbdc363b66e567 https://github.com/WebKit/WebKit/commit/90d00dc15a7b02dda4a6088e22cbdc363b66e567 Author: Matthieu Dubet Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalid-inner-rules-expected.txt M Source/WebCore/css/CSSGroupingRule.cpp M Source/WebCore/css/CSSGroupingRule.h M Source/WebCore/css/CSSRule.cpp M Source/WebCore/css/CSSRule.h M Source/WebCore/css/CSSStyleRule.cpp M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/CSSStyleSheet.h M Source/WebCore/css/StyleRule.cpp M Source/WebCore/css/StyleRule.h M Source/WebCore/css/StyleSheetContents.h M Source/WebCore/css/parser/CSSParser.cpp M Source/WebCore/css/parser/CSSParser.h M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSParserImpl.h M Source/WebCore/css/parser/CSSSelectorParser.cpp Log Message: --- [CSS] Implement CSSOM insertRule() on StyleRule https://bugs.webkit.org/show_bug.cgi?id=254601 rdar://107322119 Reviewed by Antti Koivisto. This patch handles the transformation of old-school StyleRule object (without a children vector) to a StyleRuleWithNesting object when necessary. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalid-inner-rules-expected.txt: * Source/WebCore/css/CSSGroupingRule.cpp: (WebCore::CSSGroupingRule::insertRule): (WebCore::CSSGroupingRule::prepareChildStyleRuleForNesting): * Source/WebCore/css/CSSGroupingRule.h: * Source/WebCore/css/CSSRule.cpp: (WebCore::CSSRule::hasStyleRuleAncestor const): (WebCore::CSSRule::prepareChildStyleRuleForNesting): * Source/WebCore/css/CSSRule.h: * Source/WebCore/css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText): (WebCore::CSSStyleRule::cssTextForDeclsAndRules const): (WebCore::CSSStyleRule::insertRule): (WebCore::CSSStyleRule::deleteRule): * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::prepareChildStyleRuleForNesting): * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/css/StyleRule.cpp: (WebCore::m_originalSelectorList): (WebCore::StyleRuleWithNesting::StyleRuleWithNesting): (WebCore::StyleRuleWithNesting::create): * Source/WebCore/css/StyleRule.h: (WebCore::StyleRuleBase::isStyleRule const): * Source/WebCore/css/StyleSheetContents.h: * Source/WebCore/css/parser/CSSParser.cpp: (WebCore::CSSParser::parseRule): * Source/WebCore/css/parser/CSSParser.h: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::CSSParserImpl): (WebCore::CSSParserImpl::parseRule): (WebCore::CSSParserImpl::consumeDeclarationListOrStyleBlockHelper): * Source/WebCore/css/parser/CSSParserImpl.h: (WebCore::CSSParserImpl::isNestedContext): * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeNestedSelectorList): Canonical link: https://commits.webkit.org/262394@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5c038: Remove workarounds for Microsoft My Day, Messenger...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e5c038660e27bd020baf52f74a31b91dc467af5b https://github.com/WebKit/WebKit/commit/e5c038660e27bd020baf52f74a31b91dc467af5b Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/WebCore.order M Source/WebCore/platform/RuntimeApplicationChecks.h M Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig R Source/WebKitLegacy/mac/Misc/OutlookQuirksUserScript.js M Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Remove workarounds for Microsoft My Day, Messenger, and Outlook https://bugs.webkit.org/show_bug.cgi?id=252816 Reviewed by Brent Fulgham. Microsoft My Day no longer exists as of 2008, so we can remove the workarounds made for it. Same for Microsoft Messenger and Microsoft Outlook as of 2010. * Source/WebCore/WebCore.order: Removed mangled names of removed workarounds. * Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm: (isMicrosoftMessenger): Removed. (isMicrosoftMyDay): Removed. * Source/WebCore/platform/RuntimeApplicationChecks.h: (isMicrosoftMessenger): Removed. (isMicrosoftMyDay): Removed. * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: Remove references to OutlookQuirksUserScript.js. * Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig: Ditto. * Source/WebKitLegacy/mac/Misc/OutlookQuirksUserScript.js: Deleted. * Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_HTML5_PARSER. * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (needsMicrosoftMessengerDOMDocumentWorkaround): Removed. * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm: (defaultUsePreHTML5ParserQuirks): Remove calls to isMicrosoftMyDay. * Source/WebKitLegacy/mac/WebView/WebView.mm:(needsOutlookQuirksScript): Removed. (_commonInitializationWithFrameName): Removed call to needsOutlookQuirksScript. (createOutlookQuirksUserScriptContents): Removed (_injectOutlookQuirksScript): Removed. Canonical link: https://commits.webkit.org/262393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d1f6a: [WGSL] Fix overload test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d1f6adbb1f27bf1d46027ef6bbd6e671827f9c6 https://github.com/WebKit/WebKit/commit/7d1f6adbb1f27bf1d46027ef6bbd6e671827f9c6 Author: Tadeu Zagallo Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Fix overload test https://bugs.webkit.org/show_bug.cgi?id=254746 rdar://107424282 Reviewed by Myles C. Maxfield. The test was originally created with a mistake (initializing a mat2x4 with only 4 values), but at the time the type checker didn't catch since we weren't validating arguments of construtors with explicit type arguments (i.e. mat2x4 in this case). That was fixed in 262325@main, but I forgot to update the test. * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/262392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5560df: Enable new WebGL conformance tests, conformance/{g...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5560dfadfa5d5a1d97ff73a8b1741653a16316c5
https://github.com/WebKit/WebKit/commit/5560dfadfa5d5a1d97ff73a8b1741653a16316c5
Author: Kimmo Kinnunen
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk-wayland/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
Log Message:
---
Enable new WebGL conformance tests, conformance/{glsl,limits}
https://bugs.webkit.org/show_bug.cgi?id=254320
rdar://107122630
Reviewed by Antti Koivisto.
Enable subset of webgl/1.0.x, webgl/2.0.y and disable old tests.
* LayoutTests/TestExpectations:
* LayoutTests/platform/gtk-wayland/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
Canonical link: https://commits.webkit.org/262391@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2700ab: Avoid CPU time under AnimationEffect::getBasicTimi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2700abd1cd65088c94c06be6e3d711dbee1561a5 https://github.com/WebKit/WebKit/commit/2700abd1cd65088c94c06be6e3d711dbee1561a5 Author: Chris Dumez Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/animation/DeclarativeAnimation.cpp M Source/WebCore/animation/DeclarativeAnimation.h Log Message: --- Avoid CPU time under AnimationEffect::getBasicTiming() when no animation event listeners are registered https://bugs.webkit.org/show_bug.cgi?id=254792 Reviewed by Antoine Quint. Avoid CPU time under AnimationEffect::getBasicTiming() when no animation event listeners are registered: Sample Count, Samples %, Normalized CPU %, Symbol 45, 0.0%, 0.0%, WebCore::AnimationEffect::getBasicTiming(std::__1::optional) const (in WebCore) 25, 0.0%, 0.0%, WebCore::DeclarativeAnimation::cancelFromStyle() (in WebCore) 8, 0.0%, 0.0%, WebCore::WebAnimation::updateRelevance() (in WebCore) 5, 0.0%, 0.0%, WebCore::Styleable::cancelDeclarativeAnimations() const (in WebCore) * Source/WebCore/animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::tick): (WebCore::DeclarativeAnimation::cancel): (WebCore::DeclarativeAnimation::shouldFireDOMEvents const): (WebCore::DeclarativeAnimation::invalidateDOMEvents): * Source/WebCore/animation/DeclarativeAnimation.h: Canonical link: https://commits.webkit.org/262390@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d07a15: Enable new WebGL conformance tests, conformance/{c...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d07a15d103fd10637522e84e5998e70d6a097476
https://github.com/WebKit/WebKit/commit/d07a15d103fd10637522e84e5998e70d6a097476
Author: Kimmo Kinnunen
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk-wayland/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios-simulator-wk2/TestExpectations
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M LayoutTests/platform/wk2/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M LayoutTests/webgl/TestExpectations
R LayoutTests/webgl/conformance/extensions/ext-float-blend-expected.txt
R LayoutTests/webgl/conformance/extensions/ext-float-blend.html
R
LayoutTests/webgl/conformance/extensions/ext-texture-compression-rgtc-expected.txt
R LayoutTests/webgl/conformance/extensions/ext-texture-compression-rgtc.html
R
LayoutTests/webgl/conformance/extensions/khr-parallel-shader-compile-expected.txt
R LayoutTests/webgl/conformance/extensions/khr-parallel-shader-compile.html
R
LayoutTests/webgl/conformance/extensions/oes-fbo-render-mipmap-expected.txt
R LayoutTests/webgl/conformance/extensions/oes-fbo-render-mipmap.html
R LayoutTests/webgl/conformance/extensions/s3tc-and-rgtc-expected.txt
R LayoutTests/webgl/conformance/extensions/s3tc-and-rgtc.html
R LayoutTests/webgl/conformance/extensions/webgl-multi-draw-expected.txt
R LayoutTests/webgl/conformance/extensions/webgl-multi-draw.html
Log Message:
---
Enable new WebGL conformance tests, conformance/{context,extensions}
https://bugs.webkit.org/show_bug.cgi?id=254208
rdar://106989736
Reviewed by Dean Jackson.
Enable subset of webgl/1.0.x, webgl/2.0.y and disable old tests.
* LayoutTests/TestExpectations:
Canonical link: https://commits.webkit.org/262389@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 552a34: Web Inspector: support OffscreenCanvas for Canvas ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 552a34376f9678e24c422e71dfdb3539bc9b096e https://github.com/WebKit/WebKit/commit/552a34376f9678e24c422e71dfdb3539bc9b096e Author: Kimmo Kinnunen Date: 2023-03-30 (Thu, 30 Mar 2023) Changed paths: A LayoutTests/inspector/canvas/console-record-offscreen-canvas-2d-expected.txt A LayoutTests/inspector/canvas/console-record-offscreen-canvas-2d.html M LayoutTests/inspector/canvas/context-attributes-expected.txt M LayoutTests/inspector/canvas/context-attributes.html M LayoutTests/inspector/canvas/create-context-2d-expected.txt M LayoutTests/inspector/canvas/create-context-2d.html M LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt M LayoutTests/inspector/canvas/create-context-webgl-expected.txt M LayoutTests/inspector/canvas/create-context-webgl2-expected.txt A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount-expected.txt A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount.html A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full.html A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-memoryLimit-expected.txt A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-memoryLimit.html A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-saves-expected.txt A LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-saves.html M LayoutTests/inspector/canvas/requestClientNodes-expected.txt M LayoutTests/inspector/canvas/requestClientNodes.html M LayoutTests/inspector/canvas/requestContent-2d-expected.txt M LayoutTests/inspector/canvas/requestContent-2d.html M LayoutTests/inspector/canvas/resolveContext-2d-expected.txt M LayoutTests/inspector/canvas/resolveContext-2d.html M LayoutTests/inspector/canvas/resources/create-context-utilities.js M LayoutTests/inspector/canvas/resources/recording-2d.js M LayoutTests/platform/gtk/TestExpectations A LayoutTests/platform/gtk/inspector/canvas/context-attributes-expected.txt A LayoutTests/platform/gtk/inspector/canvas/requestClientNodes-expected.txt A LayoutTests/platform/gtk/inspector/canvas/requestContent-2d-expected.txt A LayoutTests/platform/gtk/inspector/canvas/resolveContext-2d-expected.txt M Source/JavaScriptCore/inspector/protocol/Canvas.json M Source/JavaScriptCore/inspector/protocol/Recording.json M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/OffscreenCanvas.idl M Source/WebCore/html/canvas/CanvasRenderingContext.h M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.h M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl M Source/WebCore/inspector/InspectorCanvas.cpp M Source/WebCore/inspector/InspectorCanvas.h M Source/WebCore/inspector/InspectorCanvasCallTracer.cpp M Source/WebCore/inspector/InspectorCanvasCallTracer.h M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp M Source/WebCore/page/PageConsoleClient.cpp M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Models/Canvas.js M Source/WebInspectorUI/UserInterface/Models/Recording.js M Source/WebInspectorUI/UserInterface/Models/RecordingAction.js M Source/WebInspectorUI/UserInterface/Models/RecordingState.js M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js M Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js M Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js M Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js Log Message: --- Web Inspector: support OffscreenCanvas for Canvas related operations https://bugs.webkit.org/show_bug.cgi?id=180833 rdar://36059660 Reviewed by Devin Rousso. Implement Inspector support for OffscreenCanvas OffscreenCanvasRenderingContext2D for main page (not workers). Later commits may add support for workers. Fixes assertion failures when bringing up Inspector for pages that use OffscreenCanvas. * LayoutTests/inspector/canvas/console-record-offscreen-canvas-2d-expected.txt: Added. * LayoutTests/inspector/canvas/console-record-offscreen-canvas-2d.html: Added. * LayoutTests/inspector/canvas/context-attributes-expected.txt: * LayoutTests/inspector/canvas/context-attributes.html: * LayoutTests/inspector/canvas/create-context-2d-expected.txt: * LayoutTests/inspector/canvas/create-context-2d.html: * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount-expected.txt: Added. * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount.html: Added. *
