date:20231016

[webkit-changes] [WebKit/WebKit] 236dd9: SVGResourcesCache::addResourcesFromRenderObject sh...

2023-10-16 Thread Rob Buis

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 236dd9dd2c2c2cf873fc7de8d3d15bd685176724
  
https://github.com/WebKit/WebKit/commit/236dd9dd2c2c2cf873fc7de8d3d15bd685176724
  Author: Rob Buis 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/rendering/svg/SVGResources.cpp
M Source/WebCore/rendering/svg/SVGResources.h
M Source/WebCore/rendering/svg/SVGResourcesCache.cpp

  Log Message:
  ---
  SVGResourcesCache::addResourcesFromRenderObject should not allocate 
SVGResources unconditionally
https://bugs.webkit.org/show_bug.cgi?id=98684

Reviewed by Nikolas Zimmermann.

Only allocate SVGResources where needed and possible (not pending).

* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::setClipper):
(WebCore::SVGResources::setFilter):
(WebCore::SVGResources::setMarkerStart):
(WebCore::SVGResources::setMarkerMid):
(WebCore::SVGResources::setMarkerEnd):
(WebCore::SVGResources::setMasker):
(WebCore::SVGResources::setFill):
(WebCore::SVGResources::setStroke):
(WebCore::SVGResources::setLinkedResource):
* Source/WebCore/rendering/svg/SVGResources.h:
* Source/WebCore/rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::addResourcesFromRenderer):

Canonical link: https://commits.webkit.org/269397@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ad445: Stop using StringView::operator[] in hot code path...

2023-10-16 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ad44599784a7ab2e46317f371e0c33b667906fe
  
https://github.com/WebKit/WebKit/commit/9ad44599784a7ab2e46317f371e0c33b667906fe
  Author: Chris Dumez 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp

  Log Message:
  ---
  Stop using StringView::operator[] in hot code paths in WebCore
https://bugs.webkit.org/show_bug.cgi?id=263216

Reviewed by Darin Adler.

Stop using StringView::operator[] in hot code paths in WebCore. StringView's
operator[] is not super efficient because it needs to check the is8Bit flag for
every character when iterating. I am also looking into adding a boundary check
in StringView::operator[], which would further increase branching.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::moveToNextNonWhitespacePosition):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuring):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::canUseSimplifiedTextMeasuring):

Canonical link: https://commits.webkit.org/269396@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39451b: Eliminate Test Code to crash a WebKit XPC service

2023-10-16 Thread Michael Saboff

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39451bfc5712f354d2ecf713c24de4d5f1336165
  
https://github.com/WebKit/WebKit/commit/39451bfc5712f354d2ecf713c24de4d5f1336165
  Author: Michael Saboff 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
R Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig
R Source/WebKit/Configurations/WebContentService.Crashy.xcconfig
M Source/WebKit/Configurations/WebContentService.xcconfig
M Source/WebKit/Scripts/process-entitlements.sh
R 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist
M Source/WebKit/Shared/AuxiliaryProcessExtensions/com.apple.WebKit.appexpt
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Eliminate Test Code to crash a WebKit XPC service
https://bugs.webkit.org/show_bug.cgi?id=263045
rdar://115678493

Reviewed by Timothy Hatcher and Alex Christensen.

Remove WebContent.Crashy XPC process as it has served its purpose and is no 
longer needed.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig: Removed.
* Source/WebKit/Configurations/WebContentService.Crashy.xcconfig: Removed.
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist:
 Removed.
* Source/WebKit/Shared/AuxiliaryProcessExtensions/com.apple.WebKit.appexpt:
* 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
(isInternalBuild): Deleted.
(canaryInBaseState): Deleted.
(WebKit::WebProcessPool::initializeShouldCrashWhenCreatingWebProcess): Deleted.
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::webContentServiceName):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::forEachProcessForSession):
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
(WebKit::WebProcessProxy::createForWebContentCrashy): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::isCrashyProcess const): Deleted.
(WebKit::WebProcessProxy::setIsCrashyProcess): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::deliberateCrashForTesting): Deleted.

Canonical link: https://commits.webkit.org/269395@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 429bb1: Adopt _UIContextMenuAsyncConfiguration to let cont...

2023-10-16 Thread Wenson Hsieh

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 429bb1ad0f79cf369c4c81f7137636f4cfd8eee3
  
https://github.com/WebKit/WebKit/commit/429bb1ad0f79cf369c4c81f7137636f4cfd8eee3
  Author: Wenson Hsieh 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Adopt _UIContextMenuAsyncConfiguration to let context menu interactions begin 
asynchronously
https://bugs.webkit.org/show_bug.cgi?id=263172
rdar://114349359

Reviewed by Tim Horton and Abrar Rahman Protyasha.

Adopt `_UIContextMenuAsyncConfiguration` in WebKit to support async context 
menu interactions
without the need to use the following private context menu delegate method:

```
- (void)_contextMenuInteraction:(UIContextMenuInteraction *)interaction
configurationForMenuAtLocation:(CGPoint)location
completion:(void(^)(UIContextMenuConfiguration *))completion;
```

To use the new context menu async configuration, we simply return 
`_UIContextMenuAsyncConfiguration`
synchronously from the normal API context menu configuration delegate method; 
later, when we have
the concrete context menu configuration that we should proceed with, we call
`-fulfillWithConfiguration:` to swap out the placeholder async configuration 
with the real
configuration, which allows UIKit to proceed with the interaction.

* Source/WTF/wtf/PlatformHave.h:

Add new compile-time feature flags.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:

Drive-by fix: put conformance to `UIAsyncTextInput` behind a runtime flag as 
well, to make staged
API adoption possible.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

Add soft-link support for some of the new classes, to help preserve binary 
compatibility.

(-[WKContentView _shouldUseUIContextMenuAsyncConfiguration]):

Return `YES` if and only if we're building for an OS with 
`_UIContextMenuAsyncConfiguration`, and
`_UIContextMenuAsyncConfiguration` also exists in the runtime.

(-[WKContentView _ensureBinaryCompatibilityWithAsyncInteractionsIfNeeded]):

In order to properly opt into the `_UIContextMenuAsyncConfiguration` codepath, 
we can't implement
the legacy async method 
(`-_contextMenuInteraction:configurationForMenuAtLocation:completion:`),
since that legacy method takes priority (because UIKit only calls one of either 
the legacy async
method or the normal context menu configuration API delegate method).

However, since we still need to continue supporting the legacy async codepath 
when the runtime
feature flag is off, we need to implement the legacy async delegate method if 
the feature flag is
disabled (or `_UIContextMenuAsyncConfiguration` is otherwise unavailable).

To make this all work, we rename the existing async delegate method to have an 
`_internal` prefix,
and then use `class_addMethod` to dynamically add an implementation of the 
legacy async codepath if
needed.

(-[WKContentView setUpInteraction]):
(-[WKContentView _dragInteractionClass]):

Drive-by fix: soft link `_UIAsyncDragInteraction` so that we don't crash on 
launch, when testing
against builds without UIKit support for `_UIAsyncDragInteraction`.

(-[WKContentView contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKContentView 
_internalContextMenuInteraction:configurationForMenuAtLocation:completion:]):
(-[WKContentView 
_contextMenuInteraction:configurationForMenuAtLocation:completion:]): Deleted.

Canonical link: https://commits.webkit.org/269394@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5ff33a: REGRESSION(269388@main): Fix syntax error

2023-10-16 Thread Ross Kirsling

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ff33a6265147124f2360e1f936ade9cec34176b
  
https://github.com/WebKit/WebKit/commit/5ff33a6265147124f2360e1f936ade9cec34176b
  Author: Ross Kirsling 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/dom/Document.cpp

  Log Message:
  ---
  REGRESSION(269388@main): Fix syntax error
https://bugs.webkit.org/show_bug.cgi?id=263235

Unreviewed PlayStation build fix.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::createElementNS):
Put #endif where it belongs.

Canonical link: https://commits.webkit.org/269393@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] baa3a7: [WGSL] Fix argument buffer generation when using e...

2023-10-16 Thread Tadeu Zagallo

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: baa3a7fc959adc64f4cf77ee5319a3266461d54a
  
https://github.com/WebKit/WebKit/commit/baa3a7fc959adc64f4cf77ee5319a3266461d54a
  Author: Tadeu Zagallo 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/MangleNames.cpp
M Source/WebGPU/WGSL/WGSL.h
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  ---
  [WGSL] Fix argument buffer generation when using explicit layouts
https://bugs.webkit.org/show_bug.cgi?id=262956
rdar://116739149

Reviewed by Dan Glastonbury and Mike Wyrzykowski.

Originally, the global rewriter was written with only auto layouts in mind, so 
it
always generated a new layout instead of consulting the user-provided layout 
when
there is one. The biggest change required was in `insertStructs`, where we 
either
use the information we discovered about which globals are used to create the
argument buffer structs, or the new path, where we use the user-provided bind 
group
layouts to generate the same structs.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::RewriteGlobalVariables):
(WGSL::RewriteGlobalVariables::run):
(WGSL::RewriteGlobalVariables::collectGlobals):
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::createArgumentBufferEntry):
(WGSL::RewriteGlobalVariables::finalizeArgumentBufferStruct):
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::run):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::convertPipelineLayout):

Canonical link: https://commits.webkit.org/269392@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c193b9: [Gardening]: REGRESSION(264111@main): 2 layout tes...

2023-10-16 Thread Ben

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c193b95a25cf7d88b9d814b1942c1b9be3cbdd59
  
https://github.com/WebKit/WebKit/commit/c193b95a25cf7d88b9d814b1942c1b9be3cbdd59
  Author: Ben Schwartz 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(264111@main): 2 layout tests under 
imported/w3c/web-platform-tests/webrtc/* are consistently failing.
rdar://117045403
https://bugs.webkit.org/show_bug.cgi?id=263227

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269391@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9320b5: (REGRESSION (265731@main): fast/scrolling/rtl-scro...

2023-10-16 Thread Nikos Mouchtaris

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9320b50206384e7b857c586879952789b6d16aaf
  
https://github.com/WebKit/WebKit/commit/9320b50206384e7b857c586879952789b6d16aaf
  Author: Nikolaos Mouchtaris 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/platform/mac/ScrollbarThemeMac.mm

  Log Message:
  ---
  (REGRESSION (265731@main): 
fast/scrolling/rtl-scrollbars-animation-property.html is a constant failure)
https://bugs.webkit.org/show_bug.cgi?id=262930
rdar://114349934

Reviewed by Cameron McCormack.

After https://commits.webkit.org/265731@main 
ScrollbarThemeMac::isLayoutDirectionRTL did not have an
NSScrollerImp to query about being in rtl mode. AppKit only uses 
userInterfaceLayoutDirection for
rectForPart/expandedRectForPart, which are not used with UI-side compositing, 
so for now if we detect
that the scrollbar should not be registered (due to UI-side compositing being 
on), just query the scrollable
area to see if the scrollbar is in rtl mode.

* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::isLayoutDirectionRTL):

Canonical link: https://commits.webkit.org/269390@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 418b7e: [Gardening]: REGRESSION(268692@main?): [ macOS ] 7...

2023-10-16 Thread Ben

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 418b7e23c9ec1c57c32bc1f59c78f6f78ce3d4d7
  
https://github.com/WebKit/WebKit/commit/418b7e23c9ec1c57c32bc1f59c78f6f78ce3d4d7
  Author: Ben Schwartz 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(268692@main?): [ macOS ] 7 tests under 
imported/w3c/web-platform-tests/media-source/mediasource-* are flaky failures.
rdar://117044354
https://bugs.webkit.org/show_bug.cgi?id=263226

Unreviewed test gardening.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/269389@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a2095: Opportunistically match built-in elements in creat...

2023-10-16 Thread Ryosuke Niwa

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a209521829e185dec49e36f65f9c6bca28dfc2b
  
https://github.com/WebKit/WebKit/commit/0a209521829e185dec49e36f65f9c6bca28dfc2b
  Author: Ryosuke Niwa 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/dom/Document.cpp

  Log Message:
  ---
  Opportunistically match built-in elements in createElementNS
https://bugs.webkit.org/show_bug.cgi?id=263151

Reviewed by Chris Dumez.

Look up the element factory before validating the qualified name.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::createElementNS):
(WebCore::isValidNameASCIIWithoutColon):
(WebCore::Document::parseQualifiedName):

Canonical link: https://commits.webkit.org/269388@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a5e53e: Unreviewed, fix the iOS build after 269380@main

2023-10-16 Thread Wenson Hsieh

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5e53e11ebf99273ad071579c6869965fac28b20
  
https://github.com/WebKit/WebKit/commit/a5e53e11ebf99273ad071579c6869965fac28b20
  Author: Wenson Hsieh 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  Unreviewed, fix the iOS build after 269380@main

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

Canonical link: https://commits.webkit.org/269387@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f3d56e: Fix build issue related to logging

2023-10-16 Thread Per Arne Vollan

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3d56e14cb77e435db0645ad1f8c5f80d0244b25
  
https://github.com/WebKit/WebKit/commit/f3d56e14cb77e435db0645ad1f8c5f80d0244b25
  Author: Per Arne Vollan 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Fix build issue related to logging
https://bugs.webkit.org/show_bug.cgi?id=263201
rdar://116956433

Reviewed by Chris Dumez.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerLogHook):

Canonical link: https://commits.webkit.org/269386@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 829fc2: Begin serializing RTCNetwork structures

2023-10-16 Thread Alex Christensen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 829fc2e8c8ea1d582570950cced6e199906a75fe
  
https://github.com/WebKit/WebKit/commit/829fc2e8c8ea1d582570950cced6e199906a75fe
  Author: Alex Christensen 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/Shared/RTCNetwork.cpp
M Source/WebKit/Shared/RTCNetwork.h
A Source/WebKit/Shared/RTCNetwork.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp

  Log Message:
  ---
  Begin serializing RTCNetwork structures
https://bugs.webkit.org/show_bug.cgi?id=263206
rdar://117030766

Reviewed by Youenn Fablet.

This is the simple pieces of a previous attempt that caused a regression, but 
only in post-commit tests
for an unknown reason.  I'll land this, watch the bots, then land more, watch 
the bots, etc.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::NetworkManagerWrapper::onNetworksChanged):
* Source/WebKit/Shared/RTCNetwork.cpp:
(WebKit::RTCNetwork::value const):
(WebKit::RTCNetwork::SocketAddress::decode):
(WebKit::RTCNetwork::decode):
(WebKit::RTC::Network::IPAddress::IPAddress):
(WebKit::RTC::Network::IPAddress::rtcAddress const):
(WebKit::RTC::Network::InterfaceAddress::InterfaceAddress):
(WebKit::RTC::Network::InterfaceAddress::rtcAddress const):
(WebKit::RTCNetwork::IPAddress::decode): Deleted.
(WebKit::RTCNetwork::IPAddress::encode const): Deleted.
* Source/WebKit/Shared/RTCNetwork.h:
(WebKit::RTC::Network::IPAddress::UnspecifiedFamily::operator== const):
(WebKit::RTC::Network::IPAddress::IPAddress):
(WebKit::RTC::Network::InterfaceAddress::InterfaceAddress):
(WebKit::RTC::Network::SocketAddress::SocketAddress):
(WebKit::RTCNetwork::IPAddress::IPAddress): Deleted.
(WebKit::RTCNetwork::SocketAddress::SocketAddress): Deleted.
* Source/WebKit/Shared/RTCNetwork.serialization.in: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:
(WebKit::LibWebRTCNetwork::signalReadPacket):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::networksChanged):
* Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp:
(WebKit::WebRTCResolver::setResolvedAddress):

Canonical link: https://commits.webkit.org/269385@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac8c79: REBASELINE: REGRESSION(268861@main): [ Monterey Ve...

2023-10-16 Thread Ben

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac8c79fc57f2629fd4359d06159a280d24ef16dc
  
https://github.com/WebKit/WebKit/commit/ac8c79fc57f2629fd4359d06159a280d24ef16dc
  Author: Ben Schwartz 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
A 
LayoutTests/platform/mac-monterey-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
A 
LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
M 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt

  Log Message:
  ---
  REBASELINE: REGRESSION(268861@main): [ Monterey Ventura ] 
imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001.html
 needs re-baselining.
rdar://117035893
https://bugs.webkit.org/show_bug.cgi?id=263214

Unreviewed test rebaseline.

Re-re-baseline(??)s 1 constantly failing test on Monterey and Ventura.

* 
LayoutTests/platform/mac-monterey-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
 Copied from 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt.
* 
LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
 Copied from 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt.
* 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:

Canonical link: https://commits.webkit.org/269384@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4878f0: REGRESSION(269369@main) ASSERTION FAILED: !m_inRem...

2023-10-16 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4878f0893799367e57d604ee5358f8e6369ee971
  
https://github.com/WebKit/WebKit/commit/4878f0893799367e57d604ee5358f8e6369ee971
  Author: Chris Dumez 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/dom/ContainerNode.cpp

  Log Message:
  ---
  REGRESSION(269369@main) ASSERTION FAILED: !m_inRemovedLastRefFunction in 
WebCore::Node::ref
https://bugs.webkit.org/show_bug.cgi?id=263217

Unreviewed, partial revert of 269369@main to address the assertion hit.

* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeNodeWithScriptAssertion):

Canonical link: https://commits.webkit.org/269383@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0f9d5a: WTF::map in NativePromise to build Vectors

2023-10-16 Thread Jean-Yves Avenard

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f9d5afd257ecb62c8e877f2df163c6140188d58
  
https://github.com/WebKit/WebKit/commit/0f9d5afd257ecb62c8e877f2df163c6140188d58
  Author: Jean-Yves Avenard 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WTF/wtf/NativePromise.h

  Log Message:
  ---
  WTF::map in NativePromise to build Vectors
https://bugs.webkit.org/show_bug.cgi?id=263176
rdar://116991334

Reviewed by Chris Dumez.

No change in functional behaviour.

* Source/WTF/wtf/NativePromise.h:

Canonical link: https://commits.webkit.org/269382@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d91d0b: Fix the build with recent SDKs

2023-10-16 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d91d0b6d092e028f08ce1901d02fcc3032e57578
  
https://github.com/WebKit/WebKit/commit/d91d0b6d092e028f08ce1901d02fcc3032e57578
  Author: Karl Rackler 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  ---
  Fix the build with recent SDKs
https://bugs.webkit.org/show_bug.cgi?id=263212
rdar://117033998

Unreviewed Build Fix.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _updateScrollViewForTransaction:]):
(-[WKWebView _scrollToContentScrollPosition:scrollOrigin:animated:]):
(-[WKWebView _viewStabilityState:]):

Canonical link: https://commits.webkit.org/269381@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 100c20: Adopt even more smart pointers in the DOM

2023-10-16 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 100c20fadc5e59baa58f342cec29e7b9dff3c1e5
  
https://github.com/WebKit/WebKit/commit/100c20fadc5e59baa58f342cec29e7b9dff3c1e5
  Author: Chris Dumez 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WTF/wtf/Ref.h
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/bindings/js/JSDOMWindowProperties.cpp
M Source/WebCore/css/StyleSheetList.cpp
M Source/WebCore/dom/CustomElementDefaultARIA.cpp
M Source/WebCore/dom/CustomElementDefaultARIA.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/DocumentFragment.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/ElementInternals.cpp
M Source/WebCore/dom/ElementInternals.h
M Source/WebCore/dom/ImageOverlay.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/SelectorQuery.cpp
M Source/WebCore/dom/TreeScope.cpp
M Source/WebCore/dom/TreeScope.h
A Source/WebCore/dom/TreeScopeInlines.h
M Source/WebCore/dom/TreeScopeOrderedMap.cpp
M Source/WebCore/dom/TreeScopeOrderedMap.h
M Source/WebCore/dom/TreeWalker.cpp
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/dom/VisitedLinkState.cpp
M Source/WebCore/dom/mac/ImageControlsMac.cpp
M Source/WebCore/html/CachedHTMLCollectionInlines.h
M Source/WebCore/html/HTMLAreaElement.cpp
M Source/WebCore/html/HTMLAreaElement.h
M Source/WebCore/html/HTMLCollection.cpp
M Source/WebCore/html/HTMLCollection.h
M Source/WebCore/html/HTMLCollectionInlines.h
M Source/WebCore/html/HTMLDocument.h
M Source/WebCore/html/HTMLFormControlElement.cpp
M Source/WebCore/html/HTMLFormControlElement.h
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLImageElement.h
M Source/WebCore/html/HTMLMapElement.cpp
M Source/WebCore/html/HTMLMapElement.h
M Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/PrintContext.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/SpatialNavigation.cpp
M Source/WebCore/rendering/CSSFilter.cpp
M Source/WebCore/rendering/ReferencedSVGResources.cpp
M Source/WebCore/rendering/ReferencedSVGResources.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderLayerFilters.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGSVGElement.h
M Source/WebCore/svg/SVGViewSpec.cpp
M Source/WebCore/svg/SVGViewSpec.h
M Source/WebCore/svg/animation/SVGSMILElement.cpp
M Source/WebCore/svg/animation/SVGSMILElement.h
M Source/WebCore/xml/XPathFunctions.cpp
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp

  Log Message:
  ---
  Adopt even more smart pointers in the DOM
https://bugs.webkit.org/show_bug.cgi?id=263171

Reviewed by Darin Adler and Ryosuke Niwa.

* Source/WTF/wtf/Ref.h:
Remove dead declarations (without implementation) which caused linking errors
as I was working on this.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::addRelations):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::labelsForNode):
(WebCore::AccessibilityNodeObject::popoverTargetElement const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::descriptionForElements const):
(WebCore::AccessibilityNodeObject::ariaLabeledByElements const):
(WebCore:: const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isTabItemSelected const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::elementsFromAttribute const):
(WebCore:: const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::popoverTargetElement const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap const):
(WebCore::AccessibilityRenderObject::documentLinks):
*

[webkit-changes] [WebKit/WebKit] f82533: [JSC] Avoid calling setIsFunction() for function n...

2023-10-16 Thread Commit Queue

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f82533b7e079ad511df75a66c942f60ec73c145a
  
https://github.com/WebKit/WebKit/commit/f82533b7e079ad511df75a66c942f60ec73c145a
  Author: Alexey Shvayka 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/parser/Parser.h

  Log Message:
  ---
  [JSC] Avoid calling setIsFunction() for function name bindings
https://bugs.webkit.org/show_bug.cgi?id=263097


Reviewed by Ross Kirsling.

Our implementations of GlobalDeclarationInstantiation / 
EvalDeclarationInstantiation
(ProgramExecutable::initializeGlobalProperties() / Interpreter::executeEval() 
respectively)
rely on IsFunction to detect bindings created via FunctionDeclaration & friends.

While calling setIsFunction() on a function name binding doesn't seem to affect 
any logic expect for
duplicate parameter SyntaxError, it's semantically more pure to reserve 
IsFunction bit only for
FunctionDeclaration & friends.

Since at the time of declareParameter() being called, only the function name 
binding and other
parameters can be declared, this change tweaks the SyntaxError condition to 
utilize isParameter()
instead, ensuring that it's checked before calling setIsParameter(), and 
refactors `isValidStrictMode`
to rely on that condition as well.

No new tests, no behavior change.

* Source/JavaScriptCore/parser/Parser.h:
(JSC::Scope::declareCallee):
(JSC::Scope::declareParameter):

Canonical link: https://commits.webkit.org/269379@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff056c: WKWebView does not respect `-[UIScrollView allowsK...

2023-10-16 Thread Richard Robinson

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff056c129d9c43a15b6b2a52e9ab874d8b50eaba
  
https://github.com/WebKit/WebKit/commit/ff056c129d9c43a15b6b2a52e9ab874d8b50eaba
  Author: Richard Robinson 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKScrollView.mm
M Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm

  Log Message:
  ---
  WKWebView does not respect `-[UIScrollView allowsKeyboardScrolling]`
https://bugs.webkit.org/show_bug.cgi?id=263164
rdar://115803459

Reviewed by Wenson Hsieh.

When determining if a keyboard scroll may occur, consult the value of 
`-[UIScrollView allowsKeyboardScrolling]`,
a new API introduced in iOS 17.

The default value of this property is `NO` on iPhone, and `YES` on iPad, 
Catalyst, and Vision. As such, the
property must initially be set to `YES` in WKScrollView to maintain its 
existing behavior.

Also adds an API test for this behavior.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView initWithFrame:]):
* Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(TEST):

Canonical link: https://commits.webkit.org/269378@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8b8b2: Fix the build with recent SDKs

2023-10-16 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8b8b2abc043d951986572592b2a257dbba2a720
  
https://github.com/WebKit/WebKit/commit/b8b8b2abc043d951986572592b2a257dbba2a720
  Author: Karl Rackler 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm

  Log Message:
  ---
  Fix the build with recent SDKs
https://bugs.webkit.org/show_bug.cgi?id=263212
rdar://117033998

Unreviewed build fix.

* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::stopAnimatedScroll):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::repositionScrollingLayers):

Canonical link: https://commits.webkit.org/269377@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 001401: REGRESSION (266316@main): Disabled checkboxes chan...

2023-10-16 Thread Aditya Keerthi

Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 001401163eab13ecfa88bb58726721ac450edb3c

https://github.com/WebKit/WebKit/commit/001401163eab13ecfa88bb58726721ac450edb3c
Author: Aditya Keerthi
Date: 2023-10-16 (Mon, 16 Oct 2023)

Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-checkbox-click-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-checkbox-click.html
M Source/WebCore/dom/EventDispatcher.cpp

Log Message:
---
REGRESSION (266316@main): Disabled checkboxes change state when clicked
https://bugs.webkit.org/show_bug.cgi?id=263148
rdar://116927372

Reviewed by Chris Dumez and Brian Weinstein.

266316@main enabled the `SendMouseEventsToDisabledFormControlsEnabled` setting,
originally implemented in 264098@main.

Prior to that change, `EventDispatcher::dispatchEvent` was elided for disabled
form controls. Following the change, events can be dispatched on disabled
controls. If the event is trusted, the event path is shrunk to remove the
disabled control. This means that trusted mouse events are not dispatched on
the clicked control itself. However, `HTMLInputElement::willDispatchEvent` is
still called on the disabled control, which triggers the state change.

To fix, elide the call to `HTMLInputElement::willDispatchEvent` in
`EventDispatcher::dispatchEvent` when the node is a disabled control and the
event is trusted. Untrusted click events can still change the checked state of
checkboxes.

*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-checkbox-click-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-checkbox-click.html:
Added.
* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

Canonical link: https://commits.webkit.org/269376@main

___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e5207: [Win] "git-webkit pr" reports "FileNotFoundError: ...

2023-10-16 Thread Fujii Hironori

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e52075ba71d423f80d114f5fadb759e7c692db2
  
https://github.com/WebKit/WebKit/commit/3e52075ba71d423f80d114f5fadb759e7c692db2
  Author: Fujii Hironori 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  ---
  [Win] "git-webkit pr" reports "FileNotFoundError: [WinError 2] The system 
cannot find the file specified"
https://bugs.webkit.org/show_bug.cgi?id=258704

Reviewed by Jonathan Bedard.

'git-webkit pr' runs pre-pr checkers specifed in webkitscmpy.pre-pr
config. 'python3' is hard-coded in 'metadata/git_config_extension'
file, but Windows Python doesn't contain 'python3.exe'.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
If the commnad name of webkitscmpy.pre-pr config is 'python3', replace
it with sys.executable.

Canonical link: https://commits.webkit.org/269375@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58c2d0: [WebGPU] https://webgpu.github.io/webgpu-samples/s...

2023-10-16 Thread mwyrzykowski

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58c2d0c5960b0d40f635a936625eb8f6b2abc687
  
https://github.com/WebKit/WebKit/commit/58c2d0c5960b0d40f635a936625eb8f6b2abc687
  Author: Mike Wyrzykowski 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  ---
  [WebGPU] https://webgpu.github.io/webgpu-samples/samples/renderBundles does 
not load on AMD or Intel
https://bugs.webkit.org/show_bug.cgi?id=263062


Reviewed by Dan Glastonbury.

Need to call useResource: on the index buffer for it to be available
when executing the ICB commands.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setIndexBuffer):

Canonical link: https://commits.webkit.org/269374@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 915522: Add syscall required by ASAN builds

2023-10-16 Thread Per Arne Vollan

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9155229feaffaa52490a43712ec9d880566f07cc
  
https://github.com/WebKit/WebKit/commit/9155229feaffaa52490a43712ec9d880566f07cc
  Author: Per Arne Vollan 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Add syscall required by ASAN builds
https://bugs.webkit.org/show_bug.cgi?id=263202
rdar://117027010

Reviewed by Chris Dumez.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/269373@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75b882: Add cache for SVGPathElement "d" attribute parsing

2023-10-16 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75b882901e3326fc37804fbf00641700acc18df7
  
https://github.com/WebKit/WebKit/commit/75b882901e3326fc37804fbf00641700acc18df7
  Author: Chris Dumez 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/page/MemoryRelease.cpp
M Source/WebCore/svg/SVGPathByteStream.h
M Source/WebCore/svg/SVGPathElement.cpp
M Source/WebCore/svg/SVGPathElement.h
M Source/WebCore/svg/SVGPathSegList.h

  Log Message:
  ---
  Add cache for SVGPathElement "d" attribute parsing
https://bugs.webkit.org/show_bug.cgi?id=263195
rdar://110970184

Reviewed by Ryosuke Niwa.

Add cache for SVGPathElement "d" attribute parsing to avoid spending CPU time
re-parsing the same "d" attribute values.

* Source/WebCore/page/MemoryRelease.cpp:
(WebCore::releaseNoncriticalMemory):
* Source/WebCore/svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::setData):
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::pathSegListCache):
(WebCore::SVGPathElement::attributeChanged):
(WebCore::SVGPathElement::clearCache):
* Source/WebCore/svg/SVGPathElement.h:
* Source/WebCore/svg/SVGPathSegList.h:

Canonical link: https://commits.webkit.org/269372@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 722fe4: Fix build failures when importing WebKit, when `-D...

2023-10-16 Thread Wenson Hsieh

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 722fe4fc50a4935023c450c325f8db75bdcc24a7
  
https://github.com/WebKit/WebKit/commit/722fe4fc50a4935023c450c325f8db75bdcc24a7
  Author: Wenson Hsieh 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h

  Log Message:
  ---
  Fix build failures when importing WebKit, when `-DOS_OBJECT_USE_OBJC=0` is set
https://bugs.webkit.org/show_bug.cgi?id=263156
rdar://114438852

Reviewed by Richard Robinson.

Before iOS 17 / macOS Sonoma, it was possible to pull in WebKit headers 
(directly, or through Swift
modules) when compiling without ObjC-backed OS objects, by specifying 
`-DOS_OBJECT_USE_OBJC=0` as a
build setting. Some popular libraries and plugins such as the 
`flutter_inappwebview` plugin (see
also: ) 
use this.

However, after we introduced the following public API in iOS 17:

```
@property (nullable, nonatomic, copy) NSArray 
*proxyConfigurations;
```

...this became impossible, since `nw_proxy_config_t` would be type-defined to 
an opaque struct
pointer in `Network.framework`, which is invalid as a type template argument in 
an `NSArray`. To fix
this, we adopt the same technique used in `Network/NSURLSession+Network.h` and 
simply expose a
generically-typed `NSArray` in the case where `OS_OBJECT_USE_OBJC` is off.

* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Canonical link: https://commits.webkit.org/269371@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ed184: uievents/mouse/mousemove_prevent_default_action.te...

2023-10-16 Thread Abrar Rahman Protyasha

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ed18444c723b19ca7ad1608aae93ca245a38296
  
https://github.com/WebKit/WebKit/commit/4ed18444c723b19ca7ad1608aae93ca245a38296
  Author: Abrar Rahman Protyasha 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
A 
LayoutTests/fast/text/canceled-mousemove-does-not-prevent-selectionchange-expected.txt
A 
LayoutTests/fast/text/canceled-mousemove-does-not-prevent-selectionchange.html
R LayoutTests/fast/text/selection-is-prevent-defaulted-expected.txt
R LayoutTests/fast/text/selection-is-prevent-defaulted.html
M 
LayoutTests/imported/w3c/web-platform-tests/uievents/mouse/mousemove_prevent_default_action.tentative-expected.txt
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h

  Log Message:
  ---
  uievents/mouse/mousemove_prevent_default_action.tentative.html WPT is failing
https://bugs.webkit.org/show_bug.cgi?id=262878
rdar://116668701

Reviewed by Aditya Keerthi.

We failed uievents/mouse/mousemove_prevent_default_action.tentative.html
WPT because we were preventing selectionchange or dragstart from
happening on a cancelled mousemove event.

However, mousemove has no default action according to the UI Events spec:
http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove. This
means that preventing the default action on mousemove should not prevent
selection/drag from happening.

To reflect this behavior change, we update the
CapturesDragging::InabilityReason enumeration with a new case --
MouseMoveIsCancelled. We consult m_capturesDragging for this failure
mode in EventHandler::handleMouseMoveEvent before passing a mousemove
event to EventHandler::handleMouseDraggedEvent, which is then
responsible for selection changes and drag operations.

* 
LayoutTests/fast/text/canceled-mousemove-does-not-prevent-selectionchange-expected.txt:
 Added.
* 
LayoutTests/fast/text/canceled-mousemove-does-not-prevent-selectionchange.html: 
Added.
* LayoutTests/fast/text/selection-is-prevent-defaulted-expected.txt: Removed.
* LayoutTests/fast/text/selection-is-prevent-defaulted.html: Removed.

Rename the layout test and make it more amenable to the fact that
selections happen in both cases now, then update expectations to reflect
our behavior change.

* 
LayoutTests/imported/w3c/web-platform-tests/uievents/mouse/mousemove_prevent_default_action.tentative-expected.txt:

Update our test expectations since we now pass the WPT partially.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchMouseEvent):
* Source/WebCore/page/EventHandler.h:

Canonical link: https://commits.webkit.org/269370@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1cfcb9: Adopt more smart pointers in dom/

2023-10-16 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cfcb963f8af7d7055a155939486947e5bfc2ce4
  
https://github.com/WebKit/WebKit/commit/1cfcb963f8af7d7055a155939486947e5bfc2ce4
  Author: Chris Dumez 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/dom/AbortController.cpp
M Source/WebCore/dom/AbortController.h
M Source/WebCore/dom/AbortSignal.cpp
M Source/WebCore/dom/ActiveDOMCallback.cpp
M Source/WebCore/dom/ActiveDOMObject.cpp
M Source/WebCore/dom/Attr.cpp
M Source/WebCore/dom/BoundaryPoint.cpp
M Source/WebCore/dom/BroadcastChannel.cpp
M Source/WebCore/dom/BroadcastChannel.h
M Source/WebCore/dom/CDATASection.cpp
M Source/WebCore/dom/CharacterData.cpp
M Source/WebCore/dom/ChildListMutationScope.cpp
M Source/WebCore/dom/ChildListMutationScope.h
M Source/WebCore/dom/ChildNodeList.cpp
M Source/WebCore/dom/ClassCollection.cpp
M Source/WebCore/dom/ConstantPropertyMap.cpp
M Source/WebCore/dom/ConstantPropertyMap.h
M Source/WebCore/dom/ContainerNode.cpp
M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/page/Page.h

  Log Message:
  ---
  Adopt more smart pointers in dom/
https://bugs.webkit.org/show_bug.cgi?id=263163

Reviewed by Darin Adler.

* Source/WebCore/dom/AbortController.cpp:
(WebCore::AbortController::abort):
(WebCore::AbortController::protectedSignal const):
* Source/WebCore/dom/AbortController.h:
* Source/WebCore/dom/AbortSignal.cpp:
(WebCore::AbortSignal::addSourceSignal):
(WebCore::AbortSignal::signalAbort):
(WebCore::AbortSignal::signalFollow):
* Source/WebCore/dom/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::canInvokeCallback const):
(WebCore::ActiveDOMCallback::activeDOMObjectsAreSuspended const):
(WebCore::ActiveDOMCallback::activeDOMObjectAreStopped const):
* Source/WebCore/dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
(WebCore::ActiveDOMObject::queueTaskInEventLoop):
(WebCore::ActiveDOMObject::queueTaskToDispatchEventInternal):
(WebCore::ActiveDOMObject::queueCancellableTaskToDispatchEventInternal):
* Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::~Attr):
(WebCore::Attr::style):
(WebCore::Attr::detachFromElementWithValue):
* Source/WebCore/dom/BoundaryPoint.cpp:
(WebCore::makeBoundaryPointBeforeNode):
(WebCore::makeBoundaryPointAfterNode):
(WebCore::treeOrder):
* Source/WebCore/dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::MainThreadBridge::ensureOnMainThread):
(WebCore::BroadcastChannel::BroadcastChannel):
(WebCore::BroadcastChannel::protectedMainThreadBridge const):
(WebCore::BroadcastChannel::postMessage):
(WebCore::BroadcastChannel::close):
(WebCore::BroadcastChannel::isEligibleForMessaging const):
* Source/WebCore/dom/BroadcastChannel.h:
* Source/WebCore/dom/CDATASection.cpp:
(WebCore::CDATASection::virtualCreate):
* Source/WebCore/dom/CharacterData.cpp:
(WebCore::CharacterData::~CharacterData):
(WebCore::canUseSetDataOptimization):
(WebCore::CharacterData::setData):
(WebCore::makeChildChange):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::notifyParentAfterChange):
(WebCore::CharacterData::dispatchModifiedEvent):
* Source/WebCore/dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::ChildListMutationAccumulator::protectedTarget const):
* Source/WebCore/dom/ChildListMutationScope.h:
* Source/WebCore/dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::~ChildNodeList):
* Source/WebCore/dom/ClassCollection.cpp:
(WebCore::ClassCollection::~ClassCollection):
* Source/WebCore/dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::protectedDocument const):
(WebCore::ConstantPropertyMap::updateConstantsForSafeAreaInsets):
(WebCore::ConstantPropertyMap::didChangeSafeAreaInsets):
(WebCore::ConstantPropertyMap::updateConstantsForFullscreen):
(WebCore::ConstantPropertyMap::didChangeFullscreenInsets):
(WebCore::ConstantPropertyMap::setFullscreenAutoHideDuration):
* Source/WebCore/dom/ConstantPropertyMap.h:
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::ContainerNode::removeNodeWithScriptAssertion):
(WebCore::ContainerNode::removeDetachedChildren):
(WebCore::isChildTypeAllowed):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::replaceAll):
(WebCore::ContainerNode::rebuildSVGExtensionsElementsIfNecessary):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChildWithoutPreInsertionValidityCheck):
(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::cloneChildNodes):
(WebCore::dispatchChildInsertionEvents):

[webkit-changes] [WebKit/WebKit] be79c2: [webkitbugspy] Use session for bugzilla requests

2023-10-16 Thread Jonathan Bedard

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be79c2ae75d406ec81b8f295b4286e8fce4c95e0
  
https://github.com/WebKit/WebKit/commit/be79c2ae75d406ec81b8f295b4286e8fce4c95e0
  Author: Jonathan Bedard 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/setup.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py
M Tools/Scripts/libraries/webkitscmpy/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py

  Log Message:
  ---
  [webkitbugspy] Use session for bugzilla requests
https://bugs.webkit.org/show_bug.cgi?id=263133
rdar://116933160

Rubber-stamped by Aakash Jain.

Use requests.Session for requests to bugzilla and pass timeout
to request calls.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.__init__): Set a default timeout of 30 seconds.
(Tracker.user): Use session, pass timeout value.
(Tracker.credentials.validater): Ditto.
(Tracker.populate): Ditto.
(Tracker.set): Ditto.
(Tracker.add_comment): Ditto.
(Tracker.projects): Ditto.
(Tracker.cc_radar): Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py:
(Tracker.__init__): Add timeout (none by default).
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(TestLand.test_canonicalize_with_bugzilla): Construct Bugzilla tracker after
instantiating Bugzilla mock.
(TestLand.test_svn_with_bugzilla): Ditto.

Canonical link: https://commits.webkit.org/269368@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6fcc2f: Revert 269302@main

2023-10-16 Thread Alex Christensen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6fcc2ff3d1b01a3b420ad3d8abe588447f212a4e
  
https://github.com/WebKit/WebKit/commit/6fcc2ff3d1b01a3b420ad3d8abe588447f212a4e
  Author: Alex Christensen 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/socket_address.h
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/Shared/RTCNetwork.cpp
M Source/WebKit/Shared/RTCNetwork.h
R Source/WebKit/Shared/RTCNetwork.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp

  Log Message:
  ---
  Revert 269302@main
https://bugs.webkit.org/show_bug.cgi?id=263200
rdar://117024566

Unreviewed.

It regressed the test webrtc/vp8-then-h264.html

* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/socket_address.h:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::NetworkManagerWrapper::onNetworksChanged):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::sendToSocket):
* Source/WebKit/Shared/RTCNetwork.cpp:
(WebKit::RTCNetwork::RTCNetwork):
(WebKit::ips):
(WebKit::RTCNetwork::value const):
(WebKit::RTCNetwork::IPAddress::decode):
(WebKit::RTCNetwork::IPAddress::encode const):
(WebKit::RTCNetwork::SocketAddress::decode):
(WebKit::RTCNetwork::SocketAddress::encode const):
(WebKit::RTCNetwork::decode):
(WebKit::RTCNetwork::encode const):
(WebKit::RTC::Network::IPAddress::IPAddress): Deleted.
(WebKit::RTC::Network::IPAddress::rtcAddress const): Deleted.
(WebKit::RTC::Network::SocketAddress::SocketAddress): Deleted.
(WebKit::RTC::Network::SocketAddress::rtcAddress const): Deleted.
(WebKit::RTC::Network::InterfaceAddress::InterfaceAddress): Deleted.
(WebKit::RTC::Network::InterfaceAddress::rtcAddress const): Deleted.
* Source/WebKit/Shared/RTCNetwork.h:
(WebKit::RTCNetwork::IPAddress::IPAddress):
(WebKit::RTCNetwork::SocketAddress::SocketAddress):
(WebKit::RTC::Network::IPAddress::UnspecifiedFamily::operator== const): Deleted.
(WebKit::RTC::Network::IPAddress::IPAddress): Deleted.
(WebKit::RTC::Network::InterfaceAddress::InterfaceAddress): Deleted.
* Source/WebKit/Shared/RTCNetwork.serialization.in: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:
(WebKit::LibWebRTCNetwork::signalAddressReady):
(WebKit::LibWebRTCNetwork::signalReadPacket):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::networksChanged):
* Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp:
(WebKit::WebRTCResolver::setResolvedAddress):

Canonical link: https://commits.webkit.org/269367@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0172e5: REGRESSION(267849@main): MESSAGE_CHECK() failure w...

2023-10-16 Thread Charlie Wolfe

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0172e5a8bf88fbaed136e070c6709cba6dc93ff5
  
https://github.com/WebKit/WebKit/commit/0172e5a8bf88fbaed136e070c6709cba6dc93ff5
  Author: Charlie Wolfe 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

  Log Message:
  ---
  REGRESSION(267849@main): MESSAGE_CHECK() failure when mouse events are being 
handled during a process swap
https://bugs.webkit.org/show_bug.cgi?id=263175
rdar://116942710

Reviewed by Wenson Hsieh.

On a process swap, events queued in the UI process will be cleared. This was 
needed before 267849@main,
because the `didReceiveEvent()` IPC messages would not be sent to dequeue the 
events after terminating
the source web process. After 267849@main, it’s possible for the completion 
handler to be called after
clearing the event queues. So the message checks in `didReceiveEvent()` 
expecting the event queues to
not be empty will fail. We can expect the completion handler to be called for 
crashed web processes, so
we shouldn’t need to clear the event queues on process termination anymore.

We should also send the next queued mouse/touch/key events even after the web 
process crashes.

Added `ProcessSwap.MouseEventDuringCrossSiteProvisionalNavigation` to verify 
the web process no longer
crashes when a mouse event is being handled during a cross-site provisional 
navigation.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendMouseEvent):
(WebKit::WebPageProxy::sendKeyEvent):
(WebKit::WebPageProxy::touchEventHandlingCompleted):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::mouseEventHandlingCompleted):
(WebKit::WebPageProxy::keyEventHandlingCompleted):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Canonical link: https://commits.webkit.org/269366@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 99b965: [WPE][GTK] Gardening `fast/multicol` after 268264@...

2023-10-16 Thread Vitaly Dyachkov

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99b96579f9d3d5f15c1b53aac9801db9314939e7
  
https://github.com/WebKit/WebKit/commit/99b96579f9d3d5f15c1b53aac9801db9314939e7
  Author: Vitaly Dyachkov 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M 
LayoutTests/platform/glib/fast/multicol/block-axis-horizontal-bt-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/block-axis-vertical-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/client-rects-spanners-complex-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/BottomToTop-bt-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/BottomToTop-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/LeftToRight-bt-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/LeftToRight-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/RightToLeft-bt-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/RightToLeft-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/TopToBottom-bt-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/pagination/TopToBottom-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/tall-image-behavior-lr-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/tall-image-behavior-lr-mixed-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/tall-image-behavior-rl-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/border-padding-pagination-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/column-count-with-rules-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/column-rules-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-avoidance-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-multicol-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-paginate-complex-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-paginate-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/nested-columns-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt
M 
LayoutTests/platform/glib/fast/multicol/vertical-rl/float-multicol-expected.txt

  Log Message:
  ---
  [WPE][GTK] Gardening `fast/multicol` after 268264@main

Unreviewed test gardening.

* LayoutTests/platform/glib/fast/multicol/block-axis-horizontal-bt-expected.txt:
* LayoutTests/platform/glib/fast/multicol/block-axis-vertical-lr-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/client-rects-spanners-complex-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/BottomToTop-bt-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/BottomToTop-lr-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/LeftToRight-bt-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/LeftToRight-lr-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/RightToLeft-bt-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/RightToLeft-lr-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/TopToBottom-bt-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/pagination/TopToBottom-lr-expected.txt:
* LayoutTests/platform/glib/fast/multicol/tall-image-behavior-lr-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/tall-image-behavior-lr-mixed-expected.txt:
* LayoutTests/platform/glib/fast/multicol/tall-image-behavior-rl-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/border-padding-pagination-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* LayoutTests/platform/glib/fast/multicol/vertical-lr/column-rules-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-multicol-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/float-paginate-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/nested-columns-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
* 
LayoutTests/platform/glib/fast/multicol/vertical-rl/float-multicol-expected.txt:

Canonical link: https://commits.webkit.org/269365@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efdde1: Re-sync the top directory files of web-platform-te...

2023-10-16 Thread Fujii Hironori

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efdde118860a9787675616975b099a4d87b53487
  
https://github.com/WebKit/WebKit/commit/efdde118860a9787675616975b099a4d87b53487
  Author: Fujii Hironori 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/.gitattributes
M LayoutTests/imported/w3c/web-platform-tests/.gitignore
M LayoutTests/imported/w3c/web-platform-tests/CODEOWNERS
A LayoutTests/imported/w3c/web-platform-tests/CODE_OF_CONDUCT.md
M LayoutTests/imported/w3c/web-platform-tests/CONTRIBUTING.md
R LayoutTests/imported/w3c/web-platform-tests/LICENSE
M LayoutTests/imported/w3c/web-platform-tests/LICENSE.md
R LayoutTests/imported/w3c/web-platform-tests/__init__.py
R LayoutTests/imported/w3c/web-platform-tests/check_stability.ini
R LayoutTests/imported/w3c/web-platform-tests/config.default.json
R LayoutTests/imported/w3c/web-platform-tests/diff-manifest.py
A LayoutTests/imported/w3c/web-platform-tests/lint.ignore
R LayoutTests/imported/w3c/web-platform-tests/lint.whitelist
R LayoutTests/imported/w3c/web-platform-tests/serve.py
R LayoutTests/imported/w3c/web-platform-tests/server-side.md
R LayoutTests/imported/w3c/web-platform-tests/test_keys_wdspec.html
R LayoutTests/imported/w3c/web-platform-tests/update-built-tests.sh

  Log Message:
  ---
  Re-sync the top directory files of web-platform-tests to d20c3cdbf6e91f14dda9
https://bugs.webkit.org/show_bug.cgi?id=263173

Reviewed by Tim Nguyen.

WPT hash for this import: d20c3cdbf6e91f14dda92737e453621617b8de74
This revision is the last tools directory sync by 259138@main.

* LayoutTests/imported/w3c/web-platform-tests/.gitattributes: Added.
* LayoutTests/imported/w3c/web-platform-tests/.gitignore:
* LayoutTests/imported/w3c/web-platform-tests/CODEOWNERS:
* LayoutTests/imported/w3c/web-platform-tests/CODE_OF_CONDUCT.md: Added.
* LayoutTests/imported/w3c/web-platform-tests/CONTRIBUTING.md:
* LayoutTests/imported/w3c/web-platform-tests/LICENSE: Removed.
* LayoutTests/imported/w3c/web-platform-tests/LICENSE.md:
* LayoutTests/imported/w3c/web-platform-tests/__init__.py: Removed.
* LayoutTests/imported/w3c/web-platform-tests/check_stability.ini: Removed.
* LayoutTests/imported/w3c/web-platform-tests/config.default.json: Removed.
* LayoutTests/imported/w3c/web-platform-tests/diff-manifest.py: Removed.
* LayoutTests/imported/w3c/web-platform-tests/lint.ignore: Added.
* LayoutTests/imported/w3c/web-platform-tests/lint.whitelist: Removed.
* LayoutTests/imported/w3c/web-platform-tests/serve.py: Removed.
* LayoutTests/imported/w3c/web-platform-tests/server-side.md: Removed.
* LayoutTests/imported/w3c/web-platform-tests/test_keys_wdspec.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/update-built-tests.sh: Removed.

Canonical link: https://commits.webkit.org/269364@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3594b: [Gardening]: (REGRESSION (267943@main): [ Sonoma w...

2023-10-16 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3594b6d96ee633aab698feb0dbee023947af009
  
https://github.com/WebKit/WebKit/commit/e3594b6d96ee633aab698feb0dbee023947af009
  Author: Karl Rackler 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: (REGRESSION (267943@main): [ Sonoma wk2 ] 27 tests are a 
constant crash)
rdar://115746676

Unreviewed test gardening.

Remove test expectations.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269363@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f2560f: Build error when CSS_BOX_DECORATION_BREAK is disabled

2023-10-16 Thread Alan Baradlay

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2560fbccb1ae3596043885587bf9ee13392fb92
  
https://github.com/WebKit/WebKit/commit/f2560fbccb1ae3596043885587bf9ee13392fb92
  Author: Alan Baradlay 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  ---
  Build error when CSS_BOX_DECORATION_BREAK is disabled
https://bugs.webkit.org/show_bug.cgi?id=263193

Unreviewed.

* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::candidateContentForLine):

Canonical link: https://commits.webkit.org/269362@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 865133: Make all senstitive $vm properties not enumerable ...

2023-10-16 Thread Commit Queue

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86513355ed9fd7714834054a3112b92206344cac
  
https://github.com/WebKit/WebKit/commit/86513355ed9fd7714834054a3112b92206344cac
  Author: Mark Lam 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/tools/JSDollarVM.cpp
M Source/JavaScriptCore/tools/JSDollarVM.h

  Log Message:
  ---
  Make all senstitive $vm properties not enumerable by 
Object.getOwnPropertyNames.
https://bugs.webkit.org/show_bug.cgi?id=263187
rdar://112814894

Reviewed by Keith Miller and Justin Michaud.

$vm functions are not meant to be enumerable.  That's why all of them have the 
DontEnum attribute.
However, Object.getOwnPropertyNames does not honor this by default.  As a 
result, this can trip up
fuzzers that happens to enumerate it with Object.getOwnPropertyNames.

The fix is to make JSDollarVM OverridesGetOwnPropertyNames, and have its 
getOwnPropertyNames
method always exclude DontEnum properties as expected.

* Source/JavaScriptCore/tools/JSDollarVM.cpp:
(JSC::JSDollarVM::getOwnPropertyNames):
* Source/JavaScriptCore/tools/JSDollarVM.h:

Canonical link: https://commits.webkit.org/269361@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7df9f6: [LBSE] Incorrect clipping for non-opaque, outermos...

2023-10-16 Thread Nikolas Zimmermann

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7df9f6186a3b0f0341ef887829fc8b1f33dbdda2
  
https://github.com/WebKit/WebKit/commit/7df9f6186a3b0f0341ef887829fc8b1f33dbdda2
  Author: Nikolas Zimmermann 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac-ventura-wk2-lbse-text/TestExpectations
R 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/W3C-SVG-1.1/render-groups-01-b-expected.png
M 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/as-background-image/svg-as-background-6-expected.png
R 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/batik/text/textAnchor-expected.png
R 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/container-opacity-clip-viewBox-expected.png
R 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/js-update-bounce-expected.png
R 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/svg/RenderSVGRoot.cpp
M Source/WebCore/rendering/svg/RenderSVGRoot.h

  Log Message:
  ---
  [LBSE] Incorrect clipping for non-opaque, outermost  elements
https://bugs.webkit.org/show_bug.cgi?id=262843

Reviewed by Rob Buis.

RenderLayer::beginTransparencyLayers() pixel snaps the clip rect before
clipping, which shouldn't be done for SVG elements. Other places already
use 'snapRectToDevicePixelsIfNeeded()', this one was still using
'snapRectToDevicePixels()' unconditionally.

Removes the need for a bunch of LBSE specific pixel test results (where the
tests pass, except for opacity clipping related glitches that are now fixed).

Covered by existing tests.

* LayoutTests/platform/mac-ventura-wk2-lbse-text/TestExpectations:
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/as-background-image/svg-as-background-6-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/batik/text/textAnchor-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/container-opacity-clip-viewBox-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/js-update-bounce-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk2-pixel/svg/as-background-image/svg-as-background-6-expected.png:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers): Only pixel snap the clip rect, 
if needed.
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRect const): Deleted. No longer needed, 
use the RenderReplaced variant.
* Source/WebCore/rendering/svg/RenderSVGRoot.h:

Canonical link: https://commits.webkit.org/269360@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3726aa: Unreviewed, reverting 269298@main.

2023-10-16 Thread Commit Queue

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3726aaa8c75fd7cd06d1e0932c4bfca2d07452c9
  
https://github.com/WebKit/WebKit/commit/3726aaa8c75fd7cd06d1e0932c4bfca2d07452c9
  Author: Commit Queue 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Tools/Scripts/webkitdirs.pm

  Log Message:
  ---
  Unreviewed, reverting 269298@main.
https://bugs.webkit.org/show_bug.cgi?id=263189

It broke `run-minibrowser`

Reverted changeset:

"[WPE][GTK] Add port name to build dir path"
https://bugs.webkit.org/show_bug.cgi?id=263117
https://commits.webkit.org/269298@main

Canonical link: https://commits.webkit.org/269359@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a62a6: [MSE][GStreamer] Simplify handling of running time...

2023-10-16 Thread Alicia Boya García

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a62a65095faf477ebaeb47b9d236b92a4d910d1
  
https://github.com/WebKit/WebKit/commit/8a62a65095faf477ebaeb47b9d236b92a4d910d1
  Author: Alicia Boya Garcia 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

  Log Message:
  ---
  [MSE][GStreamer] Simplify handling of running time for non-resetting flushes
https://bugs.webkit.org/show_bug.cgi?id=263126

Reviewed by Philippe Normand.

The computation of `base` and `start` for the GstSegment in
webKitMediaSrcStreamFlush() is superfluous, as the same running time
values can be obtained by preserving the original segment.

* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcStreamFlush):

Canonical link: https://commits.webkit.org/269358@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b928c: Update ANGLE to 2023-10-14 (cd6b265c262346dca0c236...

2023-10-16 Thread Kimmo Kinnunen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b928ce58d577d94a25fe6fba82be98a7638f3fb
  
https://github.com/WebKit/WebKit/commit/3b928ce58d577d94a25fe6fba82be98a7638f3fb
  Author: Kimmo Kinnunen 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/ThirdParty/ANGLE/.gitmodules
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/gn_isolate_map.pyl
M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_internal_shader_programs.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py
M Source/ThirdParty/ANGLE/src/common/FixedQueue.h
M Source/ThirdParty/ANGLE/src/common/FixedQueue_unittest.cpp
M Source/ThirdParty/ANGLE/src/common/utilities.h
M Source/ThirdParty/ANGLE/src/image_util/loadimage.h
M Source/ThirdParty/ANGLE/src/image_util/loadimage_etc.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Texture.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/TextureGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CommandProcessor.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CommandProcessor.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ContextVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ContextVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/DeviceVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FenceNVVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RenderTargetVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ResourceVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ResourceVk.h
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SecondaryCommandPool.cpp
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SecondaryCommandPool.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/Suballocation.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/Suballocation.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SyncVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SyncVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/UtilsVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/UtilsVk.h
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/gen_vk_internal_shaders.py
A 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/Blit3DSrc.frag..inc
A 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/Blit3DSrc.frag.0001.inc
A 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/Blit3DSrc.frag.0002.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag..inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0001.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0002.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0003.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0004.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0005.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0006.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0007.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0008.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.0009.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.000A.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.000B.inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolve.frag.000C.inc
M

[webkit-changes] [WebKit/WebKit] fcf3a6: [GStreamer][DMABuf] Allow negotiation with decoder...

2023-10-16 Thread Philippe Normand

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcf3a66b27a8ee289b8366b7fa13689d2acf6394
  
https://github.com/WebKit/WebKit/commit/fcf3a66b27a8ee289b8366b7fa13689d2acf6394
  Author: Philippe Normand 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp

  Log Message:
  ---
  [GStreamer][DMABuf] Allow negotiation with decoders without drm-format
https://bugs.webkit.org/show_bug.cgi?id=263079

Reviewed by Xabier Rodriguez-Calvar.

The TextureMapper is capable to generating DMABufs and guess related format 
fourcc when the decoder
hasn't explicitely supplied those infos in the caps, so there is no reason for 
our sink to restrict
its caps to a specific set of DRM formats.

This should allow decoders not yet ported to the new DRM caps format to still 
be used in combination
with our DMABuf sink.

* Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webKitDMABufVideoSinkConstructed):

Canonical link: https://commits.webkit.org/269356@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] abb444: [WinCairo] Unreviewed test gardening

2023-10-16 Thread Fujii Hironori

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abb444cf09b6e934ceac492efad87bf5e328479d
  
https://github.com/WebKit/WebKit/commit/abb444cf09b6e934ceac492efad87bf5e328479d
  Author: Fujii Hironori 
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/269355@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

43 matches

Mail list logo