[webkit-changes] [WebKit/WebKit] 00d4a6: [WebGPU] Correct webgpu:api, operation, labels:* tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00d4a6ebe7fa29c762e38cb0a0e87f63b26fc5a7 https://github.com/WebKit/WebKit/commit/00d4a6ebe7fa29c762e38cb0a0e87f63b26fc5a7 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp Log Message: --- [WebGPU] Correct webgpu:api,operation,labels:* test failures https://bugs.webkit.org/show_bug.cgi?id=263566 Reviewed by Dan Glastonbury. setLabel was not called on the proxy object, so that object contained an empty label. * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp: (WebKit::WebGPU::RemoteAdapterProxy::requestDevice): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp: (WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass): (WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::createBuffer): (WebKit::WebGPU::RemoteDeviceProxy::createTexture): (WebKit::WebGPU::RemoteDeviceProxy::createSampler): (WebKit::WebGPU::RemoteDeviceProxy::importExternalTexture): (WebKit::WebGPU::RemoteDeviceProxy::createBindGroupLayout): (WebKit::WebGPU::RemoteDeviceProxy::createPipelineLayout): (WebKit::WebGPU::RemoteDeviceProxy::createBindGroup): (WebKit::WebGPU::RemoteDeviceProxy::createShaderModule): (WebKit::WebGPU::RemoteDeviceProxy::createComputePipeline): (WebKit::WebGPU::RemoteDeviceProxy::createRenderPipeline): (WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync): (WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync): (WebKit::WebGPU::RemoteDeviceProxy::createCommandEncoder): (WebKit::WebGPU::RemoteDeviceProxy::createRenderBundleEncoder): (WebKit::WebGPU::RemoteDeviceProxy::createQuerySet): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp: (WebKit::WebGPU::RemoteTextureProxy::createView): Canonical link: https://commits.webkit.org/269701@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fb3ee: Use a smart pointer for ScrollingStateNode::m_scro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fb3ee87cbca7883ad7a57dd95a4a406bdb44ad1 https://github.com/WebKit/WebKit/commit/3fb3ee87cbca7883ad7a57dd95a4a406bdb44ad1 Author: Alex Christensen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateTree.h Log Message: --- Use a smart pointer for ScrollingStateNode::m_scrollingStateTree https://bugs.webkit.org/show_bug.cgi?id=263544 rdar://117366444 Reviewed by Chris Dumez. It only points to the tree that owns it, except during deserialization. Let's make it safer. * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateTree.h: Canonical link: https://commits.webkit.org/269700@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 436992: Generate serialization of WebCore::ScrollingStateTree
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 436992c4ce4856215fba08285c950dd07794e599 https://github.com/WebKit/WebKit/commit/436992c4ce4856215fba08285c950dd07794e599 Author: Alex Christensen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingStateTree.cpp M Source/WebCore/page/scrolling/ScrollingStateTree.h M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in Log Message: --- Generate serialization of WebCore::ScrollingStateTree https://bugs.webkit.org/show_bug.cgi?id=263543 rdar://117366227 Reviewed by Brady Eidson. Move logic around a little, but no change in behavior * Source/WebCore/page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::createAfterReconstruction): (WebCore::ScrollingStateTree::ScrollingStateTree): (WebCore::ScrollingStateTree::attachDeserializedNodes): (WebCore::ScrollingStateTree::setRootStateNodeAfterReconstruction): Deleted. * Source/WebCore/page/scrolling/ScrollingStateTree.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder::encode): Deleted. (ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in: Canonical link: https://commits.webkit.org/269699@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3983b: Set CSSHighlights to stable since they are enabled...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3983bcf62a26c7d1f49f5f7f0156945a144fbb4 https://github.com/WebKit/WebKit/commit/a3983bcf62a26c7d1f49f5f7f0156945a144fbb4 Author: Megan Gardner Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Set CSSHighlights to stable since they are enabled by default. https://bugs.webkit.org/show_bug.cgi?id=263562 rdar://117377518 Reviewed by Tim Nguyen. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/269698@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9405d3: Use a CheckedRef for SQLiteTransaction::m_db
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9405d3e158f78bd8ac3f2ad1749dfea70623fb8d https://github.com/WebKit/WebKit/commit/9405d3e158f78bd8ac3f2ad1749dfea70623fb8d Author: Charlie Wolfe Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp M Source/WebCore/platform/sql/SQLiteDatabase.h M Source/WebCore/platform/sql/SQLiteTransaction.cpp M Source/WebCore/platform/sql/SQLiteTransaction.h Log Message: --- Use a CheckedRef for SQLiteTransaction::m_db https://bugs.webkit.org/show_bug.cgi?id=263539 rdar://117364281 Reviewed by Sihui Liu and Chris Dumez. Also remove `CanMakeWeakPtr` since it's not used. * Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp: (WebCore::IDBServer::SQLiteIDBCursor::createSQLiteStatement): (WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindPreIndexStatementIfNecessary): (WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord): * Source/WebCore/platform/sql/SQLiteDatabase.h: * Source/WebCore/platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin): (WebCore::SQLiteTransaction::commit): (WebCore::SQLiteTransaction::rollback): (WebCore::SQLiteTransaction::stop): (WebCore::SQLiteTransaction::wasRolledBackBySqlite const): * Source/WebCore/platform/sql/SQLiteTransaction.h: (WebCore::SQLiteTransaction::database const): Canonical link: https://commits.webkit.org/269697@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 214900: [WGSL] Implement constant functions for all operat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2149009b609785bf41a35548d4ab6157337e30cd https://github.com/WebKit/WebKit/commit/2149009b609785bf41a35548d4ab6157337e30cd Author: Tadeu Zagallo Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WGSL/ConstantFunctions.h M Source/WebGPU/WGSL/ConstantValue.h M Source/WebGPU/WGSL/TypeDeclarations.rb Log Message: --- [WGSL] Implement constant functions for all operators and constructors https://bugs.webkit.org/show_bug.cgi?id=263553 rdar://117370549 Reviewed by Mike Wyrzykowski. Start batch-implmenting the constant functions for all type declarations. This starts by implementing all unary and binary operators, plus all the type constructors. * Source/WebGPU/WGSL/ConstantValue.h: (WGSL::ConstantValue::isBool const): Canonical link: https://commits.webkit.org/269696@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21a5d7: [Cocoa] Make WebContextMenuProxy::copySubjectResul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21a5d7f6e5b2c3d4fc502f6f1969461856260a43 https://github.com/WebKit/WebKit/commit/21a5d7f6e5b2c3d4fc502f6f1969461856260a43 Author: Wenson Hsieh Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebKit/UIProcess/WebContextMenuProxy.h M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm Log Message: --- [Cocoa] Make WebContextMenuProxy::copySubjectResult return a `RetainPtr` https://bugs.webkit.org/show_bug.cgi?id=263567 Reviewed by Tim Horton. Clarify the ownership model around this method by returning a `RetainPtr`, and additionally rename the method so that it doesn't read like it copies the result. * Source/WebKit/UIProcess/WebContextMenuProxy.h: (WebKit::WebContextMenuProxy::imageForCopySubject const): (WebKit::WebContextMenuProxy::copySubjectResult const): Deleted. * Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h: * Source/WebKit/UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::handleContextMenuCopySubject): Canonical link: https://commits.webkit.org/269695@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 728c25: Use more smart pointers in ProcessingInstruction &...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 728c25250643e662df8f4b9cfa268f62c11bc1b6 https://github.com/WebKit/WebKit/commit/728c25250643e662df8f4b9cfa268f62c11bc1b6 Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/CSSStyleSheet.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/ProcessingInstruction.cpp M Source/WebCore/dom/ProcessingInstruction.h M Source/WebCore/dom/PseudoElement.cpp M Source/WebCore/style/StyleScope.cpp M Source/WebCore/style/StyleScope.h Log Message: --- Use more smart pointers in ProcessingInstruction & PseudoElement https://bugs.webkit.org/show_bug.cgi?id=263537 Reviewed by Ryosuke Niwa. * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::protectedContents): * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::checkedStyleScope): (WebCore::Document::checkedStyleScope const): * Source/WebCore/dom/Document.h: (WebCore::Document::styleScope): (WebCore::Document::styleScope const): * Source/WebCore/dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): Drop some unnecessary code that was used to check if we got disconnected after firing the beforeload event (as you can see in https://commits.webkit.org/187003@main). We've stopped firing the beforeload event a while back but this code wasn't simplified. (WebCore::ProcessingInstruction::isLoading const): (WebCore::ProcessingInstruction::sheetLoaded): (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet): (WebCore::ProcessingInstruction::protectedSheet const): (WebCore::ProcessingInstruction::parseStyleSheet): (WebCore::ProcessingInstruction::insertedIntoAncestor): (WebCore::ProcessingInstruction::removedFromAncestor): * Source/WebCore/dom/ProcessingInstruction.h: * Source/WebCore/dom/PseudoElement.cpp: (WebCore::PseudoElement::create): (WebCore::PseudoElement::clearHostElement): * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::incrementPtrCount const): (WebCore::Style::Scope::decrementPtrCount const): (WebCore::Style::Scope::createDocumentResolver): (WebCore::Style::Scope::releaseMemory): (WebCore::Style::Scope::didRemovePendingStylesheet): (WebCore::Style::Scope::addStyleSheetCandidateNode): (WebCore::Style::Scope::collectActiveStyleSheets): (WebCore::Style::Scope::updateActiveStyleSheets): (WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange): (WebCore::Style::Scope::activeStyleSheetsForInspector): (WebCore::Style::Scope::flushPendingDescendantUpdates): (WebCore::Style::Scope::scheduleUpdate): (WebCore::Style::Scope::collectResolverScopes): (WebCore::Style::Scope::didChangeStyleSheetEnvironment): (WebCore::Style::Scope::didChangeViewportSize): (WebCore::Style::Scope::invalidateMatchedDeclarationsCache): (WebCore::Style::Scope::pendingUpdateTimerFired): (WebCore::Style::Scope::documentScope): (WebCore::Style::Scope::updateQueryContainerState): * Source/WebCore/style/StyleScope.h: Canonical link: https://commits.webkit.org/269694@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15b02a: [ANGLE] Clear pending program linking in Context::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15b02a1209b1a129490ed9e0b587aeed29ff1c68 https://github.com/WebKit/WebKit/commit/15b02a1209b1a129490ed9e0b587aeed29ff1c68 Author: Dan Glastonbury Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm Log Message: --- [ANGLE] Clear pending program linking in Context::onDestroy https://bugs.webkit.org/show_bug.cgi?id=263429 rdar://117242201 Reviewed by Kimmo Kinnunen. When destroying Context, ANGLE resets any internal state before releasing allocated objects, such as Programs and Shaders. When destroying a program, any pending program linking is resolved via Program::resolveLink. This results in trying to access the Context state that’s just been reset. To work around this, we ensure there are no pending links before resetting the Context state. * Source/ThirdParty/ANGLE/changes.diff: * Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp: (gl::Context::onDestroy): * Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/269693@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 271494: Stop using a raw pointer for Node::m_treeScope
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2714943f80da611b6d992d9aa457ba9c5c2f633a https://github.com/WebKit/WebKit/commit/2714943f80da611b6d992d9aa457ba9c5c2f633a Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WTF/wtf/Ref.h M Source/WTF/wtf/RefPtr.h M Source/WTF/wtf/TypeCasts.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h Log Message: --- Stop using a raw pointer for Node::m_treeScope https://bugs.webkit.org/show_bug.cgi?id=262239 rdar://116501041 Reviewed by Ryosuke Niwa. * Source/WTF/wtf/Ref.h: (WTF::checkedDowncast): * Source/WTF/wtf/RefPtr.h: (WTF::checkedDowncast): * Source/WTF/wtf/TypeCasts.h: (WTF::checkedDowncast): Introduce checkedDowncast<>(), which is similar to downcast<>() but the type check happens in release builds too for extra safety. * Source/WebCore/dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node): * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::incrementPtrCount const): (WebCore::TreeScope::decrementPtrCount const): * Source/WebCore/dom/TreeScope.h: Canonical link: https://commits.webkit.org/269692@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c57ce1: [Gardening]: REGRESSION(Sonoma/iOS17): [ wk2 debug...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c57ce1fb16ef9d92bdedfd00bdf2389e8171e1a7 https://github.com/WebKit/WebKit/commit/c57ce1fb16ef9d92bdedfd00bdf2389e8171e1a7 Author: Ben Schwartz Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(Sonoma/iOS17): [ wk2 debug ] fast/text/glyph-display-lists/glyph-display-list-colr-unshared.html is constantly failing. rdar://117386994 https://bugs.webkit.org/show_bug.cgi?id=263575 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269691@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29e5f2: [JSC] Add Array.from(Array) fast path
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29e5f281e3273d83748455fb6d3325e7722a8b31 https://github.com/WebKit/WebKit/commit/29e5f281e3273d83748455fb6d3325e7722a8b31 Author: Yusuke Suzuki Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: A JSTests/microbenchmarks/array-from-array.js M Source/JavaScriptCore/builtins/ArrayConstructor.js M Source/JavaScriptCore/builtins/BuiltinNames.h M Source/JavaScriptCore/bytecode/LinkTimeConstant.h M Source/JavaScriptCore/runtime/ArrayPrototype.cpp M Source/JavaScriptCore/runtime/ArrayPrototype.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp Log Message: --- [JSC] Add Array.from(Array) fast path https://bugs.webkit.org/show_bug.cgi?id=263490 rdar://117290480 Reviewed by Michael Saboff. This patch adds Array.from fast path for simple arrays without callbacks, like, `Array.from(array)`. This is because this pattern can be used for fast array cloning. The fast path is 8.14x faster than the Array.from generic path. We should take Array.from fast path when array iterator protocol allows. This ensures that we can iterate an array without creating an iterator. And it also ensures that our Array prototype chain is sane. So, we can skip many costly operations and directly copy data. array-from-array 2.6646+-0.0174 ^ 0.3271+-0.0155 ^ definitely 8.1469x faster * JSTests/microbenchmarks/array-from-array.js: Added. * Source/JavaScriptCore/builtins/ArrayConstructor.js: * Source/JavaScriptCore/builtins/BuiltinNames.h: * Source/JavaScriptCore/bytecode/LinkTimeConstant.h: * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/ArrayPrototype.h: * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Canonical link: https://commits.webkit.org/269690@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0b6e8: [MediaSource] canplay event does not fire for vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0b6e889f00ee859d4f9ed8f7119a3ed3f5ad7cf https://github.com/WebKit/WebKit/commit/d0b6e889f00ee859d4f9ed8f7119a3ed3f5ad7cf Author: Andy Estes Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-false-expected.txt A LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-false.html A LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-true-expected.txt A LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-true.html A LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-expected.txt A LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-without-renderer-expected.txt A LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-without-renderer.html A LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay.html A LayoutTests/media/media-source/resources/first-sample-pts-non-zero/LICENSE A LayoutTests/media/media-source/resources/first-sample-pts-non-zero/first-sample-pts-non-zero.mp4 M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm Log Message: --- [MediaSource] canplay event does not fire for video elements with renderers when first sample has a pts greater than 0 https://bugs.webkit.org/show_bug.cgi?id=263415 rdar://105169372 Reviewed by Jer Noble. Some MediaSource content adds a source buffer where the first decoded sample has a presentation start time that is slightly greater than 0. This exposes a bug in WebCoreDecompressionSession where the "canplay" event is never dispatched because a sample whose pts matches the playback synchronizer's current time is never decoded. This bug is tracked by webkit.org/b/263413. Instead of addressing the issue in WebCoreDecompressionSession, this commit addresses the reason why WebCoreDecompressionSession was being used to begin with for video elements with renderers. In 252183@main, MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer() was modified to return false when a video element's bounds were empty to address a failure in fast/canvas/webgl/texImage2D-mse-flipY-false.html, but this turned out to be overly restrictive. -[AVSampleBufferDisplayLayer copyDisplayedPixelBuffer] actually does work properly when its bounds are empty; it merely fails when the video element does not have a renderer. 266162@main later added a renderer check to MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer(), making the empty-bounds checks unnecessary. This commit removes the empty-bounds checks from MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer(), ensuring we use an AVSampleBufferDisplayLayer for decoding (which is not tripped up by the pts issue described above) in all situations where the video element has a renderer. Added tests to verify the following behaviors for video elements with renderers: - video-in-canvas rendering continues to work via AVSampleBufferDisplayLayer with zero-sized video elements - "canplay" event is dispatched for zero-sized video elements Also added a failing test for the issue tracked in webkit.org/b/263413 and marked it as such in TestExpectations. * LayoutTests/TestExpectations: * LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-false-expected.txt: Added. * LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-false.html: Added. * LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-true-expected.txt: Added. * LayoutTests/fast/canvas/webgl/texImage2D-mse-in-dom-flipY-true.html: Added. * LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-expected.txt: Added. * LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-without-renderer-expected.txt: Added. * LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay-without-renderer.html: Added. * LayoutTests/media/media-source/media-source-first-sample-pts-non-zero-canplay.html: Added. * LayoutTests/media/media-source/resources/first-sample-pts-non-zero/LICENSE: Added. * LayoutTests/media/media-source/resources/first-sample-pts-non-zero/first-sample-pts-non-zero.mp4: Added. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const): Canonical link: https://commits.webkit.org/269689@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21002e: REGRESSION(269643@main) AX: Summary elements are n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21002ed8c1d123439659759bd9fcb303e414d5d0 https://github.com/WebKit/WebKit/commit/21002ed8c1d123439659759bd9fcb303e414d5d0 Author: Tyler Wilcock Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/accessibility/mac/search-predicate-summary-expected.txt M LayoutTests/accessibility/mac/search-predicate-summary.html M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: --- REGRESSION(269643@main) AX: Summary elements are not expandable by macOS VoiceOver https://bugs.webkit.org/show_bug.cgi?id=263534 rdar://problem/117359988 Reviewed by Andres Gonzalez. Regression from: https://bugs.webkit.org/show_bug.cgi?id=263499 Claiming "supports press action" for summary elements is not correct, and actually regresses this functionality. This patch undoes that part of https://bugs.webkit.org/show_bug.cgi?id=263499, and adds testcases and documentation to prevent this mistake in the future. * LayoutTests/accessibility/mac/search-predicate-summary-expected.txt: * LayoutTests/accessibility/mac/search-predicate-summary.html: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsPressAction const): Canonical link: https://commits.webkit.org/269688@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b462c: [WebGPU] Update WebGPU CTS tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b462cda336c09650085307935438f1c3f8f1d0d https://github.com/WebKit/WebKit/commit/9b462cda336c09650085307935438f1c3f8f1d0d Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/http/tests/webgpu/common/framework/data_cache.js M LayoutTests/http/tests/webgpu/common/framework/fixture.js A LayoutTests/http/tests/webgpu/common/framework/metadata.js M LayoutTests/http/tests/webgpu/common/framework/params_builder.js M LayoutTests/http/tests/webgpu/common/framework/resources.js M LayoutTests/http/tests/webgpu/common/framework/test_config.js M LayoutTests/http/tests/webgpu/common/framework/test_group.js M LayoutTests/http/tests/webgpu/common/internal/file_loader.js M LayoutTests/http/tests/webgpu/common/internal/logging/log_message.js M LayoutTests/http/tests/webgpu/common/internal/logging/logger.js M LayoutTests/http/tests/webgpu/common/internal/logging/result.js M LayoutTests/http/tests/webgpu/common/internal/logging/test_case_recorder.js M LayoutTests/http/tests/webgpu/common/internal/params_utils.js M LayoutTests/http/tests/webgpu/common/internal/query/compare.js M LayoutTests/http/tests/webgpu/common/internal/query/encode_selectively.js M LayoutTests/http/tests/webgpu/common/internal/query/json_param_value.js M LayoutTests/http/tests/webgpu/common/internal/query/parseQuery.js M LayoutTests/http/tests/webgpu/common/internal/query/query.js M LayoutTests/http/tests/webgpu/common/internal/query/separators.js M LayoutTests/http/tests/webgpu/common/internal/query/stringify_params.js M LayoutTests/http/tests/webgpu/common/internal/query/validQueryPart.js M LayoutTests/http/tests/webgpu/common/internal/stack.js M LayoutTests/http/tests/webgpu/common/internal/test_group.js M LayoutTests/http/tests/webgpu/common/internal/test_suite_listing.js M LayoutTests/http/tests/webgpu/common/internal/tree.js M LayoutTests/http/tests/webgpu/common/internal/util.js M LayoutTests/http/tests/webgpu/common/internal/version.js A LayoutTests/http/tests/webgpu/common/internal/websocket_logger.js M LayoutTests/http/tests/webgpu/common/runtime/helper/options.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker-worker.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker.js M LayoutTests/http/tests/webgpu/common/runtime/wpt.js M LayoutTests/http/tests/webgpu/common/util/collect_garbage.js M LayoutTests/http/tests/webgpu/common/util/colors.js M LayoutTests/http/tests/webgpu/common/util/data_tables.js M LayoutTests/http/tests/webgpu/common/util/navigator_gpu.js M LayoutTests/http/tests/webgpu/common/util/preprocessor.js M LayoutTests/http/tests/webgpu/common/util/timeout.js M LayoutTests/http/tests/webgpu/common/util/types.js M LayoutTests/http/tests/webgpu/common/util/util.js M LayoutTests/http/tests/webgpu/common/util/wpt_reftest_wait.js A LayoutTests/http/tests/webgpu/cts-chunked2sec.https.html M LayoutTests/http/tests/webgpu/cts.https.html M LayoutTests/http/tests/webgpu/resources/README.md A LayoutTests/http/tests/webgpu/resources/four-colors-h264-bt601-rotate-180.mp4 A LayoutTests/http/tests/webgpu/resources/four-colors-h264-bt601-rotate-270.mp4 A LayoutTests/http/tests/webgpu/resources/four-colors-h264-bt601-rotate-90.mp4 A LayoutTests/http/tests/webgpu/resources/four-colors-h264-bt601.mp4 A LayoutTests/http/tests/webgpu/resources/four-colors-theora-bt601.ogv A LayoutTests/http/tests/webgpu/resources/four-colors-vp8-bt601.webm A LayoutTests/http/tests/webgpu/resources/four-colors-vp9-bt601.webm A LayoutTests/http/tests/webgpu/resources/four-colors-vp9-bt709.webm A LayoutTests/http/tests/webgpu/resources/four-colors.png M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestAdapter.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestAdapterInfo.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestDevice.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_detach.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_oom.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/image_copy.spec.js A LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/queries/occlusionQuery.html A LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/queries/occlusionQuery.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/render/state_tracking.spec.js M
[webkit-changes] [WebKit/WebKit] b06c5b: Wrappers of r-value Ref/RefPtr should be RetainPtr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b06c5b6e37bf5af6279d85e1e9a9de34e4848a38 https://github.com/WebKit/WebKit/commit/b06c5b6e37bf5af6279d85e1e9a9de34e4848a38 Author: Alex Christensen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebKit/Shared/Cocoa/WKObject.h M Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm M Source/WebKit/UIProcess/API/Cocoa/WKBackForwardList.mm M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm M Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm M Source/WebKit/UIProcess/API/Cocoa/WKOpenPanelParameters.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm M Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm M Source/WebKit/UIProcess/API/Cocoa/_WKGeolocationPosition.mm M Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadInfo.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/Inspector/Cocoa/InspectorExtensionDelegate.mm M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInCSSStyleDeclarationHandle.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm Log Message: --- Wrappers of r-value Ref/RefPtr should be RetainPtr instead of autorelease https://bugs.webkit.org/show_bug.cgi?id=263548 rdar://117369554 Reviewed by Simon Fraser. It turns out they don't all need to go into the autoreleasepool. Some of them can just use RetainPtr::get and then deallocate the object immediately if it is not retained by the called function. Also, having adoptNS leakRef and autorelease on the same line is hard to tell a regex how to reason about, so this makes our style easier to enforce. * Source/WebKit/Shared/Cocoa/WKObject.h: (WebKit::wrapper): * Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm: (WKPageLoadURLRequestReturningNavigation): (WKPageLoadFileReturningNavigation): * Source/WebKit/UIProcess/API/Cocoa/WKBackForwardList.mm: (-[WKBackForwardList backList]): (-[WKBackForwardList forwardList]): * Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm: (+[WKContentRuleListStore storeWithURL:]): (+[WKContentRuleListStore storeWithURLAndLegacyFilename:]): * Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm: (+[WKContentWorld worldWithName:]): * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm: (-[WKFrameInfo _handle]): (-[WKFrameInfo _parentFrameHandle]): * Source/WebKit/UIProcess/API/Cocoa/WKOpenPanelParameters.mm: (-[WKOpenPanelParameters _acceptedMIMETypes]): (-[WKOpenPanelParameters _acceptedFileExtensions]): (-[WKOpenPanelParameters _allowedFileExtensions]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (+[WKPreferences _features]): (+[WKPreferences _internalDebugFeatures]): (+[WKPreferences _experimentalFeatures]): * Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _configuration]): (-[WKProcessPool _downloadURLRequest:websiteDataStore:originatingWebView:]): (-[WKProcessPool _resumeDownloadFromData:websiteDataStore:path:originatingWebView:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView loadRequest:]): (-[WKWebView loadFileURL:allowingReadAccessToURL:]): (-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]): (-[WKWebView goToBackForwardListItem:]): (-[WKWebView goBack]): (-[WKWebView goForward]): (-[WKWebView reload]): (-[WKWebView reloadFromOrigin]): (-[WKWebView loadSimulatedRequest:response:responseData:]): (-[WKWebView loadFileRequest:allowingReadAccessToURL:]): (-[WKWebView _mainFrame]): (-[WKWebView _frames:]): (-[WKWebView _frameTrees:]): (-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]): (-[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:]): (-[WKWebView _reloadWithoutContentBlockers]): (-[WKWebView _reloadExpiredOnly]): (-[WKWebView _sessionStateData]):
[webkit-changes] [WebKit/WebKit] 7d177e: [JSC] Make each IC as one big handler
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d177e2ec1a6260e4272a03a4d2baf33dfd065ac https://github.com/WebKit/WebKit/commit/7d177e2ec1a6260e4272a03a4d2baf33dfd065ac Author: Yusuke Suzuki Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/AccessCase.h M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/InlineAccess.cpp M Source/JavaScriptCore/bytecode/InlineAccess.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGJITCode.cpp M Source/JavaScriptCore/dfg/DFGJITCode.h M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp M Source/JavaScriptCore/dfg/DFGJITCompiler.h M Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/jit/BaselineJITCode.cpp M Source/JavaScriptCore/jit/BaselineJITCode.h M Source/JavaScriptCore/jit/BaselineJITRegisters.h M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITCall.cpp M Source/JavaScriptCore/jit/JITCode.h M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITInlines.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/jit/JITPropertyAccess.cpp M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/runtime/VM.cpp M Source/WTF/WTF.xcodeproj/project.pbxproj A Source/WTF/wtf/ButterflyArray.h M Source/WTF/wtf/CMakeLists.txt Log Message: --- [JSC] Make each IC as one big handler https://bugs.webkit.org/show_bug.cgi?id=263414 rdar://117227541 Reviewed by Keith Miller. This is a part of handler IC transition. In this patch, we make all IC as one big handler IC in each place. So, each IC's launching code becomes the final form, which loads a handler and invoke it. And now, each IC only has one handler which includes everything. The approach in handler IC will split this handler into chain of handlers, and sharing these handlers across the IC sites. Now, we need to have additional one level load for each IC, and we would like to alleviate the effect of this. To make it work well, in this patch, we introduce ButterflyArray, and remove one level of load to get StructureStubInfo. Now StructureStubInfo is directly embedded into JITData, and we can compute the pointer without load from that. This removes one load, and instead we introduce one load for handler. So, while we are not getting the final handler IC benefit, we can keep perf neutral while we are continuously doing incremental work towards handler IC. * Source/JavaScriptCore/bytecode/AccessCase.cpp: (JSC::SharedJITStubSet::getMegamorphic): Deleted. (JSC::SharedJITStubSet::setMegamorphic): Deleted. * Source/JavaScriptCore/bytecode/AccessCase.h: (JSC::SharedJITStubSet::Hash::Key::Key): Deleted. (JSC::SharedJITStubSet::Hash::Key::isHashTableDeletedValue const): Deleted. (JSC::SharedJITStubSet::Hash::hash): Deleted. (JSC::SharedJITStubSet::Hash::equal): Deleted. (JSC::SharedJITStubSet::Searcher::Translator::hash): Deleted. (JSC::SharedJITStubSet::Searcher::Translator::equal): Deleted. (JSC::SharedJITStubSet::PointerTranslator::hash): Deleted. (JSC::SharedJITStubSet::PointerTranslator::equal): Deleted. (JSC::SharedJITStubSet::add): Deleted. (JSC::SharedJITStubSet::remove): Deleted. (JSC::SharedJITStubSet::find): Deleted. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::setupWithUnlinkedBaselineCode): (JSC::CodeBlock::forEachStructureStubInfo): (JSC::CodeBlock::resetBaselineJITData): * Source/JavaScriptCore/bytecode/InlineAccess.cpp: (JSC::InlineAccess::resetStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccessNotUsingInlineAccess): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheHandler::InlineCacheHandler): (JSC::m_watchpoints): (JSC::InlineCacheHandler::createSlowPath): (JSC::InlineCacheCompiler::generateSlowPathHandler): (JSC::InlineCacheCompiler::regenerate): (JSC::PolymorphicAccess::visitWeak const): (JSC::InlineCacheHandler::aboutToDie): (JSC::InlineCacheHandler::visitWeak const): (JSC::PolymorphicAccess::PolymorphicAccess): Deleted. (JSC::PolymorphicAccess::~PolymorphicAccess): Deleted. (JSC::PolymorphicAccess::aboutToDie): Deleted. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: (JSC::AccessGenerationResult::handler const):
[webkit-changes] [WebKit/WebKit] 9c1e3b: (safe-)merge-queue should expose its status
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c1e3b2893b0e7e790052ee964a72896091b5f90 https://github.com/WebKit/WebKit/commit/9c1e3b2893b0e7e790052ee964a72896091b5f90 Author: Brianna Fan Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- (safe-)merge-queue should expose its status https://bugs.webkit.org/show_bug.cgi?id=262899 rdar://problem/116687268 Reviewed by Jonathan Bedard. Adds a comment with the build link to a PR labelled with safe-merge-queue once it is updated (either labelled with merge-queue or merging-blocked). * Tools/CISupport/ews-build/steps.py: (ValidateCommitterAndReviewer.fail_build): (RemoveAndAddLabels.run): Canonical link: https://commits.webkit.org/269684@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c49d82: [Gardening]: REGRESSION (NEW TEST): [ macOS wk1 ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c49d82439cf85e5c6a9e455a580a040b910aacd9 https://github.com/WebKit/WebKit/commit/c49d82439cf85e5c6a9e455a580a040b910aacd9 Author: Marta Darbinyan Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (NEW TEST): [ macOS wk1 arm64 ] media/media-source/media-source-webm-configuration-framerate.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=263568 rdar://117380844 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/269683@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 551c2e: wasm.yaml/wasm/lowExecutableMemory/imports-oom.js....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 551c2ebfb07ae634e4e893c2fa4ecefda920bbc9 https://github.com/WebKit/WebKit/commit/551c2ebfb07ae634e4e893c2fa4ecefda920bbc9 Author: Michael Saboff Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M JSTests/wasm/lowExecutableMemory/exports-oom.js M JSTests/wasm/lowExecutableMemory/imports-oom.js M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp Log Message: --- wasm.yaml/wasm/lowExecutableMemory/imports-oom.js.default-wasm is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=244122 rdar://98882300 Reviewed by Justin Michaud. Fixed two issues. 1) If we run out of memory when creating a LLIntPlan in the CalleeGroup constructor, we now error out. 2) If we run out of memory when compiling / linking the JS to Wasm IC callee, we error out instead of creating a JSToWasmICCallee that doesn't have and entrypoint. Re-enabled exports-oom.js and imports-oom.js tests. * JSTests/wasm/lowExecutableMemory/exports-oom.js: * JSTests/wasm/lowExecutableMemory/imports-oom.js: * Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp: (JSC::Wasm::CalleeGroup::CalleeGroup): * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::jsCallEntrypointSlow): Canonical link: https://commits.webkit.org/269682@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5b5a3: Use `_UITextCursorDragAnimator` to animate the car...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5b5a33d6f129ebae5acab64dfff3e0e481283b7 https://github.com/WebKit/WebKit/commit/f5b5a33d6f129ebae5acab64dfff3e0e481283b7 Author: Wenson Hsieh Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- Use `_UITextCursorDragAnimator` to animate the caret view when dropping over editable content https://bugs.webkit.org/show_bug.cgi?id=263540 rdar://114331535 Reviewed by Megan Gardner. Adopt `_UITextCursorDragAnimator` and use it to display the "drop caret" when hovering over an editable element on iOS, with an active drag session (we currently use `_UITextDragCaretView`). The new animator works similarly, taking `UITextPosition`s that can be used to update the caret position when the drop position changes; however, it must be initialized with a `UIView`, which we can indirectly create by * Source/WTF/wtf/PlatformHave.h: Add a new compile-time flag. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: Import the requisite header for `_UITextCursorDragAnimator`. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _shouldUseTextCursorDragAnimator]): Use the new animator only if `UseAsyncUIKitInteractions` is set, and the animator class is available at runtime. (-[WKContentView cleanUpDragSourceSessionState]): (-[WKContentView _insertDropCaret:]): (-[WKContentView _removeDropCaret]): Consolidate logic for tearing down the drop caret in a single method, now that it needs to take care of both the legacy `_UITextDragCaretView` and the modern `_UITextCursorDragAnimator` / `UIView`. (-[WKContentView _didChangeDragCaretRect:currentRect:]): Canonical link: https://commits.webkit.org/269681@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c07a3c: [text-wrap] Enable `text-wrap: balance` in STP
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c07a3c339c79176f5c06ffc5a285a450f4db7f8a https://github.com/WebKit/WebKit/commit/c07a3c339c79176f5c06ffc5a285a450f4db7f8a Author: Tim Nguyen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: A LayoutTests/fast/css/text-wrap-pretty-disabled-expected.txt A LayoutTests/fast/css/text-wrap-pretty-disabled.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSPropertyParser.cpp Log Message: --- [text-wrap] Enable `text-wrap: balance` in STP https://bugs.webkit.org/show_bug.cgi?id=263516 rdar://117336969 Reviewed by Brent Fulgham. Enable the `text-wrap-style` property in STP (and hence `text-wrap: balance`). Also split out `text-wrap-style: pretty` in its own preference since it is not currently implemented. * LayoutTests/fast/css/text-wrap-pretty-disabled-expected.txt: Added. * LayoutTests/fast/css/text-wrap-pretty-disabled.html: Added. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeTextWrapShorthand): Canonical link: https://commits.webkit.org/269680@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9abc7c: Deploy smart pointers in ScriptElement.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9abc7cc058f076eff92d7a800356e3782ee24b74 https://github.com/WebKit/WebKit/commit/9abc7cc058f076eff92d7a800356e3782ee24b74 Author: Ryosuke Niwa Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptRunner.h Log Message: --- Deploy smart pointers in ScriptElement.cpp https://bugs.webkit.org/show_bug.cgi?id=263464 Reviewed by Chris Dumez. Deploy more smart pointers in ScriptElement.cpp as found by clang static analyzer. * Source/WebCore/dom/Document.cpp: (WebCore::Document::checkedScriptRunner): * Source/WebCore/dom/Document.h: * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::prepareScript): (WebCore::ScriptElement::requestImportMap): (WebCore::ScriptElement::executeClassicScript): (WebCore::ScriptElement::executeScriptAndDispatchEvent): (WebCore::ScriptElement::executePendingScript): * Source/WebCore/dom/ScriptRunner.h: Canonical link: https://commits.webkit.org/269679@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b9811: [WGSL] Mangle struct fields
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b981166c8cf856b285755b9ec1a0bc886b2b664 https://github.com/WebKit/WebKit/commit/2b981166c8cf856b285755b9ec1a0bc886b2b664 Author: Tadeu Zagallo Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WGSL/AST/ASTFieldAccessExpression.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/MangleNames.cpp M Source/WebGPU/WGSL/tests/valid/name-mangling.wgsl M Source/WebGPU/WGSL/tests/valid/packing.wgsl Log Message: --- [WGSL] Mangle struct fields https://bugs.webkit.org/show_bug.cgi?id=263549 rdar://117369715 Reviewed by Mike Wyrzykowski. Originally we didn't have enough type information to support mangling struct members, but it works now. * Source/WebGPU/WGSL/AST/ASTFieldAccessExpression.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::getPacking): * Source/WebGPU/WGSL/MangleNames.cpp: (WGSL::NameManglerVisitor::visit): * Source/WebGPU/WGSL/tests/valid/name-mangling.wgsl: * Source/WebGPU/WGSL/tests/valid/packing.wgsl: Canonical link: https://commits.webkit.org/269678@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c02eeb: [WGSL] Allow pointer operators on assignment targets
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c02eeb8b9b22cd5effae9a654f36e61f24118beb https://github.com/WebKit/WebKit/commit/c02eeb8b9b22cd5effae9a654f36e61f24118beb Author: Tadeu Zagallo Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/tests/valid/pointers.wgsl Log Message: --- [WGSL] Allow pointer operators on assignment targets https://bugs.webkit.org/show_bug.cgi?id=263547 rdar://117369455 Reviewed by Mike Wyrzykowski. The grammar allows for `*x` and `*x` to appear in the left-hand side of assignments, but our parser did not support it yet. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseStatement): (WGSL::Parser::parseLHSExpression): * Source/WebGPU/WGSL/tests/valid/pointers.wgsl: Canonical link: https://commits.webkit.org/269677@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60b012: [Gardening][ iOS17, Sonoma ] 6 tests in imported/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60b012b627391e8911f83f8dc5f874a0b9056adc https://github.com/WebKit/WebKit/commit/60b012b627391e8911f83f8dc5f874a0b9056adc Author: Tim Nguyen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening][ iOS17, Sonoma ] 6 tests in imported/w3c/web-platform-tests/css/css-text/word-break/auto-phrase are constant ImageOnlyFailures. https://bugs.webkit.org/show_bug.cgi?id=263556 rdar://117372325 Unreviewed, test gardening. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/269676@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d07b7: Unreviewed partial revert of 269641@main to addres...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d07b7ea6c41c42095b3a5beefbf5c2c7cfee65a https://github.com/WebKit/WebKit/commit/8d07b7ea6c41c42095b3a5beefbf5c2c7cfee65a Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/dom/EventTarget.cpp Log Message: --- Unreviewed partial revert of 269641@main to address assertions on the bots * Source/WebCore/dom/EventTarget.cpp: (WebCore::EventTarget::invalidateEventListenerRegions): Canonical link: https://commits.webkit.org/269675@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe0aa7: [JSC] Implement ArrayBuffer#transfer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe0aa79252484e5da584cf525ccc930e7698deef https://github.com/WebKit/WebKit/commit/fe0aa79252484e5da584cf525ccc930e7698deef Author: Yusuke Suzuki Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M JSTests/stress/v8-harmony-arraybuffer-transfer.js M JSTests/test262/config.yaml M JSTests/test262/expectations.yaml M Source/JavaScriptCore/runtime/CommonIdentifiers.h M Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp Log Message: --- [JSC] Implement ArrayBuffer#transfer https://bugs.webkit.org/show_bug.cgi?id=263518 rdar://117337535 Reviewed by Mark Lam and Ross Kirsling. This patch implements ArrayBuffer#transfer proposal[1], which is stage-3 and implemented in the other engines too. It implements two functions and one getter. 1. ArrayBuffer#transfer. It transfers internal ArrayBuffer to a new ArrayBuffer and detach the original buffer. This only works with normal ArrayBuffer and it throws an error against SharedArrayBuffer. This preserves resizability of the original ArrayBuffer, it means that if we transfer resizable ArrayBuffer, we get resizable transferred ArrayBuffer. 2. ArrayBuffer#transferToFixedLength is similar to ArrayBuffer#transfer. But this always creates non-resizable ArrayBuffer. It means, internally, we create a new ArrayBuffer if resizability is different and copy the underlying content. In both cases, if ArrayBuffer is not resizable and result size is the same, then it just changes underlying buffer's ownership and does not allocate and copy contents. If it is ArrayBuffer#transfer and the input ArrayBuffer is resizable, then we also just changes the ownership and resize the resulted ArrayBuffer's size. 3. ArrayBuffer#detach getter returns boolean whether ArrayBuffer is detached or not. [1]: https://tc39.es/proposal-arraybuffer-transfer/ * JSTests/test262/config.yaml: * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/CommonIdentifiers.h: * Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp: (JSC::arrayBufferCopyAndDetach): (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSArrayBufferPrototype::finishCreation): Canonical link: https://commits.webkit.org/269674@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 454ec9: [WGSL] Add more information to type declarations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 454ec9e1ec8c89ed1977b3e149f0533ec77c6097 https://github.com/WebKit/WebKit/commit/454ec9e1ec8c89ed1977b3e149f0533ec77c6097 Author: Tadeu Zagallo Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WGSL/AST/ASTCallExpression.h M Source/WebGPU/WGSL/ConstantFunctions.h M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/Overload.h M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/generator/main.rb Log Message: --- [WGSL] Add more information to type declarations https://bugs.webkit.org/show_bug.cgi?id=263550 rdar://117370085 Reviewed by Mike Wyrzykowski. This patch adds 4 bits of information to the declarations in TypeDeclarations.rb: - it makes a distinction between constructors, regular functions and operators - whether the function is const, and moves the pointer to the constant functions into the overload entry, so that it no longer needs to be looked up in a separate hash map - the stages in which the declaration is available - whether the function specifies `@must_use` or not * Source/WebGPU/WGSL/AST/ASTCallExpression.h: * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::constantAdd): (WGSL::constantVec2): (WGSL::constantVec3): (WGSL::constantVec4): (WGSL::constantVector2): Deleted. (WGSL::constantVector3): Deleted. (WGSL::constantVector4): Deleted. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/Overload.h: * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::TypeChecker): (WGSL::TypeChecker::chooseOverload): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/generator/main.rb: Canonical link: https://commits.webkit.org/269673@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4fdfc1: Adopt more smart pointers in RadioButtonGroups
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4fdfc1517dbe4fc4d25caf4070de1280dcbb9843 https://github.com/WebKit/WebKit/commit/4fdfc1517dbe4fc4d25caf4070de1280dcbb9843 Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/dom/RadioButtonGroups.cpp Log Message: --- Adopt more smart pointers in RadioButtonGroups https://bugs.webkit.org/show_bug.cgi?id=263528 Reviewed by Darin Adler. * Source/WebCore/dom/RadioButtonGroups.cpp: (WebCore::RadioButtonGroup::isEmpty const): (WebCore::RadioButtonGroup::members const): (WebCore::RadioButtonGroup::setCheckedButton): (WebCore::RadioButtonGroup::remove): (WebCore::RadioButtonGroup::setNeedsStyleRecalcForAllButtons): (WebCore::RadioButtonGroup::updateValidityForAllButtons): (WebCore::RadioButtonGroups::groupMembers const): (WebCore::RadioButtonGroups::updateCheckedState): (WebCore::RadioButtonGroups::requiredStateChanged): (WebCore::RadioButtonGroups::checkedButtonForGroup const): (WebCore::RadioButtonGroups::hasCheckedButton const): (WebCore::RadioButtonGroups::isInRequiredGroup const): (WebCore::RadioButtonGroups::removeButton): Canonical link: https://commits.webkit.org/269672@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc27e1: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc27e1c45f91699dfcf05f7e3f9ee30fb6f07904 https://github.com/WebKit/WebKit/commit/bc27e1c45f91699dfcf05f7e3f9ee30fb6f07904 Author: Fujii Hironori Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68f1a3: Stabilise attachment-uti.html with reftest-wait an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68f1a337127aec08290217e19bc40ac142103093 https://github.com/WebKit/WebKit/commit/68f1a337127aec08290217e19bc40ac142103093 Author: Gerald Squelart Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/fast/attachment/attachment-uti-expected.html M LayoutTests/fast/attachment/attachment-uti.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Stabilise attachment-uti.html with reftest-wait and takeScreenshotWhenAttachmentsSettled https://bugs.webkit.org/show_bug.cgi?id=263085 rdar://116877284 Reviewed by Aditya Keerthi. Attachment-uti.html was flaky, with the actual and/or expected rendering sometimes missing the icon, because that icon is only fetched during the first rendering. Use reftest-wait and takeScreenshotWhenAttachmentsSettled to delay the test screenshot until there is an icon. * LayoutTests/fast/attachment/attachment-uti-expected.html: * LayoutTests/fast/attachment/attachment-uti.html: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269670@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82de22: Provide a getter for webViewConfiguration on _WKWe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82de229ab5a54e1441857befa56fa9cab65b1e8e https://github.com/WebKit/WebKit/commit/82de229ab5a54e1441857befa56fa9cab65b1e8e Author: Timothy Hatcher Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- Provide a getter for webViewConfiguration on _WKWebExtensionContext. https://webkit.org/b/263533 rdar://problem/117359849 Reviewed by Brian Weinstein. Add API for obtaining correct WKWebViewConfiguration for web extension content in tabs. Flesh out the remaining web view configuration properties needed, and provide configurations for distinct web view purposes with different process names in manifest v3. To make sure the app uses the right configuration, make extension URL load fail if they are not using the right configuration, and prevent extension configured views from loading other URLs. * Source/WebCore/en.lproj/Localizable.strings: Updated. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration copyWithZone:]): Copy _requiredWebExtensionBaseURL. (-[WKWebViewConfiguration _requiredWebExtensionBaseURL]): Added. (-[WKWebViewConfiguration _setRequiredWebExtensionBaseURL:]): Added. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext webViewConfiguration]): Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm: (-[_WKWebExtensionController extensionContextForURL:]): Added. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::isUnsupportedWebExtensionNavigation): Added. (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): Call isUnsupportedWebExtensionNavigation. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: (WebKit::WebExtensionAction::popupWebView): Pass a WebViewPurpose for the configuration. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::webProcessDisplayName): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::relatedWebView): Return nil for v3 and later. Simplify by looking at all known pages that have the extension URL loaded, so it catches tab pages too. (WebKit::WebExtensionContext::processDisplayName): Added. (WebKit::WebExtensionContext::corsDisablingPatterns): Added. (WebKit::WebExtensionContext::webViewConfiguration): Expanded and added WebViewPurpose. (WebKit::WebExtensionContext::loadBackgroundWebView): Pass a WebViewPurpose for the configuration. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm: (WebKit::WebExtensionURLSchemeHandler::platformStartTask): Return an error when loading an extension URL in the main frame of a improperly configured web view. * Source/WebKit/UIProcess/Extensions/WebExtension.h: (WebKit::WebExtension::supportsManifestVersion): Added an ASSERT to catch a mistake that I keep making where passing 2 is invalid since that will be true for all extensions. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: Canonical link: https://commits.webkit.org/269669@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc94fc: synthesizedBaseline uses incorrect line under edge...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc94fc496ea98de389ed201f55ab2b4f089a0f7e https://github.com/WebKit/WebKit/commit/bc94fc496ea98de389ed201f55ab2b4f089a0f7e Author: Sammy Gill Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-vert-lr-line-under-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-vert-lr-line-under.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt M Source/WebCore/rendering/RenderBox.cpp Log Message: --- synthesizedBaseline uses incorrect line under edge for vertical-lr and sideways items https://bugs.webkit.org/show_bug.cgi?id=263461 rdar://117273063 Reviewed by Alan Baradlay. To synthesize a baseline, the spec says the following: "synthesize the alphabetic baseline from the line-under line, and the central baseline by averaging the positions of the two edges or lines." When the writing mode is vertical-lr and text-orientation is sideways, we must synthesize the alphabetic baseline. This means that the baseline for the item in this writing-mode is its block-start and not the block-end like in vertical-rl writing mode. We can first determine the baseline that we are synthesizing according to the logic in: https://drafts.csswg.org/css-inline-3/#dominant-baseline-property If the baseline type is alphabetic and we are in a vertical-lr writing mode according to the formatting context root, then we can return 0_lu for the synthesized baseline. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-vert-lr-line-under-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-vert-lr-line-under.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::synthesizedBaseline): Canonical link: https://commits.webkit.org/269668@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53f8f0: [WebGPU] mip level validation is not handled corre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53f8f07b250856cd134cedc5466ff64eb12cd778 https://github.com/WebKit/WebKit/commit/53f8f07b250856cd134cedc5466ff64eb12cd778 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/Queue.mm M Source/WebGPU/WebGPU/Texture.h M Source/WebGPU/WebGPU/Texture.mm Log Message: --- [WebGPU] mip level validation is not handled correctly in copyBuffer/TextureToBuffer/Texture https://bugs.webkit.org/show_bug.cgi?id=254175 Reviewed by Tadeu Zagallo. Fix some validation that was preventing imageCopy tests from working. Compressed texture formats are still not fully working, but all the other cases pass. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp: (WebCore::WebGPU::CommandEncoderImpl::copyBufferToTexture): (WebCore::WebGPU::CommandEncoderImpl::copyTextureToBuffer): * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::validateImageCopyBuffer): (WebGPU::CommandEncoder::copyBufferToTexture): (WebGPU::CommandEncoder::copyTextureToBuffer): * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): * Source/WebGPU/WebGPU/Texture.h: * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Texture::isCompressedFormat): (WebGPU::Device::validateCreateTexture): (WebGPU::Texture::validateImageCopyTexture): (WebGPU::Texture::validateLinearTextureData): (WebGPU::isCompressedFormat): Deleted. Canonical link: https://commits.webkit.org/269667@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b4d9a: Remove 'libxml2' hacks called 'hackAroundLibXMLEnt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b4d9ac4ad7211b883b024bd21450d0dbbf36fce https://github.com/WebKit/WebKit/commit/2b4d9ac4ad7211b883b024bd21450d0dbbf36fce Author: Ahmad Saleem Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/xml/parser/XMLDocumentParser.h M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Remove 'libxml2' hacks called 'hackAroundLibXMLEntityBug' and 'hackAroundLibXMLEntityParsingBug' https://bugs.webkit.org/show_bug.cgi?id=263497 Reviewed by Don Olmstead, David Kilzer and Michael Catanzaro. Inspired by: https://src.chromium.org/viewvc/blink?view=revision=149452 & https://src.chromium.org/viewvc/blink?view=revision=149412 This patch removes old hacks to workaround `libxml2` bugs, which are no longer applicable. These underlying bugs were fixed in upstream `libxml2` in following versions: - hackAroundLibXMLEntityBug (fixed in 2.6.27) - hackAroundLibXMLEntityParsingBug (fixed in 2.7.3) All WebKit ports (via CMake) support following libxml2 version as required: - mac (2.8.0 as required) - Windows & Playstation (2.9.7 as required) - WPE (2.8.0 as required) - GTK (2.8.0 as required) * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (hackAroundLibXMLEntityParsingBug): Deleted (XMLDocumentParser::startElementNs): Clean-up after 'function' deletion (XMLDocumentParser::endElementNs): Ditto (hackAroundLibXMLEntityBug): Deleted (startElementNsHandler): Clean-up after 'function' deletion (endElementNsHandler): Ditto (charactersHandler): Ditto (processingInstructionHandler): Ditto (cdataBlockHandler): Ditto (commentHandler): Ditto (entityDeclarationHandler): Deleted (getEntityHandler): Clean-up after 'function' deletion (XMLDocumentParser::initializeParserContext): Ditto * Source/WebCore/xml/parser/XMLDocumentParser.h: Remove unused functions after clean-up Canonical link: https://commits.webkit.org/269666@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53375e: [WebGPU] WGPU_COPY_STRIDE_UNDEFINED is not handled...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53375e8efea77e409e62077ef412844bc974a637 https://github.com/WebKit/WebKit/commit/53375e8efea77e409e62077ef412844bc974a637 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] WGPU_COPY_STRIDE_UNDEFINED is not handled in WGPUVertexBufferLayout https://bugs.webkit.org/show_bug.cgi?id=263484 Reviewed by Tadeu Zagallo. WGPU_COPY_STRIDE_UNDEFINED should be handled since the buffers can be null per the idl file, but the only reason we failed to create a buffer in this CTS test was due to the switch statement values being incorrect. So this patch also corrects the switch statement values to avoid the null buffer creation. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::vertexFormat): (WebGPU::createVertexDescriptor): Canonical link: https://commits.webkit.org/269665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 922c03: [GPU Process] REGRESSION: display-p3 stroke color ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 922c037bca6e8cdf1186b3731e3e91a70372333a https://github.com/WebKit/WebKit/commit/922c037bca6e8cdf1186b3731e3e91a70372333a Author: Said Abou-Hallawa Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: A LayoutTests/fast/canvas/canvas-line-no-change-display-p3-stroke-expected.html A LayoutTests/fast/canvas/canvas-line-no-change-display-p3-stroke.html M Source/WebCore/platform/graphics/Color.h M Source/WebCore/platform/graphics/displaylists/DisplayListItem.h M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h M Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp M Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp Log Message: --- [GPU Process] REGRESSION: display-p3 stroke color in canvas crashes the webpage https://bugs.webkit.org/show_bug.cgi?id=263387 rdar://117226767 Reviewed by Simon Fraser. Recording the inline path data items is enabled only if the state stroke has an inline color or if the stroke color was not changed since last time the state was committed. A crash will happen when the current stroke color is not inline (display-p3 for example) and it has been committed to the destination context in GPUP but the stroke thickness was changed. The item SetInlineStrokeColor tries to get the inline data a non inline color although the current stroke color is not inline and it has not changed. So the crash happens. The fix is to merge the inline stroke changes into one DisplayList item named SetInlineStroke. It has two optional members: the inline color data and the thickness. Each member will be set only if it was changed since last commit. For representing the color in SetInlineStroke, PackedColor::RGBA will be used instead of SRGBA since it is easier to be encoded. * LayoutTests/fast/canvas/canvas-line-no-change-display-p3-stroke-expected.html: Added. * LayoutTests/fast/canvas/canvas-line-no-change-display-p3-stroke.html: Added. * Source/WebCore/platform/graphics/Color.h: (WebCore::Color::tryGetAsPackedInline const): * Source/WebCore/platform/graphics/displaylists/DisplayListItem.h: * Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp: (WebCore::DisplayList::SetInlineStroke::apply const): (WebCore::DisplayList::SetInlineStroke::dump const): (WebCore::DisplayList::SetInlineStrokeColor::apply const): Deleted. (WebCore::DisplayList::SetInlineStrokeColor::dump const): Deleted. (WebCore::DisplayList::SetStrokeThickness::apply const): Deleted. (WebCore::DisplayList::SetStrokeThickness::dump const): Deleted. * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h: (WebCore::DisplayList::SetInlineFillColor::SetInlineFillColor): (WebCore::DisplayList::SetInlineFillColor::color const): (WebCore::DisplayList::SetInlineFillColor::colorData const): (WebCore::DisplayList::SetInlineStroke::SetInlineStroke): (WebCore::DisplayList::SetInlineStroke::color const): (WebCore::DisplayList::SetInlineStroke::colorData const): (WebCore::DisplayList::SetInlineStroke::thickness const): (WebCore::DisplayList::SetInlineStrokeColor::SetInlineStrokeColor): Deleted. (WebCore::DisplayList::SetInlineStrokeColor::color const): Deleted. (WebCore::DisplayList::SetInlineStrokeColor::colorData const): Deleted. (WebCore::DisplayList::SetStrokeThickness::SetStrokeThickness): Deleted. (WebCore::DisplayList::SetStrokeThickness::thickness const): Deleted. * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::appendStateChangeItem): (WebCore::DisplayList::Recorder::buildSetInlineStroke): (WebCore::DisplayList::Recorder::strokePath): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::recordSetInlineFillColor): (WebCore::DisplayList::RecorderImpl::recordSetInlineStroke): (WebCore::DisplayList::RecorderImpl::recordStrokeLineWithColorAndThickness): (WebCore::DisplayList::RecorderImpl::recordSetInlineStrokeColor): Deleted.
[webkit-changes] [WebKit/WebKit] ed5594: Unreviewed build fix after 269661@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed5594dc7841bd26f5498c1b996160ab50d3aaa3 https://github.com/WebKit/WebKit/commit/ed5594dc7841bd26f5498c1b996160ab50d3aaa3 Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/editing/TextManipulationController.h Log Message: --- Unreviewed build fix after 269661@main. * Source/WebCore/editing/TextManipulationController.h: Canonical link: https://commits.webkit.org/269663@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67c142: Auto-generate a handful of WebKit/Shared serializers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67c142aa6a6a646e2acc2385238769a7cdf0897a https://github.com/WebKit/WebKit/commit/67c142aa6a6a646e2acc2385238769a7cdf0897a Author: Brady Eidson Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/AppPrivacyReport.h A Source/WebKit/Shared/AppPrivacyReportTestingData.serialization.in M Source/WebKit/Shared/ResourceLoadStatisticsParameters.h A Source/WebKit/Shared/ResourceLoadStatisticsParameters.serialization.in R Source/WebKit/Shared/UserContentControllerParameters.cpp M Source/WebKit/Shared/UserContentControllerParameters.h A Source/WebKit/Shared/UserContentControllerParameters.serialization.in M Source/WebKit/Shared/WebBackForwardListCounts.h A Source/WebKit/Shared/WebBackForwardListCounts.serialization.in M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Auto-generate a handful of WebKit/Shared serializers https://bugs.webkit.org/show_bug.cgi?id=263514 rdar://117332035 Reviewed by Alex Christensen. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/AppPrivacyReport.h: (WebKit::AppPrivacyReportTestingData::encode const): Deleted. (WebKit::AppPrivacyReportTestingData::decode): Deleted. * Source/WebKit/Shared/AppPrivacyReportTestingData.serialization.in: Added. * Source/WebKit/Shared/ResourceLoadStatisticsParameters.h: (WebKit::ResourceLoadStatisticsParameters::encode const): Deleted. (WebKit::ResourceLoadStatisticsParameters::decode): Deleted. * Source/WebKit/Shared/ResourceLoadStatisticsParameters.serialization.in: Added. * Source/WebKit/Shared/UserContentControllerParameters.cpp: Removed. * Source/WebKit/Shared/UserContentControllerParameters.h: * Source/WebKit/Shared/UserContentControllerParameters.serialization.in: Added. * Source/WebKit/Shared/WebBackForwardListCounts.h: (WebKit::WebBackForwardListCounts::encode const): Deleted. (WebKit::WebBackForwardListCounts::decode): Deleted. * Source/WebKit/Shared/WebBackForwardListCounts.serialization.in: Added. * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/269662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c054a: Unreviewed, reverting 269344@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c054af26f6d67afca68d83e3708a8e575635c2f https://github.com/WebKit/WebKit/commit/8c054af26f6d67afca68d83e3708a8e575635c2f Author: Commit Queue Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/dom/Node.cpp M Source/WebCore/editing/TextManipulationController.h Log Message: --- Unreviewed, reverting 269344@main. https://bugs.webkit.org/show_bug.cgi?id=263545 Caused a Speedometer 2 regression Reverted changeset: "Adopt more smart pointers in Node.cpp" https://bugs.webkit.org/show_bug.cgi?id=263107 https://commits.webkit.org/269344@main Canonical link: https://commits.webkit.org/269661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c22f64: [WebGPU] "unorm10-10-10-2" vertex format is not im...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c22f641da18b8c4eee23b8021b37aeec69268675 https://github.com/WebKit/WebKit/commit/c22f641da18b8c4eee23b8021b37aeec69268675 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/Modules/WebGPU/GPUVertexFormat.h M Source/WebCore/Modules/WebGPU/GPUVertexFormat.idl M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUVertexFormat.h M Source/WebGPU/WebGPU/RenderPipeline.mm M Source/WebGPU/WebGPU/WebGPU.h Log Message: --- [WebGPU] "unorm10-10-10-2" vertex format is not implemented https://bugs.webkit.org/show_bug.cgi?id=263482 Reviewed by Tadeu Zagallo. This format was added a few weeks ago. * Source/WebCore/Modules/WebGPU/GPUVertexFormat.h: (WebCore::convertToBacking): * Source/WebCore/Modules/WebGPU/GPUVertexFormat.idl: * Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp: (WebCore::WebGPU::ConvertToBackingContext::convertToBacking): * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUVertexFormat.h: * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::vertexFormat): * Source/WebGPU/WebGPU/WebGPU.h: Canonical link: https://commits.webkit.org/269660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8561f1: [WebGPU] It is legal to draw zero instances, verti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8561f11281d90b07ea3171da80154be98e07f703 https://github.com/WebKit/WebKit/commit/8561f11281d90b07ea3171da80154be98e07f703 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- [WebGPU] It is legal to draw zero instances, vertices, or indices in WebGPU but this results in a validation error https://bugs.webkit.org/show_bug.cgi?id=263472 Reviewed by Tadeu Zagallo. The validation error rightfully errors if we attempt to draw zero instances, vertices, or indices, but this is legal to perform in WebGPU without an error, so simply return. * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::draw): (WebGPU::RenderBundleEncoder::drawIndexed): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::draw): (WebGPU::RenderPassEncoder::drawIndexed): Canonical link: https://commits.webkit.org/269659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60723a: [WebGPU] createConstantValues returns empty tuple ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60723a98948e25e82f78fcce1ab364165754c10b https://github.com/WebKit/WebKit/commit/60723a98948e25e82f78fcce1ab364165754c10b Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/Pipeline.mm Log Message: --- [WebGPU] createConstantValues returns empty tuple if default values are used for all overrides https://bugs.webkit.org/show_bug.cgi?id=263469 Reviewed by Tadeu Zagallo. It is not necessary to specify the constant values if they all have default values. * Source/WebGPU/WebGPU/Pipeline.mm: (WebGPU::createConstantValues): Canonical link: https://commits.webkit.org/269658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 90dd11: [WebGPU] topologyType returns wrong result for WGP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90dd1166688175f698913329ddfab799a593b6b6 https://github.com/WebKit/WebKit/commit/90dd1166688175f698913329ddfab799a593b6b6 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] topologyType returns wrong result for WGPUPrimitiveTopology_LineList https://bugs.webkit.org/show_bug.cgi?id=263470> Reviewed by Tadeu Zagallo. Looks like a typo implementing the switch statement, correct the return result for line list. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::topologyType): Canonical link: https://commits.webkit.org/269657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd905f: [WebGPU] rgb10a2 is incorrectly listed as a non-re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd905f2c70f153e08bfe28e1d7dd64caa1296a56 https://github.com/WebKit/WebKit/commit/cd905f2c70f153e08bfe28e1d7dd64caa1296a56 Author: Mike Wyrzykowski Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/Texture.mm Log Message: --- [WebGPU] rgb10a2 is incorrectly listed as a non-renderable format https://bugs.webkit.org/show_bug.cgi?id=263458 Reviewed by Tadeu Zagallo. Listed incorrectly in switch statement, rgb10a2uint is renderable. * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::isRenderableFormat): Canonical link: https://commits.webkit.org/269656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00756e: Make `TransformOperationData` constructors explicit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00756ec4a27caa537682bf6e18005d7745ee26d1 https://github.com/WebKit/WebKit/commit/00756ec4a27caa537682bf6e18005d7745ee26d1 Author: Tim Nguyen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp M Source/WebCore/rendering/TransformOperationData.h Log Message: --- Make `TransformOperationData` constructors explicit https://bugs.webkit.org/show_bug.cgi?id=263524 rdar://117352958 Unreviewed, address Darin Adler's review comment. * Source/WebCore/platform/animation/AcceleratedEffectValues.cpp: (WebCore::AcceleratedEffectValues::AcceleratedEffectValues): * Source/WebCore/rendering/TransformOperationData.h: (WebCore::TransformOperationData::TransformOperationData): Canonical link: https://commits.webkit.org/269655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54e9d3: [Gardening]: [ iOS ] All tests under imported/w3c/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54e9d335f70f1e8a504610c1dfef0c14d13cfff1 https://github.com/WebKit/WebKit/commit/54e9d335f70f1e8a504610c1dfef0c14d13cfff1 Author: Ben Schwartz Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening]: [ iOS ] All tests under imported/w3c/web-platform-tests/css/css-text/word-break/auto/ are constant failures. rdar://113988670 https://bugs.webkit.org/show_bug.cgi?id=260305 Unreviewed test gardening. Modifying expectations to skip down-levels that don't support `word-break: auto-phrase`. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/269654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f32cd0: [JSC] ForStatement should call CreatePerIterationE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f32cd0f7cb7961420ce08ae78b8f01f287bec199 https://github.com/WebKit/WebKit/commit/f32cd0f7cb7961420ce08ae78b8f01f287bec199 Author: Alexey Shvayka Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: A JSTests/stress/regress-189799.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/parser/ASTBuilder.h M Source/JavaScriptCore/parser/NodeConstructors.h M Source/JavaScriptCore/parser/Nodes.h M Source/JavaScriptCore/parser/Parser.cpp M Source/JavaScriptCore/parser/SyntaxChecker.h Log Message: --- [JSC] ForStatement should call CreatePerIterationEnvironment before first iteration https://bugs.webkit.org/show_bug.cgi?id=189799 Reviewed by Justin Michaud. This change implements step 2 of ForBodyEvaluation [1], but only if loop initializer contains a function that captures a variable from outer scope (so-called closure), to preserve performance of the common case. Emitting prepareLexicalScopeForNextForLoopIteration() unconditionally would otherwise slow down any `for` loop with body statement containing a closure (which is a quite common) by 10-20%. Before this patch, a closure inside `for` loop initializer was created with parent scope of the first iteration, rather than a separate lexical scope, ending up capturing incorrect loop counter value. Aligns JSC with V8 and SpiderMonkey. [1]: https://tc39.es/ecma262/#sec-forbodyevaluation * JSTests/stress/regress-189799.js: Added. * JSTests/test262/expectations.yaml: Mark 2 tests as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::ForNode::emitBytecode): * Source/JavaScriptCore/parser/ASTBuilder.h: (JSC::ASTBuilder::createForLoop): * Source/JavaScriptCore/parser/NodeConstructors.h: (JSC::ForNode::ForNode): * Source/JavaScriptCore/parser/Nodes.h: * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseForStatement): * Source/JavaScriptCore/parser/SyntaxChecker.h: (JSC::SyntaxChecker::createForLoop): Canonical link: https://commits.webkit.org/269653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c33e77: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c33e776c5776c72225d37ba5dc1b4e07b9006c27 https://github.com/WebKit/WebKit/commit/c33e776c5776c72225d37ba5dc1b4e07b9006c27 Author: Russell Epstein Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.5 Canonical link: https://commits.webkit.org/269652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9daa36: Get rid of a few more false positives in count-han...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9daa364b60433a09f4718da8bbbdfc9fe2a90358 https://github.com/WebKit/WebKit/commit/9daa364b60433a09f4718da8bbbdfc9fe2a90358 Author: Brady Eidson Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Tools/Scripts/count-handwritten-decoders Log Message: --- Get rid of a few more false positives in count-handwritten-decoders https://bugs.webkit.org/show_bug.cgi?id=263515 rdar://117335018 Reviewed by Alex Christensen. * Tools/Scripts/count-handwritten-decoders: Canonical link: https://commits.webkit.org/269651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5086d0: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5086d05fb428065c2b73f85795ba36ce1e2e1797 https://github.com/WebKit/WebKit/commit/5086d05fb428065c2b73f85795ba36ce1e2e1797 Author: Russell Epstein Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.4 Canonical link: https://commits.webkit.org/269650@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8764c: [ Ventura+ ] TestWebKitAPI.ServiceWorker.ServiceWo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8764c09d722fe7cd5f4fbf41f6e0a41334d0d4c https://github.com/WebKit/WebKit/commit/e8764c09d722fe7cd5f4fbf41f6e0a41334d0d4c Author: Chris Dumez Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm Log Message: --- [ Ventura+ ] TestWebKitAPI.ServiceWorker.ServiceWorkerWindowClientFocus is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=263421 rdar://117233556 Reviewed by Youenn Fablet. There can be some delay until isMiniaturized starts to returning the correct value due to visual animations. This patch updates the test to be more robust and keep checking the value if it is not the expected one yet. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Canonical link: https://commits.webkit.org/269649@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08f814: Prepare RemoteScrollingCoordinatorTransaction piec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08f8141737e23917c19660c0beaa9ea871e752e0 https://github.com/WebKit/WebKit/commit/08f8141737e23917c19660c0beaa9ea871e752e0 Author: Alex Christensen Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp M Source/WebCore/page/scrolling/ScrollingStateFixedNode.h M Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.h M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateNode.cpp M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.h M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStatePositionedNode.cpp M Source/WebCore/page/scrolling/ScrollingStatePositionedNode.h M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp M Source/WebCore/page/scrolling/ScrollingStateStickyNode.h M Source/WebCore/page/scrolling/ScrollingStateTree.cpp M Source/WebCore/page/scrolling/ScrollingStateTree.h M Source/WebCore/page/scrolling/ScrollingTree.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm Log Message: --- Prepare RemoteScrollingCoordinatorTransaction pieces for generated serialization https://bugs.webkit.org/show_bug.cgi?id=261622 rdar://115573578 Reviewed by Simon Fraser. This moves the manual C++ serialization code around so that each piece has a symmetric encode and decode function that only encodes and decodes itself with no additional context. To do this, I needed to have the scrolling state nodes deserialize only the values they contain and then attach to the scrolling state tree after all the nodes are deserialized. * Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp: (WebCore::ScrollingStateFixedNode::create): (WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): * Source/WebCore/page/scrolling/ScrollingStateFixedNode.h: * Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp: (WebCore::ScrollingStateFrameHostingNode::create): (WebCore::ScrollingStateFrameHostingNode::ScrollingStateFrameHostingNode): * Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.h: * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::create): (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode): (WebCore::ScrollingStateFrameScrollingNode::isMainFrame const): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateNode.cpp: (WebCore::ScrollingStateNode::ScrollingStateNode): (WebCore::ScrollingStateNode::attachAfterDeserialization): (WebCore::ScrollingStateNode::setChildren): (WebCore::ScrollingStateNode::recurse): (WebCore::ScrollingStateNode::setLayer): (WebCore::ScrollingStateNode::parentPointersAreCorrect const): * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp: (WebCore::ScrollingStateOverflowScrollProxyNode::create): (WebCore::ScrollingStateOverflowScrollProxyNode::ScrollingStateOverflowScrollProxyNode): * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.h: * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp: (WebCore::ScrollingStateOverflowScrollingNode::create): (WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStatePositionedNode.cpp: (WebCore::ScrollingStatePositionedNode::create): (WebCore::ScrollingStatePositionedNode::ScrollingStatePositionedNode): * Source/WebCore/page/scrolling/ScrollingStatePositionedNode.h: * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp: (WebCore::ScrollingStateStickyNode::create): (WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode): *
[webkit-changes] [WebKit/WebKit] 63bf59: [WPE][GTK] Add port name to build dir path
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63bf597ad4a3985773cf8bfeb9832ac2a6914e5e https://github.com/WebKit/WebKit/commit/63bf597ad4a3985773cf8bfeb9832ac2a6914e5e Author: Vitaly Dyachkov Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M CMakePresets.json M Tools/Scripts/webkitdirs.pm M Tools/glib/api_test_runner.py M Tools/glib/common.py Log Message: --- [WPE][GTK] Add port name to build dir path https://bugs.webkit.org/show_bug.cgi?id=263117 Reviewed by Michael Catanzaro. This will let both builds coexist on one host which is useful for QA. * Tools/Scripts/webkitdirs.pm: (determineConfigurationProductDir): (cmakeCachePath): (shouldRemoveCMakeCache): (cmakeGeneratedBuildfile): (generateBuildSystemFromCMakeProject): (buildCMakeGeneratedProject): (cleanCMakeGeneratedProject): (productDirForCMake): Deleted. * Tools/glib/api_test_runner.py: (TestRunner.__init__): (TestRunner._setup_testing_environment): (TestRunner._run_test_qt): * Tools/glib/common.py: (library_build_path): (binary_build_path): (get_build_path): (build_path): Canonical link: https://commits.webkit.org/269647@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d40154: Empty WebVTT files should not succeed in loading
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d40154a4fe8f153060d3b85bc29baf5f50ebefff https://github.com/WebKit/WebKit/commit/d40154a4fe8f153060d3b85bc29baf5f50ebefff Author: Kohei Ueno Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt R LayoutTests/media/track/captions-webvtt/tc000-empty.vtt R LayoutTests/media/track/track-webvtt-tc000-empty-expected.txt R LayoutTests/media/track/track-webvtt-tc000-empty.html M Source/WebCore/loader/TextTrackLoader.cpp Log Message: --- Empty WebVTT files should not succeed in loading https://bugs.webkit.org/show_bug.cgi?id=260409 Reviewed by Eric Carlson. Empty WebVTT files don't have a valid signature, so they should fail the signature check and result in loading failure. This patch adds the check if the resource is empty before attempting to parse it. And also the old test case is removed since it's not valid anymore in favor of the WPT. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt: * LayoutTests/media/track/captions-webvtt/tc000-empty.vtt: Removed. * LayoutTests/media/track/track-webvtt-tc000-empty-expected.txt: Removed. * LayoutTests/media/track/track-webvtt-tc000-empty.html: Removed. * Source/WebCore/loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::notifyFinished): Canonical link: https://commits.webkit.org/269646@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4adb95: Fix PlayStation build following 269639@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4adb95ac02378b7e298f1da271779af0df956d59 https://github.com/WebKit/WebKit/commit/4adb95ac02378b7e298f1da271779af0df956d59 Author: Ross Kirsling Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/JavaScriptCore/runtime/SideDataRepository.h Log Message: --- Fix PlayStation build following 269639@main https://bugs.webkit.org/show_bug.cgi?id=263517 Unreviewed build fix. std::derived_from is a C++20 feature that's nearly the same as the C++11 feature std::is_base_of_v; since it shouldn't make a difference for this particular case, let's just make use of the latter. * Source/JavaScriptCore/runtime/SideDataRepository.h: (JSC::SideDataRepository::ensure): Use std::is_base_of_v instead of std::derived_from. Canonical link: https://commits.webkit.org/269645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0e12ca: Adopt even more smart pointers in DOM code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e12ca3ef084d8fe6459fb909e7a784d879adec6 https://github.com/WebKit/WebKit/commit/0e12ca3ef084d8fe6459fb909e7a784d879adec6 Author: Chris Dumez Date: 2023-10-22 (Sun, 22 Oct 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/DocumentParser.cpp M Source/WebCore/dom/DocumentParser.h M Source/WebCore/dom/PendingScript.h M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/Range.h M Source/WebCore/dom/RangeBoundaryPoint.h M Source/WebCore/dom/RawDataDocumentParser.h M Source/WebCore/dom/RejectedPromiseTracker.cpp M Source/WebCore/dom/ScopedEventQueue.cpp M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptElement.h M Source/WebCore/dom/ScriptRunner.cpp M Source/WebCore/dom/ScriptRunner.h M Source/WebCore/dom/ScriptableDocumentParser.cpp M Source/WebCore/dom/ScriptedAnimationController.cpp M Source/WebCore/dom/ScriptedAnimationController.h M Source/WebCore/dom/SecurityContext.cpp M Source/WebCore/dom/SecurityContext.h M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/SimpleRange.cpp M Source/WebCore/dom/SimulatedClick.cpp M Source/WebCore/dom/SlotAssignment.cpp M Source/WebCore/dom/StaticRange.cpp M Source/WebCore/dom/StringCallback.cpp M Source/WebCore/dom/StyledElement.cpp M Source/WebCore/dom/TagCollection.cpp M Source/WebCore/dom/TemplateContentDocumentFragment.h M Source/WebCore/dom/Text.cpp M Source/WebCore/dom/TextDecoderStreamDecoder.cpp M Source/WebCore/dom/TextDecoderStreamDecoder.h M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/FrameSelection.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/page/csp/ContentSecurityPolicy.h Log Message: --- Adopt even more smart pointers in DOM code https://bugs.webkit.org/show_bug.cgi?id=263505 Reviewed by Darin Adler. * Source/WebCore/dom/Document.cpp: (WebCore::Document::protectedWindowProxy const): (WebCore::Document::checkedSelection): (WebCore::Document::checkedSelection const): * Source/WebCore/dom/Document.h: * Source/WebCore/dom/DocumentParser.cpp: (WebCore::DocumentParser::protectedDocument const): * Source/WebCore/dom/DocumentParser.h: * Source/WebCore/dom/PendingScript.h: * Source/WebCore/dom/Range.cpp: (WebCore::Range::Range): (WebCore::Range::~Range): (WebCore::Range::protectedOwnerDocument): (WebCore::Range::updateAssociatedSelection): (WebCore::Range::updateAssociatedHighlight): (WebCore::Range::updateDocument): (WebCore::childOfCommonRootBeforeOffset): (WebCore::Range::protectedStartContainer const): (WebCore::Range::protectedEndContainer const): (WebCore::Range::processContents): (WebCore::processContentsBetweenOffsets): (WebCore::processAncestorsAndTheirSiblings): (WebCore::Range::insertNode): (WebCore::Range::toString const): (WebCore::Range::createContextualFragment): (WebCore::Range::checkNodeOffsetPair): (WebCore::Range::cloneRange const): (WebCore::Range::setStartAfter): (WebCore::Range::setEndBefore): (WebCore::Range::setEndAfter): (WebCore::Range::selectNode): (WebCore::Range::surroundContents): (WebCore::Range::setStartBefore): (WebCore::Range::updateRangeForParentlessNodeMovedToNewDocument): (WebCore::boundaryTextNodesMerged): (WebCore::boundaryTextNodesSplit): (WebCore::Range::expand): (WebCore::Range::getClientRects const): (WebCore::Range::getBoundingClientRect const): (WebCore::setBothEndpoints): (WebCore::makeSimpleRange): (WebCore::createLiveRange): * Source/WebCore/dom/Range.h: * Source/WebCore/dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setToAfterNode): * Source/WebCore/dom/RawDataDocumentParser.h: * Source/WebCore/dom/RejectedPromiseTracker.cpp: (WebCore::RejectedPromiseTracker::reportUnhandledRejections): (WebCore::RejectedPromiseTracker::reportRejectionHandled): * Source/WebCore/dom/ScopedEventQueue.cpp: (WebCore::ScopedEventQueue::dispatchEvent const): * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::ref const): (WebCore::ScriptElement::deref const): (WebCore::ScriptElement::ref): Deleted. (WebCore::ScriptElement::deref): Deleted. * Source/WebCore/dom/ScriptElement.h: * Source/WebCore/dom/ScriptRunner.cpp: (WebCore::ScriptRunner::~ScriptRunner): (WebCore::ScriptRunner::queueScriptForExecution): (WebCore::ScriptRunner::resume): (WebCore::ScriptRunner::notifyFinished): (WebCore::ScriptRunner::timerFired): * Source/WebCore/dom/ScriptRunner.h: * Source/WebCore/dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::scriptsWaitingForStylesheetsExecutionTimerFired): * Source/WebCore/dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::registerCallback):
[webkit-changes] [WebKit/WebKit] c69c97: AX: details/summary not included in VoiceOver Form...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c69c97c046fd5b44688eb842e644ae3cb36c5bd2 https://github.com/WebKit/WebKit/commit/c69c97c046fd5b44688eb842e644ae3cb36c5bd2 Author: Tyler Wilcock Date: 2023-10-22 (Sun, 22 Oct 2023) Changed paths: A LayoutTests/accessibility/ios-simulator/activate-summary-expected.txt A LayoutTests/accessibility/ios-simulator/activate-summary.html A LayoutTests/accessibility/mac/search-predicate-summary-expected.txt A LayoutTests/accessibility/mac/search-predicate-summary.html M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm Log Message: --- AX: details/summary not included in VoiceOver Form Controls menu or list https://bugs.webkit.org/show_bug.cgi?id=263499 rdar://problem/117308226 Reviewed by Chris Fleizach. This is fixed on iOS by exposing summary text as a button (as pressing it toggles the containing details open state). On macOS, AXControlSearchKey is modified to include summary elements (consistent with the fact that we expose them as buttons prior to this patch). We also modify AccessibilityObject::supportsPressAction to help indicate their interacive state. This patch also fixes a bug on iOS where a details element with a user-agent default summary did not expand or collapse when activated via VoiceOver. * LayoutTests/accessibility/ios-simulator/activate-summary-expected.txt: Added. * LayoutTests/accessibility/ios-simulator/activate-summary.html: Added. * LayoutTests/accessibility/mac/search-predicate-summary-expected.txt: Added. * LayoutTests/accessibility/mac/search-predicate-summary.html: Added. * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::toggleDetailsAncestor): * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsPressAction const): (WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex): * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::toggleDetailsAncestor): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]): (-[WebAccessibilityObjectWrapper accessibilityTraits]): (-[WebAccessibilityObjectWrapper _accessibilityActivate]): Canonical link: https://commits.webkit.org/269643@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
