[webkit-changes] [WebKit/WebKit] 856754: Fix PlayStation builds following 277104@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 856754ff32bcf6d62a5dd7da95dac43aa3963c6b https://github.com/WebKit/WebKit/commit/856754ff32bcf6d62a5dd7da95dac43aa3963c6b Author: Ross Kirsling Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h Log Message: --- Fix PlayStation builds following 277104@main https://bugs.webkit.org/show_bug.cgi?id=272268 Unreviewed build fix. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: It is not valid to mark a method as WEBCORE_EXPORT when the class is already WEBCORE_EXPORT. Canonical link: https://commits.webkit.org/277153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eef029: Fix WinCairo Debug following 277140@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eef029ffac934bb421242c33a6d1ffa63272ba3c https://github.com/WebKit/WebKit/commit/eef029ffac934bb421242c33a6d1ffa63272ba3c Author: Ross Kirsling Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- Fix WinCairo Debug following 277140@main https://bugs.webkit.org/show_bug.cgi?id=272267 Unreviewed build fix. * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: (WebCore::getShaderLog): (WebCore::getProgramLog): Clarify usage of std::span. Canonical link: https://commits.webkit.org/277152@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac57d4: REGRESSION (275503@main): Double space in Mail com...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ac57d4f365e1de0dfe1e90fed2b22c67e10cdac8
https://github.com/WebKit/WebKit/commit/ac57d4f365e1de0dfe1e90fed2b22c67e10cdac8
Author: Wenson Hsieh
Date: 2024-04-05 (Fri, 05 Apr 2024)
Changed paths:
A
LayoutTests/editing/input/ios/autocorrection-replaces-space-with-period-expected.txt
A
LayoutTests/editing/input/ios/autocorrection-replaces-space-with-period.html
M Source/WebCore/editing/TextIterator.cpp
Log Message:
---
REGRESSION (275503@main): Double space in Mail compose on iOS doesn’t insert
period
https://bugs.webkit.org/show_bug.cgi?id=272237
rdar://125852636
Reviewed by Abrar Protyasha and Ryosuke Niwa.
With the changes in 275503@main, we now use `WebCore::findPlainText` to
discover the nearby text to
replace, in the case where the replacement range isn't just the last word.
While `findPlainText`
(and the underlying `SearchBuffer` machinery) is intended to ignore
non-breaking spaces for the
purposes of finding matches, this only works when `UCONFIG_NO_COLLATION` is
disabled; otherwise,
searching for the target text `" "` against a single non-breaking space
`"0xA0"` will fail to find
any matches.
This subsequently causes autocorrection replacement to fail, in the case where
UIKit tries to
replace a space after a sentence with a period, when the user inserts two space
characters in a row,
since we fail to match the non-breaking space character right after the word.
To fix this, we align the two find behaviors by moving the
`UCONFIG_NO_COLLATION`-specific logic to
handle `nbsp`:
```
inline void SearchBuffer::append(UChar c, bool isStart)
{
…
m_buffer[m_cursor] = c == noBreakSpace ? ' ' : foldQuoteMark(c);
}
```
...into `foldQuoteMark`, renaming that helper function to
`foldQuoteMarkAndReplaceNoBreakSpace`, and
finally deploying `foldQuoteMarkAndReplaceNoBreakSpace` in the
`!UCONFIG_NO_COLLATION` codepath as
well.
Test: editing/input/ios/autocorrection-replaces-space-with-period.html
*
LayoutTests/editing/input/ios/autocorrection-replaces-space-with-period-expected.txt:
Added.
* LayoutTests/editing/input/ios/autocorrection-replaces-space-with-period.html:
Added.
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::foldQuoteMarkAndReplaceNoBreakSpace):
(WebCore::SearchBuffer::append):
(WebCore::foldQuoteMark): Deleted.
Canonical link: https://commits.webkit.org/277151@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5c213: Some text fails to translate to Simplified Chinese...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5c2130755ab39b4b005c196eabaa05406f586ea https://github.com/WebKit/WebKit/commit/f5c2130755ab39b4b005c196eabaa05406f586ea Author: Ryosuke Niwa Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/editing/TextIterator.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm Log Message: --- Some text fails to translate to Simplified Chinese on Apple TV+ page https://bugs.webkit.org/show_bug.cgi?id=272214 Reviewed by Sihui Liu and Wenson Hsieh. The bug is caused by ParagraphContentIterator::advanceIteratorNodeAndUpdateText skipping a whitespace generated for a tab character that appears at where a line wraps. When the layout of the page changes slightly so that this tab character appears in the middle of a line, we don't skip the same whitespace. As a result, TextManipulationController erroneously conclude that the content has changed and reject the translation. Fixed the bug by tweaking TextIterator to generate a non-collapsed range in this specific case so that ParagraphContentIterator::advanceIteratorNodeAndUpdateText generates a whitespace as expected. We already had a code path for a space so reuse the same code path for other collapsible whitespaces. This PR also adds TextIterator::showTreeForThis and showTree(TextIterator&) / showTree(TextIterator*) to make debugging TextIterator easier. Tests: TextManipulation.CompleteTextManipulationDoesNotSkipTabCharacterAtLineWrap * Source/WebCore/editing/TextIterator.cpp: (WebCore::TextIterator::handleTextRun): (WebCore::TextIterator::showTreeForThis const): Added. (showTree): Added. * Source/WebCore/editing/TextIterator.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: (TextManipulation.CompleteTextManipulationDoesNotSkipTabCharacterAtLineWrap): Canonical link: https://commits.webkit.org/277150@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e936e6: Fix -Wformat warnings in CtapAuthenticator.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e936e6991f61148b6b911c66fbc8e65d67a1acc2 https://github.com/WebKit/WebKit/commit/e936e6991f61148b6b911c66fbc8e65d67a1acc2 Author: David Kilzer Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp Log Message: --- Fix -Wformat warnings in CtapAuthenticator.cpp https://bugs.webkit.org/show_bug.cgi?id=272262 Reviewed by Ryosuke Niwa. * Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: (WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived): (WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::tryRestartPin): - Add enumToUnderlyingType() when logging to fix warnings. Canonical link: https://commits.webkit.org/277149@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a538b9: LocalizableStrings.pm is executable, but not a script
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a538b93623879085d6c61df1adc9f9f6832f6bb5 https://github.com/WebKit/WebKit/commit/a538b93623879085d6c61df1adc9f9f6832f6bb5 Author: Elliott Williams Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/Scripts/LocalizableStrings.pm Log Message: --- LocalizableStrings.pm is executable, but not a script rdar://125993111 https://bugs.webkit.org/show_bug.cgi?id=272252 Reviewed by Alexey Proskuryakov. LocalizableStrings.pm does not have a perl shebang line, and even if it did, it doesn't do anything when run standalong. chmod -x the file to clarify its usage. With this change, all executable files in builds of macOS WebKit are either scripts or Mach-O binaries. * Source/WebCore/Scripts/LocalizableStrings.pm: Canonical link: https://commits.webkit.org/277148@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27a1ee: Use std::span more in StringImpl code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27a1ee5ab6deb23c6e618ab2756faccce741e9e2 https://github.com/WebKit/WebKit/commit/27a1ee5ab6deb23c6e618ab2756faccce741e9e2 Author: Chris Dumez Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/dfg/DFGLazyJSValue.cpp M Source/JavaScriptCore/runtime/IntlObject.cpp M Source/JavaScriptCore/runtime/JSStringJoiner.cpp M Source/JavaScriptCore/runtime/StringConstructor.cpp M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/WTF/wtf/HexNumber.h M Source/WTF/wtf/URLHelpers.cpp M Source/WTF/wtf/text/StringBuilder.cpp M Source/WTF/wtf/text/StringBuilderInternals.h M Source/WTF/wtf/text/StringCommon.cpp M Source/WTF/wtf/text/StringCommon.h M Source/WTF/wtf/text/StringConcatenate.h M Source/WTF/wtf/text/StringConcatenateNumbers.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/StringView.cpp M Source/WTF/wtf/text/StringView.h M Source/WTF/wtf/text/WTFString.cpp M Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp M Tools/TestWebKitAPI/Tests/WTF/StringCommon.cpp M Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp Log Message: --- Use std::span more in StringImpl code https://bugs.webkit.org/show_bug.cgi?id=272208 Reviewed by Darin Adler. * Source/JavaScriptCore/dfg/DFGLazyJSValue.cpp: (JSC::DFG::LazyJSValue::dumpInContext const): * Source/JavaScriptCore/runtime/IntlObject.cpp: (JSC::languageTagForLocaleID): (JSC::addScriptlessLocaleIfNeeded): (JSC::numberingSystemsForLocale): (JSC::intlAvailableCalendars): (JSC::intlAvailableTimeZones): * Source/JavaScriptCore/runtime/JSStringJoiner.cpp: (JSC::appendStringToData): * Source/JavaScriptCore/runtime/StringConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::jsSpliceSubstrings): * Source/WTF/wtf/HexNumber.h: (WTF::StringTypeAdapter::writeTo const): * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::escapeUnsafeCharacters): * Source/WTF/wtf/text/StringBuilder.cpp: (WTF::StringBuilder::appendCharacters): * Source/WTF/wtf/text/StringBuilderInternals.h: (WTF::StringBuilder::allocateBuffer): * Source/WTF/wtf/text/StringCommon.cpp: (WTF::find8NonASCIIAlignedImpl): (WTF::find16NonASCIIAlignedImpl): * Source/WTF/wtf/text/StringCommon.h: * Source/WTF/wtf/text/StringConcatenate.h: * Source/WTF/wtf/text/StringConcatenateNumbers.h: (WTF::FormattedNumber::span const): (WTF::StringTypeAdapter::writeTo const): (WTF::FormattedCSSNumber::span const): (WTF::StringTypeAdapter::writeTo const): * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::createInternal): (WTF::StringImpl::createStaticStringImpl): (WTF::StringImpl::create8BitIfPossible): (WTF::StringImpl::foldCase): (WTF::StringImpl::convertASCIICase): (WTF::StringImpl::replace): (WTF::StringImpl::utf8ForCharacters): (WTF::StringImpl::utf8ForCharactersIntoBuffer): (WTF::StringImpl::tryGetUTF8 const): * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::create8BitIfPossible): (WTF::StringImpl::createStaticStringImpl): (WTF::StringImpl::copyCharacters): (WTF::StringImpl::StringImpl): (WTF::StringImpl::removeCharactersImpl): (WTF::StringImpl::createByReplacingInCharacters): (WTF::StringImpl::tryGetUTF8 const): (WTF::StringImpl::tryGetUTF8ForCharacters): * Source/WTF/wtf/text/StringView.cpp: (WTF::StringView::tryGetUTF8 const): * Source/WTF/wtf/text/StringView.h: (WTF::StringView::getCharacters8 const): (WTF::StringView::getCharacters16 const): (WTF::StringView::UpconvertedCharactersWithSize::UpconvertedCharactersWithSize): (WTF::StringView::tryGetUTF8 const): * Source/WTF/wtf/text/WTFString.cpp: (WTF::String::make8Bit): (WTF::String::convertTo16Bit): * Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp: (WTF::uTextLatin1Access): (WTF::uTextLatin1Extract): (WTF::textLatin1ContextAwareMoveInPrimaryContext): * Tools/TestWebKitAPI/Tests/WTF/StringCommon.cpp: (TestWebKitAPI::TEST(WTF_StringCommon, Find8NonASCII)): (TestWebKitAPI::TEST(WTF_StringCommon, Find16NonASCII)): * Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST(WTF, DynamicStaticStringImpl)): Canonical link: https://commits.webkit.org/277147@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f13b4f: [WebGPU] rename writeBuffer which takes a non-cons...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f13b4f7f2205531e7c68e4e03d854ae82acf43a6 https://github.com/WebKit/WebKit/commit/f13b4f7f2205531e7c68e4e03d854ae82acf43a6 Author: Mike Wyrzykowski Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h Log Message: --- [WebGPU] rename writeBuffer which takes a non-const data to writeBufferNoCopy https://bugs.webkit.org/show_bug.cgi?id=272160 Reviewed by Chris Dumez. We shouldn’t have overloaded a method on the constness of a pointer, that is fragile, just give it a different name. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp: (WebCore::WebGPU::QueueImpl::writeBufferNoCopy): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp: (WebKit::RemoteQueue::writeBuffer): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp: (WebKit::WebGPU::RemoteQueueProxy::writeBufferNoCopy): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h: Canonical link: https://commits.webkit.org/277146@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fff0ad: REGRESSION(276009@main) NSRangeException thrown fr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fff0ad4731a7aa82055ab033829f8e13cc09f3eb https://github.com/WebKit/WebKit/commit/fff0ad4731a7aa82055ab033829f8e13cc09f3eb Author: Jer Noble Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/UIProcess/ApplicationStateTracker.mm Log Message: --- REGRESSION(276009@main) NSRangeException thrown from -[WKUIWindowSceneObserver setObservedWindow:] https://bugs.webkit.org/show_bug.cgi?id=272250 rdar://125653988 Reviewed by Eric Carlson. Crashlogs say this NSRangeException is thrown when trying to call -removeObserver:withKeyPath: on _window, with the error message saying the caller is not registered as an observer in the first place. To be absolutely sure that we aren't accidentally messaging nil when registering ourselves as an observer, store both the new window and old window in RetainPtrs. There doesn't appear to be a code path by which we can accidentally un-register twice, but just in case, wrap the call to -removeObserver:withKeyPath: in a @try/@catch block. * Source/WebKit/UIProcess/ApplicationStateTracker.mm: (-[WKUIWindowSceneObserver setObservedWindow:]): Canonical link: https://commits.webkit.org/277145@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 16e130: [RenderTreeBuilder][Cleanup] detachFromRenderEleme...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 16e1300785215bc82cc0b0f52bc35690589e3e2e
https://github.com/WebKit/WebKit/commit/16e1300785215bc82cc0b0f52bc35690589e3e2e
Author: Alan Baradlay
Date: 2024-04-05 (Fri, 05 Apr 2024)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
Log Message:
---
[RenderTreeBuilder][Cleanup] detachFromRenderElement keeps checking
renderTreeBeingDestroyed
https://bugs.webkit.org/show_bug.cgi?id=272229
Reviewed by Antti Koivisto.
1. Early return on renderTreeBeingDestroyed
- detachRendererInternal is the only function we need to call
2. Most of the reset/invalidate functions only ever apply when everHadLayout is
true
- group them under a new static function "resetRendererState"
{
if (parent.renderTreeBeingDestroyed())
return parent.detachRendererInternal(child);
if (child.everHadLayout())
resetRendererState();
rest of must-cleanup functions
}
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererState):
(WebCore::RenderTreeBuilder::detachFromRenderElement):
Canonical link: https://commits.webkit.org/277144@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b97e64: Don't initialize mach exceptions if we didn't regi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b97e643c5d3420737a797a79a277add465ea5fa1 https://github.com/WebKit/WebKit/commit/b97e643c5d3420737a797a79a277add465ea5fa1 Author: Keith Miller Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WTF/wtf/threads/Signals.cpp Log Message: --- Don't initialize mach exceptions if we didn't register any. https://bugs.webkit.org/show_bug.cgi?id=272261 rdar://126000755 Reviewed by Justin Michaud. This also fixes GPU process crashing on launch because the sandbox doesn't allow `task_register_hardened_exception_handler`. * Source/WTF/wtf/threads/Signals.cpp: (WTF::initMachExceptionHandlerThread): Canonical link: https://commits.webkit.org/277143@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4bb406: When exiting from pip to in-window fullscreen, the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4bb40628005815ca00ec87a46f102053546abd3f https://github.com/WebKit/WebKit/commit/4bb40628005815ca00ec87a46f102053546abd3f Author: Dana Estra Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.mm Log Message: --- When exiting from pip to in-window fullscreen, the video content becomes small https://bugs.webkit.org/show_bug.cgi?id=272108 rdar://123112852 Reviewed by Jer Noble. When exiting from pip to in-window mode, we now call exitVideoFullscreenForVideoElement instead of exitToFullscreenModeWithoutAnimationIfPossible because the lack of animation was likely causing ref counting issues. VideoPresentationManagerMac's mode is also now updated when we enter or exit in-window, so that when entering in-window, then pip, then exiting pip, the class will remember that the new mode should be in-window. Lastly, in didCleanupFullscreen, the new fullscreen mode should only be set to inline and removeclientForContext should only be called if we are exiting from pip to inline and not when we are exiting to in-window. When we call removeclientForContext, we lose the VideoPresentationManager, which is needed to correctly size the video content in fullscreen. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willBecomeFullscreenElement): * Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h: * Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm: (WebCore::VideoPresentationInterfaceMac::setupFullscreen): (WebCore::VideoPresentationInterfaceMac::enterFullscreen): * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in: * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: (WebKit::VideoPresentationManagerProxy::setVideoFullscreenMode): (WebKit::VideoPresentationManagerProxy::clearVideoFullscreenMode): (WebKit::VideoPresentationManagerProxy::didCleanupFullscreen): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setVideoFullscreenMode): (WebKit::WebChromeClient::clearVideoFullscreenMode): (WebKit::WebChromeClient::enterFullScreenForElement): (WebKit::WebChromeClient::exitFullScreenForElement): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h: * Source/WebKit/WebProcess/cocoa/VideoPresentationManager.mm: (WebKit::VideoPresentationManager::setVideoFullscreenMode): (WebKit::VideoPresentationManager::clearVideoFullscreenMode): (WebKit::VideoPresentationManager::didCleanupFullscreen): Canonical link: https://commits.webkit.org/277142@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e63aaa: [iOS 17.5 beta] Crash in WebKit::ExtensionCapabili...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e63aaa4c4c289b80bfa5d86e128a11fa22dc3963 https://github.com/WebKit/WebKit/commit/e63aaa4c4c289b80bfa5d86e128a11fa22dc3963 Author: Per Arne Vollan Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm Log Message: --- [iOS 17.5 beta] Crash in WebKit::ExtensionCapabilityGrant::operator= https://bugs.webkit.org/show_bug.cgi?id=272170 rdar://125984025 Reviewed by Sihui Liu. We need to invalidate the grant before deallocating it. * Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h: * Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm: (WebKit::ExtensionCapabilityGrant::operator=): Canonical link: https://commits.webkit.org/277141@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a52537: Drop CString constructors taking in a raw pointer ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a52537d513b7157f10fc5d1b9a6f9dde3053e038 https://github.com/WebKit/WebKit/commit/a52537d513b7157f10fc5d1b9a6f9dde3053e038 Author: Chris Dumez Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/API/ObjcRuntimeExtras.h M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp M Source/JavaScriptCore/runtime/IntlLocale.cpp M Source/WTF/wtf/StringHashDumpContext.h M Source/WTF/wtf/StringPrintStream.cpp M Source/WTF/wtf/cf/FileSystemCF.cpp M Source/WTF/wtf/cocoa/NSURLExtras.mm M Source/WTF/wtf/glib/FileSystemGlib.cpp M Source/WTF/wtf/text/CString.cpp M Source/WTF/wtf/text/CString.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringView.cpp M Source/WTF/wtf/text/WTFString.cpp M Source/WebCore/Modules/webtransport/WebTransport.cpp M Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp M Tools/TestWebKitAPI/Tests/WTF/CString.cpp M Tools/TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitNetworkSession.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp Log Message: --- Drop CString constructors taking in a raw pointer and a length https://bugs.webkit.org/show_bug.cgi?id=272179 Reviewed by Darin Adler. Drop CString constructors taking in a raw pointer and a length, in favor of the ones taking in a std::span. * Source/JavaScriptCore/API/ObjcRuntimeExtras.h: (StringRange::StringRange): * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::inferredName const): * Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp: (JSC::UnlinkedSourceCode::toUTF8 const): * Source/JavaScriptCore/runtime/IntlLocale.cpp: (JSC::LocaleIDBuilder::toCanonical): * Source/WTF/wtf/StringHashDumpContext.h: (WTF::StringHashDumpContext::getID): * Source/WTF/wtf/StringPrintStream.cpp: (WTF::StringPrintStream::toCString): * Source/WTF/wtf/cf/FileSystemCF.cpp: (WTF::FileSystem::fileSystemRepresentation): * Source/WTF/wtf/cocoa/NSURLExtras.mm: (WTF::userVisibleString): * Source/WTF/wtf/text/CString.cpp: (WTF::CString::CString): (WTF::CString::init): * Source/WTF/wtf/text/CString.h: * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::utf8ForCharacters): * Source/WTF/wtf/text/StringView.cpp: (WTF::StringView::tryGetUTF8 const): * Source/WTF/wtf/text/WTFString.cpp: (WTF::String::latin1 const): (WTF::String::tryGetUTF8 const): * Source/WebCore/Modules/webtransport/WebTransport.cpp: (WebCore::trimToValidUTF8Length1024): * Tools/TestWebKitAPI/Tests/WTF/CString.cpp: (TEST(WTF, CStringNullStringConstructor)): (TEST(WTF, CStringEmptyEmptyConstructor)): (TEST(WTF, CStringEmptyRegularConstructor)): (TEST(WTF, CStringZeroTerminated)): * Tools/TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: (TestWebKitAPI::TEST(CBORWriterTest, TestWriteUint)): (TestWebKitAPI::TEST(CBORWriterTest, TestWriteNegativeInteger)): Canonical link: https://commits.webkit.org/277140@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6e0ae: Remove WebSQLiteDatabaseTracker from WebProcess
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6e0ae60f2db0189c8b8f8c1060264411a26edd1 https://github.com/WebKit/WebKit/commit/a6e0ae60f2db0189c8b8f8c1060264411a26edd1 Author: Sihui Liu Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebProcessProxy.messages.in M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- Remove WebSQLiteDatabaseTracker from WebProcess https://bugs.webkit.org/show_bug.cgi?id=272163 rdar://125915741 Reviewed by Per Arne Vollan. With AppCache removed, web process should no longer create SQLiteDatabaseTransaction. * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::setIsHoldingLockedFiles): Deleted. * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.messages.in: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::m_nonVisibleProcessMemoryCleanupTimer): (WebKit::WebProcess::prepareToSuspend): (WebKit::WebProcess::processDidResume): (WebKit::m_webSQLiteDatabaseTracker): Deleted. * Source/WebKit/WebProcess/WebProcess.h: Canonical link: https://commits.webkit.org/277139@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59d90a: : clip entities on the page z level
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59d90a1043ebf2c49399cc1421ed06b5e729cc7b https://github.com/WebKit/WebKit/commit/59d90a1043ebf2c49399cc1421ed06b5e729cc7b Author: Aleksei Marchenko Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm Log Message: --- : clip entities on the page z level rdar://12518 https://bugs.webkit.org/show_bug.cgi?id=272183 Reviewed by Tim Horton. Initial implementation of clipping on +Z direction should use PortalComponent's ClippingPlane but it is blocked by rdar://123516357. Current implementation uses a workaround based on ClippingPrimitive. Bounding box of the primitive is an arbitrary number that is big enoungh for the model representation. * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm: (WebKit::ModelProcessModelPlayerProxy::didFinishLoading): Canonical link: https://commits.webkit.org/277138@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0e6b6: Remove leftover EnumTraits includes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0e6b6f7b1f79a9080998ed27c9a201c2824080a https://github.com/WebKit/WebKit/commit/a0e6b6f7b1f79a9080998ed27c9a201c2824080a Author: Claudio Saavedra Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUFeatureName.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPowerPreference.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPredefinedColorSpace.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureAspect.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureFormat.h M Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h M Source/WebCore/Modules/contact-picker/ContactProperty.h M Source/WebCore/Modules/cookie-consent/CookieConsentDecisionResult.h M Source/WebCore/Modules/indexeddb/IDBTransactionDurability.h M Source/WebCore/Modules/indexeddb/IDBTransactionMode.h M Source/WebCore/Modules/indexeddb/IndexedDB.h M Source/WebCore/Modules/indexeddb/shared/IDBGetRecordData.h M Source/WebCore/Modules/indexeddb/shared/IDBResultData.h M Source/WebCore/Modules/mediastream/RTCErrorDetailType.h M Source/WebCore/Modules/notifications/NotificationEventType.h M Source/WebCore/Modules/permissions/PermissionName.h M Source/WebCore/Modules/permissions/PermissionQuerySource.h M Source/WebCore/Modules/permissions/PermissionState.h M Source/WebCore/Modules/push-api/PushPermissionState.h M Source/WebCore/Modules/reporting/ViolationReportType.h M Source/WebCore/Modules/speech/SpeechRecognitionUpdate.h M Source/WebCore/dom/ExceptionCode.h M Source/WebCore/dom/SecurityPolicyViolationEventDisposition.h M Source/WebCore/dom/ViewportArguments.cpp M Source/WebCore/editing/CompositionUnderline.h M Source/WebCore/editing/TextManipulationController.h M Source/WebCore/html/Autofill.h M Source/WebCore/html/DataListSuggestionInformation.h M Source/WebCore/html/EnterKeyHint.h M Source/WebCore/html/LinkIconType.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/loader/LoadSchedulingMode.h M Source/WebCore/loader/ResourceLoaderOptions.h M Source/WebCore/loader/cache/TrustedFonts.h M Source/WebCore/page/DragActions.h M Source/WebCore/page/MediaProducer.h M Source/WebCore/page/ScreenOrientationLockType.h M Source/WebCore/page/ScreenOrientationType.h M Source/WebCore/page/SecurityOrigin.h M Source/WebCore/page/StorageBlockingPolicy.h M Source/WebCore/page/TextIndicator.h M Source/WebCore/page/TranslationContextMenuInfo.h M Source/WebCore/platform/Cursor.h M Source/WebCore/platform/FileChooser.h M Source/WebCore/platform/MediaSample.h M Source/WebCore/platform/PlatformScreen.h M Source/WebCore/platform/PopupMenuStyle.h M Source/WebCore/platform/ScreenProperties.h M Source/WebCore/platform/ScrollTypes.h M Source/WebCore/platform/UserInterfaceLayoutDirection.h M Source/WebCore/platform/audio/AudioSession.h M Source/WebCore/platform/graphics/ColorSpace.h M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h M Source/WebCore/platform/graphics/GraphicsTypes.h M Source/WebCore/platform/graphics/ImageOrientation.h M Source/WebCore/platform/graphics/PixelFormat.h M Source/WebCore/platform/graphics/PlatformColorSpace.h M Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/filters/FilterOperation.h M Source/WebCore/platform/graphics/transforms/TransformOperation.h M Source/WebCore/platform/mediastream/MediaConstraints.h M Source/WebCore/platform/network/ResourceErrorBase.h M Source/WebCore/platform/text/TextChecking.h M Source/WebCore/platform/text/TextFlags.h M Source/WebCore/plugins/PluginData.h M Source/WebCore/rendering/style/StyleSelfAlignmentData.h M Source/WebCore/storage/StorageType.h M Source/WebCore/style/StyleAppearance.h M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp M Source/WebKit/NetworkProcess/NetworkLoadParameters.h M Source/WebKit/Shared/ContextMenuContextData.h M Source/WebKit/Shared/DrawingAreaInfo.h M Source/WebKit/Shared/EditingRange.h M Source/WebKit/Shared/PrintInfo.h M Source/WebKit/Shared/SessionState.h M Source/WebKit/Shared/WebEvent.h M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/Shared/WebPopupItem.h M Source/WebKit/Shared/WebWheelEvent.h M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h M Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h Log Message: --- Remove leftover EnumTraits includes https://bugs.webkit.org/show_bug.cgi?id=272221 Reviewed
[webkit-changes] [WebKit/WebKit] b3ecee: Clean up Signals and remove hardened fallback
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3eceeb22f58375c3ae39ccdc376335e417881fe https://github.com/WebKit/WebKit/commit/b3eceeb22f58375c3ae39ccdc376335e417881fe Author: Keith Miller Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/JSCConfig.cpp M Source/JavaScriptCore/runtime/JSCConfig.h M Source/JavaScriptCore/runtime/VM.cpp M Source/JavaScriptCore/runtime/VMEntryScope.cpp M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/WTFConfig.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- Clean up Signals and remove hardened fallback https://bugs.webkit.org/show_bug.cgi?id=271766 rdar://125256111 Reviewed by Justin Michaud. This change does a couple of things: 1) Refactor the signal handler API after https://commits.webkit.org/276579@main which had mach exception users pass the mask of exceptions they would ever want to handle at initialization time (before they register their handler). Instead the new signal handler API registers our handlers with the kernel at finalization time. At which point we have a list of every exception handler added. 2) Remove the finalizeSignalHandlers function and finalize signal handlers when WTF::Config finalizes. 3) Remove disableSignalHandling function as it never really worked (signals could still get registered before we called disable) and we mostly rely on the sandbox to block signals in lockdown mode. 3) Rename SignalHandlers::InitState entries to better reflect the new design and use it for all configurations not just mach ports. 4) Remove the fallback we added to https://commits.webkit.org/276579@main as a stopgap for internal folks running on old sandboxes. 5) Remove `isX86BinaryRunningOnARM()` check since that didn't seem to work anyway. We'll probably have to remove signal handling under Rosetta as I couldn't get it to work. 6) Save the secret key for our hardened handler in Signals.cpp before finalization and only let API users see it via presignReturnPCForHandler so they can't accidentally save it somewhere an attacker could see later. We also carefully zero it at finalization time after passing it to the kernel via `task_register_hardened_exception_handler`. 7) Move disabledFreezingForTesting to WTF::Config since that's the config that actually does the freezing not JSC::Config. This allows WTF::Config to control finalizing signal handlers. 8) Remove some cases from com.apple.WebKit.WebContent.sb.in to simplify the profile slightly. We don't need to guard the `(require-not (webcontent-process-launched))` check on `ENABLE(BLOCK_SET_EXCEPTION_PORTS)` because we have `webcontent-process-launched` anywhere we `HAVE(HARDENED_MACH_EXCEPTIONS)` anyway. * Source/JavaScriptCore/jsc.cpp: (main): (CommandLine::parseArguments): * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): * Source/JavaScriptCore/runtime/JSCConfig.cpp: (JSC::Config::disableFreezingForTesting): Deleted. * Source/JavaScriptCore/runtime/JSCConfig.h: (JSC::Config::disableFreezingForTesting): (JSC::Config::finalize): (JSC::Config::permanentlyFreeze): Deleted. * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::VM): * Source/JavaScriptCore/runtime/VMEntryScope.cpp: (JSC::VMEntryScope::setUpSlow): * Source/JavaScriptCore/runtime/VMTraps.cpp: * Source/JavaScriptCore/tools/JSDollarVM.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION_WITH_ATTRIBUTES): * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): (JSC::Wasm::activateSignalingMemory): (JSC::Wasm::prepareSignalingMemory): (JSC::Wasm::MachExceptionSigningKey::MachExceptionSigningKey): Deleted. * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h: * Source/WTF/wtf/PlatformRegisters.cpp: (WTF::threadStatePCInternal): * Source/WTF/wtf/Threading.cpp: (WTF::initialize): * Source/WTF/wtf/WTFConfig.cpp: (WTF::Config::initialize): (WTF::Config::finalize): (WTF::Config::permanentlyFreeze): (WTF::Config::disableFreezingForTesting): * Source/WTF/wtf/WTFConfig.h: * Source/WTF/wtf/threads/Signals.cpp: (WTF::SignalHandlers::add): (WTF::SignalHandlers::presignReturnPCForHandler): (WTF::initMachExceptionHandlerThread): (WTF::toMachMask): (WTF::setExceptionPorts):
[webkit-changes] [WebKit/WebKit] 0713e3: [WebGPU] 2D texture copy fails in Queue::writeText...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0713e3ecf5083d5704b742da50db3c7537be8f6f https://github.com/WebKit/WebKit/commit/0713e3ecf5083d5704b742da50db3c7537be8f6f Author: Mike Wyrzykowski Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/Queue.mm M Source/WebGPU/WebGPU/ShaderModule.mm Log Message: --- [WebGPU] 2D texture copy fails in Queue::writeTexture when sourceBytesPerRow is not a multiple of 16 bytes https://bugs.webkit.org/show_bug.cgi?id=272209 Reviewed by Tadeu Zagallo. Ensure compressed texture copies are a multiple of their block size. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/277135@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75713d: [JSC] (Re-land) Add aligned label annotation to of...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75713dba17877b118b2203af2d8b7a44cb3c17c5 https://github.com/WebKit/WebKit/commit/75713dba17877b118b2203af2d8b7a44cb3c17c5 Author: Justin Michaud Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/llint/InPlaceInterpreter.h M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp M Source/JavaScriptCore/offlineasm/asm.rb M Source/JavaScriptCore/offlineasm/ast.rb M Source/JavaScriptCore/offlineasm/backends.rb M Source/JavaScriptCore/offlineasm/parser.rb M Source/JavaScriptCore/offlineasm/transform.rb Log Message: --- [JSC] (Re-land) Add aligned label annotation to offlineasm https://bugs.webkit.org/show_bug.cgi?id=270699 rdar://113594783 Reviewed by Mark Lam. Original patch by Max Rottenkolber. In https://commits.webkit.org/276085@main, we tried to add a new aligned label directive to offlineasm to make padding more deterministic. This broke some Apple builds because of LTO. This patch makes sure these labels are referenced from cpp to stop the linker from removing them. * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/llint/InPlaceInterpreter.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: * Source/JavaScriptCore/offlineasm/asm.rb: * Source/JavaScriptCore/offlineasm/ast.rb: * Source/JavaScriptCore/offlineasm/backends.rb: * Source/JavaScriptCore/offlineasm/parser.rb: * Source/JavaScriptCore/offlineasm/transform.rb: Canonical link: https://commits.webkit.org/277134@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9da729: [UnifiedPDF] Selection needs to keep tracking the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9da7290f216c59af48811f6a5e3fad3d468dfbb8 https://github.com/WebKit/WebKit/commit/9da7290f216c59af48811f6a5e3fad3d468dfbb8 Author: Abrar Rahman Protyasha Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Selection needs to keep tracking the mouse when it's dragged outside of the page area https://bugs.webkit.org/show_bug.cgi?id=269012 rdar://122574603 Reviewed by Darin Adler. Our selection tracking logic was robust to mouse events outside of the page area, but we were limited by shortcutting out of our mouse event handling logic if the received event was not on the page area. This patch follows the fixes in 276852@main and adopts PDFDocumentLayout::nearestPageIndexForDocumentPoint to determine which is the actionable page for a mouse event. This way we don't early return from our mouse event handling logic if the event is not on the page area, and our selection tracking can keep track even when dragged outside of the page area. Finally, we make a small refactor in handleMouseEvent to call stopTrackingSelection as appropriate whenever we leave the method. This is necessitated by the fact that we may _want_ to clear selection tracking state, but we return early in certain display modes. This is explained in the inline comment. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleMouseEvent): Canonical link: https://commits.webkit.org/277133@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6fca68: Unreviewed, reverting 277077@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6fca68b815503bfa21b26bd165b7ebbe2203b878 https://github.com/WebKit/WebKit/commit/6fca68b815503bfa21b26bd165b7ebbe2203b878 Author: Commit Queue Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Scripts/process-entitlements.sh M Source/WebKit/Shared/Sandbox/common.sb M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Unreviewed, reverting 277077@main. https://bugs.webkit.org/show_bug.cgi?id=272242 Introduced memory regression Reverted changeset: "Block notification service in sandbox" https://bugs.webkit.org/show_bug.cgi?id=270805 https://commits.webkit.org/277077@main Canonical link: https://commits.webkit.org/277132@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca7602: Speculative improvements for rdar://125652518
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca760255d2d5e4dffe3e11b5b342e58dc28e1d4b https://github.com/WebKit/WebKit/commit/ca760255d2d5e4dffe3e11b5b342e58dc28e1d4b Author: Brady Eidson Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.mm Log Message: --- Speculative improvements for rdar://125652518 rdar://125652518 https://bugs.webkit.org/show_bug.cgi?id=272201 Reviewed by Per Arne Vollan and Ryosuke Niwa. While we continue to explore this crash tracer (while deserializing a postMessage to a script message handler), I spotted some room for improvements. * Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: (API::SharedJSContext::ensureContext): (API::sharedContext): (API::SerializedScriptValue::deserialize): (API::coreValueFromNSObject): * Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.mm: Canonical link: https://commits.webkit.org/277131@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a51f73: Add support for text indicator style for mac.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a51f73ee57a3561098c4a7b3ab43ca432f48e44d https://github.com/WebKit/WebKit/commit/a51f73ee57a3561098c4a7b3ab43ca432f48e44d Author: Megan Gardner Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm A Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h A Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Add support for text indicator style for mac. https://bugs.webkit.org/show_bug.cgi?id=272203 rdar://123134304 Reviewed by Wenson Hsieh. Add support for text indicator style for mac. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _removeTextIndicatorStyleForID:]): * Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h: Added. * Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm: Added. * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::addTextIndicatorStyleForID): (WebKit::WebViewImpl::removeTextIndicatorStyleForID): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/277130@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d55a9c: [Navigation] Detect hasUAVisualTransition for Navi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d55a9c43bd6e450433aef6841e21b532c1c5db4b https://github.com/WebKit/WebKit/commit/d55a9c43bd6e450433aef6841e21b532c1c5db4b Author: Rob Buis Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: A LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition-expected.txt A LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition.html M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Detect hasUAVisualTransition for NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=272019 Reviewed by Simon Fraser. Detect hasUAVisualTransition for NavigateEvent as specified: https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigate-event-firing:dom-navigateevent-hasuavisualtransition * LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition-expected.txt: Added. * LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition.html: Added. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/277129@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 12e8d8: Remove ENABLE(APPLICATION_MANIFEST) in Cocoa files
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12e8d81bdb136f756804970da4fa1318136bd423 https://github.com/WebKit/WebKit/commit/12e8d81bdb136f756804970da4fa1318136bd423 Author: Sihui Liu Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/Shared/Cocoa/APIObject.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifestInternal.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm Log Message: --- Remove ENABLE(APPLICATION_MANIFEST) in Cocoa files https://bugs.webkit.org/show_bug.cgi?id=272166 rdar://125916173 Reviewed by Per Arne Vollan. ENABLE_APPLICATION_MANIFEST is true on Cocoa platforms. * Source/WebKit/Shared/Cocoa/APIObject.mm: (API::Object::newObject): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _getApplicationManifestWithCompletionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifestInternal.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Canonical link: https://commits.webkit.org/277128@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce5859: (3) Adopt com.apple.developer.cs.allow-jit entitle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce585987e8f9925db07f95dd06cc7ffa78e7dbfa https://github.com/WebKit/WebKit/commit/ce585987e8f9925db07f95dd06cc7ffa78e7dbfa Author: Justin Michaud Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- (3) Adopt com.apple.developer.cs.allow-jit entitlement for iOS. https://bugs.webkit.org/show_bug.cgi?id=270723 rdar://122841355 Reviewed by Yusuke Suzuki. * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::isJITEnabled): (JSC::ExecutableAllocator::disableJIT): * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/277127@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad45bd: REGRESSION (277067@main): LLINT CLoop build failin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad45bd40d99adfc82e0147c1e2cc45d2a5ce52dd https://github.com/WebKit/WebKit/commit/ad45bd40d99adfc82e0147c1e2cc45d2a5ce52dd Author: Yusuke Suzuki Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- REGRESSION (277067@main): LLINT CLoop build failing JavaScriptCore/jsc.cpp:3515:9: error: unknown type name 'CommaPrinter' https://bugs.webkit.org/show_bug.cgi?id=272234 rdar://125972736 Reviewed by Mark Lam. Just include CommaPrinter.h * Source/JavaScriptCore/jsc.cpp: Canonical link: https://commits.webkit.org/277126@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc794e: Add stub for new jit-less js->wasm entrypoint
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc794ece05e682e4fe156bdea696620bc3727261 https://github.com/WebKit/WebKit/commit/dc794ece05e682e4fe156bdea696620bc3727261 Author: Justin Michaud Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/assembler/JITOperationList.cpp M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/jit/RegisterSet.cpp M Source/JavaScriptCore/llint/InPlaceInterpreter.h M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp M Source/JavaScriptCore/llint/LLIntSlowPaths.h M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/llint/WebAssembly.asm M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/JSCPtrTag.h M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmBBQPlan.h M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp M Source/JavaScriptCore/wasm/WasmCalleeGroup.h M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp M Source/JavaScriptCore/wasm/WasmIPIntPlan.h M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmLLIntPlan.h M Source/bmalloc/bmalloc/Gigacage.h Log Message: --- Add stub for new jit-less js->wasm entrypoint https://bugs.webkit.org/show_bug.cgi?id=272176 rdar://125923445 Reviewed by Mark Lam and Yusuke Suzuki. A subsequent patch will fill this out with a new jit-less js->wasm stub, but this patch handles all of the mechanical bits. This is split out because this patch was causing some linker issues, so this will make it easier to isolate any fallout from landing. * Source/JavaScriptCore/assembler/CPU.h: (JSC::isJSValue3264): * Source/JavaScriptCore/assembler/JITOperationList.cpp: (JSC::llintOperations): * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/jit/RegisterSet.cpp: (JSC::RegisterSetBuilder::wasmPinnedRegisters): * Source/JavaScriptCore/llint/InPlaceInterpreter.h: * Source/JavaScriptCore/llint/LLIntSlowPaths.cpp: (JSC::LLInt::logWasmPrologue): * Source/JavaScriptCore/llint/LLIntSlowPaths.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): * Source/JavaScriptCore/runtime/JSCPtrTag.h: * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::initializeCallees): * Source/JavaScriptCore/wasm/WasmBBQPlan.h: * Source/JavaScriptCore/wasm/WasmCallee.cpp: * Source/JavaScriptCore/wasm/WasmCallee.h: * Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp: (JSC::Wasm::CalleeGroup::CalleeGroup): * Source/JavaScriptCore/wasm/WasmCalleeGroup.h: * Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp: (JSC::Wasm::IPIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmIPIntPlan.h: * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmLLIntPlan.h: * Source/bmalloc/bmalloc/Gigacage.h: (Gigacage::maxSize): (Gigacage::mask): Canonical link: https://commits.webkit.org/277125@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 524779: [JSC] Enable wasm fast-memory on iOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5247798c3d0e528e13aa722328f63a74ce2d3d4d https://github.com/WebKit/WebKit/commit/5247798c3d0e528e13aa722328f63a74ce2d3d4d Author: Yusuke Suzuki Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Enable wasm fast-memory on iOS https://bugs.webkit.org/show_bug.cgi?id=272232 rdar://125971299 Reviewed by Mark Lam. Now, primitive gigacage on iOS is 16GB. We can use some of fast-memory. Since we increased macOS primitive Gigacage from 32GB to 64GB, we also increase maxNumWebAssemblyFastMemories for macOS too. * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/277124@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44f96c: [WebAuthn] Registrations do not return transports
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44f96cd7af27e9fa00a75f04def262e4b4173af2 https://github.com/WebKit/WebKit/commit/44f96cd7af27e9fa00a75f04def262e4b4173af2 Author: Pascoe Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h M Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Registrations do not return transports https://bugs.webkit.org/show_bug.cgi?id=272116 rdar://125794592 Reviewed by Brent Fulgham. This value is not currently passed along in the modern flow. This patch fixes that. * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::convertStringToAuthenticatorTransport): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h: * Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp: (fido::convertStringToAuthenticatorTransport): Deleted. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h: * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::toTransports): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Canonical link: https://commits.webkit.org/277123@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 267ba5: [resultsdbpy] Fix commit ranges on dashboard
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 267ba50c98e879439d9e144ac1732f66d089622b https://github.com/WebKit/WebKit/commit/267ba50c98e879439d9e144ac1732f66d089622b Author: Jonathan Bedard Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js Log Message: --- [resultsdbpy] Fix commit ranges on dashboard https://bugs.webkit.org/show_bug.cgi?id=272111 rdar://125865304 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js: (Dashboard.prototype.setTilesFromData): Compare commits in range to UUID of last passing build instead of assuming the CommitBank will return a set of commits in a certain order. Canonical link: https://commits.webkit.org/277122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e93212: [WebGPU] CommandEncoder::clearBuffer fails validat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e93212620ad599d9681472961dbec3d07a4af461 https://github.com/WebKit/WebKit/commit/e93212620ad599d9681472961dbec3d07a4af461 Author: Mike Wyrzykowski Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.mm Log Message: --- [WebGPU] CommandEncoder::clearBuffer fails validation for destroyed buffer which is then unmapped https://bugs.webkit.org/show_bug.cgi?id=272211 Reviewed by Tadeu Zagallo. It does not appear the specificaion prevents a destroyed buffer from becoming unmapped and effectively non-destroyed, though it probably should. However in that case we don't fail validation and then Metal validation fails on the fillBuffer call, so guard against that. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::clearBuffer): Canonical link: https://commits.webkit.org/277121@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 014fab: Remove web process allowsFirstPartyForCookies book...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 014fab98ddc9e3e7f3024fd2daa8418a4bc68d38 https://github.com/WebKit/WebKit/commit/014fab98ddc9e3e7f3024fd2daa8418a4bc68d38 Author: Charlie Wolfe Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp M Source/WebKit/Shared/AuxiliaryProcess.cpp M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h M Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in Log Message: --- Remove web process allowsFirstPartyForCookies bookkeeping https://bugs.webkit.org/show_bug.cgi?id=272205 rdar://125906639 Reviewed by Alex Christensen. It was added for logging, but it hasn’t been very useful. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::addAllowedFirstPartyForCookies): Deleted. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): (WebKit::NetworkProcess::allowsFirstPartyForCookies): * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::handleProvisionalLoadFailureFromContentFilter): * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::addAllowedFirstPartyForCookies): * Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp: (WebKit::WebSharedWorkerServerToContextConnection::launchSharedWorker): * Source/WebKit/Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::allowsFirstPartyForCookies): Deleted. * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess): (WebKit::WebProcessPool::processForNavigation): (WebKit::WebProcessPool::prepareProcessForNavigation): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::addAllowedFirstPartyForCookies): Deleted. * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp: (WebKit::NetworkProcessConnection::addAllowedFirstPartyForCookies): Deleted. * Source/WebKit/WebProcess/Network/NetworkProcessConnection.h: * Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in: * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadAlternateHTML): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::addAllowedFirstPartyForCookies): Deleted. (WebKit::WebProcess::allowsFirstPartyForCookies): Deleted. * Source/WebKit/WebProcess/WebProcess.h: * Source/WebKit/WebProcess/WebProcess.messages.in: Canonical link: https://commits.webkit.org/277120@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb693b: [results.webkit.org] Link directly to SCM provider...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb693b0ca39e21aa29f5d359fa4380c3a235d2de https://github.com/WebKit/WebKit/commit/eb693b0ca39e21aa29f5d359fa4380c3a235d2de Author: Jonathan Bedard Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js Log Message: --- [results.webkit.org] Link directly to SCM provider from timeline https://bugs.webkit.org/show_bug.cgi?id=272195 rdar://125937058 Reviewed by Ryan Haddad. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js: (xAxisFromScale): Link directly to SCM provider's commit representation. Canonical link: https://commits.webkit.org/277119@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 916749: Use sandbox state flag to enable syscall telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9167490750e5180cf2ec4b9e1ba82881b6979da4 https://github.com/WebKit/WebKit/commit/9167490750e5180cf2ec4b9e1ba82881b6979da4 Author: Per Arne Vollan Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WTF/wtf/cocoa/Entitlements.h M Source/WTF/wtf/cocoa/Entitlements.mm M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Scripts/process-entitlements.sh M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig M Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj A Tools/MobileMiniBrowser/MobileMiniBrowser/MobileMiniBrowser.entitlements Log Message: --- Use sandbox state flag to enable syscall telemetry https://bugs.webkit.org/show_bug.cgi?id=272046 rdar://125796089 Reviewed by Sihui Liu. Use sandbox state flag to enable syscall telemetry related to QuickLook. If the parent process is able to set the state flag EnableQuickLookSandboxResources in the WebContent process, and this state flag is not set, telemetry is enabled. This will enable us to determine which rarely used syscalls are being used when not loading QuickLook documents. This will give us information on which syscalls can be blocked in that scenario. * Source/WTF/wtf/cocoa/Entitlements.h: * Source/WTF/wtf/cocoa/Entitlements.mm: (WTF::hasEntitlementValue): (WTF::hasEntitlementValueInArray): * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForResponseShared): * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): * Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: * Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: * Tools/MobileMiniBrowser/MobileMiniBrowser/MobileMiniBrowser.entitlements: Added. Canonical link: https://commits.webkit.org/277118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f26be3: AX: should expose AXSortDirection on column headers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f26be3ca90d56af08298774b5c618ff870e94cfe https://github.com/WebKit/WebKit/commit/f26be3ca90d56af08298774b5c618ff870e94cfe Author: Dominic Mazzoni Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/accessibility/table-attributes-expected.txt M LayoutTests/accessibility/table-cells-expected.txt M LayoutTests/accessibility/table-multiple-tbodies-expected.txt M LayoutTests/accessibility/table-thead-tfoot-expected.txt M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: --- AX: should expose AXSortDirection on column headers https://bugs.webkit.org/show_bug.cgi?id=272124 rdar://problem/125878207 Reviewed by Chris Fleizach. On macOS, WebKit implemented AXSortDirection but didn't expose it in accessibilityAttributeNames. We should expose it for any column or row headers. * LayoutTests/accessibility/table-attributes-expected.txt: * LayoutTests/accessibility/table-cells-expected.txt: * LayoutTests/accessibility/table-multiple-tbodies-expected.txt: * LayoutTests/accessibility/table-thead-tfoot-expected.txt: * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper _additionalAccessibilityAttributeNames:]): * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Canonical link: https://commits.webkit.org/277117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b7869: Regression(275500@main): Cache files are deleted w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b786978a314f6295948ad3a3ffc993d2a63a4ca https://github.com/WebKit/WebKit/commit/4b786978a314f6295948ad3a3ffc993d2a63a4ca Author: Sihui Liu Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Regression(275500@main): Cache files are deleted while in use https://bugs.webkit.org/show_bug.cgi?id=272187 rdar://125931004 Reviewed by Chris Dumez. applicationCachePath() returns the directory shared with other types. Ensure we only delete the application cache files inside it. * Source/WebKitLegacy/mac/WebView/WebView.mm: (webApplicationCacheStorage): Canonical link: https://commits.webkit.org/277116@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a68f96: Unreviewed, relanding 277093@main with 16GB size c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a68f96dfbdb9b8b14bfbb7651d0e05c0f5cfb560 https://github.com/WebKit/WebKit/commit/a68f96dfbdb9b8b14bfbb7651d0e05c0f5cfb560 Author: Yusuke Suzuki Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/bmalloc/bmalloc/Gigacage.cpp M Source/bmalloc/bmalloc/Gigacage.h Log Message: --- Unreviewed, relanding 277093@main with 16GB size change https://bugs.webkit.org/show_bug.cgi?id=272217 rdar://125919093 Because we were allocating 36GB region previously, 16GB VA with 16GB alignment requirement should work. * Source/bmalloc/bmalloc/Gigacage.cpp: (Gigacage::ensureGigacage): (Gigacage::bmalloc::runwaySize): Deleted. * Source/bmalloc/bmalloc/Gigacage.h: Canonical link: https://commits.webkit.org/277115@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73c959: [RenderTreeBuilder] Use WillBeDestroyed consistently
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73c959f4abe581a39c78a9ef2d214cce18f37210 https://github.com/WebKit/WebKit/commit/73c959f4abe581a39c78a9ef2d214cce18f37210 Author: Alan Baradlay Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp M Source/WebCore/rendering/updating/RenderTreeBuilder.h M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h M Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp Log Message: --- [RenderTreeBuilder] Use WillBeDestroyed consistently https://bugs.webkit.org/show_bug.cgi?id=272220 Reviewed by Antti Koivisto. This is in preparation for running some cleanup activities at the destroy root level (as opposed to at leaf renderers). (WillBeDestroyed is already used in a limited scope) * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::destroy): (WebCore::RenderTreeBuilder::detach): (WebCore::RenderTreeBuilder::move): (WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock): (WebCore::RenderTreeBuilder::detachFromRenderGrid): * Source/WebCore/rendering/updating/RenderTreeBuilder.h: * Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp: (WebCore::RenderTreeBuilder::Block::removeLeftoverAnonymousBlock): (WebCore::RenderTreeBuilder::Block::detach): (WebCore::RenderTreeBuilder::Block::dropAnonymousBoxChild): * Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h: * Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp: (WebCore::RenderTreeBuilder::FirstLetter::updateStyle): * Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp: (WebCore::RenderTreeBuilder::FormControls::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h: * Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp: (WebCore::RenderTreeBuilder::Inline::splitFlow): (WebCore::RenderTreeBuilder::Inline::childBecameNonInline): * Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp: (WebCore::RenderTreeBuilder::List::updateItemMarker): * Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp: (WebCore::RenderTreeBuilder::MultiColumn::restoreColumnSpannersForContainer): (WebCore::RenderTreeBuilder::MultiColumn::destroyFragmentedFlow): (WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp: (WebCore::RenderTreeBuilder::SVG::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h: * Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp: (WebCore::RenderTreeBuilder::Table::collapseAndDetachAnonymousNextSibling): Canonical link: https://commits.webkit.org/277114@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 904854: [GTK][WPE] Remove now unused m_disableBufferInvali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9048546f58eac07c6098a3378038e2ee142544e2 https://github.com/WebKit/WebKit/commit/9048546f58eac07c6098a3378038e2ee142544e2 Author: Olivier Blin Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.h Log Message: --- [GTK][WPE] Remove now unused m_disableBufferInvalidation variable in TextureMapperPlatformLayerProxy https://bugs.webkit.org/show_bug.cgi?id=272223 Reviewed by Miguel Gomez. 272907@main introduced the m_disableBufferInvalidation variable in TextureMapperPlatformLayerProxy, but it is now unused since 277110@main which uses the layer content type to disable buffer invalidation. * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.h: Canonical link: https://commits.webkit.org/277113@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1166d9: [web-animations] web-animations/responsive/width.h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1166d972ab8594ecf6202b5dfb7e4b9e674b2abe https://github.com/WebKit/WebKit/commit/1166d972ab8594ecf6202b5dfb7e4b9e674b2abe Author: Antoine Quint Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/width-expected.txt M Source/WebCore/platform/Length.cpp Log Message: --- [web-animations] web-animations/responsive/width.html is a failure https://bugs.webkit.org/show_bug.cgi?id=272084 Reviewed by Antti Koivisto. In 242527@main, a check was added to return a zero-length in cases where we were trying to blending lengths with mixed types, but one used a keyword. In the case of the WPT test web-animations/responsive/width.html which tested `width` blending between `min-content` and a fixed value, this meant that we would always resolve a zero-width for the first half such an animation, instead of returning `min-content`. We adjust the change made in 242527@main to deal with "intrinsic" values specifically since these will always yield discrete interpolation, as established by `canInterpolateLengths()`, and thus we can return either the "from" or "to" value. * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/width-expected.txt: * Source/WebCore/platform/Length.cpp: (WebCore::blendMixedTypes): Canonical link: https://commits.webkit.org/277112@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02e828: [WPE] Remove unused m_allowPlainText private field...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02e828193e3014198aaa64e7cc3ccf40bdd55491 https://github.com/WebKit/WebKit/commit/02e828193e3014198aaa64e7cc3ccf40bdd55491 Author: Olivier Blin Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/editing/WebContentReader.h Log Message: --- [WPE] Remove unused m_allowPlainText private field in WebContentReader https://bugs.webkit.org/show_bug.cgi?id=272088 Reviewed by Michael Catanzaro. * Source/WebCore/editing/WebContentReader.h: The m_allowPlainText private field is only used in Cocoa and GTK platforms. Canonical link: https://commits.webkit.org/277111@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba0578: [GTK][WPE] Add a content type property to TextureM...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba0578f34b1d565deb05a1db81902a9a0d925080 https://github.com/WebKit/WebKit/commit/ba0578f34b1d565deb05a1db81902a9a0d925080 Author: Miguel Gomez Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaContentLayer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaContentLayer.h M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.h M Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp Log Message: --- [GTK][WPE] Add a content type property to TextureMapperPlatformLayerProxy https://bugs.webkit.org/show_bug.cgi?id=272112 Reviewed by Carlos Garcia Campos. Add a property to TextureMapperPlatformLayerProxy to indicate the type of frames that are passing through it. The type can be WebGL, Video, OffscreenCanvas or HolePuch. We don't want to have proxies without a defined content type, so this patch removes the method to create a Nicosia::ContentLayer that doesn't receive a proxy and creates one whose content type is not known. This way, the code that creates the Nicosia::ContentLayer has to specifically create a proxy with a defined content type for it. This change removes the need of the of the disableBufferInvalidation parameter in the TextureMapperPlatformLayerProxyGL constructor, as this is only used for the HolePunch case. Now that the proxy knows when it's handling HolePunch buffers, the previous condition can be reworked. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): * Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp: (WebCore::MediaPlayerPrivateHolePunch::MediaPlayerPrivateHolePunch): * Source/WebCore/platform/graphics/nicosia/NicosiaContentLayer.cpp: * Source/WebCore/platform/graphics/nicosia/NicosiaContentLayer.h: * Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp: (Nicosia::GCGLANGLELayer::GCGLANGLELayer): * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: (Nicosia::NicosiaImageBufferPipeSource::NicosiaImageBufferPipeSource): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp: (WebCore::TextureMapperPlatformLayerProxy::TextureMapperPlatformLayerProxy): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h: (WebCore::TextureMapperPlatformLayerProxy::contentType const): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: (WebCore::TextureMapperPlatformLayerProxyDMABuf::TextureMapperPlatformLayerProxyDMABuf): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h: * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp: (WebCore::TextureMapperPlatformLayerProxyGL::TextureMapperPlatformLayerProxyGL): (WebCore::TextureMapperPlatformLayerProxyGL::invalidate): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.h: * Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp: (WebKit::NicosiaDisplayDelegate::NicosiaDisplayDelegate): Canonical link: https://commits.webkit.org/277110@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57fc61: (REGRESSION)[IFC] Missing content after 'float: ri...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57fc61c0eaf09b2031d2b0bc445981b2fed0f7cd https://github.com/WebKit/WebKit/commit/57fc61c0eaf09b2031d2b0bc445981b2fed0f7cd Author: Alan Baradlay Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: A LayoutTests/fast/inline/float-prevents-adjacent-content-on-zero-width-line-expected.html A LayoutTests/fast/inline/float-prevents-adjacent-content-on-zero-width-line.html M Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp Log Message: --- (REGRESSION)[IFC] Missing content after 'float: right' in a 0px wide container https://bugs.webkit.org/show_bug.cgi?id=272180 Reviewed by Antti Koivisto. Checking whether we managed to put content on the line or we are stuck should include 1. regular inline content 2. intrusive floats at the position of the current line 3. freshly placed floats while processing the inline content This patch add #3 to the set of conditions at formattingContexts::leadingInlineItemPositionForNextLine. * LayoutTests/fast/inline/float-prevents-adjacent-content-on-zero-width-line-expected.html: Added. * LayoutTests/fast/inline/float-prevents-adjacent-content-on-zero-width-line.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp: (WebCore::Layout::InlineContentBalancer::initialize): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::lineLayout): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp: (WebCore::Layout::InlineFormattingUtils::leadingInlineItemPositionForNextLine): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h: * Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp: (WebCore::Layout::IntrinsicWidthHandler::computedIntrinsicWidthForConstraint): Canonical link: https://commits.webkit.org/277109@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 087346: [WebGPU] WGSL compiler should support unicode char...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 087346e089cf2fe3c75037da7eb17553534a6fdb https://github.com/WebKit/WebKit/commit/087346e089cf2fe3c75037da7eb17553534a6fdb Author: Tadeu Zagallo Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/identifiers-expected.txt M Source/WebGPU/WGSL/Lexer.cpp M Source/WebGPU/WGSL/Lexer.h M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj M Source/WebGPU/WebGPU/ShaderModule.mm Log Message: --- [WebGPU] WGSL compiler should support unicode characters https://bugs.webkit.org/show_bug.cgi?id=266774 rdar://120004379 Reviewed by Mike Wyrzykowski and Yusuke Suzuki. For the most part, we already supported unicode, but the implementation for isIdentifierStart and isIdentifierContinue needed to be updated. After this patch all the identifier tests in the CTS (under shader,validation,parse,identifiers:*) are passing. * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::isIdentifierStart): (WGSL::isIdentifierContinue): (WGSL::Lexer::nextToken): * Source/WebGPU/WGSL/Lexer.h: (WGSL::Lexer::isIdentifierStart): Deleted. (WGSL::Lexer::isIdentifierContinue): Deleted. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::check): * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Source/WebGPU/WebGPU/ShaderModule.mm: (WebGPU::Device::createShaderModule): Canonical link: https://commits.webkit.org/277108@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f7e6f: [SOUP] Port SoupNetworkProxySettings to new IPC se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f7e6f818b85efbef6b8f056e86e683cfc859779 https://github.com/WebKit/WebKit/commit/1f7e6f818b85efbef6b8f056e86e683cfc859779 Author: Claudio Saavedra Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/platform/network/soup/SoupNetworkProxySettings.h R Source/WebCore/platform/network/soup/SoupNetworkProxySettings.serialization.in M Source/WebKit/Platform/IPC/ArgumentCoders.h A Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/Shared/WebCoreArgumentCoders.h R Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp A Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.serialization.in M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt Log Message: --- [SOUP] Port SoupNetworkProxySettings to new IPC serialization https://bugs.webkit.org/show_bug.cgi?id=272085 Reviewed by Michael Catanzaro. Move the serialization of the SoupNetworkProxySettingsMode to WebKit/Shared to a single file for soup-related argument coders. Also add a serializer for GUniquePtr, as it's needed for the ignored hosts list. With this in place, add a generator for SoupNetworkProxySettings and remove the handmade coder. * Source/WebCore/CMakeLists.txt: * Source/WebCore/platform/network/soup/SoupNetworkProxySettings.h: (WebCore::SoupNetworkProxySettings::SoupNetworkProxySettings): * Source/WebKit/Platform/IPC/ArgumentCoders.h: * Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h: Added. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp: Removed. * Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.serialization.in: Renamed from Source/WebCore/platform/network/soup/SoupNetworkProxySettings.serialization.in. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: Canonical link: https://commits.webkit.org/277107@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15b647: [Skia] Global alpha is not handled when drawing an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15b647424382d82c7b2c120c3f15ebf8a4126392 https://github.com/WebKit/WebKit/commit/15b647424382d82c7b2c120c3f15ebf8a4126392 Author: Carlos Garcia Campos Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Global alpha is not handled when drawing an image or filling with a pattern https://bugs.webkit.org/show_bug.cgi?id=272151 Reviewed by Alejandro G. Castro. Set the global alpha when drawing images and filling with a pattern. Also don't apply the alpha when setting the color of shadows, since it's already taken from SkPaint global alpha or source color. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::createDropShadowFilterIfNeeded const): (WebCore::GraphicsContextSkia::setupFillSource const): Canonical link: https://commits.webkit.org/277106@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 821bd0: [css-animations] update WPT import for css-animations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 821bd07f15ba9f701c476f496394d478ee324ec0 https://github.com/WebKit/WebKit/commit/821bd07f15ba9f701c476f496394d478ee324ec0 Author: Antoine Quint Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/add-pseudo-while-animating-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/cancel-update.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/pseudo-element-animation-with-marker.html M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-valid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer_animationiteration-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer_animationstart-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/w3c-import.log Log Message: --- [css-animations] update WPT import for css-animations https://bugs.webkit.org/show_bug.cgi?id=272144 rdar://125897021 Reviewed by Anne van Kesteren. This import was performed against the WPT repository at 4019765ef5. * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-offscreen-to-onscreen.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/add-pseudo-while-animating-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/cancel-update.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/pseudo-element-animation-with-marker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer_animationiteration-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/animation-event-destroy-renderer_animationstart-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/stability/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/crashtests/w3c-import.log. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/support/color-testcommon.js: * LayoutTests/imported/w3c/web-platform-tests/css/support/interpolation-testcommon.js: * LayoutTests/imported/w3c/web-platform-tests/css/support/numeric-testcommon.js: Canonical link: https://commits.webkit.org/277105@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [WebKit/WebKit] d13301: [GTK][WPE] `webanimations/combining-transform-anim...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d133014b967a8d9655f58b909801bd5a0259c25a https://github.com/WebKit/WebKit/commit/d133014b967a8d9655f58b909801bd5a0259c25a Author: Vitaly Dyachkov Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsLayer.cpp M Source/WebCore/platform/graphics/GraphicsLayer.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h Log Message: --- [GTK][WPE] `webanimations/combining-transform-animations-with-different-acceleration-capabilities-7.html` is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=272149 Reviewed by Carlos Garcia Campos. This patch implements `CoordinatedGraphicsLayer::acceleratedAnimationsForTesting()` similarly to already existing `GraphicsLayerCA::acceleratedAnimationsForTesting()`. * Source/WebCore/platform/graphics/GraphicsLayer.cpp: (WebCore::acceleratedEffectPropertyIDAsString): (WebCore::animatedPropertyIDAsString): * Source/WebCore/platform/graphics/GraphicsLayer.h: * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animatedPropertyIDAsString): Deleted. (WebCore::acceleratedEffectPropertyIDAsString): Deleted. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::acceleratedAnimationsForTesting const): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Canonical link: https://commits.webkit.org/277104@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c57ac8: [css-transitions] update WPT import for css-transi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c57ac8243f5ade220fdcc698b977a7fb68eb4d04 https://github.com/WebKit/WebKit/commit/c57ac8243f5ade220fdcc698b977a7fb68eb4d04 Author: Antoine Quint Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json R LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/all-with-discrete.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/all-with-discrete.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/animate-with-color-mix-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/animate-with-color-mix.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/transition-timing-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/transition-timing-function.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/crashtests/delete-image-set.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/crashtests/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-cascade.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-rule-none.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/support/helper.js A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-behavior-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-behavior.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/w3c-import.log Log Message: --- [css-transitions] update WPT import for css-transitions https://bugs.webkit.org/show_bug.cgi?id=272145 rdar://125897282 Reviewed by Anne van Kesteren. This import was performed against the WPT repository at 4019765ef5. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/all-with-discrete.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/all-with-discrete.tentative.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/animate-with-color-mix-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/animate-with-color-mix.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/transition-timing-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/transition-timing-function.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/crashtests/delete-image-set.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/crashtests/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-cascade.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-rule-none.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/support/helper.js: (root.supportsStartingStyle): * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-behavior-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-behavior.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/w3c-import.log: Canonical link: https://commits.webkit.org/277103@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe617b: [css] update WPT import for css/support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe617b32b76d6e3356759beccdfc77f994a8cf3a https://github.com/WebKit/WebKit/commit/fe617b32b76d6e3356759beccdfc77f994a8cf3a Author: Antoine Quint Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/compositing/isolation/animation/isolation-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-align/animation/align-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-align/animation/column-gap-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-align/animation/justify-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-align/animation/row-gap-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/transition-properties-not-animatable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-size-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-slice-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-source-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/box-shadow-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/discrete-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-break/animation/break-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/animation/color-scheme-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/animation/forced-color-adjust-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-content/content-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-display/animations/display-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/discrete-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-variation-settings-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/discrete-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/animation/grid-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/animation/grid-template-columns-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/animation/grid-template-rows-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/alignment-baseline-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/dominant-baseline-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/initial-letter-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/animations/list-style-image-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/css-lists-no-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animations/float-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-shape-expected.txt M
[webkit-changes] [WebKit/WebKit] 1f8129: Unreviewed, reverting 277093@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f812939fcb38170325f5f6ab1fe8ff833b7419f https://github.com/WebKit/WebKit/commit/1f812939fcb38170325f5f6ab1fe8ff833b7419f Author: Commit Queue Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/bmalloc/bmalloc/Gigacage.cpp M Source/bmalloc/bmalloc/Gigacage.h Log Message: --- Unreviewed, reverting 277093@main. https://bugs.webkit.org/show_bug.cgi?id=272215 32GB alignment fails Reverted changeset: "[libpas] Use sentinel page for primitive Gigacage" https://bugs.webkit.org/show_bug.cgi?id=272171 https://commits.webkit.org/277093@main Canonical link: https://commits.webkit.org/277101@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0abe80: Fix warnings in Source/WebKit/UIProcess/WebAuthent...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0abe80c522c75a75c85d6c475cbbf8acc2af9de2 https://github.com/WebKit/WebKit/commit/0abe80c522c75a75c85d6c475cbbf8acc2af9de2 Author: Ryosuke Niwa Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp Log Message: --- Fix warnings in Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp https://bugs.webkit.org/show_bug.cgi?id=272198 Reviewed by David Kilzer, Chris Dumez and Sihui Liu. Use enumToUnderlyingType on enum classes. * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::responseReceived): (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueCheckOnlyCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandExcludeCredentialsMatchAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandNoCredentialsAfterResponseReceived): (WebKit::U2fAuthenticator::continueSignCommandAfterResponseReceived): Canonical link: https://commits.webkit.org/277100@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7229c9: Add StringView::show
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7229c9f57829d3461ffa01fc29605fa721bc1029 https://github.com/WebKit/WebKit/commit/7229c9f57829d3461ffa01fc29605fa721bc1029 Author: Ryosuke Niwa Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WTF/wtf/text/StringView.cpp M Source/WTF/wtf/text/StringView.h Log Message: --- Add StringView::show https://bugs.webkit.org/show_bug.cgi?id=272207 Reviewed by Chris Dumez and Simon Fraser. Added StringView::show which calls toString().show() for debugging purposes. * Source/WTF/wtf/text/StringView.cpp: (WTF::StringView::show const): * Source/WTF/wtf/text/StringView.h: Canonical link: https://commits.webkit.org/277099@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa54f7: Make _WKApplicationManifest initializer return nil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa54f7ce3cd9b71732786437b9d5dcde72a4c07f https://github.com/WebKit/WebKit/commit/fa54f7ce3cd9b71732786437b9d5dcde72a4c07f Author: Sihui Liu Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp M Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm Log Message: --- Make _WKApplicationManifest initializer return nil when jsonData is not valid JSON https://bugs.webkit.org/show_bug.cgi?id=272161 rdar://125913241 Reviewed by Chris Dumez. API Test: WKApplicationManifest.InvalidJSONData * Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp: (WebCore::ApplicationManifestParser::parse): (WebCore::ApplicationManifestParser::parseWithValidation): (WebCore::ApplicationManifestParser::createJSONObject): (WebCore::ApplicationManifestParser::parseManifest): * Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h: * Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm: (-[_WKApplicationManifest initWithJSONData:manifestURL:documentURL:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: (TestWebKitAPI::TEST(WKApplicationManifest, InvalidJSONData)): Canonical link: https://commits.webkit.org/277098@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 804d44: [JSC] Cloning via Object Literal + 1 Spread should...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 804d44f89619bfae3e5e2e21a07669b1fb320d57
https://github.com/WebKit/WebKit/commit/804d44f89619bfae3e5e2e21a07669b1fb320d57
Author: Yusuke Suzuki
Date: 2024-04-04 (Thu, 04 Apr 2024)
Changed paths:
A JSTests/microbenchmarks/clone-objects-via-spread.js
M Source/JavaScriptCore/builtins/BuiltinNames.h
M Source/JavaScriptCore/bytecode/LinkTimeConstant.h
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/parser/Nodes.h
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h
M Source/JavaScriptCore/runtime/ObjectConstructorInlines.h
Log Message:
---
[JSC] Cloning via Object Literal + 1 Spread should be super fast
https://bugs.webkit.org/show_bug.cgi?id=272131
rdar://125883824
Reviewed by Alexey Shvayka.
For the pattern like,
`{ ...object }`
we can use super fast object cloning since there are no properties. After
checking object is very specifc conditioned FinalObject,
we can just grab a structure, copy butterfly, and create a new object with them.
ToT Patched
clone-objects-via-spread 96.1927+-0.3467 ^ 15.9928+-0.1021
^ definitely 6.0147x faster
* JSTests/microbenchmarks/clone-objects-via-spread.js: Added.
(test):
* JSTests/stress/clone-objects-via-spread.js: Added.
(test):
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/bytecode/LinkTimeConstant.h:
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::ObjectLiteralNode::emitBytecode):
* Source/JavaScriptCore/parser/Nodes.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h:
* Source/JavaScriptCore/runtime/ObjectConstructorInlines.h:
(JSC::checkStrucureForClone):
(JSC::objectCloneFast):
(JSC::tryCreateObjectViaCloning):
Canonical link: https://commits.webkit.org/277097@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7fe8ad: AX: createObjectFromRenderer and accessibleNameFor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7fe8ad6a33150c1a6a97f0541068153394560a94 https://github.com/WebKit/WebKit/commit/7fe8ad6a33150c1a6a97f0541068153394560a94 Author: Tyler Wilcock Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/accessibility/AXImage.cpp M Source/WebCore/accessibility/AXImage.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp M Source/WebCore/accessibility/AccessibilityARIAGridCell.h M Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp M Source/WebCore/accessibility/AccessibilityARIAGridRow.h M Source/WebCore/accessibility/AccessibilityARIATable.cpp M Source/WebCore/accessibility/AccessibilityARIATable.h M Source/WebCore/accessibility/AccessibilityAttachment.cpp M Source/WebCore/accessibility/AccessibilityAttachment.h M Source/WebCore/accessibility/AccessibilityLabel.cpp M Source/WebCore/accessibility/AccessibilityLabel.h M Source/WebCore/accessibility/AccessibilityList.cpp M Source/WebCore/accessibility/AccessibilityList.h M Source/WebCore/accessibility/AccessibilityListBox.cpp M Source/WebCore/accessibility/AccessibilityListBox.h M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp M Source/WebCore/accessibility/AccessibilityMathMLElement.h M Source/WebCore/accessibility/AccessibilityMediaObject.cpp M Source/WebCore/accessibility/AccessibilityMediaObject.h M Source/WebCore/accessibility/AccessibilityMenuList.cpp M Source/WebCore/accessibility/AccessibilityMenuList.h M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp M Source/WebCore/accessibility/AccessibilityProgressIndicator.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.h M Source/WebCore/accessibility/AccessibilitySVGElement.cpp M Source/WebCore/accessibility/AccessibilitySVGElement.h M Source/WebCore/accessibility/AccessibilitySVGRoot.cpp M Source/WebCore/accessibility/AccessibilitySVGRoot.h M Source/WebCore/accessibility/AccessibilitySlider.cpp M Source/WebCore/accessibility/AccessibilitySlider.h M Source/WebCore/accessibility/AccessibilityTable.cpp M Source/WebCore/accessibility/AccessibilityTable.h M Source/WebCore/accessibility/AccessibilityTableCell.cpp M Source/WebCore/accessibility/AccessibilityTableCell.h M Source/WebCore/accessibility/AccessibilityTableRow.cpp M Source/WebCore/accessibility/AccessibilityTableRow.h M Source/WebCore/accessibility/AccessibilityTree.cpp M Source/WebCore/accessibility/AccessibilityTree.h M Source/WebCore/accessibility/AccessibilityTreeItem.cpp M Source/WebCore/accessibility/AccessibilityTreeItem.h Log Message: --- AX: createObjectFromRenderer and accessibleNameForNode can take their arguments by reference rather than pointer https://bugs.webkit.org/show_bug.cgi?id=272063 rdar://problem/125813277 Reviewed by Andres Gonzalez. Doing this saves null checks on hot codepaths and makes intent more clear, as these functions or ones downstream from them would either ASSERT non-null, or directly dereference the pointer without null checking. * Source/WebCore/accessibility/AXImage.cpp: (WebCore::AXImage::AXImage): (WebCore::AXImage::create): * Source/WebCore/accessibility/AXImage.h: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::toSimpleImage): (WebCore::isAccessibilityList): (WebCore::isAccessibilityTree): (WebCore::isAccessibilityTreeItem): (WebCore::isAccessibilityARIATable): (WebCore::isAccessibilityARIAGridRow): (WebCore::isAccessibilityARIAGridCell): (WebCore::AXObjectCache::createObjectFromRenderer): (WebCore::createFromNode): (WebCore::AXObjectCache::getOrCreate): (WebCore::isSimpleImage): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp: (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell): (WebCore::AccessibilityARIAGridCell::create): * Source/WebCore/accessibility/AccessibilityARIAGridCell.h: * Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp: (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow): (WebCore::AccessibilityARIAGridRow::create): * Source/WebCore/accessibility/AccessibilityARIAGridRow.h: * Source/WebCore/accessibility/AccessibilityARIATable.cpp: (WebCore::AccessibilityARIATable::AccessibilityARIATable): (WebCore::AccessibilityARIATable::create): * Source/WebCore/accessibility/AccessibilityARIATable.h: * Source/WebCore/accessibility/AccessibilityAttachment.cpp: (WebCore::AccessibilityAttachment::AccessibilityAttachment): (WebCore::AccessibilityAttachment::create): * Source/WebCore/accessibility/AccessibilityAttachment.h: *
