[webkit-changes] [WebKit/WebKit] ffe128: [svg] update WPT import for svg/path/property

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffe1284b0eea55975a3c7e8278b5e112415f3b2d
  
https://github.com/WebKit/WebKit/commit/ffe1284b0eea55975a3c7e8278b5e112415f3b2d
  Author: Antoine Quint 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/getComputedStyle-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/getComputedStyle.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path-expected.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath-expected.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath-ref.svg
A LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/priority-expected.svg
M 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/serialization-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/serialization.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property.html
M 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/w3c-import.log

  Log Message:
  ---
  [svg] update WPT import for svg/path/property
https://bugs.webkit.org/show_bug.cgi?id=272414
rdar://126152918

Reviewed by Tim Nguyen.

Matching WPT revision: 149d525c8a.

* LayoutTests/imported/w3c/resources/resource-files.json:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/getComputedStyle-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/getComputedStyle.svg:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path-expected.svg:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path-ref.svg:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/marker-path.svg: 
Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath-expected.svg:
 Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath-ref.svg: 
Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/path/property/mpath.svg: 
Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/priority-expected.svg:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/serialization-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/serialization.svg:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property.html:
 Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/path/property/w3c-import.log:
* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/277289@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d5ab5f: [GCC] Unreviewed, build fix for Ubuntu LTS after 2...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5ab5f9bf70bb953bef41fd1a303b80445b9987f
  
https://github.com/WebKit/WebKit/commit/d5ab5f9bf70bb953bef41fd1a303b80445b9987f
  Author: Diego Pino Garcia 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/html/parser/HTMLParserIdioms.cpp

  Log Message:
  ---
  [GCC] Unreviewed, build fix for Ubuntu LTS after 277244@main
https://bugs.webkit.org/show_bug.cgi?id=272374

Similar fix to 276336@main.

* Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTTPRefreshInternal):

Canonical link: https://commits.webkit.org/277288@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39c0cf: Rebase IDNA tests: U+1E9E is mapped to U+00DF now

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39c0cf005decc875c056e5244d50b35266137992
  
https://github.com/WebKit/WebKit/commit/39c0cf005decc875c056e5244d50b35266137992
  Author: Anne van Kesteren 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/fast/url/idna2008-expected.txt
M LayoutTests/fast/url/idna2008.html
M LayoutTests/fast/url/url-hostname-encoding-expected.txt
M LayoutTests/fast/url/url-hostname-encoding.html
A LayoutTests/platform/glib/fast/url/idna2008-expected.txt
A LayoutTests/platform/glib/fast/url/url-hostname-encoding-expected.txt
M LayoutTests/platform/ios/TestExpectations
A LayoutTests/platform/mac-monterey/fast/url/idna2008-expected.txt
A 
LayoutTests/platform/mac-monterey/fast/url/url-hostname-encoding-expected.txt
A LayoutTests/platform/mac-ventura/fast/url/idna2008-expected.txt
A 
LayoutTests/platform/mac-ventura/fast/url/url-hostname-encoding-expected.txt
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Rebase IDNA tests: U+1E9E is mapped to U+00DF now
https://bugs.webkit.org/show_bug.cgi?id=271792
rdar://125507204

Reviewed by Alex Christensen.

* LayoutTests/fast/url/idna2008-expected.txt:
* LayoutTests/fast/url/idna2008.html:
* LayoutTests/fast/url/url-hostname-encoding-expected.txt:
* LayoutTests/fast/url/url-hostname-encoding.html:
* LayoutTests/platform/glib/fast/url/idna2008-expected.txt: Added.
* LayoutTests/platform/glib/fast/url/url-hostname-encoding-expected.txt: Copied 
from LayoutTests/fast/url/url-hostname-encoding-expected.txt.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-monterey/fast/url/idna2008-expected.txt: Added.
* 
LayoutTests/platform/mac-monterey/fast/url/url-hostname-encoding-expected.txt: 
Copied from LayoutTests/fast/url/url-hostname-encoding-expected.txt.
* LayoutTests/platform/mac-ventura/fast/url/idna2008-expected.txt: Added.
* LayoutTests/platform/mac-ventura/fast/url/url-hostname-encoding-expected.txt: 
Copied from LayoutTests/fast/url/url-hostname-encoding-expected.txt.
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277287@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3612b1: Supplementable name should not use ASCIILiteralPtr...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3612b1cc728638d08a16c14b515049747aeb8447
  
https://github.com/WebKit/WebKit/commit/3612b1cc728638d08a16c14b515049747aeb8447
  Author: Ryosuke Niwa 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/platform/Supplementable.h

  Log Message:
  ---
  Supplementable name should not use ASCIILiteralPtrHash
https://bugs.webkit.org/show_bug.cgi?id=272427

Reviewed by Chris Dumez.

Use the default hash traits.

* Source/WebCore/platform/Supplementable.h:

Canonical link: https://commits.webkit.org/277286@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8cab38: Replacing AES impls with interop

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cab381a36560866a220e47f934fa4b1bb717e0c
  
https://github.com/WebKit/WebKit/commit/8cab381a36560866a220e47f934fa4b1bb717e0c
  Author: Nitin Mahendru 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Vector.h
M Source/WebCore/Configurations/WebCore.xcconfig
M Source/WebCore/PAL/Configurations/PAL.xcconfig
M Source/WebCore/PAL/pal/PALSwift.h
M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift
M Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift
M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp

  Log Message:
  ---
  Replacing AES impls with interop
https://bugs.webkit.org/show_bug.cgi?id=271680
radar://125367961

Reviewed by Geoffrey Garen.

All the Unsafe Bits are now in UnsafeOverlays.swift.
Also all the Cpp wrappers to work around interop shortcomings are now
inside a namespace to keep them away from global scope.

Any wrappers deemed Unsafe are now inside namespace Cpp.Unsafe.

WTF::Vector Copy operation is hard fail from Swift. This is to guard
against swift's strategy of implicity copies of C++ types for exclusivity and
memory safety.

Also the quirk added in 276651@main for destructor linkage
 is moved out of the execution path.

* Source/WTF/wtf/Vector.h:
(WTF::Malloc>::Vector):
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebCore/PAL/pal/PALSwift.h:
(Cpp::toOptionalVectorUInt8):
(Cpp::createVectorUInt8FromSpan):
(Cpp::appendSpanToVectorUInt8):
(Cpp::Unsafe::createConstUInt8Span):
* Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift:
(AesGcmRV.cipherText):
(AesGcmRV.errorCode):
(AesGcm.ciphertext):
(AesKwRV.result):
(AesKw.wrap(_:keyToBeWrapped:)):
(AesKw.unwrap(_:wrappedKey:)):
(AesKwRV.outputSize): Deleted.
* Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift:
(HashFunction.update(_:)):
(ContiguousBytes.createConstUInt8Span(_:)):
(ContiguousBytes.createConstUInt8Span):
(VectorUInt8.appendSpan(_:)):
(VectorUInt8.appendContiguousBytes(_:)):
(Data.fromSpan(_:)):
(_CompilerBugDontUse.forceLinkageForVectorDestructor):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp:
(WebCore::encryptCryptoKitAESGCM):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp:
(WebCore::wrapKeyAESKWCryptoKit):
(WebCore::unwrapKeyAESKWCryptoKit):

Canonical link: https://commits.webkit.org/277285@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a35a92: Enable text indicator styling for specified ranges.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a35a92c62f0e85ebd505ed1fac53febe94facb6f
  
https://github.com/WebKit/WebKit/commit/a35a92c62f0e85ebd505ed1fac53febe94facb6f
  Author: Megan Gardner 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  Enable text indicator styling for specified ranges.
https://bugs.webkit.org/show_bug.cgi?id=272293
rdar://125359006

Reviewed by Wenson Hsieh.

Enable text indicator styling for specified ranges.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _enableTextIndicatorStylingAfterElementWithID:]):
(-[WKWebView _disableTextIndicatorStylingWithUUID:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::enableTextIndicatorStyleAfterElementWithID):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::getTextIndicatorForID): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getTextIndicatorForID):
(WebKit::WebPage::enableTextIndicatorStyleAfterElementWithID):
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/277284@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 455df1: [macOS] Crash when using text indicator style

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 455df18d3888d8b3eda30175a45c868882f57734
  
https://github.com/WebKit/WebKit/commit/455df18d3888d8b3eda30175a45c868882f57734
  Author: Aditya Keerthi 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A Source/WebKit/Shared/Cocoa/UnifiedTextReplacementSoftLink.h
A Source/WebKit/Shared/Cocoa/UnifiedTextReplacementSoftLink.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  [macOS] Crash when using text indicator style
https://bugs.webkit.org/show_bug.cgi?id=272425
rdar://126171238

Reviewed by Wenson Hsieh and Abrar Rahman Protyasha.

Check for support in `WKTextIndicatorStyleManager` to avoid crashes due to
missing symbols.

* Source/WebKit/Shared/Cocoa/UnifiedTextReplacementSoftLink.h: Added.
* Source/WebKit/Shared/Cocoa/UnifiedTextReplacementSoftLink.mm: Added.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::addTextIndicatorStyleForID):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/277283@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 052c7b: Typing into Bitbucket comment fields is sometimes ...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 052c7b2a782b865f1922a7c9a691799aa815d306
  
https://github.com/WebKit/WebKit/commit/052c7b2a782b865f1922a7c9a691799aa815d306
  Author: Richard Robinson 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/CSSSelector.cpp
M Source/WebCore/css/html.css
M Source/WebCore/cssjit/SelectorCompiler.cpp
A Source/WebCore/dom/WritingSuggestionData.h
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/InsertTextCommand.cpp
M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
M Source/WebKit/WebProcess/WebCoreSupport/glib/WebEditorClientGLib.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl
M Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp
M Tools/WebKitTestRunner/InjectedBundle/TextInputController.h

  Log Message:
  ---
  Typing into Bitbucket comment fields is sometimes dropping characters/sending 
editing back to the start of the field
https://bugs.webkit.org/show_bug.cgi?id=271842
rdar://125039472

Reviewed by Ryosuke Niwa and Antti Koivisto.

The original implementation of writing suggestions aka inline text predictions 
relied on using the
same code path as IME marked text has historically used; i.e., inserting the 
suggestion directly into
the DOM.

While this worked for trivial, simple cases, this proved to be incompatible 
from a web-compatibility
perspective, since sites were not expecting this type of mutation to ever be 
happening in the DOM.
Because of the combination of the conflicting selection changes that both the 
web engine and the site
do, as well as the specific event handlers that a site may have, this resulted 
in erratic behavior
when inserting and editing text.

To fix, re-implement this feature using a different and significantly safer 
implementation; instead
of inserting the suggestion into the DON, simply render it as a pseudo-element 
while it is being suggested,
and only actually insert it into the DOM once the user accepts it. This 
significantly improves web
compatibility, and also reduces risk in general by not doing unexpected things 
that the site can detect.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
* Source/WebCore/css/html.css:
(::-internal-writing-suggestions):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::writingSuggestionData const):
(WebCore::Element::setWritingSuggestionData):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ElementRareData.cpp:
* Source/WebCore/dom/ElementRareData.h:
(WebCore::ElementRareData::writingSuggestionData const):
(WebCore::ElementRareData::setWritingSuggestionData):
* Source/WebCore/dom/WritingSuggestionData.h: Copied from 
Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl.
(WebCore::WritingSuggestionData::WritingSuggestionData):
(WebCore::WritingSuggestionData::content const):
(WebCore::WritingSuggestionData::offset const):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::selectedElement):
(WebCore::Editor::removeWritingSuggestionIfNeeded):
(WebCore::Editor::confirmComposition):
(WebCore::Editor::cancelComposition):
(WebCore::Editor::setWritingSuggestion):
(WebCore::Editor::setComposition):
* Source/WebCore/editing/Editor.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::writingSuggestionsRenderer const):
(WebCore::RenderElement::setWritingSuggestionsRenderer):
* 

[webkit-changes] [WebKit/WebKit] 5144a8: (Re-land) Don't initialize mach exceptions if we d...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5144a8edcfab04c9cd2f55ab80b8fe670cb9d2e4
  
https://github.com/WebKit/WebKit/commit/5144a8edcfab04c9cd2f55ab80b8fe670cb9d2e4
  Author: Justin Michaud 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/threads/Signals.cpp

  Log Message:
  ---
  (Re-land) Don't initialize mach exceptions if we didn't register any.
https://bugs.webkit.org/show_bug.cgi?id=272261
rdar://126000755

The original patch by Keith was reverted because it came after the enablement 
patch
for the new exceptions API. It turns out that even after reverting, we still 
need
this fix.

Original patch:
Don't initialize mach exceptions if we didn't register any.
https://bugs.webkit.org/show_bug.cgi?id=272261
rdar://126000755

Reviewed by Justin Michaud.

This also fixes GPU process crashing on launch because the sandbox 
doesn't allow `task_register_hardened_exception_handler`.

* Source/WTF/wtf/threads/Signals.cpp:
(WTF::initMachExceptionHandlerThread):

Canonical link: https://commits.webkit.org/277143@main


Canonical link: https://commits.webkit.org/277281@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 969d08: [Site Isolation] `WebProcessProxy::pages()` should...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 969d08bfde0bea8664a95499a6e9e7e4710d8b8b
  
https://github.com/WebKit/WebKit/commit/969d08bfde0bea8664a95499a6e9e7e4710d8b8b
  Author: Charlie Wolfe 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/http/tests/site-isolation/paste-in-iframe-expected.txt
M LayoutTests/http/tests/site-isolation/paste-in-iframe.html
M LayoutTests/http/tests/site-isolation/resources/copy-and-paste-text.html
M Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  [Site Isolation] `WebProcessProxy::pages()` should include remote pages
https://bugs.webkit.org/show_bug.cgi?id=272365
rdar://126107383

Reviewed by Alex Christensen.

If a web process was not hosting the main frame we would not allow pasteboard 
access in
`WebPasteboardProxy::accessType()`.

* LayoutTests/http/tests/site-isolation/paste-in-iframe-expected.txt:
* LayoutTests/http/tests/site-isolation/paste-in-iframe.html:
* LayoutTests/http/tests/site-isolation/resources/copy-and-paste-text.html:
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::determineDataOwner const):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::pages const):
(WebKit::WebProcessProxy::mainPages const):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
(WebKit::WebProcessProxy::didFinishLaunching):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/277280@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e5e9b2: [JSC] DesiredWeakReferences::reallyAdd should avoi...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5e9b260874b56172ad5b7a4e75eaa946d627b34
  
https://github.com/WebKit/WebKit/commit/e5e9b260874b56172ad5b7a4e75eaa946d627b34
  Author: Yusuke Suzuki 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp
M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h
M Source/JavaScriptCore/runtime/JSCast.h

  Log Message:
  ---
  [JSC] DesiredWeakReferences::reallyAdd should avoid allocating and destroying 
Vectors
https://bugs.webkit.org/show_bug.cgi?id=272421
rdar://126167184

Reviewed by Justin Michaud.

This patch reorganizes DesiredWeakReferences.

1. DesiredWeakReferences should have separate HashSet for JSCell and Structure. 
So DesiredWeakReferences::reallyAdd becomes simpler.
   This is important since DesiredWeakReferences::reallyAdd runs on the main 
thread.
2. (1) allows us to compute FixedVector size before iterating HashSet in 
DesiredWeakReferences::reallyAdd. We stop using Vector and
   materialize exact sized FixedVector and fill them with values.

* Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):
(JSC::DFG::DesiredWeakReferences::reallyAdd):
(JSC::DFG::DesiredWeakReferences::visitChildren):
(JSC::DFG::DesiredWeakReferences::~DesiredWeakReferences): Deleted.
* Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h:
* Source/JavaScriptCore/runtime/JSCast.h:

Canonical link: https://commits.webkit.org/277279@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 72e356: [Gardening]: NEW TEST (277103@main): [ MacOS ] 2 t...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72e356e2f9ff714ea615768d6e6621152b5113cc
  
https://github.com/WebKit/WebKit/commit/72e356e2f9ff714ea615768d6e6621152b5113cc
  Author: Marta Darbinyan 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: NEW TEST (277103@main): [ MacOS ] 2 tests in 
imported/w3c/web-platform-tests/css are constant failure on x86 and Monterey
https://bugs.webkit.org/show_bug.cgi?id=272249
rdar://125991079

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277278@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b4ead: Add scaffolding for page load observer

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b4eaddd4f17d90a968b4a45467e96c53c2924cf
  
https://github.com/WebKit/WebKit/commit/8b4eaddd4f17d90a968b4a45467e96c53c2924cf
  Author: Ben Nham 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/cocoa/Entitlements.h
M Source/WTF/wtf/cocoa/Entitlements.mm
M Source/WTF/wtf/spi/cocoa/SecuritySPI.h
M Source/WebKit/Platform/Logging.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm

  Log Message:
  ---
  Add scaffolding for page load observer
https://bugs.webkit.org/show_bug.cgi?id=272266
rdar://125788604

Reviewed by Brady Eidson.

This adds some scaffolding for a main frame page load observer object.

* Source/WTF/wtf/cocoa/Entitlements.h:
* Source/WTF/wtf/cocoa/Entitlements.mm:
(WTF::hasEntitlement):
* Source/WebKit/Platform/Logging.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView backForwardList]):
(-[WKWebView _didAccessBackForwardList]):
(-[WKWebView canGoBack]):
(-[WKWebView canGoForward]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _frameOrBoundsMayHaveChanged]):
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::viewIsBecomingVisible):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewIsBecomingVisible):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::viewIsBecomingVisible):

Canonical link: https://commits.webkit.org/277277@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a6350: Add WTF_GUARDED_BY_LOCK annotation for m_canAccept...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a6350c43a96ddbdcec072004a73dff22d0333e2
  
https://github.com/WebKit/WebKit/commit/7a6350c43a96ddbdcec072004a73dff22d0333e2
  Author: Sihui Liu 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/platform/PublicSuffixStore.h
M Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm

  Log Message:
  ---
  Add WTF_GUARDED_BY_LOCK annotation for m_canAcceptCustomPublicSuffix
https://bugs.webkit.org/show_bug.cgi?id=272368
rdar://126111206

Reviewed by Chris Dumez.

This data member is actually guarded by lock now; add the annotation to make it 
clear that it can be accessed from
different threads and should be protected.

* Source/WebCore/platform/PublicSuffixStore.h:
(WebCore::PublicSuffixStore::WTF_GUARDED_BY_LOCK):
(): Deleted.
* Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm:
(WebCore::PublicSuffixStore::addPublicSuffix):

Canonical link: https://commits.webkit.org/277276@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f4378: [RenderTreeBuilder] Out-of-flow box does not stret...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f4378eb7afab5629db0f64a2ef61954245ef0eb
  
https://github.com/WebKit/WebKit/commit/2f4378eb7afab5629db0f64a2ef61954245ef0eb
  Author: Alan Baradlay 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  ---
  [RenderTreeBuilder] Out-of-flow box does not stretch its containing block 
(and not even its parent)
https://bugs.webkit.org/show_bug.cgi?id=272412

Reviewed by Antti Koivisto.

1. Out-of-flow boxes do not affect containing block's preferred width.
2. Merge multiple m_internalMovesType == IsInternalMove::No scopes.
2. Rearrange conditions in LocalFrameViewLayoutContext::scheduleLayout by 
moving the most common  isLayoutPending() to the top (we normally dirty more 
than one renderer at a time).
3. Modernize RenderObject::invalidateContainerPreferredLogicalWidths

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::scheduleLayout):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):

Canonical link: https://commits.webkit.org/277275@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a1a32: Use enum class for NetworkCache::Storage::Traverse...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a1a32eb6b1dabf36c0e137a6eb9fcd5de77992f
  
https://github.com/WebKit/WebKit/commit/7a1a32eb6b1dabf36c0e137a6eb9fcd5de77992f
  Author: Sihui Liu 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h

  Log Message:
  ---
  Use enum class for NetworkCache::Storage::TraverseFlag
https://bugs.webkit.org/show_bug.cgi?id=272411
rdar://126151671

Reviewed by Per Arne Vollan.

* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:

Canonical link: https://commits.webkit.org/277274@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67629e: REGRESSION (276433@main): Snapshots are partially ...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67629e39b0e9bc6a179cbb7c9dffe819a7015bdc
  
https://github.com/WebKit/WebKit/commit/67629e39b0e9bc6a179cbb7c9dffe819a7015bdc
  Author: Sammy Gill 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  REGRESSION (276433@main): Snapshots are partially dark-shaded.
https://bugs.webkit.org/show_bug.cgi?id=272410
rdar://125791769

Reviewed by Simon Fraser and Abrar Rahman Protyasha.

These dark regions are due to the fact that we are missing the white
background when painting the previews. This patch adds them back in the
async case since the preview is painted without the async renderer.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):

Canonical link: https://commits.webkit.org/277273@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 57d17c: error: missing field 'mpl' initializer in wtf/thre...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57d17cd8f38c3123ab4d0d13850e2fcc4bc556fd
  
https://github.com/WebKit/WebKit/commit/57d17cd8f38c3123ab4d0d13850e2fcc4bc556fd
  Author: Chris Dumez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/threads/Signals.cpp

  Log Message:
  ---
  error: missing field 'mpl' initializer in wtf/threads/Signals.cpp
https://bugs.webkit.org/show_bug.cgi?id=272418
rdar://124636304

Reviewed by Darin Adler.

Fix build error in Signals.cpp with the newer SDKs. Some of the
`mach_port_options_t` data members were missing from the initializer.

To address the issue, we now memset(0) the options after constructing
it.

* Source/WTF/wtf/threads/Signals.cpp:
(WTF::initMachExceptionHandlerThread):

Canonical link: https://commits.webkit.org/277272@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d6284: Addresses may not be persistent across calls to pa...

[David Degazio]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d6284de0e3fef99a91c909e2bb9ffe1c4064f6f
  
https://github.com/WebKit/WebKit/commit/8d6284de0e3fef99a91c909e2bb9ffe1c4064f6f
  Author: David Degazio 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/bmalloc/libpas/src/libpas/pas_enumerator.c

  Log Message:
  ---
  Addresses may not be persistent across calls to pas_enumerator_reader
https://bugs.webkit.org/show_bug.cgi?id=272404
rdar://125072587

Reviewed by Yusuke Suzuki.

Stores the results of calling the reader function in pas_enumerator_create
locally as opposed to referencing the remote memory. This reduction in
indirection means changes to the enumerating process' mapping of the remote
memory will no longer cause values the enumerator is actively using (such
as the pas_root) to become unmapped.

* Source/bmalloc/libpas/src/libpas/pas_enumerator.c:
(pas_enumerator_create):

Canonical link: https://commits.webkit.org/277271@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87b57e: [Remote Inspection] Improve the heuristic for extr...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87b57ed36164d494c13f5dfec8e6701115a8b8dd
  
https://github.com/WebKit/WebKit/commit/87b57ed36164d494c13f5dfec8e6701115a8b8dd
  Author: Wenson Hsieh 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A LayoutTests/fast/element-targeting/prefer-succinct-selectors-expected.txt
A LayoutTests/fast/element-targeting/prefer-succinct-selectors.html
M Source/WebCore/page/ElementTargetingController.cpp

  Log Message:
  ---
  [Remote Inspection] Improve the heuristic for extracting CSS selectors for 
targeted elements
https://bugs.webkit.org/show_bug.cgi?id=272413
rdar://123615458

Reviewed by Megan Gardner.

Refactor some of the logic around finding CSS selectors for targeted elements, 
such that we:

1.  Prefers shorter selector strings over longer ones.
2.  Prefers selectors that reference the target's class, ID or tag name over 
selectors that are
relative to other elements.
3.  Allow for sibling-relative selectors as well as parent-relative ones.

This also sorts the returned selector strings, in order from most preferred to 
least preferred
selector. To avoid exponential runtime in this new algorithm (since we're now 
collecting both
sibling-relative and parent-relative selectors), we also plumb a `HashMap` as 
we're recursively
walking up the tree for each element, which we use to memoize 
`selectorForElementRecursive`. This
ensures `O(n^2)` performance in the worst case, where `n` is the number of 
nodes in the DOM (since
each visit could potentially trigger a `querySelector(…)` with class or tag 
names), but in practice,
means we'll typically get away with `O(n)`, since we'll stop after hitting the 
first ancestor or
sibling element with unique classes or IDs per target, and are typically a 
small number of targets.

* LayoutTests/fast/element-targeting/prefer-succinct-selectors-expected.txt: 
Added.
* LayoutTests/fast/element-targeting/prefer-succinct-selectors.html: Added.

Add a new layout test to exercise the "prefers conciseness" part of selector 
finding.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::computeIDSelector):
(WebCore::computeClassSelector):
(WebCore::shortestSelector):
(WebCore::selectorForElementRecursive):
(WebCore::siblingRelativeSelectorRecursive):
(WebCore::parentRelativeSelectorRecursive):

See above for more details.

(WebCore::selectorsForTarget):
(WebCore::targetedElementInfo):
(WebCore::ElementTargetingController::findTargets):

Canonical link: https://commits.webkit.org/277270@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a64bd: Unreviewed. Update OptionsWPE.cmake and NEWS for t...

[Adrian Perez]

  Branch: refs/tags/wpewebkit-2.44.1
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a64bdf6ebd8cdef7487714a38ae72646e9df5ce
  
https://github.com/WebKit/WebKit/commit/5a64bdf6ebd8cdef7487714a38ae72646e9df5ce
  Author: Adrian Perez de Castro 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/wpe/NEWS
M Source/cmake/OptionsWPE.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.44.1 release

* Source/WebKit/wpe/NEWS: Add release notes for 2.44.1.
* Source/cmake/OptionsWPE.cmake: Bump version numbers.

Canonical link: https://commits.webkit.org/274313.130@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 60134b: Refine the mimeType detection for Image Fullscreen...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60134b26c7259eac53c8cbb9cca7ea5887481ea7
  
https://github.com/WebKit/WebKit/commit/60134b26c7259eac53c8cbb9cca7ea5887481ea7
  Author: Etienne Segonzac 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  ---
  Refine the mimeType detection for Image Fullscreen using 
`image->filenameExtension()`
https://bugs.webkit.org/show_bug.cgi?id=272330


Reviewed by Sihui Liu.

For Image Fullscreen, we need a MIME type to build the Quick Look request.
But some images come with a generic `application/octet-stream` MIME
type, yet still display properly inline.

Instead of directly falling back to building a MIME type from the image's URL
extension, use the filename extension generated from the image metadata first.
This should be more reliable.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):

Canonical link: https://commits.webkit.org/277269@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75f3de: Exclude -apple-pay-button from applying to any ele...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75f3ded86715b6a6ab4c4e750a005fae5f9b8e8e
  
https://github.com/WebKit/WebKit/commit/75f3ded86715b6a6ab4c4e750a005fae5f9b8e8e
  Author: Aditya Keerthi 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/css/appearance-apple-pay-button-div-expected.html
A LayoutTests/fast/css/appearance-apple-pay-button-div.html
A 
LayoutTests/fast/css/appearance-apple-pay-button-inapplicable-expected.html
A LayoutTests/fast/css/appearance-apple-pay-button-inapplicable.html
A 
LayoutTests/fast/css/appearance-apple-pay-button-input-type-button-expected.html
A LayoutTests/fast/css/appearance-apple-pay-button-input-type-button.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  ---
  Exclude -apple-pay-button from applying to any element that supports 
appearance: auto and is not a button
https://bugs.webkit.org/show_bug.cgi?id=272366
rdar://126107516

Reviewed by Tim Nguyen.

`appearance: -apple-pay-button` is non-standard, and must be maintained for
compatibility. However, it is not necessary for elements that already have an
`auto` appearance, and are not buttons, to support the non-standard value.

* LayoutTests/TestExpectations:
* LayoutTests/fast/css/appearance-apple-pay-button-div-expected.html: Added.
* LayoutTests/fast/css/appearance-apple-pay-button-div.html: Added.
* LayoutTests/fast/css/appearance-apple-pay-button-inapplicable-expected.html: 
Added.
* LayoutTests/fast/css/appearance-apple-pay-button-inapplicable.html: Added.
* 
LayoutTests/fast/css/appearance-apple-pay-button-input-type-button-expected.html:
 Added.
* LayoutTests/fast/css/appearance-apple-pay-button-input-type-button.html: 
Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustAppearanceForElement const):

Ensure that `appearance: -apple-pay-button` remains supported on buttons and
element's that do not have an `auto` appearance, like ``.

`` with no `auto` appearance are excluded. This covers the `hidden`,
`file`, and `image` types, which have no requirement to support

`appearance: -apple-pay-button`.
Canonical link: https://commits.webkit.org/277268@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 813b61: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 813b6197785513c0454ffe1e72c7a54334110c86
  
https://github.com/WebKit/WebKit/commit/813b6197785513c0454ffe1e72c7a54334110c86
  Author: Fujii Hironori 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/277267@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04af54: Warn apps that use KVC on WKWebViewConfiguration a...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04af542fbc0df7e688b6799e1dcdc524d16d8015
  
https://github.com/WebKit/WebKit/commit/04af542fbc0df7e688b6799e1dcdc524d16d8015
  Author: Ben Nham 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebKit/Platform/Logging.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

  Log Message:
  ---
  Warn apps that use KVC on WKWebViewConfiguration about future breakage
https://bugs.webkit.org/show_bug.cgi?id=272358
rdar://125913705

Reviewed by Chris Dumez.

We renamed some ivars in WKWebViewConfiguration in 276117@main. This broke some 
poorly behaved apps
that were accessing ivars on WKWebViewConfiguration via KVC. We'll temporarily 
allow these apps to
continue to function for backwards compat reasons when linking against an older 
SDK, but log a fault
when it happens. When linking against newer SDKs, Foundation will raise an 
exception about trying to
use KVC against a non-existent property for us.

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Platform/Logging.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration setValue:forKey:]):
(-[WKWebViewConfiguration valueForKey:]):

Canonical link: https://commits.webkit.org/277266@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d843b5: Use std::span more in JavaScriptCore

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d843b52783cc145dd09c2f199cd893af38b5e379
  
https://github.com/WebKit/WebKit/commit/d843b52783cc145dd09c2f199cd893af38b5e379
  Author: Chris Dumez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSStringRef.cpp
M Source/JavaScriptCore/API/JSStringRefCF.cpp
M Source/JavaScriptCore/API/OpaqueJSString.h
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/JSONAtomStringCache.h
M Source/JavaScriptCore/runtime/JSONAtomStringCacheInlines.h
M Source/JavaScriptCore/runtime/LiteralParser.cpp
M Source/JavaScriptCore/runtime/RegExp.cpp

  Log Message:
  ---
  Use std::span more in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=272402

Reviewed by Darin Adler.

* Source/JavaScriptCore/API/JSStringRef.cpp:
(JSStringCreateWithCharacters):
(JSStringCreateWithUTF8CString):
* Source/JavaScriptCore/API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
* Source/JavaScriptCore/API/OpaqueJSString.h:
(OpaqueJSString::create):
(OpaqueJSString::OpaqueJSString):
(OpaqueJSString::m_characters): Deleted.
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
* Source/JavaScriptCore/runtime/JSONAtomStringCache.h:
(JSC::JSONAtomStringCache::makeIdentifier):
* Source/JavaScriptCore/runtime/JSONAtomStringCacheInlines.h:
(JSC::JSONAtomStringCache::make):
* Source/JavaScriptCore/runtime/LiteralParser.cpp:
(JSC::LiteralParser::makeIdentifier):
* Source/JavaScriptCore/runtime/RegExp.cpp:
(JSC::escapePattern):
(JSC::RegExp::escapedPattern const):

Canonical link: https://commits.webkit.org/277265@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6da11: Indexed access on ASCIILiteral should be bounds-ch...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6da11826336336fb7fa9cbb748d3166946e5a96
  
https://github.com/WebKit/WebKit/commit/b6da11826336336fb7fa9cbb748d3166946e5a96
  Author: Chris Dumez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/text/ASCIILiteral.h

  Log Message:
  ---
  Indexed access on ASCIILiteral should be bounds-checked
https://bugs.webkit.org/show_bug.cgi?id=272399

Reviewed by Keith Miller and Darin Adler.

Indexed access on ASCIILiteral should be bounds-checked for safety.

It was previously possible to do indexed access on an ASCIILiteral,
despite its lack of `operator[]()`, due to the following operator:
```
constexpr operator const char*() const;
```

Upon indexed access, the ASCIILiteral would get implicitly converted
to a `const char*` and the index would thus not be bounds checked.

To address the issue, we now provide an explicit `operator[]()` which
does indexed access on our internal std::span (which does bounds check).

This tested as performance neutral on the benchmarks we track.

* Source/WTF/wtf/text/ASCIILiteral.h:

Canonical link: https://commits.webkit.org/277264@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3d5ca0: Fix BBQ JIT handling of remu(x, -1)

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d5ca0a9487692276e62ca70fa01a426bad06aeb
  
https://github.com/WebKit/WebKit/commit/3d5ca0a9487692276e62ca70fa01a426bad06aeb
  Author: Marcus Plutowski 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A JSTests/wasm/stress/remainder-by-constant-plusminus-1.js
M Source/JavaScriptCore/wasm/WasmBBQJIT64.h

  Log Message:
  ---
  Fix BBQ JIT handling of remu(x, -1)
https://bugs.webkit.org/show_bug.cgi?id=272346
rdar://121010056

Reviewed by Yusuke Suzuki.

The optimization emitModOrDiv was zeroing out the result whenever the
modulus was -1; this is only valid for signed operations, as for
unsigned modulus the above is equivalent to % UINT~_MAX, which does not
generally equal 0.

* JSTests/wasm/stress/remainder-by-constant-plusminus-1.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.h:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitModOrDiv):

Canonical link: https://commits.webkit.org/277263@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e1d51: Allow subclasses of WKWebViewConfiguration again

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e1d510b054f71f8611cce938af3793192e94516
  
https://github.com/WebKit/WebKit/commit/2e1d510b054f71f8611cce938af3793192e94516
  Author: Alex Christensen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
M Source/WebKit/UIProcess/API/APIPageConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm

  Log Message:
  ---
  Allow subclasses of WKWebViewConfiguration again
https://bugs.webkit.org/show_bug.cgi?id=272406
rdar://125931255

Reviewed by Ben Nham.

In 276566@main I made WKWebViewConfiguration just a wrapper around 
API::PageConfiguration
but I also changed the implementation of copyWithZone, which can be implemented 
and used
by subclasses, to be incompatible with that.  WKWebView already has an ivar for 
the actual
ObjC WKWebViewConfiguration or subclass.  This small change makes using that 
once again
possible.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(-[SubclassWebViewConfiguration subclassData]):
(-[SubclassWebViewConfiguration setSubclassData:]):
(-[SubclassWebViewConfiguration copyWithZone:]):
(TEST(WebKit, ConfigurationSubclass)):

Canonical link: https://commits.webkit.org/277262@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c6736: Web Inspector: Console code completion doesn't sug...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c6736f3f9ad8508918c6a2c2ece135498603d9c
  
https://github.com/WebKit/WebKit/commit/5c6736f3f9ad8508918c6a2c2ece135498603d9c
  Author: Qianlang Chen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A LayoutTests/inspector/console/js-completions-expected.txt
A LayoutTests/inspector/console/js-completions.html
M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
M 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
M 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js
M Source/WebInspectorUI/UserInterface/Test.html

  Log Message:
  ---
  Web Inspector: Console code completion doesn't suggest variables unless 
inspector is re-opened
rdar://125035133
https://bugs.webkit.org/show_bug.cgi?id=271265

Reviewed by Devin Rousso.

In the current JavaScriptRuntimeCompletionProvider, there's work done
to cache the list of property names present in the runtime. This
property name cache is cleared / forced to be re-fetched either when 30
seconds have passed or when the code typed starts accessing a different
object's properties (the object to the left of a dot operator). However,
when variables are created by executing a command, the cache is not
updated, resulting in those new variables missing from the suggestions.

This commit simply makes it so that executing a command from the console
also forces clearing the cache, so that new variables, in case created,
are immediately collected as suggestions when typing a new command. The
cache is also cleared when the console clears, so when the page is
reloaded with the console opened, the variable completion still gets
properly reset.

* 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WI.JavaScriptRuntimeCompletionProvider):
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
   - Update the comment on the need of loading the list of property
 names from cache to reflect now there can be additional
 opportunities that the cache should be cleared.
   - Remove the `// Protected` section comment as this function is
 accessed by others.

(WI.JavaScriptRuntimeCompletionProvider):
(WI.JavaScriptRuntimeCompletionProvider.prototype.clearCachedPropertyNames):
(WI.JavaScriptRuntimeCompletionProvider.prototype._clearLastProperties): Deleted
   - Expose the logic of clearing the property name cache so that the
 completion provider's users can also force a reload of property
 names.

(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.updateLastPropertyNames):
   - Adapt to the cache-clearing logic being exposed to public.

* 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
   - Clear cached property names whenever a new command is executed in
 the console, since new commands are what can possibly introduce
 changes to existing variables (additions from `x = ...` or `let x`,
 and deletions from `delete x`).

* Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.messagesCleared):
   - Clear cached property names when the console is cleared because the
 page might've been reloaded and therefore variables were reset
 as a result.

* Source/WebInspectorUI/UserInterface/Test.html:
* LayoutTests/inspector/console/js-completions.html: Added.
* LayoutTests/inspector/console/js-completions-expected.txt: Added.
   - Add a simple test to demonstrate how `clearCachedPropertyNames`
 is used.

Canonical link: https://commits.webkit.org/277261@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7516bd: Grant should be invalidated on the granter queue

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7516bd41dd6f4d02ab5e85bd29c71eda6dd6e5c6
  
https://github.com/WebKit/WebKit/commit/7516bd41dd6f4d02ab5e85bd29c71eda6dd6e5c6
  Author: Per Arne Vollan 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h
M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm
M Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.mm

  Log Message:
  ---
  Grant should be invalidated on the granter queue
https://bugs.webkit.org/show_bug.cgi?id=272398
rdar://125984025

Reviewed by Chris Dumez.

Grant should be invalidated on the granter queue and not on the main thread.

* Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h:
* Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm:
(WebKit::ExtensionCapabilityGrant::operator=): Deleted.
* Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.mm:
(WebKit::finalizeGrant):

Canonical link: https://commits.webkit.org/277260@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b538c7: LinkText and VisitedText system colors doesn't obe...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b538c70c4d25f6ed285f69728f78a54cb4b9ad14
  
https://github.com/WebKit/WebKit/commit/b538c70c4d25f6ed285f69728f78a54cb4b9ad14
  Author: Luke Warlow 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/mac/RenderThemeMac.mm

  Log Message:
  ---
  LinkText and VisitedText system colors doesn't obey color scheme
https://bugs.webkit.org/show_bug.cgi?id=272299

Reviewed by Tim Nguyen.

Change LinkText and VisitedText CSS system colors to use a different value when 
the used color scheme is dark.
The chosen colors are the same as `-webkit-link` and are what is expected by 
WPT tests.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor const):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):

Canonical link: https://commits.webkit.org/277259@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1cece1: [JSC] Add some fast path to Object.is

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cece1c3565e74d68509aa7b14592138754be400
  
https://github.com/WebKit/WebKit/commit/1cece1c3565e74d68509aa7b14592138754be400
  Author: Yusuke Suzuki 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A JSTests/microbenchmarks/object-is-object.js
M JSTests/stress/arguments-define-property-throws-out-of-memory.js
M Source/JavaScriptCore/jit/ThunkGenerators.cpp
M Source/JavaScriptCore/jit/ThunkGenerators.h
M Source/JavaScriptCore/runtime/JSCJSValueInlines.h
M Source/JavaScriptCore/runtime/VM.cpp

  Log Message:
  ---
  [JSC] Add some fast path to Object.is
https://bugs.webkit.org/show_bug.cgi?id=272375
rdar://126115187

Reviewed by Alexey Shvayka.

We found some use of Object.is's baseline function. So this patch adds a fast 
path in front of C++ function.

With explicitly disabling DFG JIT, we can see the following result.

 ToT Patched

object-is-object   56.3458+-0.2533 ^ 49.5551+-0.2161^ 
definitely 1.1370x faster

JSTests/microbenchmarks/object-is-object.js is updated because we no longer 
ensure that sameValue will always resolve strings. That assumption is wrong.

* JSTests/microbenchmarks/object-is-object.js: Added.
(test):
* Source/JavaScriptCore/jit/ThunkGenerators.cpp:
(JSC::objectIsThunkGenerator):
* Source/JavaScriptCore/jit/ThunkGenerators.h:
* Source/JavaScriptCore/runtime/JSCJSValueInlines.h:
(JSC::sameValue):
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):

Canonical link: https://commits.webkit.org/277258@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1b1ca4: [web-animations] changing the value of a transform...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b1ca4437c16d15f3c9ef82ae0a103e71017678e
  
https://github.com/WebKit/WebKit/commit/1b1ca4437c16d15f3c9ef82ae0a103e71017678e
  Author: Antoine Quint 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A 
LayoutTests/webanimations/accelerated-translate-animation-underlying-value-changed-in-flight-expected.html
A 
LayoutTests/webanimations/accelerated-translate-animation-underlying-value-changed-in-flight.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h

  Log Message:
  ---
  [web-animations] changing the value of a transform property while that 
property is animated with an implicit keyframe does not update the animation
https://bugs.webkit.org/show_bug.cgi?id=272387

Reviewed by Dean Jackson.

Ensure we re-compute accelerated animations targeting a transform-related 
property if it uses an implicit keyframe.

* 
LayoutTests/webanimations/accelerated-translate-animation-underlying-value-changed-in-flight-expected.html:
 Added.
* 
LayoutTests/webanimations/accelerated-translate-animation-underlying-value-changed-in-flight.html:
 Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::propertiesContainTransformRelatedProperty):
(WebCore::KeyframeEffect::isRunningAcceleratedTransformRelatedAnimation const):
(WebCore::KeyframeEffect::transformRelatedPropertyDidChange):
(WebCore::KeyframeEffect::isTargetingTransformRelatedProperty const): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/277257@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a08c3d: [css-animations] css/css-animations/animate-with-c...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a08c3d1966f92e32a037a51a30b99567a536cd4b
  
https://github.com/WebKit/WebKit/commit/a08c3d1966f92e32a037a51a30b99567a536cd4b
  Author: Antoine Quint 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/css3/color/color-function-computed-style-expected.txt
M LayoutTests/css3/color/color-function-computed-style.html
M LayoutTests/css3/color/color-function-parsing-expected.txt
M LayoutTests/css3/color/color-function-parsing.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/animations/animate-with-color-mix-expected.txt
M LayoutTests/platform/ios/fast/forms/basic-inputs-expected.txt
M LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt
M LayoutTests/platform/ios/fast/forms/basic-textareas-quirks-expected.txt
M LayoutTests/platform/ios/fast/forms/input-appearance-disabled-expected.txt
M LayoutTests/platform/ios/fast/forms/input-disabled-color-expected.txt
M 
LayoutTests/platform/ios/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt
M LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt
M 
LayoutTests/platform/ios/fast/forms/textarea-placeholder-pseudo-style-expected.txt
M LayoutTests/platform/mac-ventura/fast/forms/basic-inputs-expected.txt
M 
LayoutTests/platform/mac-ventura/fast/forms/input-disabled-color-expected.txt
M 
LayoutTests/platform/mac-ventura/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt
M 
LayoutTests/platform/mac-ventura/fast/forms/placeholder-pseudo-style-expected.txt
M LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt
M LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
M LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
M LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt
M LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt
M 
LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt
M LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt
M 
LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt
M Source/WebCore/platform/graphics/ColorSerialization.cpp

  Log Message:
  ---
  [css-animations] css/css-animations/animate-with-color-mix.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=272083

Reviewed by Anne van Kesteren and Darin Adler.

The `assert_oklab_color()` function in `css/support/color-testcommon.js` 
rejected our serialization
for `oklab()` colors because they included scientific notation. Indeed, this is 
incorrect, since CSS
numbers ought not be serialized using scientific notation, as the css-color 
spec indicates [0]:

The component values are serialized in base 10; the L, a, b and C component 
values are serialized as 

And the CSSOM spec indicates the following for serialization of `` [1]:

A base-ten number using digits 0-9 (U+0030 to U+0039) in the shortest form 
possible, using “.” to
separate decimals (if any), rounding the value if necessary to not produce 
more than 6 decimals,
preceded by “-” (U+002D) if it is negative.
NOTE: scientific notation is not used.

Credit to Anne van Kesteren for pointing out the relevant spec text here and 
find the root cause
of this issue. So all we needed to do was change the way we serialized 
`oklab()` and `oklch()` colors.

This change required some rebaselining or the addition of fuzzy comparison in 
the case of the WPT
test `css/css-color/parsing/color-valid-color-mix-function.html`.

[0] https://drafts.csswg.org/css-color-4/#serializing-oklab-oklch
[1] https://drafts.csswg.org/cssom/#serializing-css-values

* LayoutTests/css3/color/color-function-computed-style-expected.txt:
* LayoutTests/css3/color/color-function-computed-style.html:
* LayoutTests/css3/color/color-function-parsing-expected.txt:
* LayoutTests/css3/color/color-function-parsing.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animate-with-color-mix-expected.txt:
* 

[webkit-changes] [WebKit/WebKit] afd13a: [Gardening]: [ BigSur wk2 Release ] REGRESSION: fa...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afd13aa5fc400dfa2a5b3d70d48ac7855f39dfba
  
https://github.com/WebKit/WebKit/commit/afd13aa5fc400dfa2a5b3d70d48ac7855f39dfba
  Author: Ben Schwartz 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening]: [ BigSur wk2 Release ] REGRESSION: 
fast/canvas/canvas-blending-text.html and 
fast/canvas/canvas-composite-text-alpha.html are flaky failing
https://bugs.webkit.org/show_bug.cgi?id=230366
rdar://83207621

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/277255@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ef7c99: [iOS] fast/writing-mode/english-bt-text-with-spell...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef7c999e5c101b9113bb61a3002942f86f99f089
  
https://github.com/WebKit/WebKit/commit/ef7c999e5c101b9113bb61a3002942f86f99f089
  Author: Wenson Hsieh 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html
M LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html

  Log Message:
  ---
  [iOS] fast/writing-mode/english-bt-text-with-spelling-marker.html is a flaky 
failure after 277233@main
https://bugs.webkit.org/show_bug.cgi?id=272395

Reviewed by Aditya Keerthi.

After the changes in 277233@main, spelling dots are now showing up on iOS, in 
this test; this causes
a very slight image diff, as the direction of the gradient differs slightly 
between the reference
and test.

Fix this by adjusting the `maxDifference` to accommodate iOS 17, and also 
adjust the test itself to
reliably show spelling dots by adding `spellCheckingDots=true` as a test 
option, and also use
`UIHelper.setSpellCheckerResults` to force spellchecking to detect 
`"mispelled"` as a misspelled
word.

* 
LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
* LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:

Canonical link: https://commits.webkit.org/277254@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21882d: AX: Change AXCoreObject::selectedChildren() to ret...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21882dfaf5128256d146617f5eb1a64a647741b1
  
https://github.com/WebKit/WebKit/commit/21882dfaf5128256d146617f5eb1a64a647741b1
  Author: Andres Gonzalez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac/accessibility/lists-expected.txt
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityListBox.cpp
M Source/WebCore/accessibility/AccessibilityListBox.h
M Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp
M Source/WebCore/accessibility/AccessibilityMenuListPopup.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp

  Log Message:
  ---
  AX: Change AXCoreObject::selectedChildren() to return an optional instead of 
an empty Vector.
https://bugs.webkit.org/show_bug.cgi?id=272340


Reviewed by Tyler Wilcock.

This allows to remove canHaveSelectedChildren from the AXCoreObject interface 
and avoid multiple calls to it in platform wrapper code.

* LayoutTests/platform/mac/accessibility/lists-expected.txt:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::canHaveSelectedChildren const): Deleted.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::selectedChildren):
* Source/WebCore/accessibility/AccessibilityListBox.h:
* Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::selectedChildren):
* Source/WebCore/accessibility/AccessibilityMenuListPopup.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textAsLabelFor const):
(WebCore::AccessibilityNodeObject::stringValue const):
(WebCore::accessibleNameForNode):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::canHaveSelectedChildren const):
(WebCore::AccessibilityObject::selectedChildren):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::interfacesForObject):
* Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::selectionCount const):
(WebCore::AccessibilityObjectAtspi::selectedChild const):
(WebCore::AccessibilityObjectAtspi::deselectSelectedChild const):
(WebCore::AccessibilityObjectAtspi::selectAll const):
(WebCore::AccessibilityObjectAtspi::clearSelection const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::selectedChildren):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getSelectedChildNodes):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Canonical link: https://commits.webkit.org/277253@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d657a: [resultsdbpy] Handle retro-spective dashboard

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d657a94aa29fb75b6722dd16b7b2ca41562347a
  
https://github.com/WebKit/WebKit/commit/8d657a94aa29fb75b6722dd16b7b2ca41562347a
  Author: Jonathan Bedard 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js

  Log Message:
  ---
  [resultsdbpy] Handle retro-spective dashboard
https://bugs.webkit.org/show_bug.cgi?id=272397
rdar://126135192

Reviewed by Elliott Williams.

When a user requests a dashboard from the past, we should set 'now' based on
the time range the user requested, so we don't end up classify all queues as
exceeding our freshness threshold.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js:
(Dashboard.prototype.setTilesFromData): Determine "now" based on any 'before_'
parameters.

Canonical link: https://commits.webkit.org/277252@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ab862: Optimize RenderBox::contentBoxRect()

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ab862354f2a6c2eac2b73b3de555c40660d30f0
  
https://github.com/WebKit/WebKit/commit/9ab862354f2a6c2eac2b73b3de555c40660d30f0
  Author: Simon Fraser 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBoxInlines.h

  Log Message:
  ---
  Optimize RenderBox::contentBoxRect()
https://bugs.webkit.org/show_bug.cgi?id=272372
rdar://126114704

Reviewed by Alan Baradlay.

`contentBoxRect()` called `contentBoxLocation()` and `contentSize()` and both 
fan out into
calls involving scrollbar gutter and scrollbar width which are repetitive. So 
replace with
a single function that fetches all the input values without redundancy.

* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::computedCSSContentBoxRect const):
(WebCore::RenderBox::contentBoxRect const):

Canonical link: https://commits.webkit.org/277251@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d9a1a4: [RenderTreeBuilder] Stop updating visual milestone...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9a1a427397178f659598d4d0558b61252b7a0c3
  
https://github.com/WebKit/WebKit/commit/d9a1a427397178f659598d4d0558b61252b7a0c3
  Author: Alan Baradlay 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  ---
  [RenderTreeBuilder] Stop updating visual milestones with tree content after 
passing threshold
https://bugs.webkit.org/show_bug.cgi?id=272370

Reviewed by Antti Koivisto.

* Source/WebCore/page/LocalFrameView.h:
(WebCore::LocalFrameView::hasEnoughContentForVisualMilestones const):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::reportVisuallyNonEmptyContent):

Canonical link: https://commits.webkit.org/277250@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 353a20: Use std::span and char8_t for UTF-8

[Darin Adler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 353a203b0b4c5c758073d49979f100c4f354ed53
  
https://github.com/WebKit/WebKit/commit/353a203b0b4c5c758073d49979f100c4f354ed53
  Author: Darin Adler 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSStringRef.cpp
M Source/JavaScriptCore/wasm/WasmFormat.cpp
M Source/JavaScriptCore/wasm/WasmName.h
M Source/JavaScriptCore/wasm/WasmParser.h
M Source/JavaScriptCore/wasm/WasmSectionParser.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp
M Source/WTF/wtf/text/AtomStringImpl.cpp
M Source/WTF/wtf/text/StringConcatenate.h
M Source/WTF/wtf/text/WTFString.cpp
M Source/WTF/wtf/unicode/UTF8Conversion.cpp
M Source/WTF/wtf/unicode/UTF8Conversion.h
M Source/WebCore/workers/ScriptBuffer.cpp
M Source/WebCore/xml/XSLTProcessorLibxslt.cpp

  Log Message:
  ---
  Use std::span and char8_t for UTF-8
https://bugs.webkit.org/show_bug.cgi?id=271527
rdar://problem/125298503

Reviewed by Chris Dumez.

An advantage of using char8_t is that it expresses the fact that
the characters are UTF-8, so we can just use std::span
instead of things like FromUTF8. Also, makeString never returns
a null string, which turns out to be what many of these callers
want, so we save code.

* Source/JavaScriptCore/API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Cast to char8_t.

* Source/JavaScriptCore/wasm/WasmFormat.cpp:
(JSC::Wasm::makeString): Use makeString instead of String::fromUTF8.

* Source/JavaScriptCore/wasm/WasmName.h: Use char8_t.

* Source/JavaScriptCore/wasm/WasmParser.h:
(JSC::Wasm::Parser::fail const): Remove unneeded call to String::number.
(JSC::Wasm::Parser::consumeUTF8String): Use span and
spanReinterpretCast.

* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseExport): Use makeString instead of
String::fromUTF8.

* Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::tryCreate): Use makeAtomString instead of
String::fromUTF8.
* Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:
(JSC::JSWebAssemblyModule::finishCreation): Ditto.

* Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::webAssemblyModuleCustomSections): Use makeString instead of
String::fromUTF8.
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::finishCreation): Ditto.
(JSC::WebAssemblyModuleRecord::initializeImports): Take advantage of
the fact that makeString already handles this without calling
String::UTF8, and call makeAtomString instead of String::fromUTF8..
(JSC::WebAssemblyModuleRecord::initializeExports): Ditto.

* Source/WTF/wtf/text/AtomStringImpl.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Cast to char8_t.

* Source/WTF/wtf/text/StringConcatenate.h: Renamed FromUTF8 to UTF8Adapter
since there is little need to use it directly any more. Use char8_t instead
of char. Added a specialization for span that uses the UTF8Adapter.

* Source/WTF/wtf/text/WTFString.cpp:
(WTF::fromUTF8Impl): Use spanReinterpretCast.

* Source/WTF/wtf/unicode/UTF8Conversion.cpp:
(WTF::Unicode::convertUTF8ToUTF16Impl): Use std::span.
(WTF::Unicode::convertUTF8ToUTF16): Ditto.
(WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences): Ditto.
(WTF::Unicode::computeUTFLengths): Ditto.
* Source/WTF/wtf/unicode/UTF8Conversion.h: Ditto.

* Source/WebCore/workers/ScriptBuffer.cpp:
(WebCore::ScriptBuffer::toString const): Use
spanReinterpretCast.

* Source/WebCore/xml/XSLTProcessorLibxslt.cpp:
(WebCore::writeToStringBuilder): Update to use UTF8Adapter.

Canonical link: https://commits.webkit.org/277249@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e1188: Build failures in GeneratedSerializers.cpp in rele...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e1188405ef911ce4b48969b3dcfdf6397cab1e7
  
https://github.com/WebKit/WebKit/commit/2e1188405ef911ce4b48969b3dcfdf6397cab1e7
  Author: Michael Catanzaro 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/ThreadSafeRefCounted.h

  Log Message:
  ---
  Build failures in GeneratedSerializers.cpp in release builds with assertions 
enabled
https://bugs.webkit.org/show_bug.cgi?id=271997

Reviewed by Chris Dumez.

This matches the condition to determine whether assertions are enabled with 
RefCounted.h. It's a better condition anyway.

* Source/WTF/wtf/ThreadSafeRefCounted.h:

Canonical link: https://commits.webkit.org/277248@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 65a5cb: [JSC] List common types in JSCast's listing

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65a5cb3135b456521093b1f2ad0cbb47f0917b9e
  
https://github.com/WebKit/WebKit/commit/65a5cb3135b456521093b1f2ad0cbb47f0917b9e
  Author: Yusuke Suzuki 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/JSCast.h

  Log Message:
  ---
  [JSC] List common types in JSCast's listing
https://bugs.webkit.org/show_bug.cgi?id=272376
rdar://126116345

Reviewed by Keith Miller.

This patch adds some more common types to JSCast's listing.

* Source/JavaScriptCore/runtime/JSCast.h:

Canonical link: https://commits.webkit.org/277247@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 392913: Enable WebGPU in WebKitTestRunner

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3929136b4e632a0734bacadee8e164e28abde80e
  
https://github.com/WebKit/WebKit/commit/3929136b4e632a0734bacadee8e164e28abde80e
  Author: Alex Christensen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt
M LayoutTests/fast/webgpu/accelerated-image-conversion-failure.html
M LayoutTests/fast/webgpu/bind-group-layout-invalid.html
M LayoutTests/fast/webgpu/command-buffer-after-destruction.html
M LayoutTests/fast/webgpu/conversion-to-rg8unorm.html
M LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html
M LayoutTests/fast/webgpu/forbid-bottom-struct-member.html
M LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel.html
M LayoutTests/fast/webgpu/invalid-surface-height.html
M LayoutTests/fast/webgpu/multidimensional-texture-bounds.html
M LayoutTests/fast/webgpu/null-video-texture.html
M LayoutTests/fast/webgpu/optional-media-identifier.html
M LayoutTests/fast/webgpu/present-without-compute-pipeline.html
M LayoutTests/fast/webgpu/queue-write-texture-offset.html
M LayoutTests/fast/webgpu/render-bundle-validation-color-format.html
M LayoutTests/fast/webgpu/repeated-out-of-memory-error.html
M LayoutTests/fast/webgpu/type-checker-array-without-argument.html
M LayoutTests/fast/webgpu/use-canvas-without-layer.html
M LayoutTests/fast/webgpu/write-to-destroyed-buffer.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt
M LayoutTests/platform/ios/TestExpectations
M 
LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt
M LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt
M 
LayoutTests/platform/wincairo/fast/dom/navigator-detached-no-crash-expected.txt
M LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCreateImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCreateImpl.h
M Source/WebGPU/WebGPU/Instance.h
M Source/WebGPU/WebGPU/PresentationContextIOSurface.h
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
M Tools/TestRunnerShared/TestFeatures.cpp
M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  ---
  Enable WebGPU in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=271744
rdar://125823851

Reviewed by Mike Wyrzykowski.

For some unknown and mysterious reason, enabling it in 
hardcodedFeaturesBasedOnPathForTest
was insufficient to actually enable WebGPU in WebKitTestRunner.  There's no 
reason to limit
its existence to just WebGPU tests.  Let's enable it in all tests.

I had written several tests with extra try/catch statements to work if WebGPU 
was enabled
or not.  Now that it's enabled in WebKitTestRunner, I can remove these and make 
the tests
more effective in catching regressions.

In order to make the tests run to completion on computers with different GPUs 
made by different
manufacturers, I had to reduce all the maxBindingsPerBindGroup values to less 
than 1000,
remove all requirements to have etc2 and astc texture compression extensions, 
and use a
more commonly supported texture format, which I arbitrarily chose to be 
rgb9e5ufloat.
Also minStorageBufferOffsetAlignment and minUniformBufferOffsetAlignment need 
to be 256.
These things were unrelated to the original issues for which I introduced the 
tests.

The iOS simulator is unfortunately currently unable to run WebGPU tests, so I 
skip them there.

In order to fix assertions in debug builds, I changed some types from 
CompletionHandler
to Function because StreamConnectionWorkQueue::dispatch is not actually 
guaranteed
to call the function if m_shouldQuit ever becomes true because 
stopAndWaitForCompletion is called.

* LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/fast/webgpu/accelerated-image-conversion-failure.html:
* LayoutTests/fast/webgpu/bind-group-layout-invalid.html:
* LayoutTests/fast/webgpu/command-buffer-after-destruction.html:
* LayoutTests/fast/webgpu/conversion-to-rg8unorm.html:
* LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html:
* LayoutTests/fast/webgpu/forbid-bottom-struct-member.html:
* LayoutTests/fast/webgpu/image-data-8-bytes-per-pixel.html:
* LayoutTests/fast/webgpu/invalid-surface-height.html:
* LayoutTests/fast/webgpu/multidimensional-texture-bounds.html:
* LayoutTests/fast/webgpu/null-video-texture.html:
* LayoutTests/fast/webgpu/optional-media-identifier.html:
* LayoutTests/fast/webgpu/present-without-compute-pipeline.html:
* LayoutTests/fast/webgpu/queue-write-texture-offset.html:
* LayoutTests/fast/webgpu/render-bundle-validation-color-format.html:
* 

[webkit-changes] [WebKit/WebKit] 56976d: Further adopt std::span in StringCommon.h

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56976d0ea5cb10b6e37488ea790e12118764e41b
  
https://github.com/WebKit/WebKit/commit/56976d0ea5cb10b6e37488ea790e12118764e41b
  Author: Chris Dumez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/IntlLocale.cpp
M Source/JavaScriptCore/runtime/StringPrototype.cpp
M Source/WTF/wtf/DateMath.cpp
M Source/WTF/wtf/text/StringCommon.h
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/StringView.h
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/html/parser/ParsingUtilities.h
M Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
M Source/WebCore/platform/SharedStringHash.cpp

  Log Message:
  ---
  Further adopt std::span in StringCommon.h
https://bugs.webkit.org/show_bug.cgi?id=272338

Reviewed by Darin Adler.

* Source/JavaScriptCore/runtime/IntlLocale.cpp:
(JSC::IntlLocale::maximal):
(JSC::IntlLocale::minimal):
* Source/JavaScriptCore/runtime/StringPrototype.cpp:
(JSC::splitStringByOneCharacterImpl):
* Source/WTF/wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
* Source/WTF/wtf/text/StringCommon.h:
(WTF::span):
(WTF::span8):
* Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
* Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::span const):
(WTF::StringImpl::find):
* Source/WTF/wtf/text/StringView.h:
(WTF::StringView::find const):
(WTF::findCommon):
(WTF::findIgnoringASCIICase):
(WTF::startsWithIgnoringASCIICase):
(WTF::endsWithIgnoringASCIICase):
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseTransformTranslateArguments):
(WebCore::parseTransformAngleArgument):
(WebCore::parseTransformNumberArguments):
(WebCore::transformCanLikelyUseFastPath):
* Source/WebCore/html/parser/ParsingUtilities.h:
(WebCore::skipExactlyIgnoringASCIICase):
* Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::parseHeader):
* Source/WebCore/platform/SharedStringHash.cpp:
(WebCore::mergeDoubleSlashes):

Canonical link: https://commits.webkit.org/277245@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0f5f1f: Adopt std::span in HTMLParserIdioms.cpp

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f5f1f492230ba3b45fa3f5ce17d780696b1ad57
  
https://github.com/WebKit/WebKit/commit/0f5f1f492230ba3b45fa3f5ce17d780696b1ad57
  Author: Chris Dumez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/html/parser/HTMLParserIdioms.cpp
M Source/WebCore/html/parser/ParsingUtilities.h

  Log Message:
  ---
  Adopt std::span in HTMLParserIdioms.cpp
https://bugs.webkit.org/show_bug.cgi?id=272374

Reviewed by Anne van Kesteren and Darin Adler.

* Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLIntegerInternal):
(WebCore::parseHTMLInteger):
(WebCore::parseValidHTMLNonNegativeIntegerInternal):
(WebCore::parseValidHTMLNonNegativeInteger):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTTPRefreshInternal):
(WebCore::parseMetaHTTPEquivRefresh):
(WebCore::parseHTMLDimensionNumber):
(WebCore::parseHTMLDimensionInternal):
* Source/WebCore/html/parser/ParsingUtilities.h:
(WebCore::skipExactly):
(WebCore::characterPredicate):

Canonical link: https://commits.webkit.org/277244@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a38690: Update `typing-00*` tests from Blink / Chromium so...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a38690418a32ae0c2031bcdd470533eb688cbc56
  
https://github.com/WebKit/WebKit/commit/a38690418a32ae0c2031bcdd470533eb688cbc56
  Author: Ahmad Saleem 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
R LayoutTests/editing/inserting/typing-001-expected.txt
R LayoutTests/editing/inserting/typing-001.html
R LayoutTests/editing/inserting/typing-002.html
R LayoutTests/editing/inserting/typing-003-expected.txt
R LayoutTests/editing/inserting/typing-003.html
A LayoutTests/editing/inserting/typing-expected.txt
A LayoutTests/editing/inserting/typing.html
R LayoutTests/platform/gtk/editing/inserting/typing-001-expected.png
R LayoutTests/platform/gtk/editing/inserting/typing-001-expected.txt
R LayoutTests/platform/gtk/editing/inserting/typing-002-expected.png
R LayoutTests/platform/gtk/editing/inserting/typing-002-expected.txt
M LayoutTests/platform/ios/TestExpectations
R LayoutTests/platform/ios/editing/inserting/typing-001-expected.png
R LayoutTests/platform/ios/editing/inserting/typing-002-expected.txt
R LayoutTests/platform/mac/editing/inserting/typing-001-expected.png
R LayoutTests/platform/mac/editing/inserting/typing-002-expected.png
R LayoutTests/platform/mac/editing/inserting/typing-002-expected.txt
M LayoutTests/platform/wincairo/TestExpectations
R LayoutTests/platform/wincairo/editing/inserting/typing-001-expected.txt
R LayoutTests/platform/wincairo/editing/inserting/typing-002-expected.txt

  Log Message:
  ---
  Update `typing-00*` tests from Blink / Chromium source

https://bugs.webkit.org/show_bug.cgi?id=272228

Reviewed by Wenson Hsieh.

Merge: 
https://chromium.googlesource.com/chromium/src.git/+/52e039ba69a827512936f7a9146578560778e519

This changes all `typing-00*` tests into single using `testharness` and 
`assert-selection`,
making them easier to maintain and highlight any platform specific failure 
better.

* LayoutTests/editing/inserting/typing.html:
* LayoutTests/editing/inserting/typing-expected.txt:

> Deleted Tests & Test Expectations:
* LayoutTests/editing/inserting/typing-001.html:
* LayoutTests/editing/inserting/typing-001-expected.txt:
* LayoutTests/editing/inserting/typing-002.html:
* LayoutTests/editing/inserting/typing-003.html:
* LayoutTests/editing/inserting/typing-003-expected.txt:
* LayoutTests/platform/gtk/editing/inserting/typing-001-expected.png:
* LayoutTests/platform/gtk/editing/inserting/typing-001-expected.txt:
* LayoutTests/platform/gtk/editing/inserting/typing-002-expected.png:
* LayoutTests/platform/gtk/editing/inserting/typing-002-expected.txt:
* LayoutTests/platform/ios/editing/inserting/typing-001-expected.png:
* LayoutTests/platform/ios/editing/inserting/typing-002-expected.txt:
* LayoutTests/platform/mac/editing/inserting/typing-001-expected.png:
* LayoutTests/platform/mac/editing/inserting/typing-002-expected.png:
* LayoutTests/platform/mac/editing/inserting/typing-002-expected.txt:
* LayoutTests/platform/wincairo/editing/inserting/typing-001-expected.txt:
* LayoutTests/platform/wincairo/editing/inserting/typing-002-expected.txt:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/277243@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6beb22: Remove incorrect assertion in BrowsingContextGroup...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6beb22fd66bd2e19de4b8668f26df5597f6c49c3
  
https://github.com/WebKit/WebKit/commit/6beb22fd66bd2e19de4b8668f26df5597f6c49c3
  Author: Alex Christensen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  Remove incorrect assertion in BrowsingContextGroup::removePage
https://bugs.webkit.org/show_bug.cgi?id=272377
rdar://126116452

Reviewed by Charlie Wolfe.

We currently don't call BrowsingContextGroup::addPage until the UI process
receives a message that the main frame has been created.  If window.close is
called before then, many API clients will deallocate an opened page immediately.
Add a test for this case and remove the invalid assertion.

* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::removePage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::openerAndOpenedViews):
(TestWebKitAPI::TEST(SiteIsolation, OpenThenClose)):

Canonical link: https://commits.webkit.org/277242@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 112d07: [GTK][WPE] Flush the gl commands after creating th...

[Miguel Gómez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 112d07ea900f527cb07836d9373c08d020f66398
  
https://github.com/WebKit/WebKit/commit/112d07ea900f527cb07836d9373c08d020f66398
  Author: Miguel Gomez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/egl/GLFence.cpp

  Log Message:
  ---
  [GTK][WPE] Flush the gl commands after creating the fence
https://bugs.webkit.org/show_bug.cgi?id=272383

Reviewed by Carlos Garcia Campos.

Call glFlush() after we have created the fence with glFenceSync().

* Source/WebCore/platform/graphics/egl/GLFence.cpp:
(WebCore::GLFence::create):

Canonical link: https://commits.webkit.org/277241@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b08a5: Fix an issue with the background page trying to me...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b08a55102c5ec79db58f6aec9d18056b86c5425
  
https://github.com/WebKit/WebKit/commit/3b08a55102c5ec79db58f6aec9d18056b86c5425
  Author: Brian Weinstein 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  ---
  Fix an issue with the background page trying to message full page extension 
content
https://bugs.webkit.org/show_bug.cgi?id=272362
rdar://125996453

Reviewed by Timothy Hatcher.

When an extension was trying to send a message from a background page to a tab 
with full page extension content, we were treating
the message as going to a content script and sending it to a non-main world, 
which led to a crash.

Additionally, we want to block an extension from sending a message to a tab 
showing full page content for a different extension. One
extension should have no idea about another's content.

* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsSendMessage):
(WebKit::WebExtensionContext::tabsConnect):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::extensionHasPermission const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, 
SendMessageFromBackgroundPageToFullPageExtensionContent)):

Canonical link: https://commits.webkit.org/277240@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 08baee: IPC Testing API: asynchronous stream messages with...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08baee0f736008bb945716a2430aa9a513040f36
  
https://github.com/WebKit/WebKit/commit/08baee0f736008bb945716a2430aa9a513040f36
  Author: Kimmo Kinnunen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A LayoutTests/ipc/async-with-reply-expected.txt
A LayoutTests/ipc/async-with-reply.html
A LayoutTests/ipc/stream-async-with-reply-expected.txt
A LayoutTests/ipc/stream-async-with-reply.html
M LayoutTests/resources/ipc.js
M Source/WebKit/Shared/IPCStreamTester.cpp
M Source/WebKit/Shared/IPCStreamTester.h
M Source/WebKit/Shared/IPCStreamTester.messages.in
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/Shared/IPCTester.h
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  ---
  IPC Testing API: asynchronous stream messages with replies not working
https://bugs.webkit.org/show_bug.cgi?id=272148
rdar://125084127

Reviewed by Ryosuke Niwa.

Implement support for asynchronous replies in JS testing API:
 - JSIPCConnection::sendWithAsyncReply
 - JSIPCConnection::waitForAsyncReplyAndDispatchImmediately
 - JSIPCStreamClientConnection::sendWithAsyncReply
 - JSIPCStreamClientConnection::waitForAsyncReplyAndDispatchImmediately

Previously in JS, the JSIPC object would support sending the async message
and receiving it as a promise. Stream connections would not support it.

Replace it with more consistent connection-specific sendWithAsyncReply
calls that take a callback parameter, similar to C++. Implement the
promise variant in JS side.

This way the async reply id is available for the tests, if they need it.

Organize the code so that the JSIPCConnection and
JSIPCStreamClientConnection share the common implementation in jsSend,
jsSendSync, jsSendWithAsyncReply, jsWaitForMessage,
jsWaitForAsyncReplyAndDispatchImmediately. Organize
JSIPCStreamClientConnection::prepareToSendOutOfStreamMessage to just
prepare the stream connection so that the above common functionality can
then be shared.

* LayoutTests/resources/ipc.js:
(connectionSendWithPromisedReply):
(IPC.sendWithPromisedReply):
(asyncFlush):
* Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::asyncPing):
(WebKit::IPCStreamTester::asyncMessage): Deleted.
* Source/WebKit/Shared/IPCStreamTester.h:
* Source/WebKit/Shared/IPCStreamTester.messages.in:
* Source/WebKit/Shared/IPCTester.cpp:
(WebKit::IPCTester::asyncPing):
* Source/WebKit/Shared/IPCTester.h:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCConnection::create):
(WebKit::IPCTestingAPI::JSIPCConnection::connection const):
(WebKit::IPCTestingAPI::JSIPCConnection::JSIPCConnection):
(WebKit::IPCTestingAPI::createErrorFromIPCError):
(WebKit::IPCTestingAPI::extractSyncIPCMessageInfo):
(WebKit::IPCTestingAPI::jsSend):
(WebKit::IPCTestingAPI::jsSendWithAsyncReply):
(WebKit::IPCTestingAPI::jsSendSync):
(WebKit::IPCTestingAPI::jsWaitForMessage):
(WebKit::IPCTestingAPI::jsWaitForAsyncReplyAndDispatchImmediately):
(WebKit::IPCTestingAPI::JSIPCConnection::staticFunctions):
(WebKit::IPCTestingAPI::JSIPCConnection::sendMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::sendWithAsyncReply):
(WebKit::IPCTestingAPI::JSIPCConnection::sendSyncMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::waitForMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::waitForAsyncReplyAndDispatchImmediately):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::staticFunctions):
(WebKit::IPCTestingAPI::extractIPCStreamMessageInfo):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::prepareToSendOutOfStreamMessage):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendMessage):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendWithAsyncReply):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendSyncMessage):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::waitForMessage):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::waitForAsyncReplyAndDispatchImmediately):
(WebKit::IPCTestingAPI::JSIPC::staticFunctions):
(WebKit::IPCTestingAPI::JSIPC::processTargetFromArgument):
(WebKit::IPCTestingAPI::JSIPC::addMessageListener):
(WebKit::IPCTestingAPI::messageNameFromArgument):
(WebKit::IPCTestingAPI::encodeArgument):
(WebKit::IPCTestingAPI::JSIPC::getConnectionForProcessTarget):
(WebKit::IPCTestingAPI::JSIPC::sendMessage):
(WebKit::IPCTestingAPI::JSIPC::waitForMessage):
(WebKit::IPCTestingAPI::JSIPC::sendSyncMessage):
(WebKit::IPCTestingAPI::sendMessageWithJSArguments): Deleted.
(WebKit::IPCTestingAPI::sendSyncMessageWithJSArguments): Deleted.
(WebKit::IPCTestingAPI::waitForMessageWithJSArguments): Deleted.
(WebKit::IPCTestingAPI::processTargetFromArgument): Deleted.
(WebKit::IPCTestingAPI::messageIDFromArgument): Deleted.
* LayoutTests/ipc/async-with-reply-expected.txt: Added.
* LayoutTests/ipc/async-with-reply.html: Added.
* LayoutTests/ipc/stream-async-with-reply-expected.txt: Added.
* 

[webkit-changes] [WebKit/WebKit] 6473ae: Remove superfluous #ifs in PlatformDisplay.cpp

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6473aecbfaf64662db9114fae7c977d7cdbcc0ee
  
https://github.com/WebKit/WebKit/commit/6473aecbfaf64662db9114fae7c977d7cdbcc0ee
  Author: Ross Kirsling 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/PlatformDisplay.cpp

  Log Message:
  ---
  Remove superfluous #ifs in PlatformDisplay.cpp
https://bugs.webkit.org/show_bug.cgi?id=272385

Reviewed by Adrian Perez de Castro.

* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
Address build fix feedback -- remove `#if !defined` checks for 
PFNEGLCREATEIMAGEPROC and PFNEGLDESTROYIMAGEPROC,
as these typedefs can occur unconditionally.

Canonical link: https://commits.webkit.org/277238@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e11404: Update ANGLE to 2024-04-08 (ba208b45ad1c534fd8e165...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1140406851614ffb375e8b4b6342a9538e59b66
  
https://github.com/WebKit/WebKit/commit/e1140406851614ffb375e8b4b6342a9538e59b66
  Author: Kimmo Kinnunen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/waterfalls.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_internal_shader_programs.json
M Source/ThirdParty/ANGLE/scripts/export_targets.py
M Source/ThirdParty/ANGLE/scripts/run_code_generation.py
M Source/ThirdParty/ANGLE/src/common/WorkerThread.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/BaseTypes.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/BaseTypes.h
M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/OutputGLSLBase.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/OutputGLSLBase.h
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorESSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorGLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/RewritePipelines.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/IntroduceVertexIndexID.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/CLCommandQueue.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/CLCommandQueue.h
M Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Program.h
M Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.h
M Source/ThirdParty/ANGLE/src/libANGLE/cl_types.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/CLCommandQueueImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramExecutableImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/cl/CLCommandQueueCL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/cl/CLCommandQueueCL.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/ProgramD3D.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/ProgramGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/StateManagerGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_msl_utils.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/null/ProgramNULL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLCommandQueueVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLCommandQueueVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLDeviceVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLDeviceVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLKernelVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLKernelVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLProgramVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLProgramVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ContextVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FramebufferVk.h
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ProgramExecutableVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ProgramPipelineVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ProgramVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RenderTargetVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RenderTargetVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolveStencilNoExport.comp..inc
M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/shaders/gen/BlitResolveStencilNoExport.comp.0001.inc
M 

[webkit-changes] [WebKit/WebKit] 5d0121: Update Skia to 2024-04-08 (5b62c0022f92b3fea4fd9b9...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d0121407aba7fc2604b3fb0d2d3ad7c10ca0744
  
https://github.com/WebKit/WebKit/commit/5d0121407aba7fc2604b3fb0d2d3ad7c10ca0744
  Author: Adrian Perez de Castro 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/ThirdParty/skia/.bazelrc
R Source/ThirdParty/skia/.vpython
A Source/ThirdParty/skia/.vpython3
M Source/ThirdParty/skia/AUTHORS
M Source/ThirdParty/skia/BUILD.bazel
M Source/ThirdParty/skia/BUILD.gn
M Source/ThirdParty/skia/CMakeLists.txt
M Source/ThirdParty/skia/DEPS
M Source/ThirdParty/skia/PRESUBMIT.py
M Source/ThirdParty/skia/README.WebKit
M Source/ThirdParty/skia/RELEASE_NOTES.md
M Source/ThirdParty/skia/WORKSPACE.bazel
M Source/ThirdParty/skia/bazel/buildrc
M Source/ThirdParty/skia/bazel/cc_binary_with_flags.bzl
M Source/ThirdParty/skia/bazel/deps.bzl
M Source/ThirdParty/skia/bazel/deps_parser/deps_parser.go
M Source/ThirdParty/skia/bazel/exporter/bazel_query_command.go
M Source/ThirdParty/skia/bazel/exporter/gni_exporter.go
M Source/ThirdParty/skia/bazel/exporter/gni_exporter_test.go
M Source/ThirdParty/skia/bazel/exporter_tool/main.go
M Source/ThirdParty/skia/bazel/external/expat/BUILD.bazel
M Source/ThirdParty/skia/bazel/external/fontations/Cargo.lock
M Source/ThirdParty/skia/bazel/external/fontations/Cargo.toml
M Source/ThirdParty/skia/bazel/external/icu/BUILD.bazel
M Source/ThirdParty/skia/bazel/external/vello/BUILD.bazel
M Source/ThirdParty/skia/bazel/external/vello/Cargo.lock
M Source/ThirdParty/skia/bazel/external/vello/Cargo.toml
M Source/ThirdParty/skia/bazel/skia_rules.bzl
M Source/ThirdParty/skia/bench/BUILD.bazel
M Source/ThirdParty/skia/bench/ColorPrivBench.cpp
M Source/ThirdParty/skia/bench/ControlBench.cpp
M Source/ThirdParty/skia/bench/GeometryBench.cpp
M Source/ThirdParty/skia/bench/MathBench.cpp
M Source/ThirdParty/skia/bench/MatrixBench.cpp
R Source/ThirdParty/skia/bench/ScalarBench.cpp
M Source/ThirdParty/skia/bench/TessellateBench.cpp
M Source/ThirdParty/skia/bench/nanobench.cpp
M Source/ThirdParty/skia/defines.bzl
M Source/ThirdParty/skia/dm/DM.cpp
M Source/ThirdParty/skia/dm/DMSrcSink.cpp
M Source/ThirdParty/skia/example/BUILD.bazel
M Source/ThirdParty/skia/example/external_client/BUILD.bazel
A Source/ThirdParty/skia/example/external_client/src/svg_renderer.cpp
M Source/ThirdParty/skia/experimental/minimal_ios_mtl_skia_app/main.mm
M Source/ThirdParty/skia/experimental/wasm-hello-world/BUILD.bazel
M Source/ThirdParty/skia/fuzz/FuzzDDLThreading.cpp
M Source/ThirdParty/skia/fuzz/oss_fuzz/FuzzSVG.cpp
M Source/ThirdParty/skia/gm/BUILD.bazel
M Source/ThirdParty/skia/gm/asyncrescaleandread.cpp
M Source/ThirdParty/skia/gm/compressed_textures.cpp
M Source/ThirdParty/skia/gm/graphitestart.cpp
M Source/ThirdParty/skia/gm/png_codec.bzl
A Source/ThirdParty/skia/gm/rendertomipmappedyuvimageplanes.cpp
M Source/ThirdParty/skia/gm/trickycubicstrokes.cpp
M Source/ThirdParty/skia/gm/wacky_yuv_formats.cpp
M Source/ThirdParty/skia/gm/yuv420_odd_dim.cpp
M Source/ThirdParty/skia/gm/yuvtorgbsubset.cpp
M Source/ThirdParty/skia/gn/bench.gni
R Source/ThirdParty/skia/gn/flutter_defines.gni
R Source/ThirdParty/skia/gn/gen_plist_ios.py
M Source/ThirdParty/skia/gn/gm.gni
M Source/ThirdParty/skia/gn/gn_to_bp.py
M Source/ThirdParty/skia/gn/gn_to_cmake.py
M Source/ThirdParty/skia/gn/gpu.gni
M Source/ThirdParty/skia/gn/graphite.gni
M Source/ThirdParty/skia/gn/ios.gni
M Source/ThirdParty/skia/gn/skia.gni
M Source/ThirdParty/skia/gn/skia/BUILD.gn
M Source/ThirdParty/skia/gn/skqp_gn_args.py
M Source/ThirdParty/skia/gn/sksl.gni
M Source/ThirdParty/skia/gn/sksl_tests.gni
M Source/ThirdParty/skia/gn/tests.gni
M Source/ThirdParty/skia/gn/xml.gni
M Source/ThirdParty/skia/go.mod
M Source/ThirdParty/skia/go.sum
M Source/ThirdParty/skia/go_repositories.bzl
M Source/ThirdParty/skia/include/config/copts.bzl
M Source/ThirdParty/skia/include/core/SkBitmap.h
M Source/ThirdParty/skia/include/core/SkDrawLooper.h
M Source/ThirdParty/skia/include/core/SkImage.h
M Source/ThirdParty/skia/include/core/SkImageInfo.h
M Source/ThirdParty/skia/include/core/SkMilestone.h
M Source/ThirdParty/skia/include/core/SkPath.h
M Source/ThirdParty/skia/include/core/SkPicture.h
M Source/ThirdParty/skia/include/core/SkShader.h
M Source/ThirdParty/skia/include/core/SkSize.h
M Source/ThirdParty/skia/include/core/SkStream.h
R Source/ThirdParty/skia/include/effects/SkBlurDrawLooper.h
M Source/ThirdParty/skia/include/effects/SkLayerDrawLooper.h
M Source/ThirdParty/skia/include/gpu/GrBackendSurface.h
M Source/ThirdParty/skia/include/gpu/GrDirectContext.h
M 

[webkit-changes] [WebKit/WebKit] 53ca27: Cherry-pick 277203@main (bd1249cc9c4f). https://bu...

[Patrick]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 53ca279739365f9a604fba0a673f0539dfd67c55
  
https://github.com/WebKit/WebKit/commit/53ca279739365f9a604fba0a673f0539dfd67c55
  Author: Patrick Griffis 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Int128.cpp

  Log Message:
  ---
  Cherry-pick 277203@main (bd1249cc9c4f). 
https://bugs.webkit.org/show_bug.cgi?id=272309

Workaround restrict error in GCC 12
https://bugs.webkit.org/show_bug.cgi?id=272309

Reviewed by Darin Adler.

In GCC 12.3.0:

In static member function ‘static constexpr 
std::char_traits::char_type* std::char_traits::copy(char_type*, 
const char_type*, std::size_t)’,
inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, 
_Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = 
char; _Traits = std::char_traits; _Alloc = std::allocator]’ at 
/usr/include/c++/12/bits/basic_string.h:431:21,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Allocator>& std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with 
_CharT = char; _Traits = std::char_traits; _Alloc = 
std::allocator]’ at /usr/include/c++/12/bits/basic_string.tcc:532:22,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>& std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>::replace(size_type, size_type, const _CharT*, size_type) [with _CharT = 
char; _Traits = std::char_traits; _Alloc = std::allocator]’ at 
/usr/include/c++/12/bits/basic_string.h:2179:19,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::insert(size_type, 
const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = 
std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:1936:22,
inlined from ‘std::ostream& WTF::operator<<(std::ostream&, Int128Impl)’ 
at /host/home/tingping/Projects/WebKit/Source/WTF/wtf/Int128.cpp:268:17:
/usr/include/c++/12/bits/char_traits.h:435:56: error: ‘void* 
__builtin_memcpy(void*, const void*, long unsigned int)’ accessing 
9223372036854775810 or more bytes at offsets [2, 9223372036854775807] and 1 may 
overlap up to 9223372036854775813 bytes at offset -3 [-Werror=restrict]
  435 | return static_cast(__builtin_memcpy(__s1, __s2, 
__n));
  |
^

* Source/WTF/wtf/Int128.cpp:
(WTF::operator<<):

Canonical link: https://commits.webkit.org/277203@main

Canonical link: https://commits.webkit.org/274313.129@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Carlos Garcia Campos]

  Branch: refs/tags/webkitgtk-2.44.1
  Home:   https://github.com/WebKit/WebKit

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] abacd8: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...

[Carlos Garcia Campos]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: abacd880cd67e6216b5743ed571acd46afeeb2bd
  
https://github.com/WebKit/WebKit/commit/abacd880cd67e6216b5743ed571acd46afeeb2bd
  Author: Carlos Garcia Campos 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for 2.44.1 release

* Source/WebKit/gtk/NEWS: Add release notes for 2.44.1.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0cbb42: Cherry-pick 277234@main (1dcc05917fd7). https://bu...

[Miguel Gómez]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 0cbb42987e7a72594bd32dd99604c447365db93d
  
https://github.com/WebKit/WebKit/commit/0cbb42987e7a72594bd32dd99604c447365db93d
  Author: Miguel Gomez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  ---
  Cherry-pick 277234@main (1dcc05917fd7). 
https://bugs.webkit.org/show_bug.cgi?id=272324

[GTK][WPE] Don't request more than a single composition during a layerFlush
https://bugs.webkit.org/show_bug.cgi?id=272324

Reviewed by Carlos Garcia Campos.

If there weren't changes to the page that requested a composition with a 
new state,
request a composition of the current content.

* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::layerFlushTimerFired):

Canonical link: https://commits.webkit.org/277234@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a9f45: Cherry-pick 277196@main (80dd62a7e332). https://bu...

[Enrique Ocaña González]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a9f456c41460ce36e6732de6f1ffa0d41819e62
  
https://github.com/WebKit/WebKit/commit/2a9f456c41460ce36e6732de6f1ffa0d41819e62
  Author: Enrique Ocaña González 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/icon-service.js
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  ---
  Cherry-pick 277196@main (80dd62a7e332). 
https://bugs.webkit.org/show_bug.cgi?id=260455

[Modern Media Controls] HTMLMediaElement is never destroyed when showing 
media controls
https://bugs.webkit.org/show_bug.cgi?id=270571

Reviewed by Xabier Rodriguez-Calvar.

At least in GStreamer-based ports (WPE and WebKitGTK, I haven't checked
on Mac ports because I don't have the proper environment easily
available), the media element is leaked after explicit deinitialization
and detaching from the HTML document, even after manually triggering
garbage collection (GC) using the web inspector.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1285

After some debugging, we've detected that 2 extra references to
HTMLMediaElement appear when using the controls (3 refs in total), while
in a scenario where the controls are hidden on purpose only 1 reference
remains, which is released as soon as the GC kicks in.

Those references are held (or transitively held) by the MediaController,
the shadowRoot referenced by the MediaController and by the IconService,
and the  element that MediaController adds to the shadowRoot as a
container for the controls.

This commit adds code to use WeakRefs to the ShadowRoot and to the
MediaJSWrapper (media) on MediaController, and to the ShadowRoot on
the iconService, instead of the original objects. This allows the
garbage collector to kick in when needed and have those objects freed
automatically. The WeakRefs are transparently exposed as regular objects
by using properties (get/set), to avoid the need to change a lot of code
that expects regular objects.

There's still the  element added to the ShadowRoot, which
transitively holds a reference that prevents GC. There's no good place
to remove that element, so I removed it in the "less bad place", which
is HTMLMediaElement::pauseAfterDetachedTask(). A new deinitialize() JS
function takes care of that. Unfortunately, the element can still be
used after deinitialization, so there's also a method to reinitialize()
it if needed and an extra ControlsState to mark the element as
PartiallyDeinitialized in order to know when to recover from that state.

* Source/WebCore/Modules/modern-media-controls/controls/icon-service.js: 
Store shadowRoot as a WeakRef.
(const.iconService.new.IconService.prototype.get shadowRoot): Expose the 
shadowRootWeakRef as a regular shadowRoot object by binding it to the 
shadowRoot property.
(const.iconService.new.IconService.prototype.set shadowRoot): Ditto, but 
for the setter.
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController): Store shadowRoot and media as WeakRefs.
(MediaController.prototype.get media): Expose the mediaWeakRef as a regular 
media object by binding it to the media property.
(MediaController.prototype.get shadowRoot): Expose the shadowRootWeakRef as 
a regular shadowRoot object by binding it to the shadowRoot property.
(MediaController.prototype.get isFullscreen): Take into account the case 
where media can be null.
(MediaController.prototype.deinitialize): Function called from 
HTMLMediaElement to deinitialize the MediaController. Just removes the 
shadowRoot child.
(MediaController.prototype.reinitialize): Function called from 
HTMLMediaElement to reinitialize the MediaController. Readds the shadowRoot 
child and sets again the WeakRefs that might have become by lack of use of the 
main objects.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::convertEnumerationToString): Utility function to get a printable 
version of ControlsState. Useful for debugging.
(WebCore::HTMLMediaElement::pauseAfterDetachedTask): Deinitialize the 
MediaController by calling its deinitialize() JS method.
(WebCore::HTMLMediaElement::ensureMediaControls): Support the case of 
reinitialization. Call the reinitialize() JS method in MediaController in that 
case.
* Source/WebCore/html/HTMLMediaElement.h: Added new PartiallyDeinitialized 
state to ControlsState. Give friend access to convertEnumerationToString() so 
it can do its job.

Canonical link: https://commits.webkit.org/277196@main



To unsubscribe from these emails, change your notification settings at 

[webkit-changes] [WebKit/WebKit] e449d0: [build.webkit.org] Forcing a build with a hash fai...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e449d0612995ec16feec1775ede8b08d9a7d2f00
  
https://github.com/WebKit/WebKit/commit/e449d0612995ec16feec1775ede8b08d9a7d2f00
  Author: Diego Pino Garcia 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] Forcing a build with a hash fails for WebKitGTK and WPE 
builders
https://bugs.webkit.org/show_bug.cgi?id=272319

Reviewed by Jonathan Bedard.

Skip the creation and upload of minified built products for platforms that
do not support minified built products.

* Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit.evaluateCommand):

Canonical link: https://commits.webkit.org/277235@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 122d57: Cherry-pick 277071@main (3b4a4e93f160). https://bu...

[Pablo Saavedra Rodiño]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 122d572253d0af64b89894e46f01922316eec990
  
https://github.com/WebKit/WebKit/commit/122d572253d0af64b89894e46f01922316eec990
  Author: Pablo Saavedra 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp

  Log Message:
  ---
  Cherry-pick 277071@main (3b4a4e93f160). 
https://bugs.webkit.org/show_bug.cgi?id=272150

[WPE] Fix crash on ThreadedCompositor::renderLayerTree() during video 
playlist transitions
https://bugs.webkit.org/show_bug.cgi?id=272150

Reviewed by Miguel Gomez.

Unnoticed default usage of dmabuf was leading to missing checks in the 
dmabuf
proxy. This caused issues when activating a proxy in a TextureMapperLayer,
removing any reference that another layer might have had to the previous 
proxy.
Additionally, when invalidating, the reference to the proxy held by the 
TextureMapperLayer
was also removed.

This prevents an invalid memory access identified in the
CoordinatedGraphicsScene::paintToCurrentGLContext().

* 
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:

(WebCore::TextureMapperPlatformLayerProxyDMABuf::activateOnCompositingThread):
(WebCore::TextureMapperPlatformLayerProxyDMABuf::invalidate):

Canonical link: https://commits.webkit.org/277071@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d44b6: Cherry-pick 276936@main (aff02c3a8c4f). https://bu...

[Carlos Bentzen]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d44b643befab7b5a08419c11f5575ab0fc7d1f2
  
https://github.com/WebKit/WebKit/commit/6d44b643befab7b5a08419c11f5575ab0fc7d1f2
  Author: Carlos Bentzen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 276936@main (aff02c3a8c4f). 
https://bugs.webkit.org/show_bug.cgi?id=233955

[GTK] Video alpha channel doesn't work
https://bugs.webkit.org/show_bug.cgi?id=233955

Reviewed by Miguel Gomez.

Set the ShouldBlend and ShouldPremultiply flags for the texture mapper when
pushing dma-buf video frames with alpha channel. This replicates what is 
done
for the GSTREAMER_GL code path in 238313@main.

Covered by media/video-with-alpha.html and manually tested with
https://zipdox.net/alphawebm/.

* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/276936@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 30ad9a: Cherry-pick 276798@main (f91aeb92bd8e). https://bu...

[Carlos Bentzen]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 30ad9a720e6b12a6c958fcef0d7dd3f52da485bd
  
https://github.com/WebKit/WebKit/commit/30ad9a720e6b12a6c958fcef0d7dd3f52da485bd
  Author: Carlos Bentzen 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
A 
LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash-expected.txt
A 
LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash.html
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 276798@main (f91aeb92bd8e). 
https://bugs.webkit.org/show_bug.cgi?id=260455

[GStreamer][MSE] Crash in webKitMediaSrcStreamFlush
https://bugs.webkit.org/show_bug.cgi?id=260455

Reviewed by Alicia Boya Garcia.

Fix crash and playback of video on 
https://www.apple.com/apple-watch-ultra-2/.
The video starts outside of the viewport and is played via MSE.

The issue was caused due to failing to transition the pipeline to PAUSED in
MediaPlayerPrivateGStreamer::setVisibleInViewport when an MSE video starts 
initially
outside of the viewport. That, in turn, is caused because we try to set 
playbin
to PAUSED without an URL set. Then, the media player pipeline gets stuck in 
READY,
while webkitmediasrc is in the PAUSED state. With this, the video never 
starts playing
back.

Moreover, scrolling the page for the video to be in and out of the 
viewport, it triggers
a downgrade state in webkitmediasrc to READY, which if coupled with a seek 
attempt then
causes a crash in WebKitMediaSourceGStreamer when flushing.

The fix is two-fold:
1. Avoid setting the state to PAUSED if no playbin URL has been set.
2. Avoid setting the state of the pipeline to READY in
   MediaPlayerPrivateGStreamer::setVisibleInViewport if the media player is 
MSE.

Added a test that triggers the described behavior and crashes without the 
fix. It scrolls
the page to move a video in and out of the viewport, while also seeking to 
the start on
every scroll. Currently, part of the code to trigger the crash isn't 
executed
due to WEBKIT_GST_ALLOW_PLAYBACK_OF_INVISIBLE_VIDEOS=1 being set in the 
test driver in
Tools/Scripts/webkitpy/port/glib.py (264017@main), which needs to be 
commented manually.
We should find a way to add a test preference for this code path to be 
enabled.

* 
LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash-expected.txt:
 Added.
* 
LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash.html: 
Added.
* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): Set playbin URL before 
calling setVisibleInViewport.
(WebCore::MediaPlayerPrivateGStreamer::setVisibleInViewport): Avoid state 
transitions to READY if MSE
and avoid setting the pipeline to PAUSED if playbin URL is not set.

Canonical link: https://commits.webkit.org/276798@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1dcc05: [GTK][WPE] Don't request more than a single compos...

[Miguel Gómez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dcc05917fd767be73b5b47c69036eae2a76fba9
  
https://github.com/WebKit/WebKit/commit/1dcc05917fd767be73b5b47c69036eae2a76fba9
  Author: Miguel Gomez 
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  ---
  [GTK][WPE] Don't request more than a single composition during a layerFlush
https://bugs.webkit.org/show_bug.cgi?id=272324

Reviewed by Carlos Garcia Campos.

If there weren't changes to the page that requested a composition with a new 
state,
request a composition of the current content.

* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::layerFlushTimerFired):

Canonical link: https://commits.webkit.org/277234@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 697b1a: [ iOS ] 3x editing/spelling/* (layout-tests) are c...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 697b1a86cea65c70aa013ce7402a16a516181baf
  
https://github.com/WebKit/WebKit/commit/697b1a86cea65c70aa013ce7402a16a516181baf
  Author: Wenson Hsieh 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.h
M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm

  Log Message:
  ---
  [ iOS ] 3x editing/spelling/* (layout-tests) are constant failures
https://bugs.webkit.org/show_bug.cgi?id=271864
rdar://125585822

Reviewed by Aditya Keerthi.

Among the many other changes to adopt `BETextInput`, iOS 17.4 refactored 
`WKContentView` to stop
relying on the UIKit internal method `-_requiresKeyboardWhenFirstResponder`. 
Instead, UIKit now
returns `YES` when the delegate is a `BETextInput`, as long as either of the 
following are true:

1. The hardware keyboard is connected.
2. An editable element is focused.

However, a consequence of this refactoring is that `WKContentView` now vends 
text input traits to
keyboard code in UIKit when a hardware keyboard is attached, even in the case 
where there is no
focused element. In practice, this doesn't really matter, since these text 
input traits (which
contain `UITextAutocorrectionTypeNo`) are effectively unused. However, in the 
case of these three
layout tests that programmatically focus text inputs, insert text, and expect 
spellchecking to
occur outside of the context of any input session, we end up failing because 
the spelling
corrections are disabled by the traits.

To fix this, restore pre-iOS 17.4 behavior by reverting to 
`WKExtendedTextInputTraits`'s default
values when no element is focused (or being focused). Namely, this ensures that 
the autocorrection
type is set to `UITextAutocorrectionTypeDefault`, which matches shipping 
behavior in the case when
the user isn't focusing anything editable, but still enables continuous 
spellchecking when
programmatically inserting text.

* LayoutTests/platform/ios/TestExpectations:

Mark these layout test as passing again.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _updateTextInputTraits:]):
(-[WKContentView extendedTraitsDelegate]):

See above for more details.

* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.h:
* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm:
(-[WKExtendedTextInputTraits init]):
(-[WKExtendedTextInputTraits setSelectionColorsToMatchTintColor:]):
(-[WKExtendedTextInputTraits restoreDefaultValues]):

Add a new method to restore all default text input traits.

(-[WKExtendedTextInputTraits setSelectionBarColor:]): Deleted.
(-[WKExtendedTextInputTraits selectionBarColor]): Deleted.

Remove some old versions of the `UIAsyncTextInput` implementation that are no 
longer necessary,
since they've all been superceded by `BETextInput`.

Canonical link: https://commits.webkit.org/277233@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes