[webkit-changes] [177491] trunk/LayoutTests

[stavila]

Title: [177491] trunk/LayoutTests








Revision 177491
Author stav...@adobe.com
Date 2014-12-18 04:54:31 -0800 (Thu, 18 Dec 2014)


Log Message
animations/cross-fade-webkit-mask-image.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139590

Reviewed by Andrei Bucur.

animations/cross-fade-webkit-mask-image.html became flaky after the way
masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
Marking it flaky for now, pending investigation.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177490 => 177491)

--- trunk/LayoutTests/ChangeLog	2014-12-18 12:16:12 UTC (rev 177490)
+++ trunk/LayoutTests/ChangeLog	2014-12-18 12:54:31 UTC (rev 177491)
@@ -1,3 +1,16 @@
+2014-12-18  Radu Stavila  stav...@adobe.com
+
+animations/cross-fade-webkit-mask-image.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=139590
+
+Reviewed by Andrei Bucur.
+
+animations/cross-fade-webkit-mask-image.html became flaky after the way
+masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
+Marking it flaky for now, pending investigation.
+
+* TestExpectations:
+
 2014-12-18  Antti Koivisto  an...@apple.com
 
 Stop returning GlyphPage from various Font functions


Modified: trunk/LayoutTests/TestExpectations (177490 => 177491)

--- trunk/LayoutTests/TestExpectations	2014-12-18 12:16:12 UTC (rev 177490)
+++ trunk/LayoutTests/TestExpectations	2014-12-18 12:54:31 UTC (rev 177491)
@@ -37,6 +37,8 @@
 webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas-2x.html [ ImageOnlyFailure ]
 webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ Pass ImageOnlyFailure ]
 
+webkit.org/b/139590 animations/cross-fade-webkit-mask-image.html [ Pass Failure ]
+
 # The test frequently times out, and is just unsuccessful at detecting incorrect behavior when it passes.
 webkit.org/b/72698 media/audio-garbage-collect.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177441] trunk/Source/WebCore

[stavila]

Title: [177441] trunk/Source/WebCore








Revision 177441
Author stav...@adobe.com
Date 2014-12-17 02:14:32 -0800 (Wed, 17 Dec 2014)


Log Message
The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=139644

Reviewed by Antti Koivisto.

When an SVGImage is destroyed, having its SVGDocument perform style recalc and dispatching events is not only
useless but can also cause problems, such as re-entrancy in StyleResolver::loadPendingResources.

No new tests required, existing tests cover this change.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::isBeingDestroyed):
(WebCore::Document::setIsBeingDestroyed):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::~SVGImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177440 => 177441)

--- trunk/Source/WebCore/ChangeLog	2014-12-17 09:51:01 UTC (rev 177440)
+++ trunk/Source/WebCore/ChangeLog	2014-12-17 10:14:32 UTC (rev 177441)
@@ -1,3 +1,25 @@
+2014-12-17  Radu Stavila  stav...@adobe.com
+
+The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed
+https://bugs.webkit.org/show_bug.cgi?id=139644
+
+Reviewed by Antti Koivisto.
+
+When an SVGImage is destroyed, having its SVGDocument perform style recalc and dispatching events is not only
+useless but can also cause problems, such as re-entrancy in StyleResolver::loadPendingResources.
+
+No new tests required, existing tests cover this change.
+
+* dom/Document.cpp:
+(WebCore::Document::Document):
+* dom/Document.h:
+(WebCore::Document::isBeingDestroyed):
+(WebCore::Document::setIsBeingDestroyed):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::closeURL):
+* svg/graphics/SVGImage.cpp:
+(WebCore::SVGImage::~SVGImage):
+
 2014-12-17  Chris Dumez  cdu...@apple.com
 
 Drop useless 'clipToContents' argument for windowClipRect()


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (177440 => 177441)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2014-12-17 09:51:01 UTC (rev 177440)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2014-12-17 10:14:32 UTC (rev 177441)
@@ -539,10 +539,18 @@
 bool FrameLoader::closeURL()
 {
 history().saveDocumentState();
-
-// Should only send the pagehide event here if the current document exists and has not been placed in the page cache.
+
 Document* currentDocument = m_frame.document();
-stopLoading(currentDocument  !currentDocument-inPageCache() ? UnloadEventPolicyUnloadAndPageHide : UnloadEventPolicyUnloadOnly);
+UnloadEventPolicy unloadEventPolicy;
+if (m_frame.page()  m_frame.page()-chrome().client().isSVGImageChromeClient()) {
+// If this is the SVGDocument of an SVGImage, no need to dispatch events or recalcStyle.
+unloadEventPolicy = UnloadEventPolicyNone;
+} else {
+// Should only send the pagehide event here if the current document exists and has not been placed in the page cache.
+unloadEventPolicy = currentDocument  !currentDocument-inPageCache() ? UnloadEventPolicyUnloadAndPageHide : UnloadEventPolicyUnloadOnly;
+}
+
+stopLoading(unloadEventPolicy);
 
 m_frame.editor().clearUndoRedoOperations();
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177226] trunk/LayoutTests

[stavila]

Title: [177226] trunk/LayoutTests








Revision 177226
Author stav...@adobe.com
Date 2014-12-12 12:13:26 -0800 (Fri, 12 Dec 2014)


Log Message
animations/cross-fade-webkit-mask-image.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139590

Reviewed by Alexey Proskuryakov.

animations/cross-fade-webkit-mask-image.html became flaky after the way
masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
Marking it flaky for now, pending investigation.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177225 => 177226)

--- trunk/LayoutTests/ChangeLog	2014-12-12 19:27:51 UTC (rev 177225)
+++ trunk/LayoutTests/ChangeLog	2014-12-12 20:13:26 UTC (rev 177226)
@@ -1,3 +1,16 @@
+2014-12-12  Radu Stavila  stav...@adobe.com
+
+animations/cross-fade-webkit-mask-image.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=139590
+
+Reviewed by Alexey Proskuryakov.
+
+animations/cross-fade-webkit-mask-image.html became flaky after the way
+masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
+Marking it flaky for now, pending investigation.
+
+* TestExpectations:
+
 2014-12-12  Jer Noble  jer.no...@apple.com
 
 [MSE] Add support for SourceBuffer.mode.


Modified: trunk/LayoutTests/TestExpectations (177225 => 177226)

--- trunk/LayoutTests/TestExpectations	2014-12-12 19:27:51 UTC (rev 177225)
+++ trunk/LayoutTests/TestExpectations	2014-12-12 20:13:26 UTC (rev 177226)
@@ -37,6 +37,8 @@
 webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas-2x.html [ ImageOnlyFailure ]
 webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ Pass ImageOnlyFailure ]
 
+webkit.org/b/139590 animations/cross-fade-webkit-mask-image.html [ Pass Failure ]
+
 # The test frequently times out, and is just unsuccessful at detecting incorrect behavior when it passes.
 webkit.org/b/72698 media/audio-garbage-collect.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172146] trunk

[stavila]

Title: [172146] trunk








Revision 172146
Author stav...@adobe.com
Date 2014-08-06 08:06:08 -0700 (Wed, 06 Aug 2014)


Log Message
REGRESSION (r163382): Overflow hidden for inner elements breaks blurring
https://bugs.webkit.org/show_bug.cgi?id=135318

Reviewed by Zalan Bujtas.

Source/WebCore:

For elements with border radius, clipping must be applied using clipRoundedRect.
This regressed in r163382, when normal clipping started being applied also
for elements having border radius.

Test: fast/filter-image/clipped-filter.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):

LayoutTests:

Added test for filter applied on an element overflowing its parent, which has overflow:hidden.

* fast/filter-image/clipped-filter-expected.html: Added.
* fast/filter-image/clipped-filter.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/filter-image/clipped-filter-expected.html
trunk/LayoutTests/fast/filter-image/clipped-filter.html




Diff

Modified: trunk/LayoutTests/ChangeLog (172145 => 172146)

--- trunk/LayoutTests/ChangeLog	2014-08-06 15:04:09 UTC (rev 172145)
+++ trunk/LayoutTests/ChangeLog	2014-08-06 15:06:08 UTC (rev 172146)
@@ -1,3 +1,15 @@
+2014-08-06  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r163382): Overflow hidden for inner elements breaks blurring
+https://bugs.webkit.org/show_bug.cgi?id=135318
+
+Reviewed by Zalan Bujtas.
+
+Added test for filter applied on an element overflowing its parent, which has overflow:hidden.
+
+* fast/filter-image/clipped-filter-expected.html: Added.
+* fast/filter-image/clipped-filter.html: Added.
+
 2014-08-06  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions] Move selection tests under fast/regions/selection


Added: trunk/LayoutTests/fast/filter-image/clipped-filter-expected.html (0 => 172146)

--- trunk/LayoutTests/fast/filter-image/clipped-filter-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/filter-image/clipped-filter-expected.html	2014-08-06 15:06:08 UTC (rev 172146)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+
+html
+head
+style
+.circle {
+width: 300px;
+height: 300px;
+margin-left: 100px;
+margin-top: 60px;
+background-color: #f5ad61;
+border-radius: 50% 50%;
+}
+.inner {
+-webkit-filter: drop-shadow(16px 16px 0px black);
+background-color: red;
+height: 60px;
+width: 200px;
+}
+
+#clip {
+position: absolute;
+top: 0px;
+left: 0px;
+width: 500px;
+height: 500px;
+background-color: white;
+-webkit-clip-path: url(#clipPath);
+}
+/style
+/head
+
+body
+a href="" 135318 - This test passes if the red element has a black shadow and is clipped by the orange circle/a
+
+div class=circle
+div class=inner/div
+/div
+
+div id=clip/div
+/body
+
+svg
+defs
+clipPath id=clipPath
+path d=M18,38 v200 h90 a150,150 0 0,1 300,0 h50 v-200 z
+/clipPath
+/defs
+/svg
+
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/filter-image/clipped-filter.html (0 => 172146)

--- trunk/LayoutTests/fast/filter-image/clipped-filter.html	(rev 0)
+++ trunk/LayoutTests/fast/filter-image/clipped-filter.html	2014-08-06 15:06:08 UTC (rev 172146)
@@ -0,0 +1,53 @@
+!DOCTYPE html
+
+html
+head
+style
+.circle {
+width: 300px;
+height: 300px;
+margin-left: 100px;
+margin-top: 60px;
+background-color: #f5ad61;
+overflow: hidden;
+border-radius: 50% 50%;
+}
+
+.inner {
+-webkit-filter: drop-shadow(16px 16px 0px black);
+background-color: red;
+height: 60px;
+width: 200px;
+}
+
+#clip {
+position: absolute;
+top: 0px;
+left: 0px;
+width: 500px;
+height: 500px;
+background-color: white;
+-webkit-clip-path: url(#clipPath);
+}
+/style
+/head
+
+body
+a href="" 135318 - This test passes if the red element has a black shadow and is clipped by the orange circle/a
+
+div class=circle
+div class=inner/div
+/div
+
+div id=clip/div
+/body
+
+svg
+defs
+clipPath id=clipPath
+path d=M18,38 v200 h90 a150,150 0 0,1 300,0 h50 v-200 z
+/clipPath
+/defs
+/svg
+
+/html
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (172145 => 172146)

--- trunk/Source/WebCore/ChangeLog	2014-08-06 15:04:09 UTC (rev 172145)
+++ trunk/Source/WebCore/Change

[webkit-changes] [171797] trunk/Source/WebCore

[stavila]

Title: [171797] trunk/Source/WebCore








Revision 171797
Author stav...@adobe.com
Date 2014-07-30 09:23:04 -0700 (Wed, 30 Jul 2014)


Log Message
Member name collision in RenderView and SelectionSubtreeRoot
https://bugs.webkit.org/show_bug.cgi?id=135233

Reviewed by Mihnea Ovidenie.

The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.

No new tests required, no new functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::getSelection):
* rendering/RenderView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (171796 => 171797)

--- trunk/Source/WebCore/ChangeLog	2014-07-30 10:52:33 UTC (rev 171796)
+++ trunk/Source/WebCore/ChangeLog	2014-07-30 16:23:04 UTC (rev 171797)
@@ -1,3 +1,23 @@
+2014-07-30  Radu Stavila  stav...@adobe.com
+
+Member name collision in RenderView and SelectionSubtreeRoot
+https://bugs.webkit.org/show_bug.cgi?id=135233
+
+Reviewed by Mihnea Ovidenie.
+
+The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
+RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.
+
+No new tests required, no new functionality.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::isSelectionRoot):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::RenderView):
+(WebCore::RenderView::setSelection):
+(WebCore::RenderView::getSelection):
+* rendering/RenderView.h:
+
 2014-07-30  Zan Dobersek  zdober...@igalia.com
 
 [TexMap] Move TextureMapperLayer::textureMapper() definition into the header


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (171796 => 171797)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-07-30 10:52:33 UTC (rev 171796)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-07-30 16:23:04 UTC (rev 171797)
@@ -1828,8 +1828,8 @@
 || isRenderFlowThread() || style().columnSpan() == ColumnSpanAll)
 return true;
 
-if (view().selectionStart()) {
-Node* startElement = view().selectionStart()-node();
+if (view().selectionUnsplitStart()) {
+Node* startElement = view().selectionUnsplitStart()-node();
 if (startElement  startElement-rootEditableElement() == element())
 return true;
 }


Modified: trunk/Source/WebCore/rendering/RenderView.cpp (171796 => 171797)

--- trunk/Source/WebCore/rendering/RenderView.cpp	2014-07-30 10:52:33 UTC (rev 171796)
+++ trunk/Source/WebCore/rendering/RenderView.cpp	2014-07-30 16:23:04 UTC (rev 171797)
@@ -96,10 +96,10 @@
 RenderView::RenderView(Document document, PassRefRenderStyle style)
 : RenderBlockFlow(document, WTF::move(style))
 , m_frameView(*document.view())
-, m_selectionStart(0)
-, m_selectionEnd(0)
-, m_selectionStartPos(-1)
-, m_selectionEndPos(-1)
+, m_selectionUnsplitStart(0)
+, m_selectionUnsplitEnd(0)
+, m_selectionUnsplitStartPos(-1)
+, m_selectionUnsplitEndPos(-1)
 , m_rendererCount(0)
 , m_maximalOutlineSize(0)
 , m_lazyRepaintTimer(this, RenderView::lazyRepaintTimerFired)
@@ -845,15 +845,16 @@
 bool caretChanged = m_selectionWasCaret != frame().selection().isCaret();
 m_selectionWasCaret = frame().selection().isCaret();
 // Just return if the selection hasn't changed.
-if (m_selectionStart == start  m_selectionStartPos == startPos 
-m_selectionEnd == end  m_selectionEndPos == endPos  !caretChanged)
+if (m_selectionUnsplitStart == start  m_selectionUnsplitStartPos == startPos
+ m_selectionUnsplitEnd == end  m_selectionUnsplitEndPos == endPos  !caretChanged) {
 return;
+}
 
 // Set global positions for new selection.
-m_selectionStart = start;
-m_selectionStartPos = startPos;
-m_selectionEnd = end;
-m_selectionEndPos = endPos;
+m_selectionUnsplitStart = start;
+m_selectionUnsplitStartPos = startPos;
+m_selectionUnsplitEnd = end;
+m_selectionUnsplitEndPos = endPos;
 
 // If there is no RenderNamedFlowThreads we follow the regular selection.
 if (!hasRenderNamedFlowThreads()) {
@@ -1082,10 +1083,10 @@
 
 void RenderView::getSelection(RenderObject* startRenderer, int startOffset, RenderObject* endRenderer, int endOffset) const
 {
-startRenderer = m_selectionStart;
-startOffset = m_selectionStartPos;
-endRenderer = m_selectionEnd;
-endOffset = m_selectionEndPos;
+startRenderer = m_selectionUnsplitStart;
+st

[webkit-changes] [170566] trunk

[stavila]

Title: [170566] trunk








Revision 170566
Author stav...@adobe.com
Date 2014-06-28 01:44:54 -0700 (Sat, 28 Jun 2014)


Log Message
[New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content
https://bugs.webkit.org/show_bug.cgi?id=133941

Reviewed by Darin Adler.

Source/WebCore:
When having a multicol element inside an element with overflow:hidden and border-radius,
the fragments representing the columns need to have the border radius set also, to ensure
proper clipping.

Test: fast/multicol/newmulticol/multicol-clip-rounded-corners.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):

LayoutTests:
Added test for multicol element inside an element with overflow:hidden and border radius.

* fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html: Added.
* fast/multicol/newmulticol/multicol-clip-rounded-corners.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html
trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners.html




Diff

Modified: trunk/LayoutTests/ChangeLog (170565 => 170566)

--- trunk/LayoutTests/ChangeLog	2014-06-28 05:51:13 UTC (rev 170565)
+++ trunk/LayoutTests/ChangeLog	2014-06-28 08:44:54 UTC (rev 170566)
@@ -1,3 +1,15 @@
+2014-06-28  Radu Stavila  stav...@adobe.com
+
+[New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content
+https://bugs.webkit.org/show_bug.cgi?id=133941
+
+Reviewed by Darin Adler.
+
+Added test for multicol element inside an element with overflow:hidden and border radius.
+
+* fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html: Added.
+* fast/multicol/newmulticol/multicol-clip-rounded-corners.html: Added.
+
 2014-06-27  Zalan Bujtas  za...@apple.com
 
 Subpixel rendering: Background clipping with subpixel behaves differently when composited.


Added: trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html (0 => 170566)

--- trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html	2014-06-28 08:44:54 UTC (rev 170566)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+head
+style
+#multicol {
+width: 400px;
+height: 200px;
+border: 5px solid black; 
+border-radius: 10%;
+overflow: hidden;
+background-color: orange;
+}
+
+#multicol:hover { background-color: lime; }
+
+.col {
+background-color: pink;
+width: 123px;
+height: 200px;
+float: left;
+color: pink;
+}
+
+#col2 {
+width: 122px;
+margin-left: 16px;
+}
+
+#col3 {
+position: relative;
+left: 16px;
+}
+/style
+/head
+body
+a href="" 133941 - [New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content/a
+pThe text passes if the columns are correctly clipped by the parent having border-radius./p
+
+div id=multicol
+div id=col1 class=col
+Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer
+/div
+div id=col2 class=col
+took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining 
+/div
+div id=col3 class=col
+essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like 
+/div
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners.html (0 => 170566)

--- trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/multicol-clip-rounded-corners.html	2014-06-28 08:44:54 UTC (rev 170566)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+head
+style
+#multicol {
+-webkit-column-width: 100px;
+width: 400px;
+height: 200px;
+border: 5px solid black; 
+  

[webkit-changes] [170291] trunk/Source/WebCore

[stavila]

Title: [170291] trunk/Source/WebCore








Revision 170291
Author stav...@adobe.com
Date 2014-06-23 07:59:48 -0700 (Mon, 23 Jun 2014)


Log Message
REGRESSION (r168046): Incorrect handling of object information in WebCore::RenderFlowThread::removeLineRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=133587

Reviewed by Antti Koivisto.

When an object flowed in multicol is moved from in-flow positioning to out-of-flow positioning,
its information must be removed from the flowthread prior to the change being made.
Otherwise, the flow thread will no longer be its containing block and a reference to it
will not be possible to obtain.

No new tests can be added because the code still hits in an unrelated assertion followed by a null dereference.
The issue was discussed with Antti Koivisto and we decided its better to fix this problem first and
handle the following issue in a separate bug.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleWillChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::flowThreadContainingBlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (170290 => 170291)

--- trunk/Source/WebCore/ChangeLog	2014-06-23 14:59:26 UTC (rev 170290)
+++ trunk/Source/WebCore/ChangeLog	2014-06-23 14:59:48 UTC (rev 170291)
@@ -1,3 +1,24 @@
+2014-06-23  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r168046): Incorrect handling of object information in WebCore::RenderFlowThread::removeLineRegionInfo
+https://bugs.webkit.org/show_bug.cgi?id=133587
+
+Reviewed by Antti Koivisto.
+
+When an object flowed in multicol is moved from in-flow positioning to out-of-flow positioning,
+its information must be removed from the flowthread prior to the change being made. 
+Otherwise, the flow thread will no longer be its containing block and a reference to it
+will not be possible to obtain.
+
+No new tests can be added because the code still hits in an unrelated assertion followed by a null dereference.
+The issue was discussed with Antti Koivisto and we decided its better to fix this problem first and
+handle the following issue in a separate bug.
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::styleWillChange):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::flowThreadContainingBlock):
+
 2014-06-23  Krzysztof Czech  k.cz...@samsung.com
 
 [EFL] Platform support for WebSpeech feature.


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (170290 => 170291)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2014-06-23 14:59:26 UTC (rev 170290)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2014-06-23 14:59:48 UTC (rev 170291)
@@ -1981,9 +1981,22 @@
 const RenderStyle* oldStyle = hasInitializedStyle() ? style() : nullptr;
 s_canPropagateFloatIntoSibling = oldStyle ? !isFloatingOrOutOfFlowPositioned()  !avoidsFloats() : false;
 
-if (oldStyle  parent()  diff == StyleDifferenceLayout  oldStyle-position() != newStyle.position()) {
-if (containsFloats()  !isFloating()  !isOutOfFlowPositioned()  newStyle.hasOutOfFlowPosition())
-markAllDescendantsWithFloatsForLayout();
+if (oldStyle) {
+EPosition oldPosition = oldStyle-position();
+EPosition newPosition = newStyle.position();
+
+if (parent()  diff == StyleDifferenceLayout  oldPosition != newPosition) {
+if (containsFloats()  !isFloating()  !isOutOfFlowPositioned()  newStyle.hasOutOfFlowPosition())
+markAllDescendantsWithFloatsForLayout();
+
+// If this block is inside a multicol and is moving from in-flow positioning to out-of-flow positioning,
+// remove its info (such as lines-to-region mapping) from the flowthread because it won't be able to do it later.
+// The flowthread will no longer be in its containing block chain and, as such, flowThreadContainingBlock will return null.
+if (RenderFlowThread* flowThread = flowThreadContainingBlock(SkipFlowThreadCache)) {
+if (flowThread-isRenderMultiColumnFlowThread()  !isOutOfFlowPositioned()  (newPosition == AbsolutePosition || newPosition == FixedPosition))
+flowThread-removeFlowChildInfo(this);
+}
+}
 }
 
 RenderBlock::styleWillChange(diff, newStyle);


Modified: trunk/Source/WebCore/rendering/RenderObject.h (170290 => 170291)

--- trunk/Source/WebCore/rendering/RenderObject.h	2014-06-23 14:59:26 UTC (rev 170290)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2014-06-23 14:59:48 UTC (rev 170291)
@@ -210,13 +210,19 @@
 RenderBoxModelObject enclosingBoxModelObject() const;
 
 bool fixedPositionedWithNamedFlowContainingBlock() const;
+
+enum ShouldUseFlowTh

[webkit-changes] [170010] trunk

[stavila]

Title: [170010] trunk








Revision 170010
Author stav...@adobe.com
Date 2014-06-16 09:33:27 -0700 (Mon, 16 Jun 2014)


Log Message
REGRESSION (r168046): Incorrect layout for multicol spanners when moving from one thread to another
https://bugs.webkit.org/show_bug.cgi?id=133589

Reviewed by Antti Koivisto.

Source/WebCore:
When a spanner is moved from a multicol thread to another, its placeholder
must be properly repositioned.

Test: fast/multicol/newmulticol/spanner-crash.html

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):

LayoutTests:
* fast/multicol/newmulticol/spanner-crash-expected.txt: Added.
* fast/multicol/newmulticol/spanner-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash-expected.txt
trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (170009 => 170010)

--- trunk/LayoutTests/ChangeLog	2014-06-16 16:20:01 UTC (rev 170009)
+++ trunk/LayoutTests/ChangeLog	2014-06-16 16:33:27 UTC (rev 170010)
@@ -1,3 +1,13 @@
+2014-06-16  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r168046): Incorrect layout for multicol spanners when moving from one thread to another
+https://bugs.webkit.org/show_bug.cgi?id=133589
+
+Reviewed by Antti Koivisto.
+
+* fast/multicol/newmulticol/spanner-crash-expected.txt: Added.
+* fast/multicol/newmulticol/spanner-crash.html: Added.
+
 2014-06-16  Mario Sanchez Prada  mario.pr...@samsung.com
 
 [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard


Added: trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash-expected.txt (0 => 170010)

--- trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash-expected.txt	2014-06-16 16:33:27 UTC (rev 170010)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash.html (0 => 170010)

--- trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/spanner-crash.html	2014-06-16 16:33:27 UTC (rev 170010)
@@ -0,0 +1,35 @@
+!-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=133589 --
+
+style
+	h2 { 
+		-webkit-column-span: all;
+	}
+
+	* {
+		visibility: hidden;
+	}
+/style
+
+div
+	h2 id=baseY/h2
+/div
+div id=four
+	XXspan id=beforetwo/p
+
+script
+	if (window.testRunner)
+testRunner.dumpAsText();
+
+	four.insertBefore(document.getElementById('base').cloneNode(true), document.getElementById('beforetwo'));
+	var head = document.getElementsByTagName(head)[0];
+	var style = document.createElement(style);
+	style.innerHTML=* { \n\
+		-webkit-animation-name: name9; \n\
+		-webkit-animation-duration: 3s; \n\
+		} \n\
+		@-webkit-keyframes name9 { \n\
+		  from { \n\
+		-webkit-column-count: 18446744073709551615; \n\
+		;
+	head.appendChild(style);
+/script


Modified: trunk/Source/WebCore/ChangeLog (170009 => 170010)

--- trunk/Source/WebCore/ChangeLog	2014-06-16 16:20:01 UTC (rev 170009)
+++ trunk/Source/WebCore/ChangeLog	2014-06-16 16:33:27 UTC (rev 170010)
@@ -1,3 +1,18 @@
+2014-06-16  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r168046): Incorrect layout for multicol spanners when moving from one thread to another
+https://bugs.webkit.org/show_bug.cgi?id=133589
+
+Reviewed by Antti Koivisto.
+
+When a spanner is moved from a multicol thread to another, its placeholder
+must be properly repositioned.
+
+Test: fast/multicol/newmulticol/spanner-crash.html
+
+* rendering/RenderMultiColumnFlowThread.cpp:
+(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
+
 2014-06-16  Mario Sanchez Prada  mario.pr...@samsung.com
 
 [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard


Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp (170009 => 170010)

--- trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp	2014-06-16 16:20:01 UTC (rev 170009)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp	2014-06-16 16:33:27 UTC (rev 170010)
@@ -290,9 +290,6 @@
 // becoming our spanner instead, but for it to do that we first have to nuke the original spanner,
 // and get the spanner content back into this flow thread.
 RenderBox* spanner = placeholder-spanner();
-
-// Advance, since we're about to delete the descendant.
-descendant = descendant-nextInPreOrder(subtreeRoot);
 
 // Get info for the move of the original content back into 

[webkit-changes] [169586] trunk

[stavila]

Title: [169586] trunk








Revision 169586
Author stav...@adobe.com
Date 2014-06-04 05:41:27 -0700 (Wed, 04 Jun 2014)


Log Message
REGRESSION: [CSS Regions] Regions with overflow:auto generate scrollbars even if the content flows into the following regions and as such, should not be scrolled
https://bugs.webkit.org/show_bug.cgi?id=133481

Reviewed by Antti Koivisto.

Source/WebCore:
When enlarging the layout overflow of a scrollable region, the portion of the content that flows
in the region must be taken into consideration. If the content continues to flow into the next
region, the layout overflow of the current region must not be enlarged.

Test: fast/regions/scrollable-first-region.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):

LayoutTests:
Added test for a large item flowed through two regions with the first region having overflow:auto.
The region must NOT scroll.

* fast/regions/scrollable-first-region-expected.html: Added.
* fast/regions/scrollable-first-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp


Added Paths

trunk/LayoutTests/fast/regions/scrollable-first-region-expected.html
trunk/LayoutTests/fast/regions/scrollable-first-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (169585 => 169586)

--- trunk/LayoutTests/ChangeLog	2014-06-04 07:25:29 UTC (rev 169585)
+++ trunk/LayoutTests/ChangeLog	2014-06-04 12:41:27 UTC (rev 169586)
@@ -1,3 +1,16 @@
+2014-06-04  Radu Stavila  stav...@adobe.com
+
+REGRESSION: [CSS Regions] Regions with overflow:auto generate scrollbars even if the content flows into the following regions and as such, should not be scrolled
+https://bugs.webkit.org/show_bug.cgi?id=133481
+
+Reviewed by Antti Koivisto.
+
+Added test for a large item flowed through two regions with the first region having overflow:auto.
+The region must NOT scroll.
+
+* fast/regions/scrollable-first-region-expected.html: Added.
+* fast/regions/scrollable-first-region.html: Added.
+
 2014-06-03  Benjamin Poulain  benja...@webkit.org
 
 Fix some corner cases of :hover and :active in quirks mode


Added: trunk/LayoutTests/fast/regions/scrollable-first-region-expected.html (0 => 169586)

--- trunk/LayoutTests/fast/regions/scrollable-first-region-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scrollable-first-region-expected.html	2014-06-04 12:41:27 UTC (rev 169586)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+html
+head
+style
+.ahem {
+font-family: Ahem;
+font-size: 10px;
+}
+
+#region1, #region2 { 
+border: 5px solid black;
+position: absolute;
+}
+
+#region1 {
+height: 135px;
+width: 320px;
+left: 100px;
+bottom: 100px;
+}
+
+#region2 {
+overflow: auto;
+height: 308px;
+width: 308px;
+left: 500px;
+}
+/style
+/head
+body
+a href="" 133481 - REGRESSION: [CSS Regions] Regions with overflow:auto generate scrollbars even if the content flows into the following regions and as such, should not be scrolled/a
+pThis passes if neither region has scrollbars/p
+div class=ahem id=region1
+pLorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent interdum, sapien vitae faucibus suscipit, massa urna sagittis libero, ac imperdiet elit lacus a ligula. Mauris a orci sem. Nullam ullamcorper ornare porttitor. Morbi laoreet pellentesque diam, vitae hendrerit sem fringilla id. Maecenas rutrum lacinia lobortis. Praesent elit lectus,/p
+/div
+div class=ahem id=region2
+p style=margin-top: 0pxporttitor sed semper vel, fringilla id dolor. Sed lacus nisl, rutrum sit amet euismod a, vulputate quis elit. Fusce commodo dui quis lacus viverra vel egestas velit tempus. Donec ut sapien sit amet purus luctus fermentum. Donec eleifend pretium neque quis bibendum. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Nam congue dapibus mi, id ultricies est sagittis et. Integer posuere, eros vitae laoreet congue, tortor purus euismod nibh, eu porta purus arcu id turpis. Donec vitae ultricies nibh. Nullam in urna dolor, at fringilla lorem. Lorem ipsum dolor sit amet, consectetur adipiscing elit./p
+/div
+/body
+/html


Added: trunk/LayoutTests/fast/regions/scrollable-first-region.html (0 => 169586)

--- trunk/LayoutTests/fast/regions/scrollable-first-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scrollable-first-region.html	2014-06-04 12:41:27 UTC (rev 169586)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+html
+

[webkit-changes] [169160] trunk

[stavila]

Title: [169160] trunk








Revision 169160
Author stav...@adobe.com
Date 2014-05-21 08:31:20 -0700 (Wed, 21 May 2014)


Log Message
REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
https://bugs.webkit.org/show_bug.cgi?id=132933

Reviewed by Darin Adler.

Source/WebCore:
Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.

Test: fast/multicol/newmulticol/table-section-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):

LayoutTests:
Added test for crash caused by invalid layout for RenderTableSection.

* fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
* fast/multicol/newmulticol/table-section-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt
trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (169159 => 169160)

--- trunk/LayoutTests/ChangeLog	2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/LayoutTests/ChangeLog	2014-05-21 15:31:20 UTC (rev 169160)
@@ -1,3 +1,15 @@
+2014-05-21  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
+https://bugs.webkit.org/show_bug.cgi?id=132933
+
+Reviewed by Darin Adler.
+
+Added test for crash caused by invalid layout for RenderTableSection.
+
+* fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
+* fast/multicol/newmulticol/table-section-crash.html: Added.
+
 2014-05-21  Eva Balazsfalvi  evab.u-sze...@partner.samsung.com
 
 REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64 properly


Added: trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt (0 => 169160)

--- trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt	2014-05-21 15:31:20 UTC (rev 169160)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html (0 => 169160)

--- trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html	2014-05-21 15:31:20 UTC (rev 169160)
@@ -0,0 +1,39 @@
+!-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=132933 --
+
+body style=width: 800px; height: 600px
+table
+td id=td
+table
+tr id=td
+/body
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var head = document.getElementsByTagName(head)[0];
+var style = document.createElement(style);
+var rule = document.createTextNode(* { visibility: hidden; } #td { position: absolute;);
+style.appendChild(rule);
+head.appendChild(style);
+style = document.createElement(style);
+style.innerHTML = * { \n\
+position: -webkit-sticky;\n\
+-webkit-animation-direction: alternate-reverse;;
+
+head.appendChild(style);
+style = document.createElement(style);
+style.innerHTML = #td { \n\
+-webkit-animation-name: name3; \n\
+-webkit-animation-duration: 9s; \n\
+} \n\
+@-webkit-keyframes name3 { \n\
+from { \n\
+} \n\
+to { \n\
+-webkit-column-count: 4294967167;;
+
+head.appendChild(style);
+
+//head.removeChild(style);
+/script
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (169159 => 169160)

--- trunk/Source/WebCore/ChangeLog	2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/Source/WebCore/ChangeLog	2014-05-21 15:31:20 UTC (rev 169160)
@@ -1,3 +1,17 @@
+2014-05-21  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
+https://bugs.webkit.org/show_bug.cgi?id=132933
+
+Reviewed by Darin Adler.
+
+Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.
+
+Test: fast/multicol/newmulticol/table-section-crash.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
+
 2014-05-21  Simon Pena  simon.p...@samsung.com
 
 [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (169159 => 169160)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2014-05-21 15:31:20 UTC (rev 169160)
@@ -3073,6 +3073,9 @@
 if (

[webkit-changes] [169110] trunk

[stavila]

Title: [169110] trunk








Revision 169110
Author stav...@adobe.com
Date 2014-05-20 07:34:56 -0700 (Tue, 20 May 2014)


Log Message
[CSS Regions] Block incorrectly sized when containing an unsplittable box
https://bugs.webkit.org/show_bug.cgi?id=132601

Reviewed by Antti Koivisto.

Source/WebCore:
When laying out elements in a region, when an inline element is encountered
the size of its parent must not be increased beyond the bottom of the current region,
unless if its the last region. This will ensure that the next sibling of the
inline element is correctly laid out at the top of the next region, instead
of leaving an empty space equal to the height of the overflow, as it did until now.

Tests: fast/regions/inline-block-inside-anonymous-overflow.html
   fast/regions/inline-block-overflow.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::hasNextPage):
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):

LayoutTests:
Added tests for the layout of elements following inline-block elements
that overflow their region, with and without anonymous blocks.

* fast/regions/inline-block-inside-anonymous-overflow-expected.html: Added.
* fast/regions/inline-block-inside-anonymous-overflow.html: Added.
* fast/regions/inline-block-overflow-expected.html: Added.
* fast/regions/inline-block-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/regions/inline-block-inside-anonymous-overflow-expected.html
trunk/LayoutTests/fast/regions/inline-block-inside-anonymous-overflow.html
trunk/LayoutTests/fast/regions/inline-block-overflow-expected.html
trunk/LayoutTests/fast/regions/inline-block-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (169109 => 169110)

--- trunk/LayoutTests/ChangeLog	2014-05-20 13:56:27 UTC (rev 169109)
+++ trunk/LayoutTests/ChangeLog	2014-05-20 14:34:56 UTC (rev 169110)
@@ -1,3 +1,18 @@
+2014-05-20  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Block incorrectly sized when containing an unsplittable box
+https://bugs.webkit.org/show_bug.cgi?id=132601
+
+Reviewed by Antti Koivisto.
+
+Added tests for the layout of elements following inline-block elements 
+that overflow their region, with and without anonymous blocks.
+
+* fast/regions/inline-block-inside-anonymous-overflow-expected.html: Added.
+* fast/regions/inline-block-inside-anonymous-overflow.html: Added.
+* fast/regions/inline-block-overflow-expected.html: Added.
+* fast/regions/inline-block-overflow.html: Added.
+
 2014-05-20  Zoltan Horvath  zol...@webkit.org
 
 [CSS Regions] Add polygon tests for shapes on regions and shapes on the content flow


Added: trunk/LayoutTests/fast/regions/inline-block-inside-anonymous-overflow-expected.html (0 => 169110)

--- trunk/LayoutTests/fast/regions/inline-block-inside-anonymous-overflow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/inline-block-inside-anonymous-overflow-expected.html	2014-05-20 14:34:56 UTC (rev 169110)
@@ -0,0 +1,49 @@
+!DOCTYPE html
+html
+head
+style
+.region {
+border: 3px solid blue;
+float: left;
+}
+#region1 {
+height: 250px;
+}
+#region2 {
+width: 300px;
+height: 200px;
+margin-left: 50px;
+}
+.article {
+background-color: #00;
+}
+#article1 {
+height: 230px;
+}
+#video {
+width: 320px;
+height: 300px;
+background-color: salmon;
+border: 3px solid black;
+}
+/style
+/head
+
+body
+a href="" 132601 - [CSS Regions] Block incorrectly sized when containing an unsplittable box/a
+pThis test passes if the span style=color:#00BB00green text/span is positioned at the very top of the second span style=color:blueregion/span and the span style=color:blueblue text/span immediately after it./p
+div class=region id=region1
+div class=article id=article1
+video id=video controls/videospan style=color:#00FF00
+/div
+/div
+
+div class=region id=region2
+div class=article id=article2
+span style=color:#00FF00This text, togethe

[webkit-changes] [169120] trunk

[stavila]

Title: [169120] trunk








Revision 169120
Author stav...@adobe.com
Date 2014-05-20 10:38:04 -0700 (Tue, 20 May 2014)


Log Message
REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
https://bugs.webkit.org/show_bug.cgi?id=133111

Reviewed by David Hyatt.

Source/WebCore:
When computing the repaint rect of an element flowed into a flow thread, if the element is flowed directly into
the flow thread (meaning its containing block is the flow thread itself), the region's position within the flow
must no longer be taken into consideration, because its already included in the element's |topLeft|.

Test: fast/regions/hover-element-flowed-second-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:
Added test for the correct repaint of an element flowed directly into the second region of a flow thread.

* fast/regions/hover-element-flowed-second-region-expected.html: Added.
* fast/regions/hover-element-flowed-second-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/regions/hover-element-flowed-second-region-expected.html
trunk/LayoutTests/fast/regions/hover-element-flowed-second-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (169119 => 169120)

--- trunk/LayoutTests/ChangeLog	2014-05-20 17:29:35 UTC (rev 169119)
+++ trunk/LayoutTests/ChangeLog	2014-05-20 17:38:04 UTC (rev 169120)
@@ -1,3 +1,15 @@
+2014-05-20  Radu Stavila  stav...@adobe.com
+
+REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
+https://bugs.webkit.org/show_bug.cgi?id=133111
+
+Reviewed by David Hyatt.
+
+Added test for the correct repaint of an element flowed directly into the second region of a flow thread.
+
+* fast/regions/hover-element-flowed-second-region-expected.html: Added.
+* fast/regions/hover-element-flowed-second-region.html: Added.
+
 2014-05-20  Prashant Hiremath  hiremathprasha...@gmail.com
 
 Only set title on SVG documents


Added: trunk/LayoutTests/fast/regions/hover-element-flowed-second-region-expected.html (0 => 169120)

--- trunk/LayoutTests/fast/regions/hover-element-flowed-second-region-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-element-flowed-second-region-expected.html	2014-05-20 17:38:04 UTC (rev 169120)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+
+head
+style
+.region {
+-webkit-flow-from: flow;
+border: 2px solid blue;
+width: 100px;
+height: 100px;
+margin: 10px;
+}
+#region2 {
+margin-top: 10px;
+}
+.content {
+-webkit-flow-into: flow;
+background-color: green;
+width: 100px;
+height: 100px;
+}
+
+#content2 {
+background-color: red;
+}
+/style
+/head
+
+body
+a href="" 133111 - [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted/a
+pWhen hovered, the span style=color:greenbgreen/b/span content should turn span style=color:redbred/b/span./p
+div class=region id=region1/div
+div class=region id=region2/div
+div class=content id=content1/div
+div class=content id=content2/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/hover-element-flowed-second-region.html (0 => 169120)

--- trunk/LayoutTests/fast/regions/hover-element-flowed-second-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-element-flowed-second-region.html	2014-05-20 17:38:04 UTC (rev 169120)
@@ -0,0 +1,52 @@
+!DOCTYPE html
+
+head
+style
+.region {
+-webkit-flow-from: flow;
+border: 2px solid blue;
+width: 100px;
+height: 100px;
+margin: 10px;
+}
+#region2 {
+margin-top: 10px;
+}
+.content {
+-webkit-flow-into: flow;
+background-color: green;
+width: 100px;
+height: 100px;
+}
+
+.content:hover {
+background-color: red;
+}
+/style
+/head
+
+script type=text/_javascript_
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function beginTest() {
+if (window.eventSender) {
+
+// move mouse on the hover test object
+var content2 = document.getElementById(region2);
+eventSender.mouseMoveTo(content2.offsetLeft + 20, content2.offsetTop + 20);
+eventSender.mouseDown(0);
+
+testRunner.notifyDone();
+}
+}
+/script
+
+body _onload_=beginTest()
+a href="

[webkit-changes] [168971] trunk/Source/WebCore

[stavila]

Title: [168971] trunk/Source/WebCore








Revision 168971
Author stav...@adobe.com
Date 2014-05-16 11:26:24 -0700 (Fri, 16 May 2014)


Log Message
[CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
https://bugs.webkit.org/show_bug.cgi?id=132906

Reviewed by Simon Fraser.

If flowThreadContainingBlock() is called on an object which is in a different
flow thread than the one currently being laid out, this method will return an incorrect
result. I added an assertion for that to make sure we catch and treat any such scenarios.
For the moment, this assertion is only validated for regions, as multicol still has some issues.

No new tests required.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
(WebCore::RenderObject::locateFlowThreadContainingBlock):
* rendering/RenderObject.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (168970 => 168971)

--- trunk/Source/WebCore/ChangeLog	2014-05-16 17:07:09 UTC (rev 168970)
+++ trunk/Source/WebCore/ChangeLog	2014-05-16 18:26:24 UTC (rev 168971)
@@ -1,3 +1,22 @@
+2014-05-16  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
+https://bugs.webkit.org/show_bug.cgi?id=132906
+
+Reviewed by Simon Fraser.
+
+If flowThreadContainingBlock() is called on an object which is in a different
+flow thread than the one currently being laid out, this method will return an incorrect
+result. I added an assertion for that to make sure we catch and treat any such scenarios.
+For the moment, this assertion is only validated for regions, as multicol still has some issues.
+
+No new tests required.
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
+(WebCore::RenderObject::locateFlowThreadContainingBlock):
+* rendering/RenderObject.h:
+
 2014-05-16  Martin Hock  mh...@apple.com
 
 MemoryCache::addImageToCache should return the result of add().


Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (168970 => 168971)

--- trunk/Source/WebCore/rendering/RenderObject.cpp	2014-05-16 17:07:09 UTC (rev 168970)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2014-05-16 18:26:24 UTC (rev 168971)
@@ -523,16 +523,10 @@
 return false;
 }
 
-RenderFlowThread* RenderObject::locateFlowThreadContainingBlock() const
+RenderFlowThread* RenderObject::locateFlowThreadContainingBlockNoCache() const
 {
 ASSERT(flowThreadState() != NotInsideFlowThread);
 
-// See if we have the thread cached because we're in the middle of layout.
-RenderFlowThread* flowThread = view().flowThreadController().currentRenderFlowThread();
-if (flowThread  (flowThreadState() == flowThread-flowThreadState()))
-return flowThread;
-
-// Not in the middle of layout so have to find the thread the slow way.
 RenderObject* curr = const_castRenderObject*(this);
 while (curr) {
 if (curr-isRenderFlowThread())
@@ -542,6 +536,25 @@
 return 0;
 }
 
+RenderFlowThread* RenderObject::locateFlowThreadContainingBlock() const
+{
+ASSERT(flowThreadState() != NotInsideFlowThread);
+
+// See if we have the thread cached because we're in the middle of layout.
+RenderFlowThread* flowThread = view().flowThreadController().currentRenderFlowThread();
+if (flowThread  (flowThreadState() == flowThread-flowThreadState())) {
+// Make sure the slow path would return the same result as our cache.
+// FIXME: For the moment, only apply this assertion to regions, as multicol
+// still has some issues and triggers this assert.
+// Created https://bugs.webkit.org/show_bug.cgi?id=132946 for this issue.
+ASSERT(!flowThread-isRenderNamedFlowThread() || flowThread == locateFlowThreadContainingBlockNoCache());
+return flowThread;
+}
+
+// Not in the middle of layout so have to find the thread the slow way.
+return locateFlowThreadContainingBlockNoCache();
+}
+
 RenderBlock* RenderObject::firstLineBlock() const
 {
 return 0;


Modified: trunk/Source/WebCore/rendering/RenderObject.h (168970 => 168971)

--- trunk/Source/WebCore/rendering/RenderObject.h	2014-05-16 17:07:09 UTC (rev 168970)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2014-05-16 18:26:24 UTC (rev 168971)
@@ -891,6 +891,8 @@
 
 private:
 RenderFlowThread* locateFlowThreadContainingBlock() const;
+RenderFlowThread* locateFlowThreadContainingBlockNoCache() const;
+
 void removeFromRenderFlowThread();
 void removeFromRenderFlowThreadRecursive(RenderFlowThread*);
 






___
webkit-changes mailing list
webkit-changes@lists.w

[webkit-changes] [168678] trunk/Source/WebInspectorUI

[stavila]

Title: [168678] trunk/Source/WebInspectorUI








Revision 168678
Author stav...@adobe.com
Date 2014-05-13 06:11:25 -0700 (Tue, 13 May 2014)


Log Message
Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged
https://bugs.webkit.org/show_bug.cgi?id=132731

Reviewed by Joseph Pecoraro.

Added the regionLayoutUpdated event back into the inspector for compatibility with iOS 7
and removed regionOversetChanged from the iOS7 inspector as iOS 7 does not implement that event.

* UserInterface/Models/ScriptTimelineRecord.js:
* UserInterface/Protocol/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (168677 => 168678)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-05-13 13:11:25 UTC (rev 168678)
@@ -1,3 +1,19 @@
+2014-05-13  Radu Stavila  stav...@adobe.com
+
+Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged
+https://bugs.webkit.org/show_bug.cgi?id=132731
+
+Reviewed by Joseph Pecoraro.
+
+Added the regionLayoutUpdated event back into the inspector for compatibility with iOS 7
+and removed regionOversetChanged from the iOS7 inspector as iOS 7 does not implement that event.
+
+* UserInterface/Models/ScriptTimelineRecord.js:
+* UserInterface/Protocol/CSSObserver.js:
+(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
+* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+* Versions/Inspector-iOS-7.0.json:
+
 2014-05-12  Brent Fulgham  bfulg...@apple.com
 
 [Win] Correct Cygwin Path Confusion in WebInspectorUI Build


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (168677 => 168678)

--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -190,6 +190,7 @@
 nameMap.set(webkitplaybacktargetavailabilitychanged, Playback Target Availability Changed);
 nameMap.set(webkitpointerlockchange, Pointer Lock Change);
 nameMap.set(webkitpointerlockerror, Pointer Lock Error);
+nameMap.set(webkitregionlayoutupdate, Region Layout Update);// COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged.
 nameMap.set(webkitregionoversetchange, Region Overset Change);
 nameMap.set(webkitremovesourcebuffer, Remove Source Buffer);
 nameMap.set(webkitresourcetimingbufferfull, Resource Timing Buffer Full);


Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js (168677 => 168678)

--- trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -63,6 +63,12 @@
 WebInspector.domTreeManager.namedFlowRemoved(documentNodeId, flowName);
 },
 
+// COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged.
+regionLayoutUpdated: function(namedFlow)
+{
+WebInspector.domTreeManager.regionLayoutUpdated(namedFlow);
+},
+
 regionOversetChanged: function(namedFlow)
 {
 WebInspector.domTreeManager.regionOversetChanged(namedFlow);


Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (168677 => 168678)

--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -203,7 +203,7 @@
 InspectorBackend.registerEvent(CSS.styleSheetChanged, [styleSheetId]);
 InspectorBackend.registerEvent(CSS.namedFlowCreated, [namedFlow]);
 InspectorBackend.registerEvent(CSS.namedFlowRemoved, [documentNodeId, flowName]);
-InspectorBackend.registerEvent(CSS.regionOversetChanged, [namedFlow]);
+InspectorBackend.registerEvent(CSS.regionLayoutUpdated, [namedFlow]);
 InspectorBackend.registerCommand(CSS.enable, [], []);
 InspectorBackend.registerCommand(CSS.disable, [], []);
 InspectorBackend.registerCommand(CSS.getMatchedStylesForNode, [{name: nodeId, type: numb

[webkit-changes] [168630] trunk/LayoutTests

[stavila]

Title: [168630] trunk/LayoutTests








Revision 168630
Author stav...@adobe.com
Date 2014-05-12 11:19:36 -0700 (Mon, 12 May 2014)


Log Message
fast/multicol/newmulticol/first-letter-create.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=132744

Reviewed by Antti Koivisto.

Modified test to not display anything as its only purpose is to ensure it doesn't crash.

* TestExpectations:
* fast/multicol/newmulticol/first-letter-create-expected.html:
* fast/multicol/newmulticol/first-letter-create.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html
trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html




Diff

Modified: trunk/LayoutTests/ChangeLog (168629 => 168630)

--- trunk/LayoutTests/ChangeLog	2014-05-12 18:18:53 UTC (rev 168629)
+++ trunk/LayoutTests/ChangeLog	2014-05-12 18:19:36 UTC (rev 168630)
@@ -1,3 +1,16 @@
+2014-05-12  Radu Stavila  stav...@adobe.com
+
+fast/multicol/newmulticol/first-letter-create.html is very flaky
+https://bugs.webkit.org/show_bug.cgi?id=132744
+
+Reviewed by Antti Koivisto.
+
+Modified test to not display anything as its only purpose is to ensure it doesn't crash.
+
+* TestExpectations:
+* fast/multicol/newmulticol/first-letter-create-expected.html:
+* fast/multicol/newmulticol/first-letter-create.html:
+
 2014-05-12  Antti Koivisto  an...@apple.com
 
 REGRESSION (r159560): Text clips on tile border if line-height  font-size


Modified: trunk/LayoutTests/TestExpectations (168629 => 168630)

--- trunk/LayoutTests/TestExpectations	2014-05-12 18:18:53 UTC (rev 168629)
+++ trunk/LayoutTests/TestExpectations	2014-05-12 18:19:36 UTC (rev 168630)
@@ -118,8 +118,6 @@
 # Regression from r167652:
 webkit.org/b/131982 [ Debug ] fast/regions/cssom/region-range-for-box-crash.html [ Crash ]
 
-webkit.org/b/132744 fast/multicol/newmulticol/first-letter-create.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html [ Skip ]
 webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html [ Skip ]
 webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-auto.html [ Skip ]


Modified: trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html (168629 => 168630)

--- trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html	2014-05-12 18:18:53 UTC (rev 168629)
+++ trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html	2014-05-12 18:19:36 UTC (rev 168630)
@@ -1,36 +1,4 @@
 !-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=132625 --
 
-style
-  .f::first-letter { color: green }
-/style
-
-script
-  window._onload_ = function() 
-  {
-var lst = document.getElementsByClassName(d);
-for (var i = 0; i  lst.length; ++i)
-  lst[i].insertBefore(document.createTextNode(Text), lst[i].firstChild);
-  }
-/script
-
-table
-  tr
-td class=f dMore Text/td
-  /tr
-/table
-
-script
-  var head = document.getElementsByTagName(head)[0];
-  var style = document.createElement(style);
-  style.innerHTML=* { \n\
--webkit-animation-name: name5; \n\
--webkit-animation-duration: 4s; \n\
-} \n\
-@-webkit-keyframes name5 { \n\
-  from { \n\
-  } \n\
-  to { \n\
--webkit-columns: ; \n\
-;
-  head.appendChild(style);
-/script
\ No newline at end of file
+body
+/body
\ No newline at end of file


Modified: trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html (168629 => 168630)

--- trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html	2014-05-12 18:18:53 UTC (rev 168629)
+++ trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html	2014-05-12 18:19:36 UTC (rev 168630)
@@ -13,7 +13,7 @@
   }
 /script
 
-table class=test
+table class=test style=visibility:hidden
   tr
 td class=f dMore Text/td
   /tr






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [168448] trunk

[stavila]

Title: [168448] trunk








Revision 168448
Author stav...@adobe.com
Date 2014-05-07 15:48:31 -0700 (Wed, 07 May 2014)


Log Message
Use after free in WebCore::RenderObject::nextSibling / WebCore::RenderBoxModelObject::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=132625

Reviewed by David Hyatt.

Source/WebCore:
Fixed problem with dynamically inserting first letter elements.

Test: fast/multicol/newmulticol/first-letter-create.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getFirstLetter):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderBlock.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):

LayoutTests:
Added test for special case which might cause use after free.

* fast/multicol/newmulticol/first-letter-create-expected.html: Added.
* fast/multicol/newmulticol/first-letter-create.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderTextFragment.h


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html
trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html




Diff

Modified: trunk/LayoutTests/ChangeLog (168447 => 168448)

--- trunk/LayoutTests/ChangeLog	2014-05-07 22:42:46 UTC (rev 168447)
+++ trunk/LayoutTests/ChangeLog	2014-05-07 22:48:31 UTC (rev 168448)
@@ -1,3 +1,15 @@
+2014-05-07  Radu Stavila  stav...@adobe.com
+
+Use after free in WebCore::RenderObject::nextSibling / WebCore::RenderBoxModelObject::moveChildrenTo
+https://bugs.webkit.org/show_bug.cgi?id=132625
+
+Reviewed by David Hyatt.
+
+Added test for special case which might cause use after free.
+
+* fast/multicol/newmulticol/first-letter-create-expected.html: Added.
+* fast/multicol/newmulticol/first-letter-create.html: Added.
+
 2014-05-07  Chris Fleizach  cfleiz...@apple.com
 
 AX: aria-expanded changes are not communicated to clients


Added: trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html (0 => 168448)

--- trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create-expected.html	2014-05-07 22:48:31 UTC (rev 168448)
@@ -0,0 +1,36 @@
+!-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=132625 --
+
+style
+  .f::first-letter { color: green }
+/style
+
+script
+  window._onload_ = function() 
+  {
+var lst = document.getElementsByClassName(d);
+for (var i = 0; i  lst.length; ++i)
+  lst[i].insertBefore(document.createTextNode(Text), lst[i].firstChild);
+  }
+/script
+
+table
+  tr
+td class=f dMore Text/td
+  /tr
+/table
+
+script
+  var head = document.getElementsByTagName(head)[0];
+  var style = document.createElement(style);
+  style.innerHTML=* { \n\
+-webkit-animation-name: name5; \n\
+-webkit-animation-duration: 4s; \n\
+} \n\
+@-webkit-keyframes name5 { \n\
+  from { \n\
+  } \n\
+  to { \n\
+-webkit-columns: ; \n\
+;
+  head.appendChild(style);
+/script
\ No newline at end of file


Added: trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html (0 => 168448)

--- trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/first-letter-create.html	2014-05-07 22:48:31 UTC (rev 168448)
@@ -0,0 +1,36 @@
+!-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=132625 --
+
+style
+  .f::first-letter { color: green }
+/style
+
+script
+  window._onload_ = function() 
+  {
+var lst = document.getElementsByClassName(d);
+for (var i = 0; i  lst.length; ++i)
+  lst[i].insertBefore(document.createTextNode(Text), lst[i].firstChild);
+  }
+/script
+
+table class=test
+  tr
+td class=f dMore Text/td
+  /tr
+/table
+
+script
+  var head = document.getElementsByTagName(head)[0];
+  var style = document.createElement(style);
+  style.innerHTML=* { \n\
+-webkit-animation-name: name5; \n\
+-webkit-animation-duration: 4s; \n\
+} \n\
+@-webkit-keyframes name5 { \n\
+  from { \n\
+  } \n\
+  to { \n\
+-webkit-columns: ; \n\
+;
+  head.appendChild(style);
+/script
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (168447 => 168448)

--- trunk/Source/WebCore/ChangeLog	2014-05-07 22:42:46 UTC (rev 168447)
+++ trunk/Source/WebCore/ChangeLog	2014-05-07 22:48:31 UTC (rev 168448)
@@ -1,3 +1,21 @@
+2014-05-07  Radu S

[webkit-changes] [168355] trunk/Source/WebInspectorUI

[stavila]

Title: [168355] trunk/Source/WebInspectorUI








Revision 168355
Author stav...@adobe.com
Date 2014-05-06 05:37:52 -0700 (Tue, 06 May 2014)


Log Message
Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI
https://bugs.webkit.org/show_bug.cgi?id=132566

Reviewed by Antti Koivisto.

The regionOversetChange event was missing from the iOS7 WebInspector.

* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (168354 => 168355)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-05-06 12:16:58 UTC (rev 168354)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-05-06 12:37:52 UTC (rev 168355)
@@ -1,3 +1,15 @@
+2014-05-06  Radu Stavila  stav...@adobe.com
+
+Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI
+https://bugs.webkit.org/show_bug.cgi?id=132566
+
+Reviewed by Antti Koivisto.
+
+The regionOversetChange event was missing from the iOS7 WebInspector.
+
+* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+* Versions/Inspector-iOS-7.0.json:
+
 2014-05-05  Radu Stavila  stav...@adobe.com
 
 [CSS Regions] Remove regionLayoutUpdate event


Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (168354 => 168355)

--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-06 12:16:58 UTC (rev 168354)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-06 12:37:52 UTC (rev 168355)
@@ -203,6 +203,7 @@
 InspectorBackend.registerEvent(CSS.styleSheetChanged, [styleSheetId]);
 InspectorBackend.registerEvent(CSS.namedFlowCreated, [namedFlow]);
 InspectorBackend.registerEvent(CSS.namedFlowRemoved, [documentNodeId, flowName]);
+InspectorBackend.registerEvent(CSS.regionOversetChanged, [namedFlow]);
 InspectorBackend.registerCommand(CSS.enable, [], []);
 InspectorBackend.registerCommand(CSS.disable, [], []);
 InspectorBackend.registerCommand(CSS.getMatchedStylesForNode, [{name: nodeId, type: number, optional: false}, {name: includePseudo, type: boolean, optional: true}, {name: includeInherited, type: boolean, optional: true}], [matchedCSSRules, pseudoElements, inherited]);


Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (168354 => 168355)

--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-05-06 12:16:58 UTC (rev 168354)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-05-06 12:37:52 UTC (rev 168355)
@@ -2183,6 +2183,13 @@
 { name: flowName, type: string, description: Identifier of the removed Named Flow. }
 ],
 description: Fires when a Named Flow is removed: has no associated content nodes and regions.
+},
+{
+name: regionOversetChanged,
+parameters: [
+{ name: namedFlow, $ref: NamedFlow, description: The Named Flow containing the regions whose regionOverset values changed. }
+],
+description: Fires if any of the regionOverset values changed in a Named Flow's region chain.
 }
 ]
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [168375] trunk/PerformanceTests

[stavila]

Title: [168375] trunk/PerformanceTests








Revision 168375
Author stav...@adobe.com
Date 2014-05-06 12:48:53 -0700 (Tue, 06 May 2014)


Log Message
[CSSRegions] Enabled regions performance tests by default
https://bugs.webkit.org/show_bug.cgi?id=128244

Reviewed by Andreas Kling.

Enabled regions performance tests.

* Skipped:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped




Diff

Modified: trunk/PerformanceTests/ChangeLog (168374 => 168375)

--- trunk/PerformanceTests/ChangeLog	2014-05-06 19:28:25 UTC (rev 168374)
+++ trunk/PerformanceTests/ChangeLog	2014-05-06 19:48:53 UTC (rev 168375)
@@ -1,3 +1,14 @@
+2014-05-06  Radu Stavila  stav...@adobe.com
+
+[CSSRegions] Enabled regions performance tests by default
+https://bugs.webkit.org/show_bug.cgi?id=128244
+
+Reviewed by Andreas Kling.
+
+Enabled regions performance tests.
+
+* Skipped:
+
 2014-04-25  Andreas Kling  akl...@apple.com
 
 Bump jQuery to same version that dromaeo.com uses.


Modified: trunk/PerformanceTests/Skipped (168374 => 168375)

--- trunk/PerformanceTests/Skipped	2014-05-06 19:28:25 UTC (rev 168374)
+++ trunk/PerformanceTests/Skipped	2014-05-06 19:48:53 UTC (rev 168375)
@@ -77,15 +77,6 @@
 # but is still useful for testing the threaded parser.
 Parser/html-parser-threaded.html
 
-# Skip the regions performance tests for now.
-Layout/RegionsAuto.html
-Layout/RegionsAutoMaxHeight.html
-Layout/RegionsFixed.html
-Layout/RegionsFixedShort.html
-Layout/RegionsSelection.html
-Layout/RegionsSelectionMixedContent.html
-Layout/RegionsSelectAllMixedContent.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=113811#c2
 Layout/LineLayoutJapanese.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [168288] trunk

[stavila]

Title: [168288] trunk








Revision 168288
Author stav...@adobe.com
Date 2014-05-05 09:14:47 -0700 (Mon, 05 May 2014)


Log Message
[CSS Regions] Elements with overflow:auto are not painted inside regions when following a float
https://bugs.webkit.org/show_bug.cgi?id=131161

Reviewed by David Hyatt.

Source/WebCore:
When a float-avoiding element (such as overflow:auto) is flowed into a flow thread after a float, its
logical left is not set on its frameRect or its layer's topLeft, but is instead kept in its RenderBoxRegionInfo
structure. In some situation, this causes paint rejection to kick-in because intersecting the layer's rect
(which DOESN'T contain the logical left from the region info object) with the computed background rect
(which contains the logical left from the region info object) results in an empty rect.

Test: fast/regions/overflow-auto-after-float.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):

LayoutTests:
Added test for an overflow:auto element being flowed after a float.

* fast/regions/overflow-auto-after-float-expected.html: Added.
* fast/regions/overflow-auto-after-float.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/regions/overflow-auto-after-float-expected.html
trunk/LayoutTests/fast/regions/overflow-auto-after-float.html




Diff

Modified: trunk/LayoutTests/ChangeLog (168287 => 168288)

--- trunk/LayoutTests/ChangeLog	2014-05-05 14:51:48 UTC (rev 168287)
+++ trunk/LayoutTests/ChangeLog	2014-05-05 16:14:47 UTC (rev 168288)
@@ -1,3 +1,15 @@
+2014-05-05  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Elements with overflow:auto are not painted inside regions when following a float
+https://bugs.webkit.org/show_bug.cgi?id=131161
+
+Reviewed by David Hyatt.
+
+Added test for an overflow:auto element being flowed after a float.
+
+* fast/regions/overflow-auto-after-float-expected.html: Added.
+* fast/regions/overflow-auto-after-float.html: Added.
+
 2014-05-05  Andrei Bucur  abu...@adobe.com
 
 [CSSRegions] Slider displayed wrong in regions


Added: trunk/LayoutTests/fast/regions/overflow-auto-after-float-expected.html (0 => 168288)

--- trunk/LayoutTests/fast/regions/overflow-auto-after-float-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-auto-after-float-expected.html	2014-05-05 16:14:47 UTC (rev 168288)
@@ -0,0 +1,41 @@
+!DOCTYPE html
+
+html
+head
+style
+.region {
+width: 350px;
+height: 150px;
+border: thin solid black;
+padding: 10px;
+}
+
+#float {
+width: 150px;
+height: 50px;
+background-color: green;
+color: white;
+float: left;
+}
+
+#after {
+width: 150px;
+height: 100px;
+background-color: blue;
+color: white;
+overflow: auto;
+position: relative;
+}
+/style
+/head
+
+body
+a href="" 131161 - [CSS Regions] Elements with overflow:auto are not painted inside regions when following a float/a
+pA span style=color:bluebblue/b/span div should be visible next to span style=color:greenbgreen/b/span float./p
+
+div class=region
+div id=floatThis is a FLOAT/div
+div id=afterThis box has OVERFLOW:AUTO/div
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/overflow-auto-after-float.html (0 => 168288)

--- trunk/LayoutTests/fast/regions/overflow-auto-after-float.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-auto-after-float.html	2014-05-05 16:14:47 UTC (rev 168288)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+
+html
+head
+style
+.region {
+width: 350px;
+height: 150px;
+border: thin solid black;
+padding: 10px;
+-webkit-flow-from: flow;
+}
+
+#float {
+width: 150px;
+height: 50px;
+background-color: green;
+color: white;
+float: left;
+}
+
+#after {
+width: 150px;
+height: 100px;
+background-color: blue;
+color: white;
+overflow: auto;
+position: relative;
+}
+
+.flow {
+-webkit-flow-into: flow;
+}
+/style
+/head
+
+body
+a href="" 131161 - [CSS Regions] Elements with overflow:auto are not painted inside regions when following a float/a
+pA

[webkit-changes] [168306] trunk

[stavila]

Title: [168306] trunk








Revision 168306
Author stav...@adobe.com
Date 2014-05-05 11:49:54 -0700 (Mon, 05 May 2014)


Log Message
[CSS Regions] Remove regionLayoutUpdate event
https://bugs.webkit.org/show_bug.cgi?id=132564

Reviewed by Simon Fraser.

Source/WebCore:
The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
regionOversetChange and regionFragmentChange.

No new tests needed, this patch removes a feature.

* dom/EventNames.h:
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent): Deleted.
* dom/WebKitNamedFlow.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask): Deleted.
(WebCore::UpdateRegionLayoutTask::scheduleFor): Deleted.
(WebCore::UpdateRegionLayoutTask::unschedule): Deleted.
(WebCore::UpdateRegionLayoutTask::reset): Deleted.
(WebCore::UpdateRegionLayoutTask::timerFired): Deleted.
(WebCore::InspectorCSSAgent::didUpdateRegionLayout): Deleted.
(WebCore::InspectorCSSAgent::regionLayoutUpdated): Deleted.
* inspector/InspectorCSSAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl): Deleted.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didUpdateRegionLayout): Deleted.
* inspector/protocol/CSS.json:
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::updateOversetState):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::layout):
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded): Deleted.
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired): Deleted.
* rendering/RenderNamedFlowThread.h:

Source/WebInspectorUI:
The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
regionOversetChange and regionFragmentChange.

* UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.get regionLayoutUpdated): Deleted.
* UserInterface/Models/ScriptTimelineRecord.js:
* UserInterface/Protocol/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionLayoutUpdated): Deleted.
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:

LayoutTests:
Removed test for regionLayoutUpdate event.

* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Removed.
* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventNames.h
trunk/Source/WebCore/dom/WebKitNamedFlow.cpp
trunk/Source/WebCore/dom/WebKitNamedFlow.h
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/protocol/CSS.json
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json


Removed Paths

trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt
trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (168305 => 168306)

--- trunk/LayoutTests/ChangeLog	2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/LayoutTests/ChangeLog	2014-05-05 18:49:54 UTC (rev 168306)
@@ -1,3 +1,15 @@
+2014-05-05  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Remove regionLayoutUpdate event
+https://bugs.webkit.org/show_bug.cgi?id=132564
+
+Reviewed by Simon Fraser.
+
+Removed test for regionLayoutUpdate event.
+
+* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Removed.
+* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Removed.
+
 2014-05-05  Rik Cabanier  caban...@adobe.com
 
 Enhance IDL compiler so it supports unrestricted float and double


Deleted: trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt (168305 => 168306)

--- trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipl

[webkit-changes] [167810] trunk/Source/WebCore

[stavila]

Title: [167810] trunk/Source/WebCore








Revision 167810
Author stav...@adobe.com
Date 2014-04-25 10:58:19 -0700 (Fri, 25 Apr 2014)


Log Message
[CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear
https://bugs.webkit.org/show_bug.cgi?id=132050

Reviewed by Andreas Kling.

The objectShouldPaintInFlowRegion is no longer used only by the painting process
but also for hit-testing, so it was renamed to something more generic (objectShouldFragmentInFlowRegion).

No new tests required, it's just a method rename.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion):
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion): Deleted.
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::ensureOverflowForBox):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderReplaced.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167809 => 167810)

--- trunk/Source/WebCore/ChangeLog	2014-04-25 17:53:32 UTC (rev 167809)
+++ trunk/Source/WebCore/ChangeLog	2014-04-25 17:58:19 UTC (rev 167810)
@@ -1,3 +1,33 @@
+2014-04-25  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear
+https://bugs.webkit.org/show_bug.cgi?id=132050
+
+Reviewed by Andreas Kling.
+
+The objectShouldPaintInFlowRegion is no longer used only by the painting process
+but also for hit-testing, so it was renamed to something more generic (objectShouldFragmentInFlowRegion).
+
+No new tests required, it's just a method rename.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paint):
+(WebCore::RenderBlock::selectionGaps):
+(WebCore::RenderBlock::nodeAtPoint):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::positionForPoint):
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion):
+(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion): Deleted.
+* rendering/RenderFlowThread.h:
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::paintLayer):
+(WebCore::RenderLayer::hitTestLayer):
+* rendering/RenderRegion.cpp:
+(WebCore::RenderRegion::ensureOverflowForBox):
+* rendering/RenderReplaced.cpp:
+(WebCore::RenderReplaced::shouldPaint):
+
 2014-04-25  Enrica Casucci  enr...@apple.com
 
 iOS build fix after http://trac.webkit.org/changeset/167803


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (167809 => 167810)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-04-25 17:53:32 UTC (rev 167809)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-04-25 17:58:19 UTC (rev 167810)
@@ -1792,7 +1792,7 @@
 PaintPhase phase = paintInfo.phase;
 
 // Check our region range to make sure we need to be painting in this region.
-if (paintInfo.renderNamedFlowFragment  !paintInfo.renderNamedFlowFragment-flowThread()-objectShouldPaintInFlowRegion(this, paintInfo.renderNamedFlowFragment))
+if (paintInfo.renderNamedFlowFragment  !paintInfo.renderNamedFlowFragment-flowThread()-objectShouldFragmentInFlowRegion(this, paintInfo.renderNamedFlowFragment))
 return;
 
 // Check if we need to do anything at all.
@@ -2415,7 +2415,7 @@
 
 if (paintInfo  paintInfo-renderNamedFlowFragment  paintInfo-paintContainer-isRenderFlowThread()) {
 // Make sure the current object is actually flowed into the region being painted.
-if (!toRenderFlowThread(paintInfo-paintContainer)-objectShouldPaintInFlowRegion(this, paintInfo-renderNamedFlowFragment))
+if (!toRenderFlowThread(paintInfo-paintContainer)-objectShouldFragmentInFlowRegion(this, paintInfo-renderNamedFlowFragment))
 return result;
 }
 
@@ -2958,7 +2958,7 @@
 if (locationInContainer.region()) {
 RenderFlowThread* flowThread = flowThreadContainingBlock();
 ASSERT(flowThread);
-if (!flowThread-objectShouldPaintInFlowRegion(this, locationInContainer.region()))
+if (!flowThread-objectShouldFragmentInFlowRegion(this, locationInContainer.region()))
 return false;
 }
 


Modified: trunk/Source/WebCore/rendering/RenderB

[webkit-changes] [167489] trunk

[stavila]

Title: [167489] trunk








Revision 167489
Author stav...@adobe.com
Date 2014-04-18 06:07:48 -0700 (Fri, 18 Apr 2014)


Log Message
[CSSRegions] Incorrect background paint on positioned element hover
https://bugs.webkit.org/show_bug.cgi?id=131617

Reviewed by Andrei Bucur.

Source/WebCore:
When computing the repaint rect for absolute elements flowed into regions, the Y location of the
region within the flow thread must no longer be added to the repaint rect's location because absolute
positioned elements get pushed down through the regions by their absolute top. So adding the region's
position in the flow thread and then adding the element's absolute top would cause us to add
something twice.

Tests: fast/regions/repaint/repaint-absolute-pushed-to-next-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:
Added test for the proper repainting of absolute positioned elements in regions when the
absolute top of the elements causes it to be pushed to the next region.

* fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt: Added.
* fast/regions/repaint/repaint-absolute-pushed-to-next-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt
trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167488 => 167489)

--- trunk/LayoutTests/ChangeLog	2014-04-18 12:34:03 UTC (rev 167488)
+++ trunk/LayoutTests/ChangeLog	2014-04-18 13:07:48 UTC (rev 167489)
@@ -1,3 +1,16 @@
+2014-04-18  Radu Stavila  stav...@adobe.com
+
+[CSSRegions] Incorrect background paint on positioned element hover
+https://bugs.webkit.org/show_bug.cgi?id=131617
+
+Reviewed by Andrei Bucur.
+
+Added test for the proper repainting of absolute positioned elements in regions when the
+absolute top of the elements causes it to be pushed to the next region.
+
+* fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt: Added.
+* fast/regions/repaint/repaint-absolute-pushed-to-next-region.html: Added.
+
 2014-04-18  Philippe Normand  pnorm...@igalia.com
 
 Remove NETWORK_INFO support


Added: trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt (0 => 167489)

--- trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt	2014-04-18 13:07:48 UTC (rev 167489)
@@ -0,0 +1,12 @@
+Bug 131617 - [CSSRegions] Incorrect background paint on positioned element hover
+When hovering the blue div, it should turn green
+
+(repaint rects
+  (rect 105 205 100 300)
+  (rect 305 105 100 300)
+  (rect 105 205 100 300)
+  (rect 305 105 100 300)
+  (rect 105 205 100 300)
+  (rect 305 105 100 300)
+)
+


Added: trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region.html (0 => 167489)

--- trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/repaint-absolute-pushed-to-next-region.html	2014-04-18 13:07:48 UTC (rev 167489)
@@ -0,0 +1,64 @@
+!DOCTYPE html
+html
+head
+script src="" type=text/_javascript_/script
+
+style
+#cn {
+-webkit-flow-into: flow;
+}
+#region {
+-webkit-flow-from: flow;
+position: absolute;
+top: 100px;
+left: 100px;
+width: 100px;
+height: 100px;
+border: 5px solid green;
+}
+#region2 {
+-webkit-flow-from: flow;
+position: absolute;
+top: 100px;
+left: 300px;
+width: 100px;
+height: 100px;
+border: 5px solid green;
+}
+#inner {
+position: absolute;
+top: 100px;
+left: 0px; 
+width: 100px;
+height: 300px;
+background-color: blue;
+}
+#inner:hover { background-color: lime; }
+/style
+/head
+
+body _onload_=runRepaintTest();
+a href="" 131617 - [CSSRegions] Incorrect background paint on positioned element hover/a
+pWhen hovering the blue div, it should turn green/p
+
+div id=cn
+div id=inner/div
+/div
+div id=region/div
+div id=region2/div
+
+script type=text/_javascript_
+function repaintTest() 
+{
+if(!window.testRunner

[webkit-changes] [167492] trunk/LayoutTests

[stavila]

Title: [167492] trunk/LayoutTests








Revision 167492
Author stav...@adobe.com
Date 2014-04-18 10:08:11 -0700 (Fri, 18 Apr 2014)


Log Message
[CSS Regions] Content overflowing a transformed region is clipped
https://bugs.webkit.org/show_bug.cgi?id=116833

Reviewed by Mihnea Ovidenie.

Added test for overflow of content in 3d transformed regions.

* fast/regions/overflow-3dtransformed-region-expected.txt: Added.
* fast/regions/overflow-3dtransformed-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt
trunk/LayoutTests/fast/regions/overflow-3dtransformed-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167491 => 167492)

--- trunk/LayoutTests/ChangeLog	2014-04-18 17:08:07 UTC (rev 167491)
+++ trunk/LayoutTests/ChangeLog	2014-04-18 17:08:11 UTC (rev 167492)
@@ -1,5 +1,17 @@
 2014-04-18  Radu Stavila  stav...@adobe.com
 
+[CSS Regions] Content overflowing a transformed region is clipped
+https://bugs.webkit.org/show_bug.cgi?id=116833
+
+Reviewed by Mihnea Ovidenie.
+
+Added test for overflow of content in 3d transformed regions.
+
+* fast/regions/overflow-3dtransformed-region-expected.txt: Added.
+* fast/regions/overflow-3dtransformed-region.html: Added.
+
+2014-04-18  Radu Stavila  stav...@adobe.com
+
 [CSSRegions] Incorrect background paint on positioned element hover
 https://bugs.webkit.org/show_bug.cgi?id=131617
 


Added: trunk/LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt (0 => 167492)

--- trunk/LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt	2014-04-18 17:08:11 UTC (rev 167492)
@@ -0,0 +1,6 @@
+PASS Overflow hover event processed OK.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+


Added: trunk/LayoutTests/fast/regions/overflow-3dtransformed-region.html (0 => 167492)

--- trunk/LayoutTests/fast/regions/overflow-3dtransformed-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-3dtransformed-region.html	2014-04-18 17:08:11 UTC (rev 167492)
@@ -0,0 +1,86 @@
+!doctype html
+html lang=en
+head
+script src=""
+titleAccelerated compositing due to 3D transforms/title
+style
+body {
+-webkit-perspective: 400px;
+}
+div.region {
+margin: 3em;
+}
+div.region:last-child {
+margin-left: 5em;
+}
+.region {
+-webkit-flow-from: f;
+-webkit-transform: rotateY(45deg);
+}
+.big-square {
+width: 150px;
+height: 150px;
+}
+.bordered {
+border: 2px solid black;
+}
+#content {
+-webkit-flow-into: f;
+margin-top: 40px;
+width: 1000px;
+height: 300px;
+background-color: salmon;
+border: 4px solid blue;
+border-right-width: 10px;
+}
+#content:hover
+{
+background-color: green;
+}
+#console {
+position: absolute;
+right: 10px;
+top: 0px;
+}
+/style
+/head
+body
+div id=console/div
+
+a class=instructions href="" 116833 - [CSS Regions] Content overflowing a transformed region is clipped/a
+p class=instructions This test passes if the salmon box overflows the regions, has a blue border all around and turns green when hovered/p
+
+div id=content/div
+
+div class=region big-square bordered/div
+div class=region big-square bordered/div
+
+script type=text/_javascript_
+if (window.testRunner)
+testRunner.dumpAsText();
+
+if (window.eventSender) {
+var elementsToHide = document.querySelectorAll(.instructions);
+for (var i=0; ielementsToHide.length; i++)
+elementsToHide[i].style.visibility = hidden;
+
+eventSender.mouseMoveTo(350, 300);
+eventSender.mouseDown(0);
+eventSender.leapForward(500);
+eventSender.mouseUp(0);
+
+var content = document.getElementById(content);
+var bckgColor = window.getComputedStyle(content).getPropertyValue(background-color);
+
+if (bckgColor == rgb(0, 128, 0))
+testPassed(Overflow hover event processed OK.);
+else
+testFailed(Overflow hover event FAILED to process.);
+}
+else
+document.getElementById(console).style.visibility = hidden;
+/script
+
+script src=""
+/body
+/html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167018] trunk

[stavila]

Title: [167018] trunk








Revision 167018
Author stav...@adobe.com
Date 2014-04-09 10:07:50 -0700 (Wed, 09 Apr 2014)


Log Message
[CSS Regions] Monolithic elements should not affect the layout of the content outside its region
https://bugs.webkit.org/show_bug.cgi?id=130499

Reviewed by David Hyatt.

Source/WebCore:

When performing layout on an element flowed into regions, its logical height must not be incremented
past the region's logical bottom for monolithic elements in regions different than the last region their containing
block is fragmented into. This ensures that the following elements are correctly laid out
from the top of the next region.
This change must also be applied to floats in order to prevent text from avoiding part
of a float that did not actually made it into the current region, but instead overflowed
the previous one.

Tests: fast/regions/fragmentation-after-float-overflow-single-region.html
   fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html
   fast/regions/fragmentation-after-monolithic-overflow-single-region.html
   fast/regions/fragmentation-after-monolithic-overflow.html

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::computePlacedFloatsTree):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::applyAfterBreak): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock): Deleted.
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild): Deleted.
* rendering/RenderBlockFlow.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::isBoxInDifferentRegionsAsFloat):
* rendering/RenderFlowThread.h:

LayoutTests:

Added tests for different types of fragmentation following monolithic content
overflowing its region.
Rebased the webkit-flow-float-unable-to-push test as its expected result was not the correct one.

* fast/regions/webkit-flow-float-unable-to-push-expected.html:
* fast/regions/fragmentation-after-float-overflow-single-region-expected.html: Added.
* fast/regions/fragmentation-after-float-overflow-single-region.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-single-region-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-single-region.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/webkit-flow-float-unable-to-push-expected.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h


Added Paths

trunk/LayoutTests/fast/regions/fragmentation-after-float-overflow-single-region-expected.html
trunk/LayoutTests/fast/regions/fragmentation-after-float-overflow-single-region.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow-expected.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow-single-region-expected.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow-single-region.html
trunk/LayoutTests/fast/regions/fragmentation-after-monolithic-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167017 => 167018)

--- trunk/LayoutTests/ChangeLog	2014-04-09 17:05:18 UTC (rev 167017)
+++ trunk/LayoutTests/ChangeLog	2014-04-09 17:07:50 UTC (rev 167018)
@@ -1,3 +1,24 @@
+2014-04-09  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Monolithic elements should not affect the layout of the content outside its region
+https://bugs.webkit.org/show_bug.cgi?id=130499
+
+Reviewed by David Hyatt.
+
+Added tests for different types of fragmentation following monolithic content
+overflowing its region.
+Rebased the webkit-flow-float-unable-to-push test as its expected result was not the correct one.
+
+* fast/regions/webkit-flow-float-unable-to-push-expected.html:
+* fast/regions/fragmentation-after-float-overflow-single-region-expected.html: Added.
+* fast/regions/fragmentation-after-float-overflow-single-region.html: Added.
+* fast/regions/fragmentation-after-monolithic-overflow-expected.html: Added.
+* fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html: Added.
+* fast/regi

[webkit-changes] [166428] trunk

[stavila]

Title: [166428] trunk








Revision 166428
Author stav...@adobe.com
Date 2014-03-28 14:55:46 -0700 (Fri, 28 Mar 2014)


Log Message
In some situations, partial layouts of floating elements produce incorrect results.
https://bugs.webkit.org/show_bug.cgi?id=122668

Reviewed by David Hyatt.

Source/WebCore:

When performing partial layout of float elements and checking if other float
elements are encountered, incorrect results were obtained by not checking
the size of the existing floats vector.

Test: fast/block/float/floats-in-clean-line-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):

LayoutTests:

Added test to ensure an assertion is not reached when performing a partial
layout of float elements in certain situations.

* fast/block/float/floats-in-clean-line-crash-expected.txt: Added.
* fast/block/float/floats-in-clean-line-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash-expected.txt
trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166427 => 166428)

--- trunk/LayoutTests/ChangeLog	2014-03-28 21:38:25 UTC (rev 166427)
+++ trunk/LayoutTests/ChangeLog	2014-03-28 21:55:46 UTC (rev 166428)
@@ -1,3 +1,16 @@
+2014-03-28  Radu Stavila  stav...@adobe.com
+
+In some situations, partial layouts of floating elements produce incorrect results.
+https://bugs.webkit.org/show_bug.cgi?id=122668
+
+Reviewed by David Hyatt.
+
+Added test to ensure an assertion is not reached when performing a partial
+layout of float elements in certain situations.
+
+* fast/block/float/floats-in-clean-line-crash-expected.txt: Added.
+* fast/block/float/floats-in-clean-line-crash.html: Added.
+
 2014-03-28  Brent Fulgham  bfulg...@apple.com
 
 Unreviewed gardening. Make WebVTT tests less flaky by ensuring captions are set to display


Added: trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash-expected.txt (0 => 166428)

--- trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash-expected.txt	2014-03-28 21:55:46 UTC (rev 166428)
@@ -0,0 +1,4 @@
+Bug 122668 - The test passes if it doesn't crash
+1
+A2
+


Added: trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash.html (0 => 166428)

--- trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/block/float/floats-in-clean-line-crash.html	2014-03-28 21:55:46 UTC (rev 166428)
@@ -0,0 +1,48 @@
+html
+style
+html {
+ height:100%; 
+}
+
+.test { 
+float:left; 
+}
+/style
+
+body
+a href="" 122668 - The test passes if it doesn't crash/a
+br id=br
+div class=test1/div
+divAdiv class=test2/divspan id=span/span/div
+/body
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var br = document.getElementById(br);
+elem = document.getElementById(span);
+document.body.parentNode.insertBefore(elem, document.body.nextSibling);
+try
+{
+document.getElementById(br).lookupNamespacePrefix(text, document.getElementById(br));
+}
+catch(e)
+{
+}
+
+var canvas = document.createElement(canvas);
+canvas.setAttribute(height, 1226);
+canvas.setAttribute(width, 3391);
+br.parentNode.insertBefore(canvas, br.nextSibling);
+var ctx = canvas.getContext(2d);
+ctx.strokeRect(br.appendChild(document.createElement(olist)).offsetLeft, 65535, , 9223372036);
+head = document.getElementsByTagName(head)[0];
+var style = document.createElement(style);
+style.innerHTML=:first-of-type { \n\
+position: fixed;\n\
+} \n\
+;
+head.appendChild(style);
+/script
+/html


Modified: trunk/Source/WebCore/ChangeLog (166427 => 166428)

--- trunk/Source/WebCore/ChangeLog	2014-03-28 21:38:25 UTC (rev 166427)
+++ trunk/Source/WebCore/ChangeLog	2014-03-28 21:55:46 UTC (rev 166428)
@@ -1,3 +1,19 @@
+2014-03-28  Radu Stavila  stav...@adobe.com
+
+In some situations, partial layouts of floating elements produce incorrect results.
+https://bugs.webkit.org/show_bug.cgi?id=122668
+
+Reviewed by David Hyatt.
+
+When performing partial layout of float elements and checking if other float
+elements are encountered, incorrect results were obtained by not checking
+the size of the existing floats vector.
+
+Test: fast/block/float/floats-in-clean-line-crash.html

[webkit-changes] [166259] trunk

[stavila]

Title: [166259] trunk








Revision 166259
Author stav...@adobe.com
Date 2014-03-25 15:01:25 -0700 (Tue, 25 Mar 2014)


Log Message
[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
https://bugs.webkit.org/show_bug.cgi?id=130574

Reviewed by David Hyatt.

Source/WebCore:

When computing the clip rect for painting the box decorations, the scrolled content offset
must be computed by going up the containing block tree, up to the region.

Tests: fast/regions/scrollable-region-scrollable-absolute-content-background.html
   fast/regions/scrollable-region-scrollable-content-background.html

* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):

LayoutTests:

Added tests for properly painting background of children of scrollable elements flowed into regions.

* fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html: Added.
* fast/regions/scrollable-region-scrollable-absolute-content-background.html: Added.
* fast/regions/scrollable-region-scrollable-content-background-expected.html: Added.
* fast/regions/scrollable-region-scrollable-content-background.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp


Added Paths

trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-content-background-expected.html
trunk/LayoutTests/fast/regions/scrollable-region-scrollable-content-background.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166258 => 166259)

--- trunk/LayoutTests/ChangeLog	2014-03-25 21:53:14 UTC (rev 166258)
+++ trunk/LayoutTests/ChangeLog	2014-03-25 22:01:25 UTC (rev 166259)
@@ -1,3 +1,17 @@
+2014-03-25  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
+https://bugs.webkit.org/show_bug.cgi?id=130574
+
+Reviewed by David Hyatt.
+
+Added tests for properly painting background of children of scrollable elements flowed into regions.
+
+* fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html: Added.
+* fast/regions/scrollable-region-scrollable-absolute-content-background.html: Added.
+* fast/regions/scrollable-region-scrollable-content-background-expected.html: Added.
+* fast/regions/scrollable-region-scrollable-content-background.html: Added.
+
 2014-03-25  Michael Saboff  msab...@apple.com
 
 Unreviewed, rolling out r166126.


Added: trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html (0 => 166259)

--- trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html	2014-03-25 22:01:25 UTC (rev 166259)
@@ -0,0 +1,63 @@
+!DOCTYPE html
+html style=font: 16px/1.25 monospace;
+head
+script type=text/_javascript_
+_onload_ = function()
+{
+document.getElementById(container).scrollTop = 40;
+}
+/script
+
+style
+#container {
+border: thick solid green;
+height: 150px;
+overflow: scroll;
+margin: 15px;
+padding: 5px;
+}
+
+#region {
+width: 400px;
+height: 200px;
+border: 2px solid blue;
+margin: 10px;
+padding: 35px;
+}
+
+.blueBackground {
+background: lightblue;
+}
+
+.greenBackground {
+background: lightgreen;
+position: absolute; 
+left: 205px; 
+top: 227px;
+width: 250px;
+}
+
+#bottomDiv {
+position: relative;
+top: 50px;
+width: 100px;
+height: 100px;
+background: green;
+}
+/style
+/head
+
+body
+a style=font-size: 14px href="" Regions] The background of children of scrollablebr/elements flowed into regions is not properly scrolled/a
+pThis test passes if the backgrounds of the paragraphs inside the span style=color:greenbgreen box/b/span is properly painted when scrolling the box./p
+
+div id=region
+div id=container
+p class=greenBackgroundThis text is absolutely positioned and should have a lightgre

[webkit-changes] [166067] trunk/LayoutTests

[stavila]

Title: [166067] trunk/LayoutTests








Revision 166067
Author stav...@adobe.com
Date 2014-03-21 09:43:34 -0700 (Fri, 21 Mar 2014)


Log Message
[CSS Regions] incorrect clipping when the content has CSS Transforms like rotation
https://bugs.webkit.org/show_bug.cgi?id=110198

Reviewed by David Hyatt.

Added test that confirms the issue of transformed content being clipped was fixed.

* fast/regions/overflow-content-transform-rotate-expected.html: Added.
* fast/regions/overflow-content-transform-rotate.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html
trunk/LayoutTests/fast/regions/overflow-content-transform-rotate.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166066 => 166067)

--- trunk/LayoutTests/ChangeLog	2014-03-21 16:31:22 UTC (rev 166066)
+++ trunk/LayoutTests/ChangeLog	2014-03-21 16:43:34 UTC (rev 166067)
@@ -1,3 +1,15 @@
+2014-03-21  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] incorrect clipping when the content has CSS Transforms like rotation
+https://bugs.webkit.org/show_bug.cgi?id=110198
+
+Reviewed by David Hyatt.
+
+Added test that confirms the issue of transformed content being clipped was fixed.
+
+* fast/regions/overflow-content-transform-rotate-expected.html: Added.
+* fast/regions/overflow-content-transform-rotate.html: Added.
+
 2014-03-20  Brent Fulgham  bfulg...@apple.com
 
 Merge WebVTT Tokenizer Updates


Added: trunk/LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html (0 => 166067)

--- trunk/LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html	2014-03-21 16:43:34 UTC (rev 166067)
@@ -0,0 +1,32 @@
+!DOCTYPE HTML
+html lang=en-US
+head
+style
+html {
+-webkit-font-smoothing: none;
+}
+
+#text {
+-webkit-transform: rotate(90deg);
+}
+
+.region {
+position: absolute;
+left: 50px;
+top: 100px;
+border: 3px solid black;
+height: 100px;
+width: 150px;
+}
+/style
+/head
+
+body
+pBug a href="" [CSS Regions] incorrect clipping when the content has CSS Transforms like rotation/p
+pThe text below should overflow the black-border container./p
+
+div class=region
+div id=textidLorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmoddotempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, minimquis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo eaconsequat. eaconsequat/div
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/overflow-content-transform-rotate.html (0 => 166067)

--- trunk/LayoutTests/fast/regions/overflow-content-transform-rotate.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/overflow-content-transform-rotate.html	2014-03-21 16:43:34 UTC (rev 166067)
@@ -0,0 +1,34 @@
+!DOCTYPE HTML
+html lang=en-US
+head
+style
+html {
+-webkit-font-smoothing: none;
+}
+
+#text {
+-webkit-transform: rotate(90deg);
+-webkit-flow-into: flow;
+}
+
+.region {
+position: absolute;
+left: 50px;
+top: 100px;
+border: 3px solid black;
+height: 100px;
+width: 150px;
+-webkit-flow-from: flow;
+}
+/style
+/head
+
+body
+pBug a href="" [CSS Regions] incorrect clipping when the content has CSS Transforms like rotation/p
+pThe text below should overflow the black-border container./p
+
+div class=region/div
+
+div id=textidLorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmoddotempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, minimquis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo eaconsequat. eaconsequat/div
+/body
+/html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [165969] trunk/LayoutTests

[stavila]

Title: [165969] trunk/LayoutTests








Revision 165969
Author stav...@adobe.com
Date 2014-03-20 10:28:53 -0700 (Thu, 20 Mar 2014)


Log Message
[CSS Regions] Remove visibility:hidden from overflow-scrollable* tests
https://bugs.webkit.org/show_bug.cgi?id=130510

Reviewed by Andrei Bucur.

The visibility hidden option was needed to prevent these tests from failing before the
visual overflow was properly implemented (bug 118665). It is now no longer required.

* fast/regions/overflow-scrollable-rel-pos-fragment-expected.html:
* fast/regions/overflow-scrollable-rel-pos-fragment.html:
* fast/regions/overflow-scrollable-rotated-fragment-expected.html:
* fast/regions/overflow-scrollable-rotated-fragment.html:
* fast/regions/overflow-scrollable-unsplittable-fragment-expected.html:
* fast/regions/overflow-scrollable-unsplittable-fragment.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html
trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html
trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html
trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html
trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html
trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html




Diff

Modified: trunk/LayoutTests/ChangeLog (165968 => 165969)

--- trunk/LayoutTests/ChangeLog	2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/ChangeLog	2014-03-20 17:28:53 UTC (rev 165969)
@@ -1,3 +1,20 @@
+2014-03-20  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Remove visibility:hidden from overflow-scrollable* tests
+https://bugs.webkit.org/show_bug.cgi?id=130510
+
+Reviewed by Andrei Bucur.
+
+The visibility hidden option was needed to prevent these tests from failing before the 
+visual overflow was properly implemented (bug 118665). It is now no longer required.
+
+* fast/regions/overflow-scrollable-rel-pos-fragment-expected.html:
+* fast/regions/overflow-scrollable-rel-pos-fragment.html:
+* fast/regions/overflow-scrollable-rotated-fragment-expected.html:
+* fast/regions/overflow-scrollable-rotated-fragment.html:
+* fast/regions/overflow-scrollable-unsplittable-fragment-expected.html:
+* fast/regions/overflow-scrollable-unsplittable-fragment.html:
+
 2014-03-20  Lorenzo Tilve  lti...@igalia.com
 
 input event is not fired when changing a select element's value


Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html (165968 => 165969)

--- trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html	2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html	2014-03-20 17:28:53 UTC (rev 165969)
@@ -23,7 +23,7 @@
 p class=no_overflowLinetext1/p
 p class=no_overflowLinetext2/p
 p class=no_overflowLinetext3/p
-p class=no_overflow style=visibility: hidden;Linetext4/p
+p class=no_overflowLinetext4/p
 /div
 /div
 div class=container


Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html (165968 => 165969)

--- trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html	2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html	2014-03-20 17:28:53 UTC (rev 165969)
@@ -26,7 +26,7 @@
 p class=no_overflowLinetext1/p
 p class=no_overflowLinetext2/p
 p class=no_overflowLinetext3/p
-p class=no_overflow style=-webkit-region-break-after: always; visibility: hidden;Linetext4/p
+p class=no_overflow style=-webkit-region-break-after: always;Linetext4/p
 p class=no_overflowLineText5/p
 p class=no_overflowLinetext6/p
 p class=no_overflowLinetext7/p


Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html (165968 => 165969)

--- trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html	2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html	2014-03-20 17:28:53 UTC (rev 165969)
@@ -23,7 +23,7 @@
 p class=no_overflowLinetext1/p
 p class=no_overflowLinetext2/p
 p class=no_overflowLinetext3/p
-p class=no_overflow style=visibility: hidden;Linetext4/p
+p class=no_overflowLinetext4/p
 /div
 /div
 div class=container


Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html (165968 => 165969)

--- trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html	2014-03-20 17

[webkit-changes] [165377] trunk

[stavila]

Title: [165377] trunk








Revision 165377
Author stav...@adobe.com
Date 2014-03-10 09:29:09 -0700 (Mon, 10 Mar 2014)


Log Message
[CSS Regions] Scrolling regions with the mouse wheel only works properly if hovering over the region's padding
https://bugs.webkit.org/show_bug.cgi?id=129485

Reviewed by Andrei Bucur.

Source/WebCore:

When searching for the region under the mouse pointer (to identify which region to scroll),
the localToAbsolute method must be called on the region container, not the region itself.
Also, when calling the offsetFromContainer method on a named flow fragment,
it must only take into consideration the border and padding of the fragment container,
not its scrolled offset.

Test: fast/regions/wheel-scrollable-single-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scroll):
* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::offsetFromContainer):
* rendering/RenderNamedFlowFragment.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::fragmentFromAbsolutePointAndBox):
* rendering/RenderNamedFlowThread.h:

LayoutTests:

Added layout tests for scrolling regions using the mouse wheel.

* fast/regions/wheel-scrollable-single-region-expected.html: Added.
* fast/regions/wheel-scrollable-single-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h


Added Paths

trunk/LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html
trunk/LayoutTests/fast/regions/wheel-scrollable-single-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (165376 => 165377)

--- trunk/LayoutTests/ChangeLog	2014-03-10 16:28:13 UTC (rev 165376)
+++ trunk/LayoutTests/ChangeLog	2014-03-10 16:29:09 UTC (rev 165377)
@@ -1,3 +1,15 @@
+2014-03-10  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Scrolling regions with the mouse wheel only works properly if hovering over the region's padding
+https://bugs.webkit.org/show_bug.cgi?id=129485
+
+Reviewed by Andrei Bucur.
+
+Added layout tests for scrolling regions using the mouse wheel.
+
+* fast/regions/wheel-scrollable-single-region-expected.html: Added.
+* fast/regions/wheel-scrollable-single-region.html: Added.
+
 2014-03-10  Michał Pakuła vel Rutka  m.pak...@samsung.com
 
 Unreviewed EFL gardening


Added: trunk/LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html (0 => 165377)

--- trunk/LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html	2014-03-10 16:29:09 UTC (rev 165377)
@@ -0,0 +1,55 @@
+!DOCTYPE html
+html style=font: 16px/1.25 monospace;
+head
+script
+_onload_ = function() {
+if (window.eventSender) {
+eventSender.mouseMoveTo(250, 250);
+eventSender.continuousMouseScrollBy(0, -120);
+eventSender.mouseMoveTo(0, 0);
+}
+}
+/script
+
+style
+#container {
+border: 2px solid green;
+height: 300px;
+overflow: visible;
+}
+
+#region {
+width: 600px;
+height: 200px;
+border: thick solid red;
+padding: 50px;
+overflow: scroll;
+}
+
+#innerDiv {
+width: 300px;
+height: 100px;
+background-color: red;
+margin-left: 30px;
+}
+
+#innerDiv:hover
+{
+background-color: green;
+}
+/style
+/head
+
+body _onload_=testScroll()
+a style=font-size: 14px href="" Regions] Scrolling regions with the mouse wheel only works properly if hovering over the region's padding/a
+pThis test passes if the span style=color:redregion/span properly scrolls its content using the mouse wheel./p
+
+div id=region
+div id=container
+divLorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent interdum, sapien vitae faucibus suscipit, massa urna sagittis libero, ac imperdiet elit lacus a ligula. Mauris a orci sem./div
+div id=innerDiv/div
+div style=color:redLorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent interdum, sapien vitae faucibus suscipit, massa urna sag

[webkit-changes] [165388] trunk

[stavila]

Title: [165388] trunk








Revision 165388
Author stav...@adobe.com
Date 2014-03-10 11:48:49 -0700 (Mon, 10 Mar 2014)


Log Message
[CSS Regions] Hit-testing is not working properly inside scrollable regions
https://bugs.webkit.org/show_bug.cgi?id=130015

Reviewed by Antti Koivisto.

Source/WebCore:

When hit-testing inside the flow thread's layer, the scrolled offset
of the current region must be taken into consideration.

Test: fast/regions/scrollable-regions-hit-testing-inside.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

Added test for hit-testing inside scrollable regions.

* fast/regions/scrollable-regions-hit-testing-inside-expected.html: Added.
* fast/regions/scrollable-regions-hit-testing-inside.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html
trunk/LayoutTests/fast/regions/scrollable-regions-hit-testing-inside.html




Diff

Modified: trunk/LayoutTests/ChangeLog (165387 => 165388)

--- trunk/LayoutTests/ChangeLog	2014-03-10 18:41:34 UTC (rev 165387)
+++ trunk/LayoutTests/ChangeLog	2014-03-10 18:48:49 UTC (rev 165388)
@@ -1,3 +1,15 @@
+2014-03-10  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Hit-testing is not working properly inside scrollable regions
+https://bugs.webkit.org/show_bug.cgi?id=130015
+
+Reviewed by Antti Koivisto.
+
+Added test for hit-testing inside scrollable regions.
+
+* fast/regions/scrollable-regions-hit-testing-inside-expected.html: Added.
+* fast/regions/scrollable-regions-hit-testing-inside.html: Added.
+
 2014-03-10  Hans Muller  hmul...@adobe.com
 
 [CSS Shapes] SVG Image valued shape fails if root element's size is relative


Added: trunk/LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html (0 => 165388)

--- trunk/LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html	2014-03-10 18:48:49 UTC (rev 165388)
@@ -0,0 +1,60 @@
+!DOCTYPE html
+html style=font: 16px/1.25 monospace; font-family: Ahem
+head
+script
+_onload_ = function() 
+{
+var region = document.getElementById(region);
+region.scrollTop += 150;
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(140, 160);
+eventSender.mouseDown(0);
+eventSender.leapForward(500);
+eventSender.mouseUp(0);
+}
+}
+/script
+
+style
+#container {
+border: 2px solid green;
+height: 300px;
+overflow: visible;
+}
+
+#region {
+width: 600px;
+height: 200px;
+border: thick solid red;
+padding: 50px;
+overflow: scroll;
+}
+
+#innerDiv {
+width: 100px;
+height: 100px;
+background-color: red;
+margin-left: 30px;
+}
+
+#innerDiv:hover
+{
+background-color: green;
+}
+/style
+/head
+
+body
+a style=font-size: 14px href="" Regions] Hit-testing is not working properly inside scrollable regions/a
+pThis test passes if the red square turns green when hovered, even if the region is scrolled./p
+
+div id=region
+div id=container
+divLorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent interdum, sapien vitae faucibus suscipit, massa urna sagittis libero, ac imperdiet elit lacus a ligula. Mauris a orci sem./div
+div id=innerDiv/div
+div style=color:redLorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent interdum, sapien vitae faucibus suscipit, massa urna sagittis libero, ac imperdiet elit lacus a ligula. Mauris a orci sem. Nullam ullamcorper ornare porttitor. Morbi laoreet pellentesque diam, vitae hendrerit sem fringilla id. Maecenas rutrum lacinia lobortis. Praesent elit lectus, porttitor sed semper vel, fringilla id dolor. Sed lacus nisl, rutrum sit amet euismod a, vulputate quis elit. Fusce commodo dui quis lacus viverra vel egestas velit tempus. Donec ut sapien sit amet purus luctus fermentum. Donec eleifend pretium neque quis bibendum. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Nam congue dapibus mi, id ultricies est sagittis et. Integer posuere, eros vitae laoreet congue, tortor purus euismod nibh, eu porta purus arcu id turpis. Donec vitae ultricies nibh. Nullam in urna dolor, at fringi

[webkit-changes] [164837] trunk/Source/WebCore

[stavila]

Title: [164837] trunk/Source/WebCore








Revision 164837
Author stav...@adobe.com
Date 2014-02-27 15:52:23 -0800 (Thu, 27 Feb 2014)


Log Message
[CSS Regions] Move named-flow specific method decorationsClipRectForBoxInRegion to RenderNamedFlowThread
https://bugs.webkit.org/show_bug.cgi?id=129428

Reviewed by Andreas Kling.

Since the decorationsClipRectForBoxInRegion method is a named flow specific method, it makes
sense to be in the named flow specific class, RenderNamedFlowThread, instead of the more
generic RenderFlowThread.

No new tests required. No new functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
* rendering/RenderNamedFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164836 => 164837)

--- trunk/Source/WebCore/ChangeLog	2014-02-27 23:36:23 UTC (rev 164836)
+++ trunk/Source/WebCore/ChangeLog	2014-02-27 23:52:23 UTC (rev 164837)
@@ -1,3 +1,24 @@
+2014-02-27  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Move named-flow specific method decorationsClipRectForBoxInRegion to RenderNamedFlowThread
+https://bugs.webkit.org/show_bug.cgi?id=129428
+
+Reviewed by Andreas Kling.
+
+Since the decorationsClipRectForBoxInRegion method is a named flow specific method, it makes
+sense to be in the named flow specific class, RenderNamedFlowThread, instead of the more
+generic RenderFlowThread.
+
+No new tests required. No new functionality.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paintObject):
+* rendering/RenderFlowThread.cpp:
+* rendering/RenderFlowThread.h:
+* rendering/RenderNamedFlowThread.cpp:
+(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
+* rendering/RenderNamedFlowThread.h:
+
 2014-02-27  Zoltan Horvath  zol...@webkit.org
 
 Avoid calling logicalLeftOffsetForLine 2 times in LineWidth::fitBelowFloats


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (164836 => 164837)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-02-27 23:36:23 UTC (rev 164836)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-02-27 23:52:23 UTC (rev 164837)
@@ -2301,7 +2301,7 @@
 if (hasBoxDecorations()) {
 bool didClipToRegion = false;
 
-if (paintInfo.paintContainer  paintInfo.renderNamedFlowFragment  paintInfo.paintContainer-isRenderFlowThread()) {
+if (paintInfo.paintContainer  paintInfo.renderNamedFlowFragment  paintInfo.paintContainer-isRenderNamedFlowThread()) {
 // If this box goes beyond the current region, then make sure not to overflow the region.
 // This (overflowing region X altough also fragmented to region X+1) could happen when one of this box's children
 // overflows region X and is an unsplittable element (like an image).
@@ -2310,7 +2310,7 @@
 paintInfo.context-save();
 didClipToRegion = true;
 
-paintInfo.context-clip(toRenderFlowThread(paintInfo.paintContainer)-decorationsClipRectForBoxInRegion(*this, *paintInfo.renderNamedFlowFragment));
+paintInfo.context-clip(toRenderNamedFlowThread(paintInfo.paintContainer)-decorationsClipRectForBoxInNamedFlowFragment(*this, *paintInfo.renderNamedFlowFragment));
 }
 
 paintBoxDecorations(paintInfo, paintOffset);


Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (164836 => 164837)

--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-27 23:36:23 UTC (rev 164836)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-27 23:52:23 UTC (rev 164837)
@@ -1262,76 +1262,6 @@
 return localRect;
 }
 
-LayoutRect RenderFlowThread::decorationsClipRectForBoxInRegion(const RenderBox box, RenderRegion region) const
-{
-LayoutRect visualOverflowRect = region.visualOverflowRectForBox(box);
-LayoutUnit initialLogicalX = style().isHorizontalWritingMode() ? visualOverflowRect.x() : visualOverflowRect.y();
-
-// The visual overflow rect returned by visualOverflowRectForBox is already flipped but the
-// RenderRegion::rectFlowPortionForBox method expects it unflipped.
-flipForWritingModeLocalCoordinates(visualOverflowRect);
-visualOverflowRect = region.rectFlowPortionForBox(box, visualOverflowRect);
-
-// Now flip it again.
-flipForWritingModeLocalCoordinates(visualOverflowRect);
-
-

[webkit-changes] [164641] trunk/LayoutTests

[stavila]

Title: [164641] trunk/LayoutTests








Revision 164641
Author stav...@adobe.com
Date 2014-02-25 02:33:26 -0800 (Tue, 25 Feb 2014)


Log Message
[CSS Regions] scrollIntoView for elements flowed into regions
https://bugs.webkit.org/show_bug.cgi?id=129151

Reviewed by Mihnea Ovidenie.

Added tests for scrollIntoView on elements flowed inside regions.

* fast/regions/scroll-into-view-expected.html: Added.
* fast/regions/scroll-into-view-relative-expected.html: Added.
* fast/regions/scroll-into-view-relative.html: Added.
* fast/regions/scroll-into-view.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/scroll-into-view-expected.html
trunk/LayoutTests/fast/regions/scroll-into-view-relative-expected.html
trunk/LayoutTests/fast/regions/scroll-into-view-relative.html
trunk/LayoutTests/fast/regions/scroll-into-view.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164640 => 164641)

--- trunk/LayoutTests/ChangeLog	2014-02-25 10:16:04 UTC (rev 164640)
+++ trunk/LayoutTests/ChangeLog	2014-02-25 10:33:26 UTC (rev 164641)
@@ -1,3 +1,17 @@
+2014-02-25  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] scrollIntoView for elements flowed into regions
+https://bugs.webkit.org/show_bug.cgi?id=129151
+
+Reviewed by Mihnea Ovidenie.
+
+Added tests for scrollIntoView on elements flowed inside regions.
+
+* fast/regions/scroll-into-view-expected.html: Added.
+* fast/regions/scroll-into-view-relative-expected.html: Added.
+* fast/regions/scroll-into-view-relative.html: Added.
+* fast/regions/scroll-into-view.html: Added.
+
 2014-02-25  Mihai Tica  mit...@adobe.com
 
 [CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.


Added: trunk/LayoutTests/fast/regions/scroll-into-view-expected.html (0 => 164641)

--- trunk/LayoutTests/fast/regions/scroll-into-view-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scroll-into-view-expected.html	2014-02-25 10:33:26 UTC (rev 164641)
@@ -0,0 +1,44 @@
+!DOCTYPE html
+
+script type=text/_javascript_
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function onLoad()
+{
+setTimeout(
+function()
+{
+var content = document.getElementById(content);
+content.scrollIntoView(true);
+
+if (window.testRunner)
+testRunner.notifyDone();
+},
+0);
+}
+/script
+
+style
+#region {
+border: 4px solid brown;
+padding: 5px;
+position: relative;
+top: 800px;
+}
+
+#content {
+border: 2px solid green;
+width: 210px;
+height: 150px;
+padding: 3px;
+}
+/style
+
+body _onload_=onLoad()
+div id=region
+div id=content
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/scroll-into-view-relative-expected.html (0 => 164641)

--- trunk/LayoutTests/fast/regions/scroll-into-view-relative-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/scroll-into-view-relative-expected.html	2014-02-25 10:33:26 UTC (rev 164641)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+
+script type=text/_javascript_
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function onLoad()
+{
+setTimeout(
+function()
+{
+var content = document.getElementById(content);
+content.scrollIntoView(true);
+
+if (window.testRunner)
+testRunner.notifyDone();
+},
+0);
+}
+/script
+
+style
+#region {
+border: 4px solid brown;
+padding: 5px;
+position: relative;
+top: 800px;
+}
+
+#content {
+border: 2px solid green;
+width: 210px;
+height: 150px;
+padding: 3px;
+position: relative;
+top: 200px;
+}
+/style
+
+body _onload_=onLoad()
+div id=region
+div id=content
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/scroll-into-view-relative.html (0 => 164641)

--- trunk/LayoutTests/fast/regions/scroll-into-view-relative.html	(rev 0)
+++ trunk/LayoutTests/

[webkit-changes] [164600] trunk

[stavila]

Title: [164600] trunk








Revision 164600
Author stav...@adobe.com
Date 2014-02-24 12:51:05 -0800 (Mon, 24 Feb 2014)


Log Message
[CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
https://bugs.webkit.org/show_bug.cgi?id=129254

Reviewed by Antti Koivisto.

Source/WebCore:

The painting of the region's layer should not be aborted so early if the region's fragment shouldn't be painted
because that would prevent all the layer's children from being painted.

Another problem this patch addresses is that clipping should also be performed when the clip rect is empty,
which is what happens when painting in a tile in which the flowed element would normally be painted
if it wasn't clipped by the region.

Test: fast/regions/content-relative-next-tile.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):

LayoutTests:

Added test for the painting across tiles of relative positioned elements flowed into regions.

* fast/regions/content-relative-next-tile-expected.html: Added.
* fast/regions/content-relative-next-tile.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/regions/content-relative-next-tile-expected.html
trunk/LayoutTests/fast/regions/content-relative-next-tile.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164599 => 164600)

--- trunk/LayoutTests/ChangeLog	2014-02-24 20:31:04 UTC (rev 164599)
+++ trunk/LayoutTests/ChangeLog	2014-02-24 20:51:05 UTC (rev 164600)
@@ -1,3 +1,15 @@
+2014-02-24  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
+https://bugs.webkit.org/show_bug.cgi?id=129254
+
+Reviewed by Antti Koivisto.
+
+Added test for the painting across tiles of relative positioned elements flowed into regions.
+
+* fast/regions/content-relative-next-tile-expected.html: Added.
+* fast/regions/content-relative-next-tile.html: Added.
+
 2014-02-24  Dirk Schulze  k...@webkit.org
 
 Transform more clip-path pixel tests to reference tests


Added: trunk/LayoutTests/fast/regions/content-relative-next-tile-expected.html (0 => 164600)

--- trunk/LayoutTests/fast/regions/content-relative-next-tile-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/content-relative-next-tile-expected.html	2014-02-24 20:51:05 UTC (rev 164600)
@@ -0,0 +1,45 @@
+!DOCTYPE html
+style
+#region {
+border: 4px solid brown;
+padding: 5px;
+position: relative;
+top: 300px;
+}
+
+#content {
+border: 2px solid green;
+color: green;
+width: 210px;
+height: 150px;
+padding: 3px;
+position: relative;
+top: 100px;
+}
+
+#firstTile {
+margin: 0px;
+position: absolute;
+left: 0px;
+top: 0px;
+width: 512px;
+height: 512px;
+border: 2px solid blue;
+border-top: none;
+border-left: none;
+}
+/style
+
+body
+div id=firstTile/div
+div style=position:absolute
+divThis tests that span style=color:greenrelative-positioned elements/span flowed into span style=color:browna region/span are properly painted across span style=color:bluedifferent tiles/span/div
+a href="" 129254/a
+/div
+
+div id=region
+div id=content
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/content-relative-next-tile.html (0 => 164600)

--- trunk/LayoutTests/fast/regions/content-relative-next-tile.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/content-relative-next-tile.html	2014-02-24 20:51:05 UTC (rev 164600)
@@ -0,0 +1,47 @@
+!DOCTYPE html
+style
+#region {
+-webkit-flow-from: flow;
+border: 4px solid brown;
+padding: 5px;
+position: relative;
+top: 300px;
+}
+
+#content {
+-webkit-flow-into: flow;
+border: 2px solid green;
+color: green;
+width: 210px;
+height: 150px;
+padding: 3px;
+position: relative;
+top: 100px;
+}
+
+#firstTile {
+margin: 0px;
+position: absolute;
+left: 0px;
+top: 0px;
+width: 512px;
+height: 512px;
+border: 2px solid blue;
+border-top: none;
+border-left: none;
+}
+/style
+
+body
+div id=firstTile/div
+div style=position:absolute
+divThis te

[webkit-changes] [164231] trunk

[stavila]

Title: [164231] trunk








Revision 164231
Author stav...@adobe.com
Date 2014-02-17 11:10:42 -0800 (Mon, 17 Feb 2014)


Log Message
[CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=128815

Reviewed by Andrei Bucur.

Source/WebCore:

Elements flowed into a region should not be painted past the region's content box
if they continue to flow into another region in that direction.
If they do not continue into another region in that direction, they should be
painted all the way to the region's border box.
Regions with overflow:hidden will apply clip at the border box, not the content box.

Tests: fast/regions/box-decorations-over-region-padding-fragmented.html
   fast/regions/box-decorations-over-region-padding-horiz-bt.html
   fast/regions/box-decorations-over-region-padding-vert-lr.html
   fast/regions/box-decorations-over-region-padding-vert-rl.html
   fast/regions/box-decorations-over-region-padding.html

* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::flowThreadPortionRectForClipping):
* rendering/RenderNamedFlowFragment.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::rectFlowPortionForBox):

LayoutTests:

Added tests for the painting of the borders of elements flowed into regions
over the region's padding area, for regions with overflow:hidden.
Tests were added for all writing modes.

* fast/regions/box-decorations-over-region-padding-expected.html: Added.
* fast/regions/box-decorations-over-region-padding-fragmented-expected.html: Added.
* fast/regions/box-decorations-over-region-padding-fragmented.html: Added.
* fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html: Added.
* fast/regions/box-decorations-over-region-padding-horiz-bt.html: Added.
* fast/regions/box-decorations-over-region-padding-vert-lr-expected.html: Added.
* fast/regions/box-decorations-over-region-padding-vert-lr.html: Added.
* fast/regions/box-decorations-over-region-padding-vert-rl-expected.html: Added.
* fast/regions/box-decorations-over-region-padding-vert-rl.html: Added.
* fast/regions/box-decorations-over-region-padding.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h
trunk/Source/WebCore/rendering/RenderRegion.cpp


Added Paths

trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-expected.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-fragmented-expected.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-fragmented.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-horiz-bt.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-vert-lr-expected.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-vert-lr.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-vert-rl-expected.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding-vert-rl.html
trunk/LayoutTests/fast/regions/box-decorations-over-region-padding.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164230 => 164231)

--- trunk/LayoutTests/ChangeLog	2014-02-17 19:08:49 UTC (rev 164230)
+++ trunk/LayoutTests/ChangeLog	2014-02-17 19:10:42 UTC (rev 164231)
@@ -1,3 +1,25 @@
+2014-02-17  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box
+https://bugs.webkit.org/show_bug.cgi?id=128815
+
+Reviewed by Andrei Bucur.
+
+Added tests for the painting of the borders of elements flowed into regions
+over the region's padding area, for regions with overflow:hidden.
+Tests were added for all writing modes.
+
+* fast/regions/box-decorations-over-region-padding-expected.html: Added.
+* fast/regions/box-decorations-over-region-padding-fragmented-expected.html: Added.
+* fast/regions/box-decorations-over-region-padding-fragmented.html: Added.
+* fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html: Added.
+* fast/regions/box-decorations-over-region-padding-horiz-bt.html: Added.
+* fast/regions/box-decorations-over-region-padding-vert-lr-expected.html: Added.
+* fast/regions/box-decorations-over-region-padding-vert-lr.html: Added.
+* fast/regions/box-decorations-over-region-padding-vert-rl-expected.html: Added.
+* fast/regions/box-decorations-over-region-padding-vert-rl.html: Added.
+* fast/regions/box-decorations-over-region-padding.html: Added.
+
 2014-02-17  Brendan Long  b.l...@cablelabs.com
 
 DataCue.data should be a copy of the in

[webkit-changes] [164234] trunk

[stavila]

Title: [164234] trunk








Revision 164234
Author stav...@adobe.com
Date 2014-02-17 11:22:14 -0800 (Mon, 17 Feb 2014)


Log Message
[CSS Regions] Make regions unsplittable
https://bugs.webkit.org/show_bug.cgi?id=128811

Reviewed by David Hyatt.

Source/WebCore:

At the moment, nested regions are not properly fragmented across regions. For the moment,
the regions will become unsplittable elements to avoid slicing. At a later time a proper
fragmentation algorithm should be written, also taking into consideration pagination strut.

Test: fast/regions/unsplittable-nested-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):

LayoutTests:

Added test for checking that nested regions are unsplittable.

* fast/regions/unsplittable-nested-region-expected.html: Added.
* fast/regions/unsplittable-nested-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html
trunk/LayoutTests/fast/regions/unsplittable-nested-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164233 => 164234)

--- trunk/LayoutTests/ChangeLog	2014-02-17 19:15:26 UTC (rev 164233)
+++ trunk/LayoutTests/ChangeLog	2014-02-17 19:22:14 UTC (rev 164234)
@@ -1,3 +1,15 @@
+2014-02-17  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Make regions unsplittable
+https://bugs.webkit.org/show_bug.cgi?id=128811
+
+Reviewed by David Hyatt.
+
+Added test for checking that nested regions are unsplittable.
+
+* fast/regions/unsplittable-nested-region-expected.html: Added.
+* fast/regions/unsplittable-nested-region.html: Added.
+
 2014-02-17  Simon Fraser  simon.fra...@apple.com
 
 Graphics buffer issue with clip-path and fixed positioned element


Added: trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html (0 => 164234)

--- trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html	2014-02-17 19:22:14 UTC (rev 164234)
@@ -0,0 +1,55 @@
+!doctype html
+html
+	head
+		style
+			#outerContent {
+-webkit-flow-into: outerFlow;
+color: blue;
+			}
+			.outerRegion {
+-webkit-flow-from: outerFlow;
+width: 300px;
+height: 180px;
+border: solid 2px Gray;
+margin: 5px;
+border: 2px solid blue;
+padding: 30px;
+			}
+			#innerContent {
+-webkit-flow-into: innerFlow;
+color: red;
+			}
+
+			#innerRegion {
+-webkit-flow-from: innerFlow;
+border: solid 2px red;
+overflow: hidden;
+color: blue;
+			}
+			#outerRegion1
+			{
+float: left;
+			}
+			#outerRegion2
+			{
+float: right;
+			}
+		/style
+	/head
+	body
+		a href="" 128811/abr/
+		pThe span style=color:rednested region/span should bnot/b be split between the span style=color:blue2 outer regions/span and should overflow the first region/p
+
+		div class=outerRegion id=outerRegion1
+			div id=outerContent
+div id=innerRegion
+	div id=innerContent
+		Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.
+	/div
+/div
+			/div
+		/div
+
+		div class=outerRegion id=outerRegion2/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/unsplittable-nested-region.html (0 => 164234)

--- trunk/LayoutTests/fast/regions/unsplittable-nested-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/unsplittable-nested-region.html	2014-02-17 19:22:14 UTC (rev 164234)
@@ -0,0 +1,54 @@
+!doctype html
+html
+	head
+		style
+			#outerContent {
+-webkit-flow-into: outerFlow;
+color: blue;
+			}
+			.outerRegion {
+-webkit-flow-from: outerFlow;
+width: 300px;
+height: 180px;
+border: solid 2px Gray;
+margin: 5px;
+border: 2px solid blue;
+padding: 30px;
+			}
+			#innerContent {
+-webkit-flow-into: innerFlow;
+color: red;
+			}
+
+			#innerRegion {
+-webkit-flow-from: innerFlow;
+border: solid 2px red;
+overflow: hidden;
+color: blue;
+			}
+			#outerRegion1
+			{
+float: left;
+			}
+			#outerRegion2
+			{
+float: right;
+			}
+		/style
+	/head
+	body
+		a href="" 128811/abr/
+		pThe span style=color:rednested region/span should bnot/b be split between the span style=color:blue2 outer reg

[webkit-changes] [164275] trunk/Source/WebCore

[stavila]

Title: [164275] trunk/Source/WebCore








Revision 164275
Author stav...@adobe.com
Date 2014-02-17 23:53:51 -0800 (Mon, 17 Feb 2014)


Log Message
[CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=128914

Reviewed by Antti Koivisto.

Moved named flow specific methods regionContainer() and regionContainerLayer() from
RenderRegion to RenderNamedFlowFragment and renamed them to fragmentContainer and
fragmentContainerLayer.

No new tests required.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::fragmentContainer):
(WebCore::RenderNamedFlowFragment::fragmentContainerLayer):
* rendering/RenderNamedFlowFragment.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderRegion.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164274 => 164275)

--- trunk/Source/WebCore/ChangeLog	2014-02-18 07:17:24 UTC (rev 164274)
+++ trunk/Source/WebCore/ChangeLog	2014-02-18 07:53:51 UTC (rev 164275)
@@ -1,3 +1,26 @@
+2014-02-17  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment
+https://bugs.webkit.org/show_bug.cgi?id=128914
+
+Reviewed by Antti Koivisto.
+
+Moved named flow specific methods regionContainer() and regionContainerLayer() from 
+RenderRegion to RenderNamedFlowFragment and renamed them to fragmentContainer and
+fragmentContainerLayer.
+
+No new tests required.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
+(WebCore::RenderLayer::calculateClipRects):
+* rendering/RenderNamedFlowFragment.cpp:
+(WebCore::RenderNamedFlowFragment::fragmentContainer):
+(WebCore::RenderNamedFlowFragment::fragmentContainerLayer):
+* rendering/RenderNamedFlowFragment.h:
+* rendering/RenderRegion.cpp:
+* rendering/RenderRegion.h:
+
 2014-02-17  Sangho Kim  thomas@lge.com
 
 Move PublicURLMansger to std::unique_ptr.


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (164274 => 164275)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2014-02-18 07:17:24 UTC (rev 164274)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2014-02-18 07:53:51 UTC (rev 164275)
@@ -5252,15 +5252,17 @@
 
 void RenderLayer::mapLayerClipRectsToFragmentationLayer(RenderRegion* region, ClipRects clipRects) const
 {
-ASSERT(region  region-parent()  region-parent()-isRenderNamedFlowFragmentContainer());
+ASSERT(region  region-isRenderNamedFlowFragment()  region-parent()  region-parent()-isRenderNamedFlowFragmentContainer());
+
+RenderNamedFlowFragment* flowFragment = toRenderNamedFlowFragment(region);
 
-ClipRectsContext targetClipRectsContext(region-regionContainerLayer(), 0, TemporaryClipRects);
-region-regionContainerLayer()-calculateClipRects(targetClipRectsContext, clipRects);
+ClipRectsContext targetClipRectsContext(flowFragment-fragmentContainerLayer(), 0, TemporaryClipRects);
+flowFragment-fragmentContainerLayer().calculateClipRects(targetClipRectsContext, clipRects);
 
 LayoutRect flowThreadPortionRect = region-flowThreadPortionRect();
 
 LayoutPoint portionLocation = flowThreadPortionRect.location();
-LayoutRect regionContentBox = region-regionContainer()-contentBoxRect();
+LayoutRect regionContentBox = flowFragment-fragmentContainer().contentBoxRect();
 LayoutSize moveOffset = portionLocation - regionContentBox.location();
 
 ClipRect newOverflowClipRect = clipRects.overflowClipRect();
@@ -5456,8 +5458,10 @@
 outlineRect = backgroundRect;
 
 // If the region does not clip its overflow, inflate the outline rect.
-if (!(clipRectsContext.region-parent()-hasOverflowClip()  (clipRectsContext.region-regionContainerLayer() != clipRectsContext.rootLayer || clipRectsContext.respectOverflowClip == RespectOverflowClip)))
-outlineRect.inflate(renderer().maximalOutlineSize(PaintPhaseOutline));
+if (clipRectsContext.region-isRenderNamedFlowFragment()) {
+if (!(clipRectsContext.region-parent()-hasOverflowClip()  (toRenderNamedFlowFragment(clipRectsContext.region)-fragmentContainerLayer() != clipRectsContext.rootLayer || clipRectsContext.respectOverflowClip == RespectOverflowClip)))
+outlineRect.inflate(renderer().maximalOutlineSize(PaintPhaseOutline));
+}
 }
 
 // Update the clip rects that will be 

[webkit-changes] [163957] trunk/Source/WebCore

[stavila]

Title: [163957] trunk/Source/WebCore








Revision 163957
Author stav...@adobe.com
Date 2014-02-12 05:31:22 -0800 (Wed, 12 Feb 2014)


Log Message
[CSS Regions] Remove unused method in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=128373

Reviewed by Mihnea Ovidenie.

After the landing of https://bugs.webkit.org/show_bug.cgi?id=118665, the
RenderFlowThread::computeRegionClippingRect method is obsolete.

No new tests needed, this patch only removes an unused method.

* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163956 => 163957)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 13:31:22 UTC (rev 163957)
@@ -1,3 +1,18 @@
+2014-02-12  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Remove unused method in RenderFlowThread
+https://bugs.webkit.org/show_bug.cgi?id=128373
+
+Reviewed by Mihnea Ovidenie.
+
+After the landing of https://bugs.webkit.org/show_bug.cgi?id=118665, the 
+RenderFlowThread::computeRegionClippingRect method is obsolete.
+
+No new tests needed, this patch only removes an unused method.
+
+* rendering/RenderFlowThread.cpp:
+* rendering/RenderFlowThread.h:
+
 2014-02-12  Mihai Tica  mit...@adobe.com
 
 [CSS Element Blending] Implement the software path of -webkit-blend-mode with Core Graphics.


Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (163956 => 163957)

--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp	2014-02-12 13:31:22 UTC (rev 163957)
@@ -390,14 +390,6 @@
 }
 }
 
-LayoutRect RenderFlowThread::computeRegionClippingRect(const LayoutPoint offset, const LayoutRect flowThreadPortionRect, const LayoutRect flowThreadPortionOverflowRect) const
-{
-LayoutRect regionClippingRect(offset + (flowThreadPortionOverflowRect.location() - flowThreadPortionRect.location()), flowThreadPortionOverflowRect.size());
-if (style().isFlippedBlocksWritingMode())
-regionClippingRect.move(flowThreadPortionRect.size() - flowThreadPortionOverflowRect.size());
-return regionClippingRect;
-}
-
 bool RenderFlowThread::nodeAtPoint(const HitTestRequest request, HitTestResult result, const HitTestLocation locationInContainer, const LayoutPoint accumulatedOffset, HitTestAction hitTestAction)
 {
 if (hitTestAction == HitTestBlockBackground)


Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (163956 => 163957)

--- trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 13:21:10 UTC (rev 163956)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 13:31:22 UTC (rev 163957)
@@ -231,8 +231,6 @@
 void updateRegionsFlowThreadPortionRect(const RenderRegion* = 0);
 bool shouldRepaint(const LayoutRect) const;
 
-LayoutRect computeRegionClippingRect(const LayoutPoint, const LayoutRect, const LayoutRect) const;
-
 bool updateAllLayerToRegionMappings();
 
 // Triggers a layers' update if a layer has moved from a region to another since the last update.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163985] trunk/LayoutTests

[stavila]

Title: [163985] trunk/LayoutTests








Revision 163985
Author stav...@adobe.com
Date 2014-02-12 14:16:56 -0800 (Wed, 12 Feb 2014)


Log Message
[CSS Regions] Fix layout of floated nested region
https://bugs.webkit.org/show_bug.cgi?id=128367

Reviewed by Mihnea Ovidenie.

Added test for the correct layout of nested, floating regions.

* fast/regions/nested-floated-region-expected.html: Added.
* fast/regions/nested-floated-region.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/nested-floated-region-expected.html
trunk/LayoutTests/fast/regions/nested-floated-region.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163984 => 163985)

--- trunk/LayoutTests/ChangeLog	2014-02-12 22:07:04 UTC (rev 163984)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 22:16:56 UTC (rev 163985)
@@ -1,3 +1,15 @@
+2014-02-12  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Fix layout of floated nested region
+https://bugs.webkit.org/show_bug.cgi?id=128367
+
+Reviewed by Mihnea Ovidenie.
+
+Added test for the correct layout of nested, floating regions.
+
+* fast/regions/nested-floated-region-expected.html: Added.
+* fast/regions/nested-floated-region.html: Added.
+
 2014-02-12  Brady Eidson  beid...@apple.com
 
 Cleanup mac/mac-wk1/mac-wk2 TestExpectations a little bit


Added: trunk/LayoutTests/fast/regions/nested-floated-region-expected.html (0 => 163985)

--- trunk/LayoutTests/fast/regions/nested-floated-region-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/nested-floated-region-expected.html	2014-02-12 22:16:56 UTC (rev 163985)
@@ -0,0 +1,43 @@
+html
+head
+style
+* {
+border: solid 1px #888;
+padding: 2px;
+margin: 3px;
+}
+.no_decorations {
+border: none;
+padding: 0px;
+margin: 0px;
+}
+.outerRegion {
+border: 1px solid red;
+overflow: auto;
+}
+.nestedRegion {
+border: 1px solid blue;
+display: inline-block;
+float: right;
+width: 210px;
+height: 110px;
+background-color: #eee;
+}
+.width600px {
+width: 600px;
+}
+/style
+/head
+body
+pbThe text inside the large span class=no_decorations style=color:redregion/span should properly flow around the span class=no_decorations style=color:bluefloated, nested region/span./b/pbr/
+div class=width600px outerRegion
+div class=outerContent
+Lorem ipsum dolor sit amet, consectetur adipisicing elit. Mollitia, cupiditate, porro, dignissimos fuga impedit corrupti suscipit tempora earum odit asperiores quia nam soluta repellat perspiciatis iste et voluptatem molestiae magni a voluptas maxime officiis iusto dolor ut dicta. 
+div class=nestedRegion
+div class=nestedContentThis text is flowed into a nested region/div
+/div 
+Et, ad sit praesentium recusandae omnis reiciendis ipsa eveniet accusantium vero reprehenderit enim minus perferendis sapiente maxime fugiat iure soluta minima suscipit.
+/div
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/nested-floated-region.html (0 => 163985)

--- trunk/LayoutTests/fast/regions/nested-floated-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/nested-floated-region.html	2014-02-12 22:16:56 UTC (rev 163985)
@@ -0,0 +1,49 @@
+html
+head
+style
+* {
+border: solid 1px #888;
+padding: 2px;
+margin: 3px;
+}
+.no_decorations {
+border: none;
+padding: 0px;
+margin: 0px;
+}
+.nestedContent {
+-webkit-flow-into: nestedFlow;
+}
+.outerContent {
+-webkit-flow-into: outerFlow;
+}
+.outerRegion {
+-webkit-flow-from: outerFlow;
+border: 1px solid red;
+}
+.nestedRegion {
+-webkit-flow-from: nestedFlow;
+border: 1px solid blue;
+display: inline-block;
+float: right;
+width: 210px;
+height: 110px;
+background-color: #eee;
+}
+.width600px {
+width: 600px;
+}
+/style
+/head
+body
+pbThe text inside the large span class=no_decorations style=color:redregion/span should properly flow around the span class=no_decorations style=color:bluefloated, nested region/span./b/pbr/
+  

[webkit-changes] [163873] trunk

[stavila]

Title: [163873] trunk








Revision 163873
Author stav...@adobe.com
Date 2014-02-11 08:12:08 -0800 (Tue, 11 Feb 2014)


Log Message
[CSS Regions] Overflow above the first region is not properly painted for regions with padding
https://bugs.webkit.org/show_bug.cgi?id=128590

Reviewed by Andrei Bucur.

Source/WebCore:

Painting is done using the layer of the region's container, so offsetting using the content box
of the region itself is incorrect.

Test: fast/regions/region-padding-overflow-hidden.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionContainer):
(WebCore::RenderRegion::regionContainerLayer):
* rendering/RenderRegion.h:

LayoutTests:

Added test for the correct painting of overflow above the first region
when the region has padding.

* fast/regions/region-padding-overflow-hidden-expected.html: Added.
* fast/regions/region-padding-overflow-hidden.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderRegion.h


Added Paths

trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html
trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163872 => 163873)

--- trunk/LayoutTests/ChangeLog	2014-02-11 10:21:12 UTC (rev 163872)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 16:12:08 UTC (rev 163873)
@@ -1,3 +1,16 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Overflow above the first region is not properly painted for regions with padding
+https://bugs.webkit.org/show_bug.cgi?id=128590
+
+Reviewed by Andrei Bucur.
+
+Added test for the correct painting of overflow above the first region
+when the region has padding.
+
+* fast/regions/region-padding-overflow-hidden-expected.html: Added.
+* fast/regions/region-padding-overflow-hidden.html: Added.
+
 2014-02-11  Piotr Grad  p.g...@samsung.com
 
 [GStreamer] High playback rate causes crash


Added: trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html (0 => 163873)

--- trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html	2014-02-11 16:12:08 UTC (rev 163873)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+
+style
+#region {
+border: 5px solid blue;
+width: 200px;
+height: 100px;
+padding: 80px;
+margin: 50px;
+overflow: hidden;
+}
+
+#content {
+background-color: lightgrey;
+width: 200px;
+height: 100px;
+}
+/style
+
+body
+a href="" Regions] Overflow above the first region is not properly painted for regions with padding/a
+
+div id=region
+div id=content
+div style=position:relative; top: -40px; color:redThis line should be visible/div
+divThe red line above this one should be visible/div
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html (0 => 163873)

--- trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html	2014-02-11 16:12:08 UTC (rev 163873)
@@ -0,0 +1,31 @@
+!DOCTYPE html
+
+style
+#region {
+-webkit-flow-from: flow;
+border: 5px solid blue;
+width: 200px;
+height: 100px;
+padding: 80px;
+margin: 50px;
+overflow: hidden;
+}
+
+#content {
+-webkit-flow-into: flow;
+background-color: lightgrey;
+width: 200px;
+height: 100px;
+}
+/style
+
+body
+a href="" Regions] Overflow above the first region is not properly painted for regions with padding/a
+
+div id=region/div
+
+div id=content
+div style=position:relative; top: -40px; color:redThis line should be visible/div
+divThe red line above this one should be visible/div
+/div
+/body
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (163872 => 163873)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 10:21:12 UTC (rev 163872)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 16:12:08 UTC (rev 163873)
@@ -1,3 +1,22 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Overflow above the first region is not properly painted for regions with padding
+https://bugs.webkit.org/show_bug.cgi?id=128590
+
+Reviewed by Andrei Bucur.
+
+Painting is done using the layer of the region's container, so offsetting using the content box
+of the region itself is incorrect. 
+
+Test: fast/regions/reg

[webkit-changes] [163880] trunk/LayoutTests

[stavila]

Title: [163880] trunk/LayoutTests








Revision 163880
Author stav...@adobe.com
Date 2014-02-11 09:33:41 -0800 (Tue, 11 Feb 2014)


Log Message
[CSS Regions] clipping rectangle for overflow: hidden should be based on the padding box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=119546

Reviewed by Anders Carlsson.

Added tests for the correct painting of region overflow over the region's padding.
This problem was solved by https://bugs.webkit.org/show_bug.cgi?id=118665 and
https://bugs.webkit.org/show_bug.cgi?id=128590.
Two writing modes (horiz-bt and vert-rl) are still not working properly and a separate
issue has been created for them (https://bugs.webkit.org/show_bug.cgi?id=128600).

* fast/regions/clip-to-padding-box-expected.html: Added.
* fast/regions/clip-to-padding-box-margins-expected.html: Added.
* fast/regions/clip-to-padding-box-margins.html: Added.
* fast/regions/clip-to-padding-box-vertical-lr-expected.html: Added.
* fast/regions/clip-to-padding-box-vertical-lr.html: Added.
* fast/regions/clip-to-padding-box.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-margins.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-vertical-lr-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-vertical-lr.html
trunk/LayoutTests/fast/regions/clip-to-padding-box.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163879 => 163880)

--- trunk/LayoutTests/ChangeLog	2014-02-11 16:57:09 UTC (rev 163879)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 17:33:41 UTC (rev 163880)
@@ -1,3 +1,23 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] clipping rectangle for overflow: hidden should be based on the padding box, not the content box
+https://bugs.webkit.org/show_bug.cgi?id=119546
+
+Reviewed by Anders Carlsson.
+
+Added tests for the correct painting of region overflow over the region's padding.
+This problem was solved by https://bugs.webkit.org/show_bug.cgi?id=118665 and
+https://bugs.webkit.org/show_bug.cgi?id=128590.
+Two writing modes (horiz-bt and vert-rl) are still not working properly and a separate
+issue has been created for them (https://bugs.webkit.org/show_bug.cgi?id=128600).
+
+* fast/regions/clip-to-padding-box-expected.html: Added.
+* fast/regions/clip-to-padding-box-margins-expected.html: Added.
+* fast/regions/clip-to-padding-box-margins.html: Added.
+* fast/regions/clip-to-padding-box-vertical-lr-expected.html: Added.
+* fast/regions/clip-to-padding-box-vertical-lr.html: Added.
+* fast/regions/clip-to-padding-box.html: Added.
+
 2014-02-10  Filip Pizlo  fpi...@apple.com
 
 LICM should gracefully handle unprofiled code


Added: trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html (0 => 163880)

--- trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html	2014-02-11 17:33:41 UTC (rev 163880)
@@ -0,0 +1,55 @@
+!doctype html
+html
+	head
+		titleHidden overflow and regions - Expected - https://webkit.org/b/119546/title
+		style
+			* {
+font: normal 20px Times;
+			}
+			.content {
+margin-top: 2px;
+			}
+			.region {
+width: 60px;
+padding: 10px 20px 30px 40px;
+border: double 10px Gray;
+overflow-x: hidden;
+overflow-y: hidden;
+background-color: #eee;
+			}
+			.innerDivToShowPadding {
+border-width: 0px; padding: 0px; margin: 0px;
+background-color: DarkGray;
+			}
+		/style
+	/head
+	body
+		some text
+		div class=region style=height: 60px
+			div class=content innerDivToShowPadding style=margin-top: 2px;
+span style=position:relative;top:-20px;A/spanbr/ !-- this is too wide, it will be clipped --
+Bbr/
+			/div
+		/div
+
+		some text
+
+		div class=region style=height: 70px
+			div class=content innerDivToShowPadding
+CCC 
+span style=position:relative;left:30px;left:30px/span  !-- it will be clipped to the right --
+span style=position:relative;left:-50px;C/span  !-- it will be clipped to the left --
+			/div
+		/div
+
+		some text
+
+		div class=region style=height: auto
+			div class=content innerDivToShowPadding
+DDD 
+DD  !-- this is too wide, it will be clipped --
+span style=position:relative;top:40px;left:-50px;D/span  !-- it will be clipped down and to the left --
+			/div
+		/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html (0 => 163880)

--- trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/clip-to-pa

[webkit-changes] [163531] trunk

[stavila]

Title: [163531] trunk








Revision 163531
Author stav...@adobe.com
Date 2014-02-06 06:42:02 -0800 (Thu, 06 Feb 2014)


Log Message
[CSS Regions] Null dereference applying animation with CSS regions
https://bugs.webkit.org/show_bug.cgi?id=128218

Reviewed by Andrei Bucur.

Source/WebCore:

The first issue (the null dereference) was caused by the checkForZoomChange method
not guarding against a null parentStyle parameter, as the checkForGenericFamilyChange
method does, which in the crashing scenario is called just before the faulty
checkForZoomChange method.
The second issue was an assert which was caused by the fact that detaching is performed
in a certain situation if the element has a renderer or if it's inside a named flow.
However, when reattaching and asserting the element has no renderer, the
inside named flow condition was no longer considered.

Test: fast/regions/animation-element-in-region-flowed-to-other-thread.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::checkForZoomChange):
* style/StyleResolveTree.cpp:
(WebCore::Style::attachChildren):

LayoutTests:

Added test for crash caused by using animations with DOM children of regions flowed
into another flow thread.

* fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html: Added.
* fast/regions/animation-element-in-region-flowed-to-other-thread.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/style/StyleResolveTree.cpp


Added Paths

trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html
trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163530 => 163531)

--- trunk/LayoutTests/ChangeLog	2014-02-06 13:41:46 UTC (rev 163530)
+++ trunk/LayoutTests/ChangeLog	2014-02-06 14:42:02 UTC (rev 163531)
@@ -1,3 +1,16 @@
+2014-02-06  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Null dereference applying animation with CSS regions
+https://bugs.webkit.org/show_bug.cgi?id=128218
+
+Reviewed by Andrei Bucur.
+
+Added test for crash caused by using animations with DOM children of regions flowed
+into another flow thread.
+
+* fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html: Added.
+* fast/regions/animation-element-in-region-flowed-to-other-thread.html: Added.
+
 2014-02-06  Grzegorz Czajkowski  g.czajkow...@samsung.com
 
 Verify copy/paste of misspellings asynchronously


Added: trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html (0 => 163531)

--- trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html	2014-02-06 14:42:02 UTC (rev 163531)
@@ -0,0 +1,2 @@
+pThis test passes if it doesn't crash or assert/p
+a href="" 128218 - [CSS Regions] Null dereference applying animation with CSS regions/a


Added: trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread.html (0 => 163531)

--- trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/animation-element-in-region-flowed-to-other-thread.html	2014-02-06 14:42:02 UTC (rev 163531)
@@ -0,0 +1,19 @@
+style
+div {
+-webkit-animation-name: n;
+-webkit-animation-duration: 1s;
+}
+
+@-webkit-keyframes n {
+to { font-weight: bold; }
+}
+/style
+
+pThis test passes if it doesn't crash or assert/p
+a href="" 128218 - [CSS Regions] Null dereference applying animation with CSS regions/a
+div id=div1 style=-webkit-flow-from: a;
+div id=div2
+div id=div3 style=-webkit-flow-into: b;test/div
+/div
+/div
+


Modified: trunk/Source/WebCore/ChangeLog (163530 => 163531)

--- trunk/Source/WebCore/ChangeLog	2014-02-06 13:41:46 UTC (rev 163530)
+++ trunk/Source/WebCore/ChangeLog	2014-02-06 14:42:02 UTC (rev 163531)
@@ -1,3 +1,26 @@
+2014-02-06  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Null dereference applying animation with CSS regions
+https://bugs.webkit.org/show_bug.cgi?id=128218
+
+Reviewed by Andrei Bucur.
+
+The first issue (the null dereference) was caused by the checkForZoomChange method
+not guarding against a null parentStyle parameter, as the checkForGenericFamilyChange 
+method does, which in the crashing scenario is called just before the faulty
+checkForZoomChange method.
+The second issue was an assert which was caused by the fact that detaching is performed
+in a certain situation if the element has a renderer or if it's inside a named flow.
+However, when reatt

[webkit-changes] [163382] trunk

[stavila]

Title: [163382] trunk








Revision 163382
Author stav...@adobe.com
Date 2014-02-04 09:27:52 -0800 (Tue, 04 Feb 2014)


Log Message
REGRESSION (r159609): Images are corrupted when hovering over buttons @ github.com
https://bugs.webkit.org/show_bug.cgi?id=127729

Reviewed by Antti Koivisto.

Source/WebCore:

When clipping a rect, the RenderLayer would not properly save the context when
the clipping rect is the same as the paint rect and the clipping rect
has radius.

Test: fast/regions/repaint/hover-border-radius.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):

LayoutTests:

Added test for the correct repainting of buttons with border radius when hovering.

* fast/regions/repaint/hover-border-radius-expected.txt: Added.
* fast/regions/repaint/hover-border-radius.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/regions/repaint/hover-border-radius-expected.txt
trunk/LayoutTests/fast/regions/repaint/hover-border-radius.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163381 => 163382)

--- trunk/LayoutTests/ChangeLog	2014-02-04 16:48:13 UTC (rev 163381)
+++ trunk/LayoutTests/ChangeLog	2014-02-04 17:27:52 UTC (rev 163382)
@@ -1,3 +1,15 @@
+2014-02-04  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r159609): Images are corrupted when hovering over buttons @ github.com
+https://bugs.webkit.org/show_bug.cgi?id=127729
+
+Reviewed by Antti Koivisto.
+
+Added test for the correct repainting of buttons with border radius when hovering.
+
+* fast/regions/repaint/hover-border-radius-expected.txt: Added.
+* fast/regions/repaint/hover-border-radius.html: Added.
+
 2014-02-04  Andrzej Badowski  a.badow...@samsung.com
 
 [EFL] Add expectations for two flaky media layout tests


Added: trunk/LayoutTests/fast/regions/repaint/hover-border-radius-expected.txt (0 => 163382)

--- trunk/LayoutTests/fast/regions/repaint/hover-border-radius-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/hover-border-radius-expected.txt	2014-02-04 17:27:52 UTC (rev 163382)
@@ -0,0 +1,17 @@
+This test passes if moving the cursor from one of the blue items to the other produces no repaint errors (such as cropping of one of the blue items).
+
+(repaint rects
+  (rect 49 84 350 215)
+  (rect 49 84 350 215)
+  (rect 49 84 350 215)
+  (rect 49 84 350 18)
+  (rect 49 84 350 215)
+  (rect 49 84 350 215)
+  (rect 49 84 350 215)
+  (rect 400 84 350 215)
+  (rect 400 84 350 215)
+  (rect 400 84 350 215)
+  (rect 49 84 350 18)
+  (rect 400 84 350 18)
+)
+


Added: trunk/LayoutTests/fast/regions/repaint/hover-border-radius.html (0 => 163382)

--- trunk/LayoutTests/fast/regions/repaint/hover-border-radius.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/hover-border-radius.html	2014-02-04 17:27:52 UTC (rev 163382)
@@ -0,0 +1,64 @@
+!DOCTYPE html
+html
+  head
+script src=""
+
+style
+  .page_body
+  {
+border-bottom-left-radius: 5px;
+overflow-x: hidden;
+overflow-y: hidden;
+  }
+
+  li
+  {
+background-color: lightblue;
+margin-left: 1px;
+border-top-left-radius: 5px;
+float: left;
+height: 215px;
+overflow-x: hidden;
+overflow-y: hidden;
+position: relative;
+width: 350px;
+  }
+
+  li:hover
+  {
+background-color: red;
+  }
+/style
+
+script type=text/_javascript_
+  function repaintTest() {
+if(!window.testRunner)
+  return;
+
+var first = document.getElementById(first);
+var second = document.getElementById(second);
+
+// hover the 1st item
+var left = first.offsetLeft;
+var top = first.offsetTop;
+eventSender.mouseMoveTo(left + 20, top + 20);
+
+// now hover the 2nd item
+left = second.offsetLeft;
+top = second.offsetTop;
+eventSender.mouseMoveTo(left + 20, top + 20);
+  }
+/script
+
+  /head
+
+  body _onload_=runRepaintTest();
+pThis test passes if moving the cursor from one of the blue items to the other produces no repaint errors (such as cropping of one of the blue items).
+div class=page_body
+  ul
+li id=first/li
+li id=second/li
+  /ul
+/div
+  /body
+/html


Modified: trunk/Source/WebCore/ChangeLog (163381 => 163382)

--- trunk/Source/WebCore/ChangeLog	2014-02-04 16:48:13 UTC (rev 163381)
+++ trunk/Source/WebCore/ChangeLog	2014-02-04 17:27:52 UTC (rev 163382)
@@ -1,3 +1,20 @@
+2014-02-04  Radu Stavila  stav...@adobe.com
+
+REGRESSION (r159609): Images are corrupted when hovering over buttons @ github.com
+https://bugs.webkit.org/show_bug.cgi?id=127729
+
+Reviewed by Antti Koivisto.
+
+  

[webkit-changes] [163018] trunk

[stavila]

Title: [163018] trunk








Revision 163018
Author stav...@adobe.com
Date 2014-01-29 07:20:56 -0800 (Wed, 29 Jan 2014)


Log Message
[CSSRegions] Unable to scroll a scrollable container for regions using mouse wheel
https://bugs.webkit.org/show_bug.cgi?id=123886

Source/WebCore:

When an element flowed into a scrollable region is scrolled using the mouse wheel, the event
needs to be propagated to the region containing that element, on top of which the cursor
is located.

Reviewed by Antti Koivisto.

Tests: fast/regions/wheel-scroll-abspos.html
   fast/regions/wheel-scroll.html

* page/EventHandler.cpp:
(WebCore::scrollNode):
(WebCore::EventHandler::defaultWheelEventHandler):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scroll):
(WebCore::RenderBox::scrollWithWheelEventLocation):
* rendering/RenderBox.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionFromAbsolutePointAndBox):
* rendering/RenderFlowThread.h:

LayoutTests:

Added tests for scrolling elements flowed into scrollable regions.

Reviewed by Antti Koivisto.

* fast/regions/wheel-scroll-abspos-expected.html: Added.
* fast/regions/wheel-scroll-abspos.html: Added.
* fast/regions/wheel-scroll-expected.html: Added.
* fast/regions/wheel-scroll.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h


Added Paths

trunk/LayoutTests/fast/regions/wheel-scroll-abspos-expected.html
trunk/LayoutTests/fast/regions/wheel-scroll-abspos.html
trunk/LayoutTests/fast/regions/wheel-scroll-expected.html
trunk/LayoutTests/fast/regions/wheel-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163017 => 163018)

--- trunk/LayoutTests/ChangeLog	2014-01-29 14:52:22 UTC (rev 163017)
+++ trunk/LayoutTests/ChangeLog	2014-01-29 15:20:56 UTC (rev 163018)
@@ -1,3 +1,17 @@
+2014-01-29  Radu Stavila  stav...@adobe.com
+
+[CSSRegions] Unable to scroll a scrollable container for regions using mouse wheel
+https://bugs.webkit.org/show_bug.cgi?id=123886
+
+Added tests for scrolling elements flowed into scrollable regions.
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/wheel-scroll-abspos-expected.html: Added.
+* fast/regions/wheel-scroll-abspos.html: Added.
+* fast/regions/wheel-scroll-expected.html: Added.
+* fast/regions/wheel-scroll.html: Added.
+
 2014-01-29  Krzysztof Czech  k.cz...@samsung.com
 
 [EFL][WK2] REGRESSION (r162586-r162589): accessibility/range-alter-by-percent.html failing


Added: trunk/LayoutTests/fast/regions/wheel-scroll-abspos-expected.html (0 => 163018)

--- trunk/LayoutTests/fast/regions/wheel-scroll-abspos-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/wheel-scroll-abspos-expected.html	2014-01-29 15:20:56 UTC (rev 163018)
@@ -0,0 +1,84 @@
+!DOCTYPE html
+
+style
+body { font: 16px/16px monospace; }
+
+.region {
+border: 1px solid red;
+padding: 2px;
+width: 250px;
+height: 55px;
+}
+
+#region4 {
+height: 356px;
+position: absolute;
+left: 330px;
+top: 120px;
+border-width: thick;
+}
+
+p {
+margin: 0px;
+}
+
+#container {
+overflow: auto; 
+border: 3px solid blue;
+width: 270px;
+height: 100px; 
+padding: 10px;
+}
+
+.inner_scroll {
+height: 75px;
+border: 2px solid green;
+margin: 5px;
+overflow: scroll;
+padding: 5px;
+}
+/style
+
+script
+_onload_ = function() {
+if (window.eventSender) {
+eventSender.mouseMoveTo(150, 230);
+eventSender.continuousMouseScrollBy(0, -1);
+eventSender.continuousMouseScrollBy(0, -1);
+eventSender.mouseMoveTo(0, 0);
+}
+}
+/script
+
+body
+div
+The text passes if everything can be scrolled normally using the mouse wheel: 
+ul
+liScrolling inside the green div should work until it reaches the end and then the blue container should scroll./li
+liScrolling inside the orange div should work until it reaches the end and then the blue container should NOT scroll because the region in which the orange div is flowed is absolutely positioned/li
+/ul
+/div
+
+div id=container
+div class=region
+pAssume that there is enough content in the flow to fill the regions/p
+/div
+div class=region
+div class=inner_scroll style=height: 30px; margin-top: 0px;
+pAssume that there is enough content in the flow to fill the regions and the size of the container is less than the size of regions so that the container gets vertical scrollbar.

[webkit-changes] [161056] trunk/LayoutTests

[stavila]

Title: [161056] trunk/LayoutTests








Revision 161056
Author stav...@adobe.com
Date 2013-12-24 06:45:37 -0800 (Tue, 24 Dec 2013)


Log Message
Rename fast/regions/repaint/increasing-region-content-height.html to something more clear
https://bugs.webkit.org/show_bug.cgi?id=126209

Reviewed by Mihnea Ovidenie.

Renamed test file name to better reflect the scenario it tests.

* fast/regions/repaint/repaint-element-inside-relative-region-expected.txt: Renamed from LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt.
* fast/regions/repaint/repaint-element-inside-relative-region.html: Renamed from LayoutTests/fast/regions/repaint/increasing-region-content-height.html.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region-expected.txt
trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region.html


Removed Paths

trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt
trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height.html




Diff

Modified: trunk/LayoutTests/ChangeLog (161055 => 161056)

--- trunk/LayoutTests/ChangeLog	2013-12-24 09:36:13 UTC (rev 161055)
+++ trunk/LayoutTests/ChangeLog	2013-12-24 14:45:37 UTC (rev 161056)
@@ -1,3 +1,15 @@
+2013-12-24  Radu Stavila  stav...@adobe.com
+
+Rename fast/regions/repaint/increasing-region-content-height.html to something more clear
+https://bugs.webkit.org/show_bug.cgi?id=126209
+
+Reviewed by Mihnea Ovidenie.
+
+Renamed test file name to better reflect the scenario it tests.
+
+* fast/regions/repaint/repaint-element-inside-relative-region-expected.txt: Renamed from LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt.
+* fast/regions/repaint/repaint-element-inside-relative-region.html: Renamed from LayoutTests/fast/regions/repaint/increasing-region-content-height.html.
+
 2013-12-24  Ryosuke Niwa  rn...@webkit.org
 
 Suppress assertions in js/dom/dfg-custom-getter-throw.html and js/dom/dfg-custom-getter-throw-inlined.html for now.


Deleted: trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt (161055 => 161056)

--- trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt	2013-12-24 09:36:13 UTC (rev 161055)
+++ trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt	2013-12-24 14:45:37 UTC (rev 161056)
@@ -1,10 +0,0 @@
-This text should not get clipped
-(repaint rects
-  (rect 0 0 800 50)
-  (rect 0 200 800 50)
-  (rect 0 200 800 50)
-  (rect 0 0 400 200)
-  (rect 0 50 400 200)
-  (rect 0 50 400 200)
-)
-


Deleted: trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height.html (161055 => 161056)

--- trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height.html	2013-12-24 09:36:13 UTC (rev 161055)
+++ trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height.html	2013-12-24 14:45:37 UTC (rev 161056)
@@ -1,38 +0,0 @@
-!DOCTYPE html
-html
-	head
-		script src="" type=text/_javascript_/script
-		
-		style
-			div.content {
--webkit-flow-into: flow;
-			}
-			p, body {
-margin: 0;
-			}
-			#region {
--webkit-flow-from: flow;
-background-color: lightgray;
-position: relative;
-width: 400px;
-height: 200px;
-			}
-		/style
-	/head
-	body _onload_=runRepaintTest();
-		div id=box/div
-		div class=content
-			pThis text should not get clipped/p
-		/div
-
-		div id=region/div
-		
-		script type=text/_javascript_
-			function repaintTest() 
-			{
-var box = document.getElementById(box);
-box.style.height = 50px;
-			}
-		/script
-	/body
-/html


Copied: trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region-expected.txt (from rev 161055, trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt) (0 => 161056)

--- trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region-expected.txt	2013-12-24 14:45:37 UTC (rev 161056)
@@ -0,0 +1,10 @@
+This text should not get clipped
+(repaint rects
+  (rect 0 0 800 50)
+  (rect 0 200 800 50)
+  (rect 0 200 800 50)
+  (rect 0 0 400 200)
+  (rect 0 50 400 200)
+  (rect 0 50 400 200)
+)
+


Copied: trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region.html (from rev 161055, trunk/LayoutTests/fast/regions/repaint/increasing-region-content-height.html) (0 => 161056)

--- trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region.html	2013-12-24 14:45:37 UTC (rev 161056)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+	head
+		script src="&

[webkit-changes] [160905] trunk

[stavila]

Title: [160905] trunk








Revision 160905
Author stav...@adobe.com
Date 2013-12-20 05:44:45 -0800 (Fri, 20 Dec 2013)


Log Message
[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
https://bugs.webkit.org/show_bug.cgi?id=117259

Reviewed by Antti Koivisto.

Source/WebCore:

When computing the repaint rect for a region, the existing visual overflow must be taken into consideration.
For this purpose, I overridden the visualOverflowRect method in RenderNamedFlowFragment, which ends up being
called from RenderBox::clippedOverflowRectForRepaint.

Test: fast/regions/hover-single-flow-from-none-overflow.html
  fast/regions/hover-single-flow-from-none-overflow-top.html

* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::visualOverflowRect):
* rendering/RenderNamedFlowFragment.h:

LayoutTests:

Added new tests and rebased existing test.

* fast/regions/hover-single-flow-from-none-overflow-expected.html: Added.
* fast/regions/hover-single-flow-from-none-overflow.html: Added.
* fast/regions/hover-single-flow-from-none-overflow-top-expected.html: Added.
* fast/regions/hover-single-flow-from-none-overflow-top.html: Added.
* fast/regions/repaint/repaint-regions-overflow-expected.txt: Rebased.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h


Added Paths

trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html
trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html
trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top.html
trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (160904 => 160905)

--- trunk/LayoutTests/ChangeLog	2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/LayoutTests/ChangeLog	2013-12-20 13:44:45 UTC (rev 160905)
@@ -1,3 +1,18 @@
+2013-12-20  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
+https://bugs.webkit.org/show_bug.cgi?id=117259
+
+Reviewed by Antti Koivisto.
+
+Added new tests and rebased existing test.
+
+* fast/regions/hover-single-flow-from-none-overflow-expected.html: Added.
+* fast/regions/hover-single-flow-from-none-overflow.html: Added.
+* fast/regions/hover-single-flow-from-none-overflow-top-expected.html: Added.
+* fast/regions/hover-single-flow-from-none-overflow-top.html: Added.
+* fast/regions/repaint/repaint-regions-overflow-expected.txt: Rebased.
+
 2013-12-20  Mario Sanchez Prada  mario.pr...@samsung.com
 
 Programmatically-inserted children lack accessibility events


Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html (0 => 160905)

--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html	2013-12-20 13:44:45 UTC (rev 160905)
@@ -0,0 +1,23 @@
+!doctype html
+html lang=en
+head
+	style
+	p, div {
+		font: 12px/1 monospace;
+	}
+	#region {
+		width: 300px;
+		height: 190px;
+		border: 5px solid green;
+		border-left: 100px solid green;
+		border-color: darkred;
+		background-color: #ff;
+	}
+	/style
+/head
+body
+	a href="" Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted/a
+	pWhen hovering the span style=color:greenbregion/b/span, the span style=color:bluebblue/b/span box band its overflow/b should disappear (the region's bflow-from/b will change to none)/p
+	div id=region/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html (0 => 160905)

--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html	2013-12-20 13:44:45 UTC (rev 160905)
@@ -0,0 +1,25 @@
+!doctype html
+html lang=en
+head
+	style
+	p, div {
+		font: 12px/1 monospace;
+	}
+	#region {
+		width: 300px;
+		height: 190px;
+		border: 5px solid green;
+		border-left: 100px solid green;
+		border-color: darkred;
+		background-color: #ff;
+		margin-top: 50px;
+		margin-left: 50px;
+	}
+	/style
+/head
+body
+	a href="" Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted/a
+	pWhen hovering the span style=color:greenbregion/b/span, the span style=color:bluebblue/b/span box band its overflow/b should disappe

[webkit-changes] [160721] trunk

[stavila]

Title: [160721] trunk








Revision 160721
Author stav...@adobe.com
Date 2013-12-17 12:13:53 -0800 (Tue, 17 Dec 2013)


Log Message
[CSS Regions] Positioned elements in regions get clipped if they fall outside the region
https://bugs.webkit.org/show_bug.cgi?id=117120

Reviewed by Mihnea Ovidenie.

Source/WebCore:

Fixed the computing of the box decorations clip rect when having statically positioned
elements inside positioned elements. The existing algorithm computed the rect in a loop
running up the containing block chain and only checked for positioned elements before
starting the loop. If a positioned elements was found in the middle of a loop (as would
be the case with a positioned element parenting a non-positioned element), it was not
correctly handled.
Also changed it so the clip is only performed in the fragmentation direction as that was
the original purpose of this method.

Tests: fast/regions/absolute-in-relative-overflow.html
   fast/regions/static-in-relative-overflow.html
   fast/regions/sticky-border-overflow.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):

LayoutTests:

Added tests for the correct painting of the borders of differently positioned elements overflowing regions.

* fast/regions/absolute-in-relative-overflow-expected.html: Added.
* fast/regions/absolute-in-relative-overflow.html: Added.
* fast/regions/static-in-relative-overflow-expected.html: Added.
* fast/regions/static-in-relative-overflow.html: Added.
* fast/regions/sticky-border-overflow-expected.html: Added.
* fast/regions/sticky-border-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp


Added Paths

trunk/LayoutTests/fast/regions/absolute-in-relative-overflow-expected.html
trunk/LayoutTests/fast/regions/absolute-in-relative-overflow.html
trunk/LayoutTests/fast/regions/static-in-relative-overflow-expected.html
trunk/LayoutTests/fast/regions/static-in-relative-overflow.html
trunk/LayoutTests/fast/regions/sticky-border-overflow-expected.html
trunk/LayoutTests/fast/regions/sticky-border-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (160720 => 160721)

--- trunk/LayoutTests/ChangeLog	2013-12-17 20:11:56 UTC (rev 160720)
+++ trunk/LayoutTests/ChangeLog	2013-12-17 20:13:53 UTC (rev 160721)
@@ -1,3 +1,19 @@
+2013-12-17  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Positioned elements in regions get clipped if they fall outside the region
+https://bugs.webkit.org/show_bug.cgi?id=117120
+
+Reviewed by Mihnea Ovidenie.
+
+Added tests for the correct painting of the borders of differently positioned elements overflowing regions.
+
+* fast/regions/absolute-in-relative-overflow-expected.html: Added.
+* fast/regions/absolute-in-relative-overflow.html: Added.
+* fast/regions/static-in-relative-overflow-expected.html: Added.
+* fast/regions/static-in-relative-overflow.html: Added.
+* fast/regions/sticky-border-overflow-expected.html: Added.
+* fast/regions/sticky-border-overflow.html: Added.
+
 2013-12-17  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r160717.


Added: trunk/LayoutTests/fast/regions/absolute-in-relative-overflow-expected.html (0 => 160721)

--- trunk/LayoutTests/fast/regions/absolute-in-relative-overflow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/absolute-in-relative-overflow-expected.html	2013-12-17 20:13:53 UTC (rev 160721)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+
+style
+#regionFlow {
+border: 4px solid brown;
+width: 180px;
+height: 140px;
+padding: 5px;
+}
+
+#rel {
+border: 2px solid green;
+width: 210px;
+height: 150px;
+position: relative;
+left: 30px;
+top: 20px;
+padding: 3px;
+}
+
+#abs {
+border: 1px solid magenta;
+position: absolute;
+width: 250px;
+top: 50px;
+left: 30px;
+}
+/style
+
+body
+a href="" Regions] Positioned elements in regions get clipped if they fall outside the region/a
+pThis tests that overflowing borders are properly painted for absolute-positioned elements inside relative-positioned elements. The test passes if all borders are completely visible and the text span style=color:brownbTHE END/b/span is visible/p
+div id=regionFlow
+div id=rel
+div id=abs
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/abso

[webkit-changes] [160014] trunk

[stavila]

Title: [160014] trunk








Revision 160014
Author stav...@adobe.com
Date 2013-12-03 10:28:54 -0800 (Tue, 03 Dec 2013)


Log Message
The overflow border of a relatively positioned element inside a region is not painted
https://bugs.webkit.org/show_bug.cgi?id=124919

Source/WebCore:

Relative positioned elements have self-painting layers that don't propagate the visual overflow
so the layer's position should be used when determining the clipping rectangle for box decorations.

Reviewed by Mihnea Ovidenie.

Test: fast/regions/relative-borders-overflow.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):

LayoutTests:

Added new tests for correct painting of the borders of a relatively positioned element inside a region.

Reviewed by Mihnea Ovidenie.

* fast/regions/relative-borders-overflow-expected.html: Added.
* fast/regions/relative-borders-overflow.html: Added.
* fast/regions/relative-in-absolute-borders-overflow-expected.html: Added.
* fast/regions/relative-in-absolute-borders-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp


Added Paths

trunk/LayoutTests/fast/regions/relative-borders-overflow-expected.html
trunk/LayoutTests/fast/regions/relative-borders-overflow.html
trunk/LayoutTests/fast/regions/relative-in-absolute-borders-overflow-expected.html
trunk/LayoutTests/fast/regions/relative-in-absolute-borders-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (160013 => 160014)

--- trunk/LayoutTests/ChangeLog	2013-12-03 18:09:28 UTC (rev 160013)
+++ trunk/LayoutTests/ChangeLog	2013-12-03 18:28:54 UTC (rev 160014)
@@ -1,3 +1,17 @@
+2013-12-03  Radu Stavila  stav...@adobe.com
+
+The overflow border of a relatively positioned element inside a region is not painted
+https://bugs.webkit.org/show_bug.cgi?id=124919
+
+Added new tests for correct painting of the borders of a relatively positioned element inside a region.
+
+Reviewed by Mihnea Ovidenie.
+
+* fast/regions/relative-borders-overflow-expected.html: Added.
+* fast/regions/relative-borders-overflow.html: Added.
+* fast/regions/relative-in-absolute-borders-overflow-expected.html: Added.
+* fast/regions/relative-in-absolute-borders-overflow.html: Added.
+
 2013-12-03  Chris Fleizach  cfleiz...@apple.com
 
 AX: aria-hidden=false does not work as expected


Added: trunk/LayoutTests/fast/regions/relative-borders-overflow-expected.html (0 => 160014)

--- trunk/LayoutTests/fast/regions/relative-borders-overflow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/relative-borders-overflow-expected.html	2013-12-03 18:28:54 UTC (rev 160014)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+
+style
+#regionFlow {
+border: 1px solid brown;
+width: 180px;
+height: 140px;
+}
+
+#article {
+border: 2px solid green;
+width: 210px;
+height: 150px;
+position: relative;
+left: 30px;
+top: 20px;
+padding: 3px;
+}
+/style
+
+body
+pThe test passes if all borders are completely visible and the text span style=color:brownbTHE END/b/span is visible/p
+div id=regionFlow
+div id=article
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/relative-borders-overflow.html (0 => 160014)

--- trunk/LayoutTests/fast/regions/relative-borders-overflow.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/relative-borders-overflow.html	2013-12-03 18:28:54 UTC (rev 160014)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+
+style
+#regionFlow {
+-webkit-flow-from: flow2;
+border: 1px solid brown;
+width: 180px;
+height: 140px;
+}
+
+#article {
+-webkit-flow-into: flow2;
+border: 2px solid green;
+width: 210px;
+height: 150px;
+position: relative;
+left: 30px;
+top: 20px;
+padding: 3px;
+}
+/style
+
+body
+pThe test passes if all borders are completely visible and the text span style=color:brownbTHE END/b/span is visible/p
+div id=regionFlow/div
+
+div id=article
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. span style=color:brownbTHE END/b/span.
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/relative-in-absolut

[webkit-changes] [159745] trunk/Source/WebCore

[stavila]

Title: [159745] trunk/Source/WebCore








Revision 159745
Author stav...@adobe.com
Date 2013-11-25 04:14:52 -0800 (Mon, 25 Nov 2013)


Log Message
Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833

Reviewed by Mihnea Ovidenie.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderRegion.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (159744 => 159745)

--- trunk/Source/WebCore/ChangeLog	2013-11-25 11:36:11 UTC (rev 159744)
+++ trunk/Source/WebCore/ChangeLog	2013-11-25 12:14:52 UTC (rev 159745)
@@ -1,3 +1,13 @@
+2013-11-25  Radu Stavila  stav...@adobe.com
+
+Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
+https://bugs.webkit.org/show_bug.cgi?id=124833
+
+Reviewed by Mihnea Ovidenie.
+
+* rendering/RenderRegion.cpp:
+(WebCore::RenderRegion::layoutBlock):
+
 2013-11-18  Sergio Villar Senin  svil...@igalia.com
 
 [CSS Grid Layout] Cache several vectors to avoid malloc/free churn


Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (159744 => 159745)

--- trunk/Source/WebCore/rendering/RenderRegion.cpp	2013-11-25 11:36:11 UTC (rev 159744)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp	2013-11-25 12:14:52 UTC (rev 159745)
@@ -324,17 +324,6 @@
 // This can happen even if we are in the inConstrainedLayoutPhase and it will trigger a pathological layout of the flow thread.
 m_flowThread-invalidateRegions();
 }
-
-// FIXME: We need to find a way to set up overflow properly. Our flow thread hasn't gotten a layout
-// yet, so we can't look to it for correct information. It's possible we could wait until after the RenderFlowThread
-// gets a layout, and then try to propagate overflow information back to the region, and then mark for a second layout.
-// That second layout would then be able to use the information from the RenderFlowThread to set up overflow.
-//
-// The big problem though is that overflow needs to be region-specific. We can't simply use the RenderFlowThread's global
-// overflow values, since then we'd always think any narrow region had huge overflow (all the way to the width of the
-// RenderFlowThread itself).
-//
-// We'll need to expand RenderBoxRegionInfo to also hold left and right overflow values.
 }
 
 void RenderRegion::computeOverflowFromFlowThread()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [159640] trunk/LayoutTests

[stavila]

Title: [159640] trunk/LayoutTests








Revision 159640
Author stav...@adobe.com
Date 2013-11-21 12:03:05 -0800 (Thu, 21 Nov 2013)


Log Message
Added test for :hover and _javascript_ events on the visual overflow of a region.

[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor _javascript_ events
https://bugs.webkit.org/show_bug.cgi?id=112010

Reviewed by Antti Koivisto.

* fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
* fast/regions/hover-and-js-in-visual-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow-expected.html
trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (159639 => 159640)

--- trunk/LayoutTests/ChangeLog	2013-11-21 20:00:13 UTC (rev 159639)
+++ trunk/LayoutTests/ChangeLog	2013-11-21 20:03:05 UTC (rev 159640)
@@ -1,3 +1,15 @@
+2013-11-21  Radu Stavila  stav...@adobe.com
+
+Added test for :hover and _javascript_ events on the visual overflow of a region.
+
+[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor _javascript_ events
+https://bugs.webkit.org/show_bug.cgi?id=112010
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
+* fast/regions/hover-and-js-in-visual-overflow.html: Added.
+
 2013-11-21  Alexey Proskuryakov  a...@apple.com
 
 Implement WebCrypto unwrapKey


Added: trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow-expected.html (0 => 159640)

--- trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow-expected.html	2013-11-21 20:03:05 UTC (rev 159640)
@@ -0,0 +1,68 @@
+!doctype html
+html lang=en
+head
+	meta charset=UTF-8
+	titleMouse selection in visible overflow of a region/title
+	style
+	body, p, ol {
+		margin: 0;
+		padding: 0;
+	}
+	input {
+		width: 100px;
+	}
+	#content {
+		font-family: monospace;
+		font-size: 20px;
+		line-height: 1em;
+	}
+	.spacer {
+		width: 100%;
+		height: 80px;
+		display: block;
+	}
+	.highlite {
+		background-color: green;
+		color: white;
+	}
+	#region {
+		border: 2px solid black;
+		background-color: lightgray;
+		width: 100px;
+		height: 100px;
+	}
+	#parent {
+		float: left;
+		height: 200px;
+	}
+	#region p {
+		background-color: red;
+		width: 100%;
+		height: 50%;
+	}
+	#result {
+		color: green;
+		font-weight: bold;
+	}
+	ol {
+	list-style:none;
+	}
+	/style
+/head
+body
+	div id=parent
+		div id=region
+			div id=contentspan class=spacer/spanThis text has span class=highliteoverflow/span/div
+		/div
+	/div
+	!-- span class=highlitetest/span --
+	ol
+		liYou should not see any red before or during this test./li
+		liMove the mouse over the blue word (emoverflow/em) outside the gray square./li
+		liThe word should become white on a green background./li
+		liYou should see the word PASS displayed below, in green./li
+	/ol
+	
+	div id=resultPASS/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow.html (0 => 159640)

--- trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/hover-and-js-in-visual-overflow.html	2013-11-21 20:03:05 UTC (rev 159640)
@@ -0,0 +1,94 @@
+!doctype html
+html lang=en
+head
+	meta charset=UTF-8
+	titleMouse selection in visible overflow of a region/title
+	style
+	body, p, ol {
+		margin: 0;
+		padding: 0;
+	}
+	input {
+		width: 100px;
+	}
+	#content {
+		font-family: monospace;
+		font-size: 20px;
+		line-height: 1em;
+		-webkit-flow-into: f;
+	}
+	.spacer {
+		width: 100%;
+		height: 80px;
+		display: block;
+	}
+	.highlite {
+		color: deepskyblue;
+	}
+	.highlite:hover {
+		background-color: green;
+		color: white;
+	}
+	#region {
+		border: 2px solid black;
+		background-color: lightgray;
+		width: 100px;
+		height: 100px;
+		-webkit-flow-from: f;
+	}
+	#parent {
+		float: left;
+		height: 200px;
+	}
+	#region p {
+		background-color: red;
+		width: 100%;
+		height: 50%;
+	}
+	#result {
+		color: green;
+		font-weight: bold;
+	}
+	/style
+/head
+
+script type=text/_javascript_
+	if (window.testRunner)
+		testRunner.waitUntilDone();
+
+	function beginTest() {
+		if (window.eventSender) {
+			var obj  = document.querySelector(.highlite);
+
+			// move mouse on the hover test object
+			eventSender.mouseMoveTo(obj.offsetLeft + 5, obj.offsetTop + 5);
+			eventSender.mouseDown(0);
+
+			testRunner.notifyDone();
+		}
+	}
+/script
+
+body _onload_=beginTest()
+	div id=parent
+		div id=region
+			p/p
+		/div
+	/div
+	ol
+		liYou should not see any red before or during this test./li
+		liMove the mouse over the blue word (emoverflow/em) outside the gray square./li
+		l

[webkit-changes] [159627] trunk/LayoutTests

[stavila]

Title: [159627] trunk/LayoutTests








Revision 159627
Author stav...@adobe.com
Date 2013-11-21 07:43:37 -0800 (Thu, 21 Nov 2013)


Log Message
[CSS Regions] Float get sliced if its container has forced break and is less tall than float
https://bugs.webkit.org/show_bug.cgi?id=124205

Added test for the case when a float is overflowing a region due to a forced break.

Reviewed by Antti Koivisto.

* fast/regions/float-slicing-on-forced-break-expected.html: Added.
* fast/regions/float-slicing-on-forced-break.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/float-slicing-on-forced-break-expected.html
trunk/LayoutTests/fast/regions/float-slicing-on-forced-break.html




Diff

Modified: trunk/LayoutTests/ChangeLog (159626 => 159627)

--- trunk/LayoutTests/ChangeLog	2013-11-21 15:17:08 UTC (rev 159626)
+++ trunk/LayoutTests/ChangeLog	2013-11-21 15:43:37 UTC (rev 159627)
@@ -1,3 +1,15 @@
+2013-11-21  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Float get sliced if its container has forced break and is less tall than float
+https://bugs.webkit.org/show_bug.cgi?id=124205
+
+Added test for the case when a float is overflowing a region due to a forced break.
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/float-slicing-on-forced-break-expected.html: Added.
+* fast/regions/float-slicing-on-forced-break.html: Added.
+
 2013-11-21  Mihai Maerean  mmaer...@adobe.com
 
 Fix hover area for divs with css transforms


Added: trunk/LayoutTests/fast/regions/float-slicing-on-forced-break-expected.html (0 => 159627)

--- trunk/LayoutTests/fast/regions/float-slicing-on-forced-break-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/float-slicing-on-forced-break-expected.html	2013-11-21 15:43:37 UTC (rev 159627)
@@ -0,0 +1,49 @@
+!DOCTYPE html
+html
+	head
+		titlefloat overflowing container with forced region break/title
+		style
+		div {
+			font-family: monospace;
+			font-size: 20px;
+			line-height: 1em;
+		}
+		#container {
+			color: blue;
+		}
+		.float {
+			float: left;
+			color: green;
+		}
+		.region {
+			margin: 20px;
+		}
+		#small {
+			font-size: 10px;
+			line-height: 1em;
+		}
+		/style
+	/head
+	body
+		p
+			Float overflowing its container that has a forced break. Two regions. No line should be sliced.
+		/p
+
+		div class=region
+			div id=container
+div class=float
+	FILLERbr
+	FILLERbr
+	FILLERbr
+	FILLER
+/div
+FILLER
+div id=smallTINY/div
+			/div
+		/div
+		div class=region style=color: blue;
+			FILLERbr
+			FILLER
+		/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/float-slicing-on-forced-break.html (0 => 159627)

--- trunk/LayoutTests/fast/regions/float-slicing-on-forced-break.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/float-slicing-on-forced-break.html	2013-11-21 15:43:37 UTC (rev 159627)
@@ -0,0 +1,58 @@
+!DOCTYPE html
+html
+	head
+		titlefloat overflowing container with forced region break/title
+		style
+		article {
+			font-family: monospace;
+			font-size: 20px;
+			line-height: 1em;
+			color: green;
+		}
+		.flow {
+			-webkit-flow-into: f;
+			color: blue;
+		}
+		.float {
+			float: left;
+			color: green;
+		}
+		.region {
+			-webkit-flow-from: f;
+			margin: 20px;
+		}
+		#container {
+			-webkit-region-break-after: always;
+		}
+		#small {
+			font-size: 10px;
+			line-height: 1em;
+		}
+		/style
+	/head
+	body
+		p
+			Float overflowing its container that has a forced break. Two regions. No line should be sliced.
+		/p
+
+		div class=region
+		/div
+		div class=region
+		/div
+
+		article class=flow
+			div id=container
+div class=float
+	FILLERbr
+	FILLERbr
+	FILLERbr
+	FILLER
+/div
+FILLER
+div id=smallTINY/div
+			/div
+			FILLERbr
+			FILLER
+		/article
+	/body
+/html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [159624] trunk/LayoutTests

[stavila]

Title: [159624] trunk/LayoutTests








Revision 159624
Author stav...@adobe.com
Date 2013-11-21 06:57:14 -0800 (Thu, 21 Nov 2013)


Log Message
Added test for visual overflow with transformed content in regions.

[CSS Regions] Transform applied to content node causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=116242

Reviewed by Antti Koivisto.

* fast/regions/region-visual-overflow-transform-expected.html: Added.
* fast/regions/region-visual-overflow-transform.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/region-visual-overflow-transform-expected.html
trunk/LayoutTests/fast/regions/region-visual-overflow-transform.html




Diff

Modified: trunk/LayoutTests/ChangeLog (159623 => 159624)

--- trunk/LayoutTests/ChangeLog	2013-11-21 14:53:19 UTC (rev 159623)
+++ trunk/LayoutTests/ChangeLog	2013-11-21 14:57:14 UTC (rev 159624)
@@ -1,3 +1,15 @@
+2013-11-21  Radu Stavila  stav...@adobe.com
+
+Added test for visual overflow with transformed content in regions.
+
+[CSS Regions] Transform applied to content node causes overflow to be hidden
+https://bugs.webkit.org/show_bug.cgi?id=116242
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/region-visual-overflow-transform-expected.html: Added.
+* fast/regions/region-visual-overflow-transform.html: Added.
+
 2013-11-21  Andrzej Badowski  a.badow...@samsung.com
 
 [EFL] Fix accessibility media-element expectation


Added: trunk/LayoutTests/fast/regions/region-visual-overflow-transform-expected.html (0 => 159624)

--- trunk/LayoutTests/fast/regions/region-visual-overflow-transform-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-visual-overflow-transform-expected.html	2013-11-21 14:57:14 UTC (rev 159624)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+head
+titleCSS Reftest Reference/title
+style type=text/css
+.square {
+float: left;
+font-family: Ahem;
+font-size: 10px;
+line-height: 20px;
+margin-left: 10px;
+color: green;
+width: 100px;
+height: 100px;
+border: 1px solid black;
+}
+
+/style
+/head
+body
+pThe test passes if:/p
+ul 
+liThe two squares each contain five green horizontal stripes/li
+liThere are two green horizontal stripes below the square on right/li
+liThere is no red/li
+/ul
+div class=square
+XX XX XX XX XX
+/div
+div class=square
+XX XX XX XX XX XX XX
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/region-visual-overflow-transform.html (0 => 159624)

--- trunk/LayoutTests/fast/regions/region-visual-overflow-transform.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-visual-overflow-transform.html	2013-11-21 14:57:14 UTC (rev 159624)
@@ -0,0 +1,66 @@
+!DOCTYPE HTML
+html
+head
+meta charset=UTF-8
+titleCSS Regions: Transformed content in named flow that spans multiple regions and overflows/title
+style
+.ahem {
+font-family: Ahem;
+font-size: 10px;
+line-height: 20px; 
+}
+#source {
+width: 100px;
+height: 100px;
+color: green;
+margin-left: -50px;
+-webkit-transform: translateX(50px);
+-webkit-flow-into: f;
+}
+.region {
+-webkit-flow-from: f;
+width: 100px;
+height: 100px;
+margin-left: 10px;
+float: left;
+border: 1px solid black;
+}
+.failure {
+position: absolute;
+width: 102px;
+height: 102px;
+margin-top: 1px;
+margin-left: 10px;
+padding-left: 1px;
+color: red;
+z-index: -1;
+}
+.left {
+left: 8px;
+}
+.right {
+left: 120px;
+}
+/style
+/head
+body
+pThe test passes if:/p
+ul 
+liThe two squares each contain five green horizontal stripes/li
+liThere are two green horizontal stripes below the square on right/li
+liThere is no red/li
+/ul
+div id=source class=ahemXX XX XX XX XX XX XX XX XX XX XX XX/div
+div class=region/div
+div class=region/div
+
+div class=ahem failure left
+XX XX XX XX XX
+/div
+div class=ahem failure right
+XX XX XX XX XX XX XX
+/div
+
+
+/body
+/html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [159625] trunk/LayoutTests

[stavila]

Title: [159625] trunk/LayoutTests








Revision 159625
Author stav...@adobe.com
Date 2013-11-21 06:58:20 -0800 (Thu, 21 Nov 2013)


Log Message
Created test for positioned fragmented content which overflows the regions.

[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
https://bugs.webkit.org/show_bug.cgi?id=117122

Reviewed by Antti Koivisto.

* fast/regions/positioned-fragmented-content-expected.html: Added.
* fast/regions/positioned-fragmented-content.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/positioned-fragmented-content-expected.html
trunk/LayoutTests/fast/regions/positioned-fragmented-content.html




Diff

Modified: trunk/LayoutTests/ChangeLog (159624 => 159625)

--- trunk/LayoutTests/ChangeLog	2013-11-21 14:57:14 UTC (rev 159624)
+++ trunk/LayoutTests/ChangeLog	2013-11-21 14:58:20 UTC (rev 159625)
@@ -1,5 +1,17 @@
 2013-11-21  Radu Stavila  stav...@adobe.com
 
+Created test for positioned fragmented content which overflows the regions.
+
+[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
+https://bugs.webkit.org/show_bug.cgi?id=117122
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/positioned-fragmented-content-expected.html: Added.
+* fast/regions/positioned-fragmented-content.html: Added.
+
+2013-11-21  Radu Stavila  stav...@adobe.com
+
 Added test for visual overflow with transformed content in regions.
 
 [CSS Regions] Transform applied to content node causes overflow to be hidden


Added: trunk/LayoutTests/fast/regions/positioned-fragmented-content-expected.html (0 => 159625)

--- trunk/LayoutTests/fast/regions/positioned-fragmented-content-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/positioned-fragmented-content-expected.html	2013-11-21 14:58:20 UTC (rev 159625)
@@ -0,0 +1,51 @@
+!doctype html
+html lang=en
+head
+	meta charset=UTF-8
+	titlePositioned elements/title
+	style
+		.region {
+			margin: 25px;
+		}
+
+		.square {
+			width: 100px;
+			height: 100px;
+		}
+
+		.big-square {
+			width: 150px;
+			height: 150px;
+		}
+
+		.bordered {
+			border: 2px dashed red;
+		}
+
+		.float {
+			float: left;
+		}
+
+		.flow p {
+			position: relative;
+			top: 16px;
+			right: 10px;
+			margin: 0;
+			font-size: 16px;
+		}
+	/style
+/head
+body
+	div class=region bordered big-square float
+		div class=flow
+			pLorem ipsum dolor sit amet, consectetur adipisicing elit. Quam, repellat non rerum sit nobis in! Molestias, cumque architecto commodi nam similique? Maiores,/p
+		/div
+	/div
+
+	div class=region bordered square float
+		div class=flow
+			passumenda aperiam reprehenderit magni eaque autem ducimus earum./p
+		/div
+	/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/positioned-fragmented-content.html (0 => 159625)

--- trunk/LayoutTests/fast/regions/positioned-fragmented-content.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/positioned-fragmented-content.html	2013-11-21 14:58:20 UTC (rev 159625)
@@ -0,0 +1,50 @@
+!doctype html
+html lang=en
+head
+	meta charset=UTF-8
+	titlePositioned elements/title
+	style
+		.flow {
+			-webkit-flow-into: f;
+		}
+
+		.region {
+			-webkit-flow-from: f;
+			margin: 25px;
+		}
+
+		.square {
+			width: 100px;
+			height: 100px;
+		}
+
+		.big-square {
+			width: 150px;
+			height: 150px;
+		}
+
+		.bordered {
+			border: 2px dashed red;
+		}
+
+		.float {
+			float: left;
+		}
+
+		.flow p {
+			position: relative;
+			top: 16px;
+			right: 10px;
+			margin: 0;
+			font-size: 16px;
+		}
+	/style
+/head
+body
+	div class=flow
+		pLorem ipsum dolor sit amet, consectetur adipisicing elit. Quam, repellat non rerum sit nobis in! Molestias, cumque architecto commodi nam similique? Maiores, assumenda aperiam reprehenderit magni eaque autem ducimus earum./p
+	/div
+	div class=region bordered big-square float/div
+	div class=region bordered square float/div
+/body
+/html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [159628] trunk/LayoutTests

[stavila]

Title: [159628] trunk/LayoutTests








Revision 159628
Author stav...@adobe.com
Date 2013-11-21 08:50:50 -0800 (Thu, 21 Nov 2013)


Log Message
Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.

[CSS Regions] Overflow areas from regions do not redraw
https://bugs.webkit.org/show_bug.cgi?id=117329

Reviewed by Antti Koivisto.

* fast/regions/regions-overflow-tile-expected.html: Added.
* fast/regions/regions-overflow-tile.html: Added.
* fast/repaint/repaint-regions-overflow-expected.txt: Added.
* fast/repaint/repaint-regions-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/regions-overflow-tile-expected.html
trunk/LayoutTests/fast/regions/regions-overflow-tile.html
trunk/LayoutTests/fast/repaint/repaint-regions-overflow-expected.txt
trunk/LayoutTests/fast/repaint/repaint-regions-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (159627 => 159628)

--- trunk/LayoutTests/ChangeLog	2013-11-21 15:43:37 UTC (rev 159627)
+++ trunk/LayoutTests/ChangeLog	2013-11-21 16:50:50 UTC (rev 159628)
@@ -1,5 +1,20 @@
 2013-11-21  Radu Stavila  stav...@adobe.com
 
+Added test for the overflow of a region being painted across multiple tiles.
+Added test for correct repainting of a region's overflow.
+
+[CSS Regions] Overflow areas from regions do not redraw
+https://bugs.webkit.org/show_bug.cgi?id=117329
+
+Reviewed by Antti Koivisto.
+
+* fast/regions/regions-overflow-tile-expected.html: Added.
+* fast/regions/regions-overflow-tile.html: Added.
+* fast/repaint/repaint-regions-overflow-expected.txt: Added.
+* fast/repaint/repaint-regions-overflow.html: Added.
+
+2013-11-21  Radu Stavila  stav...@adobe.com
+
 [CSS Regions] Float get sliced if its container has forced break and is less tall than float
 https://bugs.webkit.org/show_bug.cgi?id=124205
 


Added: trunk/LayoutTests/fast/regions/regions-overflow-tile-expected.html (0 => 159628)

--- trunk/LayoutTests/fast/regions/regions-overflow-tile-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/regions-overflow-tile-expected.html	2013-11-21 16:50:50 UTC (rev 159628)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+	head
+		style
+			#region1, #region2 {
+			position: absolute;
+			width: 500px;
+			height: 150px;
+			border: 1px solid red;
+			padding: 5px;
+			background-color: lightgray;
+			}
+
+			#region2 {
+			left: 60px;
+			top: 250px;
+			}
+		/style
+	/head
+	body style=-webkit-font-smoothing: none;
+		pOn success, no text should be clipped and you should see span style=color:redLAST LINE/span at the bottom of the text/p
+
+		div id=region1
+		  	pAbove all, avoid lies, all lies, especially the lie to yourself. Keep watch on your own lie and examine it every hour, every minute. And avoid contempt, both of others and of yourself: what seems bad to you in yourself is purified by the very fact that you have noticed it in yourself. And avoid fear, though fear is simply the consequence of every lie. Never be frightened at your own faintheartedness in attaining love, and meanwhile do not even be very frightened by your own bad acts./p
+		/div
+
+		div id=region2
+			p style=margin-top: 0px;Above all, avoid lies, all lies, especially the lie to yourself. Keep watch on your own lie and examine it every hour, every minute. And avoid contempt, both of others and of yourself: what seems bad to you in yourself is purified by the very fact that you have noticed it in yourself. And avoid fear, though fear is simply the consequence of every lie. Never be frightened at your own faintheartedness in attaining love, and meanwhile do not even be very frightened by your own bad acts./p
+		  	pAbove all, avoid lies, all lies, especially the lie to yourself. Keep watch on your own lie and examine it every hour, every minute. And avoid contempt, both of others and of yourself: what seems bad to you in yourself is purified by the very fact that you have noticed it in yourself. And avoid fear, though fear is simply the consequence of every lie. Never be frightened at your own faintheartedness in attaining love, and meanwhile do not even be very frightened by your own bad acts./p
+		  	p style=color:redLAST LINE/p
+		/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/regions-overflow-tile.html (0 => 159628)

--- trunk/LayoutTests/fast/regions/regions-overflow-tile.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/regions-overflow-tile.html	2013-11-21 16:50:50 UTC (rev 159628)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+	head
+		style
+			#content {
+-webkit-flow-into: flow;
+			}
+
+			#region1, #region2 {
+			position: absolute;
+			width: 500px;
+			height: 150px;
+			-webkit-flow-from: flow;
+			border: 1px