[webkit-changes] [WebKit/WebKit] f3b58b: [PlayStation] Remove compiler workaround following...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3b58bf1fdf2e271e1ac10fd933458df78c86429 https://github.com/WebKit/WebKit/commit/f3b58bf1fdf2e271e1ac10fd933458df78c86429 Author: Ross Kirsling Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Remove compiler workaround following gtest upgrade https://bugs.webkit.org/show_bug.cgi?id=273119 Reviewed by Don Olmstead. Following the googletest upgrade in 277635@main, PlayStation no longer needs to undefine __cpp_char8_t. Accordingly, we can revert 268268@main, which silenced a clang warning. * Source/cmake/OptionsPlayStation.cmake: Remove -Wno-builtin-macro-redefined. Canonical link: https://commits.webkit.org/277903@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0315a0: Fix PlayStation build following 277639@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0315a06eafa61cd2713b6b9873003667d7965c6a https://github.com/WebKit/WebKit/commit/0315a06eafa61cd2713b6b9873003667d7965c6a Author: Ross Kirsling Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Source/WebCore/rendering/style/RenderStyleConstants.h Log Message: --- Fix PlayStation build following 277639@main https://bugs.webkit.org/show_bug.cgi?id=272872 Unreviewed build fix. * Source/WebCore/rendering/style/RenderStyleConstants.h: Add missing include. Canonical link: https://commits.webkit.org/277646@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f6df9: Fix PlayStation build following 277560@main, part 2
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f6df93c9ff97c5cf3cdde69ea592c7b694fa78a https://github.com/WebKit/WebKit/commit/8f6df93c9ff97c5cf3cdde69ea592c7b694fa78a Author: Ross Kirsling Date: 2024-04-16 (Tue, 16 Apr 2024) Changed paths: M Source/WebCore/page/DOMWindow.cpp Log Message: --- Fix PlayStation build following 277560@main, part 2 https://bugs.webkit.org/show_bug.cgi?id=272798 Unreviewed build fix. * Source/WebCore/page/DOMWindow.cpp: Add missing include. Canonical link: https://commits.webkit.org/277589@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95394c: Fix PlayStation build following 277560@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95394c1d33d8558d4fd1babcc849b0e53653e08e https://github.com/WebKit/WebKit/commit/95394c1d33d8558d4fd1babcc849b0e53653e08e Author: Ross Kirsling Date: 2024-04-16 (Tue, 16 Apr 2024) Changed paths: M Source/WebCore/page/DOMWindow.h Log Message: --- Fix PlayStation build following 277560@main https://bugs.webkit.org/show_bug.cgi?id=272795 Unreviewed build fix. * Source/WebCore/page/DOMWindow.h: Add missing forward declaration. Canonical link: https://commits.webkit.org/277588@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02f471: Remove new passes from test262 expectations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02f471e34f5612ccd9546a9a4615fc7d22980561 https://github.com/WebKit/WebKit/commit/02f471e34f5612ccd9546a9a4615fc7d22980561 Author: Ross Kirsling Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M JSTests/test262/expectations.yaml Log Message: --- Remove new passes from test262 expectations https://bugs.webkit.org/show_bug.cgi?id=272719 Unreviewed test gardening. * JSTests/test262/expectations.yaml: Remove 10 tests which the bot considers "newly passing". Canonical link: https://commits.webkit.org/277524@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6473ae: Remove superfluous #ifs in PlatformDisplay.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6473aecbfaf64662db9114fae7c977d7cdbcc0ee https://github.com/WebKit/WebKit/commit/6473aecbfaf64662db9114fae7c977d7cdbcc0ee Author: Ross Kirsling Date: 2024-04-09 (Tue, 09 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp Log Message: --- Remove superfluous #ifs in PlatformDisplay.cpp https://bugs.webkit.org/show_bug.cgi?id=272385 Reviewed by Adrian Perez de Castro. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: Address build fix feedback -- remove `#if !defined` checks for PFNEGLCREATEIMAGEPROC and PFNEGLDESTROYIMAGEPROC, as these typedefs can occur unconditionally. Canonical link: https://commits.webkit.org/277238@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c089c7: Fix PlayStation build following 277192@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c089c7bbfc21c7d3fd958631cc0c1de6861ca7a4 https://github.com/WebKit/WebKit/commit/c089c7bbfc21c7d3fd958631cc0c1de6861ca7a4 Author: Ross Kirsling Date: 2024-04-08 (Mon, 08 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp Log Message: --- Fix PlayStation build following 277192@main https://bugs.webkit.org/show_bug.cgi?id=272367 Unreviewed build fix. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: The condition `#ifndef EGL_VERSION_1_5` seems to be based on an assumption that doesn't hold for PS port, so revert it to the explicit `#if !defined`s that we had before. Canonical link: https://commits.webkit.org/277230@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e437c1: Fix !ENABLE(JIT) && ENABLE(WEBASSEMBLY) build afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e437c19ce3281174598fa7a0c68daf6d3f1f1fc8 https://github.com/WebKit/WebKit/commit/e437c19ce3281174598fa7a0c68daf6d3f1f1fc8 Author: Ross Kirsling Date: 2024-04-07 (Sun, 07 Apr 2024) Changed paths: M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp Log Message: --- Fix !ENABLE(JIT) && ENABLE(WEBASSEMBLY) build after 277125@main https://bugs.webkit.org/show_bug.cgi?id=272312 Unreviewed build fix. * Source/JavaScriptCore/wasm/WasmCallee.cpp: * Source/JavaScriptCore/wasm/WasmCallee.h: Ensure JSEntrypointCallee extends from JITCallee even with !ENABLE(JIT). * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: Ensure CCallHelpers usage is guarded by ENABLE(JIT). Canonical link: https://commits.webkit.org/277189@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f0154: Fix PS build following 277163@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f01545fc73fdbf7110122b0bd842c6eea347948 https://github.com/WebKit/WebKit/commit/1f01545fc73fdbf7110122b0bd842c6eea347948 Author: Ross Kirsling Date: 2024-04-07 (Sun, 07 Apr 2024) Changed paths: M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp Log Message: --- Fix PS build following 277163@main https://bugs.webkit.org/show_bug.cgi?id=272316 Unreviewed build fix. * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: Add missing include. Canonical link: https://commits.webkit.org/277188@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34e783: Speculative fix for WinCairo Debug following 27710...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34e783df3303cf7c035425dad421cfb9f5a37a04 https://github.com/WebKit/WebKit/commit/34e783df3303cf7c035425dad421cfb9f5a37a04 Author: Ross Kirsling Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- Speculative fix for WinCairo Debug following 277104@main https://bugs.webkit.org/show_bug.cgi?id=272270 Unreviewed build fix. * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: (WebCore::getShaderLog): (WebCore::getProgramLog): Clarifying that it should be std::span wasn't enough, so clarify that it should be std::span. Canonical link: https://commits.webkit.org/277154@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 856754: Fix PlayStation builds following 277104@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 856754ff32bcf6d62a5dd7da95dac43aa3963c6b https://github.com/WebKit/WebKit/commit/856754ff32bcf6d62a5dd7da95dac43aa3963c6b Author: Ross Kirsling Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h Log Message: --- Fix PlayStation builds following 277104@main https://bugs.webkit.org/show_bug.cgi?id=272268 Unreviewed build fix. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: It is not valid to mark a method as WEBCORE_EXPORT when the class is already WEBCORE_EXPORT. Canonical link: https://commits.webkit.org/277153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eef029: Fix WinCairo Debug following 277140@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eef029ffac934bb421242c33a6d1ffa63272ba3c https://github.com/WebKit/WebKit/commit/eef029ffac934bb421242c33a6d1ffa63272ba3c Author: Ross Kirsling Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- Fix WinCairo Debug following 277140@main https://bugs.webkit.org/show_bug.cgi?id=272267 Unreviewed build fix. * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: (WebCore::getShaderLog): (WebCore::getProgramLog): Clarify usage of std::span. Canonical link: https://commits.webkit.org/277152@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb829e: Fix PlayStation build following 276593@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb829e0ad14e053543e6b140a9f8c68cc9c37cc9 https://github.com/WebKit/WebKit/commit/fb829e0ad14e053543e6b140a9f8c68cc9c37cc9 Author: Ross Kirsling Date: 2024-03-24 (Sun, 24 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp Log Message: --- Fix PlayStation build following 276593@main https://bugs.webkit.org/show_bug.cgi?id=271609 Unreviewed build fix. Same as the previous (276607@main). * Tools/TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp: Canonical link: https://commits.webkit.org/276609@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de98fc: Fix PlayStation build following 276558@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de98fcee68c0bd94f16d6dfb9dac2ea106ee40d5 https://github.com/WebKit/WebKit/commit/de98fcee68c0bd94f16d6dfb9dac2ea106ee40d5 Author: Ross Kirsling Date: 2024-03-24 (Sun, 24 Mar 2024) Changed paths: M Source/WebCore/loader/TextResourceDecoder.cpp Log Message: --- Fix PlayStation build following 276558@main https://bugs.webkit.org/show_bug.cgi?id=271542 Unreviewed build fix. * Source/WebCore/loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::textFromUTF8): Replace std::to_array with std::array; there is minimal benefit to the former in this case. Canonical link: https://commits.webkit.org/276607@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26bbf5: Fix PlayStation build following 276524@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26bbf5941f3e293e33cb56a93fcc7116320240a0 https://github.com/WebKit/WebKit/commit/26bbf5941f3e293e33cb56a93fcc7116320240a0 Author: Ross Kirsling Date: 2024-03-23 (Sat, 23 Mar 2024) Changed paths: M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WTF/wtf/ByteOrder.h Log Message: --- Fix PlayStation build following 276524@main https://bugs.webkit.org/show_bug.cgi?id=271518 Unreviewed build fix. The names bswap16, bswap32, and bswap64 are unfortunately #defines on FreeBSD. https://cgit.freebsd.org/src/tree/sys/sys/endian.h#n62 Per Yusuke's suggestion, rename these to `byteSwap` instead (and update `wswap` to `wordSwap` for consistency). * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::initializeJITPageReservation): * Source/WTF/wtf/ByteOrder.h: (WTF::wordSwap32): Renamed from wswap32. (WTF::byteSwap64): Renamed from bswap64. (WTF::byteSwap32): Renamed from bswap32. (WTF::byteSwap16): Renamed from bswap16. Canonical link: https://commits.webkit.org/276588@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6364f3: Fix PlayStation build following 276462@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6364f38510df0d2b3cf6b30c068d78d12a5831d9 https://github.com/WebKit/WebKit/commit/6364f38510df0d2b3cf6b30c068d78d12a5831d9 Author: Ross Kirsling Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebKit/UIProcess/playstation/PlayStationWebView.cpp Log Message: --- Fix PlayStation build following 276462@main https://bugs.webkit.org/show_bug.cgi?id=271447 Unreviewed build fix; PlayStation platform code was not updated. * Source/WebKit/UIProcess/playstation/PlayStationWebView.cpp: (WebKit::m_backend): Canonical link: https://commits.webkit.org/276527@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 176c9a: Fix PlayStation build after 276463@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 176c9a7db547df2d3ac249f981025a216abf82f7 https://github.com/WebKit/WebKit/commit/176c9a7db547df2d3ac249f981025a216abf82f7 Author: Ross Kirsling Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/PlatformPlayStation.cmake Log Message: --- Fix PlayStation build after 276463@main https://bugs.webkit.org/show_bug.cgi?id=271439 Unreviewed build fix. * Source/WebCore/PlatformPlayStation.cmake: For now, don't compile GLFence.cpp on PS; this requires GLES3. Canonical link: https://commits.webkit.org/276519@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc4afd: Fix PlayStation build following 276417@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc4afd55e79ab471f49f361a783bf6f8b551c429 https://github.com/WebKit/WebKit/commit/cc4afd55e79ab471f49f361a783bf6f8b551c429 Author: Ross Kirsling Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/wtf/MathExtras.h Log Message: --- Fix PlayStation build following 276417@main https://bugs.webkit.org/show_bug.cgi?id=271352 Unreviewed build fix. PlayStation doesn't currently support std::is_integral, but there's no reason not to use std::is_integral_v anyway. * Source/WTF/wtf/MathExtras.h: (WTF::negate): Replace std::is_integral with std::is_integral_v, as we do elsewhere in the very same file. Canonical link: https://commits.webkit.org/276440@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 129ce1: AXNotification enum ought to be an X macro
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 129ce14b05a4a086cd7ddb915f9ad64c116873aa https://github.com/WebKit/WebKit/commit/129ce14b05a4a086cd7ddb915f9ad64c116873aa Author: Ross Kirsling Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- AXNotification enum ought to be an X macro https://bugs.webkit.org/show_bug.cgi?id=270893 Reviewed by Darin Adler. AXNotification is a giant and frequently updated enum. Every time it is updated, exhaustive switch statements must be updated accordingly. This is a very appropriate place for an X macro -- selfishly, it will help PlayStation port avoid build breaks (since we handle this enum in WKAPICast), but irrespective of platform, it also means that AXLogger won't need to be updated each time AXNotification is updated. * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/276393@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5383d2: test262-runner must only load async harness for as...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5383d29dcaad9a0143ba6eb69cd569a8a0e2ccec https://github.com/WebKit/WebKit/commit/5383d29dcaad9a0143ba6eb69cd569a8a0e2ccec Author: Ross Kirsling Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Tools/Scripts/test262/Runner.pm Log Message: --- test262-runner must only load async harness for async-flagged tests https://bugs.webkit.org/show_bug.cgi?id=271140 Reviewed by Darin Adler. According to test262's documentation (https://github.com/tc39/test262/blob/main/INTERPRETING.md?plain=1#L343), we should not be loading `harness/doneprintHandle.js` for tests without `flags: [async]`. We currently load it for all tests, which results in a harness test failure. * JSTests/test262/expectations.yaml: * Tools/Scripts/test262/Runner.pm: Canonical link: https://commits.webkit.org/276328@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3645b1: [JSC] Bracket compound assignment should resolve p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3645b1d995ed232f168ca763cb79551e3c8596eb https://github.com/WebKit/WebKit/commit/3645b1d995ed232f168ca763cb79551e3c8596eb Author: Ross Kirsling Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- [JSC] Bracket compound assignment should resolve property key at most once https://bugs.webkit.org/show_bug.cgi?id=270563 Reviewed by Yusuke Suzuki. Just as we did for `obj[prop]++` (275531@main), we need to make sure `obj[prop] += 1;` doesn't double-evaluate `prop`. The existing solution, however, is not of reasonable performance when `prop` is a Number value -- it is, of course, unacceptable for `arr[i]++` to be slow. To this end, this patch also introduces OpToPropertyKeyOrNumber, which will return numbers unchanged, just as it does with strings and symbols. * JSTests/test262/expectations.yaml: Mark 22 test cases as passing. * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::PostfixNode::emitBracket): (JSC::PrefixNode::emitBracket): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::ShortCircuitReadModifyBracketNode::emitBytecode): (JSC::ObjectPatternNode::bindValue const): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: * Source/JavaScriptCore/dfg/DFGClobberize.h: * Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp: * Source/JavaScriptCore/dfg/DFGDoesGC.cpp: * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: * Source/JavaScriptCore/dfg/DFGNode.h: * Source/JavaScriptCore/dfg/DFGNodeType.h: * Source/JavaScriptCore/dfg/DFGOperations.cpp: * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGSafeToExecute.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: * Source/JavaScriptCore/ftl/FTLCapabilities.cpp: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: * Source/JavaScriptCore/jit/JIT.cpp: * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: * Source/JavaScriptCore/runtime/CommonSlowPaths.h: Canonical link: https://commits.webkit.org/276014@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9e7ab: [JSC] Bracket compound assignment should resolve p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9e7ab3bddef8b9423dc407026b91312ba46a72d https://github.com/WebKit/WebKit/commit/c9e7ab3bddef8b9423dc407026b91312ba46a72d Author: Ross Kirsling Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- [JSC] Bracket compound assignment should resolve property key at most once https://bugs.webkit.org/show_bug.cgi?id=270563 Reviewed by Yusuke Suzuki. Just as we did for `obj[prop]++` (275531@main), we need to make sure `obj[prop] += 1;` doesn't double-evaluate `prop`. The existing solution, however, is not of reasonable performance when `prop` is a Number value -- it is, of course, unacceptable for `arr[i]++` to be slow. To this end, this patch also introduces OpToPropertyKeyOrNumber, which will return numbers unchanged, just as it does with strings and symbols. * JSTests/test262/expectations.yaml: Mark 22 test cases as passing. * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::PostfixNode::emitBracket): (JSC::PrefixNode::emitBracket): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::ShortCircuitReadModifyBracketNode::emitBytecode): (JSC::ObjectPatternNode::bindValue const): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: * Source/JavaScriptCore/dfg/DFGClobberize.h: * Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp: * Source/JavaScriptCore/dfg/DFGDoesGC.cpp: * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: * Source/JavaScriptCore/dfg/DFGNode.h: * Source/JavaScriptCore/dfg/DFGNodeType.h: * Source/JavaScriptCore/dfg/DFGOperations.cpp: * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGSafeToExecute.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: * Source/JavaScriptCore/ftl/FTLCapabilities.cpp: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: * Source/JavaScriptCore/jit/JIT.cpp: * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: * Source/JavaScriptCore/runtime/CommonSlowPaths.h: Canonical link: https://commits.webkit.org/275944@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b945b: [JSC] Bracket update expression should resolve pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b945bdd8d46d2755cb115acb4596b3ed14d97eb https://github.com/WebKit/WebKit/commit/9b945bdd8d46d2755cb115acb4596b3ed14d97eb Author: Ross Kirsling Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] Bracket update expression should resolve property key at most once https://bugs.webkit.org/show_bug.cgi?id=270150 Reviewed by Justin Michaud. Currently, in an expression like `obj[prop]++`, we double-evaluate `prop`, as GetByVal and PutByVal each perform ToPropertyKey separately. To correct this, we need to perform ToPropertyKey in advance, but only after ensuring that `obj` is object-coercible; if it isn't, we shouldn't perform ToPropertyKey at all. This extra work can be bypassed for literal numbers and strings; as a drive-by fix, this patch corrects a case which was intending to perform a similar bypass, but which mixed up || and &&, thereby ending up with a constant true. * JSTests/test262/expectations.yaml: Mark 8 test cases as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::PostfixNode::emitBracket): (JSC::PrefixNode::emitBracket): (JSC::ObjectPatternNode::bindValue const): Canonical link: https://commits.webkit.org/275531@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a1f6c: instanceof should not get RHS prototype when LHS i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a1f6c179e546b6219dcee2d55add5dc8c7c6b3e https://github.com/WebKit/WebKit/commit/2a1f6c179e546b6219dcee2d55add5dc8c7c6b3e Author: Ross Kirsling Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- instanceof should not get RHS prototype when LHS is primitive https://bugs.webkit.org/show_bug.cgi?id=270065 Reviewed by Justin Michaud. The expression `x instanceof obj` should not access obj.prototype when x is primitive per the spec, but our implementation eagerly grabs the prototype in order to hand it off to OpInstanceof. https://tc39.es/ecma262/multipage/abstract-operations.html#sec-ordinaryhasinstance 7.3.21 OrdinaryHasInstance ( C, O ) ... 3. If O is not an Object, return false. 4. Let P be ? Get(C, "prototype"). ... We could refactor OpInstanceof to take the RHS directly instead of its prototype, but it suffices to add a couple of lines to InstanceOfNode::emitBytecode. (And while we're at it, we can also do a bit better with temp register reuse.) * JSTests/test262/expectations.yaml: Mark two tests as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::InstanceOfNode::emitBytecode): Canonical link: https://commits.webkit.org/275318@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe3d1a: Remove unnecessary feature skip from test262 config
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe3d1a8dd998e753d66c1f26abe5064bdf005faf https://github.com/WebKit/WebKit/commit/fe3d1a8dd998e753d66c1f26abe5064bdf005faf Author: Ross Kirsling Date: 2024-02-25 (Sun, 25 Feb 2024) Changed paths: M JSTests/test262/config.yaml Log Message: --- Remove unnecessary feature skip from test262 config https://bugs.webkit.org/show_bug.cgi?id=270061 Unreviewed test gardening. * JSTests/test262/config.yaml: Remove skip for Intl.Locale-info. This was added in https://github.com/WebKit/WebKit/commit/7e2deb203d53a225fa971d7fb8763dae3e493228 because our implementation was updated *before* the tests were; the tests have been updated in the year since. Canonical link: https://commits.webkit.org/275303@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fc81f: [JSC] Fix parsing of private fields with Unicode s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fc81f8795e87f422134be7c28ca4636b1afedf3 https://github.com/WebKit/WebKit/commit/5fc81f8795e87f422134be7c28ca4636b1afedf3 Author: Ross Kirsling Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/parser/Lexer.cpp Log Message: --- [JSC] Fix parsing of private fields with Unicode start characters https://bugs.webkit.org/show_bug.cgi?id=269831 Reviewed by Darin Adler and Yusuke Suzuki. Our lexer can't currently handle various class-private field names with valid Unicode start characters, like `#ࡀ`. After seeing that m_current is '#', we call isSingleCharacterIdentStart(peek(1)), which complains of U16_IS_SURROGATE; instead of trying to cut a corner, we need to get the next code point from U16_GET, just like we did for m_current. * JSTests/test262/expectations.yaml: Mark 24 test cases passing. * Source/JavaScriptCore/parser/Lexer.cpp: (JSC::Lexer::lexWithoutClearingLineTerminator): Use U16_GET when a private field name starts with a non-Latin1 character. Canonical link: https://commits.webkit.org/275152@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6d51d5: [JSC] Implement Promise.try
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d51d579af47028306a003653150ade5d395f942
https://github.com/WebKit/WebKit/commit/6d51d579af47028306a003653150ade5d395f942
Author: Ross Kirsling
Date: 2024-02-20 (Tue, 20 Feb 2024)
Changed paths:
A JSTests/stress/promise-try.js
M Source/JavaScriptCore/builtins/PromiseConstructor.js
M Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp
M Source/JavaScriptCore/runtime/OptionsList.h
Log Message:
---
[JSC] Implement Promise.try
https://bugs.webkit.org/show_bug.cgi?id=269775
Reviewed by Justin Michaud.
This patch implements https://github.com/tc39/proposal-promise-try behind a
runtime option;
the proposal is currently at Stage 2 but the spec is very simple and not
expected to change.
Effectively, Promise.try(f) is a more convenient way to write `new
Promise((resolve) => { resolve(f()); })` --
we don't care whether f is sync or async, but if is synchronous, we want it to
be executed immediately.
This implementation includes
https://github.com/tc39/proposal-promise-try/pull/16, which the champion
expects to merge;
it simply extends the API to Promise.try(f, ...args) such that arguments can be
forwarded to the callback.
* JSTests/stress/promise-try.js: Added.
* Source/JavaScriptCore/builtins/PromiseConstructor.js:
(try): Added.
* Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::finishCreation):
* Source/JavaScriptCore/runtime/OptionsList.h:
Canonical link: https://commits.webkit.org/275081@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6972b: Fix Win build following 273800@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c6972b546219bef1592ec480c52554f5af40ecc8 https://github.com/WebKit/WebKit/commit/c6972b546219bef1592ec480c52554f5af40ecc8 Author: Ross Kirsling Date: 2024-01-30 (Tue, 30 Jan 2024) Changed paths: M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h Log Message: --- Fix Win build following 273800@main https://bugs.webkit.org/show_bug.cgi?id=268431 Unreviewed build fix. * Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h: Add missing include. Canonical link: https://commits.webkit.org/273807@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f6614: Fix PlayStation build following 273690@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f66141523c809d33c871ef198759b76cf265eba https://github.com/WebKit/WebKit/commit/1f66141523c809d33c871ef198759b76cf265eba Author: Ross Kirsling Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebCore/Modules/credentialmanagement/DigitalCredential.h Log Message: --- Fix PlayStation build following 273690@main https://bugs.webkit.org/show_bug.cgi?id=268353 Unreviewed build fix. * Source/WebCore/Modules/credentialmanagement/DigitalCredential.h: Add missing include. Canonical link: https://commits.webkit.org/273718@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a80fbc: [Win] Remove unused method ChromeClient::setLastSe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a80fbc53323b3e5d5ca1f805c14076c4f78f3fde https://github.com/WebKit/WebKit/commit/a80fbc53323b3e5d5ca1f805c14076c4f78f3fde Author: Ross Kirsling Date: 2024-01-23 (Tue, 23 Jan 2024) Changed paths: M Source/WebCore/loader/EmptyClients.h M Source/WebCore/page/ChromeClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h Log Message: --- [Win] Remove unused method ChromeClient::setLastSetCursorToCurrentCursor https://bugs.webkit.org/show_bug.cgi?id=267983 Reviewed by Fujii Hironori. Seems like this method was used in old WKL Win plugins code, but it's now just dead code. * Source/WebCore/loader/EmptyClients.h: * Source/WebCore/page/ChromeClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: Canonical link: https://commits.webkit.org/273392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c9fb8: REGRESSION(273264@main): SingleRefWeakPtr undefine...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c9fb89b0b131bd03192b36677d5a502e35f730a https://github.com/WebKit/WebKit/commit/8c9fb89b0b131bd03192b36677d5a502e35f730a Author: Ross Kirsling Date: 2024-01-20 (Sat, 20 Jan 2024) Changed paths: M Source/WebCore/rendering/svg/SVGResourcesCache.h Log Message: --- REGRESSION(273264@main): SingleRefWeakPtr undefined in SVGResourcesCache.h https://bugs.webkit.org/show_bug.cgi?id=267829 Unreviewed PlayStation build fix. * Source/WebCore/rendering/svg/SVGResourcesCache.h: Add missing include. Canonical link: https://commits.webkit.org/273270@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7bb431: [PlayStation][Cmake] Fix incorrect filename capita...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7bb43163b87b2c5e949ed1e4b2df69cc12770bc6 https://github.com/WebKit/WebKit/commit/7bb43163b87b2c5e949ed1e4b2df69cc12770bc6 Author: Ross Kirsling Date: 2024-01-16 (Tue, 16 Jan 2024) Changed paths: M Source/WebCore/PlatformPlayStation.cmake Log Message: --- [PlayStation][Cmake] Fix incorrect filename capitalization https://bugs.webkit.org/show_bug.cgi?id=267574 Unreviewed correction for PlayStation port. * Source/WebCore/PlatformPlayStation.cmake: Filenames use the capitalization "PlayStation", not "Playstation". Canonical link: https://commits.webkit.org/273059@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c13502: Fix inconsistent ENABLE(LAYER_BASED_SVG_ENGINE) us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c13502d53c2dc40b2e1376002f4bdb020eb9b98e https://github.com/WebKit/WebKit/commit/c13502d53c2dc40b2e1376002f4bdb020eb9b98e Author: Ross Kirsling Date: 2024-01-15 (Mon, 15 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderObject.h Log Message: --- Fix inconsistent ENABLE(LAYER_BASED_SVG_ENGINE) usage in RenderObject.h https://bugs.webkit.org/show_bug.cgi?id=267524 Unreviewed internal build fix. * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isRenderSVGModelObject const): (WebCore::RenderObject::isRenderSVGContainer const): (WebCore::RenderObject::isRenderSVGShape const): (WebCore::RenderObject::isRenderSVGResourceContainer const): Expose predicates regardless of the ENABLE. Currently we're randomly exposing some predicates and not others, yet some of the unexposed ones depend on exposed ones. Callsites need to be able to check these predicates regardless of whether the feature is enabled. Canonical link: https://commits.webkit.org/273036@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e6dc9: REGRESSION(273000@main): Fix nonsense type `uint`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e6dc979260067def9b97119005132628603fcef https://github.com/WebKit/WebKit/commit/3e6dc979260067def9b97119005132628603fcef Author: Ross Kirsling Date: 2024-01-13 (Sat, 13 Jan 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- REGRESSION(273000@main): Fix nonsense type `uint` https://bugs.webkit.org/show_bug.cgi?id=267490 Unreviewed Win Debug build fix. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::addRelation): Fix typo: `uint` -> `uint8_t` Canonical link: https://commits.webkit.org/273007@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 882831: [PS][WKTR] Adjust AccessibilityUIElement following...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 882831716343f01d582c6740cc7584d96516 https://github.com/WebKit/WebKit/commit/882831716343f01d582c6740cc7584d96516 Author: Ross Kirsling Date: 2024-01-10 (Wed, 10 Jan 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp Log Message: --- [PS][WKTR] Adjust AccessibilityUIElement following 272871@main https://bugs.webkit.org/show_bug.cgi?id=267390 Unreviewed fix, methods stubbed for Win should be stubbed for PS as well. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Canonical link: https://commits.webkit.org/272877@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60c4b2: Clean up PlayStation usage of Chrome / ChromeClient
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60c4b2f3354cabcb107d815b7d9408a0c7a1be79 https://github.com/WebKit/WebKit/commit/60c4b2f3354cabcb107d815b7d9408a0c7a1be79 Author: Ross Kirsling Date: 2024-01-10 (Wed, 10 Jan 2024) Changed paths: M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/loader/EmptyClients.h M Source/WebCore/page/Chrome.h M Source/WebCore/page/ChromeClient.h R Source/WebCore/page/playstation/ChromePlayStation.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h Log Message: --- Clean up PlayStation usage of Chrome / ChromeClient https://bugs.webkit.org/show_bug.cgi?id=267314 Reviewed by Fujii Hironori. Following 272433@main, ensure PlayStation's usage of WebCore's Chrome and ChromeClient classes is sufficiently aligned with other ports (most namely, Windows). In particular: - Remove ChromePlayStation, which serves no purpose - For PS-specific methods in ChromeClient... - make declarations pure virtual - put empty definitions in EmptyClients - stub out real definitions in WebChromeClient (to be implemented in a further patch) * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/loader/EmptyClients.h: * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/playstation/ChromePlayStation.cpp: Removed. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: Canonical link: https://commits.webkit.org/272874@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cc105: PlayStation shouldn't be a !ENABLE(ACCESSIBILITY) ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cc105dfcbd70728e933c45ddb921d353f1448d6 https://github.com/WebKit/WebKit/commit/8cc105dfcbd70728e933c45ddb921d353f1448d6 Author: Ross Kirsling Date: 2023-12-21 (Thu, 21 Dec 2023) Changed paths: M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/accessibility/AXCoreObject.h A Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp A Source/WebCore/accessibility/playstation/AccessibilityObjectPlayStation.cpp M Source/WebCore/page/Chrome.h M Source/WebCore/page/ChromeClient.h A Source/WebCore/page/playstation/ChromePlayStation.cpp M Source/cmake/OptionsPlayStation.cmake Log Message: --- PlayStation shouldn't be a !ENABLE(ACCESSIBILITY) port https://bugs.webkit.org/show_bug.cgi?id=266776 Reviewed by Don Olmstead. Ensure that PlayStation port can build with ENABLE(ACCESSIBILITY), and enable this by default. The implementation can be fleshed out future commits, but it's probably high time to retire this ENABLE. * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp: Added. * Source/WebCore/accessibility/playstation/AccessibilityObjectPlayStation.cpp: Added. * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/playstation/ChromePlayStation.cpp: Added. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/272433@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc7eb6: [PlayStation] Downgrade curl to 7.85.0
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc7eb618e38637aa88ce789c16716bd9309f58cf https://github.com/WebKit/WebKit/commit/cc7eb618e38637aa88ce789c16716bd9309f58cf Author: Ross Kirsling Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/network/curl/CurlContext.cpp M Source/WebCore/platform/network/curl/CurlRequest.cpp M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Downgrade curl to 7.85.0 https://bugs.webkit.org/show_bug.cgi?id=266583 Reviewed by Don Olmstead. Build fix -- revert 263486@main and 263783@main for PlayStation. * Source/WebCore/platform/network/curl/CurlContext.cpp: (WebCore::CurlHandle::enableHttp): * Source/WebCore/platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::didReceiveHeader): (WebCore::CurlRequest::didReceiveData): * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/272228@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e1abb: Make rebind::other explicit in FastAllocator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e1abb6514cdc2bf301e5ea4f299c139faa0b2ff https://github.com/WebKit/WebKit/commit/4e1abb6514cdc2bf301e5ea4f299c139faa0b2ff Author: Ross Kirsling Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/wtf/FastMalloc.h Log Message: --- Make rebind::other explicit in FastAllocator https://bugs.webkit.org/show_bug.cgi?id=265933 Reviewed by Yusuke Suzuki. PlayStation build fix following 271419@main. Evidently using StdUnorderedMap::extract(K) causes our platform to complain about rebind::other being undefined. It's trivial to define so let's just do so. * Source/WTF/wtf/FastMalloc.h: Canonical link: https://commits.webkit.org/271714@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5de93: Use find instead of contains for unordered_map
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5de9361d7352eeb0c9c62ec675a3d32f1d63499 https://github.com/WebKit/WebKit/commit/c5de9361d7352eeb0c9c62ec675a3d32f1d63499 Author: Ross Kirsling Date: 2023-12-05 (Tue, 05 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp Log Message: --- Use find instead of contains for unordered_map https://bugs.webkit.org/show_bug.cgi?id=265920 Reviewed by Don Olmstead. Build fix for PlayStation. `map.contains(element)` may read nicely, but `map.find(element) != map.end()` is still a one-liner. Let's stick to the latter for the moment since it's non-trivial to add a new method to an existing STL container. * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::addTrackBuffer): (WebCore::SourceBufferPrivate::validateInitializationSegment): Canonical link: https://commits.webkit.org/271589@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ec78f: Update Temporal.Now.timeZone() to timeZoneId()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ec78f06da8511b07238023ff6115cf08436c9b9 https://github.com/WebKit/WebKit/commit/8ec78f06da8511b07238023ff6115cf08436c9b9 Author: Ross Kirsling Date: 2023-11-20 (Mon, 20 Nov 2023) Changed paths: M JSTests/complex/temporal-now-timezone-check.js M JSTests/complex/temporal-now-timezone-with-broken-tz.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/runtime/TemporalNow.cpp Log Message: --- Update Temporal.Now.timeZone() to timeZoneId() https://bugs.webkit.org/show_bug.cgi?id=265121 Reviewed by Yusuke Suzuki. The Temporal API spec has changed such that Temporal.Now now has a timeZoneId method instead of a timeZone method. This patch adapts our implementation accordingly. * JSTests/complex/temporal-now-timezone-check.js: * JSTests/complex/temporal-now-timezone-with-broken-tz.js: * JSTests/test262/expectations.yaml: Mark 12 test cases as passing. * Source/JavaScriptCore/runtime/TemporalNow.cpp: Canonical link: https://commits.webkit.org/271003@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c96f1c: Fix !ENABLE(ACCESSIBILITY) build following 270916@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c96f1c58a0d8f11be92c51b509d3858cfb73d366 https://github.com/WebKit/WebKit/commit/c96f1c58a0d8f11be92c51b509d3858cfb73d366 Author: Ross Kirsling Date: 2023-11-17 (Fri, 17 Nov 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 270916@main https://bugs.webkit.org/show_bug.cgi?id=265080 Unreviewed build fix. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::objectsForIDs): Delete duplicate definition. (WebCore::AXObjectCache::relatedObjectIDsFor): Update function signature. Canonical link: https://commits.webkit.org/270932@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 130fd1: Fix PlayStation build following 270852@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 130fd1385553a7a6e82ff7c836e0a4018e35f27e https://github.com/WebKit/WebKit/commit/130fd1385553a7a6e82ff7c836e0a4018e35f27e Author: Ross Kirsling Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M Source/JavaScriptCore/heap/MarkedSpaceInlines.h Log Message: --- Fix PlayStation build following 270852@main https://bugs.webkit.org/show_bug.cgi?id=264997 Unreviewed build fix. * Source/JavaScriptCore/heap/MarkedSpaceInlines.h: (JSC::MarkedSpace::forEachWeakInParallel): .begin() is an iterator, .data() is the pointer that we're looking for. Canonical link: https://commits.webkit.org/270859@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c35971: Fix PlayStation build following 270837@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c359716df67dd66b10da70703b469713d9e1d3dc https://github.com/WebKit/WebKit/commit/c359716df67dd66b10da70703b469713d9e1d3dc Author: Ross Kirsling Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M Source/WebKit/UIProcess/API/C/playstation/WKView.cpp Log Message: --- Fix PlayStation build following 270837@main https://bugs.webkit.org/show_bug.cgi?id=264995 Unreviewed build fix. * Source/WebKit/UIProcess/API/C/playstation/WKView.cpp: (toWKCursorType): Turn Cursor::* into Cursor::Type::*. Canonical link: https://commits.webkit.org/270858@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d3e50: Fix PlayStation build after 270770@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d3e502dfd43fa419482c258d6b7bb7678668813 https://github.com/WebKit/WebKit/commit/5d3e502dfd43fa419482c258d6b7bb7678668813 Author: Ross Kirsling Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M Source/WebCore/PlatformPlayStation.cmake A Source/WebCore/platform/playstation/ThemePlayStation.cpp A Source/WebCore/platform/playstation/ThemePlayStation.h M Source/WebCore/rendering/RenderThemePlayStation.cpp Log Message: --- Fix PlayStation build after 270770@main https://bugs.webkit.org/show_bug.cgi?id=264929 Reviewed by Don Olmstead. Add ThemePlayStation and implement Theme::singleton(). * Source/WebCore/PlatformPlayStation.cmake: Add new file. * Source/WebCore/platform/playstation/ThemePlayStation.cpp: Added. * Source/WebCore/platform/playstation/ThemePlayStation.h: Added. * Source/WebCore/rendering/RenderThemePlayStation.cpp: Fix bogus include. Canonical link: https://commits.webkit.org/270829@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a09dca: Fix !ENABLE(ACCESSIBILITY) build after 270785@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a09dcaed8771059542385757f6dea92939e26c2b https://github.com/WebKit/WebKit/commit/a09dcaed8771059542385757f6dea92939e26c2b Author: Ross Kirsling Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build after 270785@main https://bugs.webkit.org/show_bug.cgi?id=264928 Unreviewed build fix, correct bogus function signature. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onWidgetVisibilityChanged): Canonical link: https://commits.webkit.org/270818@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d7e86: Realign handling of Temporal options with spec
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d7e86f4423f5912f9dce2c3c18689c32524baa4 https://github.com/WebKit/WebKit/commit/3d7e86f4423f5912f9dce2c3c18689c32524baa4 Author: Ross Kirsling Date: 2023-11-07 (Tue, 07 Nov 2023) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/runtime/TemporalObject.cpp Log Message: --- Realign handling of Temporal options with spec https://bugs.webkit.org/show_bug.cgi?id=264326 Reviewed by Yusuke Suzuki. As of the latest Temporal spec... 1. fractionalSecondDigits has been updated to use floor instead of trunc. 2. roundingIncrement now has a maximum of 10^9 and does trunc (not floor) prior to checking against said maximum. * JSTests/test262/expectations.yaml: Mark 14 test cases as passing. * Source/JavaScriptCore/runtime/TemporalObject.cpp: (JSC::temporalFractionalSecondDigits): (JSC::temporalRoundingIncrement): Canonical link: https://commits.webkit.org/270360@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 681701: Temporal API should throw TypeErrors for unexpecte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 681701c7e39b6750bdd27c95497e8dcbc361176b https://github.com/WebKit/WebKit/commit/681701c7e39b6750bdd27c95497e8dcbc361176b Author: Ross Kirsling Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M JSTests/stress/temporal-duration.js M JSTests/stress/temporal-plaindatetime.js M JSTests/test262/config.yaml M JSTests/test262/expectations.yaml M Source/JavaScriptCore/runtime/JSCJSValue.h M Source/JavaScriptCore/runtime/JSCJSValueInlines.h M Source/JavaScriptCore/runtime/TemporalDuration.cpp M Source/JavaScriptCore/runtime/TemporalDurationConstructor.cpp M Source/JavaScriptCore/runtime/TemporalInstant.cpp M Source/JavaScriptCore/runtime/TemporalPlainDate.cpp M Source/JavaScriptCore/runtime/TemporalPlainDateConstructor.cpp M Source/JavaScriptCore/runtime/TemporalPlainDateTime.cpp M Source/JavaScriptCore/runtime/TemporalPlainTime.cpp Log Message: --- Temporal API should throw TypeErrors for unexpected primitives https://bugs.webkit.org/show_bug.cgi?id=264240 Reviewed by Yusuke Suzuki. As of the latest Temporal spec, we should never convert non-object, non-string values to a Temporal object. At our current stage of implementation, this applies to Duration, Instant, PlainDate, PlainTime, and PlainDateTime. Relatedly (namely, for the case of handling explicit undefined values), toIntegerOrInfinity is no longer used by Temporal and toIntegerWithoutRounding has been removed entirely. Spec-side, these have been replaced by toIntegerWithTruncation and toIntegerIfIntegral; here, we implement the former and inline the latter. * JSTests/test262/config.yaml: Move two tests over from expectations.yaml; even before this patch, these are hitting an assertion due to unimplemented parts of Temporal. * JSTests/test262/expectations.yaml: Mark 102 test cases passing. * JSTests/stress/temporal-duration.js: * JSTests/stress/temporal-plaindatetime.js: * Source/JavaScriptCore/runtime/JSCJSValue.h: * Source/JavaScriptCore/runtime/JSCJSValueInlines.h: (JSC::JSValue::toIntegerWithTruncation const): (JSC::JSValue::toIntegerOrInfinity const): (JSC::JSValue::toIntegerWithoutRounding const): Deleted. * Source/JavaScriptCore/runtime/TemporalDuration.cpp: (JSC::TemporalDuration::fromDurationLike): (JSC::TemporalDuration::toISO8601Duration): * Source/JavaScriptCore/runtime/TemporalDurationConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalInstant.cpp: * Source/JavaScriptCore/runtime/TemporalPlainDate.cpp: (JSC::TemporalPlainDate::from): * Source/JavaScriptCore/runtime/TemporalPlainDateConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainDateTime.cpp: (JSC::TemporalPlainDateTime::from): * Source/JavaScriptCore/runtime/TemporalPlainTime.cpp: (JSC::TemporalPlainTime::from): Canonical link: https://commits.webkit.org/270262@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1700e0: Remove passing tests from test262 expectations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1700e039867772aa27b361982e2561c110349510 https://github.com/WebKit/WebKit/commit/1700e039867772aa27b361982e2561c110349510 Author: Ross Kirsling Date: 2023-11-05 (Sun, 05 Nov 2023) Changed paths: M JSTests/test262/expectations.yaml Log Message: --- Remove passing tests from test262 expectations https://bugs.webkit.org/show_bug.cgi?id=264233 Unreviewed test gardening. * JSTests/test262/expectations.yaml: Four of the listed test failures are actually passing. Canonical link: https://commits.webkit.org/270250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c0494: [JSC] Stop ignoring useWebAssembly=1 when JIT is d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c0494fcc3fe018670c408476931c3698d9b2ee2 https://github.com/WebKit/WebKit/commit/2c0494fcc3fe018670c408476931c3698d9b2ee2 Author: Ross Kirsling Date: 2023-11-01 (Wed, 01 Nov 2023) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp Log Message: --- [JSC] Stop ignoring useWebAssembly=1 when JIT is disabled https://bugs.webkit.org/show_bug.cgi?id=263763 Reviewed by Justin Michaud. It's true that WebAssembly won't yet *run* sensibly with JIT off, but ENABLE(WEBASSEMBLY) && !ENABLE(JIT) *is* a valid build configuration now, so JSC should permit enabling useWebAssembly even when JIT is disabled. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::disableAllJITOptions): Canonical link: https://commits.webkit.org/270100@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e757a: Non-unified build fixes, Halloween 2023 edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e757ac6671257c48e961235785ff22e8aeef792 https://github.com/WebKit/WebKit/commit/5e757ac6671257c48e961235785ff22e8aeef792 Author: Ross Kirsling Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M Source/WebCore/Modules/push-api/ServiceWorkerRegistrationPushAPI.cpp M Source/WebCore/Modules/web-locks/WebLockRegistry.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/animation/AnimationEffect.cpp M Source/WebCore/animation/AnimationEventBase.cpp M Source/WebCore/animation/CustomEffect.cpp M Source/WebCore/animation/ElementAnimationRareData.cpp M Source/WebCore/animation/WebAnimationUtilities.cpp M Source/WebCore/bindings/js/JSFileSystemEntryCustom.cpp M Source/WebCore/bindings/js/JSFileSystemHandleCustom.cpp M Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/dom/CDATASection.cpp M Source/WebCore/dom/ContentVisibilityDocumentState.cpp M Source/WebCore/dom/CustomElementRegistry.h M Source/WebCore/dom/DocumentFontLoader.cpp M Source/WebCore/dom/DocumentFullscreen.cpp M Source/WebCore/dom/DocumentMarkerController.cpp M Source/WebCore/dom/DocumentType.cpp M Source/WebCore/dom/IdTargetObserverRegistry.h M Source/WebCore/dom/PendingScript.h M Source/WebCore/dom/ScriptedAnimationController.cpp M Source/WebCore/dom/ScriptedAnimationController.h M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/DictationCommand.cpp M Source/WebCore/editing/SplitTextNodeCommand.cpp M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/editing/VisibleUnits.cpp M Source/WebCore/history/CachedPage.cpp M Source/WebCore/html/SubmitInputType.cpp M Source/WebCore/html/parser/HTMLSrcsetParser.cpp M Source/WebCore/html/parser/HTMLSrcsetParser.h M Source/WebCore/html/shadow/SwitchThumbElement.cpp M Source/WebCore/html/shadow/SwitchTrackElement.cpp M Source/WebCore/html/track/AudioTrack.cpp M Source/WebCore/html/track/AudioTrackList.cpp M Source/WebCore/html/track/VideoTrack.cpp M Source/WebCore/html/track/VideoTrackList.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/platform/graphics/FontMetrics.h M Source/WebCore/rendering/LayoutRepainter.cpp M Source/WebCore/rendering/MarkedText.cpp M Source/WebCore/rendering/RenderReplaced.cpp M Source/WebCore/rendering/TextBoxPainter.cpp M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h Log Message: --- Non-unified build fixes, Halloween 2023 edition https://bugs.webkit.org/show_bug.cgi?id=263942 Unreviewed non-unified build fix. Run non-unified PlayStation Release build and add missing includes. * Source/WebCore/Modules/push-api/ServiceWorkerRegistrationPushAPI.cpp: * Source/WebCore/Modules/web-locks/WebLockRegistry.cpp: * Source/WebCore/accessibility/AccessibilityObject.cpp: * Source/WebCore/animation/AnimationEffect.cpp: * Source/WebCore/animation/AnimationEventBase.cpp: * Source/WebCore/animation/CustomEffect.cpp: * Source/WebCore/animation/ElementAnimationRareData.cpp: * Source/WebCore/animation/WebAnimationUtilities.cpp: * Source/WebCore/bindings/js/JSFileSystemEntryCustom.cpp: * Source/WebCore/bindings/js/JSFileSystemHandleCustom.cpp: * Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: * Source/WebCore/dom/CDATASection.cpp: * Source/WebCore/dom/ContentVisibilityDocumentState.cpp: * Source/WebCore/dom/CustomElementRegistry.h: * Source/WebCore/dom/DocumentFontLoader.cpp: * Source/WebCore/dom/DocumentFullscreen.cpp: * Source/WebCore/dom/DocumentMarkerController.cpp: * Source/WebCore/dom/DocumentType.cpp: * Source/WebCore/dom/IdTargetObserverRegistry.h: * Source/WebCore/dom/PendingScript.h: * Source/WebCore/dom/ScriptedAnimationController.cpp: * Source/WebCore/dom/ScriptedAnimationController.h: * Source/WebCore/editing/AlternativeTextController.cpp: * Source/WebCore/editing/DictationCommand.cpp: * Source/WebCore/editing/SplitTextNodeCommand.cpp: * Source/WebCore/editing/VisibleSelection.cpp: * Source/WebCore/editing/VisibleUnits.cpp: * Source/WebCore/history/CachedPage.cpp: * Source/WebCore/html/SubmitInputType.cpp: (WebCore::SubmitInputType::appendFormData const): * Source/WebCore/html/parser/HTMLSrcsetParser.cpp: * Source/WebCore/html/parser/HTMLSrcsetParser.h: * Source/WebCore/html/shadow/SwitchThumbElement.cpp: * Source/WebCore/html/shadow/SwitchTrackElement.cpp: * Source/WebCore/html/track/AudioTrack.cpp
[webkit-changes] [WebKit/WebKit] cc8f8d: Fix PS Release build following 269870@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc8f8dff0c37fc14a5256bd2aa68fe3ce6ca9624 https://github.com/WebKit/WebKit/commit/cc8f8dff0c37fc14a5256bd2aa68fe3ce6ca9624 Author: Ross Kirsling Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/SVGRenderSupport.cpp Log Message: --- Fix PS Release build following 269870@main https://bugs.webkit.org/show_bug.cgi?id=263863 Unreviewed build fix. * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: Add missing include. Canonical link: https://commits.webkit.org/269919@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0f246: Fix PlayStation build following 269870@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0f2468d88fd442489d4452f8177c36396aee5f7 https://github.com/WebKit/WebKit/commit/c0f2468d88fd442489d4452f8177c36396aee5f7 Author: Ross Kirsling Date: 2023-10-29 (Sun, 29 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h Log Message: --- Fix PlayStation build following 269870@main https://bugs.webkit.org/show_bug.cgi?id=263844 Unreviewed build fix. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h: Add missing include. Canonical link: https://commits.webkit.org/269905@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87241d: Cleanup #undefs in JSGlobalObject.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87241d542807a9d1c15a8cdd5e7a7db9f5968fae https://github.com/WebKit/WebKit/commit/87241d542807a9d1c15a8cdd5e7a7db9f5968fae Author: Ross Kirsling Date: 2023-10-27 (Fri, 27 Oct 2023) Changed paths: M Source/JavaScriptCore/runtime/JSGlobalObject.cpp Log Message: --- Cleanup #undefs in JSGlobalObject.cpp https://bugs.webkit.org/show_bug.cgi?id=263762 Reviewed by Keith Miller. 1. CREATE_PROTOTYPE_FOR_LAZY_TYPE has its #undef >600 lines later than expected; move it to its rightful location. 2. CREATE_WEBASSEMBLY_CONSTRUCTOR doesn't exist; we mean to be #undefing CREATE_WEBASSEMBLY_PROTOTYPE. * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Canonical link: https://commits.webkit.org/269868@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4adb95: Fix PlayStation build following 269639@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4adb95ac02378b7e298f1da271779af0df956d59 https://github.com/WebKit/WebKit/commit/4adb95ac02378b7e298f1da271779af0df956d59 Author: Ross Kirsling Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M Source/JavaScriptCore/runtime/SideDataRepository.h Log Message: --- Fix PlayStation build following 269639@main https://bugs.webkit.org/show_bug.cgi?id=263517 Unreviewed build fix. std::derived_from is a C++20 feature that's nearly the same as the C++11 feature std::is_base_of_v; since it shouldn't make a difference for this particular case, let's just make use of the latter. * Source/JavaScriptCore/runtime/SideDataRepository.h: (JSC::SideDataRepository::ensure): Use std::is_base_of_v instead of std::derived_from. Canonical link: https://commits.webkit.org/269645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00ee52: Update JSC stress tests to support ICU 74
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00ee523e133c96a5459ae343549700553140fb94 https://github.com/WebKit/WebKit/commit/00ee523e133c96a5459ae343549700553140fb94 Author: Ross Kirsling Date: 2023-10-18 (Wed, 18 Oct 2023) Changed paths: M JSTests/stress/array-toLocaleString.js M JSTests/stress/date-toLocaleString.js M JSTests/stress/intl-datetimeformat.js Log Message: --- Update JSC stress tests to support ICU 74 https://bugs.webkit.org/show_bug.cgi?id=263304 Reviewed by Yusuke Suzuki. There only seems to be one change we need to adapt for this release: Han decimal time display changed such that the hour 0 is now 〇 instead of 〇〇. * JSTests/stress/array-toLocaleString.js: * JSTests/stress/date-toLocaleString.js: * JSTests/stress/intl-datetimeformat.js: Canonical link: https://commits.webkit.org/269451@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d90f93: JSValue::isConstructor is misbehaving in clang-cl ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d90f93a1b1854997ec227981d2e661dcc75724ad
https://github.com/WebKit/WebKit/commit/d90f93a1b1854997ec227981d2e661dcc75724ad
Author: Ross Kirsling
Date: 2023-10-17 (Tue, 17 Oct 2023)
Changed paths:
M Source/cmake/OptionsMSVC.cmake
Log Message:
---
JSValue::isConstructor is misbehaving in clang-cl Release
https://bugs.webkit.org/show_bug.cgi?id=263240
Reviewed by Yusuke Suzuki.
Currently, either of the following throws a TypeError in the clang-cl Release
build:
```
Reflect.construct(function () {}, [], BigInt)
Reflect.construct(function () {}, [], Symbol)
```
The cause of this is the ICF (identical code folding) link-time optimization,
which makes it unsafe to pointer-compare different functions with identical
definitions.
In this particular case, constructBigIntConstructor and constructSymbol are
identical to callHostFunctionAsConstructor,
so when InternalFunction::getConstructData checks whether
`m_functionForConstruct == callHostFunctionAsConstructor`,
the result is erroneously true.
While this specific issue is only reproducing with clang-cl/lld-link and not
normal cl/link,
we have had such issues with cl/link in the past (see 248787@main), so let's
just disable ICF altogether.
* Source/cmake/OptionsMSVC.cmake:
Canonical link: https://commits.webkit.org/269405@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ff33a: REGRESSION(269388@main): Fix syntax error
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ff33a6265147124f2360e1f936ade9cec34176b https://github.com/WebKit/WebKit/commit/5ff33a6265147124f2360e1f936ade9cec34176b Author: Ross Kirsling Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: M Source/WebCore/dom/Document.cpp Log Message: --- REGRESSION(269388@main): Fix syntax error https://bugs.webkit.org/show_bug.cgi?id=263235 Unreviewed PlayStation build fix. * Source/WebCore/dom/Document.cpp: (WebCore::Document::createElementNS): Put #endif where it belongs. Canonical link: https://commits.webkit.org/269393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fd85f: Error message for `new Array(1.5)` is confusing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fd85f75915069dee692d60e04cdf9479708e273 https://github.com/WebKit/WebKit/commit/5fd85f75915069dee692d60e04cdf9479708e273 Author: Ross Kirsling Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M JSTests/ChakraCore/test/es5/exceptions3.baseline-jsc M JSTests/stress/tail-call-host-call-throw.js M LayoutTests/js/array-from-expected.txt M LayoutTests/js/dom/dfg-negative-array-size-expected.txt M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/runtime/ArrayConstructor.cpp M Source/JavaScriptCore/runtime/ArrayConstructor.h M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp Log Message: --- Error message for `new Array(1.5)` is confusing https://bugs.webkit.org/show_bug.cgi?id=262991 Reviewed by Keith Miller. Currently, `new Array(1.5)` gives the error "Array size is not a small enough positive integer", which is quite confusing since being "small enough" isn't the problem with 1.5 as an input. Let's update this to "Array length must be a positive integer of safe magnitude". * JSTests/ChakraCore/test/es5/exceptions3.baseline-jsc: * JSTests/stress/tail-call-host-call-throw.js: * LayoutTests/js/array-from-expected.txt: * LayoutTests/js/dom/dfg-negative-array-size-expected.txt: * Source/JavaScriptCore/dfg/DFGOperations.cpp: * Source/JavaScriptCore/runtime/ArrayConstructor.cpp: * Source/JavaScriptCore/runtime/ArrayConstructor.h: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: Canonical link: https://commits.webkit.org/269193@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0eeeaa: Fix PlayStation build after 269108@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0eeeaa4ec6363362e6c354d9dfcee88d4835bab9 https://github.com/WebKit/WebKit/commit/0eeeaa4ec6363362e6c354d9dfcee88d4835bab9 Author: Ross Kirsling Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Fix PlayStation build after 269108@main https://bugs.webkit.org/show_bug.cgi?id=262932 Unreviewed build fix. * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: Add missing include. Canonical link: https://commits.webkit.org/269125@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 042357: Fix PlayStation build following 269046@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04235733b7c07b6305a197085a2bc766e3628664 https://github.com/WebKit/WebKit/commit/04235733b7c07b6305a197085a2bc766e3628664 Author: Ross Kirsling Date: 2023-10-07 (Sat, 07 Oct 2023) Changed paths: M Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp Log Message: --- Fix PlayStation build following 269046@main https://bugs.webkit.org/show_bug.cgi?id=262855 Unreviewed build fix. * Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp: Add header removed from WebProcess.h. Canonical link: https://commits.webkit.org/269053@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c6bb2: Remove unused DatePrototype.js
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c6bb26eeb9651642a8393e0053add963e02718b https://github.com/WebKit/WebKit/commit/0c6bb26eeb9651642a8393e0053add963e02718b Author: Ross Kirsling Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: R Source/JavaScriptCore/builtins/DatePrototype.js Log Message: --- Remove unused DatePrototype.js https://bugs.webkit.org/show_bug.cgi?id=262517 Reviewed by Yusuke Suzuki. The commit message for 266868@main suggests that this file should have been removed, yet the file remains without any code content. Let's remove it. * Source/JavaScriptCore/builtins/DatePrototype.js: Removed. Canonical link: https://commits.webkit.org/268761@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] becdae: REGRESSION(268412@main): Fix !ENABLE(VARIATION_FON...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: becdaec721b244e0b7d2f3e57c856a4fb92369c4 https://github.com/WebKit/WebKit/commit/becdaec721b244e0b7d2f3e57c856a4fb92369c4 Author: Ross Kirsling Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M Source/WebCore/rendering/style/RenderStyle.cpp Log Message: --- REGRESSION(268412@main): Fix !ENABLE(VARIATION_FONTS) build https://bugs.webkit.org/show_bug.cgi?id=262091 Unreviewed PlayStation build fix. * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): Guard usage of CSSPropertyFontVariationSettings. Canonical link: https://commits.webkit.org/268428@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a6676: REGRESSION(268355@main): Broke PlayStation build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a667670104aafe0f8bc74daf0abf5eb8775ffdb https://github.com/WebKit/WebKit/commit/2a667670104aafe0f8bc74daf0abf5eb8775ffdb Author: Ross Kirsling Date: 2023-09-24 (Sun, 24 Sep 2023) Changed paths: M Source/WebCore/PlatformPlayStation.cmake Log Message: --- REGRESSION(268355@main): Broke PlayStation build https://bugs.webkit.org/show_bug.cgi?id=262026 Unreviewed build fix. * Source/WebCore/PlatformPlayStation.cmake: Revert change to file. It doesn't seem like this should have been part of that patch at all. Canonical link: https://commits.webkit.org/268387@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb59fe: Make explicit where WebAssembly actually depends o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb59fe503475013a28183568e48c35bfebc7b1b9 https://github.com/WebKit/WebKit/commit/fb59fe503475013a28183568e48c35bfebc7b1b9 Author: Ross Kirsling Date: 2023-09-19 (Tue, 19 Sep 2023) Changed paths: M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jit/JITExceptions.cpp M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/llint/LLIntData.h M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/wasm/WasmBinding.cpp M Source/JavaScriptCore/wasm/WasmBinding.h M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmEntryPlan.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmThunks.cpp M Source/JavaScriptCore/wasm/WasmThunks.h M Source/JavaScriptCore/wasm/js/JSToWasm.cpp M Source/JavaScriptCore/wasm/js/JSToWasm.h M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h M Source/JavaScriptCore/wasm/js/WasmToJS.cpp M Source/JavaScriptCore/wasm/js/WasmToJS.h M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h Log Message: --- Make explicit where WebAssembly actually depends on JIT https://bugs.webkit.org/show_bug.cgi?id=261458 Reviewed by Justin Michaud. As a step toward removing our WebAssembly implementation's JIT dependence, this patch makes it possible to build an ENABLE(WEBASSEMBLY) && !ENABLE(JIT) configuration. Such a build will of course encounter runtime issues, since this patch does not implement replacement functionality; however, it is still useful to clearly demarcate which code is dependent on JIT and thereby discontinue our assumption that ENABLE(WEBASSEMBLY) implies ENABLE(JIT). * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::CatchInfo::CatchInfo): * Source/JavaScriptCore/jit/JITExceptions.cpp: (JSC::genericUnwind): * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/llint/LLIntData.h: (JSC::LLInt::getCodePtr): (JSC::LLInt::getWide16CodePtr): (JSC::LLInt::getWide32CodePtr): (JSC::LLInt::getWide32CodeFunctionPtr): * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): * Source/JavaScriptCore/wasm/WasmBinding.cpp: * Source/JavaScriptCore/wasm/WasmBinding.h: * Source/JavaScriptCore/wasm/WasmCallee.cpp: (JSC::Wasm::Callee::runWithDowncast): * Source/JavaScriptCore/wasm/WasmCallee.h: * Source/JavaScriptCore/wasm/WasmEntryPlan.cpp: (JSC::Wasm::EntryPlan::prepare): * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): * Source/JavaScriptCore/wasm/WasmFormat.h: * Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp: (JSC::Wasm::IPIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmThunks.cpp: * Source/JavaScriptCore/wasm/WasmThunks.h: * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: * Source/JavaScriptCore/wasm/js/JSToWasm.h: * Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp: (JSC::JSWebAssemblyModule::createStub): (JSC::JSWebAssemblyModule::clearJSCallICs): (JSC::JSWebAssemblyModule::finalizeUnconditionally): * Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h: * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: * Source/JavaScriptCore/wasm/js/WasmToJS.h: * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h: Canonical link: https://commits.webkit.org/268172@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f93b5a: Fix !ENABLE(SERVICE_WORKER) build following 267251...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f93b5aa8b64c7938563d4ea8dd60066a66b4462e https://github.com/WebKit/WebKit/commit/f93b5aa8b64c7938563d4ea8dd60066a66b4462e Author: Ross Kirsling Date: 2023-08-25 (Fri, 25 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Modules/cookie-store/CookieStoreManager.cpp M Source/WebCore/Modules/cookie-store/CookieStoreManager.h M Source/WebCore/Modules/cookie-store/CookieStoreManager.idl M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.cpp M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.h M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.idl M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEventInit.h M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEventInit.idl M Source/WebCore/dom/EventNames.in Log Message: --- Fix !ENABLE(SERVICE_WORKER) build following 267251@main https://bugs.webkit.org/show_bug.cgi?id=260703 Unreviewed build fix. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/cookie-store/CookieStoreManager.cpp: * Source/WebCore/Modules/cookie-store/CookieStoreManager.h: * Source/WebCore/Modules/cookie-store/CookieStoreManager.idl: * Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.cpp: * Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.h: * Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.idl: * Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEventInit.h: * Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEventInit.idl: * Source/WebCore/dom/EventNames.in: Canonical link: https://commits.webkit.org/267269@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f29fc: Fix PlayStation build following 266368@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f29fc26239e2b130b4836fac7470ecb33c0f74e https://github.com/WebKit/WebKit/commit/1f29fc26239e2b130b4836fac7470ecb33c0f74e Author: Ross Kirsling Date: 2023-07-27 (Thu, 27 Jul 2023) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.cpp M Source/JavaScriptCore/llint/InPlaceInterpreter.h M Source/JavaScriptCore/runtime/InitializeThreading.cpp Log Message: --- Fix PlayStation build following 266368@main https://bugs.webkit.org/show_bug.cgi?id=259586 Unreviewed build fix. * Source/JavaScriptCore/llint/InPlaceInterpreter.cpp: * Source/JavaScriptCore/llint/InPlaceInterpreter.h: * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): IPInt is a wasm feature; it must be guarded by ENABLE(WEBASSEMBLY). Canonical link: https://commits.webkit.org/266378@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37352d: WASM sources should use more specific macros than ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37352d2348e7717a4de489470019968596806367 https://github.com/WebKit/WebKit/commit/37352d2348e7717a4de489470019968596806367 Author: Ross Kirsling Date: 2023-07-14 (Fri, 14 Jul 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp Log Message: --- WASM sources should use more specific macros than FINALIZE_CODE() https://bugs.webkit.org/show_bug.cgi?id=259208 Reviewed by Yusuke Suzuki. FINALIZE_WASM_CODE() and FINALIZE_WASM_CODE_FOR_MODE() exist, so we should use them instead of just FINALIZE_CODE(); otherwise, dumpWasmDisassembly is missing information that you'd expect it to have. * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): Canonical link: https://commits.webkit.org/266062@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 441ba4: Ensure validity of ENABLE(WEBASSEMBLY) without ENA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 441ba4d830a01083c3ec189832d9163697c9385d https://github.com/WebKit/WebKit/commit/441ba4d830a01083c3ec189832d9163697c9385d Author: Ross Kirsling Date: 2023-07-05 (Wed, 05 Jul 2023) Changed paths: M Source/JavaScriptCore/interpreter/StackVisitor.cpp M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.cpp Log Message: --- Ensure validity of ENABLE(WEBASSEMBLY) without ENABLE(WEBASSEMBLY_B3JIT) https://bugs.webkit.org/show_bug.cgi?id=258554 Reviewed by Justin Michaud. As a step toward having JITless WASM, we must ensure that the WASM build isn't secretly depending on B3. This patch corrects a few neglected locations. * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::readInlinableWasmFrame): * Source/JavaScriptCore/wasm/WasmCallee.cpp: * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseBody): (JSC::Wasm::FunctionParser::parseExpression): (JSC::Wasm::FunctionParser::parseUnreachableExpression): * Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.cpp: Canonical link: https://commits.webkit.org/265786@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa1a33: Fix PlayStation build following 265651@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa1a33ed1ca1ff3e4310a3d530a778903ef10d75 https://github.com/WebKit/WebKit/commit/aa1a33ed1ca1ff3e4310a3d530a778903ef10d75 Author: Ross Kirsling Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- Fix PlayStation build following 265651@main https://bugs.webkit.org/show_bug.cgi?id=258729 Unreviewed build fix. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: Move #if ENABLE(WEBASSEMBLY_BBQJIT) where it belongs. This isn't a new issue in 265651@main, but it means that non-WASM platforms have needed to load every header in this file. Canonical link: https://commits.webkit.org/265655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0d722: Fix !ENABLE(ACCESSIBILITY) build following 264911@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0d7223f7f316fa8ac48139e92b66b570860bf3c https://github.com/WebKit/WebKit/commit/a0d7223f7f316fa8ac48139e92b66b570860bf3c Author: Ross Kirsling Date: 2023-06-06 (Tue, 06 Jun 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 264911@main https://bugs.webkit.org/show_bug.cgi?id=257772 Unreviewed build fix. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onTextCompositionChange): (WebCore::AXObjectCache::textCompositionObjectForNode): Add missing stubs. Canonical link: https://commits.webkit.org/264917@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0dfd18: Fix !ENABLE(ACCESSIBILITY) build following 264852@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0dfd18e6886ab4b1237b1ca65d623823b530a150 https://github.com/WebKit/WebKit/commit/0dfd18e6886ab4b1237b1ca65d623823b530a150 Author: Ross Kirsling Date: 2023-06-04 (Sun, 04 Jun 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 264852@main https://bugs.webkit.org/show_bug.cgi?id=257688 Unreviewed build fix. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onPopoverTargetToggle): Add missing stub. Canonical link: https://commits.webkit.org/264855@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4811e2: Fix !ENABLE(ACCESSIBILITY) build following 264762@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4811e26fe93b914bdd64afd0f16173d0864dbe0d https://github.com/WebKit/WebKit/commit/4811e26fe93b914bdd64afd0f16173d0864dbe0d Author: Ross Kirsling Date: 2023-06-01 (Thu, 01 Jun 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 264762@main https://bugs.webkit.org/show_bug.cgi?id=257600 Unreviewed build fix. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onScrollbarFrameRectChange): Add missing stub. Canonical link: https://commits.webkit.org/264790@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ba277: Fix PS build following 264739@main (part 3)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ba277162b4680038b26fe2706eb914f61062362 https://github.com/WebKit/WebKit/commit/2ba277162b4680038b26fe2706eb914f61062362 Author: Ross Kirsling Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M Source/WebCore/Modules/highlight/HighlightRegister.cpp Log Message: --- Fix PS build following 264739@main (part 3) https://bugs.webkit.org/show_bug.cgi?id=257592 Unreviewed build fix. * Source/WebCore/Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::addAnnotationHighlightWithRange): Actually fix the root issue -- Ref could not be implicitly converted to reference_wrapper. Canonical link: https://commits.webkit.org/264780@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a4f4a: Fix PS build following 264739@main (part 2)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a4f4a579f1867d70b9f8cc533110c729ae03a09 https://github.com/WebKit/WebKit/commit/7a4f4a579f1867d70b9f8cc533110c729ae03a09 Author: Ross Kirsling Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M Source/WebCore/Modules/highlight/HighlightRegister.cpp Log Message: --- Fix PS build following 264739@main (part 2) https://bugs.webkit.org/show_bug.cgi?id=257587 Unreviewed build fix. * Source/WebCore/Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::addAnnotationHighlightWithRange): Add explicit parens so there is no confusion about the braces being an initializer_list. Canonical link: https://commits.webkit.org/264776@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0de6e3: Fix PS build following 264739@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0de6e36e1db7e181d3eccb00a704bd00f2f4f7f9 https://github.com/WebKit/WebKit/commit/0de6e36e1db7e181d3eccb00a704bd00f2f4f7f9 Author: Ross Kirsling Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M Source/WebCore/Modules/highlight/Highlight.h M Source/WebCore/Modules/highlight/HighlightRegister.cpp Log Message: --- Fix PS build following 264739@main https://bugs.webkit.org/show_bug.cgi?id=257586 Unreviewed build fix. * Source/WebCore/Modules/highlight/Highlight.h: * Source/WebCore/Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::addAnnotationHighlightWithRange): Make type conversion explicit. Canonical link: https://commits.webkit.org/264774@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3dd065: REGRESSION(263796@main): C++20 is not needed in or...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3dd065753ef71af08141959e6508c473514cf3cb https://github.com/WebKit/WebKit/commit/3dd065753ef71af08141959e6508c473514cf3cb Author: Ross Kirsling Date: 2023-05-09 (Tue, 09 May 2023) Changed paths: M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp Log Message: --- REGRESSION(263796@main): C++20 is not needed in order to have a pi constant https://bugs.webkit.org/show_bug.cgi?id=256512 Unreviewed PlayStation build fix. * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::rotate): * Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp: We already have `piFloat` at home. Canonical link: https://commits.webkit.org/263856@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b5ad5: Fix !ENABLE(ACCESSIBILITY) build following 263771@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b5ad581d8e8d3faa17b44c3e09cbbb5e8ffd1fb https://github.com/WebKit/WebKit/commit/3b5ad581d8e8d3faa17b44c3e09cbbb5e8ffd1fb Author: Ross Kirsling Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 263771@main https://bugs.webkit.org/show_bug.cgi?id=256510 Unreviewed build fix. Stubs for onPaint were both redundant and invalid (missing const). * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onPaint): Deleted. Canonical link: https://commits.webkit.org/263853@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72712b: REGRESSION(263719@main): KeyframeList.h depends on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72712be1177bac5d22a9c14926f9f37ccb5ab538 https://github.com/WebKit/WebKit/commit/72712be1177bac5d22a9c14926f9f37ccb5ab538 Author: Ross Kirsling Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/WebCore/rendering/style/KeyframeList.h Log Message: --- REGRESSION(263719@main): KeyframeList.h depends on RenderStyle.h https://bugs.webkit.org/show_bug.cgi?id=256447 Unreviewed PlayStation (or non-unified) build fix. * Source/WebCore/rendering/style/KeyframeList.h: Upgrade forward decl to include. Canonical link: https://commits.webkit.org/263785@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5a91e: [JSC] Implement ctiMasmProbeTrampolineSIMD for MSVC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5a91e8e40a684cd9fe7694da3ba16b75a2470a9 https://github.com/WebKit/WebKit/commit/b5a91e8e40a684cd9fe7694da3ba16b75a2470a9 Author: Ross Kirsling Date: 2023-04-24 (Mon, 24 Apr 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp M Source/JavaScriptCore/jit/JITStubsMSVC64.asm Log Message: --- [JSC] Implement ctiMasmProbeTrampolineSIMD for MSVC https://bugs.webkit.org/show_bug.cgi?id=255856 Reviewed by Yusuke Suzuki. 258282@main implemented ctiMasmProbeTrampolineSIMD for non-MSVC x86_64, this patch implements the MSVC version. (As with non-MSVC, this is identical to ctiMasmProbeTrampoline except for the use of vmovaps.) Without this, testProbeModifiesStackPointerToInsideProbeStateOnStack fails in testmasm. (The size of Probe::State increased with the addition of fprs.vectors, but the position on the stack did not change, meaning that the last iteration(s) would try to move the stack pointer in a *positive* direction.) * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp: (JSC::MacroAssembler::probe): * Source/JavaScriptCore/jit/JITStubsMSVC64.asm: Canonical link: https://commits.webkit.org/263301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59c22d: [JSC] MSVC miscompiles PropertyCatchalls_setProper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59c22d8e9fd410926949b88437b0eb7a46cdce49 https://github.com/WebKit/WebKit/commit/59c22d8e9fd410926949b88437b0eb7a46cdce49 Author: Ross Kirsling Date: 2023-04-12 (Wed, 12 Apr 2023) Changed paths: M Source/JavaScriptCore/API/tests/testapi.c Log Message: --- [JSC] MSVC miscompiles PropertyCatchalls_setProperty in testapi.c https://bugs.webkit.org/show_bug.cgi?id=255331 Reviewed by Mark Lam. Windows fails testapi.c in release mode with "PropertyCatchalls.x should be 4 but instead is 3". MSVC seems to be doing some invalid inlining of the static local `count` variable, yet somehow changing the code in almost any way fixes the issue. In particular, we can even *simplify* the relevant code! * Source/JavaScriptCore/API/tests/testapi.c: (PropertyCatchalls_setProperty): Canonical link: https://commits.webkit.org/262899@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 896719: Unreviewed Win JSC stress test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8967198542ca09f82f5d4f2d32afc74a6224fb39 https://github.com/WebKit/WebKit/commit/8967198542ca09f82f5d4f2d32afc74a6224fb39 Author: Ross Kirsling Date: 2023-04-11 (Tue, 11 Apr 2023) Changed paths: M JSTests/stress/ensure-crash.js M JSTests/stress/regexp-testinline-stacklimits.js Log Message: --- Unreviewed Win JSC stress test gardening https://bugs.webkit.org/show_bug.cgi?id=255274 Unreviewed, skip two tests on Windows. * JSTests/stress/ensure-crash.js: Depends on Unix signal handlers. * JSTests/stress/regexp-testinline-stacklimits.js: The RangeError that occurs on Win is OOM, not stack overflow. Canonical link: https://commits.webkit.org/262816@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 226c80: Speculative fix for PS Release build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 226c809b2e6b2461435b10075fdd24410dce2cea https://github.com/WebKit/WebKit/commit/226c809b2e6b2461435b10075fdd24410dce2cea Author: Ross Kirsling Date: 2023-04-10 (Mon, 10 Apr 2023) Changed paths: M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_implementation.py M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_implementation.py M Source/WebCore/bindings/js/JSDOMGlobalObjectInlines.h Log Message: --- Speculative fix for PS Release build https://bugs.webkit.org/show_bug.cgi?id=255217 Unreviewed build fix. Following 262755@main, PS Release yet again has a linking error like: Link : error: L0039: reference to undefined symbol `JSC::JSObject::didBecomePrototype()' This happens in WebCoreJSBuiltins.cpp when new IDL is added and...that's literally all we ever know, but the fix is generally to upgrade StructureInlines.h to JSObjectInlines.h *somewhere*. It is clear that 260052@main was not aggressive enough in upgrading the includes in the builtins generator scripts, so let's go further this time. * Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_implementation.py: * Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py: * Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_implementation.py: * Source/WebCore/bindings/js/JSDOMGlobalObjectInlines.h: Canonical link: https://commits.webkit.org/262765@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 512db9: [JSC] Watchdog calls valid timers "stale" on Windows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 512db9a6900b400f9ce93e90e6e178fa74fef03e https://github.com/WebKit/WebKit/commit/512db9a6900b400f9ce93e90e6e178fa74fef03e Author: Ross Kirsling Date: 2023-04-06 (Thu, 06 Apr 2023) Changed paths: M Source/JavaScriptCore/runtime/Watchdog.cpp Log Message: --- [JSC] Watchdog calls valid timers "stale" on Windows https://bugs.webkit.org/show_bug.cgi?id=255135 Reviewed by Mark Lam. The following tests tend to time out on Win JSC: - stress/bounds-checking-in-cold-loop.js - stress/call-link-info-osrexit-repatch.js - stress/call-varargs-inlining-should-not-clobber-previous-to-free-register.js - stress/ftl-ai-filter-phantoms-should-clear-clear-value.js - stress/ftl-entry-osr-exit-has-nullptr-node.js - stress/has-indexed-property-with-worsening-array-mode.js - stress/polling-based-trap-on-unlinked-dfg.js - stress/reduce-loop-strength-multiple-exits.js - stress/regress-189227-watchdog-on-infinite-loop.js - stress/suppress-TerminationException-in-operationGetPrivateNameOptimize.js The cause is that Watchdog::shouldTerminate fires as much as 15ms prior to m_deadline, so one simple solution is to add a 20ms epsilon value when comparing "now" against the deadline. Technically, we wouldn't need to platform-restrict this value -- after all, the early out appears more concerned with "when m_deadline is infinity" than "when we're a little early" -- but then, the issue only seems to occur on Windows. * Source/JavaScriptCore/runtime/Watchdog.cpp: (JSC::Watchdog::shouldTerminate): Canonical link: https://commits.webkit.org/262701@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d31d84: Ensure Win JSC can run complex.yaml tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d31d8491766b5f7149b5a3594eb4ce48b7fe0229 https://github.com/WebKit/WebKit/commit/d31d8491766b5f7149b5a3594eb4ce48b7fe0229 Author: Ross Kirsling Date: 2023-04-06 (Thu, 06 Apr 2023) Changed paths: M JSTests/complex.yaml M Source/JavaScriptCore/jsc.cpp Log Message: --- Ensure Win JSC can run complex.yaml tests https://bugs.webkit.org/show_bug.cgi?id=255078 Reviewed by Yusuke Suzuki. Making this test suite work on Windows boils down to fixing two problems: 1. The tests which don't set env vars are passing an empty string, but in Ruby, this is appended to a list ($envVars), meaning that we end up trying to set a env var with key "". Use nil instead. 2. On Windows, TZ isn't a magic env var, so: a. Have jsc.cpp call setTimeZoneOverride instead. b. Skip temporal-now-timezone-with-broken-tz.js. (Obviously we could call setTimeZoneOverride with "UTC" if (a) fails, but it would serve no purpose, as this behavior has nothing to do with Temporal.) * JSTests/complex.yaml: * Source/JavaScriptCore/jsc.cpp: Canonical link: https://commits.webkit.org/262659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d6a1d: [JSC] strcat-bigint-oom.js should only run on WASM...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d6a1d456583be02e81476582bb9eaf5ee944f2d https://github.com/WebKit/WebKit/commit/7d6a1d456583be02e81476582bb9eaf5ee944f2d Author: Ross Kirsling Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M JSTests/stress/strcat-bigint-oom.js Log Message: --- [JSC] strcat-bigint-oom.js should only run on WASM platforms https://bugs.webkit.org/show_bug.cgi?id=255074 Reviewed by Yusuke Suzuki. * JSTests/stress/strcat-bigint-oom.js: Guard test file with $isWasmPlatform. Canonical link: https://commits.webkit.org/262651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45b46f: Unreviewed gardening for ChakraCore tests on Win JSC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45b46fd412b4ed1555bb417fdc1f556bb2b16df8 https://github.com/WebKit/WebKit/commit/45b46fd412b4ed1555bb417fdc1f556bb2b16df8 Author: Ross Kirsling Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M JSTests/ChakraCore.yaml A JSTests/ChakraCore/test/es5/hasItem.baseline-jsc-windows Log Message: --- Unreviewed gardening for ChakraCore tests on Win JSC https://bugs.webkit.org/show_bug.cgi?id=255019 Renable various tests and add a Win-specific expectation. (The latter wouldn't be necessary if we could easily `diff -a` against the existing JSC baseline, but adding a platform-specific expectation seems less complicated. It's weird that the test is using binary output anyway.) * JSTests/ChakraCore.yaml: * JSTests/ChakraCore/test/es5/hasItem.baseline-jsc-windows: Added. Canonical link: https://commits.webkit.org/262611@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22b883: Unreviewed, address Darin's feedback on #12098
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22b88331dc8d3bc70bd992d209bd7352182af7ad https://github.com/WebKit/WebKit/commit/22b88331dc8d3bc70bd992d209bd7352182af7ad Author: Ross Kirsling Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M Source/JavaScriptCore/runtime/TemporalObject.cpp Log Message: --- Unreviewed, address Darin's feedback on #12098 https://bugs.webkit.org/show_bug.cgi?id=255014 Requested update for 262273@main. * Source/JavaScriptCore/runtime/TemporalObject.cpp: (JSC::extractDifferenceOptions): constexpr was removed but let's still use const. Canonical link: https://commits.webkit.org/262606@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45c07e: [JSC] Intl tests should support ICU 72 / CLDR 42
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45c07eac52a534b1d50c0ef6cd60f43b0df4da8a https://github.com/WebKit/WebKit/commit/45c07eac52a534b1d50c0ef6cd60f43b0df4da8a Author: Ross Kirsling Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M JSTests/stress/intl-displaynames.js M JSTests/stress/intl-numberformat-unified.js M JSTests/stress/intl-relativetimeformat.js Log Message: --- [JSC] Intl tests should support ICU 72 / CLDR 42 https://bugs.webkit.org/show_bug.cgi?id=254904 Reviewed by Yusuke Suzuki. A few of our Intl tests have different results with the latest CLDR data, so let's update them accordingly. * JSTests/stress/intl-displaynames.js: * JSTests/stress/intl-numberformat-unified.js: * JSTests/stress/intl-relativetimeformat.js: Canonical link: https://commits.webkit.org/262604@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b45992: Unreviewed, fix !ENABLE(ACCESSIBILITY) build follo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b459920528a607cfba5a57f126097546ff47628b https://github.com/WebKit/WebKit/commit/b459920528a607cfba5a57f126097546ff47628b Author: Ross Kirsling Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- Unreviewed, fix !ENABLE(ACCESSIBILITY) build following 262566@main https://bugs.webkit.org/show_bug.cgi?id=254977 Unreviewed PlayStation build fix. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::updateRelations): Add missing function definition. Canonical link: https://commits.webkit.org/262570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 516d70: wasm/stress/timer-exception.js should not run on n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 516d70dbb289cb5e73f59ddaa8605f54734b947f https://github.com/WebKit/WebKit/commit/516d70dbb289cb5e73f59ddaa8605f54734b947f Author: Ross Kirsling Date: 2023-04-03 (Mon, 03 Apr 2023) Changed paths: M JSTests/wasm/stress/timer-exception.js Log Message: --- wasm/stress/timer-exception.js should not run on non-WASM platforms https://bugs.webkit.org/show_bug.cgi?id=254908 Reviewed by Yusuke Suzuki. `runDefault` is not appropriate for WASM tests. * JSTests/wasm/stress/timer-exception.js: Canonical link: https://commits.webkit.org/262549@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd452a: Unreviewed, fix PlayStation build after 262488@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd452a4fb465833ed5a95827102143f36bf58aa3 https://github.com/WebKit/WebKit/commit/dd452a4fb465833ed5a95827102143f36bf58aa3 Author: Ross Kirsling Date: 2023-04-02 (Sun, 02 Apr 2023) Changed paths: M Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp M Source/WebKit/UIProcess/API/C/playstation/WKView.cpp M Source/WebKit/UIProcess/playstation/PageClientImpl.cpp M Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp Log Message: --- Unreviewed, fix PlayStation build after 262488@main https://bugs.webkit.org/show_bug.cgi?id=254895 The refactor in 262488@main incurred lots of missing includes in platform-specific files; hopefully this is all of them. * Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp: * Source/WebKit/UIProcess/API/C/playstation/WKView.cpp: * Source/WebKit/UIProcess/playstation/PageClientImpl.cpp: * Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp: Canonical link: https://commits.webkit.org/262497@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42f059: jsc.exe is unable to dump exception output to a file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42f05910565f4a78ddf4e19a548c3600ae5544c5 https://github.com/WebKit/WebKit/commit/42f05910565f4a78ddf4e19a548c3600ae5544c5 Author: Ross Kirsling Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- jsc.exe is unable to dump exception output to a file https://bugs.webkit.org/show_bug.cgi?id=254799 Reviewed by Keith Miller. Currently, Win JSC fails various ChakraCore tests due to diff failures. The crux of the issue is that this works: ``` > .\WebKitBuild\Debug\bin64\jsc.exe .\JSTests\ChakraCore\test\jsc-lib.js > .\JSTests\ChakraCore\test\Basics\bug650104.js name: push -288556213674691number undefined Exception: TypeError: Number().push is not a function. (In 'Number().push()', 'Number().push' is undefined) global code@.\JSTests\ChakraCore\test\Basics\bug650104.js:18:14 ``` But if we add `> out.txt` to the end, the file contains just the first two lines and lacks the dumped exception. The fix is simply to flush before exiting. * Source/JavaScriptCore/jsc.cpp: (dumpException): Canonical link: https://commits.webkit.org/262402@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1490a5: [JSC] Fix Win crash in Temporal since/until methods
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1490a5c2a806d767de0b4e2dd113a35053467eea
https://github.com/WebKit/WebKit/commit/1490a5c2a806d767de0b4e2dd113a35053467eea
Author: Ross Kirsling
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M Source/JavaScriptCore/runtime/TemporalObject.cpp
Log Message:
---
[JSC] Fix Win crash in Temporal since/until methods
https://bugs.webkit.org/show_bug.cgi?id=254650
Reviewed by Mark Lam.
Without a JSC testbot for Windows, we hadn't noticed that Temporal.{PlainDate,
PlainTime}#{since, until} can crash.
The crux of the issue seems to be in having a static constexpr
std::initializer_list array,
but this can just be a static local anyway.
* Source/JavaScriptCore/runtime/TemporalObject.cpp:
(JSC::extractDifferenceOptions):
Canonical link: https://commits.webkit.org/262273@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29a107: Re-enable new Set methods following confirmation o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29a10740cf9d9d7653a729b9767480a3146cabcf https://github.com/WebKit/WebKit/commit/29a10740cf9d9d7653a729b9767480a3146cabcf Author: Ross Kirsling Date: 2023-03-22 (Wed, 22 Mar 2023) Changed paths: M JSTests/stress/set-prototype-intersection.js M LayoutTests/js/Object-getOwnPropertyNames-expected.txt M LayoutTests/js/script-tests/Object-getOwnPropertyNames.js M Source/JavaScriptCore/builtins/SetPrototype.js M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- Re-enable new Set methods following confirmation of intersection algorithm https://bugs.webkit.org/show_bug.cgi?id=254249 Reviewed by Yusuke Suzuki. The TC39 Set Methods proposal had been blocked pending a final decision on the algorithm for Set.prototype.intersection, but it was decided in today's plenary to simply not sort the output in the case where we iterate over the parameter set. This is our existing behavior, so https://webkit.org/b/251869 becomes unnecessary and we can just go with what we have. * JSTests/stress/set-prototype-intersection.js: Add a couple of tests to demonstrate commutativity. * LayoutTests/js/Object-getOwnPropertyNames-expected.txt: * LayoutTests/js/script-tests/Object-getOwnPropertyNames.js: Update expectations. * Source/JavaScriptCore/builtins/SetPrototype.js: * Source/JavaScriptCore/runtime/OptionsList.h: Remove FIXMEs and flip runtime option. Canonical link: https://commits.webkit.org/261946@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b67c50: Remove outdated MSVC guard in CRASH_WITH_INFO
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b67c507f2e03c783e3ecec660f663b95e1105703 https://github.com/WebKit/WebKit/commit/b67c507f2e03c783e3ecec660f663b95e1105703 Author: Ross Kirsling Date: 2023-03-08 (Wed, 08 Mar 2023) Changed paths: M Source/WTF/wtf/Assertions.h Log Message: --- Remove outdated MSVC guard in CRASH_WITH_INFO https://bugs.webkit.org/show_bug.cgi?id=253619 Reviewed by Fujii Hironori. * Source/WTF/wtf/Assertions.h: MSVC 2022 is perfectly happy with VA_OPT, so we no longer need this #if to be MSVC-specific; on the other hand, the broader check was added for older clang versions, so we probably still need that. Canonical link: https://commits.webkit.org/261407@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f105d6: Fix PlayStation build after 261239@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f105d6117bd798d28c016d2f2a639e693afbeefa https://github.com/WebKit/WebKit/commit/f105d6117bd798d28c016d2f2a639e693afbeefa Author: Ross Kirsling Date: 2023-03-05 (Sun, 05 Mar 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- Fix PlayStation build after 261239@main https://bugs.webkit.org/show_bug.cgi?id=253406 Unreviewed build fix. * Source/cmake/OptionsPlayStation.cmake: Ensure HAVE_STD_SPAN is always set before we reach PlatformHave.h. Canonical link: https://commits.webkit.org/261243@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b65a28: Update test262 (2023.03.01)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b65a280c93b26af9be97e76b54fe1df20b846433 https://github.com/WebKit/WebKit/commit/b65a280c93b26af9be97e76b54fe1df20b846433 Author: Ross Kirsling Date: 2023-03-01 (Wed, 01 Mar 2023) Changed paths: M JSTests/test262/config.yaml M JSTests/test262/expectations.yaml A JSTests/test262/harness/asyncHelpers.js M JSTests/test262/harness/isConstructor.js M JSTests/test262/harness/temporalHelpers.js M JSTests/test262/latest-changes-summary.txt A JSTests/test262/test/built-ins/Array/fromAsync/builtin.js A JSTests/test262/test/built-ins/Array/fromAsync/length.js A JSTests/test262/test/built-ins/Array/fromAsync/name.js A JSTests/test262/test/built-ins/Array/fromAsync/not-a-constructor.js A JSTests/test262/test/built-ins/Array/fromAsync/prop-desc.js A JSTests/test262/test/built-ins/Array/prototype/findLast/maximum-index.js A JSTests/test262/test/built-ins/Array/prototype/findLastIndex/maximum-index.js A JSTests/test262/test/built-ins/Array/prototype/toLocaleString/invoke-element-tolocalestring.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/detached-buffer-resizable.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/detached-buffer.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/invoked-as-accessor.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/invoked-as-func.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/length.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/name.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/prop-desc.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/this-has-no-arraybufferdata-internal.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/this-is-not-object.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer-resizable.js A JSTests/test262/test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/descriptor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/extensible.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-larger.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-same.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-smaller.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-zero.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-larger.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-same.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-smaller.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-zero.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/length.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/name.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/new-length-excessive.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/new-length-non-number.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/nonconstructor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/this-is-detached.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/this-is-not-arraybuffer-object.js M JSTests/test262/test/built-ins/AsyncFromSyncIteratorPrototype/next/absent-value-not-passed.js M JSTests/test262/test/built-ins/AsyncFromSyncIteratorPrototype/return/absent-value-not-passed.js M JSTests/test262/test/built-ins/AsyncFromSyncIteratorPrototype/return/return-null.js M JSTests/test262/test/built-ins/AsyncGeneratorPrototype/next/request-queue-await-order.js M JSTests/test262/test/built-ins/Atomics/waitAsync/bigint/good-views.js M JSTests/test262/test/built-ins/Atomics/waitAsync/good-views.js M JSTests/test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/not-a-constructor.js M JSTests/test262/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls-argument.js M JSTests/test262/test/built-ins/String/prototype/isWellFormed/prop-desc.js A JSTests/test262/test/built-ins/String/prototype/isWellFormed/to-string-primitive.js M JSTests/test262/test/built-ins/String/prototype/toWellFormed/prop-desc.js A JSTests/test262/test/built-ins/String/prototype/toWellFormed/to-string-primitive.js M JSTests/test262/test/built-ins/Temporal/Calendar/from/calendar-temporal-object.js R JSTests/test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-calendar-fields-undefined.js M
[webkit-changes] [WebKit/WebKit] d0ee61: [JSC] Implement Set.prototype.difference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0ee6166ed77e30df02233eb175d02a9db59a117 https://github.com/WebKit/WebKit/commit/d0ee6166ed77e30df02233eb175d02a9db59a117 Author: Ross Kirsling Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A JSTests/stress/set-prototype-difference.js M Source/JavaScriptCore/builtins/SetPrototype.js M Source/JavaScriptCore/runtime/SetPrototype.cpp Log Message: --- [JSC] Implement Set.prototype.difference https://bugs.webkit.org/show_bug.cgi?id=253060 Reviewed by Keith Miller. 260033@main implemented six of seven methods in the Stage 3 proposal https://github.com/tc39/proposal-set-methods; this PR implements the last one, Set.prototype.difference. * JSTests/stress/set-prototype-difference.js: Added. * Source/JavaScriptCore/builtins/SetPrototype.js: * Source/JavaScriptCore/runtime/SetPrototype.cpp: (JSC::SetPrototype::finishCreation): Canonical link: https://commits.webkit.org/260942@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce6284: REGRESSION(260641@main): Fix PlayStation build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce6284d859829d6da4fb3d0a715e2a0fbefbcf14 https://github.com/WebKit/WebKit/commit/ce6284d859829d6da4fb3d0a715e2a0fbefbcf14 Author: Ross Kirsling Date: 2023-02-21 (Tue, 21 Feb 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h Log Message: --- REGRESSION(260641@main): Fix PlayStation build https://bugs.webkit.org/show_bug.cgi?id=252718 Unreviewed PlayStation build fix. * Source/WTF/wtf/PlatformEnable.h: Ensure PlayStation keeps using ENABLE_OPENTYPE_MATH. Canonical link: https://commits.webkit.org/260652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
