[webkit-dev] Troubles with Anonymous Blocks

2010-02-08 Thread Alex Milowski
I've been struggling with odd issues with anonymous blocks that I don't quite understand. For example, to build a fraction in MathML I wrap the numerator and denominator in an anonymous block: RenderBlock* row = new (renderArena()) RenderBlock(document()); I then set border, padding, and

[webkit-dev] http://webkit.org/pending-commit

2010-02-08 Thread Eric Seidel
In an effort to clean out the list of to-be-committed patches (http://webkit.org/pending-commit) I wrote a small command for webkit-patch to clear r+ flags on obsolete attachments and ran it this afternoon. My apologies to those of you who received a bunch of bug mail as a result. I tried for a

[webkit-dev] Buildbot Emails

2010-02-08 Thread Eric Seidel
Historically build.webkit.org would email people when their changes broke the tree. This was disabled some time ago. I would very much like to see it re-enabled. Could someone point me as to how that would happen (I'm happy to code up a patch), or flip the magical switch themselves? -eric

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Maciej Stachowiak
On Feb 8, 2010, at 4:45 PM, Eric Seidel wrote: Historically build.webkit.org would email people when their changes broke the tree. This was disabled some time ago. I would very much like to see it re-enabled. Could someone point me as to how that would happen (I'm happy to code up a

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Dimitri Glazkov
Do you guys think it may be a good idea to bring the concept of tree closure to WebKit? :DG On Mon, Feb 8, 2010 at 5:29 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 8, 2010, at 4:45 PM, Eric Seidel wrote: Historically build.webkit.org would email people when their changes broke the

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Maciej Stachowiak
On Feb 8, 2010, at 5:33 PM, Dimitri Glazkov wrote: Do you guys think it may be a good idea to bring the concept of tree closure to WebKit? I'd like to start with more active broadcast notification of build breaks and see if we think we need more changes from there. I prefer to try

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Timothy Hatcher
On Feb 8, 2010, at 5:29 PM, Maciej Stachowiak wrote: That could be either webkit-dev or a new list. Maybe some won't want the spam but I bet a lot of people would like to find out about every build break. Please make it a new opt-in list. — Timothy Hatcher

[webkit-dev] Buildbot early exit

2010-02-08 Thread Nikolas Zimmermann
Good morning crowd, can anyone explain the --exit-after-n-failures=20 default behaviour for the build bots? Background: Today I had to update a lot of SVG *expected.txt files including all platform specific variations (in LayoutTests/platform/gtk/qt/win/mac- *). I landed my patch with

Re: [webkit-dev] Buildbot early exit

2010-02-08 Thread Adam Barth
We've had cases of a patch destroying the buildbots by rampaging through thousands of test failures. The 20 limit is a fail-stop to keep the bots rolling. I agree that try servers would be a better way to handle this case than lighting the buildbot on fire. I'd like to extend the EWS to run

[webkit-dev] MathML Update: Recent Progress

2010-02-08 Thread Alex Milowski
I've just added support for mfrac (fractions) as a separate patch. I've also updated the monster patch with all the latest code against the trunk. You can get this from: https://bugs.webkit.org/show_bug.cgi?id=33703 There are a number of individual patches that need review:

Re: [webkit-dev] Troubles with Anonymous Blocks

2010-02-08 Thread Roland Steiner
Just a stab in the dark here, and without knowledge about recent changes that could have caused your code to break (so this could be wildly off). The difference between the 2 versions AFAICT is whether m_isAnonymous is set or not, which leads me to the question: have you properly overridden