On Sun, Jan 30, 2011 at 4:41 PM, Ryan Leavengood leaveng...@gmail.comwrote:
Maybe the solution here is better documentation outside the source
code. I hope some of the more experienced WebKit developers can agree
that there are parts of the code that are harder for new developers to
dig into.
31.01.2011, 03:41, Ryan Leavengood leaveng...@gmail.com:
Maybe the solution here is better documentation outside the source
code. I hope some of the more experienced WebKit developers can agree
that there are parts of the code that are harder for new developers to
dig into. Some high-level
On Fri, Jan 28, 2011 at 10:21 AM, Peter Kasting pkast...@google.com wrote:
On Fri, Jan 28, 2011 at 10:14 AM, Alexey Proskuryakov a...@webkit.orgwrote:
Do you have any specific mechanism in mind for keeping global comments
accurate?
No more than I have for keeping API usage or function
31.01.2011, 11:47, Ryosuke Niwa rn...@webkit.org:
How can we ensure that all comments are up to do date? For example, suppose
function A calls B, and B calls C. Then in the call site of A, I comment
Because A does X, we do Y. Now suppose for the moment that the behavior X
of A is
2011/1/31 Konstantin Tokarev annu...@yandex.ru
You can document A as function calling B, B as function calling C, and keep
documentation of C up to date when it's behavior changes
I don't see how that can substitute my comment that Because A does X, do
Y. Saying do Y because we call A isn't
On Fri, Jan 28, 2011 at 5:29 PM, Joe Mason jma...@rim.com wrote:
I’m not clear from your question what you’re trying to do. If you’re just
trying to write an app using the Qt port of WebKit, you should ask on
webkit-h...@lists.webkit.org. This list is only for developing WebKit
itself.
I'm trying to understand how float 'inf' values are used in WebKit
rendering.
I'm particularly interested in a case where a very large coordinate for a
rect, which gets converted to 'inf' since its true value is too large to fit
in a float, is retained. The value of 'inf' can't really be used for
On Sun, Jan 30, 2011 at 4:47 PM, Maciej Stachowiak m...@apple.com wrote:
Well, I didn't mean to pick on the authors of this file. This is the
impression I get from a lot of code that some call well-commented, by
which they mean lots of comments.
I agree that the comments you pointed out are
Hi all-
We'd like to switch Apple's Windows WebKit port to build with Visual Studio
2010 sometime in the next 6-8 months, and to drop support for building with
Visual Studio 2005 at the same time.
The biggest consequence of this will be that anyone wishing to build Apple's
Windows port will
On Mon, Jan 31, 2011 at 12:30 PM, Adam Roben aro...@apple.com wrote:
Please let me (and the list) know if this change will cause you trouble,
and if there's something we can do to make the transition easier.
This may make life hard on Chromium as right now we don't support building
with
On Jan 31, 2011, at 3:41 PM, Peter Kasting wrote:
On Mon, Jan 31, 2011 at 12:30 PM, Adam Roben aro...@apple.com wrote:
Please let me (and the list) know if this change will cause you trouble, and
if there's something we can do to make the transition easier.
This may make life hard on
On Jan 31, 2011, at 11:01 AM, Peter Kasting wrote:
On Sun, Jan 30, 2011 at 4:47 PM, Maciej Stachowiak m...@apple.com wrote:
Well, I didn't mean to pick on the authors of this file. This is the
impression I get from a lot of code that some call well-commented, by which
they mean lots of
On Mon, Jan 31, 2011 at 12:47 PM, Maciej Stachowiak m...@apple.com wrote:
On Jan 31, 2011, at 11:01 AM, Peter Kasting wrote:
I think people who favor comments tend to produce a lot of exactly this
kind of comment. Except in some cases its verbose multiline comments that
exceed the number of
On Mon, Jan 31, 2011 at 12:47 AM, Ryosuke Niwa rn...@webkit.org wrote:
How can we ensure that all comments are up to do date? For example, suppose
function A calls B, and B calls C. Then in the call site of A, I comment
Because A does X, we do Y. Now suppose for the moment that the behavior
On Mon, Jan 31, 2011 at 4:54 PM, Aaron Boodman a...@chromium.org wrote:
It seems like the one line patch to C just broke A. It had a
dependency on the behavior of C that was worth documenting. Now you
have changed C and the behavior of A is probably wrong (or at least
wasteful).
Not
Hi,
We have recently noticed a patch to implement the device element in
WebKit. Since this is an important new feature, I thought we should have a
discussion about the best way to implement it. Here's the actual
specification for it:
On Mon, Jan 31, 2011 at 5:23 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Jan 31, 2011 at 4:54 PM, Aaron Boodman a...@chromium.org wrote:
It seems like the one line patch to C just broke A. It had a
dependency on the behavior of C that was worth documenting. Now you
have changed C and the
How hard will the transition be? If it's going to take a lot of time and
cause a lot of churn anyway, would this be a good time to try and make that
port use GYP or CMake? (I assume the answer is probably no, but figured it
was worth asking anyway. :-)
J
On Mon, Jan 31, 2011 at 12:46 PM, Adam
On Jan 31, 2011, at 1:06 PM, Peter Kasting wrote:
On Mon, Jan 31, 2011 at 12:47 PM, Maciej Stachowiak m...@apple.com wrote:
On Jan 31, 2011, at 11:01 AM, Peter Kasting wrote:
I think people who favor comments tend to produce a lot of exactly this kind
of comment. Except in some cases its
On Jan 31, 2011, at 5:48 PM, Aaron Boodman wrote:
On Mon, Jan 31, 2011 at 5:23 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Jan 31, 2011 at 4:54 PM, Aaron Boodman a...@chromium.org wrote:
It seems like the one line patch to C just broke A. It had a
dependency on the behavior of C that
This thread has probably gone the way of all webkit-dev threads on comments
or ChangeLog files -- people's opinions vary, it turns into a bikeshed, and
nothing really changes about how we code. Repeat in a year.
w.r.t. ImageDecoder specifically, as I mentioned before I do agree that
there are
On Mon, Jan 31, 2011 at 7:18 PM, Peter Kasting pkast...@chromium.org wrote:
P.S. I agree with you about assertions being better than comments to
document pre- (and post-) conditions (where possible).
Me too (where possible).
- a
___
webkit-dev
On Jan 31, 2011, at 7:18 PM, Peter Kasting wrote:
This thread has probably gone the way of all webkit-dev threads on comments
or ChangeLog files -- people's opinions vary, it turns into a bikeshed, and
nothing really changes about how we code. Repeat in a year.
Well, even though we didn't
23 matches
Mail list logo
