[webkit-dev] Experimental cr-linux-ews now runs tests

2011-04-22 Thread Adam Barth
I just wanted to let you know that I'm experimenting with having Chromium Linux EWS bots run the LayoutTests. There are a bunch of bugs to work out, but it seems to be more or less working with a bunch of local hacks. Please don't be surprised if the bot acts strangely for a while. Thanks! Adam

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
I will pass your good arguments to the spec author. Personally I am not in strong favor of mimicking Array.slice. I just found the problems we have during implementation and seek the solution. On Fri, Apr 22, 2011 at 3:00 PM, Geoffrey Garen wrote: > I would suggest updating the specification fo

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Geoffrey Garen
> I would suggest updating the specification for Blob.slice() so that it > doesn't expect passing "undefined" for the second argument to have > identical behavior to not passing the argument at all. The "subarray" > method in the Typed Array spec [1], which has similar behavior to > slice(), doesn'

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
On Fri, Apr 22, 2011 at 12:21 PM, Kenneth Russell wrote: > The generated code for optional arguments in WebKit IDL already does > this sort of dispatch. See Jian Li's first message on this thread and > the code snippet he cited. > > The problem is that "undefined" is being passed explicitly as th

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Kenneth Russell
The generated code for optional arguments in WebKit IDL already does this sort of dispatch. See Jian Li's first message on this thread and the code snippet he cited. The problem is that "undefined" is being passed explicitly as the second argument. If this weren't being done, the default value for

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-04-22 Thread Eric Seidel
On Fri, Apr 22, 2011 at 11:04 AM, Ojan Vafai wrote: >>> (3) I like PrettyPatch format better than wdiff format. >> >> This is orthogonal. new-run-webkit-tests will use whichever one is >> available on the system. The results.html file will display whichever one >> was used. >> >> What would the bo

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-04-22 Thread Ojan Vafai
On Thu, Apr 21, 2011 at 10:05 PM, Maciej Stachowiak wrote: > On Apr 21, 2011, at 4:47 PM, Ojan Vafai wrote: > > On Thu, Apr 21, 2011 at 4:21 PM, Maciej Stachowiak wrote: > > (2) Slow to load (apparently it loads a 3 meg JSON file before displaying >> anything?) >> > > Loading it locally is very

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
This seems not to work. When we call foo(arg1, undefined), arguments.length is 2 and thus we convert undefined to 0 and pass it to impl->foo(arg1, arg2). But we want default value for arg2 other than 0. On Fri, Apr 22, 2011 at 8:52 AM, Oliver Hunt wrote: > An alternative would be to generate cod

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Oliver Hunt
An alternative would be to generate code for optional args along the lines of (pseudo code): void foo(Arg1Type arg1, [Optional] Arg2Type arg2); => Arg1Type arg1 = toArg1Type(arguments[0]); if (arguments.length < 2) return impl->foo(arg1); Arg2Type arg2 = toArg2Type(arguments[1]); return impl->