On Fri, Apr 22, 2011 at 11:04 AM, Ojan Vafai <o...@chromium.org> wrote: >>> (3) I like PrettyPatch format better than wdiff format. >> >> This is orthogonal. new-run-webkit-tests will use whichever one is >> available on the system. The results.html file will display whichever one >> was used. >> >> What would the bots display if this is deployed? > > I'm not 100% sure. Dirk can confirm, but I believe it will use whichever one > is on the system. So, if the bot has pretty-patch, but not wdiff, it would > only show the pretty-patch link. The Chromium bot I linked to has wdiff, but > not pretty-patch, hence the wdiff links.
That's correct. We added that code a year or more ago when initially considering moving to NRWT. The code will prefer PrettyPatch over wdiff if ruby is found on the system. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
