[webkit-dev] New Qt-WK2 EWS

2012-03-07 Thread Osztrogonac Csaba
Hi WebKittens, Today morning we started a new EWS to help your WebKit2 development. It is a build only EWS, which builds QtWebKit (WK1 and WK2 too) with the latest stable Qt5 hash which is used by all QtWebKit developer. The new EWS can be found here: http://queues.webkit.org/ and you will see

Re: [webkit-dev] New Qt-WK2 EWS

2012-03-07 Thread Eric Seidel
I would strongly encourage other ports (at least those who like not having their build break all the time) to see up EWSes. We recently added a wiki on the topic: http://trac.webkit.org/wiki/EWS Post-commit testing (buildbots) is great. But it's much better if patch authors can know they might

Re: [webkit-dev] FYI: ForwardingHeaders/wtf is dead

2012-03-07 Thread Eric Seidel
The patch landed, buildbots look green. Let me know if there is any fallout I missed. Extra thanks to Mark Rowe for all his help with this! -eric On Tue, Mar 6, 2012 at 8:18 PM, Eric Seidel e...@webkit.org wrote: In preparation for moving the WTF code out of JavaScriptCore, support for

Re: [webkit-dev] New Qt-WK2 EWS

2012-03-07 Thread Jesus Sanchez-Palencia
On Wed, Mar 7, 2012 at 6:08 AM, Osztrogonac Csaba o...@inf.u-szeged.hu wrote: Hi WebKittens, Today morning we started a new EWS to help your WebKit2 development. It is a build only EWS, which builds QtWebKit (WK1 and WK2 too) with the latest stable Qt5 hash which is used by all QtWebKit

Re: [webkit-dev] CSS3 Paged Media module

2012-03-07 Thread Seo Sanghyeon
2012/3/7, Milian Wolff milian.wo...@kdab.com: Ping? Could someone be so kind as to answer my questions below? As the following page admits, WebKit's printing architecture has the big flaw and in general inferior to Gecko and other engines. I fear you may have to rework most of WebKit's printing

[webkit-dev] About BrowsingContext and WindowProxy spec

2012-03-07 Thread Sachin Puranik
Hi, While going through the whatwg.org spec, I came across the section 6 Loading Web Pages. Spec looks to be written to help web app developers, to maintain the context for multiple pages to be presented to user and access some cross page information. This section is added to the spec

Re: [webkit-dev] CSS3 Paged Media module

2012-03-07 Thread David Hyatt
That page should be updated. We don't have that architectural flaw any longer since I re-wrote pagination last year. dave (hy...@apple.com) On Mar 7, 2012, at 8:27 AM, Seo Sanghyeon wrote: 2012/3/7, Milian Wolff milian.wo...@kdab.com: Ping? Could someone be so kind as to answer my questions

Re: [webkit-dev] About BrowsingContext and WindowProxy spec

2012-03-07 Thread Adam Barth
I might be misunderstanding your question, but WebKit already implements most (if not all) of this section. WindowProxy and BrowsingContext are internal concepts to the spec. They aren't visible as such in the platform. In particular, a nested BrowsingContext is created by the iframe element

[webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Ojan Vafai
I just did a first pass a greening the Chromium Lion bot: http://trac.webkit.org/changeset/110096. Of these hundreds of tests, ~99% of them are perfect candidates for being reftests (e.g. they contain one line of text and a solid box or two under the text), but most of them are in the CSS

[webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Dan Bernstein
Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient. Thanks. ___ webkit-dev

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread James Robinson
On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Eric Seidel
Unless this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Simon Fraser
The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548 Simon On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote: Unless this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Maciej Stachowiak
I'd prefer we not modify imported test suites. That will just make it more confusing to update. Perhaps future CSS test suites will be changed to a reftest model. Regards, Maciej On Mar 7, 2012, at 1:41 PM, Ojan Vafai wrote: I just did a first pass a greening the Chromium Lion bot:

Re: [webkit-dev] Web Notifications update

2012-03-07 Thread Jon Lee
Update: https://bugs.webkit.org/show_bug.cgi?id=80497 has a patch up. Would appreciate a once-over from port maintainers. It defines an additional variable, with values the same as that of ENABLE_NOTIFICATIONS. Jon On Mar 6, 2012, at 10:00 PM, Maciej Stachowiak m...@apple.com wrote: On Mar

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Darin Fisher
Hrm, if the test expectations are customized already for different ports of WebKit, then why not support replacing a PNG file with a HTML file that is intended to generate exactly the same result? How does this impair our ability to update the tests? (I realize that our current reftest system

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Ojan Vafai
That hadn't occurred to me. You're right, we wouldn't actually modify the test itself. We would just replace the -expected.txt/png with a -expected.html file. Maciej, does that change your opinion on this? On Wed, Mar 7, 2012 at 4:44 PM, Darin Fisher da...@chromium.org wrote: Hrm, if the test

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Ryosuke Niwa
On Wed, Mar 7, 2012 at 4:44 PM, Darin Fisher da...@chromium.org wrote: Hrm, if the test expectations are customized already for different ports of WebKit, then why not support replacing a PNG file with a HTML file that is intended to generate exactly the same result? How does this impair our

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Levi Weintraub
On Wed, Mar 7, 2012 at 4:50 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Mar 7, 2012 at 4:44 PM, Darin Fisher da...@chromium.org wrote: Hrm, if the test expectations are customized already for different ports of WebKit, then why not support replacing a PNG file with a HTML file that is

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Ojan Vafai
On Wed, Mar 7, 2012 at 4:50 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Mar 7, 2012 at 4:44 PM, Darin Fisher da...@chromium.org wrote: Hrm, if the test expectations are customized already for different ports of WebKit, then why not support replacing a PNG file with a HTML file that is

Re: [webkit-dev] About BrowsingContext and WindowProxy spec

2012-03-07 Thread Darin Adler
On Mar 7, 2012, at 9:34 AM, Adam Barth wrote: The WindowProxy is implemented in WebKit using the WindowShell class. Idle thought: We might want to consider renaming our WindowShell class WindowProxy, just to match the HTML specification concept, as I think we’ve done in a few other cases. --

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Sravan
Hi, If i get the context correct, then mime-type is automatically set to png files as Property changes on: abc.png ___ Added: svn:mime-type ## -0,0 +1 ## +image/png when we run ./Tools/Scripts/svn-create-patch if the svn version is

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-07 Thread Maciej Stachowiak
I too am mildly concerned about references not being sufficiently independent of the tests, which is why I hoped we could get the WG in the business of reviewing references along with tests. However, another possibility is looking at what Mozilla uses for reference for these tests, since those

[webkit-dev] Microdata document.getItems()

2012-03-07 Thread Gurpreet Kaur
Dear Webkit Team, I am working on Microdata for Android browser. After taking all the changes related to Microdata the following test case is failing for me. http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html This test case has call to document.getItems() (with no

Re: [webkit-dev] Microdata document.getItems()

2012-03-07 Thread Ryosuke Niwa
Your best bet is to talk with Arko :) - Ryosuke On Wed, Mar 7, 2012 at 11:26 PM, Gurpreet Kaur gur.t...@gmail.com wrote: Dear Webkit Team, I am working on Microdata for Android browser. After taking all the changes related to Microdata the following test case is failing for me.

Re: [webkit-dev] Microdata document.getItems()

2012-03-07 Thread Gurpreet Kaur
Dear Ryosuke, Thanks for the update. Dear Arko, Could you please help me with this? Thanks and Regards, Gurpreet On Thu, Mar 8, 2012 at 1:27 PM, Ryosuke Niwa rn...@webkit.org wrote: Your best bet is to talk with Arko :) - Ryosuke On Wed, Mar 7, 2012 at 11:26 PM, Gurpreet Kaur