Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread James Robinson
On Fri, May 25, 2012 at 1:42 PM, Žan Doberšek wrote: > > > On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches < > dominik.rottsc...@intel.com> wrote: > >> Andrei, >> >> >> On 05/25/2012 02:43 AM, Andrei Bucur wrote: >> >> Ojan, >> >> As Simon states, some repaint tests will likely not be possib

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Žan Doberšek
On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches < dominik.rottsc...@intel.com> wrote: > Andrei, > > > On 05/25/2012 02:43 AM, Andrei Bucur wrote: > > Ojan, > > As Simon states, some repaint tests will likely not be possible to write > correctly as ref tests, but some of them I think they fit

Re: [webkit-dev] JSGlobalData & GC collection thread lifetime if webview is recreated without application exit.

2012-05-25 Thread Geoffrey Garen
> So I think that gc thread is still active even though webview has been > deleted. > Are my assumptions correct regarding the js gc thread? No. There's no dedicated GC thread. > One more query is that JSDOMWindowBase::commonJSGlobalData is a static > object. Again I do not see any one clearing

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Julien Chaffraix
>> I think this will be too fragile. It relies on the fact that a subsequent >> paint won't obscure the repaint bug that you're trying to detect. >> >> I'm much rather we work towards detecting repaint bugs via dumping the >> list of repaint rectangles. I don't think every test has to be a ref test

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Dominik Röttsches
Andrei, On 05/25/2012 02:43 AM, Andrei Bucur wrote: Ojan, As Simon states, some repaint tests will likely not be possible to write correctly as ref tests, but some of them I think they fit very well in the happy-no-pixel-test bucket :). If people decide it's a direction worth investigating,

Re: [webkit-dev] JSGlobalData & GC collection thread lifetime if webview is recreated without application exit.

2012-05-25 Thread Mayur K
Hi All, Thanks for the reply Geoff. I am currently facing an issue where in after deleting the webview, but not exiting the application, after some time the javascript gc thread is seg faulting. The breakpoints that I have added are also not hitting. So I think that gc thread is still active even t