Re: [webkit-dev] Existing metrics for deprecated features

2012-09-13 Thread Adam Barth
On Thu, Sep 13, 2012 at 10:58 PM, Pavel Feldman wrote: > On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote: >> In connection with the thread on webkitPostMessage, I took a look at >> what sorts of metrics we have currently for depreciated features. We >> have high quality data for two groups of

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Pavel Feldman
> > > By the way, in preparing the patch, I noticed that webkitSlice was > used by the web inspector. Note that the data above includes the use > by the web inspector. > > The usage was in the heap profiler's load snapshot routines, so I can imagine it not being invoked a lot. That matches the sta

Re: [webkit-dev] Existing metrics for deprecated features

2012-09-13 Thread Pavel Feldman
On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote: > In connection with the thread on webkitPostMessage, I took a look at > what sorts of metrics we have currently for depreciated features. We > have high quality data for two groups of APIs: > > For mutation events, we measure what percent of Do

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Adam Barth
On Thu, Sep 13, 2012 at 9:05 PM, Maciej Stachowiak wrote: > On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote: > On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: >> On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: >> > Another metric we have is for Blob.webkitSlice: >> > >> > Ratio of Blob.w

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Yin, Li
Congrats Yuta. -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of TAMURA, Kent Sent: Friday, September 14, 2012 11:57 AM To: WebKit Development Subject: [webkit-dev] New WebKit reviewer: Yuta Kitamura I'd like to announc

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Gyuyoung Kim
Wow, congratulation Yuta :-) Gyuyoung On Fri, Sep 14, 2012 at 1:01 PM, Adam Barth wrote: > Congrats Yuta!! > > Adam > > > On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote: > > I'd like to announce that Yuta Kitamura is now a > > WebKit reviewer. > > > > He has contributed to WebKit project

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Maciej Stachowiak
On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote: > > > On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: > On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > > Another metric we have is for Blob.webkitSlice: > > > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > > Ratio of Blob.

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Adam Barth
Congrats Yuta!! Adam On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote: > I'd like to announce that Yuta Kitamura is now a > WebKit reviewer. > > He has contributed to WebKit project for three years mainly in WebSocket > area. He is a trustworthy authority on WebSocket area. If you worked on

[webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread TAMURA, Kent
I'd like to announce that Yuta Kitamura is now a WebKit reviewer. He has contributed to WebKit project for three years mainly in WebSocket area. He is a trustworthy authority on WebSocket area. If you worked on WebSocket issues, please involve him. -- TAMURA Kent Software Engineer, Google

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Darin Fisher
On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: > On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > > Another metric we have is for Blob.webkitSlice: > > > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > > > It's

[webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Adam Barth
On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > Another metric we have is for Blob.webkitSlice: > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > It's difficult to know how to interpret this data because we don't > ac

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-09-13 Thread Gergely Kis
Hi, Submitted the patch for enabling the MIPS slave in build.webkit.org. https://bugs.webkit.org/show_bug.cgi?id=96713 Who should I send the buildbot password for the slave? Thanks, Gergely On Thu, Aug 30, 2012 at 9:52 AM, Holger Freyther wrote: > On 08/30/2012 12:10 AM, Gergely Kis wrote: >

[webkit-dev] Existing metrics for deprecated features

2012-09-13 Thread Adam Barth
In connection with the thread on webkitPostMessage, I took a look at what sorts of metrics we have currently for depreciated features. We have high quality data for two groups of APIs: For mutation events, we measure what percent of Documents have listeners for various kinds of mutation events:

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread David Levin
If someone wanted this and understood python, I suspect that they could search for "unsigned" in that cpp.py and in about 10 min have a pretty good idea of how to add such a check. If you don't understand Python, then 30 minutes :) dave On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Kenneth Rohde Christiansen
Filed https://bugs.webkit.org/show_bug.cgi?id=96693 On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa wrote: > No. I think we can update webkitpy/style/checkers/cpp.py to do that. > Unfortunately, I don't understand that code base. > > - Ryosuke > > > On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wr

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
No. I think we can update webkitpy/style/checkers/cpp.py to do that. Unfortunately, I don't understand that code base. - Ryosuke On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wrote: > Does the style bot pick up "unsigned int" etc? > > --Oliver > > On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Oliver Hunt
Does the style bot pick up "unsigned int" etc? --Oliver On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote: > Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) > > On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: > Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: > Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. > > - Ryosuke > > On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > >> >> >> On Sep 13, 2012, at 1:

Re: [webkit-dev] Should we support multiple bug URLs in TestExpectations?

2012-09-13 Thread Dirk Pranke
On Thu, Sep 13, 2012 at 12:32 PM, Ryosuke Niwa wrote: > Hi, > > This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. > > Should we allow URLs other than webkit.org/b/ to be used in > TestExpectations? > > I vote for yes, and in fact, adding new URLs should be easy. What do yo

[webkit-dev] Should we support multiple bug URLs in TestExpectations?

2012-09-13 Thread Ryosuke Niwa
Hi, This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. Should we allow URLs other than webkit.org/b/ to be used in TestExpectations? I vote for yes, and in fact, adding new URLs should be easy. What do you guys think? Best, Ryosuke Niwa Software Engineer Google Inc.

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. - Ryosuke On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > > > On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen < > kenneth.christian...@gmail.com> wrote: > > > Hi there, > > > > I was telling people to use "unsign

Re: [webkit-dev] Removing the prefix from webkitPostMessage

2012-09-13 Thread Ojan Vafai
On Thu, Sep 13, 2012 at 12:06 PM, Dirk Pranke wrote: > On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote: > > > > On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote: > > > > On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak > wrote: > >> > >> - Is this approach substantially less time and

Re: [webkit-dev] Removing the prefix from webkitPostMessage

2012-09-13 Thread Dirk Pranke
On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote: > > On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote: > > On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak wrote: >> >> - Is this approach substantially less time and effort than adding a >> histogram-style metric? I expect you have adde

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Dan Bernstein
On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen wrote: > Hi there, > > I was telling people to use "unsigned" instead of "unsigned int", as I > have been told that was the preferred style before, but apparently > that is not in the style guide. > > The question is, should it be? Yes

[webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Kenneth Rohde Christiansen
Hi there, I was telling people to use "unsigned" instead of "unsigned int", as I have been told that was the preferred style before, but apparently that is not in the style guide. The question is, should it be? A few greps in the code: "unsigned" -> 18406 occurrences. "unsigned int" -> 1721 "un