Re: [webkit-dev] Where Paste from clipboard happens?

2013-03-21 Thread Daniel Cheng
​From reading the bug report, I'm guessing you can fix the bug by simply writing the correct text content to the clipboard. Just join the URLs with \n's in between and write the resulting text to the clipboard in BookmarkNodeData::WriteToClipboard(). Daniel​ On Thu, Mar 21, 2013 at 6:16 PM, Thia

Re: [webkit-dev] WebSocket development

2013-03-21 Thread Lamarque Souza
Hi, I already tried to contact tkent on #websocket with no answer from him. Alexey commented on the bug entry I mentioned, that is good :-). Thanks for the answer. On March 21, 2013 at 11:37 PM Takashi Toyoshima wrote: > > +a...@webkit.org [mailto:a...@webkit.org] , tk...@chromium.org > [

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer wrote: > On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: >> >>> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >>> >>> On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: >>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Silvia Pfeiffer
On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > >> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >> >> On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: >>> >>>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: >> >>> >>> On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: >>> >>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Maciej Stachowiak
On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > That's my platform

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > >> >> On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >>> That's my platform, so I have to manage with it. >>>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >> >>> That's my platform, so I have to manage with it. >>> >> >> I do have a Retina MBP too but I don't use it to work on the r

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > >> That's my platform, so I have to manage with it. >> > > I do have a Retina MBP too but I don't use it to work on the rendering > engine precisely because of this issue. It's expected

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 5:04 PM, Silvia Pfeiffer wrote: > On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >> >>> On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: >>> >> >> >>> In general, I don't recommend people running and re

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Silvia Pfeiffer
On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > >> On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: >> > > >> In general, I don't recommend people running and relying on layout tests >>> on Retina MBP especially if you work on th

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: >> >>> >>> On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: >>> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote:

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: > >> >> On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: >>> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote:

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: >> >>> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: >>> Lately, I've encountering changesets that only add lines t

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: > >> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: >> >>> Lately, I've encountering changesets that only add lines to >>> TestExpectations and then never baseline tests for any pla

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: > On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: > >> Lately, I've encountering changesets that only add lines to >> TestExpectations and then never baseline tests for any platform. >> > > This (never rebaseline tests for any platform in

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: > Lately, I've encountering changesets that only add lines to > TestExpectations and then never baseline tests for any platform. > This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances

Re: [webkit-dev] WebSocket development

2013-03-21 Thread Takashi Toyoshima
+a...@webkit.org, tk...@chromium.org Hi Lamarque, I think they can review WebSocket related changes. On Thu, Mar 21, 2013 at 2:40 PM, Lamarque Souza wrote: > ** > Hi all, > > I am starting to work on WebSocket development for WebKit and submitted a > patch [1] for review some weeks ago. The thi

Re: [webkit-dev] PSA: EWS bots now upload results again

2013-03-21 Thread Eric Seidel
Thank you very much for making the uploads (and thus the flaky test reporter) work again! On Thu, Mar 21, 2013 at 2:52 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 2:50 PM, Eric Seidel wrote: >> >> I think to expect folks to use these results, we're going to need to >> give them nice tools,

Re: [webkit-dev] PSA: EWS bots now upload results again

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 2:50 PM, Eric Seidel wrote: > I think to expect folks to use these results, we're going to need to > give them nice tools, like: > https://bugs.webkit.org/show_bug.cgi?id=92033 I might work on that tonight if I decide to stay up 'til 4am again. - R. Niwa ___

Re: [webkit-dev] PSA: EWS bots now upload results again

2013-03-21 Thread Eric Seidel
I think to expect folks to use these results, we're going to need to give them nice tools, like: https://bugs.webkit.org/show_bug.cgi?id=92033 On Thu, Mar 21, 2013 at 10:55 AM, Ryosuke Niwa wrote: > Fixed it in http://trac.webkit.org/changeset/146443. > > So yeah, don't add entries for rebaseline

[webkit-dev] WebSocket development

2013-03-21 Thread Lamarque Souza
Hi all, I am starting to work on WebSocket development for WebKit and submitted a patch [1] for review some weeks ago. The thing is that only one reviewer in [2] is listed as working on WebSocket and he seems absent from WebKit development since October of last year. I tried to contact him through

[webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This makes it impossible to figure out what the expected results is for other platforms the patch author doesn't contribute to / care about. Furthermore, I don't know how r

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 11:16 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 10:54 AM, Žan Doberšek wrote: > >> On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote: >> >>> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >>> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: > O

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Levi Weintraub
I wish I could explicitly set an entry as being intended to be rebaselined, then notified (by email, by webkit-patch, something) when the tests covered by that entry have ran through all the bots with a url that shows the results so I can quickly validate them. In this magic world, if the results

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 10:54 AM, Žan Doberšek wrote: > On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote: > >> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: >>> On Thursday, 21 March 2013, Ryosuke Niwa wrote: > I used

[webkit-dev] PSA: EWS bots now upload results again

2013-03-21 Thread Ryosuke Niwa
Fixed it in http://trac.webkit.org/changeset/146443. So yeah, don't add entries for rebaselines in platform/mac/TestExpectations please. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-d

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Žan Doberšek
On Thu, Mar 21, 2013 at 5:18 PM, Robert Hogan wrote: > > > On Thursday, 21 March 2013, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: >> >>> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >>> I used to pull results from the bots where possible but creating >>>

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Robert Hogan
On Thursday, 21 March 2013, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan > > > wrote: > >> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >> >>> I used to pull results from the bots where possible but creating inconsistency between png/text results is not good.

Re: [webkit-dev] APNG support

2013-03-21 Thread Adam Barth
Chromium is not interested in supporting APNG. I'm not opposed to landing this patch if other ports are interested in supporting APNG. Adam On Mar 21, 2013 4:28 AM, "Allan Sandfeld Jensen" wrote: > On Thursday 21 March 2013, Max Stepin wrote: > > What do you think? > > > > I posted the patch h

Re: [webkit-dev] APNG support

2013-03-21 Thread Allan Sandfeld Jensen
On Thursday 21 March 2013, Max Stepin wrote: > What do you think? > > I posted the patch here: > https://bugs.webkit.org/show_bug.cgi?id=17022 > I don't mind. APNG is a nice simple format. GIF has limitations and MNG is almost inherently broken. To support it though, you need to make sure the p

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: > On Thursday, 21 March 2013, Ryosuke Niwa wrote: > >> I used to pull results from the bots where possible but creating >>> inconsistency between png/text results is not good. >>> >> >> It is unfortunate but it's much better than losing the com

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Robert Hogan
On Thursday, 21 March 2013, Ryosuke Niwa wrote: > I used to pull results from the bots where possible but creating >> inconsistency between png/text results is not good. >> > > It is unfortunate but it's much better than losing the complete test > coverage. > If that's the case then I'm happy to

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Ryosuke Niwa
To give you a perspective on how bad the current system is, just while I was removing those 30 entires, I've found out that fast/css-generated-content/table-row-group-to-inline.html has regressed since it was first added. This regression should have caught by people running pixel tests only if we h