[webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

Hi, http://trac.webkit.org/changeset/155643 broke Qt build with an error saying: Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors because of the following code: GPRReg gpr(WhichValue

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 5:29 PM, Geoffrey Garen wrote: >> Sure. We at University of Szeged who work on WebKitNix from this year >> contributed many fixes to various part of WebKit: JavaScriptCore, >> WebCore, Tools, … > > Thank you for this list. I started reading through it, but I noticed a high

[webkit-dev] Is Nix/GTK/EFL really using applyPageScaleFactorInCompositor?

Hi WebKit, There are remains of applyPageScaleFactorInCompositor here and there in the code and it is not clear to me if it is correct or not. The hack was introduced specifically for chromium (https://bugs.webkit.org/show_bug.cgi?id=107424) and most of the code has already been cleaned. I c

Re: [webkit-dev] Announcing new port: Nix

On 9/12/13 9:34 PM, Brent Fulgham wrote: However, you've already clarified that you're going to improve WebRTC and are, in fact, in the process of doing so. Furthermore, you've clarified that there is a demand for your port and human resources to maintain it. I'm actually curious if anyone's

Re: [webkit-dev] Announcing new port: Nix

> However, you've already clarified that you're going to improve WebRTC and > are, in fact, in the process of doing so. Furthermore, you've clarified that > there is a demand for your port and human resources to maintain it. > > I'm actually curious if anyone's opposed to supporting Nix port a

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

The problem here is Qt uses older compilers which do not detect when all cases are handled before the end of the function (like the example of Ryosuke). It looks like this will not be a problem for much longer. Qt people are giving up on developing a web engine: http://blog.qt.digia.com/blog/

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Thu, Sep 12, 2013 at 4:19 PM, Myles C. Maxfield wrote: > I can't speak for Qt, but this warning has been helpful for me in the past. > We have the same warning enabled on Mac, GTK+, etc... and I agree it's useful. The problem here is that the version of gcc used by Qt builders isn't smart en

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

I can't speak for Qt, but this warning has been helpful for me in the past. On Thu, Sep 12, 2013 at 2:07 PM, Ryosuke Niwa wrote: > Hi, > > http://trac.webkit.org/changeset/155643 broke Qt build with an error > saying: > > Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control reaches end

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 11:06 AM, Hugo Lima wrote: > On Thu, Sep 12, 2013 at 2:54 PM, Darin Adler wrote: > > On Sep 12, 2013, at 10:36 AM, Hugo Lima wrote: > > > >> the Nix implementation will just delegate the implementation to the > application > > > > I think what this means is that Nix will

Re: [webkit-dev] Announcing new port: Nix

>> As it was pointed in the first email of this thread and by Hugo's >> email, Nix "targets whoever wants to have a hardware accelerated >> WebKit2 port on UNIX-based devices, with a minimum effort". > > Yes. I read that email. Then I asked who "whoever" was, and the answer was > "nobody". > > My

Re: [webkit-dev] Announcing new port: Nix

On Sep 12, 2013, at 6:38 AM, Thomas Fletcher wrote: > TDLR: Crank Software Supports a NIX port This is a question of maintenance burden. As Geoff said every port adds a cost to developing and maintaining webkit. You've said you support a NIX port, but a quick search doesn't show any contribut

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Thu, Sep 12, 2013 at 8:46 PM, Filip Pizlo wrote: > > On Sep 12, 2013, at 7:54 PM, Ryosuke Niwa wrote: > > Hm... it appears that I was wrong about this. It appears that this is the > intended feature in gcc: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28236 > > > Yuck! Madness! > > > Regar

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On 9/12/13 8:46 PM, Filip Pizlo wrote: On Sep 12, 2013, at 7:54 PM, Ryosuke Niwa > wrote: Hm... it appears that I was wrong about this. It appears that this is the intended feature in gcc: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28236 Yuck! Madness! Regardle

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Sep 12, 2013, at 7:54 PM, Ryosuke Niwa wrote: > Hm... it appears that I was wrong about this. It appears that this is the > intended feature in gcc: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28236 Yuck! Madness! > > Regardless, I don't think we should have this warning enabled. We'r

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Friday 13 September 2013, Benjamin Poulain wrote: > On 9/12/13 4:48 PM, Ryosuke Niwa wrote: > > On Thu, Sep 12, 2013 at 4:45 PM, Allan Sandfeld Jensen > > > > mailto:k...@carewolf.com>> wrote: > > Don't worry we are still here, just in fewer numbers, and with > > fewer things to > >

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Sep 12, 2013, at 4:45 PM, Allan Sandfeld Jensen wrote: > Don't worry we are still here, just in fewer numbers, and with fewer things > to > support. Hi Allan, reading the article it seems to me like Qt WebKit is going into maintenance mode. Is this true? Does this mean that you’ll crea

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 2:54 PM, Darin Adler wrote: > On Sep 12, 2013, at 10:36 AM, Hugo Lima wrote: > >> the Nix implementation will just delegate the implementation to the >> application > > I think what this means is that Nix will export interfaces that closely match > WebKit internals as th

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

Hm... it appears that I was wrong about this. It appears that this is the intended feature in gcc: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28236 Regardless, I don't think we should have this warning enabled. We're generating some unused code everywhere :( - R. Niwa On Thu, Sep 12, 2013 at

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Sep 13, 2013, at 12:45 AM, Allan Sandfeld Jensen wrote: > Don't worry we are still here, just in fewer numbers, and with fewer things > to > support. Can you give us more details on what’s no longer supported? -Andreas___ webkit-dev mailing list

Re: [webkit-dev] Announcing new port: Nix

Benjamin Poulain wrote: On 9/12/13 5:21 PM, Thomas Fletcher wrote: Geoffrey Garen wrote: Sure. We at University of Szeged who work on WebKitNix from this year contributed many fixes to various part of WebKit: JavaScriptCore, WebCore, Tools, ... Thank you for this list. I started reading thr

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 6:05 PM, Thomas Fletcher wrote: > Benjamin Poulain wrote: > > On 9/12/13 5:21 PM, Thomas Fletcher wrote: > > Geoffrey Garen wrote: > > Sure. We at University of Szeged who work on WebKitNix from this year > contributed many fixes to various part of WebKit: JavaScriptCore, >

Re: [webkit-dev] Announcing new port: Nix

Oliver Hunt wrote: On Sep 12, 2013, at 6:38 AM, Thomas Fletcher wrote: TDLR: Crank Software Supports a NIX port This is a question of maintenance burden. As Geoff said every port adds a cost to developing and maintaining webkit. You've said you support a NIX port, but a quick search does

Re: [webkit-dev] Announcing new port: Nix

On 9/12/13 5:21 PM, Thomas Fletcher wrote: Geoffrey Garen wrote: Sure. We at University of Szeged who work on WebKitNix from this year contributed many fixes to various part of WebKit: JavaScriptCore, WebCore, Tools, ... Thank you for this list. I started reading through it, but I noticed a hi

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 4:14 PM, Ryosuke Niwa wrote: > Interesting. That sounds a lot like Chromium's WebKit API layer. If I > remember correctly, that layer had to be modified constantly as > WebCore/WebKit code was refactored so I'm a bit worried about this. Yes, in fact we got some API from t

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On 9/12/13 4:48 PM, Ryosuke Niwa wrote: On Thu, Sep 12, 2013 at 4:45 PM, Allan Sandfeld Jensen mailto:k...@carewolf.com>> wrote: Don't worry we are still here, just in fewer numbers, and with fewer things to support. I would prefer to keep the warning, it is quite useful at tim

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

On Thu, Sep 12, 2013 at 4:45 PM, Allan Sandfeld Jensen wrote: > Don't worry we are still here, just in fewer numbers, and with fewer > things to > support. > > I would prefer to keep the warning, it is quite useful at times, and when > it > isn't you just add a default case with an ASSERT_NOT_REAC

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

Don't worry we are still here, just in fewer numbers, and with fewer things to support. I would prefer to keep the warning, it is quite useful at times, and when it isn't you just add a default case with an ASSERT_NOT_REACHED(). `Allan On Friday 13 September 2013, Benjamin Poulain wrote: > Th

Re: [webkit-dev] Announcing new port: Nix

On Sep 12, 2013, at 10:36 AM, Hugo Lima wrote: > the Nix implementation will just delegate the implementation to the > application I think what this means is that Nix will export interfaces that closely match WebKit internals as the Nix API to WebKit. This may well create a long term problem

Re: [webkit-dev] Announcing new port: Nix

On Thu, Sep 12, 2013 at 1:46 PM, Darin Adler wrote: > In my work on clipboard and pasteboard recently, I started with the Mac port. > The Qt and GTK ports have been easy to work with. Contributors to those ports > have helped me get the details right, and the code for those ports is > relativel

Re: [webkit-dev] Moving LayoutTests/fast/js to LayoutTests/js

Unsubscribe at https://lists.webkit.org/mailman/listinfo/webkit-dev - R. Niwa On Thu, Sep 12, 2013 at 3:29 PM, Kabeer Kalra wrote: > i do not want to be in this mailing list > On Sep 6, 2013, at 8:06 PM, Mark Lam wrote: > > > This is a courtesy notice: FYI, I’m in the process of moving > Layout

Re: [webkit-dev] Moving LayoutTests/fast/js to LayoutTests/js

i do not want to be in this mailing list On Sep 6, 2013, at 8:06 PM, Mark Lam wrote: > This is a courtesy notice: FYI, I’m in the process of moving > LayoutTests/fast/js to LayoutTests/js for > https://bugs.webkit.org/show_bug.cgi?id=120899. This change will touch many > files in the test fil

Re: [webkit-dev] Announcing new port: Nix

> However, I am quite happy that people have been working on improving the > libcURL support :-) Thank you Brent. Although many people left, we are still here, and continually improving WebKit. We are serious about it. Regards, Zoltan ___ webkit-dev m

Re: [webkit-dev] Announcing new port: Nix

> Sure. We at University of Szeged who work on WebKitNix from this year > contributed many fixes to various part of WebKit: JavaScriptCore, > WebCore, Tools, … Thank you for this list. I started reading through it, but I noticed a high percentage of patches that were port-specific build fixes or

Re: [webkit-dev] Announcing new port: Nix

In my work on clipboard and pasteboard recently, I started with the Mac port. The Qt and GTK ports have been easy to work with. Contributors to those ports have helped me get the details right, and the code for those ports is relatively self explanatory. The Windows port has been pretty easy, to

Re: [webkit-dev] Announcing new port: Nix

Hi, On 09/12/13, Osztrogonác Csaba wrote: > Improving cURL network backend (which used by Apple's WinCairo port too) > > The WinCairo port is not an Apple project, though it is tied very closely to the existing Apple Windows port. However, I am quite happy that people have been working on im

Re: [webkit-dev] Announcing new port: Nix

Geoffrey Garen wrote: The most recent effort from our side is to provide WebRTC support. Great. Features, like performance improvements and bug fixes, are a great way to contribute to WebKit. As it was pointed in the first email of this thread and by Hugo's email, Nix "targets whoever wan

Re: [webkit-dev] Announcing new port: Nix

Hi, Geoffrey Garen írta: If the NIX port is what gets you guys excited about WebKit, and the end result is a great implementation of WebRTC, that's great. But, six months from now, if the NIX port still has no adopters, and the only activity it brings to WebKit is the occasional rude email fr

Re: [webkit-dev] Announcing new port: Nix

Hi, Geoffrey Garen írta: Does your code fix bugs or improve performance in WebCore or JavaScriptCore? As any other WebKit port WebCore bugs are fixed when we found it and need a fix, our current performance focus is on CoordinatedGraphics and there are another team working on get the can

Re: [webkit-dev] Announcing new port: Nix

On Wed, 2013-09-11 at 17:43 -0300, Luciano Wolf wrote: > The most recent effort from our side is to provide WebRTC support. > Thiago Lacerda is talking with Eric Carlson and they are coordinating > the merge of Blink patches as well as planning the development of > missing features. So, I believe