Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Ryosuke Niwa
On Thu, May 11, 2017 at 11:32 PM, Anne van Kesteren wrote: > On Fri, May 12, 2017 at 6:46 AM, Simon Fraser wrote: >> I was under the impression that tests upstreamed from vendor repositories >> would land in WPT tests >> with minimal review, based on the fact that they had been reviewed when >>

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Anne van Kesteren
On Fri, May 12, 2017 at 6:46 AM, Simon Fraser wrote: > I was under the impression that tests upstreamed from vendor repositories > would land in WPT tests > with minimal review, based on the fact that they had been reviewed when > landed in the vendor repo. I think that's under the expectation

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Simon Fraser
> On May 11, 2017, at 9:30 PM, Anne van Kesteren wrote: > > On Tue, May 9, 2017 at 8:27 PM, Simon Fraser wrote: >> I'm also concerned that with 4 vendors upstreaming their WPT tests, the WPT >> repo will just become a morass of partially overlapping tests that takes 4x >> longer to run than a cu

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Anne van Kesteren
On Tue, May 9, 2017 at 8:27 PM, Simon Fraser wrote: > I'm also concerned that with 4 vendors upstreaming their WPT tests, the WPT > repo will just become a morass of partially overlapping tests that takes 4x > longer to run than a curated repo. Why do you think WPT is not curated? It's an activel

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread youenn fablet
Patch just landed. Location is LayoutTests/http/wpt. I also forgot to say that, should you want to write http served tests, it might make sense to use this folder instead of http/tests. Y Le jeu. 11 mai 2017 à 19:05, Sam Weinig a écrit : > > On May 8, 2017, at 9:31 PM, youenn fablet wrote: >

Re: [webkit-dev] Fwd: Port WebKit to GNUstep

2017-05-11 Thread Ryosuke Niwa
Are you intending to maintain this port going forward? The bar for introducing a new port in the WebKit repository is pretty high due to the maintenance cost it incurs to all other contributors. Unless you're intending to maintain your own port, and then contribute to the rest of the WebKit project

Re: [webkit-dev] Port WebKit to GNUstep

2017-05-11 Thread Geoffrey Garen
No. The bar is much higher for introducing a new port to WebKit. Geoff > On May 11, 2017, at 7:54 PM, Daniel Ferreira (theiostream) > wrote: > > Hi there, > > My name is Daniel Ferreira and as a Google Summer of Code project I > decided to tackle the ten-year-long[1] effort of porting WebKit

[webkit-dev] Fwd: Port WebKit to GNUstep

2017-05-11 Thread Daniel Ferreira (theiostream)
Hi there, My name is Daniel Ferreira and as a Google Summer of Code project I decided to tackle the ten-year-long[1] effort of porting WebKit to GNUstep one more time (and hopefully get somewhere this time). Since 2009, GNUstep has gained a lot of maturity in its graphics stack and on its impleme

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Sam Weinig
> On May 8, 2017, at 9:31 PM, youenn fablet wrote: > > Hi all, > > Discussing with some WebKittens, testharness.js is more and more used in > WebKit. > Is it time to make testharness.js the recommended way of writing LayoutTests? I am in favor of this. If we simplified the question to some f

Re: [webkit-dev] Reminder: be careful when printing sized integer types

2017-05-11 Thread Yusuke SUZUKI
Or, alternative way is casting the value to `unsigned long long` and always using %llu for uint64_t. uint64_t value = ...; printf("%llu", (unsigned long long)value); Regards, Yusuke Suzuki On Wed, May 10, 2017 at 4:07 AM, Michael Catanzaro wrote: > Hi, > > This is just a reminder to avoid a ca

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-11 Thread Konstantin Tokarev
11.05.2017, 11:18, "Osztrogonác Csaba" : > Hi, > > On 2017.05.11. 0:32, Andy Estes wrote: >>>  On May 10, 2017, at 3:17 PM, Michael Catanzaro >>> wrote: >>> >>>  On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote:  One annoying thing is that I've seen clang complaining about that  re

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-11 Thread Osztrogonác Csaba
Hi, On 2017.05.11. 0:32, Andy Estes wrote: On May 10, 2017, at 3:17 PM, Michael Catanzaro wrote: On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote: One annoying thing is that I've seen clang complaining about that return statement being an unreachable statement while gcc doesn't :(. So we p