Re: [webkit-dev] 'final' class specifier and 'final' method specifier

Thank you very much for the feedbacks. On Thu, Dec 20, 2018 at 4:52 AM Konstantin Tokarev wrote: > > 19.12.2018, 12:53, "Fujii Hironori" : > > I'd like to change this because 'final' doesn't necessarily imply > > 'override'. See the following stackoverflow: > >

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 9:41 PM, Chris Dumez wrote: > >> >> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak > > wrote: >> >> >> >>> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa >> > wrote: >>> >>> On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser >>

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak wrote: > > > >> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa > > wrote: >> >> On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser > > wrote: >> > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > >

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa wrote: > > On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser > wrote: > > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > > wrote: > > > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler >

Re: [webkit-dev] the name "AtomicString"

On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser wrote: > > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > wrote: > > > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: > >> I’ve gotten used to the name AtomicString over the years, but I > wouldn’t strongly object to changing it if other

Re: [webkit-dev] the name "AtomicString"

Seems to me we could fix the current problem by renaming from AtomicString to AtomString without causing any new problem. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

In that case, I'll point out that C++ Core Guidelines has a rule "Virtual functions should specify exactly one of virtual, override, or final". (http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override) Their tl;dr: " • virtual means exactly and only “this is a new virtual

Re: [webkit-dev] Hash table empty value

> On Dec 19, 2018, at 12:54 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 2:31 PM, Ryosuke Niwa wrote: >> I tend to agree but then we'd come up with other numbers for the empty & >> deleted values. >> I've been thinking that we could use -1 and -2 but that's also somewhat >>

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 12:33 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: >> I’ve gotten used to the name AtomicString over the years, but I wouldn’t >> strongly object to changing it if other programmers are often confused by >> it’s similarity to the

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

Let’s be clear about what we are discussing. The choice is not be between “final” and “override”. The choice is between “final override”, “override final”, and “final” for functions which are both overrides and final. — Darin Sent from my iPhone > On Dec 19, 2018, at 12:27 PM, Michael

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

19.12.2018, 23:27, "Michael Catanzaro" : > On Wed, Dec 19, 2018 at 1:58 PM, Konstantin Tokarev > wrote: >>  Adding override to method which already has final specifier doesn't >>  affect anything, >>  because both final and override may ony be used on virtual methods > > FWIW I prefer override

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 12:33 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: >> I’ve gotten used to the name AtomicString over the years, but I wouldn’t >> strongly object to changing it if other programmers are often confused by >> it’s similarity to the

[webkit-dev] Hash table empty value

On Tue, Dec 18, 2018 at 2:31 PM, Ryosuke Niwa wrote: I tend to agree but then we'd come up with other numbers for the empty & deleted values. I've been thinking that we could use -1 and -2 but that's also somewhat arbitrary restriction. Using min/max values seems much safer. E.g. we already

Re: [webkit-dev] the name "AtomicString"

On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: I’ve gotten used to the name AtomicString over the years, but I wouldn’t strongly object to changing it if other programmers are often confused by it’s similarity to the term “atomic operations”. Well there were two other developers in the

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

On Wed, Dec 19, 2018 at 1:58 PM, Konstantin Tokarev wrote: Adding override to method which already has final specifier doesn't affect anything, because both final and override may ony be used on virtual methods FWIW I prefer override because it's much more clear what that keyword is used

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

19.12.2018, 21:02, "Darin Adler" : >>  On Dec 19, 2018, at 1:52 AM, Fujii Hironori >> wrote: >> >>  I'd like to change this because 'final' doesn't necessarily imply >>  'override'. See the following stackoverflow: >>  https://stackoverflow.com/questions/29412412/does-final-imply-override > >

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

19.12.2018, 12:53, "Fujii Hironori" : > I'd like to change this because 'final' doesn't necessarily imply > 'override'. See the following stackoverflow: > https://stackoverflow.com/questions/29412412/does-final-imply-override It does imply override, unless it is used in a declaration of new

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

> On Dec 19, 2018, at 1:52 AM, Fujii Hironori wrote: > > I'd like to change this because 'final' doesn't necessarily imply > 'override'. See the following stackoverflow: > https://stackoverflow.com/questions/29412412/does-final-imply-override I’d be happy to require both final and override if

[webkit-dev] 'final' class specifier and 'final' method specifier

Hi WebKit devs, 'final' keyword can be applied to both a class and a method (non-static member function). I don't know correct terminology for them. I call them 'final' class specifier and 'final' method specifier. I'm now going to update WebKit Code Style Guidelines for using 'final' class