[webkit-dev] Tests failing because WPT images not served at correct URL?

Look at the expected results here . The results show “expected" failures like this one: "FAIL Image with usemap of #åωk should not

Re: [webkit-dev] Unified source builds: A new rule for static variables

Sent from my iPhone > On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: > > I doubt anyone is going to run such a script before they go to upload a > patch to bugzilla. EWS was what I was hoping for; likely to be sufficient. But it could also be integrated into the

Re: [webkit-dev] Unified source builds: A new rule for static variables

If we decide that we can’t support file scope identifiers then we should figure out the most practical way to do it. Of course this affects constants and variables, too, not just functions. I think this special FILENAME namespace isn’t all that helpful or needed. If a file contains a class

Re: [webkit-dev] Unified source builds: A new rule for static variables

How does this work? Without a “using” how does it know to search this namespace? Is this superior to using anonymous namespaces instead of “static”? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

> On Jul 31, 2017, at 2:04 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler <da...@apple.com> wrote: >> I don’t think we should add lots of includes of “config.h”, though. I think >> we can come up with some

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

We originally adopted this “config.h” style to make WebKit buildable with autotools. Since that has not been a consideration for years I would be willing to abandon this and change how we do things. I don’t think we should add lots of includes of “config.h”, though. I think we can come up with

Re: [webkit-dev] Does someone know how to fix WTF::Function on Windows

;> On Jul 15, 2017, at 9:14 AM, Yusuke SUZUKI <utatane@gmail.com> wrote: >> >> I'm not 100% confident, but can you try it `` instead? >> >> Regards, >> Yusuke Suzuki >> >>> On Sun, Jul 16, 2017 at 1:13 AM, Darin Adler <da...@apple.com&

[webkit-dev] Does someone know how to fix WTF::Function on Windows

Hi folks. On Windows, WTF::Function doesn’t quite work right. Code that is something like this: void addCallback(WTF::Function&&); void testFunction() { // ... } void addTestFunction() { addCallback(testFunction); } Leads to errors like

[webkit-dev] Why does our std::optional lack the has_value() function?

I noticed we don’t have has_value() in our version of std::optional. Does anyone know why? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Should we ever use std::function instead of WTF::Function?

I’ve noticed many patches switching us from std::function to WTF::Function recently, to fix problems with copying and thread safety. Does std::function have any advantages over WTF::Function? Should we ever prefer std::function, or should we use WTF::Function everywhere in WebKit where we

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 14, 2017, at 12:39 PM, Myles C. Maxfield wrote: > > However, a shared library would enforce layering naturally, whereas a static > library would need either an application to link to it and not to WebCore, > such as a unit test suite, or some out-of-band layering

Re: [webkit-dev] usage of auto

We probably need to step away from mandating style for a while until we have more consensus. I’m sad that we are so far away from that right now. I’ve found greatly increased use of auto during coding and refactoring that I am doing feels like it’s improving clarity quite at bit. From the

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 11, 2017, at 9:41 AM, Alexey Proskuryakov wrote: > > In a way, these are read-time assertions. Exactly. A type name is a read-time assertion of the specific type that a variable has and “auto” is a read-time assertion that the type of the variable is the same as the

Re: [webkit-dev] [webkit-reviewers] usage of auto

OK, you didn’t convince me but I can see that your opinions here are strongly held! — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 10, 2017, at 10:17 PM, Filip Pizlo wrote: > > while (Arg src = worklist.pop()) { > HashMap::iterator iter = > mapping.find(src); > if (iter == mapping.end()) { > // With a shift it's possible

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 10, 2017, at 9:49 PM, Darin Adler <da...@apple.com> wrote: > >> On Jan 10, 2017, at 9:46 PM, Simon Fraser <simon.fra...@apple.com> wrote: >> >> auto countOfThing = getNumberOfThings(); >> ASSERT(countOfThing >= 0); // Can’t tell by reading

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 10, 2017, at 9:46 PM, Simon Fraser wrote: > > auto countOfThing = getNumberOfThings(); > ASSERT(countOfThing >= 0); // Can’t tell by reading whether the ASSERT is > assured at compile time if countOfThing is unsigned I understand wanting to know, but I am not

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: > > We opted for WebCore to include files using “#include ” instead of > just including Foo.h. Will this work without ForwardingHeaders on macOS and iOS? Given that WTF chose , what is the reasoning for PAL choosing

Re: [webkit-dev] Thread naming policy in WebKit

I understand the appeal of “org.webkit” and structured names but personally I would prefer to read names that look like titles and are made up of words with spaces, like these: “WebKit: Image Decoder”, rather than “org.webkit.ImageDecoder”. “WebKit: JavaScript DFG Compiler” rather than

Re: [webkit-dev] Reducing the use of EncodedJSValue and use JSValue directly instead.

> On Jan 3, 2017, at 2:33 PM, Mark Lam wrote: > > I propose that we switch to using JSValue directly where we can. Sounds like a great idea to me. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Status of GTK EWS bot?

> On Oct 25, 2016, at 1:18 AM, Philippe Normand wrote: > > The GTK EWS is back online. Thanks! I was able to use the EWS results this morning to improve my patch. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Status of GTK EWS bot?

Hi folks. As I am uploading patches to for EWS processing I noticed that all the other platforms said “#1”, but gtk-wk2 said #85. Is this just the bot falling a bit behind because of load, or is there a more serious problem? This is important

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

> On Sep 7, 2016, at 1:57 AM, Maciej Stachowiak wrote: > > perhaps a syntax like Ref x = notNull(move(refPtr)) could be made to work It definitely can. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

> On Sep 6, 2016, at 6:43 PM, Maciej Stachowiak wrote: > > RefPtr does also have regular release() though. I'm not sure if this is for a > practical reason or just no one has fixed it yet. It’s still around until we finish getting rid of PassRefPtr, that’s all. > A wacky

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

> On Sep 6, 2016, at 4:48 PM, Maciej Stachowiak wrote: > > STL smart pointers have a 0-argument reset for non-returning remove instead, > and convention seems to be to use swap() or move() for the returning remove > on a smart pointer. So an alternate possibility would be to

[webkit-dev] Terminology for giving up ownership: take, release, move

Hi folks. WebKit has some critical functions that involve asking an object to give up ownership of something so the caller can take ownership. In the C++ standard library itself, this is called move, as in std::move. In WebKit smart pointers, we call this operation release, as in

Re: [webkit-dev] WebKit GObject bindings: Who is guiding their future?

Thanks for the frank discussion, guys. I do think we may be able to make the GObject bindings better and better over time even if they are hand written rather than generated. I understand that you want to keep them vital and up to date in a way that the Apple folks are not planning to do for

Re: [webkit-dev] WebKit GObject bindings: Who is guiding their future?

> On Aug 29, 2016, at 1:16 AM, Carlos Garcia Campos wrote: > > Does that mean than from the WebIDL point of view all methods can now > raise a exception? If don't tell the code generator that a method can > raise a exception, we assume all could return a Exception? Correct.

[webkit-dev] WebKit gobject bindings: Who is guiding their future?

Hi folks. You may have noticed the substantial improvements we’ve made to our WebIDL support over the last year. Also, the last few days I’ve been working on one small exciting improvement to our JavaScript bindings. We can express exceptions as a special return value inside the DOM

Re: [webkit-dev] "Fake" ref-tests

> On Jul 22, 2016, at 10:25 PM, Alexey Proskuryakov wrote: > > Simon and I were trying to move all tests out of platform/ directories. Is this nearly done? Can we take that feature out of the test running script? Anyone have any objections to this? — Darin

Re: [webkit-dev] "Fake" ref-tests

> On Jul 22, 2016, at 4:14 PM, Konstantin Tokarev wrote: > > What is the right way to deal with tests like these? I think we should move the tests into platform/mac. > I think it would be better to convert such tests to pixel tests. No, because we don’t run pixel tests. —

Re: [webkit-dev] JSObjectGetClass proposal

> On Jul 22, 2016, at 6:16 AM, Danilo Cesar Lemes de Paula > wrote: > > My > best option until now was defining a specific property during object > creation containing another object with the private pointer set to the > JSClassRef itself (as the main object SetPrivate

Re: [webkit-dev] On Mac and iOS ports, you may need to trigger clean rebuilds after r203337

> On Jul 20, 2016, at 4:08 PM, Ryosuke Niwa wrote: > > It looks like the binding generator doesn't re-generate .cpp files when > CodeGeneratorJS.pm is modified even though that dependency is explicitly > expressed in DerivedSources.make. Is that reproducible everywhere, or

Re: [webkit-dev] Request for comments on some bindings generator patches

> On Jul 19, 2016, at 8:36 PM, Nikos Andronikos > wrote: > > https://bugs.webkit.org/show_bug.cgi?id=158830 > This patch stops the IDL preprocessor from looking for the IDL file at all, > and all is well. What about “option 2” from this bug? Why aren’t we

Re: [webkit-dev] On Mac and iOS ports, you may need to trigger clean rebuilds after r203337

> On Jul 17, 2016, at 5:57 PM, Ryosuke Niwa wrote: > > Objective-C bindings files may fail to re-generate after > https://trac.webkit.org/changeset/203337. Do you know why? Can we fix it so we don’t have this problem again in the future? — Darin

Re: [webkit-dev] "No red pixels below" automation

> On Jul 16, 2016, at 10:21 AM, Konstantin Tokarev wrote: > > Yet another example: fast/layers/scroll-with-transform-composited-layer.html > > "All the boxes should only contain green content.” That one should be converted to a reference test. Note the comment inside the

Re: [webkit-dev] "No red pixels below" automation

> On Jul 16, 2016, at 8:45 AM, Konstantin Tokarev wrote: > > For example, I'm looking at fast/canvas/shadow-offset-* now. They are pixel > tests now. The simplest efficient way to turn these into reference tests that check that no red is visible would be by having the test

Re: [webkit-dev] "No red pixels below" automation

> On Jul 16, 2016, at 8:19 AM, Konstantin Tokarev wrote: > > There is a number of layout tests which are expected not to have red pixels > in case of pass. Some of them are purely pixel tests, which are not checked > by bots (and not often by humans), others have render

Re: [webkit-dev] Are there any plans to upgrade bugzilla server on bugs.webkit.org?

Yes, we definitely want to upgrade. It’s a bit of work. In the past, I think David Kilzer did some upgrades. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SPAM on trac.webkit.org

We are definitely going to have to change the policy on the wiki. The spam is being posted from multiple different email addresses, so banning accounts is not going to be sufficient. Who knows how to turn off modification to the Wiki while we decide how to lock it down? — Darin

Re: [webkit-dev] SPAM on trac.webkit.org

> On Apr 16, 2016, at 6:44 PM, Michael Catanzaro wrote: > > a wiki admin will have to clean this up I don’t think I’m an admin, but I was able to delete the pages. > (and ban the user). I don’t know how to do that. — Darin

Re: [webkit-dev] SPAM on trac.webkit.org

> On Apr 16, 2016, at 6:44 PM, Michael Catanzaro wrote: > > A bunch of spam pages are currently being created on the wiki. I don’t have > permission to delete the pages I deleted them. If this continues then we can change the rules for the Wiki. — Darin

Re: [webkit-dev] BigO correlation tests

> On Apr 13, 2016, at 12:18 PM, Ryosuke Niwa wrote: > > I think Darin likes these tests. I love the idea of them and I’d like to see us write more. Changing our algorithms to be efficient for large data sets is a tricky problem and an easy way to write a test that cleanly

[webkit-dev] Is someone going to fix Windows EWS?

Every patch I look at has a red bubble for Windows on EWS. Is someone planning on fixing this? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SPAM on trac.webkit.org

> On Mar 30, 2016, at 4:00 AM, Osztrogonác Csaba wrote: > > Just out of curiosity, why trac.webkit.org WIKI can be editable by everybody? > Shouldn't we restrict it for only contributors who are present in > contributors.json? I think it’s just a result of our original

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

> On Mar 17, 2016, at 9:35 AM, Konstantin Tokarev wrote: > > Here is a script which apparently can be used to convert whole code base to > new style: > > https://github.com/cgmb/guardonce They sound like they are worth trying. Especially the “checkguard” script. Whoever

Re: [webkit-dev] Fonts for WebKit tests on OS X?

I don’t think the size of the font files in the repository is a significant issue; are the sizes particularly huge compared to the total size of all the layout tests including expected results? If this was a problem, we could come up with some other way of having the test machinery download the

Re: [webkit-dev] Regarding CVE-2014-1303

Much of the information about WebKit security bugs and their fixes is available only to members of the WebKit Security Group. Details here . Typically there is no critical reason for someone outside that group needs the specifics of one particular bug that

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

> On Mar 4, 2016, at 10:51 AM, Michael Catanzaro wrote: > > We had a GTK port bug caused by a missing virtual destructor recently. Oh no! > GCC and Clang have warnings for this, which I think should be enabled, but > apparently were not or somehow didn't work. I’d like

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

> On Mar 4, 2016, at 10:51 AM, Michael Catanzaro wrote: > >> - Style guide should encourage programmers to use final instead of override >> whenever possible. I suspect many of the functions that currently are tagged >> override should be final instead. Agreed? > >

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

I think when de-finalizing the class we likely don't want to de-finalize all the overrides. Only ones where we need to override. — Darin Sent from my iPhone > On Mar 4, 2016, at 10:39 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > 04.03.2016, 21:32, "Darin Adl

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

Here are three other loose ends I am thinking about: - Style guide should say that in a class marked final, virtual functions should all be marked final, not override and certainly not virtual. Agreed? Can we check that with the script? Apply that rule globally like we just did with the other

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

> On Mar 4, 2016, at 9:11 AM, Antonio Gomes wrote: > > It is a good follow up I agree. > once the first patch bakes for a while I don’t think we need “bake time” for this. It’s super-straightforward. I’m going to do it right now. — Darin

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

> On Mar 4, 2016, at 9:03 AM, Konstantin Tokarev wrote: > > I've done different thing - added override specifiers wherever clang deduces > they are needed. Sounds good. > Here is my patch: https://bugs.webkit.org/show_bug.cgi?id=155021 I’m looking now. — Darin

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

> On Mar 4, 2016, at 6:54 AM, Konstantin Tokarev wrote: > > I have WebCore patch ready for upload. Yes, I had already done this last night . Just haven’t landed it yet because tiled-drawing tests were failing. Fixing that now.

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

OK! Do we have volunteers to: 1) update the style guide webpage 2) update check-webkit-style 3) physically restrain me from turning do-webcore-rename into a perl script that does this all the code in the entire source tree all at one go, since that would be a bad idea, right? — Darin

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

Antti proposed using only “override” a while back since it’s less verbose and still unambiguous. I don’t think we reached consensus on which style to prefer for the project, though. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Is MIMETypeRegistry::canShowMIMEType supposed to accept lowercase or unknown case?

> On Feb 12, 2016, at 5:33 AM, Konstantin Tokarev wrote: > > In WebProcess/WebPage/WebPage.cpp MIMETypeRegistry::canShowMIMEType seems to > be called with argument of unknown case (the same string is then looked up in > ASCIICaseInsensitiveHash). > > However,

Re: [webkit-dev] Thought about Nix JavaScriptCore port

> On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: > > 10.02.2016, 05:41, "Eric Wing" : >> - I don't know what parts JSC actually needs to know what I can safely remove > > I second this request, it would be great if WebKit had a documentation which

Re: [webkit-dev] Preferred style for checking for undefined in our built-in JavaScript code?

> On Nov 30, 2015, at 11:57 AM, Geoffrey Garen wrote: > > For the time being, I like “x === undefined”. > > Long term, I’d like us to switch to “x === @undefined”. > > We use @ to indicate reserved words in built-ins. Currently, “@undefined" > does not exist, but the

[webkit-dev] Preferred style for checking for undefined in our built-in JavaScript code?

I see the following in some code: if (xxx === undefined) And I see the following in some other code: if (typeof xxx == “undefined”) or if (typeof xxx === “undefined”) Is one preferred over the other, style-wise? Is one more efficient than the other? — Darin

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

> On Nov 18, 2015, at 4:36 AM, Carlos Alberto Lopez Perez > wrote: > > Some reference tests give a 1-pixel or very few pixel differences [1]. Why? We need to understand why. > Should we tolerate a few pixel differences for reftests ? I don’t think we should. I think we

Re: [webkit-dev] Trying to turn WebRTC's code on - MEDIA_STREAM flags

> On Jul 18, 2014, at 3:17 AM, Jacques-Olivier wrote: > > "__ZN7WebCore11JSNavigator18webkitGetUserMediaEPN3JSC9ExecStateE", > referenced from: > > __ZN7WebCore46jsNavigatorPrototypeFunctionWebkitGetUserMediaEPN3JSC9ExecStateE > in JSNavigator.o >

[webkit-dev] Windows EWS not working?

I was looking at the patch in this bug: https://bugs.webkit.org/show_bug.cgi?id=150967 The patch was posted 20 hours ago. EWS has processed this for all platforms other than Windows, but it says “win #61”, so it seems like the Windows bot has 60 other patches to process before getting to this

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

> On Nov 5, 2015, at 11:24 PM, L. David Baron wrote: > > For what it's worth, Gecko does have code to produce a > minimal-length alpha value. nsStyleUtil::ColorComponentToFloat just > tries rounding to 2 decimal places, sees if the resulting float > round-trips back to the

Re: [webkit-dev] Implementing Web Animations

> On Nov 4, 2015, at 6:19 PM, Nikos Andronikos > wrote: > > The current plan, after chatting to Dean at TPAC, will be to implement the > web animations model as a new module, with a runtime flag for switching CSS > and SVG animations over to use the new

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

> On Nov 3, 2015, at 11:10 AM, Maciej Stachowiak wrote: > > Minimal strings should round trip ok, but will it still be accurate enough if > the client attempts to do math with them? I was thinking about the same thing this morning. If we don’t want them minimal, then how many

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

> On Nov 2, 2015, at 8:37 AM, Simon Fraser <simon.fra...@apple.com> wrote: > >> On Nov 1, 2015, at 7:40 PM, Darin Adler <da...@apple.com> wrote: >> >> 1) Does the CSS specification allow or encourage this? > > As long as the values round-trip, I think

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

> On Nov 2, 2015, at 8:37 AM, Simon Fraser wrote: > > I would like to know what other browsers do. Someone should check Firefox and IE, I guess. I think it’s likely that Chrome still has the behavior that Blink inherited from WebKit when Google forked it, and someone

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

> On Nov 2, 2015, at 2:34 AM, Gavin Barraclough wrote: > > I guess if you just store the fractions as BCD & unpack you can get the table > size down to 512 bytes. I like that approach. (I’d probably leave leave off the first F from each one and then use 3 instead of 4

[webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

Hi folks. Our engine supports alpha values from 0-255. But when we serialize them, we turn them into floating point values. When we do that, we include way too many digits of precision. For example, the alpha value 127 becomes 0.498039. I like the idea of writing the minimum number of digits

[webkit-dev] Removing ENABLE(OPENCL)

Looks like http://trac.webkit.org/changeset/170208 last June removed all WebKit OpenCL code, but left behind unused ENABLE(OPENCL) cases. I plan to remove those. Any objections? — Darin___ webkit-dev mailing

Re: [webkit-dev] How does WebKit accessibility code tell VoiceOver that a page has finished loading?

> On Oct 1, 2015, at 4:10 PM, Frédéric WANG wrote: > > Hi, > > When Safari has finished loading a page, VoiceOver plays an ascending > three tone sound effect, selects the web document and starts reading the > page. I'm trying to reproduce this effect on Firefox for Mac (see

Re: [webkit-dev] Bugzilla default assignees

> On Sep 27, 2015, at 5:52 PM, Michael Catanzaro wrote: > > On Mon, 2015-09-14 at 09:39 -0700, Alexey Proskuryakov wrote: >> Yet another approach used by the Accessibility component is to have a >> technical account auto-CC'ed, and then anyone interested can follow >> this

Re: [webkit-dev] Bugzilla default assignees

> On Sep 28, 2015, at 3:07 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, 2015-09-28 at 14:32 -0700, Darin Adler wrote: >> Yes, I’m sure someone can help. Do you have the accounts for each >> component? Then we can add these to the auto-CC list. &

Re: [webkit-dev] Bugzilla default assignees

> On Sep 28, 2015, at 3:09 PM, Darin Adler <da...@apple.com> wrote: > >> On Sep 28, 2015, at 3:07 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: >> >> On Mon, 2015-09-28 at 14:32 -0700, Darin Adler wrote: >>> Yes, I’m sure someone can help. Do

Re: [webkit-dev] Bugzilla default assignees

> On Sep 28, 2015, at 3:07 PM, Michael Catanzaro wrote: > > I was thinking it might be possible to just add some fake email addresses to > the auto-CC list, like webkitgtk-ma...@webkit.bugs I poked around a little. I don’t think it’s easy to do this. > But if we need to

Re: [webkit-dev] Using JavaScriptCore in an audio context

> On Sep 22, 2015, at 8:32 AM, Stéphane Letz wrote: > > since the asm.js code does not allocate memory Unlike C and C++, JavaScript doesn’t directly expose a concept of “allocating memory” so I’m not sure what it means to say that. Any JavaScript code, including “asm.js code”

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

Even if we remove the obsolete WTF classes, we might still want a checker rule about the ones in the std namespace. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WinCairo Stability

These all look like backtraces from assertion failures. If you are working on WebKit, the next step would be to figure out which assertion is failing. If you’re looking for greater stability, you could try a release build instead of a debug build, which won’t include the assertions. I’m not

[webkit-dev] Proposal: Remove CSS color-correction property

Hi folks. WebKit has a CSS property named color-correction. It’s still prefixed, so some would call it -webkit-color-correction and I don’t think it’s yet been proposed as a CSS standard. Apple engineers added this a while back so that WebKit could continue interpret webpage and image colors

Re: [webkit-dev] JavaScriptCore performance is very slow on Windows

On Jun 29, 2015, at 6:17 PM, Eric Wing ewmail...@gmail.com wrote: On 6/29/15, Filip Pizlo fpi...@apple.com wrote: WebKit-dev is really not the place where you should be posting performance problems. Please create a bug on bugs.webkit.org. Okay, I just filed radar://21604141

Re: [webkit-dev] WTF and STL

On Jun 23, 2015, at 1:40 AM, youenn fablet youe...@gmail.com wrote: Vector Many features in WTF::Vector are critical to performance, such as inline capacity, the specifics of its growth strategy, functions to preallocate at a particular size, and to trim once allocated. Some might have

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

Are we making progress in this discussion? Maciej stated that he thinks this is useful for mailto and I think that Gyuyoung Kim and Michael Catanzaro stated that they want to do this. As one next step in the discussion, is there anyone that wants to present a use case for a protocol other than

Re: [webkit-dev] run-webkit-tests and run-perf-tests scripts now use WebKitTestRunner by default

On Apr 12, 2015, at 10:29 AM, Simon Fraser simon.fra...@apple.com wrote: I think that now we’ve done this, we should make LayoutTests/platform/mac/ contain WK2 results by default, and place WK1 exceptions in platform/mac-wk1. Same for other platforms. Thoughts? I agree, we should do

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object Library.

Re: [webkit-dev] Modern image formats for WebKit

We should consider whether to keep the image format decoders in the WebKit tree or not. Dave Hyatt originally created this when we first were planning the Apple Windows port of WebKit, but in the end we chose to not use them for the Windows port. They aren’t used in the Windows port nor in the

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

On Mar 9, 2015, at 5:02 PM, Steven Coul (scoul) sc...@cisco.com wrote: The IDL processing time went from 139 seconds real time to 105. 34 seconds sounds like substantial savings. What’s the total build time for you on that computer? — Darin ___

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

On Mar 9, 2015, at 5:39 AM, Steven Coul (scoul) sc...@cisco.com wrote: Would [Conditional] use through out also not allow us to perform the IDL compile without running the c preprocessor on each file? Possibly. Can [Conditional] not be fixed to support multiple flags? It does support

[webkit-dev] [Conditional=] vs. #if in IDL files

Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past? Should we use #if or [Conditional]? See for example, HTMLMediaElement.idl, which has a mix of both styles. It’s pretty ugly how the #if look in the IDL files, but even worse is a

Re: [webkit-dev] Move WebKit Objective-C code to ARC?

On Feb 24, 2015, at 9:34 AM, Anders Carlsson ander...@apple.com wrote: ARC doesn’t work on 32-bit Intel. It also doesn’t work with GC. Oops. OK, some day when we don’t need to support either of those on Mac. I guess it will be a while. — Darin ___

[webkit-dev] Move WebKit Objective-C code to ARC?

Hi folks. I believe that WebKit tip of tree on the Cocoa platforms now supports platforms with a new-enough version of the Objective-C runtime that we could move our Objective-C code to use ARC instead of manual retain/release. Does anyone know of a reason we couldn’t start making this change

Re: [webkit-dev] WEBCORE_EXPORT

Hooray! Lets document these somewhere so people don’t have to read the webkit-dev archives to learn these rules. Maybe in the header that defines WEBCORE_EXPORT? Maybe in a webpage somewhere on webkit.org? — Darin ___ webkit-dev mailing list

Re: [webkit-dev] Pattern for singleton classes instance getters

I like the economy of the smaller non-member function name; it seems overly wordy to be constantly stating the class name as well as the nearly meaningless word “shared”. I think the word “shared” is what I like least about the member function approach. It had always thought that we used

Re: [webkit-dev] Unused parameter warnings / errors / warning fixes

I have found serious bugs in WebKit with unused parameter warnings; I found some when first turning on the warning. I don’t have a specific story to tell, but I remember there was more than one case. So far it’s been impractical to turn on this warning for our Objective-C code, since we can’t

Re: [webkit-dev] Unused parameter warnings / errors / warning fixes

On Jan 26, 2015, at 10:11 AM, Filip Pizlo fpi...@apple.com wrote: So I actually do the opposite of pushing the configuration conditionals to the edges - I put them into the innards. Yes, this explains why the unused argument warnings are so frustrating for you! I don’t know what it says for

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

On Jan 22, 2015, at 10:36 PM, Alexey Proskuryakov a...@webkit.org wrote: 22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а): What about the test I cited? svg/css/svg-resource-fragment-identifier-img-src.html This particular test is buggy - it is a hidpi test, so it dumps

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

On Jan 22, 2015, at 11:30 AM, Simon Fraser simon.fra...@apple.com wrote: For example, some of the tests in question render a green box either via CALayers, or by painting, and there’s a slight color difference between the two code paths. What about the test I cited?

[webkit-dev] run-webkit-tests question; hashes when comparing ref test output

I noticed that when running tests I get messages like this: svg/css/svg-resource-fragment-identifier-img-src.html - ref test hashes didn't match but diff passed I understand that we can have hash mismatches in actual checked in images (expected.png files), and there, at least, I believe

Re: [webkit-dev] FTP directory support

On Jan 5, 2015, at 12:54 AM, Benjamin Poulain benja...@webkit.org wrote: Isn't it used by iOS? I remember fixing a bug for it last year. Yes, another engineer from Apple told me it is. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

<    1   2   3   4   5   6   7   8   9   10   >