Re: [webkit-dev] Breakpoints in #included .cpp files [Was: Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)]

On Tue, Aug 29, 2017 at 8:48 PM, Simon Fraser wrote: > > On Aug 28, 2017, at 9:46 PM, Geoffrey Garen wrote: > > > >> The line numbers and filenames will be total nonsense if we just > concatenate multiple source files together. But that's very easy to

Re: [webkit-dev] canvas and sRGB

On Mon, May 2, 2016 at 2:59 PM, Dean Jackson <d...@apple.com> wrote: > > On 3 May 2016, at 7:04 AM, Rik Cabanier <caban...@gmail.com> wrote: > > > > On Mon, May 2, 2016 at 1:58 PM, Simon Fraser <simon.fra...@apple.com> > wrote: > >> On May 2, 20

Re: [webkit-dev] canvas and sRGB

On Mon, May 2, 2016 at 1:58 PM, Simon Fraser <simon.fra...@apple.com> wrote: > On May 2, 2016, at 1:45 PM, Rik Cabanier <caban...@gmail.com> wrote: > > All, > > with the release of DCI-P3 screen, WebKit began supporting the display of > high gamut images. > S

[webkit-dev] canvas and sRGB

All, with the release of DCI-P3 screen, WebKit began supporting the display of high gamut images. Specifically, if you have an image with a DCI-P3 profile, its pixels render untouched on the new displays. However, if you try do do any sort of canvas manipulation, you will see that the colors are

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

Hi Filip, very interesting to see you change out such a fundamental algorithm! It's amazing that it works. Reading the code, it seems very comparable to Windows' critical sections [1]. Is that the case? Looking at github and msdn, 4000 seems to be the most common number of spins. I believe your

Re: [webkit-dev] Adding support for gradient midpoint

On Tue, Sep 30, 2014 at 9:30 AM, Darin Adler da...@apple.com wrote: On Sep 29, 2014, at 1:57 PM, Benjamin Poulain benja...@webkit.org wrote: What is the bug number for tracking this? https://bugs.webkit.org/show_bug.cgi?id=137171 Thanks! I accidentally sent the reply just to Benjamin.

[webkit-dev] Adding support for gradient midpoint

All, I'm planning on adding support for gradient midpoints.[1] Since this is such a small addition, the feature will not be behind a feature flag and will be enabled by default. Let me know if you have questions or concerns with this approach 1:

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 2:21 PM, Dean Jackson d...@apple.com wrote: On 6 May 2014, at 11:13 am, Rik Cabanier caban...@gmail.com wrote: On Mon, May 5, 2014 at 5:52 PM, Simon Fraser simon.fra...@apple.comwrote: It allows attackers to know even more about my system, exposing more data

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 2:47 PM, Oliver Hunt oli...@apple.com wrote: On May 7, 2014, at 2:41 PM, Rik Cabanier caban...@gmail.com wrote: When would I as a user, not want a page or web application to be as fast as possible? Has a user ever complained about a desktop app that uses too many

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 2:57 PM, Benjamin Poulain benja...@webkit.orgwrote: On 5/7/14, 2:47 PM, Oliver Hunt wrote: On May 7, 2014, at 2:41 PM, Rik Cabanier caban...@gmail.com wrote: When would I as a user, not want a page or web application to be as fast as possible? Has a user ever

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 3:19 PM, Oliver Hunt oli...@apple.com wrote: On May 7, 2014, at 3:15 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 2:47 PM, Oliver Hunt oli...@apple.com wrote: On May 7, 2014, at 2:41 PM, Rik Cabanier caban...@gmail.com wrote: When would I

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

, Rik Cabanier caban...@gmail.com mailto:caban...@gmail.com wrote: On Wed, May 7, 2014 at 3:19 PM, Oliver Hunt oli...@apple.com mailto:oli...@apple.com wrote: On May 7, 2014, at 3:15 PM, Rik Cabanier caban...@gmail.com mailto:caban...@gmail.com wrote: On Wed, May 7, 2014

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 7:58 PM, Brady Eidson beid...@apple.com wrote: On May 7, 2014, at 5:38 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 5:07 PM, Benjamin Poulain benja...@webkit.orgwrote: On 5/7/14, 4:13 PM, Benjamin Poulain wrote: On 5/7/14, 3:52 PM, Filip

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

may or may not be number of cores - depending on system load. I think we can eventually do that. The issue is that the problem quickly spirals out of control which makes finding a solution and coming to a consensus harder. On May 7, 2014, at 7:38 PM, Rik Cabanier caban...@gmail.com wrote

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Wed, May 7, 2014 at 9:32 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, May 7, 2014 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 7:58 PM, Brady Eidson beid...@apple.com wrote: On May 7, 2014, at 5:38 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May

[webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

All, there's a thread on blink-dev [1] and whatwg [2] to create a new parameter on the navigator object that returns the maximum number of tasks that can run in parallel. [3] Is this something that WebKit would support? 1:

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

threading) On May 5, 2014 at 4:49:35 PM, Rik Cabanier (caban...@gmail.com) wrote: All, there's a thread on blink-dev [1] and whatwg [2] to create a new parameter on the navigator object that returns the maximum number of tasks that can run in parallel. [3] Is this something that WebKit would

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

create one? :-) -Phil On May 5, 2014 at 4:49:35 PM, Rik Cabanier (caban...@gmail.com) wrote: All, there's a thread on blink-dev [1] and whatwg [2] to create a new parameter on the navigator object that returns the maximum number of tasks that can run in parallel. [3] Is this something

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

On Mon, May 5, 2014 at 6:23 PM, Oliver Hunt oli...@apple.com wrote: On May 5, 2014, at 6:13 PM, Rik Cabanier caban...@gmail.com wrote: Do you really want a page to know that you have a fancy-pants 24-core Mac Pro rather than a little Mac mini? Yes! If I have 24 cores ready to do work

Re: [webkit-dev] Remove CANVAS_PATH compiler flag where possible

On Wed, Apr 16, 2014 at 1:18 PM, Dirk Schulze k...@webkit.org wrote: Hi, I would like to ask to remove the CANVAS_PATH compiler flag from WebCore where possible. At the moment it guards the Path2D object and all related methods in Canvas like: void fill(Path2D path, optional

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

this discussion back to WebApps WG or WHATWG instead of spamming webkit-dev. - R. Niwa On Monday, October 14, 2013, Rik Cabanier wrote: On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. On Oct 10, 2013, at 7:32 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:26 PM

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Mon, Oct 14, 2013 at 2:46 PM, Chris Fleizach cfleiz...@apple.com wrote: On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Mon, Oct 14, 2013 at 2:58 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:50 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Thu, Oct 10, 2013 at 1:14 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Oct 9, 2013 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote: I'd like to add for focus rings. They are currently specified in the w3c and whatwg canvas specs: http://www.whatwg.org/specs/web-apps/current-work

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Thu, Oct 10, 2013 at 5:49 PM, Chris Fleizach cfleiz...@apple.com wrote: On Oct 10, 2013, at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 1:14 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Oct 9, 2013 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: Support (behind runtime flags) has landed in: - Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=540456 - chrome: https://code.google.com/p

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Thu, Oct 10, 2013 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.comwrote

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.comwrote: Support (behind runtime flags) has landed in: - Firefox: https

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

On Thu, Oct 10, 2013 at 7:13 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 7:09 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.comwrote: On Thu

Re: [webkit-dev] Proposal: Add support for Promises

That sounds like a great idea! The blink people are running into a bunch of issues by implementing them on the C++ side as opposed to inside the VM. Implement them in JavaScript seems like the right approach. On Fri, Aug 23, 2013 at 11:32 AM, Sam Weinig wei...@apple.com wrote: Hey WebKittens,

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

Things are not that bad. (See Shadow DOM for instance where people begged for it to become a standard) You should definitely write something up and have a working prototype that demonstrates how your solution improves performance, cleaner implementations, etc. You will also have to prove that

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg zherc...@webkit.org wrote: A message passing model a la Web Workers has some advantages compared to threads with shared mutable state and locks: - No possibility of deadlock - No possibility of corrupting data structures due to races - No

Re: [webkit-dev] New web-facing canvas feature: opaque attribute

The main reason for this feature is to enhance performance of canvas operations. Are we certain that this will always be the case? For instance, is google going to make certain that the cairo and core graphics backends don't slow down? Rik On Wed, Mar 13, 2013 at 1:21 PM, Brandon Jones

Re: [webkit-dev] New web-facing canvas feature: opaque attribute

channel will fail... does globalAlpha still work? It's sad that WebGL picked such a generic name that isn't about all alpha related things. On Wed, Mar 13, 2013 at 2:59 PM, Rik Cabanier caban...@gmail.com wrote: The main reason for this feature is to enhance performance of canvas operations

[webkit-dev] Adding blending mode to background images

Hi, I'd like to add support for blending of background images. The spec for this feature can be found here: * https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode * The implementation will be tracked by a meta bug: * https://bugs.webkit.org/show_bug.cgi?id=108546*

Re: [webkit-dev] Adding blending mode to background images

:09 PM, Dirk Schulze k...@webkit.org wrote: Hi Rik, Can you just add an example for the better understanding please? Greetings, Dirk On Feb 2, 2013, at 6:43 AM, Rik Cabanier caban...@gmail.com wrote: Hi, I'd like to add support for blending of background images. The spec

Re: [webkit-dev] Adding blending mode to background images

='mix-blend-mode: difference'/ /div 1: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#mix-blend-mode On Fri, Feb 1, 2013 at 1:01 PM, Benjamin Poulain benja...@webkit.orgwrote: On Fri, Feb 1, 2013 at 12:44 PM, Rik Cabanier caban...@gmail.com wrote: background-image: url(a.png

Re: [webkit-dev] Adding blending mode to background images

On Fri, Feb 1, 2013 at 1:08 PM, Dirk Schulze dschu...@adobe.com wrote: On Feb 2, 2013, at 8:01 AM, Benjamin Poulain benja...@webkit.org wrote: On Fri, Feb 1, 2013 at 12:44 PM, Rik Cabanier caban...@gmail.com wrote: background-image: url(a.png), url(b.png); -webkit-background-blend-mode

[webkit-dev] Fwd: Proposal: Add CanvasRenderingContext2D.fillRule with nonzero (default) and evenodd options

: https://bugs.webkit.org/show_bug.cgi?id=106188 Please let me know if there are any objections. Rik On Wed, Jan 9, 2013 at 11:59 AM, Tab Atkins Jr. jackalm...@gmail.comwrote: On Wed, Jan 9, 2013 at 11:42 AM, Rik Cabanier caban...@gmail.com wrote: Do people have an opinion on a boolean value vs

Re: [webkit-dev] Proposal: Add webkitFillRule to canvas

I think this feature was rushed in the spec. Can we hold off submitting this until people have a chance to think it through? It seems innocent enough to make this part of the graphic state but I believe this is the wrong place (since no graphic library except cairo did it this way) and will give

Re: [webkit-dev] Proposal: Add webkitFillRule to canvas

On Fri, Jan 4, 2013 at 2:57 PM, Ian Hickson i...@hixie.ch wrote: On Fri, 4 Jan 2013, Rik Cabanier wrote: I think this feature was rushed in the spec. The specing is usually the first step. You can't rush to spec. :-) In this particular case, though, it was the third or fourth step

Re: [webkit-dev] Proposal: Add webkitFillRule to canvas

On Fri, Jan 4, 2013 at 5:42 PM, Dirk Schulze dschu...@adobe.com wrote: On Jan 4, 2013, at 5:24 PM, Rik Cabanier caban...@gmail.com wrote: On Fri, Jan 4, 2013 at 2:57 PM, Ian Hickson i...@hixie.ch wrote: On Fri, 4 Jan 2013, Rik Cabanier wrote: I think this feature was rushed

Re: [webkit-dev] Proposal: Add webkitFillRule to canvas

On Fri, Jan 4, 2013 at 8:04 PM, Dirk Schulze dschu...@adobe.com wrote: On Jan 4, 2013, at 7:28 PM, Rik Cabanier caban...@gmail.com wrote: On Fri, Jan 4, 2013 at 5:42 PM, Dirk Schulze dschu...@adobe.com wrote: On Jan 4, 2013, at 5:24 PM, Rik Cabanier caban...@gmail.com wrote

Re: [webkit-dev] Adding blending mode to WebKit canvas

On Wed, Nov 14, 2012 at 1:37 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 14, 2012, at 8:33 AM, Rik Cabanier caban...@gmail.com wrote: On Tue, Nov 13, 2012 at 11:19 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 13, 2012, at 4:43 PM, Rik Cabanier caban...@gmail.com wrote

Re: [webkit-dev] Adding blending mode to WebKit canvas

Maciej, did this sound reasonable to you? Would you object if Canvas combines blending and compositing but not CSS? Rik On Mon, Nov 12, 2012 at 3:46 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Nov 12, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 11, 2012, at 9

Re: [webkit-dev] Adding blending mode to WebKit canvas

On Sun, Nov 11, 2012 at 5:25 PM, Dirk Schulze dschu...@adobe.com wrote: On Nov 9, 2012, at 4:39 PM, Rik Cabanier caban...@gmail.com wrote: Hi, I'd like to add support for blending modes to Canvas. The spec for this feature can be found here: https://dvcs.w3.org/hg/FXTF/rawfile/tip

Re: [webkit-dev] Adding blending mode to WebKit canvas

On Sun, Nov 11, 2012 at 8:43 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 11, 2012, at 6:59 PM, Rik Cabanier caban...@gmail.com wrote: Wouldn't it be better to add a new property to canvas for blending? At the beginning, implementations are just require to use different blend

Re: [webkit-dev] Adding blending mode to WebKit canvas

On Sun, Nov 11, 2012 at 9:52 PM, Dirk Schulze k...@webkit.org wrote: On Sunday, November 11, 2012, Rik Cabanier wrote: On Sun, Nov 11, 2012 at 8:43 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 11, 2012, at 6:59 PM, Rik Cabanier caban...@gmail.com wrote: Wouldn't it be better

[webkit-dev] Adding blending mode to WebKit canvas

Hi, I'd like to add support for blending modes to Canvas. The spec for this feature can be found here: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#canvascompositingandblending The implementation will be tracked by a meta bug: https://bugs.webkit.org/show_bug.cgi?id=100069 I

Re: [webkit-dev] On returning mutable pointers from const methods

It is valid for a const method to return you a new object ie a const factory object. In that case, const-ness would not be desired. Rik On Thu, Oct 25, 2012 at 3:48 AM, Andreas Kling kl...@webkit.org wrote: Yo WebKittens! After some mild morning discussion in #webkit, I'm wondering if we

Re: [webkit-dev] On returning mutable pointers from const methods

On Fri, Oct 26, 2012 at 9:06 AM, Peter Kasting pkast...@google.com wrote: On Fri, Oct 26, 2012 at 8:27 AM, Rik Cabanier caban...@gmail.com wrote: It is valid for a const method to return you a new object ie a const factory object. In that case, const-ness would not be desired. Not really

Re: [webkit-dev] New Feature: Canvas Path object

On Mon, Sep 24, 2012 at 10:27 AM, Darin Adler da...@apple.com wrote: On Sep 22, 2012, at 9:21 PM, Elliott Sprehn espr...@chromium.org wrote: On Fri, Sep 21, 2012 at 6:34 AM, Dirk Schulze dschu...@adobe.com wrote: I would like to ask if there are objections to implement the canvas Path

Re: [webkit-dev] Adding CSS blending to WebKit

, at 8:50 AM, Rik Cabanier caban...@gmail.com wrote: I'm planning on adding CSS blending to WebKit: https://bugs.webkit.org/show_bug.cgi?id=91908 We already have a working prototype and I will bring it over as a couple of patches. We did a couple of write-ups on this feature: https

[webkit-dev] Adding CSS blending to WebKit

. Rik Cabanier Adobe Systems ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Timing attacks on CSS Shaders (was Re: Security problems with CSS shaders)

This might no longer be true, but isn't it the case that shaders are designed to take the same amount of time to execute, no matter what input they get? ie if you have an if/else block, the time of the shader would be whatever block takes the longest. This was done so you can schedule many of them

Re: [webkit-dev] Starting implementation on W3C Filter Effects

Dean, could you implement the filters on top of shaders if the target has WEBGL acceleration? Doing animated filters in software will be slow unless you spend a significant amount of time on coding SSE or NEON instructions. Rik On Mon, Oct 24, 2011 at 9:02 PM, Dean Jackson d...@apple.com wrote: