Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Ryosuke Niwa
The patch has been landed successfully. Thanks all for your help. - Ryosuke On Wed, Mar 2, 2011 at 3:21 PM, Ryosuke Niwa wrote: > Hi, > > *When is the best time to land a massive patch that requires rebaselines > of about 165 tests?* > > I'm going to land my > patch

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Osztrogonac Csaba
Ooops, I miscalculated. :) (All times are in 24h format.) The following interval is good for me everyday. 08:00 - 02:00 in CET 23:00 - 17:00 in PST 16:00 - 10:00 in JST Osztrogonac Csaba írta: I'm in CET, but I'm flexible. I will have time between 08:00-02:00 in CET, 17:00-11:00 in PST and 0:00

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Osztrogonac Csaba
I'm in CET, but I'm flexible. I will have time between 08:00-02:00 in CET, 17:00-11:00 in PST and 0:00-18:00 in JST. Please tell me the exact time and I will be online at the time. Ossy Ryosuke Niwa írta: *When is the best time to land a massive patch that requires rebaselines of about 165 test

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Ryosuke Niwa
Since Windows 7 is green now, can I try to land it 2 hours from now? http://www.timeanddate.com/worldclock/meetingdetails.html?year=2011&month=3&day=2&hour=11&min=0&sec=0&p1=248&p2=195&p3=179&p4=224 - Ryosuke On Wed, Mar 2, 2011 at 7:24 PM, Sergio Villar Senin wrote: > En 02/03/11 10:53, Benjam

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Sergio Villar Senin
En 02/03/11 10:53, Benjamin escribiu: > On Wed, Mar 2, 2011 at 7:36 AM, Ryosuke Niwa > wrote: > > I'm specifically asking for the convenient time for Chromium, GTK, > Qt, and Windows ports since they have test bots running on > build.webkit.org

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-02 Thread Benjamin
On Wed, Mar 2, 2011 at 7:36 AM, Ryosuke Niwa wrote: > I'm specifically asking for the convenient time for Chromium, GTK, Qt, and > Windows ports since they have test bots running on build.webkit.org. For Qt, most people are in CET timezone. It would be nice if you wait for the test bot to be ba

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-01 Thread Ryosuke Niwa
On Wed, Mar 2, 2011 at 3:39 PM, Maciej Stachowiak wrote: > > Why does a fix for an assertion failure require so many test results to > change? Perhaps the bug should be retitled to describe the problem that > requires such a wide-ranging behavior change. > It changes the way selection offsets are

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-01 Thread Maciej Stachowiak
On Mar 1, 2011, at 10:21 PM, Ryosuke Niwa wrote: > Hi, > > When is the best time to land a massive patch that requires rebaselines of > about 165 tests? > > I'm going to land my patch for the bug 51389 within the next 24 hours but the > patch is 688KB > and rebaselines 186 tests, of which 165

Re: [webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-01 Thread Ryosuke Niwa
I'm specifically asking for the convenient time for Chromium, GTK, Qt, and Windows ports since they have test bots running on build.webkit.org. - Ryosuke On Wed, Mar 2, 2011 at 3:21 PM, Ryosuke Niwa wrote: > Hi, > > *When is the best time to land a massive patch that requires rebaselines > of a

[webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

2011-03-01 Thread Ryosuke Niwa
Hi, *When is the best time to land a massive patch that requires rebaselines of about 165 tests?* I'm going to land my patchfor the bug 51389 within the next 24 hours but the patch is 68