Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2020-04-03 Thread Keith Miller
Resurrecting this from the dead because it came up in: https://bugs.webkit.org/show_bug.cgi?id=209979 > On May 10, 2019, at 5:34 PM, Alexey Proskuryakov wrote: > > >> 10 мая 2019 г., в 13:50, Darin Adler > > написал(а): >> >>> On May 10, 2019, at 1:13 PM, Keith Miller

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Alexey Proskuryakov
> 10 мая 2019 г., в 13:50, Darin Adler написал(а): > >> On May 10, 2019, at 1:13 PM, Keith Miller wrote: >> >> I’m not sure I know what you mean by allow a whole-directory exception. Do >> you mean a top level directory? Or some kind of parameter we pass to the >> hook to ignore some

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Darin Adler
> On May 10, 2019, at 1:13 PM, Keith Miller wrote: > > I’m not sure I know what you mean by allow a whole-directory exception. Do > you mean a top level directory? Or some kind of parameter we pass to the hook > to ignore some directory for that run? I meant that we could add something the

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Keith Miller
> On May 10, 2019, at 1:07 PM, Darin Adler wrote: > >> On May 10, 2019, at 1:00 PM, Keith Miller wrote: >> >> I don’t know if this is possible but it would be great if some >> sub-directories could be excluded from the no-tabs pre-commit hook. > > Maybe we can rewrite the pre-commit hook

[webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Keith Miller
Hi all, I don’t know if this is possible but it would be great if some sub-directories could be excluded from the no-tabs pre-commit hook. For example, there are many test262 tests that contain tabs, either because they intentionally try to test parsing tab characters or because they were

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Darin Adler
> On May 10, 2019, at 1:00 PM, Keith Miller wrote: > > I don’t know if this is possible but it would be great if some > sub-directories could be excluded from the no-tabs pre-commit hook. Maybe we can rewrite the pre-commit hook to allow a whole-directory exception. Ideally I’d prefer not to