Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-02 Thread youenn fablet
Hi, Do you have any additional information on why the first patch failed? Can the problem be reproduced? Thanks Y Le 1 avr. 2015 21:43, "Brent Fulgham" a écrit : > Hi Everyone, > > We lost Windows EWS coverage for the past 36 hours due to a very > benign-appearing change to some webkitpy cod

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-02 Thread Osztrogonác Csaba
Hi, There are different issues here: - EWS bots don't run webkitpy tests, except the Mac WK1 and WK2. (running webkitpy tests is part of run tests) Maybe we should run webkitpy tests on the non tester EWS bots too. - poor webkitpy test coverage: Windows buildbots should have noticed the mentione

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-02 Thread Ryosuke Niwa
Right now, EWS restarts after every 20 iterations or so. We could expedite the process by doing it more frequently. However, I can't think of a way we can test a webkitpy patch that affects EWS on EWS since it's webkitpy code that's applying the patch and running the tests, etc… On Thu, Apr 2, 2

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-02 Thread Maciej Stachowiak
You said it did not detect the failure until many builds later. That seems bad. People expect EWS validation to happen on their bug, not out of band 10-13 builds later. Is there any way to fix this limitation? That seems better than asking people to remember exceptions about patches that EWS can

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Adam Barth
On Apr 1, 2015 9:29 PM, "Brent Fulgham" wrote: > > The Windows EWS bots process patches fairly quickly. Once I corrected the problem today, it managed to process about 97 patches in about an hour. > > I do think one bottleneck is due to individual EWS bots “locking” patches. The first bot to reach

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Brent Fulgham
The Windows EWS bots process patches fairly quickly. Once I corrected the problem today, it managed to process about 97 patches in about an hour. I do think one bottleneck is due to individual EWS bots “locking” patches. The first bot to reach a patch locks the patch against other bots handling

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Maciej Stachowiak
Is it possible to make EWS start processing changes more promptly? > On Apr 1, 2015, at 12:42 PM, Brent Fulgham wrote: > > Hi Everyone, > > We lost Windows EWS coverage for the past 36 hours due to a very > benign-appearing change to some webkitpy code. I haven’t yet figured out why > this p

[webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Brent Fulgham
Hi Everyone, We lost Windows EWS coverage for the past 36 hours due to a very benign-appearing change to some webkitpy code. I haven’t yet figured out why this particular set of changes caused the Windows bots to start failing, but it has to do with various differences between the Cygwin Python