Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-15 Thread Ryosuke Niwa
On Tuesday, October 15, 2013, Ryosuke Niwa wrote: At this point, I don't think we should proceed with the implementation given the number of concerns other WebKit contributors have raised. Let's bring this discussion back to WebApps WG or WHATWG instead of spamming webkit-dev. - R. Niwa

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-15 Thread Rik Cabanier
Could you briefly say what you would like to see addressed? On Tue, Oct 15, 2013 at 10:31 AM, Ryosuke Niwa ryosuke.n...@gmail.comwrote: At this point, I don't think we should proceed with the implementation given the number of concerns other WebKit contributors have raised. Let's bring

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Fri, Oct 11, 2013 at 12:14 AM, Chris Fleizach cfleiz...@apple.comwrote: Hi The naming of these methods also made it a bit confusing for me. It appears that drawCustomFocusRing just updates the accessibility rectangle -- while the system variant does that, and draws the normal focus

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Timothy Hatcher
On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Ryosuke Niwa
On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Ryosuke Niwa
Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Chris Fleizach
On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon,

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Mon, Oct 14, 2013 at 2:46 PM, Chris Fleizach cfleiz...@apple.com wrote: On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Ryosuke Niwa
On Mon, Oct 14, 2013 at 2:50 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon,

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Mon, Oct 14, 2013 at 2:58 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:50 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon,

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Timothy Hatcher
On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Rik Cabanier
On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-11 Thread Chris Fleizach
Hi The naming of these methods also made it a bit confusing for me. It appears that drawCustomFocusRing just updates the accessibility rectangle -- while the system variant does that, and draws the normal focus ring. In the former case, it doesn't really draw anything, it just allows an AT

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-11 Thread Mario Sanchez Prada
[...] It seems that for this to be useful for ATs, you'd have to iterate every object in your canvas and call at least drawCustomFocusRing once. Then when the item actually did become focused, you'd have to call drawSystemFocusRing.  I don't know what others think, but I think

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Wed, Oct 9, 2013 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote: I'd like to add for focus rings. They are currently specified in the w3c and whatwg canvas specs: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-drawsystemfocusring

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 1:14 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Oct 9, 2013 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote: I'd like to add for focus rings. They are currently specified in the w3c and whatwg canvas specs:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: Support (behind runtime flags) has landed in: - Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=540456 - chrome: https://code.google.com/p/chromium/issues/detail?id=261998 Focus rings associate elements that are

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 5:49 PM, Chris Fleizach cfleiz...@apple.com wrote: On Oct 10, 2013, at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 1:14 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Oct 9, 2013 at 9:08 PM, Rik Cabanier caban...@gmail.com wrote:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: Support (behind runtime flags) has landed in: - Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=540456 - chrome:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.com wrote: Support (behind runtime flags) has landed in: - Firefox:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
The spec. text is also misleading in saying that The drawSystemFocusRing(element) method, when invoked, must run the following steps: If I understood your reply correctly, these are steps that need to be ran continuously? Or is it that steps 2 3 must run upon the currently focused element

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 1:35 PM, Rik Cabanier caban...@gmail.comwrote:

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2013 at 7:09 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 6:08 PM, Ryosuke Niwa rn...@webkit.org wrote: On

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 7:07 PM, Ryosuke Niwa rn...@webkit.org wrote: The spec. text is also misleading in saying that The drawSystemFocusRing(element) method, when invoked, must run the following steps: If I understood your reply correctly, these are steps that need to be ran

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Rik Cabanier
On Thu, Oct 10, 2013 at 7:13 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 7:09 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 6:56 PM, Rik Cabanier caban...@gmail.comwrote: On Thu,

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2013 at 7:14 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:07 PM, Ryosuke Niwa rn...@webkit.org wrote: The spec. text is also misleading in saying that The drawSystemFocusRing(element) method, when invoked, must run the following steps: If I

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2013 at 7:21 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:19 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 7:14 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:07 PM, Ryosuke Niwa rn...@webkit.org wrote: The