Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-11 Thread Timothy Hatcher
> On Jul 9, 2016, at 3:22 PM, Sam Weinig wrote: > > It should probably get a parallel page to > https://webkit.org/code-style-guidelines/ > and be updated with the same type > of right / wrong examples. Yes, I agree it should be a

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-10 Thread Anthony Ricaud
It would be nice for contributors if those rules were enforced by a linter, like ESLint. > On 10 Jul 2016, at 00:22, Sam Weinig wrote: > >  > > It should probably get a parallel page to > https://webkit.org/code-style-guidelines/ and be updated with the same type > of

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-09 Thread Sam Weinig
 It should probably get a parallel page to https://webkit.org/code-style-guidelines/ and be updated with the same type of right / wrong examples. Our of curiosity, other than for features that simply aren’t available in C++ / Objective-C (or vice-versa), are there places where the

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-07 Thread manoj0011989
Sent from my HTC - Reply message - From: "Filip Pizlo" <fpi...@apple.com> To: "Ryosuke Niwa" <rn...@webkit.org> Cc: "WebKit-Dev Development" <webkit-dev@lists.webkit.org> Subject: [webkit-dev] Proposal: Adopt Web Inspector coding style for

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Filip Pizlo
I like the idea of adopting inspector style for JS builtins! It might also be good to adopt it for JS tests that we write ourselves, with an escape hatch if you need to violate style to test some feature. For example, it should be a goal to follow inspector style for the JetStream harness code,

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Ryosuke Niwa
On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson wrote: > I propose we make it official that the Web Inspector Coding Style is what > must be used for all JavaScript and CSS that count as source code in the > project. > https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide > >

[webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Dean Jackson
I propose we make it official that the Web Inspector Coding Style is what must be used for all JavaScript and CSS that count as source code in the project. https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide Now that JavaScript is used in more places (JS builtins, some parts of the DOM,